Reproducible build backports to jdk17u-dev ?

[Lindenmaier, Goetz]

Hi,

Do I understand correct that these changes
  * make the jdk17 build reproducible
  * allow others to have reproducible Java 17 builds

I think we should have this feature in 17.

The build changes are all acceptable.
The two changes to the jar/jmod are a bit more critical,
as they do affect the build outcome of other projects.
JDK-8276764 Enable deterministic file content ordering for Jar and Jmod
JDK-8276766 Enable jar and jmod to produce deterministic timestamped content
But potential performance effects have been well 
addressed in the original PR, and other differences 
should really be minimal.  

I would start out with the backport of the CSR for JDK-8276766.
Are you still waiting/hoping to get it into 18?

Best regards,
  Goetz.

PS: sorry for the scrambled URLs below, that is a done 
by SAPs mainling software.

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> Behalf Of Severin Gehwolf
> Sent: Tuesday, January 11, 2022 1:13 PM
> To: Andrew Leonard <anleonar at redhat.com>
> Cc: jdk-updates-dev at openjdk.java.net
> Subject: Re: Reproducible build backports to jdk17u-dev ?
> 
> On Tue, 2022-01-11 at 11:45 +0000, Andrew Leonard wrote:
> > Thanks Severin,
> > Good idea, here's the list I would propose backporting:
> > 8276743: Make openjdk build Zip Archive generation "reproducible" :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fopenjdk%2Fjdk%2Fpull%2F6311&data=04%7C01%7Cgoetz.lin
> denmaier%40sap.com%7C9f8d074b77c443c2ed1b08d9d4fbd0a2%7C42f7676c
> f455423c82f6dc2d99791af7%7C0%7C0%7C637775000270975682%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000&sdata=C0stoP85sDmXY7J8PxQijzvjohkq
> URamAERZj2W34Ik%3D&reserved=0
> > 8276764: Enable deterministic file content ordering for Jar and Jmod :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fopenjdk%2Fjdk%2Fpull%2F6395&data=04%7C01%7Cgoetz.lin
> denmaier%40sap.com%7C9f8d074b77c443c2ed1b08d9d4fbd0a2%7C42f7676c
> f455423c82f6dc2d99791af7%7C0%7C0%7C637775000270975682%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000&sdata=uCscTpwEwnDCNeak13al7N9yy
> NAwAbHBtxv6ebgou1k%3D&reserved=0
> > 8276766: Enable jar and jmod to produce deterministic timestamped
> content :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fopenjdk%2Fjdk%2Fpull%2F6481&data=04%7C01%7Cgoetz.lin
> denmaier%40sap.com%7C9f8d074b77c443c2ed1b08d9d4fbd0a2%7C42f7676c
> f455423c82f6dc2d99791af7%7C0%7C0%7C637775000270975682%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000&sdata=WPZf9DiZwrMs%2F4d3ZbzPI7z0
> f%2F99D5GsVjVLYzryavQ%3D&reserved=0
> > 8277762: Allow configuration of HOTSPOT_BUILD_USER :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fopenjdk%2Fjdk%2Fpull%2F6542&data=04%7C01%7Cgoetz.lin
> denmaier%40sap.com%7C9f8d074b77c443c2ed1b08d9d4fbd0a2%7C42f7676c
> f455423c82f6dc2d99791af7%7C0%7C0%7C637775000270975682%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000&sdata=IK46Bgd%2FNNilRnFGICSILL93ro
> QgK7UlIGc%2Bgsa1Fps%3D&reserved=0
> > 8278080: Add --with-cacerts-src='user cacerts folder' to enable
> deterministic cacerts generation :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fopenjdk%2Fjdk%2Fpull%2F6647&data=04%7C01%7Cgoetz.lin
> denmaier%40sap.com%7C9f8d074b77c443c2ed1b08d9d4fbd0a2%7C42f7676c
> f455423c82f6dc2d99791af7%7C0%7C0%7C637775000270975682%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000&sdata=z54Sb1u4vc3EoBbArjfIOSWAHQ
> YTa6dc9KnSAqda99o%3D&reserved=0
> > 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe
> setup :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fopenjdk%2Fjdk%2Fpull%2F6680&data=04%7C01%7Cgoetz.lin
> denmaier%40sap.com%7C9f8d074b77c443c2ed1b08d9d4fbd0a2%7C42f7676c
> f455423c82f6dc2d99791af7%7C0%7C0%7C637775000270975682%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000&sdata=vjA%2F6Ti%2FMEcAkSSVbP2Ah
> uH80JgtB97MQ0zhgdZBnzk%3D&reserved=0
> > 8278766: Enable OpenJDK build support for reproducible jars and jmods
> using --date :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fopenjdk%2Fjdk%2Fpull%2F6878&data=04%7C01%7Cgoetz.lin
> denmaier%40sap.com%7C9f8d074b77c443c2ed1b08d9d4fbd0a2%7C42f7676c
> f455423c82f6dc2d99791af7%7C0%7C0%7C637775000270975682%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000&sdata=zUucIe%2FLRlV0xNukKp64agrgd
> aGF%2FsT6dKck2Hlh8KQ%3D&reserved=0
> > 8279182: MakeZipReproducible ZipEntry timestamps not localized to UTC :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2Fopenjdk%2Fjdk%2Fpull%2F6926&data=04%7C01%7Cgoetz.lin
> denmaier%40sap.com%7C9f8d074b77c443c2ed1b08d9d4fbd0a2%7C42f7676c
> f455423c82f6dc2d99791af7%7C0%7C0%7C637775000271131898%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000&sdata=iqRomn7ZhaO6palQD8BvaGoJS4
> 1y8JcCe3d%2BprZf99s%3D&reserved=0
> >
> > So this essentially comes down to whether we see jdk-17.0.. being
> "reproducible" given it's an LTS it would seem sensible?
> 
> Thanks.
> 
> The above changes seem fine to me for JDK 17u.
> 
> Thanks,
> Severin