[jdk11u-dev] RFR: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror" [v2]

[Goetz Lindenmaier]

On Mon, 6 Dec 2021 14:48:48 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> This patch redoes JDK-8274338 backport to openjdk 11u.
>> 
>> Early backport failed and was backout. The failure was due to `CLD::loaded_classes_do()`, now requires to hold `MultiArray_lock`, therefore, the closure  `LinkSharedClassesClosure` can not trigger `JavaCall` while holding a lock.
>> 
>> [Revised]
>> Drop new assertion in `CLD::loaded_classes_do()`, only add `MultiArray_lock` to `InstanceKlass::restore_unshareable_info()`, which is the only thing matter in this patch.
>> 
>> Test:
>> - [x] hotspot_appcds 
>> - [x] tier1
>
> Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' into backport-8274338-redo
>  - revert some changes
>  - Fix leading whitespace
>  - release local refs
>  - keep CLD alive
>  - Backport 172aed1a2d75756b140cb723133ac5fb67f7745e

I ran the change through our nightly tests an do not see any failures.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/632