[jdk17u-dev] RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v2]
Goetz Lindenmaier
goetz at openjdk.java.net
Thu Jan 13 11:04:36 UTC 2022
On Wed, 12 Jan 2022 12:17:33 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:
>> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Backport db68a0ce1ce152345320e70acb7e9842d2f1ece4
>>
>> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> Also adds disablement of test/jdk/tools/jar/ReproducibleJar.java on 32bit platforms for https://bugs.openjdk.java.net/browse/JDK-8279453
Hi @andrew-m-leonard
next time, I would prefer two backports for seperate issues as JDK-8276766 and JDK-8279453.
You can use dependent Pull Request to stack changes if needed.
Add in the fix request comments that such changes need to be pushed at the same time.
I assume this would have saved you from looking for a reviewer.
Please also elaborate why the change is not clean when you make the Pull Request. This simplifies the task of reviewing.
Please only add the jfk17u-fix-request label once the change is reviewed.
Thanks,
Goetz.
-------------
PR: https://git.openjdk.java.net/jdk17u-dev/pull/82
More information about the jdk-updates-dev
mailing list