[jdk17u-dev] RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v3]

[Andrew Leonard]

On Wed, 12 Jan 2022 12:21:59 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

>> This backport (along with others in-progress) enables reproducible building of jar's and jmod's with the addition of a new --date <source date> option. Enabling reproducible timestamped jar & jmod content.
>> 
>> jdk-17.0.3 CSR: https://bugs.openjdk.java.net/browse/JDK-8279926
>
> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport db68a0ce1ce152345320e70acb7e9842d2f1ece4
>   
>   Signed-off-by: Andrew Leonard <anleonar at redhat.com>

Hi Goetz,
Thanks for the tips,  i'll follow this advice for the next ones.
Cheers
Andrew


On Thu, Jan 13, 2022 at 11:01 AM Goetz Lindenmaier ***@***.***>
wrote:

> Hi @andrew-m-leonard <https://github.com/andrew-m-leonard>
> next time, I would prefer two backports for seperate issues as JDK-8276766
> and JDK-8279453.
> You can use dependent Pull Request to stack changes if needed.
> Add in the fix request comments that such changes need to be pushed at the
> same time.
> I assume this would have saved you from looking for a reviewer.
> Please also elaborate why the change is not clean when you make the Pull
> Request. This simplifies the task of reviewing.
> Please only add the jfk17u-fix-request label once the change is reviewed.
> Thanks,
> Goetz.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jdk17u-dev/pull/82#issuecomment-1012028462>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHQDDNZQYGKLQBTWZMWOPZLUV2WIZANCNFSM5LYVYD3Q>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>

-------------

PR: https://git.openjdk.java.net/jdk17u-dev/pull/82