[jdk11u-dev] RFR: 8236210: javac generates wrong annotation for fields generated from record components [v2]

[Paul Hohensee]

On Thu, 20 Jan 2022 23:07:36 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> This is a backport of [JDK-8236210: javac generates wrong annotation for fields generated from record components](https://bugs.openjdk.java.net/browse/JDK-8236210)
>> 
>> This is a partial backport.
>> 
>> * The focus of JDK-8236210 was a bug with records and most of the diff was to logic that was added to deal with records. However the patch also included a fix to the logic for checking annotation applicability in `Check.annotationApplicable` that fixes a bug with annotations on `var`, so I backported the part that is relevant to Java 11.
>> * I added a test for the issue specific to `var`, since the original test is for records and cannot be backported.
>> 
>> Testing: x86 build, affected tests, tier1
>
> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix a compilation error with JDK 10

Lgtm again.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/771