[jdk17u-dev] RFR: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits [v3]

[aamarsh]

On Thu, 27 Jan 2022 16:55:25 GMT, aamarsh <duke at openjdk.java.net> wrote:

>> Makes colorBits and maskBits dynamic variables to force allocation on the heap instead of the stack and avoid a stackoverflow. Also adds a test to confirm this stackoverflow is no longer happening.
>> 
>> Tier1 and the newly added test passes on Windows. Clean backport.
>
> aamarsh has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains one commit:
> 
>   Backport 94127f43a4a28a89094fa93cd1da49763134f9db

Fix request 17u: This backport avoids a stack overflow in Windows 32 bit binaries, which some external contributors release. Additionally this is a nice change for Windows 64 bit binaries as well, even though the larger stack size has avoided the problem. The risk is low, simply placing two variables on the heap instead of the stack. Additionally, Tier1 and the newly added test passes on Windows after the changes.

-------------

PR: https://git.openjdk.java.net/jdk17u-dev/pull/98