[jdk11u-dev] RFR: 8261205: AssertionError: Cannot add metadata to an intersection type [v2]

[Liam Miller-Cushon]

> This is a backport of [JDK-8888888: AssertionError: Cannot add metadata to an intersection type](https://bugs.openjdk.java.net/browse/JDK-8261205)
> 
> Original patch does not apply cleanly to 11u
> 
> * I resolved a conflict where the loop in `JavacParser` that sets `declaredUsingVar = true;` was modified by JDK-8210742
> * I adjusted the changes to imports, the original patch removed an import of `com.sun.tools.javac.code.Attribute.Array` from `TypeAnnotations.java` that was still being used in 11
> * I removed the use of multi-line string literals in the test
>  
> Testing: x86_64 build, affected tests, tier1

Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  Backport 81f39ed3e0176b75dee1c8db24041545bcc68a86

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk11u-dev/pull/794/files
  - new: https://git.openjdk.java.net/jdk11u-dev/pull/794/files/d1be876e..f70fe836

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=794&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=794&range=00-01

  Stats: 323 lines in 13 files changed: 258 ins; 27 del; 38 mod
  Patch: https://git.openjdk.java.net/jdk11u-dev/pull/794.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/794/head:pull/794

PR: https://git.openjdk.java.net/jdk11u-dev/pull/794