[jdk11u-dev] RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads

Christoph Langer clanger at openjdk.org
Thu Jul 7 11:47:39 UTC 2022


On Thu, 7 Jul 2022 07:52:20 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> This is the backport of a small enhancement of the test library. The `TestScaffold` used in jdi tests is changed adding a new version of the overloaded method `resumeTo()` which takes an additional parameter `suspendThread`.
> 
> This part applies well.
> Other parts of the original commit 09e8675f568571d959d55b096c2cd3b033204e62 are not applicable (tested feature not in 11u).
> 
> Testing: jtreg:test/jdk:jdk_jdi

Hi @reinrich,
generally, the backport of the changes to TestScaffold are fine. However, I don't think it's a good idea to do this as a fully fledged backport of JDK-8255381. With that approach one could think that the fix to the EATests is already backported while in fact the test is not even there. I think the most pragmatic way would be to incorporate these changes into #1189, which seems to be the motivation of this backport. Alternatively, you could open a separate JBS bug for 11 to do the TestScaffold changes. But that's probably unnecessary overhead.

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1202


More information about the jdk-updates-dev mailing list