[jdk11u-dev] RFR: 8266461: tools/jmod/hashes/HashesTest.java fails: static @Test methods

[George Adams]

On Fri, 22 Jul 2022 09:24:55 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Backport required to bump JDK11u to jtreg 6
>> 
>> `test/jdk/tools/jmod/hashes/HashesTest.java`
>> - several occurrences of `ht.checkHashes("j2", Set.of("j3"));` (in jdk) not matching up with `ht.checkHashes("j2", "j3");` in jdk11u. I left the `checkHashes` function as it was simply removed the `ht.` to match the patch.
>> - [`testHashModulesPattern`](https://github.com/openjdk/jdk/commit/e90388bc1e7bba92675fa799d9da77aa4d6e1a05#diff-90d72039e87e2a26eb11bd8e15e499aa96eef5372361fb1a47eec0d5ab168f5aR322) does not exist in jdk11u so I removed it from the patch.
>
> I had the patch in our nightly build.  The test is still failing.

@GoeLin I've pushed up a commit to align the patch better with upstream but I'm still seeing one test failure:


test HashesTest.testReproducibibleHash(): failure
java.lang.AssertionError: Maps do not match for key:m2 actual:jdk.internal.module.ModuleHashes at 115b3f30 expected:jdk.internal.module.ModuleHashes at 405f34b
	at org.testng.Assert.fail(Assert.java:99)
	at org.testng.Assert.assertEquals(Assert.java:1458)
	at org.testng.Assert.assertEquals(Assert.java:1412)
	at HashesTest.testReproducibibleHash(HashesTest.java:297)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
	at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599)
	at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
	at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
	at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
	at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at org.testng.TestRunner.privateRun(TestRunner.java:764)
	at org.testng.TestRunner.run(TestRunner.java:585)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)
	at org.testng.SuiteRunner.run(SuiteRunner.java:286)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
	at org.testng.TestNG.runSuites(TestNG.java:1069)
	at org.testng.TestNG.run(TestNG.java:1037)
	at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:93)
	at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:53)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:125)
	at java.base/java.lang.Thread.run(Thread.java:829)


Any ideas?

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1252