[jdk11u-dev] RFR: 8266254: Update to use jtreg 6

[George Adams]

On Fri, 22 Jul 2022 12:22:49 GMT, George Adams <duke at openjdk.org> wrote:

>>> Hi, we still see the WebSocket tests failing. Did you test the patch with jtreg 6 in place? Things like this: test/jdk/java/net/httpclient/websocket/WebSocketProxyTest.java:155: error: ';' expected public boolean equals(Object o) {
>> 
>> Hi GoeLin,
>>  line 155 says:
>> 
>>     record bytes(byte[] bytes) {
>>         @Override
>>         public boolean equals(Object o) {
>>             if (this == o) return true;
>>             if (o instanceof bytes other) {
>>                 return Arrays.equals(bytes(), other.bytes());
>>             }
>>             return false;
>>         }
>>         @Override
>>         public int hashCode() { return Arrays.hashCode(bytes()); }
>>         public String toString() {
>>             return "0x" + HexFormat.of()
>>                     .withUpperCase()
>>                     .formatHex(bytes());
>>         }
>>     }
>> 
>> record was added with JDK14 I guess. We might have to adopt this to 11.
>
>> record was added with JDK14 I guess. We might have to adopt this to 11.
> 
> @ArnoZeller how many patches would be involved in this process?

> @gdams I do not mean to downport record - that would break the java spec. You just have to change the test coding to not use record.
I see that the backport is already pushed? Then the test has to be fixed, because this coding does not compile with JDK11.

Understood - I'll see what I can do

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1241