[jdk11u-dev] RFR: 8266461: tools/jmod/hashes/HashesTest.java fails: static @Test methods [v2]

George Adams duke at openjdk.org
Fri Jul 22 14:35:03 UTC 2022


On Fri, 22 Jul 2022 10:17:53 GMT, George Adams <duke at openjdk.org> wrote:

>> Backport required to bump JDK11u to jtreg 6
>> 
>> `test/jdk/tools/jmod/hashes/HashesTest.java`
>> - several occurrences of `ht.checkHashes("j2", Set.of("j3"));` (in jdk) not matching up with `ht.checkHashes("j2", "j3");` in jdk11u. I left the `checkHashes` function as it was simply removed the `ht.` to match the patch.
>> - [`testHashModulesPattern`](https://github.com/openjdk/jdk/commit/e90388bc1e7bba92675fa799d9da77aa4d6e1a05#diff-90d72039e87e2a26eb11bd8e15e499aa96eef5372361fb1a47eec0d5ab168f5aR322) does not exist in jdk11u so I removed it from the patch.
>
> George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport e90388bc1e7bba92675fa799d9da77aa4d6e1a05

Ignore my comments. Just tested with 11.0.16 and it works just fine:


➜  jdk11u-dev git:(hashes) ✗ java -version
openjdk version "11.0.16-beta" 2022-07-19
OpenJDK Runtime Environment Temurin-11.0.16+7-202207191813 (build 11.0.16-beta+7-202207191813)
OpenJDK 64-Bit Server VM Temurin-11.0.16+7-202207191813 (build 11.0.16-beta+7-202207191813, mixed mode)
➜  jdk11u-dev git:(hashes) ✗ jtreg test/jdk/tools/jmod/hashes/HashesTest.java                    
Test results: passed: 1
Report written to /Users/gadams/jdk11u-dev/JTreport/html/report.html
Results written to /Users/gadams/jdk11u-dev/JTwork

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1252


More information about the jdk-updates-dev mailing list