[jdk11u-dev] RFR: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows

[Goetz Lindenmaier]

On Tue, 26 Jul 2022 14:31:18 GMT, George Adams <duke at openjdk.org> wrote:

> depends on https://github.com/openjdk/jdk11u-dev/pull/1247. CC @GoeLin who requested this backport be raised in parallel.

Hi George, 
will this be clean if you backport it on top of 1247?
Are you aware of the possibility to have dependent pull requests? You can make a pull request on top of the branch of 1247.  This is the common way if you backport a change and a follow up fix.
Also, please only add jdk11u-fix-request if you have the change reviewed!
Further, you need to get the tests green here in the PR, or at least check them that the failure is unrelated. If you do so, note it down in a comment.
I will again remove the jdk11u-fix-request tags.
Have you ever read the instructions about making changes in 11/17?  https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix

Also, somewhere you state that the risk of the backport is low because the change applies clean.
That is not the kind of risk I consider when approving a backport.
The question is: might the change introduce an error that crashes the VM? Will it change the behaviour of the VM? Will it somehow require users to adapt something? E.g. the need to install a different vcruntime would be a risk. If users don't do so they will break their system when updating.

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1275