[jdk11u-dev] RFR: 8268185: Update GitHub Actions for jtreg 6 [v4]
George Adams
duke at openjdk.org
Thu Jul 28 11:24:48 UTC 2022
On Thu, 28 Jul 2022 09:17:51 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
>> George Adams has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
>>
>> Backport e27c4d463d920994b79b8163f063ad74f6ee5d59
>
> The backport is not clean because in
> .github/workflows/submit.yml
> The original calls 'sh', but jdk11u-dev calls 'bash'.
>
> Also, the context in make/conf/test-dependencies
> differs ( BOOT_JDK_VERSION=11 vs 16).
>
> But the change looks good.
>
> Please only use the /clean command if you
> understood why the change is not clean.
> Adaptions to Copyright, ProblemList and maybe
> some whitespace differences allow to
> use the command.
> Any resolves in code require a review, also
> such as the differences here.
>
> I'll mark it reviewed in case the tests
> complete green.
@GoeLin all tests pass
-------------
PR: https://git.openjdk.org/jdk11u-dev/pull/1239
More information about the jdk-updates-dev
mailing list