[jdk11u-dev] RFR: 8247907: XMLDsig logging does not work

Paul Hohensee phh at openjdk.java.net
Fri Jun 10 18:00:01 UTC 2022


On Wed, 8 Jun 2022 04:28:32 GMT, Joshua Cao <duke at openjdk.java.net> wrote:

> Not a clean backport, due to the following:
> * [these lines](https://github.com/openjdk/jdk11u-dev/blob/f700d37d2b3d8c23d50defc19853c68bb60027ab/src/java.xml.crypto/share/classes/com/sun/org/slf4j/internal/Logger.java#L80-L83) are not included in the original patch
> * Use HexDumpEncoder instead of HexPrinter, because HexPrinter does not exist in JDK11
> * Different copyright years
> 
> Changes pass the new jtreg test.

The copyright date maintainer policy as I understand it is to update the year to what is in the original commit if that's later than what's in the target file, not to the current year. So in this case, use 2020 rather than 2022.

Please document in this PR the use of "warn(String s, Object... o)" in 11 that doesn't exist in 16.

Otherwise lgtm.

-------------

Changes requested by phh (Reviewer).

PR: https://git.openjdk.org/jdk11u-dev/pull/1129


More information about the jdk-updates-dev mailing list