[jdk11u-dev] RFR: 8261160: Add a deserialization JFR event

Paul Hohensee phh at openjdk.org
Thu Jun 16 19:30:48 UTC 2022


On Wed, 15 Jun 2022 06:58:30 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this for parity with 11.0.17-oracle.
> 
> It needed a row of adaptions, but none touching the base functionality.
> 
> src/java.base/share/classes/java/io/ObjectInputStream.java
> Resolved an import. Trivial.
> 
> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java
> In this file some cleanup wrt alphabetic ordering was made that does 
> not apply to 11. (ProcessStartEvent not in 11.)
> 
> test/jdk/jdk/jfr/event/io/TestDeserializationEvent.java
> I adapted this test to Java 11 syntax.
> It used records and modern instanceof statements.
> Also, I included /test/lib/jdk/test/lib/serial/SerialObjectBuilder.java
> from "JDK-8254234: Add test library stream object builder".
> In that file, I also removed the record and replaced
> Class.descriptorString() by a local implementation. DescriptorString() was
> introduced in 12.  Backporting 8254234
> as prerequisite makes no sense as the adapted test is not 
> in 11, thus the backport would be quite incomplete.
> 
> test/jdk/jdk/jfr/event/metadata/TestDefaultConfigurations.java
> test/jdk/jdk/jfr/event/runtime/TestActiveSettingEvent.java
> Resolved due to context (ProcessStartEvent not in 11.)
> 
> test/lib/jdk/test/lib/jfr/EventNames.java
> Resolved due to context (DirectBufferStatistics not in 11.)

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk11u-dev/pull/1150


More information about the jdk-updates-dev mailing list