[jdk11u-dev] RFR: 8288763: [s390x] Pack200 extraction failure with invalid size

Lutz Schmidt lucy at openjdk.org
Wed Jun 29 09:17:54 UTC 2022


On Mon, 20 Jun 2022 23:03:33 GMT, Tyler Steele <tsteele at openjdk.org> wrote:

> While running some internal testing, a college has discovered a failure related to the Pack200 archive format on the zLinux platform. The problematic code was removed in the current repo by [JDK-8234596](https://bugs.openjdk.org/browse/JDK-8234596), however that change was large, and required a CSR. I feel that it would be too risky and cumbersome to backport those changes to jdk11 (and ultimately jdk8 as well), so I'd like to propose this change as a new change to jdk11 rather than via the usual backport process.
> 
> ### Testing
> These changes have been run against the failing test on zLinux and the Tier 1 tests completed successfully.

Changes look good to me. 

I would like to see a short comment, explaining why it is necessary to reset the compressed size. Looking at the class declaration, I see all members being preset with some value. Is the same instance (re)used multiple times?

Additional "issue": I'm not a Reviewer for the jdk-updates project. Someone else will need to jump in here, maybe @TheRealMDoerr

-------------

Changes requested by lucy (Committer).

PR: https://git.openjdk.org/jdk11u-dev/pull/1163


More information about the jdk-updates-dev mailing list