From goetz at openjdk.java.net Tue Mar 1 07:45:31 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 07:45:31 GMT Subject: [jdk11u-dev] RFR: 8211333: AArch64: Fix another build failure after JDK-8211029 Message-ID: I backport this to fix the build on windows aarch64. See also https://github.com/openjdk/jdk11u-dev/pull/841#issuecomment-1051610703 ------------- Commit messages: - Backport 21af2af13ecc7739b6e28b0a46896108570e564c Changes: https://git.openjdk.java.net/jdk11u-dev/pull/844/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=844&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8211333 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/844.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/844/head:pull/844 PR: https://git.openjdk.java.net/jdk11u-dev/pull/844 From goetz at openjdk.java.net Tue Mar 1 07:47:03 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 07:47:03 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: References: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> Message-ID: On Fri, 11 Feb 2022 08:32:57 GMT, Aleksey Shipilev wrote: >> Hi, I would appreciate a second review. Does anyone have an opinion on the aliases? >> @martinuy If I remember correctly you have made changes to the security files in the past. >> Could you have a look? Or @shipilev or @zhengyu123, would you find time? Thanks! > >> Hi, I would appreciate a second review. Does anyone have an opinion on the aliases? @martinuy If I remember correctly you have made changes to the security files in the past. Could you have a look? Or @shipilev or @zhengyu123, would you find time? Thanks! > > @martinuy is our security expert, please wait for him to reply :) Hi @shipilev, @TheRealMDoerr I would like to push this today before the start of rampdown. @martinuy did not react yet. What do you think, is this ok to go anyways? I think we should not miss it in 11.0.15. In case the aliases are not good, we can still make a follow up change. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From goetz at openjdk.java.net Tue Mar 1 08:06:19 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 08:06:19 GMT Subject: [jdk17u-dev] Withdrawn: 8276141: XPathFactory set/getProperty method In-Reply-To: References: Message-ID: On Wed, 16 Feb 2022 16:17:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/167 From mbaesken at openjdk.java.net Tue Mar 1 08:21:22 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 1 Mar 2022 08:21:22 GMT Subject: [jdk17u-dev] RFR: 8276141: XPathFactory set/getProperty method In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 13:36:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > > I adapted it as proposed in the backport CSR. Marked as reviewed by mbaesken (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/181 From itakiguchi at openjdk.java.net Tue Mar 1 08:58:12 2022 From: itakiguchi at openjdk.java.net (Ichiroh Takiguchi) Date: Tue, 1 Mar 2022 08:58:12 GMT Subject: [jdk17u-dev] Integrated: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 14:22:37 GMT, Ichiroh Takiguchi wrote: > Backport JDK-8282219 This pull request has now been integrated. Changeset: 6ce19ed5 Author: Ichiroh Takiguchi URL: https://git.openjdk.java.net/jdk17u-dev/commit/6ce19ed58591532d3cd8dcf68c3da30f4884eac5 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX Backport-of: c5c6058fd57d4b594012035eaf18a57257f4ad85 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/182 From itakiguchi at openjdk.java.net Tue Mar 1 09:01:20 2022 From: itakiguchi at openjdk.java.net (Ichiroh Takiguchi) Date: Tue, 1 Mar 2022 09:01:20 GMT Subject: [jdk17u-dev] RFR: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 14:22:37 GMT, Ichiroh Takiguchi wrote: > Backport JDK-8282219 jdk17u-fix-yes was added into [JDK-8282219](https://bugs.openjdk.java.net/browse/JDK-8282219) ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/182 From aph at openjdk.java.net Tue Mar 1 09:47:10 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Tue, 1 Mar 2022 09:47:10 GMT Subject: [jdk11u-dev] RFR: 8211333: AArch64: Fix another build failure after JDK-8211029 In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 07:38:29 GMT, Goetz Lindenmaier wrote: > I backport this to fix the build on windows aarch64. See also https://github.com/openjdk/jdk11u-dev/pull/841#issuecomment-1051610703 > > I had to do trivial resolves due to context. ahmedmuhsin did the same ones. Marked as reviewed by aph (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/844 From mdoerr at openjdk.java.net Tue Mar 1 10:16:10 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 1 Mar 2022 10:16:10 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> References: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> Message-ID: <8r7bhIMNkm7kJAafpXTqi6eRqcDRyGNOT4Ay--yBaLw=.b8e9a9db-068c-4907-944b-b4059ef1b01d@github.com> On Fri, 11 Feb 2022 07:15:07 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.15-oracle. >> >> I had to do a row of adaptions. There are some implementation >> differences, and many Java 17 usages that had to be changed. >> >> In the original change in SunPKCS11.java, dA() is used >> to give alias names of algorithms. It calls to >> SecurityProviderConstants.getAliases(). >> In SunPKCS11.java of jdk11 neither dA() nore getAliases() >> are available. It uses d() instead of da() and calls a >> s() with a list of literal strings to give the alias names. >> SecurityProviderConstants.java is in java.base. The jdk11 >> version does not contain the list of aliases that can be >> found in 17. >> >> I looked up whether there are aliases listed for >> "ChaCha20-Poly1305" in 17, but found none, so I added >> an empty call s() in SunPKCS11.java. >> >> In P11AEADCipher.java I had to modify the syntax of >> a switch statement. >> >> In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java >> I had to replace HexFormat.of().formatHex(...) >> which is a java.util class not in 11. >> >> The tests use HexFormat heavily. >> I replaced it by HexToBytes() from TestKATForGCM and >> by toHexString() from TestLeadingZeroesP11.java. >> To make these methods available I moved them to the >> superclass PKCS11Test.java. >> This way they can be used for potential later backports, too. >> I also had to adapt a switch statement using '->' to syntax >> know to 11. > > Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: > > - One more tiny detail > - These changes sneaked in from anonther backport I'd prefer to push it after updating the aliases. Some jdk11 code may use the "OID." prefix and the algorithm would not be found. I agree with that this backport should go into 11.0.15. Ideally before ramp down or alternatively as critical backport. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From pushkar.nk at in.ibm.com Tue Mar 1 10:26:19 2022 From: pushkar.nk at in.ibm.com (Pushkar N Kulkarni) Date: Tue, 1 Mar 2022 10:26:19 +0000 Subject: Fix backport request For JDK-8193682 Message-ID: <4AA9CAB4-D777-4119-A282-823FD8B9FC95@in.ibm.com> I am not sure if I am writing to the right mailing list. Pardon me if I am not. I want to request for a backport of https://github.com/openjdk/jdk/commit/1e9ed54d362b8c57be5fbbac2de5afbd0f05435f to the JDK8. If someone could help me with the process to raise backport requests, or point me to steps I could follow to help with the backport work, I?d appreciate it. I guess, git -> Hg backports are not as straightforward as the git->git ones? Thanks! - Pushkar From aph at openjdk.java.net Tue Mar 1 11:43:06 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Tue, 1 Mar 2022 11:43:06 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: <8r7bhIMNkm7kJAafpXTqi6eRqcDRyGNOT4Ay--yBaLw=.b8e9a9db-068c-4907-944b-b4059ef1b01d@github.com> References: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> <8r7bhIMNkm7kJAafpXTqi6eRqcDRyGNOT4Ay--yBaLw=.b8e9a9db-068c-4907-944b-b4059ef1b01d@github.com> Message-ID: On Tue, 1 Mar 2022 10:13:08 GMT, Martin Doerr wrote: > I'd prefer to push it after updating the aliases. Some jdk11 code may use the "OID." prefix and the algorithm would not be found. I agree with that this backport should go into 11.0.15. Ideally before ramp down or alternatively as critical backport. I agree too, but let's wait for a comment from Martin. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From mdoerr at openjdk.java.net Tue Mar 1 11:58:10 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 1 Mar 2022 11:58:10 GMT Subject: [jdk17u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response [v2] In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 06:28:54 GMT, Alexey Pavlyutkin wrote: >> This one is submitted in place of https://github.com/openjdk/jdk17u/pull/248 that was too late to jdk17u >> >> I'd like to backport JDK-8274471 to jdk17u-dev >> >> The patch fixes internal error upon verification of OCSP Response signed with RSASSA-PSS >> >> The original patch applied with minor changes to src/java.base/share/classes/sun/security/provider/certpath/OCSP.java >> >> - resolved baseline conflict: the original patch was done on top of JDK-8272120: Avoid looking for standard encodings in "java." modules and cannot be applied cleanly although it deletes the changes done against JDK-8272120 (see lines 249-241) >> - imported few required packages >> >> Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security > > Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: > > peer-review: removes the delta related to JDK-8272120 Thanks for the update! Good. I think it makes sense to accept it in 11u, too, after it is carefully reviewed and tested. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/36 From duke at openjdk.java.net Tue Mar 1 12:29:03 2022 From: duke at openjdk.java.net (zzambers) Date: Tue, 1 Mar 2022 12:29:03 GMT Subject: [jdk11u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 18:02:38 GMT, Paul Hohensee wrote: >> Tested locally passed tests in test/jdk/com/sun/jdi for me. > > I can sponsor this, but please check the pre-submit failures first. @phohensee I no longer need sponsor, but thank your for your offer. When it comes to failures: - on linux there were some hs/tier1 failures, but as this change only touched test class in jdk tests so I see no connection (also I have noticed same issue for other PRs created at similar time, e.g. [1]) - on windows it failed to unpack archive with jdk prior to testing (also don't see any possible connection to my change, seems like workflow or system/infrastructure problem) [1] https://github.com/openjdk/jdk11u-dev/pull/833 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/837 From phh at openjdk.java.net Tue Mar 1 13:48:23 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 1 Mar 2022 13:48:23 GMT Subject: [jdk17u-dev] RFR: 8276141: XPathFactory set/getProperty method In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 13:36:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > > I adapted it as proposed in the backport CSR. I missed the CSR note. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/181 From phh at openjdk.java.net Tue Mar 1 13:57:05 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 1 Mar 2022 13:57:05 GMT Subject: [jdk11u-dev] RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 00:13:55 GMT, zzambers wrote: > Tested locally passed tests in test/jdk/com/sun/jdi for me. Thanks for checking. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/837 From goetz at openjdk.java.net Tue Mar 1 14:06:00 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 14:06:00 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v4] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.15-oracle. > > I had to do a row of adaptions. There are some implementation > differences, and many Java 17 usages that had to be changed. > > In the original change in SunPKCS11.java, dA() is used > to give alias names of algorithms. It calls to > SecurityProviderConstants.getAliases(). > In SunPKCS11.java of jdk11 neither dA() nore getAliases() > are available. It uses d() instead of da() and calls a > s() with a list of literal strings to give the alias names. > SecurityProviderConstants.java is in java.base. The jdk11 > version does not contain the list of aliases that can be > found in 17. > > I looked up whether there are aliases listed for > "ChaCha20-Poly1305" in 17, but found none, so I added > an empty call s() in SunPKCS11.java. > > In P11AEADCipher.java I had to modify the syntax of > a switch statement. > > In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java > I had to replace HexFormat.of().formatHex(...) > which is a java.util class not in 11. > > The tests use HexFormat heavily. > I replaced it by HexToBytes() from TestKATForGCM and > by toHexString() from TestLeadingZeroesP11.java. > To make these methods available I moved them to the > superclass PKCS11Test.java. > This way they can be used for potential later backports, too. > I also had to adapt a switch statement using '->' to syntax > know to 11. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Update aliases, add OID, remove cases sensitive variant ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/805/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/805/files/7a7ba53d..e09f7bfd Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=805&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=805&range=02-03 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/805.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/805/head:pull/805 PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From goetz at openjdk.java.net Tue Mar 1 14:10:11 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 14:10:11 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: References: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> <8r7bhIMNkm7kJAafpXTqi6eRqcDRyGNOT4Ay--yBaLw=.b8e9a9db-068c-4907-944b-b4059ef1b01d@github.com> Message-ID: On Tue, 1 Mar 2022 11:40:22 GMT, Andrew Haley wrote: > I agree too, but let's wait for a comment from Martin. You mean Martin Balao, right? He didn't react for 18 days now. I'd rather have it pushed so that it reaches any downstream testing, than wait and do a critical push on last notice. I updated the aliases as recommended by Martin Doerr. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From mdoerr at openjdk.java.net Tue Mar 1 14:10:11 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 1 Mar 2022 14:10:11 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v4] In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 14:06:00 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.15-oracle. >> >> I had to do a row of adaptions. There are some implementation >> differences, and many Java 17 usages that had to be changed. >> >> In the original change in SunPKCS11.java, dA() is used >> to give alias names of algorithms. It calls to >> SecurityProviderConstants.getAliases(). >> In SunPKCS11.java of jdk11 neither dA() nore getAliases() >> are available. It uses d() instead of da() and calls a >> s() with a list of literal strings to give the alias names. >> SecurityProviderConstants.java is in java.base. The jdk11 >> version does not contain the list of aliases that can be >> found in 17. >> >> I looked up whether there are aliases listed for >> "ChaCha20-Poly1305" in 17, but found none, so I added >> an empty call s() in SunPKCS11.java. >> >> In P11AEADCipher.java I had to modify the syntax of >> a switch statement. >> >> In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java >> I had to replace HexFormat.of().formatHex(...) >> which is a java.util class not in 11. >> >> The tests use HexFormat heavily. >> I replaced it by HexToBytes() from TestKATForGCM and >> by toHexString() from TestLeadingZeroesP11.java. >> To make these methods available I moved them to the >> superclass PKCS11Test.java. >> This way they can be used for potential later backports, too. >> I also had to adapt a switch statement using '->' to syntax >> know to 11. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Update aliases, add OID, remove cases sensitive variant Thanks for the update. Good to go IMHO. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From goetz at openjdk.java.net Tue Mar 1 14:32:25 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 14:32:25 GMT Subject: [jdk17u-dev] RFR: 8276141: XPathFactory set/getProperty method In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 13:36:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > > I adapted it as proposed in the backport CSR. The failing pre submit tests are timeouts of tests. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/181 From aph at openjdk.java.net Tue Mar 1 14:46:00 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Tue, 1 Mar 2022 14:46:00 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: References: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> <8r7bhIMNkm7kJAafpXTqi6eRqcDRyGNOT4Ay--yBaLw=.b8e9a9db-068c-4907-944b-b4059ef1b01d@github.com> Message-ID: <_bo_0rKjA721AOG3YpklGvtKdsmnqj1gArCLbH9YWnk=.e1ba10a2-1b70-46d3-8a0b-3b19e9f7a57a@github.com> On Tue, 1 Mar 2022 14:05:18 GMT, Goetz Lindenmaier wrote: > > I agree too, but let's wait for a comment from Martin. > > You mean Martin Balao, right? He didn't react for 18 days now. I'm sure he never saw it. He's working on it at the moment. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From mbalao at openjdk.java.net Tue Mar 1 14:57:12 2022 From: mbalao at openjdk.java.net (Martin Balao) Date: Tue, 1 Mar 2022 14:57:12 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v4] In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 14:06:00 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.15-oracle. >> >> I had to do a row of adaptions. There are some implementation >> differences, and many Java 17 usages that had to be changed. >> >> In the original change in SunPKCS11.java, dA() is used >> to give alias names of algorithms. It calls to >> SecurityProviderConstants.getAliases(). >> In SunPKCS11.java of jdk11 neither dA() nore getAliases() >> are available. It uses d() instead of da() and calls a >> s() with a list of literal strings to give the alias names. >> SecurityProviderConstants.java is in java.base. The jdk11 >> version does not contain the list of aliases that can be >> found in 17. >> >> I looked up whether there are aliases listed for >> "ChaCha20-Poly1305" in 17, but found none, so I added >> an empty call s() in SunPKCS11.java. >> >> In P11AEADCipher.java I had to modify the syntax of >> a switch statement. >> >> In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java >> I had to replace HexFormat.of().formatHex(...) >> which is a java.util class not in 11. >> >> The tests use HexFormat heavily. >> I replaced it by HexToBytes() from TestKATForGCM and >> by toHexString() from TestLeadingZeroesP11.java. >> To make these methods available I moved them to the >> superclass PKCS11Test.java. >> This way they can be used for potential later backports, too. >> I also had to adapt a switch statement using '->' to syntax >> know to 11. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Update aliases, add OID, remove cases sensitive variant Hi all, I'm reviewing the backport now and will provide my comments today. Martin.- ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From goetz at openjdk.java.net Tue Mar 1 14:57:13 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 14:57:13 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: <_bo_0rKjA721AOG3YpklGvtKdsmnqj1gArCLbH9YWnk=.e1ba10a2-1b70-46d3-8a0b-3b19e9f7a57a@github.com> References: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> <8r7bhIMNkm7kJAafpXTqi6eRqcDRyGNOT4Ay--yBaLw=.b8e9a9db-068c-4907-944b-b4059ef1b01d@github.com> <_bo_0rKjA721AOG3YpklGvtKdsmnqj1gArCLbH9YWnk=.e1ba10a2-1b70-46d3-8a0b-3b19e9f7a57a@github.com> Message-ID: On Tue, 1 Mar 2022 14:43:16 GMT, Andrew Haley wrote: > I'm sure he never saw it. He's working on it at the moment. Great, thank you! Reaching out to somebody is a bit problematic since github: Too many channels (PR, JBS, Mail), and too many mail notifications. I missed things, too. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From duke at openjdk.java.net Tue Mar 1 15:14:19 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Tue, 1 Mar 2022 15:14:19 GMT Subject: [jdk17u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response [v2] In-Reply-To: References: Message-ID: <9cUJV-Z8d44yLE4uOq9xkrx4JGT6LtxF6VJJQ2BtxA0=.7dee8fcf-7cde-44db-9e41-4854371ed758@github.com> On Tue, 1 Mar 2022 11:54:32 GMT, Martin Doerr wrote: > Thanks for the update! Good. I think it makes sense to accept it in 11u, too, after it is carefully reviewed and tested. Thank you. I've already completed backports to 11 (very dirty) & 8 (just a bit unclean). They are postponed @GoeLin how can I get "ready" label back? Thank you ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/36 From duke at openjdk.java.net Tue Mar 1 15:19:32 2022 From: duke at openjdk.java.net (zzambers) Date: Tue, 1 Mar 2022 15:19:32 GMT Subject: [jdk11u-dev] RFR: 8206330: Revisit com/sun/jdi/RedefineCrossEvent.java Message-ID: This test can now be enabled. Tested locally, com/sun/jdi/RedefineCrossEvent.java as well as all other tests in test/jdk/com/sun/jdi pass for me with this backport. Unlike original changeset this backport does not touch test/jdk/com/sun/jdi/TestScaffold.java since condition there was wrong and was properly reworked in JDK-8279669 [1] (backported to jdk11u-dev). [1] https://bugs.openjdk.java.net/browse/JDK-8279669 ------------- Commit messages: - Backport 426873751c710061d0f9bc713a0de47373e51418 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/845/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=845&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8206330 Stats: 12 lines in 2 files changed: 0 ins; 11 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/845.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/845/head:pull/845 PR: https://git.openjdk.java.net/jdk11u-dev/pull/845 From goetz at openjdk.java.net Tue Mar 1 15:51:25 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 15:51:25 GMT Subject: [jdk17u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response [v2] In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 06:28:54 GMT, Alexey Pavlyutkin wrote: >> This one is submitted in place of https://github.com/openjdk/jdk17u/pull/248 that was too late to jdk17u >> >> I'd like to backport JDK-8274471 to jdk17u-dev >> >> The patch fixes internal error upon verification of OCSP Response signed with RSASSA-PSS >> >> The original patch applied with minor changes to src/java.base/share/classes/sun/security/provider/certpath/OCSP.java >> >> - resolved baseline conflict: the original patch was done on top of JDK-8272120: Avoid looking for standard encodings in "java." modules and cannot be applied cleanly although it deletes the changes done against JDK-8272120 (see lines 249-241) >> - imported few required packages >> >> Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security > > Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: > > peer-review: removes the delta related to JDK-8272120 Formal requirements are all met now. LGTM Please enable github actions, also in the other repos where you might backport to. ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/36 From duke at openjdk.java.net Tue Mar 1 16:12:25 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Tue, 1 Mar 2022 16:12:25 GMT Subject: [jdk17u-dev] Integrated: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: References: Message-ID: On Fri, 24 Dec 2021 17:23:26 GMT, Alexey Pavlyutkin wrote: > This one is submitted in place of https://github.com/openjdk/jdk17u/pull/248 that was too late to jdk17u > > I'd like to backport JDK-8274471 to jdk17u-dev > > The patch fixes internal error upon verification of OCSP Response signed with RSASSA-PSS > > The original patch applied with minor changes to src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > > - resolved baseline conflict: the original patch was done on top of JDK-8272120: Avoid looking for standard encodings in "java." modules and cannot be applied cleanly although it deletes the changes done against JDK-8272120 (see lines 249-241) > - imported few required packages > > Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security This pull request has now been integrated. Changeset: 8e13d2f3 Author: Alexey Pavlyutkin Committer: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/8e13d2f3e79b0595b97300ac7090b50be6d295b6 Stats: 111 lines in 9 files changed: 26 ins; 45 del; 40 mod 8274471: Add support for RSASSA-PSS in OCSP Response Reviewed-by: mdoerr, goetz Backport-of: f63c4a832a1aea451f47aaf86d5361e970c6a28f ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/36 From mbalao at openjdk.java.net Tue Mar 1 16:14:11 2022 From: mbalao at openjdk.java.net (Martin Balao) Date: Tue, 1 Mar 2022 16:14:11 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3] In-Reply-To: References: <20qpYXvg0VDS2Em9wFpZ5pyeEKA_E1OWZjPzygaYqRQ=.f40030b3-4d28-4bf4-bed9-5b4e76d3aafb@github.com> <8r7bhIMNkm7kJAafpXTqi6eRqcDRyGNOT4Ay--yBaLw=.b8e9a9db-068c-4907-944b-b4059ef1b01d@github.com> <_bo_0rKjA721AOG3YpklGvtKdsmnqj1gArCLbH9YWnk=.e1ba10a2-1b70-46d3-8a0b-3b19e9f7a57a@github.com> Message-ID: On Tue, 1 Mar 2022 14:54:11 GMT, Goetz Lindenmaier wrote: >>> > I agree too, but let's wait for a comment from Martin. >>> >>> You mean Martin Balao, right? He didn't react for 18 days now. >> >> I'm sure he never saw it. He's working on it at the moment. > >> I'm sure he never saw it. He's working on it at the moment. > > Great, thank you! > Reaching out to somebody is a bit problematic since github: Too many channels (PR, JBS, Mail), and too many mail notifications. I missed things, too. Hi @GoeLin, Thanks for proposing this backports. Looks good to me and I agree with all the previous review comments and fixes. One minor thing: it looks to me that HexToBytes does not exactly reflect HexFormat::parseHex behavior when it comes to handling null strings. While HexFormat::parseHex requires a non-null value (or throws a NPE) [1], HexToBytes will return an array of length 0. Returning an array of length 0, for HexFormat::parseHex, is reserved for the case in which the string is empty (non-null) only. There might be some performance differences too. Given that this is only used for tests, I believe that no changes are needed to the current PR. Something I was thinking is that HexFormat looks pretty self-contained so I wondered if it is worth moving it to an internal package of java.base (which could be for example jdk.internal.util) and exporting it to modules (such as jdk.crypto.cryptoki) on demand as backports use it. This would allow to use it even beyond SunPKCS11 in the future. Martin.- -- [1] - https://github.com/openjdk/jdk/blob/jdk-19+11/src/java.base/share/classes/java/util/HexFormat.java#L527 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From goetz at openjdk.java.net Tue Mar 1 16:15:05 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 16:15:05 GMT Subject: [jdk11u-dev] RFR: 8211333: AArch64: Fix another build failure after JDK-8211029 In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 07:38:29 GMT, Goetz Lindenmaier wrote: > I backport this to fix the build on windows aarch64. See also https://github.com/openjdk/jdk11u-dev/pull/841#issuecomment-1051610703 > > I had to do trivial resolves due to context. ahmedmuhsin did the same ones. Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/844 From goetz at openjdk.java.net Tue Mar 1 16:15:05 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 16:15:05 GMT Subject: [jdk11u-dev] Integrated: 8211333: AArch64: Fix another build failure after JDK-8211029 In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 07:38:29 GMT, Goetz Lindenmaier wrote: > I backport this to fix the build on windows aarch64. See also https://github.com/openjdk/jdk11u-dev/pull/841#issuecomment-1051610703 > > I had to do trivial resolves due to context. ahmedmuhsin did the same ones. This pull request has now been integrated. Changeset: c0effc24 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/c0effc24b7c68834a804dd1494a658e674494f11 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8211333: AArch64: Fix another build failure after JDK-8211029 Reviewed-by: aph Backport-of: 21af2af13ecc7739b6e28b0a46896108570e564c ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/844 From goetz at openjdk.java.net Tue Mar 1 16:16:17 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 16:16:17 GMT Subject: [jdk17u-dev] Integrated: 8276141: XPathFactory set/getProperty method In-Reply-To: References: Message-ID: <6Y9msZfA4nhk9kX9S1qA_PsxnfzPQkffEPbGGCtDSPI=.b6bd1656-794f-463d-827c-51dbc6500c98@github.com> On Mon, 28 Feb 2022 13:36:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > > I adapted it as proposed in the backport CSR. This pull request has now been integrated. Changeset: 51e7af2e Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/51e7af2e222edeb76792b8660b1139ffe013d8e1 Stats: 59 lines in 2 files changed: 56 ins; 0 del; 3 mod 8276141: XPathFactory set/getProperty method Reviewed-by: mbaesken, phh Backport-of: b226ab99c872e791d3ed9fca015cf92847904c34 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/181 From goetz at openjdk.java.net Tue Mar 1 16:20:15 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 16:20:15 GMT Subject: [jdk17u-dev] Integrated: 8277795: ldap connection timeout not honoured under contention In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 09:18:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. This pull request has now been integrated. Changeset: 47f29a34 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/47f29a346cdd11727afd0d6f866970505f165494 Stats: 467 lines in 5 files changed: 324 ins; 72 del; 71 mod 8277795: ldap connection timeout not honoured under contention Backport-of: 3d926dd66ef6551e91a4ebbbc59dcff58f5ede5a ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/180 From goetz at openjdk.java.net Tue Mar 1 16:31:07 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 16:31:07 GMT Subject: [jdk11u-dev] Withdrawn: 8276141: XPathFactory set/getProperty method In-Reply-To: References: Message-ID: <7sQGHx_MkJJGbP_0W9LmTLs7Xqhw-d6D7bmCwjjnDq8=.69b0f3d7-8efc-4f07-8916-411925d084f0@github.com> On Wed, 16 Feb 2022 16:06:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. > > I had to do two straight forward fixes: > XPathFactoryImpl Tag @LastModified is adapted in head but does not exist in 11. > XPathTest.java A larger hunk did not apply. Simple to patch by hand. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/828 From goetz at openjdk.java.net Tue Mar 1 16:56:45 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 16:56:45 GMT Subject: [jdk17u-dev] RFR: 8282499: Bump update version for OpenJDK: jdk-17.0.4 Message-ID: <4KUD5D02qYsOLS0VCTP8p51QBPbjRCFNAhH6W4Rr6r0=.9c8e71a9-9bb6-4367-aa1c-74a821905832@github.com> The necessary increment of the update version. ------------- Commit messages: - 8282499: Bump update version for OpenJDK: jdk-17.0.4 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/184/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=184&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282499 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/184.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/184/head:pull/184 PR: https://git.openjdk.java.net/jdk17u-dev/pull/184 From goetz at openjdk.java.net Tue Mar 1 17:01:09 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 17:01:09 GMT Subject: [jdk11u-dev] RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v4] In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 14:06:00 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.15-oracle. >> >> I had to do a row of adaptions. There are some implementation >> differences, and many Java 17 usages that had to be changed. >> >> In the original change in SunPKCS11.java, dA() is used >> to give alias names of algorithms. It calls to >> SecurityProviderConstants.getAliases(). >> In SunPKCS11.java of jdk11 neither dA() nore getAliases() >> are available. It uses d() instead of da() and calls a >> s() with a list of literal strings to give the alias names. >> SecurityProviderConstants.java is in java.base. The jdk11 >> version does not contain the list of aliases that can be >> found in 17. >> >> I looked up whether there are aliases listed for >> "ChaCha20-Poly1305" in 17, but found none, so I added >> an empty call s() in SunPKCS11.java. >> >> In P11AEADCipher.java I had to modify the syntax of >> a switch statement. >> >> In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java >> I had to replace HexFormat.of().formatHex(...) >> which is a java.util class not in 11. >> >> The tests use HexFormat heavily. >> I replaced it by HexToBytes() from TestKATForGCM and >> by toHexString() from TestLeadingZeroesP11.java. >> To make these methods available I moved them to the >> superclass PKCS11Test.java. >> This way they can be used for potential later backports, too. >> I also had to adapt a switch statement using '->' to syntax >> know to 11. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Update aliases, add OID, remove cases sensitive variant Thanks Martin for looking at this so ad-hoc! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From goetz at openjdk.java.net Tue Mar 1 17:01:10 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 17:01:10 GMT Subject: [jdk11u-dev] Integrated: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider In-Reply-To: References: Message-ID: On Thu, 3 Feb 2022 19:33:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. > > I had to do a row of adaptions. There are some implementation > differences, and many Java 17 usages that had to be changed. > > In the original change in SunPKCS11.java, dA() is used > to give alias names of algorithms. It calls to > SecurityProviderConstants.getAliases(). > In SunPKCS11.java of jdk11 neither dA() nore getAliases() > are available. It uses d() instead of da() and calls a > s() with a list of literal strings to give the alias names. > SecurityProviderConstants.java is in java.base. The jdk11 > version does not contain the list of aliases that can be > found in 17. > > I looked up whether there are aliases listed for > "ChaCha20-Poly1305" in 17, but found none, so I added > an empty call s() in SunPKCS11.java. > > In P11AEADCipher.java I had to modify the syntax of > a switch statement. > > In CK_SALSA20_CHACHA20_POLY1305_PARAMS.java > I had to replace HexFormat.of().formatHex(...) > which is a java.util class not in 11. > > The tests use HexFormat heavily. > I replaced it by HexToBytes() from TestKATForGCM and > by toHexString() from TestLeadingZeroesP11.java. > To make these methods available I moved them to the > superclass PKCS11Test.java. > This way they can be used for potential later backports, too. > I also had to adapt a switch statement using '->' to syntax > know to 11. This pull request has now been integrated. Changeset: 5cad68f5 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/5cad68f586b1d75403ba7339828221ff6f167c53 Stats: 1683 lines in 18 files changed: 1526 ins; 75 del; 82 mod 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider Reviewed-by: mdoerr Backport-of: 5d8c1cc8a05e0d9aedd6d54b8147d374c2290024 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/805 From goetz at openjdk.java.net Tue Mar 1 17:11:32 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 1 Mar 2022 17:11:32 GMT Subject: [jdk11u-dev] RFR: 8282501: Bump update version for OpenJDK: jdk-11.0.16 Message-ID: The necessary increment of the update version. ------------- Commit messages: - 8282501: Bump update version for OpenJDK: jdk-11.0.16 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/846/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=846&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282501 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/846.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/846/head:pull/846 PR: https://git.openjdk.java.net/jdk11u-dev/pull/846 From duke at openjdk.java.net Tue Mar 1 18:15:15 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Tue, 1 Mar 2022 18:15:15 GMT Subject: [jdk11u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: <5dcsrr9VvWF81CTqEue6tOrY5UDigY2l1IHXLE8xgAA=.ebd03557-52ca-4d8f-b932-dc8cfca43b0c@github.com> References: <5dcsrr9VvWF81CTqEue6tOrY5UDigY2l1IHXLE8xgAA=.ebd03557-52ca-4d8f-b932-dc8cfca43b0c@github.com> Message-ID: On Sat, 22 Jan 2022 09:13:30 GMT, Alexey Pavlyutkin wrote: > I'd like to backport > > 8274471: Add support for RSASSA-PSS in OCSP Response > 8179503: Java should support GET OCSP calls (dependency) > > to jdk11u-dev. > > The patches fix internal error upon verification of OCSP Response signed with RSASSA-PSS. > > The following changes were done to original patches: > > 8179503: > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > - resolved baseline conflict that took place due to absent revocation checking code > > test/jdk/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java > - unsupported `ObjectIdentifier.of()` substituted with `new ObjectIdentifier` > > 8274471: > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > - changes to absent revokation checking code ignored > > src/java.base/share/classes/sun/security/util/SignatureUtil.java > - the following non-existing methods transferred from jdk17: > `public static Signature fromKey(String sigAlg, PrivateKey key, String provider);` > `public static Signature fromKey(String sigAlg, PrivateKey key, Provider provider);` > `private static Signature autoInitInternal(String alg, PrivateKey key, Signature s);` > `public static AlgorithmId fromSignature(Signature sigEngine, PrivateKey key);` > - `EdEcKey` (unsupported in jdk11) hook removed from fromSignature() method > - copied `SignatureUtil.autoInitInternal()` method updated to use `AlgorithmId.getDefaultAlgorithmParameterSpec()` instead of `SignatureUtil.getDefaultParamSpec()` > - imported AlgorithmId class > > test/jdk/java/security/testlibrary/SimpleOCSPServer.java > - imported SignatureUtil class > > Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security @TheRealMDoerr @alexeybakhtin Gentlemen, if you find time for this one, you will greatly oblige me. Thank you ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/788 From mdoerr at openjdk.java.net Tue Mar 1 21:01:08 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 1 Mar 2022 21:01:08 GMT Subject: [jdk17u-dev] RFR: 8282499: Bump update version for OpenJDK: jdk-17.0.4 In-Reply-To: <4KUD5D02qYsOLS0VCTP8p51QBPbjRCFNAhH6W4Rr6r0=.9c8e71a9-9bb6-4367-aa1c-74a821905832@github.com> References: <4KUD5D02qYsOLS0VCTP8p51QBPbjRCFNAhH6W4Rr6r0=.9c8e71a9-9bb6-4367-aa1c-74a821905832@github.com> Message-ID: On Tue, 1 Mar 2022 16:48:20 GMT, Goetz Lindenmaier wrote: > The necessary increment of the update version. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/184 From mdoerr at openjdk.java.net Tue Mar 1 21:02:04 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 1 Mar 2022 21:02:04 GMT Subject: [jdk11u-dev] RFR: 8282501: Bump update version for OpenJDK: jdk-11.0.16 In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 17:06:37 GMT, Goetz Lindenmaier wrote: > The necessary increment of the update version. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/846 From mdoerr at openjdk.java.net Tue Mar 1 22:24:02 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 1 Mar 2022 22:24:02 GMT Subject: [jdk11u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: <5dcsrr9VvWF81CTqEue6tOrY5UDigY2l1IHXLE8xgAA=.ebd03557-52ca-4d8f-b932-dc8cfca43b0c@github.com> References: <5dcsrr9VvWF81CTqEue6tOrY5UDigY2l1IHXLE8xgAA=.ebd03557-52ca-4d8f-b932-dc8cfca43b0c@github.com> Message-ID: On Sat, 22 Jan 2022 09:13:30 GMT, Alexey Pavlyutkin wrote: > I'd like to backport > > 8274471: Add support for RSASSA-PSS in OCSP Response > 8179503: Java should support GET OCSP calls (dependency) > > to jdk11u-dev. > > The patches fix internal error upon verification of OCSP Response signed with RSASSA-PSS. > > The following changes were done to original patches: > > 8179503: > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > - resolved baseline conflict that took place due to absent revocation checking code > > test/jdk/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java > - unsupported `ObjectIdentifier.of()` substituted with `new ObjectIdentifier` > > 8274471: > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > - changes to absent revokation checking code ignored > > src/java.base/share/classes/sun/security/util/SignatureUtil.java > - the following non-existing methods transferred from jdk17: > `public static Signature fromKey(String sigAlg, PrivateKey key, String provider);` > `public static Signature fromKey(String sigAlg, PrivateKey key, Provider provider);` > `private static Signature autoInitInternal(String alg, PrivateKey key, Signature s);` > `public static AlgorithmId fromSignature(Signature sigEngine, PrivateKey key);` > - `EdEcKey` (unsupported in jdk11) hook removed from fromSignature() method > - copied `SignatureUtil.autoInitInternal()` method updated to use `AlgorithmId.getDefaultAlgorithmParameterSpec()` instead of `SignatureUtil.getDefaultParamSpec()` > - imported AlgorithmId class > > test/jdk/java/security/testlibrary/SimpleOCSPServer.java > - imported SignatureUtil class > > Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security Would it be possible to backport both changes individually (i.e. JDK-8179503 first and JDK-8274471 as dependent PR)? That would make it easier to review and keep the integration history clean. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/788 From goetz at openjdk.java.net Wed Mar 2 07:28:11 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 2 Mar 2022 07:28:11 GMT Subject: [jdk11u-dev] Integrated: 8282501: Bump update version for OpenJDK: jdk-11.0.16 In-Reply-To: References: Message-ID: <1DXLt8VoN8bz_zGTLW7g5DjEqP2aR999HdWToeIr4tw=.7fc6935b-3a46-4f4f-9566-bdaf6fd8147b@github.com> On Tue, 1 Mar 2022 17:06:37 GMT, Goetz Lindenmaier wrote: > The necessary increment of the update version. This pull request has now been integrated. Changeset: 16d98b35 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/16d98b354cbcba2cd494af30d0220e15692e8d6d Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8282501: Bump update version for OpenJDK: jdk-11.0.16 Reviewed-by: mdoerr ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/846 From goetz at openjdk.java.net Wed Mar 2 08:06:20 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 2 Mar 2022 08:06:20 GMT Subject: [jdk17u-dev] Integrated: 8282499: Bump update version for OpenJDK: jdk-17.0.4 In-Reply-To: <4KUD5D02qYsOLS0VCTP8p51QBPbjRCFNAhH6W4Rr6r0=.9c8e71a9-9bb6-4367-aa1c-74a821905832@github.com> References: <4KUD5D02qYsOLS0VCTP8p51QBPbjRCFNAhH6W4Rr6r0=.9c8e71a9-9bb6-4367-aa1c-74a821905832@github.com> Message-ID: On Tue, 1 Mar 2022 16:48:20 GMT, Goetz Lindenmaier wrote: > The necessary increment of the update version. This pull request has now been integrated. Changeset: 02a876f0 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/02a876f0e7cdf7ace8cbf304aa35b725f0075800 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8282499: Bump update version for OpenJDK: jdk-17.0.4 Reviewed-by: mdoerr ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/184 From duke at openjdk.java.net Wed Mar 2 12:02:30 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Wed, 2 Mar 2022 12:02:30 GMT Subject: [jdk11u-dev] RFR: 8179503: Java should support GET OCSP calls Message-ID: Hello! I'd like to backport 8179503: Java should support GET OCSP calls (dependency) to jdk11u-dev. This one is required as a dependency for 8274471: Add support for RSASSA-PSS in OCSP Response The following changes were done to apply original patch: src/java.base/share/classes/sun/security/provider/certpath/OCSP.java - resolved baseline conflict taking due to absent revocation checking code Verification/regression (20.04/amd64): jdk_security ------------- Commit messages: - removes trailing whitespaces - Backport f5ee356540d7aa4a7663c0d5d74f5fdb0726b426 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/847/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=847&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8179503 Stats: 370 lines in 3 files changed: 316 ins; 38 del; 16 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/847.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/847/head:pull/847 PR: https://git.openjdk.java.net/jdk11u-dev/pull/847 From duke at openjdk.java.net Wed Mar 2 12:06:12 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Wed, 2 Mar 2022 12:06:12 GMT Subject: [jdk11u-dev] RFR: 8179503: Java should support GET OCSP calls In-Reply-To: References: Message-ID: On Wed, 2 Mar 2022 11:47:30 GMT, Alexey Pavlyutkin wrote: > Hello! I'd like to backport > > 8179503: Java should support GET OCSP calls (dependency) > > to jdk11u-dev. This one is required as a dependency for > > 8274471: Add support for RSASSA-PSS in OCSP Response > > The following changes were done to apply original patch: > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > > - resolved baseline conflict taking due to absent revocation checking code > > Verification/regression (20.04/amd64): jdk_security @TheRealMDoerr @alexeybakhtin I splitted https://github.com/openjdk/jdk11u-dev/pull/788, this is the 1st part for 8179503 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/847 From duke at openjdk.java.net Wed Mar 2 12:07:05 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Wed, 2 Mar 2022 12:07:05 GMT Subject: [jdk11u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: <5dcsrr9VvWF81CTqEue6tOrY5UDigY2l1IHXLE8xgAA=.ebd03557-52ca-4d8f-b932-dc8cfca43b0c@github.com> References: <5dcsrr9VvWF81CTqEue6tOrY5UDigY2l1IHXLE8xgAA=.ebd03557-52ca-4d8f-b932-dc8cfca43b0c@github.com> Message-ID: <_VL421oA4D1q6oIravwKPshM0d4tECFkMbKF8BqowcM=.55c0cfb8-9370-4e8e-b6a4-5bac21908001@github.com> On Sat, 22 Jan 2022 09:13:30 GMT, Alexey Pavlyutkin wrote: > I'd like to backport > > 8274471: Add support for RSASSA-PSS in OCSP Response > 8179503: Java should support GET OCSP calls (dependency) > > to jdk11u-dev. > > The patches fix internal error upon verification of OCSP Response signed with RSASSA-PSS. > > The following changes were done to original patches: > > 8179503: > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > - resolved baseline conflict that took place due to absent revocation checking code > > test/jdk/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java > - unsupported `ObjectIdentifier.of()` substituted with `new ObjectIdentifier` > > 8274471: > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > - changes to absent revokation checking code ignored > > src/java.base/share/classes/sun/security/util/SignatureUtil.java > - the following non-existing methods transferred from jdk17: > `public static Signature fromKey(String sigAlg, PrivateKey key, String provider);` > `public static Signature fromKey(String sigAlg, PrivateKey key, Provider provider);` > `private static Signature autoInitInternal(String alg, PrivateKey key, Signature s);` > `public static AlgorithmId fromSignature(Signature sigEngine, PrivateKey key);` > - `EdEcKey` (unsupported in jdk11) hook removed from fromSignature() method > - copied `SignatureUtil.autoInitInternal()` method updated to use `AlgorithmId.getDefaultAlgorithmParameterSpec()` instead of `SignatureUtil.getDefaultParamSpec()` > - imported AlgorithmId class > > test/jdk/java/security/testlibrary/SimpleOCSPServer.java > - imported SignatureUtil class > > Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security This one is to be splitted into two separate ones ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/788 From duke at openjdk.java.net Wed Mar 2 12:07:05 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Wed, 2 Mar 2022 12:07:05 GMT Subject: [jdk11u-dev] Withdrawn: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: <5dcsrr9VvWF81CTqEue6tOrY5UDigY2l1IHXLE8xgAA=.ebd03557-52ca-4d8f-b932-dc8cfca43b0c@github.com> References: <5dcsrr9VvWF81CTqEue6tOrY5UDigY2l1IHXLE8xgAA=.ebd03557-52ca-4d8f-b932-dc8cfca43b0c@github.com> Message-ID: On Sat, 22 Jan 2022 09:13:30 GMT, Alexey Pavlyutkin wrote: > I'd like to backport > > 8274471: Add support for RSASSA-PSS in OCSP Response > 8179503: Java should support GET OCSP calls (dependency) > > to jdk11u-dev. > > The patches fix internal error upon verification of OCSP Response signed with RSASSA-PSS. > > The following changes were done to original patches: > > 8179503: > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > - resolved baseline conflict that took place due to absent revocation checking code > > test/jdk/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java > - unsupported `ObjectIdentifier.of()` substituted with `new ObjectIdentifier` > > 8274471: > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > - changes to absent revokation checking code ignored > > src/java.base/share/classes/sun/security/util/SignatureUtil.java > - the following non-existing methods transferred from jdk17: > `public static Signature fromKey(String sigAlg, PrivateKey key, String provider);` > `public static Signature fromKey(String sigAlg, PrivateKey key, Provider provider);` > `private static Signature autoInitInternal(String alg, PrivateKey key, Signature s);` > `public static AlgorithmId fromSignature(Signature sigEngine, PrivateKey key);` > - `EdEcKey` (unsupported in jdk11) hook removed from fromSignature() method > - copied `SignatureUtil.autoInitInternal()` method updated to use `AlgorithmId.getDefaultAlgorithmParameterSpec()` instead of `SignatureUtil.getDefaultParamSpec()` > - imported AlgorithmId class > > test/jdk/java/security/testlibrary/SimpleOCSPServer.java > - imported SignatureUtil class > > Verified (20.04 LTS/amd64) with attached [Test8274471.java.zip](https://github.com/openjdk/jdk17u/files/7514663/Test8274471.java.zip). Regression: jdk_security This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/788 From mdoerr at openjdk.java.net Wed Mar 2 13:15:05 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 2 Mar 2022 13:15:05 GMT Subject: [jdk11u-dev] RFR: 8179503: Java should support GET OCSP calls In-Reply-To: References: Message-ID: On Wed, 2 Mar 2022 11:47:30 GMT, Alexey Pavlyutkin wrote: > Hello! I'd like to backport > > 8179503: Java should support GET OCSP calls (dependency) > > to jdk11u-dev. This one is required as a dependency for > > 8274471: Add support for RSASSA-PSS in OCSP Response > > The following changes were done to apply original patch: > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > > - resolved baseline conflict taking place due to absent revocation checking code > > The rest of the code applied without changes > > Verification/regression (20.04/amd64): jdk_security Looks good. src/java.base/share/classes/sun/security/provider/certpath/OCSP.java line 2: > 1: /* > 2: * Copyright (c) 2009, 2022, Oracle and/or its affiliates. All rights reserved. Copyright year update not needed for pure backports when the original change doesn't touch it. May cause merge conflicts. Feel free to revert. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/847 From duke at openjdk.java.net Wed Mar 2 14:06:44 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Wed, 2 Mar 2022 14:06:44 GMT Subject: [jdk11u-dev] RFR: 8179503: Java should support GET OCSP calls [v2] In-Reply-To: References: Message-ID: <861H92b5UmmXqVXSRFATJy06EI1meeKW1-Ym7V_RjKE=.9e8b993b-d18f-46a1-a7fb-049c3d2f87eb@github.com> > Hello! I'd like to backport > > 8179503: Java should support GET OCSP calls (dependency) > > to jdk11u-dev. This one is required as a dependency for > > 8274471: Add support for RSASSA-PSS in OCSP Response > > The following changes were done to apply original patch: > > src/java.base/share/classes/sun/security/provider/certpath/OCSP.java > > - resolved baseline conflict taking place due to absent revocation checking code > > The rest of the code applied without changes > > Verification/regression (20.04/amd64): jdk_security Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: reverts copyright year ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/847/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/847/files/07b077c4..ae3d2ba2 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=847&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=847&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/847.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/847/head:pull/847 PR: https://git.openjdk.java.net/jdk11u-dev/pull/847 From mdoerr at openjdk.java.net Wed Mar 2 14:09:59 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 2 Mar 2022 14:09:59 GMT Subject: [jdk11u-dev] RFR: 8179503: Java should support GET OCSP calls [v2] In-Reply-To: <861H92b5UmmXqVXSRFATJy06EI1meeKW1-Ym7V_RjKE=.9e8b993b-d18f-46a1-a7fb-049c3d2f87eb@github.com> References: <861H92b5UmmXqVXSRFATJy06EI1meeKW1-Ym7V_RjKE=.9e8b993b-d18f-46a1-a7fb-049c3d2f87eb@github.com> Message-ID: <5h3Z0caf75FazgxCJ-7Ku3gjeB6FThQ1VgJoEi4XQCw=.1da46914-d7cf-4544-8f60-6a9523aca955@github.com> On Wed, 2 Mar 2022 14:06:44 GMT, Alexey Pavlyutkin wrote: >> Hello! I'd like to backport >> >> 8179503: Java should support GET OCSP calls (dependency) >> >> to jdk11u-dev. This one is required as a dependency for >> >> 8274471: Add support for RSASSA-PSS in OCSP Response >> >> The following changes were done to apply original patch: >> >> src/java.base/share/classes/sun/security/provider/certpath/OCSP.java >> >> - resolved baseline conflict taking place due to absent revocation checking code >> >> The rest of the code applied without changes >> >> Verification/regression (20.04/amd64): jdk_security > > Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: > > reverts copyright year Thumbs up from my side! ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/847 From burban at openjdk.java.net Wed Mar 2 14:58:07 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Wed, 2 Mar 2022 14:58:07 GMT Subject: [jdk11u-dev] RFR: 8260518: Change default -mmacosx-version-min to 10.12 [v2] In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 17:18:30 GMT, Vladimir Kempik wrote: >> Please review this backport of JDK-8260518 to jdk11u-dev >> The backport is not applying clean due to the context code difference. >> It's needed mostly to resolve this compilation error on macos-aarch64 >> splashscreen_sys.m:274:39: error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS 10.14 [-Werror,-Wdeprecated-declarations] >> This will allow to add macos-aarch64 build into github actions for jdk11u-dev ( once jep-391 backport is integrated) > > Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into JDK-8260518 > - 8260518: Change default -mmacosx-version-min to 10.12 Can this be merged? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From phh at openjdk.java.net Wed Mar 2 14:58:08 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 2 Mar 2022 14:58:08 GMT Subject: [jdk11u-dev] RFR: 8260518: Change default -mmacosx-version-min to 10.12 [v2] In-Reply-To: References: Message-ID: On Tue, 15 Feb 2022 17:18:30 GMT, Vladimir Kempik wrote: >> Please review this backport of JDK-8260518 to jdk11u-dev >> The backport is not applying clean due to the context code difference. >> It's needed mostly to resolve this compilation error on macos-aarch64 >> splashscreen_sys.m:274:39: error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS 10.14 [-Werror,-Wdeprecated-declarations] >> This will allow to add macos-aarch64 build into github actions for jdk11u-dev ( once jep-391 backport is integrated) > > Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into JDK-8260518 > - 8260518: Change default -mmacosx-version-min to 10.12 The JBS issue has been tagged with jdk11u-fix-yes, so yes, it can be merged. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From vkempik at openjdk.java.net Wed Mar 2 15:30:13 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Wed, 2 Mar 2022 15:30:13 GMT Subject: [jdk11u-dev] Integrated: 8260518: Change default -mmacosx-version-min to 10.12 In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 08:16:59 GMT, Vladimir Kempik wrote: > Please review this backport of JDK-8260518 to jdk11u-dev > The backport is not applying clean due to the context code difference. > It's needed mostly to resolve this compilation error on macos-aarch64 > splashscreen_sys.m:274:39: error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS 10.14 [-Werror,-Wdeprecated-declarations] > This will allow to add macos-aarch64 build into github actions for jdk11u-dev ( once jep-391 backport is integrated) This pull request has now been integrated. Changeset: 5561fd1e Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/5561fd1e4253489c667b18b79f261c96a3d5a9b4 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod 8260518: Change default -mmacosx-version-min to 10.12 Reviewed-by: phh, burban Backport-of: 53f1b93881a6404508628388ba590fe1f7f958ff ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From vkempik at openjdk.java.net Wed Mar 2 15:36:18 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Wed, 2 Mar 2022 15:36:18 GMT Subject: [jdk11u-dev] RFR: 8263856: Github Actions for macos/aarch64 cross-build [v2] In-Reply-To: References: Message-ID: > PLease review this backport to jdk11u-dev > it enables github CI crossbuilds of macos-aarch64 > Not applying clean due to gtest and few configure options, remade the patch basing on macos-intel part of existing jdk11u-dev job Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - 8263856: Github Actions for macos/aarch64 cross-build - Merge branch 'master' into JDK-8260518 - 8260518: Change default -mmacosx-version-min to 10.12 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/826/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=826&range=01 Stats: 107 lines in 4 files changed: 103 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/826.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/826/head:pull/826 PR: https://git.openjdk.java.net/jdk11u-dev/pull/826 From duke at openjdk.java.net Wed Mar 2 15:36:19 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Wed, 2 Mar 2022 15:36:19 GMT Subject: [jdk11u-dev] RFR: 8263856: Github Actions for macos/aarch64 cross-build In-Reply-To: References: Message-ID: <-belFSJbE3_ghd0N7Y1P4cjrJDAHTMpGH0BaNd3oH0M=.39d09dcb-fe5a-48f4-8c83-98e74b05e269@github.com> On Tue, 15 Feb 2022 17:22:20 GMT, Vladimir Kempik wrote: > PLease review this backport to jdk11u-dev > it enables github CI crossbuilds of macos-aarch64 > Not applying clean due to gtest and few configure options, remade the patch basing on macos-intel part of existing jdk11u-dev job The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8260518 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/826 From mdoerr at openjdk.java.net Wed Mar 2 16:32:36 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 2 Mar 2022 16:32:36 GMT Subject: [jdk17u-dev] RFR: 8275854: C2: assert(stride_con != 0) failed: missed some peephole opt Message-ID: <-85QARsva3SHlgIFVz7HBhzxGHkIGEF7VJNWeZo3AJc=.3138b523-5440-478f-a2e6-9027d7eec9b8@github.com> Clean backport of JDK-8275854. ------------- Commit messages: - Backport aea096770e74b9c0e1556467705ffdd6cf843d9d Changes: https://git.openjdk.java.net/jdk17u-dev/pull/185/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=185&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275854 Stats: 103 lines in 2 files changed: 103 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/185.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/185/head:pull/185 PR: https://git.openjdk.java.net/jdk17u-dev/pull/185 From mdoerr at openjdk.java.net Wed Mar 2 16:55:42 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 2 Mar 2022 16:55:42 GMT Subject: [jdk17u-dev] RFR: 8274983: C1 optimizes the invocation of private interface methods Message-ID: Clean backport of JDK-8274983. ------------- Commit messages: - Backport 21d9ca6cd942ac98a3be2577ded8eaf92dac7d46 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/186/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=186&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274983 Stats: 119 lines in 2 files changed: 107 ins; 12 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/186.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/186/head:pull/186 PR: https://git.openjdk.java.net/jdk17u-dev/pull/186 From mdoerr at openjdk.java.net Wed Mar 2 17:00:00 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 2 Mar 2022 17:00:00 GMT Subject: [jdk17u-dev] RFR: 8277906: Incorrect type for IV phi of long counted loops after CCP Message-ID: <4FcPKLv2Um_UWceZcZ1jqml65ddGrTdsMfIvCceMg8g=.8e22dd99-6922-4882-9983-1872c9b5e5f9@github.com> Clean backport of JDK-8277906. ------------- Commit messages: - Backport 3889af3f7debc4f8d75f620bb54134d1d11a6c83 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/187/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=187&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277906 Stats: 66 lines in 2 files changed: 61 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/187.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/187/head:pull/187 PR: https://git.openjdk.java.net/jdk17u-dev/pull/187 From xliu at openjdk.java.net Wed Mar 2 17:43:10 2022 From: xliu at openjdk.java.net (Xin Liu) Date: Wed, 2 Mar 2022 17:43:10 GMT Subject: [jdk17u-dev] RFR: 8274983: C1 optimizes the invocation of private interface methods In-Reply-To: References: Message-ID: <-P0Y2QKO-3z12m2tg7IfTSZ_xBuUoQKKMVgPSQzOkto=.277e1fd5-5cba-4d49-941d-333facf2e0fd@github.com> On Wed, 2 Mar 2022 16:39:25 GMT, Martin Doerr wrote: > Clean backport of JDK-8274983. LGTM. I am not a reviewer. We still need other reviewers to approve it. ------------- Marked as reviewed by xliu (no project role). PR: https://git.openjdk.java.net/jdk17u-dev/pull/186 From rkennke at openjdk.java.net Wed Mar 2 20:14:50 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 2 Mar 2022 20:14:50 GMT Subject: [jdk18u] RFR: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations Message-ID: Hi all, This backports a fix for a memory leak in the JDWP. The original change applies cleanly: https://github.com/openjdk/jdk/commit/5ab22e88da8d79f9e19e8afffdd06206f42bab94 See issue: https://bugs.openjdk.java.net/browse/JDK-8276990 and origina PR: https://github.com/openjdk/jdk/pull/7306 Thanks! ------------- Commit messages: - Backport 5ab22e88da8d79f9e19e8afffdd06206f42bab94 Changes: https://git.openjdk.java.net/jdk18u/pull/32/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=32&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276990 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/32.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/32/head:pull/32 PR: https://git.openjdk.java.net/jdk18u/pull/32 From burban at openjdk.java.net Wed Mar 2 20:27:14 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Wed, 2 Mar 2022 20:27:14 GMT Subject: [jdk11u-dev] RFR: 8260518: Change default -mmacosx-version-min to 10.12 [v2] In-Reply-To: References: Message-ID: <2ydstvwmrt99vvet93ZkiHsRal4TggWrka2fIgaLIWI=.65927e85-dfb3-4984-8661-b3159123d71f@github.com> On Tue, 15 Feb 2022 17:18:30 GMT, Vladimir Kempik wrote: >> Please review this backport of JDK-8260518 to jdk11u-dev >> The backport is not applying clean due to the context code difference. >> It's needed mostly to resolve this compilation error on macos-aarch64 >> splashscreen_sys.m:274:39: error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS 10.14 [-Werror,-Wdeprecated-declarations] >> This will allow to add macos-aarch64 build into github actions for jdk11u-dev ( once jep-391 backport is integrated) > > Vladimir Kempik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into JDK-8260518 > - 8260518: Change default -mmacosx-version-min to 10.12 Thank you Paul and Vladimir! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/810 From rkennke at openjdk.java.net Wed Mar 2 20:32:48 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 2 Mar 2022 20:32:48 GMT Subject: [jdk17u] RFR: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations Message-ID: Hi all, This backports a fix for a memory leak in the JDWP. The original change applies cleanly: https://github.com/openjdk/jdk/commit/5ab22e88da8d79f9e19e8afffdd06206f42bab94 See issue: https://bugs.openjdk.java.net/browse/JDK-8276990 and original PR: https://github.com/openjdk/jdk/pull/7306 Thanks! ------------- Commit messages: - Backport 5ab22e88da8d79f9e19e8afffdd06206f42bab94 Changes: https://git.openjdk.java.net/jdk17u/pull/334/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=334&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276990 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u/pull/334.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/334/head:pull/334 PR: https://git.openjdk.java.net/jdk17u/pull/334 From andrew at openjdk.java.net Wed Mar 2 21:59:13 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Wed, 2 Mar 2022 21:59:13 GMT Subject: [jdk11u-dev] RFR: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32 In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 17:05:59 GMT, Andrew John Hughes wrote: > The `slowdebug` build in 11u is broken in the same way as trunk was before this fix. We recently had to build 11u on x86_32 using Zero, due to issues with the new GCC 12 release, and the slowdebug build failed with this broken assert. Removing it allowed the build to complete. > > Backport is clean, but couldn't be automated as later JDK versions have the file in a `zero` subdirectory. > > Additional checks: > - [x] slowdebug build on x86_32 Waiting on jdk11u-fix-yes ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/839 From goetz.lindenmaier at sap.com Thu Mar 3 07:54:02 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 3 Mar 2022 07:54:02 +0000 Subject: Heads up: planned Harfbuzz update in jdk11u-dev In-Reply-To: References: <876bffc4-cb67-a92d-9be8-a8fcef1769e4@littlepinkcloud.com> <6f8f3b7be829565e23703572bddcbd8541202c59.camel@redhat.com> Message-ID: Hi, Development of 11.0.16 started in jdk11u-dev. I think we should now increment the C++ version for harfbuzz to C++11. Some later, we can backport the harfbuzz changes. This gives everybody time to make sure the compilers grok the C++11 flag before we do the code change. Best regards, Goetz. > -----Original Message----- > From: Baesken, Matthias > Sent: Friday, February 4, 2022 4:31 PM > To: sgehwolf ; Lindenmaier, Goetz > ; 'Andrew Haley' open at littlepinkcloud.com>; jdk-updates-dev at openjdk.java.net > Subject: RE: Heads up: planned Harfbuzz update in jdk11u-dev > > Hi Severin, thanks for the update ! > That's great news . > > Best regards, Matthias > > >FYI: We are able to use GCC 8 for the Vanilla JDK 11 builds. GCC 8 > >supports C++11. Builds are still RHEL 6/7 based as before. > > > >No objection for this harfbuzz update from our end. > From goetz at openjdk.java.net Thu Mar 3 08:04:10 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 3 Mar 2022 08:04:10 GMT Subject: [jdk11u-dev] RFR: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32 In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 17:05:59 GMT, Andrew John Hughes wrote: > The `slowdebug` build in 11u is broken in the same way as trunk was before this fix. We recently had to build 11u on x86_32 using Zero, due to issues with the new GCC 12 release, and the slowdebug build failed with this broken assert. Removing it allowed the build to complete. > > Backport is clean, but couldn't be automated as later JDK versions have the file in a `zero` subdirectory. > > Additional checks: > - [x] slowdebug build on x86_32 Shouldn't this go to jdk11u via critical request now? Rampdown started last Tuesday. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/839 From avoitylov at openjdk.java.net Thu Mar 3 08:16:28 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 3 Mar 2022 08:16:28 GMT Subject: [jdk11u-dev] RFR: 8217340: Compilation failed: tools/launcher/Test7029048.java Message-ID: JDK-8217340 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. Original changeset does not apply cleanly because comment line was changed to javadoc-style from "/*" to "/**" as part of "8216265: [testbug] Introduce Platform.sharedLibraryPathVariableName() and adapt all tests", which is irrelevant and too large to backport. Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html ------------- Commit messages: - backport of JDK-8217340 to 11u Changes: https://git.openjdk.java.net/jdk11u-dev/pull/848/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=848&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8217340 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/848.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/848/head:pull/848 PR: https://git.openjdk.java.net/jdk11u-dev/pull/848 From matthias.baesken at sap.com Thu Mar 3 08:20:30 2022 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Thu, 3 Mar 2022 08:20:30 +0000 Subject: Heads up: planned Harfbuzz update in jdk11u-dev Message-ID: Thanks Goetz ! I created https://bugs.openjdk.java.net/browse/JDK-8282588 8282588 : [11] set harfbuzz compilation flag to -std=c++11 Best regards, Matthias > Hi, > > Development of 11.0.16 started in jdk11u-dev. > > I think we should now increment the C++ version > for harfbuzz to C++11. > Some later, we can backport the harfbuzz changes. > This gives everybody time to make sure the compilers > grok the C++11 flag before we do the code change. > > Best regards, > Goetz. From avoitylov at openjdk.java.net Thu Mar 3 08:27:33 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 3 Mar 2022 08:27:33 GMT Subject: [jdk11u-dev] RFR: 8245938: Remove unused print_stack(void) method from XToolkit.c Message-ID: JDK-8245938 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. Applies cleanly. Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html ------------- Commit messages: - backport of JDK-8245938 to 11u Changes: https://git.openjdk.java.net/jdk11u-dev/pull/849/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=849&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8245938 Stats: 23 lines in 1 file changed: 0 ins; 23 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/849.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/849/head:pull/849 PR: https://git.openjdk.java.net/jdk11u-dev/pull/849 From stuefe at openjdk.java.net Thu Mar 3 08:30:28 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Thu, 3 Mar 2022 08:30:28 GMT Subject: [jdk11u-dev] RFR: JDK-8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11 Message-ID: In JDK 11 only, we see errors in runtime/ErrorHandling/ErrorHandler.java. The test induces an artificial (but real) segfault and checks the VMs reaction to it (that the hs-err file is written correctly and contains expected output). The test does this by reading from `char* p = NULL;`. This is not guaranteed to work, and does not in this case: the process gets a "BPT/Trap" message instead and dies. This code (`VMError::controlled_crash()`) has been streamlined and rewritten for later releases, and there we consistently use a known non-null address to invalid memory instead, which seems to work reliably for MacOs aarch64 too. --- The patch, instead of downporting the whole reworkings of `VMError::controlled_crash`, just reuses the code which checks a segfault against a non-null invalid address. That way we do the same as newer releases, but with minimal changes. ------------- Commit messages: - small fix - fix Changes: https://git.openjdk.java.net/jdk11u-dev/pull/842/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=842&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282589 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/842.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/842/head:pull/842 PR: https://git.openjdk.java.net/jdk11u-dev/pull/842 From stuefe at openjdk.java.net Thu Mar 3 08:30:28 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Thu, 3 Mar 2022 08:30:28 GMT Subject: [jdk11u-dev] RFR: JDK-8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11 In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 13:52:08 GMT, Thomas Stuefe wrote: > In JDK 11 only, we see errors in runtime/ErrorHandling/ErrorHandler.java. The test induces an artificial (but real) segfault and checks the VMs reaction to it (that the hs-err file is written correctly and contains expected output). > > The test does this by reading from `char* p = NULL;`. This is not guaranteed to work, and does not in this case: the process gets a "BPT/Trap" message instead and dies. > > This code (`VMError::controlled_crash()`) has been streamlined and rewritten for later releases, and there we consistently use a known non-null address to invalid memory instead, which seems to work reliably for MacOs aarch64 too. > > --- > > The patch, instead of downporting the whole reworkings of `VMError::controlled_crash`, just reuses the code which checks a segfault against a non-null invalid address. That way we do the same as newer releases, but with minimal changes. Linux GHA error unrelated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/842 From avoitylov at openjdk.java.net Thu Mar 3 08:33:29 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 3 Mar 2022 08:33:29 GMT Subject: [jdk11u-dev] RFR: 8252248: __SIGRTMAX is not declared in musl libc Message-ID: JDK-8252248 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. Compared to original changeset this backport looks cosmetically different in #ifdefs in NativeThread.c because of another code layout due to "8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports". Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html ------------- Commit messages: - backport of JDK-8252248 to 11u Changes: https://git.openjdk.java.net/jdk11u-dev/pull/850/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=850&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252248 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/850.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/850/head:pull/850 PR: https://git.openjdk.java.net/jdk11u-dev/pull/850 From avoitylov at openjdk.java.net Thu Mar 3 08:35:27 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 3 Mar 2022 08:35:27 GMT Subject: [jdk11u-dev] RFR: 8252250: isnanf is obsolete Message-ID: <4hcI6RLplGU_qvFnBIAzcHCMpWbwLV_CAqNWBQa84sE=.42f2d7b7-ab3e-406f-8459-53b3260f0ebc@github.com> JDK-8252250 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. Unlike original changeset this backport also changes src/java.base/unix/native/libjava/jdk_util_md.h because it also contains isnanf, which was removed in JDK16 by "JDK-8249612: Remove unused ISNANF and ISNAND from jdk_util_md.h" after removing its usage by "JDK-8199424: consider removing ObjectInputStream and ObjectOutputStream native methods" in JDK14. Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html ------------- Commit messages: - backport of JDK-8252250 to 11u Changes: https://git.openjdk.java.net/jdk11u-dev/pull/851/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=851&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252250 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/851.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/851/head:pull/851 PR: https://git.openjdk.java.net/jdk11u-dev/pull/851 From vkempik at openjdk.java.net Thu Mar 3 08:54:11 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 3 Mar 2022 08:54:11 GMT Subject: [jdk11u-dev] Integrated: 8263856: Github Actions for macos/aarch64 cross-build In-Reply-To: References: Message-ID: <56P11oFfkWAwbbHrr4r34gNdLlTk2F6bY_lLlyOTKQg=.360794dd-466e-4d23-b0a0-9ae94bf97920@github.com> On Tue, 15 Feb 2022 17:22:20 GMT, Vladimir Kempik wrote: > PLease review this backport to jdk11u-dev > it enables github CI crossbuilds of macos-aarch64 > Not applying clean due to gtest and few configure options, remade the patch basing on macos-intel part of existing jdk11u-dev job This pull request has now been integrated. Changeset: 8a9f20a1 Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/8a9f20a1c6b1592e0cbc5bfc15ae21a7924bc662 Stats: 103 lines in 1 file changed: 103 ins; 0 del; 0 mod 8263856: Github Actions for macos/aarch64 cross-build Reviewed-by: phh Backport-of: 114e3c3e2daedb34368c741bc8902f532550043f ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/826 From vkempik at openjdk.java.net Thu Mar 3 08:57:14 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 3 Mar 2022 08:57:14 GMT Subject: [jdk11u-dev] RFR: JDK-8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11 In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 13:52:08 GMT, Thomas Stuefe wrote: > In JDK 11 only, we see errors in runtime/ErrorHandling/ErrorHandler.java. The test induces an artificial (but real) segfault and checks the VMs reaction to it (that the hs-err file is written correctly and contains expected output). > > The test does this by reading from `char* p = NULL;`. This is not guaranteed to work, and does not in this case: the process gets a "BPT/Trap" message instead and dies. > > This code (`VMError::controlled_crash()`) has been streamlined and rewritten for later releases, and there we consistently use a known non-null address to invalid memory instead, which seems to work reliably for MacOs aarch64 too. > > --- > > The patch, instead of downporting the whole reworkings of `VMError::controlled_crash`, just reuses the code which checks a segfault against a non-null invalid address. That way we do the same as newer releases, but with minimal changes. Marked as reviewed by vkempik (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/842 From vkempik at openjdk.java.net Thu Mar 3 09:00:07 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 3 Mar 2022 09:00:07 GMT Subject: [jdk11u-dev] RFR: JDK-8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11 In-Reply-To: References: Message-ID: <_NqVZx1AquGifjpGN5uOWo5yGEDEe5Mm2Y4lfHFwPSI=.188e9b70-2304-4ff4-8dbd-ea5beb9f0d6a@github.com> On Mon, 28 Feb 2022 13:52:08 GMT, Thomas Stuefe wrote: > In JDK 11 only, we see errors in runtime/ErrorHandling/ErrorHandler.java. The test induces an artificial (but real) segfault and checks the VMs reaction to it (that the hs-err file is written correctly and contains expected output). > > The test does this by reading from `char* p = NULL;`. This is not guaranteed to work, and does not in this case: the process gets a "BPT/Trap" message instead and dies. > > This code (`VMError::controlled_crash()`) has been streamlined and rewritten for later releases, and there we consistently use a known non-null address to invalid memory instead, which seems to work reliably for MacOs aarch64 too. > > --- > > The patch, instead of downporting the whole reworkings of `VMError::controlled_crash`, just reuses the code which checks a segfault against a non-null invalid address. That way we do the same as newer releases, but with minimal changes. I was investigating that also and came to conclusion it's a difference between mac-intel and mac-arm. lgtm. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/842 From stuefe at openjdk.java.net Thu Mar 3 09:09:04 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Thu, 3 Mar 2022 09:09:04 GMT Subject: [jdk11u-dev] RFR: JDK-8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11 In-Reply-To: <_NqVZx1AquGifjpGN5uOWo5yGEDEe5Mm2Y4lfHFwPSI=.188e9b70-2304-4ff4-8dbd-ea5beb9f0d6a@github.com> References: <_NqVZx1AquGifjpGN5uOWo5yGEDEe5Mm2Y4lfHFwPSI=.188e9b70-2304-4ff4-8dbd-ea5beb9f0d6a@github.com> Message-ID: On Thu, 3 Mar 2022 08:57:02 GMT, Vladimir Kempik wrote: > I was investigating that also and came to conclusion it's a difference between mac-intel and mac-arm. lgtm. Thanks Vladimir! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/842 From mdoerr at openjdk.java.net Thu Mar 3 09:58:20 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 3 Mar 2022 09:58:20 GMT Subject: [jdk17u-dev] Integrated: 8281043: Intrinsify recursive ObjectMonitor locking for PPC64 In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 11:48:12 GMT, Martin Doerr wrote: > Clean backport of JDK-8281043. It addresses a performance regression from jdk16. This pull request has now been integrated. Changeset: 23b7f7e7 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/23b7f7e7b4246b95c636cf77f02a2c1c1265f2a6 Stats: 23 lines in 1 file changed: 8 ins; 3 del; 12 mod 8281043: Intrinsify recursive ObjectMonitor locking for PPC64 Backport-of: 46c6c6f308b5ec0ec3b762df4b76de555287474c ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/150 From mdoerr at openjdk.java.net Thu Mar 3 09:59:31 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 3 Mar 2022 09:59:31 GMT Subject: [jdk17u-dev] Integrated: 8274983: C1 optimizes the invocation of private interface methods In-Reply-To: References: Message-ID: On Wed, 2 Mar 2022 16:39:25 GMT, Martin Doerr wrote: > Clean backport of JDK-8274983. This pull request has now been integrated. Changeset: 977e7736 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/977e773663d5fad07cb37471e00381718f62c889 Stats: 119 lines in 2 files changed: 107 ins; 12 del; 0 mod 8274983: C1 optimizes the invocation of private interface methods Reviewed-by: xliu Backport-of: 21d9ca6cd942ac98a3be2577ded8eaf92dac7d46 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/186 From mdoerr at openjdk.java.net Thu Mar 3 10:00:24 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 3 Mar 2022 10:00:24 GMT Subject: [jdk17u-dev] Integrated: 8277906: Incorrect type for IV phi of long counted loops after CCP In-Reply-To: <4FcPKLv2Um_UWceZcZ1jqml65ddGrTdsMfIvCceMg8g=.8e22dd99-6922-4882-9983-1872c9b5e5f9@github.com> References: <4FcPKLv2Um_UWceZcZ1jqml65ddGrTdsMfIvCceMg8g=.8e22dd99-6922-4882-9983-1872c9b5e5f9@github.com> Message-ID: On Wed, 2 Mar 2022 16:46:25 GMT, Martin Doerr wrote: > Clean backport of JDK-8277906. This pull request has now been integrated. Changeset: 40173515 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/40173515c17c2adb1b21612256d84a2c47c5348a Stats: 66 lines in 2 files changed: 61 ins; 0 del; 5 mod 8277906: Incorrect type for IV phi of long counted loops after CCP Backport-of: 3889af3f7debc4f8d75f620bb54134d1d11a6c83 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/187 From mdoerr at openjdk.java.net Thu Mar 3 10:01:28 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 3 Mar 2022 10:01:28 GMT Subject: [jdk17u-dev] Integrated: 8275854: C2: assert(stride_con != 0) failed: missed some peephole opt In-Reply-To: <-85QARsva3SHlgIFVz7HBhzxGHkIGEF7VJNWeZo3AJc=.3138b523-5440-478f-a2e6-9027d7eec9b8@github.com> References: <-85QARsva3SHlgIFVz7HBhzxGHkIGEF7VJNWeZo3AJc=.3138b523-5440-478f-a2e6-9027d7eec9b8@github.com> Message-ID: On Wed, 2 Mar 2022 16:23:29 GMT, Martin Doerr wrote: > Clean backport of JDK-8275854. This pull request has now been integrated. Changeset: 4631f4ac Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/4631f4ac5f2955f3765c77cbb93d4c7501d82f80 Stats: 103 lines in 2 files changed: 103 ins; 0 del; 0 mod 8275854: C2: assert(stride_con != 0) failed: missed some peephole opt Backport-of: aea096770e74b9c0e1556467705ffdd6cf843d9d ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/185 From stuefe at openjdk.java.net Thu Mar 3 10:02:07 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Thu, 3 Mar 2022 10:02:07 GMT Subject: [jdk11u-dev] RFR: 8252248: __SIGRTMAX is not declared in musl libc In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 08:25:51 GMT, Aleksei Voitylov wrote: > JDK-8252248 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Compared to original changeset this backport looks cosmetically different in #ifdefs in NativeThread.c because of another code layout due to "8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports". > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html Looks good. ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/850 From vkempik at openjdk.java.net Thu Mar 3 11:36:06 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 3 Mar 2022 11:36:06 GMT Subject: [jdk11u-dev] RFR: JDK-8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11 In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 13:52:08 GMT, Thomas Stuefe wrote: > In JDK 11 only, we see errors in runtime/ErrorHandling/ErrorHandler.java. The test induces an artificial (but real) segfault and checks the VMs reaction to it (that the hs-err file is written correctly and contains expected output). > > The test does this by reading from `char* p = NULL;`. This is not guaranteed to work, and does not in this case: the process gets a "BPT/Trap" message instead and dies. > > This code (`VMError::controlled_crash()`) has been streamlined and rewritten for later releases, and there we consistently use a known non-null address to invalid memory instead, which seems to work reliably for MacOs aarch64 too. > > --- > > The patch, instead of downporting the whole reworkings of `VMError::controlled_crash`, just reuses the code which checks a segfault against a non-null invalid address. That way we do the same as newer releases, but with minimal changes. Thomas, could you please revert this change https://github.com/openjdk/jdk11u-dev/pull/715/files#diff-aa0ca5360fa814ad73db34b607175d3e73987cf6a3c8274ac8c17a08d8c8a753 as part of your commit ? it was the test I have disabled on mac-arm as a workaround for the issue you fixing here ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/842 From stuefe at openjdk.java.net Thu Mar 3 13:41:36 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Thu, 3 Mar 2022 13:41:36 GMT Subject: [jdk11u-dev] RFR: JDK-8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11 [v2] In-Reply-To: References: Message-ID: > In JDK 11 only, we see errors in runtime/ErrorHandling/ErrorHandler.java. The test induces an artificial (but real) segfault and checks the VMs reaction to it (that the hs-err file is written correctly and contains expected output). > > The test does this by reading from `char* p = NULL;`. This is not guaranteed to work, and does not in this case: the process gets a "BPT/Trap" message instead and dies. > > This code (`VMError::controlled_crash()`) has been streamlined and rewritten for later releases, and there we consistently use a known non-null address to invalid memory instead, which seems to work reliably for MacOs aarch64 too. > > --- > > The patch, instead of downporting the whole reworkings of `VMError::controlled_crash`, just reuses the code which checks a segfault against a non-null invalid address. That way we do the same as newer releases, but with minimal changes. Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision: Re-enable runtime/ErrorHandling/TestOnError.java on MacOS aarch64 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/842/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/842/files/40fdc398..5883b481 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=842&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=842&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/842.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/842/head:pull/842 PR: https://git.openjdk.java.net/jdk11u-dev/pull/842 From stuefe at openjdk.java.net Thu Mar 3 13:41:37 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Thu, 3 Mar 2022 13:41:37 GMT Subject: [jdk11u-dev] RFR: JDK-8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11 In-Reply-To: References: Message-ID: <2cuxkOLyhXmAFtV_-iJVFwpbYw_cpZb1wbOAzhW4NA8=.3b6e937e-89c5-40d2-aec3-1652f387bb95@github.com> On Thu, 3 Mar 2022 11:32:49 GMT, Vladimir Kempik wrote: > Thomas, could you please revert this change https://github.com/openjdk/jdk11u-dev/pull/715/files#diff-aa0ca5360fa814ad73db34b607175d3e73987cf6a3c8274ac8c17a08d8c8a753 as part of your commit ? it was the test I have disabled on mac-arm as a workaround for the issue you fixing here Done. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/842 From vkempik at openjdk.java.net Thu Mar 3 14:45:07 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 3 Mar 2022 14:45:07 GMT Subject: [jdk11u-dev] RFR: JDK-8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11 [v2] In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 13:41:36 GMT, Thomas Stuefe wrote: >> In JDK 11 only, we see errors in runtime/ErrorHandling/ErrorHandler.java. The test induces an artificial (but real) segfault and checks the VMs reaction to it (that the hs-err file is written correctly and contains expected output). >> >> The test does this by reading from `char* p = NULL;`. This is not guaranteed to work, and does not in this case: the process gets a "BPT/Trap" message instead and dies. >> >> This code (`VMError::controlled_crash()`) has been streamlined and rewritten for later releases, and there we consistently use a known non-null address to invalid memory instead, which seems to work reliably for MacOs aarch64 too. >> >> --- >> >> The patch, instead of downporting the whole reworkings of `VMError::controlled_crash`, just reuses the code which checks a segfault against a non-null invalid address. That way we do the same as newer releases, but with minimal changes. > > Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision: > > Re-enable runtime/ErrorHandling/TestOnError.java on MacOS aarch64 Marked as reviewed by vkempik (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/842 From mdoerr at openjdk.java.net Thu Mar 3 15:01:37 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 3 Mar 2022 15:01:37 GMT Subject: [jdk17u-dev] RFR: 8258814: Compilation logging crashes for thread suspension / debugging tests Message-ID: Clean backport of JDK-8258814. ------------- Commit messages: - Backport 35ee0f38c6d5e35fb50a059a189e032df7f7e7c5 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/188/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=188&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258814 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/188.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/188/head:pull/188 PR: https://git.openjdk.java.net/jdk17u-dev/pull/188 From mdoerr at openjdk.java.net Thu Mar 3 15:10:32 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 3 Mar 2022 15:10:32 GMT Subject: [jdk17u-dev] RFR: 8279837: C2: assert(is_Loop()) failed: invalid node class: Region Message-ID: Clean Backport of JDK-8279837. ------------- Commit messages: - Backport 65eb066b630b892f22492457e0f86165e5ef4765 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/189/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=189&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279837 Stats: 87 lines in 2 files changed: 87 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/189.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/189/head:pull/189 PR: https://git.openjdk.java.net/jdk17u-dev/pull/189 From mdoerr at openjdk.java.net Thu Mar 3 15:14:40 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 3 Mar 2022 15:14:40 GMT Subject: [jdk17u-dev] RFR: 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist! Message-ID: Clean Backport of JDK-8279356. ------------- Commit messages: - Backport 6d7db4b0b3e9172645cef12c36fbeb41a6d38d83 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/190/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=190&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279356 Stats: 53 lines in 2 files changed: 43 ins; 2 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/190.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/190/head:pull/190 PR: https://git.openjdk.java.net/jdk17u-dev/pull/190 From vkempik at openjdk.java.net Thu Mar 3 16:41:58 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 3 Mar 2022 16:41:58 GMT Subject: [jdk11u-dev] RFR: 8252250: isnanf is obsolete In-Reply-To: <4hcI6RLplGU_qvFnBIAzcHCMpWbwLV_CAqNWBQa84sE=.42f2d7b7-ab3e-406f-8459-53b3260f0ebc@github.com> References: <4hcI6RLplGU_qvFnBIAzcHCMpWbwLV_CAqNWBQa84sE=.42f2d7b7-ab3e-406f-8459-53b3260f0ebc@github.com> Message-ID: On Thu, 3 Mar 2022 08:29:01 GMT, Aleksei Voitylov wrote: > JDK-8252250 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Unlike original changeset this backport also changes src/java.base/unix/native/libjava/jdk_util_md.h because it also contains isnanf, which was removed in JDK16 by "JDK-8249612: Remove unused ISNANF and ISNAND from jdk_util_md.h" after removing its usage by "JDK-8199424: consider removing ObjectInputStream and ObjectOutputStream native methods" in JDK14. > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html Marked as reviewed by vkempik (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/851 From rkennke at openjdk.java.net Thu Mar 3 19:11:23 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Thu, 3 Mar 2022 19:11:23 GMT Subject: [jdk11u-dev] RFR: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations Message-ID: <8_1oUjbRhcoaVKjhtHAQfYp4ZbY2l5itdNWceegkdkY=.5db98b2b-8066-449b-9bc9-a532781b2865@github.com> Hi all, This backports a fix for a memory leak in the JDWP. The original change applies cleanly: https://github.com/openjdk/jdk/commit/5ab22e88da8d79f9e19e8afffdd06206f42bab94 See issue: https://bugs.openjdk.java.net/browse/JDK-8276990 and original PR: https://github.com/openjdk/jdk/pull/7306 Thanks! ------------- Commit messages: - Backport 5ab22e88da8d79f9e19e8afffdd06206f42bab94 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/852/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=852&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276990 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/852.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/852/head:pull/852 PR: https://git.openjdk.java.net/jdk11u-dev/pull/852 From dchuyko at openjdk.java.net Thu Mar 3 20:40:13 2022 From: dchuyko at openjdk.java.net (Dmitry Chuyko) Date: Thu, 3 Mar 2022 20:40:13 GMT Subject: [jdk17u-dev] Integrated: 8268231: Aarch64: Use Ldp in intrinsics for String.compareTo In-Reply-To: References: Message-ID: On Thu, 13 Jan 2022 14:48:40 GMT, Dmitry Chuyko wrote: > Original patch applies cleanly. > > Benchmark results of test/micro/org/openjdk/bench/java/lang/StringCompareToDifferentLength.java correspond to original issue, 10-25% 17u improvements on Graviton 2 for long enough strings (72+ chars). > > Testing: tier1, tier2 (aarch64). This pull request has now been integrated. Changeset: dd83c4e7 Author: Dmitry Chuyko Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk17u-dev/commit/dd83c4e72d6111482e223723b10cefd6b8b52c49 Stats: 106 lines in 1 file changed: 39 ins; 40 del; 27 mod 8268231: Aarch64: Use Ldp in intrinsics for String.compareTo Backport-of: 6d1d4d52928ed38bbc73ddcbede5389995a8e65f ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/91 From dchuyko at openjdk.java.net Thu Mar 3 21:59:30 2022 From: dchuyko at openjdk.java.net (Dmitry Chuyko) Date: Thu, 3 Mar 2022 21:59:30 GMT Subject: [jdk17u-dev] RFR: 8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment Message-ID: This is a trivial follow-up to JDK-8268231 that puts loop alignment in the right place. It can improve the intrinsic performance on some aarch64 implementations. Testing: jtreg tier1, tier2, test/hotspot/jtreg/compiler/intrinsics/string on Graviton 2. ------------- Commit messages: - Backport 126328cb6218a93d23ed6169d7e52fb2719528ed Changes: https://git.openjdk.java.net/jdk17u-dev/pull/191/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=191&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279560 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/191.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/191/head:pull/191 PR: https://git.openjdk.java.net/jdk17u-dev/pull/191 From yan at openjdk.java.net Fri Mar 4 07:43:46 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Fri, 4 Mar 2022 07:43:46 GMT Subject: [jdk15u-dev] RFR: 8276141: XPathFactory set/getProperty method [v3] In-Reply-To: <0TOCj7XxTc54fdb2UzD5ZvhPsTK8SJF3xB-B6XrpdZ0=.6b7e4db6-eda8-41c0-ad49-d82e4410a708@github.com> References: <0TOCj7XxTc54fdb2UzD5ZvhPsTK8SJF3xB-B6XrpdZ0=.6b7e4db6-eda8-41c0-ad49-d82e4410a708@github.com> Message-ID: > get/setProperty added plus test and presumably CSR; difference from the original is in LAstModified of XPathFactoryImpl.java and the test context. Yuri Nesterenko has updated the pull request incrementally with two additional commits since the last revision: - Remove Override from XPathFactoryImpl - Remove changes in XPathFactory ------------- Changes: - all: https://git.openjdk.java.net/jdk15u-dev/pull/179/files - new: https://git.openjdk.java.net/jdk15u-dev/pull/179/files/61ee9a0f..9a2b047e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=179&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=179&range=01-02 Stats: 199 lines in 4 files changed: 3 ins; 191 del; 5 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/179.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/179/head:pull/179 PR: https://git.openjdk.java.net/jdk15u-dev/pull/179 From yan at openjdk.java.net Fri Mar 4 08:02:57 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Fri, 4 Mar 2022 08:02:57 GMT Subject: [jdk13u-dev] RFR: 8276141: XPathFactory set/getProperty method [v3] In-Reply-To: References: Message-ID: > Difference against the original: no LastModified in XPathFactoryImpl.java in 13/15; the test patch manually applied. Yuri Nesterenko has updated the pull request incrementally with one additional commit since the last revision: Remove changes in XPathFactory and Override from Impl ------------- Changes: - all: https://git.openjdk.java.net/jdk13u-dev/pull/329/files - new: https://git.openjdk.java.net/jdk13u-dev/pull/329/files/2d99ba15..9789b370 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=329&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=329&range=01-02 Stats: 199 lines in 4 files changed: 3 ins; 191 del; 5 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/329.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/329/head:pull/329 PR: https://git.openjdk.java.net/jdk13u-dev/pull/329 From goetz at openjdk.java.net Fri Mar 4 08:30:11 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 4 Mar 2022 08:30:11 GMT Subject: [jdk13u-dev] RFR: 8276141: XPathFactory set/getProperty method [v3] In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 08:02:57 GMT, Yuri Nesterenko wrote: >> Difference against the original: no LastModified in XPathFactoryImpl.java in 13/15; the test patch manually applied. > > Yuri Nesterenko has updated the pull request incrementally with one additional commit since the last revision: > > Remove changes in XPathFactory and Override from Impl LGTM ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.java.net/jdk13u-dev/pull/329 From mbaesken at openjdk.java.net Fri Mar 4 08:47:21 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Fri, 4 Mar 2022 08:47:21 GMT Subject: [jdk11u-dev] RFR: JDK-8282588: [11] set harfbuzz compilation flag to -std=c++11 Message-ID: As a preparation to update harfbuzz in jdk11u-dev to the versions used in higher JDK (harfbuzz 2.7.2 / 2.8.0) increment the C++ version for harfbuzz to C++11. Some time later, the harfbuzz changes are backported. This gives everybody time to make sure the compilers work with the C++11 flag, or system harfbuzz is used as a workaround. ------------- Commit messages: - JDK-8282588 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/853/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=853&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282588 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/853.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/853/head:pull/853 PR: https://git.openjdk.java.net/jdk11u-dev/pull/853 From bae at openjdk.java.net Fri Mar 4 08:53:04 2022 From: bae at openjdk.java.net (Andrew Brygin) Date: Fri, 4 Mar 2022 08:53:04 GMT Subject: [jdk13u-dev] RFR: 8276141: XPathFactory set/getProperty method [v3] In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 08:02:57 GMT, Yuri Nesterenko wrote: >> Difference against the original: no LastModified in XPathFactoryImpl.java in 13/15; the test patch manually applied. > > Yuri Nesterenko has updated the pull request incrementally with one additional commit since the last revision: > > Remove changes in XPathFactory and Override from Impl Looks fine. ------------- Marked as reviewed by bae (Reviewer). PR: https://git.openjdk.java.net/jdk13u-dev/pull/329 From bae at openjdk.java.net Fri Mar 4 09:00:09 2022 From: bae at openjdk.java.net (Andrew Brygin) Date: Fri, 4 Mar 2022 09:00:09 GMT Subject: [jdk15u-dev] RFR: 8276141: XPathFactory set/getProperty method [v3] In-Reply-To: References: <0TOCj7XxTc54fdb2UzD5ZvhPsTK8SJF3xB-B6XrpdZ0=.6b7e4db6-eda8-41c0-ad49-d82e4410a708@github.com> Message-ID: On Fri, 4 Mar 2022 07:43:46 GMT, Yuri Nesterenko wrote: >> get/setProperty added plus test and presumably CSR; difference from the original is in LAstModified of XPathFactoryImpl.java and the test context. > > Yuri Nesterenko has updated the pull request incrementally with two additional commits since the last revision: > > - Remove Override from XPathFactoryImpl > - Remove changes in XPathFactory Looks fine to me. Thanks, Andrew ------------- Marked as reviewed by bae (Reviewer). PR: https://git.openjdk.java.net/jdk15u-dev/pull/179 From yan at openjdk.java.net Fri Mar 4 09:08:11 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Fri, 4 Mar 2022 09:08:11 GMT Subject: [jdk13u-dev] Integrated: 8276141: XPathFactory set/getProperty method In-Reply-To: References: Message-ID: On Thu, 17 Feb 2022 15:14:46 GMT, Yuri Nesterenko wrote: > Difference against the original: no LastModified in XPathFactoryImpl.java in 13/15; the test patch manually applied. This pull request has now been integrated. Changeset: 4b2f75b0 Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk13u-dev/commit/4b2f75b0b0441e1ffb4fb3b4f789f13008c20307 Stats: 58 lines in 2 files changed: 56 ins; 0 del; 2 mod 8276141: XPathFactory set/getProperty method Reviewed-by: bae, goetz Backport-of: b226ab99c872e791d3ed9fca015cf92847904c34 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/329 From yan at openjdk.java.net Fri Mar 4 09:11:01 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Fri, 4 Mar 2022 09:11:01 GMT Subject: [jdk15u-dev] Integrated: 8276141: XPathFactory set/getProperty method In-Reply-To: <0TOCj7XxTc54fdb2UzD5ZvhPsTK8SJF3xB-B6XrpdZ0=.6b7e4db6-eda8-41c0-ad49-d82e4410a708@github.com> References: <0TOCj7XxTc54fdb2UzD5ZvhPsTK8SJF3xB-B6XrpdZ0=.6b7e4db6-eda8-41c0-ad49-d82e4410a708@github.com> Message-ID: <6_aHUQzzhBgtOx9HE-QwpBUPzCQU2ngCo2LWCdCt5do=.e52ded0a-b3b1-4eb5-a400-c19f3a2ad792@github.com> On Thu, 17 Feb 2022 15:17:33 GMT, Yuri Nesterenko wrote: > get/setProperty added plus test and presumably CSR; difference from the original is in LAstModified of XPathFactoryImpl.java and the test context. This pull request has now been integrated. Changeset: b98036fd Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk15u-dev/commit/b98036fd88c11d12b4f55bc1e7f5e592fc1014f0 Stats: 58 lines in 2 files changed: 56 ins; 0 del; 2 mod 8276141: XPathFactory set/getProperty method Reviewed-by: bae Backport-of: b226ab99c872e791d3ed9fca015cf92847904c34 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/179 From mdoerr at openjdk.java.net Fri Mar 4 09:39:25 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 4 Mar 2022 09:39:25 GMT Subject: [jdk17u-dev] Integrated: 8258814: Compilation logging crashes for thread suspension / debugging tests In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 14:52:46 GMT, Martin Doerr wrote: > Clean backport of JDK-8258814. This pull request has now been integrated. Changeset: 9ff24faf Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/9ff24faf1f796d61cde53584522c96e7592790bc Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8258814: Compilation logging crashes for thread suspension / debugging tests Backport-of: 35ee0f38c6d5e35fb50a059a189e032df7f7e7c5 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/188 From mdoerr at openjdk.java.net Fri Mar 4 09:40:25 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 4 Mar 2022 09:40:25 GMT Subject: [jdk17u-dev] Integrated: 8279837: C2: assert(is_Loop()) failed: invalid node class: Region In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 15:01:04 GMT, Martin Doerr wrote: > Clean Backport of JDK-8279837. This pull request has now been integrated. Changeset: ac19e3e1 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/ac19e3e14456060f8ff10c5aeedd22c75e44ff4f Stats: 87 lines in 2 files changed: 87 ins; 0 del; 0 mod 8279837: C2: assert(is_Loop()) failed: invalid node class: Region Backport-of: 65eb066b630b892f22492457e0f86165e5ef4765 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/189 From mdoerr at openjdk.java.net Fri Mar 4 09:41:23 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 4 Mar 2022 09:41:23 GMT Subject: [jdk17u-dev] Integrated: 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist! In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 15:08:09 GMT, Martin Doerr wrote: > Clean Backport of JDK-8279356. This pull request has now been integrated. Changeset: 2c480b2c Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/2c480b2c2bbbfcba5222ee2ff151a2cc92da54a7 Stats: 53 lines in 2 files changed: 43 ins; 2 del; 8 mod 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist! Backport-of: 6d7db4b0b3e9172645cef12c36fbeb41a6d38d83 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/190 From rkennke at openjdk.java.net Fri Mar 4 10:14:24 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Fri, 4 Mar 2022 10:14:24 GMT Subject: [jdk17u] RFR: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations In-Reply-To: References: Message-ID: <8yOISZHtxFtNawrmxj7zJzqnkh_Ye_KwDiy0hdz08rk=.ad4d8906-1963-4034-bab6-c260419f4966@github.com> On Wed, 2 Mar 2022 20:26:38 GMT, Roman Kennke wrote: > Hi all, > > This backports a fix for a memory leak in the JDWP. > The original change applies cleanly: > > https://github.com/openjdk/jdk/commit/5ab22e88da8d79f9e19e8afffdd06206f42bab94 > > See issue: > https://bugs.openjdk.java.net/browse/JDK-8276990 > and original PR: > https://github.com/openjdk/jdk/pull/7306 > > Thanks! Closing and re-opening vs jdk17u-dev ------------- PR: https://git.openjdk.java.net/jdk17u/pull/334 From rkennke at openjdk.java.net Fri Mar 4 10:14:25 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Fri, 4 Mar 2022 10:14:25 GMT Subject: [jdk17u] Withdrawn: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations In-Reply-To: References: Message-ID: On Wed, 2 Mar 2022 20:26:38 GMT, Roman Kennke wrote: > Hi all, > > This backports a fix for a memory leak in the JDWP. > The original change applies cleanly: > > https://github.com/openjdk/jdk/commit/5ab22e88da8d79f9e19e8afffdd06206f42bab94 > > See issue: > https://bugs.openjdk.java.net/browse/JDK-8276990 > and original PR: > https://github.com/openjdk/jdk/pull/7306 > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/334 From adinn at openjdk.java.net Fri Mar 4 10:19:17 2022 From: adinn at openjdk.java.net (Andrew Dinn) Date: Fri, 4 Mar 2022 10:19:17 GMT Subject: [jdk17u-dev] RFR: 8268231: Aarch64: Use Ldp in intrinsics for String.compareTo In-Reply-To: References: Message-ID: On Thu, 10 Feb 2022 14:21:43 GMT, Dmitry Chuyko wrote: >> Original patch applies cleanly. >> >> Benchmark results of test/micro/org/openjdk/bench/java/lang/StringCompareToDifferentLength.java correspond to original issue, 10-25% 17u improvements on Graviton 2 for long enough strings (72+ chars). >> >> Testing: tier1, tier2 (aarch64). > > I think it is actually a win for many actual aarch64 implementations. For example here is a chart for L-L string comparison on A72 (RPi4) up to length 128. Starting from size 72 there is a constant 16-17% time reduction. If we go to really long strings there which can be considred a rare use, the improvement grows to 38% for size 256 and even over 50% for size 512. > ![image](https://user-images.githubusercontent.com/31855791/153425712-1089f494-f0ae-4cb1-b5a8-f8d1a3b3eb9d.png) @dchuyko @phohensee Has this patch been approved by one of the maintainers? ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/91 From rkennke at openjdk.java.net Fri Mar 4 10:21:24 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Fri, 4 Mar 2022 10:21:24 GMT Subject: [jdk17u-dev] RFR: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations Message-ID: Hi all, This backports a fix for a memory leak in the JDWP. The original change applies cleanly: https://github.com/openjdk/jdk/commit/5ab22e88da8d79f9e19e8afffdd06206f42bab94 See issue: https://bugs.openjdk.java.net/browse/JDK-8276990 and original PR: https://github.com/openjdk/jdk/pull/7306 Thanks! ------------- Commit messages: - Backport 5ab22e88da8d79f9e19e8afffdd06206f42bab94 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/192/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=192&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276990 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/192.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/192/head:pull/192 PR: https://git.openjdk.java.net/jdk17u-dev/pull/192 From adinn at openjdk.java.net Fri Mar 4 10:30:15 2022 From: adinn at openjdk.java.net (Andrew Dinn) Date: Fri, 4 Mar 2022 10:30:15 GMT Subject: [jdk17u-dev] RFR: 8268231: Aarch64: Use Ldp in intrinsics for String.compareTo In-Reply-To: References: Message-ID: On Thu, 13 Jan 2022 14:48:40 GMT, Dmitry Chuyko wrote: > Original patch applies cleanly. > > Benchmark results of test/micro/org/openjdk/bench/java/lang/StringCompareToDifferentLength.java correspond to original issue, 10-25% 17u improvements on Graviton 2 for long enough strings (72+ chars). > > Testing: tier1, tier2 (aarch64). Ok, I see Goetz commented on the JIRA issue. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/91 From mdoerr at openjdk.java.net Fri Mar 4 11:16:35 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 4 Mar 2022 11:16:35 GMT Subject: [jdk17u-dev] RFR: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed Message-ID: Basically clean backport of JDK-8274855. Removal from ProblemList does not apply because vectorapi tests are not problem listed in 17 (JDK-8274920 not in 17). ------------- Commit messages: - Backport 5021a12ceada3192e81e2c06b556e7c80cd6cf31 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/193/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=193&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274855 Stats: 15 lines in 1 file changed: 15 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/193.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/193/head:pull/193 PR: https://git.openjdk.java.net/jdk17u-dev/pull/193 From mdoerr at openjdk.java.net Fri Mar 4 11:24:26 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 4 Mar 2022 11:24:26 GMT Subject: [jdk17u-dev] RFR: 8273804: Platform.isTieredSupported should handle the no-compiler case Message-ID: Clean backport of JDK-8273804. ------------- Commit messages: - Backport 46af82e5b0d176e340f46125f8a3bb17e56bd7b3 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/194/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=194&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273804 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/194.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/194/head:pull/194 PR: https://git.openjdk.java.net/jdk17u-dev/pull/194 From mdoerr at openjdk.java.net Fri Mar 4 11:32:23 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 4 Mar 2022 11:32:23 GMT Subject: [jdk17u-dev] RFR: 8278014: [vectorapi] Remove test run script Message-ID: Clean backport of JDK-8278014. ------------- Commit messages: - Backport 9b3e67205913daa1960373a4ab33422137082696 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/195/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=195&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278014 Stats: 161 lines in 5 files changed: 0 ins; 156 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/195.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/195/head:pull/195 PR: https://git.openjdk.java.net/jdk17u-dev/pull/195 From mdoerr at openjdk.java.net Fri Mar 4 11:40:37 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 4 Mar 2022 11:40:37 GMT Subject: [jdk17u-dev] RFR: 8278796: Incorrect behavior of FloatVector.withLane on X86 Message-ID: Clean backport of [JDK-8278796](https://bugs.openjdk.java.net/browse/JDK-8278796) ------------- Commit messages: - Backport 8494fec665bfa51d1702827bd0aa4f4547e67729 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/196/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=196&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278796 Stats: 283 lines in 34 files changed: 94 ins; 0 del; 189 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/196.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/196/head:pull/196 PR: https://git.openjdk.java.net/jdk17u-dev/pull/196 From mdoerr at openjdk.java.net Fri Mar 4 12:06:34 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 4 Mar 2022 12:06:34 GMT Subject: [jdk17u-dev] RFR: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers Message-ID: Clean Backport of JDK-8275830. ------------- Commit messages: - Backport 95a3010acf822a76bf0e1ebffdddce5d38b75e7b Changes: https://git.openjdk.java.net/jdk17u-dev/pull/197/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=197&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275830 Stats: 120 lines in 4 files changed: 92 ins; 11 del; 17 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/197.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/197/head:pull/197 PR: https://git.openjdk.java.net/jdk17u-dev/pull/197 From mdoerr at openjdk.java.net Fri Mar 4 12:18:53 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 4 Mar 2022 12:18:53 GMT Subject: [jdk17u-dev] RFR: 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN Message-ID: Clean backport of [JDK-8280123](https://bugs.openjdk.java.net/browse/JDK-8280123) ------------- Commit messages: - Backport 3f747368b9a5c321d2724ba57103f17edc166251 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/198/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=198&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280123 Stats: 93 lines in 2 files changed: 72 ins; 4 del; 17 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/198.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/198/head:pull/198 PR: https://git.openjdk.java.net/jdk17u-dev/pull/198 From burban at openjdk.java.net Fri Mar 4 12:20:30 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Fri, 4 Mar 2022 12:20:30 GMT Subject: [jdk11u-dev] RFR: 8211962: Implicit narrowing in MacOSX java.desktop jsound Message-ID: Hi all, This pull request contains a backport of commit [47e7b141](https://github.com/openjdk/jdk/commit/47e7b141c03b338ef7bbadc3c554e50c8fb210a9) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Kim Barrett on 11 Oct 2018 and was reviewed by Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport 47e7b141c03b338ef7bbadc3c554e50c8fb210a9 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/854/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=854&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8211962 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/854.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/854/head:pull/854 PR: https://git.openjdk.java.net/jdk11u-dev/pull/854 From goetz at openjdk.java.net Fri Mar 4 12:21:34 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 4 Mar 2022 12:21:34 GMT Subject: [jdk11u] RFR: 8276141: XPathFactory set/getProperty method Message-ID: I backport this for parity with 11.0.15-oracle. ------------- Commit messages: - Backport 4b2f75b0b0441e1ffb4fb3b4f789f13008c20307 Changes: https://git.openjdk.java.net/jdk11u/pull/28/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=28&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276141 Stats: 58 lines in 2 files changed: 56 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u/pull/28.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/28/head:pull/28 PR: https://git.openjdk.java.net/jdk11u/pull/28 From dchuyko at openjdk.java.net Fri Mar 4 12:45:00 2022 From: dchuyko at openjdk.java.net (Dmitry Chuyko) Date: Fri, 4 Mar 2022 12:45:00 GMT Subject: [jdk17u-dev] RFR: 8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment [v2] In-Reply-To: References: Message-ID: > This is a trivial follow-up to JDK-8268231 that puts loop alignment in the right place. It can improve the intrinsic performance on some aarch64 implementations. > > Testing: jtreg tier1, tier2, test/hotspot/jtreg/compiler/intrinsics/string on Graviton 2. Dmitry Chuyko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8279560 - Backport 126328cb6218a93d23ed6169d7e52fb2719528ed ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/191/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/191/files/5bc5c879..02eb28ae Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=191&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=191&range=00-01 Stats: 142 lines in 5 files changed: 132 ins; 2 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/191.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/191/head:pull/191 PR: https://git.openjdk.java.net/jdk17u-dev/pull/191 From duke at openjdk.java.net Fri Mar 4 13:18:24 2022 From: duke at openjdk.java.net (duke) Date: Fri, 4 Mar 2022 13:18:24 GMT Subject: [jdk18u] Withdrawn: 8278125: Some preallocated OOMEs are missing stack trace In-Reply-To: References: Message-ID: On Thu, 23 Dec 2021 13:32:04 GMT, Yi Yang wrote: > 8278125: Some preallocated OOMEs are missing stack trace This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk18u/pull/3 From goetz at openjdk.java.net Fri Mar 4 13:35:38 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 4 Mar 2022 13:35:38 GMT Subject: [jdk11u] RFR: 8277795: ldap connection timeout not honoured under contention Message-ID: I backport this for parity with 11.0.15-oracle. I had to resolve the second hunk to Connections.java due to conflicts. Final and private keywords are swapped in 18. I had to adapt the spelling of a message in the test. 11 does not capitalize the sentence "connect timed out". ------------- Commit messages: - Backport 3d926dd66ef6551e91a4ebbbc59dcff58f5ede5a Changes: https://git.openjdk.java.net/jdk11u/pull/29/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=29&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277795 Stats: 468 lines in 5 files changed: 325 ins; 72 del; 71 mod Patch: https://git.openjdk.java.net/jdk11u/pull/29.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/29/head:pull/29 PR: https://git.openjdk.java.net/jdk11u/pull/29 From dchuyko at openjdk.java.net Fri Mar 4 13:50:09 2022 From: dchuyko at openjdk.java.net (Dmitry Chuyko) Date: Fri, 4 Mar 2022 13:50:09 GMT Subject: [jdk17u-dev] Integrated: 8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 21:50:13 GMT, Dmitry Chuyko wrote: > This is a trivial follow-up to JDK-8268231 that puts loop alignment in the right place. It can improve the intrinsic performance on some aarch64 implementations. > > Testing: jtreg tier1, tier2, test/hotspot/jtreg/compiler/intrinsics/string on Graviton 2. This pull request has now been integrated. Changeset: a51a5f03 Author: Dmitry Chuyko Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk17u-dev/commit/a51a5f03a33ae1d17b951dfdc27a257a9403d488 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod 8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment Backport-of: 126328cb6218a93d23ed6169d7e52fb2719528ed ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/191 From sgehwolf at openjdk.java.net Fri Mar 4 17:40:10 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 4 Mar 2022 17:40:10 GMT Subject: [jdk11u-dev] RFR: 8230305: Cgroups v2: Container awareness In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 21:18:12 GMT, Zhengyu Gu wrote: > I would like backport cgroups v2 support to openjdk11u. > > The original patch does not apply cleanly, conflicts are resolved manually. > > Test: > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS This seems fine. A few minor comments. Aside: We need to devise a plan how we want to deal with integrating this set of patches. For example I'm seeing test failures of the hotspot container tests on a cgroups v2 system due to https://bugs.openjdk.java.net/browse/JDK-8253714. src/hotspot/os/linux/cgroupSubsystem_linux.hpp line 54: > 52: * [3] https://github.com/apache/mesos/blob/3478e344fb77d931f6122980c6e94cd3913c441d/src/docker/docker.cpp#L648 > 53: * https://github.com/apache/mesos/blob/3478e344fb77d931f6122980c6e94cd3913c441d/src/slave/containerizer/mesos/isolators/cgroups/constants.hpp#L30 > 54: */ This is essentially a backport of https://bugs.openjdk.java.net/browse/JDK-8216366. Perhaps add this issue as part of the backport (`/isssue add JDK-8216366`). src/hotspot/os/linux/osContainer_linux.hpp line 71: > 69: > 70: inline bool OSContainer::is_containerized() { > 71: assert(_is_initialized, "OSContainer not initialized"); This is essentially a backport of https://bugs.openjdk.java.net/browse/JDK-8229202 please mention that issue in the backport (`/issue add JDK-8229202`). Not sure if this will work for a backport. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/840 From zgu at openjdk.java.net Fri Mar 4 19:11:08 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Fri, 4 Mar 2022 19:11:08 GMT Subject: [jdk11u-dev] RFR: 8230305: Cgroups v2: Container awareness In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 17:37:15 GMT, Severin Gehwolf wrote: >> I would like backport cgroups v2 support to openjdk11u. >> >> The original patch does not apply cleanly, conflicts are resolved manually. >> >> Test: >> - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > > This seems fine. A few minor comments. > > Aside: We need to devise a plan how we want to deal with integrating this set of patches. For example I'm seeing test failures of the hotspot container tests on a cgroups v2 system due to https://bugs.openjdk.java.net/browse/JDK-8253714. @jerboaa Thanks for the review. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/840 From duke at openjdk.java.net Fri Mar 4 19:39:33 2022 From: duke at openjdk.java.net (Dan Lutker) Date: Fri, 4 Mar 2022 19:39:33 GMT Subject: [jdk17u-dev] RFR: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions Message-ID: ?ussian distributions Clean backport of JDK-8273056 ------------- Commit messages: - 8273056: java.util.random does not correctly sample exponential or Gaussian distributions Changes: https://git.openjdk.java.net/jdk17u-dev/pull/199/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=199&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273056 Stats: 15 lines in 1 file changed: 6 ins; 4 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/199.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/199/head:pull/199 PR: https://git.openjdk.java.net/jdk17u-dev/pull/199 From phh at openjdk.java.net Fri Mar 4 20:07:16 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 4 Mar 2022 20:07:16 GMT Subject: [jdk17u-dev] RFR: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 19:33:13 GMT, Dan Lutker wrote: > ?ussian distributions > > Clean backport of JDK-8273056 Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/199 From mdoerr at openjdk.java.net Sat Mar 5 10:20:11 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Sat, 5 Mar 2022 10:20:11 GMT Subject: [jdk17u-dev] RFR: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 19:33:13 GMT, Dan Lutker wrote: > ?ussian distributions > > Clean backport of JDK-8273056 Seems like Skara doesn't recognize this PR as backport. Also, it warns because no new branch was used. I suggest to create a new branch and a new PR with title "Backport 3d98ec1b7bc77237177ecfc069c0e9a7e75829bc" and let the Skara bot do the job (title and labels ...). ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/199 From mdoerr at openjdk.java.net Sat Mar 5 10:29:19 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Sat, 5 Mar 2022 10:29:19 GMT Subject: [jdk17u-dev] RFR: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 10:16:23 GMT, Roman Kennke wrote: > Hi all, > > This backports a fix for a memory leak in the JDWP. > The original change applies cleanly: > > https://github.com/openjdk/jdk/commit/5ab22e88da8d79f9e19e8afffdd06206f42bab94 > > See issue: > https://bugs.openjdk.java.net/browse/JDK-8276990 > and original PR: > https://github.com/openjdk/jdk/pull/7306 > > Thanks! Seems like Skara doesn't recognize this PR as backport. I suggest to change the title to "Backport 5ab22e88da8d79f9e19e8afffdd06206f42bab94" and let the Skara bot do the necessary updates. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/192 From andrew at openjdk.java.net Sat Mar 5 17:09:55 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Sat, 5 Mar 2022 17:09:55 GMT Subject: [jdk11u-dev] RFR: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32 In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 08:00:43 GMT, Goetz Lindenmaier wrote: > [~gnu-andrew] Shouldn't this go to jdk11u via critical request now? Rampdown started last Tuesday. No, there's nothing critical about this. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/839 From pkumaraswamy at openjdk.java.net Mon Mar 7 05:40:41 2022 From: pkumaraswamy at openjdk.java.net (Prajwal Kumaraswamy) Date: Mon, 7 Mar 2022 05:40:41 GMT Subject: [jdk18u] RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake Message-ID: This is a clean backport. The fix has been confirmed by running against internal test suite and JCK SSL tests, where the initial failure was observed in test api/javax_net/ssl/SSLSocket/setUseClientMode.html ------------- Commit messages: - Backport 58dae60da0711c4ae0cb23f8ce2328e051d603b2 Changes: https://git.openjdk.java.net/jdk18u/pull/33/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=33&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274524 Stats: 151 lines in 2 files changed: 151 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/33.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/33/head:pull/33 PR: https://git.openjdk.java.net/jdk18u/pull/33 From mdoerr at openjdk.java.net Mon Mar 7 09:23:12 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 7 Mar 2022 09:23:12 GMT Subject: [jdk11u-dev] RFR: JDK-8282588: [11] set harfbuzz compilation flag to -std=c++11 In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 08:40:59 GMT, Matthias Baesken wrote: > As a preparation to update harfbuzz in jdk11u-dev to the versions used in higher JDK (harfbuzz 2.7.2 / 2.8.0) increment the C++ version > for harfbuzz to C++11. > Some time later, the harfbuzz changes are backported. > This gives everybody time to make sure the compilers work with the C++11 flag, or system harfbuzz is used as a workaround. LGTM. I had added the flag in the same file when creating my experimental JDK-8247872 backport http://cr.openjdk.java.net/~mdoerr/8247872_harfbuzz_11u/ ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/853 From goetz at openjdk.java.net Mon Mar 7 10:41:58 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Mar 2022 10:41:58 GMT Subject: [jdk11u-dev] RFR: 8179503: Java should support GET OCSP calls [v2] In-Reply-To: <861H92b5UmmXqVXSRFATJy06EI1meeKW1-Ym7V_RjKE=.9e8b993b-d18f-46a1-a7fb-049c3d2f87eb@github.com> References: <861H92b5UmmXqVXSRFATJy06EI1meeKW1-Ym7V_RjKE=.9e8b993b-d18f-46a1-a7fb-049c3d2f87eb@github.com> Message-ID: On Wed, 2 Mar 2022 14:06:44 GMT, Alexey Pavlyutkin wrote: >> Hello! I'd like to backport >> >> 8179503: Java should support GET OCSP calls (dependency) >> >> to jdk11u-dev. This one is required as a dependency for >> >> 8274471: Add support for RSASSA-PSS in OCSP Response >> >> The following changes were done to apply original patch: >> >> src/java.base/share/classes/sun/security/provider/certpath/OCSP.java >> >> - resolved baseline conflict taking place due to absent revocation checking code >> >> The rest of the code applied without changes >> >> Verification/regression (20.04/amd64): jdk_security > > Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: > > reverts copyright year Please configure Pre-submit tests. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/847 From mdoerr at openjdk.java.net Mon Mar 7 10:51:29 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 7 Mar 2022 10:51:29 GMT Subject: [jdk17u-dev] Integrated: 8273804: Platform.isTieredSupported should handle the no-compiler case In-Reply-To: References: Message-ID: <4LID68lS76sUau3hNhZWTFn0YxhUly194aoc1HNTv9Q=.1093019a-a2ee-4c1d-81e1-55a43fb02e21@github.com> On Fri, 4 Mar 2022 11:15:34 GMT, Martin Doerr wrote: > Clean backport of JDK-8273804. This pull request has now been integrated. Changeset: 3aa5b510 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/3aa5b5100a92c43ddf311f513718cf5ee4ab7551 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8273804: Platform.isTieredSupported should handle the no-compiler case Backport-of: 46af82e5b0d176e340f46125f8a3bb17e56bd7b3 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/194 From mdoerr at openjdk.java.net Mon Mar 7 10:53:26 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 7 Mar 2022 10:53:26 GMT Subject: [jdk17u-dev] Integrated: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 11:57:25 GMT, Martin Doerr wrote: > Clean Backport of JDK-8275830. This pull request has now been integrated. Changeset: 47723c20 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/47723c20278ac03015e0ae50e2e87b2fc7ce0049 Stats: 120 lines in 4 files changed: 92 ins; 11 del; 17 mod 8275830: C2: Receiver downcast is missing when inlining through method handle linkers Backport-of: 95a3010acf822a76bf0e1ebffdddce5d38b75e7b ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/197 From mdoerr at openjdk.java.net Mon Mar 7 10:53:29 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 7 Mar 2022 10:53:29 GMT Subject: [jdk17u-dev] Integrated: 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 12:09:28 GMT, Martin Doerr wrote: > Clean backport of [JDK-8280123](https://bugs.openjdk.java.net/browse/JDK-8280123) This pull request has now been integrated. Changeset: 1fc280c2 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/1fc280c2b1df4e8dab8b10bb00df254ee1a83b36 Stats: 93 lines in 2 files changed: 72 ins; 4 del; 17 mod 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN Backport-of: 3f747368b9a5c321d2724ba57103f17edc166251 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/198 From mdoerr at openjdk.java.net Mon Mar 7 10:55:16 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 7 Mar 2022 10:55:16 GMT Subject: [jdk17u-dev] Integrated: 8278014: [vectorapi] Remove test run script In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 11:21:58 GMT, Martin Doerr wrote: > Clean backport of JDK-8278014. This pull request has now been integrated. Changeset: b3aa42d1 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/b3aa42d1cab3734b3acf76f7d0d93e27722a5097 Stats: 161 lines in 5 files changed: 0 ins; 156 del; 5 mod 8278014: [vectorapi] Remove test run script Backport-of: 9b3e67205913daa1960373a4ab33422137082696 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/195 From mdoerr at openjdk.java.net Mon Mar 7 10:59:25 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 7 Mar 2022 10:59:25 GMT Subject: [jdk17u-dev] Integrated: 8278796: Incorrect behavior of FloatVector.withLane on X86 In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 11:31:43 GMT, Martin Doerr wrote: > Clean backport of [JDK-8278796](https://bugs.openjdk.java.net/browse/JDK-8278796) This pull request has now been integrated. Changeset: ec2c521c Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/ec2c521ca75c30c4a26c2db9df14990f9fb471a8 Stats: 283 lines in 34 files changed: 94 ins; 0 del; 189 mod 8278796: Incorrect behavior of FloatVector.withLane on X86 Backport-of: 8494fec665bfa51d1702827bd0aa4f4547e67729 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/196 From mdoerr at openjdk.java.net Mon Mar 7 11:17:16 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 7 Mar 2022 11:17:16 GMT Subject: [jdk17u-dev] Integrated: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed In-Reply-To: References: Message-ID: <8c9RKj0Kv6OzFT3BrE2L8q_j8nw-XpEwM3HFXl1uvnA=.c5fe9269-34fe-4f8d-80fc-2e9dd1005069@github.com> On Fri, 4 Mar 2022 11:07:47 GMT, Martin Doerr wrote: > Basically clean backport of JDK-8274855. Removal from ProblemList does not apply because vectorapi tests are not problem listed in 17 (JDK-8274920 not in 17). This pull request has now been integrated. Changeset: 91e93446 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/91e9344624def4242a7a529edd9cdf07216d7318 Stats: 15 lines in 1 file changed: 15 ins; 0 del; 0 mod 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed Backport-of: 5021a12ceada3192e81e2c06b556e7c80cd6cf31 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/193 From mbaesken at openjdk.java.net Mon Mar 7 11:27:10 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Mon, 7 Mar 2022 11:27:10 GMT Subject: [jdk11u] RFR: 8277795: ldap connection timeout not honoured under contention In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 13:23:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. > > I had to resolve the second hunk to Connections.java due to conflicts. > Final and private keywords are swapped in 18. > I had to adapt the spelling of a message in the test. 11 does not > capitalize the sentence "connect timed out". Marked as reviewed by mbaesken (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u/pull/29 From coffeys at openjdk.java.net Mon Mar 7 11:38:49 2022 From: coffeys at openjdk.java.net (Sean Coffey) Date: Mon, 7 Mar 2022 11:38:49 GMT Subject: [jdk18u] RFR: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method Message-ID: backport to jdk18u ------------- Commit messages: - Backport 1f1db838ab7d427170d59a8b55fdb45c4d80c359 Changes: https://git.openjdk.java.net/jdk18u/pull/34/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=34&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278186 Stats: 75 lines in 4 files changed: 66 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jdk18u/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/34/head:pull/34 PR: https://git.openjdk.java.net/jdk18u/pull/34 From coffeys at openjdk.java.net Mon Mar 7 11:43:16 2022 From: coffeys at openjdk.java.net (Sean Coffey) Date: Mon, 7 Mar 2022 11:43:16 GMT Subject: [jdk18u] Integrated: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 11:30:23 GMT, Sean Coffey wrote: > backport to jdk18u This pull request has now been integrated. Changeset: 32c0aa29 Author: Sean Coffey URL: https://git.openjdk.java.net/jdk18u/commit/32c0aa29ffc44b4afdc5621b69d9541aff547aac Stats: 75 lines in 4 files changed: 66 ins; 0 del; 9 mod 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method Backport-of: 1f1db838ab7d427170d59a8b55fdb45c4d80c359 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/34 From mbaesken at openjdk.java.net Mon Mar 7 11:45:04 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Mon, 7 Mar 2022 11:45:04 GMT Subject: [jdk11u-dev] Integrated: JDK-8282588: [11] set harfbuzz compilation flag to -std=c++11 In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 08:40:59 GMT, Matthias Baesken wrote: > As a preparation to update harfbuzz in jdk11u-dev to the versions used in higher JDK (harfbuzz 2.7.2 / 2.8.0) increment the C++ version > for harfbuzz to C++11. > Some time later, the harfbuzz changes are backported. > This gives everybody time to make sure the compilers work with the C++11 flag, or system harfbuzz is used as a workaround. This pull request has now been integrated. Changeset: 86d39a69 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/86d39a69598a4ee559109b46a5b8fa91ae2e2723 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8282588: [11] set harfbuzz compilation flag to -std=c++11 Reviewed-by: mdoerr ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/853 From goetz at openjdk.java.net Mon Mar 7 12:41:06 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Mar 2022 12:41:06 GMT Subject: [jdk11u] Integrated: 8276141: XPathFactory set/getProperty method In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 12:13:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. This pull request has now been integrated. Changeset: e3391113 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u/commit/e339111366210c5d1d2fc6d929493bf3753460ca Stats: 58 lines in 2 files changed: 56 ins; 0 del; 2 mod 8276141: XPathFactory set/getProperty method Backport-of: 4b2f75b0b0441e1ffb4fb3b4f789f13008c20307 ------------- PR: https://git.openjdk.java.net/jdk11u/pull/28 From goetz at openjdk.java.net Mon Mar 7 12:55:13 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Mar 2022 12:55:13 GMT Subject: [jdk11u] RFR: 8277795: ldap connection timeout not honoured under contention In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 13:23:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. > > I had to resolve the second hunk to Connections.java due to conflicts. > Final and private keywords are swapped in 18. > I had to adapt the spelling of a message in the test. 11 does not > capitalize the sentence "connect timed out". Mac pre-submit failure: Error. Agent error: java.lang.Exception: Agent 38 timed out unrelated. linux pre-submit failure: macroAssembler_x86.cpp # assert(false) failed: DEBUG MESSAGE: exception oop already set Also unrelated. ------------- PR: https://git.openjdk.java.net/jdk11u/pull/29 From goetz at openjdk.java.net Mon Mar 7 12:55:14 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Mar 2022 12:55:14 GMT Subject: [jdk11u] Integrated: 8277795: ldap connection timeout not honoured under contention In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 13:23:20 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. > > I had to resolve the second hunk to Connections.java due to conflicts. > Final and private keywords are swapped in 18. > I had to adapt the spelling of a message in the test. 11 does not > capitalize the sentence "connect timed out". This pull request has now been integrated. Changeset: 1cff5631 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u/commit/1cff5631dcd0a122715a06be38894cd7bff2bcec Stats: 468 lines in 5 files changed: 325 ins; 72 del; 71 mod 8277795: ldap connection timeout not honoured under contention Reviewed-by: mbaesken Backport-of: 3d926dd66ef6551e91a4ebbbc59dcff58f5ede5a ------------- PR: https://git.openjdk.java.net/jdk11u/pull/29 From mdoerr at openjdk.java.net Mon Mar 7 13:14:43 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 7 Mar 2022 13:14:43 GMT Subject: [jdk17u-dev] RFR: 8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert Message-ID: Clean Backport of JDK-8275638. Should get backported together with JDK-8278966. ------------- Commit messages: - Backport b9a477bf19d9f276f6b1da8984eb56d7bd5fc137 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/200/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=200&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275638 Stats: 117 lines in 3 files changed: 117 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/200.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/200/head:pull/200 PR: https://git.openjdk.java.net/jdk17u-dev/pull/200 From mdoerr at openjdk.java.net Mon Mar 7 13:19:46 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 7 Mar 2022 13:19:46 GMT Subject: [jdk17u-dev] RFR: 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638 Message-ID: Clean Backport of JDK-8278966 on top of JDK-8275638. ------------- Depends on: https://git.openjdk.java.net/jdk17u-dev/pull/200 Commit messages: - Backport e7244c19f4e24698ab074da530bf6c403f0e22cd Changes: https://git.openjdk.java.net/jdk17u-dev/pull/201/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=201&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278966 Stats: 31 lines in 2 files changed: 29 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/201.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/201/head:pull/201 PR: https://git.openjdk.java.net/jdk17u-dev/pull/201 From mdoerr at openjdk.java.net Mon Mar 7 13:34:53 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 7 Mar 2022 13:34:53 GMT Subject: [jdk17u-dev] RFR: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL Message-ID: Clean backport of [JDK-8265317](https://bugs.openjdk.java.net/browse/JDK-8265317) ------------- Commit messages: - Backport 58b5fb3233a9bbbfc1f1f8818be4dfd54325f1bd Changes: https://git.openjdk.java.net/jdk17u-dev/pull/202/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=202&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265317 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/202.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/202/head:pull/202 PR: https://git.openjdk.java.net/jdk17u-dev/pull/202 From mdoerr at openjdk.java.net Mon Mar 7 13:43:42 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 7 Mar 2022 13:43:42 GMT Subject: [jdk17u-dev] RFR: 8278948: compiler/vectorapi/reshape/TestVectorCastAVX1.java crashes in assembler Message-ID: Clean backport of [JDK-8278948](https://bugs.openjdk.java.net/browse/JDK-8278948) ------------- Commit messages: - Backport f8f9148016662578804479180a70e3732b08c11c Changes: https://git.openjdk.java.net/jdk17u-dev/pull/203/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=203&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278948 Stats: 100 lines in 2 files changed: 85 ins; 8 del; 7 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/203.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/203/head:pull/203 PR: https://git.openjdk.java.net/jdk17u-dev/pull/203 From goetz at openjdk.java.net Mon Mar 7 15:07:31 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Mar 2022 15:07:31 GMT Subject: [jdk11u-dev] RFR: 8208246: flags duplications in vmTestbase_vm_g1classunloading tests Message-ID: <-cEjMwFhm6Bb8Eyz0PnYQVbbxS9FvmtUgwoHVf6M8hE=.d788c858-36e8-4b59-b739-e6307b96dd56@github.com> I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport b184fceaa00be64862e9a7a0b04a1f0ce819c821 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/857/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=857&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8208246 Stats: 784 lines in 112 files changed: 0 ins; 784 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/857.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/857/head:pull/857 PR: https://git.openjdk.java.net/jdk11u-dev/pull/857 From goetz at openjdk.java.net Mon Mar 7 17:00:35 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Mar 2022 17:00:35 GMT Subject: [jdk11u-dev] RFR: 8208249: TriggerUnloadingByFillingMetaspace generates garbage class names Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 3d94ce71b5c379627406b3c889058d49bd5b7622 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/858/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=858&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8208249 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/858.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/858/head:pull/858 PR: https://git.openjdk.java.net/jdk11u-dev/pull/858 From duke at openjdk.java.net Mon Mar 7 17:03:24 2022 From: duke at openjdk.java.net (Dan Lutker) Date: Mon, 7 Mar 2022 17:03:24 GMT Subject: [jdk17u-dev] Withdrawn: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions In-Reply-To: References: Message-ID: <9hkFWpoPaO8kdT9cln2iHhTCaCmBUCQwkRT-QvwBz8Q=.c1fd86ba-eeac-40e9-97ef-894d2e872cd1@github.com> On Fri, 4 Mar 2022 19:33:13 GMT, Dan Lutker wrote: > ?ussian distributions > > Clean backport of JDK-8273056 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/199 From duke at openjdk.java.net Mon Mar 7 17:11:44 2022 From: duke at openjdk.java.net (Dan Lutker) Date: Mon, 7 Mar 2022 17:11:44 GMT Subject: [jdk17u-dev] RFR: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions In-Reply-To: <-nZS2bb-cO5AOu_LXPC7CKOlyuMi7r9HQnU5sF-ewQs=.ebe6da90-9f2d-4244-a630-efce89fafb24@github.com> References: <-nZS2bb-cO5AOu_LXPC7CKOlyuMi7r9HQnU5sF-ewQs=.ebe6da90-9f2d-4244-a630-efce89fafb24@github.com> Message-ID: On Mon, 7 Mar 2022 17:02:58 GMT, Dan Lutker wrote: > Clean backport of `8273056: java.util.random does not correctly sample exponential or Gaussian distributions` Same as https://github.com/openjdk/jdk17u-dev/pull/199 but with a branch and correct title as per @TheRealMDoerr's comments. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/204 From duke at openjdk.java.net Mon Mar 7 17:11:44 2022 From: duke at openjdk.java.net (Dan Lutker) Date: Mon, 7 Mar 2022 17:11:44 GMT Subject: [jdk17u-dev] RFR: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions Message-ID: <-nZS2bb-cO5AOu_LXPC7CKOlyuMi7r9HQnU5sF-ewQs=.ebe6da90-9f2d-4244-a630-efce89fafb24@github.com> Clean backport of `8273056: java.util.random does not correctly sample exponential or Gaussian distributions` ------------- Commit messages: - 8273056: java.util.random does not correctly sample exponential or Gaussian distributions Changes: https://git.openjdk.java.net/jdk17u-dev/pull/204/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=204&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273056 Stats: 15 lines in 1 file changed: 6 ins; 4 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/204.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/204/head:pull/204 PR: https://git.openjdk.java.net/jdk17u-dev/pull/204 From goetz at openjdk.java.net Mon Mar 7 19:27:30 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 7 Mar 2022 19:27:30 GMT Subject: [jdk11u-dev] RFR: 8212151: jdi/ExclusiveBind.java times out due to "bind failed: Address already in use" on Solaris-X64 Message-ID: <8fYoJXpa8lwEaVURysIQo1ye8Up5_xRHnrZOnVn_rXU=.28cb010f-9153-4dbf-8bee-ec8f2c8e77d4@github.com> I backport this for parity with 11.0.16-oracle. I had to resolve the whole change because it is one hunk that does not apply because changes to the test description are not backported (8210112: remove jdk.testlibrary.ProcessTools; 8210732: remove jdk.testlibrary.Utils) I resolved the test to be the same as head. ------------- Commit messages: - Backport b4cb7d6fc7237e6f25ec876887c66d62f1cd6214 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/859/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=859&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8212151 Stats: 332 lines in 3 files changed: 191 ins; 109 del; 32 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/859.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/859/head:pull/859 PR: https://git.openjdk.java.net/jdk11u-dev/pull/859 From duke at openjdk.java.net Mon Mar 7 22:13:31 2022 From: duke at openjdk.java.net (Joshua Cao) Date: Mon, 7 Mar 2022 22:13:31 GMT Subject: [jdk11u-dev] RFR: 8258956: Memory Leak in StringCoding on ThreadLocal resultCached StringCoding.Result Message-ID: <-xLw7Q1R06MXI2gbG7ZxMyS1z_kTP12lXxd2R21NH4A=.ee97b975-83db-48fc-b6fc-eb5d60ebfd8c@github.com> One rejected hunk on the copyright year: diff a/src/java.base/share/classes/java/lang/StringCoding.java b/src/java.base/share/classes/java/lang/StringCoding.java (rejected hunks) @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it Otherwise, this is a clean backport. ------------- Commit messages: - Merge branch 'openjdk:master' into 8258956 - 8258956: Memory Leak in StringCoding on ThreadLocal resultCached StringCoding.Result Changes: https://git.openjdk.java.net/jdk11u-dev/pull/860/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=860&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258956 Stats: 17 lines in 1 file changed: 9 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/860.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/860/head:pull/860 PR: https://git.openjdk.java.net/jdk11u-dev/pull/860 From duke at openjdk.java.net Tue Mar 8 02:03:04 2022 From: duke at openjdk.java.net (wxiang) Date: Tue, 8 Mar 2022 02:03:04 GMT Subject: [jdk11u-dev] RFR: 8261090: Store old classfiles in static CDS archive Message-ID: 8261090: Store old classfiles in static CDS archive ------------- Commit messages: - remove whitespace and add requires - Backport 8261090: Store old classfiles in static CDS archive Changes: https://git.openjdk.java.net/jdk11u-dev/pull/856/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=856&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261090 Stats: 565 lines in 25 files changed: 498 ins; 27 del; 40 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/856.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/856/head:pull/856 PR: https://git.openjdk.java.net/jdk11u-dev/pull/856 From goetz at openjdk.java.net Tue Mar 8 08:09:36 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 8 Mar 2022 08:09:36 GMT Subject: [jdk11u] RFR: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem Message-ID: I backport this for parity with 11.0.15-oracle. The code touched was completely reworked in jdk15 by "8228336: Refactor native library loading implementation" make/test/JtregNativeJdk.gmk Trivial resolve due to context. src/hotspot/share/prims/jvm.cpp Applies clean, but does not compile. I removed "log_info(library)("Failed to load library %s", name);" Logging was only added to this file in jdk15 with "8187305: Add logging for shared library loads/unloads" Changes to src/java.base/macosx/classes/jdk/internal/loader/ClassLoaderHelper.java applied to src/java.base/macosx/classes/java/lang/ClassLoaderHelper.java Fits well. Changes to src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java applied to class NativeLibrary in java/lang/ClassLoader.java. I had to modify the code. Changes to src/java.base/share/native/libjava/NativeLibraries.c applied to src/java.base/share/native/libjava/ClassLoader.c Fits acceptable. Changes to src/java.base/unix/classes/jdk/internal/loader/ClassLoaderHelper.java applied to src/java.base/unix/classes/java/lang/ClassLoaderHelper.java Fits well. Changes to src/java.base/windows/classes/jdk/internal/loader/ClassLoaderHelper.java applied to src/java.base/windows/classes/java/lang/ClassLoaderHelper.java Fits well. SAP testing passed. ------------- Commit messages: - Backport 6aa02d75d9f26f46fbdb54aef52cea3257aa7462 Changes: https://git.openjdk.java.net/jdk11u/pull/30/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=30&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275703 Stats: 189 lines in 10 files changed: 167 ins; 0 del; 22 mod Patch: https://git.openjdk.java.net/jdk11u/pull/30.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/30/head:pull/30 PR: https://git.openjdk.java.net/jdk11u/pull/30 From goetz at openjdk.java.net Tue Mar 8 08:22:08 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 8 Mar 2022 08:22:08 GMT Subject: [jdk11u-dev] RFR: 8208246: flags duplications in vmTestbase_vm_g1classunloading tests In-Reply-To: <-cEjMwFhm6Bb8Eyz0PnYQVbbxS9FvmtUgwoHVf6M8hE=.d788c858-36e8-4b59-b739-e6307b96dd56@github.com> References: <-cEjMwFhm6Bb8Eyz0PnYQVbbxS9FvmtUgwoHVf6M8hE=.d788c858-36e8-4b59-b739-e6307b96dd56@github.com> Message-ID: On Mon, 7 Mar 2022 14:58:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Pre-submit failures: some build dependencies are missing. Unrelated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/857 From goetz at openjdk.java.net Tue Mar 8 08:23:59 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 8 Mar 2022 08:23:59 GMT Subject: [jdk11u-dev] RFR: 8208249: TriggerUnloadingByFillingMetaspace generates garbage class names In-Reply-To: References: Message-ID: <6-wzSVOL-Q4lgOjNPckXFqT2MJrqIgyB0ZbN4SUk9bc=.3891e067-4ee3-42d9-ae5f-8cac2634da9b@github.com> On Mon, 7 Mar 2022 16:51:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Pre-submit failures: some build dependencies were missing. Unrelated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/858 From aleonard at openjdk.java.net Tue Mar 8 08:49:49 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 8 Mar 2022 08:49:49 GMT Subject: [jdk17u-dev] RFR: 8279182: MakeZipReproducible ZipEntry timestamps not localized to UTC Message-ID: This patch is for reproducible builds whereby the reproducible src.zip timestamps where not being localized to UTC, hence src.zip differed depending on what local timezone was set to. ------------- Commit messages: - Backport bc0466c7ca57f14b1e6285e2a39755d57c8de376 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/205/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=205&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279182 Stats: 11 lines in 1 file changed: 6 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/205.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/205/head:pull/205 PR: https://git.openjdk.java.net/jdk17u-dev/pull/205 From goetz at openjdk.java.net Tue Mar 8 08:59:16 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 8 Mar 2022 08:59:16 GMT Subject: [jdk17u-dev] RFR: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions In-Reply-To: <-nZS2bb-cO5AOu_LXPC7CKOlyuMi7r9HQnU5sF-ewQs=.ebe6da90-9f2d-4244-a630-efce89fafb24@github.com> References: <-nZS2bb-cO5AOu_LXPC7CKOlyuMi7r9HQnU5sF-ewQs=.ebe6da90-9f2d-4244-a630-efce89fafb24@github.com> Message-ID: On Mon, 7 Mar 2022 17:02:58 GMT, Dan Lutker wrote: > Clean backport of `8273056: java.util.random does not correctly sample exponential or Gaussian distributions` Hi @Pr0methean @lutkerd please make yourself familiar with the OpenJDK and jdk11u upedates project rules. You might want to start reading here: https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/204 From duke at openjdk.java.net Tue Mar 8 11:29:11 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Tue, 8 Mar 2022 11:29:11 GMT Subject: [jdk11u-dev] RFR: 8179503: Java should support GET OCSP calls [v2] In-Reply-To: References: <861H92b5UmmXqVXSRFATJy06EI1meeKW1-Ym7V_RjKE=.9e8b993b-d18f-46a1-a7fb-049c3d2f87eb@github.com> Message-ID: On Mon, 7 Mar 2022 10:39:01 GMT, Goetz Lindenmaier wrote: >> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: >> >> reverts copyright year > > Please configure Pre-submit tests. @GoeLin I've configured pre-submit tests, but they constantly fail on cross-compilation for different target architectures due to absense of required packages. Is that my fault, should I do something else? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/847 From aleonard at openjdk.java.net Tue Mar 8 11:45:40 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 8 Mar 2022 11:45:40 GMT Subject: [jdk17u-dev] RFR: 8275745: Reproducible copyright headers Message-ID: The copyright headers are generated at build time, and the year inserted in the template depends on the current date. This means the headers are not reproducible if the project is built a year later. This PR uses the year derived from the SOURCE_DATE_EPOCH environment variable to make the build reproducible (this variable is already used in other parts of the build). ------------- Commit messages: - Backport a0227965bb8d1d49718794d67f8a4cfeebc9bec2 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/206/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=206&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275745 Stats: 53 lines in 8 files changed: 33 ins; 11 del; 9 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/206.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/206/head:pull/206 PR: https://git.openjdk.java.net/jdk17u-dev/pull/206 From mbaesken at openjdk.java.net Tue Mar 8 12:45:10 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 8 Mar 2022 12:45:10 GMT Subject: [jdk11u] RFR: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 07:59:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. > > The code touched was completely reworked in jdk15 by "8228336: Refactor native library loading implementation" > > make/test/JtregNativeJdk.gmk > Trivial resolve due to context. > > src/hotspot/share/prims/jvm.cpp > Applies clean, but does not compile. > I removed "log_info(library)("Failed to load library %s", name);" > Logging was only added to this file in jdk15 with "8187305: Add logging for shared library loads/unloads" > > Changes to > src/java.base/macosx/classes/jdk/internal/loader/ClassLoaderHelper.java > applied to > src/java.base/macosx/classes/java/lang/ClassLoaderHelper.java > Fits well. > > Changes to > src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java > applied to class NativeLibrary in java/lang/ClassLoader.java. > I had to modify the code. > > Changes to > src/java.base/share/native/libjava/NativeLibraries.c > applied to > src/java.base/share/native/libjava/ClassLoader.c > Fits acceptable. > > Changes to > src/java.base/unix/classes/jdk/internal/loader/ClassLoaderHelper.java > applied to > src/java.base/unix/classes/java/lang/ClassLoaderHelper.java > Fits well. > > Changes to > src/java.base/windows/classes/jdk/internal/loader/ClassLoaderHelper.java > applied to > src/java.base/windows/classes/java/lang/ClassLoaderHelper.java > Fits well. > > SAP testing passed. Looks good mostly. Minor comments (leave it to you if you want to add) src/hotspot/share/prims/jvm.cpp Instead of log_info(library)("Failed to load library %s", name); we could use log_info(os)("Failed to load library %s", name); The comment from src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java * Load a native library from the given file. Returns null if the given * library is determined to be non-loadable, which is system-dependent. could be added to src/java.base/share/classes/java/lang/ClassLoader.java at an approriate place. ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.java.net/jdk11u/pull/30 From mdoerr at openjdk.java.net Tue Mar 8 13:50:25 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Mar 2022 13:50:25 GMT Subject: [jdk11u-dev] RFR: 8223143: Restructure/clean-up for 'loopexit_or_null()'. Message-ID: Clean backport of JDK-8223143. ------------- Commit messages: - Backport 8088ed83178ef8b0e4be6d510f28bd6bb1beecc8 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/861/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=861&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8223143 Stats: 42 lines in 1 file changed: 23 ins; 1 del; 18 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/861.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/861/head:pull/861 PR: https://git.openjdk.java.net/jdk11u-dev/pull/861 From rkennke at openjdk.java.net Tue Mar 8 15:09:25 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Tue, 8 Mar 2022 15:09:25 GMT Subject: [jdk18u] Integrated: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations In-Reply-To: References: Message-ID: On Wed, 2 Mar 2022 19:06:11 GMT, Roman Kennke wrote: > Hi all, > > This backports a fix for a memory leak in the JDWP. > The original change applies cleanly: > > https://github.com/openjdk/jdk/commit/5ab22e88da8d79f9e19e8afffdd06206f42bab94 > > See issue: > https://bugs.openjdk.java.net/browse/JDK-8276990 > and original PR: > https://github.com/openjdk/jdk/pull/7306 > > Thanks! This pull request has now been integrated. Changeset: 16ff0561 Author: Roman Kennke URL: https://git.openjdk.java.net/jdk18u/commit/16ff0561589755ec74747a0e242298849216f0c8 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations Backport-of: 5ab22e88da8d79f9e19e8afffdd06206f42bab94 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/32 From rkennke at openjdk.java.net Tue Mar 8 15:11:04 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Tue, 8 Mar 2022 15:11:04 GMT Subject: [jdk11u-dev] Integrated: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations In-Reply-To: <8_1oUjbRhcoaVKjhtHAQfYp4ZbY2l5itdNWceegkdkY=.5db98b2b-8066-449b-9bc9-a532781b2865@github.com> References: <8_1oUjbRhcoaVKjhtHAQfYp4ZbY2l5itdNWceegkdkY=.5db98b2b-8066-449b-9bc9-a532781b2865@github.com> Message-ID: <6pVpjJ4warzTmMobpGDHSUe9EbUUxW09AkPFM1R49Lc=.550cc7d3-f8a4-4c4b-b10b-b190677fd0d2@github.com> On Thu, 3 Mar 2022 19:05:25 GMT, Roman Kennke wrote: > Hi all, > > This backports a fix for a memory leak in the JDWP. > The original change applies cleanly: > > https://github.com/openjdk/jdk/commit/5ab22e88da8d79f9e19e8afffdd06206f42bab94 > > See issue: > https://bugs.openjdk.java.net/browse/JDK-8276990 > and original PR: > https://github.com/openjdk/jdk/pull/7306 > > Thanks! This pull request has now been integrated. Changeset: 4b9bba66 Author: Roman Kennke URL: https://git.openjdk.java.net/jdk11u-dev/commit/4b9bba662d25dec914fcd36f4b50be4b77401f08 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations Backport-of: 5ab22e88da8d79f9e19e8afffdd06206f42bab94 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/852 From rkennke at openjdk.java.net Tue Mar 8 15:11:12 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Tue, 8 Mar 2022 15:11:12 GMT Subject: [jdk17u-dev] Integrated: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 10:16:23 GMT, Roman Kennke wrote: > Hi all, > > This backports a fix for a memory leak in the JDWP. > The original change applies cleanly: > > https://github.com/openjdk/jdk/commit/5ab22e88da8d79f9e19e8afffdd06206f42bab94 > > See issue: > https://bugs.openjdk.java.net/browse/JDK-8276990 > and original PR: > https://github.com/openjdk/jdk/pull/7306 > > Thanks! This pull request has now been integrated. Changeset: e2103de4 Author: Roman Kennke URL: https://git.openjdk.java.net/jdk17u-dev/commit/e2103de4896e9c4662fbac78a70747f57de7ab2a Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations Backport-of: 5ab22e88da8d79f9e19e8afffdd06206f42bab94 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/192 From mdoerr at openjdk.java.net Tue Mar 8 16:06:38 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Mar 2022 16:06:38 GMT Subject: [jdk11u-dev] RFR: 8279837: C2: assert(is_Loop()) failed: invalid node class: Region Message-ID: Clean backport of JDK-8279837. ------------- Commit messages: - Backport 65eb066b630b892f22492457e0f86165e5ef4765 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/862/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=862&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279837 Stats: 87 lines in 2 files changed: 87 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/862.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/862/head:pull/862 PR: https://git.openjdk.java.net/jdk11u-dev/pull/862 From goetz at openjdk.java.net Tue Mar 8 17:03:17 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 8 Mar 2022 17:03:17 GMT Subject: [jdk11u] RFR: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 07:59:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. > > The code touched was completely reworked in jdk15 by "8228336: Refactor native library loading implementation" > > make/test/JtregNativeJdk.gmk > Trivial resolve due to context. > > src/hotspot/share/prims/jvm.cpp > Applies clean, but does not compile. > I removed "log_info(library)("Failed to load library %s", name);" > Logging was only added to this file in jdk15 with "8187305: Add logging for shared library loads/unloads" > > Changes to > src/java.base/macosx/classes/jdk/internal/loader/ClassLoaderHelper.java > applied to > src/java.base/macosx/classes/java/lang/ClassLoaderHelper.java > Fits well. > > Changes to > src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java > applied to class NativeLibrary in java/lang/ClassLoader.java. > I had to modify the code. > > Changes to > src/java.base/share/native/libjava/NativeLibraries.c > applied to > src/java.base/share/native/libjava/ClassLoader.c > Fits acceptable. > > Changes to > src/java.base/unix/classes/jdk/internal/loader/ClassLoaderHelper.java > applied to > src/java.base/unix/classes/java/lang/ClassLoaderHelper.java > Fits well. > > Changes to > src/java.base/windows/classes/jdk/internal/loader/ClassLoaderHelper.java > applied to > src/java.base/windows/classes/java/lang/ClassLoaderHelper.java > Fits well. > > SAP testing passed. Thanks for the review! I think adding the log output is a bit lost, as all the related logs are missing in 11, as e.g. "Loaded library %s" "Unloaded library with handle " As for the comment ... I did not find an appropriate place. The code is split into several classes after the reengineering. Pre-submit failures: dependencies missing ------------- PR: https://git.openjdk.java.net/jdk11u/pull/30 From goetz at openjdk.java.net Tue Mar 8 17:08:02 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 8 Mar 2022 17:08:02 GMT Subject: [jdk11u-dev] RFR: 8212151: jdi/ExclusiveBind.java times out due to "bind failed: Address already in use" on Solaris-X64 In-Reply-To: <8fYoJXpa8lwEaVURysIQo1ye8Up5_xRHnrZOnVn_rXU=.28cb010f-9153-4dbf-8bee-ec8f2c8e77d4@github.com> References: <8fYoJXpa8lwEaVURysIQo1ye8Up5_xRHnrZOnVn_rXU=.28cb010f-9153-4dbf-8bee-ec8f2c8e77d4@github.com> Message-ID: On Mon, 7 Mar 2022 19:21:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to resolve the whole change because it is one hunk that does not apply because changes to the test description are not backported (8210112: remove jdk.testlibrary.ProcessTools; 8210732: remove jdk.testlibrary.Utils) > > I resolved the test to be the same as head. Pre-submit failures: StopAtExit test. Fails in various presubmit runs. Unrelated Others miss their build dependencies. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/859 From duke at openjdk.java.net Tue Mar 8 17:35:25 2022 From: duke at openjdk.java.net (Dan Lutker) Date: Tue, 8 Mar 2022 17:35:25 GMT Subject: [jdk17u-dev] Integrated: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions In-Reply-To: <-nZS2bb-cO5AOu_LXPC7CKOlyuMi7r9HQnU5sF-ewQs=.ebe6da90-9f2d-4244-a630-efce89fafb24@github.com> References: <-nZS2bb-cO5AOu_LXPC7CKOlyuMi7r9HQnU5sF-ewQs=.ebe6da90-9f2d-4244-a630-efce89fafb24@github.com> Message-ID: On Mon, 7 Mar 2022 17:02:58 GMT, Dan Lutker wrote: > Clean backport of `8273056: java.util.random does not correctly sample exponential or Gaussian distributions` This pull request has now been integrated. Changeset: ff1ef50a Author: Jim Laskey Committer: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/ff1ef50a42a7cadf262d8bc22a8775ffe19f5f04 Stats: 15 lines in 1 file changed: 6 ins; 4 del; 5 mod 8273056: java.util.random does not correctly sample exponential or Gaussian distributions Backport-of: 3d98ec1b7bc77237177ecfc069c0e9a7e75829bc ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/204 From mdoerr at openjdk.java.net Tue Mar 8 17:35:20 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Mar 2022 17:35:20 GMT Subject: [jdk17u-dev] Integrated: 8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 13:05:34 GMT, Martin Doerr wrote: > Clean Backport of JDK-8275638. Should get backported together with JDK-8278966. This pull request has now been integrated. Changeset: a8775f16 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/a8775f16d75e08c5a7ad927edd45bc9650f01ed0 Stats: 117 lines in 3 files changed: 117 ins; 0 del; 0 mod 8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert Backport-of: b9a477bf19d9f276f6b1da8984eb56d7bd5fc137 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/200 From mdoerr at openjdk.java.net Tue Mar 8 17:44:11 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Mar 2022 17:44:11 GMT Subject: [jdk17u-dev] RFR: 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638 [v2] In-Reply-To: References: Message-ID: <31lfCIsaEhBEKj5gmUlrPhoo_Ijp72-jzZd0uB6Bmno=.cba6d667-0732-40c6-82b1-cf4adebe7eae@github.com> > Clean Backport of JDK-8278966 on top of JDK-8275638. Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport e7244c19f4e24698ab074da530bf6c403f0e22cd ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/201/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/201/files/acbe8280..193cc876 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=201&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=201&range=00-01 Stats: 20 lines in 2 files changed: 11 ins; 4 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/201.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/201/head:pull/201 PR: https://git.openjdk.java.net/jdk17u-dev/pull/201 From mdoerr at openjdk.java.net Tue Mar 8 17:44:12 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Mar 2022 17:44:12 GMT Subject: [jdk17u-dev] Integrated: 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638 In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 13:13:26 GMT, Martin Doerr wrote: > Clean Backport of JDK-8278966 on top of JDK-8275638. This pull request has now been integrated. Changeset: f820a3c3 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/f820a3c3dae079697bc397ddd445bb6585b20e5b Stats: 31 lines in 2 files changed: 29 ins; 0 del; 2 mod 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638 Backport-of: e7244c19f4e24698ab074da530bf6c403f0e22cd ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/201 From mdoerr at openjdk.java.net Tue Mar 8 17:45:08 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Mar 2022 17:45:08 GMT Subject: [jdk17u-dev] Integrated: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 13:26:54 GMT, Martin Doerr wrote: > Clean backport of [JDK-8265317](https://bugs.openjdk.java.net/browse/JDK-8265317) This pull request has now been integrated. Changeset: eee17fb7 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/eee17fb7b55c81522231709744d71d1a5bf2f5da Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL Backport-of: 58b5fb3233a9bbbfc1f1f8818be4dfd54325f1bd ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/202 From mdoerr at openjdk.java.net Tue Mar 8 17:45:22 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Mar 2022 17:45:22 GMT Subject: [jdk17u-dev] Integrated: 8278948: compiler/vectorapi/reshape/TestVectorCastAVX1.java crashes in assembler In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 13:35:24 GMT, Martin Doerr wrote: > Clean backport of [JDK-8278948](https://bugs.openjdk.java.net/browse/JDK-8278948) This pull request has now been integrated. Changeset: a15455fa Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/a15455fae6a5523d604ff66f3b9d46b52a5ac119 Stats: 100 lines in 2 files changed: 85 ins; 8 del; 7 mod 8278948: compiler/vectorapi/reshape/TestVectorCastAVX1.java crashes in assembler Backport-of: f8f9148016662578804479180a70e3732b08c11c ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/203 From mdoerr at openjdk.java.net Tue Mar 8 17:58:41 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Mar 2022 17:58:41 GMT Subject: [jdk17u-dev] RFR: 8269129: Multiple tier1 tests in hotspot/jtreg/compiler are failing for client VMs Message-ID: Clean backport of [JDK-8269129](https://bugs.openjdk.java.net/browse/JDK-8269129) ------------- Commit messages: - Backport 561a3a5077a573c88ba94cb7f7412dfc4c97aa91 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/207/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=207&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269129 Stats: 22 lines in 6 files changed: 18 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/207.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/207/head:pull/207 PR: https://git.openjdk.java.net/jdk17u-dev/pull/207 From zgu at openjdk.java.net Tue Mar 8 18:54:12 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 8 Mar 2022 18:54:12 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy Message-ID: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> This is a followup backport for Cgroup v2 support. The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. In additional: 1) Include partial backport of JDK-8250627. - Renamed `Metrics.c` => `CgroupMetrics.c` - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` - Return instance only if `isUseContainerSupport()` is enabled. 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` Test: - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS - [x] jdk/test/lib/containers/cgroup - [x] jdk/internal/platform/docker ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/840 Commit messages: - Fix tests - Add parital 8250627 backport - Backport 4def210a22faaec6b47912dd314e6365ea48d28f Changes: https://git.openjdk.java.net/jdk11u-dev/pull/863/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8231111 Stats: 5364 lines in 32 files changed: 3585 ins; 1622 del; 157 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/863/head:pull/863 PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From zgu at openjdk.java.net Tue Mar 8 19:10:36 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 8 Mar 2022 19:10:36 GMT Subject: [jdk11u-dev] RFR: 8237479: 8230305 causes slowdebug build failure Message-ID: A clean, followup (JDK-8230305) backport for Cgroup v2 support. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/840 Commit messages: - Backport 4ca06995855b5c974321d7b3622d661b8d27ba76 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/864/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=864&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8237479 Stats: 14 lines in 1 file changed: 0 ins; 0 del; 14 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/864.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/864/head:pull/864 PR: https://git.openjdk.java.net/jdk11u-dev/pull/864 From zgu at openjdk.java.net Tue Mar 8 19:10:38 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 8 Mar 2022 19:10:38 GMT Subject: [jdk11u-dev] RFR: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high Message-ID: A clean, followup (JDK-8231111) backport for Cgroup V2 support. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/863 Commit messages: - Backport ff6843ca4842498791061f924c545fa9469cc1dc Changes: https://git.openjdk.java.net/jdk11u-dev/pull/865/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=865&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253714 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/865.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/865/head:pull/865 PR: https://git.openjdk.java.net/jdk11u-dev/pull/865 From duke at openjdk.java.net Tue Mar 8 19:20:24 2022 From: duke at openjdk.java.net (Evgeny Astigeevich) Date: Tue, 8 Mar 2022 19:20:24 GMT Subject: [jdk15u-dev] RFR: 8186670: Implement _onSpinWait() intrinsic for AArch64 In-Reply-To: <2fac3e4c-2165-794e-be14-7b8ff874e543@littlepinkcloud.com> References: <2fac3e4c-2165-794e-be14-7b8ff874e543@littlepinkcloud.com> Message-ID: On Fri, 25 Feb 2022 13:22:14 GMT, Andrew Haley wrote: > Interesting, so I guess that's much more dramatic than anything we have in > the OpenJDK benchmarks. Maybe we want a JMH version of that. I've converted it to the JMH version. Results: No intrinsic: Benchmark Mode Cnt Score Error Units ThreadOnSpinWaitProducerConsumer01.trial avgt 10 2078.777 ? 743.187 ms/op 1-ISB Benchmark Mode Cnt Score Error Units ThreadOnSpinWaitProducerConsumer01.trial avgt 10 239.728 ? 3.207 ms/op > Do you think that onSpinWait() = ISB would help with 8267502? Maybe, if I knew more details of https://bugs.openjdk.java.net/browse/JDK-8246677. ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/181 From mdoerr at openjdk.java.net Tue Mar 8 19:26:07 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Mar 2022 19:26:07 GMT Subject: [jdk11u-dev] RFR: 8179503: Java should support GET OCSP calls [v2] In-Reply-To: <861H92b5UmmXqVXSRFATJy06EI1meeKW1-Ym7V_RjKE=.9e8b993b-d18f-46a1-a7fb-049c3d2f87eb@github.com> References: <861H92b5UmmXqVXSRFATJy06EI1meeKW1-Ym7V_RjKE=.9e8b993b-d18f-46a1-a7fb-049c3d2f87eb@github.com> Message-ID: On Wed, 2 Mar 2022 14:06:44 GMT, Alexey Pavlyutkin wrote: >> Hello! I'd like to backport >> >> 8179503: Java should support GET OCSP calls (dependency) >> >> to jdk11u-dev. This one is required as a dependency for >> >> 8274471: Add support for RSASSA-PSS in OCSP Response >> >> The following changes were done to apply original patch: >> >> src/java.base/share/classes/sun/security/provider/certpath/OCSP.java >> >> - resolved baseline conflict taking place due to absent revocation checking code >> >> The rest of the code applied without changes >> >> Verification/regression (20.04/amd64): jdk_security > > Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: > > reverts copyright year A lot of pre-submit tests have failed for other PRs, too. I don't think it's your fault. This change is not platform dependent, so I think your tests are fine. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/847 From phh at openjdk.java.net Tue Mar 8 19:31:04 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Tue, 8 Mar 2022 19:31:04 GMT Subject: [jdk11u-dev] RFR: 8212151: jdi/ExclusiveBind.java times out due to "bind failed: Address already in use" on Solaris-X64 In-Reply-To: <8fYoJXpa8lwEaVURysIQo1ye8Up5_xRHnrZOnVn_rXU=.28cb010f-9153-4dbf-8bee-ec8f2c8e77d4@github.com> References: <8fYoJXpa8lwEaVURysIQo1ye8Up5_xRHnrZOnVn_rXU=.28cb010f-9153-4dbf-8bee-ec8f2c8e77d4@github.com> Message-ID: On Mon, 7 Mar 2022 19:21:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to resolve the whole change because it is one hunk that does not apply because changes to the test description are not backported (8210112: remove jdk.testlibrary.ProcessTools; 8210732: remove jdk.testlibrary.Utils) > > I resolved the test to be the same as head. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/859 From mdoerr at openjdk.java.net Tue Mar 8 19:39:43 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 8 Mar 2022 19:39:43 GMT Subject: [jdk17u-dev] RFR: 8270468: TestRangeCheckEliminated fails because methods are not compiled Message-ID: Clean backport of [JDK-8270468](https://bugs.openjdk.java.net/browse/JDK-8270468) ------------- Commit messages: - Backport bb82005a8102dd5bb2fa2abc5c2f7255d6969e9e Changes: https://git.openjdk.java.net/jdk17u-dev/pull/208/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=208&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270468 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/208.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/208/head:pull/208 PR: https://git.openjdk.java.net/jdk17u-dev/pull/208 From rreddy at openjdk.java.net Wed Mar 9 02:23:44 2022 From: rreddy at openjdk.java.net (Ravi Reddy) Date: Wed, 9 Mar 2022 02:23:44 GMT Subject: [jdk18u] RFR: 8281093: Violating Attribute-Value Normalization in the XML specification 1.0 Message-ID: Clean backport of https://github.com/openjdk/jdk/commit/3996782c5af7b0396d5133fab457c507758d9340 to jdk18u. ------------- Commit messages: - 8281093: Violating Attribute-Value Normalization in the XML specification 1.0 Changes: https://git.openjdk.java.net/jdk18u/pull/35/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=35&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281093 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk18u/pull/35.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/35/head:pull/35 PR: https://git.openjdk.java.net/jdk18u/pull/35 From rreddy at openjdk.java.net Wed Mar 9 03:00:11 2022 From: rreddy at openjdk.java.net (Ravi Reddy) Date: Wed, 9 Mar 2022 03:00:11 GMT Subject: [jdk18u] Integrated: 8281093: Violating Attribute-Value Normalization in the XML specification 1.0 In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 02:15:21 GMT, Ravi Reddy wrote: > Clean backport of https://github.com/openjdk/jdk/commit/3996782c5af7b0396d5133fab457c507758d9340 to jdk18u. This pull request has now been integrated. Changeset: 9bd2fc6d Author: Ravi Reddy Committer: Joe Wang URL: https://git.openjdk.java.net/jdk18u/commit/9bd2fc6d5824461ebac38d3ec77eee43eaa29595 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8281093: Violating Attribute-Value Normalization in the XML specification 1.0 Backport-of: 3996782c5af7b0396d5133fab457c507758d9340 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/35 From mbaesken at openjdk.java.net Wed Mar 9 08:33:01 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 9 Mar 2022 08:33:01 GMT Subject: [jdk11u-dev] Integrated: 8275082: Update XML Security for Java to 2.3.0 In-Reply-To: References: Message-ID: <1FAn4SqUkXC2Iroz4bS6JkGtHCS5mvAxf1zLg61n-Uc=.a3c83a6c-6a17-4c2e-ad76-c241c71cd481@github.com> On Tue, 15 Feb 2022 08:49:50 GMT, Matthias Baesken wrote: > 8275082: Update XML Security for Java to 2.3.0 This pull request has now been integrated. Changeset: b0c0dc5a Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/b0c0dc5ad2eb792343d579e6ff4be31422cd9f70 Stats: 413 lines in 33 files changed: 63 ins; 267 del; 83 mod 8275082: Update XML Security for Java to 2.3.0 Backport-of: 1082544d23ee4cd1d81cdd707f136adc951eca00 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/825 From goetz at openjdk.java.net Wed Mar 9 08:47:08 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 08:47:08 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge build tag 11.0.15+5 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8277795: ldap connection timeout not honoured under contention - 8276141: XPathFactory set/getProperty method The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jdk11u-dev/pull/866/files Stats: 526 lines in 7 files changed: 381 ins; 72 del; 73 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/866.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/866/head:pull/866 PR: https://git.openjdk.java.net/jdk11u-dev/pull/866 From mdoerr at openjdk.java.net Wed Mar 9 10:09:28 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Mar 2022 10:09:28 GMT Subject: [jdk17u-dev] Integrated: 8270468: TestRangeCheckEliminated fails because methods are not compiled In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 19:31:06 GMT, Martin Doerr wrote: > Clean backport of [JDK-8270468](https://bugs.openjdk.java.net/browse/JDK-8270468) This pull request has now been integrated. Changeset: 11a5bbd6 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/11a5bbd65ef39d500fd90a7032e96055333a5a0d Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8270468: TestRangeCheckEliminated fails because methods are not compiled Backport-of: bb82005a8102dd5bb2fa2abc5c2f7255d6969e9e ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/208 From mdoerr at openjdk.java.net Wed Mar 9 10:09:29 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Mar 2022 10:09:29 GMT Subject: [jdk17u-dev] Integrated: 8269129: Multiple tier1 tests in hotspot/jtreg/compiler are failing for client VMs In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 17:49:07 GMT, Martin Doerr wrote: > Clean backport of [JDK-8269129](https://bugs.openjdk.java.net/browse/JDK-8269129) This pull request has now been integrated. Changeset: a946f04d Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/a946f04d2e2356307b3968222ee4c733f49c9f9d Stats: 22 lines in 6 files changed: 18 ins; 0 del; 4 mod 8269129: Multiple tier1 tests in hotspot/jtreg/compiler are failing for client VMs Backport-of: 561a3a5077a573c88ba94cb7f7412dfc4c97aa91 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/207 From goetz at openjdk.java.net Wed Mar 9 10:10:05 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 10:10:05 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 08:42:24 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.15+5 from jdk11u to jdk11u-dev Failing Pre-submit test: deps missing. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/866 From goetz at openjdk.java.net Wed Mar 9 10:10:06 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 10:10:06 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: <3bcLTAzmb8HCn9j2BAtj-eVT3B8oUt0huNJOiDuuJdM=.53a16b5b-7764-43f9-b15f-d7a1f2bb2a79@github.com> On Wed, 9 Mar 2022 08:42:24 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.15+5 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: 7a1d1e02 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/7a1d1e022b8e97e58460cca9bb989e4ad304f874 Stats: 526 lines in 7 files changed: 381 ins; 72 del; 73 mod Merge ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/866 From goetz at openjdk.java.net Wed Mar 9 10:17:20 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 10:17:20 GMT Subject: [jdk11u] Integrated: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 07:59:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. > > The code touched was completely reworked in jdk15 by "8228336: Refactor native library loading implementation" > > make/test/JtregNativeJdk.gmk > Trivial resolve due to context. > > src/hotspot/share/prims/jvm.cpp > Applies clean, but does not compile. > I removed "log_info(library)("Failed to load library %s", name);" > Logging was only added to this file in jdk15 with "8187305: Add logging for shared library loads/unloads" > > Changes to > src/java.base/macosx/classes/jdk/internal/loader/ClassLoaderHelper.java > applied to > src/java.base/macosx/classes/java/lang/ClassLoaderHelper.java > Fits well. > > Changes to > src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java > applied to class NativeLibrary in java/lang/ClassLoader.java. > I had to modify the code. > > Changes to > src/java.base/share/native/libjava/NativeLibraries.c > applied to > src/java.base/share/native/libjava/ClassLoader.c > Fits acceptable. > > Changes to > src/java.base/unix/classes/jdk/internal/loader/ClassLoaderHelper.java > applied to > src/java.base/unix/classes/java/lang/ClassLoaderHelper.java > Fits well. > > Changes to > src/java.base/windows/classes/jdk/internal/loader/ClassLoaderHelper.java > applied to > src/java.base/windows/classes/java/lang/ClassLoaderHelper.java > Fits well. > > SAP testing passed. This pull request has now been integrated. Changeset: f7346f08 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u/commit/f7346f087a14f1878029a00104005e04468d333f Stats: 189 lines in 10 files changed: 167 ins; 0 del; 22 mod 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem Reviewed-by: mbaesken Backport-of: 6aa02d75d9f26f46fbdb54aef52cea3257aa7462 ------------- PR: https://git.openjdk.java.net/jdk11u/pull/30 From goetz at openjdk.java.net Wed Mar 9 10:18:08 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 10:18:08 GMT Subject: [jdk11u-dev] Integrated: 8208246: flags duplications in vmTestbase_vm_g1classunloading tests In-Reply-To: <-cEjMwFhm6Bb8Eyz0PnYQVbbxS9FvmtUgwoHVf6M8hE=.d788c858-36e8-4b59-b739-e6307b96dd56@github.com> References: <-cEjMwFhm6Bb8Eyz0PnYQVbbxS9FvmtUgwoHVf6M8hE=.d788c858-36e8-4b59-b739-e6307b96dd56@github.com> Message-ID: On Mon, 7 Mar 2022 14:58:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: 56e23849 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/56e2384959be0549fb2514951c1a1da887827129 Stats: 784 lines in 112 files changed: 0 ins; 784 del; 0 mod 8208246: flags duplications in vmTestbase_vm_g1classunloading tests Remove duplicate flags for the classunloading tests Backport-of: b184fceaa00be64862e9a7a0b04a1f0ce819c821 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/857 From mdoerr at openjdk.java.net Wed Mar 9 10:20:04 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Mar 2022 10:20:04 GMT Subject: [jdk11u-dev] Integrated: 8279837: C2: assert(is_Loop()) failed: invalid node class: Region In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 16:00:29 GMT, Martin Doerr wrote: > Clean backport of JDK-8279837. This pull request has now been integrated. Changeset: 87b60073 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/87b60073b8a8d62b1f7238c7c22cb62521477851 Stats: 87 lines in 2 files changed: 87 ins; 0 del; 0 mod 8279837: C2: assert(is_Loop()) failed: invalid node class: Region Backport-of: 65eb066b630b892f22492457e0f86165e5ef4765 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/862 From goetz at openjdk.java.net Wed Mar 9 10:20:09 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 10:20:09 GMT Subject: [jdk11u-dev] Integrated: 8208249: TriggerUnloadingByFillingMetaspace generates garbage class names In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 16:51:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: 571d3239 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/571d3239968d9759c5172789c1d649232bb87410 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod 8208249: TriggerUnloadingByFillingMetaspace generates garbage class names Put a ThreadLocal around the object to be thread safe Backport-of: 3d94ce71b5c379627406b3c889058d49bd5b7622 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/858 From mdoerr at openjdk.java.net Wed Mar 9 10:22:02 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Mar 2022 10:22:02 GMT Subject: [jdk11u-dev] Integrated: 8223143: Restructure/clean-up for 'loopexit_or_null()'. In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 13:41:31 GMT, Martin Doerr wrote: > Clean backport of JDK-8223143. This pull request has now been integrated. Changeset: bca1970e Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/bca1970e865a87afc51f03cfd45b1745cc439331 Stats: 42 lines in 1 file changed: 23 ins; 1 del; 18 mod 8223143: Restructure/clean-up for 'loopexit_or_null()'. Minor restructure and clean-up for 'loopexit_or_null()' and its use. Backport-of: 8088ed83178ef8b0e4be6d510f28bd6bb1beecc8 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/861 From goetz at openjdk.java.net Wed Mar 9 10:39:37 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 10:39:37 GMT Subject: [jdk11u-dev] RFR: 8208697: vmTestbase/metaspace/stressHierarchy/stressHierarchy012/TestDescription.java fails with OutOfMemoryError: Metaspace Message-ID: <0oEVLr3U9IJ8c4LHQlwIHrn5FzfK-QYgGPU61nYYo4U=.ff2aefea-c754-44f4-93e5-b725206717d8@github.com> I backport this for parity with 11.0.16-oracle. ProblemList: skipped, tests are not Problem Listed. ------------- Commit messages: - Backport 7445ebf02bca4111a6c98fefb42819b28212f19a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/867/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=867&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8208697 Stats: 592 lines in 10 files changed: 0 ins; 566 del; 26 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/867.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/867/head:pull/867 PR: https://git.openjdk.java.net/jdk11u-dev/pull/867 From mdoerr at openjdk.java.net Wed Mar 9 11:19:21 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Mar 2022 11:19:21 GMT Subject: [jdk11u-dev] RFR: 8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit Message-ID: Backport of [JDK-8216137](https://bugs.openjdk.java.net/browse/JDK-8216137) (including [JDK-8219520](https://bugs.openjdk.java.net/browse/JDK-8219520) as in original commit) loopTransform.cpp (introduction of `AutoNodeBudget`) and loopnode.hpp required manual integration. Rest applies cleanly. ------------- Commit messages: - Backport e08506e6831667c17f1197345261f4c5e34294dc Changes: https://git.openjdk.java.net/jdk11u-dev/pull/868/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=868&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8216137 Stats: 266 lines in 5 files changed: 181 ins; 24 del; 61 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/868.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/868/head:pull/868 PR: https://git.openjdk.java.net/jdk11u-dev/pull/868 From mdoerr at openjdk.java.net Wed Mar 9 11:19:22 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Mar 2022 11:19:22 GMT Subject: [jdk11u-dev] RFR: 8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit In-Reply-To: References: Message-ID: <5UgHYhKD63_IzrInDLDbW-v9Yq58RWTQihtZidB8-7s=.37c7ccb1-cb71-424f-b582-22c20c0c69db@github.com> On Wed, 9 Mar 2022 10:47:54 GMT, Martin Doerr wrote: > Backport of [JDK-8216137](https://bugs.openjdk.java.net/browse/JDK-8216137) (including [JDK-8219520](https://bugs.openjdk.java.net/browse/JDK-8219520) as in original commit) > loopTransform.cpp (introduction of `AutoNodeBudget`) and loopnode.hpp required manual integration. Rest applies cleanly. Skara reports this as integration blocker: Title mismatch between PR and JBS for issue [JDK-8219520](https://bugs.openjdk.java.net/browse/JDK-8219520). Fix: ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/868 From mdoerr at openjdk.java.net Wed Mar 9 11:58:00 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Mar 2022 11:58:00 GMT Subject: [jdk11u-dev] RFR: 8208697: vmTestbase/metaspace/stressHierarchy/stressHierarchy012/TestDescription.java fails with OutOfMemoryError: Metaspace In-Reply-To: <0oEVLr3U9IJ8c4LHQlwIHrn5FzfK-QYgGPU61nYYo4U=.ff2aefea-c754-44f4-93e5-b725206717d8@github.com> References: <0oEVLr3U9IJ8c4LHQlwIHrn5FzfK-QYgGPU61nYYo4U=.ff2aefea-c754-44f4-93e5-b725206717d8@github.com> Message-ID: On Wed, 9 Mar 2022 10:31:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > ProblemList: skipped, tests are not Problem Listed. Marked as reviewed by mdoerr (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/867 From mdoerr at openjdk.java.net Wed Mar 9 13:27:39 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Mar 2022 13:27:39 GMT Subject: [jdk17u-dev] RFR: 8279515: C1: No inlining through invokedynamic and invokestatic call sites when resolved class is not linked Message-ID: Clean backport of [JDK-8279515](https://bugs.openjdk.java.net/browse/JDK-8279515) ------------- Commit messages: - Backport ad34f03b549e6f37825efc3e554d2232b557611a Changes: https://git.openjdk.java.net/jdk17u-dev/pull/209/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=209&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279515 Stats: 166 lines in 4 files changed: 162 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/209.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/209/head:pull/209 PR: https://git.openjdk.java.net/jdk17u-dev/pull/209 From goetz at openjdk.java.net Wed Mar 9 14:08:14 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 14:08:14 GMT Subject: [jdk17u-dev] RFR: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure Message-ID: I backport this for parity with 17.0.4-oracle. I had to resolve the ProblemList because of 8271877: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK17 As I understand the fix it is platform agnostic, so removing all platforms is fine. ------------- Commit messages: - Backport ee0247f056daea7a0afdd572d13fb30f5164e889 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/211/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=211&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263461 Stats: 70 lines in 3 files changed: 21 ins; 37 del; 12 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/211.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/211/head:pull/211 PR: https://git.openjdk.java.net/jdk17u-dev/pull/211 From rkennke at openjdk.java.net Wed Mar 9 14:08:31 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 9 Mar 2022 14:08:31 GMT Subject: [jdk17u-dev] RFR: 8277072: ObjectStreamClass caches keep ClassLoaders alive Message-ID: Hi all, This pull request contains a backport of commit [8eb453ba](https://github.com/openjdk/jdk/commit/8eb453baebe377697286f7eb32280ca9f1fd7775) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Roman Kennke on 10 Dec 2021 and was reviewed by Roger Riggs and Peter Levart. It fixes a memory leak in ObjectStreamClass under certain conditions. See bug for details. Thanks! ------------- Commit messages: - Backport 8eb453baebe377697286f7eb32280ca9f1fd7775 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/210/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=210&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277072 Stats: 496 lines in 4 files changed: 284 ins; 186 del; 26 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/210.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/210/head:pull/210 PR: https://git.openjdk.java.net/jdk17u-dev/pull/210 From goetz at openjdk.java.net Wed Mar 9 14:28:35 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 14:28:35 GMT Subject: [jdk17u-dev] RFR: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport a0f32cb1406e4957e84befd9b68444adb662bd13 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/212/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=212&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268906 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/212.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/212/head:pull/212 PR: https://git.openjdk.java.net/jdk17u-dev/pull/212 From anton.tarasov at jetbrains.com Wed Mar 9 14:34:07 2022 From: anton.tarasov at jetbrains.com (Anton Tarasov) Date: Wed, 9 Mar 2022 17:34:07 +0300 Subject: New JDK Updates Committer: Artem Semenov Message-ID: Voting for Artem Semenov [1] is now closed. Yes: 5 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus [2], this is sufficient to approve the nomination. Thank you, Anton [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012310.html [2] http://openjdk.java.net/bylaws#three-vote-consensus From goetz at openjdk.java.net Wed Mar 9 14:34:27 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 14:34:27 GMT Subject: [jdk17u-dev] RFR: 8269135: TestDifferentProtectionDomains runs into timeout in client VM Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 53ad903a820b6892dbb273357defe7cf5c7e24ab Changes: https://git.openjdk.java.net/jdk17u-dev/pull/213/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=213&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269135 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/213.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/213/head:pull/213 PR: https://git.openjdk.java.net/jdk17u-dev/pull/213 From goetz at openjdk.java.net Wed Mar 9 14:39:53 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 14:39:53 GMT Subject: [jdk17u-dev] RFR: 8263538: SharedArchiveConsistency.java should test -Xshare:auto as well Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport e8206dbb1758325ce10ac23768c82cb567eed704 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/214/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=214&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263538 Stats: 41 lines in 1 file changed: 26 ins; 3 del; 12 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/214.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/214/head:pull/214 PR: https://git.openjdk.java.net/jdk17u-dev/pull/214 From goetz at openjdk.java.net Wed Mar 9 14:40:37 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 14:40:37 GMT Subject: [jdk17u-dev] RFR: 8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 4a45d95719bf68221e6843572511c2eb741ba69c Changes: https://git.openjdk.java.net/jdk17u-dev/pull/215/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=215&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270021 Stats: 12 lines in 2 files changed: 4 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/215.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/215/head:pull/215 PR: https://git.openjdk.java.net/jdk17u-dev/pull/215 From goetz at openjdk.java.net Wed Mar 9 14:44:30 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 14:44:30 GMT Subject: [jdk17u-dev] RFR: 8270837: fix typos in test TestSigParse.java Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 67dc1c5bf34cfe987b672f34f0b2a6b36840382a Changes: https://git.openjdk.java.net/jdk17u-dev/pull/216/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=216&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270837 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/216.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/216/head:pull/216 PR: https://git.openjdk.java.net/jdk17u-dev/pull/216 From burban at openjdk.java.net Wed Mar 9 14:45:13 2022 From: burban at openjdk.java.net (Bernhard Urban-Forster) Date: Wed, 9 Mar 2022 14:45:13 GMT Subject: [jdk11u-dev] Integrated: 8211962: Implicit narrowing in MacOSX java.desktop jsound In-Reply-To: References: Message-ID: On Fri, 4 Mar 2022 12:13:14 GMT, Bernhard Urban-Forster wrote: > Hi all, > > This pull request contains a backport of commit [47e7b141](https://github.com/openjdk/jdk/commit/47e7b141c03b338ef7bbadc3c554e50c8fb210a9) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Kim Barrett on 11 Oct 2018 and was reviewed by Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: 85a89c50 Author: Bernhard Urban-Forster Committer: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/85a89c50754f88e53e205d78b19b30b898817005 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8211962: Implicit narrowing in MacOSX java.desktop jsound Cast value to needed type. Backport-of: 47e7b141c03b338ef7bbadc3c554e50c8fb210a9 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/854 From goetz at openjdk.java.net Wed Mar 9 14:53:39 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 14:53:39 GMT Subject: [jdk17u-dev] RFR: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 6346793c6401b3758edf0a8912acb0fd8813957b Changes: https://git.openjdk.java.net/jdk17u-dev/pull/217/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=217&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269933 Stats: 27 lines in 1 file changed: 15 ins; 0 del; 12 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/217.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/217/head:pull/217 PR: https://git.openjdk.java.net/jdk17u-dev/pull/217 From goetz at openjdk.java.net Wed Mar 9 14:59:34 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 14:59:34 GMT Subject: [jdk17u-dev] RFR: 8270336: [TESTBUG] Fix initialization in NonbranchyTree Message-ID: <2HV7xfTl3D8ymx4YJ3maQ0-hECR_vK7Ii0ZTw3pSpmE=.fbcc7c21-bccb-48e2-895b-805a6e0a1520@github.com> I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 3cadc3606073f0efc2e97dda348ffb65c41dad0c Changes: https://git.openjdk.java.net/jdk17u-dev/pull/218/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=218&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270336 Stats: 30 lines in 1 file changed: 4 ins; 17 del; 9 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/218.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/218/head:pull/218 PR: https://git.openjdk.java.net/jdk17u-dev/pull/218 From goetz at openjdk.java.net Wed Mar 9 15:09:30 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 15:09:30 GMT Subject: [jdk17u-dev] RFR: 8269753: Misplaced caret in PatternSyntaxException's detail message Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport bb508e13032c3571c48275391dfeb04c03bbf3a3 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/219/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=219&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269753 Stats: 24 lines in 2 files changed: 21 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/219.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/219/head:pull/219 PR: https://git.openjdk.java.net/jdk17u-dev/pull/219 From goetz at openjdk.java.net Wed Mar 9 15:28:40 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 15:28:40 GMT Subject: [jdk17u-dev] RFR: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 68dd8280886ede7f5cd8d34811ad0f9ffac440f3 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/220/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=220&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271224 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/220.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/220/head:pull/220 PR: https://git.openjdk.java.net/jdk17u-dev/pull/220 From goetz at openjdk.java.net Wed Mar 9 15:31:31 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 15:31:31 GMT Subject: [jdk17u-dev] RFR: 8272169: runtime/logging/LoaderConstraintsTest.java doesn't build test.Empty Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport eb6f3fe59d469a369383a750d319318909cf8613 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/221/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=221&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272169 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/221.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/221/head:pull/221 PR: https://git.openjdk.java.net/jdk17u-dev/pull/221 From goetz at openjdk.java.net Wed Mar 9 15:33:32 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 15:33:32 GMT Subject: [jdk17u-dev] RFR: 8272146: Disable Fibonacci test on memory constrained systems Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport adba09b91de2e86fe4eb844c9066a23b176176bd Changes: https://git.openjdk.java.net/jdk17u-dev/pull/222/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=222&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272146 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/222.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/222/head:pull/222 PR: https://git.openjdk.java.net/jdk17u-dev/pull/222 From goetz at openjdk.java.net Wed Mar 9 15:39:43 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 9 Mar 2022 15:39:43 GMT Subject: [jdk17u-dev] RFR: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 041ae20b10e11381415e8f61fd39e9e19aa8d4f2 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/223/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=223&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268558 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/223.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/223/head:pull/223 PR: https://git.openjdk.java.net/jdk17u-dev/pull/223 From mdoerr at openjdk.java.net Wed Mar 9 15:51:22 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 9 Mar 2022 15:51:22 GMT Subject: [jdk17u-dev] RFR: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:02:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. > > I had to resolve the ProblemList because of 8271877: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK17 > As I understand the fix it is platform agnostic, so removing all platforms is fine. LGTM. Please check test results on all linux and Windows before integrating. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/211 From rkennke at openjdk.java.net Wed Mar 9 16:17:43 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 9 Mar 2022 16:17:43 GMT Subject: [jdk11u-dev] RFR: 8277072: ObjectStreamClass caches keep ClassLoaders alive Message-ID: <40K8iorg2vcaPk5L8g16A7vwfZbMKvlBcYpCSqepT0s=.0e2479c1-7af0-4945-a9eb-63c98a6dac8b@github.com> Hi all, This pull request contains a backport of commit [8eb453ba](https://github.com/openjdk/jdk/commit/8eb453baebe377697286f7eb32280ca9f1fd7775) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Roman Kennke on 10 Dec 2021 and was reviewed by Roger Riggs and Peter Levart. It fixes a memory leak in ObjectStreamClass under certain conditions. See bug for details. The backport was not clean, there have been some rather minor differences in context. Thanks! ------------- Commit messages: - Backport 8eb453baebe377697286f7eb32280ca9f1fd7775 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/869/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=869&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277072 Stats: 497 lines in 4 files changed: 285 ins; 186 del; 26 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/869.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/869/head:pull/869 PR: https://git.openjdk.java.net/jdk11u-dev/pull/869 From rkennke at openjdk.java.net Wed Mar 9 16:19:00 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 9 Mar 2022 16:19:00 GMT Subject: [jdk18u] RFR: 8277072: ObjectStreamClass caches keep ClassLoaders alive Message-ID: <5X_t5RoYSeQPT5vOdCSGiflNoGnvgcNx3-OX6_2F1q4=.63ff24ca-c7b1-403a-acc5-1987b4a5594f@github.com> Hi all, This pull request contains a backport of commit [8eb453ba](https://github.com/openjdk/jdk/commit/8eb453baebe377697286f7eb32280ca9f1fd7775) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Roman Kennke on 10 Dec 2021 and was reviewed by Roger Riggs and Peter Levart. It fixes a memory leak in ObjectStreamClass under certain conditions. See bug for details. Thanks! ------------- Commit messages: - Backport 8eb453baebe377697286f7eb32280ca9f1fd7775 Changes: https://git.openjdk.java.net/jdk18u/pull/36/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=36&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277072 Stats: 496 lines in 4 files changed: 284 ins; 186 del; 26 mod Patch: https://git.openjdk.java.net/jdk18u/pull/36.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/36/head:pull/36 PR: https://git.openjdk.java.net/jdk18u/pull/36 From andrew at openjdk.java.net Wed Mar 9 16:37:12 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Wed, 9 Mar 2022 16:37:12 GMT Subject: [jdk17u-dev] RFR: 8279182: MakeZipReproducible ZipEntry timestamps not localized to UTC In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 08:43:36 GMT, Andrew Leonard wrote: > This patch is for reproducible builds whereby the reproducible src.zip timestamps where not being localized to UTC, hence src.zip differed depending on what local build machine timezone was set to. Looks good to me. Thanks for backporting. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/205 From aleonard at openjdk.java.net Wed Mar 9 16:37:12 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Wed, 9 Mar 2022 16:37:12 GMT Subject: [jdk17u-dev] Integrated: 8279182: MakeZipReproducible ZipEntry timestamps not localized to UTC In-Reply-To: References: Message-ID: <6KVTdaxHD_5FtL0oy9lKndyj0YPr8GGKeM6AafZ8u-0=.3c50f839-3ad2-4cc3-87e6-a45bfe6d8316@github.com> On Tue, 8 Mar 2022 08:43:36 GMT, Andrew Leonard wrote: > This patch is for reproducible builds whereby the reproducible src.zip timestamps where not being localized to UTC, hence src.zip differed depending on what local build machine timezone was set to. This pull request has now been integrated. Changeset: 673c5850 Author: Andrew Leonard Committer: Andrew John Hughes URL: https://git.openjdk.java.net/jdk17u-dev/commit/673c5850b5db0a84c63d9799cec9e47b2661b4be Stats: 11 lines in 1 file changed: 6 ins; 0 del; 5 mod 8279182: MakeZipReproducible ZipEntry timestamps not localized to UTC Backport-of: bc0466c7ca57f14b1e6285e2a39755d57c8de376 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/205 From andrew at openjdk.java.net Wed Mar 9 16:43:17 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Wed, 9 Mar 2022 16:43:17 GMT Subject: [jdk17u-dev] RFR: 8275745: Reproducible copyright headers In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 11:37:14 GMT, Andrew Leonard wrote: > The copyright headers are generated at build time, and the year inserted in the template depends on the current date. This means the headers are not reproducible if the project is built a year later. This PR uses the year derived from the SOURCE_DATE_EPOCH environment variable to make the build reproducible (this variable is already used in other parts of the build). Looks good. Thanks. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/206 From aleonard at openjdk.java.net Wed Mar 9 16:43:17 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Wed, 9 Mar 2022 16:43:17 GMT Subject: [jdk17u-dev] Integrated: 8275745: Reproducible copyright headers In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 11:37:14 GMT, Andrew Leonard wrote: > The copyright headers are generated at build time, and the year inserted in the template depends on the current date. This means the headers are not reproducible if the project is built a year later. This PR uses the year derived from the SOURCE_DATE_EPOCH environment variable to make the build reproducible (this variable is already used in other parts of the build). This pull request has now been integrated. Changeset: 0d933c9b Author: Andrew Leonard Committer: Andrew John Hughes URL: https://git.openjdk.java.net/jdk17u-dev/commit/0d933c9b4f096c55058209ab7eaa8588bdc95ffb Stats: 53 lines in 8 files changed: 33 ins; 11 del; 9 mod 8275745: Reproducible copyright headers Backport-of: a0227965bb8d1d49718794d67f8a4cfeebc9bec2 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/206 From rriggs at openjdk.java.net Wed Mar 9 17:36:18 2022 From: rriggs at openjdk.java.net (Roger Riggs) Date: Wed, 9 Mar 2022 17:36:18 GMT Subject: [jdk18u] RFR: 8277072: ObjectStreamClass caches keep ClassLoaders alive In-Reply-To: <5X_t5RoYSeQPT5vOdCSGiflNoGnvgcNx3-OX6_2F1q4=.63ff24ca-c7b1-403a-acc5-1987b4a5594f@github.com> References: <5X_t5RoYSeQPT5vOdCSGiflNoGnvgcNx3-OX6_2F1q4=.63ff24ca-c7b1-403a-acc5-1987b4a5594f@github.com> Message-ID: <2fmplhFYYAppe95D9HskyrtgjxnO8olTlikrUzQ0y8c=.a010137d-b154-4f5a-aab6-7ed5e4834748@github.com> On Wed, 9 Mar 2022 16:11:13 GMT, Roman Kennke wrote: > Hi all, > > This pull request contains a backport of commit [8eb453ba](https://github.com/openjdk/jdk/commit/8eb453baebe377697286f7eb32280ca9f1fd7775) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Roman Kennke on 10 Dec 2021 and was reviewed by Roger Riggs and Peter Levart. > > It fixes a memory leak in ObjectStreamClass under certain conditions. See bug for details. > > Thanks! Marked as reviewed by rriggs (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk18u/pull/36 From jincheng at ca.ibm.com Wed Mar 9 17:53:15 2022 From: jincheng at ca.ibm.com (Cheng Jin) Date: Wed, 9 Mar 2022 17:53:15 +0000 Subject: Backport request for JDK-8276657 on JDK11 & JDK17 Message-ID: Hi there, I notice the issue with the XSLT compiler (https://github.com/openjdk/jdk/blob/master/src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java) I raised later last year at https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-November/083135.html was fixed in JDK18 via https://bugs.openjdk.java.net/browse/JDK-8276657. Could you please backport the fix to JDK11 and JDK17 give both of them share the same issue in code? Many thanks. Best Regards Cheng Jin From aleonard at openjdk.java.net Wed Mar 9 18:02:08 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Wed, 9 Mar 2022 18:02:08 GMT Subject: [jdk17u-dev] RFR: 8275745: Reproducible copyright headers In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 16:37:53 GMT, Andrew John Hughes wrote: >> The copyright headers are generated at build time, and the year inserted in the template depends on the current date. This means the headers are not reproducible if the project is built a year later. This PR uses the year derived from the SOURCE_DATE_EPOCH environment variable to make the build reproducible (this variable is already used in other parts of the build). > > Looks good. Thanks. @gnu-andrew thank you Andrew ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/206 From duke at openjdk.java.net Wed Mar 9 18:08:25 2022 From: duke at openjdk.java.net (Joshua Cao) Date: Wed, 9 Mar 2022 18:08:25 GMT Subject: [jdk11u-dev] Integrated: 8258956: Memory Leak in StringCoding on ThreadLocal resultCached StringCoding.Result In-Reply-To: <-xLw7Q1R06MXI2gbG7ZxMyS1z_kTP12lXxd2R21NH4A=.ee97b975-83db-48fc-b6fc-eb5d60ebfd8c@github.com> References: <-xLw7Q1R06MXI2gbG7ZxMyS1z_kTP12lXxd2R21NH4A=.ee97b975-83db-48fc-b6fc-eb5d60ebfd8c@github.com> Message-ID: <4u2nOg4ZPy0MBpxjBHfpqS54YNNjGX44u7kkBIhnuIA=.5f90617d-6134-4378-9bfc-42cf67a5207f@github.com> On Mon, 7 Mar 2022 22:08:01 GMT, Joshua Cao wrote: > One rejected hunk on the copyright year: > > > diff a/src/java.base/share/classes/java/lang/StringCoding.java b/src/java.base/share/classes/java/lang/StringCoding.java (rejected hunks) > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2000, 2020, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > > > Otherwise, this is a clean backport. This pull request has now been integrated. Changeset: 8e01531a Author: Joshua Cao Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk11u-dev/commit/8e01531a547f7693387dfdefb6b2c18ed0ee1e68 Stats: 17 lines in 1 file changed: 9 ins; 0 del; 8 mod 8258956: Memory Leak in StringCoding on ThreadLocal resultCached StringCoding.Result Backport-of: aba3431c4e594a68454faca62b6ba1b6840c12c6 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/860 From duke at openjdk.java.net Thu Mar 10 07:32:26 2022 From: duke at openjdk.java.net (wxiang) Date: Thu, 10 Mar 2022 07:32:26 GMT Subject: [jdk11u-dev] RFR: 8261090: Store old classfiles in static CDS archive [v2] In-Reply-To: References: Message-ID: <4tqUkn-OsqxCUK_XarWC0UNUloQjtNMN8i1Keyuxjgo=.6e70c9ff-9c4b-4396-9303-6a8d9cf062e5@github.com> > 8261090: Store old classfiles in static CDS archive wxiang has updated the pull request incrementally with one additional commit since the last revision: revert the changes with 8266822 and 8267431 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/856/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/856/files/0b531ce0..2c0b5935 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=856&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=856&range=00-01 Stats: 75 lines in 10 files changed: 24 ins; 25 del; 26 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/856.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/856/head:pull/856 PR: https://git.openjdk.java.net/jdk11u-dev/pull/856 From shade at openjdk.java.net Thu Mar 10 08:28:12 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 08:28:12 GMT Subject: [jdk17u-dev] RFR: 8282225: GHA: Allow one concurrent run per PR only Message-ID: Clean backport to improve GHA performance. ------------- Commit messages: - Backport aaab2cb41666af8520fd01de70e2c4f9c87ef5fd Changes: https://git.openjdk.java.net/jdk17u-dev/pull/224/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=224&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282225 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/224.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/224/head:pull/224 PR: https://git.openjdk.java.net/jdk17u-dev/pull/224 From shade at openjdk.java.net Thu Mar 10 08:33:20 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 08:33:20 GMT Subject: [jdk18u] RFR: 8282225: GHA: Allow one concurrent run per PR only Message-ID: Clean backport to improve GHA performance. ------------- Commit messages: - Backport aaab2cb41666af8520fd01de70e2c4f9c87ef5fd Changes: https://git.openjdk.java.net/jdk18u/pull/37/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=37&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282225 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/37.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/37/head:pull/37 PR: https://git.openjdk.java.net/jdk18u/pull/37 From avoitylov at openjdk.java.net Thu Mar 10 08:37:39 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 10 Mar 2022 08:37:39 GMT Subject: [jdk11u-dev] Integrated: 8252250: isnanf is obsolete In-Reply-To: <4hcI6RLplGU_qvFnBIAzcHCMpWbwLV_CAqNWBQa84sE=.42f2d7b7-ab3e-406f-8459-53b3260f0ebc@github.com> References: <4hcI6RLplGU_qvFnBIAzcHCMpWbwLV_CAqNWBQa84sE=.42f2d7b7-ab3e-406f-8459-53b3260f0ebc@github.com> Message-ID: On Thu, 3 Mar 2022 08:29:01 GMT, Aleksei Voitylov wrote: > JDK-8252250 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Unlike original changeset this backport also changes src/java.base/unix/native/libjava/jdk_util_md.h because it also contains isnanf, which was removed in JDK16 by "JDK-8249612: Remove unused ISNANF and ISNAND from jdk_util_md.h" after removing its usage by "JDK-8199424: consider removing ObjectInputStream and ObjectOutputStream native methods" in JDK14. > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html This pull request has now been integrated. Changeset: 49f91052 Author: Aleksei Voitylov Committer: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/49f91052b8930b23ceff7399151e4225762bd13d Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8252250: isnanf is obsolete Reviewed-by: vkempik Backport-of: b957d802e6982be56d3a344668d8fd230f20d0df ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/851 From shade at openjdk.java.net Thu Mar 10 08:38:03 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 08:38:03 GMT Subject: [jdk11u-dev] RFR: 8282225: GHA: Allow one concurrent run per PR only Message-ID: Clean backport to improve GHA performance. ------------- Commit messages: - Backport aaab2cb41666af8520fd01de70e2c4f9c87ef5fd Changes: https://git.openjdk.java.net/jdk11u-dev/pull/870/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=870&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282225 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/870.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/870/head:pull/870 PR: https://git.openjdk.java.net/jdk11u-dev/pull/870 From shade at openjdk.java.net Thu Mar 10 08:56:04 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 08:56:04 GMT Subject: [jdk17u-dev] RFR: 8279958: Provide configure hints for Alpine/apk package managers Message-ID: Clean backport to improve Alpine port. ------------- Commit messages: - Backport a30aa52b77931bcea38213cf3d243d18a37dc858 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/225/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=225&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279958 Stats: 25 lines in 1 file changed: 23 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/225.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/225/head:pull/225 PR: https://git.openjdk.java.net/jdk17u-dev/pull/225 From shade at openjdk.java.net Thu Mar 10 08:57:14 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 08:57:14 GMT Subject: [jdk18u] RFR: 8279958: Provide configure hints for Alpine/apk package managers Message-ID: Clean backport to improve Alpine port. ------------- Commit messages: - Backport a30aa52b77931bcea38213cf3d243d18a37dc858 Changes: https://git.openjdk.java.net/jdk18u/pull/38/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=38&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279958 Stats: 25 lines in 1 file changed: 23 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/38.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/38/head:pull/38 PR: https://git.openjdk.java.net/jdk18u/pull/38 From avoitylov at openjdk.java.net Thu Mar 10 08:57:43 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 10 Mar 2022 08:57:43 GMT Subject: [jdk11u-dev] Integrated: 8252248: __SIGRTMAX is not declared in musl libc In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 08:25:51 GMT, Aleksei Voitylov wrote: > JDK-8252248 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Compared to original changeset this backport looks cosmetically different in #ifdefs in NativeThread.c because of another code layout due to "8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports". > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html This pull request has now been integrated. Changeset: e18126a2 Author: Aleksei Voitylov Committer: Alexander Scherbatiy URL: https://git.openjdk.java.net/jdk11u-dev/commit/e18126a2b92b14ddc134d303c30cef5450cc87d8 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod 8252248: __SIGRTMAX is not declared in musl libc Reviewed-by: stuefe Backport-of: 5490b03160deff68a92a8af5ff012db96aad05d8 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/850 From avoitylov at openjdk.java.net Thu Mar 10 09:04:45 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 10 Mar 2022 09:04:45 GMT Subject: [jdk11u-dev] Integrated: 8245938: Remove unused print_stack(void) method from XToolkit.c In-Reply-To: References: Message-ID: On Thu, 3 Mar 2022 08:21:27 GMT, Aleksei Voitylov wrote: > JDK-8245938 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Applies cleanly. > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html This pull request has now been integrated. Changeset: c3628a25 Author: Aleksei Voitylov Committer: Alexander Scherbatiy URL: https://git.openjdk.java.net/jdk11u-dev/commit/c3628a25a842b7ef2336cd6d14d2e94b7c5d9179 Stats: 23 lines in 1 file changed: 0 ins; 23 del; 0 mod 8245938: Remove unused print_stack(void) method from XToolkit.c Backport-of: 2845c3d02979cf51308fff7ce1198d2882bbb6ff ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/849 From avoitylov at openjdk.java.net Thu Mar 10 09:08:50 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 10 Mar 2022 09:08:50 GMT Subject: [jdk11u-dev] Integrated: 8217340: Compilation failed: tools/launcher/Test7029048.java In-Reply-To: References: Message-ID: <2JWmloWkwAhfUSa9f0XFjZC5bncIDzUkcXXyOGhLbTg=.04cb3bdb-2e52-4eb3-82b5-1141daee97a9@github.com> On Thu, 3 Mar 2022 08:08:53 GMT, Aleksei Voitylov wrote: > JDK-8217340 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Original changeset does not apply cleanly because comment line was changed to javadoc-style from "/*" to "/**" as part of "8216265: [testbug] Introduce Platform.sharedLibraryPathVariableName() and adapt all tests", which is irrelevant and too large to backport. > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html This pull request has now been integrated. Changeset: 7d3db81f Author: Aleksei Voitylov Committer: Alexander Scherbatiy URL: https://git.openjdk.java.net/jdk11u-dev/commit/7d3db81ff2bd4fa09bfd67903b9617fdf1c1fce1 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8217340: Compilation failed: tools/launcher/Test7029048.java Backport-of: e16b29942039d33cbd1ab15ed0a8154efa7ac55f ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/848 From goetz at openjdk.java.net Thu Mar 10 09:18:12 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 09:18:12 GMT Subject: [jdk11u-dev] RFR: 8220813: update hotspot tier1_gc tests depending on GC to use @requires vm.gc.X Message-ID: I backport this for parity with 11.0.16-oracle. I had to resolve quite some files, mostly because "8214799: Add package declaration to each JTREG test case in the gc folder" Is not in 11. I looked at backporting that chagne. It would simplify backporting gc test changes, but requires a lot of work itself. So I decided to resolve this change. TestMetaSpaceLog.java is not in 11, so I skipped the changes to that file. ------------- Commit messages: - Backport e6ace7be6f8c5e43806842aa0d8aea210593a7a2 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/871/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=871&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8220813 Stats: 437 lines in 32 files changed: 350 ins; 16 del; 71 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/871.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/871/head:pull/871 PR: https://git.openjdk.java.net/jdk11u-dev/pull/871 From goetz at openjdk.java.net Thu Mar 10 09:33:54 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 09:33:54 GMT Subject: [jdk17u-dev] RFR: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support In-Reply-To: References: Message-ID: <-kKm2Ww1gL0RORoknUZ2KnO7uDCJ4pMQgPo6IZ5NCP0=.7072465f-8ed1-43da-82bd-99f438ff4764@github.com> On Wed, 9 Mar 2022 14:43:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Pre-submit failure: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 fails. This is unrelated. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/217 From clanger at openjdk.java.net Thu Mar 10 10:24:54 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 10 Mar 2022 10:24:54 GMT Subject: [jdk17u-dev] RFR: 8269135: TestDifferentProtectionDomains runs into timeout in client VM In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:26:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/213 From goetz at openjdk.java.net Thu Mar 10 11:14:42 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 11:14:42 GMT Subject: [jdk11u-dev] RFR: 8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit In-Reply-To: References: Message-ID: <1bFYJVRlx2l_xlFT6Wc298xCjBwRyMAFUseFT8GPWYs=.08ccca63-5502-41e1-870f-208c8bf66695@github.com> On Wed, 9 Mar 2022 10:47:54 GMT, Martin Doerr wrote: > Backport of [JDK-8216137](https://bugs.openjdk.java.net/browse/JDK-8216137) (including [JDK-8219520](https://bugs.openjdk.java.net/browse/JDK-8219520) as in original commit) > loopTransform.cpp (introduction of `AutoNodeBudget`) and loopnode.hpp required manual integration. Rest applies cleanly. LGTM Pre-submit failures: dependencies missing. ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/868 From goetz at openjdk.java.net Thu Mar 10 11:16:43 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 11:16:43 GMT Subject: [jdk11u-dev] RFR: 8179503: Java should support GET OCSP calls [v2] In-Reply-To: <861H92b5UmmXqVXSRFATJy06EI1meeKW1-Ym7V_RjKE=.9e8b993b-d18f-46a1-a7fb-049c3d2f87eb@github.com> References: <861H92b5UmmXqVXSRFATJy06EI1meeKW1-Ym7V_RjKE=.9e8b993b-d18f-46a1-a7fb-049c3d2f87eb@github.com> Message-ID: On Wed, 2 Mar 2022 14:06:44 GMT, Alexey Pavlyutkin wrote: >> Hello! I'd like to backport >> >> 8179503: Java should support GET OCSP calls (dependency) >> >> to jdk11u-dev. This one is required as a dependency for >> >> 8274471: Add support for RSASSA-PSS in OCSP Response >> >> The following changes were done to apply original patch: >> >> src/java.base/share/classes/sun/security/provider/certpath/OCSP.java >> >> - resolved baseline conflict taking place due to absent revocation checking code >> >> The rest of the code applied without changes >> >> Verification/regression (20.04/amd64): jdk_security > > Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: > > reverts copyright year Thanks for the tests, the failures are unrelated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/847 From pkumaraswamy at openjdk.java.net Thu Mar 10 11:45:09 2022 From: pkumaraswamy at openjdk.java.net (Prajwal Kumaraswamy) Date: Thu, 10 Mar 2022 11:45:09 GMT Subject: [jdk18u] Integrated: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake In-Reply-To: References: Message-ID: On Mon, 7 Mar 2022 05:29:32 GMT, Prajwal Kumaraswamy wrote: > This is a clean backport. > The fix has been confirmed by running against internal test suite and JCK SSL tests, where the initial failure was observed in test api/javax_net/ssl/SSLSocket/setUseClientMode.html This pull request has now been integrated. Changeset: afae4921 Author: Prajwal Kumaraswamy Committer: Sean Coffey URL: https://git.openjdk.java.net/jdk18u/commit/afae4921532ea6dacc292936e8fedb9a3bfc9f2d Stats: 151 lines in 2 files changed: 151 ins; 0 del; 0 mod 8274524: SSLSocket.close() hangs if it is called during the ssl handshake Backport-of: 58dae60da0711c4ae0cb23f8ce2328e051d603b2 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/33 From shade at openjdk.java.net Thu Mar 10 11:55:21 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 11:55:21 GMT Subject: [jdk18u] RFR: 8279668: x86: AVX2 versions of vpxor should be asserted Message-ID: Clean backport to prevent SIGILLs on incompatible hardware. Additional testing: - [ ] Linux x86_64 fastdebug with `-XX:UseAVX=1` ------------- Commit messages: - Backport 2bbeae3f056243a224b0bda021f16cdcbee3b3d6 Changes: https://git.openjdk.java.net/jdk18u/pull/39/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=39&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279668 Stats: 15 lines in 2 files changed: 12 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk18u/pull/39.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/39/head:pull/39 PR: https://git.openjdk.java.net/jdk18u/pull/39 From shade at openjdk.java.net Thu Mar 10 11:56:02 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 11:56:02 GMT Subject: [jdk11u-dev] RFR: 8279668: x86: AVX2 versions of vpxor should be asserted Message-ID: Clean backport to prevent SIGILLs on incompatible hardware. Additional testing: - [ ] Linux x86_64 fastdebug with -XX:UseAVX=1 ------------- Commit messages: - Backport 2bbeae3f056243a224b0bda021f16cdcbee3b3d6 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/872/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=872&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279668 Stats: 15 lines in 2 files changed: 12 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/872.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/872/head:pull/872 PR: https://git.openjdk.java.net/jdk11u-dev/pull/872 From shade at openjdk.java.net Thu Mar 10 11:56:07 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 11:56:07 GMT Subject: [jdk17u-dev] RFR: 8279668: x86: AVX2 versions of vpxor should be asserted Message-ID: Clean backport to prevent SIGILLs on incompatible hardware. Additional testing: - [ ] Linux x86_64 fastdebug with -XX:UseAVX=1 ------------- Commit messages: - Backport 2bbeae3f056243a224b0bda021f16cdcbee3b3d6 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/226/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=226&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279668 Stats: 15 lines in 2 files changed: 12 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/226.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/226/head:pull/226 PR: https://git.openjdk.java.net/jdk17u-dev/pull/226 From duke at openjdk.java.net Thu Mar 10 12:01:49 2022 From: duke at openjdk.java.net (Evgeny Astigeevich) Date: Thu, 10 Mar 2022 12:01:49 GMT Subject: [jdk15u-dev] Integrated: 8186670: Implement _onSpinWait() intrinsic for AArch64 In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 15:43:41 GMT, Evgeny Astigeevich wrote: > A backport of a configurable implementation of _onSpinWait() intrinsic to achieve parity with x86 which has it implemented. > The risk of changes is low. By default it is off. > Tested for fastdebug and release builds: > > - `gtest`: Passed > - `tier1`...`tier3`: Passed except [JDK-8261534](https://bugs.openjdk.java.net/browse/JDK-8261534) and [JDK-8277488](https://bugs.openjdk.java.net/browse/JDK-8277488) > - `hotspot/jtreg/compiler/onSpinWait`: Passed > > Applying the patch had issues to find proper positions. No code changes are needed after repositioning. > Changes to `globals_aarch64.hpp` needed the new added options definitions to be converted from the new format to the old one. `vm.flagless` was removed from the new tests. > Changes to `vm_version_aarch64.cpp`, instantiation of `SpinWait`, use C++11 syntax. They needed to be changed to C++03 syntax. This pull request has now been integrated. Changeset: e972e77a Author: Evgeny Astigeevich Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk15u-dev/commit/e972e77af38d4cd4c1e6e3e408b3a5c2909aaa46 Stats: 765 lines in 13 files changed: 763 ins; 0 del; 2 mod 8186670: Implement _onSpinWait() intrinsic for AArch64 Reviewed-by: phh Backport-of: 6954b98f8faf29b6c2d13687a7a94e83302bdd85 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/181 From duke at openjdk.java.net Thu Mar 10 12:03:48 2022 From: duke at openjdk.java.net (Evgeny Astigeevich) Date: Thu, 10 Mar 2022 12:03:48 GMT Subject: [jdk15u-dev] Integrated: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 In-Reply-To: <8WsMYmsmykXQ2gPZq80NE21-8R3EEJ7uIYAALXZI6-Q=.b0b4656f-27db-4fdc-91eb-8a288d4af89b@github.com> References: <8WsMYmsmykXQ2gPZq80NE21-8R3EEJ7uIYAALXZI6-Q=.b0b4656f-27db-4fdc-91eb-8a288d4af89b@github.com> Message-ID: <0hN0smIPJ-TDROx_qRqok3C_G7DOE9cf9lP5ikVX8z0=.454c4add-a324-45a6-8b95-0c79d8aa87f7@github.com> On Wed, 23 Feb 2022 17:02:47 GMT, Evgeny Astigeevich wrote: > A backport to fix an issue with the test. When it is applied it has a conflict with a Copyright line. No other conflicts. This pull request has now been integrated. Changeset: bfe6f7c9 Author: Evgeny Astigeevich Committer: Paul Hohensee URL: https://git.openjdk.java.net/jdk15u-dev/commit/bfe6f7c97a7c98c65ef91e46de1bae21fc2dc362 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022 Backport-of: d3749de47832c6de4bcee9cf64a0b698e796b2f2 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/183 From goetz at openjdk.java.net Thu Mar 10 12:37:04 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 12:37:04 GMT Subject: [jdk17u-dev] RFR: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:02:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. > > I had to resolve the ProblemList because of 8271877: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK17 > As I understand the fix it is platform agnostic, so removing all platforms is fine. Pre-submit test failure gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 unrelated. I saw this in other runs of today, too. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/211 From goetz at openjdk.java.net Thu Mar 10 12:39:57 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 12:39:57 GMT Subject: [jdk17u-dev] Integrated: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:02:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. > > I had to resolve the ProblemList because of 8271877: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java in JDK17 > As I understand the fix it is platform agnostic, so removing all platforms is fine. This pull request has now been integrated. Changeset: 365e4ced Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/365e4ced9c39950af879446032d89888eb872b61 Stats: 70 lines in 3 files changed: 21 ins; 37 del; 12 mod 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure Reviewed-by: mdoerr Backport-of: ee0247f056daea7a0afdd572d13fb30f5164e889 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/211 From goetz at openjdk.java.net Thu Mar 10 12:40:53 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 12:40:53 GMT Subject: [jdk17u-dev] Integrated: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:21:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: ba26525e Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/ba26525e29f457a93851e5c9cfd35e031a06008c Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum Backport-of: a0f32cb1406e4957e84befd9b68444adb662bd13 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/212 From goetz at openjdk.java.net Thu Mar 10 12:41:53 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 12:41:53 GMT Subject: [jdk17u-dev] Integrated: 8269135: TestDifferentProtectionDomains runs into timeout in client VM In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:26:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 97096d87 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/97096d87010afef5d56cc43b87bcd1f20ac3a428 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod 8269135: TestDifferentProtectionDomains runs into timeout in client VM Reviewed-by: clanger Backport-of: 53ad903a820b6892dbb273357defe7cf5c7e24ab ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/213 From goetz at openjdk.java.net Thu Mar 10 12:44:51 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 12:44:51 GMT Subject: [jdk17u-dev] RFR: 8263538: SharedArchiveConsistency.java should test -Xshare:auto as well In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:29:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Pre-submit failure: github issue: Cannot find path 'D:\a\jdk17u-dev\jdk17u-dev\build' because it does not exist. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/214 From goetz at openjdk.java.net Thu Mar 10 12:46:55 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 12:46:55 GMT Subject: [jdk17u-dev] RFR: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:43:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Pre-submit failure: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 This failed in several runs tonight. Unrelated ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/217 From shade at openjdk.java.net Thu Mar 10 13:22:46 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 13:22:46 GMT Subject: [jdk11u-dev] RFR: 8282225: GHA: Allow one concurrent run per PR only In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 08:29:41 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA performance. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/870 From shade at openjdk.java.net Thu Mar 10 13:22:46 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 13:22:46 GMT Subject: [jdk11u-dev] Integrated: 8282225: GHA: Allow one concurrent run per PR only In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 08:29:41 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA performance. This pull request has now been integrated. Changeset: 194b66f6 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/194b66f6a72437345c458e747e24beb46352537a Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8282225: GHA: Allow one concurrent run per PR only Backport-of: aaab2cb41666af8520fd01de70e2c4f9c87ef5fd ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/870 From avoitylov at openjdk.java.net Thu Mar 10 13:26:17 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 10 Mar 2022 13:26:17 GMT Subject: [jdk11u-dev] RFR: 8247592: refactor test/jdk/tools/launcher/Test7029048.java Message-ID: JDK-8247592 is in the only issue in the second batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. Original changeset does not apply cleanly because of "8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports", which removed Solaris-specific code from affected test. Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html ------------- Commit messages: - 8247592 backport to 11u Changes: https://git.openjdk.java.net/jdk11u-dev/pull/873/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=873&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8247592 Stats: 84 lines in 1 file changed: 21 ins; 46 del; 17 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/873.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/873/head:pull/873 PR: https://git.openjdk.java.net/jdk11u-dev/pull/873 From goetz at openjdk.java.net Thu Mar 10 13:31:50 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:31:50 GMT Subject: [jdk17u-dev] Integrated: 8263538: SharedArchiveConsistency.java should test -Xshare:auto as well In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:29:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 3e7cbd22 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/3e7cbd2256d39097507a1f7139b7aa6ea99c2028 Stats: 41 lines in 1 file changed: 26 ins; 3 del; 12 mod 8263538: SharedArchiveConsistency.java should test -Xshare:auto as well Backport-of: e8206dbb1758325ce10ac23768c82cb567eed704 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/214 From goetz at openjdk.java.net Thu Mar 10 13:34:46 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:34:46 GMT Subject: [jdk17u-dev] Integrated: 8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:32:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: f25a8fc5 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/f25a8fc5e1cb063ee3625337502dc0402169d3d2 Stats: 12 lines in 2 files changed: 4 ins; 0 del; 8 mod 8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFailure.java Backport-of: 4a45d95719bf68221e6843572511c2eb741ba69c ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/215 From goetz at openjdk.java.net Thu Mar 10 13:36:52 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:36:52 GMT Subject: [jdk17u-dev] Integrated: 8270837: fix typos in test TestSigParse.java In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:35:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 1e25ca92 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/1e25ca92ce4fe97c6236a6bdc47d4c5bbcf6641a Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8270837: fix typos in test TestSigParse.java Backport-of: 67dc1c5bf34cfe987b672f34f0b2a6b36840382a ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/216 From goetz at openjdk.java.net Thu Mar 10 13:39:18 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:39:18 GMT Subject: [jdk17u-dev] RFR: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform Message-ID: <6FbRs8w6IlrOItYS0XGcVAOzfF5I0F8EFGOw5nQcY00=.ae30b9ad-e277-4a84-b576-88aa7b2bfb6e@github.com> I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport cb112affd6061e8ace6dad4e92c7b394a413e37f Changes: https://git.openjdk.java.net/jdk17u-dev/pull/227/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=227&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269373 Stats: 14 lines in 2 files changed: 12 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/227.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/227/head:pull/227 PR: https://git.openjdk.java.net/jdk17u-dev/pull/227 From goetz at openjdk.java.net Thu Mar 10 13:41:52 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:41:52 GMT Subject: [jdk17u-dev] Integrated: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:43:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 722964b2 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/722964b2ab7fb074bb40c55ade28549452f54bef Stats: 27 lines in 1 file changed: 15 ins; 0 del; 12 mod 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support Backport-of: 6346793c6401b3758edf0a8912acb0fd8813957b ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/217 From goetz at openjdk.java.net Thu Mar 10 13:43:53 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:43:53 GMT Subject: [jdk17u-dev] Integrated: 8270336: [TESTBUG] Fix initialization in NonbranchyTree In-Reply-To: <2HV7xfTl3D8ymx4YJ3maQ0-hECR_vK7Ii0ZTw3pSpmE=.fbcc7c21-bccb-48e2-895b-805a6e0a1520@github.com> References: <2HV7xfTl3D8ymx4YJ3maQ0-hECR_vK7Ii0ZTw3pSpmE=.fbcc7c21-bccb-48e2-895b-805a6e0a1520@github.com> Message-ID: <0IeLHxikgk1OKpbopf_FoS_fgbK6nroW9C_HGgnQ2_Y=.d7447a3e-7cdf-4943-b315-079091e6bf93@github.com> On Wed, 9 Mar 2022 14:51:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: eb076ae1 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/eb076ae137f8c181e5a7f3850730eb20390ce9f4 Stats: 30 lines in 1 file changed: 4 ins; 17 del; 9 mod 8270336: [TESTBUG] Fix initialization in NonbranchyTree Backport-of: 3cadc3606073f0efc2e97dda348ffb65c41dad0c ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/218 From goetz at openjdk.java.net Thu Mar 10 13:45:47 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:45:47 GMT Subject: [jdk17u-dev] Integrated: 8269753: Misplaced caret in PatternSyntaxException's detail message In-Reply-To: References: Message-ID: <_8OlbPmdKp1KiCdqxl2W3azGZ5SYd2ePkG4_TTpD-84=.4989f906-ffdc-4f93-ad50-e8f3ef2eb0b7@github.com> On Wed, 9 Mar 2022 15:01:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 6fb49c33 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/6fb49c330dc1f7f74bf1977ab4e45b4d123a2c7a Stats: 24 lines in 2 files changed: 21 ins; 0 del; 3 mod 8269753: Misplaced caret in PatternSyntaxException's detail message Backport-of: bb508e13032c3571c48275391dfeb04c03bbf3a3 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/219 From goetz at openjdk.java.net Thu Mar 10 13:50:52 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:50:52 GMT Subject: [jdk17u-dev] Integrated: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 15:20:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: f79a4edd Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/f79a4edd692b77298c58fdbddf126bd904d49488 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code Backport-of: 68dd8280886ede7f5cd8d34811ad0f9ffac440f3 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/220 From duke at openjdk.java.net Thu Mar 10 13:51:54 2022 From: duke at openjdk.java.net (Campbell Jones) Date: Thu, 10 Mar 2022 13:51:54 GMT Subject: [jdk11u] Withdrawn: 8229258: Backport patch from JDK 14 to allow building with Clang 13 In-Reply-To: References: Message-ID: On Sun, 19 Dec 2021 02:55:01 GMT, Campbell Jones wrote: > This patch backports changes from JDK14 commit ae5615c6142a4dc0d9033462f4880d7b3c127e26. It does not rename the class to markWord as the original patch does, but instead converts markOop to a markWord equivalent in-place. This patch allows the JDK to be built with Clang 13, as it avoids undefined behavior. > > See the following for more information: > - https://bugs.openjdk.java.net/browse/JDK-8229258 > - https://bugs.gentoo.org/817995 > - https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038704.html > - https://mail.openjdk.java.net/pipermail/hotspot-dev/2019-July/038712.html > - https://reviews.llvm.org/D99790#2678384 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u/pull/23 From goetz at openjdk.java.net Thu Mar 10 13:53:21 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:53:21 GMT Subject: [jdk17u-dev] RFR: 8274233: Minor cleanup for ToolBox Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport e741a18062061c1959f7881503aaf3a4cbcae776 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/228/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=228&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274233 Stats: 111 lines in 1 file changed: 47 ins; 12 del; 52 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/228.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/228/head:pull/228 PR: https://git.openjdk.java.net/jdk17u-dev/pull/228 From goetz at openjdk.java.net Thu Mar 10 13:53:54 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:53:54 GMT Subject: [jdk17u-dev] Integrated: 8272169: runtime/logging/LoaderConstraintsTest.java doesn't build test.Empty In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 15:21:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: d4134692 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/d41346927d77ea52d0fb608c35985b6c473510ea Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8272169: runtime/logging/LoaderConstraintsTest.java doesn't build test.Empty Backport-of: eb6f3fe59d469a369383a750d319318909cf8613 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/221 From mdoerr at openjdk.java.net Thu Mar 10 13:54:49 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Mar 2022 13:54:49 GMT Subject: [jdk11u-dev] Integrated: 8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 10:47:54 GMT, Martin Doerr wrote: > Backport of [JDK-8216137](https://bugs.openjdk.java.net/browse/JDK-8216137) (including [JDK-8219520](https://bugs.openjdk.java.net/browse/JDK-8219520) as in original commit) > loopTransform.cpp (introduction of `AutoNodeBudget`) and loopnode.hpp required manual integration. Rest applies cleanly. This pull request has now been integrated. Changeset: 04d8f98c Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/04d8f98cd19262e9de3b13fe1fbb6d6c595b170e Stats: 266 lines in 5 files changed: 181 ins; 24 del; 61 mod 8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit Adding simplistic node budget support for loop-transformations. This /should/attempts to/ resolve most cases of: "assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit". Reviewed-by: goetz Backport-of: e08506e6831667c17f1197345261f4c5e34294dc ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/868 From mdoerr at openjdk.java.net Thu Mar 10 13:54:49 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Mar 2022 13:54:49 GMT Subject: [jdk11u-dev] RFR: 8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 10:47:54 GMT, Martin Doerr wrote: > Backport of [JDK-8216137](https://bugs.openjdk.java.net/browse/JDK-8216137) (including [JDK-8219520](https://bugs.openjdk.java.net/browse/JDK-8219520) as in original commit) > loopTransform.cpp (introduction of `AutoNodeBudget`) and loopnode.hpp required manual integration. Rest applies cleanly. Thanks for the review and the approval! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/868 From mdoerr at openjdk.java.net Thu Mar 10 13:55:56 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Mar 2022 13:55:56 GMT Subject: [jdk17u-dev] Integrated: 8279515: C1: No inlining through invokedynamic and invokestatic call sites when resolved class is not linked In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 13:18:42 GMT, Martin Doerr wrote: > Clean backport of [JDK-8279515](https://bugs.openjdk.java.net/browse/JDK-8279515) This pull request has now been integrated. Changeset: d3dc0cda Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/d3dc0cdaf8f2c47bfbd943b20250c9a1b2a36b51 Stats: 166 lines in 4 files changed: 162 ins; 0 del; 4 mod 8279515: C1: No inlining through invokedynamic and invokestatic call sites when resolved class is not linked Backport-of: ad34f03b549e6f37825efc3e554d2232b557611a ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/209 From goetz at openjdk.java.net Thu Mar 10 13:57:50 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:57:50 GMT Subject: [jdk17u-dev] Integrated: 8272146: Disable Fibonacci test on memory constrained systems In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 15:26:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: feeb4180 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/feeb4180c81c89a6c108a8d16c9020c6b549b47a Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8272146: Disable Fibonacci test on memory constrained systems Backport-of: adba09b91de2e86fe4eb844c9066a23b176176bd ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/222 From goetz at openjdk.java.net Thu Mar 10 13:59:45 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:59:45 GMT Subject: [jdk17u-dev] RFR: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 15:32:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Pre-submit failure java.lang.Error: compilation failed. rc=1 in tools/javac/annotations/typeAnnotations/referenceinfos/RepeatingTypeAnnotations.java Unrelated. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/223 From goetz at openjdk.java.net Thu Mar 10 13:59:46 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 13:59:46 GMT Subject: [jdk17u-dev] Integrated: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 15:32:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: d5e4f031 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/d5e4f03179cd34eb939ba63c9799db4ac7301650 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped Backport-of: 041ae20b10e11381415e8f61fd39e9e19aa8d4f2 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/223 From goetz at openjdk.java.net Thu Mar 10 14:03:48 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 14:03:48 GMT Subject: [jdk11u-dev] RFR: 8212151: jdi/ExclusiveBind.java times out due to "bind failed: Address already in use" on Solaris-X64 In-Reply-To: <8fYoJXpa8lwEaVURysIQo1ye8Up5_xRHnrZOnVn_rXU=.28cb010f-9153-4dbf-8bee-ec8f2c8e77d4@github.com> References: <8fYoJXpa8lwEaVURysIQo1ye8Up5_xRHnrZOnVn_rXU=.28cb010f-9153-4dbf-8bee-ec8f2c8e77d4@github.com> Message-ID: On Mon, 7 Mar 2022 19:21:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to resolve the whole change because it is one hunk that does not apply because changes to the test description are not backported (8210112: remove jdk.testlibrary.ProcessTools; 8210732: remove jdk.testlibrary.Utils) > > I resolved the test to be the same as head. Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/859 From goetz at openjdk.java.net Thu Mar 10 14:03:49 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 14:03:49 GMT Subject: [jdk11u-dev] Integrated: 8212151: jdi/ExclusiveBind.java times out due to "bind failed: Address already in use" on Solaris-X64 In-Reply-To: <8fYoJXpa8lwEaVURysIQo1ye8Up5_xRHnrZOnVn_rXU=.28cb010f-9153-4dbf-8bee-ec8f2c8e77d4@github.com> References: <8fYoJXpa8lwEaVURysIQo1ye8Up5_xRHnrZOnVn_rXU=.28cb010f-9153-4dbf-8bee-ec8f2c8e77d4@github.com> Message-ID: On Mon, 7 Mar 2022 19:21:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to resolve the whole change because it is one hunk that does not apply because changes to the test description are not backported (8210112: remove jdk.testlibrary.ProcessTools; 8210732: remove jdk.testlibrary.Utils) > > I resolved the test to be the same as head. This pull request has now been integrated. Changeset: 7d167194 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/7d1671948de83a7776911bfce1f3af48eaa3e004 Stats: 332 lines in 3 files changed: 191 ins; 109 del; 32 mod 8212151: jdi/ExclusiveBind.java times out due to "bind failed: Address already in use" on Solaris-X64 Reviewed-by: phh Backport-of: b4cb7d6fc7237e6f25ec876887c66d62f1cd6214 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/859 From goetz at openjdk.java.net Thu Mar 10 14:05:47 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 14:05:47 GMT Subject: [jdk11u-dev] RFR: 8208697: vmTestbase/metaspace/stressHierarchy/stressHierarchy012/TestDescription.java fails with OutOfMemoryError: Metaspace In-Reply-To: <0oEVLr3U9IJ8c4LHQlwIHrn5FzfK-QYgGPU61nYYo4U=.ff2aefea-c754-44f4-93e5-b725206717d8@github.com> References: <0oEVLr3U9IJ8c4LHQlwIHrn5FzfK-QYgGPU61nYYo4U=.ff2aefea-c754-44f4-93e5-b725206717d8@github.com> Message-ID: On Wed, 9 Mar 2022 10:31:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > ProblemList: skipped, tests are not Problem Listed. Pre-submit failures: runtime/Thread/StopAtExit.java seen in several tests, unrelated others: missing dependencies ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/867 From goetz at openjdk.java.net Thu Mar 10 14:05:48 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 14:05:48 GMT Subject: [jdk11u-dev] Integrated: 8208697: vmTestbase/metaspace/stressHierarchy/stressHierarchy012/TestDescription.java fails with OutOfMemoryError: Metaspace In-Reply-To: <0oEVLr3U9IJ8c4LHQlwIHrn5FzfK-QYgGPU61nYYo4U=.ff2aefea-c754-44f4-93e5-b725206717d8@github.com> References: <0oEVLr3U9IJ8c4LHQlwIHrn5FzfK-QYgGPU61nYYo4U=.ff2aefea-c754-44f4-93e5-b725206717d8@github.com> Message-ID: On Wed, 9 Mar 2022 10:31:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > ProblemList: skipped, tests are not Problem Listed. This pull request has now been integrated. Changeset: 87703322 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/87703322e980e42035d7cf101f04cafdc31fe278 Stats: 592 lines in 10 files changed: 0 ins; 566 del; 26 mod 8208697: vmTestbase/metaspace/stressHierarchy/stressHierarchy012/TestDescription.java fails with OutOfMemoryError: Metaspace Remove timeoutHandler class and let Stresser handle timeout, remove 30 threads filling metaspace, and remove related unused files. Reviewed-by: mdoerr Backport-of: 7445ebf02bca4111a6c98fefb42819b28212f19a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/867 From mdoerr at openjdk.java.net Thu Mar 10 14:18:16 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Mar 2022 14:18:16 GMT Subject: [jdk11u-dev] RFR: 8223363: Bad node estimate assertion failure Message-ID: <59AJzX53ijc0BmatQBOnlkRTtBvky5dVTlsNIOGQOWo=.29c9c4de-a7af-4b53-8dce-4de7e62e4477@github.com> Backport of [JDK-8223363](https://bugs.openjdk.java.net/browse/JDK-8223363) (including [JDK-8223502](https://bugs.openjdk.java.net/browse/JDK-8223502) and [JDK-8224648](https://bugs.openjdk.java.net/browse/JDK-8224648) as in original commit) loopTransform.cpp (introduction of `policy_unswitching` and `policy_maximally_unroll`) and loopnode.hpp required manual integration. Rest applies cleanly. ------------- Commit messages: - Backport d222b01dee09f9963a3a0c7ae0088b64752b7809 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/874/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=874&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8223363 Stats: 443 lines in 6 files changed: 310 ins; 37 del; 96 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/874.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/874/head:pull/874 PR: https://git.openjdk.java.net/jdk11u-dev/pull/874 From goetz at openjdk.java.net Thu Mar 10 14:21:03 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 14:21:03 GMT Subject: [jdk11u-dev] RFR: 8218751: Do not store original classfiles inside the CDS archive Message-ID: I backport this for parity with 11.0.16-oracle. src/hotspot/share/classfile/systemDictionary.cpp src/hotspot/share/classfile/systemDictionaryShared.cpp Resolved. Context differs. src/hotspot/share/memory/metaspaceShared.cpp/hpp Resolved a lot of code. _total_string_region_size renamed in 13, changes to INCLUDE_JVMTI etc in context. src/hotspot/share/runtime/mutexLocker.cpp/hpp Trivial resolve. ------------- Commit messages: - Backport d06f3e7e28bd1baf00b903a7c6b2f18965e73311 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/875/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=875&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8218751 Stats: 229 lines in 16 files changed: 97 ins; 101 del; 31 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/875.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/875/head:pull/875 PR: https://git.openjdk.java.net/jdk11u-dev/pull/875 From goetz at openjdk.java.net Thu Mar 10 14:27:19 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 14:27:19 GMT Subject: [jdk17u-dev] RFR: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport b7b78ff1f380d19214dbca48455772bc87cc137d Changes: https://git.openjdk.java.net/jdk17u-dev/pull/229/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=229&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274561 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/229.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/229/head:pull/229 PR: https://git.openjdk.java.net/jdk17u-dev/pull/229 From sgehwolf at openjdk.java.net Thu Mar 10 14:33:56 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 10 Mar 2022 14:33:56 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy In-Reply-To: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Tue, 8 Mar 2022 18:47:32 GMT, Zhengyu Gu wrote: > This is a followup backport for Cgroup v2 support. > > The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. > > In additional: > > 1) Include partial backport of JDK-8250627. > - Renamed `Metrics.c` => `CgroupMetrics.c` > - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` > - Return instance only if `isUseContainerSupport()` is enabled. > > 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test > > 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` > > Test: > > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS Hi Zhengyu! Here is the first round of review comments. This is a bit hairy as we are doing backports out of orderand we need to be careful not to drop an already backported patch (applied to the old location which is now moved with this). I'll run this through my own testing, too. Thanks, Severin src/java.base/linux/classes/jdk/internal/platform/CgroupUtil.java line 48: > 46: unwrapIOExceptionAndRethrow(e); > 47: throw new InternalError(e.getCause()); > 48: } Missing hunks of JDK-8255908: See https://github.com/openjdk/jdk/commit/8d9cf48e#diff-96f6e99fbc0d093a8b423d1a3fc86c0408768b2bb10747d926832d9286c6b3bbR49 src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java line 80: > 78: } catch (IOException e) { > 79: return null; > 80: } I believe the original, `Metrics.java` had a catch for `UncheckedIOException` here that's now gone. https://github.com/openjdk/jdk11u-dev/blob/194b66f6a72437345c458e747e24beb46352537a/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java#L89..L91 Please add it back as it's part of the fix of JDK-8255908. src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java line 108: > 106: CgroupUtil.readFilePrivileged(Paths.get("/proc/self/cgroup"))) { > 107: > 108: lines.map(line -> line.split(":")) We are missing the patch of JDK-8272124 here. Old code was: https://github.com/openjdk/jdk11u-dev/blob/194b66f6a72437345c458e747e24beb46352537a/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java#L119..L122 Best to use the JDK 17u commit as a base for this: See: https://github.com/openjdk/jdk17u/commit/f0028333d83c39b434c26f66a6a92e446e7047cd#diff-7d6f202c58b4205f19a9b6c657f4827e9ef132d7433a7bf906b5b640f9f7841fR197 Looking at this again, we should bring in the test changes of JDK-8272124 too (as we are now bringing in those tests with the cgroups v2 backport). It helps to verify this fix is present as well. src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java line 114: > 112: } catch (IOException e) { > 113: return null; > 114: } Same here: https://github.com/openjdk/jdk11u-dev/blob/194b66f6a72437345c458e747e24beb46352537a/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java#L128..L130 src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java line 168: > 166: controllerName = entry[1]; > 167: base = entry[2]; > 168: if (controllerName != null && base != null) { We are missing the fix of https://bugs.openjdk.java.net/browse/JDK-8254854 here. Old code was: https://github.com/openjdk/jdk11u-dev/blob/194b66f6a72437345c458e747e24beb46352537a/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java#L200..L202 See head commit at the time: https://github.com/openjdk/jdk/commit/a0b687bf src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java line 216: > 214: } > 215: > 216: private void setActiveSubSystems() { function `getSwapEnabled()` from JDK-8250984 is missing here. See: https://github.com/openjdk/jdk11u-dev/blob/194b66f6a72437345c458e747e24beb46352537a/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java#L246..L249 src/java.base/share/classes/sun/launcher/LauncherHelper.java line 844: > 842: if (mainClass.getModule().isNamed()) { > 843: abort(e, "java.launcher.module.error5", > 844: mainClass.getName(), mainClass.getModule().getName(), This seems an unrelated change, please remove. Seems to come from JDK-8221368, not in jdk11u. src/jdk.management/unix/classes/com/sun/management/internal/OperatingSystemImpl.java line 215: > 213: if (deltaLimit <= 0) { > 214: return 0; > 215: } This seems to revert https://bugs.openjdk.java.net/browse/JDK-8242480. Please remove. src/jdk.management/unix/classes/com/sun/management/internal/OperatingSystemImpl.java line 219: > 217: // If this happens just retry the loop for a few iterations. > 218: if ((memSwapUsage - memUsage) >= 0) { > 219: return memSwapLimit - memLimit - (memSwapUsage - memUsage); This seems to revert https://bugs.openjdk.java.net/browse/JDK-8242480. Please remove. src/jdk.management/unix/classes/com/sun/management/internal/OperatingSystemImpl.java line 277: > 275: private boolean isCpuSetSameAsHostCpuSet() { > 276: if (containerMetrics != null && containerMetrics.getCpuSetCpus() != null) { > 277: return containerMetrics.getCpuSetCpus().length == getHostConfiguredCpuCount0(); Line 277 is a partial revert of https://bugs.openjdk.java.net/browse/JDK-8247469. Please remove. Only line 276 is needed. test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java line 30: > 28: > 29: private static final long UNLIMITED = -1; > 30: Seems a revert of https://bugs.openjdk.java.net/browse/JDK-8275713. Please remove. test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java line 77: > 75: // Break out as soon as we see an increase in failcount > 76: // to avoid getting killed by the OOM killer. > 77: if (Metrics.systemMetrics().getMemoryFailCount() > count) { This seems a partial revert of https://bugs.openjdk.java.net/browse/JDK-8250984. Please double check. test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java line 93: > 91: throw new RuntimeException("Memory fail count : new : [" > 92: + Metrics.systemMetrics().getMemoryFailCount() + "]" > 93: + ", old : [" + count + "]"); Same here. Re revert of https://bugs.openjdk.java.net/browse/JDK-8250984. Please check. test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java line 118: > 116: // This feature is deprecated. Only perform the check if we get an actual > 117: // limit back. > 118: if (kmemlimit != UNLIMITED && limit != kmemlimit) { Seems a revert of https://bugs.openjdk.java.net/browse/JDK-8275713. Please remove. test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java line 134: > 132: if (expectedMem != Metrics.systemMetrics().getMemoryLimit() > 133: || expectedMemAndSwap != Metrics.systemMetrics().getMemoryAndSwapLimit()) { > 134: System.err.println("Memory and swap limit not equal, expected : [" Revert of https://bugs.openjdk.java.net/browse/JDK-8250984 ? Please check. test/lib/jdk/test/lib/Utils.java line 784: > 782: Path dir = Paths.get(System.getProperty("user.dir", ".")); > 783: return Files.createTempDirectory(dir, prefix, attrs); > 784: } This looks like a partial backport of https://bugs.openjdk.java.net/browse/JDK-8223396. It's a test-only change, cleanup. Perhaps worth bringing into jdk11u wholesale as a dep? Failing that, rework usages of `Utils.createTempDirectory()`? test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java line 291: > 289: newVal = getLongValueFromFile(Controller.MEMORY, "memory.memsw.failcnt"); > 290: if (!CgroupMetricsTester.compareWithErrorMargin(oldVal, newVal)) { > 291: fail(Controller.MEMORY, "memory.memsw.failcnt", oldVal, newVal); This seems to be missing JDK-8250984 changes (reverts them). Please check. This file is basically a move from `MetricsTester.java`. So we should bring in all the changes it since collected before moving. ------------- Changes requested by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From shade at openjdk.java.net Thu Mar 10 15:12:55 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 15:12:55 GMT Subject: [jdk17u-dev] RFR: 8282225: GHA: Allow one concurrent run per PR only In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 08:19:14 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA performance. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/224 From shade at openjdk.java.net Thu Mar 10 15:12:55 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 15:12:55 GMT Subject: [jdk17u-dev] Integrated: 8282225: GHA: Allow one concurrent run per PR only In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 08:19:14 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA performance. This pull request has now been integrated. Changeset: 863631fa Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u-dev/commit/863631fa6b1b04cc8e10bf01b6dde0e5e609998a Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8282225: GHA: Allow one concurrent run per PR only Backport-of: aaab2cb41666af8520fd01de70e2c4f9c87ef5fd ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/224 From shade at openjdk.java.net Thu Mar 10 15:33:34 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 15:33:34 GMT Subject: [jdk18u] RFR: 8281168: Micro-optimize VarForm.getMemberName for interpreter Message-ID: Clean backport to improve interpreter performance. Additional testing: - [x] Linux x86_64 fastdebug `tier1` ------------- Commit messages: - Backport fc77217814eb1a346d7380299abdc2b01a69b4de Changes: https://git.openjdk.java.net/jdk18u/pull/40/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=40&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281168 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/40.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/40/head:pull/40 PR: https://git.openjdk.java.net/jdk18u/pull/40 From goetz at openjdk.java.net Thu Mar 10 15:41:51 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 15:41:51 GMT Subject: [jdk11u-dev] RFR: 8220813: update hotspot tier1_gc tests depending on GC to use @requires vm.gc.X In-Reply-To: References: Message-ID: <_Mh-r5E7u4QE6JEj8rl1OblL0gZUZhp9yrIrI1IEJM0=.9c87da35-0d77-4464-af92-0c9193c50c52@github.com> On Thu, 10 Mar 2022 09:11:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to resolve quite some files, mostly because "8214799: Add package declaration to each JTREG test case in the gc folder" Is not in 11. > I looked at backporting that chagne. It would simplify backporting gc test changes, but requires a lot of work itself. So I decided to resolve this change. > > TestMetaSpaceLog.java is not in 11, so I skipped the changes to that file. I'll have a second look at the prerequisites of this change, they help with other backports, too. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/871 From goetz at openjdk.java.net Thu Mar 10 15:41:51 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 15:41:51 GMT Subject: [jdk11u-dev] Withdrawn: 8220813: update hotspot tier1_gc tests depending on GC to use @requires vm.gc.X In-Reply-To: References: Message-ID: <0vJUcqV7pk-UwEg9xDvNY1nIlNWGbm8FwZ8nt9mNPxw=.1bf9a652-905d-4659-9ae7-5403e2347c7b@github.com> On Thu, 10 Mar 2022 09:11:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to resolve quite some files, mostly because "8214799: Add package declaration to each JTREG test case in the gc folder" Is not in 11. > I looked at backporting that chagne. It would simplify backporting gc test changes, but requires a lot of work itself. So I decided to resolve this change. > > TestMetaSpaceLog.java is not in 11, so I skipped the changes to that file. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/871 From mdoerr at openjdk.java.net Thu Mar 10 15:46:08 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 10 Mar 2022 15:46:08 GMT Subject: [jdk17u-dev] RFR: 8282509: [exploded image] ResolvedClassTest fails with similar output Message-ID: Clean backport of [JDK-8282509](https://bugs.openjdk.java.net/browse/JDK-8282509) ------------- Commit messages: - Backport 7c8ea9f05b35069e2b5b43e1a0e46f7dbe374e4c Changes: https://git.openjdk.java.net/jdk17u-dev/pull/231/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=231&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282509 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/231.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/231/head:pull/231 PR: https://git.openjdk.java.net/jdk17u-dev/pull/231 From shade at openjdk.java.net Thu Mar 10 15:46:13 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 10 Mar 2022 15:46:13 GMT Subject: [jdk17u-dev] RFR: 8281168: Micro-optimize VarForm.getMemberName for interpreter Message-ID: Clean backport to improve interpreter performance. Additional testing: - [x] Linux x86_64 fastdebug tier1 ------------- Commit messages: - Backport fc77217814eb1a346d7380299abdc2b01a69b4de Changes: https://git.openjdk.java.net/jdk17u-dev/pull/230/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=230&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281168 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/230.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/230/head:pull/230 PR: https://git.openjdk.java.net/jdk17u-dev/pull/230 From goetz at openjdk.java.net Thu Mar 10 16:09:42 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 16:09:42 GMT Subject: [jdk17u-dev] RFR: 8267163: Rename anonymous loader tests to hidden loader tests Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 5c21c0044104b52fcaf3f3a830ea6e219d504ada Changes: https://git.openjdk.java.net/jdk17u-dev/pull/232/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=232&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267163 Stats: 900 lines in 14 files changed: 900 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/232.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/232/head:pull/232 PR: https://git.openjdk.java.net/jdk17u-dev/pull/232 From goetz at openjdk.java.net Thu Mar 10 16:16:05 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 16:16:05 GMT Subject: [jdk11u-dev] RFR: 8210039: move OSInfo to top level testlibrary Message-ID: I want to backport this test cleanup as it simplifies later backports. Stuff to resolve was all trivial. Already fixed: patching file test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.java patching file test/jdk/java/awt/FileDialog/8003399/bug8003399.java Resolved because html test was already removed test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.java test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.java test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.java test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java Context test/jdk/javax/swing/JButton/4796987/bug4796987.java Copyright patching file test/jdk/javax/swing/JFileChooser/8041694/bug8041694.java patching file test/jdk/javax/swing/JPopupMenu/7154841/bug7154841.java Indentation patching file test/jdk/javax/swing/JLabel/6596966/bug6596966.java patching file test/jdk/javax/swing/JMenu/6470128/bug6470128.java patching file test/jdk/javax/swing/JPopupMenu/6827786/bug6827786.java patching file test/jdk/javax/swing/JScrollBar/bug4202954/bug4202954.java patching file test/jdk/javax/swing/JTabbedPane/4624207/bug4624207.java Dependency of platform removed by backport of later change. patching file test/jdk/sun/awt/dnd/8024061/bug8024061.java ------------- Commit messages: - Backport 315e71f87e7441fff8a5b95335b7c8125e383766 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/876/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=876&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210039 Stats: 829 lines in 77 files changed: 108 ins; 326 del; 395 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/876.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/876/head:pull/876 PR: https://git.openjdk.java.net/jdk11u-dev/pull/876 From goetz at openjdk.java.net Thu Mar 10 16:28:20 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 16:28:20 GMT Subject: [jdk17u-dev] RFR: 8274244: ReportOnImportedModuleAnnotation.java fails on rerun Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport c391e59ea6fe6759553425e342b2d97824dd9323 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/233/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=233&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274244 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/233.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/233/head:pull/233 PR: https://git.openjdk.java.net/jdk17u-dev/pull/233 From goetz at openjdk.java.net Thu Mar 10 16:27:51 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 16:27:51 GMT Subject: [jdk17u-dev] RFR: 8267163: Rename anonymous loader tests to hidden loader tests [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.4-oracle. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 5c21c0044104b52fcaf3f3a830ea6e219d504ada ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/232/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/232/files/fabaf82d..4381e707 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=232&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=232&range=00-01 Stats: 1020 lines in 14 files changed: 0 ins; 1020 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/232.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/232/head:pull/232 PR: https://git.openjdk.java.net/jdk17u-dev/pull/232 From goetz at openjdk.java.net Thu Mar 10 16:38:12 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 16:38:12 GMT Subject: [jdk17u-dev] RFR: 8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout Message-ID: <5l1flLIdfHMZ_40J2CWfJbd8y7ZuTzXw5lzXHOj_DzA=.222e86bb-f0f3-49f2-828b-db57808876da@github.com> I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport f143d2a88e1972cdce9eb6f61c2eb9754cb89251 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/234/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=234&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268595 Stats: 12 lines in 1 file changed: 0 ins; 12 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/234.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/234/head:pull/234 PR: https://git.openjdk.java.net/jdk17u-dev/pull/234 From goetz at openjdk.java.net Thu Mar 10 16:40:14 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 16:40:14 GMT Subject: [jdk17u-dev] RFR: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR Message-ID: <3eCbsJ8QUcksNwlVmyrPUgsr4n39MNowCUFxqS3ddlI=.e032c3ea-daf0-43de-bd38-3800634278dc@github.com> I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 7ca053de218bf76ea06bbeed860d142db381ca53 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/235/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=235&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251904 Stats: 9 lines in 2 files changed: 1 ins; 3 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/235.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/235/head:pull/235 PR: https://git.openjdk.java.net/jdk17u-dev/pull/235 From goetz at openjdk.java.net Thu Mar 10 16:48:07 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 16:48:07 GMT Subject: [jdk17u-dev] RFR: 8276260: (se) Remove java/nio/channels/Selector/Wakeup.java from ProblemList (win) Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport fa4ce824a39264e765b8236ee58b1f28faa371e0 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/236/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=236&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276260 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/236.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/236/head:pull/236 PR: https://git.openjdk.java.net/jdk17u-dev/pull/236 From goetz at openjdk.java.net Thu Mar 10 16:49:16 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 16:49:16 GMT Subject: [jdk17u-dev] RFR: 8276825: hotspot/runtime/SelectionResolution test errors Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 55b36c6f3bb7eb066daaf41f9eba46633afedf08 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/237/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=237&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276825 Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/237.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/237/head:pull/237 PR: https://git.openjdk.java.net/jdk17u-dev/pull/237 From goetz at openjdk.java.net Thu Mar 10 16:57:13 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 16:57:13 GMT Subject: [jdk17u-dev] RFR: 8269077: TestSystemGC uses "require vm.gc.G1" for large pages subtest Message-ID: I backport this test fix to simplify a follow up backport. I think this is useful, too. ------------- Commit messages: - Backport 1a818154cfe852a680070c5c07f2df33109e5b54 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/238/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=238&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269077 Stats: 9 lines in 1 file changed: 7 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/238.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/238/head:pull/238 PR: https://git.openjdk.java.net/jdk17u-dev/pull/238 From goetz at openjdk.java.net Thu Mar 10 17:21:30 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 17:21:30 GMT Subject: [jdk11u-dev] RFR: 8210039: move OSInfo to top level testlibrary [v2] In-Reply-To: References: Message-ID: > I want to backport this test cleanup as it simplifies later backports. > > Stuff to resolve was all trivial. > > Already fixed: > patching file test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.java > patching file test/jdk/java/awt/FileDialog/8003399/bug8003399.java > > Resolved because html test was already removed > test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.java > test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.java > test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.java > test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java > test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java > > Context > test/jdk/javax/swing/JButton/4796987/bug4796987.java > > Copyright > patching file test/jdk/javax/swing/JFileChooser/8041694/bug8041694.java > patching file test/jdk/javax/swing/JPopupMenu/7154841/bug7154841.java > > Indentation > patching file test/jdk/javax/swing/JLabel/6596966/bug6596966.java > patching file test/jdk/javax/swing/JMenu/6470128/bug6470128.java > patching file test/jdk/javax/swing/JPopupMenu/6827786/bug6827786.java > patching file test/jdk/javax/swing/JScrollBar/bug4202954/bug4202954.java > patching file test/jdk/javax/swing/JTabbedPane/4624207/bug4624207.java > > Dependency of platform removed by backport of later change. > patching file test/jdk/sun/awt/dnd/8024061/bug8024061.java Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 315e71f87e7441fff8a5b95335b7c8125e383766 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/876/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/876/files/5828a088..c004c54e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=876&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=876&range=00-01 Stats: 112 lines in 1 file changed: 112 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/876.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/876/head:pull/876 PR: https://git.openjdk.java.net/jdk11u-dev/pull/876 From sgehwolf at openjdk.java.net Thu Mar 10 19:17:46 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 10 Mar 2022 19:17:46 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy In-Reply-To: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Tue, 8 Mar 2022 18:47:32 GMT, Zhengyu Gu wrote: > This is a followup backport for Cgroup v2 support. > > The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. > > In additional: > > 1) Include partial backport of JDK-8250627. > - Renamed `Metrics.c` => `CgroupMetrics.c` > - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` > - Return instance only if `isUseContainerSupport()` is enabled. > > 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test > > 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` > > Test: > > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS A few more comments related to: https://bugs.openjdk.java.net/browse/JDK-8250984 src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java line 442: > 440: public long getMemoryAndSwapFailCount() { > 441: return getLongValue(memory, "memory.memsw.failcnt"); > 442: } This is missing the hunk for https://bugs.openjdk.java.net/browse/JDK-8250984. See: https://github.com/openjdk/jdk11u-dev/blob/87703322e980e42035d7cf101f04cafdc31fe278/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java#L480..L482 src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java line 445: > 443: > 444: public long getMemoryAndSwapLimit() { > 445: long retval = getLongValue(memory, "memory.memsw.limit_in_bytes"); This is missing the hunk for https://bugs.openjdk.java.net/browse/JDK-8250984. See: https://github.com/openjdk/jdk11u-dev/blob/87703322e980e42035d7cf101f04cafdc31fe278/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java#L487..L489 src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java line 460: > 458: > 459: public long getMemoryAndSwapMaxUsage() { > 460: return getLongValue(memory, "memory.memsw.max_usage_in_bytes"); This is missing the hunk for https://bugs.openjdk.java.net/browse/JDK-8250984. See: https://github.com/openjdk/jdk11u-dev/blob/87703322e980e42035d7cf101f04cafdc31fe278/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java#L506..L508 src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java line 464: > 462: > 463: public long getMemoryAndSwapUsage() { > 464: return getLongValue(memory, "memory.memsw.usage_in_bytes"); This is missing the hunk for https://bugs.openjdk.java.net/browse/JDK-8250984. See: https://github.com/openjdk/jdk11u-dev/blob/87703322e980e42035d7cf101f04cafdc31fe278/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java#L513..L515 ------------- Changes requested by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From goetz at openjdk.java.net Thu Mar 10 21:17:15 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 21:17:15 GMT Subject: [jdk11u-dev] RFR: 8210022: remove jdk.testlibrary.ProcessThread, TestThread and XRun Message-ID: Backport this cleanup to simplify later backports. ------------- Commit messages: - Backport 370abe471ffe0385eb78128fc3d5725f7f43b544 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/877/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=877&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210022 Stats: 304 lines in 17 files changed: 21 ins; 266 del; 17 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/877.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/877/head:pull/877 PR: https://git.openjdk.java.net/jdk11u-dev/pull/877 From goetz at openjdk.java.net Thu Mar 10 22:03:16 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 10 Mar 2022 22:03:16 GMT Subject: [jdk11u-dev] RFR: 8186548: move jdk.testlibrary.JcmdBase closer to tests Message-ID: <5j5HnaP_whzBoC_PUPMNLpWqchMViPOR1PuTnLtAVDw=.51b3e3ef-805b-4529-bd45-78ac45da2e03@github.com> I backport this to simplify follow up backports. ------------- Commit messages: - Backport 56ee0fccb33a3b542da89ff252d5f4e5aa6d0ddb Changes: https://git.openjdk.java.net/jdk11u-dev/pull/878/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=878&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8186548 Stats: 10 lines in 3 files changed: 4 ins; 4 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/878.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/878/head:pull/878 PR: https://git.openjdk.java.net/jdk11u-dev/pull/878 From duke at openjdk.java.net Fri Mar 11 03:27:49 2022 From: duke at openjdk.java.net (wxiang) Date: Fri, 11 Mar 2022 03:27:49 GMT Subject: [jdk11u-dev] RFR: 8261090: Store old classfiles in static CDS archive [v2] In-Reply-To: <4tqUkn-OsqxCUK_XarWC0UNUloQjtNMN8i1Keyuxjgo=.6e70c9ff-9c4b-4396-9303-6a8d9cf062e5@github.com> References: <4tqUkn-OsqxCUK_XarWC0UNUloQjtNMN8i1Keyuxjgo=.6e70c9ff-9c4b-4396-9303-6a8d9cf062e5@github.com> Message-ID: On Thu, 10 Mar 2022 07:32:26 GMT, wxiang wrote: >> 8261090: Store old classfiles in static CDS archive > > wxiang has updated the pull request incrementally with one additional commit since the last revision: > > revert the changes with 8266822 and 8267431 As described in JDK-8230413, there are still large number of existing classes with older class version (< 50) in real world applications. Those classes are missing the benefit of CDS. For better use of AppCDS, we requested the backport. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/856 From goetz at openjdk.java.net Fri Mar 11 07:06:46 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 07:06:46 GMT Subject: [jdk11u-dev] RFR: 8210022: remove jdk.testlibrary.ProcessThread, TestThread and XRun In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 21:10:01 GMT, Goetz Lindenmaier wrote: > Backport this cleanup to simplify later backports. Pre-submit failures: dependencies missing Version '9.3.0-17ubuntu1~20.04cross2' for 'gcc-9-aarch64-linux-gnu' was not found ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/877 From goetz at openjdk.java.net Fri Mar 11 07:12:54 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 07:12:54 GMT Subject: [jdk17u-dev] RFR: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform In-Reply-To: <6FbRs8w6IlrOItYS0XGcVAOzfF5I0F8EFGOw5nQcY00=.ae30b9ad-e277-4a84-b576-88aa7b2bfb6e@github.com> References: <6FbRs8w6IlrOItYS0XGcVAOzfF5I0F8EFGOw5nQcY00=.ae30b9ad-e277-4a84-b576-88aa7b2bfb6e@github.com> Message-ID: On Thu, 10 Mar 2022 13:31:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Pre-submit failure: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 Unrelated ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/227 From goetz at openjdk.java.net Fri Mar 11 07:34:13 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 07:34:13 GMT Subject: [jdk17u-dev] RFR: 8276657: XSLT compiler tries to define a class with empty name Message-ID: Simple fix to backport ------------- Commit messages: - Backport a093cdddaf5ab88eb84a147e523db5c3e1be54be Changes: https://git.openjdk.java.net/jdk17u-dev/pull/239/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=239&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276657 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/239.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/239/head:pull/239 PR: https://git.openjdk.java.net/jdk17u-dev/pull/239 From stuefe at openjdk.java.net Fri Mar 11 07:41:40 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 11 Mar 2022 07:41:40 GMT Subject: [jdk11u-dev] Integrated: JDK-8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11 In-Reply-To: References: Message-ID: On Mon, 28 Feb 2022 13:52:08 GMT, Thomas Stuefe wrote: > In JDK 11 only, we see errors in runtime/ErrorHandling/ErrorHandler.java. The test induces an artificial (but real) segfault and checks the VMs reaction to it (that the hs-err file is written correctly and contains expected output). > > The test does this by reading from `char* p = NULL;`. This is not guaranteed to work, and does not in this case: the process gets a "BPT/Trap" message instead and dies. > > This code (`VMError::controlled_crash()`) has been streamlined and rewritten for later releases, and there we consistently use a known non-null address to invalid memory instead, which seems to work reliably for MacOs aarch64 too. > > --- > > The patch, instead of downporting the whole reworkings of `VMError::controlled_crash`, just reuses the code which checks a segfault against a non-null invalid address. That way we do the same as newer releases, but with minimal changes. This pull request has now been integrated. Changeset: 51b45e74 Author: Thomas Stuefe URL: https://git.openjdk.java.net/jdk11u-dev/commit/51b45e740caba64e8369e57f30fa065595148d07 Stats: 10 lines in 2 files changed: 6 ins; 3 del; 1 mod 8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11 Reviewed-by: vkempik ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/842 From stuefe at openjdk.java.net Fri Mar 11 07:50:43 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 11 Mar 2022 07:50:43 GMT Subject: [jdk11u-dev] RFR: 8218751: Do not store original classfiles inside the CDS archive In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 14:15:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > src/hotspot/share/classfile/systemDictionary.cpp > src/hotspot/share/classfile/systemDictionaryShared.cpp > Resolved. Context differs. > > src/hotspot/share/memory/metaspaceShared.cpp/hpp > Resolved a lot of code. > _total_string_region_size renamed in 13, > changes to INCLUDE_JVMTI etc in context. > > src/hotspot/share/runtime/mutexLocker.cpp/hpp > Trivial resolve. Test errors: - gc/cms/TestBubbleUpRef.java fails on x86 - build errors on side platforms infrastructure related, but obfuscate the builds ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/875 From goetz at openjdk.java.net Fri Mar 11 08:19:44 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 08:19:44 GMT Subject: [jdk11u-dev] RFR: 8279668: x86: AVX2 versions of vpxor should be asserted In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 11:47:42 GMT, Aleksey Shipilev wrote: > Clean backport to prevent SIGILLs on incompatible hardware. > > Additional testing: > - [x] Linux x86_64 fastdebug with -XX:UseAVX=1 LGTM, only copyright resolved. (a candidate for /clean) ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/872 From stuefe at openjdk.java.net Fri Mar 11 09:09:46 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 11 Mar 2022 09:09:46 GMT Subject: [jdk11u-dev] RFR: 8218751: Do not store original classfiles inside the CDS archive In-Reply-To: References: Message-ID: <_qZVLc8_nG8fY2u-efCPr18UOZXDgLLtDw1Kuxxg3ok=.2aa4559e-ac33-45df-ac50-f772bee91a78@github.com> On Thu, 10 Mar 2022 14:15:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > src/hotspot/share/classfile/systemDictionary.cpp > src/hotspot/share/classfile/systemDictionaryShared.cpp > Resolved. Context differs. > > src/hotspot/share/memory/metaspaceShared.cpp/hpp > Resolved a lot of code. > _total_string_region_size renamed in 13, > changes to INCLUDE_JVMTI etc in context. > > src/hotspot/share/runtime/mutexLocker.cpp/hpp > Trivial resolve. Looks okay. I was concerned about the 32-bit error but could not reproduce it locally. SAP nightlies look fine it seems, but we don't test 32-bit Linux. ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/875 From goetz at openjdk.java.net Fri Mar 11 09:18:45 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 09:18:45 GMT Subject: [jdk11u-dev] RFR: 8218751: Do not store original classfiles inside the CDS archive In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 14:15:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > src/hotspot/share/classfile/systemDictionary.cpp > src/hotspot/share/classfile/systemDictionaryShared.cpp > Resolved. Context differs. > > src/hotspot/share/memory/metaspaceShared.cpp/hpp > Resolved a lot of code. > _total_string_region_size renamed in 13, > changes to INCLUDE_JVMTI etc in context. > > src/hotspot/share/runtime/mutexLocker.cpp/hpp > Trivial resolve. TestBubbleUpRef.java timed out. I don't think this is CDS related, thus unrelated to this change. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/875 From jdowland at openjdk.java.net Fri Mar 11 11:03:09 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 11 Mar 2022 11:03:09 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot Message-ID: This is a backport of 8239785 for jdk11u. It depends upon pr/865: 8253714 (hopefully the bots will figure this out automatically) It's not clean, but the only conflict was the copyright line in the comment header for src/hotspot/share/prims/whitebox.hpp. I tried these tests, and they pass: test/hotspot/jtreg/applications/ctw/modules/java_compiler.java test/hotspot/jtreg/compiler/c2/Test8004741.java test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java Awaiting tier tests via GA. ------------- Commit messages: - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot - Backport ff6843ca4842498791061f924c545fa9469cc1dc - Fix tests - Add parital 8250627 backport - Backport 4def210a22faaec6b47912dd314e6365ea48d28f - Backport d462a6b5c9bd3dae5257cca42ea38c19cb742e3c Changes: https://git.openjdk.java.net/jdk11u-dev/pull/880/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=880&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8239785 Stats: 7797 lines in 46 files changed: 5404 ins; 2198 del; 195 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/880.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/880/head:pull/880 PR: https://git.openjdk.java.net/jdk11u-dev/pull/880 From stuefe at openjdk.java.net Fri Mar 11 11:04:54 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 11 Mar 2022 11:04:54 GMT Subject: [jdk11u-dev] RFR: 8218751: Do not store original classfiles inside the CDS archive In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 09:15:58 GMT, Goetz Lindenmaier wrote: > TestBubbleUpRef.java timed out. I don't think this is CDS related, thus unrelated to this change. Yes. I tested with and without your patch and could not reproduce the long runtime. Since I am not sure how this could relate to your patch, I think this is ok. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/875 From jdowland at openjdk.java.net Fri Mar 11 11:05:29 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 11 Mar 2022 11:05:29 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot [v2] In-Reply-To: References: Message-ID: > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport add18914fb1294999877b563c734a25b4c17b922 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/880/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/880/files/361d45fb..d09b3cd1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=880&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=880&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/880.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/880/head:pull/880 PR: https://git.openjdk.java.net/jdk11u-dev/pull/880 From jdowland at openjdk.java.net Fri Mar 11 11:07:55 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 11 Mar 2022 11:07:55 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: <_KFSHf_e4r1KHyilkshXjdKre5OmmbvX3CqKCZWeXBY=.aa509285-97a8-47bd-b924-703f4f933043@github.com> On Fri, 11 Mar 2022 10:56:27 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. Closing in favour of #881 (targetting a PR branch) ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/880 From jdowland at openjdk.java.net Fri Mar 11 11:07:56 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 11 Mar 2022 11:07:56 GMT Subject: [jdk11u-dev] Withdrawn: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 10:56:27 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/880 From jdowland at openjdk.java.net Fri Mar 11 11:15:15 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 11 Mar 2022 11:15:15 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot Message-ID: This is a backport of 8239785 for jdk11u. It depends upon pr/865: 8253714 (hopefully the bots will figure this out automatically) It's not clean, but the only conflict was the copyright line in the comment header for src/hotspot/share/prims/whitebox.hpp. I tried these tests, and they pass: test/hotspot/jtreg/applications/ctw/modules/java_compiler.java test/hotspot/jtreg/compiler/c2/Test8004741.java test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java Awaiting tier tests via GA. --------- ### Progress - [x] Change must not contain extraneous whitespace - [x] Commit message must refer to an issue - [ ] Change must be properly reviewed ### Integration blocker  ?? Dependency #865 must be integrated first ### Reviewing
Using git Checkout this PR locally: \ `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \ `$ git checkout pull/881` Update a local copy of the PR: \ `$ git checkout pull/881` \ `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head`
Using Skara CLI tools Checkout this PR locally: \ `$ git pr checkout 881` View PR using the GUI difftool: \ `$ git pr show -t 881`
Using diff file Download this PR as a diff file: \ https://git.openjdk.java.net/jdk11u-dev/pull/881.diff
------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/865 Commit messages: - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot Changes: https://git.openjdk.java.net/jdk11u-dev/pull/881/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=881&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8239785 Stats: 694 lines in 6 files changed: 526 ins; 96 del; 72 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/881.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881 PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From mdoerr at openjdk.java.net Fri Mar 11 12:05:47 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 11 Mar 2022 12:05:47 GMT Subject: [jdk11u-dev] RFR: 8210039: move OSInfo to top level testlibrary [v2] In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 17:21:30 GMT, Goetz Lindenmaier wrote: >> I want to backport this test cleanup as it simplifies later backports. >> >> Stuff to resolve was all trivial. >> >> Already fixed: >> patching file test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.java >> patching file test/jdk/java/awt/FileDialog/8003399/bug8003399.java >> >> Resolved because html test was already removed >> test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.java >> test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.java >> test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.java >> test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java >> test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java >> >> Context >> test/jdk/javax/swing/JButton/4796987/bug4796987.java >> >> Copyright >> patching file test/jdk/javax/swing/JFileChooser/8041694/bug8041694.java >> patching file test/jdk/javax/swing/JPopupMenu/7154841/bug7154841.java >> >> Indentation >> patching file test/jdk/javax/swing/JLabel/6596966/bug6596966.java >> patching file test/jdk/javax/swing/JMenu/6470128/bug6470128.java >> patching file test/jdk/javax/swing/JPopupMenu/6827786/bug6827786.java >> patching file test/jdk/javax/swing/JScrollBar/bug4202954/bug4202954.java >> patching file test/jdk/javax/swing/JTabbedPane/4624207/bug4624207.java >> >> Dependency of platform removed by backport of later change. >> patching file test/jdk/sun/awt/dnd/8024061/bug8024061.java > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 315e71f87e7441fff8a5b95335b7c8125e383766 LGTM. Thanks for backporting. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/876 From shade at openjdk.java.net Fri Mar 11 12:57:02 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Mar 2022 12:57:02 GMT Subject: [jdk11u-dev] RFR: 8283018: 11u GHA: Update GCC 9 minor versions Message-ID: Current GHA runs in 11u fail with: E: Version '9.3.0-17ubuntu1~20.04cross2' for 'gcc-9-aarch64-linux-gnu' was not found E: Version '9.3.0-17ubuntu1~20.04cross2' for 'g++-9-aarch64-linux-gnu' was not found We should update these. 11u GHA workflow runs GCC 9, not GCC 10 like the rest of releases, so this is the 11u-specific bug. ------------- Commit messages: - Upgrade to GCC 9.4.0 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/879/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=879&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283018 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/879.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/879/head:pull/879 PR: https://git.openjdk.java.net/jdk11u-dev/pull/879 From mdoerr at openjdk.java.net Fri Mar 11 13:26:07 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 11 Mar 2022 13:26:07 GMT Subject: [jdk17u-dev] RFR: 8267163: Rename anonymous loader tests to hidden loader tests [v2] In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 16:27:51 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.4-oracle. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 5c21c0044104b52fcaf3f3a830ea6e219d504ada LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/232 From mdoerr at openjdk.java.net Fri Mar 11 13:28:06 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 11 Mar 2022 13:28:06 GMT Subject: [jdk17u-dev] Integrated: 8282509: [exploded image] ResolvedClassTest fails with similar output In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 15:36:59 GMT, Martin Doerr wrote: > Clean backport of [JDK-8282509](https://bugs.openjdk.java.net/browse/JDK-8282509) This pull request has now been integrated. Changeset: 6dcf10b2 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/6dcf10b2423047c9bd63fd37c4d958efb2a3ff6d Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8282509: [exploded image] ResolvedClassTest fails with similar output Backport-of: 7c8ea9f05b35069e2b5b43e1a0e46f7dbe374e4c ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/231 From sgehwolf at openjdk.java.net Fri Mar 11 13:34:41 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 11 Mar 2022 13:34:41 GMT Subject: [jdk11u-dev] RFR: 8283018: 11u GHA: Update GCC 9 minor versions In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 09:51:00 GMT, Aleksey Shipilev wrote: > Current GHA runs in 11u fail with: > > > E: Version '9.3.0-17ubuntu1~20.04cross2' for 'gcc-9-aarch64-linux-gnu' was not found > E: Version '9.3.0-17ubuntu1~20.04cross2' for 'g++-9-aarch64-linux-gnu' was not found > > > We should update these. 11u GHA workflow runs GCC 9, not GCC 10 like the rest of releases, so this is the 11u-specific bug. LGTM. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/879 From goetz at openjdk.java.net Fri Mar 11 13:35:54 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:35:54 GMT Subject: [jdk17u-dev] Integrated: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform In-Reply-To: <6FbRs8w6IlrOItYS0XGcVAOzfF5I0F8EFGOw5nQcY00=.ae30b9ad-e277-4a84-b576-88aa7b2bfb6e@github.com> References: <6FbRs8w6IlrOItYS0XGcVAOzfF5I0F8EFGOw5nQcY00=.ae30b9ad-e277-4a84-b576-88aa7b2bfb6e@github.com> Message-ID: <3SO57O35UOkmDE4kyCKjUe14Y0kIG7LYeXoRKv5szv4=.a689ca34-184b-4a5c-9a89-ff62dc15b3c1@github.com> On Thu, 10 Mar 2022 13:31:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 8197fd47 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/8197fd4781d8ba6594f1621a17e2dca669664eab Stats: 14 lines in 2 files changed: 12 ins; 0 del; 2 mod 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform Backport-of: cb112affd6061e8ace6dad4e92c7b394a413e37f ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/227 From goetz at openjdk.java.net Fri Mar 11 13:37:51 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:37:51 GMT Subject: [jdk11u-dev] Integrated: 8218751: Do not store original classfiles inside the CDS archive In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 14:15:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > src/hotspot/share/classfile/systemDictionary.cpp > src/hotspot/share/classfile/systemDictionaryShared.cpp > Resolved. Context differs. > > src/hotspot/share/memory/metaspaceShared.cpp/hpp > Resolved a lot of code. > _total_string_region_size renamed in 13, > changes to INCLUDE_JVMTI etc in context. > > src/hotspot/share/runtime/mutexLocker.cpp/hpp > Trivial resolve. This pull request has now been integrated. Changeset: 9d3c9402 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/9d3c9402176e3714ea3998eea09ea5a7602e22f7 Stats: 229 lines in 16 files changed: 97 ins; 101 del; 31 mod 8218751: Do not store original classfiles inside the CDS archive Remove the OD shared region and decode classfiles on the fly Reviewed-by: stuefe Backport-of: d06f3e7e28bd1baf00b903a7c6b2f18965e73311 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/875 From sgehwolf at openjdk.java.net Fri Mar 11 13:38:54 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 11 Mar 2022 13:38:54 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 11:04:45 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Integration blocker >  ?? Dependency #865 must be integrated first > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \ > `$ git checkout pull/881` > > Update a local copy of the PR: \ > `$ git checkout pull/881` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 881` > > View PR using the GUI difftool: \ > `$ git pr show -t 881` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/881.diff > >
Did you run container tests on a cgroups v1 and cgroups v2 system? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From goetz at openjdk.java.net Fri Mar 11 13:38:56 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:38:56 GMT Subject: [jdk17u-dev] Integrated: 8274233: Minor cleanup for ToolBox In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 13:42:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 08084ea1 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/08084ea1400bafee5720f61bd6e893292e58dba0 Stats: 111 lines in 1 file changed: 47 ins; 12 del; 52 mod 8274233: Minor cleanup for ToolBox Backport-of: e741a18062061c1959f7881503aaf3a4cbcae776 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/228 From goetz at openjdk.java.net Fri Mar 11 13:39:48 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:39:48 GMT Subject: [jdk11u-dev] Integrated: 8210022: remove jdk.testlibrary.ProcessThread, TestThread and XRun In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 21:10:01 GMT, Goetz Lindenmaier wrote: > Backport this cleanup to simplify later backports. This pull request has now been integrated. Changeset: 50ac1389 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/50ac138923e3a31fc79f83e09ae0095645c8d45b Stats: 304 lines in 17 files changed: 21 ins; 266 del; 17 mod 8210022: remove jdk.testlibrary.ProcessThread, TestThread and XRun Backport-of: 370abe471ffe0385eb78128fc3d5725f7f43b544 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/877 From goetz at openjdk.java.net Fri Mar 11 13:43:49 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:43:49 GMT Subject: [jdk11u-dev] RFR: 8186548: move jdk.testlibrary.JcmdBase closer to tests In-Reply-To: <5j5HnaP_whzBoC_PUPMNLpWqchMViPOR1PuTnLtAVDw=.51b3e3ef-805b-4529-bd45-78ac45da2e03@github.com> References: <5j5HnaP_whzBoC_PUPMNLpWqchMViPOR1PuTnLtAVDw=.51b3e3ef-805b-4529-bd45-78ac45da2e03@github.com> Message-ID: <537Xt8iN2v7yjRT3JYb7XyzXy-oAKstWmM3pns2DiWY=.415f3f1e-fd1a-4341-a397-a26f3058d6b3@github.com> On Thu, 10 Mar 2022 21:56:42 GMT, Goetz Lindenmaier wrote: > I backport this to simplify follow up backports. Pre-submit test failures: missing dependencies runtime/Thread/StopAtExit.java fails also in other jobs ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/878 From goetz at openjdk.java.net Fri Mar 11 13:43:50 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:43:50 GMT Subject: [jdk11u-dev] Integrated: 8186548: move jdk.testlibrary.JcmdBase closer to tests In-Reply-To: <5j5HnaP_whzBoC_PUPMNLpWqchMViPOR1PuTnLtAVDw=.51b3e3ef-805b-4529-bd45-78ac45da2e03@github.com> References: <5j5HnaP_whzBoC_PUPMNLpWqchMViPOR1PuTnLtAVDw=.51b3e3ef-805b-4529-bd45-78ac45da2e03@github.com> Message-ID: <746XC9cwjz0aeGjjry9gBUP0vg5oEarvdN3f5PoSq4E=.47540046-0e4c-4b6e-b52f-c6c30da35775@github.com> On Thu, 10 Mar 2022 21:56:42 GMT, Goetz Lindenmaier wrote: > I backport this to simplify follow up backports. This pull request has now been integrated. Changeset: 39974dc1 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/39974dc1a012772f86e1cf7fe96f749b948f81f5 Stats: 10 lines in 3 files changed: 4 ins; 4 del; 2 mod 8186548: move jdk.testlibrary.JcmdBase closer to tests Backport-of: 56ee0fccb33a3b542da89ff252d5f4e5aa6d0ddb ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/878 From goetz at openjdk.java.net Fri Mar 11 13:45:55 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:45:55 GMT Subject: [jdk17u-dev] Integrated: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 14:19:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: e2fa3d36 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/e2fa3d36f0e8d80ecfe7e1d9e1ab1a35d0533233 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines Backport-of: b7b78ff1f380d19214dbca48455772bc87cc137d ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/229 From goetz at openjdk.java.net Fri Mar 11 13:47:50 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:47:50 GMT Subject: [jdk17u-dev] Integrated: 8274244: ReportOnImportedModuleAnnotation.java fails on rerun In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 16:17:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: fb3ccbcd Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/fb3ccbcda8952feb91d92ac8862d4115dd56f4a0 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod 8274244: ReportOnImportedModuleAnnotation.java fails on rerun Backport-of: c391e59ea6fe6759553425e342b2d97824dd9323 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/233 From goetz at openjdk.java.net Fri Mar 11 13:51:07 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:51:07 GMT Subject: [jdk17u-dev] Integrated: 8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout In-Reply-To: <5l1flLIdfHMZ_40J2CWfJbd8y7ZuTzXw5lzXHOj_DzA=.222e86bb-f0f3-49f2-828b-db57808876da@github.com> References: <5l1flLIdfHMZ_40J2CWfJbd8y7ZuTzXw5lzXHOj_DzA=.222e86bb-f0f3-49f2-828b-db57808876da@github.com> Message-ID: On Thu, 10 Mar 2022 16:30:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 3b536354 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/3b5363540a305a60501645adf625720eb3474406 Stats: 12 lines in 1 file changed: 0 ins; 12 del; 0 mod 8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout Backport-of: f143d2a88e1972cdce9eb6f61c2eb9754cb89251 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/234 From goetz at openjdk.java.net Fri Mar 11 13:52:53 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:52:53 GMT Subject: [jdk17u-dev] Integrated: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR In-Reply-To: <3eCbsJ8QUcksNwlVmyrPUgsr4n39MNowCUFxqS3ddlI=.e032c3ea-daf0-43de-bd38-3800634278dc@github.com> References: <3eCbsJ8QUcksNwlVmyrPUgsr4n39MNowCUFxqS3ddlI=.e032c3ea-daf0-43de-bd38-3800634278dc@github.com> Message-ID: On Thu, 10 Mar 2022 16:32:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 535511a8 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/535511a85aff2e36b1da4e8d3a6860ef1c91ea05 Stats: 9 lines in 2 files changed: 1 ins; 3 del; 5 mod 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR Backport-of: 7ca053de218bf76ea06bbeed860d142db381ca53 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/235 From goetz at openjdk.java.net Fri Mar 11 13:55:03 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:55:03 GMT Subject: [jdk17u-dev] Integrated: 8276260: (se) Remove java/nio/channels/Selector/Wakeup.java from ProblemList (win) In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 16:39:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 972dcde4 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/972dcde474be66772cbb029d3b060866a17b82da Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8276260: (se) Remove java/nio/channels/Selector/Wakeup.java from ProblemList (win) Backport-of: fa4ce824a39264e765b8236ee58b1f28faa371e0 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/236 From goetz at openjdk.java.net Fri Mar 11 13:56:55 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:56:55 GMT Subject: [jdk17u-dev] Integrated: 8276825: hotspot/runtime/SelectionResolution test errors In-Reply-To: References: Message-ID: <_OAkwpV31CXWoMcsQmA-04JTObabnf-6AaGrskjOC90=.c0ba68ab-7a65-46c2-9e9c-2114e4e214a3@github.com> On Thu, 10 Mar 2022 16:39:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 79cce169 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/79cce169d4618e689698cedbb5eeae840fb3fe22 Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6 mod 8276825: hotspot/runtime/SelectionResolution test errors Backport-of: 55b36c6f3bb7eb066daaf41f9eba46633afedf08 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/237 From goetz at openjdk.java.net Fri Mar 11 13:59:51 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 13:59:51 GMT Subject: [jdk17u-dev] Integrated: 8276657: XSLT compiler tries to define a class with empty name In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 07:24:51 GMT, Goetz Lindenmaier wrote: > Simple fix to backport This pull request has now been integrated. Changeset: 3c6aecd3 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/3c6aecd395e2dd6829815dcaa9d0e17d252131ed Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod 8276657: XSLT compiler tries to define a class with empty name Backport-of: a093cdddaf5ab88eb84a147e523db5c3e1be54be ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/239 From shade at openjdk.java.net Fri Mar 11 14:22:08 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Mar 2022 14:22:08 GMT Subject: [jdk17u-dev] RFR: 8279958: Provide configure hints for Alpine/apk package managers In-Reply-To: References: Message-ID: <7cef9mBDFBGzxmySxKJOXxVn8UR0dP3i3-_N2aWf6_U=.4b45b853-8d5e-4fd2-825e-2bee218cd660@github.com> On Thu, 10 Mar 2022 08:48:16 GMT, Aleksey Shipilev wrote: > Clean backport to improve Alpine port. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/225 From shade at openjdk.java.net Fri Mar 11 14:22:09 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Mar 2022 14:22:09 GMT Subject: [jdk17u-dev] Integrated: 8279958: Provide configure hints for Alpine/apk package managers In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 08:48:16 GMT, Aleksey Shipilev wrote: > Clean backport to improve Alpine port. This pull request has now been integrated. Changeset: bb8b3c22 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u-dev/commit/bb8b3c22268a530ad8d7576da1fed9e05efc7513 Stats: 25 lines in 1 file changed: 23 ins; 0 del; 2 mod 8279958: Provide configure hints for Alpine/apk package managers Backport-of: a30aa52b77931bcea38213cf3d243d18a37dc858 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/225 From jdowland at openjdk.java.net Fri Mar 11 14:23:52 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 11 Mar 2022 14:23:52 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 13:35:49 GMT, Severin Gehwolf wrote: > Did you run container tests on a cgroups v1 and cgroups v2 system? Just a v2 one so far. I'm looking at setting up a v1 environment now. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From shade at openjdk.java.net Fri Mar 11 14:23:56 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Mar 2022 14:23:56 GMT Subject: [jdk17u-dev] RFR: 8279668: x86: AVX2 versions of vpxor should be asserted In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 11:47:16 GMT, Aleksey Shipilev wrote: > Clean backport to prevent SIGILLs on incompatible hardware. > > Additional testing: > - [x] Linux x86_64 fastdebug with -XX:UseAVX=1 Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/226 From shade at openjdk.java.net Fri Mar 11 14:23:56 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Mar 2022 14:23:56 GMT Subject: [jdk17u-dev] Integrated: 8279668: x86: AVX2 versions of vpxor should be asserted In-Reply-To: References: Message-ID: <3aOUN1lonI0ZSGLt8k6mhrXn5ierg9fVzgHXY9XSPl4=.9682a132-1f71-4032-bc43-ce2da31c73d1@github.com> On Thu, 10 Mar 2022 11:47:16 GMT, Aleksey Shipilev wrote: > Clean backport to prevent SIGILLs on incompatible hardware. > > Additional testing: > - [x] Linux x86_64 fastdebug with -XX:UseAVX=1 This pull request has now been integrated. Changeset: 5edb9822 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u-dev/commit/5edb982271d22711507ae9e7b8ddacc2e2e2a4a3 Stats: 15 lines in 2 files changed: 12 ins; 0 del; 3 mod 8279668: x86: AVX2 versions of vpxor should be asserted Backport-of: 2bbeae3f056243a224b0bda021f16cdcbee3b3d6 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/226 From shade at openjdk.java.net Fri Mar 11 14:25:46 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Mar 2022 14:25:46 GMT Subject: [jdk11u-dev] RFR: 8279668: x86: AVX2 versions of vpxor should be asserted In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 11:47:42 GMT, Aleksey Shipilev wrote: > Clean backport to prevent SIGILLs on incompatible hardware. > > Additional testing: > - [x] Linux x86_64 fastdebug with -XX:UseAVX=1 Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/872 From shade at openjdk.java.net Fri Mar 11 14:25:46 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Mar 2022 14:25:46 GMT Subject: [jdk11u-dev] Integrated: 8279668: x86: AVX2 versions of vpxor should be asserted In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 11:47:42 GMT, Aleksey Shipilev wrote: > Clean backport to prevent SIGILLs on incompatible hardware. > > Additional testing: > - [x] Linux x86_64 fastdebug with -XX:UseAVX=1 This pull request has now been integrated. Changeset: 11231206 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/11231206403b4655a866fb94f4498a24ffe98baa Stats: 15 lines in 2 files changed: 12 ins; 0 del; 3 mod 8279668: x86: AVX2 versions of vpxor should be asserted Reviewed-by: goetz Backport-of: 2bbeae3f056243a224b0bda021f16cdcbee3b3d6 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/872 From sgehwolf at openjdk.java.net Fri Mar 11 14:41:38 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 11 Mar 2022 14:41:38 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: <3xc2N-8hNZsfhoqzfLLbiJzSQ_QPBXN7usN4pDKGDRU=.b4774188-329a-4010-a615-f0cb5f26b67b@github.com> On Fri, 11 Mar 2022 11:04:45 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Integration blocker >  ?? Dependency #865 must be integrated first > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \ > `$ git checkout pull/881` > > Update a local copy of the PR: \ > `$ git checkout pull/881` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 881` > > View PR using the GUI difftool: \ > `$ git pr show -t 881` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/881.diff > >
OK, thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From goetz at openjdk.java.net Fri Mar 11 15:03:46 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 15:03:46 GMT Subject: [jdk11u-dev] RFR: 8223363: Bad node estimate assertion failure In-Reply-To: <59AJzX53ijc0BmatQBOnlkRTtBvky5dVTlsNIOGQOWo=.29c9c4de-a7af-4b53-8dce-4de7e62e4477@github.com> References: <59AJzX53ijc0BmatQBOnlkRTtBvky5dVTlsNIOGQOWo=.29c9c4de-a7af-4b53-8dce-4de7e62e4477@github.com> Message-ID: On Thu, 10 Mar 2022 14:09:01 GMT, Martin Doerr wrote: > Backport of [JDK-8223363](https://bugs.openjdk.java.net/browse/JDK-8223363) (including [JDK-8223502](https://bugs.openjdk.java.net/browse/JDK-8223502) and [JDK-8224648](https://bugs.openjdk.java.net/browse/JDK-8224648) as in original commit) > loopTransform.cpp (introduction of `policy_unswitching` and `policy_maximally_unroll`) and loopnode.hpp required manual integration. Rest applies cleanly. LGTM. Differences are only minimal. Pre-submit failures: missing dependencies; unrelated. ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/874 From robm at openjdk.java.net Fri Mar 11 15:06:29 2022 From: robm at openjdk.java.net (Rob McKenna) Date: Fri, 11 Mar 2022 15:06:29 GMT Subject: [jdk18u] RFR: 8283037: Update jdk18u fix version to 18.0.2 Message-ID: 8283037: Update jdk18u fix version to 18.0.2 ------------- Commit messages: - 8283037: Update jdk18u fix version to 18.0.2 Changes: https://git.openjdk.java.net/jdk18u/pull/41/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=41&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283037 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk18u/pull/41.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/41/head:pull/41 PR: https://git.openjdk.java.net/jdk18u/pull/41 From kcr at openjdk.java.net Fri Mar 11 15:06:29 2022 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 11 Mar 2022 15:06:29 GMT Subject: [jdk18u] RFR: 8283037: Update jdk18u fix version to 18.0.2 In-Reply-To: References: Message-ID: <8SWl0pqwKJktIA2gRHi6XFW-RvUri1AAt9FqFKEmFxc=.e479f3d7-ae6d-45df-8a1a-5827cd24e58b@github.com> On Fri, 11 Mar 2022 14:40:04 GMT, Rob McKenna wrote: > 8283037: Update jdk18u fix version to 18.0.2 Marked as reviewed by kcr (no project role). ------------- PR: https://git.openjdk.java.net/jdk18u/pull/41 From coffeys at openjdk.java.net Fri Mar 11 15:06:29 2022 From: coffeys at openjdk.java.net (Sean Coffey) Date: Fri, 11 Mar 2022 15:06:29 GMT Subject: [jdk18u] RFR: 8283037: Update jdk18u fix version to 18.0.2 In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 14:40:04 GMT, Rob McKenna wrote: > 8283037: Update jdk18u fix version to 18.0.2 Marked as reviewed by coffeys (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk18u/pull/41 From robm at openjdk.java.net Fri Mar 11 15:12:04 2022 From: robm at openjdk.java.net (Rob McKenna) Date: Fri, 11 Mar 2022 15:12:04 GMT Subject: [jdk18u] Integrated: 8283037: Update jdk18u fix version to 18.0.2 In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 14:40:04 GMT, Rob McKenna wrote: > Update OpenJDK jdk18u fix version to 18.0.2 This pull request has now been integrated. Changeset: 6bebb34b Author: Rob McKenna URL: https://git.openjdk.java.net/jdk18u/commit/6bebb34bb49ee538e24131bfe65ddae6f636d511 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8283037: Update jdk18u fix version to 18.0.2 Reviewed-by: kcr, coffeys ------------- PR: https://git.openjdk.java.net/jdk18u/pull/41 From goetz at openjdk.java.net Fri Mar 11 15:13:22 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 11 Mar 2022 15:13:22 GMT Subject: [jdk11u-dev] RFR: 8211822: Some tests fail after JDK-8210039 Message-ID: A test fix. Had to adapt ProblemList, rest applies clean. Marking as /clean ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/876 Commit messages: - Backport 245a72938ada2914d5c81a0044c8a09696244214 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/882/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=882&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8211822 Stats: 89 lines in 5 files changed: 43 ins; 32 del; 14 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/882.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/882/head:pull/882 PR: https://git.openjdk.java.net/jdk11u-dev/pull/882 From jdowland at openjdk.java.net Fri Mar 11 15:26:45 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 11 Mar 2022 15:26:45 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 11:04:45 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Integration blocker >  ?? Dependency #865 must be integrated first > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \ > `$ git checkout pull/881` > > Update a local copy of the PR: \ > `$ git checkout pull/881` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 881` > > View PR using the GUI difftool: \ > `$ git pr show -t 881` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/881.diff > >
I've now run the following on a v1/hybrid setup as well as a pure v2. all pass in both cases: test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java test/hotspot/jtreg/applications/ctw/modules/java_compiler.java test/hotspot/jtreg/compiler/c2/Test8004741.java If there's any other specific tests worth running on v1/hybrid please let me know (or if you think I should do the whole tier1... not sure which of v1 or v2 GitHub Actions is testing. I'll try to check) `test/hotspot/jtreg/containers/cgroup/PlainRead.java` is failing (for me) on pure v2. Investigating ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From shade at openjdk.java.net Fri Mar 11 15:32:20 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Mar 2022 15:32:20 GMT Subject: [jdk18u] RFR: 8281318: Improve jfr/event/allocation tests reliability Message-ID: Clean backport to improve JFR tests on x86_32. Needs [JDK-8281638](https://bugs.openjdk.java.net/browse/JDK-8281638) as the follow-up. Additional testing: - [x] Linux x86_32 fastdebug, affected tests fail without the patch, pass with it ------------- Commit messages: - Backport 65831eb294b6f1f5f99988836c00005d41c27fd3 Changes: https://git.openjdk.java.net/jdk18u/pull/42/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=42&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281318 Stats: 54 lines in 3 files changed: 33 ins; 0 del; 21 mod Patch: https://git.openjdk.java.net/jdk18u/pull/42.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/42/head:pull/42 PR: https://git.openjdk.java.net/jdk18u/pull/42 From sgehwolf at openjdk.java.net Fri Mar 11 15:34:47 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 11 Mar 2022 15:34:47 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 11:04:45 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Integration blocker >  ?? Dependency #865 must be integrated first > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \ > `$ git checkout pull/881` > > Update a local copy of the PR: \ > `$ git checkout pull/881` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 881` > > View PR using the GUI difftool: \ > `$ git pr show -t 881` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/881.diff > >
Running tests in `test/hotspot/jtreg/containers` are the most important ones for this patch. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From mdoerr at openjdk.java.net Fri Mar 11 15:37:48 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 11 Mar 2022 15:37:48 GMT Subject: [jdk11u-dev] RFR: 8223363: Bad node estimate assertion failure In-Reply-To: <59AJzX53ijc0BmatQBOnlkRTtBvky5dVTlsNIOGQOWo=.29c9c4de-a7af-4b53-8dce-4de7e62e4477@github.com> References: <59AJzX53ijc0BmatQBOnlkRTtBvky5dVTlsNIOGQOWo=.29c9c4de-a7af-4b53-8dce-4de7e62e4477@github.com> Message-ID: On Thu, 10 Mar 2022 14:09:01 GMT, Martin Doerr wrote: > Backport of [JDK-8223363](https://bugs.openjdk.java.net/browse/JDK-8223363) (including [JDK-8223502](https://bugs.openjdk.java.net/browse/JDK-8223502) and [JDK-8224648](https://bugs.openjdk.java.net/browse/JDK-8224648) as in original commit) > loopTransform.cpp (introduction of `policy_unswitching` and `policy_maximally_unroll`) and loopnode.hpp required manual integration. Rest applies cleanly. Thanks for the review and the approval! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/874 From mdoerr at openjdk.java.net Fri Mar 11 15:37:49 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 11 Mar 2022 15:37:49 GMT Subject: [jdk11u-dev] Integrated: 8223363: Bad node estimate assertion failure In-Reply-To: <59AJzX53ijc0BmatQBOnlkRTtBvky5dVTlsNIOGQOWo=.29c9c4de-a7af-4b53-8dce-4de7e62e4477@github.com> References: <59AJzX53ijc0BmatQBOnlkRTtBvky5dVTlsNIOGQOWo=.29c9c4de-a7af-4b53-8dce-4de7e62e4477@github.com> Message-ID: On Thu, 10 Mar 2022 14:09:01 GMT, Martin Doerr wrote: > Backport of [JDK-8223363](https://bugs.openjdk.java.net/browse/JDK-8223363) (including [JDK-8223502](https://bugs.openjdk.java.net/browse/JDK-8223502) and [JDK-8224648](https://bugs.openjdk.java.net/browse/JDK-8224648) as in original commit) > loopTransform.cpp (introduction of `policy_unswitching` and `policy_maximally_unroll`) and loopnode.hpp required manual integration. Rest applies cleanly. This pull request has now been integrated. Changeset: 5f40afc1 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/5f40afc10909061b5b4e17ec59856611e160e474 Stats: 443 lines in 6 files changed: 310 ins; 37 del; 96 mod 8223363: Bad node estimate assertion failure 8223502: Node estimate for loop unswitching is not correct: assert(delta <= 2 * required) failed: Bad node estimate 8224648: assert(!exceeding_node_budget()) failed: Too many NODES required! failure with ctw Tighten the node estimates. New est_loop_clone_sz() implementation that will compute a "fan-out" complexity estimate as part of the size estimate (to better estimate complex loop body size after cloning). New est_loop_unroll_sz() function, used to estimate the size of a loop body att full/maximal unrolling. Correction to node budget final tests and asserts. Reviewed-by: goetz Backport-of: d222b01dee09f9963a3a0c7ae0088b64752b7809 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/874 From shade at openjdk.java.net Fri Mar 11 15:39:26 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Mar 2022 15:39:26 GMT Subject: [jdk18u] RFR: 8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions Message-ID: Follow-up for JDK-8281318 backport. Additional testing: - [x] Linux x86_32 fastdebug, affected tests pass - [x] Linux x86_32 release, affected tests pass ------------- Depends on: https://git.openjdk.java.net/jdk18u/pull/42 Commit messages: - Backport d254cf28c5e72bd9b8de863b831015237640ca25 Changes: https://git.openjdk.java.net/jdk18u/pull/43/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=43&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281638 Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk18u/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/43/head:pull/43 PR: https://git.openjdk.java.net/jdk18u/pull/43 From sgehwolf at openjdk.java.net Fri Mar 11 15:39:49 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 11 Mar 2022 15:39:49 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: <10j2DzMOPSbK-cbk3Qw3UR6IZiyHXLwT3_VOPuaKFrc=.ae9c70b7-3dd2-4a9f-a558-bbf94f4dde43@github.com> On Fri, 11 Mar 2022 11:04:45 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Integration blocker >  ?? Dependency #865 must be integrated first > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \ > `$ git checkout pull/881` > > Update a local copy of the PR: \ > `$ git checkout pull/881` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 881` > > View PR using the GUI difftool: \ > `$ git pr show -t 881` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/881.diff > >
This looks good to me, just fix the copyright update (the old value `2017` should change to `2020`) which was also done in head and this is good to go. See: https://hg.openjdk.java.net/jdk/jdk/rev/d527da8f8f9b#l4.6 ------------- Changes requested by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From sgehwolf at openjdk.java.net Fri Mar 11 15:39:49 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 11 Mar 2022 15:39:49 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: <14O7FN4tl9x9QGrd1l6fimpT9uBKHCsaFiKURpGqhrg=.35deb0af-a8da-423f-ad41-21cf108a2458@github.com> On Fri, 11 Mar 2022 15:23:08 GMT, Jonathan Dowland wrote: > `test/hotspot/jtreg/containers/cgroup/PlainRead.java` is failing (for me) on pure v2. Investigating That's likely https://bugs.openjdk.java.net/browse/JDK-8278951 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From mdoerr at openjdk.java.net Fri Mar 11 15:51:10 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 11 Mar 2022 15:51:10 GMT Subject: [jdk11u-dev] RFR: 8225475: Node budget asserts on x86_32/64 Message-ID: <5BZ88lbOUWumffT5XY187O51Oo1Xczf7kMsYCErexaA=.2be46311-4022-4ae4-a0cf-6db84bed2d02@github.com> Clean backport of JDK-8225475. ------------- Commit messages: - Backport ca29203cac651af295d78e6fff6dfdd8a614ff86 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/883/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=883&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8225475 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/883.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/883/head:pull/883 PR: https://git.openjdk.java.net/jdk11u-dev/pull/883 From jdowland at openjdk.java.net Fri Mar 11 15:52:42 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 11 Mar 2022 15:52:42 GMT Subject: [jdk11u-dev] RFR: 8230305: Cgroups v2: Container awareness In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 21:18:12 GMT, Zhengyu Gu wrote: > I would like backport cgroups v2 support to openjdk11u. > > The original patch does not apply cleanly, conflicts are resolved manually. > > Test: > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS For me, `PlainRead.java` is failing on a pure cgroups v2 system (passes on v1): ;$JT_HOME/bin/jtreg -jdk:build/linux-x86_64-normal-server-release/jdk test/hotspot/jtreg/containers/cgroup/PlainRead.java Test results: failed: 1 (I noticed this in a downstream backport and traced it back up here) I've put my JTreport here: https://jmtd.net/tmp/jdk11u_8230305_PlainRead_jtreport/JTreport/html/index.html ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/840 From mdoerr at openjdk.java.net Fri Mar 11 16:00:23 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 11 Mar 2022 16:00:23 GMT Subject: [jdk11u-dev] RFR: 8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget()) Message-ID: <0-j8KtAR1qOZ_IYtUiYcRMTaHkzDUhlttbmwCi72tlE=.8ac587fb-09d4-4b2b-99ae-363f21e9b4b0@github.com> Backport of trivial Shenandoah fix [JDK-8223389](https://bugs.openjdk.java.net/browse/JDK-8223389) after JDK-8223502 and JDK-8216137 were backported. ------------- Commit messages: - Backport 8b07b191c3a8f01085bcf9baf677fb0699183c05 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/884/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=884&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8223389 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/884.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/884/head:pull/884 PR: https://git.openjdk.java.net/jdk11u-dev/pull/884 From shade at openjdk.java.net Fri Mar 11 16:02:17 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Mar 2022 16:02:17 GMT Subject: [jdk17u-dev] RFR: 8281318: Improve jfr/event/allocation tests reliability Message-ID: <6Soc1RIO5MfX_4oc8PM5OOWbEnCcxdsTldzvG5ZfUp0=.61e2859d-ad4a-4429-ad20-6e3a48996d1f@github.com> Clean backport to improve JFR tests on x86_32. Needs [JDK-8281638](https://bugs.openjdk.java.net/browse/JDK-8281638) as the follow-up. Additional testing: - [x] Linux x86_32 fastdebug, affected tests fail without the patch, pass with it ------------- Commit messages: - Backport 65831eb294b6f1f5f99988836c00005d41c27fd3 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/240/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=240&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281318 Stats: 54 lines in 3 files changed: 33 ins; 0 del; 21 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/240.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/240/head:pull/240 PR: https://git.openjdk.java.net/jdk17u-dev/pull/240 From jdowland at openjdk.java.net Fri Mar 11 16:09:40 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 11 Mar 2022 16:09:40 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: <14O7FN4tl9x9QGrd1l6fimpT9uBKHCsaFiKURpGqhrg=.35deb0af-a8da-423f-ad41-21cf108a2458@github.com> References: <14O7FN4tl9x9QGrd1l6fimpT9uBKHCsaFiKURpGqhrg=.35deb0af-a8da-423f-ad41-21cf108a2458@github.com> Message-ID: On Fri, 11 Mar 2022 15:36:58 GMT, Severin Gehwolf wrote: > That's likely https://bugs.openjdk.java.net/browse/JDK-8278951 It looks likely (although backporting that does not resolve the failure for me). I've traced the failure right back to pr/840, so I'll leave further investigation there. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From zgu at openjdk.java.net Fri Mar 11 16:23:11 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Fri, 11 Mar 2022 16:23:11 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v2] In-Reply-To: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: <3Yi-tyqcMQf7wsTs7eftAe4yuO2lXUMdmty6Gitji8Q=.0e00d55e-cf9f-439a-8f0f-91158f16dfaa@github.com> > This is a followup backport for Cgroup v2 support. > > The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. > > In additional: > > 1) Include partial backport of JDK-8250627. > - Renamed `Metrics.c` => `CgroupMetrics.c` > - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` > - Return instance only if `isUseContainerSupport()` is enabled. > > 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test > > 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` > > Test: > > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS Zhengyu Gu has updated the pull request incrementally with three additional commits since the last revision: - Redo CgroupV1Subsystem.java merge - Severin's comments - 2 - Severin's comments ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/863/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/863/files/f200bd77..d5d4fa02 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=00-01 Stats: 127 lines in 5 files changed: 59 ins; 13 del; 55 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/863/head:pull/863 PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From shade at openjdk.java.net Fri Mar 11 16:26:21 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 11 Mar 2022 16:26:21 GMT Subject: [jdk17u-dev] RFR: 8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions Message-ID: Follow-up for JDK-8281318 backport. Additional testing: - [x] Linux x86_32 fastdebug, affected tests pass - [x] Linux x86_32 release, affected tests pass ------------- Depends on: https://git.openjdk.java.net/jdk17u-dev/pull/240 Commit messages: - Backport d254cf28c5e72bd9b8de863b831015237640ca25 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/241/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=241&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281638 Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/241.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/241/head:pull/241 PR: https://git.openjdk.java.net/jdk17u-dev/pull/241 From mdoerr at openjdk.java.net Fri Mar 11 17:32:48 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 11 Mar 2022 17:32:48 GMT Subject: [jdk11u-dev] RFR: 8211822: Some tests fail after JDK-8210039 In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 14:44:19 GMT, Goetz Lindenmaier wrote: > A test fix. Had to adapt ProblemList, rest applies clean. > Marking as /clean Marked as reviewed by mdoerr (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/882 From zgu at redhat.com Fri Mar 11 18:13:28 2022 From: zgu at redhat.com (Zhengyu Gu) Date: Fri, 11 Mar 2022 13:13:28 -0500 Subject: [jdk11u-dev] RFR: 8230305: Cgroups v2: Container awareness In-Reply-To: References: Message-ID: On 3/11/22 10:52, Jonathan Dowland wrote: > On Thu, 24 Feb 2022 21:18:12 GMT, Zhengyu Gu wrote: > >> I would like backport cgroups v2 support to openjdk11u. >> >> The original patch does not apply cleanly, conflicts are resolved manually. >> >> Test: >> - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > > For me, `PlainRead.java` is failing on a pure cgroups v2 system (passes on v1): > > > ;$JT_HOME/bin/jtreg -jdk:build/linux-x86_64-normal-server-release/jdk test/hotspot/jtreg/containers/cgroup/PlainRead.java > Test results: failed: 1 > Yes, I noticed. I would suggest you postpone your backport until the first four patches are pushed. -Zhengyu > > (I noticed this in a downstream backport and traced it back up here) > > I've put my JTreport here: https://jmtd.net/tmp/jdk11u_8230305_PlainRead_jtreport/JTreport/html/index.html > > ------------- > > PR: https://git.openjdk.java.net/jdk11u-dev/pull/840 > From zgu at openjdk.java.net Fri Mar 11 18:21:10 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Fri, 11 Mar 2022 18:21:10 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v3] In-Reply-To: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: > This is a followup backport for Cgroup v2 support. > > The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. > > In additional: > > 1) Include partial backport of JDK-8250627. > - Renamed `Metrics.c` => `CgroupMetrics.c` > - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` > - Return instance only if `isUseContainerSupport()` is enabled. > > 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test > > 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` > > Test: > > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: Fix indents and whitespaces ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/863/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/863/files/d5d4fa02..8545c356 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=01-02 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/863/head:pull/863 PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From zgu at openjdk.java.net Fri Mar 11 21:16:19 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Fri, 11 Mar 2022 21:16:19 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v4] In-Reply-To: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: > This is a followup backport for Cgroup v2 support. > > The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. > > In additional: > > 1) Include partial backport of JDK-8250627. > - Renamed `Metrics.c` => `CgroupMetrics.c` > - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` > - Return instance only if `isUseContainerSupport()` is enabled. > > 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test > > 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` > > Test: > > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: More fixes ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/863/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/863/files/8545c356..77c1f7f0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=02-03 Stats: 40 lines in 4 files changed: 17 ins; 0 del; 23 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/863/head:pull/863 PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From zgu at openjdk.java.net Fri Mar 11 21:26:47 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Fri, 11 Mar 2022 21:26:47 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v4] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Fri, 11 Mar 2022 21:16:19 GMT, Zhengyu Gu wrote: >> This is a followup backport for Cgroup v2 support. >> >> The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. >> >> In additional: >> >> 1) Include partial backport of JDK-8250627. >> - Renamed `Metrics.c` => `CgroupMetrics.c` >> - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` >> - Return instance only if `isUseContainerSupport()` is enabled. >> >> 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test >> >> 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` >> >> Test: >> >> - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS > > Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: > > More fixes > @jerboaa Thanks for the review. I underestimated how many out-of-order backports that affected this backport, especially files without conflicts. I redid `CgroupV1Subsystem.java` and need to go through others. Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From goetz at openjdk.java.net Mon Mar 14 07:30:49 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 07:30:49 GMT Subject: [jdk11u-dev] RFR: 8211822: Some tests fail after JDK-8210039 In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 14:44:19 GMT, Goetz Lindenmaier wrote: > A test fix. Had to adapt ProblemList, rest applies clean. > Marking as /clean Pre-submit failures: crash in gc/cms/TestBubbleUpRef.java dependencies missing. both unrelated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/882 From goetz at openjdk.java.net Mon Mar 14 07:47:23 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 07:47:23 GMT Subject: [jdk11u-dev] RFR: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed Message-ID: I backport this because it fixes a test failure we see on mac aarch. I had to remove the record from the test UniqueMacAddressesTest.java ------------- Commit messages: - Backport f5d36e6c9470b1ac5326990b1c4fea80457c4ad6 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/885/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=885&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8246741 Stats: 90 lines in 1 file changed: 24 ins; 39 del; 27 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/885.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/885/head:pull/885 PR: https://git.openjdk.java.net/jdk11u-dev/pull/885 From goetz at openjdk.java.net Mon Mar 14 07:49:55 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 07:49:55 GMT Subject: [jdk11u-dev] Integrated: 8210039: move OSInfo to top level testlibrary In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 16:09:18 GMT, Goetz Lindenmaier wrote: > I want to backport this test cleanup as it simplifies later backports. > > Stuff to resolve was all trivial. > > Already fixed: > patching file test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.java > patching file test/jdk/java/awt/FileDialog/8003399/bug8003399.java > > Resolved because html test was already removed > test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.java > test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.java > test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.java > test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java > test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java > > Context > test/jdk/javax/swing/JButton/4796987/bug4796987.java > > Copyright > patching file test/jdk/javax/swing/JFileChooser/8041694/bug8041694.java > patching file test/jdk/javax/swing/JPopupMenu/7154841/bug7154841.java > > Indentation > patching file test/jdk/javax/swing/JLabel/6596966/bug6596966.java > patching file test/jdk/javax/swing/JMenu/6470128/bug6470128.java > patching file test/jdk/javax/swing/JPopupMenu/6827786/bug6827786.java > patching file test/jdk/javax/swing/JScrollBar/bug4202954/bug4202954.java > patching file test/jdk/javax/swing/JTabbedPane/4624207/bug4624207.java > > Dependency of platform removed by backport of later change. > patching file test/jdk/sun/awt/dnd/8024061/bug8024061.java This pull request has now been integrated. Changeset: c94ce2cc Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/c94ce2cce4414bc693a543c686a47c9c66a41e7d Stats: 941 lines in 78 files changed: 220 ins; 326 del; 395 mod 8210039: move OSInfo to top level testlibrary Reviewed-by: mdoerr Backport-of: 315e71f87e7441fff8a5b95335b7c8125e383766 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/876 From goetz at openjdk.java.net Mon Mar 14 07:58:19 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 07:58:19 GMT Subject: [jdk11u-dev] RFR: 8211822: Some tests fail after JDK-8210039 [v2] In-Reply-To: References: Message-ID: > A test fix. Had to adapt ProblemList, rest applies clean. > Marking as /clean Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport 245a72938ada2914d5c81a0044c8a09696244214 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/882/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/882/files/d6675957..8b7e555d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=882&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=882&range=00-01 Stats: 1011 lines in 46 files changed: 450 ins; 411 del; 150 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/882.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/882/head:pull/882 PR: https://git.openjdk.java.net/jdk11u-dev/pull/882 From duke at openjdk.java.net Mon Mar 14 07:58:20 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Mon, 14 Mar 2022 07:58:20 GMT Subject: [jdk11u-dev] RFR: 8211822: Some tests fail after JDK-8210039 In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 14:44:19 GMT, Goetz Lindenmaier wrote: > A test fix. Had to adapt ProblemList, rest applies clean. > Marking as /clean The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8210039 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/882 From shade at openjdk.java.net Mon Mar 14 09:13:57 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Mar 2022 09:13:57 GMT Subject: [jdk17u-dev] RFR: 8277893: Arraycopy stress tests Message-ID: Clean backport to improve testing. Additional testing: - [x] Linux x86_64 fastdebug passes `hotspot_compiler_arraycopy` ------------- Commit messages: - Backport 29bd73638a22d341767a1266723a7d7263e17093 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/242/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=242&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277893 Stats: 1154 lines in 12 files changed: 1153 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/242.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/242/head:pull/242 PR: https://git.openjdk.java.net/jdk17u-dev/pull/242 From shade at openjdk.java.net Mon Mar 14 09:14:06 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Mar 2022 09:14:06 GMT Subject: [jdk18u] RFR: 8277893: Arraycopy stress tests Message-ID: Clean backport to improve testing. Additional testing: - [x] Linux x86_64 fastdebug passes `hotspot_compiler_arraycopy` ------------- Commit messages: - Backport 29bd73638a22d341767a1266723a7d7263e17093 Changes: https://git.openjdk.java.net/jdk18u/pull/44/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=44&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277893 Stats: 1154 lines in 12 files changed: 1153 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk18u/pull/44.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/44/head:pull/44 PR: https://git.openjdk.java.net/jdk18u/pull/44 From shade at openjdk.java.net Mon Mar 14 09:16:28 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Mar 2022 09:16:28 GMT Subject: [jdk18u] RFR: 8283017: GHA: Workflows break with update release versions Message-ID: Clean backport to fix GHA in 18u. Additional testing: - [ ] GHA checks now pass (in progress) ------------- Commit messages: - Backport 01570ca92d234481df2d540027e320b91af415a0 Changes: https://git.openjdk.java.net/jdk18u/pull/45/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=45&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283017 Stats: 29 lines in 1 file changed: 18 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jdk18u/pull/45.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/45/head:pull/45 PR: https://git.openjdk.java.net/jdk18u/pull/45 From shade at openjdk.java.net Mon Mar 14 09:20:22 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Mar 2022 09:20:22 GMT Subject: [jdk17u-dev] RFR: 8283017: GHA: Workflows break with update release versions Message-ID: Unclean backport to enable GHA workflows for update releases. This drops the 17u-specific hack (https://bugs.openjdk.java.net/browse/JDK-8276130) from GHA, and uses the handling code from mainline. Additional testing: - [ ] GHA checks still pass (in progress) ------------- Commit messages: - Backport 01570ca92d234481df2d540027e320b91af415a0 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/243/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=243&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283017 Stats: 29 lines in 1 file changed: 18 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/243.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/243/head:pull/243 PR: https://git.openjdk.java.net/jdk17u-dev/pull/243 From shade at openjdk.java.net Mon Mar 14 10:16:04 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Mar 2022 10:16:04 GMT Subject: [jdk17u-dev] RFR: 8281168: Micro-optimize VarForm.getMemberName for interpreter In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 15:36:37 GMT, Aleksey Shipilev wrote: > Clean backport to improve interpreter performance. > > Additional testing: > - [x] Linux x86_64 fastdebug tier1 Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/230 From shade at openjdk.java.net Mon Mar 14 10:16:05 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Mar 2022 10:16:05 GMT Subject: [jdk17u-dev] Integrated: 8281168: Micro-optimize VarForm.getMemberName for interpreter In-Reply-To: References: Message-ID: <8es6QfIN2kCdhplWZhPyYk6Ezq-E36FmTdrm1ZPS2fk=.c9a87b38-2652-4f09-b953-b3091d3d2be7@github.com> On Thu, 10 Mar 2022 15:36:37 GMT, Aleksey Shipilev wrote: > Clean backport to improve interpreter performance. > > Additional testing: > - [x] Linux x86_64 fastdebug tier1 This pull request has now been integrated. Changeset: c82e18fe Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u-dev/commit/c82e18fe8fb17c7dfd156e72aa0c763d09a5fa13 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod 8281168: Micro-optimize VarForm.getMemberName for interpreter Backport-of: fc77217814eb1a346d7380299abdc2b01a69b4de ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/230 From rkennke at openjdk.java.net Mon Mar 14 10:22:17 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 14 Mar 2022 10:22:17 GMT Subject: [jdk18u] RFR: 8280041: Retry loop issues in java.io.ClassCache Message-ID: This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. The original change has baked for several weeks in jdk19 and applies cleanly. Testing: - [x] tier1 - [ ] tier2 - [ ] tier3 ------------- Depends on: https://git.openjdk.java.net/jdk18u/pull/36 Commit messages: - Backport cebaad1c94c301304fd146526cac95bfeaac66bf Changes: https://git.openjdk.java.net/jdk18u/pull/46/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=46&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280041 Stats: 41 lines in 1 file changed: 29 ins; 0 del; 12 mod Patch: https://git.openjdk.java.net/jdk18u/pull/46.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/46/head:pull/46 PR: https://git.openjdk.java.net/jdk18u/pull/46 From rkennke at openjdk.java.net Mon Mar 14 10:46:32 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 14 Mar 2022 10:46:32 GMT Subject: [jdk17u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache Message-ID: This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. The original change has baked for several weeks in jdk19 and applies cleanly. Testing: - [x] tier1 - [ ] tier2 - [ ] tier3 ------------- Commit messages: - Backport cebaad1c94c301304fd146526cac95bfeaac66bf - Backport 8eb453baebe377697286f7eb32280ca9f1fd7775 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/244/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=244&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280041 Stats: 525 lines in 4 files changed: 313 ins; 186 del; 26 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/244.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/244/head:pull/244 PR: https://git.openjdk.java.net/jdk17u-dev/pull/244 From shade at openjdk.java.net Mon Mar 14 10:49:53 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Mar 2022 10:49:53 GMT Subject: [jdk11u-dev] Integrated: 8283018: 11u GHA: Update GCC 9 minor versions In-Reply-To: References: Message-ID: <6SSVntDlAYEuqv7VStjfNRipI8saWcERtNA-c7Zp86A=.d8370c1b-ceb9-45c6-86b2-63bd6b6fdb11@github.com> On Fri, 11 Mar 2022 09:51:00 GMT, Aleksey Shipilev wrote: > Current GHA runs in 11u fail with: > > > E: Version '9.3.0-17ubuntu1~20.04cross2' for 'gcc-9-aarch64-linux-gnu' was not found > E: Version '9.3.0-17ubuntu1~20.04cross2' for 'g++-9-aarch64-linux-gnu' was not found > > > We should update these. 11u GHA workflow runs GCC 9, not GCC 10 like the rest of releases, so this is the 11u-specific bug. This pull request has now been integrated. Changeset: 997c55f3 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/997c55f3600cf0c2f74de45f34934617eb3ba599 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8283018: 11u GHA: Update GCC 9 minor versions Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/879 From shade at openjdk.java.net Mon Mar 14 10:49:53 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 14 Mar 2022 10:49:53 GMT Subject: [jdk11u-dev] RFR: 8283018: 11u GHA: Update GCC 9 minor versions In-Reply-To: References: Message-ID: <2YJ6qyb2mZUTuC9sR6M-8-h_jhGmgZua_P5cMkGUytk=.11e8f9f4-71f0-43b4-bca9-994629d7364e@github.com> On Fri, 11 Mar 2022 09:51:00 GMT, Aleksey Shipilev wrote: > Current GHA runs in 11u fail with: > > > E: Version '9.3.0-17ubuntu1~20.04cross2' for 'gcc-9-aarch64-linux-gnu' was not found > E: Version '9.3.0-17ubuntu1~20.04cross2' for 'g++-9-aarch64-linux-gnu' was not found > > > We should update these. 11u GHA workflow runs GCC 9, not GCC 10 like the rest of releases, so this is the 11u-specific bug. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/879 From rkennke at openjdk.java.net Mon Mar 14 11:02:43 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 14 Mar 2022 11:02:43 GMT Subject: [jdk17u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache [v2] In-Reply-To: References: Message-ID: > This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [ ] tier2 > - [ ] tier3 Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: Add missing tests ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/245/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/245/files/2083a749..843d5dae Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=245&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=245&range=00-01 Stats: 161 lines in 4 files changed: 161 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/245.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/245/head:pull/245 PR: https://git.openjdk.java.net/jdk17u-dev/pull/245 From anleonar at redhat.com Mon Mar 14 12:22:26 2022 From: anleonar at redhat.com (Andrew Leonard) Date: Mon, 14 Mar 2022 12:22:26 +0000 Subject: How to re-run PR pre-submit tests? Message-ID: One of my pre-submit tests failed and i'd like to re-run it, does anyone know how that can be done? I've normally seen "Re-run all jobs", but don't see that on my backport PR: https://github.com/openjdk/jdk17u-dev/pull/246/checks?check_run_id=5536931356 thanks From mdoerr at openjdk.java.net Mon Mar 14 11:31:47 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 14 Mar 2022 11:31:47 GMT Subject: [jdk11u-dev] Integrated: 8225475: Node budget asserts on x86_32/64 In-Reply-To: <5BZ88lbOUWumffT5XY187O51Oo1Xczf7kMsYCErexaA=.2be46311-4022-4ae4-a0cf-6db84bed2d02@github.com> References: <5BZ88lbOUWumffT5XY187O51Oo1Xczf7kMsYCErexaA=.2be46311-4022-4ae4-a0cf-6db84bed2d02@github.com> Message-ID: <_21_NrFgdCB5ghdpdOfPXBs2YmQBw35eD-CWZw65bGc=.dec180ca-38ac-4c63-a8c1-8c8f0b9c5845@github.com> On Fri, 11 Mar 2022 15:45:04 GMT, Martin Doerr wrote: > Clean backport of JDK-8225475. This pull request has now been integrated. Changeset: f3708bb1 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/f3708bb16926b0765cd68e5447651c03d9fb3d6f Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8225475: Node budget asserts on x86_32/64 Make the (ad-hoc) loop cloning size estimate more pessimistic. Backport-of: ca29203cac651af295d78e6fff6dfdd8a614ff86 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/883 From mdoerr at openjdk.java.net Mon Mar 14 11:46:20 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 14 Mar 2022 11:46:20 GMT Subject: [jdk11u-dev] RFR: 8229499: Node budget assert in fuzzed test Message-ID: <44hrok75QUxbQHzEGnie878guHkxy0igqDb11Nm80es=.9b10312a-ab56-410d-a8bd-e9763605d37d@github.com> Almost clean backport of [JDK-8229499](https://bugs.openjdk.java.net/browse/JDK-8229499) Only the minor cleanup in loopnode.hpp required manual integration. ------------- Commit messages: - Backport 8275b17b07b1c15bde79b36b76ecbe3072db1e1a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/888/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=888&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8229499 Stats: 202 lines in 4 files changed: 118 ins; 33 del; 51 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/888.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/888/head:pull/888 PR: https://git.openjdk.java.net/jdk11u-dev/pull/888 From rkennke at openjdk.java.net Mon Mar 14 10:53:22 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 14 Mar 2022 10:53:22 GMT Subject: [jdk17u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache Message-ID: This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. The original change has baked for several weeks in jdk19 and applies cleanly. Testing: - [x] tier1 - [ ] tier2 - [ ] tier3 ------------- Depends on: https://git.openjdk.java.net/jdk17u-dev/pull/210 Commit messages: - Backport cebaad1c94c301304fd146526cac95bfeaac66bf Changes: https://git.openjdk.java.net/jdk17u-dev/pull/245/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=245&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280041 Stats: 41 lines in 1 file changed: 29 ins; 0 del; 12 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/245.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/245/head:pull/245 PR: https://git.openjdk.java.net/jdk17u-dev/pull/245 From rkennke at openjdk.java.net Mon Mar 14 10:55:20 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 14 Mar 2022 10:55:20 GMT Subject: [jdk11u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache Message-ID: <8a9lCHHdvjKYN7QzfnB1yrLWUarFljBfnDGy3xrcYU8=.89c903ad-446e-4c67-82fe-9fc40f5027b5@github.com> This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. The original change has baked for several weeks in jdk19 and applies cleanly. Testing: - [x] tier1 - [ ] tier2 - [ ] tier3 ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/869 Commit messages: - Backport cebaad1c94c301304fd146526cac95bfeaac66bf Changes: https://git.openjdk.java.net/jdk11u-dev/pull/887/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=887&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280041 Stats: 41 lines in 1 file changed: 29 ins; 0 del; 12 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/887.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/887/head:pull/887 PR: https://git.openjdk.java.net/jdk11u-dev/pull/887 From mdoerr at openjdk.java.net Mon Mar 14 12:10:03 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 14 Mar 2022 12:10:03 GMT Subject: [jdk11u-dev] RFR: 8234605: C2 failed "assert(C->live_nodes() - live_at_begin <= 2 * _nodes_required) failed: Bad node estimate: actual = 208 >> request = 101" Message-ID: Clean Backport of JDK-8234605. ------------- Commit messages: - Backport d19f2bdec01eb324d200f2144293d05ea310f9b8 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/889/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=889&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8234605 Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/889.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/889/head:pull/889 PR: https://git.openjdk.java.net/jdk11u-dev/pull/889 From mdoerr at openjdk.java.net Mon Mar 14 11:33:01 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 14 Mar 2022 11:33:01 GMT Subject: [jdk11u-dev] RFR: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed In-Reply-To: References: Message-ID: <8xYcrvS06EdXuvWmR5kYPMaZbZkwHqTqnKZmTI11Nek=.2db0235a-3604-4439-9f7b-6352eb4bfa49@github.com> On Mon, 14 Mar 2022 07:39:26 GMT, Goetz Lindenmaier wrote: > I backport this because it fixes a test failure we see on mac aarch. > I had to remove the record from the test UniqueMacAddressesTest.java LGTM. Thanks for backporting! ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/885 From goetz at openjdk.java.net Mon Mar 14 12:45:02 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 12:45:02 GMT Subject: [jdk17u-dev] RFR: 8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 21e302a0f4cbf3ace907c36d871a2f2cf6277188 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/250/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=250&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270435 Stats: 10 lines in 1 file changed: 8 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/250.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/250/head:pull/250 PR: https://git.openjdk.java.net/jdk17u-dev/pull/250 From goetz at openjdk.java.net Mon Mar 14 12:37:16 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 12:37:16 GMT Subject: [jdk17u-dev] RFR: 8275037: Test vmTestbase/nsk/sysdict/vm/stress/btree/btree011/btree011.java crashes with memory exhaustion on Windows Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 9f2f46ee4576d9cd0190530949e5e50f796a6bdc Changes: https://git.openjdk.java.net/jdk17u-dev/pull/249/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=249&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275037 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/249.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/249/head:pull/249 PR: https://git.openjdk.java.net/jdk17u-dev/pull/249 From zgu at openjdk.java.net Mon Mar 14 13:10:12 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 14 Mar 2022 13:10:12 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v5] In-Reply-To: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: <8QEHt4QKzLODkHDOlI-rip45zBC0GfyBjfyhnmQFoxk=.ce82503c-d76f-4791-8c57-43a5f5a65303@github.com> > This is a followup backport for Cgroup v2 support. > > The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. > > In additional: > > 1) Include partial backport of JDK-8250627. > - Renamed `Metrics.c` => `CgroupMetrics.c` > - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` > - Return instance only if `isUseContainerSupport()` is enabled. > > 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test > > 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` > > Test: > > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: Fix MetricsTesterCgroupV1 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/863/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/863/files/77c1f7f0..bd9ec039 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=03-04 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/863/head:pull/863 PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From sgehwolf at openjdk.java.net Mon Mar 14 13:16:46 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 14 Mar 2022 13:16:46 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v5] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Thu, 10 Mar 2022 19:14:17 GMT, Severin Gehwolf wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix MetricsTesterCgroupV1 > > A few more comments related to: https://bugs.openjdk.java.net/browse/JDK-8250984 > @jerboaa Thanks for the review. I underestimated how many out-of-order backports that affected this backport, especially files without conflicts. I redid `CgroupV1Subsystem.java` and need to go through others. Anytime. Please let me know when you are ready for another review. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From rkennke at openjdk.java.net Mon Mar 14 10:47:22 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 14 Mar 2022 10:47:22 GMT Subject: [jdk17u-dev] Withdrawn: 8280041: Retry loop issues in java.io.ClassCache In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 10:39:18 GMT, Roman Kennke wrote: > This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [ ] tier2 > - [ ] tier3 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/244 From rkennke at openjdk.java.net Mon Mar 14 11:01:54 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 14 Mar 2022 11:01:54 GMT Subject: [jdk11u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache [v2] In-Reply-To: <8a9lCHHdvjKYN7QzfnB1yrLWUarFljBfnDGy3xrcYU8=.89c903ad-446e-4c67-82fe-9fc40f5027b5@github.com> References: <8a9lCHHdvjKYN7QzfnB1yrLWUarFljBfnDGy3xrcYU8=.89c903ad-446e-4c67-82fe-9fc40f5027b5@github.com> Message-ID: > This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [ ] tier2 > - [ ] tier3 Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: Add missing tests ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/887/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/887/files/89758aff..07ca7b9d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=887&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=887&range=00-01 Stats: 161 lines in 4 files changed: 161 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/887.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/887/head:pull/887 PR: https://git.openjdk.java.net/jdk11u-dev/pull/887 From aleonard at openjdk.java.net Mon Mar 14 12:20:12 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Mon, 14 Mar 2022 12:20:12 GMT Subject: [jdk17u-dev] RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date Message-ID: This PR is to enable usage of the --date option for OpenJDK build to enable reproducible build jars & jmods. ------------- Commit messages: - Backport 214f98f6b07e312e6f4ded5364a94277114784e7 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/246/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=246&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278766 Stats: 65 lines in 7 files changed: 45 ins; 6 del; 14 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/246.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/246/head:pull/246 PR: https://git.openjdk.java.net/jdk17u-dev/pull/246 From goetz at openjdk.java.net Mon Mar 14 12:31:08 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 12:31:08 GMT Subject: [jdk17u-dev] RFR: 8272168: some hotspot runtime/logging tests don't check exit code Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 3b899ef7ffd87477ac1b10f4334b127597e9fe32 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/247/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=247&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272168 Stats: 16 lines in 5 files changed: 12 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/247.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/247/head:pull/247 PR: https://git.openjdk.java.net/jdk17u-dev/pull/247 From rkennke at openjdk.java.net Mon Mar 14 11:00:51 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 14 Mar 2022 11:00:51 GMT Subject: [jdk18u] RFR: 8280041: Retry loop issues in java.io.ClassCache [v2] In-Reply-To: References: Message-ID: > This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [ ] tier2 > - [ ] tier3 Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: Add missing tests ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/46/files - new: https://git.openjdk.java.net/jdk18u/pull/46/files/2ff35307..b3783162 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=46&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=46&range=00-01 Stats: 161 lines in 4 files changed: 161 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/46.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/46/head:pull/46 PR: https://git.openjdk.java.net/jdk18u/pull/46 From mdoerr at openjdk.java.net Mon Mar 14 11:31:49 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 14 Mar 2022 11:31:49 GMT Subject: [jdk11u-dev] Integrated: 8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget()) In-Reply-To: <0-j8KtAR1qOZ_IYtUiYcRMTaHkzDUhlttbmwCi72tlE=.8ac587fb-09d4-4b2b-99ae-363f21e9b4b0@github.com> References: <0-j8KtAR1qOZ_IYtUiYcRMTaHkzDUhlttbmwCi72tlE=.8ac587fb-09d4-4b2b-99ae-363f21e9b4b0@github.com> Message-ID: On Fri, 11 Mar 2022 15:51:38 GMT, Martin Doerr wrote: > Backport of trivial Shenandoah fix [JDK-8223389](https://bugs.openjdk.java.net/browse/JDK-8223389) after JDK-8223502 and JDK-8216137 were backported. This pull request has now been integrated. Changeset: f441970b Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/f441970b6216506eb8183a364162b07efb7e3dc3 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget()) Backport-of: 8b07b191c3a8f01085bcf9baf677fb0699183c05 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/884 From mdoerr at openjdk.java.net Mon Mar 14 13:35:22 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 14 Mar 2022 13:35:22 GMT Subject: [jdk11u-dev] RFR: 8231565: More node budget asserts in fuzzed tests Message-ID: Almost clean backport of https://bugs.openjdk.java.net/browse/JDK-8231565 Only cleanup in `PhaseIdealLoop::partial_peel` (loopopts.cpp) required manual integration. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/888 Commit messages: - Backport 902858e3ceb43bf92ea9fa038b9edcf1ee0c48b5 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/890/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=890&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8231565 Stats: 105 lines in 3 files changed: 86 ins; 5 del; 14 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/890.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/890/head:pull/890 PR: https://git.openjdk.java.net/jdk11u-dev/pull/890 From goetz at openjdk.java.net Mon Mar 14 14:09:47 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 14:09:47 GMT Subject: [jdk11u-dev] Integrated: 8211822: Some tests fail after JDK-8210039 In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 14:44:19 GMT, Goetz Lindenmaier wrote: > A test fix. Had to adapt ProblemList, rest applies clean. > Marking as /clean This pull request has now been integrated. Changeset: 2ed46d8c Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/2ed46d8ce17afa1613ad11cbdd42ab061788f424 Stats: 89 lines in 5 files changed: 43 ins; 32 del; 14 mod 8211822: Some tests fail after JDK-8210039 8202886: [macos] Test java/awt/MenuBar/8007006/bug8007006.java fails on MacOS Reviewed-by: mdoerr Backport-of: 245a72938ada2914d5c81a0044c8a09696244214 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/882 From goetz at openjdk.java.net Mon Mar 14 14:11:46 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 14:11:46 GMT Subject: [jdk11u-dev] Integrated: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 07:39:26 GMT, Goetz Lindenmaier wrote: > I backport this because it fixes a test failure we see on mac aarch. > I had to remove the record from the test UniqueMacAddressesTest.java This pull request has now been integrated. Changeset: ed275bab Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/ed275bab2c0ae61fbc1e0c2ed32434225b608dee Stats: 90 lines in 1 file changed: 24 ins; 39 del; 27 mod 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed Reviewed-by: mdoerr Backport-of: f5d36e6c9470b1ac5326990b1c4fea80457c4ad6 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/885 From goetz at openjdk.java.net Mon Mar 14 14:14:02 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 14:14:02 GMT Subject: [jdk17u-dev] Integrated: 8267163: Rename anonymous loader tests to hidden loader tests In-Reply-To: References: Message-ID: <-puie8k-rWhu3pBLnbi8t_mh1Pi5_I7z2z0jyM6iv5Q=.fcb1e9be-985f-4d3d-9330-593fd5e0a6a6@github.com> On Thu, 10 Mar 2022 16:03:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: d4d33488 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/d4d334886cbb86826cb2a43a244486055362b310 Stats: 1268 lines in 21 files changed: 631 ins; 631 del; 6 mod 8267163: Rename anonymous loader tests to hidden loader tests Reviewed-by: mdoerr Backport-of: 5c21c0044104b52fcaf3f3a830ea6e219d504ada ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/232 From goetz at openjdk.java.net Mon Mar 14 14:20:02 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 14:20:02 GMT Subject: [jdk17u-dev] Integrated: 8269077: TestSystemGC uses "require vm.gc.G1" for large pages subtest In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 16:47:28 GMT, Goetz Lindenmaier wrote: > I backport this test fix to simplify a follow up backport. > I think this is useful, too. This pull request has now been integrated. Changeset: 16f75080 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/16f75080e6d8506fbb2716feb267091f422ce6bc Stats: 9 lines in 1 file changed: 7 ins; 1 del; 1 mod 8269077: TestSystemGC uses "require vm.gc.G1" for large pages subtest Backport-of: 1a818154cfe852a680070c5c07f2df33109e5b54 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/238 From clanger at openjdk.java.net Mon Mar 14 14:34:04 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 14 Mar 2022 14:34:04 GMT Subject: [jdk17u-dev] RFR: 8283017: GHA: Workflows break with update release versions In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 09:10:33 GMT, Aleksey Shipilev wrote: > Unclean backport to enable GHA workflows for update releases. This drops the 17u-specific hack (https://bugs.openjdk.java.net/browse/JDK-8276130) from GHA, and uses the handling code from mainline. > > Additional testing: > - [ ] GHA checks still pass (in progress) Looks good. Thanks for doing this, also in head. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/243 From mdoerr at openjdk.java.net Mon Mar 14 14:42:17 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 14 Mar 2022 14:42:17 GMT Subject: [jdk11u-dev] RFR: 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist! Message-ID: Backport of https://bugs.openjdk.java.net/browse/JDK-8279356 Fix needs manual integration because 11u has additional CDS code in `Method::link_method`. Copyright year updates were also integrated manually. ------------- Commit messages: - Backport 6d7db4b0b3e9172645cef12c36fbeb41a6d38d83 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/891/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=891&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279356 Stats: 53 lines in 2 files changed: 43 ins; 2 del; 8 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/891.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/891/head:pull/891 PR: https://git.openjdk.java.net/jdk11u-dev/pull/891 From aleonard at openjdk.java.net Mon Mar 14 14:44:25 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Mon, 14 Mar 2022 14:44:25 GMT Subject: [jdk17u-dev] RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v2] In-Reply-To: References: Message-ID: > This PR is to enable usage of the --date option for OpenJDK build to enable reproducible build jars & jmods. Andrew Leonard has updated the pull request incrementally with two additional commits since the last revision: - retrigger checks Signed-off-by: Andrew Leonard - retrigger checks Signed-off-by: root ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/246/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/246/files/a1f48396..04762b5d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=246&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=246&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/246.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/246/head:pull/246 PR: https://git.openjdk.java.net/jdk17u-dev/pull/246 From goetz at openjdk.java.net Mon Mar 14 14:55:08 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 14:55:08 GMT Subject: [jdk17u-dev] RFR: 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport ad1ff27b730773a141d73744e5f5a899bdfbea78 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/251/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=251&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277422 Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/251.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/251/head:pull/251 PR: https://git.openjdk.java.net/jdk17u-dev/pull/251 From mdoerr at openjdk.java.net Mon Mar 14 14:58:22 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 14 Mar 2022 14:58:22 GMT Subject: [jdk11u-dev] RFR: 8266251: compiler.inlining.InlineAccessors shouldn't do testing in driver VM Message-ID: Clean backport of [JDK-8266251](https://bugs.openjdk.java.net/browse/JDK-8266251) ------------- Commit messages: - Backport 9605aeddee70ba4f3dba2ae2a3d100319164b03d Changes: https://git.openjdk.java.net/jdk11u-dev/pull/892/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=892&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266251 Stats: 6 lines in 1 file changed: 0 ins; 4 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/892.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/892/head:pull/892 PR: https://git.openjdk.java.net/jdk11u-dev/pull/892 From mdoerr at openjdk.java.net Mon Mar 14 15:13:32 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 14 Mar 2022 15:13:32 GMT Subject: [jdk17u-dev] RFR: 8273139: C2: assert(f <= 1 && f >= 0) failed: Incorrect frequency Message-ID: Clean backport of [JDK-8273139](https://bugs.openjdk.java.net/browse/JDK-8273139) ------------- Commit messages: - Backport 68b40ec28658a2dd829c77281b0025e16095c170 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/252/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=252&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273139 Stats: 19 lines in 1 file changed: 2 ins; 5 del; 12 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/252.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/252/head:pull/252 PR: https://git.openjdk.java.net/jdk17u-dev/pull/252 From goetz at openjdk.java.net Mon Mar 14 15:31:16 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 15:31:16 GMT Subject: [jdk17u-dev] RFR: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 1f1db838ab7d427170d59a8b55fdb45c4d80c359 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/253/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=253&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278186 Stats: 75 lines in 4 files changed: 66 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/253.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/253/head:pull/253 PR: https://git.openjdk.java.net/jdk17u-dev/pull/253 From sgehwolf at openjdk.java.net Mon Mar 14 15:34:52 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 14 Mar 2022 15:34:52 GMT Subject: [jdk17u-dev] RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v2] In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 14:44:25 GMT, Andrew Leonard wrote: >> This PR is to enable usage of the --date option for OpenJDK build to enable reproducible build jars & jmods. > > Andrew Leonard has updated the pull request incrementally with two additional commits since the last revision: > > - retrigger checks > > Signed-off-by: Andrew Leonard > - retrigger checks > > Signed-off-by: root Has a CSR for this been filed? I see https://bugs.openjdk.java.net/browse/JDK-8277755 was the original in HEAD. There should be an approved CSR targeting JDK 17 before integrating this. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/246 From goetz at openjdk.java.net Mon Mar 14 15:51:43 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 15:51:43 GMT Subject: [jdk17u-dev] RFR: 8274751: Drag And Drop hangs on Windows In-Reply-To: References: Message-ID: On Wed, 2 Feb 2022 04:42:55 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [7a0a6c95](https://github.com/openjdk/jdk/commit/7a0a6c95a53c6cb3340328d6543a97807320b740) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Dmitry Markov on 24 Jan 2022 and was reviewed by Alexey Ivanov, Phil Race and Sergey Bylokhov. > Thanks! Hi @mrserb, you could finish this up now. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/142 From goetz at openjdk.java.net Mon Mar 14 15:55:15 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 15:55:15 GMT Subject: [jdk17u-dev] RFR: 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport e14fb4f4aa9c4569615005e474f897c54094f024 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/254/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=254&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279437 Stats: 492 lines in 10 files changed: 359 ins; 32 del; 101 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/254.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/254/head:pull/254 PR: https://git.openjdk.java.net/jdk17u-dev/pull/254 From goetz at openjdk.java.net Mon Mar 14 16:02:15 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 14 Mar 2022 16:02:15 GMT Subject: [jdk17u-dev] RFR: 8214733: runtime/8176717/TestInheritFD.java timed out Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 4501ddda7f8e0eb9352a937030a62902bfaac647 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/255/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=255&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8214733 Stats: 6 lines in 1 file changed: 2 ins; 1 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/255.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/255/head:pull/255 PR: https://git.openjdk.java.net/jdk17u-dev/pull/255 From aleonard at openjdk.java.net Mon Mar 14 16:07:56 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Mon, 14 Mar 2022 16:07:56 GMT Subject: [jdk17u-dev] RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v2] In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 15:31:08 GMT, Severin Gehwolf wrote: > Has a CSR for this been filed? I see https://bugs.openjdk.java.net/browse/JDK-8277755 was the original in HEAD. There should be an approved CSR targeting JDK 17 before integrating this. @jerboaa JDK-8277755 is a different issue, which is actually already in jdk17u (https://github.com/openjdk/jdk17u/commit/761e2989e459b9403a5ee3c5f3c776838637f8ac). This PR is backport of https://github.com/openjdk/jdk/pull/6878 bug https://bugs.openjdk.java.net/browse/JDK-8278766. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/246 From sgehwolf at openjdk.java.net Mon Mar 14 16:26:50 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 14 Mar 2022 16:26:50 GMT Subject: [jdk17u-dev] RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v2] In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 14:44:25 GMT, Andrew Leonard wrote: >> This PR is to enable usage of the --date option for OpenJDK build to enable reproducible build jars & jmods. > > Andrew Leonard has updated the pull request incrementally with two additional commits since the last revision: > > - retrigger checks > > Signed-off-by: Andrew Leonard > - retrigger checks > > Signed-off-by: root > JDK-8277755 is a different issue, which is actually already in jdk17u ([openjdk/jdk17u at 761e298](https://github.com/openjdk/jdk17u/commit/761e2989e459b9403a5ee3c5f3c776838637f8ac)). This PR is backport of [openjdk/jdk#6878](https://github.com/openjdk/jdk/pull/6878) bug https://bugs.openjdk.java.net/browse/JDK-8278766. Ahh, ok then. Sorry for the noise. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/246 From sgehwolf at openjdk.java.net Mon Mar 14 17:03:46 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 14 Mar 2022 17:03:46 GMT Subject: [jdk11u-dev] RFR: 8230305: Cgroups v2: Container awareness In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 15:49:08 GMT, Jonathan Dowland wrote: > For me, `PlainRead.java` is failing on a pure cgroups v2 system (passes on v1): > > ``` > ;$JT_HOME/bin/jtreg -jdk:build/linux-x86_64-normal-server-release/jdk test/hotspot/jtreg/containers/cgroup/PlainRead.java > Test results: failed: 1 > ``` > > (I noticed this in a downstream backport and traced it back up here) > > I've put my JTreport here: https://jmtd.net/tmp/jdk11u_8230305_PlainRead_jtreport/JTreport/html/index.html > > Edit: @jerboaa [points out](https://github.com/openjdk/jdk11u-dev/pull/881#issuecomment-1065226806) that this is probably JDK-8278951, although backporting that does not fix the test for me locally. I'll keep exploring. > > Edit 2: fails for me on jdk17u-dev master, passes on jdk master. Note that the `PlainRead.java` test depends on proper [setup of the `cpu` controller](https://www.scrivano.org/2019/02/26/resources-management-with-rootless-containers/) on your cgroups v2 system (unlike cgroups v1). It passes for me on my configured cgroups v2 system: # /home/sgehwolf/jdk11u-dev/../jdk11u-jdk/bin/java -cp /home/sgehwolf/jdk11u-dev/JTwork/classes/containers/cgroup/PlainRead.d:/home/sgehwolf/jdk11u-dev/test/hotspot/jtreg/containers/cgroup:/home/sgehwolf/jdk11u-dev/JTwork/classes/testlibrary:/home/sgehwolf/jdk11u-dev/test/hotspot/jtreg/testlibrary:/home/sgehwolf/jdk11u-dev/JTwork/classes/test/lib:/home/sgehwolf/jdk11u-dev/test/lib:/home/sgehwolf/jtreg-5/lib/javatest.jar:/home/sgehwolf/jtreg-5/lib/jtreg.jar -Xlog:os+container=trace -version [0.001s][trace][os,container] OSContainer::init: Initializing Container Support [0.001s][debug][os,container] Detected cgroups v2 unified hierarchy [0.001s][trace][os,container] Path to /memory.max is /sys/fs/cgroup/user.slice/user-1000.slice/session-2.scope/memory.max [0.001s][trace][os,container] Raw value for memory limit is: max [0.001s][trace][os,container] Memory Limit is: Unlimited [0.002s][trace][os,container] Path to /cpu.max is /sys/fs/cgroup/user.slice/user-1000.slice/session-2.scope/cpu.max [0.002s][trace][os,container] Raw value for CPU quota is: max [0.002s][trace][os,container] CPU Quota is: -1 [0.002s][trace][os,container] Path to /cpu.max is /sys/fs/cgroup/user.slice/user-1000.slice/session-2.scope/cpu.max [0.002s][trace][os,container] CPU Period is: 100000 [0.002s][trace][os,container] Path to /cpu.weight is /sys/fs/cgroup/user.slice/user-1000.slice/session-2.scope/cpu.weight [0.002s][trace][os,container] Raw value for CPU shares is: 100 [0.002s][debug][os,container] CPU Shares is: -1 [0.002s][trace][os,container] OSContainer::active_processor_count: 4 [0.002s][trace][os,container] CgroupSubsystem::active_processor_count (cached): 4 [0.002s][debug][os,container] container memory limit unlimited: -1, using host value [0.002s][debug][os,container] container memory limit unlimited: -1, using host value [0.003s][trace][os,container] CgroupSubsystem::active_processor_count (cached): 4 [0.072s][trace][os,container] Path to /cpu.max is /sys/fs/cgroup/user.slice/user-1000.slice/session-2.scope/cpu.max [0.072s][trace][os,container] Raw value for CPU quota is: max [0.072s][trace][os,container] CPU Quota is: -1 [0.072s][trace][os,container] Path to /cpu.max is /sys/fs/cgroup/user.slice/user-1000.slice/session-2.scope/cpu.max [0.072s][trace][os,container] CPU Period is: 100000 [0.072s][trace][os,container] Path to /cpu.weight is /sys/fs/cgroup/user.slice/user-1000.slice/session-2.scope/cpu.weight [0.072s][trace][os,container] Raw value for CPU shares is: 100 [0.072s][debug][os,container] CPU Shares is: -1 [0.072s][trace][os,container] OSContainer::active_processor_count: 4 [0.095s][trace][os,container] Path to /memory.max is /sys/fs/cgroup/user.slice/user-1000.slice/session-2.scope/memory.max [0.095s][trace][os,container] Raw value for memory limit is: max [0.095s][trace][os,container] Memory Limit is: Unlimited [0.095s][debug][os,container] container memory limit unlimited: -1, using host value [0.095s][debug][os,container] container memory limit unlimited: -1, using host value [0.096s][debug][os,container] container memory limit unlimited: -1, using host value [0.096s][debug][os,container] container memory limit unlimited: -1, using host value [0.097s][debug][os,container] container memory limit unlimited: -1, using host value [0.097s][debug][os,container] container memory limit unlimited: -1, using host value [0.098s][debug][os,container] container memory limit unlimited: -1, using host value [0.098s][debug][os,container] container memory limit unlimited: -1, using host value [0.100s][debug][os,container] container memory limit unlimited: -1, using host value [0.100s][debug][os,container] container memory limit unlimited: -1, using host value [0.101s][debug][os,container] container memory limit unlimited: -1, using host value [0.103s][debug][os,container] container memory limit unlimited: -1, using host value [0.104s][debug][os,container] container memory limit unlimited: -1, using host value [0.104s][debug][os,container] container memory limit unlimited: -1, using host value [0.104s][debug][os,container] container memory limit unlimited: -1, using host value [0.105s][debug][os,container] container memory limit unlimited: -1, using host value [0.105s][debug][os,container] container memory limit unlimited: -1, using host value [0.106s][debug][os,container] container memory limit unlimited: -1, using host value [0.107s][debug][os,container] container memory limit unlimited: -1, using host value [0.108s][debug][os,container] container memory limit unlimited: -1, using host value [0.108s][debug][os,container] container memory limit unlimited: -1, using host value [0.108s][debug][os,container] container memory limit unlimited: -1, using host value [0.109s][debug][os,container] container memory limit unlimited: -1, using host value [0.114s][debug][os,container] container memory limit unlimited: -1, using host value [0.115s][debug][os,container] container memory limit unlimited: -1, using host value [0.118s][trace][os,container] Path to /memory.max is /sys/fs/cgroup/user.slice/user-1000.slice/session-2.scope/memory.max [0.118s][trace][os,container] Raw value for memory limit is: max [0.118s][trace][os,container] Memory Limit is: Unlimited [0.118s][debug][os,container] container memory limit unlimited: -1, using host value [0.120s][debug][os,container] container memory limit unlimited: -1, using host value [0.121s][debug][os,container] container memory limit unlimited: -1, using host value [0.121s][debug][os,container] container memory limit unlimited: -1, using host value [0.122s][debug][os,container] container memory limit unlimited: -1, using host value [0.123s][debug][os,container] container memory limit unlimited: -1, using host value [0.123s][debug][os,container] container memory limit unlimited: -1, using host value [0.124s][debug][os,container] container memory limit unlimited: -1, using host value [0.125s][debug][os,container] container memory limit unlimited: -1, using host value [0.131s][debug][os,container] container memory limit unlimited: -1, using host value [0.132s][debug][os,container] container memory limit unlimited: -1, using host value [0.135s][debug][os,container] container memory limit unlimited: -1, using host value [0.137s][debug][os,container] container memory limit unlimited: -1, using host value [0.137s][debug][os,container] container memory limit unlimited: -1, using host value [0.138s][trace][os,container] Path to /memory.max is /sys/fs/cgroup/user.slice/user-1000.slice/session-2.scope/memory.max [0.138s][trace][os,container] Raw value for memory limit is: max [0.138s][trace][os,container] Memory Limit is: Unlimited [0.138s][debug][os,container] container memory limit unlimited: -1, using host value [0.138s][debug][os,container] container memory limit unlimited: -1, using host value openjdk version "11.0.15-internal" 2022-04-19 OpenJDK Runtime Environment (fastdebug build 11.0.15-internal+0-adhoc.sgehwolf.jdk11u-dev) OpenJDK 64-Bit Server VM (fastdebug build 11.0.15-internal+0-adhoc.sgehwolf.jdk11u-dev, mixed mode) [0.142s][debug][os,container] container memory limit unlimited: -1, using host value [0.142s][debug][os,container] container memory limit unlimited: -1, using host value This shouldn't block this backport. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/840 From rkennke at openjdk.java.net Mon Mar 14 17:09:28 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 14 Mar 2022 17:09:28 GMT Subject: [jdk11u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache [v3] In-Reply-To: <8a9lCHHdvjKYN7QzfnB1yrLWUarFljBfnDGy3xrcYU8=.89c903ad-446e-4c67-82fe-9fc40f5027b5@github.com> References: <8a9lCHHdvjKYN7QzfnB1yrLWUarFljBfnDGy3xrcYU8=.89c903ad-446e-4c67-82fe-9fc40f5027b5@github.com> Message-ID: > This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [ ] tier2 > - [ ] tier3 Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: Adjust test for missing Reference.refersTo() API ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/887/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/887/files/07ca7b9d..fdd0c9af Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=887&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=887&range=01-02 Stats: 7 lines in 1 file changed: 2 ins; 2 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/887.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/887/head:pull/887 PR: https://git.openjdk.java.net/jdk11u-dev/pull/887 From aleonard at openjdk.java.net Mon Mar 14 17:10:11 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Mon, 14 Mar 2022 17:10:11 GMT Subject: [jdk17u-dev] RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v2] In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 16:24:01 GMT, Severin Gehwolf wrote: > Ahh, ok then. Sorry for the noise. No worries, thanks for taking a look ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/246 From zgu at openjdk.java.net Mon Mar 14 18:11:13 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 14 Mar 2022 18:11:13 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v6] In-Reply-To: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: > This is a followup backport for Cgroup v2 support. > > The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. > > In additional: > > 1) Include partial backport of JDK-8250627. > - Renamed `Metrics.c` => `CgroupMetrics.c` > - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` > - Return instance only if `isUseContainerSupport()` is enabled. > > 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test > > 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` > > Test: > > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: Fixes ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/863/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/863/files/bd9ec039..191fbe46 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=05 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=04-05 Stats: 38 lines in 5 files changed: 24 ins; 14 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/863/head:pull/863 PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From zgu at openjdk.java.net Mon Mar 14 23:06:50 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 14 Mar 2022 23:06:50 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v6] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Mon, 14 Mar 2022 18:11:13 GMT, Zhengyu Gu wrote: >> This is a followup backport for Cgroup v2 support. >> >> The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. >> >> In additional: >> >> 1) Include partial backport of JDK-8250627. >> - Renamed `Metrics.c` => `CgroupMetrics.c` >> - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` >> - Return instance only if `isUseContainerSupport()` is enabled. >> >> 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test >> >> 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` >> >> Test: >> >> - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS > > Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: > > Fixes > getMemoryAndSwapMaxUsage Ready for another round, thanks. -Zhengyu ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From rreddy at openjdk.java.net Tue Mar 15 04:35:19 2022 From: rreddy at openjdk.java.net (Ravi Reddy) Date: Tue, 15 Mar 2022 04:35:19 GMT Subject: [jdk18u] RFR: 8282583: Update BCEL md to include the copyright notice Message-ID: Clean backport of https://github.com/openjdk/jdk/commit/8478173d837113bf603aadb614badd461f474250 to jdk18u ------------- Commit messages: - 8282583: Update BCEL md to include the copyright notice Changes: https://git.openjdk.java.net/jdk18u/pull/47/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=47&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282583 Stats: 8 lines in 1 file changed: 0 ins; 3 del; 5 mod Patch: https://git.openjdk.java.net/jdk18u/pull/47.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/47/head:pull/47 PR: https://git.openjdk.java.net/jdk18u/pull/47 From stuefe at openjdk.java.net Tue Mar 15 06:16:46 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 15 Mar 2022 06:16:46 GMT Subject: [jdk11u-dev] RFR: 8229499: Node budget assert in fuzzed test In-Reply-To: <44hrok75QUxbQHzEGnie878guHkxy0igqDb11Nm80es=.9b10312a-ab56-410d-a8bd-e9763605d37d@github.com> References: <44hrok75QUxbQHzEGnie878guHkxy0igqDb11Nm80es=.9b10312a-ab56-410d-a8bd-e9763605d37d@github.com> Message-ID: On Mon, 14 Mar 2022 11:38:25 GMT, Martin Doerr wrote: > Almost clean backport of [JDK-8229499](https://bugs.openjdk.java.net/browse/JDK-8229499) > Only the minor cleanup in loopnode.hpp required manual integration. Looks good from my non-JIT eyes. loopnode.hpp looks fine (was hard to spot the one relevant chance in the many cleanups). Cheers, Thomas ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/888 From stuefe at openjdk.java.net Tue Mar 15 06:24:50 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 15 Mar 2022 06:24:50 GMT Subject: [jdk11u-dev] RFR: 8265343: Update Debian-based cross-compilation recipes [v2] In-Reply-To: References: <7CC6WPGbUdVXErgaSHvhY98bp9JygorbdilS6rdqzHw=.45fe9557-9b56-4a68-b3d3-bd8d5f0b6202@github.com> Message-ID: On Wed, 5 Jan 2022 10:02:59 GMT, Aleksey Shipilev wrote: >> Another (hopefully final) backport to improve cross-compilation docs. The simplified cross-compilation recipe matches what we have in 11u GHA: only `--openjdk-target` and `--with-sysroot` is supplied. >> >> It had minor contextual conflicts that precluded the automatic merge. I checked that the platforms listed in compatible platforms list is indeed buildable (see https://builds.shipilev.net/openjdk-jdk11-dev/ for example). > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8265343-update-debian > - Backport 7879adbe88ec54b8f5ac9543d80142bc1b12112b LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/601 From stuefe at openjdk.java.net Tue Mar 15 06:52:45 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 15 Mar 2022 06:52:45 GMT Subject: [jdk11u-dev] RFR: 8261090: Store old classfiles in static CDS archive [v2] In-Reply-To: References: <4tqUkn-OsqxCUK_XarWC0UNUloQjtNMN8i1Keyuxjgo=.6e70c9ff-9c4b-4396-9303-6a8d9cf062e5@github.com> Message-ID: <2i8Flj3v6PikhlGXCHcBCIO9oOy3UuAZ_P6TODR82u8=.9a68455a-55cb-4301-b71a-3e4c474bdfb2@github.com> On Fri, 11 Mar 2022 03:24:54 GMT, wxiang wrote: >> wxiang has updated the pull request incrementally with one additional commit since the last revision: >> >> revert the changes with 8266822 and 8267431 > > Thanks a lot for the suggestion. > As described in JDK-8230413, there are still large number of existing classes with older class version (< 50) in real world applications. Those classes are missing the benefit of CDS. For better use of AppCDS, we requested the backport. > We have run all the test cases under hotspot/jtreg/runtime/appcds includes these new cases in this patch, > and run some demos which has old classifies, such as spring-petclinic. > We have submitted a new patch to revert the change for for JDK-8266822 and JDK-8267431 Hi @shiyuexw, Decision is not up to me, so just my personal opinion. But I have strong reservations about downporting this patch: - it is large and complex. It's a lot of Reviewer work taken away from other issues. - its effects are difficult to estimate. Even if this patch was working flawlessly, we'd now run with a much larger number of old classes getting stored in application archives, which means CDS and the VM runtime exercised in a lot new ways. This may destabilize 11u by shaking bugs lose we have not encountered yet or may have not been down ported yet. - It's also difficult to test. Because the real behavior difference will show up only in applications using large amounts of very old class files We have run all the test cases under hotspot/jtreg/runtime/appcds includes these new cases in this patch, and run some demos which has old classifies, such as spring-petclinic. Sorry, I don't think this is enough by a long stretch. I'd need tier1-n tests across the board, across the whole range of supported platforms and architectures. We'd also like to see large scale tests with systems that use large amounts of pre-JDK6 classes. Bottomline, in my eye there is not a large enough benefit to justify the cost and risk involved. I think the workarounds we have are acceptable: users can just run JDK17 or should update their class libraries or just have to live without them in AppCDS. Sorry, I know you put a lot of work in. When in doubt, before attempting a large backport, it is better to discuss it on the OpenJDK mailing lists to see what folks think. Cheers, Thomas ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/856 From goetz at openjdk.java.net Tue Mar 15 09:16:57 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 15 Mar 2022 09:16:57 GMT Subject: [jdk17u-dev] Integrated: 8272168: some hotspot runtime/logging tests don't check exit code In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 12:22:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 88216d84 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/88216d84a7f8b2045b8b7a87cb92158f61688025 Stats: 16 lines in 5 files changed: 12 ins; 0 del; 4 mod 8272168: some hotspot runtime/logging tests don't check exit code Backport-of: 3b899ef7ffd87477ac1b10f4334b127597e9fe32 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/247 From goetz at openjdk.java.net Tue Mar 15 09:19:55 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 15 Mar 2022 09:19:55 GMT Subject: [jdk17u-dev] Integrated: 8274172: Convert JavadocTester to use NIO In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 12:26:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 24ce3f49 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/24ce3f49c8954ceb846ba85bf45272ce4b86a89c Stats: 207 lines in 8 files changed: 67 ins; 55 del; 85 mod 8274172: Convert JavadocTester to use NIO Backport-of: 5b0c9ccc495b6bf8061c161d48f73238c7167bc0 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/248 From goetz at openjdk.java.net Tue Mar 15 09:23:02 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 15 Mar 2022 09:23:02 GMT Subject: [jdk17u-dev] Integrated: 8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 12:38:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: cd5684ac Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/cd5684ac9396d060f72df036802fe73b92a34e12 Stats: 10 lines in 1 file changed: 8 ins; 0 del; 2 mod 8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output Backport-of: 21e302a0f4cbf3ace907c36d871a2f2cf6277188 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/250 From goetz at openjdk.java.net Tue Mar 15 09:28:48 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 15 Mar 2022 09:28:48 GMT Subject: [jdk17u-dev] RFR: 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 15:46:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Pre-submit tests: test archive was corrupted? ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/254 From goetz at openjdk.java.net Tue Mar 15 09:41:27 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 15 Mar 2022 09:41:27 GMT Subject: [jdk17u-dev] RFR: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 7e54d065a17f1277adf1b8561fadb8a480bc6bed Changes: https://git.openjdk.java.net/jdk17u-dev/pull/256/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=256&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277165 Stats: 301 lines in 11 files changed: 288 ins; 6 del; 7 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/256.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/256/head:pull/256 PR: https://git.openjdk.java.net/jdk17u-dev/pull/256 From mdoerr at openjdk.java.net Tue Mar 15 09:56:39 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 15 Mar 2022 09:56:39 GMT Subject: [jdk11u-dev] Integrated: 8234605: C2 failed "assert(C->live_nodes() - live_at_begin <= 2 * _nodes_required) failed: Bad node estimate: actual = 208 >> request = 101" In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 12:02:43 GMT, Martin Doerr wrote: > Clean Backport of JDK-8234605. This pull request has now been integrated. Changeset: 6c84ce90 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/6c84ce9038aceca0374345e3a851278e955f5969 Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod 8234605: C2 failed "assert(C->live_nodes() - live_at_begin <= 2 * _nodes_required) failed: Bad node estimate: actual = 208 >> request = 101" Backport-of: d19f2bdec01eb324d200f2144293d05ea310f9b8 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/889 From mdoerr at openjdk.java.net Tue Mar 15 10:03:45 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 15 Mar 2022 10:03:45 GMT Subject: [jdk11u-dev] RFR: 8229499: Node budget assert in fuzzed test In-Reply-To: <44hrok75QUxbQHzEGnie878guHkxy0igqDb11Nm80es=.9b10312a-ab56-410d-a8bd-e9763605d37d@github.com> References: <44hrok75QUxbQHzEGnie878guHkxy0igqDb11Nm80es=.9b10312a-ab56-410d-a8bd-e9763605d37d@github.com> Message-ID: On Mon, 14 Mar 2022 11:38:25 GMT, Martin Doerr wrote: > Almost clean backport of [JDK-8229499](https://bugs.openjdk.java.net/browse/JDK-8229499) > Only the minor cleanup in loopnode.hpp required manual integration. Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/888 From goetz at openjdk.java.net Tue Mar 15 10:03:45 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 15 Mar 2022 10:03:45 GMT Subject: [jdk11u-dev] RFR: 8229499: Node budget assert in fuzzed test In-Reply-To: <44hrok75QUxbQHzEGnie878guHkxy0igqDb11Nm80es=.9b10312a-ab56-410d-a8bd-e9763605d37d@github.com> References: <44hrok75QUxbQHzEGnie878guHkxy0igqDb11Nm80es=.9b10312a-ab56-410d-a8bd-e9763605d37d@github.com> Message-ID: <58MDfYHjc7Dd43S8hX25-9O0oqPlyuj6jemRHU79kr8=.9eb98d01-a2de-43ac-b97f-78077ae00aec@github.com> On Mon, 14 Mar 2022 11:38:25 GMT, Martin Doerr wrote: > Almost clean backport of [JDK-8229499](https://bugs.openjdk.java.net/browse/JDK-8229499) > Only the minor cleanup in loopnode.hpp required manual integration. Pre-submit tests gc/cms/TestBubbleUpRef.java timed out I saw problem with this test in other Pre-submit runs, so this should be unrelated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/888 From mdoerr at openjdk.java.net Tue Mar 15 10:21:47 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 15 Mar 2022 10:21:47 GMT Subject: [jdk11u-dev] Integrated: 8229499: Node budget assert in fuzzed test In-Reply-To: <44hrok75QUxbQHzEGnie878guHkxy0igqDb11Nm80es=.9b10312a-ab56-410d-a8bd-e9763605d37d@github.com> References: <44hrok75QUxbQHzEGnie878guHkxy0igqDb11Nm80es=.9b10312a-ab56-410d-a8bd-e9763605d37d@github.com> Message-ID: On Mon, 14 Mar 2022 11:38:25 GMT, Martin Doerr wrote: > Almost clean backport of [JDK-8229499](https://bugs.openjdk.java.net/browse/JDK-8229499) > Only the minor cleanup in loopnode.hpp required manual integration. This pull request has now been integrated. Changeset: 18b5f5be Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/18b5f5be052f3c0d77eb97719f96399e547838ac Stats: 202 lines in 4 files changed: 118 ins; 33 del; 51 mod 8229499: Node budget assert in fuzzed test Reviewed-by: stuefe Backport-of: 8275b17b07b1c15bde79b36b76ecbe3072db1e1a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/888 From mdoerr at openjdk.java.net Tue Mar 15 10:27:26 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 15 Mar 2022 10:27:26 GMT Subject: [jdk11u-dev] RFR: 8231565: More node budget asserts in fuzzed tests [v2] In-Reply-To: References: Message-ID: > Almost clean backport of https://bugs.openjdk.java.net/browse/JDK-8231565 > Only cleanup in `PhaseIdealLoop::partial_peel` (loopopts.cpp) required manual integration. Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/890/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/890/files/5d690660..5d690660 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=890&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=890&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/890.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/890/head:pull/890 PR: https://git.openjdk.java.net/jdk11u-dev/pull/890 From duke at openjdk.java.net Tue Mar 15 10:27:27 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Tue, 15 Mar 2022 10:27:27 GMT Subject: [jdk11u-dev] RFR: 8231565: More node budget asserts in fuzzed tests In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 13:27:10 GMT, Martin Doerr wrote: > Almost clean backport of https://bugs.openjdk.java.net/browse/JDK-8231565 > Only cleanup in `PhaseIdealLoop::partial_peel` (loopopts.cpp) required manual integration. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8229499_C2_node_budget git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/890 From shade at openjdk.java.net Tue Mar 15 10:45:07 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 15 Mar 2022 10:45:07 GMT Subject: [jdk17u-dev] RFR: 8283017: GHA: Workflows break with update release versions In-Reply-To: References: Message-ID: <2l6e8wsRHdHEhMOF_p07fi-fiuqdnHUnCoB0SdBgPl0=.56028ef2-2118-4fd0-b419-1b40d302fca6@github.com> On Mon, 14 Mar 2022 09:10:33 GMT, Aleksey Shipilev wrote: > Unclean backport to enable GHA workflows for update releases. This drops the 17u-specific hack (https://bugs.openjdk.java.net/browse/JDK-8276130) from GHA, and uses the handling code from mainline. > > Additional testing: > - [x] GHA checks still pass (in progress) Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/243 From shade at openjdk.java.net Tue Mar 15 10:45:08 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 15 Mar 2022 10:45:08 GMT Subject: [jdk17u-dev] Integrated: 8283017: GHA: Workflows break with update release versions In-Reply-To: References: Message-ID: <6HJLKKv0E8nue-gF6uKAt74utgnEbtWWNrjhEU-2Ao8=.44daa0f1-1eeb-4590-aeb8-5e01b12a213c@github.com> On Mon, 14 Mar 2022 09:10:33 GMT, Aleksey Shipilev wrote: > Unclean backport to enable GHA workflows for update releases. This drops the 17u-specific hack (https://bugs.openjdk.java.net/browse/JDK-8276130) from GHA, and uses the handling code from mainline. > > Additional testing: > - [x] GHA checks still pass (in progress) This pull request has now been integrated. Changeset: 35215049 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u-dev/commit/35215049b40c1d4902cdf0cf65840371174a6178 Stats: 29 lines in 1 file changed: 18 ins; 0 del; 11 mod 8283017: GHA: Workflows break with update release versions Reviewed-by: clanger Backport-of: 01570ca92d234481df2d540027e320b91af415a0 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/243 From shade at openjdk.java.net Tue Mar 15 10:46:56 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 15 Mar 2022 10:46:56 GMT Subject: [jdk11u-dev] RFR: 8265343: Update Debian-based cross-compilation recipes [v2] In-Reply-To: References: <7CC6WPGbUdVXErgaSHvhY98bp9JygorbdilS6rdqzHw=.45fe9557-9b56-4a68-b3d3-bd8d5f0b6202@github.com> Message-ID: <8ggQZ0Q0ih3QZhe6cXH_0Ll9Egm5xlx-eB0ZdADVghQ=.bdde8608-a211-405c-a45b-60a788c03f00@github.com> On Tue, 15 Mar 2022 06:21:55 GMT, Thomas Stuefe wrote: > LGTM Thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/601 From mdoerr at openjdk.java.net Tue Mar 15 10:50:44 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 15 Mar 2022 10:50:44 GMT Subject: [jdk11u-dev] RFR: 8231565: More node budget asserts in fuzzed tests [v2] In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 10:27:26 GMT, Martin Doerr wrote: >> Almost clean backport of https://bugs.openjdk.java.net/browse/JDK-8231565 >> Only cleanup in `PhaseIdealLoop::partial_peel` (loopopts.cpp) required manual integration. > > Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Looks messed up. I'll recreate it. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/890 From mdoerr at openjdk.java.net Tue Mar 15 10:50:45 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 15 Mar 2022 10:50:45 GMT Subject: [jdk11u-dev] Withdrawn: 8231565: More node budget asserts in fuzzed tests In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 13:27:10 GMT, Martin Doerr wrote: > Almost clean backport of https://bugs.openjdk.java.net/browse/JDK-8231565 > Only cleanup in `PhaseIdealLoop::partial_peel` (loopopts.cpp) required manual integration. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/890 From shade at openjdk.java.net Tue Mar 15 10:55:31 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 15 Mar 2022 10:55:31 GMT Subject: [jdk11u-dev] RFR: 8265343: Update Debian-based cross-compilation recipes [v3] In-Reply-To: <7CC6WPGbUdVXErgaSHvhY98bp9JygorbdilS6rdqzHw=.45fe9557-9b56-4a68-b3d3-bd8d5f0b6202@github.com> References: <7CC6WPGbUdVXErgaSHvhY98bp9JygorbdilS6rdqzHw=.45fe9557-9b56-4a68-b3d3-bd8d5f0b6202@github.com> Message-ID: > Another (hopefully final) backport to improve cross-compilation docs. The simplified cross-compilation recipe matches what we have in 11u GHA: only `--openjdk-target` and `--with-sysroot` is supplied. > > It had minor contextual conflicts that precluded the automatic merge. I checked that the platforms listed in compatible platforms list is indeed buildable (see https://builds.shipilev.net/openjdk-jdk11-dev/ for example). Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport 7879adbe88ec54b8f5ac9543d80142bc1b12112b ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/601/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/601/files/e4c8a9ea..6ef1339e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=601&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=601&range=01-02 Stats: 25131 lines in 981 files changed: 16784 ins; 5224 del; 3123 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/601.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/601/head:pull/601 PR: https://git.openjdk.java.net/jdk11u-dev/pull/601 From aleonard at openjdk.java.net Tue Mar 15 10:57:53 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 15 Mar 2022 10:57:53 GMT Subject: [jdk17u-dev] RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v2] In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 14:44:25 GMT, Andrew Leonard wrote: >> This PR is to enable usage of the --date option for OpenJDK build to enable reproducible build jars & jmods. > > Andrew Leonard has updated the pull request incrementally with two additional commits since the last revision: > > - retrigger checks > > Signed-off-by: Andrew Leonard > - retrigger checks > > Signed-off-by: root Testing all good with various reproducible options --with-source-date, and with boot jdks with --date support and ones that don't. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/246 From mdoerr at openjdk.java.net Tue Mar 15 11:04:17 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 15 Mar 2022 11:04:17 GMT Subject: [jdk11u-dev] Integrated: 8231565: More node budget asserts in fuzzed tests Message-ID: Basically clean backport of https://bugs.openjdk.java.net/browse/JDK-8231565 Only cleanup in PhaseIdealLoop::partial_peel (loopopts.cpp) required manual integration, but looks identical. ------------- Commit messages: - Backport 902858e3ceb43bf92ea9fa038b9edcf1ee0c48b5 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/893/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=893&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8231565 Stats: 105 lines in 3 files changed: 86 ins; 5 del; 14 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/893.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/893/head:pull/893 PR: https://git.openjdk.java.net/jdk11u-dev/pull/893 From mdoerr at openjdk.java.net Tue Mar 15 11:04:19 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 15 Mar 2022 11:04:19 GMT Subject: [jdk11u-dev] Integrated: 8231565: More node budget asserts in fuzzed tests In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 10:54:54 GMT, Martin Doerr wrote: > Basically clean backport of https://bugs.openjdk.java.net/browse/JDK-8231565 > Only cleanup in PhaseIdealLoop::partial_peel (loopopts.cpp) required manual integration, but looks identical. This pull request has now been integrated. Changeset: f8abb70e Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/f8abb70e278bdcf3b394a8a8a968ab91e744cd45 Stats: 105 lines in 3 files changed: 86 ins; 5 del; 14 mod 8231565: More node budget asserts in fuzzed tests Backport-of: 902858e3ceb43bf92ea9fa038b9edcf1ee0c48b5 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/893 From mdoerr at openjdk.java.net Tue Mar 15 11:06:47 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 15 Mar 2022 11:06:47 GMT Subject: [jdk11u-dev] Integrated: 8266251: compiler.inlining.InlineAccessors shouldn't do testing in driver VM In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 14:51:48 GMT, Martin Doerr wrote: > Clean backport of [JDK-8266251](https://bugs.openjdk.java.net/browse/JDK-8266251) This pull request has now been integrated. Changeset: 1b8ef742 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/1b8ef742cab98086d8246f3753751d10eb2ca658 Stats: 6 lines in 1 file changed: 0 ins; 4 del; 2 mod 8266251: compiler.inlining.InlineAccessors shouldn't do testing in driver VM Backport-of: 9605aeddee70ba4f3dba2ae2a3d100319164b03d ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/892 From mdoerr at openjdk.java.net Tue Mar 15 11:08:04 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 15 Mar 2022 11:08:04 GMT Subject: [jdk17u-dev] Integrated: 8273139: C2: assert(f <= 1 && f >= 0) failed: Incorrect frequency In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 15:05:38 GMT, Martin Doerr wrote: > Clean backport of [JDK-8273139](https://bugs.openjdk.java.net/browse/JDK-8273139) This pull request has now been integrated. Changeset: 7b65a39f Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/7b65a39f22995a35e0b1aa78e811bb8850280e10 Stats: 19 lines in 1 file changed: 2 ins; 5 del; 12 mod 8273139: C2: assert(f <= 1 && f >= 0) failed: Incorrect frequency Backport-of: 68b40ec28658a2dd829c77281b0025e16095c170 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/252 From chegar at openjdk.java.net Tue Mar 15 13:57:26 2022 From: chegar at openjdk.java.net (Chris Hegarty) Date: Tue, 15 Mar 2022 13:57:26 GMT Subject: [jdk17u] RFR: 8282444: Module finder incorrectly assumes default file system path-separator character Message-ID: <93-LtO_OejuHhHl7wGdHt8cIzWJBPZ7Lvxi-FNGj9yA=.d3d5daa4-ff40-415f-ba41-a17d87920185@github.com> Backport of JDK-8282444 ------------- Commit messages: - 8282444: Module finder incorrectly assumes default file system path-separator character Changes: https://git.openjdk.java.net/jdk17u/pull/335/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=335&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282444 Stats: 10 lines in 5 files changed: 2 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u/pull/335.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/335/head:pull/335 PR: https://git.openjdk.java.net/jdk17u/pull/335 From chegar at openjdk.java.net Tue Mar 15 14:35:00 2022 From: chegar at openjdk.java.net (Chris Hegarty) Date: Tue, 15 Mar 2022 14:35:00 GMT Subject: [jdk17u] RFR: 8282444: Module finder incorrectly assumes default file system path-separator character [v2] In-Reply-To: <93-LtO_OejuHhHl7wGdHt8cIzWJBPZ7Lvxi-FNGj9yA=.d3d5daa4-ff40-415f-ba41-a17d87920185@github.com> References: <93-LtO_OejuHhHl7wGdHt8cIzWJBPZ7Lvxi-FNGj9yA=.d3d5daa4-ff40-415f-ba41-a17d87920185@github.com> Message-ID: > Backport of JDK-8282444 Chris Hegarty has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 369291b265e13d625c5f465da9b1854c0d70c435 ------------- Changes: - all: https://git.openjdk.java.net/jdk17u/pull/335/files - new: https://git.openjdk.java.net/jdk17u/pull/335/files/88051c25..3d7a303c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=335&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=335&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u/pull/335.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/335/head:pull/335 PR: https://git.openjdk.java.net/jdk17u/pull/335 From chegar at openjdk.java.net Tue Mar 15 14:38:27 2022 From: chegar at openjdk.java.net (Chris Hegarty) Date: Tue, 15 Mar 2022 14:38:27 GMT Subject: [jdk18u] RFR: 8282444: Module finder incorrectly assumes default file system path-separator character Message-ID: 8282444: Module finder incorrectly assumes default file system path-separator character ------------- Commit messages: - Backport 369291b265e13d625c5f465da9b1854c0d70c435 Changes: https://git.openjdk.java.net/jdk18u/pull/48/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=48&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282444 Stats: 10 lines in 5 files changed: 2 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk18u/pull/48.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/48/head:pull/48 PR: https://git.openjdk.java.net/jdk18u/pull/48 From aleonard at openjdk.java.net Tue Mar 15 14:47:54 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 15 Mar 2022 14:47:54 GMT Subject: [jdk17u-dev] Integrated: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 12:11:12 GMT, Andrew Leonard wrote: > This PR is to enable usage of the --date option for OpenJDK build to enable reproducible build jars & jmods. This pull request has now been integrated. Changeset: 943c2b31 Author: Andrew Leonard Committer: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/943c2b31ad4d44f8019f96177051b34a3f9f6b0e Stats: 65 lines in 7 files changed: 45 ins; 6 del; 14 mod 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date Backport-of: 214f98f6b07e312e6f4ded5364a94277114784e7 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/246 From chegar at openjdk.java.net Tue Mar 15 14:57:55 2022 From: chegar at openjdk.java.net (Chris Hegarty) Date: Tue, 15 Mar 2022 14:57:55 GMT Subject: [jdk17u] Withdrawn: 8282444: Module finder incorrectly assumes default file system path-separator character In-Reply-To: <93-LtO_OejuHhHl7wGdHt8cIzWJBPZ7Lvxi-FNGj9yA=.d3d5daa4-ff40-415f-ba41-a17d87920185@github.com> References: <93-LtO_OejuHhHl7wGdHt8cIzWJBPZ7Lvxi-FNGj9yA=.d3d5daa4-ff40-415f-ba41-a17d87920185@github.com> Message-ID: On Tue, 15 Mar 2022 13:39:27 GMT, Chris Hegarty wrote: > Backport of JDK-8282444 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/335 From aleonard at openjdk.java.net Tue Mar 15 15:04:57 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 15 Mar 2022 15:04:57 GMT Subject: [jdk17u-dev] RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v2] In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 14:44:25 GMT, Andrew Leonard wrote: >> This PR is to enable usage of the --date option for OpenJDK build to enable reproducible build jars & jmods. > > Andrew Leonard has updated the pull request incrementally with two additional commits since the last revision: > > - retrigger checks > > Signed-off-by: Andrew Leonard > - retrigger checks > > Signed-off-by: root thank you Martin @TheRealMDoerr ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/246 From chegar at openjdk.java.net Tue Mar 15 15:05:39 2022 From: chegar at openjdk.java.net (Chris Hegarty) Date: Tue, 15 Mar 2022 15:05:39 GMT Subject: [jdk17u] RFR: 8282444: Module finder incorrectly assumes default file system path-separator character Message-ID: 8282444: Module finder incorrectly assumes default file system path-separator character ------------- Commit messages: - Backport 369291b265e13d625c5f465da9b1854c0d70c435 Changes: https://git.openjdk.java.net/jdk17u/pull/336/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=336&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282444 Stats: 10 lines in 5 files changed: 2 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u/pull/336.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/336/head:pull/336 PR: https://git.openjdk.java.net/jdk17u/pull/336 From sgehwolf at openjdk.java.net Tue Mar 15 15:07:46 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 15 Mar 2022 15:07:46 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v6] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: <1alEOafTbHZbDELaJSRaBw-KXyyu4f7kl3XCitfkjBA=.46f6dac4-8a5a-41e7-ac11-32f307809230@github.com> On Mon, 14 Mar 2022 18:11:13 GMT, Zhengyu Gu wrote: >> This is a followup backport for Cgroup v2 support. >> >> The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. >> >> In additional: >> >> 1) Include partial backport of JDK-8250627. >> - Renamed `Metrics.c` => `CgroupMetrics.c` >> - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` >> - Return instance only if `isUseContainerSupport()` is enabled. >> >> 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test >> >> 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` >> >> Test: >> >> - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS > > Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: > > Fixes A few more fix-ups are needed (see also inline comments): 1. [JDK-8272124](https://bugs.openjdk.java.net/browse/JDK-8272124) fix and test. 2. [JDK-8223396](https://bugs.openjdk.java.net/browse/JDK-8223396). Backport those test changes as a dependency? 3. `PlainRead.java` would need to get the `-2` added as a "good" value. Like here: https://github.com/openjdk/jdk/commit/01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48 It's part of the original JDK-8250984 fix, but wasn't part of the 11 backport when it was done. So we should add it with this backport. ------------- Changes requested by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From sgehwolf at openjdk.java.net Tue Mar 15 15:07:46 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 15 Mar 2022 15:07:46 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v6] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Thu, 10 Mar 2022 14:13:13 GMT, Severin Gehwolf wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: >> >> Fixes > > src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java line 108: > >> 106: CgroupUtil.readFilePrivileged(Paths.get("/proc/self/cgroup"))) { >> 107: >> 108: lines.map(line -> line.split(":")) > > We are missing the patch of JDK-8272124 here. Old code was: > https://github.com/openjdk/jdk11u-dev/blob/194b66f6a72437345c458e747e24beb46352537a/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java#L119..L122 > > Best to use the JDK 17u commit as a base for this: > See: https://github.com/openjdk/jdk17u/commit/f0028333d83c39b434c26f66a6a92e446e7047cd#diff-7d6f202c58b4205f19a9b6c657f4827e9ef132d7433a7bf906b5b640f9f7841fR197 > > Looking at this again, we should bring in the test changes of JDK-8272124 too (as we are now bringing in those tests with the cgroups v2 backport). It helps to verify this fix is present as well. This is still not fixed --^ We should bring in the test changes from https://github.com/openjdk/jdk/commit/4d6593ce0243457e7431a5990957a8f880e0a3fb as well (with this backport). That will cause the test to fail and we are good to find regressions related to this going forward. > test/lib/jdk/test/lib/Utils.java line 784: > >> 782: Path dir = Paths.get(System.getProperty("user.dir", ".")); >> 783: return Files.createTempDirectory(dir, prefix, attrs); >> 784: } > > This looks like a partial backport of https://bugs.openjdk.java.net/browse/JDK-8223396. It's a test-only change, cleanup. Perhaps worth bringing into jdk11u wholesale as a dep? Failing that, rework usages of `Utils.createTempDirectory()`? Why has this been marked resolved? I still see this hunk in the current patch. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From hseigel at openjdk.java.net Tue Mar 15 16:49:23 2022 From: hseigel at openjdk.java.net (Harold Seigel) Date: Tue, 15 Mar 2022 16:49:23 GMT Subject: [jdk18u] RFR: 8282295: SymbolPropertyEntry::set_method_type fails with assert Message-ID: Backport of the fix for JDK-8282295. Patch applied cleanly and was tested with Mach5 tiers 1-2. Harold ------------- Commit messages: - Backport 3e4dfc63e75db7e8ccbb21a831d8d86fb7c1ac4e Changes: https://git.openjdk.java.net/jdk18u/pull/49/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=49&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282295 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/49.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/49/head:pull/49 PR: https://git.openjdk.java.net/jdk18u/pull/49 From aleonard at openjdk.java.net Tue Mar 15 17:01:23 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Tue, 15 Mar 2022 17:01:23 GMT Subject: [jdk17u-dev] RFR: 8279834: Alpine Linux fails to build when --with-source-date enabled Message-ID: Alpine linux fails to configure if --with-source-date option for reproducible builds is specified. ------------- Commit messages: - Backport 9e0244762c0961b1bb3453d294531997b367e757 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/257/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=257&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279834 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/257.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/257/head:pull/257 PR: https://git.openjdk.java.net/jdk17u-dev/pull/257 From hseigel at openjdk.java.net Tue Mar 15 17:25:09 2022 From: hseigel at openjdk.java.net (Harold Seigel) Date: Tue, 15 Mar 2022 17:25:09 GMT Subject: [jdk18u] Integrated: 8282295: SymbolPropertyEntry::set_method_type fails with assert In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 16:40:11 GMT, Harold Seigel wrote: > Backport of the fix for JDK-8282295. Patch applied cleanly and was tested with Mach5 tiers 1-2. > Harold This pull request has now been integrated. Changeset: 507cbd6d Author: Harold Seigel URL: https://git.openjdk.java.net/jdk18u/commit/507cbd6d322686327dab8e7c99708259cc7c8273 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8282295: SymbolPropertyEntry::set_method_type fails with assert Backport-of: 3e4dfc63e75db7e8ccbb21a831d8d86fb7c1ac4e ------------- PR: https://git.openjdk.java.net/jdk18u/pull/49 From zgu at openjdk.java.net Tue Mar 15 17:43:50 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 15 Mar 2022 17:43:50 GMT Subject: [jdk11u-dev] Integrated: 8281615: Deadlock caused by jdwp agent In-Reply-To: References: Message-ID: <8Nuob4PPhxe_rZCjNAgKJIp9GlZicr8rXiCxWGzY-x4=.af7d5370-1826-4f6c-9c4c-5d68308ec8c7@github.com> On Mon, 28 Feb 2022 15:34:10 GMT, Zhengyu Gu wrote: > I would like to backport this patch to jdk11u, because without the fix, jdwp can potential deadlock whole JVM. > > Test: > - [x] Testbase_nsk_jdi > - [x] Testbase_nsk_jvmti > - [x] Testbase_nsk_jdwp This pull request has now been integrated. Changeset: deb08572 Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/deb085729b9f9ff8481fc886ca9b9b457ec5c28a Stats: 31 lines in 1 file changed: 18 ins; 5 del; 8 mod 8281615: Deadlock caused by jdwp agent Backport-of: e1060bee2adb9f2e07ca09309d0f89132db30f28 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/843 From zgu at openjdk.java.net Tue Mar 15 17:43:57 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 15 Mar 2022 17:43:57 GMT Subject: [jdk18u] Integrated: 8281615: Deadlock caused by jdwp agent In-Reply-To: <-M5N5ZgKf1tKPsW7CP4YetVn3eZeAFkoou2Uy8J9VHI=.d960707f-b117-4099-b0f5-291f3e9a3f03@github.com> References: <-M5N5ZgKf1tKPsW7CP4YetVn3eZeAFkoou2Uy8J9VHI=.d960707f-b117-4099-b0f5-291f3e9a3f03@github.com> Message-ID: <8Du-bOkz5GynfaROtVve5lpWDAqIchifTkBz5DVK9Lk=.bde3747f-ddb7-43d2-b219-a9e2dcf49cbc@github.com> On Mon, 28 Feb 2022 18:08:09 GMT, Zhengyu Gu wrote: > I would like to backport this patch to jdk18u, because without the fix, jdwp can potential deadlock whole JVM. > > Test: > - [x] Testbase_nsk_jdi > - [x] Testbase_nsk_jvmti > - [x] Testbase_nsk_jdwp This pull request has now been integrated. Changeset: defa9e8c Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk18u/commit/defa9e8c83e0262d5735042e087720787f18ccaf Stats: 31 lines in 1 file changed: 18 ins; 5 del; 8 mod 8281615: Deadlock caused by jdwp agent Backport-of: e1060bee2adb9f2e07ca09309d0f89132db30f28 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/31 From zgu at openjdk.java.net Tue Mar 15 17:44:04 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 15 Mar 2022 17:44:04 GMT Subject: [jdk17u-dev] Integrated: 8281615: Deadlock caused by jdwp agent In-Reply-To: <4RxmFSG6tOvTOM7sONXFYX8mRzUV8gRR3T8CU2DhVnY=.dcb8177a-bb86-4f95-8e36-20bcedcd4037@github.com> References: <4RxmFSG6tOvTOM7sONXFYX8mRzUV8gRR3T8CU2DhVnY=.dcb8177a-bb86-4f95-8e36-20bcedcd4037@github.com> Message-ID: On Mon, 28 Feb 2022 15:21:02 GMT, Zhengyu Gu wrote: > I would like to backport this patch to jdk17u, because without the fix, jdwp can potential deadlock whole JVM. > > Test: > - [x] Testbase_nsk_jdi > - [x] Testbase_nsk_jvmti > - [x] Testbase_nsk_jdwp This pull request has now been integrated. Changeset: 4f0d7114 Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk17u-dev/commit/4f0d71148755c1f5544543a6c6725a0c1f44d191 Stats: 31 lines in 1 file changed: 18 ins; 5 del; 8 mod 8281615: Deadlock caused by jdwp agent Backport-of: e1060bee2adb9f2e07ca09309d0f89132db30f28 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/183 From shade at openjdk.java.net Tue Mar 15 18:16:55 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 15 Mar 2022 18:16:55 GMT Subject: [jdk18u] RFR: 8283017: GHA: Workflows break with update release versions In-Reply-To: References: Message-ID: <-jLs9n5Za7zrhPjhMKrYkK-q43klFM-bAAAiL362-eg=.6003e7a8-ceaf-49e3-a8d9-9a0fae373ab4@github.com> On Mon, 14 Mar 2022 09:06:34 GMT, Aleksey Shipilev wrote: > Clean backport to fix GHA in 18u. > > Additional testing: > - [x] GHA checks now pass (in progress) Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk18u/pull/45 From shade at openjdk.java.net Tue Mar 15 18:16:56 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 15 Mar 2022 18:16:56 GMT Subject: [jdk18u] Integrated: 8283017: GHA: Workflows break with update release versions In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 09:06:34 GMT, Aleksey Shipilev wrote: > Clean backport to fix GHA in 18u. > > Additional testing: > - [x] GHA checks now pass (in progress) This pull request has now been integrated. Changeset: 8fd1a9e5 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk18u/commit/8fd1a9e548d4137726bbc85f8bed903ff640e872 Stats: 29 lines in 1 file changed: 18 ins; 0 del; 11 mod 8283017: GHA: Workflows break with update release versions Backport-of: 01570ca92d234481df2d540027e320b91af415a0 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/45 From shade at openjdk.java.net Tue Mar 15 18:19:03 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 15 Mar 2022 18:19:03 GMT Subject: [jdk18u] RFR: 8282225: GHA: Allow one concurrent run per PR only In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 08:26:00 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA performance. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk18u/pull/37 From shade at openjdk.java.net Tue Mar 15 18:19:03 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 15 Mar 2022 18:19:03 GMT Subject: [jdk18u] Integrated: 8282225: GHA: Allow one concurrent run per PR only In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 08:26:00 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA performance. This pull request has now been integrated. Changeset: 92d2de6e Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk18u/commit/92d2de6e95d0e2f264892eef0b5caa6608f3bb5a Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8282225: GHA: Allow one concurrent run per PR only Backport-of: aaab2cb41666af8520fd01de70e2c4f9c87ef5fd ------------- PR: https://git.openjdk.java.net/jdk18u/pull/37 From sgehwolf at openjdk.java.net Tue Mar 15 18:31:47 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 15 Mar 2022 18:31:47 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v6] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Mon, 14 Mar 2022 23:03:50 GMT, Zhengyu Gu wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: >> >> Fixes > >> getMemoryAndSwapMaxUsage > > Ready for another round, thanks. > > -Zhengyu @zhengyu123 Please also merge latest master into your branch so that GHA tests become clean (baring build/test fail due to this patch). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From sgehwolf at openjdk.java.net Tue Mar 15 18:48:07 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 15 Mar 2022 18:48:07 GMT Subject: [jdk11u-dev] RFR: 8253727: [cgroups v2] Memory and swap limits reported incorrectly Message-ID: Backport JDK-8253727 to 11u-dev. Depends on #863. Testing: container tests on a cgroups v2 system ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/863 Commit messages: - 8253727: [cgroups v2] Memory and swap limits reported incorrectly Changes: https://git.openjdk.java.net/jdk11u-dev/pull/894/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=894&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253727 Stats: 47 lines in 3 files changed: 42 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/894.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/894/head:pull/894 PR: https://git.openjdk.java.net/jdk11u-dev/pull/894 From duke at openjdk.java.net Wed Mar 16 02:00:51 2022 From: duke at openjdk.java.net (wxiang) Date: Wed, 16 Mar 2022 02:00:51 GMT Subject: [jdk11u-dev] RFR: 8261090: Store old classfiles in static CDS archive [v2] In-Reply-To: <4tqUkn-OsqxCUK_XarWC0UNUloQjtNMN8i1Keyuxjgo=.6e70c9ff-9c4b-4396-9303-6a8d9cf062e5@github.com> References: <4tqUkn-OsqxCUK_XarWC0UNUloQjtNMN8i1Keyuxjgo=.6e70c9ff-9c4b-4396-9303-6a8d9cf062e5@github.com> Message-ID: On Thu, 10 Mar 2022 07:32:26 GMT, wxiang wrote: >> 8261090: Store old classfiles in static CDS archive > > wxiang has updated the pull request incrementally with one additional commit since the last revision: > > revert the changes with 8266822 and 8267431 Hi Thomas, Thanks a lot for your comment. I understand your concern, and understand it will be difficult to accept this enhancement being ported to JDK11. In actual work, it is difficult for us to ask customers to update their libraries, especially some third-party libraries. This is why we request this backport. We have run the tier1, tier2, tier3 cases on linux x86 and aarch64, and revert the other commits in this PR. Thanks again for your advice. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/856 From serb at openjdk.java.net Wed Mar 16 04:57:15 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Wed, 16 Mar 2022 04:57:15 GMT Subject: [jdk17u-dev] RFR: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking Message-ID: Hi all, This pull request contains a backport of commit [18a7dc8c](https://github.com/openjdk/jdk/commit/18a7dc8c08fa15a260b4a39b18c068d30ee45962) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Alexander Zuev on 1 Feb 2022 and was reviewed by Sergey Bylokhov and Alexander Zvegintsev. Thanks! ------------- Commit messages: - Backport 18a7dc8c08fa15a260b4a39b18c068d30ee45962 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/258/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=258&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279586 Stats: 19 lines in 2 files changed: 15 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/258.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/258/head:pull/258 PR: https://git.openjdk.java.net/jdk17u-dev/pull/258 From goetz at openjdk.java.net Wed Mar 16 08:42:58 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 16 Mar 2022 08:42:58 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge build tag 11.0.15+6 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jdk11u-dev/pull/895/files Stats: 189 lines in 10 files changed: 167 ins; 0 del; 22 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/895.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/895/head:pull/895 PR: https://git.openjdk.java.net/jdk11u-dev/pull/895 From goetz at openjdk.java.net Wed Mar 16 08:55:49 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 16 Mar 2022 08:55:49 GMT Subject: [jdk17u] RFR: 8282444: Module finder incorrectly assumes default file system path-separator character In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 14:55:42 GMT, Chris Hegarty wrote: > 8282444: Module finder incorrectly assumes default file system path-separator character Hi @ChrisHegarty please open this change against jdk17u-dev. If this is your first pr against jdk17u-dev, remember to enable github actions for it. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/336 From shade at openjdk.java.net Wed Mar 16 09:06:05 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:06:05 GMT Subject: [jdk18u] RFR: 8279958: Provide configure hints for Alpine/apk package managers In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 08:47:23 GMT, Aleksey Shipilev wrote: > Clean backport to improve Alpine port. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk18u/pull/38 From shade at openjdk.java.net Wed Mar 16 09:06:06 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:06:06 GMT Subject: [jdk18u] Integrated: 8279958: Provide configure hints for Alpine/apk package managers In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 08:47:23 GMT, Aleksey Shipilev wrote: > Clean backport to improve Alpine port. This pull request has now been integrated. Changeset: 9089b948 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk18u/commit/9089b94894f4765bb46a4fe597c12ba19e7ecec3 Stats: 25 lines in 1 file changed: 23 ins; 0 del; 2 mod 8279958: Provide configure hints for Alpine/apk package managers Backport-of: a30aa52b77931bcea38213cf3d243d18a37dc858 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/38 From shade at openjdk.java.net Wed Mar 16 09:06:41 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:06:41 GMT Subject: [jdk18u] RFR: 8279668: x86: AVX2 versions of vpxor should be asserted [v2] In-Reply-To: References: Message-ID: > Clean backport to prevent SIGILLs on incompatible hardware. > > Additional testing: > - [x] Linux x86_64 fastdebug with `-XX:UseAVX=1` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8279668-vpxor-asserts - Backport 2bbeae3f056243a224b0bda021f16cdcbee3b3d6 ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/39/files - new: https://git.openjdk.java.net/jdk18u/pull/39/files/16edabd7..bd56b8ae Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=39&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=39&range=00-01 Stats: 217 lines in 6 files changed: 192 ins; 5 del; 20 mod Patch: https://git.openjdk.java.net/jdk18u/pull/39.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/39/head:pull/39 PR: https://git.openjdk.java.net/jdk18u/pull/39 From shade at openjdk.java.net Wed Mar 16 09:25:02 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:25:02 GMT Subject: [jdk17u-dev] RFR: 8277893: Arraycopy stress tests In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 09:04:58 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. > > Additional testing: > - [x] Linux x86_64 fastdebug passes `hotspot_compiler_arraycopy` Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/242 From shade at openjdk.java.net Wed Mar 16 09:25:04 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:25:04 GMT Subject: [jdk17u-dev] Integrated: 8277893: Arraycopy stress tests In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 09:04:58 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. > > Additional testing: > - [x] Linux x86_64 fastdebug passes `hotspot_compiler_arraycopy` This pull request has now been integrated. Changeset: 5d1969bd Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u-dev/commit/5d1969bde415556ab13a4d54bbaba6b182d70f82 Stats: 1154 lines in 12 files changed: 1153 ins; 0 del; 1 mod 8277893: Arraycopy stress tests Backport-of: 29bd73638a22d341767a1266723a7d7263e17093 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/242 From shade at openjdk.java.net Wed Mar 16 09:28:56 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:28:56 GMT Subject: [jdk17u-dev] RFR: 8281318: Improve jfr/event/allocation tests reliability In-Reply-To: <6Soc1RIO5MfX_4oc8PM5OOWbEnCcxdsTldzvG5ZfUp0=.61e2859d-ad4a-4429-ad20-6e3a48996d1f@github.com> References: <6Soc1RIO5MfX_4oc8PM5OOWbEnCcxdsTldzvG5ZfUp0=.61e2859d-ad4a-4429-ad20-6e3a48996d1f@github.com> Message-ID: <51Mdmg-lbyHRDTbEXeXRSnUeLxuOWpdaBskpqdipGsc=.d307e447-a728-4328-a02e-8b7172b02616@github.com> On Fri, 11 Mar 2022 15:53:57 GMT, Aleksey Shipilev wrote: > Clean backport to improve JFR tests on x86_32. Needs [JDK-8281638](https://bugs.openjdk.java.net/browse/JDK-8281638) as the follow-up. > > Additional testing: > - [x] Linux x86_32 fastdebug, affected tests fail without the patch, pass with it Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/240 From shade at openjdk.java.net Wed Mar 16 09:28:57 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:28:57 GMT Subject: [jdk17u-dev] Integrated: 8281318: Improve jfr/event/allocation tests reliability In-Reply-To: <6Soc1RIO5MfX_4oc8PM5OOWbEnCcxdsTldzvG5ZfUp0=.61e2859d-ad4a-4429-ad20-6e3a48996d1f@github.com> References: <6Soc1RIO5MfX_4oc8PM5OOWbEnCcxdsTldzvG5ZfUp0=.61e2859d-ad4a-4429-ad20-6e3a48996d1f@github.com> Message-ID: <-Sj9VEq7VCNikDkVKGibwgrCvRutJ0717kae1tt-3rM=.4146dea4-9bf8-4855-84d7-72de24719636@github.com> On Fri, 11 Mar 2022 15:53:57 GMT, Aleksey Shipilev wrote: > Clean backport to improve JFR tests on x86_32. Needs [JDK-8281638](https://bugs.openjdk.java.net/browse/JDK-8281638) as the follow-up. > > Additional testing: > - [x] Linux x86_32 fastdebug, affected tests fail without the patch, pass with it This pull request has now been integrated. Changeset: cf2a7abc Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u-dev/commit/cf2a7abcc505d579333d328adb2d1fb19895efb6 Stats: 54 lines in 3 files changed: 33 ins; 0 del; 21 mod 8281318: Improve jfr/event/allocation tests reliability Backport-of: 65831eb294b6f1f5f99988836c00005d41c27fd3 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/240 From chegar at openjdk.java.net Wed Mar 16 09:30:47 2022 From: chegar at openjdk.java.net (Chris Hegarty) Date: Wed, 16 Mar 2022 09:30:47 GMT Subject: [jdk18u] RFR: 8282444: Module finder incorrectly assumes default file system path-separator character [v2] In-Reply-To: References: Message-ID: <_FkhaYNXvasL3dykdHUxdKR0KSdNV1yCS_fBKP9Soog=.7f095702-736a-481b-a81c-32dcf3aa8bba@github.com> > 8282444: Module finder incorrectly assumes default file system path-separator character Chris Hegarty has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into ChrisHegarty-backport-369291b2 - Backport 369291b265e13d625c5f465da9b1854c0d70c435 ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/48/files - new: https://git.openjdk.java.net/jdk18u/pull/48/files/5bb5661a..7ad35dc4 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=48&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=48&range=00-01 Stats: 90 lines in 4 files changed: 64 ins; 5 del; 21 mod Patch: https://git.openjdk.java.net/jdk18u/pull/48.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/48/head:pull/48 PR: https://git.openjdk.java.net/jdk18u/pull/48 From shade at openjdk.java.net Wed Mar 16 09:32:38 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:32:38 GMT Subject: [jdk17u-dev] RFR: 8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions [v2] In-Reply-To: References: Message-ID: > Follow-up for JDK-8281318 backport. > > Additional testing: > - [x] Linux x86_32 fastdebug, affected tests pass > - [x] Linux x86_32 release, affected tests pass Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/241/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/241/files/296e108b..296e108b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=241&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=241&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/241.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/241/head:pull/241 PR: https://git.openjdk.java.net/jdk17u-dev/pull/241 From duke at openjdk.java.net Wed Mar 16 09:32:39 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Wed, 16 Mar 2022 09:32:39 GMT Subject: [jdk17u-dev] RFR: 8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 16:17:57 GMT, Aleksey Shipilev wrote: > Follow-up for JDK-8281318 backport. > > Additional testing: > - [x] Linux x86_32 fastdebug, affected tests pass > - [x] Linux x86_32 release, affected tests pass The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8281318-jfr-32bit git fetch https://git.openjdk.java.net/jdk17u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/241 From shade at openjdk.java.net Wed Mar 16 09:43:24 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:43:24 GMT Subject: [jdk17u-dev] RFR: 8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions [v3] In-Reply-To: References: Message-ID: <3lkr68zxgsvCUHdWqsZmp31-qAQ3D1wS4x4_pO5cx1o=.023f6c05-f9b2-4594-95e2-50c5069b7cf6@github.com> > Follow-up for JDK-8281318 backport. > > Additional testing: > - [x] Linux x86_32 fastdebug, affected tests pass > - [x] Linux x86_32 release, affected tests pass Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8281638-jfr-test-fix - Backport d254cf28c5e72bd9b8de863b831015237640ca25 - Backport 65831eb294b6f1f5f99988836c00005d41c27fd3 ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/241/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/241/files/296e108b..1c136c92 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=241&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=241&range=01-02 Stats: 2815 lines in 59 files changed: 1966 ins; 703 del; 146 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/241.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/241/head:pull/241 PR: https://git.openjdk.java.net/jdk17u-dev/pull/241 From shade at openjdk.java.net Wed Mar 16 09:43:26 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:43:26 GMT Subject: [jdk17u-dev] RFR: 8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions [v2] In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 09:32:38 GMT, Aleksey Shipilev wrote: >> Follow-up for JDK-8281318 backport. >> >> Additional testing: >> - [x] Linux x86_32 fastdebug, affected tests pass >> - [x] Linux x86_32 release, affected tests pass > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/241 From shade at openjdk.java.net Wed Mar 16 09:43:27 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:43:27 GMT Subject: [jdk17u-dev] Integrated: 8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 16:17:57 GMT, Aleksey Shipilev wrote: > Follow-up for JDK-8281318 backport. > > Additional testing: > - [x] Linux x86_32 fastdebug, affected tests pass > - [x] Linux x86_32 release, affected tests pass This pull request has now been integrated. Changeset: 60d085e6 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk17u-dev/commit/60d085e6f7ebc92f9ee14cd542c6968d6a125e43 Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod 8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions Backport-of: d254cf28c5e72bd9b8de863b831015237640ca25 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/241 From shade at openjdk.java.net Wed Mar 16 09:47:31 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 09:47:31 GMT Subject: [jdk18u] RFR: 8281168: Micro-optimize VarForm.getMemberName for interpreter [v2] In-Reply-To: References: Message-ID: > Clean backport to improve interpreter performance. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8281168-varform-interp - Backport fc77217814eb1a346d7380299abdc2b01a69b4de ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/40/files - new: https://git.openjdk.java.net/jdk18u/pull/40/files/73075ca8..f999c07d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=40&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=40&range=00-01 Stats: 242 lines in 7 files changed: 215 ins; 5 del; 22 mod Patch: https://git.openjdk.java.net/jdk18u/pull/40.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/40/head:pull/40 PR: https://git.openjdk.java.net/jdk18u/pull/40 From goetz at openjdk.java.net Wed Mar 16 11:29:48 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 16 Mar 2022 11:29:48 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 08:38:24 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.15+6 from jdk11u to jdk11u-dev Pre-submit: java/util/DoubleStreamSums/CompensatedSums.java failed, this can not be related to the change merged. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/895 From goetz at openjdk.java.net Wed Mar 16 11:29:49 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 16 Mar 2022 11:29:49 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 08:38:24 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.15+6 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: ba38fed9 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/ba38fed9136d969773b064a3afba4bb330f7b768 Stats: 189 lines in 10 files changed: 167 ins; 0 del; 22 mod Merge ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/895 From omikhaltcova at openjdk.java.net Wed Mar 16 11:37:18 2022 From: omikhaltcova at openjdk.java.net (Olga Mikhaltsova) Date: Wed, 16 Mar 2022 11:37:18 GMT Subject: [jdk11u-dev] RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28 Message-ID: I'd like to backport JDK-8166727 to jdk11u. The original patch applied cleanly. All regular tests passed (Linux x64, Windows x64, macOS x64). ------------- Commit messages: - Backport a8005efde388821e39e6464dbb17fbeac3c9830a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/896/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=896&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8166727 Stats: 17 lines in 2 files changed: 5 ins; 11 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/896.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/896/head:pull/896 PR: https://git.openjdk.java.net/jdk11u-dev/pull/896 From shade at openjdk.java.net Wed Mar 16 11:40:50 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 11:40:50 GMT Subject: [jdk11u-dev] Integrated: 8265343: Update Debian-based cross-compilation recipes In-Reply-To: <7CC6WPGbUdVXErgaSHvhY98bp9JygorbdilS6rdqzHw=.45fe9557-9b56-4a68-b3d3-bd8d5f0b6202@github.com> References: <7CC6WPGbUdVXErgaSHvhY98bp9JygorbdilS6rdqzHw=.45fe9557-9b56-4a68-b3d3-bd8d5f0b6202@github.com> Message-ID: On Mon, 8 Nov 2021 09:34:14 GMT, Aleksey Shipilev wrote: > Another (hopefully final) backport to improve cross-compilation docs. The simplified cross-compilation recipe matches what we have in 11u GHA: only `--openjdk-target` and `--with-sysroot` is supplied. > > It had minor contextual conflicts that precluded the automatic merge. I checked that the platforms listed in compatible platforms list is indeed buildable (see https://builds.shipilev.net/openjdk-jdk11-dev/ for example). This pull request has now been integrated. Changeset: 90ac8aea Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk11u-dev/commit/90ac8aea0372a6f26592015ca42b98b109ac89f7 Stats: 139 lines in 2 files changed: 86 ins; 15 del; 38 mod 8265343: Update Debian-based cross-compilation recipes Reviewed-by: stuefe Backport-of: 7879adbe88ec54b8f5ac9543d80142bc1b12112b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/601 From shade at openjdk.java.net Wed Mar 16 11:40:50 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 11:40:50 GMT Subject: [jdk11u-dev] RFR: 8265343: Update Debian-based cross-compilation recipes [v3] In-Reply-To: References: <7CC6WPGbUdVXErgaSHvhY98bp9JygorbdilS6rdqzHw=.45fe9557-9b56-4a68-b3d3-bd8d5f0b6202@github.com> Message-ID: On Tue, 15 Mar 2022 10:55:31 GMT, Aleksey Shipilev wrote: >> Another (hopefully final) backport to improve cross-compilation docs. The simplified cross-compilation recipe matches what we have in 11u GHA: only `--openjdk-target` and `--with-sysroot` is supplied. >> >> It had minor contextual conflicts that precluded the automatic merge. I checked that the platforms listed in compatible platforms list is indeed buildable (see https://builds.shipilev.net/openjdk-jdk11-dev/ for example). > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 7879adbe88ec54b8f5ac9543d80142bc1b12112b Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/601 From shade at openjdk.java.net Wed Mar 16 12:27:56 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 12:27:56 GMT Subject: [jdk18u] RFR: 8279668: x86: AVX2 versions of vpxor should be asserted [v2] In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 09:06:41 GMT, Aleksey Shipilev wrote: >> Clean backport to prevent SIGILLs on incompatible hardware. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug with `-XX:UseAVX=1` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8279668-vpxor-asserts > - Backport 2bbeae3f056243a224b0bda021f16cdcbee3b3d6 Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk18u/pull/39 From shade at openjdk.java.net Wed Mar 16 12:27:56 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 12:27:56 GMT Subject: [jdk18u] Integrated: 8279668: x86: AVX2 versions of vpxor should be asserted In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 11:46:51 GMT, Aleksey Shipilev wrote: > Clean backport to prevent SIGILLs on incompatible hardware. > > Additional testing: > - [x] Linux x86_64 fastdebug with `-XX:UseAVX=1` This pull request has now been integrated. Changeset: 6b5706a8 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk18u/commit/6b5706a8a06a9fed86780910f3d83838e7fddcb7 Stats: 15 lines in 2 files changed: 12 ins; 0 del; 3 mod 8279668: x86: AVX2 versions of vpxor should be asserted Backport-of: 2bbeae3f056243a224b0bda021f16cdcbee3b3d6 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/39 From goetz at openjdk.java.net Wed Mar 16 12:49:32 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 16 Mar 2022 12:49:32 GMT Subject: [jdk17u] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods Message-ID: I backport this for parity with 17.0.3-oracle. It's a clean backout of 8276141 ------------- Commit messages: - 8282761: XPathFactoryImpl remove setProperty and getProperty methods Changes: https://git.openjdk.java.net/jdk17u/pull/337/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u&pr=337&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282761 Stats: 59 lines in 2 files changed: 0 ins; 56 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u/pull/337.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u pull/337/head:pull/337 PR: https://git.openjdk.java.net/jdk17u/pull/337 From aleonard at openjdk.java.net Wed Mar 16 13:16:59 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Wed, 16 Mar 2022 13:16:59 GMT Subject: [jdk17u-dev] Integrated: 8279834: Alpine Linux fails to build when --with-source-date enabled In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 16:52:17 GMT, Andrew Leonard wrote: > Alpine linux fails to configure if --with-source-date option for reproducible builds is specified. > This is the accompanying fix for Alpine Linux with recently merged PR https://github.com/openjdk/jdk17u-dev/pull/246. This pull request has now been integrated. Changeset: f67a3a5b Author: Andrew Leonard Committer: Vladimir Kempik URL: https://git.openjdk.java.net/jdk17u-dev/commit/f67a3a5bda48dcf3abacc78113d359a9524b1609 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8279834: Alpine Linux fails to build when --with-source-date enabled Backport-of: 9e0244762c0961b1bb3453d294531997b367e757 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/257 From vkempik at openjdk.java.net Wed Mar 16 13:22:16 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Wed, 16 Mar 2022 13:22:16 GMT Subject: [jdk11u-dev] RFR: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang Message-ID: Clean backport to jdk11u-dev ------------- Commit messages: - Backport f5d6fddc6df8c5c5456a2544b131833d5227292b Changes: https://git.openjdk.java.net/jdk11u-dev/pull/897/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=897&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280476 Stats: 11 lines in 1 file changed: 10 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/897.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/897/head:pull/897 PR: https://git.openjdk.java.net/jdk11u-dev/pull/897 From vkempik at openjdk.java.net Wed Mar 16 13:25:33 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Wed, 16 Mar 2022 13:25:33 GMT Subject: [jdk17u-dev] RFR: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang Message-ID: Clean Backport to jdk17u-dev ------------- Commit messages: - Backport f5d6fddc6df8c5c5456a2544b131833d5227292b Changes: https://git.openjdk.java.net/jdk17u-dev/pull/259/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=259&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280476 Stats: 11 lines in 1 file changed: 10 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/259.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/259/head:pull/259 PR: https://git.openjdk.java.net/jdk17u-dev/pull/259 From yan at openjdk.java.net Wed Mar 16 13:35:07 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 16 Mar 2022 13:35:07 GMT Subject: [jdk17u] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 12:41:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > It's a clean backout of 8276141 It would go to 17.0.4, right, in July? There may be a merge necessary then because of some XPATHErrorResources.java context in a backport series I've posted on Mar 10. Maybe it would be easier to do it after a build 01? At least I have such a plan for 15/13 as there seems to be no rush. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/337 From zgu at openjdk.java.net Wed Mar 16 13:43:55 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 16 Mar 2022 13:43:55 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v7] In-Reply-To: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: > This is a followup backport for Cgroup v2 support. > > The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. > > In additional: > > 1) Include partial backport of JDK-8250627. > - Renamed `Metrics.c` => `CgroupMetrics.c` > - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` > - Return instance only if `isUseContainerSupport()` is enabled. > > 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test > > 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` > > Test: > > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS Zhengyu Gu has updated the pull request incrementally with 50 additional commits since the last revision: - Merge branch 'master' into backport-8231111-unified-hierarchy - 8265343: Update Debian-based cross-compilation recipes Reviewed-by: stuefe Backport-of: 7879adbe88ec54b8f5ac9543d80142bc1b12112b - Merge - 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem Reviewed-by: mbaesken Backport-of: 6aa02d75d9f26f46fbdb54aef52cea3257aa7462 - 8281615: Deadlock caused by jdwp agent Backport-of: e1060bee2adb9f2e07ca09309d0f89132db30f28 - 8266251: compiler.inlining.InlineAccessors shouldn't do testing in driver VM Backport-of: 9605aeddee70ba4f3dba2ae2a3d100319164b03d - 8231565: More node budget asserts in fuzzed tests Backport-of: 902858e3ceb43bf92ea9fa038b9edcf1ee0c48b5 - 8229499: Node budget assert in fuzzed test Reviewed-by: stuefe Backport-of: 8275b17b07b1c15bde79b36b76ecbe3072db1e1a - 8234605: C2 failed "assert(C->live_nodes() - live_at_begin <= 2 * _nodes_required) failed: Bad node estimate: actual = 208 >> request = 101" Backport-of: d19f2bdec01eb324d200f2144293d05ea310f9b8 - 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed Reviewed-by: mdoerr Backport-of: f5d36e6c9470b1ac5326990b1c4fea80457c4ad6 - ... and 40 more: https://git.openjdk.java.net/jdk11u-dev/compare/191fbe46...7d276fe6 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/863/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/863/files/191fbe46..7d276fe6 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=06 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=05-06 Stats: 7601 lines in 348 files changed: 3788 ins; 2721 del; 1092 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/863/head:pull/863 PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From aleonard at openjdk.java.net Wed Mar 16 13:58:47 2022 From: aleonard at openjdk.java.net (Andrew Leonard) Date: Wed, 16 Mar 2022 13:58:47 GMT Subject: [jdk17u-dev] RFR: 8279834: Alpine Linux fails to build when --with-source-date enabled In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 16:52:17 GMT, Andrew Leonard wrote: > Alpine linux fails to configure if --with-source-date option for reproducible builds is specified. > This is the accompanying fix for Alpine Linux with recently merged PR https://github.com/openjdk/jdk17u-dev/pull/246. thank you @VladimirKempik ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/257 From rkennke at openjdk.java.net Wed Mar 16 14:14:13 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 16 Mar 2022 14:14:13 GMT Subject: [jdk18u] RFR: 8278065: Refactor subclassAudits to use ClassValue Message-ID: This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. The original change has baked for several weeks in jdk19 and applies cleanly. Testing: - [ ] tier1 - [ ] tier2 - [ ] tier3 ------------- Depends on: https://git.openjdk.java.net/jdk18u/pull/36 Commit messages: - Backport 8fed8ab29cae4f189f44609c23f116967eef6bdf Changes: https://git.openjdk.java.net/jdk18u/pull/50/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=50&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278065 Stats: 105 lines in 3 files changed: 2 ins; 89 del; 14 mod Patch: https://git.openjdk.java.net/jdk18u/pull/50.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/50/head:pull/50 PR: https://git.openjdk.java.net/jdk18u/pull/50 From rkennke at openjdk.java.net Wed Mar 16 14:27:20 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 16 Mar 2022 14:27:20 GMT Subject: [jdk17u-dev] RFR: 8278065: Refactor subclassAudits to use ClassValue Message-ID: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. The original change has baked for several weeks in jdk19 and applies with some fuzz, but no conflicts. Testing: - [ ] tier1 - [ ] tier2 - [ ] tier3 ------------- Depends on: https://git.openjdk.java.net/jdk17u-dev/pull/210 Commit messages: - Backport 8fed8ab29cae4f189f44609c23f116967eef6bdf Changes: https://git.openjdk.java.net/jdk17u-dev/pull/260/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=260&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278065 Stats: 105 lines in 3 files changed: 2 ins; 89 del; 14 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/260.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/260/head:pull/260 PR: https://git.openjdk.java.net/jdk17u-dev/pull/260 From goetz at openjdk.java.net Wed Mar 16 14:29:17 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 16 Mar 2022 14:29:17 GMT Subject: [jdk11u-dev] RFR: 8199874: [TESTBUG] runtime/Thread/ThreadPriorities.java fails with "expected 0 to equal 10" Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 0d9f615e9214ed6f1f69f6e7969e966005948eb3 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/898/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=898&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8199874 Stats: 18 lines in 1 file changed: 13 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/898.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/898/head:pull/898 PR: https://git.openjdk.java.net/jdk11u-dev/pull/898 From rkennke at openjdk.java.net Wed Mar 16 14:40:02 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 16 Mar 2022 14:40:02 GMT Subject: [jdk11u-dev] RFR: 8278065: Refactor subclassAudits to use ClassValue Message-ID: This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. The original change has baked for several weeks in jdk19 and applies with some conflicts caused by different context. Testing: - [ ] tier1 - [ ] tier2 - [ ] tier3 ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/869 Commit messages: - Backport 8fed8ab29cae4f189f44609c23f116967eef6bdf Changes: https://git.openjdk.java.net/jdk11u-dev/pull/899/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=899&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278065 Stats: 105 lines in 3 files changed: 2 ins; 89 del; 14 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/899.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/899/head:pull/899 PR: https://git.openjdk.java.net/jdk11u-dev/pull/899 From goetz at openjdk.java.net Wed Mar 16 15:14:07 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 16 Mar 2022 15:14:07 GMT Subject: [jdk11u-dev] RFR: 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start Message-ID: <0ktbL9vceZ3EseL7h9sJYRxW-ogWMDXWu1NmP6gCFgk=.a7e434e5-99eb-4518-98f8-b495aea1a226@github.com> I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 31cf8b1c65fb0b19e093547fc557fff55d7213bd Changes: https://git.openjdk.java.net/jdk11u-dev/pull/900/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=900&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8207364 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/900.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/900/head:pull/900 PR: https://git.openjdk.java.net/jdk11u-dev/pull/900 From zgu at openjdk.java.net Wed Mar 16 15:40:21 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 16 Mar 2022 15:40:21 GMT Subject: [jdk11u-dev] RFR: 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp Message-ID: I would like to backport this patch to 11u for reducing noise on JDK-8231111. The original patch does not apply cleanly, due to out-of-order backport of JDK-8202142. Test: - [x] jdk_jfr `EvilInstrument.java` test fails. Followup JDK-8230865 backport to fix it. ------------- Commit messages: - Remove whitespaces - Backport 7d3aebccc0b90aa2ca2f656c683fa5931fd0ed3a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/901/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=901&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8223396 Stats: 51 lines in 11 files changed: 30 ins; 5 del; 16 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/901.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/901/head:pull/901 PR: https://git.openjdk.java.net/jdk11u-dev/pull/901 From goetz at openjdk.java.net Wed Mar 16 15:48:02 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 16 Mar 2022 15:48:02 GMT Subject: [jdk11u-dev] RFR: 8229486: Replace wildcard address with loopback or local host in tests - part 21 Message-ID: I backport this for parity with 11.0.16-oracle. TcpKeepAliveTest.java does not apply because 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 f... is missing SetIfModifiedSince.java does not apply because 8226756: Replace wildcard address with loopback or local host in tests - part 18 is missing. I included the respective previous changes to these two files in this patch. Backporting these larger dependencies will cause recursive backports or require resolving. I want to avoid this additional effort. In case backports of these other changes are necessary later, one will just have to skip the patches to the corresponding files. As the changes are quite simple, this should be easy enough to do. ------------- Commit messages: - Backport 77d09f0f14bdaafa2e3528c73ee2287338e2ad49 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/902/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=902&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8229486 Stats: 242 lines in 11 files changed: 155 ins; 11 del; 76 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/902.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/902/head:pull/902 PR: https://git.openjdk.java.net/jdk11u-dev/pull/902 From zgu at openjdk.java.net Wed Mar 16 15:54:09 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 16 Mar 2022 15:54:09 GMT Subject: [jdk11u-dev] RFR: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target Message-ID: I would like to backport this patch to fix test failure, introduced by JDK-8223396. This is a clean backport on top of JDK-8223396 backport. Test: - [x] jdk_jfr ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/901 Commit messages: - Backport 725da985e170d72c3ca3dc2dfbb3d7e083b5371a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/903/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=903&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8230865 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/903.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/903/head:pull/903 PR: https://git.openjdk.java.net/jdk11u-dev/pull/903 From mdoerr at openjdk.java.net Wed Mar 16 16:06:10 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 16 Mar 2022 16:06:10 GMT Subject: [jdk11u] RFR: 8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 Message-ID: Restore usage of ThreadInVMfromJavaNoAsyncException in JRT_ENTRY_NO_ASYNC. See JBS for details. ------------- Commit messages: - 8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 Changes: https://git.openjdk.java.net/jdk11u/pull/31/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=31&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283270 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u/pull/31.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/31/head:pull/31 PR: https://git.openjdk.java.net/jdk11u/pull/31 From sgehwolf at openjdk.java.net Wed Mar 16 16:49:53 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 16 Mar 2022 16:49:53 GMT Subject: [jdk11u] RFR: 8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 In-Reply-To: References: Message-ID: <_OAMJ9XWr9m3zwa9-jVnXsGp-yCZQuOH4753qLgN2BU=.160681ea-ae00-40dc-a85e-852f53a351d5@github.com> On Wed, 16 Mar 2022 15:59:14 GMT, Martin Doerr wrote: > Restore usage of ThreadInVMfromJavaNoAsyncException in JRT_ENTRY_NO_ASYNC. See JBS for details. LGTM, https://bugs.openjdk.java.net/browse/JDK-8263191 is not in 11u. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u/pull/31 From shade at openjdk.java.net Wed Mar 16 17:03:55 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 17:03:55 GMT Subject: [jdk18u] RFR: 8281168: Micro-optimize VarForm.getMemberName for interpreter [v2] In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 09:47:31 GMT, Aleksey Shipilev wrote: >> Clean backport to improve interpreter performance. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug `tier1` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8281168-varform-interp > - Backport fc77217814eb1a346d7380299abdc2b01a69b4de Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk18u/pull/40 From shade at openjdk.java.net Wed Mar 16 17:05:52 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 17:05:52 GMT Subject: [jdk18u] RFR: 8277893: Arraycopy stress tests [v2] In-Reply-To: References: Message-ID: > Clean backport to improve testing. > > Additional testing: > - [x] Linux x86_64 fastdebug passes `hotspot_compiler_arraycopy` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8277893-arraycopy-stress-tests - Backport 29bd73638a22d341767a1266723a7d7263e17093 ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/44/files - new: https://git.openjdk.java.net/jdk18u/pull/44/files/2064acfc..15543921 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=44&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=44&range=00-01 Stats: 257 lines in 9 files changed: 227 ins; 5 del; 25 mod Patch: https://git.openjdk.java.net/jdk18u/pull/44.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/44/head:pull/44 PR: https://git.openjdk.java.net/jdk18u/pull/44 From shade at openjdk.java.net Wed Mar 16 17:06:11 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 17:06:11 GMT Subject: [jdk18u] Integrated: 8281168: Micro-optimize VarForm.getMemberName for interpreter In-Reply-To: References: Message-ID: <9WbcymUz3TCdkjzx3qG-V9aGReRCnFleCpk-NhqXxyk=.f0b4926a-a8a5-43ad-82e8-ca39a610c4b5@github.com> On Thu, 10 Mar 2022 15:24:54 GMT, Aleksey Shipilev wrote: > Clean backport to improve interpreter performance. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` This pull request has now been integrated. Changeset: c66544f7 Author: Aleksey Shipilev URL: https://git.openjdk.java.net/jdk18u/commit/c66544f78f84f978d6aad50d5cdc1e046d7e3f3b Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod 8281168: Micro-optimize VarForm.getMemberName for interpreter Backport-of: fc77217814eb1a346d7380299abdc2b01a69b4de ------------- PR: https://git.openjdk.java.net/jdk18u/pull/40 From shade at openjdk.java.net Wed Mar 16 17:09:45 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 16 Mar 2022 17:09:45 GMT Subject: [jdk18u] RFR: 8281318: Improve jfr/event/allocation tests reliability [v2] In-Reply-To: References: Message-ID: > Clean backport to improve JFR tests on x86_32. > Needs [JDK-8281638](https://bugs.openjdk.java.net/browse/JDK-8281638) as the follow-up. > > Additional testing: > - [x] Linux x86_32 fastdebug, affected tests fail without the patch, pass with it Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8281318-jfr-32bit - Backport 65831eb294b6f1f5f99988836c00005d41c27fd3 ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/42/files - new: https://git.openjdk.java.net/jdk18u/pull/42/files/9d8bda7f..dd8d894b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=42&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=42&range=00-01 Stats: 257 lines in 9 files changed: 227 ins; 5 del; 25 mod Patch: https://git.openjdk.java.net/jdk18u/pull/42.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/42/head:pull/42 PR: https://git.openjdk.java.net/jdk18u/pull/42 From mdoerr at openjdk.java.net Wed Mar 16 17:34:51 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 16 Mar 2022 17:34:51 GMT Subject: [jdk11u] RFR: 8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 In-Reply-To: References: Message-ID: <6Cx5gm3slzmPnuD3vK_h17_d_NS8sPZDiKY_u0zBV34=.01fef633-a634-42cd-b66b-f95f548dd8da@github.com> On Wed, 16 Mar 2022 15:59:14 GMT, Martin Doerr wrote: > Restore usage of ThreadInVMfromJavaNoAsyncException in JRT_ENTRY_NO_ASYNC. See JBS for details. Thanks for the review! We'll test it one more night before requesting jdk11u-critical approval. ------------- PR: https://git.openjdk.java.net/jdk11u/pull/31 From sgehwolf at openjdk.java.net Wed Mar 16 17:50:46 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 16 Mar 2022 17:50:46 GMT Subject: [jdk11u-dev] RFR: 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 15:30:14 GMT, Zhengyu Gu wrote: > I would like to backport this patch to 11u for reducing noise on JDK-8231111. > > The original patch does not apply cleanly, due to out-of-order backport of JDK-8202142. > > Test: > > - [x] jdk_jfr > `EvilInstrument.java` test fails. Followup JDK-8230865 backport to fix it. LGTM. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/901 From phh at openjdk.java.net Wed Mar 16 17:59:43 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 16 Mar 2022 17:59:43 GMT Subject: [jdk11u-dev] RFR: 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist! In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 14:35:52 GMT, Martin Doerr wrote: > Backport of https://bugs.openjdk.java.net/browse/JDK-8279356 > Fix needs manual integration because 11u has additional CDS code in `Method::link_method`. Copyright year updates were also integrated manually. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/891 From mdoerr at openjdk.java.net Wed Mar 16 17:59:43 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 16 Mar 2022 17:59:43 GMT Subject: [jdk11u-dev] RFR: 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist! In-Reply-To: References: Message-ID: <2tue65TlZuIyyx6d0AyS3qPf3ooTBos9tj18PbcfheA=.eb2b0492-e1ba-44bc-a792-ffc2fd1d4c9e@github.com> On Mon, 14 Mar 2022 14:35:52 GMT, Martin Doerr wrote: > Backport of https://bugs.openjdk.java.net/browse/JDK-8279356 > Fix needs manual integration because 11u has additional CDS code in `Method::link_method`. Copyright year updates were also integrated manually. Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/891 From phh at openjdk.java.net Wed Mar 16 18:37:39 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Wed, 16 Mar 2022 18:37:39 GMT Subject: [jdk11u-dev] RFR: 8247592: refactor test/jdk/tools/launcher/Test7029048.java In-Reply-To: References: Message-ID: On Thu, 10 Mar 2022 13:19:13 GMT, Aleksei Voitylov wrote: > JDK-8247592 is in the only issue in the second batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Original changeset does not apply cleanly because of "8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports", which removed Solaris-specific code from affected test. > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/873 From clanger at openjdk.java.net Wed Mar 16 19:33:46 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 16 Mar 2022 19:33:46 GMT Subject: [jdk11u] RFR: 8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 15:59:14 GMT, Martin Doerr wrote: > Restore usage of ThreadInVMfromJavaNoAsyncException in JRT_ENTRY_NO_ASYNC. See JBS for details. Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u/pull/31 From duke at openjdk.java.net Thu Mar 17 01:41:06 2022 From: duke at openjdk.java.net (Basil Crow) Date: Thu, 17 Mar 2022 01:41:06 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) Message-ID: Hi all, This pull request contains a clean backport of commit [44ae643b2b4](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. Thanks! ------------- Commit messages: - 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) Changes: https://git.openjdk.java.net/jdk11u-dev/pull/855/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=855&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210649 Stats: 176 lines in 3 files changed: 161 ins; 8 del; 7 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/855.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/855/head:pull/855 PR: https://git.openjdk.java.net/jdk11u-dev/pull/855 From duke at openjdk.java.net Thu Mar 17 02:00:19 2022 From: duke at openjdk.java.net (Basil Crow) Date: Thu, 17 Mar 2022 02:00:19 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) [v2] In-Reply-To: References: Message-ID: <7OIKCPioWCLbgTMTHMYOjKKRopckOACgX5g7-cnibhk=.ebdb4fda-4028-4b92-a7ce-a9361b172310@github.com> > Hi all, > > This pull request contains a clean backport of commit [44ae643b2b4](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. > > See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. > > Thanks! Basil Crow has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) Summary: Do not clean trees after last round of annotation processing, if the trees won't be re-entered again. Reviewed-by: vromero Backport-of: 44ae643b2b49b66b1fff4c151c17972c6b683cc0 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/855/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=855&range=01 Stats: 176 lines in 3 files changed: 161 ins; 8 del; 7 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/855.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/855/head:pull/855 PR: https://git.openjdk.java.net/jdk11u-dev/pull/855 From duke at openjdk.java.net Thu Mar 17 02:03:38 2022 From: duke at openjdk.java.net (Basil Crow) Date: Thu, 17 Mar 2022 02:03:38 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) In-Reply-To: References: Message-ID: On Sun, 6 Mar 2022 01:51:23 GMT, Basil Crow wrote: > Hi all, > > This pull request contains a clean backport of commit [44ae643b2b4](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. > > See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. > > Thanks! CC @lahodaj @vicente-romero-oracle ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/855 From serb at openjdk.java.net Thu Mar 17 06:33:45 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Thu, 17 Mar 2022 06:33:45 GMT Subject: [jdk17u-dev] Integrated: 8274751: Drag And Drop hangs on Windows In-Reply-To: References: Message-ID: On Wed, 2 Feb 2022 04:42:55 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [7a0a6c95](https://github.com/openjdk/jdk/commit/7a0a6c95a53c6cb3340328d6543a97807320b740) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Dmitry Markov on 24 Jan 2022 and was reviewed by Alexey Ivanov, Phil Race and Sergey Bylokhov. > Thanks! This pull request has now been integrated. Changeset: ee7a603d Author: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk17u-dev/commit/ee7a603dfdc84f0c9f2888a362ea2fcfd8ee1e4d Stats: 19 lines in 4 files changed: 2 ins; 0 del; 17 mod 8274751: Drag And Drop hangs on Windows Backport-of: 7a0a6c95a53c6cb3340328d6543a97807320b740 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/142 From goetz at openjdk.java.net Thu Mar 17 07:56:07 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 07:56:07 GMT Subject: [jdk11u-dev] RFR: 8231489: GC watermark_0_1 failed due to "metaspace.gc.Fault: GC has happened too rare" Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 9e17946ab21434df0f6780423f7998166265af2a Changes: https://git.openjdk.java.net/jdk11u-dev/pull/904/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=904&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8231489 Stats: 33 lines in 6 files changed: 21 ins; 7 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/904.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/904/head:pull/904 PR: https://git.openjdk.java.net/jdk11u-dev/pull/904 From goetz at openjdk.java.net Thu Mar 17 08:00:52 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 08:00:52 GMT Subject: [jdk11u-dev] RFR: 8241707: introduce randomness k/w to hotspot test suite Message-ID: <776Hw1_pRJvV8LkXBFXf1xEcAVDNGguuJLSiQUJKl_k=.98fe1017-3802-47ef-9c8a-b67080893272@github.com> I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 0eb72d4e7485b837c5690ac1c892a546e1554802 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/905/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=905&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8241707 Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/905.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/905/head:pull/905 PR: https://git.openjdk.java.net/jdk11u-dev/pull/905 From goetz at openjdk.java.net Thu Mar 17 08:15:08 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 08:15:08 GMT Subject: [jdk11u-dev] RFR: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support Message-ID: <8Kc8Ah7DYFo3bKN7ZbZgfTf-2P8TZ-4DkyScvEzrxIU=.3e9108db-2efc-48f9-8f71-bed84e0e46ea@github.com> I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 6346793c6401b3758edf0a8912acb0fd8813957b Changes: https://git.openjdk.java.net/jdk11u-dev/pull/906/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=906&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269933 Stats: 27 lines in 1 file changed: 15 ins; 0 del; 12 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/906.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/906/head:pull/906 PR: https://git.openjdk.java.net/jdk11u-dev/pull/906 From goetz at openjdk.java.net Thu Mar 17 08:29:03 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 08:29:03 GMT Subject: [jdk11u-dev] RFR: 8274233: Minor cleanup for ToolBox Message-ID: <9xgChbUDTt--TMNrBkk6c0Zf4CMO-hb3LrLdcfXWWZs=.09ce0d97-3707-49aa-95ed-1e7c0c93bc4b@github.com> I backport this for parity with 11.0.16-oracle. I had to resolve some comment changes because previous changes are missing. They are formatting changes, so pretty pointless. One code block had to be resolved because of context changes. ------------- Commit messages: - Backport e741a18062061c1959f7881503aaf3a4cbcae776 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/907/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=907&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274233 Stats: 107 lines in 1 file changed: 45 ins; 12 del; 50 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/907.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/907/head:pull/907 PR: https://git.openjdk.java.net/jdk11u-dev/pull/907 From goetz at openjdk.java.net Thu Mar 17 08:34:50 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 08:34:50 GMT Subject: [jdk17u-dev] Integrated: 8275037: Test vmTestbase/nsk/sysdict/vm/stress/btree/btree011/btree011.java crashes with memory exhaustion on Windows In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 12:31:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: e9557600 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/e9557600c5571e7fe8dea0ddbf5c5d60c288cc58 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod 8275037: Test vmTestbase/nsk/sysdict/vm/stress/btree/btree011/btree011.java crashes with memory exhaustion on Windows Backport-of: 9f2f46ee4576d9cd0190530949e5e50f796a6bdc ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/249 From goetz at openjdk.java.net Thu Mar 17 08:37:56 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 08:37:56 GMT Subject: [jdk17u-dev] Integrated: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories In-Reply-To: References: Message-ID: <-h-3VpzHtSj7LoB0iAzIgQYCo6jFFiaAnrGzYQ87zSk=.ae1decb4-aa61-4136-8372-4864eb0eec3a@github.com> On Tue, 15 Mar 2022 09:34:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: defd25c9 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/defd25c98f39d0708d8cb54b9e46b3f81c4a330e Stats: 301 lines in 11 files changed: 288 ins; 6 del; 7 mod 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories 8277166: Data race in jdeps VersionHelper 8277123: jdeps does not report some exceptions correctly Backport-of: 7e54d065a17f1277adf1b8561fadb8a480bc6bed ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/256 From vkempik at openjdk.java.net Thu Mar 17 08:39:53 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 17 Mar 2022 08:39:53 GMT Subject: [jdk17u-dev] RFR: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 13:04:49 GMT, Vladimir Kempik wrote: > Clean Backport to jdk17u-dev Linux test failures are infra issues and unrelated ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/259 From goetz at openjdk.java.net Thu Mar 17 08:39:56 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 08:39:56 GMT Subject: [jdk17u-dev] Integrated: 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 14:45:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 40dce20d Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/40dce20d2b582ee1830cedfd0d70645e8ea3ba80 Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch Backport-of: ad1ff27b730773a141d73744e5f5a899bdfbea78 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/251 From goetz at openjdk.java.net Thu Mar 17 08:43:56 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 08:43:56 GMT Subject: [jdk17u-dev] Integrated: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 15:23:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 2acca949 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/2acca949709b75a6076be2c2b1e27e01a03f7b5d Stats: 75 lines in 4 files changed: 66 ins; 0 del; 9 mod 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method Backport-of: 1f1db838ab7d427170d59a8b55fdb45c4d80c359 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/253 From goetz at openjdk.java.net Thu Mar 17 08:46:40 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 08:46:40 GMT Subject: [jdk17u-dev] Integrated: 8214733: runtime/8176717/TestInheritFD.java timed out In-Reply-To: References: Message-ID: <-T-3If8cNgA5DpjxUwgJ7X_ZYb0u6QAvemuqimU2zmU=.fa921bcd-593b-47fd-8fdc-122f87b627a9@github.com> On Mon, 14 Mar 2022 15:53:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 90126f80 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/90126f80c3ffa6d803b303cea749567731634185 Stats: 6 lines in 1 file changed: 2 ins; 1 del; 3 mod 8214733: runtime/8176717/TestInheritFD.java timed out Backport-of: 4501ddda7f8e0eb9352a937030a62902bfaac647 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/255 From goetz at openjdk.java.net Thu Mar 17 08:45:43 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 08:45:43 GMT Subject: [jdk17u-dev] Integrated: 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 15:46:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 00f201d5 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/00f201d514700424eed6805fa6587d07927afe06 Stats: 492 lines in 10 files changed: 359 ins; 32 del; 101 mod 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM Backport-of: e14fb4f4aa9c4569615005e474f897c54094f024 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/254 From goetz at openjdk.java.net Thu Mar 17 08:58:41 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 08:58:41 GMT Subject: [jdk11u-dev] Integrated: 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start In-Reply-To: <0ktbL9vceZ3EseL7h9sJYRxW-ogWMDXWu1NmP6gCFgk=.a7e434e5-99eb-4518-98f8-b495aea1a226@github.com> References: <0ktbL9vceZ3EseL7h9sJYRxW-ogWMDXWu1NmP6gCFgk=.a7e434e5-99eb-4518-98f8-b495aea1a226@github.com> Message-ID: On Wed, 16 Mar 2022 15:05:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: ebf6a5b7 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/ebf6a5b7afcb717573611f6dacf3c231dee08223 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start Backport-of: 31cf8b1c65fb0b19e093547fc557fff55d7213bd ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/900 From goetz at openjdk.java.net Thu Mar 17 09:00:34 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 09:00:34 GMT Subject: [jdk11u-dev] Integrated: 8199874: [TESTBUG] runtime/Thread/ThreadPriorities.java fails with "expected 0 to equal 10" In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 14:20:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: 38e44eb5 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/38e44eb552c6ebaa75310babb920b72f80deba90 Stats: 18 lines in 1 file changed: 13 ins; 0 del; 5 mod 8199874: [TESTBUG] runtime/Thread/ThreadPriorities.java fails with "expected 0 to equal 10" Backport-of: 0d9f615e9214ed6f1f69f6e7969e966005948eb3 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/898 From mdoerr at openjdk.java.net Thu Mar 17 09:07:38 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 17 Mar 2022 09:07:38 GMT Subject: [jdk11u] RFR: 8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 In-Reply-To: References: Message-ID: <49bBuCqUJT2eZQem9XfKxOH8KWIscUT_-Rtbqw_VijE=.45be0251-d6e2-49fe-a5d2-8c1bdfac8015@github.com> On Wed, 16 Mar 2022 15:59:14 GMT, Martin Doerr wrote: > Restore usage of ThreadInVMfromJavaNoAsyncException in JRT_ENTRY_NO_ASYNC. See JBS for details. Thanks for the review! Nightly tests have passed. I've requested jdk11u-critical approval. ------------- PR: https://git.openjdk.java.net/jdk11u/pull/31 From goetz at openjdk.java.net Thu Mar 17 09:26:47 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 09:26:47 GMT Subject: [jdk11u-dev] RFR: 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport ad1ff27b730773a141d73744e5f5a899bdfbea78 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/908/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=908&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277422 Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/908.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/908/head:pull/908 PR: https://git.openjdk.java.net/jdk11u-dev/pull/908 From mdoerr at openjdk.java.net Thu Mar 17 09:38:31 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 17 Mar 2022 09:38:31 GMT Subject: [jdk11u-dev] Integrated: 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist! In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 14:35:52 GMT, Martin Doerr wrote: > Backport of https://bugs.openjdk.java.net/browse/JDK-8279356 > Fix needs manual integration because 11u has additional CDS code in `Method::link_method`. Copyright year updates were also integrated manually. This pull request has now been integrated. Changeset: e1b2f92a Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u-dev/commit/e1b2f92a308d27ea9a1bc8e6562b48be8120e9da Stats: 53 lines in 2 files changed: 43 ins; 2 del; 8 mod 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist! Reviewed-by: phh Backport-of: 6d7db4b0b3e9172645cef12c36fbeb41a6d38d83 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/891 From mdoerr at openjdk.java.net Thu Mar 17 09:39:31 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 17 Mar 2022 09:39:31 GMT Subject: [jdk11u] Integrated: 8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 15:59:14 GMT, Martin Doerr wrote: > Restore usage of ThreadInVMfromJavaNoAsyncException in JRT_ENTRY_NO_ASYNC. See JBS for details. This pull request has now been integrated. Changeset: 3a0074c0 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk11u/commit/3a0074c05f9f6da287db9772fa1fe96ec79cf4a7 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 Reviewed-by: sgehwolf, clanger ------------- PR: https://git.openjdk.java.net/jdk11u/pull/31 From omikhaltcova at openjdk.java.net Thu Mar 17 10:25:34 2022 From: omikhaltcova at openjdk.java.net (Olga Mikhaltsova) Date: Thu, 17 Mar 2022 10:25:34 GMT Subject: [jdk11u-dev] Integrated: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28 In-Reply-To: References: Message-ID: <3n_2diQiznB3JsuzF8PRlgjn174pFwEXixvsHIdU8jo=.1e24330d-5d0c-40d6-ac06-4ccbadf49e4a@github.com> On Wed, 16 Mar 2022 11:30:42 GMT, Olga Mikhaltsova wrote: > I'd like to backport JDK-8166727 to jdk11u. > The original patch applied cleanly. > All regular tests passed (Linux x64, Windows x64, macOS x64). This pull request has now been integrated. Changeset: 62afe2eb Author: Olga Mikhaltsova URL: https://git.openjdk.java.net/jdk11u-dev/commit/62afe2ebf74367b76874eda7cfc7b4bfcb10d703 Stats: 17 lines in 2 files changed: 5 ins; 11 del; 1 mod 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28 Backport-of: a8005efde388821e39e6464dbb17fbeac3c9830a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/896 From avoitylov at openjdk.java.net Thu Mar 17 12:39:31 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 17 Mar 2022 12:39:31 GMT Subject: [jdk11u-dev] Integrated: 8247592: refactor test/jdk/tools/launcher/Test7029048.java In-Reply-To: References: Message-ID: <-SMJU88AVKhXDGDsaLYYaqq7OU-dZ1l1nv3PBb73J3o=.36416bbc-32fc-406a-9f9b-52855a88bc0a@github.com> On Thu, 10 Mar 2022 13:19:13 GMT, Aleksei Voitylov wrote: > JDK-8247592 is in the only issue in the second batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Original changeset does not apply cleanly because of "8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports", which removed Solaris-specific code from affected test. > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html This pull request has now been integrated. Changeset: 95434882 Author: Aleksei Voitylov Committer: Alexander Scherbatiy URL: https://git.openjdk.java.net/jdk11u-dev/commit/95434882fd90cedc75aece11196c71885e2fe102 Stats: 84 lines in 1 file changed: 21 ins; 46 del; 17 mod 8247592: refactor test/jdk/tools/launcher/Test7029048.java Reviewed-by: phh Backport-of: 8b87402a4409b345b820207dcd2aec720a23325b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/873 From goetz at openjdk.java.net Thu Mar 17 15:35:14 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 15:35:14 GMT Subject: [jdk11u-dev] RFR: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method Message-ID: I backport this for parity with 11.0.16-oracle. The change applies clean, but the new test requires XMLUtils.java. I include XMLUtils.java, which was introduced by "8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params"". I had to adapt a row on non Java 11 constructs. Also, I commented references to RSAPSSParameterSpec and and SignatureMethod.RSA_PSS which only come with 8241306. The code is not used by this test. I added an exception to make sure the code is not executed. ------------- Commit messages: - Backport 1f1db838ab7d427170d59a8b55fdb45c4d80c359 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/909/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=909&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278186 Stats: 646 lines in 4 files changed: 642 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/909.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/909/head:pull/909 PR: https://git.openjdk.java.net/jdk11u-dev/pull/909 From goetz at openjdk.java.net Thu Mar 17 15:39:53 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 15:39:53 GMT Subject: [jdk17u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() In-Reply-To: <4DpUi5DwcXjmaSojcPrnurkMU4kNYmZZujoAnzHcAAc=.b57f88b4-be53-4f82-8347-23168fea88e6@github.com> References: <4DpUi5DwcXjmaSojcPrnurkMU4kNYmZZujoAnzHcAAc=.b57f88b4-be53-4f82-8347-23168fea88e6@github.com> Message-ID: On Mon, 7 Feb 2022 22:06:12 GMT, Jonathan Dowland wrote: >> @jmtd This is a clean backport, you don't need code review. Please tag the bug for approval. > > @zhengyu123 thank you for your reply! I meant to get back to this one today. It is clean, but the original bug needed a CSR, so I believe I need to raise a CSR for the backport too. I just didn't get around to looking into that yet. Am I right? @jmtd, I'll handle this. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/147 From goetz at openjdk.java.net Thu Mar 17 15:42:13 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 15:42:13 GMT Subject: [jdk17u-dev] RFR: 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 91bb0d658bce010e74b248b56f0fa5b8a79e8802 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/261/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=261&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276796 Stats: 15 lines in 1 file changed: 7 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/261.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/261/head:pull/261 PR: https://git.openjdk.java.net/jdk17u-dev/pull/261 From rkennke at openjdk.java.net Thu Mar 17 15:53:32 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Thu, 17 Mar 2022 15:53:32 GMT Subject: [jdk11u-dev] RFR: 8277072: ObjectStreamClass caches keep ClassLoaders alive [v2] In-Reply-To: <40K8iorg2vcaPk5L8g16A7vwfZbMKvlBcYpCSqepT0s=.0e2479c1-7af0-4945-a9eb-63c98a6dac8b@github.com> References: <40K8iorg2vcaPk5L8g16A7vwfZbMKvlBcYpCSqepT0s=.0e2479c1-7af0-4945-a9eb-63c98a6dac8b@github.com> Message-ID: <1t6P-pT8JR-Oh84FdJ0Y44c7FigbJ0nMeTA1kTpW_8U=.59f91ca0-6639-4fa9-8593-ee282c41ccd5@github.com> > Hi all, > > This pull request contains a backport of commit [8eb453ba](https://github.com/openjdk/jdk/commit/8eb453baebe377697286f7eb32280ca9f1fd7775) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Roman Kennke on 10 Dec 2021 and was reviewed by Roger Riggs and Peter Levart. > > It fixes a memory leak in ObjectStreamClass under certain conditions. See bug for details. > The backport was not clean, there have been some rather minor differences in context. > > Thanks! Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: Fix usage of Reference.refersTo() in new test ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/869/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/869/files/054c7215..5ec1e0b8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=869&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=869&range=00-01 Stats: 7 lines in 1 file changed: 2 ins; 2 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/869.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/869/head:pull/869 PR: https://git.openjdk.java.net/jdk11u-dev/pull/869 From clanger at openjdk.java.net Thu Mar 17 16:14:51 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 17 Mar 2022 16:14:51 GMT Subject: [jdk17u] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 12:41:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > It's a clean backout of 8276141 Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17u/pull/337 From yan at openjdk.java.net Thu Mar 17 16:19:47 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Thu, 17 Mar 2022 16:19:47 GMT Subject: [jdk17u] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 12:41:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > It's a clean backout of 8276141 Marked as reviewed by yan (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17u/pull/337 From sgehwolf at openjdk.java.net Thu Mar 17 16:34:49 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 17 Mar 2022 16:34:49 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v7] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Wed, 16 Mar 2022 13:43:55 GMT, Zhengyu Gu wrote: >> This is a followup backport for Cgroup v2 support. >> >> The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. >> >> In additional: >> >> 1) Include partial backport of JDK-8250627. >> - Renamed `Metrics.c` => `CgroupMetrics.c` >> - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` >> - Return instance only if `isUseContainerSupport()` is enabled. >> >> 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test >> >> 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` >> >> Test: >> >> - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS > > Zhengyu Gu has updated the pull request incrementally with 50 additional commits since the last revision: > > - Merge branch 'master' into backport-8231111-unified-hierarchy > - 8265343: Update Debian-based cross-compilation recipes > > Reviewed-by: stuefe > Backport-of: 7879adbe88ec54b8f5ac9543d80142bc1b12112b > - Merge > - 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem > > Reviewed-by: mbaesken > Backport-of: 6aa02d75d9f26f46fbdb54aef52cea3257aa7462 > - 8281615: Deadlock caused by jdwp agent > > Backport-of: e1060bee2adb9f2e07ca09309d0f89132db30f28 > - 8266251: compiler.inlining.InlineAccessors shouldn't do testing in driver VM > > Backport-of: 9605aeddee70ba4f3dba2ae2a3d100319164b03d > - 8231565: More node budget asserts in fuzzed tests > > Backport-of: 902858e3ceb43bf92ea9fa038b9edcf1ee0c48b5 > - 8229499: Node budget assert in fuzzed test > > Reviewed-by: stuefe > Backport-of: 8275b17b07b1c15bde79b36b76ecbe3072db1e1a > - 8234605: C2 failed "assert(C->live_nodes() - live_at_begin <= 2 * _nodes_required) failed: Bad node estimate: actual = 208 >> request = 101" > > Backport-of: d19f2bdec01eb324d200f2144293d05ea310f9b8 > - 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed > > Reviewed-by: mdoerr > Backport-of: f5d36e6c9470b1ac5326990b1c4fea80457c4ad6 > - ... and 40 more: https://git.openjdk.java.net/jdk11u-dev/compare/191fbe46...7d276fe6 Something is wrong with this PR now. Says 376 changed files. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From goetz at openjdk.java.net Thu Mar 17 16:35:54 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 16:35:54 GMT Subject: [jdk17u] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 12:41:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > It's a clean backout of 8276141 Thanks for the quick reviews! ------------- PR: https://git.openjdk.java.net/jdk17u/pull/337 From goetz at openjdk.java.net Thu Mar 17 16:35:55 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 16:35:55 GMT Subject: [jdk17u] Integrated: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 12:41:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.3-oracle. > It's a clean backout of 8276141 This pull request has now been integrated. Changeset: c3ea7ca0 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u/commit/c3ea7ca00afc14c87082a7c798156a44e6d47af1 Stats: 59 lines in 2 files changed: 0 ins; 56 del; 3 mod 8282761: XPathFactoryImpl remove setProperty and getProperty methods Reviewed-by: clanger, yan ------------- PR: https://git.openjdk.java.net/jdk17u/pull/337 From zgu at openjdk.java.net Thu Mar 17 16:37:36 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Thu, 17 Mar 2022 16:37:36 GMT Subject: [jdk11u-dev] Integrated: 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 15:30:14 GMT, Zhengyu Gu wrote: > I would like to backport this patch to 11u for reducing noise on JDK-8231111. > > The original patch does not apply cleanly, due to out-of-order backport of JDK-8202142. > > Test: > > - [x] jdk_jfr > `EvilInstrument.java` test fails. Followup JDK-8230865 backport to fix it. This pull request has now been integrated. Changeset: 61355403 Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/613554035cd50eb4cb056b015c4243b9329e8b16 Stats: 51 lines in 11 files changed: 30 ins; 5 del; 16 mod 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp Using test utils to create temp files and directories Reviewed-by: sgehwolf Backport-of: 7d3aebccc0b90aa2ca2f656c683fa5931fd0ed3a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/901 From zgu at openjdk.java.net Thu Mar 17 16:43:50 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Thu, 17 Mar 2022 16:43:50 GMT Subject: [jdk11u-dev] RFR: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target [v2] In-Reply-To: References: Message-ID: > I would like to backport this patch to fix test failure, introduced by JDK-8223396. > > This is a clean backport on top of JDK-8223396 backport. > > Test: > - [x] jdk_jfr Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/903/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/903/files/7a2871ae..7a2871ae Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=903&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=903&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/903.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/903/head:pull/903 PR: https://git.openjdk.java.net/jdk11u-dev/pull/903 From duke at openjdk.java.net Thu Mar 17 16:43:51 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Thu, 17 Mar 2022 16:43:51 GMT Subject: [jdk11u-dev] RFR: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target In-Reply-To: References: Message-ID: <4vWLA7GmCRDlVze1aR8QF1uOjYEC25xe63g00NPuF0U=.58b72e1e-7c9b-416a-a3af-96961274bbdd@github.com> On Wed, 16 Mar 2022 15:45:18 GMT, Zhengyu Gu wrote: > I would like to backport this patch to fix test failure, introduced by JDK-8223396. > > This is a clean backport on top of JDK-8223396 backport. > > Test: > - [x] jdk_jfr The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backport-8223396-jfr-test git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/903 From zgu at openjdk.java.net Thu Mar 17 17:06:22 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Thu, 17 Mar 2022 17:06:22 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v8] In-Reply-To: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: > This is a followup backport for Cgroup v2 support. > > The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. > > In additional: > > 1) Include partial backport of JDK-8250627. > - Renamed `Metrics.c` => `CgroupMetrics.c` > - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` > - Return instance only if `isUseContainerSupport()` is enabled. > > 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test > > 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` > > Test: > > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS Zhengyu Gu has updated the pull request incrementally with eight additional commits since the last revision: - Merge - Merge branch 'master' into backport-8230305-cgroup-v2 - 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp Using test utils to create temp files and directories Reviewed-by: sgehwolf Backport-of: 7d3aebccc0b90aa2ca2f656c683fa5931fd0ed3a - 8247592: refactor test/jdk/tools/launcher/Test7029048.java Reviewed-by: phh Backport-of: 8b87402a4409b345b820207dcd2aec720a23325b - 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28 Backport-of: a8005efde388821e39e6464dbb17fbeac3c9830a - 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist! Reviewed-by: phh Backport-of: 6d7db4b0b3e9172645cef12c36fbeb41a6d38d83 - 8199874: [TESTBUG] runtime/Thread/ThreadPriorities.java fails with "expected 0 to equal 10" Backport-of: 0d9f615e9214ed6f1f69f6e7969e966005948eb3 - 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start Backport-of: 31cf8b1c65fb0b19e093547fc557fff55d7213bd ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/863/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/863/files/7d276fe6..3e4a0b42 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=07 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=06-07 Stats: 211 lines in 18 files changed: 92 ins; 64 del; 55 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/863/head:pull/863 PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From goetz at openjdk.java.net Thu Mar 17 17:30:17 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 17 Mar 2022 17:30:17 GMT Subject: [jdk17u-dev] RFR: 8278851: Correct signer logic for jars signed with multiple digestalgs Message-ID: I backport this for parity with 17.0.4-oracle. JarVerifier: resolve due to context. ManifestEntryVerifier.java: I had to remove an argument 'false' because "JDK-8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled" is not in 17. I had to add a hunk from "JDK-8269039: Disable SHA-1 Signed JARs" to SecurityUtils.java to make a method public that is called in a test. ------------- Commit messages: - Backport 61b8944327e3d12cf58dc3f6bc45ecbeba4ef611 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/262/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=262&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278851 Stats: 273 lines in 4 files changed: 221 ins; 20 del; 32 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/262.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/262/head:pull/262 PR: https://git.openjdk.java.net/jdk17u-dev/pull/262 From zgu at openjdk.java.net Thu Mar 17 17:36:12 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Thu, 17 Mar 2022 17:36:12 GMT Subject: [jdk11u-dev] RFR: 8230305: Cgroups v2: Container awareness [v2] In-Reply-To: References: Message-ID: > I would like backport cgroups v2 support to openjdk11u. > > The original patch does not apply cleanly, conflicts are resolved manually. > > Test: > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into backport-8230305-cgroup-v2 - Backport d462a6b5c9bd3dae5257cca42ea38c19cb742e3c ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/840/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/840/files/4749f095..ab03faaa Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=840&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=840&range=00-01 Stats: 7826 lines in 365 files changed: 3900 ins; 2785 del; 1141 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/840.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/840/head:pull/840 PR: https://git.openjdk.java.net/jdk11u-dev/pull/840 From andrew at openjdk.java.net Thu Mar 17 17:37:43 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Thu, 17 Mar 2022 17:37:43 GMT Subject: [jdk11u-dev] Integrated: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32 In-Reply-To: References: Message-ID: On Wed, 23 Feb 2022 17:05:59 GMT, Andrew John Hughes wrote: > The `slowdebug` build in 11u is broken in the same way as trunk was before this fix. We recently had to build 11u on x86_32 using Zero, due to issues with the new GCC 12 release, and the slowdebug build failed with this broken assert. Removing it allowed the build to complete. > > Backport is clean, but couldn't be automated as later JDK versions have the file in a `zero` subdirectory. > > Additional checks: > - [x] slowdebug build on x86_32 This pull request has now been integrated. Changeset: 73dc2225 Author: Andrew John Hughes URL: https://git.openjdk.java.net/jdk11u-dev/commit/73dc222557e11caa1f5999c0c4b346c25f3d62be Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32 Reviewed-by: phh Backport-of: df55ecd83c70e8962e9037671cd13b104d3e5620 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/839 From zgu at openjdk.java.net Thu Mar 17 17:40:09 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Thu, 17 Mar 2022 17:40:09 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v8] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Thu, 17 Mar 2022 17:06:22 GMT, Zhengyu Gu wrote: >> This is a followup backport for Cgroup v2 support. >> >> The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. >> >> In additional: >> >> 1) Include partial backport of JDK-8250627. >> - Renamed `Metrics.c` => `CgroupMetrics.c` >> - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` >> - Return instance only if `isUseContainerSupport()` is enabled. >> >> 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test >> >> 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` >> >> Test: >> >> - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS > > Zhengyu Gu has updated the pull request incrementally with eight additional commits since the last revision: > > - Merge > - Merge branch 'master' into backport-8230305-cgroup-v2 > - 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp > > Using test utils to create temp files and directories > > Reviewed-by: sgehwolf > Backport-of: 7d3aebccc0b90aa2ca2f656c683fa5931fd0ed3a > - 8247592: refactor test/jdk/tools/launcher/Test7029048.java > > Reviewed-by: phh > Backport-of: 8b87402a4409b345b820207dcd2aec720a23325b > - 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28 > > Backport-of: a8005efde388821e39e6464dbb17fbeac3c9830a > - 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist! > > Reviewed-by: phh > Backport-of: 6d7db4b0b3e9172645cef12c36fbeb41a6d38d83 > - 8199874: [TESTBUG] runtime/Thread/ThreadPriorities.java fails with "expected 0 to equal 10" > > Backport-of: 0d9f615e9214ed6f1f69f6e7969e966005948eb3 > - 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start > > Backport-of: 31cf8b1c65fb0b19e093547fc557fff55d7213bd > A few more fix-ups are needed (see also inline comments): > > 3. `PlainRead.java` would need to get the `-2` added as a "good" value. Like here: [openjdk/jdk at 01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48](https://github.com/openjdk/jdk/commit/01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48) It's part of the original JDK-8250984 fix, but wasn't part of the 11 backport when it was done. So we should add it with this backport. Even with this change, the test still failed. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From sgehwolf at openjdk.java.net Thu Mar 17 17:40:09 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Thu, 17 Mar 2022 17:40:09 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v8] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Thu, 17 Mar 2022 17:33:27 GMT, Zhengyu Gu wrote: > > A few more fix-ups are needed (see also inline comments): > > > 3. `PlainRead.java` would need to get the `-2` added as a "good" value. Like here: [openjdk/jdk at 01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48](https://github.com/openjdk/jdk/commit/01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48) It's part of the original JDK-8250984 fix, but wasn't part of the 11 backport when it was done. So we should add it with this backport. > > Even with this change, the test still failed. Right. See: https://github.com/openjdk/jdk11u-dev/pull/840#issuecomment-1067065313 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From zgu at openjdk.java.net Thu Mar 17 17:40:06 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Thu, 17 Mar 2022 17:40:06 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v9] In-Reply-To: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: > This is a followup backport for Cgroup v2 support. > > The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. > > In additional: > > 1) Include partial backport of JDK-8250627. > - Renamed `Metrics.c` => `CgroupMetrics.c` > - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` > - Return instance only if `isUseContainerSupport()` is enabled. > > 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test > > 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` > > Test: > > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - Merge - Merge - Merge branch 'master' into backport-8231111-unified-hierarchy - Fixes - Fix MetricsTesterCgroupV1 - More fixes - Fix indents and whitespaces - Redo CgroupV1Subsystem.java merge - Severin's comments - 2 - Severin's comments - ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/ab03faaa...171d73f7 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/863/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=863&range=08 Stats: 5351 lines in 31 files changed: 3618 ins; 1599 del; 134 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/863/head:pull/863 PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From vkempik at openjdk.java.net Thu Mar 17 18:50:38 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 17 Mar 2022 18:50:38 GMT Subject: [jdk17u-dev] Integrated: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang In-Reply-To: References: Message-ID: <-GOLaXWNHz5KXUiXU85KUHK4fpYN5ZC-R67urzhZqso=.583cb29f-f358-4880-93f4-301d64f1045b@github.com> On Wed, 16 Mar 2022 13:04:49 GMT, Vladimir Kempik wrote: > Clean Backport to jdk17u-dev This pull request has now been integrated. Changeset: fbe05ec5 Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk17u-dev/commit/fbe05ec561e8d2a061be126c969c37c219b594f3 Stats: 11 lines in 1 file changed: 10 ins; 1 del; 0 mod 8280476: [macOS] : hotspot arm64 bug exposed by latest clang Backport-of: f5d6fddc6df8c5c5456a2544b131833d5227292b ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/259 From vkempik at openjdk.java.net Thu Mar 17 18:50:34 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Thu, 17 Mar 2022 18:50:34 GMT Subject: [jdk11u-dev] Integrated: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 13:05:37 GMT, Vladimir Kempik wrote: > Clean backport to jdk11u-dev This pull request has now been integrated. Changeset: b42dd744 Author: Vladimir Kempik URL: https://git.openjdk.java.net/jdk11u-dev/commit/b42dd7440523072f321da9c80d9c6471357d7e3d Stats: 11 lines in 1 file changed: 10 ins; 1 del; 0 mod 8280476: [macOS] : hotspot arm64 bug exposed by latest clang Backport-of: f5d6fddc6df8c5c5456a2544b131833d5227292b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/897 From avoitylov at openjdk.java.net Thu Mar 17 20:50:55 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 17 Mar 2022 20:50:55 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port Message-ID: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. Original changeset does not apply cleanly because of: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, 8215445: Enable building for Windows in WSL 8257913: Add more known library locations to simplify Linux cross-compilation 8244592: Start supporting SOURCE_DATE_EPOCH 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html ------------- Commit messages: - JDK-8247589 backport to 11u Changes: https://git.openjdk.java.net/jdk11u-dev/pull/910/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=910&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8247589 Stats: 400 lines in 29 files changed: 347 ins; 17 del; 36 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/910.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/910/head:pull/910 PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From avoitylov at openjdk.java.net Thu Mar 17 20:54:51 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 17 Mar 2022 20:54:51 GMT Subject: [jdk11u-dev] RFR: 8247591: Document Alpine Linux build steps in OpenJDK build guide Message-ID: JDK-8247591 is in the docs issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. Original changeset does not apply cleanly because of: 8220164: Fix build instructions for AIX 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html ------------- Commit messages: - JDK-8247591 backport to 11u Changes: https://git.openjdk.java.net/jdk11u-dev/pull/911/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=911&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8247591 Stats: 51 lines in 2 files changed: 51 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/911.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/911/head:pull/911 PR: https://git.openjdk.java.net/jdk11u-dev/pull/911 From zgu at openjdk.java.net Thu Mar 17 21:03:36 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Thu, 17 Mar 2022 21:03:36 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v9] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: <-GqFZ64AXU31jyeCbwJgojdtBx_yeQi7AeZcAEtqHms=.da92e0e0-d602-4cda-9585-eb62c95b5a5f@github.com> On Thu, 17 Mar 2022 17:40:06 GMT, Zhengyu Gu wrote: >> This is a followup backport for Cgroup v2 support. >> >> The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. >> >> In additional: >> >> 1) Include partial backport of JDK-8250627. >> - Renamed `Metrics.c` => `CgroupMetrics.c` >> - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` >> - Return instance only if `isUseContainerSupport()` is enabled. >> >> 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test >> >> 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` >> >> Test: >> >> - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS > > Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: > > - Merge > - Merge > - Merge branch 'master' into backport-8231111-unified-hierarchy > - Fixes > - Fix MetricsTesterCgroupV1 > - More fixes > - Fix indents and whitespaces > - Redo CgroupV1Subsystem.java merge > - Severin's comments - 2 > - Severin's comments > - ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/ab03faaa...171d73f7 > > > A few more fix-ups are needed (see also inline comments): > > > > 3. `PlainRead.java` would need to get the `-2` added as a "good" value. Like here: [openjdk/jdk at 01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48](https://github.com/openjdk/jdk/commit/01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48) It's part of the original JDK-8250984 fix, but wasn't part of the 11 backport when it was done. So we should add it with this backport. > > > > > > Even with this change, the test still failed. > > Right. See: [#840 (comment)](https://github.com/openjdk/jdk11u-dev/pull/840#issuecomment-1067065313) Okay. It does not fix the test, I don't think we should include it in this patch, I would prefer to fix it separately. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From mdoerr at openjdk.java.net Thu Mar 17 21:12:33 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 17 Mar 2022 21:12:33 GMT Subject: [jdk11u-dev] RFR: 8229486: Replace wildcard address with loopback or local host in tests - part 21 In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 15:41:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > TcpKeepAliveTest.java does not apply because > 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 f... > is missing > > SetIfModifiedSince.java does not apply because > 8226756: Replace wildcard address with loopback or local host in tests - part 18 > is missing. > > I included the respective previous changes to these two files in this patch. Backporting these larger > dependencies will cause recursive backports or require resolving. I want to avoid this additional > effort. In case backports of these other changes are necessary later, one will just have to > skip the patches to the corresponding files. As the changes are quite simple, this should > be easy enough to do. For reference: parts of these changes were integrated: https://github.com/openjdk/jdk/commit/ef9ce3be1e33f1a45a6d8fbcbe3d4ceffcf7c4ce https://github.com/openjdk/jdk/commit/76785af549f94d0a46dee6dc85933c4e2c7b126e ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/902 From mdoerr at openjdk.java.net Thu Mar 17 21:22:34 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 17 Mar 2022 21:22:34 GMT Subject: [jdk11u-dev] RFR: 8229486: Replace wildcard address with loopback or local host in tests - part 21 In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 15:41:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > TcpKeepAliveTest.java does not apply because > 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 f... > is missing > > SetIfModifiedSince.java does not apply because > 8226756: Replace wildcard address with loopback or local host in tests - part 18 > is missing. > > I included the respective previous changes to these two files in this patch. Backporting these larger > dependencies will cause recursive backports or require resolving. I want to avoid this additional > effort. In case backports of these other changes are necessary later, one will just have to > skip the patches to the corresponding files. As the changes are quite simple, this should > be easy enough to do. Taking these parts makes sense IMHO. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/902 From mdoerr at openjdk.java.net Thu Mar 17 21:35:30 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 17 Mar 2022 21:35:30 GMT Subject: [jdk11u-dev] RFR: 8274233: Minor cleanup for ToolBox In-Reply-To: <9xgChbUDTt--TMNrBkk6c0Zf4CMO-hb3LrLdcfXWWZs=.09ce0d97-3707-49aa-95ed-1e7c0c93bc4b@github.com> References: <9xgChbUDTt--TMNrBkk6c0Zf4CMO-hb3LrLdcfXWWZs=.09ce0d97-3707-49aa-95ed-1e7c0c93bc4b@github.com> Message-ID: On Thu, 17 Mar 2022 08:22:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to resolve some comment changes because previous changes are missing. > They are formatting changes, so pretty pointless. > One code block had to be resolved because of context changes. Ok. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/907 From goetz at openjdk.java.net Fri Mar 18 06:50:27 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 06:50:27 GMT Subject: [jdk11u-dev] Integrated: 8241707: introduce randomness k/w to hotspot test suite In-Reply-To: <776Hw1_pRJvV8LkXBFXf1xEcAVDNGguuJLSiQUJKl_k=.98fe1017-3802-47ef-9c8a-b67080893272@github.com> References: <776Hw1_pRJvV8LkXBFXf1xEcAVDNGguuJLSiQUJKl_k=.98fe1017-3802-47ef-9c8a-b67080893272@github.com> Message-ID: On Thu, 17 Mar 2022 07:54:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: dfcef298 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/dfcef29870988e231fbb523bd8acfaffdadd1c89 Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod 8241707: introduce randomness k/w to hotspot test suite Backport-of: 0eb72d4e7485b837c5690ac1c892a546e1554802 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/905 From goetz at openjdk.java.net Fri Mar 18 06:50:26 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 06:50:26 GMT Subject: [jdk11u-dev] RFR: 8241707: introduce randomness k/w to hotspot test suite In-Reply-To: <776Hw1_pRJvV8LkXBFXf1xEcAVDNGguuJLSiQUJKl_k=.98fe1017-3802-47ef-9c8a-b67080893272@github.com> References: <776Hw1_pRJvV8LkXBFXf1xEcAVDNGguuJLSiQUJKl_k=.98fe1017-3802-47ef-9c8a-b67080893272@github.com> Message-ID: On Thu, 17 Mar 2022 07:54:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Pre-submit failures runtime/Thread/StopAtExit.java fixed in jdk111u gc/metaspace/TestMetaspacePerfCounters.java#id1 sporadic failure, unrelated ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/905 From goetz at openjdk.java.net Fri Mar 18 06:55:26 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 06:55:26 GMT Subject: [jdk11u-dev] RFR: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 13:56:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > The change applies clean, but the new test requires XMLUtils.java. > I include XMLUtils.java, which was introduced by > "8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params"". > I had to adapt a row on non Java 11 constructs. > Also, I commented references to RSAPSSParameterSpec and > and SignatureMethod.RSA_PSS which only come with 8241306. > The code is not used by this test. I added an exception > to make sure the code is not executed. Pre-submit failure: infrastructure problem: Error: Internal Server Error. Internal Server Error ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/909 From goetz at openjdk.java.net Fri Mar 18 06:55:28 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 06:55:28 GMT Subject: [jdk11u-dev] RFR: 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch In-Reply-To: References: Message-ID: <4EOrzrlbRjsAVpyfhhw01LH3ChITUc0fOZs2SuDxdi4=.6fa0f1a0-f5b7-428b-9ef1-2d0105ba48f1@github.com> On Thu, 17 Mar 2022 09:18:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Pre-submit failuter: fixed in jdk11u ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/908 From goetz at openjdk.java.net Fri Mar 18 06:55:28 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 06:55:28 GMT Subject: [jdk11u-dev] Integrated: 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 09:18:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: dbd14f7b Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/dbd14f7b2c023200e6d8c9ec3a7a8f07a3ea9613 Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch Backport-of: ad1ff27b730773a141d73744e5f5a899bdfbea78 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/908 From goetz at openjdk.java.net Fri Mar 18 06:58:38 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 06:58:38 GMT Subject: [jdk17u-dev] Integrated: 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 15:32:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 32148d26 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/32148d26432dea0dfcced9d6afb8214d69184ad9 Stats: 15 lines in 1 file changed: 7 ins; 0 del; 8 mod 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC Backport-of: 91bb0d658bce010e74b248b56f0fa5b8a79e8802 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/261 From goetz at openjdk.java.net Fri Mar 18 07:12:56 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 07:12:56 GMT Subject: [jdk11u-dev] RFR: 8215544: SA: Modify ClhsdbLauncher to add sudo privileges to enable MacOS tests on Mach5 Message-ID: <9Mhlfua-qGyHPA6L6c5Vhu_LyiKkXx2Qr4bCFDISZ4k=.3f0f3876-9e5b-42bf-8531-376666145fbf@github.com> I backport this to improve mac testing and to fix a test failure. ------------- Commit messages: - Backport 86fcd475b1227cff0fc9f9557f542ca6bd3abfe0 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/912/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=912&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8215544 Stats: 116 lines in 4 files changed: 99 ins; 8 del; 9 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/912.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/912/head:pull/912 PR: https://git.openjdk.java.net/jdk11u-dev/pull/912 From goetz at openjdk.java.net Fri Mar 18 07:31:54 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 07:31:54 GMT Subject: [jdk11u-dev] RFR: 8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers Message-ID: I backport this to improve testing and to fix the test bug in ClhsdbRegionDetailsScanOopsForG1.java. I had to resolve the imports in the following files: test/hotspot/jtreg/serviceability/sa/ClhsdbJstack.java test/hotspot/jtreg/serviceability/sa/ClhsdbPmap.java test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java test/hotspot/jtreg/serviceability/sa/ClhsdbPstack.java test/hotspot/jtreg/serviceability/sa/ClhsdbWhere.java The hunk to ClhsdbRegionDetailsScanOopsForG1.java is left out. The hunk was included accidentially when the test was move to resourcehogs. This is also the cause of the failure of this test. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/912 Commit messages: - Backport 55369945b94003e96c841e5969add992a86c0156 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/913/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=913&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8217473 Stats: 111 lines in 20 files changed: 50 ins; 43 del; 18 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/913.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/913/head:pull/913 PR: https://git.openjdk.java.net/jdk11u-dev/pull/913 From mbaesken at openjdk.java.net Fri Mar 18 08:35:42 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Fri, 18 Mar 2022 08:35:42 GMT Subject: [jdk17u-dev] RFR: 8278851: Correct signer logic for jars signed with multiple digestalgs In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 17:23:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. > > JarVerifier: resolve due to context. > ManifestEntryVerifier.java: I had to remove an argument 'false' because "JDK-8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled" is not in 17. > > I had to add a hunk from "JDK-8269039: Disable SHA-1 Signed JARs" to > SecurityUtils.java to make a method public that is called in a test. LGTM ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/262 From yan at openjdk.java.net Fri Mar 18 08:37:24 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Fri, 18 Mar 2022 08:37:24 GMT Subject: [jdk13u-dev] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods Message-ID: Clean rollback of JDK-8276141; relevant tests do pass. We have a day before the team repository closed, so targeted there. ------------- Commit messages: - 8282761: XPathFactoryImpl remove setProperty and getProperty methods Changes: https://git.openjdk.java.net/jdk13u-dev/pull/330/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=330&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282761 Stats: 58 lines in 2 files changed: 0 ins; 56 del; 2 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/330.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/330/head:pull/330 PR: https://git.openjdk.java.net/jdk13u-dev/pull/330 From goetz at openjdk.java.net Fri Mar 18 08:43:00 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 08:43:00 GMT Subject: [jdk11u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() Message-ID: I backport this for parity with 11.0.16-oracle. It does not apply because "8267587: Update java.util to use enhanced switch" is not in 11. I removed the new switch constructs from the code. ------------- Commit messages: - Backport 1e9ed54d362b8c57be5fbbac2de5afbd0f05435f Changes: https://git.openjdk.java.net/jdk11u-dev/pull/914/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=914&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8193682 Stats: 257 lines in 4 files changed: 189 ins; 25 del; 43 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/914.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/914/head:pull/914 PR: https://git.openjdk.java.net/jdk11u-dev/pull/914 From clanger at openjdk.java.net Fri Mar 18 08:56:52 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 18 Mar 2022 08:56:52 GMT Subject: [jdk11u-dev] RFR: 8240734: ModuleHashes attribute not reproducible between builds Message-ID: 8240734: ModuleHashes attribute not reproducible between builds This is a clean backport of JDK-8240734. I'm backporting this as a predecessor of JDK-8243666. ------------- Commit messages: - 8240734: ModuleHashes attribute not reproducible between builds Changes: https://git.openjdk.java.net/jdk11u-dev/pull/915/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=915&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8240734 Stats: 6 lines in 2 files changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/915.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/915/head:pull/915 PR: https://git.openjdk.java.net/jdk11u-dev/pull/915 From goetz at openjdk.java.net Fri Mar 18 08:57:23 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 08:57:23 GMT Subject: [jdk17u-dev] RFR: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND Message-ID: I think this is a useful backport of a bugfix for 17u. ------------- Commit messages: - Backport e3243ee963d074c892a0ed16a00fd91b440c96ac Changes: https://git.openjdk.java.net/jdk17u-dev/pull/263/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=263&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277087 Stats: 117 lines in 2 files changed: 114 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/263.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/263/head:pull/263 PR: https://git.openjdk.java.net/jdk17u-dev/pull/263 From yan at openjdk.java.net Fri Mar 18 09:07:10 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Fri, 18 Mar 2022 09:07:10 GMT Subject: [jdk15u-dev] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods Message-ID: rollback of JDK-8276141; relevant tests do pass. We have a day before the team repository closed, so targeted there. ------------- Commit messages: - 8282761: XPathFactoryImpl remove setProperty and getProperty methods Changes: https://git.openjdk.java.net/jdk15u-dev/pull/184/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=184&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282761 Stats: 58 lines in 2 files changed: 0 ins; 56 del; 2 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/184.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/184/head:pull/184 PR: https://git.openjdk.java.net/jdk15u-dev/pull/184 From goetz at openjdk.java.net Fri Mar 18 09:10:10 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 09:10:10 GMT Subject: [jdk17u-dev] RFR: 8279227: Access Bridge: Wrong frame position and hit test result on HiDPI display Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 20ef954158bc5a339118640946b39047fe853ae4 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/264/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=264&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279227 Stats: 185 lines in 1 file changed: 185 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/264.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/264/head:pull/264 PR: https://git.openjdk.java.net/jdk17u-dev/pull/264 From goetz at openjdk.java.net Fri Mar 18 09:16:08 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 09:16:08 GMT Subject: [jdk17u-dev] RFR: 8280401: [sspi] gss_accept_sec_context leaves output_token uninitialized Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 6352c020c25f2701afb4fabee0cc7fcef2d407fb Changes: https://git.openjdk.java.net/jdk17u-dev/pull/265/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=265&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280401 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/265.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/265/head:pull/265 PR: https://git.openjdk.java.net/jdk17u-dev/pull/265 From clanger at openjdk.java.net Fri Mar 18 09:21:02 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 18 Mar 2022 09:21:02 GMT Subject: [jdk11u-dev] RFR: 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps Message-ID: Clean backport, only resolved one copyright header diff. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/915 Commit messages: - 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps Changes: https://git.openjdk.java.net/jdk11u-dev/pull/916/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=916&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8243666 Stats: 189 lines in 5 files changed: 129 ins; 21 del; 39 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/916.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/916/head:pull/916 PR: https://git.openjdk.java.net/jdk11u-dev/pull/916 From goetz at openjdk.java.net Fri Mar 18 09:23:30 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 09:23:30 GMT Subject: [jdk13u-dev] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 08:30:53 GMT, Yuri Nesterenko wrote: > Clean rollback of JDK-8276141; relevant tests do pass. We have a day before the team repository closed, so targeted there. A clean backout of 8276141. LGTM ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.java.net/jdk13u-dev/pull/330 From goetz at openjdk.java.net Fri Mar 18 09:23:50 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 09:23:50 GMT Subject: [jdk15u-dev] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 09:01:03 GMT, Yuri Nesterenko wrote: > rollback of JDK-8276141; relevant tests do pass. We have a day before the team repository closed, so targeted there. A clean backout of 8276141. LGTM ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.java.net/jdk15u-dev/pull/184 From yan at openjdk.java.net Fri Mar 18 09:36:46 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Fri, 18 Mar 2022 09:36:46 GMT Subject: [jdk13u-dev] Integrated: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 08:30:53 GMT, Yuri Nesterenko wrote: > Clean rollback of JDK-8276141; relevant tests do pass. We have a day before the team repository closed, so targeted there. This pull request has now been integrated. Changeset: 67dd8915 Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk13u-dev/commit/67dd89154a5a8bd4661101d8d97e8b249063cca6 Stats: 58 lines in 2 files changed: 0 ins; 56 del; 2 mod 8282761: XPathFactoryImpl remove setProperty and getProperty methods Reviewed-by: goetz ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/330 From yan at openjdk.java.net Fri Mar 18 09:38:50 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Fri, 18 Mar 2022 09:38:50 GMT Subject: [jdk15u-dev] Integrated: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: <7G1t97k-w4TR44k487eWkqNiWfc6LEqFyBYg1QGkDdw=.a4dce9bb-54eb-4791-8e2e-6d1b95a2978a@github.com> On Fri, 18 Mar 2022 09:01:03 GMT, Yuri Nesterenko wrote: > rollback of JDK-8276141; relevant tests do pass. We have a day before the team repository closed, so targeted there. This pull request has now been integrated. Changeset: 5ef77dea Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk15u-dev/commit/5ef77dea5cb49548af8473188259ea8b15301dff Stats: 58 lines in 2 files changed: 0 ins; 56 del; 2 mod 8282761: XPathFactoryImpl remove setProperty and getProperty methods Reviewed-by: goetz ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/184 From sgehwolf at openjdk.java.net Fri Mar 18 09:59:39 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 18 Mar 2022 09:59:39 GMT Subject: [jdk11u-dev] RFR: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target [v2] In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 16:43:50 GMT, Zhengyu Gu wrote: >> I would like to backport this patch to fix test failure, introduced by JDK-8223396. >> >> This is a clean backport on top of JDK-8223396 backport. >> >> Test: >> - [x] jdk_jfr > > Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. @zhengyu123 Please follow the steps in comment https://github.com/openjdk/jdk11u-dev/pull/903#issuecomment-1071063082 so as to make this a clean backport again. Then integration should work. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/903 From goetz at openjdk.java.net Fri Mar 18 10:15:15 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 10:15:15 GMT Subject: [jdk11u] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods Message-ID: I backport this for parity with 11.0.15-oracle. ------------- Commit messages: - Backport 67dd89154a5a8bd4661101d8d97e8b249063cca6 Changes: https://git.openjdk.java.net/jdk11u/pull/32/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=32&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282761 Stats: 58 lines in 2 files changed: 0 ins; 56 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u/pull/32.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/32/head:pull/32 PR: https://git.openjdk.java.net/jdk11u/pull/32 From mdoerr at openjdk.java.net Fri Mar 18 10:21:38 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 18 Mar 2022 10:21:38 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) [v2] In-Reply-To: <7OIKCPioWCLbgTMTHMYOjKKRopckOACgX5g7-cnibhk=.ebdb4fda-4028-4b92-a7ce-a9361b172310@github.com> References: <7OIKCPioWCLbgTMTHMYOjKKRopckOACgX5g7-cnibhk=.ebdb4fda-4028-4b92-a7ce-a9361b172310@github.com> Message-ID: On Thu, 17 Mar 2022 02:00:19 GMT, Basil Crow wrote: >> Hi all, >> >> This pull request contains a clean backport of commit [44ae643b2b4](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. >> >> The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. >> >> See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. >> >> Thanks! > > Basil Crow has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) > > Summary: Do not clean trees after last round of annotation processing, if the trees won't be re-entered again. > > Reviewed-by: vromero > Backport-of: 44ae643b2b49b66b1fff4c151c17972c6b683cc0 This PR is not recognized as backport. I suggest to change the title to "Backport 44ae643b2b49b66b1fff4c151c17972c6b683cc0" and let the Skara Bot do the work. You will also have to request "jdk11u-fix-request" approval (see https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/855 From mdoerr at openjdk.java.net Fri Mar 18 10:41:32 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 18 Mar 2022 10:41:32 GMT Subject: [jdk11u-dev] RFR: 8277072: ObjectStreamClass caches keep ClassLoaders alive [v2] In-Reply-To: <1t6P-pT8JR-Oh84FdJ0Y44c7FigbJ0nMeTA1kTpW_8U=.59f91ca0-6639-4fa9-8593-ee282c41ccd5@github.com> References: <40K8iorg2vcaPk5L8g16A7vwfZbMKvlBcYpCSqepT0s=.0e2479c1-7af0-4945-a9eb-63c98a6dac8b@github.com> <1t6P-pT8JR-Oh84FdJ0Y44c7FigbJ0nMeTA1kTpW_8U=.59f91ca0-6639-4fa9-8593-ee282c41ccd5@github.com> Message-ID: On Thu, 17 Mar 2022 15:53:32 GMT, Roman Kennke wrote: >> Hi all, >> >> This pull request contains a backport of commit [8eb453ba](https://github.com/openjdk/jdk/commit/8eb453baebe377697286f7eb32280ca9f1fd7775) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. >> >> The commit being backported was authored by Roman Kennke on 10 Dec 2021 and was reviewed by Roger Riggs and Peter Levart. >> >> It fixes a memory leak in ObjectStreamClass under certain conditions. See bug for details. >> The backport was not clean, there have been some rather minor differences in context. >> >> Thanks! > > Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: > > Fix usage of Reference.refersTo() in new test LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/869 From mdoerr at openjdk.java.net Fri Mar 18 11:01:39 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 18 Mar 2022 11:01:39 GMT Subject: [jdk11u-dev] RFR: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 13:56:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > The change applies clean, but the new test requires XMLUtils.java. > I include XMLUtils.java, which was introduced by > "8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params"". > I had to adapt a row on non Java 11 constructs. > Also, I commented references to RSAPSSParameterSpec and > and SignatureMethod.RSA_PSS which only come with 8241306. > The code is not used by this test. I added an exception > to make sure the code is not executed. For reference: XMLUtils.java was taken from https://github.com/openjdk/jdk/commit/8dbf7aa1f92fec56564d2a2a68ffa3da96b6795c ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/909 From mdoerr at openjdk.java.net Fri Mar 18 11:10:31 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 18 Mar 2022 11:10:31 GMT Subject: [jdk11u-dev] RFR: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 13:56:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > The change applies clean, but the new test requires XMLUtils.java. > I include XMLUtils.java, which was introduced by > "8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params"". > I had to adapt a row on non Java 11 constructs. > Also, I commented references to RSAPSSParameterSpec and > and SignatureMethod.RSA_PSS which only come with 8241306. > The code is not used by this test. I added an exception > to make sure the code is not executed. Adaptations for 11u look correct. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/909 From mdoerr at openjdk.java.net Fri Mar 18 11:21:39 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 18 Mar 2022 11:21:39 GMT Subject: [jdk11u-dev] RFR: 8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 07:24:20 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing and to fix the test bug in ClhsdbRegionDetailsScanOopsForG1.java. > > I had to resolve the imports in the following files: > > test/hotspot/jtreg/serviceability/sa/ClhsdbJstack.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPmap.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPstack.java > test/hotspot/jtreg/serviceability/sa/ClhsdbWhere.java > > The hunk to ClhsdbRegionDetailsScanOopsForG1.java is left out. > The hunk was included accidentially when the test was move to resourcehogs. > This is also the cause of the failure of this test. Marked as reviewed by mdoerr (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/913 From mdoerr at openjdk.java.net Fri Mar 18 11:32:31 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 18 Mar 2022 11:32:31 GMT Subject: [jdk11u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() In-Reply-To: References: Message-ID: <4dcycf3wxSYl4f8u13V48sjeZ-q_89w2g6MMcnebDx0=.953720a0-7326-4519-8e88-536d0af9de18@github.com> On Fri, 18 Mar 2022 08:35:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > > It does not apply because "8267587: Update java.util to use enhanced switch" > is not in 11. I removed the new switch constructs from the code. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/914 From goetz at openjdk.java.net Fri Mar 18 12:26:46 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:26:46 GMT Subject: [jdk17u-dev] Integrated: 8278851: Correct signer logic for jars signed with multiple digestalgs In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 17:23:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. > > JarVerifier: resolve due to context. > ManifestEntryVerifier.java: I had to remove an argument 'false' because "JDK-8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled" is not in 17. > > I had to add a hunk from "JDK-8269039: Disable SHA-1 Signed JARs" to > SecurityUtils.java to make a method public that is called in a test. This pull request has now been integrated. Changeset: cbe49739 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/cbe497394786ff76a09f9743040e3ba96ee8298f Stats: 273 lines in 4 files changed: 221 ins; 20 del; 32 mod 8278851: Correct signer logic for jars signed with multiple digestalgs Reviewed-by: mbaesken Backport-of: 61b8944327e3d12cf58dc3f6bc45ecbeba4ef611 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/262 From goetz at openjdk.java.net Fri Mar 18 12:34:36 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:34:36 GMT Subject: [jdk11u-dev] RFR: 8229486: Replace wildcard address with loopback or local host in tests - part 21 In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 15:41:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > TcpKeepAliveTest.java does not apply because > 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 f... > is missing > > SetIfModifiedSince.java does not apply because > 8226756: Replace wildcard address with loopback or local host in tests - part 18 > is missing. > > I included the respective previous changes to these two files in this patch. Backporting these larger > dependencies will cause recursive backports or require resolving. I want to avoid this additional > effort. In case backports of these other changes are necessary later, one will just have to > skip the patches to the corresponding files. As the changes are quite simple, this should > be easy enough to do. Pre-submit failure: runtime/Thread/StopAtExit.java fixed in jdk11u Thanks for the reivew ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/902 From goetz at openjdk.java.net Fri Mar 18 12:34:37 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:34:37 GMT Subject: [jdk11u-dev] RFR: 8231489: GC watermark_0_1 failed due to "metaspace.gc.Fault: GC has happened too rare" In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 07:45:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Pre-submit failure: runtime/Thread/StopAtExit.java fixed in jdk11u ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/904 From goetz at openjdk.java.net Fri Mar 18 12:34:36 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:34:36 GMT Subject: [jdk11u-dev] Integrated: 8229486: Replace wildcard address with loopback or local host in tests - part 21 In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 15:41:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > TcpKeepAliveTest.java does not apply because > 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 f... > is missing > > SetIfModifiedSince.java does not apply because > 8226756: Replace wildcard address with loopback or local host in tests - part 18 > is missing. > > I included the respective previous changes to these two files in this patch. Backporting these larger > dependencies will cause recursive backports or require resolving. I want to avoid this additional > effort. In case backports of these other changes are necessary later, one will just have to > skip the patches to the corresponding files. As the changes are quite simple, this should > be easy enough to do. This pull request has now been integrated. Changeset: 306d8633 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/306d863343d9cecf9d810ab1f793c83929f708bb Stats: 242 lines in 11 files changed: 155 ins; 11 del; 76 mod 8229486: Replace wildcard address with loopback or local host in tests - part 21 Reviewed-by: mdoerr Backport-of: 77d09f0f14bdaafa2e3528c73ee2287338e2ad49 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/902 From goetz at openjdk.java.net Fri Mar 18 12:34:37 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:34:37 GMT Subject: [jdk11u-dev] Integrated: 8231489: GC watermark_0_1 failed due to "metaspace.gc.Fault: GC has happened too rare" In-Reply-To: References: Message-ID: <7tIILN8YlIoTm9JHovwix7aXf7VdkRcrN1HlbkSkApk=.45193ace-da4b-4cf6-82e0-af1ddbd8b63f@github.com> On Thu, 17 Mar 2022 07:45:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: d2671718 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/d267171850a28191c8d19caad170ff094495754c Stats: 33 lines in 6 files changed: 21 ins; 7 del; 5 mod 8231489: GC watermark_0_1 failed due to "metaspace.gc.Fault: GC has happened too rare" Backport-of: 9e17946ab21434df0f6780423f7998166265af2a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/904 From goetz at openjdk.java.net Fri Mar 18 12:35:33 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:35:33 GMT Subject: [jdk11u-dev] Integrated: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support In-Reply-To: <8Kc8Ah7DYFo3bKN7ZbZgfTf-2P8TZ-4DkyScvEzrxIU=.3e9108db-2efc-48f9-8f71-bed84e0e46ea@github.com> References: <8Kc8Ah7DYFo3bKN7ZbZgfTf-2P8TZ-4DkyScvEzrxIU=.3e9108db-2efc-48f9-8f71-bed84e0e46ea@github.com> Message-ID: On Thu, 17 Mar 2022 08:05:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: 269114b6 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/269114b6b4ac6079b72424e058d5da2e0a2995c2 Stats: 27 lines in 1 file changed: 15 ins; 0 del; 12 mod 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support Backport-of: 6346793c6401b3758edf0a8912acb0fd8813957b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/906 From goetz at openjdk.java.net Fri Mar 18 12:38:42 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:38:42 GMT Subject: [jdk11u-dev] Integrated: 8274233: Minor cleanup for ToolBox In-Reply-To: <9xgChbUDTt--TMNrBkk6c0Zf4CMO-hb3LrLdcfXWWZs=.09ce0d97-3707-49aa-95ed-1e7c0c93bc4b@github.com> References: <9xgChbUDTt--TMNrBkk6c0Zf4CMO-hb3LrLdcfXWWZs=.09ce0d97-3707-49aa-95ed-1e7c0c93bc4b@github.com> Message-ID: On Thu, 17 Mar 2022 08:22:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to resolve some comment changes because previous changes are missing. > They are formatting changes, so pretty pointless. > One code block had to be resolved because of context changes. This pull request has now been integrated. Changeset: a3af00c0 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/a3af00c03fca0d663161308b140e9087ad2b346e Stats: 107 lines in 1 file changed: 45 ins; 12 del; 50 mod 8274233: Minor cleanup for ToolBox Reviewed-by: mdoerr Backport-of: e741a18062061c1959f7881503aaf3a4cbcae776 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/907 From goetz at openjdk.java.net Fri Mar 18 12:39:36 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:39:36 GMT Subject: [jdk11u-dev] Integrated: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 13:56:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > The change applies clean, but the new test requires XMLUtils.java. > I include XMLUtils.java, which was introduced by > "8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params"". > I had to adapt a row on non Java 11 constructs. > Also, I commented references to RSAPSSParameterSpec and > and SignatureMethod.RSA_PSS which only come with 8241306. > The code is not used by this test. I added an exception > to make sure the code is not executed. This pull request has now been integrated. Changeset: 63db1bf6 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/63db1bf6ee7a7bab61ea879a55862821add7c79f Stats: 646 lines in 4 files changed: 642 ins; 0 del; 4 mod 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method Reviewed-by: mdoerr Backport-of: 1f1db838ab7d427170d59a8b55fdb45c4d80c359 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/909 From goetz at openjdk.java.net Fri Mar 18 12:46:34 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:46:34 GMT Subject: [jdk11u-dev] RFR: 8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 07:24:20 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing and to fix the test bug in ClhsdbRegionDetailsScanOopsForG1.java. > > I had to resolve the imports in the following files: > > test/hotspot/jtreg/serviceability/sa/ClhsdbJstack.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPmap.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPstack.java > test/hotspot/jtreg/serviceability/sa/ClhsdbWhere.java > > The hunk to ClhsdbRegionDetailsScanOopsForG1.java is left out. > The hunk was included accidentially when the test was move to resourcehogs. > This is also the cause of the failure of this test. Pre-submit failure: runtime/Thread/StopAtExit.java fixed in jdk11u ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/913 From goetz at openjdk.java.net Fri Mar 18 12:49:34 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:49:34 GMT Subject: [jdk11u-dev] Integrated: 8215544: SA: Modify ClhsdbLauncher to add sudo privileges to enable MacOS tests on Mach5 In-Reply-To: <9Mhlfua-qGyHPA6L6c5Vhu_LyiKkXx2Qr4bCFDISZ4k=.3f0f3876-9e5b-42bf-8531-376666145fbf@github.com> References: <9Mhlfua-qGyHPA6L6c5Vhu_LyiKkXx2Qr4bCFDISZ4k=.3f0f3876-9e5b-42bf-8531-376666145fbf@github.com> Message-ID: On Fri, 18 Mar 2022 07:06:37 GMT, Goetz Lindenmaier wrote: > I backport this to improve mac testing and to fix a test failure. This pull request has now been integrated. Changeset: ca21a709 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/ca21a709b43a898a2a13923579625422af6f327d Stats: 116 lines in 4 files changed: 99 ins; 8 del; 9 mod 8215544: SA: Modify ClhsdbLauncher to add sudo privileges to enable MacOS tests on Mach5 Check if 'sudo' privileges can be added for executing macOS tests, and if so, add these privileges before executing the tests Backport-of: 86fcd475b1227cff0fc9f9557f542ca6bd3abfe0 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/912 From goetz at openjdk.java.net Fri Mar 18 12:49:33 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:49:33 GMT Subject: [jdk11u-dev] RFR: 8215544: SA: Modify ClhsdbLauncher to add sudo privileges to enable MacOS tests on Mach5 In-Reply-To: <9Mhlfua-qGyHPA6L6c5Vhu_LyiKkXx2Qr4bCFDISZ4k=.3f0f3876-9e5b-42bf-8531-376666145fbf@github.com> References: <9Mhlfua-qGyHPA6L6c5Vhu_LyiKkXx2Qr4bCFDISZ4k=.3f0f3876-9e5b-42bf-8531-376666145fbf@github.com> Message-ID: On Fri, 18 Mar 2022 07:06:37 GMT, Goetz Lindenmaier wrote: > I backport this to improve mac testing and to fix a test failure. Pre-submit failure: java.lang.Error: Cannot attach. Fixed by follow up 8217473 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/912 From goetz at openjdk.java.net Fri Mar 18 12:57:20 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:57:20 GMT Subject: [jdk11u-dev] RFR: 8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers [v2] In-Reply-To: References: Message-ID: <7XjWtPNEr4o8s7yQDLDj_OPiHKGMs7NIgxPchlC-9sE=.f3750660-57cc-4020-8c3d-9d271dfe989c@github.com> > I backport this to improve testing and to fix the test bug in ClhsdbRegionDetailsScanOopsForG1.java. > > I had to resolve the imports in the following files: > > test/hotspot/jtreg/serviceability/sa/ClhsdbJstack.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPmap.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPstack.java > test/hotspot/jtreg/serviceability/sa/ClhsdbWhere.java > > The hunk to ClhsdbRegionDetailsScanOopsForG1.java is left out. > The hunk was included accidentially when the test was move to resourcehogs. > This is also the cause of the failure of this test. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8217473 - Backport 55369945b94003e96c841e5969add992a86c0156 - Backport 86fcd475b1227cff0fc9f9557f542ca6bd3abfe0 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/913/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/913/files/dbd9293a..6c40bb18 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=913&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=913&range=00-01 Stats: 1055 lines in 23 files changed: 878 ins; 30 del; 147 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/913.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/913/head:pull/913 PR: https://git.openjdk.java.net/jdk11u-dev/pull/913 From goetz at openjdk.java.net Fri Mar 18 12:57:21 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 12:57:21 GMT Subject: [jdk11u-dev] Integrated: 8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 07:24:20 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing and to fix the test bug in ClhsdbRegionDetailsScanOopsForG1.java. > > I had to resolve the imports in the following files: > > test/hotspot/jtreg/serviceability/sa/ClhsdbJstack.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPmap.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPstack.java > test/hotspot/jtreg/serviceability/sa/ClhsdbWhere.java > > The hunk to ClhsdbRegionDetailsScanOopsForG1.java is left out. > The hunk was included accidentially when the test was move to resourcehogs. > This is also the cause of the failure of this test. This pull request has now been integrated. Changeset: 8f3308af Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/8f3308afb83f09e4ed813dbe1a0955c2b7b6d125 Stats: 111 lines in 20 files changed: 50 ins; 43 del; 18 mod 8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers Skip the test with jtreg.SkippedException if Platform.shouldSAAttach() returns false Reviewed-by: mdoerr Backport-of: 55369945b94003e96c841e5969add992a86c0156 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/913 From duke at openjdk.java.net Fri Mar 18 12:57:21 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Fri, 18 Mar 2022 12:57:21 GMT Subject: [jdk11u-dev] RFR: 8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 07:24:20 GMT, Goetz Lindenmaier wrote: > I backport this to improve testing and to fix the test bug in ClhsdbRegionDetailsScanOopsForG1.java. > > I had to resolve the imports in the following files: > > test/hotspot/jtreg/serviceability/sa/ClhsdbJstack.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPmap.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java > test/hotspot/jtreg/serviceability/sa/ClhsdbPstack.java > test/hotspot/jtreg/serviceability/sa/ClhsdbWhere.java > > The hunk to ClhsdbRegionDetailsScanOopsForG1.java is left out. > The hunk was included accidentially when the test was move to resourcehogs. > This is also the cause of the failure of this test. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout GoeLin-backport-86fcd475 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/913 From zgu at openjdk.java.net Fri Mar 18 13:09:24 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Fri, 18 Mar 2022 13:09:24 GMT Subject: [jdk11u-dev] RFR: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target [v3] In-Reply-To: References: Message-ID: <0fU9lCPdfhJT6pj0fcnwQhL3W6g-HfeZF7D2WiIlOy0=.7cb8b21b-66a4-466a-bdcb-134acba172f5@github.com> > I would like to backport this patch to fix test failure, introduced by JDK-8223396. > > This is a clean backport on top of JDK-8223396 backport. > > Test: > - [x] jdk_jfr Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge - Backport 725da985e170d72c3ca3dc2dfbb3d7e083b5371a - Backport 7d3aebccc0b90aa2ca2f656c683fa5931fd0ed3a ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/903/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/903/files/7a2871ae..cfbb409d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=903&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=903&range=01-02 Stats: 1257 lines in 35 files changed: 981 ins; 91 del; 185 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/903.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/903/head:pull/903 PR: https://git.openjdk.java.net/jdk11u-dev/pull/903 From yan at openjdk.java.net Fri Mar 18 13:14:42 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Fri, 18 Mar 2022 13:14:42 GMT Subject: [jdk11u] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 10:07:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. LGTM! ------------- Marked as reviewed by yan (Reviewer). PR: https://git.openjdk.java.net/jdk11u/pull/32 From zgu at openjdk.java.net Fri Mar 18 13:20:10 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Fri, 18 Mar 2022 13:20:10 GMT Subject: [jdk11u-dev] RFR: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target [v4] In-Reply-To: References: Message-ID: > I would like to backport this patch to fix test failure, introduced by JDK-8223396. > > This is a clean backport on top of JDK-8223396 backport. > > Test: > - [x] jdk_jfr Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: Remove whitespaces ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/903/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/903/files/cfbb409d..14e52a35 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=903&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=903&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/903.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/903/head:pull/903 PR: https://git.openjdk.java.net/jdk11u-dev/pull/903 From goetz at openjdk.java.net Fri Mar 18 13:22:00 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 13:22:00 GMT Subject: [jdk11u-dev] RFR: 8246494: introduce vm.flagless at-requires property Message-ID: I backport this for parity with 11.0.16-oracle. TEST.ROOT, GTestWrapper.java, VMProps.java context, Copyright. LargePageGtests.java, MetaspaceGtests.java: not in 11 ------------- Commit messages: - Backport e333b6e15343535789353f0017721b6509eb4f00 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/917/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=917&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8246494 Stats: 70 lines in 4 files changed: 66 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/917.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/917/head:pull/917 PR: https://git.openjdk.java.net/jdk11u-dev/pull/917 From duke at openjdk.java.net Fri Mar 18 13:49:55 2022 From: duke at openjdk.java.net (Basil Crow) Date: Fri, 18 Mar 2022 13:49:55 GMT Subject: [jdk11u-dev] RFR: Backport 44ae643b2b4 [v3] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a clean backport of commit [44ae643b2b4](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. > > See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. > > Thanks! Basil Crow has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 44ae643b2b49b66b1fff4c151c17972c6b683cc0 ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/855/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=855&range=02 Stats: 176 lines in 3 files changed: 161 ins; 8 del; 7 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/855.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/855/head:pull/855 PR: https://git.openjdk.java.net/jdk11u-dev/pull/855 From goetz at openjdk.java.net Fri Mar 18 13:57:46 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 13:57:46 GMT Subject: [jdk11u-dev] RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream Message-ID: I backport this for parity with 11.0.16-oracle. I removed "...".formatted() calls. That is not supported in 11. This was already reviewed in https://github.com/openjdk/jdk11u-dev/pull/530. 8222938 was backported in the meantime. As this is only a test change and is identical to the already reviewed change, I mark this as clean. ------------- Commit messages: - Backport 5caa77b043ae490c3d7d56d181d0e07e6b859b9e Changes: https://git.openjdk.java.net/jdk11u-dev/pull/918/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=918&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263364 Stats: 124 lines in 1 file changed: 83 ins; 13 del; 28 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/918.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/918/head:pull/918 PR: https://git.openjdk.java.net/jdk11u-dev/pull/918 From duke at openjdk.java.net Fri Mar 18 13:59:33 2022 From: duke at openjdk.java.net (Basil Crow) Date: Fri, 18 Mar 2022 13:59:33 GMT Subject: [jdk11u-dev] RFR: Backport 44ae643b2b4 [v3] In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 13:49:55 GMT, Basil Crow wrote: >> Hi all, >> >> This pull request contains a clean backport of commit [44ae643b2b4](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. >> >> The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. >> >> See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. >> >> Thanks! > > Basil Crow has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 44ae643b2b49b66b1fff4c151c17972c6b683cc0 Going to try creating this PR again using SKARA CLI tooling]. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/855 From duke at openjdk.java.net Fri Mar 18 13:59:34 2022 From: duke at openjdk.java.net (Basil Crow) Date: Fri, 18 Mar 2022 13:59:34 GMT Subject: [jdk11u-dev] Withdrawn: Backport 44ae643b2b4 In-Reply-To: References: Message-ID: On Sun, 6 Mar 2022 01:51:23 GMT, Basil Crow wrote: > Hi all, > > This pull request contains a clean backport of commit [44ae643b2b4](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. > > See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/855 From duke at openjdk.java.net Fri Mar 18 14:13:32 2022 From: duke at openjdk.java.net (Basil Crow) Date: Fri, 18 Mar 2022 14:13:32 GMT Subject: [jdk11u-dev] RFR: Backport 44ae643b2b4 [v3] In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 13:56:44 GMT, Basil Crow wrote: > Going to try creating this PR again using SKARA CLI tooling. Done in #919. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/855 From duke at openjdk.java.net Fri Mar 18 14:14:06 2022 From: duke at openjdk.java.net (Basil Crow) Date: Fri, 18 Mar 2022 14:14:06 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) Message-ID: Hi all, This pull request contains a clean backport of commit [44ae643b2b49b66b1fff4c151c17972c6b683cc0](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. Thanks! ------------- Commit messages: - Backport 44ae643b2b49b66b1fff4c151c17972c6b683cc0 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/919/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=919&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210649 Stats: 176 lines in 3 files changed: 161 ins; 8 del; 7 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/919.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/919/head:pull/919 PR: https://git.openjdk.java.net/jdk11u-dev/pull/919 From stuefe at openjdk.java.net Fri Mar 18 14:19:31 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Fri, 18 Mar 2022 14:19:31 GMT Subject: [jdk11u-dev] RFR: 8246494: introduce vm.flagless at-requires property In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 13:14:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > TEST.ROOT, GTestWrapper.java, VMProps.java > context, Copyright. > > LargePageGtests.java, MetaspaceGtests.java: > not in 11 LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/917 From zgu at openjdk.java.net Fri Mar 18 15:26:30 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Fri, 18 Mar 2022 15:26:30 GMT Subject: [jdk11u-dev] Integrated: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 15:45:18 GMT, Zhengyu Gu wrote: > I would like to backport this patch to fix test failure, introduced by JDK-8223396. > > This is a clean backport on top of JDK-8223396 backport. > > Test: > - [x] jdk_jfr This pull request has now been integrated. Changeset: 23af0b1e Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/23af0b1efbde5763f7a9dbc6b7b7d8130d83ab61 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target Prebuilding the test class before adding it into a jar file Backport-of: 725da985e170d72c3ca3dc2dfbb3d7e083b5371a ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/903 From duke at openjdk.java.net Fri Mar 18 16:02:31 2022 From: duke at openjdk.java.net (Basil Crow) Date: Fri, 18 Mar 2022 16:02:31 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 14:04:33 GMT, Basil Crow wrote: > Hi all, > > This pull request contains a clean backport of commit [44ae643b2b49b66b1fff4c151c17972c6b683cc0](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. > > See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. > > Thanks! ### Testing done - `tier1` test run via GitHub Actions - `make run-test TEST=test/langtools/tools/javac/processing` (to cover the test in this PR) ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/langtools/tools/javac/processing 172 172 0 0 ============================== TEST SUCCESS ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/919 From duke at openjdk.java.net Fri Mar 18 16:27:26 2022 From: duke at openjdk.java.net (Basil Crow) Date: Fri, 18 Mar 2022 16:27:26 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 14:04:33 GMT, Basil Crow wrote: > Hi all, > > This pull request contains a clean backport of commit [44ae643b2b49b66b1fff4c151c17972c6b683cc0](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. > > See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. > > Thanks! CC @TheRealMDoerr if you're interested In addition to the unit/integration tests, I verified locally in an end-to-end testing scenario that this backport resolves the issue I was experiencing running Maven. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/919 From duke at openjdk.java.net Fri Mar 18 16:35:27 2022 From: duke at openjdk.java.net (Basil Crow) Date: Fri, 18 Mar 2022 16:35:27 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) In-Reply-To: References: Message-ID: <-oaM5hlIaBk5H5f2knbo-BYPKw2i4X88BJZU7IwAOJM=.8d05d782-5a10-48b3-bf12-0be23e427a2b@github.com> On Fri, 18 Mar 2022 14:04:33 GMT, Basil Crow wrote: > Hi all, > > This pull request contains a clean backport of commit [44ae643b2b49b66b1fff4c151c17972c6b683cc0](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. > > See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. > > Thanks! Issues resolved by this backport: - [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) - [JDK-8216202](https://bugs.openjdk.java.net/browse/JDK-8216202) - [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) - [MCOMPILER-415](https://issues.apache.org/jira/browse/MCOMPILER-415) ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/919 From phh at openjdk.java.net Fri Mar 18 17:02:35 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 18 Mar 2022 17:02:35 GMT Subject: [jdk11u-dev] RFR: 8247591: Document Alpine Linux build steps in OpenJDK build guide In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 20:46:37 GMT, Aleksei Voitylov wrote: > JDK-8247591 is in the docs issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Original changeset does not apply cleanly because of: > > 8220164: Fix build instructions for AIX > 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/911 From sgehwolf at openjdk.java.net Fri Mar 18 17:09:40 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 18 Mar 2022 17:09:40 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) In-Reply-To: <-oaM5hlIaBk5H5f2knbo-BYPKw2i4X88BJZU7IwAOJM=.8d05d782-5a10-48b3-bf12-0be23e427a2b@github.com> References: <-oaM5hlIaBk5H5f2knbo-BYPKw2i4X88BJZU7IwAOJM=.8d05d782-5a10-48b3-bf12-0be23e427a2b@github.com> Message-ID: On Fri, 18 Mar 2022 16:32:09 GMT, Basil Crow wrote: >> Hi all, >> >> This pull request contains a clean backport of commit [44ae643b2b49b66b1fff4c151c17972c6b683cc0](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. >> >> The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. >> >> See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. >> >> Thanks! > > Issues resolved by this backport: > > - [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) > - [JDK-8216202](https://bugs.openjdk.java.net/browse/JDK-8216202) > - [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) > - [MCOMPILER-415](https://issues.apache.org/jira/browse/MCOMPILER-415) @basil Please only `/integrate` once you've got `jdk11u-fix-yes` label in JBS by an 11u maintainer. See the process description here: https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/919 From mdoerr at openjdk.java.net Fri Mar 18 17:14:31 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 18 Mar 2022 17:14:31 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 14:04:33 GMT, Basil Crow wrote: > Hi all, > > This pull request contains a clean backport of commit [44ae643b2b49b66b1fff4c151c17972c6b683cc0](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. > > See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. > > Thanks! You still need to request approval for 11u backports and justify why it should be done. See https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix section "Request and await approval for the fix". If you don't have JBS access, please provide the information and ask somebody to add it to the JBS issue. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/919 From duke at openjdk.java.net Fri Mar 18 17:46:33 2022 From: duke at openjdk.java.net (Basil Crow) Date: Fri, 18 Mar 2022 17:46:33 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) In-Reply-To: References: <-oaM5hlIaBk5H5f2knbo-BYPKw2i4X88BJZU7IwAOJM=.8d05d782-5a10-48b3-bf12-0be23e427a2b@github.com> Message-ID: On Fri, 18 Mar 2022 17:06:47 GMT, Severin Gehwolf wrote: > Please only `/integrate` once you've got `jdk11u-fix-yes` label in JBS by an 11u maintainer. See the process description here: https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u @jerboaa Sorry, this is my first time submitting a PR to this project and I was unfamiliar with the process. I will read the link; thank you! > You still need to request approval for 11u backports and justify why it should be done. See https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix section "Request and await approval for the fix". If you don't have JBS access, please provide the information and ask somebody to add it to the JBS issue. @TheRealMDoerr I do not have JBS access. Can someone please submit the following comment with the `jdk11u-fix-request` label: When compiling source code with compilation errors using Maven and Java 11, I frequently encounter the `AssertionError` from [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) (tracked by [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346)) with `11` and the `NullPointerException` from [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8216202) (tracked by [MCOMPILER-415](https://issues.apache.org/jira/browse/MCOMPILER-415)) with `8`. That is, rather than getting an informative error message that tells me the nature of the compilation error, I get an unhelpful stack trace emanating from the depths of the JDK, which does not get me any closer to fixing the compilation error and compiling my code. Both issues have the same root cause and were resolved by openjdk/jdk at 44ae643b2b4. Backporting this commit to `jdk11u-dev` resolves both issues and eliminates a developer productivity pain point. Not only have I done a `t ier1` test run via GitHub Actions and executed the test from openjdk/jdk at 44ae643b2b4 locally by running `make run-test TEST=test/langtools/tools/javac/processing`, but also I have verified locally in an end-to-end testing scenario that this backport resolves the issues I was experiencing running Maven with both `11` (i.e., the `AssertionError`) and `8` (i.e., the `NullPointerException`). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/919 From phh at openjdk.java.net Fri Mar 18 18:32:30 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 18 Mar 2022 18:32:30 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 14:04:33 GMT, Basil Crow wrote: > Hi all, > > This pull request contains a clean backport of commit [44ae643b2b49b66b1fff4c151c17972c6b683cc0](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. > > See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. > > Thanks! Done. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/919 From duke at openjdk.java.net Fri Mar 18 18:32:30 2022 From: duke at openjdk.java.net (Basil Crow) Date: Fri, 18 Mar 2022 18:32:30 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 18:24:39 GMT, Paul Hohensee wrote: > Done. @phohensee Thank you! @phohensee Sorry to trouble you one more time, but I had a typo... meant to write: > When compiling source code with compilation errors using Maven and Java 11, I frequently encounter the `AssertionError` from [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) (tracked by [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346)) with `11` and the `NullPointerException` from [JDK-8216202](https://bugs.openjdk.java.net/browse/JDK-8216202) (tracked by [MCOMPILER-415](https://issues.apache.org/jira/browse/MCOMPILER-415)) with `8`. Note the two different JDK bugs. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/919 From phh at openjdk.java.net Fri Mar 18 18:36:27 2022 From: phh at openjdk.java.net (Paul Hohensee) Date: Fri, 18 Mar 2022 18:36:27 GMT Subject: [jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 14:04:33 GMT, Basil Crow wrote: > Hi all, > > This pull request contains a clean backport of commit [44ae643b2b49b66b1fff4c151c17972c6b683cc0](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. > > See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. > > Thanks! Updated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/919 From goetz at openjdk.java.net Fri Mar 18 18:40:34 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 18:40:34 GMT Subject: [jdk11u] RFR: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 10:07:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. Pre-submit failures: missing dependencies, fixed in jdk11u-dev. ------------- PR: https://git.openjdk.java.net/jdk11u/pull/32 From goetz at openjdk.java.net Fri Mar 18 18:40:35 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 18 Mar 2022 18:40:35 GMT Subject: [jdk11u] Integrated: 8282761: XPathFactoryImpl remove setProperty and getProperty methods In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 10:07:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.15-oracle. This pull request has now been integrated. Changeset: 9a7bd43d Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u/commit/9a7bd43d277135ac2bbb9c8289430b9f8dd5af3d Stats: 58 lines in 2 files changed: 0 ins; 56 del; 2 mod 8282761: XPathFactoryImpl remove setProperty and getProperty methods Reviewed-by: yan Backport-of: 67dd89154a5a8bd4661101d8d97e8b249063cca6 ------------- PR: https://git.openjdk.java.net/jdk11u/pull/32 From ebaron at openjdk.java.net Fri Mar 18 22:24:42 2022 From: ebaron at openjdk.java.net (Elliott Baron) Date: Fri, 18 Mar 2022 22:24:42 GMT Subject: [jdk11u-dev] RFR: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java Message-ID: Doesn't apply cleanly because of newer backport "JDK-8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1". In test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java: - One hunk in testOperatingSystemMXBeanAwareness doesn't apply because of newer fix JDK-8250984 backported ahead of this fix. - testOperatingSystemMXBeanAwareness in 11u already matches the what it looked like after the original JDK-8250984 commit, with JDK-8244500 already present in that version: https://github.com/openjdk/jdk/blob/0187567704d79ecf394d4cb656d0ba4c886351f1/test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java#L160-L175. - Dropping this hunk. ------------- Commit messages: - Backport fb5132254d834ba01a4b65ce64143843e83c674e Changes: https://git.openjdk.java.net/jdk11u-dev/pull/920/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=920&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8244500 Stats: 21 lines in 3 files changed: 19 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/920.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/920/head:pull/920 PR: https://git.openjdk.java.net/jdk11u-dev/pull/920 From jiefu at openjdk.java.net Sat Mar 19 08:52:48 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Sat, 19 Mar 2022 08:52:48 GMT Subject: [jdk11u-dev] RFR: 8283409: JDK11 fails to build when C1 is disabled Message-ID: Hi all, This patch fixes build failure of JDK11 when C1 compiler is disabled with `--with-jvm-features=-compiler1`. Please review it. Thanks. Best regards, Jie ------------- Commit messages: - 8283409: JDK11 fails to build when C1 is disabled Changes: https://git.openjdk.java.net/jdk11u-dev/pull/921/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=921&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283409 Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/921.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/921/head:pull/921 PR: https://git.openjdk.java.net/jdk11u-dev/pull/921 From jiefu at openjdk.java.net Sat Mar 19 12:27:57 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Sat, 19 Mar 2022 12:27:57 GMT Subject: [jdk11u-dev] RFR: 8210108: sun/tools/jstatd test build failures after JDK-8210022 Message-ID: Hi all, I'd like to backport this patch to fix the following testing failures. sun/tools/jstatd/TestJstatdDefaults.java sun/tools/jstatd/TestJstatdServer.java sun/tools/jstatd/TestJstatdPort.java sun/tools/jstatd/TestJstatdExternalRegistry.java sun/tools/jstatd/TestJstatdPortAndServer.java Thanks. Best regards, Jie ------------- Commit messages: - Backport 86c476b5e5e0cc00c40e7049d1dbb02874afe247 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/922/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=922&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210108 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/922.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/922/head:pull/922 PR: https://git.openjdk.java.net/jdk11u-dev/pull/922 From goetz at openjdk.java.net Sat Mar 19 18:37:38 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Sat, 19 Mar 2022 18:37:38 GMT Subject: [jdk17u-dev] RFR: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 08:49:02 GMT, Goetz Lindenmaier wrote: > I think this is a useful backport of a bugfix for 17u. Pre-submit test:gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 I have seen this before in other tests. Unrelated ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/263 From goetz at openjdk.java.net Sat Mar 19 18:46:38 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Sat, 19 Mar 2022 18:46:38 GMT Subject: [jdk17u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() In-Reply-To: References: Message-ID: <8uZCeSOnGjrP0EjlazOGYwblx_YhcH49nrnG3dj4b8E=.c3a33954-ab7b-4f27-ad34-dea0a6da8553@github.com> On Fri, 4 Feb 2022 12:28:57 GMT, Jonathan Dowland wrote: > Hi > > This pull request contains a backport of commit [1e9ed54d](https://github.com/openjdk/jdk/commit/1e9ed54d362b8c57be5fbbac2de5afbd0f05435f) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Ravi Reddy on 1 Dec 2021 and was reviewed by Lance Andersen and Sean Coffey. > > This is a backport for Oracle parity. The patch introduces a new test for the bug. The test fails against jdk17u-dev master prior to the patch and passes afterwards. > > Thanks! I tested the PR agains the current jdk17-dev. All green. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/147 From goetz at openjdk.java.net Sat Mar 19 18:50:32 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Sat, 19 Mar 2022 18:50:32 GMT Subject: [jdk11u-dev] RFR: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 13:45:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I removed "...".formatted() calls. That is not supported in 11. > > This was already reviewed in https://github.com/openjdk/jdk11u-dev/pull/530. > 8222938 was backported in the meantime. > > As this is only a test change and is identical to the already reviewed change, I mark this as clean. Pre-submit failure: runtime/Thread/StopAtExit.java fixed in jdk11u ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/918 From clanger at openjdk.java.net Sat Mar 19 21:07:25 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Sat, 19 Mar 2022 21:07:25 GMT Subject: [jdk11u-dev] RFR: 8240734: ModuleHashes attribute not reproducible between builds In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 08:49:00 GMT, Christoph Langer wrote: > This is a clean backport of JDK-8240734. I'm backporting this as a predecessor of JDK-8243666. Got the push approval. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/915 From clanger at openjdk.java.net Sat Mar 19 21:07:25 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Sat, 19 Mar 2022 21:07:25 GMT Subject: [jdk11u-dev] Integrated: 8240734: ModuleHashes attribute not reproducible between builds In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 08:49:00 GMT, Christoph Langer wrote: > This is a clean backport of JDK-8240734. I'm backporting this as a predecessor of JDK-8243666. This pull request has now been integrated. Changeset: e6f8c1e1 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/e6f8c1e15671947578a0e54f9b3e439f8f8cfef5 Stats: 6 lines in 2 files changed: 2 ins; 0 del; 4 mod 8240734: ModuleHashes attribute not reproducible between builds Backport-of: f4b54881811353ab61748db5af7f93b6c40efb2d ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/915 From clanger at openjdk.java.net Sat Mar 19 21:11:54 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Sat, 19 Mar 2022 21:11:54 GMT Subject: [jdk11u-dev] RFR: 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps [v2] In-Reply-To: References: Message-ID: <2etPh4mWxsB7CQQU-plCEkJlGilbW75RJ472ilTytNU=.eb9e2133-a972-4f38-b408-fb1c37c4f2b3@github.com> > Clean backport, only resolved one copyright header diff. > > I'm backporting this because it resolves an issue with jlink when using it with a debian package that was built with debuild. We got a report here in SapMachine: https://github.com/SAP/SapMachine/issues/1009 > > debuild seems to modify the jmod files in a way that the hash computation as of JDK11 will yield different results (e.g. timestamps of files differ). The modified hash calculation solves this. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/916/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/916/files/41262ce2..41262ce2 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=916&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=916&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/916.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/916/head:pull/916 PR: https://git.openjdk.java.net/jdk11u-dev/pull/916 From duke at openjdk.java.net Sat Mar 19 21:11:55 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Sat, 19 Mar 2022 21:11:55 GMT Subject: [jdk11u-dev] RFR: 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 09:12:01 GMT, Christoph Langer wrote: > Clean backport, only resolved one copyright header diff. > > I'm backporting this because it resolves an issue with jlink when using it with a debian package that was built with debuild. We got a report here in SapMachine: https://github.com/SAP/SapMachine/issues/1009 > > debuild seems to modify the jmod files in a way that the hash computation as of JDK11 will yield different results (e.g. timestamps of files differ). The modified hash calculation solves this. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backport-8240734 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/916 From clanger at openjdk.java.net Sat Mar 19 21:25:55 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Sat, 19 Mar 2022 21:25:55 GMT Subject: [jdk11u-dev] RFR: 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps [v3] In-Reply-To: References: Message-ID: <45bp_719ezbHE0DJA_6gIdZqvfINQPa2sPrGoRj7BjM=.754285f6-3ec2-4d15-a281-5340d3f07982@github.com> > Clean backport, only resolved one copyright header diff. > > I'm backporting this because it resolves an issue with jlink when using it with a debian package that was built with debuild. We got a report here in SapMachine: https://github.com/SAP/SapMachine/issues/1009 > > debuild seems to modify the jmod files in a way that the hash computation as of JDK11 will yield different results (e.g. timestamps of files differ). The modified hash calculation solves this. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps Reviewed-by: mchung ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/916/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=916&range=02 Stats: 189 lines in 5 files changed: 129 ins; 21 del; 39 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/916.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/916/head:pull/916 PR: https://git.openjdk.java.net/jdk11u-dev/pull/916 From duke at openjdk.java.net Sat Mar 19 21:55:27 2022 From: duke at openjdk.java.net (Basil Crow) Date: Sat, 19 Mar 2022 21:55:27 GMT Subject: [jdk11u-dev] Integrated: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 14:04:33 GMT, Basil Crow wrote: > Hi all, > > This pull request contains a clean backport of commit [44ae643b2b49b66b1fff4c151c17972c6b683cc0](https://github.com/openjdk/jdk/commit/44ae643b2b4) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Jan Lahoda on June 1, 2020, and was reviewed by Vicente Romero. > > See [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) and [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346) for more information. > > Thanks! This pull request has now been integrated. Changeset: dd6ba087 Author: Basil Crow Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/dd6ba0875f7b388ab05d326ab3d9c5d771437529 Stats: 176 lines in 3 files changed: 161 ins; 8 del; 7 mod 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244) Do not clean trees after last round of annotation processing, if the trees won't be re-entered again. Backport-of: 44ae643b2b49b66b1fff4c151c17972c6b683cc0 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/919 From clanger at openjdk.java.net Sat Mar 19 22:49:41 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Sat, 19 Mar 2022 22:49:41 GMT Subject: [jdk11u-dev] RFR: 8283420: [AOT] Exclude TrackedFlagTest/NotTrackedFlagTest in 11u because of intermittent java.lang.AssertionError: duplicate classes for name Ljava/lang/Boolean; Message-ID: We see intermittent errors in our CI systems, like here: https://ci.sapmachine.io/job/build-11-pr-validation-linux_x86_64/61/ https://ci.sapmachine.io/job/build-11-pr-validation-linux_x86_64/53/ The issue would only be fixed with a Graal update (https://bugs.openjdk.java.net/browse/JDK-8215224 from OpenJDK 12) which is probably not going to happen in OpenJDK 11u. So we shall exclude these two tests to reduce noise in CI systems. ------------- Commit messages: - JDK-8283420 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/923/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=923&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283420 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/923.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/923/head:pull/923 PR: https://git.openjdk.java.net/jdk11u-dev/pull/923 From jiefu at openjdk.java.net Sun Mar 20 00:19:23 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Sun, 20 Mar 2022 00:19:23 GMT Subject: [jdk11u-dev] RFR: 8210108: sun/tools/jstatd test build failures after JDK-8210022 In-Reply-To: References: Message-ID: On Sat, 19 Mar 2022 12:22:15 GMT, Jie Fu wrote: > Hi all, > > I'd like to backport this patch to fix the following testing failures. > > sun/tools/jstatd/TestJstatdDefaults.java > sun/tools/jstatd/TestJstatdServer.java > sun/tools/jstatd/TestJstatdPort.java > sun/tools/jstatd/TestJstatdExternalRegistry.java > sun/tools/jstatd/TestJstatdPortAndServer.java > > > Thanks. > Best regards, > Jie Fix request had been approved. So integrate it. Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/922 From jiefu at openjdk.java.net Sun Mar 20 00:42:21 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Sun, 20 Mar 2022 00:42:21 GMT Subject: [jdk11u-dev] Integrated: 8210108: sun/tools/jstatd test build failures after JDK-8210022 In-Reply-To: References: Message-ID: On Sat, 19 Mar 2022 12:22:15 GMT, Jie Fu wrote: > Hi all, > > I'd like to backport this patch to fix the following testing failures. > > sun/tools/jstatd/TestJstatdDefaults.java > sun/tools/jstatd/TestJstatdServer.java > sun/tools/jstatd/TestJstatdPort.java > sun/tools/jstatd/TestJstatdExternalRegistry.java > sun/tools/jstatd/TestJstatdPortAndServer.java > > > Thanks. > Best regards, > Jie This pull request has now been integrated. Changeset: e66e3e5f Author: Jie Fu Committer: John Jiang URL: https://git.openjdk.java.net/jdk11u-dev/commit/e66e3e5f8ceab818a3ed02b67417d451916cf260 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod 8210108: sun/tools/jstatd test build failures after JDK-8210022 Backport-of: 86c476b5e5e0cc00c40e7049d1dbb02874afe247 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/922 From jiefu at openjdk.java.net Sun Mar 20 01:36:39 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Sun, 20 Mar 2022 01:36:39 GMT Subject: [jdk11u-dev] RFR: 8283424: compiler/loopopts/LoopUnswitchingBadNodeBudget.java fails with release VMs due to lack of -XX:+UnlockDiagnosticVMOptions Message-ID: Hi all, I'd like to fix the failure of compiler/loopopts/LoopUnswitchingBadNodeBudget.java with release VMs due to lack of -XX:+UnlockDiagnosticVMOptions. Testing: - compiler/loopopts/LoopUnswitchingBadNodeBudget.java with {fastdebug, release} VMs Thanks. Best regards, Jie ------------- Commit messages: - 8283424: compiler/loopopts/LoopUnswitchingBadNodeBudget.java fails with release VMs due to lack of -XX:+UnlockDiagnosticVMOptions Changes: https://git.openjdk.java.net/jdk11u-dev/pull/924/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=924&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283424 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/924.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/924/head:pull/924 PR: https://git.openjdk.java.net/jdk11u-dev/pull/924 From clanger at openjdk.java.net Sun Mar 20 06:29:25 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Sun, 20 Mar 2022 06:29:25 GMT Subject: [jdk11u-dev] RFR: 8283420: [AOT] Exclude TrackedFlagTest/NotTrackedFlagTest in 11u because of intermittent java.lang.AssertionError: duplicate classes for name Ljava/lang/Boolean; In-Reply-To: References: Message-ID: On Sat, 19 Mar 2022 22:44:08 GMT, Christoph Langer wrote: > We see intermittent errors in our CI systems, like here: > https://ci.sapmachine.io/job/build-11-pr-validation-linux_x86_64/61/ > https://ci.sapmachine.io/job/build-11-pr-validation-linux_x86_64/53/ > > The issue would only be fixed with a Graal update (https://bugs.openjdk.java.net/browse/JDK-8215224 from OpenJDK 12) which is probably not going to happen in OpenJDK 11u. > So we shall exclude these two tests to reduce noise in CI systems. GHA error unrelated - runtime/Thread/StopAtExit.java will be fixed with JDK-8283270. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/923 From clanger at openjdk.java.net Sun Mar 20 06:30:31 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Sun, 20 Mar 2022 06:30:31 GMT Subject: [jdk11u-dev] RFR: 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps [v3] In-Reply-To: <45bp_719ezbHE0DJA_6gIdZqvfINQPa2sPrGoRj7BjM=.754285f6-3ec2-4d15-a281-5340d3f07982@github.com> References: <45bp_719ezbHE0DJA_6gIdZqvfINQPa2sPrGoRj7BjM=.754285f6-3ec2-4d15-a281-5340d3f07982@github.com> Message-ID: On Sat, 19 Mar 2022 21:25:55 GMT, Christoph Langer wrote: >> Clean backport, only resolved one copyright header diff. >> >> I'm backporting this because it resolves an issue with jlink when using it with a debian package that was built with debuild. We got a report here in SapMachine: https://github.com/SAP/SapMachine/issues/1009 >> >> debuild seems to modify the jmod files in a way that the hash computation as of JDK11 will yield different results (e.g. timestamps of files differ). The modified hash calculation solves this. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps > > Reviewed-by: mchung GHA error unrelated - runtime/Thread/SuspendAtExit.java will be fixed with JDK-8283270. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/916 From stuefe at openjdk.java.net Sun Mar 20 06:55:35 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Sun, 20 Mar 2022 06:55:35 GMT Subject: [jdk11u-dev] RFR: 8283420: [AOT] Exclude TrackedFlagTest/NotTrackedFlagTest in 11u because of intermittent java.lang.AssertionError: duplicate classes for name Ljava/lang/Boolean; In-Reply-To: References: Message-ID: On Sat, 19 Mar 2022 22:44:08 GMT, Christoph Langer wrote: > We see intermittent errors in our CI systems, like here: > https://ci.sapmachine.io/job/build-11-pr-validation-linux_x86_64/61/ > https://ci.sapmachine.io/job/build-11-pr-validation-linux_x86_64/53/ > > The issue would only be fixed with a Graal update (https://bugs.openjdk.java.net/browse/JDK-8215224 from OpenJDK 12) which is probably not going to happen in OpenJDK 11u. > So we shall exclude these two tests to reduce noise in CI systems. LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/923 From goetz at openjdk.java.net Sun Mar 20 19:31:58 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Sun, 20 Mar 2022 19:31:58 GMT Subject: [jdk17u-dev] Integrated: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 08:49:02 GMT, Goetz Lindenmaier wrote: > I think this is a useful backport of a bugfix for 17u. This pull request has now been integrated. Changeset: a605a306 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/a605a3065f864f152b5239d454ca74c52b50d509 Stats: 117 lines in 2 files changed: 114 ins; 0 del; 3 mod 8277087: ZipException: zip END header not found at ZipFile#Source.findEND Backport-of: e3243ee963d074c892a0ed16a00fd91b440c96ac ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/263 From goetz at openjdk.java.net Sun Mar 20 19:33:28 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Sun, 20 Mar 2022 19:33:28 GMT Subject: [jdk11u-dev] Integrated: 8246494: introduce vm.flagless at-requires property In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 13:14:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > TEST.ROOT, GTestWrapper.java, VMProps.java > context, Copyright. > > LargePageGtests.java, MetaspaceGtests.java: > not in 11 This pull request has now been integrated. Changeset: f14b9328 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/f14b9328ecd39c19a09881e4a559a6e5e9687493 Stats: 70 lines in 4 files changed: 66 ins; 0 del; 4 mod 8246494: introduce vm.flagless at-requires property Reviewed-by: stuefe Backport-of: e333b6e15343535789353f0017721b6509eb4f00 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/917 From goetz at openjdk.java.net Sun Mar 20 19:33:51 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Sun, 20 Mar 2022 19:33:51 GMT Subject: [jdk17u-dev] Integrated: 8279227: Access Bridge: Wrong frame position and hit test result on HiDPI display In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 09:02:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 7650afa4 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/7650afa460c6058b5ecceecdccb1547a9082de6a Stats: 185 lines in 1 file changed: 185 ins; 0 del; 0 mod 8279227: Access Bridge: Wrong frame position and hit test result on HiDPI display Backport-of: 20ef954158bc5a339118640946b39047fe853ae4 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/264 From goetz at openjdk.java.net Sun Mar 20 19:35:33 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Sun, 20 Mar 2022 19:35:33 GMT Subject: [jdk11u-dev] Integrated: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 13:45:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I removed "...".formatted() calls. That is not supported in 11. > > This was already reviewed in https://github.com/openjdk/jdk11u-dev/pull/530. > 8222938 was backported in the meantime. > > As this is only a test change and is identical to the already reviewed change, I mark this as clean. This pull request has now been integrated. Changeset: cf52a6f4 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/cf52a6f4fa2b9e6ccc669dd89fb2e2ea10c05056 Stats: 124 lines in 1 file changed: 83 ins; 13 del; 28 mod 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream Backport-of: 5caa77b043ae490c3d7d56d181d0e07e6b859b9e ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/918 From goetz at openjdk.java.net Sun Mar 20 19:35:41 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Sun, 20 Mar 2022 19:35:41 GMT Subject: [jdk17u-dev] Integrated: 8280401: [sspi] gss_accept_sec_context leaves output_token uninitialized In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 09:07:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 049b1baa Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/049b1baaf5d8535a59b5e2d96317560f2c83ae41 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8280401: [sspi] gss_accept_sec_context leaves output_token uninitialized Backport-of: 6352c020c25f2701afb4fabee0cc7fcef2d407fb ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/265 From goetz at openjdk.java.net Sun Mar 20 19:42:32 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Sun, 20 Mar 2022 19:42:32 GMT Subject: [jdk17u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() In-Reply-To: <4DpUi5DwcXjmaSojcPrnurkMU4kNYmZZujoAnzHcAAc=.b57f88b4-be53-4f82-8347-23168fea88e6@github.com> References: <4DpUi5DwcXjmaSojcPrnurkMU4kNYmZZujoAnzHcAAc=.b57f88b4-be53-4f82-8347-23168fea88e6@github.com> Message-ID: On Mon, 7 Feb 2022 22:06:12 GMT, Jonathan Dowland wrote: >> @jmtd This is a clean backport, you don't need code review. Please tag the bug for approval. > > @zhengyu123 thank you for your reply! I meant to get back to this one today. It is clean, but the original bug needed a CSR, so I believe I need to raise a CSR for the backport too. I just didn't get around to looking into that yet. Am I right? @jmtd, this is all ready now, could you please integrate the PR? ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/147 From vkempik at openjdk.java.net Sun Mar 20 20:19:36 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Sun, 20 Mar 2022 20:19:36 GMT Subject: [jdk11u-dev] RFR: 8283409: JDK11 fails to build when C1 is disabled In-Reply-To: References: Message-ID: On Sat, 19 Mar 2022 08:47:45 GMT, Jie Fu wrote: > Hi all, > > This patch fixes build failure of JDK11 when C1 compiler is disabled with `--with-jvm-features=-compiler1`. > Please review it. > > Thanks. > Best regards, > Jie could you please instead of this, backport https://bugs.openjdk.java.net/browse/JDK-8222926 and https://bugs.openjdk.java.net/browse/JDK-8209883 into jdk11u-dev ? this will do the same in accordance to general backporting rules ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/921 From jiefu at openjdk.java.net Mon Mar 21 07:17:52 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Mon, 21 Mar 2022 07:17:52 GMT Subject: [jdk11u-dev] RFR: 8209883: ZGC: Compile without C1 broken Message-ID: Hi all, Please review the backport of "JDK-8209883 ZGC: Compile without C1 broken", which is suggested here https://github.com/openjdk/jdk11u-dev/pull/921#issuecomment-1073341167 . Although it doesn't apply cleanly, only a small adjustment is required to do this backport. Testing: - tier1~3 on Linux/x64, no regression. Thanks. Best regards, Jie ------------- Commit messages: - Backport 14443eec10043fa86622d9e8e1d8b4a6bee22482 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/926/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=926&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8209883 Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/926.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/926/head:pull/926 PR: https://git.openjdk.java.net/jdk11u-dev/pull/926 From jiefu at openjdk.java.net Mon Mar 21 07:19:31 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Mon, 21 Mar 2022 07:19:31 GMT Subject: [jdk11u-dev] RFR: 8283409: JDK11 fails to build when C1 is disabled In-Reply-To: References: Message-ID: On Sun, 20 Mar 2022 20:16:53 GMT, Vladimir Kempik wrote: > could you please instead of this, backport https://bugs.openjdk.java.net/browse/JDK-8222926 and https://bugs.openjdk.java.net/browse/JDK-8209883 into jdk11u-dev ? this will do the same in accordance to general backporting rules Sounds good. So I've backported JDK-8209883 here: https://github.com/openjdk/jdk11u-dev/pull/926 Please review it. And I'll do the second one once the first one is integrated. Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/921 From duke at openjdk.java.net Mon Mar 21 07:51:44 2022 From: duke at openjdk.java.net (Yude Lin) Date: Mon, 21 Mar 2022 07:51:44 GMT Subject: [jdk11u-dev] RFR: 8228609: G1 copy cost prediction uses used vs. actual copied bytes Message-ID: I would like to backport 8228609 which fixes a prediction error regarding cost per bytes copied. The patch does not apply cleanly, so this backport is basically changing the calculation of copied bytes. https://bugs.openjdk.java.net/browse/JDK-8227442 is not in 11u. So this patch also uses G1ParScanThreadState::surviving_young_words() in place of _surviving_young_words to adjust for the correct cset index. ------------- Commit messages: - 8228609: G1 copy cost prediction uses used vs. actual copied bytes Changes: https://git.openjdk.java.net/jdk11u-dev/pull/927/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=927&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8228609 Stats: 19 lines in 4 files changed: 12 ins; 1 del; 6 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/927.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/927/head:pull/927 PR: https://git.openjdk.java.net/jdk11u-dev/pull/927 From roland at openjdk.java.net Mon Mar 21 08:24:39 2022 From: roland at openjdk.java.net (Roland Westrelin) Date: Mon, 21 Mar 2022 08:24:39 GMT Subject: [jdk11u-dev] RFR: 8283424: compiler/loopopts/LoopUnswitchingBadNodeBudget.java fails with release VMs due to lack of -XX:+UnlockDiagnosticVMOptions In-Reply-To: References: Message-ID: On Sun, 20 Mar 2022 01:32:20 GMT, Jie Fu wrote: > Hi all, > > I'd like to fix the failure of compiler/loopopts/LoopUnswitchingBadNodeBudget.java with release VMs due to lack of -XX:+UnlockDiagnosticVMOptions. > > Testing: > - compiler/loopopts/LoopUnswitchingBadNodeBudget.java with {fastdebug, release} VMs > > Thanks. > Best regards, > Jie Looks good to me. ------------- Marked as reviewed by roland (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/924 From jiefu at openjdk.java.net Mon Mar 21 08:31:39 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Mon, 21 Mar 2022 08:31:39 GMT Subject: [jdk11u-dev] RFR: 8283424: compiler/loopopts/LoopUnswitchingBadNodeBudget.java fails with release VMs due to lack of -XX:+UnlockDiagnosticVMOptions In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 08:21:12 GMT, Roland Westrelin wrote: > Looks good to me. Thanks @rwestrel for your review. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/924 From tobias.hartmann at oracle.com Mon Mar 21 08:33:22 2022 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 21 Mar 2022 09:33:22 +0100 Subject: CFV: New JDK Updates Committer: Christian Hagedorn Message-ID: I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he contributed over 120 changes to the JDK project [2] many of which have been backported to older releases. Votes are due by April 4, 2022, 09:00 UTC. Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [4]. Best regards, Tobias [1] https://openjdk.java.net/census#chagedorn [2] https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits [3] https://openjdk.java.net/census#jdk-updates [4] https://openjdk.java.net/bylaws#three-vote-consensus From tobias.hartmann at oracle.com Mon Mar 21 08:36:02 2022 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 21 Mar 2022 09:36:02 +0100 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: <6981726a-0036-76ea-c337-6007f51f250f@oracle.com> Vote: yes Best regards, Tobias On 21.03.22 09:33, Tobias Hartmann wrote: > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From vladimir.kempik at jetbrains.com Mon Mar 21 08:38:44 2022 From: vladimir.kempik at jetbrains.com (Vladimir Kempik) Date: Mon, 21 Mar 2022 11:38:44 +0300 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: <40BA2B10-A3BC-45EE-98C0-16B6C1B71BDF@jetbrains.com> Vote: yes Btw, shouldn?t it be simple lazy consensus for Committer nomination? > 21 ????? 2022 ?., ? 11:33, Tobias Hartmann ???????(?): > > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From yan at azul.com Mon Mar 21 08:36:25 2022 From: yan at azul.com (Yuri Nesterenko) Date: Mon, 21 Mar 2022 11:36:25 +0300 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: Vote: yes --yan On 21.03.2022 11:33, Tobias Hartmann wrote: > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From tobias.hartmann at oracle.com Mon Mar 21 08:46:33 2022 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 21 Mar 2022 09:46:33 +0100 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: Correction: It should be Lazy Consensus voting (see [5]) not Three-Vote Consensus. Thanks, Tobias [5] https://openjdk.java.net/projects/#committer-vote On 21.03.22 09:33, Tobias Hartmann wrote: > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From tobias.hartmann at oracle.com Mon Mar 21 08:47:11 2022 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 21 Mar 2022 09:47:11 +0100 Subject: [External] : Re: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: <40BA2B10-A3BC-45EE-98C0-16B6C1B71BDF@jetbrains.com> References: <40BA2B10-A3BC-45EE-98C0-16B6C1B71BDF@jetbrains.com> Message-ID: <7a5e86c8-1958-5f28-7ac3-93b21b0cdaef@oracle.com> On 21.03.22 09:38, Vladimir Kempik wrote: > Btw, shouldn?t it be simple lazy consensus for Committer nomination? Yes, you are right. Copy-paste error. Thanks for pointing it out. Best regards, Tobias From vkempik at openjdk.java.net Mon Mar 21 08:47:31 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Mon, 21 Mar 2022 08:47:31 GMT Subject: [jdk11u-dev] RFR: 8209883: ZGC: Compile without C1 broken In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 07:10:45 GMT, Jie Fu wrote: > Hi all, > > Please review the backport of "JDK-8209883 ZGC: Compile without C1 broken", which is suggested here https://github.com/openjdk/jdk11u-dev/pull/921#issuecomment-1073341167 . > > Although it doesn't apply cleanly, only a small adjustment is required to do this backport. > > Testing: > - tier1~3 on Linux/x64, no regression. > > Thanks. > Best regards, > Jie Marked as reviewed by vkempik (Reviewer). should we really update copyright year on a file where the patch applied cleanly ? talking about zBarrierSetAssembler_x86.cpp Other than this - looks good ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/926 From christoph.langer at sap.com Mon Mar 21 08:56:42 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 21 Mar 2022 08:56:42 +0000 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: Vote:yes /Christoph > -----Original Message----- > From: jdk-updates-dev On Behalf Of > Tobias Hartmann > Sent: Montag, 21. M?rz 2022 09:33 > To: jdk-updates-dev at openjdk.java.net > Subject: CFV: New JDK Updates Committer: Christian Hagedorn > > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project > Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK > Reviewer. Since 2019, he contributed over 120 changes to the JDK project [2] > many of which have been backported to older releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer- > name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commit > s > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From felix.yang at huawei.com Mon Mar 21 08:59:39 2022 From: felix.yang at huawei.com (Yangfei (Felix)) Date: Mon, 21 Mar 2022 08:59:39 +0000 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: <6981726a-0036-76ea-c337-6007f51f250f@oracle.com> References: <6981726a-0036-76ea-c337-6007f51f250f@oracle.com> Message-ID: Vote: yes Best regards, Felix > -----Original Message----- > From: jdk-updates-dev [mailto:jdk-updates-dev-retn at openjdk.java.net] On > Behalf Of Tobias Hartmann > Sent: Monday, March 21, 2022 4:36 PM > To: jdk-updates-dev at openjdk.java.net > Subject: Re: CFV: New JDK Updates Committer: Christian Hagedorn > > Vote: yes > > Best regards, > Tobias > > On 21.03.22 09:33, Tobias Hartmann wrote: > > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates > Project Committer. > > > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK > > Reviewer. Since 2019, he contributed over 120 changes to the JDK > > project [2] many of which have been backported to older releases. > > > > Votes are due by April 4, 2022, 09:00 UTC. > > > > Only current JDK Updates Committer [3] are eligible to vote on this > > nomination. Votes must be cast in the open by replying to this mailing list. > > > > For Three-Vote Consensus voting instructions, see [4]. > > > > Best regards, > > Tobias > > > > [1] https://openjdk.java.net/census#chagedorn > > [2] > > https://github.com/search?q=committer- > name%3A%22Christian+Hagedorn%22+ > > repo%3Aopenjdk%2Fjdk&type=commits [3] > > https://openjdk.java.net/census#jdk-updates > > [4] https://openjdk.java.net/bylaws#three-vote-consensus From sgehwolf at redhat.com Mon Mar 21 09:09:55 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Mon, 21 Mar 2022 10:09:55 +0100 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: Vote: yes. On Mon, 2022-03-21 at 09:33 +0100, Tobias Hartmann wrote: > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates > Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a > JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which > have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this > nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus > From jiefu at openjdk.java.net Mon Mar 21 09:15:03 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Mon, 21 Mar 2022 09:15:03 GMT Subject: [jdk11u-dev] RFR: 8209883: ZGC: Compile without C1 broken [v2] In-Reply-To: References: Message-ID: > Hi all, > > Please review the backport of "JDK-8209883 ZGC: Compile without C1 broken", which is suggested here https://github.com/openjdk/jdk11u-dev/pull/921#issuecomment-1073341167 . > > Although it doesn't apply cleanly, only a small adjustment is required to do this backport. > > Testing: > - tier1~3 on Linux/x64, no regression. > > Thanks. > Best regards, > Jie Jie Fu has updated the pull request incrementally with one additional commit since the last revision: Address review comment ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/926/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/926/files/ec5a2d0c..6f3cf759 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=926&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=926&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/926.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/926/head:pull/926 PR: https://git.openjdk.java.net/jdk11u-dev/pull/926 From jiefu at openjdk.java.net Mon Mar 21 09:15:04 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Mon, 21 Mar 2022 09:15:04 GMT Subject: [jdk11u-dev] RFR: 8209883: ZGC: Compile without C1 broken In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 08:43:48 GMT, Vladimir Kempik wrote: > should we really update copyright year on a file where the patch applied cleanly ? The patch has been updated not touching the copyright year of zBarrierSetAssembler_x86.cpp . Thanks @VladimirKempik for the review. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/926 From jiefu at openjdk.java.net Mon Mar 21 09:41:29 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Mon, 21 Mar 2022 09:41:29 GMT Subject: [jdk11u-dev] Integrated: 8283424: compiler/loopopts/LoopUnswitchingBadNodeBudget.java fails with release VMs due to lack of -XX:+UnlockDiagnosticVMOptions In-Reply-To: References: Message-ID: On Sun, 20 Mar 2022 01:32:20 GMT, Jie Fu wrote: > Hi all, > > I'd like to fix the failure of compiler/loopopts/LoopUnswitchingBadNodeBudget.java with release VMs due to lack of -XX:+UnlockDiagnosticVMOptions. > > Testing: > - compiler/loopopts/LoopUnswitchingBadNodeBudget.java with {fastdebug, release} VMs > > Thanks. > Best regards, > Jie This pull request has now been integrated. Changeset: 6e5000fb Author: Jie Fu Committer: John Jiang URL: https://git.openjdk.java.net/jdk11u-dev/commit/6e5000fbbec76e5a19563811d8b2ae3e832c7536 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8283424: compiler/loopopts/LoopUnswitchingBadNodeBudget.java fails with release VMs due to lack of -XX:+UnlockDiagnosticVMOptions Reviewed-by: roland ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/924 From yan at openjdk.java.net Mon Mar 21 09:50:07 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Mon, 21 Mar 2022 09:50:07 GMT Subject: [jdk13u-dev] RFR: 8283444: Bump update version for OpenJDK: jdk-13.0.12 Message-ID: Regular switch to a new version on the start of a season. ------------- Commit messages: - Bump update version for OpenJDK: jdk-13.0.12 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/331/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=331&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283444 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/331.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/331/head:pull/331 PR: https://git.openjdk.java.net/jdk13u-dev/pull/331 From yan at openjdk.java.net Mon Mar 21 10:01:47 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Mon, 21 Mar 2022 10:01:47 GMT Subject: [jdk15u-dev] RFR: 8283443: Bump update version for OpenJDK: jdk-15.0.8 Message-ID: Switch the the new (July) release in this release train. ------------- Commit messages: - 8283443: Bump update version for OpenJDK: jdk-15.0.8 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/185/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=185&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283443 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/185.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/185/head:pull/185 PR: https://git.openjdk.java.net/jdk15u-dev/pull/185 From dcherepanov at openjdk.java.net Mon Mar 21 10:10:32 2022 From: dcherepanov at openjdk.java.net (Dmitry Cherepanov) Date: Mon, 21 Mar 2022 10:10:32 GMT Subject: [jdk13u-dev] RFR: 8283444: Bump update version for OpenJDK: jdk-13.0.12 In-Reply-To: References: Message-ID: <6yn3DBFBkewHtgIygXp4WM7R8doU02mli7WUHZxRrzU=.711278cb-074a-4f8b-bcf6-7e12c2c600d2@github.com> On Mon, 21 Mar 2022 09:37:36 GMT, Yuri Nesterenko wrote: > Regular switch to a new version on the start of a season. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/331 From dcherepanov at openjdk.java.net Mon Mar 21 10:10:41 2022 From: dcherepanov at openjdk.java.net (Dmitry Cherepanov) Date: Mon, 21 Mar 2022 10:10:41 GMT Subject: [jdk15u-dev] RFR: 8283443: Bump update version for OpenJDK: jdk-15.0.8 In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 09:56:20 GMT, Yuri Nesterenko wrote: > Switch the the new (July) release in this release train. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/185 From yan at openjdk.java.net Mon Mar 21 10:16:35 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Mon, 21 Mar 2022 10:16:35 GMT Subject: [jdk15u-dev] Integrated: 8283443: Bump update version for OpenJDK: jdk-15.0.8 In-Reply-To: References: Message-ID: <-yTjw_RM5gPXtI7baD4evPtrH1hACU0Y56Cw_rBGZ_A=.61d3e854-2049-4c06-be5a-c3670f39102e@github.com> On Mon, 21 Mar 2022 09:56:20 GMT, Yuri Nesterenko wrote: > Switch the the new (July) release in this release train. This pull request has now been integrated. Changeset: 7f61f08e Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk15u-dev/commit/7f61f08e87e4eb0db13271cd834097b54b58613a Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8283443: Bump update version for OpenJDK: jdk-15.0.8 Reviewed-by: dcherepanov ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/185 From volker.simonis at gmail.com Mon Mar 21 10:21:05 2022 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 21 Mar 2022 11:21:05 +0100 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: Vote: yes On Mon, Mar 21, 2022 at 9:34 AM Tobias Hartmann wrote: > > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From yan at azul.com Mon Mar 21 10:22:07 2022 From: yan at azul.com (Yuri Nesterenko) Date: Mon, 21 Mar 2022 13:22:07 +0300 Subject: [15u notice] 15u-dev open for 15.0.8 Message-ID: <56b4362b-e8cb-dc09-a8b9-4222b9e505b0@azul.com> Hi, now https://github.com/openjdk/jdk15u-dev repository is ready for changes targeted for July 15.0.8 release. You are welcome! Thanks, --yan From yan at openjdk.java.net Mon Mar 21 10:25:35 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Mon, 21 Mar 2022 10:25:35 GMT Subject: [jdk13u-dev] Integrated: 8283444: Bump update version for OpenJDK: jdk-13.0.12 In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 09:37:36 GMT, Yuri Nesterenko wrote: > Regular switch to a new version on the start of a season. This pull request has now been integrated. Changeset: 4444442d Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk13u-dev/commit/4444442d133b04525b1fa871c725757dabb73791 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8283444: Bump update version for OpenJDK: jdk-13.0.12 Reviewed-by: dcherepanov ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/331 From yan at azul.com Mon Mar 21 10:31:13 2022 From: yan at azul.com (Yuri Nesterenko) Date: Mon, 21 Mar 2022 13:31:13 +0300 Subject: [13u notice] 13u-dev open for 13.0.12 Message-ID: <8f7e4d62-98d9-e85b-3bc2-45117022c9e3@azul.com> Hi, now https://github.com/openjdk/jdk13u-dev repository is ready for changes targeted for July 13.0.12 release. You are welcome! Thanks, --yan From chegar at openjdk.java.net Mon Mar 21 12:13:55 2022 From: chegar at openjdk.java.net (Chris Hegarty) Date: Mon, 21 Mar 2022 12:13:55 GMT Subject: [jdk17u] Withdrawn: 8282444: Module finder incorrectly assumes default file system path-separator character In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 14:55:42 GMT, Chris Hegarty wrote: > 8282444: Module finder incorrectly assumes default file system path-separator character This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk17u/pull/336 From chegar at openjdk.java.net Mon Mar 21 12:21:23 2022 From: chegar at openjdk.java.net (Chris Hegarty) Date: Mon, 21 Mar 2022 12:21:23 GMT Subject: [jdk17u-dev] RFR: 8282444: Module finder incorrectly assumes default file system path-separator character Message-ID: 8282444: Module finder incorrectly assumes default file system path-separator character ------------- Commit messages: - Backport 369291b265e13d625c5f465da9b1854c0d70c435 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/266/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=266&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282444 Stats: 10 lines in 5 files changed: 2 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/266.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/266/head:pull/266 PR: https://git.openjdk.java.net/jdk17u-dev/pull/266 From harold.seigel at oracle.com Mon Mar 21 12:26:06 2022 From: harold.seigel at oracle.com (Harold Seigel) Date: Mon, 21 Mar 2022 08:26:06 -0400 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: Vote: Yes Harold On 3/21/2022 4:33 AM, Tobias Hartmann wrote: > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From david.holmes at oracle.com Mon Mar 21 12:30:59 2022 From: david.holmes at oracle.com (David Holmes) Date: Mon, 21 Mar 2022 22:30:59 +1000 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: <4839db20-c6e6-e23b-be0b-a249eff27339@oracle.com> Vote: yes David On 21/03/2022 6:33 pm, Tobias Hartmann wrote: > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From jiefu at openjdk.java.net Mon Mar 21 13:43:34 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Mon, 21 Mar 2022 13:43:34 GMT Subject: [jdk11u-dev] RFR: 8209883: ZGC: Compile without C1 broken [v2] In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 09:15:03 GMT, Jie Fu wrote: >> Hi all, >> >> Please review the backport of "JDK-8209883 ZGC: Compile without C1 broken", which is suggested here https://github.com/openjdk/jdk11u-dev/pull/921#issuecomment-1073341167 . >> >> Although it doesn't apply cleanly, only a small adjustment is required to do this backport. >> >> Testing: >> - tier1~3 on Linux/x64, no regression. >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull request incrementally with one additional commit since the last revision: > > Address review comment Fix request had been approved. So integrate it. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/926 From goetz at openjdk.java.net Mon Mar 21 13:46:07 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 21 Mar 2022 13:46:07 GMT Subject: [jdk17u-dev] RFR: 8278472: Invalid value set to CANDIDATEFORM structure Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 2426d58e592c54de64ebe0f06448d239aeced082 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/267/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=267&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278472 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/267.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/267/head:pull/267 PR: https://git.openjdk.java.net/jdk17u-dev/pull/267 From goetz at openjdk.java.net Mon Mar 21 13:51:04 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 21 Mar 2022 13:51:04 GMT Subject: [jdk11u-dev] RFR: 8278851: Correct signer logic for jars signed with multiple digestalgs Message-ID: I backport this for parity with 11.0.16-oracle. This is based on the jdk17u-dev change as it is closer to 11 than the original. I had to resolve because of differences in Hex formatting in context lines. ------------- Commit messages: - Backport cbe497394786ff76a09f9743040e3ba96ee8298f Changes: https://git.openjdk.java.net/jdk11u-dev/pull/928/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=928&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278851 Stats: 272 lines in 4 files changed: 221 ins; 19 del; 32 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/928.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/928/head:pull/928 PR: https://git.openjdk.java.net/jdk11u-dev/pull/928 From jiefu at openjdk.java.net Mon Mar 21 13:54:34 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Mon, 21 Mar 2022 13:54:34 GMT Subject: [jdk11u-dev] Integrated: 8209883: ZGC: Compile without C1 broken In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 07:10:45 GMT, Jie Fu wrote: > Hi all, > > Please review the backport of "JDK-8209883 ZGC: Compile without C1 broken", which is suggested here https://github.com/openjdk/jdk11u-dev/pull/921#issuecomment-1073341167 . > > Although it doesn't apply cleanly, only a small adjustment is required to do this backport. > > Testing: > - tier1~3 on Linux/x64, no regression. > > Thanks. > Best regards, > Jie This pull request has now been integrated. Changeset: bb54eeb1 Author: Jie Fu Committer: John Jiang URL: https://git.openjdk.java.net/jdk11u-dev/commit/bb54eeb1cf1eb28c2cdc7bee2be9d49cda3bfae3 Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod 8209883: ZGC: Compile without C1 broken Reviewed-by: vkempik Backport-of: 14443eec10043fa86622d9e8e1d8b4a6bee22482 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/926 From goetz at openjdk.java.net Mon Mar 21 13:55:06 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 21 Mar 2022 13:55:06 GMT Subject: [jdk17u-dev] RFR: 8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport fe547eacd71b4eb8119ecc7ca2d0bbe8e757f854 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/268/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=268&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280956 Stats: 78 lines in 26 files changed: 52 ins; 0 del; 26 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/268.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/268/head:pull/268 PR: https://git.openjdk.java.net/jdk17u-dev/pull/268 From daniel.daugherty at oracle.com Mon Mar 21 14:12:28 2022 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Mon, 21 Mar 2022 10:12:28 -0400 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: <755e0301-f300-65bb-26f5-7a2e646484bc@oracle.com> Vote: yes Dan On 3/21/22 4:33 AM, Tobias Hartmann wrote: > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From goetz at openjdk.java.net Mon Mar 21 14:18:24 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 21 Mar 2022 14:18:24 GMT Subject: [jdk17u-dev] RFR: 8281262: Windows builds in different directories are not fully reproducible Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport d442328bc2f2f4bc35dd054487a78552e3d9a759 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/269/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=269&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281262 Stats: 12 lines in 3 files changed: 7 ins; 2 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/269.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/269/head:pull/269 PR: https://git.openjdk.java.net/jdk17u-dev/pull/269 From goetz.lindenmaier at sap.com Mon Mar 21 14:21:07 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Mon, 21 Mar 2022 14:21:07 +0000 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: Vote: yes Best, Goetz. > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Tobias Hartmann > Sent: Monday, March 21, 2022 9:33 AM > To: jdk-updates-dev at openjdk.java.net > Subject: CFV: New JDK Updates Committer: Christian Hagedorn > > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project > Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK > Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have > been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this > nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer- > name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=com > mits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From goetz at openjdk.java.net Mon Mar 21 14:22:07 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 21 Mar 2022 14:22:07 GMT Subject: [jdk17u-dev] RFR: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 84868e39be4522ba87e603beea0f8da9efa43b6d Changes: https://git.openjdk.java.net/jdk17u-dev/pull/270/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=270&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281275 Stats: 28 lines in 2 files changed: 23 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/270.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/270/head:pull/270 PR: https://git.openjdk.java.net/jdk17u-dev/pull/270 From goetz at openjdk.java.net Mon Mar 21 14:28:11 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 21 Mar 2022 14:28:11 GMT Subject: [jdk17u-dev] RFR: 8282295: SymbolPropertyEntry::set_method_type fails with assert Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 3e4dfc63e75db7e8ccbb21a831d8d86fb7c1ac4e Changes: https://git.openjdk.java.net/jdk17u-dev/pull/271/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=271&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282295 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/271.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/271/head:pull/271 PR: https://git.openjdk.java.net/jdk17u-dev/pull/271 From goetz at openjdk.java.net Mon Mar 21 14:33:07 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 21 Mar 2022 14:33:07 GMT Subject: [jdk17u-dev] RFR: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode Message-ID: <--H2hNvjMQDaxMLcIpSVzH0PYGckoGj0IJ8FSXZVzDo=.dc188a6e-bf8d-456e-9c57-83873b191168@github.com> I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 8aba4de98477a3bcfcde8db71e0d797965f774c7 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/272/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=272&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8249592 Stats: 26 lines in 1 file changed: 18 ins; 5 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/272/head:pull/272 PR: https://git.openjdk.java.net/jdk17u-dev/pull/272 From rreddy at openjdk.java.net Mon Mar 21 14:39:51 2022 From: rreddy at openjdk.java.net (Ravi Reddy) Date: Mon, 21 Mar 2022 14:39:51 GMT Subject: [jdk18u] Integrated: 8282583: Update BCEL md to include the copyright notice In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 04:25:51 GMT, Ravi Reddy wrote: > Clean backport of https://github.com/openjdk/jdk/commit/8478173d837113bf603aadb614badd461f474250 to jdk18u This pull request has now been integrated. Changeset: 7bdf94be Author: Ravi Reddy Committer: Sean Coffey URL: https://git.openjdk.java.net/jdk18u/commit/7bdf94be83836a4386b51b69b19299a015a4ecaf Stats: 8 lines in 1 file changed: 0 ins; 3 del; 5 mod 8282583: Update BCEL md to include the copyright notice Backport-of: 8478173d837113bf603aadb614badd461f474250 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/47 From martin.doerr at sap.com Mon Mar 21 14:42:06 2022 From: martin.doerr at sap.com (Doerr, Martin) Date: Mon, 21 Mar 2022 14:42:06 +0000 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: Vote: yes Best regards, Martin Von: jdk-updates-dev im Auftrag von Tobias Hartmann Datum: Montag, 21. M?rz 2022 um 09:34 An: jdk-updates-dev at openjdk.java.net Betreff: CFV: New JDK Updates Committer: Christian Hagedorn I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he contributed over 120 changes to the JDK project [2] many of which have been backported to older releases. Votes are due by April 4, 2022, 09:00 UTC. Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [4]. Best regards, Tobias [1] https://openjdk.java.net/census#chagedorn [2] https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits [3] https://openjdk.java.net/census#jdk-updates [4] https://openjdk.java.net/bylaws#three-vote-consensus From goetz at openjdk.java.net Mon Mar 21 14:47:14 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 21 Mar 2022 14:47:14 GMT Subject: [jdk17u-dev] RFR: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 1668c02ee83cc4f7bd7b2fe5bb7ef59b5dbda081 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/273/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=273&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277922 Stats: 212 lines in 2 files changed: 211 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/273.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/273/head:pull/273 PR: https://git.openjdk.java.net/jdk17u-dev/pull/273 From mdoerr at openjdk.java.net Mon Mar 21 14:51:40 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 21 Mar 2022 14:51:40 GMT Subject: [jdk11u-dev] RFR: 8283409: JDK11 fails to build when C1 is disabled In-Reply-To: References: Message-ID: On Sat, 19 Mar 2022 08:47:45 GMT, Jie Fu wrote: > Hi all, > > This patch fixes build failure of JDK11 when C1 compiler is disabled with `--with-jvm-features=-compiler1`. > Please review it. > > Thanks. > Best regards, > Jie LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/921 From mdoerr at openjdk.java.net Mon Mar 21 14:54:36 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 21 Mar 2022 14:54:36 GMT Subject: [jdk11u-dev] RFR: 8283409: JDK11 fails to build when C1 is disabled In-Reply-To: References: Message-ID: On Sat, 19 Mar 2022 08:47:45 GMT, Jie Fu wrote: > Hi all, > > This patch fixes build failure of JDK11 when C1 compiler is disabled with `--with-jvm-features=-compiler1`. > Please review it. > > Thanks. > Best regards, > Jie Thanks for doing it as backport of [JDK-8209883](https://bugs.openjdk.java.net/browse/JDK-8209883) Please close this PR and update [JDK-8283409](https://bugs.openjdk.java.net/browse/JDK-8283409) (close as duplicate) ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/921 From duke at openjdk.java.net Mon Mar 21 14:57:20 2022 From: duke at openjdk.java.net (Foivos) Date: Mon, 21 Mar 2022 14:57:20 GMT Subject: [jdk17u-dev] RFR: 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly Message-ID: Hi This pull request contains a backport of https://github.com/openjdk/jdk/commit/0cbc4b85bf8ab2ccfb8762322098c4cc7996df7d. The patch introduces a fix and a new test for the bug being fixed. The test fails against jdk17u-dev master prior to the patch and passes afterwards. Thanks! ------------- Commit messages: - Backport 0cbc4b85bf8ab2ccfb8762322098c4cc7996df7d Changes: https://git.openjdk.java.net/jdk17u-dev/pull/274/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=274&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281266 Stats: 46 lines in 2 files changed: 20 ins; 5 del; 21 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/274.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/274/head:pull/274 PR: https://git.openjdk.java.net/jdk17u-dev/pull/274 From mdoerr at openjdk.java.net Mon Mar 21 14:58:34 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 21 Mar 2022 14:58:34 GMT Subject: [jdk11u-dev] RFR: 8228609: G1 copy cost prediction uses used vs. actual copied bytes In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 07:45:31 GMT, Yude Lin wrote: > I would like to backport 8228609 which fixes a prediction error regarding cost per bytes copied. > > The patch does not apply cleanly, so this backport is basically changing the calculation of copied bytes. > > https://bugs.openjdk.java.net/browse/JDK-8227442 is not in 11u. So this patch also uses G1ParScanThreadState::surviving_young_words() in place of _surviving_young_words to adjust for the correct cset index. This PR is not recognized as backport. Please fix that (e.g. by changing the title to "Backport hash of original commit", https://wiki.openjdk.java.net/display/SKARA/Backports#Backports-BackportPullRequests). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/927 From mdoerr at openjdk.java.net Mon Mar 21 15:06:28 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 21 Mar 2022 15:06:28 GMT Subject: [jdk11u-dev] RFR: 8278851: Correct signer logic for jars signed with multiple digestalgs In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 13:42:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > This is based on the jdk17u-dev change as it is closer to 11 than the original. > > I had to resolve because of differences in Hex formatting in context lines. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/928 From sgehwolf at openjdk.java.net Mon Mar 21 15:08:39 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 21 Mar 2022 15:08:39 GMT Subject: [jdk17u-dev] RFR: 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly In-Reply-To: References: Message-ID: <_Fgh-twUBg5urGQu9vm-xJ1GY8HeI0LK5GsTEBi2TYo=.7fb0922e-de59-4bac-a590-fb46ae52f772@github.com> On Mon, 21 Mar 2022 14:46:10 GMT, Foivos wrote: > Hi > > This pull request contains a backport of https://github.com/openjdk/jdk/commit/0cbc4b85bf8ab2ccfb8762322098c4cc7996df7d. > > The patch introduces a fix and a new test for the bug being fixed. The test fails against jdk17u-dev master prior to the patch and passes afterwards. > > Thanks! @zakkak Please only `/integrate` once you've got push approval as per: https://wiki.openjdk.java.net/display/JDKUpdates/JDK+17u ("Fix Approvals" section). Thanks! ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/274 From duke at openjdk.java.net Mon Mar 21 15:14:31 2022 From: duke at openjdk.java.net (Foivos) Date: Mon, 21 Mar 2022 15:14:31 GMT Subject: [jdk17u-dev] RFR: 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly In-Reply-To: <_Fgh-twUBg5urGQu9vm-xJ1GY8HeI0LK5GsTEBi2TYo=.7fb0922e-de59-4bac-a590-fb46ae52f772@github.com> References: <_Fgh-twUBg5urGQu9vm-xJ1GY8HeI0LK5GsTEBi2TYo=.7fb0922e-de59-4bac-a590-fb46ae52f772@github.com> Message-ID: <5Rjvh2Iwv0rljk2IrolNSQVRryGl4aepYZr2RRVf86I=.63ab577b-6bce-4645-b660-c4894b842df5@github.com> On Mon, 21 Mar 2022 15:05:08 GMT, Severin Gehwolf wrote: > @zakkak Please only `/integrate` once you've got push approval as per: https://wiki.openjdk.java.net/display/JDKUpdates/JDK+17u ("Fix Approvals" section). Thanks! OK, I was following the bot's comment: > As you do not have [Committer](https://openjdk.java.net/bylaws#committer) status in [this project](https://openjdk.java.net/census#jdk-updates) an existing Committer must agree to [sponsor](https://openjdk.java.net/sponsor/) your change. > > ? To flag this PR as ready for integration with the above commit message, type `/integrate` in a new comment. (Afterwards, your sponsor types `/sponsor` in a new comment to perform the integration). ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/274 From sgehwolf at openjdk.java.net Mon Mar 21 15:23:50 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 21 Mar 2022 15:23:50 GMT Subject: [jdk17u-dev] RFR: 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 14:46:10 GMT, Foivos wrote: > Hi > > This pull request contains a backport of https://github.com/openjdk/jdk/commit/0cbc4b85bf8ab2ccfb8762322098c4cc7996df7d. > > The patch introduces a fix and a new test for the bug being fixed. The test fails against jdk17u-dev master prior to the patch and passes afterwards. > > Thanks! > OK, I was following the bot's comment: > > > As you do not have [Committer](https://openjdk.java.net/bylaws#committer) status in [this project](https://openjdk.java.net/census#jdk-updates) an existing Committer must agree to [sponsor](https://openjdk.java.net/sponsor/) your change. > > arrow_right To flag this PR as ready for integration with the above commit message, type `/integrate` in a new comment. (Afterwards, your sponsor types `/sponsor` in a new comment to perform the integration). Hopefully https://bugs.openjdk.java.net/browse/SKARA-1199 will improve this situation :) ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/274 From lois.foltan at oracle.com Mon Mar 21 15:47:44 2022 From: lois.foltan at oracle.com (Lois Foltan) Date: Mon, 21 Mar 2022 11:47:44 -0400 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: <88b66128-1ec6-5648-ecd3-902a90c192cb@oracle.com> Vote: yes Lois On 3/21/2022 4:33 AM, Tobias Hartmann wrote: > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From mbaesken at openjdk.java.net Mon Mar 21 15:52:34 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Mon, 21 Mar 2022 15:52:34 GMT Subject: [jdk11u-dev] RFR: JDK-8261169: Upgrade HarfBuzz to the latest 2.8.0 Message-ID: Hello, I would like to backport harfbuzz 2.8.0 to 11u-dev, so that a current harfbuzz version is used there that includes latest fixes. Awt2dLibraries.gmk needed a bit of manual adjustments. As a preparation https://bugs.openjdk.java.net/browse/JDK-8282588 had been done recently. Discussion about this issue https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-January/thread.html#11411 https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/thread.html#11937 https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-March/thread.html#12497 Thanks, Matthias ------------- Commit messages: - JDK-8261169 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/929/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=929&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261169 Stats: 57497 lines in 221 files changed: 33259 ins; 15266 del; 8972 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/929.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/929/head:pull/929 PR: https://git.openjdk.java.net/jdk11u-dev/pull/929 From thomas.stuefe at gmail.com Mon Mar 21 16:00:13 2022 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Mon, 21 Mar 2022 17:00:13 +0100 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: Vote: yes On Mon, Mar 21, 2022 at 9:34 AM Tobias Hartmann wrote: > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates > Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK > Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have > been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this > nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus > From mbaesken at openjdk.java.net Mon Mar 21 16:10:57 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Mon, 21 Mar 2022 16:10:57 GMT Subject: [jdk11u] RFR: 8275082: Update XML Security for Java to 2.3.0 Message-ID: 8275082: Update XML Security for Java to 2.3.0 ------------- Commit messages: - Backport b0c0dc5ad2eb792343d579e6ff4be31422cd9f70 Changes: https://git.openjdk.java.net/jdk11u/pull/33/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=33&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275082 Stats: 413 lines in 33 files changed: 63 ins; 267 del; 83 mod Patch: https://git.openjdk.java.net/jdk11u/pull/33.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/33/head:pull/33 PR: https://git.openjdk.java.net/jdk11u/pull/33 From clanger at openjdk.java.net Mon Mar 21 16:53:33 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 21 Mar 2022 16:53:33 GMT Subject: [jdk11u-dev] Integrated: 8283420: [AOT] Exclude TrackedFlagTest/NotTrackedFlagTest in 11u because of intermittent java.lang.AssertionError: duplicate classes for name Ljava/lang/Boolean; In-Reply-To: References: Message-ID: On Sat, 19 Mar 2022 22:44:08 GMT, Christoph Langer wrote: > We see intermittent errors in our CI systems, like here: > https://ci.sapmachine.io/job/build-11-pr-validation-linux_x86_64/61/ > https://ci.sapmachine.io/job/build-11-pr-validation-linux_x86_64/53/ > > The issue would only be fixed with a Graal update (https://bugs.openjdk.java.net/browse/JDK-8215224 from OpenJDK 12) which is probably not going to happen in OpenJDK 11u. > So we shall exclude these two tests to reduce noise in CI systems. This pull request has now been integrated. Changeset: d568fc82 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/d568fc823ee1078b5124277e91264d9d467530ff Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8283420: [AOT] Exclude TrackedFlagTest/NotTrackedFlagTest in 11u because of intermittent java.lang.AssertionError: duplicate classes for name Ljava/lang/Boolean; Reviewed-by: stuefe ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/923 From sgehwolf at openjdk.java.net Mon Mar 21 18:40:38 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 21 Mar 2022 18:40:38 GMT Subject: [jdk11u-dev] RFR: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 22:14:20 GMT, Elliott Baron wrote: > Doesn't apply cleanly because of newer backport "JDK-8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1". > > In test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java: > - One hunk in testOperatingSystemMXBeanAwareness doesn't apply because of newer fix JDK-8250984 backported ahead of this fix. > - testOperatingSystemMXBeanAwareness in 11u already matches the what it looked like after the original JDK-8250984 commit, with JDK-8244500 already present in that version: https://github.com/openjdk/jdk/blob/0187567704d79ecf394d4cb656d0ba4c886351f1/test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java#L160-L175. > - Dropping this hunk. Looks fine. Once you integrate could you please mention on the backport bug that the hunk from `TestMemoryAwareness.java` got already backported with JDK-8250984? Thanks! ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/920 From sgehwolf at openjdk.java.net Mon Mar 21 18:42:33 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 21 Mar 2022 18:42:33 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port In-Reply-To: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> Message-ID: On Thu, 17 Mar 2022 20:43:30 GMT, Aleksei Voitylov wrote: > JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Original changeset does not apply cleanly because of: > > 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, > 8215445: Enable building for Windows in WSL > 8257913: Add more known library locations to simplify Linux cross-compilation > 8244592: Start supporting SOURCE_DATE_EPOCH > 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html @voitylov Could you please resolve conflicts? Thanks! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From vladimir.kozlov at oracle.com Mon Mar 21 18:43:27 2022 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Mon, 21 Mar 2022 11:43:27 -0700 Subject: CFV: New JDK Updates Committer: Christian Hagedorn In-Reply-To: References: Message-ID: Vote: yes Thanks, Vladimir K On 3/21/22 1:33 AM, Tobias Hartmann wrote: > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From sgehwolf at openjdk.java.net Mon Mar 21 18:46:40 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 21 Mar 2022 18:46:40 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v9] In-Reply-To: <-GqFZ64AXU31jyeCbwJgojdtBx_yeQi7AeZcAEtqHms=.da92e0e0-d602-4cda-9585-eb62c95b5a5f@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> <-GqFZ64AXU31jyeCbwJgojdtBx_yeQi7AeZcAEtqHms=.da92e0e0-d602-4cda-9585-eb62c95b5a5f@github.com> Message-ID: On Thu, 17 Mar 2022 21:00:29 GMT, Zhengyu Gu wrote: > > > > A few more fix-ups are needed (see also inline comments): > > > > > 3. `PlainRead.java` would need to get the `-2` added as a "good" value. Like here: [openjdk/jdk at 01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48](https://github.com/openjdk/jdk/commit/01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48) It's part of the original JDK-8250984 fix, but wasn't part of the 11 backport when it was done. So we should add it with this backport. > > > > > > > > > Even with this change, the test still failed. > > > > > > Right. See: [#840 (comment)](https://github.com/openjdk/jdk11u-dev/pull/840#issuecomment-1067065313) > > Okay. It does not fix the test, I don't think we should include it in this patch, I would prefer to fix it separately. @zhengyu123 That's fine with me. Please rebase on top of the test changes ([JDK-8223396](https://bugs.openjdk.java.net/browse/JDK-8223396)) integrated recently and backport the test and fix from [JDK-8272124](https://bugs.openjdk.java.net/browse/JDK-8272124). Thank you. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From zgu at openjdk.java.net Mon Mar 21 20:17:44 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Mon, 21 Mar 2022 20:17:44 GMT Subject: [jdk17u-dev] Integrated: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted In-Reply-To: References: Message-ID: On Tue, 8 Feb 2022 16:27:55 GMT, Zhengyu Gu wrote: > A clean and test only backport for parity with Oracle 17.0.4. > > > Test: > - [x] Test passed on Linux x86_64. > - [x] Test passed on Windows 10. This pull request has now been integrated. Changeset: f2329d51 Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk17u-dev/commit/f2329d515f0e61880951a66ec93f2a4641139b94 Stats: 60 lines in 1 file changed: 39 ins; 0 del; 21 mod 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted Backport-of: aaedac635a0a7ca1f73dcf85336230cc537fcdf2 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/148 From ebaron at openjdk.java.net Mon Mar 21 20:21:34 2022 From: ebaron at openjdk.java.net (Elliott Baron) Date: Mon, 21 Mar 2022 20:21:34 GMT Subject: [jdk11u-dev] RFR: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java In-Reply-To: References: Message-ID: <5IGulVBJuZ6rTX5uUghz1AD504saxrCIp2JYqM2B-fc=.8e887647-ffdc-42dd-a3db-42c446a151d2@github.com> On Mon, 21 Mar 2022 18:37:29 GMT, Severin Gehwolf wrote: > Looks fine. Once you integrate could you please mention on the backport bug that the hunk from `TestMemoryAwareness.java` got already backported with JDK-8250984? Thanks! Will do, thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/920 From goetz at openjdk.java.net Mon Mar 21 20:47:04 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 21 Mar 2022 20:47:04 GMT Subject: [jdk11u-dev] RFR: 8242310: use reproducible random in hotspot compiler tests Message-ID: I backport this for parity with 11.0.16-oracle. I had to adapt the change in some places, all quite trivial: TestTrichotomyExpressions.java TestShift.java Vec_MulAddS2I.java These tests are not in 11. Skipped. ClearDirectivesFileStackTest.java Resolved Copyright. UnsafeIntrinsicsTest.java A later change doubling the test description was already backported. Applying the patch was trivial. ------------- Commit messages: - Backport 7c351405c4a43c8af40a63f63b70bfcb7719b570 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/930/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=930&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8242310 Stats: 271 lines in 91 files changed: 118 ins; 22 del; 131 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/930.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/930/head:pull/930 PR: https://git.openjdk.java.net/jdk11u-dev/pull/930 From goetz at openjdk.java.net Mon Mar 21 20:53:40 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 21 Mar 2022 20:53:40 GMT Subject: [jdk11u-dev] RFR: 8242313: use reproducible random in hotspot svc tests Message-ID: <8hIUE0AyzVYHP0G8IeLbxJwr60en3CFfy3XVD05PfxM=.70893dde-009d-44a5-85a6-249f245dadd8@github.com> I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 116fe806c3008680cfb21484f6469a5ccb638c5d Changes: https://git.openjdk.java.net/jdk11u-dev/pull/931/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=931&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8242313 Stats: 16 lines in 3 files changed: 10 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/931.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/931/head:pull/931 PR: https://git.openjdk.java.net/jdk11u-dev/pull/931 From goetz at openjdk.java.net Mon Mar 21 21:05:50 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 21 Mar 2022 21:05:50 GMT Subject: [jdk11u-dev] RFR: 8242311: use reproducible random in hotspot runtime tests Message-ID: <0DHFRd2oy5sK20PPx3MfkCGgd5xHINoEStCrj3jDy4I=.9cc72374-4a24-4e38-af09-b8fb3abc8430@github.com> I backport this for parity with 11.0.16-oracle. SharedArchiveConsistency.java GCStressApp.java GCStressTest.java Test were moved, patch applies with the following edits if the paths are adapted: Copyright in GCStressApp.java Copyright, test description in GCStressTest.java This test is not in 11: NullPointerExceptionTest.java ------------- Commit messages: - Backport c73934d8c8dcc81c85f770ce303f2cb47823785f Changes: https://git.openjdk.java.net/jdk11u-dev/pull/932/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=932&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8242311 Stats: 21 lines in 6 files changed: 7 ins; 1 del; 13 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/932.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/932/head:pull/932 PR: https://git.openjdk.java.net/jdk11u-dev/pull/932 From clanger at openjdk.java.net Mon Mar 21 21:31:42 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 21 Mar 2022 21:31:42 GMT Subject: [jdk11u-dev] RFR: 8206330: Revisit com/sun/jdi/RedefineCrossEvent.java In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 15:11:59 GMT, zzambers wrote: > This test can now be enabled. Tested locally, com/sun/jdi/RedefineCrossEvent.java as well as all other tests in test/jdk/com/sun/jdi pass for me with this backport. Unlike original changeset this backport does not touch test/jdk/com/sun/jdi/TestScaffold.java since condition there was wrong and was properly reworked in JDK-8279669 [1] (backported to jdk11u-dev). > > [1] https://bugs.openjdk.java.net/browse/JDK-8279669 Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/845 From duke at openjdk.java.net Mon Mar 21 21:39:26 2022 From: duke at openjdk.java.net (zzambers) Date: Mon, 21 Mar 2022 21:39:26 GMT Subject: [jdk11u-dev] RFR: 8206330: Revisit com/sun/jdi/RedefineCrossEvent.java In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 21:28:39 GMT, Christoph Langer wrote: >> This test can now be enabled. Tested locally, com/sun/jdi/RedefineCrossEvent.java as well as all other tests in test/jdk/com/sun/jdi pass for me with this backport. Unlike original changeset this backport does not touch test/jdk/com/sun/jdi/TestScaffold.java since condition there was wrong and was properly reworked in JDK-8279669 [1] (backported to jdk11u-dev). >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8279669 > > Marked as reviewed by clanger (Reviewer). @RealCLanger thanks for review ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/845 From duke at openjdk.java.net Mon Mar 21 22:58:37 2022 From: duke at openjdk.java.net (zzambers) Date: Mon, 21 Mar 2022 22:58:37 GMT Subject: [jdk11u-dev] Integrated: 8206330: Revisit com/sun/jdi/RedefineCrossEvent.java In-Reply-To: References: Message-ID: On Tue, 1 Mar 2022 15:11:59 GMT, zzambers wrote: > This test can now be enabled. Tested locally, com/sun/jdi/RedefineCrossEvent.java as well as all other tests in test/jdk/com/sun/jdi pass for me with this backport. Unlike original changeset this backport does not touch test/jdk/com/sun/jdi/TestScaffold.java since condition there was wrong and was properly reworked in JDK-8279669 [1] (backported to jdk11u-dev). > > [1] https://bugs.openjdk.java.net/browse/JDK-8279669 This pull request has now been integrated. Changeset: 9714b69f Author: Zdenek Zambersky Committer: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/9714b69f3981972aa4eafdebdbd669c67455822a Stats: 12 lines in 2 files changed: 0 ins; 11 del; 1 mod 8206330: Revisit com/sun/jdi/RedefineCrossEvent.java Reviewed-by: clanger Backport-of: 426873751c710061d0f9bc713a0de47373e51418 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/845 From zgu at openjdk.java.net Tue Mar 22 00:11:39 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 22 Mar 2022 00:11:39 GMT Subject: [jdk11u-dev] Integrated: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted In-Reply-To: References: Message-ID: On Wed, 9 Feb 2022 15:53:54 GMT, Zhengyu Gu wrote: > A clean, test only backport for parity with Oracle 11.0.16. > > The test passed on Windows 10. This pull request has now been integrated. Changeset: 03da67b1 Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/03da67b1b19b44490b3fc74bdcc917c53494caa6 Stats: 60 lines in 1 file changed: 39 ins; 0 del; 21 mod 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted Backport-of: aaedac635a0a7ca1f73dcf85336230cc537fcdf2 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/815 From jiefu at openjdk.java.net Tue Mar 22 00:17:51 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 22 Mar 2022 00:17:51 GMT Subject: [jdk11u-dev] RFR: 8222926: Shenandoah build fails with --with-jvm-features=-compiler1 Message-ID: Hi all, As discussed here https://github.com/openjdk/jdk11u-dev/pull/921#issuecomment-1073341167 , I'd like to backport this patch to fix the build failure of jdk11u when c1 is disabled. The patch doesn't apply cleanly since most of the changes are already in the jdk11u repo. Actually, only two include statements are added in the backport, so the risk is low. Thanks. Best regards, Jie ------------- Commit messages: - Backport c5fc45ee081b496b86c03fd1d23b5250d6b1e9a1 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/933/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=933&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8222926 Stats: 3 lines in 2 files changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/933.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/933/head:pull/933 PR: https://git.openjdk.java.net/jdk11u-dev/pull/933 From jiefu at openjdk.java.net Tue Mar 22 01:14:34 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 22 Mar 2022 01:14:34 GMT Subject: [jdk11u-dev] RFR: 8283409: JDK11 fails to build when C1 is disabled In-Reply-To: References: Message-ID: <8CQw0pSFVOJeniiT7HrJ4xaSfrPOD7VqbVKNsave57Y=.e5b1c44a-0f2c-491f-9dd2-c3dbc68f14e3@github.com> On Mon, 21 Mar 2022 07:16:21 GMT, Jie Fu wrote: > could you please instead of this, backport https://bugs.openjdk.java.net/browse/JDK-8222926 and https://bugs.openjdk.java.net/browse/JDK-8209883 into jdk11u-dev ? this will do the same in accordance to general backporting rules Hi @VladimirKempik , here is the second one : https://github.com/openjdk/jdk11u-dev/pull/933 Please review it. Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/921 From jiefu at openjdk.java.net Tue Mar 22 01:14:35 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 22 Mar 2022 01:14:35 GMT Subject: [jdk11u-dev] RFR: 8283409: JDK11 fails to build when C1 is disabled In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 14:51:25 GMT, Martin Doerr wrote: > Thanks for doing it as backport of [JDK-8209883](https://bugs.openjdk.java.net/browse/JDK-8209883) Please close this PR and update [JDK-8283409](https://bugs.openjdk.java.net/browse/JDK-8283409) (close as duplicate) Thanks @TheRealMDoerr for the review. Will do it right now. Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/921 From jiefu at openjdk.java.net Tue Mar 22 01:18:28 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 22 Mar 2022 01:18:28 GMT Subject: [jdk11u-dev] Withdrawn: 8283409: JDK11 fails to build when C1 is disabled In-Reply-To: References: Message-ID: On Sat, 19 Mar 2022 08:47:45 GMT, Jie Fu wrote: > Hi all, > > This patch fixes build failure of JDK11 when C1 compiler is disabled with `--with-jvm-features=-compiler1`. > Please review it. > > Thanks. > Best regards, > Jie This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/921 From duke at openjdk.java.net Tue Mar 22 03:55:14 2022 From: duke at openjdk.java.net (Yude Lin) Date: Tue, 22 Mar 2022 03:55:14 GMT Subject: [jdk11u-dev] RFR: 8228609: G1 copy cost prediction uses used vs. actual copied bytes [v2] In-Reply-To: References: Message-ID: > I would like to backport 8228609 which fixes a prediction error regarding cost per bytes copied. > > The patch does not apply cleanly, so this backport is basically changing the calculation of copied bytes. > > https://bugs.openjdk.java.net/browse/JDK-8227442 is not in 11u. So this patch also uses G1ParScanThreadState::surviving_young_words() in place of _surviving_young_words to adjust for the correct cset index. Yude Lin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 9a4c25731eef42d18ba0c20ff3eb42f32ae90c00 ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/927/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/927/files/45741370..89870b83 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=927&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=927&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/927.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/927/head:pull/927 PR: https://git.openjdk.java.net/jdk11u-dev/pull/927 From duke at openjdk.java.net Tue Mar 22 03:58:57 2022 From: duke at openjdk.java.net (Yude Lin) Date: Tue, 22 Mar 2022 03:58:57 GMT Subject: [jdk11u-dev] RFR: 8228609: G1 copy cost prediction uses used vs. actual copied bytes [v3] In-Reply-To: References: Message-ID: > I would like to backport 8228609 which fixes a prediction error regarding cost per bytes copied. > > The patch does not apply cleanly, so this backport is basically changing the calculation of copied bytes. > > https://bugs.openjdk.java.net/browse/JDK-8227442 is not in 11u. So this patch also uses G1ParScanThreadState::surviving_young_words() in place of _surviving_young_words to adjust for the correct cset index. Yude Lin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8228609: G1 copy cost prediction uses used vs. actual copied bytes ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/927/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/927/files/89870b83..be565894 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=927&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=927&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/927.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/927/head:pull/927 PR: https://git.openjdk.java.net/jdk11u-dev/pull/927 From goetz at openjdk.java.net Tue Mar 22 07:02:42 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 07:02:42 GMT Subject: [jdk17u-dev] Integrated: 8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 13:47:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 5c8ce904 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/5c8ce904d1a4c5144d597fd2ddf39bc4f12f159e Stats: 78 lines in 26 files changed: 52 ins; 0 del; 26 mod 8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y Backport-of: fe547eacd71b4eb8119ecc7ca2d0bbe8e757f854 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/268 From goetz at openjdk.java.net Tue Mar 22 07:04:50 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 07:04:50 GMT Subject: [jdk17u-dev] RFR: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths In-Reply-To: References: Message-ID: <2CqRjaabOijk1aaUu-pNrGxyHV7CE-839FwoODagkm8=.34e66adc-d8d8-453a-9e8c-e53fbaf7bb09@github.com> On Mon, 21 Mar 2022 14:13:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Pre-submit failure: gzip decompression failed. Infrastructore problem, unrelated. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/270 From goetz at openjdk.java.net Tue Mar 22 07:09:50 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 07:09:50 GMT Subject: [jdk17u-dev] RFR: 8282295: SymbolPropertyEntry::set_method_type fails with assert In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 14:21:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Pre-submit failure: java/foreign/TestResourceScope.java Subtest: TestResourceScope.testSharedMultiThread() AssertionError: expected [4950] but found incubator feature Unrelated. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/271 From goetz at openjdk.java.net Tue Mar 22 07:13:32 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 07:13:32 GMT Subject: [jdk17u-dev] RFR: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode In-Reply-To: <--H2hNvjMQDaxMLcIpSVzH0PYGckoGj0IJ8FSXZVzDo=.dc188a6e-bf8d-456e-9c57-83873b191168@github.com> References: <--H2hNvjMQDaxMLcIpSVzH0PYGckoGj0IJ8FSXZVzDo=.dc188a6e-bf8d-456e-9c57-83873b191168@github.com> Message-ID: On Mon, 21 Mar 2022 14:23:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Pre-submit failure: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 fails regularly, unrelated ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/272 From goetz at openjdk.java.net Tue Mar 22 07:17:34 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 07:17:34 GMT Subject: [jdk11u-dev] RFR: 8278851: Correct signer logic for jars signed with multiple digestalgs In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 13:42:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > This is based on the jdk17u-dev change as it is closer to 11 than the original. > > I had to resolve because of differences in Hex formatting in context lines. Pre-submit failure: runtime/Thread/StopAtExit.java fixed in jdk11u ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/928 From yan at openjdk.java.net Tue Mar 22 07:26:39 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Tue, 22 Mar 2022 07:26:39 GMT Subject: [jdk11u] RFR: 8275082: Update XML Security for Java to 2.3.0 In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 16:02:46 GMT, Matthias Baesken wrote: > 8275082: Update XML Security for Java to 2.3.0 I guess the first two failures in presubmit testing are the same or similar to that in Goetz's https://github.com/openjdk/jdk11u/pull/32 ------------- Marked as reviewed by yan (Reviewer). PR: https://git.openjdk.java.net/jdk11u/pull/33 From goetz at openjdk.java.net Tue Mar 22 07:56:10 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 07:56:10 GMT Subject: [jdk17u-dev] RFR: 8255266: Update Public Suffix List to 3c213aa Message-ID: I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 7ce75afbbcca7635356c7377be7ddff15335e563 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/275/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=275&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255266 Stats: 1254 lines in 5 files changed: 887 ins; 215 del; 152 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/275.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/275/head:pull/275 PR: https://git.openjdk.java.net/jdk17u-dev/pull/275 From goetz at openjdk.java.net Tue Mar 22 08:00:10 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 08:00:10 GMT Subject: [jdk17u-dev] RFR: 8282583: Update BCEL md to include the copyright notice Message-ID: <1dDYOEik0e2IxSawwU_98DYDjj6_BhpS-tUFZfmCH9I=.f35d1c21-e63d-4473-be8b-32fd86c0a562@github.com> I backport this for parity with 17.0.4-oracle. ------------- Commit messages: - Backport 8478173d837113bf603aadb614badd461f474250 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/276/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=276&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282583 Stats: 8 lines in 1 file changed: 0 ins; 3 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/276.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/276/head:pull/276 PR: https://git.openjdk.java.net/jdk17u-dev/pull/276 From goetz at openjdk.java.net Tue Mar 22 08:00:31 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 08:00:31 GMT Subject: [jdk11u-dev] RFR: 8222926: Shenandoah build fails with --with-jvm-features=-compiler1 In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 00:10:53 GMT, Jie Fu wrote: > Hi all, > > As discussed here https://github.com/openjdk/jdk11u-dev/pull/921#issuecomment-1073341167 , I'd like to backport this patch to fix the build failure of jdk11u when c1 is disabled. > > The patch doesn't apply cleanly since most of the changes are already in the jdk11u repo. > Actually, only two include statements are added in the backport, so the risk is low. > > Thanks. > Best regards, > Jie Please undo the copyright change. A backport should only change the copyright if the original change did so. Please point out the change that backported all the other content. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/933 From jiefu at openjdk.java.net Tue Mar 22 08:26:39 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 22 Mar 2022 08:26:39 GMT Subject: [jdk11u-dev] RFR: 8222926: Shenandoah build fails with --with-jvm-features=-compiler1 In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 07:56:51 GMT, Goetz Lindenmaier wrote: > Please undo the copyright change. A backport should only change the copyright if the original change did so. I'm fine to revert the copyright change. The copyright was changed since the patch didn't apply cleanly, so I just made the change by hand. Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/933 From jiefu at openjdk.java.net Tue Mar 22 08:32:30 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 22 Mar 2022 08:32:30 GMT Subject: [jdk11u-dev] RFR: 8222926: Shenandoah build fails with --with-jvm-features=-compiler1 In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 07:56:51 GMT, Goetz Lindenmaier wrote: > Please point out the change that backported all the other content. Hi @GoeLin , please see here: https://bugs.openjdk.java.net/browse/JDK-8250784 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/933 From jiefu at openjdk.java.net Tue Mar 22 08:36:09 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 22 Mar 2022 08:36:09 GMT Subject: [jdk11u-dev] RFR: 8222926: Shenandoah build fails with --with-jvm-features=-compiler1 [v2] In-Reply-To: References: Message-ID: <64BpMyP9S4wGBGa9gJngK_6OgjKFo-6bf3adb5RH-8M=.8f1774ab-7fd1-4b07-9812-83b5afd1113a@github.com> > Hi all, > > As discussed here https://github.com/openjdk/jdk11u-dev/pull/921#issuecomment-1073341167 , I'd like to backport this patch to fix the build failure of jdk11u when c1 is disabled. > > The patch doesn't apply cleanly since most of the changes are already in the jdk11u repo. > Actually, only two include statements are added in the backport, so the risk is low. > > Thanks. > Best regards, > Jie Jie Fu has updated the pull request incrementally with one additional commit since the last revision: Revert copyright change ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/933/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/933/files/6a16d0bf..53f7b1e5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=933&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=933&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/933.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/933/head:pull/933 PR: https://git.openjdk.java.net/jdk11u-dev/pull/933 From jiefu at openjdk.java.net Tue Mar 22 08:36:10 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 22 Mar 2022 08:36:10 GMT Subject: [jdk11u-dev] RFR: 8222926: Shenandoah build fails with --with-jvm-features=-compiler1 In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 08:23:31 GMT, Jie Fu wrote: > Please undo the copyright change. A backport should only change the copyright if the original change did so. Updated. Thanks. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/933 From vkempik at openjdk.java.net Tue Mar 22 08:48:42 2022 From: vkempik at openjdk.java.net (Vladimir Kempik) Date: Tue, 22 Mar 2022 08:48:42 GMT Subject: [jdk11u-dev] RFR: 8222926: Shenandoah build fails with --with-jvm-features=-compiler1 [v2] In-Reply-To: <64BpMyP9S4wGBGa9gJngK_6OgjKFo-6bf3adb5RH-8M=.8f1774ab-7fd1-4b07-9812-83b5afd1113a@github.com> References: <64BpMyP9S4wGBGa9gJngK_6OgjKFo-6bf3adb5RH-8M=.8f1774ab-7fd1-4b07-9812-83b5afd1113a@github.com> Message-ID: On Tue, 22 Mar 2022 08:36:09 GMT, Jie Fu wrote: >> Hi all, >> >> As discussed here https://github.com/openjdk/jdk11u-dev/pull/921#issuecomment-1073341167 , I'd like to backport this patch to fix the build failure of jdk11u when c1 is disabled. >> >> The patch doesn't apply cleanly since most of the changes are already in the jdk11u repo. >> Actually, only two include statements are added in the backport, so the risk is low. >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull request incrementally with one additional commit since the last revision: > > Revert copyright change Marked as reviewed by vkempik (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/933 From jiefu at openjdk.java.net Tue Mar 22 09:24:35 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 22 Mar 2022 09:24:35 GMT Subject: [jdk11u-dev] RFR: 8222926: Shenandoah build fails with --with-jvm-features=-compiler1 [v2] In-Reply-To: <64BpMyP9S4wGBGa9gJngK_6OgjKFo-6bf3adb5RH-8M=.8f1774ab-7fd1-4b07-9812-83b5afd1113a@github.com> References: <64BpMyP9S4wGBGa9gJngK_6OgjKFo-6bf3adb5RH-8M=.8f1774ab-7fd1-4b07-9812-83b5afd1113a@github.com> Message-ID: On Tue, 22 Mar 2022 08:36:09 GMT, Jie Fu wrote: >> Hi all, >> >> As discussed here https://github.com/openjdk/jdk11u-dev/pull/921#issuecomment-1073341167 , I'd like to backport this patch to fix the build failure of jdk11u when c1 is disabled. >> >> The patch doesn't apply cleanly since most of the changes are already in the jdk11u repo. >> Actually, only two include statements are added in the backport, so the risk is low. >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull request incrementally with one additional commit since the last revision: > > Revert copyright change Fix request had been approved. So integrate it. Thanks @VladimirKempik and @GoeLin . ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/933 From clanger at openjdk.java.net Tue Mar 22 09:24:41 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 22 Mar 2022 09:24:41 GMT Subject: [jdk11u-dev] Integrated: 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 09:12:01 GMT, Christoph Langer wrote: > Clean backport, only resolved one copyright header diff. > > I'm backporting this because it resolves an issue with jlink when using it with a debian package that was built with debuild. We got a report here in SapMachine: https://github.com/SAP/SapMachine/issues/1009 > > debuild seems to modify the jmod files in a way that the hash computation as of JDK11 will yield different results (e.g. timestamps of files differ). The modified hash calculation solves this. This pull request has now been integrated. Changeset: 7c29f0e8 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/7c29f0e88cfd9dbe66b7c8355bfd13b2dfce50bd Stats: 189 lines in 5 files changed: 129 ins; 21 del; 39 mod 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps Backport-of: fe152cdcc5c6ef7e7f3f8c0acf065049e40ee2ea ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/916 From goetz at openjdk.java.net Tue Mar 22 09:27:54 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 09:27:54 GMT Subject: [jdk17u-dev] RFR: 8278472: Invalid value set to CANDIDATEFORM structure In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 13:34:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Pre-submit falure: gzip: stdin: invalid compressed data--format violated Infrastructure, unrelated ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/267 From goetz at openjdk.java.net Tue Mar 22 09:27:55 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 09:27:55 GMT Subject: [jdk17u-dev] Integrated: 8278472: Invalid value set to CANDIDATEFORM structure In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 13:34:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: ea167d7c Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/ea167d7ce9aa3364f76a454f28b4c9fc8598e0cb Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8278472: Invalid value set to CANDIDATEFORM structure Backport-of: 2426d58e592c54de64ebe0f06448d239aeced082 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/267 From jiefu at openjdk.java.net Tue Mar 22 09:30:38 2022 From: jiefu at openjdk.java.net (Jie Fu) Date: Tue, 22 Mar 2022 09:30:38 GMT Subject: [jdk11u-dev] Integrated: 8222926: Shenandoah build fails with --with-jvm-features=-compiler1 In-Reply-To: References: Message-ID: <8KkyM4euE-iB5r3posrBLPUhL78Nw4DqpQPH6AY4ei8=.343e928d-c430-4637-b0bc-395db39c4c93@github.com> On Tue, 22 Mar 2022 00:10:53 GMT, Jie Fu wrote: > Hi all, > > As discussed here https://github.com/openjdk/jdk11u-dev/pull/921#issuecomment-1073341167 , I'd like to backport this patch to fix the build failure of jdk11u when c1 is disabled. > > The patch doesn't apply cleanly since most of the changes are already in the jdk11u repo. > Actually, only two include statements are added in the backport, so the risk is low. > > Thanks. > Best regards, > Jie This pull request has now been integrated. Changeset: 31d7b5eb Author: Jie Fu Committer: John Jiang URL: https://git.openjdk.java.net/jdk11u-dev/commit/31d7b5ebc40c45b46ef35d1c89735b7b31806380 Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod 8222926: Shenandoah build fails with --with-jvm-features=-compiler1 Reviewed-by: vkempik Backport-of: c5fc45ee081b496b86c03fd1d23b5250d6b1e9a1 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/933 From goetz at openjdk.java.net Tue Mar 22 09:34:42 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 09:34:42 GMT Subject: [jdk17u-dev] Integrated: 8281262: Windows builds in different directories are not fully reproducible In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 14:10:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: bd360ab5 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/bd360ab55760e94b80b7d0af6c55fd137f23c0e4 Stats: 12 lines in 3 files changed: 7 ins; 2 del; 3 mod 8281262: Windows builds in different directories are not fully reproducible Backport-of: d442328bc2f2f4bc35dd054487a78552e3d9a759 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/269 From goetz at openjdk.java.net Tue Mar 22 09:42:51 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 09:42:51 GMT Subject: [jdk17u-dev] Integrated: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 14:13:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: aafda8cd Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/aafda8cd477421f1b7d59f650b98f2ba6bdfe344 Stats: 28 lines in 2 files changed: 23 ins; 0 del; 5 mod 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths Backport-of: 84868e39be4522ba87e603beea0f8da9efa43b6d ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/270 From goetz at openjdk.java.net Tue Mar 22 09:45:50 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 09:45:50 GMT Subject: [jdk17u-dev] Integrated: 8282295: SymbolPropertyEntry::set_method_type fails with assert In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 14:21:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: a637773e Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/a637773e23615992c83027f60958b9e14b754729 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8282295: SymbolPropertyEntry::set_method_type fails with assert Backport-of: 3e4dfc63e75db7e8ccbb21a831d8d86fb7c1ac4e ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/271 From avoitylov at openjdk.java.net Tue Mar 22 09:46:03 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Tue, 22 Mar 2022 09:46:03 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v2] In-Reply-To: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> Message-ID: <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> > JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Original changeset does not apply cleanly because of: > > 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, > 8215445: Enable building for Windows in WSL > 8257913: Add more known library locations to simplify Linux cross-compilation > 8244592: Start supporting SOURCE_DATE_EPOCH > 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html Aleksei Voitylov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JDK-8247589 backport to 11u ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/910/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=910&range=01 Stats: 400 lines in 29 files changed: 347 ins; 17 del; 36 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/910.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/910/head:pull/910 PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From goetz at openjdk.java.net Tue Mar 22 09:48:39 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 09:48:39 GMT Subject: [jdk17u-dev] Integrated: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode In-Reply-To: <--H2hNvjMQDaxMLcIpSVzH0PYGckoGj0IJ8FSXZVzDo=.dc188a6e-bf8d-456e-9c57-83873b191168@github.com> References: <--H2hNvjMQDaxMLcIpSVzH0PYGckoGj0IJ8FSXZVzDo=.dc188a6e-bf8d-456e-9c57-83873b191168@github.com> Message-ID: On Mon, 21 Mar 2022 14:23:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 9bfb3229 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/9bfb32297584757b3e76a58cd16234000a50c405 Stats: 26 lines in 1 file changed: 18 ins; 5 del; 3 mod 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode Backport-of: 8aba4de98477a3bcfcde8db71e0d797965f774c7 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/272 From goetz at openjdk.java.net Tue Mar 22 09:52:44 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 09:52:44 GMT Subject: [jdk17u-dev] Integrated: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 14:37:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: a7efccab Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/a7efccab6dbf6ec5821adfda87eed731b4214890 Stats: 212 lines in 2 files changed: 211 ins; 0 del; 1 mod 8277922: Unable to click JCheckBox in JTable through Java Access Bridge Backport-of: 1668c02ee83cc4f7bd7b2fe5bb7ef59b5dbda081 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/273 From goetz at openjdk.java.net Tue Mar 22 09:58:42 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 09:58:42 GMT Subject: [jdk11u-dev] Integrated: 8278851: Correct signer logic for jars signed with multiple digestalgs In-Reply-To: References: Message-ID: <90opk4AV9IphThQIOk2dmVAPvOM4eEsMLfdW-XH0o50=.36e6bf08-8d0e-45ea-9b62-59a34f51afc4@github.com> On Mon, 21 Mar 2022 13:42:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > This is based on the jdk17u-dev change as it is closer to 11 than the original. > > I had to resolve because of differences in Hex formatting in context lines. This pull request has now been integrated. Changeset: 79c45a59 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/79c45a5963edd40eab42e40c456a4f28cba65501 Stats: 272 lines in 4 files changed: 221 ins; 19 del; 32 mod 8278851: Correct signer logic for jars signed with multiple digestalgs Reviewed-by: mdoerr Backport-of: cbe497394786ff76a09f9743040e3ba96ee8298f ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/928 From stuefe at openjdk.java.net Tue Mar 22 10:53:58 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 22 Mar 2022 10:53:58 GMT Subject: [jdk17u-dev] RFR: 8280543: Update the "java" and "jcmd" tool specification for CDS Message-ID: Not a clean backport. I had to remove mentioning of the "dynamic_dump" option since its not supported in jdk17. ------------- Commit messages: - Backport 39165613aa0430861e361a33a4925b85ea24fff1 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/277/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=277&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280543 Stats: 544 lines in 2 files changed: 73 ins; 364 del; 107 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/277.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/277/head:pull/277 PR: https://git.openjdk.java.net/jdk17u-dev/pull/277 From stuefe at openjdk.java.net Tue Mar 22 10:53:59 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 22 Mar 2022 10:53:59 GMT Subject: [jdk17u-dev] RFR: 8280543: Update the "java" and "jcmd" tool specification for CDS In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 10:46:00 GMT, Thomas Stuefe wrote: > Not a clean backport. > > I had to remove mentioning of the "dynamic_dump" option since its not supported in jdk17. I testbuilt the manpages manually on Ubuntu 20.4, and checked that they looked okay and made sense. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/277 From mdoerr at openjdk.java.net Tue Mar 22 11:07:35 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 22 Mar 2022 11:07:35 GMT Subject: [jdk11u-dev] RFR: JDK-8261169: Upgrade HarfBuzz to the latest 2.8.0 In-Reply-To: References: Message-ID: <8GMLOdyJ2HL1tnppkGb1rbs6C-LkVigoI5WyYbJrpDw=.99a80346-90c8-41f7-9752-3e53cba71f88@github.com> On Mon, 21 Mar 2022 15:46:30 GMT, Matthias Baesken wrote: > Hello, I would like to backport harfbuzz 2.8.0 to 11u-dev, so that a current harfbuzz version is used there that includes latest fixes. Awt2dLibraries.gmk needed a bit of manual adjustments. > As a preparation https://bugs.openjdk.java.net/browse/JDK-8282588 had been done recently. > > Discussion about this issue > https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-January/thread.html#11411 > https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/thread.html#11937 > https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-March/thread.html#12497 > > Thanks, Matthias Backport looks good. Harfbuzz matches the version from 13u-dev exactly, now. Note that Skara doesn't recognize it as backport. I suggest to change the bug id to [JDK-8267977](https://bugs.openjdk.java.net/browse/JDK-8267977) which was already created for this backport. Please check if https://bugs.openjdk.java.net/browse/JDK-8266545 is also needed. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/929 From avoitylov at openjdk.java.net Tue Mar 22 11:19:40 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Tue, 22 Mar 2022 11:19:40 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port In-Reply-To: References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> Message-ID: On Mon, 21 Mar 2022 18:39:20 GMT, Severin Gehwolf wrote: >> JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. >> >> Original changeset does not apply cleanly because of: >> >> 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, >> 8215445: Enable building for Windows in WSL >> 8257913: Add more known library locations to simplify Linux cross-compilation >> 8244592: Start supporting SOURCE_DATE_EPOCH >> 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes >> >> Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. >> >> [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html > > @voitylov Could you please resolve conflicts? Thanks! @jerboaa merge conflict with 8246494 is now resolved. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From mdoerr at openjdk.java.net Tue Mar 22 11:27:25 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 22 Mar 2022 11:27:25 GMT Subject: [jdk11u-dev] RFR: 8242310: use reproducible random in hotspot compiler tests In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 20:40:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to adapt the change in some places, all quite trivial: > > TestTrichotomyExpressions.java > TestShift.java > Vec_MulAddS2I.java > These tests are not in 11. Skipped. > > ClearDirectivesFileStackTest.java > Resolved Copyright. > > UnsafeIntrinsicsTest.java > A later change doubling the test description was already backported. > Applying the patch was trivial. LGTM. Thanks for the detailed description. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/930 From mdoerr at openjdk.java.net Tue Mar 22 11:28:36 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 22 Mar 2022 11:28:36 GMT Subject: [jdk11u-dev] RFR: 8242311: use reproducible random in hotspot runtime tests In-Reply-To: <0DHFRd2oy5sK20PPx3MfkCGgd5xHINoEStCrj3jDy4I=.9cc72374-4a24-4e38-af09-b8fb3abc8430@github.com> References: <0DHFRd2oy5sK20PPx3MfkCGgd5xHINoEStCrj3jDy4I=.9cc72374-4a24-4e38-af09-b8fb3abc8430@github.com> Message-ID: On Mon, 21 Mar 2022 20:58:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > SharedArchiveConsistency.java > GCStressApp.java > GCStressTest.java > Test were moved, patch applies with the following edits if the paths are adapted: > Copyright in GCStressApp.java > Copyright, test description in GCStressTest.java > > This test is not in 11: NullPointerExceptionTest.java Marked as reviewed by mdoerr (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/932 From mdoerr at openjdk.java.net Tue Mar 22 11:55:32 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 22 Mar 2022 11:55:32 GMT Subject: [jdk17u-dev] RFR: 8280543: Update the "java" and "jcmd" tool specification for CDS In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 10:46:00 GMT, Thomas Stuefe wrote: > Not a clean backport. > > I had to remove mentioning of the "dynamic_dump" option since its not supported in jdk17. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/277 From mbaesken at openjdk.java.net Tue Mar 22 13:25:09 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 22 Mar 2022 13:25:09 GMT Subject: [jdk17u-dev] RFR: 8282345: handle latest VS2022 in abstract_vm_version Message-ID: 8282345: handle latest VS2022 in abstract_vm_version ------------- Commit messages: - Backport 735e86b0f71c97c2ba35c1cffd9b4492a8ca55bc Changes: https://git.openjdk.java.net/jdk17u-dev/pull/278/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=278&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282345 Stats: 10 lines in 1 file changed: 4 ins; 4 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/278.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/278/head:pull/278 PR: https://git.openjdk.java.net/jdk17u-dev/pull/278 From mbaesken at openjdk.java.net Tue Mar 22 13:55:02 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 22 Mar 2022 13:55:02 GMT Subject: [jdk17u-dev] RFR: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info Message-ID: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info ------------- Commit messages: - Backport bb2e10ccea0c0b89b06ace034c99253e9999ec47 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/279/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=279&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281274 Stats: 16 lines in 2 files changed: 14 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/279.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/279/head:pull/279 PR: https://git.openjdk.java.net/jdk17u-dev/pull/279 From mdoerr at openjdk.java.net Tue Mar 22 14:34:07 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 22 Mar 2022 14:34:07 GMT Subject: [jdk17u-dev] RFR: 8281338: NSAccessibilityPressAction action for tree node and NSAccessibilityShowMenuAcgtion action not working Message-ID: Clean backport of [JDK-8281338](https://bugs.openjdk.java.net/browse/JDK-8281338) ------------- Commit messages: - Backport cb2f8caed2de1bf0a85a7ebfd232c36371e06c98 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/280/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=280&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281338 Stats: 185 lines in 2 files changed: 183 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/280.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/280/head:pull/280 PR: https://git.openjdk.java.net/jdk17u-dev/pull/280 From goetz at openjdk.java.net Tue Mar 22 15:19:05 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 15:19:05 GMT Subject: [jdk11u-dev] RFR: 8278472: Invalid value set to CANDIDATEFORM structure Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 2426d58e592c54de64ebe0f06448d239aeced082 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/934/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=934&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278472 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/934.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/934/head:pull/934 PR: https://git.openjdk.java.net/jdk11u-dev/pull/934 From goetz at openjdk.java.net Tue Mar 22 15:23:06 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 15:23:06 GMT Subject: [jdk11u-dev] RFR: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths Message-ID: I backport this for parity with 11.0.16-oracle. I had to resolve the copyrights, the rest applied clean. Marking as clean backport. ------------- Commit messages: - Backport 84868e39be4522ba87e603beea0f8da9efa43b6d Changes: https://git.openjdk.java.net/jdk11u-dev/pull/935/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=935&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281275 Stats: 28 lines in 2 files changed: 23 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/935.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/935/head:pull/935 PR: https://git.openjdk.java.net/jdk11u-dev/pull/935 From goetz at openjdk.java.net Tue Mar 22 15:25:52 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 15:25:52 GMT Subject: [jdk17u-dev] RFR: 8282583: Update BCEL md to include the copyright notice In-Reply-To: <1dDYOEik0e2IxSawwU_98DYDjj6_BhpS-tUFZfmCH9I=.f35d1c21-e63d-4473-be8b-32fd86c0a562@github.com> References: <1dDYOEik0e2IxSawwU_98DYDjj6_BhpS-tUFZfmCH9I=.f35d1c21-e63d-4473-be8b-32fd86c0a562@github.com> Message-ID: On Tue, 22 Mar 2022 07:51:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. Pre-submit failure: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 seen sporadically. Unrelated to this change. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/276 From goetz at openjdk.java.net Tue Mar 22 15:25:53 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 15:25:53 GMT Subject: [jdk17u-dev] Integrated: 8282583: Update BCEL md to include the copyright notice In-Reply-To: <1dDYOEik0e2IxSawwU_98DYDjj6_BhpS-tUFZfmCH9I=.f35d1c21-e63d-4473-be8b-32fd86c0a562@github.com> References: <1dDYOEik0e2IxSawwU_98DYDjj6_BhpS-tUFZfmCH9I=.f35d1c21-e63d-4473-be8b-32fd86c0a562@github.com> Message-ID: On Tue, 22 Mar 2022 07:51:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: 937b55c0 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/937b55c0db059e39081ec3b64b6a926891e6c0c3 Stats: 8 lines in 1 file changed: 0 ins; 3 del; 5 mod 8282583: Update BCEL md to include the copyright notice Backport-of: 8478173d837113bf603aadb614badd461f474250 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/276 From goetz at openjdk.java.net Tue Mar 22 15:34:58 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 15:34:58 GMT Subject: [jdk11u-dev] RFR: 8282583: Update BCEL md to include the copyright notice Message-ID: <3BLv8XtmL5ORqMxeBYufjJ9l0i0WYgszL5TqyQ_BUX0=.4b83059f-8513-43dd-92e9-73f5cd5a2b0b@github.com> I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 8478173d837113bf603aadb614badd461f474250 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/936/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=936&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282583 Stats: 8 lines in 1 file changed: 0 ins; 3 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/936.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/936/head:pull/936 PR: https://git.openjdk.java.net/jdk11u-dev/pull/936 From goetz at openjdk.java.net Tue Mar 22 15:42:02 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 15:42:02 GMT Subject: [jdk11u-dev] RFR: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 8aba4de98477a3bcfcde8db71e0d797965f774c7 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/937/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=937&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8249592 Stats: 26 lines in 1 file changed: 18 ins; 5 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/937.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/937/head:pull/937 PR: https://git.openjdk.java.net/jdk11u-dev/pull/937 From jdowland at openjdk.java.net Tue Mar 22 15:45:49 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Tue, 22 Mar 2022 15:45:49 GMT Subject: [jdk17u-dev] Integrated: 8193682: Infinite loop in ZipOutputStream.close() In-Reply-To: References: Message-ID: On Fri, 4 Feb 2022 12:28:57 GMT, Jonathan Dowland wrote: > Hi > > This pull request contains a backport of commit [1e9ed54d](https://github.com/openjdk/jdk/commit/1e9ed54d362b8c57be5fbbac2de5afbd0f05435f) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Ravi Reddy on 1 Dec 2021 and was reviewed by Lance Andersen and Sean Coffey. > > This is a backport for Oracle parity. The patch introduces a new test for the bug. The test fails against jdk17u-dev master prior to the patch and passes afterwards. > > Thanks! This pull request has now been integrated. Changeset: d19ec6f8 Author: Jonathan Dowland Committer: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/d19ec6f8c68e2d542434554b84696bc504e1cccb Stats: 258 lines in 4 files changed: 191 ins; 29 del; 38 mod 8193682: Infinite loop in ZipOutputStream.close() Backport-of: 1e9ed54d362b8c57be5fbbac2de5afbd0f05435f ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/147 From goetz at openjdk.java.net Tue Mar 22 15:49:52 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 22 Mar 2022 15:49:52 GMT Subject: [jdk11u-dev] Integrated: 8193682: Infinite loop in ZipOutputStream.close() In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 08:35:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > > It does not apply because "8267587: Update java.util to use enhanced switch" > is not in 11. I removed the new switch constructs from the code. This pull request has now been integrated. Changeset: b0d7b5a6 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/b0d7b5a663a3fdd3d46fd2ea1fa5f8a0e81ee9e8 Stats: 257 lines in 4 files changed: 189 ins; 25 del; 43 mod 8193682: Infinite loop in ZipOutputStream.close() Reviewed-by: mdoerr Backport-of: 1e9ed54d362b8c57be5fbbac2de5afbd0f05435f ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/914 From mdoerr at openjdk.java.net Tue Mar 22 16:16:31 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 22 Mar 2022 16:16:31 GMT Subject: [jdk11u-dev] RFR: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 15:15:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to resolve the copyrights, the rest applied clean. Marking as clean backport. Marked as reviewed by mdoerr (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/935 From zgu at openjdk.java.net Tue Mar 22 16:19:33 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 22 Mar 2022 16:19:33 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v9] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> <-GqFZ64AXU31jyeCbwJgojdtBx_yeQi7AeZcAEtqHms=.da92e0e0-d602-4cda-9585-eb62c95b5a5f@github.com> Message-ID: On Mon, 21 Mar 2022 18:43:10 GMT, Severin Gehwolf wrote: > > > > > A few more fix-ups are needed (see also inline comments): > > > > > > 3. `PlainRead.java` would need to get the `-2` added as a "good" value. Like here: [openjdk/jdk at 01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48](https://github.com/openjdk/jdk/commit/01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48) It's part of the original JDK-8250984 fix, but wasn't part of the 11 backport when it was done. So we should add it with this backport. > > > > > > > > > > > > Even with this change, the test still failed. > > > > > > > > > Right. See: [#840 (comment)](https://github.com/openjdk/jdk11u-dev/pull/840#issuecomment-1067065313) > > > > > > Okay. It does not fix the test, I don't think we should include it in this patch, I would prefer to fix it separately. > > @zhengyu123 That's fine with me. Please rebase on top of the test changes ([JDK-8223396](https://bugs.openjdk.java.net/browse/JDK-8223396)) integrated recently and backport the test and fix from [JDK-8272124](https://bugs.openjdk.java.net/browse/JDK-8272124). Thank you. I think all 4 PRs are lined up for push. Once this review is done, I will request for approvals for all 4. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From sgehwolf at openjdk.java.net Tue Mar 22 16:54:39 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 22 Mar 2022 16:54:39 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v2] In-Reply-To: <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> Message-ID: On Tue, 22 Mar 2022 09:46:03 GMT, Aleksei Voitylov wrote: >> JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. >> >> Original changeset does not apply cleanly because of: >> >> 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, >> 8215445: Enable building for Windows in WSL >> 8257913: Add more known library locations to simplify Linux cross-compilation >> 8244592: Start supporting SOURCE_DATE_EPOCH >> 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes >> >> Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. >> >> [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html > > Aleksei Voitylov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > JDK-8247589 backport to 11u This looks OK to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From jdowland at openjdk.java.net Tue Mar 22 17:02:58 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Tue, 22 Mar 2022 17:02:58 GMT Subject: [jdk17u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() In-Reply-To: References: <4DpUi5DwcXjmaSojcPrnurkMU4kNYmZZujoAnzHcAAc=.b57f88b4-be53-4f82-8347-23168fea88e6@github.com> Message-ID: On Sun, 20 Mar 2022 19:38:58 GMT, Goetz Lindenmaier wrote: >> @zhengyu123 thank you for your reply! I meant to get back to this one today. It is clean, but the original bug needed a CSR, so I believe I need to raise a CSR for the backport too. I just didn't get around to looking into that yet. Am I right? > > @jmtd, this is all ready now, could you please integrate the PR? @GoeLin thank you for sorting out the CSR! ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/147 From sgehwolf at openjdk.java.net Tue Mar 22 17:11:35 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 22 Mar 2022 17:11:35 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v9] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> <-GqFZ64AXU31jyeCbwJgojdtBx_yeQi7AeZcAEtqHms=.da92e0e0-d602-4cda-9585-eb62c95b5a5f@github.com> Message-ID: On Tue, 22 Mar 2022 16:14:37 GMT, Zhengyu Gu wrote: > > > > > > A few more fix-ups are needed (see also inline comments): > > > > > > > 3. `PlainRead.java` would need to get the `-2` added as a "good" value. Like here: [openjdk/jdk at 01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48](https://github.com/openjdk/jdk/commit/01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48) It's part of the original JDK-8250984 fix, but wasn't part of the 11 backport when it was done. So we should add it with this backport. > > > > > > > > > > > > > > > Even with this change, the test still failed. > > > > > > > > > > > > Right. See: [#840 (comment)](https://github.com/openjdk/jdk11u-dev/pull/840#issuecomment-1067065313) > > > > > > > > > Okay. It does not fix the test, I don't think we should include it in this patch, I would prefer to fix it separately. > > > > > > @zhengyu123 That's fine with me. Please rebase on top of the test changes ([JDK-8223396](https://bugs.openjdk.java.net/browse/JDK-8223396)) integrated recently and backport the test and fix from [JDK-8272124](https://bugs.openjdk.java.net/browse/JDK-8272124). Thank you. > > I think all 4 PRs are lined up for push. Once this review is done, I will request for approvals for all 4. Sorry my bad, I thought we were missing the fix from JDK-8272124 but it's there now. As for the test, we can only add that in once JDK-8239559 gets backported. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From sgehwolf at openjdk.java.net Tue Mar 22 17:38:40 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 22 Mar 2022 17:38:40 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v9] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Thu, 17 Mar 2022 17:40:06 GMT, Zhengyu Gu wrote: >> This is a followup backport for Cgroup v2 support. >> >> The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. >> >> In additional: >> >> 1) Include partial backport of JDK-8250627. >> - Renamed `Metrics.c` => `CgroupMetrics.c` >> - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` >> - Return instance only if `isUseContainerSupport()` is enabled. >> >> 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test >> >> 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` >> >> Test: >> >> - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS > > Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: > > - Merge > - Merge > - Merge branch 'master' into backport-8231111-unified-hierarchy > - Fixes > - Fix MetricsTesterCgroupV1 > - More fixes > - Fix indents and whitespaces > - Redo CgroupV1Subsystem.java merge > - Severin's comments - 2 > - Severin's comments > - ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/ab03faaa...171d73f7 This looks good now. Thanks! ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From stuefe at openjdk.java.net Wed Mar 23 07:06:39 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Wed, 23 Mar 2022 07:06:39 GMT Subject: [jdk17u-dev] RFR: 8280543: Update the "java" and "jcmd" tool specification for CDS In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 11:52:12 GMT, Martin Doerr wrote: >> Not a clean backport. >> >> I had to remove mentioning of the "dynamic_dump" option since its not supported in jdk17. > > LGTM. Thanks @TheRealMDoerr for review, @GoeLin for approval. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/277 From stuefe at openjdk.java.net Wed Mar 23 07:06:39 2022 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Wed, 23 Mar 2022 07:06:39 GMT Subject: [jdk17u-dev] Integrated: 8280543: Update the "java" and "jcmd" tool specification for CDS In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 10:46:00 GMT, Thomas Stuefe wrote: > Not a clean backport. > > I had to remove mentioning of the "dynamic_dump" option since its not supported in jdk17. This pull request has now been integrated. Changeset: d6eb2818 Author: Thomas Stuefe URL: https://git.openjdk.java.net/jdk17u-dev/commit/d6eb2818b8764eb24e43824fcc047b57eefa3a7e Stats: 544 lines in 2 files changed: 73 ins; 364 del; 107 mod 8280543: Update the "java" and "jcmd" tool specification for CDS Reviewed-by: mdoerr Backport-of: 39165613aa0430861e361a33a4925b85ea24fff1 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/277 From mbaesken at openjdk.java.net Wed Mar 23 08:31:51 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 23 Mar 2022 08:31:51 GMT Subject: [jdk17u-dev] Integrated: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info In-Reply-To: References: Message-ID: <4w-5rthatBxZ2AJFiJZnnKZL_BQfjVmQXQyPbk_gF3g=.b1662105-33fa-49bc-9439-8d66e30472fc@github.com> On Tue, 22 Mar 2022 13:48:21 GMT, Matthias Baesken wrote: > 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info This pull request has now been integrated. Changeset: d4424463 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/d4424463c83625b9667f931b25afef6e70726252 Stats: 16 lines in 2 files changed: 14 ins; 0 del; 2 mod 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info Backport-of: bb2e10ccea0c0b89b06ace034c99253e9999ec47 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/279 From mbaesken at openjdk.java.net Wed Mar 23 08:33:34 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 23 Mar 2022 08:33:34 GMT Subject: [jdk17u-dev] Integrated: 8282345: handle latest VS2022 in abstract_vm_version In-Reply-To: References: Message-ID: <9MITXMY47heqtgqwir-7y16C4cFxxJkGFSJ6x9KZ-xE=.7a5c86b2-e850-4609-9419-698dcf70a59d@github.com> On Tue, 22 Mar 2022 13:16:43 GMT, Matthias Baesken wrote: > 8282345: handle latest VS2022 in abstract_vm_version This pull request has now been integrated. Changeset: 18ece9b5 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/18ece9b5c45e5e1dbf82b22cee54eb79945995d2 Stats: 10 lines in 1 file changed: 4 ins; 4 del; 2 mod 8282345: handle latest VS2022 in abstract_vm_version Backport-of: 735e86b0f71c97c2ba35c1cffd9b4492a8ca55bc ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/278 From mbaesken at openjdk.java.net Wed Mar 23 08:37:40 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 23 Mar 2022 08:37:40 GMT Subject: [jdk11u-dev] Integrated: 8261169: Upgrade HarfBuzz to the latest 2.8.0 In-Reply-To: References: Message-ID: <46RUEonyFHOdzIwwKCumODT2brOgIEefInDv9x3EQd4=.f2c25b12-1e87-4bc6-8530-00152e55d1b4@github.com> On Mon, 21 Mar 2022 15:46:30 GMT, Matthias Baesken wrote: > Hello, I would like to backport harfbuzz 2.8.0 to 11u-dev, so that a current harfbuzz version is used there that includes latest fixes. Awt2dLibraries.gmk needed a bit of manual adjustments. > As a preparation https://bugs.openjdk.java.net/browse/JDK-8282588 had been done recently. > > Discussion about this issue > https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-January/thread.html#11411 > https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/thread.html#11937 > https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-March/thread.html#12497 > > Thanks, Matthias This pull request has now been integrated. Changeset: 088445f9 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/088445f90be21513d7ed64328e0d075704a496d9 Stats: 57497 lines in 221 files changed: 33259 ins; 15266 del; 8972 mod 8261169: Upgrade HarfBuzz to the latest 2.8.0 Reviewed-by: mdoerr Backport-of: 80323b7f66541e24177d02cc668a2eb9267962b9 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/929 From goetz at openjdk.java.net Wed Mar 23 08:48:38 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 23 Mar 2022 08:48:38 GMT Subject: [jdk11u-dev] RFR: 8278472: Invalid value set to CANDIDATEFORM structure In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 15:11:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Pre-submit failure: dependencies not available E: Version '9.4.0-1ubuntu1~20.04' for 'gcc-9' was not found ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/934 From goetz at openjdk.java.net Wed Mar 23 08:51:43 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 23 Mar 2022 08:51:43 GMT Subject: [jdk11u-dev] RFR: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 15:15:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to resolve the copyrights, the rest applied clean. Marking as clean backport. Pre-submit tests: dependencies missing. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/935 From goetz at openjdk.java.net Wed Mar 23 08:52:37 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 23 Mar 2022 08:52:37 GMT Subject: [jdk11u-dev] RFR: 8282583: Update BCEL md to include the copyright notice In-Reply-To: <3BLv8XtmL5ORqMxeBYufjJ9l0i0WYgszL5TqyQ_BUX0=.4b83059f-8513-43dd-92e9-73f5cd5a2b0b@github.com> References: <3BLv8XtmL5ORqMxeBYufjJ9l0i0WYgszL5TqyQ_BUX0=.4b83059f-8513-43dd-92e9-73f5cd5a2b0b@github.com> Message-ID: On Tue, 22 Mar 2022 15:27:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Pre-submit failure; dependencies missing. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/936 From goetz at openjdk.java.net Wed Mar 23 08:53:43 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 23 Mar 2022 08:53:43 GMT Subject: [jdk11u-dev] RFR: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode In-Reply-To: References: Message-ID: <-nOGQGkF6XmbpLbC7IHjSzTVyGQB94ufmVT0rl2L4XY=.a444a7cf-6e74-4abd-be30-60d3d0789753@github.com> On Tue, 22 Mar 2022 15:34:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Pre-submit failure: dependencies missing. unrelated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/937 From goetz at openjdk.java.net Wed Mar 23 09:07:42 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 23 Mar 2022 09:07:42 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: <8b87kLLNUQfxQlqhtVKeWKanX_P0yNl00bTWPLWtiBg=.da1f7989-186f-474e-b3f6-a06a68165ff6@github.com> Merge build tag 11.0.15+7 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8282761: XPathFactoryImpl remove setProperty and getProperty methods - 8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jdk11u-dev/pull/938/files Stats: 59 lines in 3 files changed: 0 ins; 56 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/938.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/938/head:pull/938 PR: https://git.openjdk.java.net/jdk11u-dev/pull/938 From goetz at openjdk.java.net Wed Mar 23 09:15:43 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 23 Mar 2022 09:15:43 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: <8b87kLLNUQfxQlqhtVKeWKanX_P0yNl00bTWPLWtiBg=.da1f7989-186f-474e-b3f6-a06a68165ff6@github.com> References: <8b87kLLNUQfxQlqhtVKeWKanX_P0yNl00bTWPLWtiBg=.da1f7989-186f-474e-b3f6-a06a68165ff6@github.com> Message-ID: On Wed, 23 Mar 2022 09:01:39 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.15+7 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: 1a969f12 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/1a969f122d3b9db8a9f29694528562299817347a Stats: 59 lines in 3 files changed: 0 ins; 56 del; 3 mod Merge ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/938 From mbaesken at openjdk.java.net Wed Mar 23 09:18:52 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 23 Mar 2022 09:18:52 GMT Subject: [jdk11u-dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 Message-ID: backport of 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 ------------- Commit messages: - Merge branch 'master' into MBaesken-backport-a86ee9b3 - Backport a86ee9b3f370b59caea2ae78169d13498560cd8e - JDK-8261169 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/939/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=939&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266545 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/939.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/939/head:pull/939 PR: https://git.openjdk.java.net/jdk11u-dev/pull/939 From mbaesken at openjdk.java.net Wed Mar 23 09:22:34 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 23 Mar 2022 09:22:34 GMT Subject: [jdk11u-dev] Withdrawn: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 09:05:12 GMT, Matthias Baesken wrote: > backport of 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/939 From mbaesken at openjdk.java.net Wed Mar 23 09:30:02 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 23 Mar 2022 09:30:02 GMT Subject: [jdk11u-dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 Message-ID: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 ------------- Commit messages: - Backport c42c231e1dabd37ec09362291dc8141117ce0bbd Changes: https://git.openjdk.java.net/jdk11u-dev/pull/940/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=940&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266545 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/940.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/940/head:pull/940 PR: https://git.openjdk.java.net/jdk11u-dev/pull/940 From goetz at openjdk.java.net Wed Mar 23 09:30:01 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 23 Mar 2022 09:30:01 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master Message-ID: Merge build tag 17.0.3+5 from jdk17u to jdk17u-dev ------------- Commit messages: - Merge - 8282761: XPathFactoryImpl remove setProperty and getProperty methods The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jdk17u-dev/pull/282/files Stats: 59 lines in 2 files changed: 0 ins; 56 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/282.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/282/head:pull/282 PR: https://git.openjdk.java.net/jdk17u-dev/pull/282 From goetz at openjdk.java.net Wed Mar 23 09:30:02 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 23 Mar 2022 09:30:02 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 09:18:41 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.3+5 from jdk17u to jdk17u-dev This pull request has now been integrated. Changeset: d62a116e Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/d62a116e2827f4de3ed95f463b8070acfd619b91 Stats: 59 lines in 2 files changed: 0 ins; 56 del; 3 mod Merge ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/282 From mdoerr at openjdk.java.net Wed Mar 23 09:33:46 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 23 Mar 2022 09:33:46 GMT Subject: [jdk17u-dev] Integrated: 8281338: NSAccessibilityPressAction action for tree node and NSAccessibilityShowMenuAcgtion action not working In-Reply-To: References: Message-ID: <2XNSDMd-_OdCUa6dm8-HNFmB2uNCDAtHHjWmyFYvVjQ=.9d3e0fd5-16c1-4aa0-a255-5f8f74ed2444@github.com> On Tue, 22 Mar 2022 14:24:57 GMT, Martin Doerr wrote: > Clean backport of [JDK-8281338](https://bugs.openjdk.java.net/browse/JDK-8281338) This pull request has now been integrated. Changeset: 1705541b Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/1705541ba998dfb726e6f5273bdf81b7c027a8e9 Stats: 185 lines in 2 files changed: 183 ins; 0 del; 2 mod 8281338: NSAccessibilityPressAction action for tree node and NSAccessibilityShowMenuAcgtion action not working Backport-of: cb2f8caed2de1bf0a85a7ebfd232c36371e06c98 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/280 From duke at openjdk.java.net Wed Mar 23 09:37:51 2022 From: duke at openjdk.java.net (Foivos) Date: Wed, 23 Mar 2022 09:37:51 GMT Subject: [jdk17u-dev] Integrated: 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 14:46:10 GMT, Foivos wrote: > Hi > > This pull request contains a backport of https://github.com/openjdk/jdk/commit/0cbc4b85bf8ab2ccfb8762322098c4cc7996df7d. > > The patch introduces a fix and a new test for the bug being fixed. The test fails against jdk17u-dev master prior to the patch and passes afterwards. > > Thanks! This pull request has now been integrated. Changeset: 13140f91 Author: Foivos Zakkak Committer: Severin Gehwolf URL: https://git.openjdk.java.net/jdk17u-dev/commit/13140f91b0aa3fadaea7cd2651432c56cea7773a Stats: 46 lines in 2 files changed: 20 ins; 5 del; 21 mod 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly Backport-of: 0cbc4b85bf8ab2ccfb8762322098c4cc7996df7d ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/274 From chegar at openjdk.java.net Wed Mar 23 10:48:55 2022 From: chegar at openjdk.java.net (Chris Hegarty) Date: Wed, 23 Mar 2022 10:48:55 GMT Subject: [jdk18u] Integrated: 8282444: Module finder incorrectly assumes default file system path-separator character In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 14:26:02 GMT, Chris Hegarty wrote: > 8282444: Module finder incorrectly assumes default file system path-separator character This pull request has now been integrated. Changeset: 73014a2a Author: Chris Hegarty URL: https://git.openjdk.java.net/jdk18u/commit/73014a2a1409e91a1afe1b272fe537697f9160a4 Stats: 10 lines in 5 files changed: 2 ins; 0 del; 8 mod 8282444: Module finder incorrectly assumes default file system path-separator character Backport-of: 369291b265e13d625c5f465da9b1854c0d70c435 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/48 From mbaesken at openjdk.java.net Wed Mar 23 11:44:29 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Wed, 23 Mar 2022 11:44:29 GMT Subject: [jdk11u-dev] Integrated: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 09:21:52 GMT, Matthias Baesken wrote: > 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 This pull request has now been integrated. Changeset: b4b4e3e1 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/b4b4e3e17c8fd1291f11948132b6ef77e7dee697 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 Backport-of: c42c231e1dabd37ec09362291dc8141117ce0bbd ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/940 From zgu at openjdk.java.net Wed Mar 23 12:28:20 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 23 Mar 2022 12:28:20 GMT Subject: [jdk11u-dev] RFR: 8230305: Cgroups v2: Container awareness [v3] In-Reply-To: References: Message-ID: <5eW34y_FCK1hXefOQ4-gGyY0tQJA5W0PeqIaVD2M2-I=.3c54efdf-e449-4034-be97-b739ee100cad@github.com> > I would like backport cgroups v2 support to openjdk11u. > > The original patch does not apply cleanly, conflicts are resolved manually. > > Test: > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into backport-8230305-cgroup-v2 - Merge branch 'master' into backport-8230305-cgroup-v2 - Backport d462a6b5c9bd3dae5257cca42ea38c19cb742e3c ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/840/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/840/files/ab03faaa..3aed7ba3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=840&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=840&range=01-02 Stats: 60016 lines in 302 files changed: 35191 ins; 15488 del; 9337 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/840.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/840/head:pull/840 PR: https://git.openjdk.java.net/jdk11u-dev/pull/840 From zgu at openjdk.java.net Wed Mar 23 12:28:20 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 23 Mar 2022 12:28:20 GMT Subject: [jdk11u-dev] Integrated: 8230305: Cgroups v2: Container awareness In-Reply-To: References: Message-ID: On Thu, 24 Feb 2022 21:18:12 GMT, Zhengyu Gu wrote: > I would like backport cgroups v2 support to openjdk11u. > > The original patch does not apply cleanly, conflicts are resolved manually. > > Test: > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS This pull request has now been integrated. Changeset: 8715f37c Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/8715f37c6743a49dcc5f2e8fb5cc68f7d5ed8aa2 Stats: 2003 lines in 10 files changed: 1389 ins; 576 del; 38 mod 8230305: Cgroups v2: Container awareness 8229202: Docker reporting causes secondary crashes in error handling 8216366: Add rationale to PER_CPU_SHARES define Implement Cgroups v2 container awareness in hotspot Reviewed-by: sgehwolf Backport-of: d462a6b5c9bd3dae5257cca42ea38c19cb742e3c ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/840 From duke at openjdk.java.net Wed Mar 23 12:31:39 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Wed, 23 Mar 2022 12:31:39 GMT Subject: [jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v9] In-Reply-To: References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Thu, 17 Mar 2022 17:40:06 GMT, Zhengyu Gu wrote: >> This is a followup backport for Cgroup v2 support. >> >> The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. >> >> In additional: >> >> 1) Include partial backport of JDK-8250627. >> - Renamed `Metrics.c` => `CgroupMetrics.c` >> - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` >> - Return instance only if `isUseContainerSupport()` is enabled. >> >> 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test >> >> 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` >> >> Test: >> >> - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS >> - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS > > Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: > > - Merge > - Merge > - Merge branch 'master' into backport-8231111-unified-hierarchy > - Fixes > - Fix MetricsTesterCgroupV1 > - More fixes > - Fix indents and whitespaces > - Redo CgroupV1Subsystem.java merge > - Severin's comments - 2 > - Severin's comments > - ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/ab03faaa...171d73f7 The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backport-8230305-cgroup-v2 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From zgu at openjdk.java.net Wed Mar 23 12:36:24 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 23 Mar 2022 12:36:24 GMT Subject: [jdk11u-dev] RFR: 8237479: 8230305 causes slowdebug build failure [v2] In-Reply-To: References: Message-ID: > A clean, followup (JDK-8230305) backport for Cgroup v2 support. Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge - Backport 4ca06995855b5c974321d7b3622d661b8d27ba76 - Backport d462a6b5c9bd3dae5257cca42ea38c19cb742e3c ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/864/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/864/files/c62fac99..853c4709 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=864&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=864&range=00-01 Stats: 67722 lines in 656 files changed: 39034 ins; 18216 del; 10472 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/864.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/864/head:pull/864 PR: https://git.openjdk.java.net/jdk11u-dev/pull/864 From duke at openjdk.java.net Wed Mar 23 12:36:24 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Wed, 23 Mar 2022 12:36:24 GMT Subject: [jdk11u-dev] RFR: 8237479: 8230305 causes slowdebug build failure In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 18:55:07 GMT, Zhengyu Gu wrote: > A clean, followup (JDK-8230305) backport for Cgroup v2 support. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backport-8230305-cgroup-v2 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/864 From zgu at openjdk.java.net Wed Mar 23 12:47:39 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 23 Mar 2022 12:47:39 GMT Subject: [jdk11u-dev] Integrated: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy In-Reply-To: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> References: <1BH9N8D5fvrrhb2Pt8G8q5U04V2Oh68rE48wfBSHKuQ=.a12dc8a5-457f-4e07-be58-fa93853c92d1@github.com> Message-ID: On Tue, 8 Mar 2022 18:47:32 GMT, Zhengyu Gu wrote: > This is a followup backport for Cgroup v2 support. > > The original patch does not apply cleanly, due to context differences and some of out-of-order backports, conflicts were resolved manually. > > In additional: > > 1) Include partial backport of JDK-8250627. > - Renamed `Metrics.c` => `CgroupMetrics.c` > - Added native method `isUseContainerSupport()` to `CgroupMetrics.java` > - Return instance only if `isUseContainerSupport()` is enabled. > > 2) Add `createTempDirectory()` method to `test/lib/jdk/test/lib/Utils.java` for `TestCgroupSubsystemController.java` test > > 3) Add `import jdk.test.lib.process.OutputAnalyzer;` to `TestDockerMemoryMetrics.java` > > Test: > > - [x] jtreg containers/docker test on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/cgroup on Ubuntu 20.04.4 LTS > - [x] jdk/internal/platform/docker on Ubuntu 20.04.4 LTS This pull request has now been integrated. Changeset: 19f26f72 Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/19f26f725fdc29ee0eb4e330a275134663933629 Stats: 5351 lines in 31 files changed: 3618 ins; 1599 del; 134 mod 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy Reviewed-by: sgehwolf Backport-of: 4def210a22faaec6b47912dd314e6365ea48d28f ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/863 From sgehwolf at openjdk.java.net Wed Mar 23 12:53:20 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 23 Mar 2022 12:53:20 GMT Subject: [jdk11u-dev] RFR: 8253727: [cgroups v2] Memory and swap limits reported incorrectly [v2] In-Reply-To: References: Message-ID: > Backport JDK-8253727 to 11u-dev. Depends on #863. > > Testing: container tests on a cgroups v2 system Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/894/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/894/files/ccc164b6..ccc164b6 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=894&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=894&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/894.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/894/head:pull/894 PR: https://git.openjdk.java.net/jdk11u-dev/pull/894 From duke at openjdk.java.net Wed Mar 23 12:53:20 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Wed, 23 Mar 2022 12:53:20 GMT Subject: [jdk11u-dev] RFR: 8253727: [cgroups v2] Memory and swap limits reported incorrectly In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 18:40:58 GMT, Severin Gehwolf wrote: > Backport JDK-8253727 to 11u-dev. Depends on #863. > > Testing: container tests on a cgroups v2 system The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backport-8231111-unified-hierarchy git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/894 From zgu at openjdk.java.net Wed Mar 23 12:53:28 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 23 Mar 2022 12:53:28 GMT Subject: [jdk11u-dev] RFR: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high [v2] In-Reply-To: References: Message-ID: <9DlMNNFQm17RMWdeiurSSyc9l6QkEiHvkZK-DGd-YKg=.293a9c1c-ecb4-412a-ac46-4c05ad244792@github.com> > A clean, followup (JDK-8231111) backport for Cgroup V2 support. Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/865/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/865/files/07ee583d..07ee583d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=865&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=865&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/865.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/865/head:pull/865 PR: https://git.openjdk.java.net/jdk11u-dev/pull/865 From duke at openjdk.java.net Wed Mar 23 12:53:29 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Wed, 23 Mar 2022 12:53:29 GMT Subject: [jdk11u-dev] RFR: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 18:58:11 GMT, Zhengyu Gu wrote: > A clean, followup (JDK-8231111) backport for Cgroup V2 support. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backport-8231111-unified-hierarchy git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/865 From zgu at openjdk.java.net Wed Mar 23 13:27:32 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 23 Mar 2022 13:27:32 GMT Subject: [jdk11u-dev] RFR: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high [v2] In-Reply-To: <9DlMNNFQm17RMWdeiurSSyc9l6QkEiHvkZK-DGd-YKg=.293a9c1c-ecb4-412a-ac46-4c05ad244792@github.com> References: <9DlMNNFQm17RMWdeiurSSyc9l6QkEiHvkZK-DGd-YKg=.293a9c1c-ecb4-412a-ac46-4c05ad244792@github.com> Message-ID: On Wed, 23 Mar 2022 12:53:28 GMT, Zhengyu Gu wrote: >> A clean, followup (JDK-8231111) backport for Cgroup V2 support. > > Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Followed above instructions to resolve dependency pull, but resulted many conflicts. Replace this with PR [941](https://github.com/openjdk/jdk11u-dev/pull/941), which is a clean backport. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/865 From zgu at openjdk.java.net Wed Mar 23 13:27:33 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 23 Mar 2022 13:27:33 GMT Subject: [jdk11u-dev] Withdrawn: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 18:58:11 GMT, Zhengyu Gu wrote: > A clean, followup (JDK-8231111) backport for Cgroup V2 support. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/865 From sgehwolf at openjdk.java.net Wed Mar 23 13:30:52 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 23 Mar 2022 13:30:52 GMT Subject: [jdk11u-dev] RFR: 8253727: [cgroups v2] Memory and swap limits reported incorrectly [v3] In-Reply-To: References: Message-ID: <1Xc75bGB0NvfVa9n5fToG3UkhmRikMQggT6iuuaAQnU=.61083b77-2518-4a98-a525-7d1a31225791@github.com> > Backport JDK-8253727 to 11u-dev. Depends on #863. > > Testing: container tests on a cgroups v2 system Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8253727: [cgroups v2] Memory and swap limits reported incorrectly Account for interface files for swap and memory being reported independently. The cgroup v1-like value is now reported by adding the memory.max value to the memory.swap.max value, and memory.current and memory.swap.current respectively. Reviewed-by: bobv, shade ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/894/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=894&range=02 Stats: 47 lines in 3 files changed: 42 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/894.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/894/head:pull/894 PR: https://git.openjdk.java.net/jdk11u-dev/pull/894 From zgu at openjdk.java.net Wed Mar 23 13:32:09 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 23 Mar 2022 13:32:09 GMT Subject: [jdk11u-dev] RFR: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high Message-ID: A clean backport to replace dependency PR [865](https://github.com/openjdk/jdk11u-dev/pull/865) that resulted many conflicts. ------------- Commit messages: - Backport ff6843ca4842498791061f924c545fa9469cc1dc Changes: https://git.openjdk.java.net/jdk11u-dev/pull/941/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=941&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253714 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/941.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/941/head:pull/941 PR: https://git.openjdk.java.net/jdk11u-dev/pull/941 From jdowland at openjdk.java.net Wed Mar 23 13:34:29 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Wed, 23 Mar 2022 13:34:29 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot [v2] In-Reply-To: References: Message-ID: <7pPqgnj263C3M8h9WXglla6XDOp4JgbwcGJINC7h8K8=.efcbcb05-66f6-442c-86ca-c52e6677af38@github.com> > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Integration blocker >  ?? Dependency #865 must be integrated first > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \ > `$ git checkout pull/881` > > Update a local copy of the PR: \ > `$ git checkout pull/881` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 881` > > View PR using the GUI difftool: \ > `$ git pr show -t 881` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/881.diff > >
Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/881/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/881/files/43de2010..43de2010 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=881&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=881&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/881.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881 PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From duke at openjdk.java.net Wed Mar 23 13:34:30 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Wed, 23 Mar 2022 13:34:30 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 11:04:45 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Integration blocker >  ?? Dependency #865 must be integrated first > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \ > `$ git checkout pull/881` > > Update a local copy of the PR: \ > `$ git checkout pull/881` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 881` > > View PR using the GUI difftool: \ > `$ git pr show -t 881` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/881.diff > >
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backport-8253714-memory.high git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From zgu at openjdk.java.net Wed Mar 23 13:36:27 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 23 Mar 2022 13:36:27 GMT Subject: [jdk11u-dev] Integrated: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high In-Reply-To: References: Message-ID: <2i8cnk9b-P0NSqk_3wo6kGIXgP0jkoYJ4XjLDjU4NMo=.0d298d90-d90b-4dfb-ab1d-a2e855f7e037@github.com> On Wed, 23 Mar 2022 13:23:17 GMT, Zhengyu Gu wrote: > A clean backport to replace dependency PR [865](https://github.com/openjdk/jdk11u-dev/pull/865) that resulted many conflicts. This pull request has now been integrated. Changeset: f76091ec Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/f76091ec9a05a8cb40514082dcff22c7829fa3aa Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high The early implementation of cgroups v2 support was done with crun 0.8 and it contained a bug which set memory.high over memory.low when --memory-reservation was being used as a CLI option. This bug has been fixed in later crun versions, starting with crun 0.11. Use memory.low in OpenJDK as well. Backport-of: ff6843ca4842498791061f924c545fa9469cc1dc ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/941 From zgu at openjdk.java.net Wed Mar 23 13:39:28 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 23 Mar 2022 13:39:28 GMT Subject: [jdk11u-dev] Integrated: 8237479: 8230305 causes slowdebug build failure In-Reply-To: References: Message-ID: On Tue, 8 Mar 2022 18:55:07 GMT, Zhengyu Gu wrote: > A clean, followup (JDK-8230305) backport for Cgroup v2 support. This pull request has now been integrated. Changeset: 45b78836 Author: Zhengyu Gu URL: https://git.openjdk.java.net/jdk11u-dev/commit/45b78836991ca9bcc6e339a97ab5598cf3765ca5 Stats: 14 lines in 1 file changed: 0 ins; 0 del; 14 mod 8237479: 8230305 causes slowdebug build failure Declare methods as pure virtual. Backport-of: 4ca06995855b5c974321d7b3622d661b8d27ba76 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/864 From sgehwolf at openjdk.java.net Wed Mar 23 14:06:34 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 23 Mar 2022 14:06:34 GMT Subject: [jdk11u-dev] Integrated: 8253727: [cgroups v2] Memory and swap limits reported incorrectly In-Reply-To: References: Message-ID: On Tue, 15 Mar 2022 18:40:58 GMT, Severin Gehwolf wrote: > Backport JDK-8253727 to 11u-dev. Depends on #863. > > Testing: container tests on a cgroups v2 system This pull request has now been integrated. Changeset: 3fc205cf Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/3fc205cf8d09e2ab924fbb33ab4f3a9cc86ae470 Stats: 47 lines in 3 files changed: 42 ins; 0 del; 5 mod 8253727: [cgroups v2] Memory and swap limits reported incorrectly Account for interface files for swap and memory being reported independently. The cgroup v1-like value is now reported by adding the memory.max value to the memory.swap.max value, and memory.current and memory.swap.current respectively. Backport-of: 3e96721cd9d1e1f46711e70dfc22064bab212b64 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/894 From hohensee at amazon.com Wed Mar 23 17:29:28 2022 From: hohensee at amazon.com (Hohensee, Paul) Date: Wed, 23 Mar 2022 17:29:28 +0000 Subject: CFV: New JDK Updates Committer: Christian Hagedorn Message-ID: <7F708823-8194-4BAB-94C6-796D132EB10C@amazon.com> Vote: yes ?-----Original Message----- From: jdk-updates-dev on behalf of Tobias Hartmann Date: Monday, March 21, 2022 at 1:47 AM To: "jdk-updates-dev at openjdk.java.net" Subject: Re: CFV: New JDK Updates Committer: Christian Hagedorn Correction: It should be Lazy Consensus voting (see [5]) not Three-Vote Consensus. Thanks, Tobias [5] https://openjdk.java.net/projects/#committer-vote On 21.03.22 09:33, Tobias Hartmann wrote: > I hereby nominate Christian Hagedorn [1] for the role of JDK Updates Project Committer. > > Christian is a member of the HotSpot Compiler Team at Oracle and a JDK Reviewer. Since 2019, he > contributed over 120 changes to the JDK project [2] many of which have been backported to older > releases. > > Votes are due by April 4, 2022, 09:00 UTC. > > Only current JDK Updates Committer [3] are eligible to vote on this nomination. Votes must be cast > in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [4]. > > Best regards, > Tobias > > [1] https://openjdk.java.net/census#chagedorn > [2] > https://github.com/search?q=committer-name%3A%22Christian+Hagedorn%22+repo%3Aopenjdk%2Fjdk&type=commits > [3] https://openjdk.java.net/census#jdk-updates > [4] https://openjdk.java.net/bylaws#three-vote-consensus From rkennke at openjdk.java.net Wed Mar 23 19:16:40 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 23 Mar 2022 19:16:40 GMT Subject: [jdk18u] Integrated: 8277072: ObjectStreamClass caches keep ClassLoaders alive In-Reply-To: <5X_t5RoYSeQPT5vOdCSGiflNoGnvgcNx3-OX6_2F1q4=.63ff24ca-c7b1-403a-acc5-1987b4a5594f@github.com> References: <5X_t5RoYSeQPT5vOdCSGiflNoGnvgcNx3-OX6_2F1q4=.63ff24ca-c7b1-403a-acc5-1987b4a5594f@github.com> Message-ID: On Wed, 9 Mar 2022 16:11:13 GMT, Roman Kennke wrote: > Hi all, > > This pull request contains a backport of commit [8eb453ba](https://github.com/openjdk/jdk/commit/8eb453baebe377697286f7eb32280ca9f1fd7775) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Roman Kennke on 10 Dec 2021 and was reviewed by Roger Riggs and Peter Levart. > > It fixes a memory leak in ObjectStreamClass under certain conditions. See bug for details. > > Thanks! This pull request has now been integrated. Changeset: 76e25e64 Author: Roman Kennke URL: https://git.openjdk.java.net/jdk18u/commit/76e25e64e0306841ea6a4fc3f4d74640a48e5333 Stats: 496 lines in 4 files changed: 284 ins; 186 del; 26 mod 8277072: ObjectStreamClass caches keep ClassLoaders alive Reviewed-by: rriggs Backport-of: 8eb453baebe377697286f7eb32280ca9f1fd7775 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/36 From duke at openjdk.java.net Wed Mar 23 19:19:53 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Wed, 23 Mar 2022 19:19:53 GMT Subject: [jdk18u] RFR: 8280041: Retry loop issues in java.io.ClassCache [v2] In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 11:00:51 GMT, Roman Kennke wrote: >> This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. >> The original change has baked for several weeks in jdk19 and applies cleanly. >> >> Testing: >> - [x] tier1 >> - [x] tier2 >> - [ ] tier3 > > Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: > > Add missing tests The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout rkennke-backport-8eb453ba git fetch https://git.openjdk.java.net/jdk18u master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk18u/pull/46 From rkennke at openjdk.java.net Wed Mar 23 19:20:53 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 23 Mar 2022 19:20:53 GMT Subject: [jdk18u] RFR: 8278065: Refactor subclassAudits to use ClassValue [v2] In-Reply-To: References: Message-ID: <8zlGNwvtp_lIrWw0eH-EY3Ec-pLo_YfmDYC-Ww7V9cQ=.e6d381cd-9f24-4648-a166-5ec60bbb5c4c@github.com> > This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [x] tier2 > - [x] tier3 Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/50/files - new: https://git.openjdk.java.net/jdk18u/pull/50/files/482d41e7..482d41e7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=50&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=50&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/50.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/50/head:pull/50 PR: https://git.openjdk.java.net/jdk18u/pull/50 From duke at openjdk.java.net Wed Mar 23 19:20:55 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Wed, 23 Mar 2022 19:20:55 GMT Subject: [jdk18u] RFR: 8278065: Refactor subclassAudits to use ClassValue In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 14:06:40 GMT, Roman Kennke wrote: > This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [x] tier2 > - [x] tier3 The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout rkennke-backport-8eb453ba git fetch https://git.openjdk.java.net/jdk18u master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk18u/pull/50 From rkennke at openjdk.java.net Wed Mar 23 19:36:20 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 23 Mar 2022 19:36:20 GMT Subject: [jdk18u] RFR: 8280041: Retry loop issues in java.io.ClassCache [v3] In-Reply-To: References: Message-ID: > This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [x] tier2 > - [ ] tier3 Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into backport-8280041 - Add missing tests - Backport cebaad1c94c301304fd146526cac95bfeaac66bf - Backport 8eb453baebe377697286f7eb32280ca9f1fd7775 ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/46/files - new: https://git.openjdk.java.net/jdk18u/pull/46/files/b3783162..4fd1d9a4 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=46&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=46&range=01-02 Stats: 282 lines in 16 files changed: 234 ins; 8 del; 40 mod Patch: https://git.openjdk.java.net/jdk18u/pull/46.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/46/head:pull/46 PR: https://git.openjdk.java.net/jdk18u/pull/46 From rkennke at openjdk.java.net Wed Mar 23 19:51:44 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 23 Mar 2022 19:51:44 GMT Subject: [jdk18u] Integrated: 8280041: Retry loop issues in java.io.ClassCache In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 09:44:00 GMT, Roman Kennke wrote: > This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [x] tier2 > - [ ] tier3 This pull request has now been integrated. Changeset: 27fbc080 Author: Roman Kennke URL: https://git.openjdk.java.net/jdk18u/commit/27fbc0804f6be599f59249dcc79bcd74e90db49c Stats: 202 lines in 5 files changed: 190 ins; 0 del; 12 mod 8280041: Retry loop issues in java.io.ClassCache Backport-of: cebaad1c94c301304fd146526cac95bfeaac66bf ------------- PR: https://git.openjdk.java.net/jdk18u/pull/46 From rkennke at openjdk.java.net Wed Mar 23 20:12:57 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 23 Mar 2022 20:12:57 GMT Subject: [jdk18u] RFR: 8278065: Refactor subclassAudits to use ClassValue [v3] In-Reply-To: References: Message-ID: > This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [x] tier2 > - [x] tier3 Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into backport-8278065 - Backport 8fed8ab29cae4f189f44609c23f116967eef6bdf - Backport 8eb453baebe377697286f7eb32280ca9f1fd7775 ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/50/files - new: https://git.openjdk.java.net/jdk18u/pull/50/files/482d41e7..03aeff78 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=50&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=50&range=01-02 Stats: 484 lines in 21 files changed: 424 ins; 8 del; 52 mod Patch: https://git.openjdk.java.net/jdk18u/pull/50.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/50/head:pull/50 PR: https://git.openjdk.java.net/jdk18u/pull/50 From gnu.andrew at redhat.com Wed Mar 23 20:13:59 2022 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 23 Mar 2022 20:13:59 +0000 Subject: [Proposal] Maintainer Approvals and SKARA Message-ID: Hi all, We have been discussing how to implement and/or adapt the current approval process (jdk-fix-request, jdk-fix-yes, etc.) to SKARA on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199 At present, we have been continuing to approve bugs for update releases as we did in Mercurial; when the change is reviewed, the proposer should flag it as jdk<>-fix-request (or jdk<>-critical-request for a rampdown fix) and then an approver responds with the *-yes or *-no response on the bug. SKARA has introduced a new worry for me into this process, due to the way the PR bot directs the user through the change process. This in itself is a good thing. However, while it is currently not aware of the approval process, it can encourage someone to integrate a change which has not yet been approved. Hence why I feel some solution to SKARA-1199 is quite critical (especially with the potential move of the master 8u repository to SKARA) and it surprises me that other update projects have not pushed harder for this, prior to 8u adopting SKARA. In thinking through how to implement this in SKARA, it occurred to me that trying to continue with what we have now may not be the best solution. The issues I see are: 1. Having the approval process in the bug database separate from the proposed commit on GitHub creates a disconnect between the two. We had this before, with the separation between mailing list activity and the bug database, but now that pretty much everything else happens in GitHub/SKARA, it feels odd to have to go back and forth between JBS and GitHub to approve a change. 2. Access to add a label in JBS requires someone to have JDK authorship status, so, for non-authors, someone else has to do this on their behalf (as with sponsoring) 3. On the flip-side to #2, any JDK author can add jdk-fix-yes or jdk-critical-yes to a bug, as I believe has happened in the past. 4. From a technical perspective, this means JBS has to be regularly probed to pick up new labels. This also affects CSRs, which already have issues in this area, and the demand for backports would be much higher. 5. When we've dealt with backports which affect multiple bugs, the informal process we've had in the past means we've been able to choose whether to require that all bugs are flagged or not. Having a formal version of the process we have now in SKARA would mean having to label every referenced bug in something like [0]. My proposal would be that we shift approvals to SKARA in a similar way to which sponsorship is currently handled: 1. When a PR for a backport project reaches the point at which it would currently be integrated (after either /integrate for a committer or /sponsor for a non-committer), it instead gets an 'approval' label. 2. For the PR to move forward, an 'integrator' (someone capable of merges & tags) [1] would need to perform '/approval [yes|no]' to cause the change to either be integrated or rejected. I believe this would simplify the implementation of this feature a lot and also integrate it better into SKARA. The bot could still label bugs with the jdk-fix-request when it adds the 'approval' label to the PR and with jdk-fix-yes and jdk-fix-no when the /approval command is used. The use of jdk-fix-request or jdk-critical-request can also be pre-determined by the bot, based on the repository the PR is against (jdku-dev for the former, jdku for the latter). This is something that would go in the server-side bot configuration. Thoughts? I'm honestly struggling to see why we'd hold onto the existing process, but I also realise that adaptation can be hard, particularly for other update projects where SKARA has been in use longer. [0] https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b95933aa35eac6 [1] https://bugs.openjdk.java.net/browse/SKARA-1384 Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 From andrew at openjdk.java.net Wed Mar 23 20:20:16 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Wed, 23 Mar 2022 20:20:16 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 09:18:41 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.3+5 from jdk17u to jdk17u-dev @GoeLin so this works without requiring a review? I just did the same merge for 8u->8u-dev via direct push because I was under the impression a PR would block on a reviewer. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/282 From kevin.rushforth at oracle.com Wed Mar 23 21:13:02 2022 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Wed, 23 Mar 2022 14:13:02 -0700 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: Message-ID: Without discussing whether I think this is a better approach than the existing label (it's certainly more work, and requires formalizing the role an "approver" in Skara, but I'll let others comment on the relative merits), I did want to comment on one aspect of your proposal. I don't think that having another state *after* integrate is the best way to go. Even if you don't use the bug database to record approvals, It seems cleaner to make the approval an integration blocker in the same way that the appropriate number of reviews, a matching title for the PR and bug, etc., are integration blockers. That way once Skara says "ready" to integrate, it really is. So my recommendation is that, regardless of whether SKARA-1199 is implemented via JBS labels or some other approval mechanism, the "approval" label (or whatever it is called) is added initially when the PR is created, and is an integration blocker. An "approver" can then indicate approval, either in parallel with the review or after the review is done (just like CSR reviews). Once both the review and the approval are done, Skara would mark it as "ready". -- Kevin On 3/23/2022 1:13 PM, Andrew Hughes wrote: > Hi all, > > We have been discussing how to implement and/or adapt the current > approval process (jdk-fix-request, jdk-fix-yes, etc.) to SKARA > on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199 > > At present, we have been continuing to approve bugs for update > releases as we did in Mercurial; when the change is reviewed, the > proposer should flag it as jdk<>-fix-request (or > jdk<>-critical-request for a rampdown fix) and then an approver > responds with the *-yes or *-no response on the bug. > > SKARA has introduced a new worry for me into this process, due to the > way the PR bot directs the user through the change process. This in > itself is a good thing. However, while it is currently not aware of > the approval process, it can encourage someone to integrate a change > which has not yet been approved. Hence why I feel some solution to > SKARA-1199 is quite critical (especially with the potential move of > the master 8u repository to SKARA) and it surprises me that other > update projects have not pushed harder for this, prior to 8u adopting > SKARA. > > In thinking through how to implement this in SKARA, it occurred to me > that trying to continue with what we have now may not be the best > solution. The issues I see are: > > 1. Having the approval process in the bug database separate from the > proposed commit on GitHub creates a disconnect between the two. > We had this before, with the separation between mailing list activity > and the bug database, but now that pretty much everything else happens > in GitHub/SKARA, it feels odd to have to go back and forth between > JBS and GitHub to approve a change. > > 2. Access to add a label in JBS requires someone to have JDK authorship > status, so, for non-authors, someone else has to do this on their > behalf (as with sponsoring) > > 3. On the flip-side to #2, any JDK author can add jdk-fix-yes or > jdk-critical-yes to a bug, as I believe has happened in the past. > > 4. From a technical perspective, this means JBS has to be regularly > probed to pick up new labels. This also affects CSRs, which already > have issues in this area, and the demand for backports would be > much higher. > > 5. When we've dealt with backports which affect multiple bugs, > the informal process we've had in the past means we've been able > to choose whether to require that all bugs are flagged or not. > Having a formal version of the process we have now in SKARA would > mean having to label every referenced bug in something like [0]. > > My proposal would be that we shift approvals to SKARA in a similar > way to which sponsorship is currently handled: > > 1. When a PR for a backport project reaches the point at which > it would currently be integrated (after either /integrate for > a committer or /sponsor for a non-committer), it instead > gets an 'approval' label. > > 2. For the PR to move forward, an 'integrator' (someone capable > of merges & tags) [1] would need to perform '/approval [yes|no]' to > cause the change to either be integrated or rejected. > > I believe this would simplify the implementation of this feature > a lot and also integrate it better into SKARA. > > The bot could still label bugs with the jdk-fix-request when > it adds the 'approval' label to the PR and with jdk-fix-yes > and jdk-fix-no when the /approval command is used. > > The use of jdk-fix-request or jdk-critical-request can > also be pre-determined by the bot, based on the repository > the PR is against (jdku-dev for the former, jdku for the > latter). This is something that would go in the server-side > bot configuration. > > Thoughts? > > I'm honestly struggling to see why we'd hold onto the existing > process, but I also realise that adaptation can be hard, particularly > for other update projects where SKARA has been in use longer. > > [0] https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b95933aa35eac6 > [1] https://bugs.openjdk.java.net/browse/SKARA-1384 > > Thanks, From rkennke at openjdk.java.net Wed Mar 23 21:35:47 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Wed, 23 Mar 2022 21:35:47 GMT Subject: [jdk18u] Integrated: 8278065: Refactor subclassAudits to use ClassValue In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 14:06:40 GMT, Roman Kennke wrote: > This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [x] tier2 > - [x] tier3 This pull request has now been integrated. Changeset: b5ce23b0 Author: Roman Kennke URL: https://git.openjdk.java.net/jdk18u/commit/b5ce23b0c17e4855fdd91dca37655fd6eb0e7ec2 Stats: 105 lines in 3 files changed: 2 ins; 89 del; 14 mod 8278065: Refactor subclassAudits to use ClassValue Backport-of: 8fed8ab29cae4f189f44609c23f116967eef6bdf ------------- PR: https://git.openjdk.java.net/jdk18u/pull/50 From gnu.andrew at redhat.com Thu Mar 24 01:21:54 2022 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 24 Mar 2022 01:21:54 +0000 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: Message-ID: On 14:13 Wed 23 Mar , Kevin Rushforth wrote: > Without discussing whether I think this is a better approach than the > existing label (it's certainly more work, and requires formalizing the > role an "approver" in Skara, but I'll let others comment on the relative > merits), I did want to comment on one aspect of your proposal. I don't > think that having another state *after* integrate is the best way to go. > Even if you don't use the bug database to record approvals, It seems > cleaner to make the approval an integration blocker in the same way that > the appropriate number of reviews, a matching title for the PR and bug, > etc., are integration blockers. That way once Skara says "ready" to > integrate, it really is. > > So my recommendation is that, regardless of whether SKARA-1199 is > implemented via JBS labels or some other approval mechanism, the > "approval" label (or whatever it is called) is added initially when the > PR is created, and is an integration blocker. An "approver" can then > indicate approval, either in parallel with the review or after the > review is done (just like CSR reviews). Once both the review and the > approval are done, Skara would mark it as "ready". > > -- Kevin > > I don't have a strong issue with doing it that way instead. My initial suggestion was based on how the sponsorship system works at present, because this is essentially the same thing - block until someone else gives the ok - and that is the time in the process when we would currently approve changes. For 8u, we've tended to ask people only to add jdk8u-fix-request when the change has been reviewed and is "ready". I don't see how one would approve something that is not in its final form, but there's certainly no reason to complicate things by making it impossible to do so. As to the role of approver, it would be those who are currently maintainers for the update project. There is already a role in SKARA - integrators - which I believe fits the bill and is already required to tag commits and perform merges. I'm not sure how you see this as "more work", as the existing task of flagging the issue for approval would now be handled by the bot, rather than the committer. Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 From serb at openjdk.java.net Thu Mar 24 03:47:25 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Thu, 24 Mar 2022 03:47:25 GMT Subject: [jdk11u-dev] RFR: 8274751: Drag And Drop hangs on Windows Message-ID: <507fneSPOxK0QSU3SM6f7wwnFQDn96TmnuC-Aw7ye1s=.5d1d9770-cf9f-4229-9b3a-a74c3ee049dc@github.com> Hi all, This pull request contains a backport of commit [7a0a6c95](https://github.com/openjdk/jdk/commit/7a0a6c95a53c6cb3340328d6543a97807320b740) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Dmitry Markov on 24 Jan 2022 and was reviewed by Alexey Ivanov, Phil Race and Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport 7a0a6c95a53c6cb3340328d6543a97807320b740 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/942/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=942&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274751 Stats: 19 lines in 4 files changed: 2 ins; 0 del; 17 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/942.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/942/head:pull/942 PR: https://git.openjdk.java.net/jdk11u-dev/pull/942 From mbaesken at openjdk.java.net Thu Mar 24 07:59:48 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Thu, 24 Mar 2022 07:59:48 GMT Subject: [jdk11u] Integrated: 8275082: Update XML Security for Java to 2.3.0 In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 16:02:46 GMT, Matthias Baesken wrote: > 8275082: Update XML Security for Java to 2.3.0 This pull request has now been integrated. Changeset: af99bc3a Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u/commit/af99bc3ac9b0ba5cc18b049d245c0c34a9a55800 Stats: 413 lines in 33 files changed: 63 ins; 267 del; 83 mod 8275082: Update XML Security for Java to 2.3.0 Reviewed-by: yan Backport-of: b0c0dc5ad2eb792343d579e6ff4be31422cd9f70 ------------- PR: https://git.openjdk.java.net/jdk11u/pull/33 From clanger at openjdk.java.net Thu Mar 24 08:29:49 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 24 Mar 2022 08:29:49 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v2] In-Reply-To: <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> Message-ID: <-z60-hGwW9_Hf3j03DkkfxSIgWeXaiwPfvgQGnnp9j4=.5758fad7-291f-496b-b63b-2311cf4f68f2@github.com> On Tue, 22 Mar 2022 09:46:03 GMT, Aleksei Voitylov wrote: >> JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. >> >> Original changeset does not apply cleanly because of: >> >> 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, >> 8215445: Enable building for Windows in WSL >> 8257913: Add more known library locations to simplify Linux cross-compilation >> 8244592: Start supporting SOURCE_DATE_EPOCH >> 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes >> >> Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. >> >> [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html > > Aleksei Voitylov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > JDK-8247589 backport to 11u I'll run this patch through SAP's testing tonight. I'm going to approve it when we don't see regressions. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From avoitylov at openjdk.java.net Thu Mar 24 08:33:48 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Thu, 24 Mar 2022 08:33:48 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v2] In-Reply-To: <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> Message-ID: <13bxL1mbSMfDd-2E8sHsqyTLbWVCNNqy7-STTt_LLAM=.1e129f1a-9905-48e8-996c-a390ec65c4b5@github.com> On Tue, 22 Mar 2022 09:46:03 GMT, Aleksei Voitylov wrote: >> JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. >> >> Original changeset does not apply cleanly because of: >> >> 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, >> 8215445: Enable building for Windows in WSL >> 8257913: Add more known library locations to simplify Linux cross-compilation >> 8244592: Start supporting SOURCE_DATE_EPOCH >> 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes >> >> Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. >> >> [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html > > Aleksei Voitylov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > JDK-8247589 backport to 11u Thanks Christoph! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From chegar at openjdk.java.net Thu Mar 24 08:48:11 2022 From: chegar at openjdk.java.net (Chris Hegarty) Date: Thu, 24 Mar 2022 08:48:11 GMT Subject: [jdk17u-dev] Integrated: 8282444: Module finder incorrectly assumes default file system path-separator character In-Reply-To: References: Message-ID: <_Eaiy9A4FvvtSUYjoZfyMwV4jthCe6Zt4TKISOm4lMU=.2b82f511-651f-492f-af47-ab4a91b63061@github.com> On Mon, 21 Mar 2022 12:10:53 GMT, Chris Hegarty wrote: > 8282444: Module finder incorrectly assumes default file system path-separator character This pull request has now been integrated. Changeset: 3c123f30 Author: Chris Hegarty URL: https://git.openjdk.java.net/jdk17u-dev/commit/3c123f307bc681fb8a29b4b8a1ce955ac1d1405f Stats: 10 lines in 5 files changed: 2 ins; 0 del; 8 mod 8282444: Module finder incorrectly assumes default file system path-separator character Backport-of: 369291b265e13d625c5f465da9b1854c0d70c435 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/266 From mbaesken at openjdk.java.net Thu Mar 24 08:51:37 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Thu, 24 Mar 2022 08:51:37 GMT Subject: [jdk18u] RFR: 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15 Message-ID: 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15 ------------- Commit messages: - Backport 84976b45315feb6c37a9f3db6e1e62812c9b0a37 Changes: https://git.openjdk.java.net/jdk18u/pull/51/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=51&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278549 Stats: 34 lines in 2 files changed: 32 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/51.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/51/head:pull/51 PR: https://git.openjdk.java.net/jdk18u/pull/51 From mbaesken at openjdk.java.net Thu Mar 24 09:29:17 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Thu, 24 Mar 2022 09:29:17 GMT Subject: [jdk11u-dev] RFR: JDK-8283614: [11] Repair compiler versions handling after 8233787 Message-ID: Looks like "8233787: Break cycle in vm_version* includes" removed the handling of some VS versions (like _MSC_VER == 1923) from abstract_vm_version.cpp; this should be repaired. see https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d compare the new src/hotspot/share/runtime/abstract_vm_version.cpp with what we had in src/hotspot/share/runtime/vm_version.cpp . see https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d#diff-e1be9153f5c542ba094a1a0052a8fb549363aeb73a6e316448bd2b5c8074f3cbR231 and https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d#diff-ab4abdc4613ecb623211a17dff37909553374e4287fc80114e917d609989223eL241 ------------- Commit messages: - JDK-8283614 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/943/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=943&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283614 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/943.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/943/head:pull/943 PR: https://git.openjdk.java.net/jdk11u-dev/pull/943 From snazarki at openjdk.java.net Thu Mar 24 09:52:53 2022 From: snazarki at openjdk.java.net (Sergey Nazarkin) Date: Thu, 24 Mar 2022 09:52:53 GMT Subject: [jdk13u-dev] Withdrawn: 8216557: Aarch64: Add support for Concurrent Class Unloading In-Reply-To: References: Message-ID: On Sat, 23 Oct 2021 21:19:53 GMT, Sergey Nazarkin wrote: > I'd like to backport feature implemented for x86 platform but missed for aarch64. The patch doesn't not apply cleanly for following files: > 1. [8234562](https://bugs.openjdk.java.net/browse/JDK-8234562) was not backported yet, so release_store/load_acquire are part of OrderAccess class > 2. [8234737](https://bugs.openjdk.java.net/browse/JDK-8234737) is missed, so Atomic::add use old function signature > 3. macroAssembler_aarch64.hpp copyright year > 4. sharedRutime.cpp contains [8253375](https://bugs.openjdk.java.net/browse/JDK-8253375) that confuses patcher not expected it > > Tested with hotspot tier1/2 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/282 From lucy at openjdk.java.net Thu Mar 24 10:16:55 2022 From: lucy at openjdk.java.net (Lutz Schmidt) Date: Thu, 24 Mar 2022 10:16:55 GMT Subject: [jdk11u-dev] RFR: JDK-8283614: [11] Repair compiler versions handling after 8233787 In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 09:22:54 GMT, Matthias Baesken wrote: > Looks like "8233787: Break cycle in vm_version* includes" removed the handling of some VS versions (like _MSC_VER == 1923) from abstract_vm_version.cpp; this should be repaired. > see > https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d > compare the new src/hotspot/share/runtime/abstract_vm_version.cpp with what we had in src/hotspot/share/runtime/vm_version.cpp . > see > https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d#diff-e1be9153f5c542ba094a1a0052a8fb549363aeb73a6e316448bd2b5c8074f3cbR231 > and > https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d#diff-ab4abdc4613ecb623211a17dff37909553374e4287fc80114e917d609989223eL241 Changes look good. Thanks for fixing. ------------- Marked as reviewed by lucy (Committer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/943 From mdoerr at openjdk.java.net Thu Mar 24 10:33:50 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Thu, 24 Mar 2022 10:33:50 GMT Subject: [jdk11u-dev] RFR: JDK-8283614: [11] Repair compiler versions handling after 8233787 In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 09:22:54 GMT, Matthias Baesken wrote: > Looks like "8233787: Break cycle in vm_version* includes" removed the handling of some VS versions (like _MSC_VER == 1923) from abstract_vm_version.cpp; this should be repaired. > see > https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d > compare the new src/hotspot/share/runtime/abstract_vm_version.cpp with what we had in src/hotspot/share/runtime/vm_version.cpp . > see > https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d#diff-e1be9153f5c542ba094a1a0052a8fb549363aeb73a6e316448bd2b5c8074f3cbR231 > and > https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d#diff-ab4abdc4613ecb623211a17dff37909553374e4287fc80114e917d609989223eL241 LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/943 From mbaesken at openjdk.java.net Thu Mar 24 11:30:47 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Thu, 24 Mar 2022 11:30:47 GMT Subject: [jdk11u-dev] Integrated: JDK-8283614: [11] Repair compiler versions handling after 8233787 In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 09:22:54 GMT, Matthias Baesken wrote: > Looks like "8233787: Break cycle in vm_version* includes" removed the handling of some VS versions (like _MSC_VER == 1923) from abstract_vm_version.cpp; this should be repaired. > see > https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d > compare the new src/hotspot/share/runtime/abstract_vm_version.cpp with what we had in src/hotspot/share/runtime/vm_version.cpp . > see > https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d#diff-e1be9153f5c542ba094a1a0052a8fb549363aeb73a6e316448bd2b5c8074f3cbR231 > and > https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d#diff-ab4abdc4613ecb623211a17dff37909553374e4287fc80114e917d609989223eL241 This pull request has now been integrated. Changeset: 60e771f8 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/60e771f82d35358ea90ee753611216b2fd5ae28b Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod 8283614: [11] Repair compiler versions handling after 8233787 Reviewed-by: lucy, mdoerr ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/943 From mbaesken at openjdk.java.net Thu Mar 24 12:01:03 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Thu, 24 Mar 2022 12:01:03 GMT Subject: [jdk11u-dev] RFR: 8256722: handle VC++:1927 VS2019 in abstract_vm_version Message-ID: 8256722: handle VC++:1927 VS2019 in abstract_vm_version ------------- Commit messages: - Backport e838d71d6151655980c8a96673f5db65f9168aee Changes: https://git.openjdk.java.net/jdk11u-dev/pull/944/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=944&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8256722 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/944.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/944/head:pull/944 PR: https://git.openjdk.java.net/jdk11u-dev/pull/944 From kevin.rushforth at oracle.com Thu Mar 24 12:07:13 2022 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Thu, 24 Mar 2022 05:07:13 -0700 Subject: [External] : Re: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: Message-ID: <84424e44-6577-3084-5604-a356ddf404ec@oracle.com> > I'm not sure how you see this as "more work", as the existing task > of flagging the issue for approval would now be handled by the bot, > rather than the committer. I meant more work in Skara to develop and implement this new feature (although Erik could confirm whether my assessment is accurate). I can see some advantages for the maintainers, but we need to balance to potential benefit against the cost to implement. -- Kevin On 3/23/2022 6:21 PM, Andrew Hughes wrote: > On 14:13 Wed 23 Mar , Kevin Rushforth wrote: >> Without discussing whether I think this is a better approach than the >> existing label (it's certainly more work, and requires formalizing the >> role an "approver" in Skara, but I'll let others comment on the relative >> merits), I did want to comment on one aspect of your proposal. I don't >> think that having another state *after* integrate is the best way to go. >> Even if you don't use the bug database to record approvals, It seems >> cleaner to make the approval an integration blocker in the same way that >> the appropriate number of reviews, a matching title for the PR and bug, >> etc., are integration blockers. That way once Skara says "ready" to >> integrate, it really is. >> >> So my recommendation is that, regardless of whether SKARA-1199 is >> implemented via JBS labels or some other approval mechanism, the >> "approval" label (or whatever it is called) is added initially when the >> PR is created, and is an integration blocker. An "approver" can then >> indicate approval, either in parallel with the review or after the >> review is done (just like CSR reviews). Once both the review and the >> approval are done, Skara would mark it as "ready". >> >> -- Kevin >> >> > I don't have a strong issue with doing it that way instead. My initial > suggestion was based on how the sponsorship system works at present, > because this is essentially the same thing - block until someone else > gives the ok - and that is the time in the process when we would > currently approve changes. For 8u, we've tended to ask people only to > add jdk8u-fix-request when the change has been reviewed and is > "ready". > > I don't see how one would approve something that is not in its final > form, but there's certainly no reason to complicate things by making > it impossible to do so. > > As to the role of approver, it would be those who are currently > maintainers for the update project. There is already a role in SKARA - > integrators - which I believe fits the bill and is already required to > tag commits and perform merges. > > I'm not sure how you see this as "more work", as the existing task > of flagging the issue for approval would now be handled by the bot, > rather than the committer. > > Thanks, From sgehwolf at redhat.com Thu Mar 24 13:05:43 2022 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 24 Mar 2022 14:05:43 +0100 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: Message-ID: <1d4d5f66e456f214f3fd4ebf6746da9afdf6ea4f.camel@redhat.com> On Wed, 2022-03-23 at 20:13 +0000, Andrew Hughes wrote: > > Hi all, > > We have been discussing how to implement and/or adapt the current > approval process (jdk-fix-request, jdk-fix-yes, etc.) to SKARA > on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199 > > At present, we have been continuing to approve bugs for update > releases as we did in Mercurial; when the change is reviewed, the > proposer should flag it as jdk<>-fix-request (or > jdk<>-critical-request for a rampdown fix) and then an approver > responds with the *-yes or *-no response on the bug. > > SKARA has introduced a new worry for me into this process, due to the > way the PR bot directs the user through the change process. This in > itself is a good thing. However, while it is currently not aware of > the approval process, it can encourage someone to integrate a change > which has not yet been approved. Hence why I feel some solution to > SKARA-1199 is quite critical (especially with the potential move of > the master 8u repository to SKARA) and it surprises me that other > update projects have not pushed harder for this, prior to 8u adopting > SKARA. > > In thinking through how to implement this in SKARA, it occurred to me > that trying to continue with what we have now may not be the best > solution. The issues I see are: > > 1. Having the approval process in the bug database separate from the > proposed commit on GitHub creates a disconnect between the two. > We had this before, with the separation between mailing list activity > and the bug database, but now that pretty much everything else > happens in GitHub/SKARA, it feels odd to have to go back and forth > between JBS and GitHub to approve a change. > 2. Access to add a label in JBS requires someone to have JDK > authorship > status, so, for non-authors, someone else has to do this on their > behalf (as with sponsoring) > > 3. On the flip-side to #2, any JDK author can add jdk-fix-yes or > jdk-critical-yes to a bug, as I believe has happened in the past. > > 4. From a technical perspective, this means JBS has to be regularly > probed to pick up new labels. This also affects CSRs, which already > have issues in this area, and the demand for backports would be > much higher. > > 5. When we've dealt with backports which affect multiple bugs, > the informal process we've had in the past means we've been able > to choose whether to require that all bugs are flagged or not. > Having a formal version of the process we have now in SKARA would > mean having to label every referenced bug in something like [0]. > > My proposal would be that we shift approvals to SKARA in a similar > way to which sponsorship is currently handled: > > 1. When a PR for a backport project reaches the point at which > it would currently be integrated (after either /integrate for > a committer or /sponsor for a non-committer), it instead > gets an 'approval' label. > > 2. For the PR to move forward, an 'integrator' (someone capable > of merges & tags) [1] would need to perform '/approval [yes|no]' to > cause the change to either be integrated or rejected. > > I believe this would simplify the implementation of this feature > a lot and also integrate it better into SKARA. > > The bot could still label bugs with the jdk-fix-request when > it adds the 'approval' label to the PR and with jdk-fix-yes > and jdk-fix-no when the /approval command is used. > > The use of jdk-fix-request or jdk-critical-request can > also be pre-determined by the bot, based on the repository > the PR is against (jdku-dev for the former, jdku for the > latter).? This is something that would go in the server-side > bot configuration. > > Thoughts? My worry would be that "Fix Request" comments would be spread across different PRs if a single bug gets backported to, many update releases. JDK 18u, 17u, 11u and 8u, for example. It would move the "approval" conversation to the source control system (and per backport PR) rather than the bug database. From a maintenance perspective it makes sense to have all the info related to backports in one place (on the bug). If something gets requested for 8u, say, I can see immediately in the bug database that it has been backported to later releases too and can see the approval flags (and who approved it). Moving this to skare makes the info much more dispersed. Besides, we've had the issue of update project committers being able to integrate without formal approval in JBS before. It's only much more visible now (which is a good thing). I.e. the problem doesn't change with Skara. The difference really is bot guidance. In general, the process is fairly well understood and I don't anticipate this to be a huge problem in practise. Thanks, Severin > I'm honestly struggling to see why we'd hold onto the existing > process, but I also realise that adaptation can be hard, particularly > for other update projects where SKARA has been in use longer. > > [0] > https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b9593= > 3aa35eac6 > [1] https://bugs.openjdk.java.net/browse/SKARA-1384 > > Thanks, > --=20 > Andrew :) > Pronouns: he / him or they / them > Senior Free Java Software Engineer > OpenJDK Package Owner > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint =3D 5132 579D D154 0ED2 3E04? C5A0 CFDA 0F9B 3596 4222 > > --X28JfW0BSfKBk7hD-- > From mbaesken at openjdk.java.net Thu Mar 24 13:37:15 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Thu, 24 Mar 2022 13:37:15 GMT Subject: [jdk17u-dev] RFR: 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15 Message-ID: backport of 8278549 ------------- Commit messages: - Backport 84976b45315feb6c37a9f3db6e1e62812c9b0a37 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/283/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=283&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278549 Stats: 34 lines in 2 files changed: 32 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/283.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/283/head:pull/283 PR: https://git.openjdk.java.net/jdk17u-dev/pull/283 From goetz at openjdk.java.net Thu Mar 24 13:38:51 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 24 Mar 2022 13:38:51 GMT Subject: [jdk11u-dev] Integrated: 8242310: use reproducible random in hotspot compiler tests In-Reply-To: References: Message-ID: On Mon, 21 Mar 2022 20:40:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to adapt the change in some places, all quite trivial: > > TestTrichotomyExpressions.java > TestShift.java > Vec_MulAddS2I.java > These tests are not in 11. Skipped. > > ClearDirectivesFileStackTest.java > Resolved Copyright. > > UnsafeIntrinsicsTest.java > A later change doubling the test description was already backported. > Applying the patch was trivial. This pull request has now been integrated. Changeset: 078eac8e Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/078eac8ecc431b72490697fae3584e2d56e8a42e Stats: 271 lines in 91 files changed: 118 ins; 22 del; 131 mod 8242310: use reproducible random in hotspot compiler tests Reviewed-by: mdoerr Backport-of: 7c351405c4a43c8af40a63f63b70bfcb7719b570 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/930 From goetz at openjdk.java.net Thu Mar 24 13:42:47 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 24 Mar 2022 13:42:47 GMT Subject: [jdk11u-dev] Integrated: 8242313: use reproducible random in hotspot svc tests In-Reply-To: <8hIUE0AyzVYHP0G8IeLbxJwr60en3CFfy3XVD05PfxM=.70893dde-009d-44a5-85a6-249f245dadd8@github.com> References: <8hIUE0AyzVYHP0G8IeLbxJwr60en3CFfy3XVD05PfxM=.70893dde-009d-44a5-85a6-249f245dadd8@github.com> Message-ID: On Mon, 21 Mar 2022 20:46:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: d064d8ef Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/d064d8ef6429253368143d2d94c8444e6ec6db09 Stats: 16 lines in 3 files changed: 10 ins; 0 del; 6 mod 8242313: use reproducible random in hotspot svc tests Backport-of: 116fe806c3008680cfb21484f6469a5ccb638c5d ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/931 From goetz at openjdk.java.net Thu Mar 24 13:45:41 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 24 Mar 2022 13:45:41 GMT Subject: [jdk11u-dev] Integrated: 8242311: use reproducible random in hotspot runtime tests In-Reply-To: <0DHFRd2oy5sK20PPx3MfkCGgd5xHINoEStCrj3jDy4I=.9cc72374-4a24-4e38-af09-b8fb3abc8430@github.com> References: <0DHFRd2oy5sK20PPx3MfkCGgd5xHINoEStCrj3jDy4I=.9cc72374-4a24-4e38-af09-b8fb3abc8430@github.com> Message-ID: On Mon, 21 Mar 2022 20:58:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > SharedArchiveConsistency.java > GCStressApp.java > GCStressTest.java > Test were moved, patch applies with the following edits if the paths are adapted: > Copyright in GCStressApp.java > Copyright, test description in GCStressTest.java > > This test is not in 11: NullPointerExceptionTest.java This pull request has now been integrated. Changeset: c1524748 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/c1524748a92e67de09263e8035c8eb8a5a49c6b1 Stats: 21 lines in 6 files changed: 7 ins; 1 del; 13 mod 8242311: use reproducible random in hotspot runtime tests Reviewed-by: mdoerr Backport-of: c73934d8c8dcc81c85f770ce303f2cb47823785f ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/932 From goetz at openjdk.java.net Thu Mar 24 13:45:48 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 24 Mar 2022 13:45:48 GMT Subject: [jdk11u-dev] Integrated: 8278472: Invalid value set to CANDIDATEFORM structure In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 15:11:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: 6aecb158 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/6aecb158d0e424eb2fbf83be728b131398a0def3 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8278472: Invalid value set to CANDIDATEFORM structure Backport-of: 2426d58e592c54de64ebe0f06448d239aeced082 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/934 From goetz at openjdk.java.net Thu Mar 24 13:48:49 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 24 Mar 2022 13:48:49 GMT Subject: [jdk11u-dev] Integrated: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 15:15:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to resolve the copyrights, the rest applied clean. Marking as clean backport. This pull request has now been integrated. Changeset: 8eeba890 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/8eeba890d1a21ccff12de10d37acc8dde370af2c Stats: 28 lines in 2 files changed: 23 ins; 0 del; 5 mod 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths Reviewed-by: mdoerr Backport-of: 84868e39be4522ba87e603beea0f8da9efa43b6d ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/935 From goetz at openjdk.java.net Thu Mar 24 13:51:49 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 24 Mar 2022 13:51:49 GMT Subject: [jdk11u-dev] Integrated: 8282583: Update BCEL md to include the copyright notice In-Reply-To: <3BLv8XtmL5ORqMxeBYufjJ9l0i0WYgszL5TqyQ_BUX0=.4b83059f-8513-43dd-92e9-73f5cd5a2b0b@github.com> References: <3BLv8XtmL5ORqMxeBYufjJ9l0i0WYgszL5TqyQ_BUX0=.4b83059f-8513-43dd-92e9-73f5cd5a2b0b@github.com> Message-ID: On Tue, 22 Mar 2022 15:27:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: f3b76aee Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/f3b76aee072a78dc989757040987d5d2f6161402 Stats: 8 lines in 1 file changed: 0 ins; 3 del; 5 mod 8282583: Update BCEL md to include the copyright notice Backport-of: 8478173d837113bf603aadb614badd461f474250 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/936 From goetz at openjdk.java.net Thu Mar 24 13:58:07 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 24 Mar 2022 13:58:07 GMT Subject: [jdk17u-dev] Integrated: 8255266: Update Public Suffix List to 3c213aa In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 07:47:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.4-oracle. This pull request has now been integrated. Changeset: ba6f7333 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk17u-dev/commit/ba6f73330b25e909f09f347b4d1834bbc36c0b25 Stats: 1254 lines in 5 files changed: 887 ins; 215 del; 152 mod 8255266: Update Public Suffix List to 3c213aa Backport-of: 7ce75afbbcca7635356c7377be7ddff15335e563 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/275 From erik.joelsson at oracle.com Thu Mar 24 14:01:53 2022 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Thu, 24 Mar 2022 07:01:53 -0700 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: Message-ID: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com> Hello, I agree that solving SKARA-1199 would provide quite a bit of benefit to the update releases. The current process works, but it requires knowledge and manual care to not make mistakes. One of the main ideas with Skara was to codify our processes to make them more foolproof and easy to follow. I definitely think this approval process fits the bill as something we should support better with tooling. Breaking apart the problem a bit, from the perspective of a user developing a fix for an update release that requires approval, I agree with Kevin that the current state of the approval should be reflected as a "progress" on the PR. That makes it very clear if the PR is ready for integration or not and fits in with how Skara tracks and treats other integration blockers. Basing this functionality around the model of the /sponsor command would be a pretty major shift in my opinion. It moves the ability to actually integrate, and as such the control of the timing, from the contributor to the integrator. This mimics how some other big open source projects handle things (e.g. the Linux kernel). I think it makes sense to do this when sponsoring, because we are then helping new and inexperienced (in OpenJDK processes at least) users, which helps prevent mistakes. For contributors of committer status or above, I think we should retain their ability to control the timing of integration. Implementation wise, I don't think it makes a big difference. The other part of the problem, which I think is what this discussion should really focus on, is where the official approval takes place. We can keep it in JBS like today, or we can move it to the PR, as suggested by Andrew. From an implementation point of view, moving it to the PR is less work, but I don't think we should base this decision on process on if it takes an extra day to implement. The tooling should support the process we want. Without having spent a lot of time thinking about it so please tell me if I'm missing something, would it be possible to support a hybrid/dual solution? The official process could still be the labels in the JBS issues, but the Skara 'integrator'-only /approve command on a PR could also add the appropriate *-fix-yes label to all associated bugs. There would also be a Skara bot monitoring JBS and automatically updating the approval status on PRs based on labels in JBS. This would shortcut the process for integrators that prefer working through PRs, while integrators that prefer to work through JBS can continue the same way as before. I think this should alleviate the issue of backporting many bugs with one PR. This is of course also the biggest change to implement, but not that much more than what I had already outlined in SKARA-1199. /Erik On 2022-03-23 13:13, Andrew Hughes wrote: > Hi all, > > We have been discussing how to implement and/or adapt the current > approval process (jdk-fix-request, jdk-fix-yes, etc.) to SKARA > on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199 > > At present, we have been continuing to approve bugs for update > releases as we did in Mercurial; when the change is reviewed, the > proposer should flag it as jdk<>-fix-request (or > jdk<>-critical-request for a rampdown fix) and then an approver > responds with the *-yes or *-no response on the bug. > > SKARA has introduced a new worry for me into this process, due to the > way the PR bot directs the user through the change process. This in > itself is a good thing. However, while it is currently not aware of > the approval process, it can encourage someone to integrate a change > which has not yet been approved. Hence why I feel some solution to > SKARA-1199 is quite critical (especially with the potential move of > the master 8u repository to SKARA) and it surprises me that other > update projects have not pushed harder for this, prior to 8u adopting > SKARA. > > In thinking through how to implement this in SKARA, it occurred to me > that trying to continue with what we have now may not be the best > solution. The issues I see are: > > 1. Having the approval process in the bug database separate from the > proposed commit on GitHub creates a disconnect between the two. > We had this before, with the separation between mailing list activity > and the bug database, but now that pretty much everything else happens > in GitHub/SKARA, it feels odd to have to go back and forth between > JBS and GitHub to approve a change. > > 2. Access to add a label in JBS requires someone to have JDK authorship > status, so, for non-authors, someone else has to do this on their > behalf (as with sponsoring) > > 3. On the flip-side to #2, any JDK author can add jdk-fix-yes or > jdk-critical-yes to a bug, as I believe has happened in the past. > > 4. From a technical perspective, this means JBS has to be regularly > probed to pick up new labels. This also affects CSRs, which already > have issues in this area, and the demand for backports would be > much higher. > > 5. When we've dealt with backports which affect multiple bugs, > the informal process we've had in the past means we've been able > to choose whether to require that all bugs are flagged or not. > Having a formal version of the process we have now in SKARA would > mean having to label every referenced bug in something like [0]. > > My proposal would be that we shift approvals to SKARA in a similar > way to which sponsorship is currently handled: > > 1. When a PR for a backport project reaches the point at which > it would currently be integrated (after either /integrate for > a committer or /sponsor for a non-committer), it instead > gets an 'approval' label. > > 2. For the PR to move forward, an 'integrator' (someone capable > of merges & tags) [1] would need to perform '/approval [yes|no]' to > cause the change to either be integrated or rejected. > > I believe this would simplify the implementation of this feature > a lot and also integrate it better into SKARA. > > The bot could still label bugs with the jdk-fix-request when > it adds the 'approval' label to the PR and with jdk-fix-yes > and jdk-fix-no when the /approval command is used. > > The use of jdk-fix-request or jdk-critical-request can > also be pre-determined by the bot, based on the repository > the PR is against (jdku-dev for the former, jdku for the > latter). This is something that would go in the server-side > bot configuration. > > Thoughts? > > I'm honestly struggling to see why we'd hold onto the existing > process, but I also realise that adaptation can be hard, particularly > for other update projects where SKARA has been in use longer. > > [0] https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b95933aa35eac6 > [1] https://bugs.openjdk.java.net/browse/SKARA-1384 > > Thanks, From goetz.lindenmaier at sap.com Thu Mar 24 14:22:22 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 24 Mar 2022 14:22:22 +0000 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: Message-ID: Hi, Basically I would appreciate some more guidance by Sakra for the backports. Blocking /integrate until the change is approved makes sense. Restricting approval to maintainers makes sense, too. I would not force sequentialization of review and approval though. The maintainer can decide by himself whether the review is needed to approve the change. If both, review and approval, are enforced by Skara before a change can be integrated, the maintainer should be able to approve a change before it is reviewed if he thinks the change is definitely needed. This would make backporting and the maintainer task much more efficient. (Maybe the maintainer can have a command /requires_review_for_approval). Also, I would not want to move all work, or, more precisely, all the documentation, to the PR. We do not need the tags in JBS if approval is handled on the PR. But what I want to see in JBS is the comment that states * why the change should be backported * the risk of the backport * the amount of work done on top of the original change Pull requests contain all sort of data, and often there are several pull request until one of them gets pushed. Is it possible to have a command /request_approval that adds the rest of the comment as a comment to JBS? So that I can write in the PR: The issue fixed by this change also exists in jdk xy. The test in this change fails without the patch and Succeeds after applying it. The risk of this backport is low because the change is very local. /request_approval And all of the comment is added to JBS under a heading "Fix request xy". Similar, when the maintainer says /approval-yes or -no, a comment should be added to the JBS issue. The JBS is the basic source of information for me when I want to approve a change. It lists related issues and the discussion in the comments often is helpful. Therefore the comment should end up there. And one thing that is important: there must be a way to filter for the PRs that need approval ?? Just my 5ct ?? Best regards, Goetz. > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Andrew Hughes > Sent: Wednesday, March 23, 2022 9:14 PM > To: jdk8u-dev at openjdk.java.net; jdk-updates-dev at openjdk.java.net > Subject: [Proposal] Maintainer Approvals and SKARA > > Hi all, > > We have been discussing how to implement and/or adapt the current > approval process (jdk-fix-request, jdk-fix-yes, etc.) to SKARA > on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199 > > At present, we have been continuing to approve bugs for update > releases as we did in Mercurial; when the change is reviewed, the > proposer should flag it as jdk<>-fix-request (or > jdk<>-critical-request for a rampdown fix) and then an approver > responds with the *-yes or *-no response on the bug. > > SKARA has introduced a new worry for me into this process, due to the > way the PR bot directs the user through the change process. This in > itself is a good thing. However, while it is currently not aware of > the approval process, it can encourage someone to integrate a change > which has not yet been approved. Hence why I feel some solution to > SKARA-1199 is quite critical (especially with the potential move of > the master 8u repository to SKARA) and it surprises me that other > update projects have not pushed harder for this, prior to 8u adopting > SKARA. > > In thinking through how to implement this in SKARA, it occurred to me > that trying to continue with what we have now may not be the best > solution. The issues I see are: > > 1. Having the approval process in the bug database separate from the > proposed commit on GitHub creates a disconnect between the two. > We had this before, with the separation between mailing list activity > and the bug database, but now that pretty much everything else happens > in GitHub/SKARA, it feels odd to have to go back and forth between > JBS and GitHub to approve a change. > > 2. Access to add a label in JBS requires someone to have JDK authorship > status, so, for non-authors, someone else has to do this on their > behalf (as with sponsoring) > > 3. On the flip-side to #2, any JDK author can add jdk-fix-yes or > jdk-critical-yes to a bug, as I believe has happened in the past. > > 4. From a technical perspective, this means JBS has to be regularly > probed to pick up new labels. This also affects CSRs, which already > have issues in this area, and the demand for backports would be > much higher. > > 5. When we've dealt with backports which affect multiple bugs, > the informal process we've had in the past means we've been able > to choose whether to require that all bugs are flagged or not. > Having a formal version of the process we have now in SKARA would > mean having to label every referenced bug in something like [0]. > > My proposal would be that we shift approvals to SKARA in a similar > way to which sponsorship is currently handled: > > 1. When a PR for a backport project reaches the point at which > it would currently be integrated (after either /integrate for > a committer or /sponsor for a non-committer), it instead > gets an 'approval' label. > > 2. For the PR to move forward, an 'integrator' (someone capable > of merges & tags) [1] would need to perform '/approval [yes|no]' to > cause the change to either be integrated or rejected. > > I believe this would simplify the implementation of this feature > a lot and also integrate it better into SKARA. > > The bot could still label bugs with the jdk-fix-request when > it adds the 'approval' label to the PR and with jdk-fix-yes > and jdk-fix-no when the /approval command is used. > > The use of jdk-fix-request or jdk-critical-request can > also be pre-determined by the bot, based on the repository > the PR is against (jdku-dev for the former, jdku for the > latter). This is something that would go in the server-side > bot configuration. > > Thoughts? > > I'm honestly struggling to see why we'd hold onto the existing > process, but I also realise that adaptation can be hard, particularly > for other update projects where SKARA has been in use longer. > > [0] > https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b9 > 5933aa35eac6 > [1] https://bugs.openjdk.java.net/browse/SKARA-1384 > > Thanks, > -- > Andrew :) > Pronouns: he / him or they / them > Senior Free Java Software Engineer > OpenJDK Package Owner > Red Hat, Inc. > (https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww > .redhat.com%2F&data=04%7C01%7Cgoetz.lindenmaier%40sap.com%7C > 2cf36bbd0cb84c6d579b08da0d09d818%7C42f7676cf455423c82f6dc2d99791af7 > %7C0%7C0%7C637836633177510023%7CUnknown%7CTWFpbGZsb3d8eyJWIj > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > 000&sdata=v%2Fv1UexHL%2Fz%2BX3kSQTcClsNWH2BRebaOWqPEP0gE > VTE%3D&reserved=0) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 From goetz.lindenmaier at sap.com Thu Mar 24 14:41:52 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 24 Mar 2022 14:41:52 +0000 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: <1d4d5f66e456f214f3fd4ebf6746da9afdf6ea4f.camel@redhat.com> References: <1d4d5f66e456f214f3fd4ebf6746da9afdf6ea4f.camel@redhat.com> Message-ID: +1 ! The information must go to JBS! ... this just came in while I was typing. I think it can be achieved by Skara that the right information ends up in the bug, see my mail on this topic. > In general, the > process is fairly well understood and I don't anticipate this to be a > huge problem in practise. Incomplete changes being tagged cause of overhead on my side (as maintainer). I read them every day and check whether the missing parts were added, this really is a nuisance. On the other side, needing review and approval sequentially causes unnecessary overhead if I am backporting. So Skara could help here. Best regards, Goetz. > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Severin Gehwolf > Sent: Thursday, March 24, 2022 2:06 PM > To: jdk8u-dev at openjdk.java.net; jdk-updates-dev at openjdk.java.net > Subject: Re: [Proposal] Maintainer Approvals and SKARA > > On Wed, 2022-03-23 at 20:13 +0000, Andrew Hughes wrote: > > > > Hi all, > > > > We have been discussing how to implement and/or adapt the current > > approval process (jdk-fix-request, jdk-fix-yes, etc.) to SKARA > > on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199 > > > > At present, we have been continuing to approve bugs for update > > releases as we did in Mercurial; when the change is reviewed, the > > proposer should flag it as jdk<>-fix-request (or > > jdk<>-critical-request for a rampdown fix) and then an approver > > responds with the *-yes or *-no response on the bug. > > > > SKARA has introduced a new worry for me into this process, due to the > > way the PR bot directs the user through the change process. This in > > itself is a good thing. However, while it is currently not aware of > > the approval process, it can encourage someone to integrate a change > > which has not yet been approved. Hence why I feel some solution to > > SKARA-1199 is quite critical (especially with the potential move of > > the master 8u repository to SKARA) and it surprises me that other > > update projects have not pushed harder for this, prior to 8u adopting > > SKARA. > > > > In thinking through how to implement this in SKARA, it occurred to me > > that trying to continue with what we have now may not be the best > > solution. The issues I see are: > > > > 1. Having the approval process in the bug database separate from the > > proposed commit on GitHub creates a disconnect between the two. > > We had this before, with the separation between mailing list activity > > and the bug database, but now that pretty much everything else > > happens in GitHub/SKARA, it feels odd to have to go back and forth > > between JBS and GitHub to approve a change. > > > > > 2. Access to add a label in JBS requires someone to have JDK > > authorship > > status, so, for non-authors, someone else has to do this on their > > behalf (as with sponsoring) > > > > 3. On the flip-side to #2, any JDK author can add jdk-fix-yes or > > jdk-critical-yes to a bug, as I believe has happened in the past. > > > > 4. From a technical perspective, this means JBS has to be regularly > > probed to pick up new labels. This also affects CSRs, which already > > have issues in this area, and the demand for backports would be > > much higher. > > > > 5. When we've dealt with backports which affect multiple bugs, > > the informal process we've had in the past means we've been able > > to choose whether to require that all bugs are flagged or not. > > Having a formal version of the process we have now in SKARA would > > mean having to label every referenced bug in something like [0]. > > > > My proposal would be that we shift approvals to SKARA in a similar > > way to which sponsorship is currently handled: > > > > 1. When a PR for a backport project reaches the point at which > > it would currently be integrated (after either /integrate for > > a committer or /sponsor for a non-committer), it instead > > gets an 'approval' label. > > > > 2. For the PR to move forward, an 'integrator' (someone capable > > of merges & tags) [1] would need to perform '/approval [yes|no]' to > > cause the change to either be integrated or rejected. > > > > I believe this would simplify the implementation of this feature > > a lot and also integrate it better into SKARA. > > > > The bot could still label bugs with the jdk-fix-request when > > it adds the 'approval' label to the PR and with jdk-fix-yes > > and jdk-fix-no when the /approval command is used. > > > > The use of jdk-fix-request or jdk-critical-request can > > also be pre-determined by the bot, based on the repository > > the PR is against (jdku-dev for the former, jdku for the > > latter).? This is something that would go in the server-side > > bot configuration. > > > > Thoughts? > > My worry would be that "Fix Request" comments would be spread across > different PRs if a single bug gets backported to, many update releases. > JDK 18u, 17u, 11u and 8u, for example. It would move the "approval" > conversation to the source control system (and per backport PR) rather > than the bug database. From a maintenance perspective it makes sense to > have all the info related to backports in one place (on the bug). If > something gets requested for 8u, say, I can see immediately in the bug > database that it has been backported to later releases too and can see > the approval flags (and who approved it). Moving this to skare makes > the info much more dispersed. > > Besides, we've had the issue of update project committers being able to > integrate without formal approval in JBS before. It's only much more > visible now (which is a good thing). I.e. the problem doesn't change > with Skara. The difference really is bot guidance. In general, the > process is fairly well understood and I don't anticipate this to be a > huge problem in practise. > > Thanks, > Severin > > > I'm honestly struggling to see why we'd hold onto the existing > > process, but I also realise that adaptation can be hard, particularly > > for other update projects where SKARA has been in use longer. > > > > [0] > > > https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b9 > 593= > > 3aa35eac6 > > [1] https://bugs.openjdk.java.net/browse/SKARA-1384 > > > > Thanks, > > --=20 > > Andrew :) > > Pronouns: he / him or they / them > > Senior Free Java Software Engineer > > OpenJDK Package Owner > > Red Hat, Inc. > (https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww > .redhat.com%2F&data=04%7C01%7Cgoetz.lindenmaier%40sap.com%7C > 66d9ee8f7f544393a57208da0d971909%7C42f7676cf455423c82f6dc2d99791af7 > %7C0%7C0%7C637837239853649848%7CUnknown%7CTWFpbGZsb3d8eyJWIj > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > 000&sdata=uoNga%2FeHXVQ9s9eIUUhU6InC4P4i9fRlv%2F5YGGRKJcE% > 3D&reserved=0) > > > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > > Fingerprint =3D 5132 579D D154 0ED2 3E04? C5A0 CFDA 0F9B 3596 4222 > > > > --X28JfW0BSfKBk7hD-- > > From goetz at openjdk.java.net Thu Mar 24 16:33:55 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Thu, 24 Mar 2022 16:33:55 GMT Subject: [jdk11u-dev] RFR: 8228609: G1 copy cost prediction uses used vs. actual copied bytes [v3] In-Reply-To: References: Message-ID: On Tue, 22 Mar 2022 03:58:57 GMT, Yude Lin wrote: >> I would like to backport 8228609 which fixes a prediction error regarding cost per bytes copied. >> >> The patch does not apply cleanly, so this backport is basically changing the calculation of copied bytes. >> >> https://bugs.openjdk.java.net/browse/JDK-8227442 is not in 11u. So this patch also uses G1ParScanThreadState::surviving_young_words() in place of _surviving_young_words to adjust for the correct cset index. > > Yude Lin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8228609: G1 copy cost prediction uses used vs. actual copied bytes @linade Two more things, please: * Enable Pre-submit tests * Only flag the change with jdk11u-fix-request once it is ready. I'll remove the tag for now, pleas add it again if the review is available. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/927 From christoph.langer at sap.com Thu Mar 24 16:46:21 2022 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 24 Mar 2022 16:46:21 +0000 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com> References: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com> Message-ID: Hi Erik, all, I completely second both points: 1. The fact that the maintainer/approval process could be improved from a tooling perspective and 2. In the end, the information has to be persisted in JBS. I very much like your analysis, Erik, and I think I would welcome a hybrid solution. So there should still be the labels and request like we have now. A missing approval label should be an integration blocker in the PR. And if we'd in the end get some commands, like /approve which only maintainers are allowed to issue and /request-approval which adds the request to JBS, also enabling non JBS users to request approval, it would greatly help. Thanks & Best regards Christoph > -----Original Message----- > From: jdk8u-dev On Behalf Of > erik.joelsson at oracle.com > Sent: Donnerstag, 24. M?rz 2022 15:02 > To: Andrew Hughes ; jdk8u-dev at openjdk.java.net; > jdk-updates-dev at openjdk.java.net > Subject: Re: [Proposal] Maintainer Approvals and SKARA > > Hello, > > I agree that solving SKARA-1199 would provide quite a bit of benefit to the > update releases. The current process works, but it requires knowledge and > manual care to not make mistakes. One of the main ideas with Skara was to > codify our processes to make them more foolproof and easy to follow. I > definitely think this approval process fits the bill as something we should > support better with tooling. > > Breaking apart the problem a bit, from the perspective of a user developing a > fix for an update release that requires approval, I agree with Kevin that the > current state of the approval should be reflected as a "progress" on the PR. > That makes it very clear if the PR is ready for integration or not and fits in with > how Skara tracks and treats other integration blockers. Basing this functionality > around the model of the /sponsor command would be a pretty major shift in > my opinion. It moves the ability to actually integrate, and as such the control of > the timing, from the contributor to the integrator. This mimics how some other > big open source projects handle things (e.g. the Linux kernel). I think it makes > sense to do this when sponsoring, because we are then helping new and > inexperienced (in OpenJDK processes at least) users, which helps prevent > mistakes. For contributors of committer status or above, I think we should > retain their ability to control the timing of integration. Implementation wise, I > don't think it makes a big difference. > > The other part of the problem, which I think is what this discussion should > really focus on, is where the official approval takes place. We can keep it in JBS > like today, or we can move it to the PR, as suggested by Andrew. From an > implementation point of view, moving it to the PR is less work, but I don't think > we should base this decision on process on if it takes an extra day to > implement. The tooling should support the process we want. > > Without having spent a lot of time thinking about it so please tell me if I'm > missing something, would it be possible to support a hybrid/dual solution? The > official process could still be the labels in the JBS issues, but the Skara > 'integrator'-only /approve command on a PR could also add the appropriate *- > fix-yes label to all associated bugs. There would also be a Skara bot monitoring > JBS and automatically updating the approval status on PRs based on labels in > JBS. This would shortcut the process for integrators that prefer working > through PRs, while integrators that prefer to work through JBS can continue > the same way as before. I think this should alleviate the issue of backporting > many bugs with one PR. This is of course also the biggest change to implement, > but not that much more than what I had already outlined in SKARA-1199. > > /Erik > > > On 2022-03-23 13:13, Andrew Hughes wrote: > > Hi all, > > > > We have been discussing how to implement and/or adapt the current > > approval process (jdk-fix-request, jdk-fix-yes, etc.) to SKARA > > on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199 > > > > At present, we have been continuing to approve bugs for update > > releases as we did in Mercurial; when the change is reviewed, the > > proposer should flag it as jdk<>-fix-request (or > > jdk<>-critical-request for a rampdown fix) and then an approver > > responds with the *-yes or *-no response on the bug. > > > > SKARA has introduced a new worry for me into this process, due to the > > way the PR bot directs the user through the change process. This in > > itself is a good thing. However, while it is currently not aware of > > the approval process, it can encourage someone to integrate a change > > which has not yet been approved. Hence why I feel some solution to > > SKARA-1199 is quite critical (especially with the potential move of > > the master 8u repository to SKARA) and it surprises me that other > > update projects have not pushed harder for this, prior to 8u adopting > > SKARA. > > > > In thinking through how to implement this in SKARA, it occurred to me > > that trying to continue with what we have now may not be the best > > solution. The issues I see are: > > > > 1. Having the approval process in the bug database separate from the > > proposed commit on GitHub creates a disconnect between the two. > > We had this before, with the separation between mailing list activity > > and the bug database, but now that pretty much everything else happens > > in GitHub/SKARA, it feels odd to have to go back and forth between JBS > > and GitHub to approve a change. > > > > 2. Access to add a label in JBS requires someone to have JDK > > authorship status, so, for non-authors, someone else has to do this on > > their behalf (as with sponsoring) > > > > 3. On the flip-side to #2, any JDK author can add jdk-fix-yes or > > jdk-critical-yes to a bug, as I believe has happened in the past. > > > > 4. From a technical perspective, this means JBS has to be regularly > > probed to pick up new labels. This also affects CSRs, which already > > have issues in this area, and the demand for backports would be much > > higher. > > > > 5. When we've dealt with backports which affect multiple bugs, the > > informal process we've had in the past means we've been able to choose > > whether to require that all bugs are flagged or not. > > Having a formal version of the process we have now in SKARA would mean > > having to label every referenced bug in something like [0]. > > > > My proposal would be that we shift approvals to SKARA in a similar way > > to which sponsorship is currently handled: > > > > 1. When a PR for a backport project reaches the point at which it > > would currently be integrated (after either /integrate for a committer > > or /sponsor for a non-committer), it instead gets an 'approval' label. > > > > 2. For the PR to move forward, an 'integrator' (someone capable of > > merges & tags) [1] would need to perform '/approval [yes|no]' to cause > > the change to either be integrated or rejected. > > > > I believe this would simplify the implementation of this feature a lot > > and also integrate it better into SKARA. > > > > The bot could still label bugs with the jdk-fix-request when it > > adds the 'approval' label to the PR and with jdk-fix-yes and > > jdk-fix-no when the /approval command is used. > > > > The use of jdk-fix-request or jdk-critical-request can also be > > pre-determined by the bot, based on the repository the PR is against > > (jdku-dev for the former, jdku for the latter). This is > > something that would go in the server-side bot configuration. > > > > Thoughts? > > > > I'm honestly struggling to see why we'd hold onto the existing > > process, but I also realise that adaptation can be hard, particularly > > for other update projects where SKARA has been in use longer. > > > > [0] > > > https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b95 > 9 > > 33aa35eac6 [1] https://bugs.openjdk.java.net/browse/SKARA-1384 > > > > Thanks, From goetz.lindenmaier at sap.com Thu Mar 24 17:00:33 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 24 Mar 2022 17:00:33 +0000 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: <1d4d5f66e456f214f3fd4ebf6746da9afdf6ea4f.camel@redhat.com> Message-ID: Hi, A good example why the information should be gathered in the bug and not in the PRs is https://bugs.openjdk.java.net/browse/JDK-8274471. The comments tell why and how the change was backported. This is good to have in the JBS issue. Then there are 2 PRs for 17 and 2 PRs for 11. If someone wants to backport to 15, 13 or 8, all the information is in one place. Having to read the four PRs would be very cumbersome! Similar for someone who wants to understand what happened because he tries to track down a bug in, say 11, where he hit on the changed code... The comment clearly says there were substantial changes. This is helpful in this place. Best regards, Goetz. > -----Original Message----- > From: Lindenmaier, Goetz > Sent: Thursday, March 24, 2022 3:42 PM > To: 'Severin Gehwolf' ; jdk8u- > dev at openjdk.java.net; jdk-updates-dev at openjdk.java.net > Subject: RE: [Proposal] Maintainer Approvals and SKARA > > +1 ! The information must go to JBS! > > ... this just came in while I was typing. > > I think it can be achieved by Skara that the right information > ends up in the bug, see my mail on this topic. > > > > In general, the > > process is fairly well understood and I don't anticipate this to be a > > huge problem in practise. > Incomplete changes being tagged cause > of overhead on my side (as maintainer). I read them every day and > check whether the missing parts were added, this > really is a nuisance. > > On the other side, needing review and approval sequentially > causes unnecessary overhead if I am backporting. > > So Skara could help here. > > Best regards, > Goetz. > > > -----Original Message----- > > From: jdk-updates-dev On > > Behalf Of Severin Gehwolf > > Sent: Thursday, March 24, 2022 2:06 PM > > To: jdk8u-dev at openjdk.java.net; jdk-updates-dev at openjdk.java.net > > Subject: Re: [Proposal] Maintainer Approvals and SKARA > > > > On Wed, 2022-03-23 at 20:13 +0000, Andrew Hughes wrote: > > > > > > Hi all, > > > > > > We have been discussing how to implement and/or adapt the current > > > approval process (jdk-fix-request, jdk-fix-yes, etc.) to SKARA > > > on this bug: https://bugs.openjdk.java.net/browse/SKARA-1199 > > > > > > At present, we have been continuing to approve bugs for update > > > releases as we did in Mercurial; when the change is reviewed, the > > > proposer should flag it as jdk<>-fix-request (or > > > jdk<>-critical-request for a rampdown fix) and then an approver > > > responds with the *-yes or *-no response on the bug. > > > > > > SKARA has introduced a new worry for me into this process, due to the > > > way the PR bot directs the user through the change process. This in > > > itself is a good thing. However, while it is currently not aware of > > > the approval process, it can encourage someone to integrate a change > > > which has not yet been approved. Hence why I feel some solution to > > > SKARA-1199 is quite critical (especially with the potential move of > > > the master 8u repository to SKARA) and it surprises me that other > > > update projects have not pushed harder for this, prior to 8u adopting > > > SKARA. > > > > > > In thinking through how to implement this in SKARA, it occurred to me > > > that trying to continue with what we have now may not be the best > > > solution. The issues I see are: > > > > > > 1. Having the approval process in the bug database separate from the > > > proposed commit on GitHub creates a disconnect between the two. > > > We had this before, with the separation between mailing list activity > > > and the bug database, but now that pretty much everything else > > > happens in GitHub/SKARA, it feels odd to have to go back and forth > > > between JBS and GitHub to approve a change. > > > > > > > > > 2. Access to add a label in JBS requires someone to have JDK > > > authorship > > > status, so, for non-authors, someone else has to do this on their > > > behalf (as with sponsoring) > > > > > > 3. On the flip-side to #2, any JDK author can add jdk-fix-yes or > > > jdk-critical-yes to a bug, as I believe has happened in the past. > > > > > > 4. From a technical perspective, this means JBS has to be regularly > > > probed to pick up new labels. This also affects CSRs, which already > > > have issues in this area, and the demand for backports would be > > > much higher. > > > > > > 5. When we've dealt with backports which affect multiple bugs, > > > the informal process we've had in the past means we've been able > > > to choose whether to require that all bugs are flagged or not. > > > Having a formal version of the process we have now in SKARA would > > > mean having to label every referenced bug in something like [0]. > > > > > > My proposal would be that we shift approvals to SKARA in a similar > > > way to which sponsorship is currently handled: > > > > > > 1. When a PR for a backport project reaches the point at which > > > it would currently be integrated (after either /integrate for > > > a committer or /sponsor for a non-committer), it instead > > > gets an 'approval' label. > > > > > > 2. For the PR to move forward, an 'integrator' (someone capable > > > of merges & tags) [1] would need to perform '/approval [yes|no]' to > > > cause the change to either be integrated or rejected. > > > > > > I believe this would simplify the implementation of this feature > > > a lot and also integrate it better into SKARA. > > > > > > The bot could still label bugs with the jdk-fix-request when > > > it adds the 'approval' label to the PR and with jdk-fix-yes > > > and jdk-fix-no when the /approval command is used. > > > > > > The use of jdk-fix-request or jdk-critical-request can > > > also be pre-determined by the bot, based on the repository > > > the PR is against (jdku-dev for the former, jdku for the > > > latter).? This is something that would go in the server-side > > > bot configuration. > > > > > > Thoughts? > > > > My worry would be that "Fix Request" comments would be spread across > > different PRs if a single bug gets backported to, many update releases. > > JDK 18u, 17u, 11u and 8u, for example. It would move the "approval" > > conversation to the source control system (and per backport PR) rather > > than the bug database. From a maintenance perspective it makes sense to > > have all the info related to backports in one place (on the bug). If > > something gets requested for 8u, say, I can see immediately in the bug > > database that it has been backported to later releases too and can see > > the approval flags (and who approved it). Moving this to skare makes > > the info much more dispersed. > > > > Besides, we've had the issue of update project committers being able to > > integrate without formal approval in JBS before. It's only much more > > visible now (which is a good thing). I.e. the problem doesn't change > > with Skara. The difference really is bot guidance. In general, the > > process is fairly well understood and I don't anticipate this to be a > > huge problem in practise. > > > > Thanks, > > Severin > > > > > I'm honestly struggling to see why we'd hold onto the existing > > > process, but I also realise that adaptation can be hard, particularly > > > for other update projects where SKARA has been in use longer. > > > > > > [0] > > > > > > https://github.com/openjdk/jdk8u/commit/845d40ae217ff47ec53e2fd655b9 > > 593= > > > 3aa35eac6 > > > [1] https://bugs.openjdk.java.net/browse/SKARA-1384 > > > > > > Thanks, > > > --=20 > > > Andrew :) > > > Pronouns: he / him or they / them > > > Senior Free Java Software Engineer > > > OpenJDK Package Owner > > > Red Hat, Inc. > > > (https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww > > .redhat.com%2F&data=04%7C01%7Cgoetz.lindenmaier%40sap.com% > 7C > > > 66d9ee8f7f544393a57208da0d971909%7C42f7676cf455423c82f6dc2d99791af7 > > %7C0%7C0%7C637837239853649848%7CUnknown%7CTWFpbGZsb3d8eyJW > Ij > > > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > > 000&sdata=uoNga%2FeHXVQ9s9eIUUhU6InC4P4i9fRlv%2F5YGGRKJcE% > > 3D&reserved=0) > > > > > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > > > Fingerprint =3D 5132 579D D154 0ED2 3E04? C5A0 CFDA 0F9B 3596 4222 > > > > > > --X28JfW0BSfKBk7hD-- > > > From goetz at openjdk.java.net Fri Mar 25 07:21:22 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Fri, 25 Mar 2022 07:21:22 GMT Subject: [jdk11u-dev] RFR: 8210112: remove jdk.testlibrary.ProcessTools Message-ID: I want to backport this ot simplify follow-up test backports. I had to adapt the change in several means. This is a list of the changes to resolve failed hunks: Already fixed: patching file test/jdk/com/sun/jdi/ExclusiveBind.java Resolved, 8211171 move JarUtils to top-level testlibrary already backported. patching file test/jdk/java/lang/ClassLoader/getResource/automaticmodules/Driver.java patching file test/jdk/java/lang/ClassLoader/securityManager/ClassLoaderTest.java patching file test/jdk/java/lang/instrument/executableJAR/ExecJarWithAgent.java patching file test/jdk/java/rmi/module/ModuleTest.java Context patching file test/jdk/java/lang/System/OsVersionTest.java patching file test/jdk/java/security/Policy/SignedJar/SignedJarTest.java patching file test/jdk/java/util/Arrays/TimSortStackSize2.java Copyright patching file test/jdk/javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java Resolved, 8211171 move JarUtils to top-level testlibrary already backported. patching file test/jdk/jdk/modules/scenarios/automaticmodules/RunWithAutomaticModules.java patching file test/jdk/sun/security/tools/jarsigner/TsacertOptionTest.java Copyright patching file test/jdk/sun/security/tools/jarsigner/Warning.java patching file test/jdk/sun/security/tools/jarsigner/warnings/BadKeyUsageTest.java Resolved, 8211171 move JarUtils to top-level testlibrary already backported. patching file test/jdk/sun/security/tools/jarsigner/warnings/NoTimestampTest.java File not in 11: --- probably goes away test/jdk/sun/tools/jcmd/JcmdBase.java b/test/jdk/sun/tools/jcmd/JcmdBase.java patching file test/jdk/sun/tools/jcmd/TestJcmdDefaults.java patching file test/jdk/sun/tools/jcmd/TestJcmdSanity.java Copyright patching file test/jdk/sun/tools/jmap/BasicJMapTest.java Resolved patching file test/jdk/sun/tools/jstatd/JstatdTest.java Resolved, 8211171 move JarUtils to top-level testlibrary already backported. patching file test/jdk/tools/jlink/basic/BasicTest.java patching file test/jdk/tools/launcher/modules/addexports/manifest/AddExportsAndOpensInManifest.java patching file test/jdk/tools/launcher/modules/addreads/AddReadsTest.java patching file test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java patching file test/jdk/tools/launcher/modules/patch/basic/PatchTest.java patching file test/jdk/tools/launcher/modules/patch/basic/PatchTestWarningError.java patching file test/jdk/tools/launcher/modules/validate/ValidateModulesTest.java On top of this, I had to adapt a few tests to work after removal of the old testlibrary file. Last, I had to move the `change` of "8217375: jarsigner breaks old signature with long lines in manifest" to OutputAnalyzer.java from the old file to the new one. Now all test are passing. ------------- Commit messages: - Backport 21a0458422c462f5ae82a98ce08c6460db26c67e Changes: https://git.openjdk.java.net/jdk11u-dev/pull/945/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=945&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210112 Stats: 2571 lines in 184 files changed: 335 ins; 1687 del; 549 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/945.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/945/head:pull/945 PR: https://git.openjdk.java.net/jdk11u-dev/pull/945 From mbaesken at openjdk.java.net Fri Mar 25 08:12:52 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Fri, 25 Mar 2022 08:12:52 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v2] In-Reply-To: <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> Message-ID: On Tue, 22 Mar 2022 09:46:03 GMT, Aleksei Voitylov wrote: >> JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. >> >> Original changeset does not apply cleanly because of: >> >> 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, >> 8215445: Enable building for Windows in WSL >> 8257913: Add more known library locations to simplify Linux cross-compilation >> 8244592: Start supporting SOURCE_DATE_EPOCH >> 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes >> >> Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. >> >> [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html > > Aleksei Voitylov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > JDK-8247589 backport to 11u Hi, we noticed a small issue in [test/jdk/tools/launcher/Test7029048.java](https://github.com/openjdk/jdk11u-dev/pull/910/files#diff-a2a1433f01e8291062945a7383286214ee41a0e8deecab03bd37bc0bebe3da14) . test/jdk/tools/launcher/Test7029048.java now has private static void printSkipMessage(String description) twice , this leads to the error test/jdk/tools/launcher/Test7029048.java:215: error: method printSkipMessage(String) is already defined in class Test7029048 private static void printSkipMessage(String description) { ^ ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From jdowland at openjdk.java.net Fri Mar 25 10:07:16 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 25 Mar 2022 10:07:16 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot [v3] In-Reply-To: References: Message-ID: > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Integration blocker >  ?? Dependency #865 must be integrated first > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \ > `$ git checkout pull/881` > > Update a local copy of the PR: \ > `$ git checkout pull/881` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 881` > > View PR using the GUI difftool: \ > `$ git pr show -t 881` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/881.diff > >
Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot Return NULL subsystem if no cgroup controllers are mounted. Reviewed-by: bobv, mbaesken ------------- Changes: https://git.openjdk.java.net/jdk11u-dev/pull/881/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=881&range=02 Stats: 695 lines in 6 files changed: 526 ins; 96 del; 73 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/881.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881 PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From rkennke at openjdk.java.net Fri Mar 25 10:12:58 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Fri, 25 Mar 2022 10:12:58 GMT Subject: [jdk17u-dev] Integrated: 8277072: ObjectStreamClass caches keep ClassLoaders alive In-Reply-To: References: Message-ID: On Wed, 9 Mar 2022 14:02:30 GMT, Roman Kennke wrote: > Hi all, > > This pull request contains a backport of commit [8eb453ba](https://github.com/openjdk/jdk/commit/8eb453baebe377697286f7eb32280ca9f1fd7775) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > > The commit being backported was authored by Roman Kennke on 10 Dec 2021 and was reviewed by Roger Riggs and Peter Levart. > > It fixes a memory leak in ObjectStreamClass under certain conditions. See bug for details. > > Thanks! This pull request has now been integrated. Changeset: 7d132f5e Author: Roman Kennke URL: https://git.openjdk.java.net/jdk17u-dev/commit/7d132f5e5e2f8d27db82dd29bfdbc24677733b65 Stats: 496 lines in 4 files changed: 284 ins; 186 del; 26 mod 8277072: ObjectStreamClass caches keep ClassLoaders alive Backport-of: 8eb453baebe377697286f7eb32280ca9f1fd7775 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/210 From rkennke at openjdk.java.net Fri Mar 25 10:15:28 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Fri, 25 Mar 2022 10:15:28 GMT Subject: [jdk17u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache [v3] In-Reply-To: References: Message-ID: > This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [x] tier2 > - [ ] tier3 Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into backport-8278065 - Add missing tests - Backport cebaad1c94c301304fd146526cac95bfeaac66bf - Backport 8eb453baebe377697286f7eb32280ca9f1fd7775 ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/245/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/245/files/843d5dae..e8b0c8b3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=245&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=245&range=01-02 Stats: 7811 lines in 207 files changed: 5347 ins; 1542 del; 922 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/245.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/245/head:pull/245 PR: https://git.openjdk.java.net/jdk17u-dev/pull/245 From duke at openjdk.java.net Fri Mar 25 10:15:29 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Fri, 25 Mar 2022 10:15:29 GMT Subject: [jdk17u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache [v2] In-Reply-To: References: Message-ID: <49WRUJSCgb_aS4beoeuclxDB_5Oo3NoCu-morUtU7rI=.af4afebb-b5cf-47a8-9549-3caa2c1904a9@github.com> On Mon, 14 Mar 2022 11:02:43 GMT, Roman Kennke wrote: >> This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. >> The original change has baked for several weeks in jdk19 and applies cleanly. >> >> Testing: >> - [x] tier1 >> - [x] tier2 >> - [ ] tier3 > > Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: > > Add missing tests The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout rkennke-backport-8eb453ba git fetch https://git.openjdk.java.net/jdk17u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/245 From rkennke at openjdk.java.net Fri Mar 25 10:15:56 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Fri, 25 Mar 2022 10:15:56 GMT Subject: [jdk17u-dev] RFR: 8278065: Refactor subclassAudits to use ClassValue [v2] In-Reply-To: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> References: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> Message-ID: > This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies with some fuzz, but no conflicts. > > Testing: > - [x] tier1 > - [x] tier2 > - [x] tier3 Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/260/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/260/files/dd73238a..dd73238a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=260&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=260&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/260.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/260/head:pull/260 PR: https://git.openjdk.java.net/jdk17u-dev/pull/260 From duke at openjdk.java.net Fri Mar 25 10:15:56 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Fri, 25 Mar 2022 10:15:56 GMT Subject: [jdk17u-dev] RFR: 8278065: Refactor subclassAudits to use ClassValue In-Reply-To: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> References: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> Message-ID: On Wed, 16 Mar 2022 14:20:31 GMT, Roman Kennke wrote: > This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies with some fuzz, but no conflicts. > > Testing: > - [x] tier1 > - [x] tier2 > - [x] tier3 The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout rkennke-backport-8eb453ba git fetch https://git.openjdk.java.net/jdk17u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/260 From jdowland at openjdk.java.net Fri Mar 25 10:20:55 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 25 Mar 2022 10:20:55 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot [v3] In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 10:07:16 GMT, Jonathan Dowland wrote: >> This is a backport of 8239785 for jdk11u. It depends upon >> pr/865: 8253714 (hopefully the bots will figure this out automatically) >> >> It's not clean, but the only conflict was the copyright line in the >> comment header for src/hotspot/share/prims/whitebox.hpp. >> >> I tried these tests, and they pass: >> >> test/hotspot/jtreg/applications/ctw/modules/java_compiler.java >> test/hotspot/jtreg/compiler/c2/Test8004741.java >> test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java >> >> Awaiting tier tests via GA. >> >> --------- >> ### Progress >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an issue >> - [ ] Change must be properly reviewed >> >> ### Integration blocker >>  ?? Dependency #865 must be integrated first >> >> >> >> ### Reviewing >>
Using git >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \ >> `$ git checkout pull/881` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/881` \ >> `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head` >> >>
>>
Using Skara CLI tools >> >> Checkout this PR locally: \ >> `$ git pr checkout 881` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 881` >> >>
>>
Using diff file >> >> Download this PR as a diff file: \ >> https://git.openjdk.java.net/jdk11u-dev/pull/881.diff >> >>
> > Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8239785: Cgroups: Incorrect detection logic on old systems in hotspot > > Return NULL subsystem if no cgroup controllers are mounted. > > Reviewed-by: bobv, mbaesken Closing since the bug is still marked dependendent on an abandoned PR. Replacement PR is #946. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From jdowland at openjdk.java.net Fri Mar 25 10:20:55 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 25 Mar 2022 10:20:55 GMT Subject: [jdk11u-dev] Withdrawn: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 11 Mar 2022 11:04:45 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. It depends upon > pr/865: 8253714 (hopefully the bots will figure this out automatically) > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I tried these tests, and they pass: > > test/hotspot/jtreg/applications/ctw/modules/java_compiler.java > test/hotspot/jtreg/compiler/c2/Test8004741.java > test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java > > Awaiting tier tests via GA. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Integration blocker >  ?? Dependency #865 must be integrated first > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \ > `$ git checkout pull/881` > > Update a local copy of the PR: \ > `$ git checkout pull/881` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 881` > > View PR using the GUI difftool: \ > `$ git pr show -t 881` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/881.diff > >
This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/881 From rreddy at openjdk.java.net Fri Mar 25 10:26:34 2022 From: rreddy at openjdk.java.net (Ravi Reddy) Date: Fri, 25 Mar 2022 10:26:34 GMT Subject: [jdk18u] RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() Message-ID: Clean backport of https://github.com/openjdk/jdk/commit/ff0b0927a2df8b36f8fd6ed41bd4e20e71a5b653 to jdk18u. ------------- Commit messages: - 8278794: Infinite loop in DeflaterOutputStream.finish() Changes: https://git.openjdk.java.net/jdk18u/pull/53/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=53&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278794 Stats: 378 lines in 5 files changed: 224 ins; 147 del; 7 mod Patch: https://git.openjdk.java.net/jdk18u/pull/53.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/53/head:pull/53 PR: https://git.openjdk.java.net/jdk18u/pull/53 From clanger at openjdk.java.net Fri Mar 25 10:30:20 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 25 Mar 2022 10:30:20 GMT Subject: [jdk11u-dev] RFR: 8276657: XSLT compiler tries to define a class with empty name Message-ID: <9z5v7X6wvK439s7NOYmKKMHXSJAMbYrgOAZAAub1uZM=.93b6e0b0-5fcf-4ffd-81b3-920a3aaf58ea@github.com> Backport of JDK-8276657 as per request of Cheng Jin http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-March/012660.html ------------- Commit messages: - Backport 3c6aecd395e2dd6829815dcaa9d0e17d252131ed Changes: https://git.openjdk.java.net/jdk11u-dev/pull/947/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=947&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276657 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/947.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/947/head:pull/947 PR: https://git.openjdk.java.net/jdk11u-dev/pull/947 From clanger at openjdk.java.net Fri Mar 25 10:30:21 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 25 Mar 2022 10:30:21 GMT Subject: [jdk11u-dev] RFR: 8276657: XSLT compiler tries to define a class with empty name In-Reply-To: <9z5v7X6wvK439s7NOYmKKMHXSJAMbYrgOAZAAub1uZM=.93b6e0b0-5fcf-4ffd-81b3-920a3aaf58ea@github.com> References: <9z5v7X6wvK439s7NOYmKKMHXSJAMbYrgOAZAAub1uZM=.93b6e0b0-5fcf-4ffd-81b3-920a3aaf58ea@github.com> Message-ID: On Fri, 25 Mar 2022 10:19:18 GMT, Christoph Langer wrote: > Backport of JDK-8276657 as per request of Cheng Jin > http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-March/012660.html Backport is clean, I only had to resolve the @LastModified tag. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/947 From jdowland at openjdk.java.net Fri Mar 25 10:45:28 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 25 Mar 2022 10:45:28 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot Message-ID: This is a backport of 8239785 for jdk11u. The dependent backports have now all been integrated. This PR replaces #881 which was stuck with a dependency on a superseded dependent PR. It's not clean, but the only conflict was the copyright line in the comment header for src/hotspot/share/prims/whitebox.hpp. I'm checking jtreg tests in test/hotspot/jtreg/containers on a mixture of cgroup v1 and v2 systems now. --------- ### Progress - [x] Change must not contain extraneous whitespace - [x] Commit message must refer to an issue - [ ] Change must be properly reviewed ### Error  ?? The pull request body must not be empty. ### Reviewing
Using git Checkout this PR locally: \ `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/946/head:pull/946` \ `$ git checkout pull/946` Update a local copy of the PR: \ `$ git checkout pull/946` \ `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/946/head`
Using Skara CLI tools Checkout this PR locally: \ `$ git pr checkout 946` View PR using the GUI difftool: \ `$ git pr show -t 946`
Using diff file Download this PR as a diff file: \ https://git.openjdk.java.net/jdk11u-dev/pull/946.diff
------------- Commit messages: - 8239785: Cgroups: Incorrect detection logic on old systems in hotspot Changes: https://git.openjdk.java.net/jdk11u-dev/pull/946/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=946&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8239785 Stats: 695 lines in 6 files changed: 526 ins; 96 del; 73 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/946.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/946/head:pull/946 PR: https://git.openjdk.java.net/jdk11u-dev/pull/946 From tschatzl at openjdk.java.net Fri Mar 25 10:50:35 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Fri, 25 Mar 2022 10:50:35 GMT Subject: [jdk18u] RFR: 8283555: G1: Concurrent mark accesses uninitialized BOT of closed archive regions Message-ID: <6PIxT0KaQ1u2H7I54YPzWHSR1TQE_ra5GcrFdb8FimA=.ff25a8df-88e0-4ee7-854d-0b2dea90e2b2@github.com> Please review this backport of [JDK-8283555](https://bugs.openjdk.java.net/browse/JDK-8283555) G1: Concurrent mark accesses uninitialized BOT of closed archive regions which removes a potential crash. Applies cleanly. Testing: gha, jdk19 ci Thanks, Thomas ------------- Commit messages: - 8283555: G1: Concurrent mark accesses uninitialized BOT of closed archive regions Changes: https://git.openjdk.java.net/jdk18u/pull/54/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=54&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283555 Stats: 10 lines in 1 file changed: 5 ins; 5 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/54.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/54/head:pull/54 PR: https://git.openjdk.java.net/jdk18u/pull/54 From mdoerr at openjdk.java.net Fri Mar 25 10:58:03 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 25 Mar 2022 10:58:03 GMT Subject: [jdk17u-dev] RFR: 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15 In-Reply-To: References: Message-ID: <8IyM81sTFjy-q-iXaNaSleuBfb4WJhsL9h5MQudMzgE=.0631e141-f8b3-45c1-ad20-037f64ce046e@github.com> On Thu, 24 Mar 2022 13:27:35 GMT, Matthias Baesken wrote: > backport of 8278549 It's clean except Copyright year update. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk17u-dev/pull/283 From sgehwolf at openjdk.java.net Fri Mar 25 11:01:42 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 25 Mar 2022 11:01:42 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 10:17:45 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. The dependent backports have now all been integrated. > > This PR replaces #881 which was stuck with a dependency on a superseded dependent PR. > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I'm checking jtreg tests in test/hotspot/jtreg/containers on a mixture of cgroup v1 and v2 systems now. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Error >  ?? The pull request body must not be empty. > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/946/head:pull/946` \ > `$ git checkout pull/946` > > Update a local copy of the PR: \ > `$ git checkout pull/946` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/946/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 946` > > View PR using the GUI difftool: \ > `$ git pr show -t 946` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/946.diff > >
[src/hotspot/share/prims/whitebox.hpp](https://github.com/openjdk/jdk11u-dev/pull/946/files#diff-0616ebadb392e16dc81358b7c8e2cdf30e171b91402bedee9aeeb0a4f57c25cc) Doesn't have the Copyright update unlike the original patch. Please add. `WhiteBox.java` on the other hand didn't have the copyright bumped in the original patch, so neither should we here. Other than that. Looks fine. test/lib/sun/hotspot/WhiteBox.java line 2: > 1: /* > 2: * Copyright (c) 2012, 2020, Oracle and/or its affiliates. All rights reserved. This change isn't in the original patch. Please remove. ------------- Changes requested by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/946 From jdowland at openjdk.java.net Fri Mar 25 11:01:42 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 25 Mar 2022 11:01:42 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 10:55:05 GMT, Severin Gehwolf wrote: >> This is a backport of 8239785 for jdk11u. The dependent backports have now all been integrated. >> >> This PR replaces #881 which was stuck with a dependency on a superseded dependent PR. >> >> It's not clean, but the only conflict was the copyright line in the >> comment header for src/hotspot/share/prims/whitebox.hpp. >> >> I'm checking jtreg tests in test/hotspot/jtreg/containers on a mixture of cgroup v1 and v2 systems now. >> >> --------- >> ### Progress >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an issue >> - [ ] Change must be properly reviewed >> >> ### Error >>  ?? The pull request body must not be empty. >> >> >> >> ### Reviewing >>
Using git >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/946/head:pull/946` \ >> `$ git checkout pull/946` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/946` \ >> `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/946/head` >> >>
>>
Using Skara CLI tools >> >> Checkout this PR locally: \ >> `$ git pr checkout 946` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 946` >> >>
>>
Using diff file >> >> Download this PR as a diff file: \ >> https://git.openjdk.java.net/jdk11u-dev/pull/946.diff >> >>
> > test/lib/sun/hotspot/WhiteBox.java line 2: > >> 1: /* >> 2: * Copyright (c) 2012, 2020, Oracle and/or its affiliates. All rights reserved. > > This change isn't in the original patch. Please remove. Odd sorry, I picked the wrong whitebox file! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/946 From sgehwolf at openjdk.java.net Fri Mar 25 11:08:41 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 25 Mar 2022 11:08:41 GMT Subject: [jdk11u-dev] RFR: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java In-Reply-To: <5IGulVBJuZ6rTX5uUghz1AD504saxrCIp2JYqM2B-fc=.8e887647-ffdc-42dd-a3db-42c446a151d2@github.com> References: <5IGulVBJuZ6rTX5uUghz1AD504saxrCIp2JYqM2B-fc=.8e887647-ffdc-42dd-a3db-42c446a151d2@github.com> Message-ID: On Mon, 21 Mar 2022 20:18:41 GMT, Elliott Baron wrote: >> Looks fine. Once you integrate could you please mention on the backport bug that the hunk from `TestMemoryAwareness.java` got already backported with JDK-8250984? Thanks! > >> Looks fine. Once you integrate could you please mention on the backport bug that the hunk from `TestMemoryAwareness.java` got already backported with JDK-8250984? Thanks! > > Will do, thanks for the review! @ebaron This should be ready to integrate now. Please let me know if you need help with it. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/920 From jdowland at openjdk.java.net Fri Mar 25 11:09:26 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 25 Mar 2022 11:09:26 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot [v2] In-Reply-To: References: Message-ID: > This is a backport of 8239785 for jdk11u. The dependent backports have now all been integrated. > > This PR replaces #881 which was stuck with a dependency on a superseded dependent PR. > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I'm checking jtreg tests in test/hotspot/jtreg/containers on a mixture of cgroup v1 and v2 systems now. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Error >  ?? The pull request body must not be empty. > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/946/head:pull/946` \ > `$ git checkout pull/946` > > Update a local copy of the PR: \ > `$ git checkout pull/946` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/946/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 946` > > View PR using the GUI difftool: \ > `$ git pr show -t 946` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/946.diff > >
Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot Return NULL subsystem if no cgroup controllers are mounted. Reviewed-by: bobv, mbaesken ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/946/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/946/files/2c52a81a..c91adaab Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=946&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=946&range=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/946.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/946/head:pull/946 PR: https://git.openjdk.java.net/jdk11u-dev/pull/946 From jdowland at openjdk.java.net Fri Mar 25 11:09:27 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 25 Mar 2022 11:09:27 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 10:17:45 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. The dependent backports have now all been integrated. > > This PR replaces #881 which was stuck with a dependency on a superseded dependent PR. > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I'm checking jtreg tests in test/hotspot/jtreg/containers on a mixture of cgroup v1 and v2 systems now. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Error >  ?? The pull request body must not be empty. > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/946/head:pull/946` \ > `$ git checkout pull/946` > > Update a local copy of the PR: \ > `$ git checkout pull/946` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/946/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 946` > > View PR using the GUI difftool: \ > `$ git pr show -t 946` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/946.diff > >
Testing notes: On a cgroups v2 system with glibc 2.33, specifying `-Djdk.test.docker.image.version=hirsute` (the version of ubuntu with a matching libc version), 8 tests pass; 1 fails - containers/cgroup/PlainRead.java - which is expected (to be fixed in backport of [JDK-8278951](https://bugs.openjdk.java.net/browse/JDK-8278951)) Running tests on a cgroups v1 system now. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/946 From mdoerr at openjdk.java.net Fri Mar 25 11:29:08 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 25 Mar 2022 11:29:08 GMT Subject: [jdk17u-dev] RFR: 8278065: Refactor subclassAudits to use ClassValue [v2] In-Reply-To: References: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> Message-ID: On Fri, 25 Mar 2022 10:15:56 GMT, Roman Kennke wrote: >> This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. >> The original change has baked for several weeks in jdk19 and applies with some fuzz, but no conflicts. >> >> Testing: >> - [x] tier1 >> - [x] tier2 >> - [x] tier3 > > Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Unfortunately, following the instructions suggested by Skara messes up the PR. The diff contains both backports and the clean label is lost. I had the same problems when trying it. (What works is rebase and force-push which is not particularly nice, either.) I don't know what would happen when integrating it this way. Is the best way in this situation to just throw it away and redo it? ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/260 From rkennke at openjdk.java.net Fri Mar 25 11:47:08 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Fri, 25 Mar 2022 11:47:08 GMT Subject: [jdk17u-dev] Integrated: 8280041: Retry loop issues in java.io.ClassCache In-Reply-To: References: Message-ID: On Mon, 14 Mar 2022 10:46:25 GMT, Roman Kennke wrote: > This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies cleanly. > > Testing: > - [x] tier1 > - [x] tier2 > - [ ] tier3 This pull request has now been integrated. Changeset: 99237145 Author: Roman Kennke URL: https://git.openjdk.java.net/jdk17u-dev/commit/99237145b104abbc04e94e931f51db0003274fec Stats: 202 lines in 5 files changed: 190 ins; 0 del; 12 mod 8280041: Retry loop issues in java.io.ClassCache Backport-of: cebaad1c94c301304fd146526cac95bfeaac66bf ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/245 From mdoerr at openjdk.java.net Fri Mar 25 11:47:33 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 25 Mar 2022 11:47:33 GMT Subject: [jdk17u-dev] RFR: 8281771: Crash in java_lang_invoke_MethodType::print_signature Message-ID: Clean backport of [JDK-8281771](https://bugs.openjdk.java.net/browse/JDK-8281771) ------------- Commit messages: - Backport a24498b777b76c04d7e6da0a8b5fb501f2fb4944 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/284/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=284&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281771 Stats: 13 lines in 1 file changed: 9 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/284.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/284/head:pull/284 PR: https://git.openjdk.java.net/jdk17u-dev/pull/284 From rkennke at openjdk.java.net Fri Mar 25 11:49:41 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Fri, 25 Mar 2022 11:49:41 GMT Subject: [jdk17u-dev] RFR: 8278065: Refactor subclassAudits to use ClassValue [v3] In-Reply-To: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> References: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> Message-ID: > This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies with some fuzz, but no conflicts. > > Testing: > - [x] tier1 > - [x] tier2 > - [x] tier3 Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into backport-JDK-8278065 - Backport 8fed8ab29cae4f189f44609c23f116967eef6bdf - Backport 8eb453baebe377697286f7eb32280ca9f1fd7775 ------------- Changes: - all: https://git.openjdk.java.net/jdk17u-dev/pull/260/files - new: https://git.openjdk.java.net/jdk17u-dev/pull/260/files/dd73238a..8f51482c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=260&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=260&range=01-02 Stats: 8013 lines in 212 files changed: 5537 ins; 1542 del; 934 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/260.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/260/head:pull/260 PR: https://git.openjdk.java.net/jdk17u-dev/pull/260 From rkennke at openjdk.java.net Fri Mar 25 11:49:42 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Fri, 25 Mar 2022 11:49:42 GMT Subject: [jdk17u-dev] RFR: 8278065: Refactor subclassAudits to use ClassValue [v2] In-Reply-To: References: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> Message-ID: On Fri, 25 Mar 2022 11:25:44 GMT, Martin Doerr wrote: > Unfortunately, following the instructions suggested by Skara messes up the PR. The diff contains both backports and the clean label is lost. I had the same problems when trying it. (What works is rebase and force-push which is not particularly nice, either.) I don't know what would happen when integrating it this way. Is the best way in this situation to just throw it away and redo it? As far as I know, the recommended way is to manually merge from upstream/master, push it to the PR branch, wait until it is flagged with clean label again, and then go. That's what I would do, unless you object to this plan. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/260 From mdoerr at openjdk.java.net Fri Mar 25 11:56:57 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 25 Mar 2022 11:56:57 GMT Subject: [jdk17u-dev] RFR: 8278065: Refactor subclassAudits to use ClassValue [v3] In-Reply-To: References: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> Message-ID: On Fri, 25 Mar 2022 11:49:41 GMT, Roman Kennke wrote: >> This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. >> The original change has baked for several weeks in jdk19 and applies with some fuzz, but no conflicts. >> >> Testing: >> - [x] tier1 >> - [x] tier2 >> - [x] tier3 > > Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into backport-JDK-8278065 > - Backport 8fed8ab29cae4f189f44609c23f116967eef6bdf > - Backport 8eb453baebe377697286f7eb32280ca9f1fd7775 Oh, ok. That's fine. Thanks for the hint. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/260 From mdoerr at openjdk.java.net Fri Mar 25 12:07:11 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 25 Mar 2022 12:07:11 GMT Subject: [jdk17u-dev] RFR: 8270797: ShortECDSA.java test is not complete Message-ID: <4YegCjbGO1iz6DH9NwrO3-5wKypt49ZRL5mdyAPXQS8=.985e59f1-3cb7-436f-9d38-ed03f78a509b@github.com> Clean backport of [JDK-8270797](https://bugs.openjdk.java.net/browse/JDK-8270797) ------------- Commit messages: - Backport 221e4b9c61cd1c9c3f4c037589ba639541532910 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/285/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=285&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270797 Stats: 16 lines in 1 file changed: 15 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/285.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/285/head:pull/285 PR: https://git.openjdk.java.net/jdk17u-dev/pull/285 From mdoerr at openjdk.java.net Fri Mar 25 12:22:55 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Fri, 25 Mar 2022 12:22:55 GMT Subject: [jdk11u-dev] RFR: 8210112: remove jdk.testlibrary.ProcessTools In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 07:12:36 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > I had to adapt the change in several means. This is a list > of the changes to resolve failed hunks: > > Already fixed: > patching file test/jdk/com/sun/jdi/ExclusiveBind.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/java/lang/ClassLoader/getResource/automaticmodules/Driver.java > patching file test/jdk/java/lang/ClassLoader/securityManager/ClassLoaderTest.java > patching file test/jdk/java/lang/instrument/executableJAR/ExecJarWithAgent.java > patching file test/jdk/java/rmi/module/ModuleTest.java > > Context > patching file test/jdk/java/lang/System/OsVersionTest.java > patching file test/jdk/java/security/Policy/SignedJar/SignedJarTest.java > patching file test/jdk/java/util/Arrays/TimSortStackSize2.java > > Copyright > patching file test/jdk/javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/jdk/modules/scenarios/automaticmodules/RunWithAutomaticModules.java > patching file test/jdk/sun/security/tools/jarsigner/TsacertOptionTest.java > > Copyright > patching file test/jdk/sun/security/tools/jarsigner/Warning.java > patching file test/jdk/sun/security/tools/jarsigner/warnings/BadKeyUsageTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/sun/security/tools/jarsigner/warnings/NoTimestampTest.java > > File not in 11: --- probably goes away > test/jdk/sun/tools/jcmd/JcmdBase.java b/test/jdk/sun/tools/jcmd/JcmdBase.java > patching file test/jdk/sun/tools/jcmd/TestJcmdDefaults.java > patching file test/jdk/sun/tools/jcmd/TestJcmdSanity.java > > Copyright > patching file test/jdk/sun/tools/jmap/BasicJMapTest.java > > Resolved > patching file test/jdk/sun/tools/jstatd/JstatdTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/tools/jlink/basic/BasicTest.java > patching file test/jdk/tools/launcher/modules/addexports/manifest/AddExportsAndOpensInManifest.java > patching file test/jdk/tools/launcher/modules/addreads/AddReadsTest.java > patching file test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java > patching file test/jdk/tools/launcher/modules/patch/basic/PatchTest.java > patching file test/jdk/tools/launcher/modules/patch/basic/PatchTestWarningError.java > patching file test/jdk/tools/launcher/modules/validate/ValidateModulesTest.java > > On top of this, I had to adapt a few tests to work after removal of > the old testlibrary file. > > Last, I had to move the `change` of "8217375: jarsigner breaks old signature with long lines in manifest" > to OutputAnalyzer.java from the old file to the new one. > > Now all test are passing. Thanks for the detailed description. However, it's still not easy to review. Can you be more specific regarding "I had to adapt a few tests to work after removal of the old testlibrary file.", please? (It sometimes helps reviewers to use individual commits when several steps were done. Just as an idea for future backports.) ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/945 From rkennke at openjdk.java.net Fri Mar 25 12:54:00 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Fri, 25 Mar 2022 12:54:00 GMT Subject: [jdk17u-dev] Integrated: 8278065: Refactor subclassAudits to use ClassValue In-Reply-To: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> References: <1bsnfZ-Gy4yI1jLVtM0h4h7bctp79nkXknuuTXWwd7k=.4919fa0b-8143-4d81-acff-e8d114c79414@github.com> Message-ID: On Wed, 16 Mar 2022 14:20:31 GMT, Roman Kennke wrote: > This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies with some fuzz, but no conflicts. > > Testing: > - [x] tier1 > - [x] tier2 > - [x] tier3 This pull request has now been integrated. Changeset: 8d7f26b7 Author: Roman Kennke URL: https://git.openjdk.java.net/jdk17u-dev/commit/8d7f26b7ad4d1cf5750ac807b4f935fa63d3b047 Stats: 105 lines in 3 files changed: 2 ins; 89 del; 14 mod 8278065: Refactor subclassAudits to use ClassValue Backport-of: 8fed8ab29cae4f189f44609c23f116967eef6bdf ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/260 From sgehwolf at openjdk.java.net Fri Mar 25 13:26:46 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 25 Mar 2022 13:26:46 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot [v2] In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 11:09:26 GMT, Jonathan Dowland wrote: >> This is a backport of 8239785 for jdk11u. The dependent backports have now all been integrated. >> >> This PR replaces #881 which was stuck with a dependency on a superseded dependent PR. >> >> It's not clean, but the only conflict was the copyright line in the >> comment header for src/hotspot/share/prims/whitebox.hpp. >> >> I'm checking jtreg tests in test/hotspot/jtreg/containers on a mixture of cgroup v1 and v2 systems now. >> >> --------- >> ### Progress >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an issue >> - [ ] Change must be properly reviewed >> >> ### Error >>  ?? The pull request body must not be empty. >> >> >> >> ### Reviewing >>
Using git >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/946/head:pull/946` \ >> `$ git checkout pull/946` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/946` \ >> `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/946/head` >> >>
>>
Using Skara CLI tools >> >> Checkout this PR locally: \ >> `$ git pr checkout 946` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 946` >> >>
>>
Using diff file >> >> Download this PR as a diff file: \ >> https://git.openjdk.java.net/jdk11u-dev/pull/946.diff >> >>
> > Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8239785: Cgroups: Incorrect detection logic on old systems in hotspot > > Return NULL subsystem if no cgroup controllers are mounted. > > Reviewed-by: bobv, mbaesken Marked as reviewed by sgehwolf (Reviewer). I'm marking this one clean as the only change is the copyright line in `whitebox.hpp` which has been fixed manually. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/946 From sgehwolf at openjdk.java.net Fri Mar 25 13:26:47 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 25 Mar 2022 13:26:47 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 11:05:06 GMT, Jonathan Dowland wrote: >> This is a backport of 8239785 for jdk11u. The dependent backports have now all been integrated. >> >> This PR replaces #881 which was stuck with a dependency on a superseded dependent PR. >> >> It's not clean, but the only conflict was the copyright line in the >> comment header for src/hotspot/share/prims/whitebox.hpp. >> >> I'm checking jtreg tests in test/hotspot/jtreg/containers on a mixture of cgroup v1 and v2 systems now. >> >> --------- >> ### Progress >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an issue >> - [ ] Change must be properly reviewed >> >> ### Error >>  ?? The pull request body must not be empty. >> >> >> >> ### Reviewing >>
Using git >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/946/head:pull/946` \ >> `$ git checkout pull/946` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/946` \ >> `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/946/head` >> >>
>>
Using Skara CLI tools >> >> Checkout this PR locally: \ >> `$ git pr checkout 946` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 946` >> >>
>>
Using diff file >> >> Download this PR as a diff file: \ >> https://git.openjdk.java.net/jdk11u-dev/pull/946.diff >> >>
> > Testing notes: > > On a cgroups v2 system with glibc 2.33, specifying `-Djdk.test.docker.image.version=hirsute` (the version of ubuntu with a matching libc version), 8 tests pass; 1 fails - containers/cgroup/PlainRead.java - which is expected (to be fixed in backport of [JDK-8278951](https://bugs.openjdk.java.net/browse/JDK-8278951)) > > Running tests on a cgroups v1 system now. @jmtd Please request for backport approval on the bug. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/946 From jdowland at openjdk.java.net Fri Mar 25 13:33:40 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Fri, 25 Mar 2022 13:33:40 GMT Subject: [jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot [v2] In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 11:09:26 GMT, Jonathan Dowland wrote: >> This is a backport of 8239785 for jdk11u. The dependent backports have now all been integrated. >> >> This PR replaces #881 which was stuck with a dependency on a superseded dependent PR. >> >> It's not clean, but the only conflict was the copyright line in the >> comment header for src/hotspot/share/prims/whitebox.hpp. >> >> I'm checking jtreg tests in test/hotspot/jtreg/containers on a mixture of cgroup v1 and v2 systems now. >> >> --------- >> ### Progress >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an issue >> - [ ] Change must be properly reviewed >> >> ### Error >>  ?? The pull request body must not be empty. >> >> >> >> ### Reviewing >>
Using git >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/946/head:pull/946` \ >> `$ git checkout pull/946` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/946` \ >> `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/946/head` >> >>
>>
Using Skara CLI tools >> >> Checkout this PR locally: \ >> `$ git pr checkout 946` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 946` >> >>
>>
Using diff file >> >> Download this PR as a diff file: \ >> https://git.openjdk.java.net/jdk11u-dev/pull/946.diff >> >>
> > Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8239785: Cgroups: Incorrect detection logic on old systems in hotspot > > Return NULL subsystem if no cgroup controllers are mounted. > > Reviewed-by: bobv, mbaesken All 9 tests pass on my cgroups v1/hybrid system. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/946 From sgehwolf at openjdk.java.net Fri Mar 25 17:11:14 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 25 Mar 2022 17:11:14 GMT Subject: [jdk11u-dev] RFR: 8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes Message-ID: Clean backport removing an unimplemented left-over after the cgroups v2 support patches. ------------- Commit messages: - Backport 5b51085c986fed342a9bc03f3641283707a89a4e Changes: https://git.openjdk.java.net/jdk11u-dev/pull/948/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=948&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254997 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/948.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/948/head:pull/948 PR: https://git.openjdk.java.net/jdk11u-dev/pull/948 From sgehwolf at openjdk.java.net Fri Mar 25 17:15:32 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 25 Mar 2022 17:15:32 GMT Subject: [jdk11u-dev] RFR: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota Message-ID: Comment only change so that correct units are documented. Makes sense now since we've carried it over via the cgroups v2 backport. Low risk, comment only. ------------- Commit messages: - Backport 5166094647f8bfae32ef4bbde2e40f68e073b595 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/949/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=949&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252957 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/949.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/949/head:pull/949 PR: https://git.openjdk.java.net/jdk11u-dev/pull/949 From sgehwolf at openjdk.java.net Fri Mar 25 17:34:16 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Fri, 25 Mar 2022 17:34:16 GMT Subject: [jdk11u-dev] RFR: 8266391: Replace use of reflection in jdk.internal.platform.Metrics Message-ID: The cgroups metrics is a Linux-only feature. Instead of using reflection and returning `null` on CNFE platform specific classes can be used instead. This is a no-op from a functionality perspective and avoids reflection, which is a good thing. ------------- Commit messages: - Backport 3544a9d0e4a071ad9c82aa17ab113e0101b4020b Changes: https://git.openjdk.java.net/jdk11u-dev/pull/950/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=950&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266391 Stats: 103 lines in 4 files changed: 93 ins; 8 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/950.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/950/head:pull/950 PR: https://git.openjdk.java.net/jdk11u-dev/pull/950 From goetz at openjdk.java.net Sun Mar 27 20:04:58 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Sun, 27 Mar 2022 20:04:58 GMT Subject: [jdk11u-dev] RFR: 8210112: remove jdk.testlibrary.ProcessTools In-Reply-To: References: Message-ID: <86S55JIa3z7JCXY6l0gRcgVDfDsZ37O9QBm4VQRZTWU=.bcdf2f1c-07eb-4173-8ebd-4471f4cec7cf@github.com> On Fri, 25 Mar 2022 07:12:36 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > I had to adapt the change in several means. This is a list > of the changes to resolve failed hunks: > > Already fixed: > patching file test/jdk/com/sun/jdi/ExclusiveBind.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/java/lang/ClassLoader/getResource/automaticmodules/Driver.java > patching file test/jdk/java/lang/ClassLoader/securityManager/ClassLoaderTest.java > patching file test/jdk/java/lang/instrument/executableJAR/ExecJarWithAgent.java > patching file test/jdk/java/rmi/module/ModuleTest.java > > Context > patching file test/jdk/java/lang/System/OsVersionTest.java > patching file test/jdk/java/security/Policy/SignedJar/SignedJarTest.java > patching file test/jdk/java/util/Arrays/TimSortStackSize2.java > > Copyright > patching file test/jdk/javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/jdk/modules/scenarios/automaticmodules/RunWithAutomaticModules.java > patching file test/jdk/sun/security/tools/jarsigner/TsacertOptionTest.java > > Copyright > patching file test/jdk/sun/security/tools/jarsigner/Warning.java > patching file test/jdk/sun/security/tools/jarsigner/warnings/BadKeyUsageTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/sun/security/tools/jarsigner/warnings/NoTimestampTest.java > > File not in 11: --- probably goes away > test/jdk/sun/tools/jcmd/JcmdBase.java b/test/jdk/sun/tools/jcmd/JcmdBase.java > patching file test/jdk/sun/tools/jcmd/TestJcmdDefaults.java > patching file test/jdk/sun/tools/jcmd/TestJcmdSanity.java > > Copyright > patching file test/jdk/sun/tools/jmap/BasicJMapTest.java > > Resolved > patching file test/jdk/sun/tools/jstatd/JstatdTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/tools/jlink/basic/BasicTest.java > patching file test/jdk/tools/launcher/modules/addexports/manifest/AddExportsAndOpensInManifest.java > patching file test/jdk/tools/launcher/modules/addreads/AddReadsTest.java > patching file test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java > patching file test/jdk/tools/launcher/modules/patch/basic/PatchTest.java > patching file test/jdk/tools/launcher/modules/patch/basic/PatchTestWarningError.java > patching file test/jdk/tools/launcher/modules/validate/ValidateModulesTest.java > > On top of this, I had to adapt a few tests to work after removal of > the old testlibrary file. > > Last, I had to move the `change` of "8217375: jarsigner breaks old signature with long lines in manifest" > to OutputAnalyzer.java from the old file to the new one. > > Now all test are passing. Hi, thanks for looking at this cumbersome change :). It have basically been these files I had to edit on top of the original change: test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java test/jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java test/jdk/sun/security/tools/jarsigner/warnings/LowerCaseManifest.java Also, I had to edit one of the OutputAnalyzer constructors. It was only added in a later change in head, but already backported to 11. It needs to call OutputBuffer. The differences in the Jcmd tests I mentioned above went away because I backported a prerequisite change. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/945 From goetz at openjdk.java.net Sun Mar 27 20:14:24 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Sun, 27 Mar 2022 20:14:24 GMT Subject: [jdk11u-dev] RFR: 8182404: remove jdk.testlibrary.JDKToolFinder and JDKToolLauncher Message-ID: I want to backport this ot simplify follow-up test backports. I had to resolve JstatdTest.java. Trivial. ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/945 Commit messages: - Backport 8182404 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/951/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=951&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8182404 Stats: 328 lines in 45 files changed: 13 ins; 270 del; 45 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/951.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/951/head:pull/951 PR: https://git.openjdk.java.net/jdk11u-dev/pull/951 From serb at openjdk.java.net Sun Mar 27 22:04:52 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Sun, 27 Mar 2022 22:04:52 GMT Subject: [jdk11u-dev] Integrated: 6986863: ProfileDeferralMgr throwing ConcurrentModificationException In-Reply-To: References: Message-ID: On Sat, 19 Feb 2022 04:20:24 GMT, Sergey Bylokhov wrote: > This is backport of the fix for [JDK-6986863](https://bugs.openjdk.java.net/browse/JDK-6986863), pushed to the [JDK 17](https://github.com/openjdk/jdk/commit/64a150c518ed1a936cd6e4cb5e60060243496901) > > This change prevents intermittent exceptions in the applications and tests caused by the weak synchronization of the color profiles loading, see additional details [here](https://github.com/openjdk/jdk/pull/1613). > > The new tests failed before and work fine after the fix. No new issues were found by the java_desktop tests. > The patch is not clean because the [getStandardProfile() ](https://github.com/openjdk/jdk/commit/64a150c518ed1a936cd6e4cb5e60060243496901#diff-b92a36346bec4c6f7d5e8921bd69b038e0932f116d627bb4f6b514e670e1fccdL923)method removed upstream is still used in the jdk11u-dev. This pull request has now been integrated. Changeset: e6020c34 Author: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk11u-dev/commit/e6020c341c06815e359a19f4467ea4cb371ee438 Stats: 518 lines in 9 files changed: 183 ins; 263 del; 72 mod 6986863: ProfileDeferralMgr throwing ConcurrentModificationException Reviewed-by: phh Backport-of: 64a150c518ed1a936cd6e4cb5e60060243496901 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/834 From serb at openjdk.java.net Sun Mar 27 23:42:46 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Sun, 27 Mar 2022 23:42:46 GMT Subject: [jdk11u-dev] Integrated: 8274751: Drag And Drop hangs on Windows In-Reply-To: <507fneSPOxK0QSU3SM6f7wwnFQDn96TmnuC-Aw7ye1s=.5d1d9770-cf9f-4229-9b3a-a74c3ee049dc@github.com> References: <507fneSPOxK0QSU3SM6f7wwnFQDn96TmnuC-Aw7ye1s=.5d1d9770-cf9f-4229-9b3a-a74c3ee049dc@github.com> Message-ID: On Thu, 24 Mar 2022 01:25:56 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [7a0a6c95](https://github.com/openjdk/jdk/commit/7a0a6c95a53c6cb3340328d6543a97807320b740) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Dmitry Markov on 24 Jan 2022 and was reviewed by Alexey Ivanov, Phil Race and Sergey Bylokhov. > Thanks! This pull request has now been integrated. Changeset: 588bdfa8 Author: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk11u-dev/commit/588bdfa8cfd495ca21a1926f825d4e827bf9b5a7 Stats: 19 lines in 4 files changed: 2 ins; 0 del; 17 mod 8274751: Drag And Drop hangs on Windows Backport-of: 7a0a6c95a53c6cb3340328d6543a97807320b740 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/942 From duke at openjdk.java.net Mon Mar 28 03:07:19 2022 From: duke at openjdk.java.net (Yude Lin) Date: Mon, 28 Mar 2022 03:07:19 GMT Subject: [jdk11u-dev] RFR: 8228609: G1 copy cost prediction uses used vs. actual copied bytes [v4] In-Reply-To: References: Message-ID: > I would like to backport 8228609 which fixes a prediction error regarding cost per bytes copied. > > The patch does not apply cleanly, so this backport is basically changing the calculation of copied bytes. > > https://bugs.openjdk.java.net/browse/JDK-8227442 is not in 11u. So this patch also uses G1ParScanThreadState::surviving_young_words() in place of _surviving_young_words to adjust for the correct cset index. Yude Lin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8228609: G1 copy cost prediction uses used vs. actual copied bytes ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/927/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/927/files/be565894..c30b074f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=927&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=927&range=02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/927.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/927/head:pull/927 PR: https://git.openjdk.java.net/jdk11u-dev/pull/927 From duke at openjdk.java.net Mon Mar 28 05:54:48 2022 From: duke at openjdk.java.net (Yude Lin) Date: Mon, 28 Mar 2022 05:54:48 GMT Subject: [jdk11u-dev] RFR: 8228609: G1 copy cost prediction uses used vs. actual copied bytes [v3] In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 16:30:47 GMT, Goetz Lindenmaier wrote: >> Yude Lin has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. > > @linade > Two more things, please: > * Enable Pre-submit tests > * Only flag the change with jdk11u-fix-request once it is ready. I'll remove the tag for now, pleas add it again if the review is available. @GoeLin I enabled the tests. Some of them seem to be blocked by a gcc dependency issue. Would you take a look? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/927 From goetz at openjdk.java.net Mon Mar 28 06:15:48 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 28 Mar 2022 06:15:48 GMT Subject: [jdk11u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache [v3] In-Reply-To: References: <8a9lCHHdvjKYN7QzfnB1yrLWUarFljBfnDGy3xrcYU8=.89c903ad-446e-4c67-82fe-9fc40f5027b5@github.com> Message-ID: On Mon, 14 Mar 2022 17:09:28 GMT, Roman Kennke wrote: >> This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. >> The original change has baked for several weeks in jdk19. One of the tests needed a small adjustment because the API Reference.refersTo() does not exist in JDK 11. >> >> Testing: >> - [x] tier1 >> - [ ] tier2 >> - [ ] tier3 > > Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: > > Adjust test for missing Reference.refersTo() API @rkennek I remove the fix-request tag. There seems to be no progress on this and I keep checking the three changes for progress over and over. Please add the tag again once the follow-ups are ready to go, especially reviewed. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/887 From mbaesken at openjdk.java.net Mon Mar 28 07:05:02 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Mon, 28 Mar 2022 07:05:02 GMT Subject: [jdk17u-dev] Integrated: 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15 In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 13:27:35 GMT, Matthias Baesken wrote: > backport of 8278549 This pull request has now been integrated. Changeset: 86ac4ab1 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk17u-dev/commit/86ac4ab1d6aa72f75ecaa3d9d842d971e59a9a8b Stats: 34 lines in 2 files changed: 32 ins; 0 del; 2 mod 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15 Reviewed-by: mdoerr Backport-of: 84976b45315feb6c37a9f3db6e1e62812c9b0a37 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/283 From goetz at openjdk.java.net Mon Mar 28 07:07:02 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 28 Mar 2022 07:07:02 GMT Subject: [jdk11u-dev] RFR: 8259517: Incorrect test path in test cases Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 81db63e8d74c0d85cdadb0a70580a33c79d0bb80 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/952/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=952&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259517 Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/952.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/952/head:pull/952 PR: https://git.openjdk.java.net/jdk11u-dev/pull/952 From mbaesken at openjdk.java.net Mon Mar 28 07:19:41 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Mon, 28 Mar 2022 07:19:41 GMT Subject: [jdk11u-dev] Integrated: 8256722: handle VC++:1927 VS2019 in abstract_vm_version In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 11:52:42 GMT, Matthias Baesken wrote: > 8256722: handle VC++:1927 VS2019 in abstract_vm_version This pull request has now been integrated. Changeset: 146fe86f Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/146fe86ff68095b5eb0ce1387061699738280c06 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod 8256722: handle VC++:1927 VS2019 in abstract_vm_version Backport-of: e838d71d6151655980c8a96673f5db65f9168aee ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/944 From mbaesken at openjdk.java.net Mon Mar 28 07:34:59 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Mon, 28 Mar 2022 07:34:59 GMT Subject: [jdk11u-dev] RFR: 8273176: handle latest VS2019 in abstract_vm_version Message-ID: 8273176: handle latest VS2019 in abstract_vm_version ------------- Commit messages: - Backport 0e14bf70cf6e482a2ec7d13ed37df0bee911740d Changes: https://git.openjdk.java.net/jdk11u-dev/pull/953/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=953&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273176 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/953.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/953/head:pull/953 PR: https://git.openjdk.java.net/jdk11u-dev/pull/953 From goetz at openjdk.java.net Mon Mar 28 08:11:44 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 28 Mar 2022 08:11:44 GMT Subject: [jdk11u-dev] RFR: 8210112: remove jdk.testlibrary.ProcessTools In-Reply-To: References: Message-ID: <5UieTPbGJpXbFNDBxniw5DOmQp_nlszH65c_30Auzjg=.e5886100-ef04-43d0-8c6d-028893c161c7@github.com> On Fri, 25 Mar 2022 07:12:36 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > I had to adapt the change in several means. This is a list > of the changes to resolve failed hunks: > > Already fixed: > patching file test/jdk/com/sun/jdi/ExclusiveBind.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/java/lang/ClassLoader/getResource/automaticmodules/Driver.java > patching file test/jdk/java/lang/ClassLoader/securityManager/ClassLoaderTest.java > patching file test/jdk/java/lang/instrument/executableJAR/ExecJarWithAgent.java > patching file test/jdk/java/rmi/module/ModuleTest.java > > Context > patching file test/jdk/java/lang/System/OsVersionTest.java > patching file test/jdk/java/security/Policy/SignedJar/SignedJarTest.java > patching file test/jdk/java/util/Arrays/TimSortStackSize2.java > > Copyright > patching file test/jdk/javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/jdk/modules/scenarios/automaticmodules/RunWithAutomaticModules.java > patching file test/jdk/sun/security/tools/jarsigner/TsacertOptionTest.java > > Copyright > patching file test/jdk/sun/security/tools/jarsigner/Warning.java > patching file test/jdk/sun/security/tools/jarsigner/warnings/BadKeyUsageTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/sun/security/tools/jarsigner/warnings/NoTimestampTest.java > > File not in 11: --- probably goes away > test/jdk/sun/tools/jcmd/JcmdBase.java b/test/jdk/sun/tools/jcmd/JcmdBase.java > patching file test/jdk/sun/tools/jcmd/TestJcmdDefaults.java > patching file test/jdk/sun/tools/jcmd/TestJcmdSanity.java > > Copyright > patching file test/jdk/sun/tools/jmap/BasicJMapTest.java > > Resolved > patching file test/jdk/sun/tools/jstatd/JstatdTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/tools/jlink/basic/BasicTest.java > patching file test/jdk/tools/launcher/modules/addexports/manifest/AddExportsAndOpensInManifest.java > patching file test/jdk/tools/launcher/modules/addreads/AddReadsTest.java > patching file test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java > patching file test/jdk/tools/launcher/modules/patch/basic/PatchTest.java > patching file test/jdk/tools/launcher/modules/patch/basic/PatchTestWarningError.java > patching file test/jdk/tools/launcher/modules/validate/ValidateModulesTest.java > > On top of this, I had to adapt a few tests to work after removal of > the old testlibrary file. > > Last, I had to move the `change` of "8217375: jarsigner breaks old signature with long lines in manifest" > to OutputAnalyzer.java from the old file to the new one. > > Now all test are passing. Pre-submit failure * missing dependencie * assertion in CMS Both unrealted to this test-only change. But the assertion is something to look at. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/945 From jdowland at openjdk.java.net Mon Mar 28 08:38:49 2022 From: jdowland at openjdk.java.net (Jonathan Dowland) Date: Mon, 28 Mar 2022 08:38:49 GMT Subject: [jdk11u-dev] Integrated: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 10:17:45 GMT, Jonathan Dowland wrote: > This is a backport of 8239785 for jdk11u. The dependent backports have now all been integrated. > > This PR replaces #881 which was stuck with a dependency on a superseded dependent PR. > > It's not clean, but the only conflict was the copyright line in the > comment header for src/hotspot/share/prims/whitebox.hpp. > > I'm checking jtreg tests in test/hotspot/jtreg/containers on a mixture of cgroup v1 and v2 systems now. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Error >  ?? The pull request body must not be empty. > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/946/head:pull/946` \ > `$ git checkout pull/946` > > Update a local copy of the PR: \ > `$ git checkout pull/946` \ > `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/946/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 946` > > View PR using the GUI difftool: \ > `$ git pr show -t 946` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.java.net/jdk11u-dev/pull/946.diff > >
This pull request has now been integrated. Changeset: d5ae8cf0 Author: Jonathan Dowland Committer: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/d5ae8cf004c4f50d552144a7ac0d933d89d53a75 Stats: 695 lines in 6 files changed: 526 ins; 96 del; 73 mod 8239785: Cgroups: Incorrect detection logic on old systems in hotspot Return NULL subsystem if no cgroup controllers are mounted. Reviewed-by: sgehwolf Backport-of: add18914fb1294999877b563c734a25b4c17b922 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/946 From avoitylov at openjdk.java.net Mon Mar 28 08:45:15 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Mon, 28 Mar 2022 08:45:15 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v3] In-Reply-To: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> Message-ID: > JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Original changeset does not apply cleanly because of: > > 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, > 8215445: Enable building for Windows in WSL > 8257913: Add more known library locations to simplify Linux cross-compilation > 8244592: Start supporting SOURCE_DATE_EPOCH > 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html Aleksei Voitylov has updated the pull request incrementally with one additional commit since the last revision: remove duplicate test helper method definition ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/910/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/910/files/1dd4c57c..6a64695e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=910&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=910&range=01-02 Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/910.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/910/head:pull/910 PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From sgehwolf at openjdk.java.net Mon Mar 28 09:26:45 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 28 Mar 2022 09:26:45 GMT Subject: [jdk11u-dev] Integrated: 8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 17:02:47 GMT, Severin Gehwolf wrote: > Clean backport removing an unimplemented left-over after the cgroups v2 support patches. This pull request has now been integrated. Changeset: 29b0b63c Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/29b0b63c6c6f2f4340fba539b12e92a5dbbe2307 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes Backport-of: 5b51085c986fed342a9bc03f3641283707a89a4e ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/948 From sgehwolf at openjdk.java.net Mon Mar 28 09:27:39 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 28 Mar 2022 09:27:39 GMT Subject: [jdk11u-dev] Integrated: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota In-Reply-To: References: Message-ID: <26rHg908O4jazCGorKl5MSyauxu74IC2ftOQ6seEnm0=.37db32c9-2580-418b-8326-93f27e328f53@github.com> On Fri, 25 Mar 2022 17:07:19 GMT, Severin Gehwolf wrote: > Comment only change so that correct units are documented. Makes sense now since we've carried it over via the cgroups v2 backport. Low risk, comment only. This pull request has now been integrated. Changeset: 27b388c6 Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/27b388c60c6df5e47d204fac224b80b49fd0cf83 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota The comment is wrong. The 'us' in 'cpu.cfs_quota_us' stands for microseconds, which is read verbatim. Similarly for cgroups v2 all units in 'cpu.max' are in microseconds. Backport-of: 5166094647f8bfae32ef4bbde2e40f68e073b595 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/949 From sgehwolf at openjdk.java.net Mon Mar 28 09:36:29 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 28 Mar 2022 09:36:29 GMT Subject: [jdk18u] RFR: 8282551: Properly initialize L32X64MixRandom state Message-ID: Issue is present in `18+36` (GA version), too. Without this fix the first int value of the default `RandomGenerator` will be the same. Clean backport. ------------- Commit messages: - Backport ce18ff8527cc51805bf11c50c050ea64c3f9dec0 Changes: https://git.openjdk.java.net/jdk18u/pull/55/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=55&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282551 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/55.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/55/head:pull/55 PR: https://git.openjdk.java.net/jdk18u/pull/55 From mdoerr at openjdk.java.net Mon Mar 28 09:37:35 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 28 Mar 2022 09:37:35 GMT Subject: [jdk17u-dev] RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() Message-ID: Backport of [JDK-8278794](https://bugs.openjdk.java.net/browse/JDK-8278794) (Clean except Copyright year update.) ------------- Commit messages: - Backport ff0b0927a2df8b36f8fd6ed41bd4e20e71a5b653 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/287/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=287&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278794 Stats: 378 lines in 5 files changed: 224 ins; 147 del; 7 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/287.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/287/head:pull/287 PR: https://git.openjdk.java.net/jdk17u-dev/pull/287 From sgehwolf at openjdk.java.net Mon Mar 28 09:37:39 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 28 Mar 2022 09:37:39 GMT Subject: [jdk17u-dev] RFR: 8282551: Properly initialize L32X64MixRandom state Message-ID: Issue is present in OpenJDK 17u too. Without this fix the first int value of the default RandomGenerator will be the same. Clean backport. ------------- Commit messages: - Backport ce18ff8527cc51805bf11c50c050ea64c3f9dec0 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/286/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=286&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282551 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/286.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/286/head:pull/286 PR: https://git.openjdk.java.net/jdk17u-dev/pull/286 From goetz at openjdk.java.net Mon Mar 28 10:32:17 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 28 Mar 2022 10:32:17 GMT Subject: [jdk11u-dev] RFR: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11 Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport a259ab4a8d163ff924ba56c5da5395cec0d8c350 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/954/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=954&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258795 Stats: 340 lines in 2 files changed: 327 ins; 0 del; 13 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/954.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/954/head:pull/954 PR: https://git.openjdk.java.net/jdk11u-dev/pull/954 From clanger at openjdk.java.net Mon Mar 28 10:46:09 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 28 Mar 2022 10:46:09 GMT Subject: [jdk11u] RFR: 8283018: 11u GHA: Update GCC 9 minor versions Message-ID: Hi all, This pull request contains a backport of [JDK-8283018](https://bugs.openjdk.java.net/browse/JDK-8283018) from the [openjdk/jdk11u-dev](https://git.openjdk.java.net/jdk11u-dev) repository. The commit being backported was authored by Aleksey Shipilev on 14 Mar 2022 and was reviewed by Severin Gehwolf. I'd like to bring this fix to 11.0.15 and do the follow-up [JDK-8283778](https://bugs.openjdk.java.net/browse/JDK-8283778) there, too, in order to have a working GHA when 11.0.15 is integrated. Thanks! ------------- Commit messages: - Backport 997c55f3600cf0c2f74de45f34934617eb3ba599 Changes: https://git.openjdk.java.net/jdk11u/pull/35/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=35&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283018 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u/pull/35.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/35/head:pull/35 PR: https://git.openjdk.java.net/jdk11u/pull/35 From rkennke at openjdk.java.net Mon Mar 28 10:46:46 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 28 Mar 2022 10:46:46 GMT Subject: [jdk11u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache [v3] In-Reply-To: References: <8a9lCHHdvjKYN7QzfnB1yrLWUarFljBfnDGy3xrcYU8=.89c903ad-446e-4c67-82fe-9fc40f5027b5@github.com> Message-ID: On Mon, 14 Mar 2022 17:09:28 GMT, Roman Kennke wrote: >> This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. >> The original change has baked for several weeks in jdk19. One of the tests needed a small adjustment because the API Reference.refersTo() does not exist in JDK 11. >> >> Testing: >> - [x] tier1 >> - [ ] tier2 >> - [ ] tier3 > > Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: > > Adjust test for missing Reference.refersTo() API @plevart @shipilev @RogerRiggs if you find some time, could you please review this backport? Thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/887 From rkennke at openjdk.java.net Mon Mar 28 10:47:49 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 28 Mar 2022 10:47:49 GMT Subject: [jdk11u-dev] RFR: 8278065: Refactor subclassAudits to use ClassValue In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 14:33:43 GMT, Roman Kennke wrote: > This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies with some conflicts caused by different context. > > Testing: > - [x] tier1 > - [x] tier2 > - [x] tier3 @RogerRiggs @plevart If you find some time, could you please review this backport? Thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/899 From avoitylov at openjdk.java.net Mon Mar 28 10:51:37 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Mon, 28 Mar 2022 10:51:37 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v2] In-Reply-To: References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> Message-ID: <-lHfvPB1b2NgIeTTse2d04buyJ8YbIStMBIAjivdLFU=.1e2f9f04-4738-4a92-8bbb-0c7fb1f38bdd@github.com> On Fri, 25 Mar 2022 08:09:27 GMT, Matthias Baesken wrote: >> Aleksei Voitylov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> JDK-8247589 backport to 11u > > Hi, we noticed a small issue in [test/jdk/tools/launcher/Test7029048.java](https://github.com/openjdk/jdk11u-dev/pull/910/files#diff-a2a1433f01e8291062945a7383286214ee41a0e8deecab03bd37bc0bebe3da14) . > test/jdk/tools/launcher/Test7029048.java now has private static void printSkipMessage(String description) twice , > this leads to the error > > test/jdk/tools/launcher/Test7029048.java:215: error: method printSkipMessage(String) is already defined in class Test7029048 > private static void printSkipMessage(String description) { > ^ @MBaesken thanks for spotting this. GHA gives "E: Version '9.4.0-1ubuntu1~20.04' for 'gcc-9' was not found" which is unrelated to this change. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From shade at openjdk.java.net Mon Mar 28 10:54:46 2022 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 28 Mar 2022 10:54:46 GMT Subject: [jdk11u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache [v3] In-Reply-To: References: <8a9lCHHdvjKYN7QzfnB1yrLWUarFljBfnDGy3xrcYU8=.89c903ad-446e-4c67-82fe-9fc40f5027b5@github.com> Message-ID: <7lKMQovDe47ZcscDba8u7SstEqAGCgI2uUKT9Lii2Sw=.f246deab-40f2-4783-9b4e-9eb93c1a425d@github.com> On Mon, 14 Mar 2022 17:09:28 GMT, Roman Kennke wrote: >> This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072. >> The original change has baked for several weeks in jdk19. One of the tests needed a small adjustment because the API Reference.refersTo() does not exist in JDK 11. >> >> Testing: >> - [x] tier1 >> - [ ] tier2 >> - [ ] tier3 > > Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: > > Adjust test for missing Reference.refersTo() API > One of the tests needed a small adjustment because the API Reference.refersTo() does not exist in JDK 11. I don't see where. Looks good otherwise. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/887 From rkennke at openjdk.java.net Mon Mar 28 11:03:39 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 28 Mar 2022 11:03:39 GMT Subject: [jdk11u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache [v3] In-Reply-To: <7lKMQovDe47ZcscDba8u7SstEqAGCgI2uUKT9Lii2Sw=.f246deab-40f2-4783-9b4e-9eb93c1a425d@github.com> References: <8a9lCHHdvjKYN7QzfnB1yrLWUarFljBfnDGy3xrcYU8=.89c903ad-446e-4c67-82fe-9fc40f5027b5@github.com> <7lKMQovDe47ZcscDba8u7SstEqAGCgI2uUKT9Lii2Sw=.f246deab-40f2-4783-9b4e-9eb93c1a425d@github.com> Message-ID: <9u4XtUGBFXULd8PydyM2adQ-YcqGfSxtZ2RJlbhkrBs=.0154a72d-ade2-4def-b846-28fb7a5ebc67@github.com> On Mon, 28 Mar 2022 10:51:58 GMT, Aleksey Shipilev wrote: > > One of the tests needed a small adjustment because the API Reference.refersTo() does not exist in JDK 11. > > I don't see where. Actually, I think that comment applies to PR #869. Dependent PRs seems to have made a little mess in GH review tab. > Looks good otherwise. Thank you! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/887 From clanger at openjdk.java.net Mon Mar 28 11:35:54 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 28 Mar 2022 11:35:54 GMT Subject: [jdk11u] RFR: 8283778: 11u GHA: Fix GCC 9 ubuntu package names Message-ID: Will be rebased after integrating https://github.com/openjdk/jdk11u/pull/35 since we don't have independet PRs in the jdk11u repository. ------------- Commit messages: - JDK-8283778 - Backport 997c55f3600cf0c2f74de45f34934617eb3ba599 Changes: https://git.openjdk.java.net/jdk11u/pull/36/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=36&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283778 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u/pull/36.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/36/head:pull/36 PR: https://git.openjdk.java.net/jdk11u/pull/36 From clanger at openjdk.java.net Mon Mar 28 11:37:44 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 28 Mar 2022 11:37:44 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v2] In-Reply-To: References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> Message-ID: On Fri, 25 Mar 2022 08:09:27 GMT, Matthias Baesken wrote: >> Aleksei Voitylov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> JDK-8247589 backport to 11u > > Hi, we noticed a small issue in [test/jdk/tools/launcher/Test7029048.java](https://github.com/openjdk/jdk11u-dev/pull/910/files#diff-a2a1433f01e8291062945a7383286214ee41a0e8deecab03bd37bc0bebe3da14) . > test/jdk/tools/launcher/Test7029048.java now has private static void printSkipMessage(String description) twice , > this leads to the error > > test/jdk/tools/launcher/Test7029048.java:215: error: method printSkipMessage(String) is already defined in class Test7029048 > private static void printSkipMessage(String description) { > ^ > @MBaesken thanks for spotting this. GHA gives "E: Version '9.4.0-1ubuntu1~20.04' for 'gcc-9' was not found" which is unrelated to this change. Yes, about to fix this with https://github.com/openjdk/jdk11u/pull/36 [JDK-8283778](https://bugs.openjdk.java.net/browse/JDK-8283778) ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From goetz at openjdk.java.net Mon Mar 28 12:12:06 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 28 Mar 2022 12:12:06 GMT Subject: [jdk11u-dev] RFR: 8255266: Update Public Suffix List to 3c213aa Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 7ce75afbbcca7635356c7377be7ddff15335e563 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/955/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=955&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255266 Stats: 1254 lines in 5 files changed: 887 ins; 215 del; 152 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/955.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/955/head:pull/955 PR: https://git.openjdk.java.net/jdk11u-dev/pull/955 From sgehwolf at openjdk.java.net Mon Mar 28 12:22:45 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 28 Mar 2022 12:22:45 GMT Subject: [jdk11u-dev] Integrated: 8266391: Replace use of reflection in jdk.internal.platform.Metrics In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 17:27:10 GMT, Severin Gehwolf wrote: > The cgroups metrics is a Linux-only feature. Instead of using reflection and returning `null` on CNFE platform specific classes can be used instead. This is a no-op from a functionality perspective and avoids reflection, which is a good thing. This pull request has now been integrated. Changeset: 2bb6a3b1 Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/2bb6a3b1333e211acf4a614b32762b5e8dbc0982 Stats: 103 lines in 4 files changed: 93 ins; 8 del; 2 mod 8266391: Replace use of reflection in jdk.internal.platform.Metrics Backport-of: 3544a9d0e4a071ad9c82aa17ab113e0101b4020b ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/950 From mdoerr at openjdk.java.net Mon Mar 28 12:33:46 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 28 Mar 2022 12:33:46 GMT Subject: [jdk11u-dev] RFR: 8210112: remove jdk.testlibrary.ProcessTools In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 07:12:36 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > I had to adapt the change in several means. This is a list > of the changes to resolve failed hunks: > > Already fixed: > patching file test/jdk/com/sun/jdi/ExclusiveBind.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/java/lang/ClassLoader/getResource/automaticmodules/Driver.java > patching file test/jdk/java/lang/ClassLoader/securityManager/ClassLoaderTest.java > patching file test/jdk/java/lang/instrument/executableJAR/ExecJarWithAgent.java > patching file test/jdk/java/rmi/module/ModuleTest.java > > Context > patching file test/jdk/java/lang/System/OsVersionTest.java > patching file test/jdk/java/security/Policy/SignedJar/SignedJarTest.java > patching file test/jdk/java/util/Arrays/TimSortStackSize2.java > > Copyright > patching file test/jdk/javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/jdk/modules/scenarios/automaticmodules/RunWithAutomaticModules.java > patching file test/jdk/sun/security/tools/jarsigner/TsacertOptionTest.java > > Copyright > patching file test/jdk/sun/security/tools/jarsigner/Warning.java > patching file test/jdk/sun/security/tools/jarsigner/warnings/BadKeyUsageTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/sun/security/tools/jarsigner/warnings/NoTimestampTest.java > > File not in 11: --- probably goes away > test/jdk/sun/tools/jcmd/JcmdBase.java b/test/jdk/sun/tools/jcmd/JcmdBase.java > patching file test/jdk/sun/tools/jcmd/TestJcmdDefaults.java > patching file test/jdk/sun/tools/jcmd/TestJcmdSanity.java > > Copyright > patching file test/jdk/sun/tools/jmap/BasicJMapTest.java > > Resolved > patching file test/jdk/sun/tools/jstatd/JstatdTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/tools/jlink/basic/BasicTest.java > patching file test/jdk/tools/launcher/modules/addexports/manifest/AddExportsAndOpensInManifest.java > patching file test/jdk/tools/launcher/modules/addreads/AddReadsTest.java > patching file test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java > patching file test/jdk/tools/launcher/modules/patch/basic/PatchTest.java > patching file test/jdk/tools/launcher/modules/patch/basic/PatchTestWarningError.java > patching file test/jdk/tools/launcher/modules/validate/ValidateModulesTest.java > > On top of this, I had to adapt a few tests to work after removal of > the old testlibrary file. > > Last, I had to move the `change` of "8217375: jarsigner breaks old signature with long lines in manifest" > to OutputAnalyzer.java from the old file to the new one. > > Now all test are passing. Thanks! Looks reasonable. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/945 From mdoerr at openjdk.java.net Mon Mar 28 12:36:48 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 28 Mar 2022 12:36:48 GMT Subject: [jdk11u-dev] RFR: 8182404: remove jdk.testlibrary.JDKToolFinder and JDKToolLauncher In-Reply-To: References: Message-ID: On Sun, 27 Mar 2022 20:07:58 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > I had to resolve JstatdTest.java. Trivial. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/951 From mdoerr at openjdk.java.net Mon Mar 28 13:05:58 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 28 Mar 2022 13:05:58 GMT Subject: [jdk11u] RFR: 8283778: 11u GHA: Fix GCC 9 ubuntu package names In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 11:30:58 GMT, Christoph Langer wrote: > Will be rebased after integrating https://github.com/openjdk/jdk11u/pull/35 since we don't have independet PRs in the jdk11u repository. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u/pull/36 From mbaesken at openjdk.java.net Mon Mar 28 13:13:46 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Mon, 28 Mar 2022 13:13:46 GMT Subject: [jdk11u] RFR: 8283778: 11u GHA: Fix GCC 9 ubuntu package names In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 11:30:58 GMT, Christoph Langer wrote: > Will be rebased after integrating https://github.com/openjdk/jdk11u/pull/35 since we don't have independet PRs in the jdk11u repository. Marked as reviewed by mbaesken (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u/pull/36 From ebaron at openjdk.java.net Mon Mar 28 15:10:45 2022 From: ebaron at openjdk.java.net (Elliott Baron) Date: Mon, 28 Mar 2022 15:10:45 GMT Subject: [jdk11u-dev] Integrated: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 22:14:20 GMT, Elliott Baron wrote: > Doesn't apply cleanly because of newer backport "JDK-8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1". > > In test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java: > - One hunk in testOperatingSystemMXBeanAwareness doesn't apply because of newer fix JDK-8250984 backported ahead of this fix. > - testOperatingSystemMXBeanAwareness in 11u already matches the what it looked like after the original JDK-8250984 commit, with JDK-8244500 already present in that version: https://github.com/openjdk/jdk/blob/0187567704d79ecf394d4cb656d0ba4c886351f1/test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java#L160-L175. > - Dropping this hunk. This pull request has now been integrated. Changeset: 2049fca2 Author: Elliott Baron Committer: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/2049fca2aacbf0f0fc73b43d242d7ad188e64ef6 Stats: 21 lines in 3 files changed: 19 ins; 0 del; 2 mod 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java When the kernel doesn't support swap limits, expect host values instead. Reviewed-by: sgehwolf Backport-of: fb5132254d834ba01a4b65ce64143843e83c674e ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/920 From rriggs at openjdk.java.net Mon Mar 28 15:44:53 2022 From: rriggs at openjdk.java.net (Roger Riggs) Date: Mon, 28 Mar 2022 15:44:53 GMT Subject: [jdk11u-dev] RFR: 8278065: Refactor subclassAudits to use ClassValue In-Reply-To: References: Message-ID: On Wed, 16 Mar 2022 14:33:43 GMT, Roman Kennke wrote: > This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072. > The original change has baked for several weeks in jdk19 and applies with some conflicts caused by different context. > > Testing: > - [x] tier1 > - [x] tier2 > - [x] tier3 Marked as reviewed by rriggs (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/899 From sgehwolf at openjdk.java.net Mon Mar 28 15:46:12 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 28 Mar 2022 15:46:12 GMT Subject: [jdk11u-dev] RFR: 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111 Message-ID: <0y4WY6PwoWzYS7w85SG8RvqvBxut0FM8ZFkjNN1cdb4=.e5b2a8c4-8e39-416f-8e87-eae5d182f669@github.com> Please review this test fix backport to align with JDK 17+. Since [JDK-8231111](https://bugs.openjdk.java.net/browse/JDK-8231111) has been backported now, we need to adjust some test code so as to not run afoul when on certain test systems. The original patch doesn't apply cleanly due to: - `test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java`: [JDK-8275713](https://bugs.openjdk.java.net/browse/JDK-8275713) being present in JDK 11u which is a bug specific to JDK 15 and less. JDK-8275713 is a partial backport of this bug. Omitted those hunks. - `test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java`: One hunk didn't apply cleanly due to [JDK-8250984](https://bugs.openjdk.java.net/browse/JDK-8250984) present in 11u ahead of this backport. Fixed this up manually. Everything else is the same. Testing: - [x] container tests on Linux x86_64 on a cgroups v2 and cgroups v1 system. All pass. ------------- Commit messages: - Backport c92adf41587767e9c5c8e116cfaeb375d36928aa Changes: https://git.openjdk.java.net/jdk11u-dev/pull/956/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=956&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8240189 Stats: 145 lines in 5 files changed: 46 ins; 28 del; 71 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/956.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/956/head:pull/956 PR: https://git.openjdk.java.net/jdk11u-dev/pull/956 From rkennke at openjdk.java.net Mon Mar 28 15:48:42 2022 From: rkennke at openjdk.java.net (Roman Kennke) Date: Mon, 28 Mar 2022 15:48:42 GMT Subject: [jdk11u-dev] RFR: 8280041: Retry loop issues in java.io.ClassCache [v3] In-Reply-To: References: <8a9lCHHdvjKYN7QzfnB1yrLWUarFljBfnDGy3xrcYU8=.89c903ad-446e-4c67-82fe-9fc40f5027b5@github.com> Message-ID: On Mon, 28 Mar 2022 06:12:39 GMT, Goetz Lindenmaier wrote: > @rkennek I remove the fix-request tag. There seems to be no progress on this and I keep checking the three changes for progress over and over. Please add the tag again on 8280041 and this one once theyh are ready to go, especially reviewed. @GoeLin thank you. Both this backport and #887 are reviewed now, and I added back the jdk11u-fix-request. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/887 From mdoerr at openjdk.java.net Mon Mar 28 17:39:45 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 28 Mar 2022 17:39:45 GMT Subject: [jdk11u-dev] RFR: 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111 In-Reply-To: <0y4WY6PwoWzYS7w85SG8RvqvBxut0FM8ZFkjNN1cdb4=.e5b2a8c4-8e39-416f-8e87-eae5d182f669@github.com> References: <0y4WY6PwoWzYS7w85SG8RvqvBxut0FM8ZFkjNN1cdb4=.e5b2a8c4-8e39-416f-8e87-eae5d182f669@github.com> Message-ID: <52bnBlZipbw8SwPai5VJyKyPjs7FuJczqIOXybzwld8=.d5e0fbc0-d9fd-4e51-a82b-19bd7a5eaac5@github.com> On Mon, 28 Mar 2022 15:39:51 GMT, Severin Gehwolf wrote: > Please review this test fix backport to align with JDK 17+. Since [JDK-8231111](https://bugs.openjdk.java.net/browse/JDK-8231111) has been backported now, we need to adjust some test code so as to not run afoul when on certain test systems. The original patch doesn't apply cleanly due to: > > - `test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java`: [JDK-8275713](https://bugs.openjdk.java.net/browse/JDK-8275713) being present in JDK 11u which is a bug specific to JDK 15 and less. JDK-8275713 is a partial backport of this bug. Omitted those hunks. > - `test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java`: One hunk didn't apply cleanly due to [JDK-8250984](https://bugs.openjdk.java.net/browse/JDK-8250984) present in 11u ahead of this backport. Fixed this up manually. > > Everything else is the same. > > Testing: > - [x] container tests on Linux x86_64 on a cgroups v2 and cgroups v1 system. All pass. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/956 From sgehwolf at openjdk.java.net Mon Mar 28 17:57:53 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Mon, 28 Mar 2022 17:57:53 GMT Subject: [jdk11u-dev] RFR: 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111 In-Reply-To: <0y4WY6PwoWzYS7w85SG8RvqvBxut0FM8ZFkjNN1cdb4=.e5b2a8c4-8e39-416f-8e87-eae5d182f669@github.com> References: <0y4WY6PwoWzYS7w85SG8RvqvBxut0FM8ZFkjNN1cdb4=.e5b2a8c4-8e39-416f-8e87-eae5d182f669@github.com> Message-ID: On Mon, 28 Mar 2022 15:39:51 GMT, Severin Gehwolf wrote: > Please review this test fix backport to align with JDK 17+. Since [JDK-8231111](https://bugs.openjdk.java.net/browse/JDK-8231111) has been backported now, we need to adjust some test code so as to not run afoul when on certain test systems. The original patch doesn't apply cleanly due to: > > - `test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java`: [JDK-8275713](https://bugs.openjdk.java.net/browse/JDK-8275713) being present in JDK 11u which is a bug specific to JDK 15 and less. JDK-8275713 is a partial backport of this bug. Omitted those hunks. > - `test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java`: One hunk didn't apply cleanly due to [JDK-8250984](https://bugs.openjdk.java.net/browse/JDK-8250984) present in 11u ahead of this backport. Fixed this up manually. > > Everything else is the same. > > Testing: > - [x] container tests on Linux x86_64 on a cgroups v2 and cgroups v1 system. All pass. Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/956 From goetz at openjdk.java.net Mon Mar 28 19:37:17 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Mon, 28 Mar 2022 19:37:17 GMT Subject: [jdk11u-dev] RFR: 8210732: remove jdk.testlibrary.Utils Message-ID: I want to backport this ot simplify follow-up test backports. Change already applied in previous backport test/hotspot/jtreg/runtime/Dictionary/ProtectionDomainCacheTest.java Change not applicable, other changes removed the import: test/jdk/com/sun/jdi/BasicJDWPConnectionTest.java test/jdk/com/sun/jdi/ExclusiveBind.java test/jdk/java/lang/ClassLoader/forNameLeak/ClassForNameLeak.java Merged: test/jdk/sun/tools/jstatd/JstatdTest.java ------------- Depends on: https://git.openjdk.java.net/jdk11u-dev/pull/951 Commit messages: - Backport 8b28ad6efe68b076bdbd6ca0043a0fddd8847230 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/957/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=957&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8210732 Stats: 469 lines in 92 files changed: 2 ins; 319 del; 148 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/957.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/957/head:pull/957 PR: https://git.openjdk.java.net/jdk11u-dev/pull/957 From clanger at openjdk.java.net Mon Mar 28 21:09:46 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 28 Mar 2022 21:09:46 GMT Subject: [jdk11u-dev] Integrated: 8276657: XSLT compiler tries to define a class with empty name In-Reply-To: <9z5v7X6wvK439s7NOYmKKMHXSJAMbYrgOAZAAub1uZM=.93b6e0b0-5fcf-4ffd-81b3-920a3aaf58ea@github.com> References: <9z5v7X6wvK439s7NOYmKKMHXSJAMbYrgOAZAAub1uZM=.93b6e0b0-5fcf-4ffd-81b3-920a3aaf58ea@github.com> Message-ID: On Fri, 25 Mar 2022 10:19:18 GMT, Christoph Langer wrote: > Backport of JDK-8276657 as per request of Cheng Jin > http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-March/012660.html This pull request has now been integrated. Changeset: 358fc5ac Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u-dev/commit/358fc5ac6b95e52eea357373acf6e56f8cd9816e Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod 8276657: XSLT compiler tries to define a class with empty name Backport-of: 3c6aecd395e2dd6829815dcaa9d0e17d252131ed ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/947 From xuelei at openjdk.java.net Mon Mar 28 21:48:43 2022 From: xuelei at openjdk.java.net (Xue-Lei Andrew Fan) Date: Mon, 28 Mar 2022 21:48:43 GMT Subject: [jdk11u-dev] RFR: 8259517: Incorrect test path in test cases In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 07:00:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. It looks like a safe backport to me. Thanks! ------------- Marked as reviewed by xuelei (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/952 From ysatowse at openjdk.java.net Mon Mar 28 22:57:12 2022 From: ysatowse at openjdk.java.net (Yoshiki Sato) Date: Mon, 28 Mar 2022 22:57:12 GMT Subject: [jdk18u] RFR: 8283350: (tz) Update Timezone Data to 2022a Message-ID: Clean backport of [JDK-8283350](https://bugs.openjdk.java.net/browse/JDK-8283350) (tz) Update Timezone Data to 2022a ------------- Commit messages: - Backport b05d4ccf8e54635c16bc2c26aa7a8fcc2e3b3dde Changes: https://git.openjdk.java.net/jdk18u/pull/52/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=52&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283350 Stats: 103 lines in 6 files changed: 76 ins; 0 del; 27 mod Patch: https://git.openjdk.java.net/jdk18u/pull/52.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/52/head:pull/52 PR: https://git.openjdk.java.net/jdk18u/pull/52 From mdoerr at openjdk.java.net Mon Mar 28 22:57:12 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Mon, 28 Mar 2022 22:57:12 GMT Subject: [jdk18u] RFR: 8283350: (tz) Update Timezone Data to 2022a In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 00:39:35 GMT, Yoshiki Sato wrote: > Clean backport of [JDK-8283350](https://bugs.openjdk.java.net/browse/JDK-8283350) > (tz) Update Timezone Data to 2022a Not recognized as clean because the files were moved. However, the hunks apply cleanly and the backport looks good to me. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk18u/pull/52 From naoto at openjdk.java.net Mon Mar 28 23:44:01 2022 From: naoto at openjdk.java.net (Naoto Sato) Date: Mon, 28 Mar 2022 23:44:01 GMT Subject: [jdk18u] RFR: 8283350: (tz) Update Timezone Data to 2022a In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 00:39:35 GMT, Yoshiki Sato wrote: > Clean backport of [JDK-8283350](https://bugs.openjdk.java.net/browse/JDK-8283350) > (tz) Update Timezone Data to 2022a Marked as reviewed by naoto (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk18u/pull/52 From ysatowse at openjdk.java.net Mon Mar 28 23:49:05 2022 From: ysatowse at openjdk.java.net (Yoshiki Sato) Date: Mon, 28 Mar 2022 23:49:05 GMT Subject: [jdk18u] Integrated: 8283350: (tz) Update Timezone Data to 2022a In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 00:39:35 GMT, Yoshiki Sato wrote: > Clean backport of [JDK-8283350](https://bugs.openjdk.java.net/browse/JDK-8283350) > (tz) Update Timezone Data to 2022a This pull request has now been integrated. Changeset: 1ab6f939 Author: Yoshiki Sato Committer: Naoto Sato URL: https://git.openjdk.java.net/jdk18u/commit/1ab6f9395f784293deb37ea0186db59d1166ae40 Stats: 103 lines in 6 files changed: 76 ins; 0 del; 27 mod 8283350: (tz) Update Timezone Data to 2022a Reviewed-by: mdoerr, naoto Backport-of: b05d4ccf8e54635c16bc2c26aa7a8fcc2e3b3dde ------------- PR: https://git.openjdk.java.net/jdk18u/pull/52 From zgu at openjdk.java.net Tue Mar 29 00:36:15 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 29 Mar 2022 00:36:15 GMT Subject: [jdk18u] RFR: 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig() Message-ID: A clean backport to fix a memory ------------- Commit messages: - Backport 5df2a057707eb65148f96710bd57d8dd8d85d1ed Changes: https://git.openjdk.java.net/jdk18u/pull/56/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=56&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282628 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk18u/pull/56.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/56/head:pull/56 PR: https://git.openjdk.java.net/jdk18u/pull/56 From zgu at openjdk.java.net Tue Mar 29 00:36:21 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Tue, 29 Mar 2022 00:36:21 GMT Subject: [jdk17u-dev] RFR: 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig() Message-ID: A clean backport to fix a memory leak. ------------- Commit messages: - Backport 5df2a057707eb65148f96710bd57d8dd8d85d1ed Changes: https://git.openjdk.java.net/jdk17u-dev/pull/288/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=288&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282628 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/288.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/288/head:pull/288 PR: https://git.openjdk.java.net/jdk17u-dev/pull/288 From clanger at openjdk.java.net Tue Mar 29 04:58:50 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 29 Mar 2022 04:58:50 GMT Subject: [jdk11u] Integrated: 8283018: 11u GHA: Update GCC 9 minor versions In-Reply-To: References: Message-ID: <4e7ydzSTbXZqm_8rMTM6Ns6xt23DJmk0OLKi4HDUpiM=.c26a26c6-4e35-4b8a-90a2-66501c068a90@github.com> On Mon, 28 Mar 2022 10:39:17 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8283018](https://bugs.openjdk.java.net/browse/JDK-8283018) from the [openjdk/jdk11u-dev](https://git.openjdk.java.net/jdk11u-dev) repository. > > The commit being backported was authored by Aleksey Shipilev on 14 Mar 2022 and was reviewed by Severin Gehwolf. > > > I'd like to bring this fix to 11.0.15 and do the follow-up [JDK-8283778](https://bugs.openjdk.java.net/browse/JDK-8283778) there, too, in order to have a working GHA when 11.0.15 is integrated. > > Thanks! This pull request has now been integrated. Changeset: 04136804 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u/commit/041368044824eb666a7553e50039a47df2b461c1 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8283018: 11u GHA: Update GCC 9 minor versions Backport-of: 997c55f3600cf0c2f74de45f34934617eb3ba599 ------------- PR: https://git.openjdk.java.net/jdk11u/pull/35 From clanger at openjdk.java.net Tue Mar 29 05:04:04 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 29 Mar 2022 05:04:04 GMT Subject: [jdk11u] RFR: 8283778: 11u GHA: Fix GCC 9 ubuntu package names [v2] In-Reply-To: References: Message-ID: > Will be rebased after integrating https://github.com/openjdk/jdk11u/pull/35 since we don't have independet PRs in the jdk11u repository. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JDK-8283778 ------------- Changes: https://git.openjdk.java.net/jdk11u/pull/36/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u&pr=36&range=01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u/pull/36.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u pull/36/head:pull/36 PR: https://git.openjdk.java.net/jdk11u/pull/36 From mbaesken at openjdk.java.net Tue Mar 29 07:35:45 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 29 Mar 2022 07:35:45 GMT Subject: [jdk11u-dev] Integrated: 8273176: handle latest VS2019 in abstract_vm_version In-Reply-To: References: Message-ID: <2M6CnmMugQ-g1fv8w5fkfze6SwGUY_4LqSU0ZXZ09EQ=.53956cdc-5382-49bd-9efa-5a2549e97490@github.com> On Mon, 28 Mar 2022 07:26:29 GMT, Matthias Baesken wrote: > 8273176: handle latest VS2019 in abstract_vm_version This pull request has now been integrated. Changeset: 65186363 Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk11u-dev/commit/65186363bffda7cf1ddf9e400c878b378c7a979c Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8273176: handle latest VS2019 in abstract_vm_version Backport-of: 0e14bf70cf6e482a2ec7d13ed37df0bee911740d ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/953 From mdoerr at openjdk.java.net Tue Mar 29 08:34:18 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 08:34:18 GMT Subject: [jdk17u-dev] RFR: 8283350: (tz) Update Timezone Data to 2022a Message-ID: Backport of [JDK-8283350](https://bugs.openjdk.java.net/browse/JDK-8283350) Version from JDK18u applies cleanly. ------------- Commit messages: - Backport 1ab6f9395f784293deb37ea0186db59d1166ae40 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/289/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=289&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283350 Stats: 103 lines in 6 files changed: 76 ins; 0 del; 27 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/289.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/289/head:pull/289 PR: https://git.openjdk.java.net/jdk17u-dev/pull/289 From clanger at openjdk.java.net Tue Mar 29 08:48:40 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 29 Mar 2022 08:48:40 GMT Subject: [jdk11u] Integrated: 8283778: 11u GHA: Fix GCC 9 ubuntu package names In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 11:30:58 GMT, Christoph Langer wrote: > Will be rebased after integrating https://github.com/openjdk/jdk11u/pull/35 since we don't have independet PRs in the jdk11u repository. This pull request has now been integrated. Changeset: 487c3344 Author: Christoph Langer URL: https://git.openjdk.java.net/jdk11u/commit/487c3344fee3502b4843e7e11acceb77ad16100c Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8283778: 11u GHA: Fix GCC 9 ubuntu package names Reviewed-by: mdoerr, mbaesken ------------- PR: https://git.openjdk.java.net/jdk11u/pull/36 From goetz at openjdk.java.net Tue Mar 29 09:13:52 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 09:13:52 GMT Subject: [jdk11u-dev] RFR: 8210732: remove jdk.testlibrary.Utils In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 19:30:42 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > Change already applied in previous backport > test/hotspot/jtreg/runtime/Dictionary/ProtectionDomainCacheTest.java > > Change not applicable, other changes removed the import: > test/jdk/com/sun/jdi/BasicJDWPConnectionTest.java > test/jdk/com/sun/jdi/ExclusiveBind.java > test/jdk/java/lang/ClassLoader/forNameLeak/ClassForNameLeak.java > > Merged: > test/jdk/sun/tools/jstatd/JstatdTest.java Pre-submti failur: dependencies missing. Fixed in jdk11u. Unrelated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/957 From goetz at openjdk.java.net Tue Mar 29 09:17:55 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 09:17:55 GMT Subject: [jdk11u-dev] Integrated: 8210112: remove jdk.testlibrary.ProcessTools In-Reply-To: References: Message-ID: <848Jd0wBsQ6S7pJVeMrJMcS-pwvH2KrUJEVBtnVz-5w=.eda59363-4ed1-4b6d-a5e3-b2bb3be570bd@github.com> On Fri, 25 Mar 2022 07:12:36 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > I had to adapt the change in several means. This is a list > of the changes to resolve failed hunks: > > Already fixed: > patching file test/jdk/com/sun/jdi/ExclusiveBind.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/java/lang/ClassLoader/getResource/automaticmodules/Driver.java > patching file test/jdk/java/lang/ClassLoader/securityManager/ClassLoaderTest.java > patching file test/jdk/java/lang/instrument/executableJAR/ExecJarWithAgent.java > patching file test/jdk/java/rmi/module/ModuleTest.java > > Context > patching file test/jdk/java/lang/System/OsVersionTest.java > patching file test/jdk/java/security/Policy/SignedJar/SignedJarTest.java > patching file test/jdk/java/util/Arrays/TimSortStackSize2.java > > Copyright > patching file test/jdk/javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/jdk/modules/scenarios/automaticmodules/RunWithAutomaticModules.java > patching file test/jdk/sun/security/tools/jarsigner/TsacertOptionTest.java > > Copyright > patching file test/jdk/sun/security/tools/jarsigner/Warning.java > patching file test/jdk/sun/security/tools/jarsigner/warnings/BadKeyUsageTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/sun/security/tools/jarsigner/warnings/NoTimestampTest.java > > File not in 11: --- probably goes away > test/jdk/sun/tools/jcmd/JcmdBase.java b/test/jdk/sun/tools/jcmd/JcmdBase.java > patching file test/jdk/sun/tools/jcmd/TestJcmdDefaults.java > patching file test/jdk/sun/tools/jcmd/TestJcmdSanity.java > > Copyright > patching file test/jdk/sun/tools/jmap/BasicJMapTest.java > > Resolved > patching file test/jdk/sun/tools/jstatd/JstatdTest.java > > Resolved, 8211171 move JarUtils to top-level testlibrary already backported. > patching file test/jdk/tools/jlink/basic/BasicTest.java > patching file test/jdk/tools/launcher/modules/addexports/manifest/AddExportsAndOpensInManifest.java > patching file test/jdk/tools/launcher/modules/addreads/AddReadsTest.java > patching file test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java > patching file test/jdk/tools/launcher/modules/patch/basic/PatchTest.java > patching file test/jdk/tools/launcher/modules/patch/basic/PatchTestWarningError.java > patching file test/jdk/tools/launcher/modules/validate/ValidateModulesTest.java > > On top of this, I had to adapt a few tests to work after removal of > the old testlibrary file. > > Last, I had to move the `change` of "8217375: jarsigner breaks old signature with long lines in manifest" > to OutputAnalyzer.java from the old file to the new one. > > Now all test are passing. This pull request has now been integrated. Changeset: 9aa728e6 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/9aa728e61efe366c00ce78ae2d9bbcc56e3d974b Stats: 2571 lines in 184 files changed: 335 ins; 1687 del; 549 mod 8210112: remove jdk.testlibrary.ProcessTools Reviewed-by: mdoerr Backport-of: 21a0458422c462f5ae82a98ce08c6460db26c67e ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/945 From mdoerr at openjdk.java.net Tue Mar 29 09:21:52 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 09:21:52 GMT Subject: [jdk17u-dev] Integrated: 8270797: ShortECDSA.java test is not complete In-Reply-To: <4YegCjbGO1iz6DH9NwrO3-5wKypt49ZRL5mdyAPXQS8=.985e59f1-3cb7-436f-9d38-ed03f78a509b@github.com> References: <4YegCjbGO1iz6DH9NwrO3-5wKypt49ZRL5mdyAPXQS8=.985e59f1-3cb7-436f-9d38-ed03f78a509b@github.com> Message-ID: On Fri, 25 Mar 2022 11:57:46 GMT, Martin Doerr wrote: > Clean backport of [JDK-8270797](https://bugs.openjdk.java.net/browse/JDK-8270797) This pull request has now been integrated. Changeset: b16d0378 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/b16d03782b75eaa4f21054d43fa1014c974f2318 Stats: 16 lines in 1 file changed: 15 ins; 0 del; 1 mod 8270797: ShortECDSA.java test is not complete Backport-of: 221e4b9c61cd1c9c3f4c037589ba639541532910 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/285 From goetz at openjdk.java.net Tue Mar 29 09:23:41 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 09:23:41 GMT Subject: [jdk11u-dev] RFR: 8182404: remove jdk.testlibrary.JDKToolFinder and JDKToolLauncher [v2] In-Reply-To: References: Message-ID: > I want to backport this ot simplify follow-up test backports. > > I had to resolve JstatdTest.java. Trivial. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/951/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/951/files/5a361dd8..5a361dd8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=951&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=951&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/951.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/951/head:pull/951 PR: https://git.openjdk.java.net/jdk11u-dev/pull/951 From duke at openjdk.java.net Tue Mar 29 09:23:41 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Tue, 29 Mar 2022 09:23:41 GMT Subject: [jdk11u-dev] RFR: 8182404: remove jdk.testlibrary.JDKToolFinder and JDKToolLauncher In-Reply-To: References: Message-ID: On Sun, 27 Mar 2022 20:07:58 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > I had to resolve JstatdTest.java. Trivial. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8210112 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/951 From mdoerr at openjdk.java.net Tue Mar 29 09:24:03 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 09:24:03 GMT Subject: [jdk17u-dev] Integrated: 8281771: Crash in java_lang_invoke_MethodType::print_signature In-Reply-To: References: Message-ID: On Fri, 25 Mar 2022 11:38:49 GMT, Martin Doerr wrote: > Clean backport of [JDK-8281771](https://bugs.openjdk.java.net/browse/JDK-8281771) This pull request has now been integrated. Changeset: 92bbddeb Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/92bbddeb55d630aae8782d0f3fef480d92389cb3 Stats: 13 lines in 1 file changed: 9 ins; 0 del; 4 mod 8281771: Crash in java_lang_invoke_MethodType::print_signature Backport-of: a24498b777b76c04d7e6da0a8b5fb501f2fb4944 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/284 From mdoerr at openjdk.java.net Tue Mar 29 09:29:02 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 09:29:02 GMT Subject: [jdk17u-dev] Integrated: 8278794: Infinite loop in DeflaterOutputStream.finish() In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 09:30:04 GMT, Martin Doerr wrote: > Backport of [JDK-8278794](https://bugs.openjdk.java.net/browse/JDK-8278794) > (Clean except Copyright year update.) This pull request has now been integrated. Changeset: 66c35298 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/66c35298616cd23382b1a1fe1afeb90b1d0c0222 Stats: 378 lines in 5 files changed: 224 ins; 147 del; 7 mod 8278794: Infinite loop in DeflaterOutputStream.finish() Backport-of: ff0b0927a2df8b36f8fd6ed41bd4e20e71a5b653 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/287 From sgehwolf at openjdk.java.net Tue Mar 29 09:49:58 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 29 Mar 2022 09:49:58 GMT Subject: [jdk17u-dev] Integrated: 8282551: Properly initialize L32X64MixRandom state In-Reply-To: References: Message-ID: <49JmYUI1rHNx7eb6vP_dBp4DjHlqwqr889H4YPPDAwk=.4947a4cc-b184-4608-9710-0dec32ba2533@github.com> On Mon, 28 Mar 2022 09:29:00 GMT, Severin Gehwolf wrote: > Issue is present in OpenJDK 17u too. Without this fix the first int value of the default RandomGenerator will be the same. Clean backport. This pull request has now been integrated. Changeset: 7e41d843 Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk17u-dev/commit/7e41d8439305a9966d968c51480df1623c50cbb2 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8282551: Properly initialize L32X64MixRandom state Backport-of: ce18ff8527cc51805bf11c50c050ea64c3f9dec0 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/286 From goetz at openjdk.java.net Tue Mar 29 09:52:45 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 09:52:45 GMT Subject: [jdk11u-dev] Integrated: 8182404: remove jdk.testlibrary.JDKToolFinder and JDKToolLauncher In-Reply-To: References: Message-ID: <-n_3_bB56fpxwHjKIgA6FnQ3C3eElTSJus1TfGNlzaY=.ab5bd698-ddbb-4d61-8f1d-be41ea5c87a9@github.com> On Sun, 27 Mar 2022 20:07:58 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > I had to resolve JstatdTest.java. Trivial. This pull request has now been integrated. Changeset: 389ac328 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/389ac328525878e507b2bb1e431edb91cb02b568 Stats: 328 lines in 45 files changed: 13 ins; 270 del; 45 mod 8182404: remove jdk.testlibrary.JDKToolFinder and JDKToolLauncher Reviewed-by: mdoerr ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/951 From goetz at openjdk.java.net Tue Mar 29 09:56:41 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 09:56:41 GMT Subject: [jdk11u-dev] RFR: 8210732: remove jdk.testlibrary.Utils [v2] In-Reply-To: References: Message-ID: > I want to backport this ot simplify follow-up test backports. > > Change already applied in previous backport > test/hotspot/jtreg/runtime/Dictionary/ProtectionDomainCacheTest.java > > Change not applicable, other changes removed the import: > test/jdk/com/sun/jdi/BasicJDWPConnectionTest.java > test/jdk/com/sun/jdi/ExclusiveBind.java > test/jdk/java/lang/ClassLoader/forNameLeak/ClassForNameLeak.java > > Merged: > test/jdk/sun/tools/jstatd/JstatdTest.java Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/957/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/957/files/55ed9a7c..55ed9a7c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=957&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=957&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/957.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/957/head:pull/957 PR: https://git.openjdk.java.net/jdk11u-dev/pull/957 From duke at openjdk.java.net Tue Mar 29 09:56:41 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Tue, 29 Mar 2022 09:56:41 GMT Subject: [jdk11u-dev] RFR: 8210732: remove jdk.testlibrary.Utils In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 19:30:42 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > Change already applied in previous backport > test/hotspot/jtreg/runtime/Dictionary/ProtectionDomainCacheTest.java > > Change not applicable, other changes removed the import: > test/jdk/com/sun/jdi/BasicJDWPConnectionTest.java > test/jdk/com/sun/jdi/ExclusiveBind.java > test/jdk/java/lang/ClassLoader/forNameLeak/ClassForNameLeak.java > > Merged: > test/jdk/sun/tools/jstatd/JstatdTest.java The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8182404 git fetch https://git.openjdk.java.net/jdk11u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/957 From goetz at openjdk.java.net Tue Mar 29 09:56:46 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 09:56:46 GMT Subject: [jdk11u-dev] RFR: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11 In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 10:24:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Pre-submit failure: missing deps. Fixed in jdk11u. Unrelated. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/954 From goetz at openjdk.java.net Tue Mar 29 09:56:49 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 09:56:49 GMT Subject: [jdk11u-dev] RFR: 8259517: Incorrect test path in test cases In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 07:00:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/952 From goetz at openjdk.java.net Tue Mar 29 09:56:49 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 09:56:49 GMT Subject: [jdk11u-dev] Integrated: 8259517: Incorrect test path in test cases In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 07:00:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: 68a9e01a Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/68a9e01a0ee4bfbd123f9afc4748a4de2604d670 Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod 8259517: Incorrect test path in test cases Reviewed-by: xuelei Backport-of: 81db63e8d74c0d85cdadb0a70580a33c79d0bb80 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/952 From goetz at openjdk.java.net Tue Mar 29 09:59:46 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 09:59:46 GMT Subject: [jdk11u-dev] RFR: 8255266: Update Public Suffix List to 3c213aa In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 12:03:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Pre-submit failure: Missing deps, fixed in jdk11u gc/cms/TestBubbleUpRef.java on x86 32-bit: known failure. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/955 From mdoerr at openjdk.java.net Tue Mar 29 10:07:24 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 10:07:24 GMT Subject: [jdk17u-dev] RFR: 8271302: Regex Test Refresh Message-ID: <0z0ouP83yOSqUBliWJHIglFqF4iQa8wrNrCl7VPu4wk=.aed35833-04e5-4c7b-a509-629800d5856a@github.com> Clean backport of [JDK-8271302](https://bugs.openjdk.java.net/browse/JDK-8271302) ------------- Commit messages: - Backport fecefb8541d5056b1a8b105126ac9c566875e056 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/290/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=290&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271302 Stats: 2253 lines in 3 files changed: 220 ins; 989 del; 1044 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/290.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/290/head:pull/290 PR: https://git.openjdk.java.net/jdk17u-dev/pull/290 From sgehwolf at openjdk.java.net Tue Mar 29 10:14:48 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Tue, 29 Mar 2022 10:14:48 GMT Subject: [jdk11u-dev] Integrated: 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111 In-Reply-To: <0y4WY6PwoWzYS7w85SG8RvqvBxut0FM8ZFkjNN1cdb4=.e5b2a8c4-8e39-416f-8e87-eae5d182f669@github.com> References: <0y4WY6PwoWzYS7w85SG8RvqvBxut0FM8ZFkjNN1cdb4=.e5b2a8c4-8e39-416f-8e87-eae5d182f669@github.com> Message-ID: <1upbzZcl5kxht4wwOf4-H2V9L_3S7GFDz35hXyCApF8=.495b2d6b-58f1-423d-9dc2-c0ed730cb846@github.com> On Mon, 28 Mar 2022 15:39:51 GMT, Severin Gehwolf wrote: > Please review this test fix backport to align with JDK 17+. Since [JDK-8231111](https://bugs.openjdk.java.net/browse/JDK-8231111) has been backported now, we need to adjust some test code so as to not run afoul when on certain test systems. The original patch doesn't apply cleanly due to: > > - `test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java`: [JDK-8275713](https://bugs.openjdk.java.net/browse/JDK-8275713) being present in JDK 11u which is a bug specific to JDK 15 and less. JDK-8275713 is a partial backport of this bug. Omitted those hunks. > - `test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java`: One hunk didn't apply cleanly due to [JDK-8250984](https://bugs.openjdk.java.net/browse/JDK-8250984) present in 11u ahead of this backport. Fixed this up manually. > > Everything else is the same. > > Testing: > - [x] container tests on Linux x86_64 on a cgroups v2 and cgroups v1 system. All pass. This pull request has now been integrated. Changeset: 5ed1009d Author: Severin Gehwolf URL: https://git.openjdk.java.net/jdk11u-dev/commit/5ed1009dc202a5f0dc3559b0242dbacac7c051b2 Stats: 145 lines in 5 files changed: 46 ins; 28 del; 71 mod 8240189: [TESTBUG] Some cgroup tests are failing after JDK-8231111 Reviewed-by: mdoerr Backport-of: c92adf41587767e9c5c8e116cfaeb375d36928aa ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/956 From goetz at openjdk.java.net Tue Mar 29 10:27:15 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 10:27:15 GMT Subject: [jdk11u-dev] RFR: 8266318: Switch to macos prefix for macOS bundles Message-ID: <-FQUEruHm5bgOnOu9PtmmO6W1GCtxzIvCkc8qOot7Sk=.c05f4c1f-f06c-488f-b6ae-046aaada7a97@github.com> I backport this for parity with 11.0.16-oracle. platform.m4: Resolved copyright. jib-proviles.js: macos-aarch64 not listed. Skipped. ------------- Commit messages: - Backport 096e9e5d13183f947089b5c7923890591490a2ce Changes: https://git.openjdk.java.net/jdk11u-dev/pull/958/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=958&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266318 Stats: 20 lines in 3 files changed: 2 ins; 4 del; 14 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/958.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/958/head:pull/958 PR: https://git.openjdk.java.net/jdk11u-dev/pull/958 From mdoerr at openjdk.java.net Tue Mar 29 10:36:47 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 10:36:47 GMT Subject: [jdk11u-dev] RFR: 8210732: remove jdk.testlibrary.Utils [v2] In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 09:56:41 GMT, Goetz Lindenmaier wrote: >> I want to backport this ot simplify follow-up test backports. >> >> Change already applied in previous backport >> test/hotspot/jtreg/runtime/Dictionary/ProtectionDomainCacheTest.java >> >> Change not applicable, other changes removed the import: >> test/jdk/com/sun/jdi/BasicJDWPConnectionTest.java >> test/jdk/com/sun/jdi/ExclusiveBind.java >> test/jdk/java/lang/ClassLoader/forNameLeak/ClassForNameLeak.java >> >> Merged: >> test/jdk/sun/tools/jstatd/JstatdTest.java > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Thanks for the description. Fortunately, not too many edits. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/957 From mdoerr at openjdk.java.net Tue Mar 29 10:38:45 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 10:38:45 GMT Subject: [jdk11u-dev] RFR: 8266318: Switch to macos prefix for macOS bundles In-Reply-To: <-FQUEruHm5bgOnOu9PtmmO6W1GCtxzIvCkc8qOot7Sk=.c05f4c1f-f06c-488f-b6ae-046aaada7a97@github.com> References: <-FQUEruHm5bgOnOu9PtmmO6W1GCtxzIvCkc8qOot7Sk=.c05f4c1f-f06c-488f-b6ae-046aaada7a97@github.com> Message-ID: On Tue, 29 Mar 2022 10:21:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > platform.m4: Resolved copyright. > jib-proviles.js: macos-aarch64 not listed. Skipped. Please fix typo. make/conf/jib-profiles.js line 610: > 608: }, > 609: "macosx-x64": { > 610: platform: "jacos-x64", Typo! ------------- Changes requested by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/958 From mdoerr at openjdk.java.net Tue Mar 29 10:39:34 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 10:39:34 GMT Subject: [jdk17u-dev] RFR: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302 Message-ID: Clean backport of [JDK-8273169](https://bugs.openjdk.java.net/browse/JDK-8273169) on top of JDK-8271302. ------------- Depends on: https://git.openjdk.java.net/jdk17u-dev/pull/290 Commit messages: - Backport 683e30db79789ee44b3cc0b44c085de4615bca7b Changes: https://git.openjdk.java.net/jdk17u-dev/pull/291/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=291&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273169 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/291.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/291/head:pull/291 PR: https://git.openjdk.java.net/jdk17u-dev/pull/291 From mdoerr at openjdk.java.net Tue Mar 29 10:51:29 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 10:51:29 GMT Subject: [jdk17u-dev] RFR: 8272358: Some tests may fail when executed with other locales than the US Message-ID: <8Bnkjiz6Dh0K7XnVfKOamZWqIIF_XWBeREtQWDS6dMg=.2f8d393e-a76f-40db-8557-86bb2792d7f2@github.com> Clean backport of [JDK-8272358](https://bugs.openjdk.java.net/browse/JDK-8272358) ------------- Commit messages: - Backport 29e552c03a2825f9526330072668a1d63ac68fd4 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/292/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=292&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272358 Stats: 9 lines in 4 files changed: 1 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/292.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/292/head:pull/292 PR: https://git.openjdk.java.net/jdk17u-dev/pull/292 From mdoerr at openjdk.java.net Tue Mar 29 12:05:08 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 12:05:08 GMT Subject: [jdk17u-dev] RFR: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL" Message-ID: <4cebzMTFJdwT7VGRU3pb58BPARff3GoEcBHvC6IhbWI=.072858ae-0378-4432-a3f4-14b0eb64b089@github.com> Backport of [JDK-8264605](https://bugs.openjdk.java.net/browse/JDK-8264605) ------------- Commit messages: - Backport 96fe1d0d4d95d87950ff2ecec570a927d831746e Changes: https://git.openjdk.java.net/jdk17u-dev/pull/293/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=293&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264605 Stats: 27 lines in 2 files changed: 5 ins; 15 del; 7 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/293.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/293/head:pull/293 PR: https://git.openjdk.java.net/jdk17u-dev/pull/293 From mdoerr at openjdk.java.net Tue Mar 29 12:19:21 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 12:19:21 GMT Subject: [jdk17u-dev] RFR: 8275337: C1: assert(false) failed: live_in set of first block must be empty Message-ID: Clean backport of [JDK-8275337](https://bugs.openjdk.java.net/browse/JDK-8275337) ------------- Commit messages: - Backport 4191b2b9b98c1137e5f27e3b64efb83857fa2c91 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/294/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=294&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275337 Stats: 71 lines in 2 files changed: 70 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/294.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/294/head:pull/294 PR: https://git.openjdk.java.net/jdk17u-dev/pull/294 From mdoerr at openjdk.java.net Tue Mar 29 12:26:37 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 12:26:37 GMT Subject: [jdk17u-dev] RFR: 8280867: Cpuid1Ecx feature parsing is incorrect for AMD CPUs Message-ID: Clean backport of [JDK-8280867](https://bugs.openjdk.java.net/browse/JDK-8280867) ------------- Commit messages: - Backport a18beb4797a1ca6fc6b31e997be48b2bd91c6ac0 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/295/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=295&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280867 Stats: 9 lines in 1 file changed: 0 ins; 1 del; 8 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/295.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/295/head:pull/295 PR: https://git.openjdk.java.net/jdk17u-dev/pull/295 From mdoerr at openjdk.java.net Tue Mar 29 12:37:47 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 12:37:47 GMT Subject: [jdk17u-dev] RFR: 8279219: [REDO] C2 crash when allocating array of size too large Message-ID: Clean backport of [JDK-8279219](https://bugs.openjdk.java.net/browse/JDK-8279219) ------------- Commit messages: - Backport d32f99ee65679601d6e160e7975fc1e367bfa6f4 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/296/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=296&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279219 Stats: 307 lines in 11 files changed: 231 ins; 53 del; 23 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/296.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/296/head:pull/296 PR: https://git.openjdk.java.net/jdk17u-dev/pull/296 From goetz at openjdk.java.net Tue Mar 29 12:47:39 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 12:47:39 GMT Subject: [jdk11u-dev] RFR: 8266318: Switch to macos prefix for macOS bundles [v2] In-Reply-To: <-FQUEruHm5bgOnOu9PtmmO6W1GCtxzIvCkc8qOot7Sk=.c05f4c1f-f06c-488f-b6ae-046aaada7a97@github.com> References: <-FQUEruHm5bgOnOu9PtmmO6W1GCtxzIvCkc8qOot7Sk=.c05f4c1f-f06c-488f-b6ae-046aaada7a97@github.com> Message-ID: <-opd04UB5VSr_6damS54SxNLa819Nj1xaLFr-W9W-HY=.1a2f491e-34ef-40ef-a16a-0bda0b9f11ae@github.com> > I backport this for parity with 11.0.16-oracle. > > platform.m4: Resolved copyright. > jib-proviles.js: macos-aarch64 not listed. Skipped. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Update jib-profiles.js ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/958/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/958/files/65773b2c..9777fe93 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=958&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=958&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/958.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/958/head:pull/958 PR: https://git.openjdk.java.net/jdk11u-dev/pull/958 From mdoerr at openjdk.java.net Tue Mar 29 12:47:39 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 12:47:39 GMT Subject: [jdk11u-dev] RFR: 8266318: Switch to macos prefix for macOS bundles [v2] In-Reply-To: <-opd04UB5VSr_6damS54SxNLa819Nj1xaLFr-W9W-HY=.1a2f491e-34ef-40ef-a16a-0bda0b9f11ae@github.com> References: <-FQUEruHm5bgOnOu9PtmmO6W1GCtxzIvCkc8qOot7Sk=.c05f4c1f-f06c-488f-b6ae-046aaada7a97@github.com> <-opd04UB5VSr_6damS54SxNLa819Nj1xaLFr-W9W-HY=.1a2f491e-34ef-40ef-a16a-0bda0b9f11ae@github.com> Message-ID: On Tue, 29 Mar 2022 12:43:32 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.16-oracle. >> >> platform.m4: Resolved copyright. >> jib-proviles.js: macos-aarch64 not listed. Skipped. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Update jib-profiles.js LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/958 From goetz at openjdk.java.net Tue Mar 29 12:47:39 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 12:47:39 GMT Subject: [jdk11u-dev] RFR: 8266318: Switch to macos prefix for macOS bundles In-Reply-To: <-FQUEruHm5bgOnOu9PtmmO6W1GCtxzIvCkc8qOot7Sk=.c05f4c1f-f06c-488f-b6ae-046aaada7a97@github.com> References: <-FQUEruHm5bgOnOu9PtmmO6W1GCtxzIvCkc8qOot7Sk=.c05f4c1f-f06c-488f-b6ae-046aaada7a97@github.com> Message-ID: On Tue, 29 Mar 2022 10:21:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > platform.m4: Resolved copyright. > jib-proviles.js: macos-aarch64 not listed. Skipped. Thanks for spotting this! Fixed. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/958 From mdoerr at openjdk.java.net Tue Mar 29 13:05:20 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 13:05:20 GMT Subject: [jdk17u-dev] RFR: 8280600: C2: assert(!had_error) failed: bad dominance Message-ID: <6XjxR1kBUM0Ptgm5rrPUBkNapIUclX8ygY3Ck5KXQrg=.267d12ce-11f7-4017-9c8f-139356159c60@github.com> Clean backport of [JDK-8280600](https://bugs.openjdk.java.net/browse/JDK-8280600) ------------- Commit messages: - Backport de826ba18a5e98586029581c2d4bcd27334fbdd1 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/297/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=297&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280600 Stats: 54 lines in 2 files changed: 53 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/297.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/297/head:pull/297 PR: https://git.openjdk.java.net/jdk17u-dev/pull/297 From mdoerr at openjdk.java.net Tue Mar 29 13:12:40 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 13:12:40 GMT Subject: [jdk17u-dev] RFR: 8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack Message-ID: Clean backport of [JDK-8271055](https://bugs.openjdk.java.net/browse/JDK-8271055) ------------- Commit messages: - Backport e44dc638b8936b1b76ca9ddf9ece0c5c4705a19c Changes: https://git.openjdk.java.net/jdk17u-dev/pull/298/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=298&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271055 Stats: 121 lines in 3 files changed: 120 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/298.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/298/head:pull/298 PR: https://git.openjdk.java.net/jdk17u-dev/pull/298 From mdoerr at openjdk.java.net Tue Mar 29 13:22:13 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 13:22:13 GMT Subject: [jdk17u-dev] RFR: 8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/ Message-ID: Clean backport of [JDK-8281544](https://bugs.openjdk.java.net/browse/JDK-8281544) ------------- Commit messages: - Backport 4e0b81c596f2a2eae49127b9ee98c80500b4e319 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/299/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=299&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281544 Stats: 14 lines in 2 files changed: 12 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/299.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/299/head:pull/299 PR: https://git.openjdk.java.net/jdk17u-dev/pull/299 From mdoerr at openjdk.java.net Tue Mar 29 13:30:20 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 13:30:20 GMT Subject: [jdk17u-dev] RFR: 8280964: [Linux aarch64] : drawImage dithers TYPE_BYTE_INDEXED images incorrectly Message-ID: Clean backport of [JDK-8280964](https://bugs.openjdk.java.net/browse/JDK-8280964) ------------- Commit messages: - Backport 6f882deddcc094777b45f0dacc7351dbc23993a4 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/300/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=300&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280964 Stats: 100 lines in 8 files changed: 83 ins; 0 del; 17 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/300.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/300/head:pull/300 PR: https://git.openjdk.java.net/jdk17u-dev/pull/300 From mdoerr at openjdk.java.net Tue Mar 29 13:37:15 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 13:37:15 GMT Subject: [jdk17u-dev] RFR: 8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers Message-ID: Clean backport of [JDK-8282231](https://bugs.openjdk.java.net/browse/JDK-8282231) ------------- Commit messages: - Backport ecd85e6f0f8906ad1e8aa0a53bf499e8c969ba73 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/301/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=301&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282231 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/301.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/301/head:pull/301 PR: https://git.openjdk.java.net/jdk17u-dev/pull/301 From mbaesken at openjdk.java.net Tue Mar 29 13:38:10 2022 From: mbaesken at openjdk.java.net (Matthias Baesken) Date: Tue, 29 Mar 2022 13:38:10 GMT Subject: [jdk18u] Integrated: 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15 In-Reply-To: References: Message-ID: On Thu, 24 Mar 2022 08:41:20 GMT, Matthias Baesken wrote: > 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15 This pull request has now been integrated. Changeset: bc630f8e Author: Matthias Baesken URL: https://git.openjdk.java.net/jdk18u/commit/bc630f8e82be8659d24897b8f2f82518b8e62c02 Stats: 34 lines in 2 files changed: 32 ins; 0 del; 2 mod 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15 Backport-of: 84976b45315feb6c37a9f3db6e1e62812c9b0a37 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/51 From mdoerr at openjdk.java.net Tue Mar 29 13:40:34 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 13:40:34 GMT Subject: [jdk17u-dev] RFR: 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads Message-ID: Clean backport of [JDK-8282172](https://bugs.openjdk.java.net/browse/JDK-8282172) ------------- Commit messages: - Backport 4e7fb41dafaf03baabe18ee1dabefed50d69e16d Changes: https://git.openjdk.java.net/jdk17u-dev/pull/302/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=302&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282172 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/302.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/302/head:pull/302 PR: https://git.openjdk.java.net/jdk17u-dev/pull/302 From yan at openjdk.java.net Tue Mar 29 13:50:15 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Tue, 29 Mar 2022 13:50:15 GMT Subject: [jdk15u-dev] RFR: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11 Message-ID: Clean backport of "Update IANA Language Subtag Registry to Version 2021-05-11". Waiting for test finish... ------------- Commit messages: - Backport a259ab4a8d163ff924ba56c5da5395cec0d8c350 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/187/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=187&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258795 Stats: 340 lines in 2 files changed: 327 ins; 0 del; 13 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/187.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/187/head:pull/187 PR: https://git.openjdk.java.net/jdk15u-dev/pull/187 From rreddy at openjdk.java.net Tue Mar 29 14:04:10 2022 From: rreddy at openjdk.java.net (Ravi Reddy) Date: Tue, 29 Mar 2022 14:04:10 GMT Subject: [jdk18u] Integrated: 8278794: Infinite loop in DeflaterOutputStream.finish() In-Reply-To: References: Message-ID: <3YGjXap_vsRLEZmaGq__9i3PI0qoQIp1JVASGOefkAw=.8f8a2c97-b3c3-4ea9-9411-a451ed14fd4a@github.com> On Fri, 25 Mar 2022 10:18:46 GMT, Ravi Reddy wrote: > Clean backport of https://github.com/openjdk/jdk/commit/ff0b0927a2df8b36f8fd6ed41bd4e20e71a5b653 to jdk18u. This pull request has now been integrated. Changeset: 9327634e Author: Ravi Reddy Committer: Sean Coffey URL: https://git.openjdk.java.net/jdk18u/commit/9327634e982314733f4126a1106be8e452f19f58 Stats: 378 lines in 5 files changed: 224 ins; 147 del; 7 mod 8278794: Infinite loop in DeflaterOutputStream.finish() Backport-of: ff0b0927a2df8b36f8fd6ed41bd4e20e71a5b653 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/53 From mdoerr at openjdk.java.net Tue Mar 29 14:04:14 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 14:04:14 GMT Subject: [jdk17u-dev] RFR: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics Message-ID: Clean backport of [JDK-8277055](https://bugs.openjdk.java.net/browse/JDK-8277055) ------------- Commit messages: - Backport b1f935c1d0d3729470b57832cf74c43d49ea1f71 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/303/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=303&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277055 Stats: 14 lines in 2 files changed: 11 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/303.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/303/head:pull/303 PR: https://git.openjdk.java.net/jdk17u-dev/pull/303 From mdoerr at openjdk.java.net Tue Mar 29 14:06:38 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 14:06:38 GMT Subject: [jdk17u-dev] RFR: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86 Message-ID: Clean backport of [JDK-8282312](https://bugs.openjdk.java.net/browse/JDK-8282312) ------------- Commit messages: - Backport 8b45dbdae6e5dee85ef65ce25850ce692ad3e965 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/304/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=304&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282312 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/304.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/304/head:pull/304 PR: https://git.openjdk.java.net/jdk17u-dev/pull/304 From mdoerr at openjdk.java.net Tue Mar 29 14:12:26 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 14:12:26 GMT Subject: [jdk17u-dev] RFR: 8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2 Message-ID: Clean backport of [JDK-8272493](https://bugs.openjdk.java.net/browse/JDK-8272493) ------------- Commit messages: - Backport 88f0938c943bfacf748ddb0588a301c2cf7e941e Changes: https://git.openjdk.java.net/jdk17u-dev/pull/305/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=305&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272493 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/305.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/305/head:pull/305 PR: https://git.openjdk.java.net/jdk17u-dev/pull/305 From mdoerr at openjdk.java.net Tue Mar 29 14:16:55 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 14:16:55 GMT Subject: [jdk17u-dev] RFR: 8271302: Regex Test Refresh In-Reply-To: <0z0ouP83yOSqUBliWJHIglFqF4iQa8wrNrCl7VPu4wk=.aed35833-04e5-4c7b-a509-629800d5856a@github.com> References: <0z0ouP83yOSqUBliWJHIglFqF4iQa8wrNrCl7VPu4wk=.aed35833-04e5-4c7b-a509-629800d5856a@github.com> Message-ID: On Tue, 29 Mar 2022 09:56:50 GMT, Martin Doerr wrote: > Clean backport of [JDK-8271302](https://bugs.openjdk.java.net/browse/JDK-8271302) Note: x86_32 needs https://github.com/openjdk/jdk17u-dev/pull/291 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/290 From mdoerr at openjdk.java.net Tue Mar 29 14:22:23 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 14:22:23 GMT Subject: [jdk17u-dev] RFR: 8283408: Fix a C2 crash when filling arrays with unsafe Message-ID: Clean backport of [JDK-8283408](https://bugs.openjdk.java.net/browse/JDK-8283408) ------------- Commit messages: - Backport a6740c010b7d37f991c8547be6ea72b198e9094f Changes: https://git.openjdk.java.net/jdk17u-dev/pull/306/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=306&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283408 Stats: 75 lines in 2 files changed: 72 ins; 2 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/306.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/306/head:pull/306 PR: https://git.openjdk.java.net/jdk17u-dev/pull/306 From yan at openjdk.java.net Tue Mar 29 14:25:21 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Tue, 29 Mar 2022 14:25:21 GMT Subject: [jdk13u-dev] RFR: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11 Message-ID: Clean backport of the 2021 IANA update. ------------- Commit messages: - Backport a259ab4a8d163ff924ba56c5da5395cec0d8c350 Changes: https://git.openjdk.java.net/jdk13u-dev/pull/332/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk13u-dev&pr=332&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258795 Stats: 340 lines in 2 files changed: 327 ins; 0 del; 13 mod Patch: https://git.openjdk.java.net/jdk13u-dev/pull/332.diff Fetch: git fetch https://git.openjdk.java.net/jdk13u-dev pull/332/head:pull/332 PR: https://git.openjdk.java.net/jdk13u-dev/pull/332 From goetz at openjdk.java.net Tue Mar 29 14:54:28 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 14:54:28 GMT Subject: [jdk11u-dev] RFR: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 1668c02ee83cc4f7bd7b2fe5bb7ef59b5dbda081 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/959/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=959&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277922 Stats: 212 lines in 2 files changed: 211 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/959.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/959/head:pull/959 PR: https://git.openjdk.java.net/jdk11u-dev/pull/959 From duke at openjdk.java.net Tue Mar 29 14:59:13 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Tue, 29 Mar 2022 14:59:13 GMT Subject: [jdk11u-dev] RFR: 8235385: Crash on aarch64 JDK due to long offset Message-ID: Hi! Please review "backport" of the [Wang Zhuo's patch](http://cr.openjdk.java.net/~wzhuo/BigOffsetAarch64/webrev.00/jdk13u.patch) to 11u-dev. The patch is applied with the following adaptation: - the legitimizing overload static void loadStore(MacroAssembler masm, mem_insn insn, Register reg, int opcode, Register base, int index, int size, int disp, int size_in_memory); ported from 15u-dev with slight changes - `aarch64_enc_strh`, `aarch64_enc_strh0`, `aarch64_enc_strw`, `aarch64_enc_strw0`, `aarch64_enc_str`, and `aarch64_enc_str0` functions updated to use new loadStore() overload Verified (18.04.6 LTS / aarch64 ) with the reproducers JBS, 10 of 10 runs passed. Aproximately a half of runs crashed before I've applied the patch. Regression (18.04.6 LTS / aarch64 ): hotspot_compilers @theRealAph @AntonKozlov please take a look at that. Andrew, I could not mention Wang, if you know his login could you mention him as well. Thank you ------------- Commit messages: - 8235385: Crash on aarch64 JDK due to long offset - 8235385: Crash on aarch64 JDK due to long offset Changes: https://git.openjdk.java.net/jdk11u-dev/pull/960/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=960&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8235385 Stats: 44 lines in 1 file changed: 38 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/960.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/960/head:pull/960 PR: https://git.openjdk.java.net/jdk11u-dev/pull/960 From thartmann at openjdk.java.net Tue Mar 29 15:05:32 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:05:32 GMT Subject: [jdk18u] RFR: 8275337: C1: assert(false) failed: live_in set of first block must be empty Message-ID: Backport of [JDK-8275337](https://bugs.openjdk.java.net/browse/JDK-8275337). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8275337: C1: assert(false) failed: live_in set of first block must be empty Changes: https://git.openjdk.java.net/jdk18u/pull/57/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=57&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275337 Stats: 71 lines in 2 files changed: 70 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk18u/pull/57.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/57/head:pull/57 PR: https://git.openjdk.java.net/jdk18u/pull/57 From thartmann at openjdk.java.net Tue Mar 29 15:12:31 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:12:31 GMT Subject: [jdk18u] RFR: 8283408: Fix a C2 crash when filling arrays with unsafe Message-ID: Backport of [JDK-8283408](https://bugs.openjdk.java.net/browse/JDK-8283408). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8283408: Fix a C2 crash when filling arrays with unsafe Changes: https://git.openjdk.java.net/jdk18u/pull/58/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=58&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283408 Stats: 75 lines in 2 files changed: 72 ins; 2 del; 1 mod Patch: https://git.openjdk.java.net/jdk18u/pull/58.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/58/head:pull/58 PR: https://git.openjdk.java.net/jdk18u/pull/58 From thartmann at openjdk.java.net Tue Mar 29 15:15:24 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:15:24 GMT Subject: [jdk18u] RFR: 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes Message-ID: Backport of [JDK-8282590](https://bugs.openjdk.java.net/browse/JDK-8282590). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes Changes: https://git.openjdk.java.net/jdk18u/pull/59/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=59&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282590 Stats: 39 lines in 3 files changed: 30 ins; 4 del; 5 mod Patch: https://git.openjdk.java.net/jdk18u/pull/59.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/59/head:pull/59 PR: https://git.openjdk.java.net/jdk18u/pull/59 From thartmann at openjdk.java.net Tue Mar 29 15:16:48 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:16:48 GMT Subject: [jdk18u] RFR: 8283451: C2: assert(_base == Long) failed: Not a Long Message-ID: Backport of [JDK-8283451](https://bugs.openjdk.java.net/browse/JDK-8283451). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8283451: C2: assert(_base == Long) failed: Not a Long Changes: https://git.openjdk.java.net/jdk18u/pull/60/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=60&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283451 Stats: 80 lines in 2 files changed: 78 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/60.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/60/head:pull/60 PR: https://git.openjdk.java.net/jdk18u/pull/60 From thartmann at openjdk.java.net Tue Mar 29 15:18:12 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:18:12 GMT Subject: [jdk18u] RFR: 8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2 Message-ID: Backport of [JDK-8272493](https://bugs.openjdk.java.net/browse/JDK-8272493). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2 Changes: https://git.openjdk.java.net/jdk18u/pull/61/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=61&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272493 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/61.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/61/head:pull/61 PR: https://git.openjdk.java.net/jdk18u/pull/61 From thartmann at openjdk.java.net Tue Mar 29 15:18:28 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:18:28 GMT Subject: [jdk18u] RFR: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86 Message-ID: <2hBZ6SuuLBR3h0-WABK0__J2BgJI3uQvYRzQzsjRQQs=.6df0b046-91f0-4445-90ce-9ce2d3522b11@github.com> Backport of [JDK-8282312](https://bugs.openjdk.java.net/browse/JDK-8282312). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86 Changes: https://git.openjdk.java.net/jdk18u/pull/62/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=62&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282312 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/62.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/62/head:pull/62 PR: https://git.openjdk.java.net/jdk18u/pull/62 From thartmann at openjdk.java.net Tue Mar 29 15:22:29 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:22:29 GMT Subject: [jdk18u] RFR: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics Message-ID: Backport of [JDK-8277055](https://bugs.openjdk.java.net/browse/JDK-8277055). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics Changes: https://git.openjdk.java.net/jdk18u/pull/63/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=63&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277055 Stats: 14 lines in 2 files changed: 11 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk18u/pull/63.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/63/head:pull/63 PR: https://git.openjdk.java.net/jdk18u/pull/63 From thartmann at openjdk.java.net Tue Mar 29 15:26:18 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:26:18 GMT Subject: [jdk18u] RFR: 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads Message-ID: <1iUGDSH_jo3avmmpd6Z7qb2-1YPpGtwslDJ-VDOtZOI=.97181818-75cb-4d9a-8efb-dcf905610fda@github.com> Backport of [JDK-8282172](https://bugs.openjdk.java.net/browse/JDK-8282172). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads Changes: https://git.openjdk.java.net/jdk18u/pull/64/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=64&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282172 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk18u/pull/64.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/64/head:pull/64 PR: https://git.openjdk.java.net/jdk18u/pull/64 From thartmann at openjdk.java.net Tue Mar 29 15:27:18 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:27:18 GMT Subject: [jdk18u] RFR: 8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers Message-ID: Backport of [JDK-8282231](https://bugs.openjdk.java.net/browse/JDK-8282231). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers Changes: https://git.openjdk.java.net/jdk18u/pull/65/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=65&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282231 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk18u/pull/65.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/65/head:pull/65 PR: https://git.openjdk.java.net/jdk18u/pull/65 From thartmann at openjdk.java.net Tue Mar 29 15:31:23 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:31:23 GMT Subject: [jdk18u] RFR: 8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack Message-ID: Backport of [JDK-8271055](https://bugs.openjdk.java.net/browse/JDK-8271055). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack Changes: https://git.openjdk.java.net/jdk18u/pull/67/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=67&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271055 Stats: 121 lines in 3 files changed: 120 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk18u/pull/67.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/67/head:pull/67 PR: https://git.openjdk.java.net/jdk18u/pull/67 From thartmann at openjdk.java.net Tue Mar 29 15:32:23 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:32:23 GMT Subject: [jdk18u] RFR: 8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/ Message-ID: Backport of [JDK-8281544](https://bugs.openjdk.java.net/browse/JDK-8281544). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/ Changes: https://git.openjdk.java.net/jdk18u/pull/66/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=66&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281544 Stats: 14 lines in 2 files changed: 12 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/66.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/66/head:pull/66 PR: https://git.openjdk.java.net/jdk18u/pull/66 From thartmann at openjdk.java.net Tue Mar 29 15:35:10 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:35:10 GMT Subject: [jdk18u] RFR: 8280600: C2: assert(!had_error) failed: bad dominance Message-ID: Backport of [JDK-8280600](https://bugs.openjdk.java.net/browse/JDK-8280600). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8280600: C2: assert(!had_error) failed: bad dominance Changes: https://git.openjdk.java.net/jdk18u/pull/68/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=68&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280600 Stats: 54 lines in 2 files changed: 53 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk18u/pull/68.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/68/head:pull/68 PR: https://git.openjdk.java.net/jdk18u/pull/68 From thartmann at openjdk.java.net Tue Mar 29 15:36:19 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:36:19 GMT Subject: [jdk18u] RFR: 8279219: [REDO] C2 crash when allocating array of size too large Message-ID: Backport of [JDK-8279219](https://bugs.openjdk.java.net/browse/JDK-8279219). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8279219: [REDO] C2 crash when allocating array of size too large Changes: https://git.openjdk.java.net/jdk18u/pull/69/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=69&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279219 Stats: 307 lines in 11 files changed: 231 ins; 53 del; 23 mod Patch: https://git.openjdk.java.net/jdk18u/pull/69.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/69/head:pull/69 PR: https://git.openjdk.java.net/jdk18u/pull/69 From thartmann at openjdk.java.net Tue Mar 29 15:38:21 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:38:21 GMT Subject: [jdk18u] RFR: 8280867: Cpuid1Ecx feature parsing is incorrect for AMD CPUs Message-ID: Backport of [JDK-8280867](https://bugs.openjdk.java.net/browse/JDK-8280867). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8280867: Cpuid1Ecx feature parsing is incorrect for AMD CPUs Changes: https://git.openjdk.java.net/jdk18u/pull/70/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=70&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280867 Stats: 9 lines in 1 file changed: 0 ins; 1 del; 8 mod Patch: https://git.openjdk.java.net/jdk18u/pull/70.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/70/head:pull/70 PR: https://git.openjdk.java.net/jdk18u/pull/70 From thartmann at openjdk.java.net Tue Mar 29 15:40:23 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 15:40:23 GMT Subject: [jdk18u] RFR: 8280901: MethodHandle::linkToNative stub is missing w/ -Xint Message-ID: Backport of [JDK-8280901](https://bugs.openjdk.java.net/browse/JDK-8280901). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8280901: MethodHandle::linkToNative stub is missing w/ -Xint Changes: https://git.openjdk.java.net/jdk18u/pull/71/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=71&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280901 Stats: 6 lines in 2 files changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk18u/pull/71.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/71/head:pull/71 PR: https://git.openjdk.java.net/jdk18u/pull/71 From thartmann at openjdk.java.net Tue Mar 29 16:03:15 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 16:03:15 GMT Subject: [jdk18u] RFR: 8282874: Bad performance on gather/scatter API caused by different IntSpecies of indexMap Message-ID: Backport of [JDK-8282874](https://bugs.openjdk.java.net/browse/JDK-8282874). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8282874: Bad performance on gather/scatter API caused by different IntSpecies of indexMap Changes: https://git.openjdk.java.net/jdk18u/pull/72/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=72&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282874 Stats: 42 lines in 7 files changed: 0 ins; 0 del; 42 mod Patch: https://git.openjdk.java.net/jdk18u/pull/72.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/72/head:pull/72 PR: https://git.openjdk.java.net/jdk18u/pull/72 From thartmann at openjdk.java.net Tue Mar 29 16:05:12 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 16:05:12 GMT Subject: [jdk18u] RFR: 8283641: Large value for CompileThresholdScaling causes assert Message-ID: Backport of [JDK-8283641](https://bugs.openjdk.java.net/browse/JDK-8283641). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8283641: Large value for CompileThresholdScaling causes assert Changes: https://git.openjdk.java.net/jdk18u/pull/73/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=73&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283641 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk18u/pull/73.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/73/head:pull/73 PR: https://git.openjdk.java.net/jdk18u/pull/73 From thartmann at openjdk.java.net Tue Mar 29 16:07:31 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Tue, 29 Mar 2022 16:07:31 GMT Subject: [jdk18u] RFR: 8280799: =?UTF-8?B?0KEyOg==?= assert(false) failed: cyclic dependency prevents range check elimination Message-ID: <5c9Ur8AUcsgua3jnZ89nAoY2nqKIsGItqIxIPIri2_E=.f4d5edfe-22fa-49f5-b382-ebfc81d34c69@github.com> Backport of [JDK-8280799](https://bugs.openjdk.java.net/browse/JDK-8280799). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8280799: ?2: assert(false) failed: cyclic dependency prevents range check elimination Changes: https://git.openjdk.java.net/jdk18u/pull/74/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=74&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280799 Stats: 340 lines in 3 files changed: 314 ins; 21 del; 5 mod Patch: https://git.openjdk.java.net/jdk18u/pull/74.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/74/head:pull/74 PR: https://git.openjdk.java.net/jdk18u/pull/74 From hseigel at openjdk.java.net Tue Mar 29 16:43:08 2022 From: hseigel at openjdk.java.net (Harold Seigel) Date: Tue, 29 Mar 2022 16:43:08 GMT Subject: [jdk18u] Integrated: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info Message-ID: <-UlwhZ6OW6ulnA2_i8UV_za8pux-lK4g6LDrRKq6wz4=.abfaa428-f3cf-4d35-b54f-37883ab1fd26@github.com> Backport of the fix for JDK-82821274 to JDK-18u. The patch applied cleanly and was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows and Mach5 tiers 3-5 on Linux x64. Harold ------------- Commit messages: - Backport bb2e10ccea0c0b89b06ace034c99253e9999ec47 Changes: https://git.openjdk.java.net/jdk18u/pull/75/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=75&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281274 Stats: 16 lines in 2 files changed: 14 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/75.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/75/head:pull/75 PR: https://git.openjdk.java.net/jdk18u/pull/75 From hseigel at openjdk.java.net Tue Mar 29 16:43:09 2022 From: hseigel at openjdk.java.net (Harold Seigel) Date: Tue, 29 Mar 2022 16:43:09 GMT Subject: [jdk18u] Integrated: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info In-Reply-To: <-UlwhZ6OW6ulnA2_i8UV_za8pux-lK4g6LDrRKq6wz4=.abfaa428-f3cf-4d35-b54f-37883ab1fd26@github.com> References: <-UlwhZ6OW6ulnA2_i8UV_za8pux-lK4g6LDrRKq6wz4=.abfaa428-f3cf-4d35-b54f-37883ab1fd26@github.com> Message-ID: On Tue, 29 Mar 2022 16:32:50 GMT, Harold Seigel wrote: > Backport of the fix for JDK-82821274 to JDK-18u. The patch applied cleanly and was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows and Mach5 tiers 3-5 on Linux x64. > Harold This pull request has now been integrated. Changeset: e6425305 Author: Harold Seigel URL: https://git.openjdk.java.net/jdk18u/commit/e6425305df33763cbd2cc0afdf57d7801ccd636d Stats: 16 lines in 2 files changed: 14 ins; 0 del; 2 mod 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info Backport-of: bb2e10ccea0c0b89b06ace034c99253e9999ec47 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/75 From hseigel at openjdk.java.net Tue Mar 29 16:49:13 2022 From: hseigel at openjdk.java.net (Harold Seigel) Date: Tue, 29 Mar 2022 16:49:13 GMT Subject: [jdk18u] Integrated: 8281771: Crash in java_lang_invoke_MethodType::print_signature Message-ID: Backport of fix for JDK-8281771 to JDK-18u. The patch applied cleanly and was tested with Mach5 tiers 1-2 and by running the crashing test locally. Harold ------------- Commit messages: - Backport a24498b777b76c04d7e6da0a8b5fb501f2fb4944 Changes: https://git.openjdk.java.net/jdk18u/pull/76/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=76&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281771 Stats: 13 lines in 1 file changed: 9 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk18u/pull/76.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/76/head:pull/76 PR: https://git.openjdk.java.net/jdk18u/pull/76 From hseigel at openjdk.java.net Tue Mar 29 16:49:13 2022 From: hseigel at openjdk.java.net (Harold Seigel) Date: Tue, 29 Mar 2022 16:49:13 GMT Subject: [jdk18u] Integrated: 8281771: Crash in java_lang_invoke_MethodType::print_signature In-Reply-To: References: Message-ID: <9JN8hRP6dGbFs7Jqr1SLmTonufVG63K_LOIK_Faq6L4=.d49a6754-2b61-455d-9a61-a8735e275824@github.com> On Tue, 29 Mar 2022 16:39:31 GMT, Harold Seigel wrote: > Backport of fix for JDK-8281771 to JDK-18u. The patch applied cleanly and was tested with Mach5 tiers 1-2 and by running the crashing test locally. > > Harold This pull request has now been integrated. Changeset: 3d289c14 Author: Harold Seigel URL: https://git.openjdk.java.net/jdk18u/commit/3d289c14e8b728eb422f0006be302e69cde1c48d Stats: 13 lines in 1 file changed: 9 ins; 0 del; 4 mod 8281771: Crash in java_lang_invoke_MethodType::print_signature Backport-of: a24498b777b76c04d7e6da0a8b5fb501f2fb4944 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/76 From hseigel at openjdk.java.net Tue Mar 29 16:56:18 2022 From: hseigel at openjdk.java.net (Harold Seigel) Date: Tue, 29 Mar 2022 16:56:18 GMT Subject: [jdk18u] Integrated: 8278381: [GCC 11] Address::make_raw() does not initialize rspec Message-ID: Backport of fix for JDK-8273881 to JDK-18u. The patch applied cleanly and was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows. Harold ------------- Commit messages: - Backport 4f594e6a28ad85d46d3252fb960f1c116f414899 Changes: https://git.openjdk.java.net/jdk18u/pull/77/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=77&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278381 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18u/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/77/head:pull/77 PR: https://git.openjdk.java.net/jdk18u/pull/77 From hseigel at openjdk.java.net Tue Mar 29 16:56:19 2022 From: hseigel at openjdk.java.net (Harold Seigel) Date: Tue, 29 Mar 2022 16:56:19 GMT Subject: [jdk18u] Integrated: 8278381: [GCC 11] Address::make_raw() does not initialize rspec In-Reply-To: References: Message-ID: <3FrzSUbXFeT6rhtVh5N72_1fhtm0HQaYjlowVv8MtPc=.f3dab4a0-7c27-4c55-a441-2e02c65a8feb@github.com> On Tue, 29 Mar 2022 16:46:28 GMT, Harold Seigel wrote: > Backport of fix for JDK-8273881 to JDK-18u. The patch applied cleanly and was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows. > > Harold This pull request has now been integrated. Changeset: 4b0818c9 Author: Harold Seigel URL: https://git.openjdk.java.net/jdk18u/commit/4b0818c934eedfab7ef2edd9552bdccb24eabb04 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8278381: [GCC 11] Address::make_raw() does not initialize rspec Backport-of: 4f594e6a28ad85d46d3252fb960f1c116f414899 ------------- PR: https://git.openjdk.java.net/jdk18u/pull/77 From tschatzl at openjdk.java.net Tue Mar 29 17:58:57 2022 From: tschatzl at openjdk.java.net (Thomas Schatzl) Date: Tue, 29 Mar 2022 17:58:57 GMT Subject: [jdk18u] Integrated: 8283555: G1: Concurrent mark accesses uninitialized BOT of closed archive regions In-Reply-To: <6PIxT0KaQ1u2H7I54YPzWHSR1TQE_ra5GcrFdb8FimA=.ff25a8df-88e0-4ee7-854d-0b2dea90e2b2@github.com> References: <6PIxT0KaQ1u2H7I54YPzWHSR1TQE_ra5GcrFdb8FimA=.ff25a8df-88e0-4ee7-854d-0b2dea90e2b2@github.com> Message-ID: On Fri, 25 Mar 2022 10:43:12 GMT, Thomas Schatzl wrote: > Please review this backport of [JDK-8283555](https://bugs.openjdk.java.net/browse/JDK-8283555) G1: Concurrent mark accesses uninitialized BOT of closed archive regions which removes a potential crash. > > Applies cleanly. > > Testing: gha, jdk19 ci > > Thanks, > Thomas This pull request has now been integrated. Changeset: 9f39b4bf Author: Thomas Schatzl URL: https://git.openjdk.java.net/jdk18u/commit/9f39b4bf33826ed6524a50dc5e6b0f085b3836ff Stats: 10 lines in 1 file changed: 5 ins; 5 del; 0 mod 8283555: G1: Concurrent mark accesses uninitialized BOT of closed archive regions Backport-of: 19f01ab70133d244422684f63f118249178bce4a ------------- PR: https://git.openjdk.java.net/jdk18u/pull/54 From goetz at openjdk.java.net Tue Mar 29 20:14:13 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 20:14:13 GMT Subject: [jdk11u-dev] RFR: 8253872: ArgumentHandler must use the same delimiters as in jvmti_tools.cpp Message-ID: <2HFfeSChIjwH4zXCZ2-21bh7GlJXJAR_Vf_vBE3jams=.97bd82fa-0f31-435d-a0b6-22ab81eb7fc1@github.com> I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport 4b16f8ab942b08b249abfe6f95c4ded3ef139ef0 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/961/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=961&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253872 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/961.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/961/head:pull/961 PR: https://git.openjdk.java.net/jdk11u-dev/pull/961 From goetz at openjdk.java.net Tue Mar 29 20:14:17 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 20:14:17 GMT Subject: [jdk11u-dev] RFR: 8247614: java/nio/channels/DatagramChannel/Connect.java timed out Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport ea26ff1142b6b7413f01d83375ff3be8a3ab3e74 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/962/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=962&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8247614 Stats: 109 lines in 1 file changed: 40 ins; 34 del; 35 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/962.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/962/head:pull/962 PR: https://git.openjdk.java.net/jdk11u-dev/pull/962 From goetz at openjdk.java.net Tue Mar 29 20:29:12 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Tue, 29 Mar 2022 20:29:12 GMT Subject: [jdk11u-dev] RFR: 8270797: ShortECDSA.java test is not complete Message-ID: I backport this for parity with 11.0.16-oracle. I had to fix the call to HexFormat in one place. That class is not in 11. Similar fix has been made before to the same test. ------------- Commit messages: - Backport 221e4b9c61cd1c9c3f4c037589ba639541532910 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/963/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=963&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270797 Stats: 19 lines in 1 file changed: 18 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/963.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/963/head:pull/963 PR: https://git.openjdk.java.net/jdk11u-dev/pull/963 From mdoerr at openjdk.java.net Tue Mar 29 22:46:38 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Tue, 29 Mar 2022 22:46:38 GMT Subject: [jdk11u-dev] RFR: 8270797: ShortECDSA.java test is not complete In-Reply-To: References: Message-ID: <-2r-OaIBlPe3e8hec1joUW8Vz8uQNeZHj7XhThv7_j4=.ac7a411b-0575-46f8-8751-e8496acecd3d@github.com> On Tue, 29 Mar 2022 20:21:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. > > I had to fix the call to HexFormat in one place. That class is not in 11. > Similar fix has been made before to the same test. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/963 From iklam at openjdk.java.net Tue Mar 29 23:12:29 2022 From: iklam at openjdk.java.net (Ioi Lam) Date: Tue, 29 Mar 2022 23:12:29 GMT Subject: [jdk18u] RFR: 8281181: Do not use CPU Shares to compute active processor count Message-ID: Please review this backport of [JDK-8281181](https://bugs.openjdk.java.net/browse/JDK-8281181) to jdk18u. Most changes were cleanly applied, except: - The changes in related to the deprecation of `UseContainerCpuShares` and `PreferContainerQuotaForCPUCount`) have been dropped. That's because the deprecation happens in the JDK 19 release cycle, not in 18u. You can compare with the JDK 19 version of the changes [here](https://github.com/openjdk/jdk/pull/7666/files). Tested with tiers 1-5, including all container test tasks. ------------- Commit messages: - reverted changes to PreferContainerQuotaForCPUCount - 8281181: Do not use CPU Shares to compute active processor count Changes: https://git.openjdk.java.net/jdk18u/pull/78/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=78&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281181 Stats: 43 lines in 4 files changed: 28 ins; 0 del; 15 mod Patch: https://git.openjdk.java.net/jdk18u/pull/78.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/78/head:pull/78 PR: https://git.openjdk.java.net/jdk18u/pull/78 From andrew at openjdk.java.net Wed Mar 30 03:30:23 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Wed, 30 Mar 2022 03:30:23 GMT Subject: [jdk17u-dev] RFR: 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4 Message-ID: DEFAULT_PROMOTED_VERSION_PRE has not been reset to 'ea' for either the 17.0.3 or 17.0.4 development cycles. While the value is not used by `configure`, we have started to rely on this value ourselves to detect if the source is for an early access (EA) or general access (GA) build, so it would be helpful if the value in the sources was accurate. This change would need to be reverted just before the `-ga` tag. ------------- Commit messages: - 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/307/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=307&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283911 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/307.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/307/head:pull/307 PR: https://git.openjdk.java.net/jdk17u-dev/pull/307 From dholmes at openjdk.java.net Wed Mar 30 05:00:42 2022 From: dholmes at openjdk.java.net (David Holmes) Date: Wed, 30 Mar 2022 05:00:42 GMT Subject: [jdk18u] RFR: 8281181: Do not use CPU Shares to compute active processor count In-Reply-To: References: Message-ID: <_VeqRUkJ0B31ktt8DBWoLU8Fvy-aKejXHZQCGAivyDQ=.a38db305-e4dd-4e1e-a4e1-9d5062844346@github.com> On Tue, 29 Mar 2022 22:42:45 GMT, Ioi Lam wrote: > Please review this backport of [JDK-8281181](https://bugs.openjdk.java.net/browse/JDK-8281181) to jdk18u. Most changes were cleanly applied, except: > > - The changes in related to the deprecation of `UseContainerCpuShares` and `PreferContainerQuotaForCPUCount`) have been dropped. That's because the deprecation happens in the JDK 19 release cycle, not in 18u. > > You can compare with the JDK 19 version of the changes [here](https://github.com/openjdk/jdk/pull/7666/files). > > Tested with tiers 1-5, including all container test tasks. Looks good! Thanks, David ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk18u/pull/78 From iklam at openjdk.java.net Wed Mar 30 05:30:57 2022 From: iklam at openjdk.java.net (Ioi Lam) Date: Wed, 30 Mar 2022 05:30:57 GMT Subject: [jdk18u] RFR: 8281181: Do not use CPU Shares to compute active processor count In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 22:42:45 GMT, Ioi Lam wrote: > Please review this backport of [JDK-8281181](https://bugs.openjdk.java.net/browse/JDK-8281181) to jdk18u. Most changes were cleanly applied, except: > > - The changes in related to the deprecation of `UseContainerCpuShares` and `PreferContainerQuotaForCPUCount`) have been dropped. That's because the deprecation happens in the JDK 19 release cycle, not in 18u. > > You can compare with the JDK 19 version of the changes [here](https://github.com/openjdk/jdk/pull/7666/files). > > Tested with tiers 1-5, including all container test tasks. I created this PR without following the proper process: https://wiki.openjdk.java.net/display/SKARA/Backports So I am abandoning this PR and will create a new one. ------------- PR: https://git.openjdk.java.net/jdk18u/pull/78 From iklam at openjdk.java.net Wed Mar 30 05:30:58 2022 From: iklam at openjdk.java.net (Ioi Lam) Date: Wed, 30 Mar 2022 05:30:58 GMT Subject: [jdk18u] Withdrawn: 8281181: Do not use CPU Shares to compute active processor count In-Reply-To: References: Message-ID: <1-BGgm8Qoq-X0CqnpawubiAIdort6aioAF-NyWFjjTc=.bdacbb17-7f43-44a1-bb0e-48fee88a7343@github.com> On Tue, 29 Mar 2022 22:42:45 GMT, Ioi Lam wrote: > Please review this backport of [JDK-8281181](https://bugs.openjdk.java.net/browse/JDK-8281181) to jdk18u. Most changes were cleanly applied, except: > > - The changes in related to the deprecation of `UseContainerCpuShares` and `PreferContainerQuotaForCPUCount`) have been dropped. That's because the deprecation happens in the JDK 19 release cycle, not in 18u. > > You can compare with the JDK 19 version of the changes [here](https://github.com/openjdk/jdk/pull/7666/files). > > Tested with tiers 1-5, including all container test tasks. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jdk18u/pull/78 From iklam at openjdk.java.net Wed Mar 30 05:37:23 2022 From: iklam at openjdk.java.net (Ioi Lam) Date: Wed, 30 Mar 2022 05:37:23 GMT Subject: [jdk18u] RFR: 8281181: Do not use CPU Shares to compute active processor count Message-ID: Please review this backport of [JDK-8281181](https://bugs.openjdk.java.net/browse/JDK-8281181) to jdk18u. Most changes were cleanly applied, except: - The changes in related to the deprecation of UseContainerCpuShares and PreferContainerQuotaForCPUCount) have been dropped. That's because the deprecation happens in the JDK 19 release cycle, not in 18u. You can compare with the JDK 19 version of the changes [here](https://github.com/openjdk/jdk/pull/7666/files). Tested with tiers 1-5, including all container test tasks. ------------- Commit messages: - Backport e07fd395bdc314867886a621ec76cf74a5f76b89 Changes: https://git.openjdk.java.net/jdk18u/pull/79/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=79&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281181 Stats: 43 lines in 4 files changed: 28 ins; 0 del; 15 mod Patch: https://git.openjdk.java.net/jdk18u/pull/79.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/79/head:pull/79 PR: https://git.openjdk.java.net/jdk18u/pull/79 From dholmes at openjdk.java.net Wed Mar 30 05:37:23 2022 From: dholmes at openjdk.java.net (David Holmes) Date: Wed, 30 Mar 2022 05:37:23 GMT Subject: [jdk18u] RFR: 8281181: Do not use CPU Shares to compute active processor count In-Reply-To: References: Message-ID: On Wed, 30 Mar 2022 05:24:13 GMT, Ioi Lam wrote: > Please review this backport of [JDK-8281181](https://bugs.openjdk.java.net/browse/JDK-8281181) to jdk18u. Most changes were cleanly applied, except: > > - The changes in related to the deprecation of UseContainerCpuShares and PreferContainerQuotaForCPUCount) have been dropped. That's because the deprecation happens in the JDK 19 release cycle, not in 18u. > > You can compare with the JDK 19 version of the changes [here](https://github.com/openjdk/jdk/pull/7666/files). > > Tested with tiers 1-5, including all container test tasks. Looks good! Thanks, David ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk18u/pull/79 From thartmann at openjdk.java.net Wed Mar 30 05:51:25 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 30 Mar 2022 05:51:25 GMT Subject: [jdk18u] RFR: 8282592: C2: assert(false) failed: graph should be schedulable Message-ID: <8TvZARob81eZA4wsIDkGj_r1elXIDr95VDI6cM-0acs=.35197436-cf4d-4b64-9cd5-04dbdf366c4e@github.com> Backport of [JDK-8282592](https://bugs.openjdk.java.net/browse/JDK-8282592). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8282592: C2: assert(false) failed: graph should be schedulable Changes: https://git.openjdk.java.net/jdk18u/pull/80/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=80&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282592 Stats: 86 lines in 3 files changed: 86 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18u/pull/80.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/80/head:pull/80 PR: https://git.openjdk.java.net/jdk18u/pull/80 From thartmann at openjdk.java.net Wed Mar 30 05:53:25 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 30 Mar 2022 05:53:25 GMT Subject: [jdk18u] RFR: 8271008: appcds/*/MethodHandlesAsCollectorTest.java tests time out because of excessive GC (CodeCache GC Threshold) in loom Message-ID: Backport of [JDK-8271008](https://bugs.openjdk.java.net/browse/JDK-8271008). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8271008: appcds/*/MethodHandlesAsCollectorTest.java tests time out because of excessive GC (CodeCache GC Threshold) in loom Changes: https://git.openjdk.java.net/jdk18u/pull/81/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=81&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271008 Stats: 36 lines in 5 files changed: 6 ins; 10 del; 20 mod Patch: https://git.openjdk.java.net/jdk18u/pull/81.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/81/head:pull/81 PR: https://git.openjdk.java.net/jdk18u/pull/81 From avoitylov at openjdk.java.net Wed Mar 30 05:55:34 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Wed, 30 Mar 2022 05:55:34 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v4] In-Reply-To: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> Message-ID: > JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Original changeset does not apply cleanly because of: > > 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, > 8215445: Enable building for Windows in WSL > 8257913: Add more known library locations to simplify Linux cross-compilation > 8244592: Start supporting SOURCE_DATE_EPOCH > 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html Aleksei Voitylov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8247589 - remove duplicate test helper method definition - JDK-8247589 backport to 11u ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/910/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/910/files/6a64695e..b7251051 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=910&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=910&range=02-03 Stats: 70049 lines in 605 files changed: 40110 ins; 19803 del; 10136 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/910.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/910/head:pull/910 PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From thartmann at openjdk.java.net Wed Mar 30 05:59:24 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 30 Mar 2022 05:59:24 GMT Subject: [jdk18u] RFR: 8256368: Avoid repeated upcalls into Java to re-resolve MH/VH linkers/invokers Message-ID: Backport of [JDK-8256368](https://bugs.openjdk.java.net/browse/JDK-8256368). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8256368: Avoid repeated upcalls into Java to re-resolve MH/VH linkers/invokers Changes: https://git.openjdk.java.net/jdk18u/pull/82/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=82&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8256368 Stats: 47 lines in 5 files changed: 22 ins; 12 del; 13 mod Patch: https://git.openjdk.java.net/jdk18u/pull/82.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/82/head:pull/82 PR: https://git.openjdk.java.net/jdk18u/pull/82 From thartmann at openjdk.java.net Wed Mar 30 06:01:18 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 30 Mar 2022 06:01:18 GMT Subject: [jdk18u] RFR: 8279822: CI: Constant pool entries in error state are not supported Message-ID: Backport of [JDK-8279822](https://bugs.openjdk.java.net/browse/JDK-8279822). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8279822: CI: Constant pool entries in error state are not supported Changes: https://git.openjdk.java.net/jdk18u/pull/83/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=83&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279822 Stats: 451 lines in 10 files changed: 361 ins; 48 del; 42 mod Patch: https://git.openjdk.java.net/jdk18u/pull/83.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/83/head:pull/83 PR: https://git.openjdk.java.net/jdk18u/pull/83 From thartmann at openjdk.java.net Wed Mar 30 06:06:09 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 30 Mar 2022 06:06:09 GMT Subject: [jdk18u] RFR: 8283187: C2: loop candidate for superword not always unrolled fully if superword fails Message-ID: <8wm2ZEl_u9CHfXw1D1JSX_D-UrtTIdYlMR4ox4IQXmE=.36d34b47-8752-4022-a52b-63f09d9f7877@github.com> Backport of [JDK-8283187](https://bugs.openjdk.java.net/browse/JDK-8283187). Did not apply cleanly due to changes to surrounding code in `test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java`. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8283187: C2: loop candidate for superword not always unrolled fully if superword fails Changes: https://git.openjdk.java.net/jdk18u/pull/84/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=84&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283187 Stats: 135 lines in 5 files changed: 90 ins; 6 del; 39 mod Patch: https://git.openjdk.java.net/jdk18u/pull/84.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/84/head:pull/84 PR: https://git.openjdk.java.net/jdk18u/pull/84 From thartmann at openjdk.java.net Wed Mar 30 06:11:23 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 30 Mar 2022 06:11:23 GMT Subject: [jdk18u] RFR: 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling Message-ID: Backport of [JDK-8281822](https://bugs.openjdk.java.net/browse/JDK-8281822). Did not apply cleanly due to changes to `test/hotspot/jtreg/serviceability/7170638/SDTProbesGNULinuxTest.java`. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling Changes: https://git.openjdk.java.net/jdk18u/pull/85/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=85&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281822 Stats: 142 lines in 9 files changed: 128 ins; 11 del; 3 mod Patch: https://git.openjdk.java.net/jdk18u/pull/85.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/85/head:pull/85 PR: https://git.openjdk.java.net/jdk18u/pull/85 From goetz at openjdk.java.net Wed Mar 30 06:16:27 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 30 Mar 2022 06:16:27 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master Message-ID: Merge build tag 11.0.16+8 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8283778: 11u GHA: Fix GCC 9 ubuntu package names - 8283018: 11u GHA: Update GCC 9 minor versions - 8275082: Update XML Security for Java to 2.3.0 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=964&range=00.0 - jdk11u:master: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=964&range=00.1 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/964/files Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/964.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/964/head:pull/964 PR: https://git.openjdk.java.net/jdk11u-dev/pull/964 From goetz at openjdk.java.net Wed Mar 30 06:16:28 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 30 Mar 2022 06:16:28 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 30 Mar 2022 06:06:18 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.16+8 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: c2e43f74 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/c2e43f7444a1df4ea441f01c5015cbe3d6726315 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Merge ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/964 From yan at openjdk.java.net Wed Mar 30 06:39:46 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 30 Mar 2022 06:39:46 GMT Subject: [jdk15u-dev] Integrated: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11 In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 13:44:18 GMT, Yuri Nesterenko wrote: > Clean backport of "Update IANA Language Subtag Registry to Version 2021-05-11". Waiting for test finish... This pull request has now been integrated. Changeset: ee1cb081 Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk15u-dev/commit/ee1cb08142c37aa13156f45956a6451d058eee8e Stats: 340 lines in 2 files changed: 327 ins; 0 del; 13 mod 8258795: Update IANA Language Subtag Registry to Version 2021-05-11 Backport-of: a259ab4a8d163ff924ba56c5da5395cec0d8c350 ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/187 From yan at openjdk.java.net Wed Mar 30 06:43:52 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 30 Mar 2022 06:43:52 GMT Subject: [jdk13u-dev] Integrated: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11 In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 14:18:11 GMT, Yuri Nesterenko wrote: > Clean backport of the 2021 IANA update. This pull request has now been integrated. Changeset: 85a1f6c6 Author: Yuri Nesterenko URL: https://git.openjdk.java.net/jdk13u-dev/commit/85a1f6c667f087bfe332023592739da3c2185f78 Stats: 340 lines in 2 files changed: 327 ins; 0 del; 13 mod 8258795: Update IANA Language Subtag Registry to Version 2021-05-11 Backport-of: a259ab4a8d163ff924ba56c5da5395cec0d8c350 ------------- PR: https://git.openjdk.java.net/jdk13u-dev/pull/332 From serb at openjdk.java.net Wed Mar 30 07:00:03 2022 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Wed, 30 Mar 2022 07:00:03 GMT Subject: [jdk15u-dev] RFR: 8274751: Drag And Drop hangs on Windows Message-ID: <-CyR-2O81Vxrsum_HOlOcWD6CCdJ8nuxGGL56U5M3Uw=.da7e471a-7f06-468e-8e74-56e4d7a02d42@github.com> Hi all, This pull request contains a backport of commit [7a0a6c95](https://github.com/openjdk/jdk/commit/7a0a6c95a53c6cb3340328d6543a97807320b740) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. The commit being backported was authored by Dmitry Markov on 24 Jan 2022 and was reviewed by Alexey Ivanov, Phil Race and Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport 7a0a6c95a53c6cb3340328d6543a97807320b740 Changes: https://git.openjdk.java.net/jdk15u-dev/pull/188/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=188&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274751 Stats: 19 lines in 4 files changed: 2 ins; 0 del; 17 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/188.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/188/head:pull/188 PR: https://git.openjdk.java.net/jdk15u-dev/pull/188 From clanger at openjdk.java.net Wed Mar 30 07:00:57 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 30 Mar 2022 07:00:57 GMT Subject: [jdk17u-dev] RFR: 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4 In-Reply-To: References: Message-ID: On Wed, 30 Mar 2022 03:24:53 GMT, Andrew John Hughes wrote: > DEFAULT_PROMOTED_VERSION_PRE has not been reset to 'ea' for either the 17.0.3 or 17.0.4 development cycles. > > While the value is not used by `configure`, we have started to rely on this value ourselves to detect if the source is for an early access (EA) or general access (GA) build, so it would be helpful if the value in the sources was accurate. > > This change would need to be reverted just before the `-ga` tag. Hi @gnu-andrew, so far, DEFAULT_PROMOTED_VERSION_PRE has not been actively used in OpenJDK update releases. It seems it has had a purpose only within Oracle's infrastructure. Hence, I removed it from 11u a while ago with [JDK-8269415](https://bugs.openjdk.java.net/browse/JDK-8269415). If we now start using it, it is a slight change in process that all maintainers have to be aware of. E.g. add "ea" when starting an update release with the version bump or keep it when merging back from the rampdown branch and make sure it gets removed with a final "ga" commit. Adding @GoeLin @jerboaa @theRealAph for comments. Cheers Christoph ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/307 From yan at openjdk.java.net Wed Mar 30 07:17:58 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 30 Mar 2022 07:17:58 GMT Subject: [jdk15u-dev] RFR: 8274751: Drag And Drop hangs on Windows In-Reply-To: <-CyR-2O81Vxrsum_HOlOcWD6CCdJ8nuxGGL56U5M3Uw=.da7e471a-7f06-468e-8e74-56e4d7a02d42@github.com> References: <-CyR-2O81Vxrsum_HOlOcWD6CCdJ8nuxGGL56U5M3Uw=.da7e471a-7f06-468e-8e74-56e4d7a02d42@github.com> Message-ID: On Wed, 30 Mar 2022 02:32:26 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [7a0a6c95](https://github.com/openjdk/jdk/commit/7a0a6c95a53c6cb3340328d6543a97807320b740) from the [openjdk/jdk](https://git.openjdk.java.net/jdk) repository. > The commit being backported was authored by Dmitry Markov on 24 Jan 2022 and was reviewed by Alexey Ivanov, Phil Race and Sergey Bylokhov. > Thanks! Thank you Sergey! jdk15u-fix-yes label set. ------------- PR: https://git.openjdk.java.net/jdk15u-dev/pull/188 From thartmann at openjdk.java.net Wed Mar 30 07:18:44 2022 From: thartmann at openjdk.java.net (Tobias Hartmann) Date: Wed, 30 Mar 2022 07:18:44 GMT Subject: [jdk18u] RFR: 8279822: CI: Constant pool entries in error state are not supported [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8279822](https://bugs.openjdk.java.net/browse/JDK-8279822). Applied cleanly but I had to set the class file version of the test to `V18`. Approval is pending. > > Thanks, > Tobias Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision: Set class file version to V18 ------------- Changes: - all: https://git.openjdk.java.net/jdk18u/pull/83/files - new: https://git.openjdk.java.net/jdk18u/pull/83/files/08edd524..b32018fe Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=83&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=83&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk18u/pull/83.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/83/head:pull/83 PR: https://git.openjdk.java.net/jdk18u/pull/83 From sgehwolf at openjdk.java.net Wed Mar 30 08:33:53 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 30 Mar 2022 08:33:53 GMT Subject: [jdk18u] RFR: 8281181: Do not use CPU Shares to compute active processor count In-Reply-To: References: Message-ID: On Wed, 30 Mar 2022 05:24:13 GMT, Ioi Lam wrote: > Please review this backport of [JDK-8281181](https://bugs.openjdk.java.net/browse/JDK-8281181) to jdk18u. Most changes were cleanly applied, except: > > - The changes in related to the deprecation of UseContainerCpuShares and PreferContainerQuotaForCPUCount) have been dropped. That's because the deprecation happens in the JDK 19 release cycle, not in 18u. > > You can compare with the JDK 19 version of the changes [here](https://github.com/openjdk/jdk/pull/7666/files). > > Tested with tiers 1-5, including all container test tasks. LGTM. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.java.net/jdk18u/pull/79 From aph at openjdk.java.net Wed Mar 30 08:59:39 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Wed, 30 Mar 2022 08:59:39 GMT Subject: [jdk11u-dev] RFR: 8235385: Crash on aarch64 JDK due to long offset In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 14:50:55 GMT, Alexey Pavlyutkin wrote: > Hi! > > Please review "backport" of [Wang Zhuo's patch](http://cr.openjdk.java.net/~wzhuo/BigOffsetAarch64/webrev.00/jdk13u.patch) to 11u-dev. The patch is applied with the following adaptation: > > - the legitimizing overload > > static void loadStore(MacroAssembler masm, mem_insn insn, > Register reg, int opcode, > Register base, int index, int size, int disp, > int size_in_memory); > > ported from 15u-dev with slight changes > - `aarch64_enc_strh`, `aarch64_enc_strh0`, `aarch64_enc_strw`, `aarch64_enc_strw0`, `aarch64_enc_str`, and `aarch64_enc_str0` functions updated to use new loadStore() overload > > Verified (18.04.6 LTS/aarch64) with the reproducers from JBS, 10 of 10 runs passed. Aproximately a half of runs crashed before I've applied the patch. > > Regression (18.04.6 LTS/aarch64): hotspot_compiler > > @theRealAph @AntonKozlov please take a look at that. Andrew, I could not mention Wang, if you know his ID could you mention him as well. Thank you That looks perfect, but I'd take out the `assert` because in this old release an out-of-range access isn't unexpected, and this is a good-enough way to fix it. Co-author is @sandlerwang . ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/960 From mdoerr at openjdk.java.net Wed Mar 30 09:16:54 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:16:54 GMT Subject: [jdk17u-dev] Integrated: 8271302: Regex Test Refresh In-Reply-To: <0z0ouP83yOSqUBliWJHIglFqF4iQa8wrNrCl7VPu4wk=.aed35833-04e5-4c7b-a509-629800d5856a@github.com> References: <0z0ouP83yOSqUBliWJHIglFqF4iQa8wrNrCl7VPu4wk=.aed35833-04e5-4c7b-a509-629800d5856a@github.com> Message-ID: On Tue, 29 Mar 2022 09:56:50 GMT, Martin Doerr wrote: > Clean backport of [JDK-8271302](https://bugs.openjdk.java.net/browse/JDK-8271302) This pull request has now been integrated. Changeset: ef42dbb7 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/ef42dbb7d2105e51258217542eabaa514659a18a Stats: 2253 lines in 3 files changed: 220 ins; 989 del; 1044 mod 8271302: Regex Test Refresh Backport-of: fecefb8541d5056b1a8b105126ac9c566875e056 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/290 From sgehwolf at openjdk.java.net Wed Mar 30 09:21:02 2022 From: sgehwolf at openjdk.java.net (Severin Gehwolf) Date: Wed, 30 Mar 2022 09:21:02 GMT Subject: [jdk17u-dev] RFR: 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4 In-Reply-To: References: Message-ID: <-RHlzhQnCw1KJaOxUcRVq9nekSfxP5NXLZSYX5_uhYk=.dd5aa7b7-183b-4b80-adfe-2528e5efc435@github.com> On Wed, 30 Mar 2022 03:24:53 GMT, Andrew John Hughes wrote: > DEFAULT_PROMOTED_VERSION_PRE has not been reset to 'ea' for either the 17.0.3 or 17.0.4 development cycles. > > While the value is not used by `configure`, we have started to rely on this value ourselves to detect if the source is for an early access (EA) or general access (GA) build, so it would be helpful if the value in the sources was accurate. > > This change would need to be reverted just before the `-ga` tag. I'm on the fence about this. On the one hand it indicates when we have an `EA` build (if we happen to define EA for update releases too) in the sources. On the other hand this would be prone to error to switch to "GA" mode at the right time. Would this need a separate bug when switching back to GA? Given that most downstream distributors probably don't rely on this (what would they have done up to this point if they did?) anyway, I'm questioning its usefulness. No strong feelings though. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/307 From mdoerr at openjdk.java.net Wed Mar 30 09:26:28 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:26:28 GMT Subject: [jdk17u-dev] RFR: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302 [v2] In-Reply-To: References: Message-ID: > Clean backport of [JDK-8273169](https://bugs.openjdk.java.net/browse/JDK-8273169) > on top of JDK-8271302. Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 683e30db79789ee44b3cc0b44c085de4615bca7b ------------- Changes: https://git.openjdk.java.net/jdk17u-dev/pull/291/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=291&range=01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/291.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/291/head:pull/291 PR: https://git.openjdk.java.net/jdk17u-dev/pull/291 From duke at openjdk.java.net Wed Mar 30 09:26:29 2022 From: duke at openjdk.java.net (openjdk-notifier[bot]) Date: Wed, 30 Mar 2022 09:26:29 GMT Subject: [jdk17u-dev] RFR: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302 In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 10:25:04 GMT, Martin Doerr wrote: > Clean backport of [JDK-8273169](https://bugs.openjdk.java.net/browse/JDK-8273169) > on top of JDK-8271302. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout TheRealMDoerr-backport-fecefb85 git fetch https://git.openjdk.java.net/jdk17u-dev master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/291 From mdoerr at openjdk.java.net Wed Mar 30 09:26:29 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:26:29 GMT Subject: [jdk17u-dev] Integrated: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302 In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 10:25:04 GMT, Martin Doerr wrote: > Clean backport of [JDK-8273169](https://bugs.openjdk.java.net/browse/JDK-8273169) > on top of JDK-8271302. This pull request has now been integrated. Changeset: d89ad1f1 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/d89ad1f104175dd4b6d4ac6551907d0fdc6f19a7 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302 Backport-of: 683e30db79789ee44b3cc0b44c085de4615bca7b ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/291 From mdoerr at openjdk.java.net Wed Mar 30 09:29:01 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:29:01 GMT Subject: [jdk17u-dev] Integrated: 8275337: C1: assert(false) failed: live_in set of first block must be empty In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 12:10:45 GMT, Martin Doerr wrote: > Clean backport of [JDK-8275337](https://bugs.openjdk.java.net/browse/JDK-8275337) This pull request has now been integrated. Changeset: b46fabf2 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/b46fabf26e50facb37d58aabf1458420f5a89777 Stats: 71 lines in 2 files changed: 70 ins; 0 del; 1 mod 8275337: C1: assert(false) failed: live_in set of first block must be empty Backport-of: 4191b2b9b98c1137e5f27e3b64efb83857fa2c91 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/294 From mdoerr at openjdk.java.net Wed Mar 30 09:29:44 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:29:44 GMT Subject: [jdk17u-dev] Integrated: 8283350: (tz) Update Timezone Data to 2022a In-Reply-To: References: Message-ID: <2wbevwhShLGgvJVSlXi2klji2wGGbLxrAxNEu7uGo20=.b0e5313c-d817-41a3-8860-bd8cef125dce@github.com> On Tue, 29 Mar 2022 08:24:39 GMT, Martin Doerr wrote: > Backport of [JDK-8283350](https://bugs.openjdk.java.net/browse/JDK-8283350) > Version from JDK18u applies cleanly. This pull request has now been integrated. Changeset: 9068185d Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/9068185db6a9a4227a16908297e5ee68f605e5fd Stats: 103 lines in 6 files changed: 76 ins; 0 del; 27 mod 8283350: (tz) Update Timezone Data to 2022a Backport-of: 1ab6f9395f784293deb37ea0186db59d1166ae40 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/289 From mdoerr at openjdk.java.net Wed Mar 30 09:30:59 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:30:59 GMT Subject: [jdk17u-dev] Integrated: 8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/ In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 13:12:37 GMT, Martin Doerr wrote: > Clean backport of [JDK-8281544](https://bugs.openjdk.java.net/browse/JDK-8281544) This pull request has now been integrated. Changeset: 6eaf579a Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/6eaf579a06efc2b84923ee04b83780a6f320f599 Stats: 14 lines in 2 files changed: 12 ins; 0 del; 2 mod 8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/ Backport-of: 4e0b81c596f2a2eae49127b9ee98c80500b4e319 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/299 From mdoerr at openjdk.java.net Wed Mar 30 09:32:48 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:32:48 GMT Subject: [jdk17u-dev] Integrated: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 13:55:23 GMT, Martin Doerr wrote: > Clean backport of [JDK-8277055](https://bugs.openjdk.java.net/browse/JDK-8277055) This pull request has now been integrated. Changeset: a9c2a50a Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/a9c2a50a0afc7e80c1aa25bb4709cfc359605d2d Stats: 14 lines in 2 files changed: 11 ins; 0 del; 3 mod 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics Backport-of: b1f935c1d0d3729470b57832cf74c43d49ea1f71 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/303 From mdoerr at openjdk.java.net Wed Mar 30 09:32:49 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:32:49 GMT Subject: [jdk17u-dev] Integrated: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL" In-Reply-To: <4cebzMTFJdwT7VGRU3pb58BPARff3GoEcBHvC6IhbWI=.072858ae-0378-4432-a3f4-14b0eb64b089@github.com> References: <4cebzMTFJdwT7VGRU3pb58BPARff3GoEcBHvC6IhbWI=.072858ae-0378-4432-a3f4-14b0eb64b089@github.com> Message-ID: On Tue, 29 Mar 2022 11:56:06 GMT, Martin Doerr wrote: > Backport of [JDK-8264605](https://bugs.openjdk.java.net/browse/JDK-8264605) This pull request has now been integrated. Changeset: 0200d64e Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/0200d64ee32ad7f46db400b754bd2492bdd96876 Stats: 27 lines in 2 files changed: 5 ins; 15 del; 7 mod 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL" Backport-of: 96fe1d0d4d95d87950ff2ecec570a927d831746e ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/293 From mdoerr at openjdk.java.net Wed Mar 30 09:33:00 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:33:00 GMT Subject: [jdk17u-dev] Integrated: 8279219: [REDO] C2 crash when allocating array of size too large In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 12:31:02 GMT, Martin Doerr wrote: > Clean backport of [JDK-8279219](https://bugs.openjdk.java.net/browse/JDK-8279219) This pull request has now been integrated. Changeset: 373526a4 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/373526a465284e985ccb4ac4a9b9494279bd2fa8 Stats: 307 lines in 11 files changed: 231 ins; 53 del; 23 mod 8279219: [REDO] C2 crash when allocating array of size too large Backport-of: d32f99ee65679601d6e160e7975fc1e367bfa6f4 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/296 From mdoerr at openjdk.java.net Wed Mar 30 09:34:45 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:34:45 GMT Subject: [jdk17u-dev] Integrated: 8272358: Some tests may fail when executed with other locales than the US In-Reply-To: <8Bnkjiz6Dh0K7XnVfKOamZWqIIF_XWBeREtQWDS6dMg=.2f8d393e-a76f-40db-8557-86bb2792d7f2@github.com> References: <8Bnkjiz6Dh0K7XnVfKOamZWqIIF_XWBeREtQWDS6dMg=.2f8d393e-a76f-40db-8557-86bb2792d7f2@github.com> Message-ID: On Tue, 29 Mar 2022 10:37:33 GMT, Martin Doerr wrote: > Clean backport of [JDK-8272358](https://bugs.openjdk.java.net/browse/JDK-8272358) This pull request has now been integrated. Changeset: 2f39462c Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/2f39462ce7057f9de9824e141d9108eb62b5397e Stats: 9 lines in 4 files changed: 1 ins; 0 del; 8 mod 8272358: Some tests may fail when executed with other locales than the US Backport-of: 29e552c03a2825f9526330072668a1d63ac68fd4 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/292 From mdoerr at openjdk.java.net Wed Mar 30 09:35:03 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:35:03 GMT Subject: [jdk17u-dev] Integrated: 8280964: [Linux aarch64] : drawImage dithers TYPE_BYTE_INDEXED images incorrectly In-Reply-To: References: Message-ID: <9qTopPJbqGGhj2YZPaeJnGyAA_D1Eekip0wfl8NnSD4=.03e0dabb-961c-4385-b1cf-dfe39829099a@github.com> On Tue, 29 Mar 2022 13:20:21 GMT, Martin Doerr wrote: > Clean backport of [JDK-8280964](https://bugs.openjdk.java.net/browse/JDK-8280964) This pull request has now been integrated. Changeset: 76402bc2 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/76402bc251233453b3c99fc07e542ed25e635305 Stats: 100 lines in 8 files changed: 83 ins; 0 del; 17 mod 8280964: [Linux aarch64] : drawImage dithers TYPE_BYTE_INDEXED images incorrectly Backport-of: 6f882deddcc094777b45f0dacc7351dbc23993a4 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/300 From mdoerr at openjdk.java.net Wed Mar 30 09:36:50 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:36:50 GMT Subject: [jdk17u-dev] Integrated: 8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 13:04:38 GMT, Martin Doerr wrote: > Clean backport of [JDK-8271055](https://bugs.openjdk.java.net/browse/JDK-8271055) This pull request has now been integrated. Changeset: 02292c5b Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/02292c5b618a83b64154650fc5f707243ad1e29e Stats: 121 lines in 3 files changed: 120 ins; 0 del; 1 mod 8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack Backport-of: e44dc638b8936b1b76ca9ddf9ece0c5c4705a19c ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/298 From mdoerr at openjdk.java.net Wed Mar 30 09:37:52 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 09:37:52 GMT Subject: [jdk17u-dev] Integrated: 8280600: C2: assert(!had_error) failed: bad dominance In-Reply-To: <6XjxR1kBUM0Ptgm5rrPUBkNapIUclX8ygY3Ck5KXQrg=.267d12ce-11f7-4017-9c8f-139356159c60@github.com> References: <6XjxR1kBUM0Ptgm5rrPUBkNapIUclX8ygY3Ck5KXQrg=.267d12ce-11f7-4017-9c8f-139356159c60@github.com> Message-ID: <5qM6Tg9BaxeED3mJ5FWBTiGcvbqkFomcxR82aKPTGC0=.519622b7-de50-405c-af3b-694f7b7c63ea@github.com> On Tue, 29 Mar 2022 12:56:02 GMT, Martin Doerr wrote: > Clean backport of [JDK-8280600](https://bugs.openjdk.java.net/browse/JDK-8280600) This pull request has now been integrated. Changeset: bf88ff18 Author: Martin Doerr URL: https://git.openjdk.java.net/jdk17u-dev/commit/bf88ff18ad6e6d16b013e0b4caa8cc493fc11b2f Stats: 54 lines in 2 files changed: 53 ins; 0 del; 1 mod 8280600: C2: assert(!had_error) failed: bad dominance Backport-of: de826ba18a5e98586029581c2d4bcd27334fbdd1 ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/297 From mdoerr at openjdk.java.net Wed Mar 30 10:24:14 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 10:24:14 GMT Subject: [jdk17u-dev] RFR: 8272964: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted Message-ID: <8xpGTQbOkMhtssffILofIXKBpWs3VSKA9E-5UT-za7Y=.54b3d912-1ed4-4570-a0c4-7e3518b69c2b@github.com> Clean backport of [JDK-8272964](https://bugs.openjdk.java.net/browse/JDK-8272964) ------------- Commit messages: - Backport dfeb4132e402c0466740a029c3b1d2d213955822 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/308/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=308&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272964 Stats: 10 lines in 1 file changed: 7 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/308.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/308/head:pull/308 PR: https://git.openjdk.java.net/jdk17u-dev/pull/308 From mdoerr at openjdk.java.net Wed Mar 30 10:30:32 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 10:30:32 GMT Subject: [jdk17u-dev] RFR: 8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security Message-ID: <-Kho42xq06DN7bqz09-lEtaCmyZgji6e1mewZT9yYi8=.5853136e-1842-4485-a4e3-ea32c9e890f7@github.com> Clean backport of [JDK-8272908](https://bugs.openjdk.java.net/browse/JDK-8272908) ------------- Commit messages: - Backport a16f2d0a3c326dd8b3b2133a9c170d998b7aa631 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/309/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=309&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272908 Stats: 253 lines in 3 files changed: 246 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/309.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/309/head:pull/309 PR: https://git.openjdk.java.net/jdk17u-dev/pull/309 From mdoerr at openjdk.java.net Wed Mar 30 10:36:29 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 10:36:29 GMT Subject: [jdk17u-dev] RFR: 8280799: =?UTF-8?B?0KEyOg==?= assert(false) failed: cyclic dependency prevents range check elimination Message-ID: Clean backport of [JDK-8280799](https://bugs.openjdk.java.net/browse/JDK-8280799) ------------- Commit messages: - Backport 1ef45c5bbdeb4e1ca65c6d8f3ac1568a6951f3a7 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/310/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=310&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280799 Stats: 340 lines in 3 files changed: 314 ins; 21 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/310.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/310/head:pull/310 PR: https://git.openjdk.java.net/jdk17u-dev/pull/310 From mdoerr at openjdk.java.net Wed Mar 30 10:53:04 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 10:53:04 GMT Subject: [jdk17u-dev] RFR: 8280901: MethodHandle::linkToNative stub is missing w/ -Xint Message-ID: <8VsdgGPAeD17eUneDZ3xtgMemOJwawToQPZEfogN_BA=.f31ab34a-1b56-4f97-96fd-8369f50a327a@github.com> Clean backport of [JDK-8280901](https://bugs.openjdk.java.net/browse/JDK-8280901) ------------- Commit messages: - Backport f86f38a8afd31c76039206f8f1f33371ad814396 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/311/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=311&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280901 Stats: 6 lines in 2 files changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/311.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/311/head:pull/311 PR: https://git.openjdk.java.net/jdk17u-dev/pull/311 From goetz at openjdk.java.net Wed Mar 30 11:01:44 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 30 Mar 2022 11:01:44 GMT Subject: [jdk11u-dev] RFR: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge In-Reply-To: References: Message-ID: <4Mvwm7yxGVZHRSp2Gcn11a_XZGAqwn4kuDV5JwwzHvE=.b90e0c6c-08b7-4841-891d-f6c6d3238271@github.com> On Tue, 29 Mar 2022 14:46:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. Pre-submit tests: missing dependencies. Fixed in jdk11u. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/959 From mdoerr at openjdk.java.net Wed Mar 30 11:01:19 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 11:01:19 GMT Subject: [jdk17u-dev] RFR: 8282045: When loop strip mining fails, safepoints are removed from loop anyway Message-ID: Backport of [JDK-8282045](https://bugs.openjdk.java.net/browse/JDK-8282045) ------------- Commit messages: - Backport 2c5d266f9f20005bc2a6c30dcaa95b059ea59d74 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/312/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=312&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282045 Stats: 203 lines in 3 files changed: 165 ins; 25 del; 13 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/312.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/312/head:pull/312 PR: https://git.openjdk.java.net/jdk17u-dev/pull/312 From mdoerr at openjdk.java.net Wed Mar 30 11:14:13 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 11:14:13 GMT Subject: [jdk17u-dev] RFR: 8283451: C2: assert(_base == Long) failed: Not a Long Message-ID: Clean backport of [JDK-8283451](https://bugs.openjdk.java.net/browse/JDK-8283451) ------------- Commit messages: - Backport fabde3b7b8ed5e576febe8138c14696ccdf636d5 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/313/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=313&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283451 Stats: 80 lines in 2 files changed: 78 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/313.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/313/head:pull/313 PR: https://git.openjdk.java.net/jdk17u-dev/pull/313 From clanger at openjdk.java.net Wed Mar 30 11:24:44 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 30 Mar 2022 11:24:44 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v4] In-Reply-To: References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> Message-ID: On Wed, 30 Mar 2022 05:55:34 GMT, Aleksei Voitylov wrote: >> JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. >> >> Original changeset does not apply cleanly because of: >> >> 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, >> 8215445: Enable building for Windows in WSL >> 8257913: Add more known library locations to simplify Linux cross-compilation >> 8244592: Start supporting SOURCE_DATE_EPOCH >> 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes >> >> Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. >> >> [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html > > Aleksei Voitylov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8247589 > - remove duplicate test helper method definition > - JDK-8247589 backport to 11u Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From avoitylov at openjdk.java.net Wed Mar 30 11:24:45 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Wed, 30 Mar 2022 11:24:45 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v2] In-Reply-To: References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> Message-ID: On Fri, 25 Mar 2022 08:09:27 GMT, Matthias Baesken wrote: >> Aleksei Voitylov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> JDK-8247589 backport to 11u > > Hi, we noticed a small issue in [test/jdk/tools/launcher/Test7029048.java](https://github.com/openjdk/jdk11u-dev/pull/910/files#diff-a2a1433f01e8291062945a7383286214ee41a0e8deecab03bd37bc0bebe3da14) . > test/jdk/tools/launcher/Test7029048.java now has private static void printSkipMessage(String description) twice , > this leads to the error > > test/jdk/tools/launcher/Test7029048.java:215: error: method printSkipMessage(String) is already defined in class Test7029048 > private static void printSkipMessage(String description) { > ^ @MBaesken I'd like to play it safe and kindly ask you to rerun the SAP nightly testing, if possible. ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From avoitylov at openjdk.java.net Wed Mar 30 11:24:46 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Wed, 30 Mar 2022 11:24:46 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v2] In-Reply-To: References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> Message-ID: On Mon, 28 Mar 2022 11:34:24 GMT, Christoph Langer wrote: >> Hi, we noticed a small issue in [test/jdk/tools/launcher/Test7029048.java](https://github.com/openjdk/jdk11u-dev/pull/910/files#diff-a2a1433f01e8291062945a7383286214ee41a0e8deecab03bd37bc0bebe3da14) . >> test/jdk/tools/launcher/Test7029048.java now has private static void printSkipMessage(String description) twice , >> this leads to the error >> >> test/jdk/tools/launcher/Test7029048.java:215: error: method printSkipMessage(String) is already defined in class Test7029048 >> private static void printSkipMessage(String description) { >> ^ > >> @MBaesken thanks for spotting this. GHA gives "E: Version '9.4.0-1ubuntu1~20.04' for 'gcc-9' was not found" which is unrelated to this change. > > Yes, about to fix this with https://github.com/openjdk/jdk11u/pull/36 [JDK-8283778](https://bugs.openjdk.java.net/browse/JDK-8283778) @RealCLanger I see my ask to Matthias crossed with your review. Can I assume SAP is happy with the updated version? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From clanger at openjdk.java.net Wed Mar 30 11:24:46 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 30 Mar 2022 11:24:46 GMT Subject: [jdk11u-dev] RFR: 8247589: Implementation of Alpine Linux/x64 Port [v2] In-Reply-To: References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> <3gk9TLWmDt8IUnA9qxquN6LRBNipZEVqh75q7lmBO9E=.d84b898a-5cfc-4e3a-8133-eb08b312198a@github.com> Message-ID: On Mon, 28 Mar 2022 11:34:24 GMT, Christoph Langer wrote: >> Hi, we noticed a small issue in [test/jdk/tools/launcher/Test7029048.java](https://github.com/openjdk/jdk11u-dev/pull/910/files#diff-a2a1433f01e8291062945a7383286214ee41a0e8deecab03bd37bc0bebe3da14) . >> test/jdk/tools/launcher/Test7029048.java now has private static void printSkipMessage(String description) twice , >> this leads to the error >> >> test/jdk/tools/launcher/Test7029048.java:215: error: method printSkipMessage(String) is already defined in class Test7029048 >> private static void printSkipMessage(String description) { >> ^ > >> @MBaesken thanks for spotting this. GHA gives "E: Version '9.4.0-1ubuntu1~20.04' for 'gcc-9' was not found" which is unrelated to this change. > > Yes, about to fix this with https://github.com/openjdk/jdk11u/pull/36 [JDK-8283778](https://bugs.openjdk.java.net/browse/JDK-8283778) > @RealCLanger I see my ask to Matthias crossed with your review. Can I assume SAP is happy with the updated version? Yes, the patch is running in our nightlies for days now - no further issues. ?? ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From mdoerr at openjdk.java.net Wed Mar 30 12:01:24 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 12:01:24 GMT Subject: [jdk17u-dev] RFR: 8282874: Bad performance on gather/scatter API caused by different IntSpecies of indexMap Message-ID: Clean backport of [JDK-8282874](https://bugs.openjdk.java.net/browse/JDK-8282874) ------------- Commit messages: - Backport 5c408c1410e15087f735a815b7edc716d514b1b3 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/314/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=314&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282874 Stats: 42 lines in 7 files changed: 0 ins; 0 del; 42 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/314.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/314/head:pull/314 PR: https://git.openjdk.java.net/jdk17u-dev/pull/314 From mdoerr at openjdk.java.net Wed Mar 30 12:07:23 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 12:07:23 GMT Subject: [jdk17u-dev] RFR: 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes Message-ID: Clean backport of [JDK-8282590](https://bugs.openjdk.java.net/browse/JDK-8282590) ------------- Commit messages: - Backport d29c7e740d51cb50a1aa0a941a5b460782f8da68 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/315/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=315&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282590 Stats: 39 lines in 3 files changed: 30 ins; 4 del; 5 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/315.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/315/head:pull/315 PR: https://git.openjdk.java.net/jdk17u-dev/pull/315 From duke at openjdk.java.net Wed Mar 30 12:08:22 2022 From: duke at openjdk.java.net (Alexey Pavlyutkin) Date: Wed, 30 Mar 2022 12:08:22 GMT Subject: [jdk11u-dev] RFR: 8235385: Crash on aarch64 JDK due to long offset [v2] In-Reply-To: References: Message-ID: > Hi! > > Please review "backport" of [Wang Zhuo's patch](http://cr.openjdk.java.net/~wzhuo/BigOffsetAarch64/webrev.00/jdk13u.patch) to 11u-dev. The patch is applied with the following adaptation: > > - the legitimizing overload > > static void loadStore(MacroAssembler masm, mem_insn insn, > Register reg, int opcode, > Register base, int index, int size, int disp, > int size_in_memory); > > ported from 15u-dev with slight changes > - `aarch64_enc_strh`, `aarch64_enc_strh0`, `aarch64_enc_strw`, `aarch64_enc_strw0`, `aarch64_enc_str`, and `aarch64_enc_str0` functions updated to use new loadStore() overload > > Verified (18.04.6 LTS/aarch64) with the reproducers from JBS, 10 of 10 runs passed. Aproximately a half of runs crashed before I've applied the patch. > > Regression (18.04.6 LTS/aarch64): hotspot_compiler > > @theRealAph @AntonKozlov please take a look at that. Andrew, I could not mention Wang, if you know his ID could you mention him as well. Thank you Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: removing unwanted assert ------------- Changes: - all: https://git.openjdk.java.net/jdk11u-dev/pull/960/files - new: https://git.openjdk.java.net/jdk11u-dev/pull/960/files/5eec99bc..26d024dd Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=960&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=960&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/960.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/960/head:pull/960 PR: https://git.openjdk.java.net/jdk11u-dev/pull/960 From mdoerr at openjdk.java.net Wed Mar 30 12:10:13 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 12:10:13 GMT Subject: [jdk17u-dev] RFR: 8283641: Large value for CompileThresholdScaling causes assert Message-ID: Clean backport of [JDK-8283641](https://bugs.openjdk.java.net/browse/JDK-8283641) ------------- Commit messages: - Backport c1048021fe57b78bb1f300b977588e1a93a284b6 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/316/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=316&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283641 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/316.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/316/head:pull/316 PR: https://git.openjdk.java.net/jdk17u-dev/pull/316 From zgu at openjdk.java.net Wed Mar 30 12:29:14 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 30 Mar 2022 12:29:14 GMT Subject: [jdk18u] RFR: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows Message-ID: A clean and low risk backport to fix a memory leak. ------------- Commit messages: - Backport 2cddf3f5391518ea40796e6c4759047d51b7b312 Changes: https://git.openjdk.java.net/jdk18u/pull/86/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18u&pr=86&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282887 Stats: 8 lines in 1 file changed: 2 ins; 3 del; 3 mod Patch: https://git.openjdk.java.net/jdk18u/pull/86.diff Fetch: git fetch https://git.openjdk.java.net/jdk18u pull/86/head:pull/86 PR: https://git.openjdk.java.net/jdk18u/pull/86 From zgu at openjdk.java.net Wed Mar 30 12:30:13 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 30 Mar 2022 12:30:13 GMT Subject: [jdk17u-dev] RFR: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows Message-ID: <4Dm-tEtGM3LHmmsURbQOrLemZHi15ccVysr7Lw3CMWQ=.6eaf781b-5c9c-4a6a-a110-c263d117803d@github.com> A clean and low risk backport to fix a memory leak. ------------- Commit messages: - Backport 2cddf3f5391518ea40796e6c4759047d51b7b312 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/317/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=317&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282887 Stats: 8 lines in 1 file changed: 2 ins; 3 del; 3 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/317.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/317/head:pull/317 PR: https://git.openjdk.java.net/jdk17u-dev/pull/317 From zgu at openjdk.java.net Wed Mar 30 12:32:05 2022 From: zgu at openjdk.java.net (Zhengyu Gu) Date: Wed, 30 Mar 2022 12:32:05 GMT Subject: [jdk11u-dev] RFR: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows Message-ID: A clean and low risk backport to fix a memory leak. ------------- Commit messages: - Backport 2cddf3f5391518ea40796e6c4759047d51b7b312 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/965/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=965&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282887 Stats: 8 lines in 1 file changed: 2 ins; 3 del; 3 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/965.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/965/head:pull/965 PR: https://git.openjdk.java.net/jdk11u-dev/pull/965 From mdoerr at openjdk.java.net Wed Mar 30 12:34:22 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 12:34:22 GMT Subject: [jdk17u-dev] RFR: 8256368: Avoid repeated upcalls into Java to re-resolve MH/VH linkers/invokers Message-ID: Clean backport of [JDK-8256368](https://bugs.openjdk.java.net/browse/JDK-8256368) ------------- Commit messages: - Backport 534e557874274255c55086b4f6128063cbd9cc58 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/318/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=318&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8256368 Stats: 47 lines in 5 files changed: 22 ins; 12 del; 13 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/318.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/318/head:pull/318 PR: https://git.openjdk.java.net/jdk17u-dev/pull/318 From mdoerr at openjdk.java.net Wed Mar 30 12:46:01 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 12:46:01 GMT Subject: [jdk17u-dev] RFR: 8271008: appcds/*/MethodHandlesAsCollectorTest.java tests time out because of excessive GC (CodeCache GC Threshold) in loom Message-ID: Backport of [JDK-8271008](https://bugs.openjdk.java.net/browse/JDK-8271008) Clean except Copyright year update. ------------- Commit messages: - Backport 022d80707c346f4b82ac1eb53e77c634769631e9 Changes: https://git.openjdk.java.net/jdk17u-dev/pull/319/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17u-dev&pr=319&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271008 Stats: 36 lines in 5 files changed: 6 ins; 10 del; 20 mod Patch: https://git.openjdk.java.net/jdk17u-dev/pull/319.diff Fetch: git fetch https://git.openjdk.java.net/jdk17u-dev pull/319/head:pull/319 PR: https://git.openjdk.java.net/jdk17u-dev/pull/319 From goetz at openjdk.java.net Wed Mar 30 12:50:37 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 30 Mar 2022 12:50:37 GMT Subject: [jdk11u-dev] Integrated: 8210732: remove jdk.testlibrary.Utils In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 19:30:42 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > Change already applied in previous backport > test/hotspot/jtreg/runtime/Dictionary/ProtectionDomainCacheTest.java > > Change not applicable, other changes removed the import: > test/jdk/com/sun/jdi/BasicJDWPConnectionTest.java > test/jdk/com/sun/jdi/ExclusiveBind.java > test/jdk/java/lang/ClassLoader/forNameLeak/ClassForNameLeak.java > > Merged: > test/jdk/sun/tools/jstatd/JstatdTest.java This pull request has now been integrated. Changeset: b6f4e3e1 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/b6f4e3e1a40ba144c738615504931eb1dfabf2d2 Stats: 469 lines in 92 files changed: 2 ins; 319 del; 148 mod 8210732: remove jdk.testlibrary.Utils Reviewed-by: mdoerr Backport-of: 8b28ad6efe68b076bdbd6ca0043a0fddd8847230 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/957 From avoitylov at openjdk.java.net Wed Mar 30 12:54:45 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Wed, 30 Mar 2022 12:54:45 GMT Subject: [jdk11u-dev] Integrated: 8247591: Document Alpine Linux build steps in OpenJDK build guide In-Reply-To: References: Message-ID: On Thu, 17 Mar 2022 20:46:37 GMT, Aleksei Voitylov wrote: > JDK-8247591 is in the docs issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Original changeset does not apply cleanly because of: > > 8220164: Fix build instructions for AIX > 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html This pull request has now been integrated. Changeset: 19761f50 Author: Aleksei Voitylov Committer: Alexander Scherbatiy URL: https://git.openjdk.java.net/jdk11u-dev/commit/19761f50d2bbe0c4c8486dc4384a7d74f5c820fc Stats: 51 lines in 2 files changed: 51 ins; 0 del; 0 mod 8247591: Document Alpine Linux build steps in OpenJDK build guide Reviewed-by: phh Backport-of: 508c8a95854a653bc85f8b931cf0d74521196e19 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/911 From avoitylov at openjdk.java.net Wed Mar 30 12:57:43 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Wed, 30 Mar 2022 12:57:43 GMT Subject: [jdk11u-dev] Integrated: 8247589: Implementation of Alpine Linux/x64 Port In-Reply-To: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> References: <08-FsCUPoDruX3hefm421WGBP1rShsXCzD4LqIJIj3o=.d57402b0-33ac-4c48-bd22-289085205a97@github.com> Message-ID: On Thu, 17 Mar 2022 20:43:30 GMT, Aleksei Voitylov wrote: > JDK-8247589 is in the main issue in the third batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1]. > > Original changeset does not apply cleanly because of: > > 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports, > 8215445: Enable building for Windows in WSL > 8257913: Add more known library locations to simplify Linux cross-compilation > 8244592: Start supporting SOURCE_DATE_EPOCH > 8244752: Enable Linux support for multiple huge page sizes -XX:LargePageSizeInBytes > > Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions. > > [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html This pull request has now been integrated. Changeset: 2faa2163 Author: Aleksei Voitylov Committer: Alexander Scherbatiy URL: https://git.openjdk.java.net/jdk11u-dev/commit/2faa2163ecbc7fa9482cc9df2fa79d6b74fa97a7 Stats: 397 lines in 29 files changed: 342 ins; 17 del; 38 mod 8247589: Implementation of Alpine Linux/x64 Port Reviewed-by: sgehwolf, clanger Backport-of: 63009f90ec7df053c936226663b463b8584364a9 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/910 From aph at openjdk.java.net Wed Mar 30 13:07:42 2022 From: aph at openjdk.java.net (Andrew Haley) Date: Wed, 30 Mar 2022 13:07:42 GMT Subject: [jdk11u-dev] RFR: 8235385: Crash on aarch64 JDK due to long offset [v2] In-Reply-To: References: Message-ID: On Wed, 30 Mar 2022 12:08:22 GMT, Alexey Pavlyutkin wrote: >> Hi! >> >> Please review "backport" of [Wang Zhuo's patch](http://cr.openjdk.java.net/~wzhuo/BigOffsetAarch64/webrev.00/jdk13u.patch) to 11u-dev. The patch is applied with the following adaptation: >> >> - the legitimizing overload >> >> static void loadStore(MacroAssembler masm, mem_insn insn, >> Register reg, int opcode, >> Register base, int index, int size, int disp, >> int size_in_memory); >> >> ported from 15u-dev with slight changes >> - `aarch64_enc_strh`, `aarch64_enc_strh0`, `aarch64_enc_strw`, `aarch64_enc_strw0`, `aarch64_enc_str`, and `aarch64_enc_str0` functions updated to use new loadStore() overload >> >> Verified (18.04.6 LTS/aarch64) with the reproducers from JBS, 10 of 10 runs passed. Aproximately a half of runs crashed before I've applied the patch. >> >> Regression (18.04.6 LTS/aarch64): hotspot_compiler >> >> @theRealAph @AntonKozlov please take a look at that. Andrew, I could not mention Wang, if you know his ID could you mention him as well. Thank you > > Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: > > removing unwanted assert src/hotspot/cpu/aarch64/aarch64.ad line 2665: > 2663: MacroAssembler _masm(&cbuf); > 2664: loadStore(_masm, &MacroAssembler::strh, zr, $mem->opcode(), > 2665: as_Register($mem$$base), $mem$$index, $mem$$scale, $mem$$disp, 2); This stuff is all generated from `ad_encode.m4`. Please edit that file, then regenerate everything between ` // BEGIN Non-volatile memory access` and ` // END Non-volatile memory access` ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/960 From goetz at openjdk.java.net Wed Mar 30 13:10:39 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 30 Mar 2022 13:10:39 GMT Subject: [jdk11u-dev] Integrated: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11 In-Reply-To: References: Message-ID: <03cBJuJyKz5SooK9G5n_HjyWX2U-NR-OCckwUFO_0WU=.cf137782-105d-45f9-9eed-77083503e232@github.com> On Mon, 28 Mar 2022 10:24:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: 89bf6390 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/89bf6390c4b16f7be688463ca53ed8ecfbf668e7 Stats: 340 lines in 2 files changed: 327 ins; 0 del; 13 mod 8258795: Update IANA Language Subtag Registry to Version 2021-05-11 Backport-of: a259ab4a8d163ff924ba56c5da5395cec0d8c350 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/954 From goetz at openjdk.java.net Wed Mar 30 13:11:39 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 30 Mar 2022 13:11:39 GMT Subject: [jdk11u-dev] Integrated: 8255266: Update Public Suffix List to 3c213aa In-Reply-To: References: Message-ID: On Mon, 28 Mar 2022 12:03:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: e9896e23 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/e9896e236a899cda7e1236192cd70fab13987845 Stats: 1254 lines in 5 files changed: 887 ins; 215 del; 152 mod 8255266: Update Public Suffix List to 3c213aa Backport-of: 7ce75afbbcca7635356c7377be7ddff15335e563 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/955 From goetz at openjdk.java.net Wed Mar 30 13:13:40 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 30 Mar 2022 13:13:40 GMT Subject: [jdk11u-dev] Integrated: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 14:46:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.16-oracle. This pull request has now been integrated. Changeset: 57faad57 Author: Goetz Lindenmaier URL: https://git.openjdk.java.net/jdk11u-dev/commit/57faad5745f5140bf7cbc609c5c64a5cf7752d5c Stats: 212 lines in 2 files changed: 211 ins; 0 del; 1 mod 8277922: Unable to click JCheckBox in JTable through Java Access Bridge Backport-of: 1668c02ee83cc4f7bd7b2fe5bb7ef59b5dbda081 ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/959 From goetz at openjdk.java.net Wed Mar 30 13:40:55 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 30 Mar 2022 13:40:55 GMT Subject: [jdk11u-dev] RFR: 8192057: com/sun/jdi/BadHandshakeTest.java fails with java.net.ConnectException Message-ID: <2sjj1cdQJg3XQ68Cd3zZtGnoTpExGFBvSKqeHfVqzmw=.6e9e6f26-a434-4e96-a979-19425235a51f@github.com> I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport c920b4a5c0258dde6e4d4f25ce575138374e5e9d Changes: https://git.openjdk.java.net/jdk11u-dev/pull/968/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=968&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8192057 Stats: 154 lines in 1 file changed: 41 ins; 87 del; 26 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/968.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/968/head:pull/968 PR: https://git.openjdk.java.net/jdk11u-dev/pull/968 From goetz at openjdk.java.net Wed Mar 30 13:53:09 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 30 Mar 2022 13:53:09 GMT Subject: [jdk11u-dev] RFR: 8214799: Add package declaration to each JTREG test case in the gc folder Message-ID: I want to backport this ot simplify follow-up test backports. I had to do a row of straight-forward edits: The backport of shenandoah put the CriticalNative tests into a different location. This affects four files in this patch. test/hotspot/jtreg/gc/CriticalNative.java I moved this to gc/shenandoah/jni because the other critical native test are located there, too. test/hotspot/jtreg/gc/CriticalNativeArgs.java is at different location in 11. Applied the patch to test/hotspot/jtreg/gc/shenandoah/jni/CriticalNativeArgs.java Additional @run commands had to be edited: test/hotspot/jtreg/gc/TestFullGCALot.java Differing context: test/hotspot/jtreg/gc/TestHumongousReferenceObject.java Copyright; @run has less VM arguments. test/hotspot/jtreg/gc/TestNUMAPageSize.java Test not in 11: test/hotspot/jtreg/gc/TestNoPerfCounter.java Copyright: (It seems the shenandoah backport 8214259 omitted the copyright updates of these tests) test/hotspot/jtreg/gc/arguments/TestDisableDefaultGC.java test/hotspot/jtreg/gc/arguments/TestMaxMinHeapFreeRatioFlags.java test/hotspot/jtreg/gc/arguments/TestNewRatioFlag.java test/hotspot/jtreg/gc/arguments/TestNewSizeFlags.java test/hotspot/jtreg/gc/arguments/TestShrinkHeapInSteps.java test/hotspot/jtreg/gc/arguments/TestSurvivorRatioFlag.java test/hotspot/jtreg/gc/arguments/TestTargetSurvivorRatioFlag.java test/hotspot/jtreg/gc/arguments/TestVerifyBeforeAndAfterGCFlags.java @run commands were changed. Simple resolve. "8272783: Epsilon: Refactor tests to improve performance" was already backported. test/hotspot/jtreg/gc/epsilon/TestAlignment.java test/hotspot/jtreg/gc/epsilon/TestAlwaysPretouch.java test/hotspot/jtreg/gc/epsilon/TestArraycopyCheckcast.java test/hotspot/jtreg/gc/epsilon/TestByteArrays.java test/hotspot/jtreg/gc/epsilon/TestClasses.java test/hotspot/jtreg/gc/epsilon/TestElasticTLAB.java test/hotspot/jtreg/gc/epsilon/TestElasticTLABDecay.java test/hotspot/jtreg/gc/epsilon/TestEpsilonEnabled.java test/hotspot/jtreg/gc/epsilon/TestHelloWorld.java test/hotspot/jtreg/gc/epsilon/TestLogTrace.java test/hotspot/jtreg/gc/epsilon/TestManyThreads.java test/hotspot/jtreg/gc/epsilon/TestMaxTLAB.java test/hotspot/jtreg/gc/epsilon/TestMemoryMXBeans.java test/hotspot/jtreg/gc/epsilon/TestMemoryPools.java test/hotspot/jtreg/gc/epsilon/TestObjects.java test/hotspot/jtreg/gc/epsilon/TestPrintHeapSteps.java test/hotspot/jtreg/gc/epsilon/TestRefArrays.java test/hotspot/jtreg/gc/epsilon/TestUpdateCountersSteps.java Not in 11: test/hotspot/jtreg/gc/g1/TestEdenSurvivorLessThanMax.java test/hotspot/jtreg/gc/g1/TestPeriodicCollection.java test/hotspot/jtreg/gc/g1/TestPeriodicLogMessages.java Copyright: test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData00.java test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData05.java test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData10.java test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData15.java test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData20.java test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData25.java test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData30.java Not in 11: test/hotspot/jtreg/gc/g1/TestStringTableStats.java Resolved: test/hotspot/jtreg/gc/g1/mixedgc/TestOldGenCollectionUsage.java test/hotspot/jtreg/gc/libCriticalNative.c is at different location in 11. Applied the patch to test/hotspot/jtreg/gc/shenandoah/jni/libCriticalNative.c Not in 11: test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAt.java test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtError.java test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtMultiple.java test/hotspot/jtreg/gc/nvdimm/TestHumongousObjectsOnNvdimm.java test/hotspot/jtreg/gc/nvdimm/TestOldObjectsOnNvdimm.java test/hotspot/jtreg/gc/nvdimm/TestYoungObjectsOnDram.java test/hotspot/jtreg/gc/stress/CriticalNativeStress.java is at different location in 11. Applied the patch to test/hotspot/jtreg/gc/shenandoah/jni/CriticalNativeStress.java Copyright: test/hotspot/jtreg/gc/stress/TestReclaimStringsLeaksMemory.java test/hotspot/jtreg/gc/stress/TestStressIHOPMultiThread.java Resolved due to "8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx" and various shenandoah changes. test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithShenandoah.java test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithSerial.java test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithShenandoah.java test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithShenandoah.java test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithShenandoah.java Copyright: test/hotspot/jtreg/gc/survivorAlignment/TestAllocationInEden.java test/hotspot/jtreg/gc/survivorAlignment/TestPromotionFromEdenToTenured.java test/hotspot/jtreg/gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterFullGC.java test/hotspot/jtreg/gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterMinorGC.java test/hotspot/jtreg/gc/survivorAlignment/TestPromotionToSurvivor.java test/hotspot/jtreg/gc/whitebox/TestWBGC.java ------------- Commit messages: - Update TestAlwaysPretouch.java - Backport 4d4b205e702abe7d940c1bab4f8253ac4b6af60d Changes: https://git.openjdk.java.net/jdk11u-dev/pull/966/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=966&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8214799 Stats: 1283 lines in 238 files changed: 621 ins; 0 del; 662 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/966.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/966/head:pull/966 PR: https://git.openjdk.java.net/jdk11u-dev/pull/966 From mdoerr at openjdk.java.net Wed Mar 30 13:53:09 2022 From: mdoerr at openjdk.java.net (Martin Doerr) Date: Wed, 30 Mar 2022 13:53:09 GMT Subject: [jdk11u-dev] RFR: 8214799: Add package declaration to each JTREG test case in the gc folder In-Reply-To: References: Message-ID: On Wed, 30 Mar 2022 12:58:01 GMT, Goetz Lindenmaier wrote: > I want to backport this ot simplify follow-up test backports. > > I had to do a row of straight-forward edits: > > > The backport of shenandoah put the CriticalNative tests > into a different location. This affects four files in this patch. > > test/hotspot/jtreg/gc/CriticalNative.java > I moved this to gc/shenandoah/jni because the other > critical native test are located there, too. > > test/hotspot/jtreg/gc/CriticalNativeArgs.java is at different > location in 11. Applied the patch to > test/hotspot/jtreg/gc/shenandoah/jni/CriticalNativeArgs.java > > Additional @run commands had to be edited: > test/hotspot/jtreg/gc/TestFullGCALot.java > > Differing context: > test/hotspot/jtreg/gc/TestHumongousReferenceObject.java > > Copyright; @run has less VM arguments. > test/hotspot/jtreg/gc/TestNUMAPageSize.java > > Test not in 11: > test/hotspot/jtreg/gc/TestNoPerfCounter.java > > Copyright: (It seems the shenandoah backport 8214259 omitted the copyright updates of these tests) > test/hotspot/jtreg/gc/arguments/TestDisableDefaultGC.java > test/hotspot/jtreg/gc/arguments/TestMaxMinHeapFreeRatioFlags.java > test/hotspot/jtreg/gc/arguments/TestNewRatioFlag.java > test/hotspot/jtreg/gc/arguments/TestNewSizeFlags.java > test/hotspot/jtreg/gc/arguments/TestShrinkHeapInSteps.java > test/hotspot/jtreg/gc/arguments/TestSurvivorRatioFlag.java > test/hotspot/jtreg/gc/arguments/TestTargetSurvivorRatioFlag.java > test/hotspot/jtreg/gc/arguments/TestVerifyBeforeAndAfterGCFlags.java > > @run commands were changed. Simple resolve. "8272783: Epsilon: Refactor tests to improve performance" was already backported. > test/hotspot/jtreg/gc/epsilon/TestAlignment.java > test/hotspot/jtreg/gc/epsilon/TestAlwaysPretouch.java > test/hotspot/jtreg/gc/epsilon/TestArraycopyCheckcast.java > test/hotspot/jtreg/gc/epsilon/TestByteArrays.java > test/hotspot/jtreg/gc/epsilon/TestClasses.java > test/hotspot/jtreg/gc/epsilon/TestElasticTLAB.java > test/hotspot/jtreg/gc/epsilon/TestElasticTLABDecay.java > test/hotspot/jtreg/gc/epsilon/TestEpsilonEnabled.java > test/hotspot/jtreg/gc/epsilon/TestHelloWorld.java > test/hotspot/jtreg/gc/epsilon/TestLogTrace.java > test/hotspot/jtreg/gc/epsilon/TestManyThreads.java > test/hotspot/jtreg/gc/epsilon/TestMaxTLAB.java > test/hotspot/jtreg/gc/epsilon/TestMemoryMXBeans.java > test/hotspot/jtreg/gc/epsilon/TestMemoryPools.java > test/hotspot/jtreg/gc/epsilon/TestObjects.java > test/hotspot/jtreg/gc/epsilon/TestPrintHeapSteps.java > test/hotspot/jtreg/gc/epsilon/TestRefArrays.java > test/hotspot/jtreg/gc/epsilon/TestUpdateCountersSteps.java > > Not in 11: > test/hotspot/jtreg/gc/g1/TestEdenSurvivorLessThanMax.java > test/hotspot/jtreg/gc/g1/TestPeriodicCollection.java > test/hotspot/jtreg/gc/g1/TestPeriodicLogMessages.java > > Copyright: > test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData00.java > test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData05.java > test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData10.java > test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData15.java > test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData20.java > test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData25.java > test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData30.java > > Not in 11: > test/hotspot/jtreg/gc/g1/TestStringTableStats.java > > Resolved: > test/hotspot/jtreg/gc/g1/mixedgc/TestOldGenCollectionUsage.java > > test/hotspot/jtreg/gc/libCriticalNative.c is at different > location in 11. Applied the patch to > test/hotspot/jtreg/gc/shenandoah/jni/libCriticalNative.c > > Not in 11: > test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java > test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAt.java > test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtError.java > test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtMultiple.java > test/hotspot/jtreg/gc/nvdimm/TestHumongousObjectsOnNvdimm.java > test/hotspot/jtreg/gc/nvdimm/TestOldObjectsOnNvdimm.java > test/hotspot/jtreg/gc/nvdimm/TestYoungObjectsOnDram.java > > test/hotspot/jtreg/gc/stress/CriticalNativeStress.java is at different > location in 11. Applied the patch to > test/hotspot/jtreg/gc/shenandoah/jni/CriticalNativeStress.java > > Copyright: > test/hotspot/jtreg/gc/stress/TestReclaimStringsLeaksMemory.java > test/hotspot/jtreg/gc/stress/TestStressIHOPMultiThread.java > > Resolved due to "8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx" and various shenandoah changes. > test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithShenandoah.java > test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithSerial.java > test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithShenandoah.java > test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithShenandoah.java > test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithShenandoah.java > > Copyright: > test/hotspot/jtreg/gc/survivorAlignment/TestAllocationInEden.java > test/hotspot/jtreg/gc/survivorAlignment/TestPromotionFromEdenToTenured.java > test/hotspot/jtreg/gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterFullGC.java > test/hotspot/jtreg/gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterMinorGC.java > test/hotspot/jtreg/gc/survivorAlignment/TestPromotionToSurvivor.java > test/hotspot/jtreg/gc/whitebox/TestWBGC.java Thanks for the detailed description! ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk11u-dev/pull/966 From goetz at openjdk.java.net Wed Mar 30 14:25:06 2022 From: goetz at openjdk.java.net (Goetz Lindenmaier) Date: Wed, 30 Mar 2022 14:25:06 GMT Subject: [jdk11u-dev] RFR: 8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect Message-ID: I backport this for parity with 11.0.16-oracle. ------------- Commit messages: - Backport d5138d1fce2d3115e19c209405f12b983f7fe630 - Backport ea26ff1142b6b7413f01d83375ff3be8a3ab3e74 Changes: https://git.openjdk.java.net/jdk11u-dev/pull/967/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=967&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255604 Stats: 110 lines in 1 file changed: 40 ins; 34 del; 36 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/967.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/967/head:pull/967 PR: https://git.openjdk.java.net/jdk11u-dev/pull/967 From yan at openjdk.java.net Wed Mar 30 14:30:25 2022 From: yan at openjdk.java.net (Yuri Nesterenko) Date: Wed, 30 Mar 2022 14:30:25 GMT Subject: [jdk15u-dev] RFR: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths Message-ID: Not too risky change in the log configurator. I hope skara would consider the port clean since the only difference with original is in old copyright dates of both files. Waiting for the tests with label... ------------- Commit messages: - Backport 84868e39be4522ba87e603beea0f8da9efa43b6d Changes: https://git.openjdk.java.net/jdk15u-dev/pull/189/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk15u-dev&pr=189&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281275 Stats: 28 lines in 2 files changed: 23 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk15u-dev/pull/189.diff Fetch: git fetch https://git.openjdk.java.net/jdk15u-dev pull/189/head:pull/189 PR: https://git.openjdk.java.net/jdk15u-dev/pull/189 From kvn at openjdk.java.net Wed Mar 30 17:09:58 2022 From: kvn at openjdk.java.net (Vladimir Kozlov) Date: Wed, 30 Mar 2022 17:09:58 GMT Subject: [jdk18u] RFR: 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling In-Reply-To: References: Message-ID: On Wed, 30 Mar 2022 06:04:37 GMT, Tobias Hartmann wrote: > Backport of [JDK-8281822](https://bugs.openjdk.java.net/browse/JDK-8281822). Did not apply cleanly due to changes to `test/hotspot/jtreg/serviceability/7170638/SDTProbesGNULinuxTest.java`. Approval is pending. > > Thanks, > Tobias Good. ------------- Marked as reviewed by kvn (Reviewer). PR: https://git.openjdk.java.net/jdk18u/pull/85 From avoitylov at openjdk.java.net Wed Mar 30 17:35:57 2022 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Wed, 30 Mar 2022 17:35:57 GMT Subject: [jdk11u-dev] RFR: 8279958: Provide configure hints for Alpine/apk package managers Message-ID: <1KYCAe60O2RMm_fWQdUo1l2qtye5OrtTWaow-_e9_Mc=.f8051b5b-eec9-47e4-b553-eb225a74bfa4@github.com> JDK-8279958 is a follow up issue of a chain of backports for Alpine support to 11u, adding configure hints for Alpine. Original changeset does not apply cleanly because of: 8219920: dependency help output in configure-step : support zypper tool 8257679: Improved unix compatibility layer in Windows build (winenv) Testing: configure produced expected output, GHA. ------------- Commit messages: - JDK-8279958 backport to 11u Changes: https://git.openjdk.java.net/jdk11u-dev/pull/969/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=969&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279958 Stats: 25 lines in 1 file changed: 23 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk11u-dev/pull/969.diff Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/969/head:pull/969 PR: https://git.openjdk.java.net/jdk11u-dev/pull/969 From andrew at openjdk.java.net Wed Mar 30 17:35:55 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Wed, 30 Mar 2022 17:35:55 GMT Subject: [jdk17u-dev] RFR: 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4 In-Reply-To: <-RHlzhQnCw1KJaOxUcRVq9nekSfxP5NXLZSYX5_uhYk=.dd5aa7b7-183b-4b80-adfe-2528e5efc435@github.com> References: <-RHlzhQnCw1KJaOxUcRVq9nekSfxP5NXLZSYX5_uhYk=.dd5aa7b7-183b-4b80-adfe-2528e5efc435@github.com> Message-ID: <6T0GxZpbqqnwi98IFl01tz6Bzf8omQA4JYojskZbMt4=.18a5b0ce-c2c3-4e1f-bff2-3ae1ad41e6c2@github.com> On Wed, 30 Mar 2022 09:17:54 GMT, Severin Gehwolf wrote: > I'm on the fence about this. On the one hand it indicates when we have an `EA` build (if we happen to define EA for update releases too) in the sources. On the other hand this would be prone to error to switch to "GA" mode at the right time. Would this need a separate bug when switching back to GA? The whole process of switching back and forth between EA and GA is error-prone, but, as far as I can see, unavoidable if one wishes to make pre-release builds rather than just moving directly from one GA release to another. Not having the value in the JDK itself doesn't solve the problem. It just makes it more likely that downstream distributors get it wrong, especially if they are not active in JDK development themselves. Having an inaccurate value, as we do now, is even worse. I think a similar argument could be made for the other values in that file; they also require someone to remember to update them at certain points in the release cycle, but having one authoritative source helps all distributors. We have done without them in the past and I think having them in the JDK sources has improved things. We can certainly make the process clear by documenting what these changes are and when they need to be made in the release process documentation. You may remember that there was a mishap in the past, when Debian was publishing EA code as a GA build. At that time, we adapted the Fedora & RHEL RPMs to handle EA & GA builds with appropriate naming. When I spotted the addition of `DEFAULT_PROMOTED_VERSION_PRE` by Oracle - who I guess from the logs have similar issues with switching this back and forth - I updated our RPMs to check their value against the value in the sources. This PR arises from that check doing its job, though in the opposite direction to what I expected when I wrote it. I was packaging 17.0.3+1, correctly changed the build to EA mode... and then it failed because the build correctly detected a mismatch and said "Hey, this should be GA!" I think there is no need for jdk-dev to ever be anything but `ea`. The switch to `` ('ga') should happen as part of the final changes along with the jdk*-ga tag in the jdk tree, and then we should avoid merging that change back into -dev. Yes, it would need a bug, but then we also have bugs for the version bump. It can be reviewed and approved in the same manner as the other security fixes, without having to go through the public process. > Given that most downstream distributors probably don't rely on this (what would they have done up to this point if they did?) anyway, I'm questioning its usefulness. No strong feelings though. The field was only added in May 2019. I only spotted it myself when updating to OpenJDK 16 last February. It's not been publicised, OpenJDK 17 is the first time it has been in an LTS release and 17.0.3 is the first 17u release where the value is being maintained by someone other than Oracle. Our logic has not caught it for 17.0.1 & 17.0.2 because we've hopped from GA release to GA release. So the question for me is not whether distributors already rely on it (we haven't had much opportunity to, it being either unavailable or wrong), but whether it is going to be maintained enough for us to rely on it. I think the check we have is useful for keeping the status in sync between the sources and the RPM. It may well help those who are more divorced from the JDK development process even more in obtaining their downstream builds. I'd actually prefer that `configure` used it, but I can see there is resistance to that, so it's not something I'd push for. I'm happy for the value to remain as a helpful hint. Either way, I think having an inaccurate value in there is helpful. If we don't wish to update this value in sync with JDK updates development, it should be removed from the updates tree. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/307 From andrew at openjdk.java.net Wed Mar 30 17:55:39 2022 From: andrew at openjdk.java.net (Andrew John Hughes) Date: Wed, 30 Mar 2022 17:55:39 GMT Subject: [jdk17u-dev] RFR: 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4 In-Reply-To: <6T0GxZpbqqnwi98IFl01tz6Bzf8omQA4JYojskZbMt4=.18a5b0ce-c2c3-4e1f-bff2-3ae1ad41e6c2@github.com> References: <-RHlzhQnCw1KJaOxUcRVq9nekSfxP5NXLZSYX5_uhYk=.dd5aa7b7-183b-4b80-adfe-2528e5efc435@github.com> <6T0GxZpbqqnwi98IFl01tz6Bzf8omQA4JYojskZbMt4=.18a5b0ce-c2c3-4e1f-bff2-3ae1ad41e6c2@github.com> Message-ID: On Wed, 30 Mar 2022 17:32:24 GMT, Andrew John Hughes wrote: >> I'm on the fence about this. On the one hand it indicates when we have an `EA` build (if we happen to define EA for update releases too) in the sources. On the other hand this would be prone to error to switch to "GA" mode at the right time. Would this need a separate bug when switching back to GA? Given that most downstream distributors probably don't rely on this (what would they have done up to this point if they did?) anyway, I'm questioning its usefulness. No strong feelings though. > >> I'm on the fence about this. On the one hand it indicates when we have an `EA` build (if we happen to define EA for update releases too) in the sources. On the other hand this would be prone to error to switch to "GA" mode at the right time. Would this need a separate bug when switching back to GA? > > The whole process of switching back and forth between EA and GA is error-prone, but, as far as I can see, unavoidable if one wishes to make pre-release builds rather than just moving directly from one GA release to another. Not having the value in the JDK itself doesn't solve the problem. It just makes it more likely that downstream distributors get it wrong, especially if they are not active in JDK development themselves. Having an inaccurate value, as we do now, is even worse. > > I think a similar argument could be made for the other values in that file; they also require someone to remember to update them at certain points in the release cycle, but having one authoritative source helps all distributors. We have done without them in the past and I think having them in the JDK sources has improved things. We can certainly make the process clear by documenting what these changes are and when they need to be made in the release process documentation. > > You may remember that there was a mishap in the past, when Debian was publishing EA code as a GA build. At that time, we adapted the Fedora & RHEL RPMs to handle EA & GA builds with appropriate naming. When I spotted the addition of `DEFAULT_PROMOTED_VERSION_PRE` by Oracle - who I guess from the logs have similar issues with switching this back and forth - I updated our RPMs to check their value against the value in the sources. > > This PR arises from that check doing its job, though in the opposite direction to what I expected when I wrote it. I was packaging 17.0.3+1, correctly changed the build to EA mode... and then it failed because the build correctly detected a mismatch and said "Hey, this should be GA!" > > I think there is no need for jdk-dev to ever be anything but `ea`. The switch to `` ('ga') should happen as part of the final changes along with the jdk*-ga tag in the jdk tree, and then we should avoid merging that change back into -dev. Yes, it would need a bug, but then we also have bugs for the version bump. It can be reviewed and approved in the same manner as the other security fixes, without having to go through the public process. > >> Given that most downstream distributors probably don't rely on this (what would they have done up to this point if they did?) anyway, I'm questioning its usefulness. No strong feelings though. > > The field was only added in May 2019. I only spotted it myself when updating to OpenJDK 16 last February. It's not been publicised, OpenJDK 17 is the first time it has been in an LTS release and 17.0.3 is the first 17u release where the value is being maintained by someone other than Oracle. Our logic has not caught it for 17.0.1 & 17.0.2 because we've hopped from GA release to GA release. > > So the question for me is not whether distributors already rely on it (we haven't had much opportunity to, it being either unavailable or wrong), but whether it is going to be maintained enough for us to rely on it. I think the check we have is useful for keeping the status in sync between the sources and the RPM. It may well help those who are more divorced from the JDK development process even more in obtaining their downstream builds. I'd actually prefer that `configure` used it, but I can see there is resistance to that, so it's not something I'd push for. I'm happy for the value to remain as a helpful hint. > > Either way, I think having an inaccurate value in there is helpful. If we don't wish to update this value in sync with JDK updates development, it should be removed from the updates tree. > Hi @gnu-andrew, > > so far, DEFAULT_PROMOTED_VERSION_PRE has not been actively used in OpenJDK update releases. It seems it has had a purpose only within Oracle's infrastructure. Hence, I removed it from 11u a while ago with [JDK-8269415](https://bugs.openjdk.java.net/browse/JDK-8269415). Well, that set the value to empty, which apparently means "ga". It didn't remove the field. I had no idea it had been backported to 11u before I found that change yesterday and I'm still surprised it was. As with 17u, it should really be either maintained or removed altogether. > If we now start using it, it is a slight change in process that all maintainers have to be aware of. E.g. add "ea" when starting an update release with the version bump or keep it when merging back from the rampdown branch and make sure it gets removed with a final "ga" commit. I think the simplest route is to change it at the same time the integration tree is tagged `-ga` and then drop it when merging this back to `-dev`, either as part of the merge changeset or a separate one. I mistakenly associated it initially with the start of a release cycle, but the transition there is from an EA build of release `n` to an EA build of release `n+1`. The integration tree is really the only one that needs to see the empty value ("ga"). My preference is to have this value maintained and I would also like to backport it to 8u so we can handle at least 8u, 11u & 17u consistently with this value. I'd maintain that value in the 8u promotions & merges, and yourself and @GoeLin would need to do so for 11u & 17u. Azul are of course welcome to maintain it as well for 13u & 15u, and I believe Oracle already do so (primarily for pre-releases of major versions). However, if the two of you don't want the additional work of maintaining this, I'm happy to achieve the same consistency by just dropping the field from the 11u & 17u update releases. As I outlined in my reply to @jerboaa above, my issue at the moment is we have a check we implemented during the OpenJDK 16 pre-release period to confirm that the value of `DEFAULT_PROMOTED_VERSION_PRE` in the source code matches what we expect in our RPMs and this is now failing because the EA source code has the same empty value as the GA source code. So I need to make a decision as to whether we abandon this check, restrict it to only where the update version is 0 or fix the value at source. I've applied the patch attached to this PR for now for 17.0.3, but that's not a sustainable solution for future update releases. ------------- PR: https://git.openjdk.java.net/jdk17u-dev/pull/307 From gnu.andrew at redhat.com Wed Mar 30 19:26:03 2022 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 30 Mar 2022 20:26:03 +0100 Subject: [External] : Re: [Proposal] Maintainer Approvals and SKARA In-Reply-To: <84424e44-6577-3084-5604-a356ddf404ec@oracle.com> References: <84424e44-6577-3084-5604-a356ddf404ec@oracle.com> Message-ID: On 05:07 Thu 24 Mar , Kevin Rushforth wrote: > > > I'm not sure how you see this as "more work", as the existing task > > of flagging the issue for approval would now be handled by the bot, > > rather than the committer. > > I meant more work in Skara to develop and implement this new feature > (although Erik could confirm whether my assessment is accurate). I can > see some advantages for the maintainers, but we need to balance to > potential benefit against the cost to implement. > > -- Kevin > Ah ok, one of my main motivations behind the change was to reduce the work required in SKARA. After reading the code and discussing this with Erik, I got the impression that it was easier to implement if the process was mostly self-contained within the PR, with SKARA only reaching out to JBS to make changes. To implement the existing system would require SKARA to be constantly polling the referenced bugs to see if someone had added jdk-fix-yes to the bug. I believe this is already something that is proving problematic with CSRs, where the SKARA PR can become out of sync with the CSR bug item. There are some additional benefits to developers, such as removing the need for someone to have JBS access to request approval, but the primary one was to avoid a large amount of SKARA development work if a simple change could be made to where the approval process takes place. Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 From gnu.andrew at redhat.com Wed Mar 30 19:46:22 2022 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 30 Mar 2022 20:46:22 +0100 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: <1d4d5f66e456f214f3fd4ebf6746da9afdf6ea4f.camel@redhat.com> References: <1d4d5f66e456f214f3fd4ebf6746da9afdf6ea4f.camel@redhat.com> Message-ID: On 14:05 Thu 24 Mar , Severin Gehwolf wrote: snip... > > My worry would be that "Fix Request" comments would be spread across > different PRs if a single bug gets backported to, many update releases. > JDK 18u, 17u, 11u and 8u, for example. It would move the "approval" > conversation to the source control system (and per backport PR) rather > than the bug database. From a maintenance perspective it makes sense to > have all the info related to backports in one place (on the bug). If > something gets requested for 8u, say, I can see immediately in the bug > database that it has been backported to later releases too and can see > the approval flags (and who approved it). Moving this to skare makes > the info much more dispersed. I see this as an advantage. It doesn't make sense to me for the approval conversation to be separated from the rest of the PR process. It's even more of a problem when the patch submitter can't comment on JBS, so there is a level of indirection between the person requesting approval on the bug and the actual author of the patch. This came to mind again today when I found myself effectively having a conversation with myself for https://bugs.openjdk.java.net/browse/JDK-8255239 Do you really find the fix request comments that useful? I usually find I have to dig out the original patch review if I need anything more detailed than whether it went in cleanly or not. For me, I find more often that they create noise on the bug which makes it harder for me to find the original diagnosis of the issue itself. As to the approval labels (I assume that's what you mean by flags), they would still be set, but by the SKARA bot, so e.g. filters would continue to work. Even without them, the links to backport issues already demonstrate whether the fix is already in another release. > > Besides, we've had the issue of update project committers being able to > integrate without formal approval in JBS before. It's only much more > visible now (which is a good thing). I.e. the problem doesn't change > with Skara. The difference really is bot guidance. In general, the > process is fairly well understood and I don't anticipate this to be a > huge problem in practise. As I mentioned in my original e-mail, it's less an issue of technical possibility than ease and the bot guidance. Yes, someone could commit a bug without approval under Mercurial, but it was a bit more work to go back to the patch, check it still applied and worked (no easy branches or rebasing with Mercurial), and then push it yourself. Even with approval, I always felt a bit of trepidation doing the actual push. With SKARA, all it takes is for someone to type '/integrate'. This is why I have been holding back a formal review (as recognised by the bot) until the bug is approved, but another reviewer may have done that instead. The bot currently encourages someone to push without approval. 8u on GitHub already seems to be attracting more attention than we've had over the last six months. I'm not sure anyone who can open such a PR is going to be aware of every aspect of the process, especially when it contradicts what they are being told by the bot. > > Thanks, > Severin > Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 From goetz.lindenmaier at sap.com Thu Mar 31 10:03:49 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 31 Mar 2022 10:03:49 +0000 Subject: [External] : Re: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: <84424e44-6577-3084-5604-a356ddf404ec@oracle.com> Message-ID: Hi, I can follow what you are saying about the Skara implementation. I think we can handle the process entirely in PRs, but for me it is really important that Skara adds relevant information to the JBS issue in the end. One thing I think should not be over emphasized: > There are some additional benefits to developers, such as removing the > need for someone to have JBS access to request approval, but the Backports from people without JBS access should be rare. If they do many backports, they can and should get the proper roles to have the access. If they are one-time backporters, the overhead for them and sponsors should not be considered. Instead, we should optimize the administrative process for the power users. Currently, I look at about 20 approvals on a daily basis! And there were a lot which were just incomplete where I had to check whether they got a review or dependent issues were backported over and over again... Similar for the backports I do. The overhead of a 1-line test-only clean backport is ridiculous! If it is a backport that is technically demanding, the administrative part is negligible no matter how the process is set up. For all three roles, the backporter, the reviewers and the maintainer. And yes, for such backports I go to the PRs and changes of the original issue and previous backports to decide on the approval. For what needs to go to JBS, we should take Java users into account that see a VM bug in their Java application and check JBS for a potential fix. They should not have to search through the PRs for information. The information I would like to see in the (main) JBS Bug: * The entry in the "Backports" section * The link to the commit and the PR in the "Issue Links" section * The "Fix request [version]" comment by the backporter * Comments by the maintainer telling - why it was labeled -fix-no (in case it was rejected) - technical concerns why it should be backported or not and a reasoning about the decision. E.g., I think the decision why we decided to backport CGroups 2.0 should be in some JBS issue. Unfortunately it is not. (I think here we can improve, including myself) What I think is not important in JBS is * the fix-request and -fix-yes/no labels If there is a process enforcing the approval in PRs the fact that the issue is in the "Backports" section (i.e. it was pushed) shows that it was approved. (Eventually Skara could put a comment "Fix request approved [version] XY approved the request" Into the JBS issue). * The comment saying "A pull request was submitted for review ..." This is redundant and the link can be found in the "Issue Links" section. I think this just spams the comments. Best regards, Goetz. > -----Original Message----- > From: jdk-updates-dev On > Behalf Of Andrew Hughes > Sent: Wednesday, March 30, 2022 9:26 PM > To: Kevin Rushforth > Cc: jdk8u-dev at openjdk.java.net; jdk-updates-dev at openjdk.java.net > Subject: Re: [External] : Re: [Proposal] Maintainer Approvals and SKARA > > On 05:07 Thu 24 Mar , Kevin Rushforth wrote: > > > > > I'm not sure how you see this as "more work", as the existing task > > > of flagging the issue for approval would now be handled by the bot, > > > rather than the committer. > > > > I meant more work in Skara to develop and implement this new feature > > (although Erik could confirm whether my assessment is accurate). I can > > see some advantages for the maintainers, but we need to balance to > > potential benefit against the cost to implement. > > > > -- Kevin > > > > Ah ok, one of my main motivations behind the change was to reduce the > work required in SKARA. After reading the code and discussing this with > Erik, I got the impression that it was easier to implement if the > process was mostly self-contained within the PR, with SKARA only reaching > out to JBS to make changes. > > To implement the existing system would require SKARA to be constantly > polling the referenced bugs to see if someone had added jdk-fix-yes > to the bug. I believe this is already something that is proving > problematic with CSRs, where the SKARA PR can become out of sync with > the CSR bug item. > > There are some additional benefits to developers, such as removing the > need for someone to have JBS access to request approval, but the > primary one was to avoid a large amount of SKARA development work if a > simple change could be made to where the approval process takes place. > > Thanks, > -- > Andrew :) > Pronouns: he / him or they / them > Senior Free Java Software Engineer > OpenJDK Package Owner > Red Hat, Inc. > (https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww > .redhat.com%2F&data=04%7C01%7Cgoetz.lindenmaier%40sap.com%7C > 93ffe9f9904a4af1e20008da12833dac%7C42f7676cf455423c82f6dc2d99791af7 > %7C0%7C0%7C637842652152336329%7CUnknown%7CTWFpbGZsb3d8eyJWIj > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > 000&sdata=wbJIiOD%2BGaYoCXOx2trvdjVI2whGQFzVkAJPJ6I9icI%3D&a > mp;reserved=0) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 From gnu.andrew at redhat.com Thu Mar 31 13:01:23 2022 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 31 Mar 2022 14:01:23 +0100 Subject: [Proposal] Maintainer Approvals and SKARA In-Reply-To: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com> References: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com> Message-ID: On 07:01 Thu 24 Mar , erik.joelsson at oracle.com wrote: > Hello, > > I agree that solving SKARA-1199 would provide quite a bit of benefit to > the update releases. The current process works, but it requires > knowledge and manual care to not make mistakes. One of the main ideas > with Skara was to codify our processes to make them more foolproof and > easy to follow. I definitely think this approval process fits the bill > as something we should support better with tooling. > I completely agree with this and it's one of the things I like about switching to using SKARA. > Breaking apart the problem a bit, from the perspective of a user > developing a fix for an update release that requires approval, I agree > with Kevin that the current state of the approval should be reflected as > a "progress" on the PR. That makes it very clear if the PR is ready for > integration or not and fits in with how Skara tracks and treats other > integration blockers. Basing this functionality around the model of the > /sponsor command would be a pretty major shift in my opinion. It moves > the ability to actually integrate, and as such the control of the > timing, from the contributor to the integrator. This mimics how some > other big open source projects handle things (e.g. the Linux kernel). I > think it makes sense to do this when sponsoring, because we are then > helping new and inexperienced (in OpenJDK processes at least) users, > which helps prevent mistakes. For contributors of committer status or > above, I think we should retain their ability to control the timing of > integration. Implementation wise, I don't think it makes a big difference. > I have no issue with this at all. I merely used the 'sponsor' example because it was the most obvious example of something that seemed similar in the code. As you know the details of SKARA far better than I do, I'm happy to follow your lead on the best place to implement this. > The other part of the problem, which I think is what this discussion > should really focus on, is where the official approval takes place. We > can keep it in JBS like today, or we can move it to the PR, as suggested > by Andrew. From an implementation point of view, moving it to the PR is > less work, but I don't think we should base this decision on process on > if it takes an extra day to implement. The tooling should support the > process we want. > I'll confess that my initial motivation in rethinking the process was to see if we could simplify the implementation of this, given it seemed to have stalled since we first discussed it last year. But, having taking a step back to analyse what we're doing with approvals and why, I think there are several other benefits to integrating the process more into the SKARA way of doing things, which I hopefully outlined in my initial e-mail. Probably the main issue is that the JBS method of approval remains inaccessible for those who aren't OpenJDK authors, and for everyone when the bug itself is not public (we tend to encounter more of them in 8u, it seems). Making approvals easier in these cases would definitely be a benefit. > Without having spent a lot of time thinking about it so please tell me > if I'm missing something, would it be possible to support a hybrid/dual > solution? The official process could still be the labels in the JBS > issues, but the Skara 'integrator'-only /approve command on a PR could > also add the appropriate *-fix-yes label to all associated bugs. There > would also be a Skara bot monitoring JBS and automatically updating the > approval status on PRs based on labels in JBS. This would shortcut the > process for integrators that prefer working through PRs, while > integrators that prefer to work through JBS can continue the same way as > before. I think this should alleviate the issue of backporting many bugs > with one PR. This is of course also the biggest change to implement, but > not that much more than what I had already outlined in SKARA-1199. > This does sound like an even better option, providing the best of both worlds as we do with the ability to use SKARA via both the GitHub website and e-mail. My main concern is the work involved, but if you are happy to do this, then I would be very grateful to have this in place and willing to help out where I can. > /Erik > > Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 From erik.joelsson at oracle.com Thu Mar 31 13:41:04 2022 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Thu, 31 Mar 2022 06:41:04 -0700 Subject: [External] : Re: [Proposal] Maintainer Approvals and SKARA In-Reply-To: References: <639d9498-c764-2005-30ef-87351d639d9d@oracle.com> Message-ID: <5d4e35b7-d745-5c63-045c-424fb4f7c38a@oracle.com> Hello, On 2022-03-31 06:01, Andrew Hughes wrote: > This does sound like an even better option, providing the best of both > worlds as we do with the ability to use SKARA via both the GitHub > website and e-mail. > > My main concern is the work involved, but if you are happy to do this, > then I would be very grateful to have this in place and willing to help > out where I can. > At least in the short term, the work involved is of course limiting. I can't promise when I would be able to spend time on this, maybe in a few weeks if things go well. /Erik