[jdk11u-dev] RFR: JDK-8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11

[Vladimir Kempik]

On Mon, 28 Feb 2022 13:52:08 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> In JDK 11 only, we see errors in runtime/ErrorHandling/ErrorHandler.java. The test induces an artificial (but real) segfault and checks the VMs reaction to it (that the hs-err file is written correctly and contains expected output).
> 
> The test does this by reading from `char* p = NULL;`. This is not guaranteed to work, and does not in this case: the process gets a "BPT/Trap" message instead and dies.
> 
> This code (`VMError::controlled_crash()`) has been streamlined and rewritten for later releases, and there we consistently use a known non-null address to invalid memory instead, which seems to work reliably for MacOs aarch64 too.
> 
> ---
> 
> The patch, instead of downporting the whole reworkings of `VMError::controlled_crash`, just reuses the code which checks a segfault against a non-null invalid address. That way we do the same as newer releases, but with minimal changes.

Thomas, could you please revert this change https://github.com/openjdk/jdk11u-dev/pull/715/files#diff-aa0ca5360fa814ad73db34b607175d3e73987cf6a3c8274ac8c17a08d8c8a753 as part of your commit ?
it was the test I have disabled on mac-arm as a workaround for the issue you fixing here

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/842