[jdk11u-dev] RFR: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)

[Basil Crow]

On Fri, 18 Mar 2022 17:06:47 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please only `/integrate` once you've got `jdk11u-fix-yes` label in JBS by an 11u maintainer. See the process description here: https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u

@jerboaa Sorry, this is my first time submitting a PR to this project and I was unfamiliar with the process. I will read the link; thank you!

> You still need to request approval for 11u backports and justify why it should be done. See https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix section "Request and await approval for the fix". If you don't have JBS access, please provide the information and ask somebody to add it to the JBS issue.

@TheRealMDoerr I do not have JBS access. Can someone please submit the following comment with the `jdk11u-fix-request` label:

When compiling source code with compilation errors using Maven and Java 11, I frequently encounter the `AssertionError` from [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8210649) (tracked by [MCOMPILER-346](https://issues.apache.org/jira/browse/MCOMPILER-346)) with `<release>11</release>` and the `NullPointerException` from [JDK-8210649](https://bugs.openjdk.java.net/browse/JDK-8216202) (tracked by [MCOMPILER-415](https://issues.apache.org/jira/browse/MCOMPILER-415)) with `<release>8</release>`. That is, rather than getting an informative error message that tells me the nature of the compilation error, I get an unhelpful stack trace emanating from the depths of the JDK, which does not get me any closer to fixing the compilation error and compiling my code. Both issues have the same root cause and were resolved by openjdk/jdk at 44ae643b2b4. Backporting this commit to `jdk11u-dev` resolves both issues and eliminates a developer productivity pain point. Not only have I done a `t
 ier1` test run via GitHub Actions and executed the test from openjdk/jdk at 44ae643b2b4 locally by running `make run-test TEST=test/langtools/tools/javac/processing`, but also I have verified locally in an end-to-end testing scenario that this backport resolves the issues I was experiencing running Maven with both `<release>11</release>` (i.e., the `AssertionError`) and `<release>8</release>` (i.e., the `NullPointerException`).

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/919