[jdk11u-dev] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy [v9]
Zhengyu Gu
zgu at openjdk.java.net
Tue Mar 22 16:19:33 UTC 2022
On Mon, 21 Mar 2022 18:43:10 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
> > > > > A few more fix-ups are needed (see also inline comments):
> > > > > > 3. `PlainRead.java` would need to get the `-2` added as a "good" value. Like here: [openjdk/jdk at 01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48](https://github.com/openjdk/jdk/commit/01875677#diff-fb4f4dbf8943e1dcfd1663922c16f9ed3db403c070bd50979680ec5303756674R48) It's part of the original JDK-8250984 fix, but wasn't part of the 11 backport when it was done. So we should add it with this backport.
> > > >
> > > >
> > > > Even with this change, the test still failed.
> > >
> > >
> > > Right. See: [#840 (comment)](https://github.com/openjdk/jdk11u-dev/pull/840#issuecomment-1067065313)
> >
> >
> > Okay. It does not fix the test, I don't think we should include it in this patch, I would prefer to fix it separately.
>
> @zhengyu123 That's fine with me. Please rebase on top of the test changes ([JDK-8223396](https://bugs.openjdk.java.net/browse/JDK-8223396)) integrated recently and backport the test and fix from [JDK-8272124](https://bugs.openjdk.java.net/browse/JDK-8272124). Thank you.
I think all 4 PRs are lined up for push. Once this review is done, I will request for approvals for all 4.
-------------
PR: https://git.openjdk.java.net/jdk11u-dev/pull/863
More information about the jdk-updates-dev
mailing list