[jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
openjdk-notifier[bot]
duke at openjdk.java.net
Wed Mar 23 13:34:30 UTC 2022
On Fri, 11 Mar 2022 11:04:45 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:
> This is a backport of 8239785 for jdk11u. It depends upon
> pr/865: 8253714 (hopefully the bots will figure this out automatically)
>
> It's not clean, but the only conflict was the copyright line in the
> comment header for src/hotspot/share/prims/whitebox.hpp.
>
> I tried these tests, and they pass:
>
> test/hotspot/jtreg/applications/ctw/modules/java_compiler.java
> test/hotspot/jtreg/compiler/c2/Test8004741.java
> test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java
>
> Awaiting tier tests via GA.
>
> ---------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] Change must be properly reviewed
>
> ### Integration blocker
> ⚠️ Dependency #865 must be integrated first
>
>
>
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
>
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \
> `$ git checkout pull/881`
>
> Update a local copy of the PR: \
> `$ git checkout pull/881` \
> `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head`
>
> </details>
> <details><summary>Using Skara CLI tools</summary>
>
> Checkout this PR locally: \
> `$ git pr checkout 881`
>
> View PR using the GUI difftool: \
> `$ git pr show -t 881`
>
> </details>
> <details><summary>Using diff file</summary>
>
> Download this PR as a diff file: \
> <a href="https://git.openjdk.java.net/jdk11u-dev/pull/881.diff">https://git.openjdk.java.net/jdk11u-dev/pull/881.diff</a>
>
> </details>
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:
git checkout backport-8253714-memory.high
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push
-------------
PR: https://git.openjdk.java.net/jdk11u-dev/pull/881
More information about the jdk-updates-dev
mailing list