[jdk11u-dev] RFR: JDK-8283614: [11] Repair compiler versions handling after 8233787
Martin Doerr
mdoerr at openjdk.java.net
Thu Mar 24 10:33:50 UTC 2022
On Thu, 24 Mar 2022 09:22:54 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> Looks like "8233787: Break cycle in vm_version* includes" removed the handling of some VS versions (like _MSC_VER == 1923) from abstract_vm_version.cpp; this should be repaired.
> see
> https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d
> compare the new src/hotspot/share/runtime/abstract_vm_version.cpp with what we had in src/hotspot/share/runtime/vm_version.cpp .
> see
> https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d#diff-e1be9153f5c542ba094a1a0052a8fb549363aeb73a6e316448bd2b5c8074f3cbR231
> and
> https://github.com/openjdk/jdk11u-dev/commit/95c7d073e24227962e04f859d9c8bb06ceab861d#diff-ab4abdc4613ecb623211a17dff37909553374e4287fc80114e917d609989223eL241
LGTM.
-------------
Marked as reviewed by mdoerr (Reviewer).
PR: https://git.openjdk.java.net/jdk11u-dev/pull/943
More information about the jdk-updates-dev
mailing list