[jdk11u-dev] RFR: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot [v3]

[Jonathan Dowland]

On Fri, 25 Mar 2022 10:07:16 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> This is a backport of 8239785 for jdk11u. It depends upon
>> pr/865: 8253714 (hopefully the bots will figure this out automatically)
>> 
>> It's not clean, but the only conflict was the copyright line in the
>> comment header for src/hotspot/share/prims/whitebox.hpp.
>> 
>> I tried these tests, and they pass:
>> 
>> test/hotspot/jtreg/applications/ctw/modules/java_compiler.java
>> test/hotspot/jtreg/compiler/c2/Test8004741.java
>> test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java
>> 
>> Awaiting tier tests via GA.
>> 
>> ---------
>> ### Progress
>> - [x] Change must not contain extraneous whitespace
>> - [x] Commit message must refer to an issue
>> - [ ] Change must be properly reviewed
>> 
>> ### Integration blocker
>>  ⚠️ Dependency #865 must be integrated first
>> 
>> 
>> 
>> ### Reviewing
>> <details><summary>Using <code>git</code></summary>
>> 
>> Checkout this PR locally: \
>> `$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/881/head:pull/881` \
>> `$ git checkout pull/881`
>> 
>> Update a local copy of the PR: \
>> `$ git checkout pull/881` \
>> `$ git pull https://git.openjdk.java.net/jdk11u-dev pull/881/head`
>> 
>> </details>
>> <details><summary>Using Skara CLI tools</summary>
>> 
>> Checkout this PR locally: \
>> `$ git pr checkout 881`
>> 
>> View PR using the GUI difftool: \
>> `$ git pr show -t 881`
>> 
>> </details>
>> <details><summary>Using diff file</summary>
>> 
>> Download this PR as a diff file: \
>> <a href="https://git.openjdk.java.net/jdk11u-dev/pull/881.diff">https://git.openjdk.java.net/jdk11u-dev/pull/881.diff</a>
>> 
>> </details>
>
> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8239785: Cgroups: Incorrect detection logic on old systems in hotspot
>   
>   Return NULL subsystem if no cgroup controllers are mounted.
>   
>   Reviewed-by: bobv, mbaesken

Closing since the bug is still marked dependendent on an abandoned PR. Replacement PR is #946.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/881