[jdk11u-dev] RFR: 8235385: Crash on aarch64 JDK due to long offset [v2]

Alexey Pavlyutkin duke at openjdk.java.net
Wed Mar 30 12:08:22 UTC 2022


> Hi!
> 
> Please review "backport" of [Wang Zhuo's patch](http://cr.openjdk.java.net/~wzhuo/BigOffsetAarch64/webrev.00/jdk13u.patch) to 11u-dev. The patch is applied with the following adaptation:
> 
> - the legitimizing overload
> 
> static void loadStore(MacroAssembler masm, mem_insn insn,
>                          Register reg, int opcode,
>                          Register base, int index, int size, int disp,
>                          int size_in_memory);
> 
> ported from 15u-dev with slight changes
> -  `aarch64_enc_strh`, `aarch64_enc_strh0`, `aarch64_enc_strw`, `aarch64_enc_strw0`, `aarch64_enc_str`, and `aarch64_enc_str0` functions updated to use new loadStore() overload
> 
> Verified (18.04.6 LTS/aarch64) with the reproducers from JBS, 10 of 10 runs passed. Aproximately a half of runs crashed before I've applied the patch.
> 
> Regression (18.04.6 LTS/aarch64): hotspot_compiler
> 
> @theRealAph @AntonKozlov please take a look at that. Andrew, I could not mention Wang, if you know his ID could you mention him as well. Thank you

Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:

  removing unwanted assert

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk11u-dev/pull/960/files
  - new: https://git.openjdk.java.net/jdk11u-dev/pull/960/files/5eec99bc..26d024dd

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=960&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=960&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk11u-dev/pull/960.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/960/head:pull/960

PR: https://git.openjdk.java.net/jdk11u-dev/pull/960


More information about the jdk-updates-dev mailing list