[jdk17u-dev] RFR: 8266936: Add a finalization JFR event

[Jaroslav Bachorik]

On Mon, 2 May 2022 11:56:46 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> I think there is a difference between bug fixes and features, not just the complexity.
>
> Bug fixes are meant to increase stability. Sometimes you need to backport features, but the bar should be high and there should be a good reason, for example to support new hardware or OS versions. Improve security. Things that are essential to be able to use the existing JDK release. I don't see this JFR event fall into that category. It's also a rather large change.

I am totally getting this. My intention was to bring this up with the maintainer as a part of the backport request process - there is a trade off in the benefit to the end user and the possible risk due to unforeseen code breakages.

Also, I was under impression that the backport PR was only to establish the veracity and correctness of the said backport  and  the decision whether it would be applied or not (if the changes are judged to be correct and true) would be up to the maintainer and is to be expressed by properly labelling the main JIRA ticket.

Additionally, there seems to be some catch-22 situation here. The maintainer will not really consider the backport request unless the PR is reviewed and the PR will not be reviewed unless the maintainer pre-approves the backport?

---

The backport is now fixed and all pre-submit checks are passing. 
The change required to make things work was to mark `JfrMsg_Lock` as never requiring checkpoint check. I checked both usages of this lock and they are compatible with this mode so I changed it.

-------------

PR: https://git.openjdk.java.net/jdk17u-dev/pull/351