[jdk11u-dev] RFR: 8283323: libharfbuzz optimization level results in extreme build times
Martin Doerr
mdoerr at openjdk.java.net
Wed May 11 14:15:00 UTC 2022
On Mon, 9 May 2022 21:42:52 GMT, Tyler Steele <tsteele at openjdk.org> wrote:
> This PR backports changes to improve build performance with xlc.
>
> It appears that the file was at `make/modules/java.desktop/lib/Awt2dLibraries.gmk` when this commit was made, but that file has since been moved to `make/lib/Awt2dLibraries.gmk`. This made the change show up as a conflict when I applied this backport using the Skara tools. I resolved the 'conflict' by copying the changes to the new path and marking the previous path as removed.
You have missed the empty line deletion from the original change. Backports should be as clean and complete as possible. Besides that, LGTM. Note that I have created a clean backport PR for 17u-dev which should be done first: https://github.com/openjdk/jdk17u-dev/pull/392
-------------
PR: https://git.openjdk.java.net/jdk11u-dev/pull/1077
More information about the jdk-updates-dev
mailing list