[jdk11u-dev] RFR: 8283469: Don't use memset to initialize members in FileMapInfo and fix memory leak

[Martin Doerr]

On Fri, 13 May 2022 15:17:28 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> I would like to backport this patch to 11u, to fix a memory leak, also eliminates dangerous memset call, could potentially result in fatal crash.
> 
> The original patch does not apply cleanly:
> 1. File moved
> 2. A lot of context differences
> 
> Applied/updated patch manually.
>   
> I also bought down following code from [JDK-8261455](https://bugs.openjdk.java.net/browse/JDK-8261455), given it is a P4 enhancement, I don't see it is a candidate for backport itself. But following code obviously fixes a bug that leaves file open after use.
> 
> 
>   if (_file_open) {
>     os::close(_fd);
>   }
> 
> 
> Test:
> - [x] hotspot_cds on Linux x86_64
> - [x] hotspot_appcds on Linux x86_64
> - [x] GHA

LGTM.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/1084