[jdk11u-dev] RFR: 8133713: [macosx] Accessible JTables always reported as empty

Goetz Lindenmaier goetz at openjdk.java.net
Thu May 19 13:07:02 UTC 2022


On Thu, 19 May 2022 11:21:20 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Backport of [JDK-8133713](https://bugs.openjdk.java.net/browse/JDK-8133713)
> Required adaptation for JNF removal ([JDK-8257852](https://bugs.openjdk.java.net/browse/JDK-8257852)):
> Definition and usage of `jm_getTableInfo` in JavaComponentAccessibility.m.
> With this change, VoiceOver works for JTableAccessible.java (attached to JBS issue). Failed without this change.

Well, a non-trivial backport. Good you managed to test it! LGTM.

src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m line 2026:

> 2024:     jint count = (*env)->CallStaticIntMethod(env, jm_getTableInfo, fAccessible,
> 2025:                                              fComponent, info);
> 2026:     CHECK_EXCEPTION();

I'm not sure you need this exception check, but it does no harm so it might be better to leave it as-is.

-------------

Marked as reviewed by goetz (Reviewer).

PR: https://git.openjdk.java.net/jdk11u-dev/pull/1097


More information about the jdk-updates-dev mailing list