[jdk11u-dev] RFR: 8285720: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails to compile after backport of 8273655

[Andrew John Hughes]

On Sat, 28 May 2022 21:14:17 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This fixes the use of records only introduced in JDK 14: https://openjdk.java.net/jeps/359
> 
> There are some follow-up fixes for other platforms I'll look into backporting, but the test passes on RHEL 8 with this fix:
> 
> ----------System.out:(33/1376)----------
> probe /tmp/foo14488337544781069376.html...
> probe /tmp/red3108884171690817066.grape...
> probe /tmp/foo6837869089951986269.adoc...
> probe /tmp/foo8389174131422317612.bz2...
> probe /tmp/foo4988620374111104012.css...
> probe /tmp/foo4818065075895620664.csv...
> probe /tmp/foo958402751345496963.doc...
> probe /tmp/foo16268833507893217383.docx...
> probe /tmp/foo13767116725451453342.gz...
> probe /tmp/foo2190727723809760358.jar...
> probe /tmp/foo2326946718652087402.jpg...
> probe /tmp/foo17121899854123140210.js...
> probe /tmp/foo1191314404474601575.json...
> probe /tmp/foo13006646258648131839.markdown...
> probe /tmp/foo241898831150235828.md...
> probe /tmp/foo1517835880936399591.mp3...
> probe /tmp/foo2549235566859403869.mp4...
> probe /tmp/foo12242144981994628768.odp...
> probe /tmp/foo16152098178679385661.ods...
> probe /tmp/foo18171252621348254871.odt...
> probe /tmp/foo10191298994929497654.pdf...
> probe /tmp/foo15979417510550432068.php...
> probe /tmp/foo16720292814853298418.png...
> probe /tmp/foo3639418216222098107.ppt...
> probe /tmp/foo13237230432521217475.pptx...
> probe /tmp/foo5799266942936446338.py...
> probe /tmp/foo17790074177388230321.rar...
> probe /tmp/foo13376340736774787502.rtf...
> probe /tmp/foo4694357397367454445.webm...
> probe /tmp/foo7736758289786048051.webp...
> probe /tmp/foo9809786483236460168.xls...
> probe /tmp/foo6169776555551953686.xlsx...
> probe /tmp/foo12407933371877207699.7z...
> ----------System.err:(1/15)----------
> STATUS:Passed.

> > The test still didn't pass on my machine:
> > ```
> > Content type: text/x-python; expected: [text/plain, text/x-python-script]
> > Content type: application/rar; expected: [application/vnd.rar]
> > java.lang.RuntimeException: Test failed!
> >         at Basic.main(Basic.java:193)
> > ```
> > 
> > 
> >     
> >       
> >     
> > 
> >       
> >     
> > 
> >     
> >   
> > Nevertheless, the fix LGTM.
> 
> I also just checked. smile We need backports of [JDK-8274171](https://bugs.openjdk.java.net/browse/JDK-8274171) and [JDK-8278346](https://bugs.openjdk.java.net/browse/JDK-8278346). Unfortunately these bugs hadn't originally been linked to [JDK-8273655](https://bugs.openjdk.java.net/browse/JDK-8273655) which I now did.

Yes, these are the follow-ons I was referring to (and why I included the clean run I had). Once this is in, I'll follow-up with those two.

Bug is flagged `jdk11u-fix-request`.

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/1111