From itakiguchi at openjdk.org Tue Nov 1 04:53:32 2022 From: itakiguchi at openjdk.org (Ichiroh Takiguchi) Date: Tue, 1 Nov 2022 04:53:32 GMT Subject: [jdk11u-dev] RFR: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform In-Reply-To: References: Message-ID: On Wed, 26 Oct 2022 08:36:53 GMT, Ichiroh Takiguchi wrote: > 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform jdk11u-fix-yes is verified ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1477 From itakiguchi at openjdk.org Tue Nov 1 04:53:32 2022 From: itakiguchi at openjdk.org (Ichiroh Takiguchi) Date: Tue, 1 Nov 2022 04:53:32 GMT Subject: [jdk11u-dev] Integrated: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform In-Reply-To: References: Message-ID: On Wed, 26 Oct 2022 08:36:53 GMT, Ichiroh Takiguchi wrote: > 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform This pull request has now been integrated. Changeset: b928a88f Author: Ichiroh Takiguchi URL: https://git.openjdk.org/jdk11u-dev/commit/b928a88fd564fab88f00086a62c0695ed5cc9353 Stats: 17 lines in 1 file changed: 11 ins; 1 del; 5 mod 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform Backport-of: 3464019d7e8fe57adc910339c00ba79884c77852 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1477 From mdoerr at openjdk.org Tue Nov 1 11:27:11 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 1 Nov 2022 11:27:11 GMT Subject: [jdk17u-dev] RFR: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library [v2] In-Reply-To: References: Message-ID: On Sun, 30 Oct 2022 10:02:44 GMT, Goetz Lindenmaier wrote: >> Resolved signals_posix.cpp because test for do_check is not in 17. >> That was added by 8283337: Posix signal handler modification warning triggering incorrectly >> I add 8283337 to this backport as it is subsumed by 8292695. >> >> Resolved os.cpp due to context. >> Context was changed by "8269466: Factor out the common code for initializing and starting internal VM JavaThreads" > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Add TestBreakSignalThreadDump I forgot in the original commit Looks basically good. Only one comment change is missing. src/hotspot/os/posix/signals_posix.cpp line 1242: > 1240: #endif > 1241: > 1242: // Save handler setup for later checking JDK-8283337 changed this comment to: // Save handler setup for possible later checking ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/834 From wkemper at openjdk.org Tue Nov 1 16:54:34 2022 From: wkemper at openjdk.org (William Kemper) Date: Tue, 1 Nov 2022 16:54:34 GMT Subject: [jdk11u-dev] RFR: 8277497: Last column cell in the JTable row is read as empty cell Message-ID: Hi all, This pull request contains a backport of commit [70bad89b](https://github.com/openjdk/jdk/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Artem Semenov on 6 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal. This backport brings parity with oracle 11. Thanks! ------------- Commit messages: - Backport 70bad89b012eb200ca1e76f384a6e5fb307cf26d Changes: https://git.openjdk.org/jdk11u-dev/pull/1490/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1490&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8277497 Stats: 22 lines in 1 file changed: 22 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1490.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1490/head:pull/1490 PR: https://git.openjdk.org/jdk11u-dev/pull/1490 From duke at openjdk.org Tue Nov 1 17:04:31 2022 From: duke at openjdk.org (Scott Gibbons) Date: Tue, 1 Nov 2022 17:04:31 GMT Subject: [jdk17u-dev] RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v2] In-Reply-To: References: Message-ID: On Fri, 28 Oct 2022 20:37:04 GMT, Derek White wrote: >> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: >> >> Update .gitignore > > Hi Scott, > > Can you post the diff between this backport and the original JDK-8268276 patch? I'm guessing it's pretty small, but it will be good to see. > > Thanks! > - Derek @dwhite-intel Did I answer your question to your satisfaction? I'd appreciate a review if you have time. Thanks! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/840 From vrudomet at openjdk.org Tue Nov 1 17:07:34 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 1 Nov 2022 17:07:34 GMT Subject: [jdk11u-dev] RFR: 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile [v2] In-Reply-To: References: Message-ID: On Mon, 31 Oct 2022 22:12:19 GMT, Victor Rudometov wrote: >> Backport of >> [JDK-8287826](https://bugs.openjdk.org/browse/JDK-8287826) javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile >> >> This is second backport in a series that fixes the test first backport added. >> >> Clean backport, trivial, low risk - new test update. >> tests pass during manual run >> >> This pr depends on this pr: https://github.com/openjdk/jdk11u-dev/pull/1483 > > Victor Rudometov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 005a330387b8ee1179d1be31b53ea2c5d49c32f8 Some checks hanged (actually stopped, but here it displays as in progress). I've run them separately (https://github.com/Rudometov/jdk11u-dev/actions/runs/3367115972) all green. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1485 From vrudomet at openjdk.org Tue Nov 1 17:36:00 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 1 Nov 2022 17:36:00 GMT Subject: [jdk11u-dev] Integrated: 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile In-Reply-To: References: Message-ID: On Thu, 27 Oct 2022 22:06:06 GMT, Victor Rudometov wrote: > Backport of > [JDK-8287826](https://bugs.openjdk.org/browse/JDK-8287826) javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile > > This is second backport in a series that fixes the test first backport added. > > Clean backport, trivial, low risk - new test update. > tests pass during manual run > > This pr depends on this pr: https://github.com/openjdk/jdk11u-dev/pull/1483 This pull request has now been integrated. Changeset: 5c454ae9 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/5c454ae994ca71e05ef538bf766a4cbaec2a0b27 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile Backport-of: 005a330387b8ee1179d1be31b53ea2c5d49c32f8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1485 From phh at openjdk.org Tue Nov 1 20:07:34 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 1 Nov 2022 20:07:34 GMT Subject: [jdk11u-dev] RFR: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound [v3] In-Reply-To: References: Message-ID: On Mon, 31 Oct 2022 17:26:47 GMT, Goetz Lindenmaier wrote: >> The original fix patches jdk/internal/util/random/RandomSupport.java. >> This class is not in 11. >> >> The Random code was completely reworked by >> "8248862: Implement Enhanced Pseudo-Random Number Generators" >> In the old 11 code there are several methods 'nextDouble' or >> 'internalNextDouble' all using the same pattern. They were >> replaced by the implementation in the new class >> RandomSupport in 17. >> >> I adapted the following methods: >> in java/util/Random.java: >> final double internalNextDouble(double origin, double bound) >> >> in java/util/SplittableRandom.java >> final double internalNextDouble(double origin, double bound) >> public double nextDouble(double bound) >> >> in java/util/concurrent/ThreadLocalRandom.java >> final double internalNextDouble(double origin, double bound) >> public double nextDouble(double bound) >> >> I think this are all affected methods, but please double-check. >> >> The change requires follow-up 8280950 which needs to be >> adapted to touch the three internalNextDouble() >> methods. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove stray comments There's similar code in java.desktop/share/classes/sun/awt/geom/Curve.java, but it hasn't been updated in tip, so lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1478 From phh at openjdk.org Tue Nov 1 20:14:37 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 1 Nov 2022 20:14:37 GMT Subject: [jdk11u-dev] RFR: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix [v2] In-Reply-To: References: <15bRYfiOIuqxgcqDcfM239WtwkaSZc0FXaClOL-Ps2A=.0f5b5ff7-a48d-4229-9407-2ea0831ac877@github.com> Message-ID: On Mon, 31 Oct 2022 18:10:46 GMT, Goetz Lindenmaier wrote: >> I had to do similar resolves as in the underlying change JDK-8280550. >> >> In the test, I had to remove RandomGenerator which is not in 11. >> The same pattern can not be implemented with SplittableRandom as it is final. >> Thus, the test is no more deterministic. It depends on whether the >> rounding error actually occurs. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Make test compile with 11 Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1487 From phh at openjdk.org Tue Nov 1 20:17:26 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 1 Nov 2022 20:17:26 GMT Subject: [jdk11u-dev] RFR: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950 In-Reply-To: References: Message-ID: On Mon, 31 Oct 2022 18:08:46 GMT, Goetz Lindenmaier wrote: > I had to do similar resolves as in the two underlying changes. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1488 From phh at openjdk.org Tue Nov 1 20:51:35 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 1 Nov 2022 20:51:35 GMT Subject: [jdk11u-dev] RFR: 8261445: Use memory_order_relaxed for os::random(). In-Reply-To: References: Message-ID: <79MCnXngkmoQVp_Xso4j34AtdK0hKhZVCpVw31K7ErQ=.4a94727a-92c5-4ffe-b6f4-a5997c432530@github.com> On Wed, 26 Oct 2022 19:28:42 GMT, Victor Rudometov wrote: > Backport https://bugs.openjdk.org/browse/JDK-8261445 Use memory_order_relaxed for os::random() for jdk11u > > Backport not clean, however the change is trivial. > Tested in linux x64/aarch64: tier1, tier2, jck's passed. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1480 From phh at openjdk.org Tue Nov 1 20:55:30 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 1 Nov 2022 20:55:30 GMT Subject: [jdk17u-dev] RFR: 8295554: Move the "sizecalc.h" to the correct location In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 16:52:11 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [6673cd85](https://github.com/openjdk/jdk/commit/6673cd857722d117b108590ba7f7c02f8622fc3b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov. > Thanks! Failure is in langtools and appears unrelated. I've seen it before. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/839 From duke at openjdk.org Tue Nov 1 20:57:19 2022 From: duke at openjdk.org (Rui Li) Date: Tue, 1 Nov 2022 20:57:19 GMT Subject: [jdk17u-dev] RFR: 8287740: NSAccessibilityShowMenuAction not working for text editors Message-ID: <1cS8UY-OeqOmeIlYRiFZNiOzMYCI8z1GRtfCLUCrBVE=.574e24d0-f416-471a-a2e6-8e5ac4cb6aef@github.com> Original commit: https://github.com/openjdk/jdk/commit/b6cdfd685d0cea308b15558e2dc607a680c89dc0 JBS: https://bugs.openjdk.org/browse/JDK-8287740 Clean backport. Tested locally. Ran `test/jdk/java/awt/a11y/AccessibleActionsTest.java`. Can see pop up menu with `One`, `Two`, `Three` items. ------------- Commit messages: - Backport b6cdfd685d0cea308b15558e2dc607a680c89dc0 Changes: https://git.openjdk.org/jdk17u-dev/pull/830/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=830&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287740 Stats: 107 lines in 2 files changed: 98 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/830.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/830/head:pull/830 PR: https://git.openjdk.org/jdk17u-dev/pull/830 From duke at openjdk.org Tue Nov 1 20:57:20 2022 From: duke at openjdk.org (Rui Li) Date: Tue, 1 Nov 2022 20:57:20 GMT Subject: [jdk17u-dev] RFR: 8287740: NSAccessibilityShowMenuAction not working for text editors In-Reply-To: <1cS8UY-OeqOmeIlYRiFZNiOzMYCI8z1GRtfCLUCrBVE=.574e24d0-f416-471a-a2e6-8e5ac4cb6aef@github.com> References: <1cS8UY-OeqOmeIlYRiFZNiOzMYCI8z1GRtfCLUCrBVE=.574e24d0-f416-471a-a2e6-8e5ac4cb6aef@github.com> Message-ID: <_PwWn1IBgK-TYRP42FITVjynQ-eQGlyAhf5PPJDxnjw=.1b58495e-5606-488e-aeca-1a07a6b2884b@github.com> On Tue, 25 Oct 2022 03:31:14 GMT, Rui Li wrote: > Original commit: https://github.com/openjdk/jdk/commit/b6cdfd685d0cea308b15558e2dc607a680c89dc0 > > JBS: https://bugs.openjdk.org/browse/JDK-8287740 > > Clean backport. > > Tested locally. Ran `test/jdk/java/awt/a11y/AccessibleActionsTest.java`. Can see pop up menu with `One`, `Two`, `Three` items. Still running git hub action: https://github.com/rgithubli/jdk17u-dev/actions/workflows/main.yml ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/830 From duke at openjdk.org Tue Nov 1 21:10:31 2022 From: duke at openjdk.org (Scott Gibbons) Date: Tue, 1 Nov 2022 21:10:31 GMT Subject: [jdk17u-dev] RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v3] In-Reply-To: <2OAEPLwykVb_jnoj5P_pJTa6BNebcMb8KHLZi_cWThM=.a166cc77-9d71-4db1-acd9-1823c6abe1b6@github.com> References: <2OAEPLwykVb_jnoj5P_pJTa6BNebcMb8KHLZi_cWThM=.a166cc77-9d71-4db1-acd9-1823c6abe1b6@github.com> Message-ID: On Mon, 31 Oct 2022 20:26:26 GMT, Scott Gibbons wrote: >> This is a backport of JDK-8268276: Base64 Decoding optimization for x86 using AVX-512. >> >> We have had numerous customer requests for this functionality to be backported due to the ~19x performance improvement. >> >> Original patch does not apply cleanly to 17u, because of a bug that was identified in the original commit, but not fixed until the later Base64 Encode acceleration enhancement was complete. The fix is on line 6039 of src/hotspot/cpu/x86/stubGenerator_x86_64.cpp and has been included in this PR. All four "translatedX" registers needed to be checked for illegal characters in the input stream. >> >> Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. >> >> Testing: x86_64 build, affected tests, tier1, tier2 >> >> Thanks, >> --Scott > > Scott Gibbons has updated the pull request incrementally with two additional commits since the last revision: > > - Merge branch 'Decode-backport' of https://github.com/asgibbons/jdk17u-dev into Decode-backport > - Hand-merging bugfix 9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e So, the original patch applied cleanly, then I included the two bugfixes that were subsequently found (JDK-8273108 and JDK-8269404), one relating to improper illegal character discovery and the other relating to writing past end-of-string. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/840 From duke at openjdk.org Tue Nov 1 21:53:03 2022 From: duke at openjdk.org (Rui Li) Date: Tue, 1 Nov 2022 21:53:03 GMT Subject: [jdk17u-dev] RFR: 8275569: Add linux-aarch64 to test-make profiles Message-ID: Clean backport Original commit: https://github.com/openjdk/jdk/commit/af14650127de47058b958be411503584c0ba6323 JBS: https://bugs.openjdk.org/browse/JDK-8275569 ------------- Commit messages: - Backport af14650127de47058b958be411503584c0ba6323 Changes: https://git.openjdk.org/jdk17u-dev/pull/850/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=850&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275569 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/850.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/850/head:pull/850 PR: https://git.openjdk.org/jdk17u-dev/pull/850 From duke at openjdk.org Tue Nov 1 21:54:54 2022 From: duke at openjdk.org (Rui Li) Date: Tue, 1 Nov 2022 21:54:54 GMT Subject: [jdk17u-dev] Withdrawn: 8275569: Add linux-aarch64 to test-make profiles In-Reply-To: References: Message-ID: On Tue, 1 Nov 2022 21:44:31 GMT, Rui Li wrote: > Clean backport > > Original commit: https://github.com/openjdk/jdk/commit/af14650127de47058b958be411503584c0ba6323 > JBS: https://bugs.openjdk.org/browse/JDK-8275569 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/850 From duke at openjdk.org Tue Nov 1 22:02:11 2022 From: duke at openjdk.org (Rui Li) Date: Tue, 1 Nov 2022 22:02:11 GMT Subject: [jdk17u-dev] RFR: 8275569: Add linux-aarch64 to test-make profiles Message-ID: Clean backport Original commit: https://github.com/openjdk/jdk/commit/af14650127de47058b958be411503584c0ba6323 JBS: https://bugs.openjdk.org/browse/JDK-8275569 ------------- Commit messages: - Backport af14650127de47058b958be411503584c0ba6323 Changes: https://git.openjdk.org/jdk17u-dev/pull/851/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=851&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275569 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/851.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/851/head:pull/851 PR: https://git.openjdk.org/jdk17u-dev/pull/851 From drwhite at openjdk.org Tue Nov 1 22:07:47 2022 From: drwhite at openjdk.org (Derek White) Date: Tue, 1 Nov 2022 22:07:47 GMT Subject: [jdk17u-dev] RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v3] In-Reply-To: <2OAEPLwykVb_jnoj5P_pJTa6BNebcMb8KHLZi_cWThM=.a166cc77-9d71-4db1-acd9-1823c6abe1b6@github.com> References: <2OAEPLwykVb_jnoj5P_pJTa6BNebcMb8KHLZi_cWThM=.a166cc77-9d71-4db1-acd9-1823c6abe1b6@github.com> Message-ID: On Mon, 31 Oct 2022 20:26:26 GMT, Scott Gibbons wrote: >> This is a backport of JDK-8268276: Base64 Decoding optimization for x86 using AVX-512. >> >> We have had numerous customer requests for this functionality to be backported due to the ~19x performance improvement. >> >> Original patch does not apply cleanly to 17u, because of a bug that was identified in the original commit, but not fixed until the later Base64 Encode acceleration enhancement was complete. The fix is on line 6039 of src/hotspot/cpu/x86/stubGenerator_x86_64.cpp and has been included in this PR. All four "translatedX" registers needed to be checked for illegal characters in the input stream. >> >> Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. >> >> Testing: x86_64 build, affected tests, tier1, tier2 >> >> Thanks, >> --Scott > > Scott Gibbons has updated the pull request incrementally with two additional commits since the last revision: > > - Merge branch 'Decode-backport' of https://github.com/asgibbons/jdk17u-dev into Decode-backport > - Hand-merging bugfix 9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e This looks good to me. Still need a (R)eviewer. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/840 From phh at openjdk.org Tue Nov 1 22:09:46 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 1 Nov 2022 22:09:46 GMT Subject: [jdk17u-dev] RFR: 8275569: Add linux-aarch64 to test-make profiles In-Reply-To: References: Message-ID: On Tue, 1 Nov 2022 21:53:05 GMT, Rui Li wrote: > Clean backport > > Original commit: https://github.com/openjdk/jdk/commit/af14650127de47058b958be411503584c0ba6323 > JBS: https://bugs.openjdk.org/browse/JDK-8275569 Tagged JBS issue. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/851 From phh at openjdk.org Tue Nov 1 22:28:45 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 1 Nov 2022 22:28:45 GMT Subject: [jdk17u-dev] RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v3] In-Reply-To: <2OAEPLwykVb_jnoj5P_pJTa6BNebcMb8KHLZi_cWThM=.a166cc77-9d71-4db1-acd9-1823c6abe1b6@github.com> References: <2OAEPLwykVb_jnoj5P_pJTa6BNebcMb8KHLZi_cWThM=.a166cc77-9d71-4db1-acd9-1823c6abe1b6@github.com> Message-ID: On Mon, 31 Oct 2022 20:26:26 GMT, Scott Gibbons wrote: >> This is a backport of JDK-8268276: Base64 Decoding optimization for x86 using AVX-512. >> >> We have had numerous customer requests for this functionality to be backported due to the ~19x performance improvement. >> >> Original patch does not apply cleanly to 17u, because of a bug that was identified in the original commit, but not fixed until the later Base64 Encode acceleration enhancement was complete. The fix is on line 6039 of src/hotspot/cpu/x86/stubGenerator_x86_64.cpp and has been included in this PR. All four "translatedX" registers needed to be checked for illegal characters in the input stream. >> >> Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. >> >> Testing: x86_64 build, affected tests, tier1, tier2 >> >> Thanks, >> --Scott > > Scott Gibbons has updated the pull request incrementally with two additional commits since the last revision: > > - Merge branch 'Decode-backport' of https://github.com/asgibbons/jdk17u-dev into Decode-backport > - Hand-merging bugfix 9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e Looks like you didn't backport the change to .gitignore. Seems unrelated to the rest of the patch, but harmless enough. Other than that, lgtm. ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/840 From duke at openjdk.org Tue Nov 1 22:50:45 2022 From: duke at openjdk.org (zzambers) Date: Tue, 1 Nov 2022 22:50:45 GMT Subject: [jdk17u-dev] RFR: 8295714: GHA ::set-output is deprecated and will be removed Message-ID: This backport fixes warnings generated in GHA summary page by use of deprecated `set-output` command. According to warning messages command will be removed soon: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/` Clean backport, all tests passed (no warnings). ------------- Commit messages: - Backport b35922be6de7b848a2982d6a278dbd205fc39e6a Changes: https://git.openjdk.org/jdk17u-dev/pull/852/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=852&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295714 Stats: 28 lines in 11 files changed: 1 ins; 0 del; 27 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/852.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/852/head:pull/852 PR: https://git.openjdk.org/jdk17u-dev/pull/852 From phh at openjdk.org Tue Nov 1 22:53:39 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 1 Nov 2022 22:53:39 GMT Subject: [jdk17u-dev] RFR: 8287740: NSAccessibilityShowMenuAction not working for text editors In-Reply-To: <1cS8UY-OeqOmeIlYRiFZNiOzMYCI8z1GRtfCLUCrBVE=.574e24d0-f416-471a-a2e6-8e5ac4cb6aef@github.com> References: <1cS8UY-OeqOmeIlYRiFZNiOzMYCI8z1GRtfCLUCrBVE=.574e24d0-f416-471a-a2e6-8e5ac4cb6aef@github.com> Message-ID: On Tue, 25 Oct 2022 03:31:14 GMT, Rui Li wrote: > Original commit: https://github.com/openjdk/jdk/commit/b6cdfd685d0cea308b15558e2dc607a680c89dc0 > > JBS: https://bugs.openjdk.org/browse/JDK-8287740 > > Clean backport. > > Tested locally. Ran `test/jdk/java/awt/a11y/AccessibleActionsTest.java`. Can see pop up menu with `One`, `Two`, `Three` items. JBS issue tagged ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/830 From duke at openjdk.org Tue Nov 1 23:55:11 2022 From: duke at openjdk.org (Scott Gibbons) Date: Tue, 1 Nov 2022 23:55:11 GMT Subject: [jdk17u-dev] RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v3] In-Reply-To: References: <2OAEPLwykVb_jnoj5P_pJTa6BNebcMb8KHLZi_cWThM=.a166cc77-9d71-4db1-acd9-1823c6abe1b6@github.com> Message-ID: On Tue, 1 Nov 2022 22:26:44 GMT, Paul Hohensee wrote: >> Scott Gibbons has updated the pull request incrementally with two additional commits since the last revision: >> >> - Merge branch 'Decode-backport' of https://github.com/asgibbons/jdk17u-dev into Decode-backport >> - Hand-merging bugfix 9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e > > Looks like you didn't backport the change to .gitignore. Seems unrelated to the rest of the patch, but harmless enough. > > Other than that, lgtm. Thanks, @phohensee . This is an unneeded artifact of me using VS for editing. I do not believe it affects anything. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/840 From goetz at openjdk.org Wed Nov 2 07:58:15 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Nov 2022 07:58:15 GMT Subject: [jdk11u-dev] RFR: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound [v3] In-Reply-To: References: Message-ID: <5ZWlUgpB_DdZhZQN75JJZDvgFUUtSJucJH7QlG-CJzU=.b671dc5c-9c58-4544-a46d-1bfee5fb29e6@github.com> On Mon, 31 Oct 2022 17:26:47 GMT, Goetz Lindenmaier wrote: >> The original fix patches jdk/internal/util/random/RandomSupport.java. >> This class is not in 11. >> >> The Random code was completely reworked by >> "8248862: Implement Enhanced Pseudo-Random Number Generators" >> In the old 11 code there are several methods 'nextDouble' or >> 'internalNextDouble' all using the same pattern. They were >> replaced by the implementation in the new class >> RandomSupport in 17. >> >> I adapted the following methods: >> in java/util/Random.java: >> final double internalNextDouble(double origin, double bound) >> >> in java/util/SplittableRandom.java >> final double internalNextDouble(double origin, double bound) >> public double nextDouble(double bound) >> >> in java/util/concurrent/ThreadLocalRandom.java >> final double internalNextDouble(double origin, double bound) >> public double nextDouble(double bound) >> >> I think this are all affected methods, but please double-check. >> >> The change requires follow-up 8280950 which needs to be >> adapted to touch the three internalNextDouble() >> methods. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove stray comments Good catch of this further appearance. I agree the fix is not needed there. But the methods there might not always deliver the previous double either. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1478 From goetz at openjdk.org Wed Nov 2 08:03:31 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Nov 2022 08:03:31 GMT Subject: [jdk17u-dev] RFR: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library [v3] In-Reply-To: References: Message-ID: > Resolved signals_posix.cpp because test for do_check is not in 17. > That was added by 8283337: Posix signal handler modification warning triggering incorrectly > I add 8283337 to this backport as it is subsumed by 8292695. > > Resolved os.cpp due to context. > Context was changed by "8269466: Factor out the common code for initializing and starting internal VM JavaThreads" Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Update signals_posix.cpp Adapt comment ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/834/files - new: https://git.openjdk.org/jdk17u-dev/pull/834/files/67611936..4159c44a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=834&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=834&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/834.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/834/head:pull/834 PR: https://git.openjdk.org/jdk17u-dev/pull/834 From goetz at openjdk.org Wed Nov 2 08:51:24 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Nov 2022 08:51:24 GMT Subject: [jdk11u-dev] RFR: 8277497: Last column cell in the JTable row is read as empty cell In-Reply-To: References: Message-ID: On Tue, 1 Nov 2022 16:46:32 GMT, William Kemper wrote: > Hi all, > > This pull request contains a backport of commit [70bad89b](https://github.com/openjdk/jdk/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Artem Semenov on 6 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal. This backport brings parity with oracle 11. > > Thanks! Hi @earthling-amzn, you should not integrate if you don not have the jdk11u-fix-yes label. Please follow https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix How did you test the backport? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1490 From mbaesken at openjdk.org Wed Nov 2 08:59:49 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 2 Nov 2022 08:59:49 GMT Subject: [jdk17u-dev] Integrated: 8287011: Improve container information In-Reply-To: References: Message-ID: On Wed, 26 Oct 2022 12:45:16 GMT, Matthias Baesken wrote: > backport of 8287011 This pull request has now been integrated. Changeset: e6093985 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/e60939850e5328b9c0f2002ac5ed7744375bf18b Stats: 125 lines in 9 files changed: 104 ins; 13 del; 8 mod 8287011: Improve container information Reviewed-by: lucy, mdoerr Backport-of: d51f4f471f3941294a987dcb68ee264fe27f018a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/844 From mbaesken at openjdk.org Wed Nov 2 09:21:10 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 2 Nov 2022 09:21:10 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event Message-ID: backport of 8289524 ------------- Commit messages: - Backport dfbc6919e1e233b42aede97f1323ce5529fab7cf Changes: https://git.openjdk.org/jdk17u-dev/pull/853/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=853&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289524 Stats: 134 lines in 8 files changed: 129 ins; 5 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/853.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/853/head:pull/853 PR: https://git.openjdk.org/jdk17u-dev/pull/853 From mdoerr at openjdk.org Wed Nov 2 09:34:11 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 2 Nov 2022 09:34:11 GMT Subject: [jdk17u-dev] RFR: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library [v3] In-Reply-To: References: Message-ID: <8_MqPvenCvR5JunMminqM5Ajju1h5z2ID89izHmjD0o=.7164fefd-7b27-4a20-a579-27222fb9feed@github.com> On Wed, 2 Nov 2022 08:03:31 GMT, Goetz Lindenmaier wrote: >> Resolved signals_posix.cpp because test for do_check is not in 17. >> That was added by 8283337: Posix signal handler modification warning triggering incorrectly >> I add 8283337 to this backport as it is subsumed by 8292695. >> >> Resolved os.cpp due to context. >> Context was changed by "8269466: Factor out the common code for initializing and starting internal VM JavaThreads" > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Update signals_posix.cpp > > Adapt comment Thumbs up! Thanks for backporting! ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/834 From goetz at openjdk.org Wed Nov 2 10:00:14 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Nov 2022 10:00:14 GMT Subject: [jdk17u-dev] RFR: 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation Message-ID: I backport this for parity with 17.0.6-oracle. ------------- Commit messages: - Backport a5e4def526697d88ff31a5fdb41d823b899372f2 Changes: https://git.openjdk.org/jdk17u-dev/pull/854/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=854&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8265489 Stats: 55 lines in 5 files changed: 8 ins; 15 del; 32 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/854.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/854/head:pull/854 PR: https://git.openjdk.org/jdk17u-dev/pull/854 From yan at openjdk.org Wed Nov 2 10:10:57 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 2 Nov 2022 10:10:57 GMT Subject: [jdk13u-dev] RFR: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present Message-ID: clean backport of the fix to jdeps. All relevant tests do pass. ------------- Commit messages: - Backport 953ce8da2c7ddd60b09a18c7875616a2477e5ba5 Changes: https://git.openjdk.org/jdk13u-dev/pull/424/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=424&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293701 Stats: 268 lines in 8 files changed: 264 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/424.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/424/head:pull/424 PR: https://git.openjdk.org/jdk13u-dev/pull/424 From yan at openjdk.org Wed Nov 2 10:11:06 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 2 Nov 2022 10:11:06 GMT Subject: [jdk15u-dev] RFR: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present Message-ID: clean backport of the fix to jdeps. All relevant tests do pass. ------------- Commit messages: - Backport 953ce8da2c7ddd60b09a18c7875616a2477e5ba5 Changes: https://git.openjdk.org/jdk15u-dev/pull/298/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=298&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293701 Stats: 268 lines in 8 files changed: 264 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/298.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/298/head:pull/298 PR: https://git.openjdk.org/jdk15u-dev/pull/298 From yan at openjdk.org Wed Nov 2 10:38:23 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 2 Nov 2022 10:38:23 GMT Subject: [jdk15u-dev] Integrated: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 10:01:55 GMT, Yuri Nesterenko wrote: > clean backport of the fix to jdeps. All relevant tests do pass. This pull request has now been integrated. Changeset: 0f171ecc Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/0f171ecce8374e525f7f9a0f459239c2e09fbf87 Stats: 268 lines in 8 files changed: 264 ins; 0 del; 4 mod 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present Backport-of: 953ce8da2c7ddd60b09a18c7875616a2477e5ba5 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/298 From yan at openjdk.org Wed Nov 2 10:39:13 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 2 Nov 2022 10:39:13 GMT Subject: [jdk13u-dev] Integrated: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 10:02:02 GMT, Yuri Nesterenko wrote: > clean backport of the fix to jdeps. All relevant tests do pass. This pull request has now been integrated. Changeset: 1db35b2e Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/1db35b2e40ca6c4ee31e170e96683863463826c1 Stats: 268 lines in 8 files changed: 264 ins; 0 del; 4 mod 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present Backport-of: 953ce8da2c7ddd60b09a18c7875616a2477e5ba5 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/424 From egahlin at openjdk.org Wed Nov 2 11:17:29 2022 From: egahlin at openjdk.org (Erik Gahlin) Date: Wed, 2 Nov 2022 11:17:29 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 09:13:56 GMT, Matthias Baesken wrote: > backport of 8289524 This is an enhancement. The bar for backporting events should be high. This PR also changes metadata of an existing event (adds a new field) which increases the risk for issues. The event is enabled by default, so it will have an impact on existing recordings running in production. It also contains a bug (JDK-8295419, fixed in mainline). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From mbaesken at openjdk.org Wed Nov 2 11:26:39 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 2 Nov 2022 11:26:39 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 09:13:56 GMT, Matthias Baesken wrote: > backport of 8289524 I am aware of the name change done in JDK-8295419, would backport this afterwards. Regarding >This PR also changes metadata of an existing event Yes sure it does , if it is such a bad concern it would be possible to separate the CodeCacheFull related change from the backport, not sure if this is really an issue in practise. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From egahlin at openjdk.org Wed Nov 2 11:49:33 2022 From: egahlin at openjdk.org (Erik Gahlin) Date: Wed, 2 Nov 2022 11:49:33 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 09:13:56 GMT, Matthias Baesken wrote: > backport of 8289524 Why is this enhancement needed in an update release? I don't doubt the event has some use, all have or they would not be integrated into mainline. I just don't see what makes this event special. If a user upgrades to get the latest security fixes, and this event (or similar) is included and for some reason causes issues, how can it be explained? Why is it so important? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From mbaesken at openjdk.org Wed Nov 2 12:13:40 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 2 Nov 2022 12:13:40 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 09:13:56 GMT, Matthias Baesken wrote: > backport of 8289524 Having a couple of additional interesting (and not too complex !) events in the latest LTS is not a bad thing but this is my personal impression. On the other hand I do not care that much, if it is rejected than probably all additional events would be rejected because the others I looked at that were interesting were more complex. Our users will avoid non-LTS releases because of the effort and investment costs , so this means Sept 2023 + probably ~ one more year of testing etc. , until they can consume other interesting JFR events that came in after 17 , quite a long time I think. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From goetz at openjdk.org Wed Nov 2 12:41:54 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Nov 2022 12:41:54 GMT Subject: [jdk11u-dev] RFR: 8282730: LdapLoginModule throw NPE from logout method after login failure Message-ID: I backport this for parity with 11.0.18-oracle. I had to resolve 6 Copyrights. Will mark as clean. Copyrights in these files: src/java.base/share/classes/javax/security/auth/login/LoginContext.java src/java.management/share/classes/com/sun/jmx/remote/security/FileLoginModule.java src/jdk.security.auth/share/classes/com/sun/security/auth/module/JndiLoginModule.java src/jdk.security.auth/share/classes/com/sun/security/auth/module/LdapLoginModule.java src/jdk.security.auth/share/classes/com/sun/security/auth/module/NTLoginModule.java src/jdk.security.auth/share/classes/com/sun/security/auth/module/UnixLoginModule.java ------------- Commit messages: - Backport 554f44ecb1134acff3eaf02e2e1c0e01158ab7e5 Changes: https://git.openjdk.org/jdk11u-dev/pull/1491/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1491&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282730 Stats: 223 lines in 11 files changed: 151 ins; 2 del; 70 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1491.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1491/head:pull/1491 PR: https://git.openjdk.org/jdk11u-dev/pull/1491 From goetz at openjdk.org Wed Nov 2 13:37:41 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Nov 2022 13:37:41 GMT Subject: [jdk11u-dev] RFR: 8295429: Update harfbuzz md file Message-ID: I backport this for parity with 11.0.18-oracle. Backport from 17 because that is clean. ------------- Commit messages: - Backport cb9289ed7589e2cfbe8ac21ab6f3039ee09216ea Changes: https://git.openjdk.org/jdk11u-dev/pull/1493/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1493&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295429 Stats: 16 lines in 1 file changed: 8 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1493.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1493/head:pull/1493 PR: https://git.openjdk.org/jdk11u-dev/pull/1493 From phh at openjdk.org Wed Nov 2 13:48:31 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 2 Nov 2022 13:48:31 GMT Subject: [jdk17u-dev] RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v3] In-Reply-To: <2OAEPLwykVb_jnoj5P_pJTa6BNebcMb8KHLZi_cWThM=.a166cc77-9d71-4db1-acd9-1823c6abe1b6@github.com> References: <2OAEPLwykVb_jnoj5P_pJTa6BNebcMb8KHLZi_cWThM=.a166cc77-9d71-4db1-acd9-1823c6abe1b6@github.com> Message-ID: On Mon, 31 Oct 2022 20:26:26 GMT, Scott Gibbons wrote: >> This is a backport of JDK-8268276: Base64 Decoding optimization for x86 using AVX-512. >> >> We have had numerous customer requests for this functionality to be backported due to the ~19x performance improvement. >> >> Original patch does not apply cleanly to 17u, because of a bug that was identified in the original commit, but not fixed until the later Base64 Encode acceleration enhancement was complete. The fix is on line 6039 of src/hotspot/cpu/x86/stubGenerator_x86_64.cpp and has been included in this PR. All four "translatedX" registers needed to be checked for illegal characters in the input stream. >> >> Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. >> >> Testing: x86_64 build, affected tests, tier1, tier2 >> >> Thanks, >> --Scott > > Scott Gibbons has updated the pull request incrementally with two additional commits since the last revision: > > - Merge branch 'Decode-backport' of https://github.com/asgibbons/jdk17u-dev into Decode-backport > - Hand-merging bugfix 9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e Yes, it doesn't affect anything, but might be a merge conflict down the line. Let's see what the approvers say. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/840 From itakiguchi at openjdk.org Wed Nov 2 14:10:54 2022 From: itakiguchi at openjdk.org (Ichiroh Takiguchi) Date: Wed, 2 Nov 2022 14:10:54 GMT Subject: [jdk19u] RFR: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform In-Reply-To: References: Message-ID: On Wed, 19 Oct 2022 17:12:37 GMT, Ichiroh Takiguchi wrote: > 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform jdk19u-fix-yes is verified ------------- PR: https://git.openjdk.org/jdk19u/pull/49 From phh at openjdk.org Wed Nov 2 14:11:41 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 2 Nov 2022 14:11:41 GMT Subject: [jdk11u-dev] RFR: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound [v3] In-Reply-To: References: Message-ID: On Mon, 31 Oct 2022 17:26:47 GMT, Goetz Lindenmaier wrote: >> The original fix patches jdk/internal/util/random/RandomSupport.java. >> This class is not in 11. >> >> The Random code was completely reworked by >> "8248862: Implement Enhanced Pseudo-Random Number Generators" >> In the old 11 code there are several methods 'nextDouble' or >> 'internalNextDouble' all using the same pattern. They were >> replaced by the implementation in the new class >> RandomSupport in 17. >> >> I adapted the following methods: >> in java/util/Random.java: >> final double internalNextDouble(double origin, double bound) >> >> in java/util/SplittableRandom.java >> final double internalNextDouble(double origin, double bound) >> public double nextDouble(double bound) >> >> in java/util/concurrent/ThreadLocalRandom.java >> final double internalNextDouble(double origin, double bound) >> public double nextDouble(double bound) >> >> I think this are all affected methods, but please double-check. >> >> The change requires follow-up 8280950 which needs to be >> adapted to touch the three internalNextDouble() >> methods. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove stray comments Perhaps file a bug against tip, fix it, and backport. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1478 From itakiguchi at openjdk.org Wed Nov 2 14:12:31 2022 From: itakiguchi at openjdk.org (Ichiroh Takiguchi) Date: Wed, 2 Nov 2022 14:12:31 GMT Subject: [jdk19u] Integrated: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform In-Reply-To: References: Message-ID: On Wed, 19 Oct 2022 17:12:37 GMT, Ichiroh Takiguchi wrote: > 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform This pull request has now been integrated. Changeset: 25448dc7 Author: Ichiroh Takiguchi URL: https://git.openjdk.org/jdk19u/commit/25448dc7ea587d5c08025e7f24e99e51d6f74c56 Stats: 17 lines in 1 file changed: 11 ins; 1 del; 5 mod 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform Backport-of: 3464019d7e8fe57adc910339c00ba79884c77852 ------------- PR: https://git.openjdk.org/jdk19u/pull/49 From goetz at openjdk.org Wed Nov 2 14:49:49 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 2 Nov 2022 14:49:49 GMT Subject: [jdk17u-dev] RFR: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary In-Reply-To: References: Message-ID: <5phE-qdliUQ_A-t_-ucGoVKB8_wQplQfWiYARV6-ARg=.20ec0bc1-0c71-450b-a9e9-bd201bf0e468@github.com> On Wed, 21 Sep 2022 11:22:31 GMT, zzambers wrote: > Backport fixing SSLSocket, not to use workaround with user_canceled alert for TLS 1.3 close, when not necessary, as it causes problems with gnutls client. > > Applied cleanly. Passed jdk_security tests. Pre-submit failure: infra issue ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/709 From duke at openjdk.org Wed Nov 2 14:53:16 2022 From: duke at openjdk.org (zzambers) Date: Wed, 2 Nov 2022 14:53:16 GMT Subject: [jdk17u-dev] Integrated: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary In-Reply-To: References: Message-ID: On Wed, 21 Sep 2022 11:22:31 GMT, zzambers wrote: > Backport fixing SSLSocket, not to use workaround with user_canceled alert for TLS 1.3 close, when not necessary, as it causes problems with gnutls client. > > Applied cleanly. Passed jdk_security tests. This pull request has now been integrated. Changeset: eef3c960 Author: Zdenek Zambersky Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/eef3c9605e2d75fc5724118fd0140b7844daa6e8 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary Backport-of: 7e88ff8a82cefa2a20acc9d5a9e42858d60fe3a3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/709 From duke at openjdk.org Wed Nov 2 15:14:36 2022 From: duke at openjdk.org (zzambers) Date: Wed, 2 Nov 2022 15:14:36 GMT Subject: [jdk17u-dev] RFR: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary In-Reply-To: <5phE-qdliUQ_A-t_-ucGoVKB8_wQplQfWiYARV6-ARg=.20ec0bc1-0c71-450b-a9e9-bd201bf0e468@github.com> References: <5phE-qdliUQ_A-t_-ucGoVKB8_wQplQfWiYARV6-ARg=.20ec0bc1-0c71-450b-a9e9-bd201bf0e468@github.com> Message-ID: On Wed, 2 Nov 2022 14:47:28 GMT, Goetz Lindenmaier wrote: >> Backport fixing SSLSocket, not to use workaround with user_canceled alert for TLS 1.3 close, when not necessary, as it causes problems with gnutls client. >> >> Applied cleanly. Passed jdk_security tests. > > Pre-submit failure: infra issue @GoeLin Thank you ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/709 From cushon at google.com Wed Nov 2 15:21:07 2022 From: cushon at google.com (Liam Miller-Cushon) Date: Wed, 2 Nov 2022 08:21:07 -0700 Subject: CLDR updates Message-ID: Hello, I noticed that CLDR updates are generally not backported to update releases. There are some parallels to timezone data updates, which are backported (e.g. JDK-8292579). I couldn't find previous discussion of this, is it something that's been considered and rejected? Thanks, Liam -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Wed Nov 2 17:16:09 2022 From: duke at openjdk.org (Joshua Cao) Date: Wed, 2 Nov 2022 17:16:09 GMT Subject: [jdk11u-dev] Integrated: 8199290: [TESTBUG] sun.hotspot.WhiteBox$WhiteBoxPermission is not copied In-Reply-To: References: Message-ID: On Mon, 10 Oct 2022 20:13:17 GMT, Joshua Cao wrote: > Not a clean backport because JarBuilder.java does not exist in JDK11. Changes in ClassFileInstaller.java are clean. > > This change fixes the repro in the JBS issue. This pull request has now been integrated. Changeset: 82c9cf2c Author: Joshua Cao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/82c9cf2c3f68e12e1574f5623c83714ed20c78ca Stats: 42 lines in 1 file changed: 33 ins; 0 del; 9 mod 8199290: [TESTBUG] sun.hotspot.WhiteBox$WhiteBoxPermission is not copied Reviewed-by: phh Backport-of: 8b2453f93b064d36d589cedd8dd45ca4962e8979 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1432 From manc at google.com Wed Nov 2 17:19:41 2022 From: manc at google.com (Man Cao) Date: Wed, 2 Nov 2022 10:19:41 -0700 Subject: [jdk19u] Sponsoring for backport 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library In-Reply-To: References: Message-ID: Hi all, Could anyone help sponsor pushing this backport into JDK 19u? https://github.com/openjdk/jdk19u/pull/59 It has been approved in https://bugs.openjdk.org/browse/JDK-8292695. Thanks, Man On Wed, Nov 2, 2022 at 10:12 AM openjdk[bot] wrote: > @caoman > Your change (at version 115b954 > ) > is now ready to be sponsored by a Committer. > > ? > Reply to this email directly, view it on GitHub > , or > unsubscribe > > . > You are receiving this because you were mentioned.Message ID: > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From aivanov at openjdk.org Wed Nov 2 18:43:44 2022 From: aivanov at openjdk.org (Alexey Ivanov) Date: Wed, 2 Nov 2022 18:43:44 GMT Subject: [jdk19u] RFR: 8295554: Move the "sizecalc.h" to the correct location In-Reply-To: <41Cu1ZCdAYTIyU8e6yTCa5NcU-etJTzQjPERy6jPFHg=.497185ab-9634-403f-b73e-2c4edd6ab166@github.com> References: <41Cu1ZCdAYTIyU8e6yTCa5NcU-etJTzQjPERy6jPFHg=.497185ab-9634-403f-b73e-2c4edd6ab166@github.com> Message-ID: On Tue, 25 Oct 2022 16:46:59 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [6673cd85](https://github.com/openjdk/jdk/commit/6673cd857722d117b108590ba7f7c02f8622fc3b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov. > Thanks! The bug has now `jdk19u-fix-yes` which it means it can be integrated to 19u. ------------- PR: https://git.openjdk.org/jdk19u/pull/57 From duke at openjdk.org Wed Nov 2 21:34:56 2022 From: duke at openjdk.org (Rui Li) Date: Wed, 2 Nov 2022 21:34:56 GMT Subject: [jdk17u-dev] Integrated: 8275569: Add linux-aarch64 to test-make profiles In-Reply-To: References: Message-ID: <3PAzEpW_paqe88pdjPU5LjL-QZQPfXK6XamSon5qgas=.598bc013-c377-4246-9ad9-563cbd3d2c0d@github.com> On Tue, 1 Nov 2022 21:53:05 GMT, Rui Li wrote: > Clean backport > > Original commit: https://github.com/openjdk/jdk/commit/af14650127de47058b958be411503584c0ba6323 > JBS: https://bugs.openjdk.org/browse/JDK-8275569 This pull request has now been integrated. Changeset: b37d7df4 Author: Rui Li Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/b37d7df487ba94f27ec591ee33721cd7d3c04e58 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8275569: Add linux-aarch64 to test-make profiles Backport-of: af14650127de47058b958be411503584c0ba6323 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/851 From duke at openjdk.org Wed Nov 2 21:37:42 2022 From: duke at openjdk.org (Rui Li) Date: Wed, 2 Nov 2022 21:37:42 GMT Subject: [jdk17u-dev] Integrated: 8287740: NSAccessibilityShowMenuAction not working for text editors In-Reply-To: <1cS8UY-OeqOmeIlYRiFZNiOzMYCI8z1GRtfCLUCrBVE=.574e24d0-f416-471a-a2e6-8e5ac4cb6aef@github.com> References: <1cS8UY-OeqOmeIlYRiFZNiOzMYCI8z1GRtfCLUCrBVE=.574e24d0-f416-471a-a2e6-8e5ac4cb6aef@github.com> Message-ID: <0JuRYG5pIfn0AD4aWl84FmGFLMMvHayllgWs1_HU3C8=.50286263-590a-4c46-b923-b58ad21d62de@github.com> On Tue, 25 Oct 2022 03:31:14 GMT, Rui Li wrote: > Original commit: https://github.com/openjdk/jdk/commit/b6cdfd685d0cea308b15558e2dc607a680c89dc0 > > JBS: https://bugs.openjdk.org/browse/JDK-8287740 > > Clean backport. > > Tested locally. Ran `test/jdk/java/awt/a11y/AccessibleActionsTest.java`. Can see pop up menu with `One`, `Two`, `Three` items. This pull request has now been integrated. Changeset: 092be507 Author: Rui Li Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/092be5071e22f0c1993d2db9716241a08e82b435 Stats: 107 lines in 2 files changed: 98 ins; 6 del; 3 mod 8287740: NSAccessibilityShowMenuAction not working for text editors Backport-of: b6cdfd685d0cea308b15558e2dc607a680c89dc0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/830 From manc at openjdk.org Thu Nov 3 00:00:36 2022 From: manc at openjdk.org (Man Cao) Date: Thu, 3 Nov 2022 00:00:36 GMT Subject: [jdk19u] Integrated: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library In-Reply-To: References: Message-ID: On Sat, 29 Oct 2022 06:28:08 GMT, Man Cao wrote: > Backport of https://bugs.openjdk.org/browse/JDK-8292695 This pull request has now been integrated. Changeset: 41677c17 Author: Man Cao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk19u/commit/41677c17f36f0b0de4146a083f5e576337718327 Stats: 138 lines in 4 files changed: 116 ins; 11 del; 11 mod 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library Backport-of: 45ff10cc68296c7c73d0eafe6fcc9946ab98267e ------------- PR: https://git.openjdk.org/jdk19u/pull/59 From manc at openjdk.org Thu Nov 3 00:11:46 2022 From: manc at openjdk.org (Man Cao) Date: Thu, 3 Nov 2022 00:11:46 GMT Subject: [jdk19u] RFR: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library In-Reply-To: References: Message-ID: On Sat, 29 Oct 2022 06:28:08 GMT, Man Cao wrote: > Backport of https://bugs.openjdk.org/browse/JDK-8292695 Thanks for sponsoring, Paul! ------------- PR: https://git.openjdk.org/jdk19u/pull/59 From goetz at openjdk.org Thu Nov 3 11:51:40 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 11:51:40 GMT Subject: [jdk11u-dev] RFR: 8292682: Code change of JDK-8282730 not updated to reflect CSR update Message-ID: <5_ZPCFtoI-AeJMQW8okarbAFMoMvUJ-Jg9Zmp3W3DhQ=.937688bd-39fb-48c5-85de-65aa3ee6056a@github.com> I backport this for parity with 11.0.18-oracle. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1491 Commit messages: - Backport 74d3330e106f2f920bf264356e4f25f8f6c11580 Changes: https://git.openjdk.org/jdk11u-dev/pull/1492/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1492&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292682 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1492.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1492/head:pull/1492 PR: https://git.openjdk.org/jdk11u-dev/pull/1492 From goetz at openjdk.org Thu Nov 3 11:51:42 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 11:51:42 GMT Subject: [jdk11u-dev] RFR: 8292682: Code change of JDK-8282730 not updated to reflect CSR update In-Reply-To: <5_ZPCFtoI-AeJMQW8okarbAFMoMvUJ-Jg9Zmp3W3DhQ=.937688bd-39fb-48c5-85de-65aa3ee6056a@github.com> References: <5_ZPCFtoI-AeJMQW8okarbAFMoMvUJ-Jg9Zmp3W3DhQ=.937688bd-39fb-48c5-85de-65aa3ee6056a@github.com> Message-ID: On Wed, 2 Nov 2022 12:58:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. Pre-submit failure: java/util/DoubleStreamSums/CompensatedSums; known to be failing. unrelated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1492 From yan at openjdk.org Thu Nov 3 11:51:49 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 3 Nov 2022 11:51:49 GMT Subject: [jdk13u-dev] RFR: 8293044: C1: Missing access check on non-accessible class Message-ID: Backporting for parity with LTS releases. c1_Runtime1.cpp needs some adaptation just like in 11u. There will be a follow-up of 8293816; with that in mind, tier1 and specific testing run fine. ------------- Commit messages: - Backport 005b49bb78a468d4e372e6f5fa48bb0db4fd73c2 Changes: https://git.openjdk.org/jdk13u-dev/pull/425/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=425&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293044 Stats: 250 lines in 8 files changed: 232 ins; 6 del; 12 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/425.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/425/head:pull/425 PR: https://git.openjdk.org/jdk13u-dev/pull/425 From bae at openjdk.org Thu Nov 3 12:00:25 2022 From: bae at openjdk.org (Andrew Brygin) Date: Thu, 3 Nov 2022 12:00:25 GMT Subject: [jdk13u-dev] RFR: 8293044: C1: Missing access check on non-accessible class In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 10:49:33 GMT, Yuri Nesterenko wrote: > Backporting for parity with LTS releases. > c1_Runtime1.cpp needs some adaptation just like in 11u. > There will be a follow-up of 8293816; with that in mind, tier1 and specific testing run fine. Marked as reviewed by bae (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/425 From goetz at openjdk.org Thu Nov 3 12:00:41 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 12:00:41 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 09:13:56 GMT, Matthias Baesken wrote: > backport of 8289524 Hi I would second Matthias' pledge. The changes to non-jfr code by this change are minimal and trivial. The risk of breaking something thus is small. The event is only a small improvement for side-case, if properly setup a vm should not start and stop the JIT. Nevertheless it might be useful analyzing systems in abnormal states. Tools using JFR data should be able to handle added fields. The cited "bug" nor really is a bug, it is about spelling of commands. It should be backported, too. But it can not be taken as proof for this being a complicated, risky change. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From yan at openjdk.org Thu Nov 3 12:02:31 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 3 Nov 2022 12:02:31 GMT Subject: [jdk15u-dev] RFR: 8293044: C1: Missing access check on non-accessible class Message-ID: Backporting for parity with LTS releases. c1_Runtime1.cpp needs some adaptation just like in 11u. There will be a follow-up of 8293816; with that in mind, tier1 and specific testing run fine. ------------- Commit messages: - Backport 005b49bb78a468d4e372e6f5fa48bb0db4fd73c2 Changes: https://git.openjdk.org/jdk15u-dev/pull/299/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=299&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293044 Stats: 252 lines in 8 files changed: 234 ins; 6 del; 12 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/299.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/299/head:pull/299 PR: https://git.openjdk.org/jdk15u-dev/pull/299 From bae at openjdk.org Thu Nov 3 12:02:32 2022 From: bae at openjdk.org (Andrew Brygin) Date: Thu, 3 Nov 2022 12:02:32 GMT Subject: [jdk15u-dev] RFR: 8293044: C1: Missing access check on non-accessible class In-Reply-To: References: Message-ID: <2mmqGQSaBIwAnzYuVVYMzkssJAFN215jsmx8lwM_Ovs=.ff37decd-a02a-4cb6-870e-a95b31f2a081@github.com> On Thu, 3 Nov 2022 10:49:43 GMT, Yuri Nesterenko wrote: > Backporting for parity with LTS releases. > c1_Runtime1.cpp needs some adaptation just like in 11u. > There will be a follow-up of 8293816; with that in mind, tier1 and specific testing run fine. Marked as reviewed by bae (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/299 From goetz at openjdk.org Thu Nov 3 12:23:52 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 12:23:52 GMT Subject: [jdk11u-dev] RFR: 8257722: Improve "keytool -printcert -jarfile" output Message-ID: I backport this for parity with 11.0.18-oracle. src/java.base/share/classes/sun/security/tools/keytool/Main.java had to be resolved: In 11, x.getSubjectDN() is printed to 'out'. In the original change and in 17, x.getSubjectX500Principal() is printed in this place. This is because "8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects" is not in 11. I also had to resolve src/java.base/share/classes/sun/security/tools/keytool/Resources.java due to context. ------------- Commit messages: - Backport de93b1d0e83a9428dae4a9609996fe7b7e9b4932 Changes: https://git.openjdk.org/jdk11u-dev/pull/1495/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1495&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8257722 Stats: 253 lines in 4 files changed: 166 ins; 84 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1495.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1495/head:pull/1495 PR: https://git.openjdk.org/jdk11u-dev/pull/1495 From yan at openjdk.org Thu Nov 3 12:29:48 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 3 Nov 2022 12:29:48 GMT Subject: [jdk15u-dev] Integrated: 8293044: C1: Missing access check on non-accessible class In-Reply-To: References: Message-ID: <5L2AMu7Te27jwJNpUVn0fWbL1J15eA6vdeDeYF-7HO0=.d31100d5-e790-49d2-a5fd-47517ccef5d5@github.com> On Thu, 3 Nov 2022 10:49:43 GMT, Yuri Nesterenko wrote: > Backporting for parity with LTS releases. > c1_Runtime1.cpp needs some adaptation just like in 11u. > There will be a follow-up of 8293816; with that in mind, tier1 and specific testing run fine. This pull request has now been integrated. Changeset: 6790a065 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/6790a0655aab13093b16f16efc14adc284b44c39 Stats: 252 lines in 8 files changed: 234 ins; 6 del; 12 mod 8293044: C1: Missing access check on non-accessible class Reviewed-by: bae Backport-of: 005b49bb78a468d4e372e6f5fa48bb0db4fd73c2 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/299 From yan at openjdk.org Thu Nov 3 12:30:27 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 3 Nov 2022 12:30:27 GMT Subject: [jdk13u-dev] Integrated: 8293044: C1: Missing access check on non-accessible class In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 10:49:33 GMT, Yuri Nesterenko wrote: > Backporting for parity with LTS releases. > c1_Runtime1.cpp needs some adaptation just like in 11u. > There will be a follow-up of 8293816; with that in mind, tier1 and specific testing run fine. This pull request has now been integrated. Changeset: 374bf7f8 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/374bf7f881907950d9f31a26011034a5e772062b Stats: 250 lines in 8 files changed: 232 ins; 6 del; 12 mod 8293044: C1: Missing access check on non-accessible class Reviewed-by: bae Backport-of: 005b49bb78a468d4e372e6f5fa48bb0db4fd73c2 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/425 From clanger at openjdk.org Thu Nov 3 13:14:42 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Nov 2022 13:14:42 GMT Subject: [jdk11u-dev] RFR: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode Message-ID: <-cpyZdFR5QaUcTDQvH5YMaNRNNejAhl7cxX7gMIsszw=.4f21daf4-797a-45ae-a787-e45979fe84ad@github.com> Hi all, This pull request contains a backport of [JDK-8277881](https://bugs.openjdk.java.net/browse/JDK-8277881), commit [9d99a377](https://github.com/openjdk/jdk/commit/9d99a377bfb6ffa890db049aee575e97914fc2a1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Daniel Jelinski on 24 Dec 2021 and was reviewed by Anthony Scarpino. Thanks! ------------- Commit messages: - Backport 9d99a377bfb6ffa890db049aee575e97914fc2a1 Changes: https://git.openjdk.org/jdk11u-dev/pull/1496/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1496&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8277881 Stats: 15 lines in 3 files changed: 4 ins; 1 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1496.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1496/head:pull/1496 PR: https://git.openjdk.org/jdk11u-dev/pull/1496 From yan at openjdk.org Thu Nov 3 13:59:29 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 3 Nov 2022 13:59:29 GMT Subject: [jdk15u-dev] RFR: 8293816: CI: ciBytecodeStream::get_klass() is not consistent Message-ID: Backporting as a follow-up to JDK-8293044. Clean backport ------------- Commit messages: - Backport 746f5f589db5c1036f15fa47f8a48b2a12c921ce Changes: https://git.openjdk.org/jdk15u-dev/pull/300/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=300&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293816 Stats: 10 lines in 3 files changed: 1 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/300.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/300/head:pull/300 PR: https://git.openjdk.org/jdk15u-dev/pull/300 From yan at openjdk.org Thu Nov 3 14:00:00 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 3 Nov 2022 14:00:00 GMT Subject: [jdk13u-dev] RFR: 8293816: CI: ciBytecodeStream::get_klass() is not consistent Message-ID: Backporting as a follow-up to JDK-8293044. Clean backport ------------- Commit messages: - Backport 746f5f589db5c1036f15fa47f8a48b2a12c921ce Changes: https://git.openjdk.org/jdk13u-dev/pull/426/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=426&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293816 Stats: 10 lines in 3 files changed: 1 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/426.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/426/head:pull/426 PR: https://git.openjdk.org/jdk13u-dev/pull/426 From yan at openjdk.org Thu Nov 3 14:03:46 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 3 Nov 2022 14:03:46 GMT Subject: [jdk13u-dev] Integrated: 8293816: CI: ciBytecodeStream::get_klass() is not consistent In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 13:50:25 GMT, Yuri Nesterenko wrote: > Backporting as a follow-up to JDK-8293044. Clean backport This pull request has now been integrated. Changeset: f0300249 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/f030024965874a486734d42defc301db9a9be549 Stats: 10 lines in 3 files changed: 1 ins; 6 del; 3 mod 8293816: CI: ciBytecodeStream::get_klass() is not consistent Backport-of: 746f5f589db5c1036f15fa47f8a48b2a12c921ce ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/426 From yan at openjdk.org Thu Nov 3 14:05:28 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 3 Nov 2022 14:05:28 GMT Subject: [jdk15u-dev] Integrated: 8293816: CI: ciBytecodeStream::get_klass() is not consistent In-Reply-To: References: Message-ID: <9MfIwXGdymhrFB1ZdadET6ldzD-MFDwdsOcTNYOWOVE=.1cad5de2-57c5-4b3a-a9f4-70c86b7b8856@github.com> On Thu, 3 Nov 2022 13:50:20 GMT, Yuri Nesterenko wrote: > Backporting as a follow-up to JDK-8293044. Clean backport This pull request has now been integrated. Changeset: 74ce11f9 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/74ce11f9330ee7df83bbce1770c2c93038bb5d9b Stats: 10 lines in 3 files changed: 1 ins; 6 del; 3 mod 8293816: CI: ciBytecodeStream::get_klass() is not consistent Backport-of: 746f5f589db5c1036f15fa47f8a48b2a12c921ce ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/300 From goetz at openjdk.org Thu Nov 3 14:15:23 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 14:15:23 GMT Subject: [jdk11u-dev] Integrated: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound In-Reply-To: References: Message-ID: <2iX_8axijPRJN6BpvACohtGPqxtIaWshABsHJgqSuvM=.025a8e1d-bb8b-47ed-81cb-3a2c3b08e951@github.com> On Wed, 26 Oct 2022 13:48:17 GMT, Goetz Lindenmaier wrote: > The original fix patches jdk/internal/util/random/RandomSupport.java. > This class is not in 11. > > The Random code was completely reworked by > "8248862: Implement Enhanced Pseudo-Random Number Generators" > In the old 11 code there are several methods 'nextDouble' or > 'internalNextDouble' all using the same pattern. They were > replaced by the implementation in the new class > RandomSupport in 17. > > I adapted the following methods: > in java/util/Random.java: > final double internalNextDouble(double origin, double bound) > > in java/util/SplittableRandom.java > final double internalNextDouble(double origin, double bound) > public double nextDouble(double bound) > > in java/util/concurrent/ThreadLocalRandom.java > final double internalNextDouble(double origin, double bound) > public double nextDouble(double bound) > > I think this are all affected methods, but please double-check. > > The change requires follow-up 8280950 which needs to be > adapted to touch the three internalNextDouble() > methods. This pull request has now been integrated. Changeset: 91f15382 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/91f1538246309143557f481c4a4964279f235932 Stats: 57 lines in 4 files changed: 52 ins; 0 del; 5 mod 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound Reviewed-by: phh Backport-of: 0c42e43f77b91a50fedc3fddb74e17f910d8df2a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1478 From mbaesken at openjdk.org Thu Nov 3 14:17:35 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 3 Nov 2022 14:17:35 GMT Subject: [jdk11u-dev] RFR: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown" In-Reply-To: <1CTgd1OcUcrhhcbirFzyYCcLBGnbrjBZWpzZyH4CN-s=.3b50a255-5f89-4cc1-882d-2d00c676d713@github.com> References: <1CTgd1OcUcrhhcbirFzyYCcLBGnbrjBZWpzZyH4CN-s=.3b50a255-5f89-4cc1-882d-2d00c676d713@github.com> Message-ID: On Mon, 31 Oct 2022 18:45:17 GMT, Goetz Lindenmaier wrote: > This is a special backport. > Time ago, I backported "8278794: Infinite loop in DeflaterOutputStream.finish() " > > There, i forgot to include CloseInflaterDeflaterTest.java. > I only realized this because I could not backport this fix now. > > So here I include the test and the fix. > Both in themselves apply clean. LGTM ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1489 From clanger at openjdk.org Thu Nov 3 14:20:03 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Nov 2022 14:20:03 GMT Subject: [jdk19u] RFR: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present In-Reply-To: References: Message-ID: On Fri, 21 Oct 2022 07:17:54 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8293701](https://bugs.openjdk.org/browse/JDK-8293701), commit [953ce8da](https://github.com/openjdk/jdk/commit/953ce8da2c7ddd60b09a18c7875616a2477e5ba5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 5 Oct 2022 and was reviewed by Mandy Chung. > > Thanks! Windows test will be fixed with https://bugs.openjdk.org/browse/JDK-8294840. ------------- PR: https://git.openjdk.org/jdk19u/pull/54 From goetz at openjdk.org Thu Nov 3 14:21:54 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 14:21:54 GMT Subject: [jdk17u-dev] Integrated: 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 09:50:55 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.6-oracle. This pull request has now been integrated. Changeset: f2a10fd2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f2a10fd27bc8888d4afe3d425fed813c3bc8eb6b Stats: 55 lines in 5 files changed: 8 ins; 15 del; 32 mod 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation Backport-of: a5e4def526697d88ff31a5fdb41d823b899372f2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/854 From clanger at openjdk.org Thu Nov 3 14:22:14 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Nov 2022 14:22:14 GMT Subject: [jdk19u] Integrated: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present In-Reply-To: References: Message-ID: On Fri, 21 Oct 2022 07:17:54 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8293701](https://bugs.openjdk.org/browse/JDK-8293701), commit [953ce8da](https://github.com/openjdk/jdk/commit/953ce8da2c7ddd60b09a18c7875616a2477e5ba5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 5 Oct 2022 and was reviewed by Mandy Chung. > > Thanks! This pull request has now been integrated. Changeset: 875a2263 Author: Christoph Langer URL: https://git.openjdk.org/jdk19u/commit/875a22633efc9234c99fe06b8fdeee89edf24e29 Stats: 268 lines in 8 files changed: 264 ins; 0 del; 4 mod 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present Backport-of: 953ce8da2c7ddd60b09a18c7875616a2477e5ba5 ------------- PR: https://git.openjdk.org/jdk19u/pull/54 From goetz at openjdk.org Thu Nov 3 14:23:17 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 14:23:17 GMT Subject: [jdk17u-dev] Integrated: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 11:51:38 GMT, Goetz Lindenmaier wrote: > Resolved signals_posix.cpp because test for do_check is not in 17. > That was added by 8283337: Posix signal handler modification warning triggering incorrectly > I add 8283337 to this backport as it is subsumed by 8292695. > > Resolved os.cpp due to context. > Context was changed by "8269466: Factor out the common code for initializing and starting internal VM JavaThreads" This pull request has now been integrated. Changeset: ff14ed4a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ff14ed4af37e465b928e55af220dbb287f6d2bc0 Stats: 136 lines in 4 files changed: 117 ins; 9 del; 10 mod 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library 8283337: Posix signal handler modification warning triggering incorrectly Reviewed-by: manc, mdoerr Backport-of: 45ff10cc68296c7c73d0eafe6fcc9946ab98267e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/834 From phh at openjdk.org Thu Nov 3 14:24:45 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 3 Nov 2022 14:24:45 GMT Subject: [jdk11u-dev] RFR: 8257722: Improve "keytool -printcert -jarfile" output In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 08:39:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. > > src/java.base/share/classes/sun/security/tools/keytool/Main.java > had to be resolved: > In 11, x.getSubjectDN() is printed to 'out'. In the original > change and in 17, x.getSubjectX500Principal() is printed in this > place. > This is because "8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects" is not in 11. > > I also had to resolve > src/java.base/share/classes/sun/security/tools/keytool/Resources.java > due to context. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1495 From goetz at openjdk.org Thu Nov 3 14:28:43 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 14:28:43 GMT Subject: [jdk11u-dev] RFR: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix [v3] In-Reply-To: <15bRYfiOIuqxgcqDcfM239WtwkaSZc0FXaClOL-Ps2A=.0f5b5ff7-a48d-4229-9407-2ea0831ac877@github.com> References: <15bRYfiOIuqxgcqDcfM239WtwkaSZc0FXaClOL-Ps2A=.0f5b5ff7-a48d-4229-9407-2ea0831ac877@github.com> Message-ID: > I had to do similar resolves as in the underlying change JDK-8280550. > > In the test, I had to remove RandomGenerator which is not in 11. > The same pattern can not be implemented with SplittableRandom as it is final. > Thus, the test is no more deterministic. It depends on whether the > rounding error actually occurs. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'master' into goetz_backport_8280950 - Make test compile with 11 - Backport 0e70d4504c267174738485c7da82a2ac0ef09770 - Remove stray comments - Add Test forgotten in orig commit. - Backport 0c42e43f77b91a50fedc3fddb74e17f910d8df2a ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1487/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1487&range=02 Stats: 32 lines in 4 files changed: 28 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1487.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1487/head:pull/1487 PR: https://git.openjdk.org/jdk11u-dev/pull/1487 From clanger at openjdk.org Thu Nov 3 14:59:07 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Nov 2022 14:59:07 GMT Subject: [jdk19u] RFR: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator Message-ID: Hi all, This pull request contains a backport of [JDK-8294840](https://bugs.openjdk.org/browse/JDK-8294840), commit [f531dae4](https://github.com/openjdk/jdk/commit/f531dae4a0ffd2a5663cf4a4bde581d68fc728d5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Matthias Baesken on 5 Oct 2022 and was reviewed by Alan Bateman. Thanks! ------------- Commit messages: - Backport f531dae4a0ffd2a5663cf4a4bde581d68fc728d5 Changes: https://git.openjdk.org/jdk19u/pull/60/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=60&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294840 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk19u/pull/60.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/60/head:pull/60 PR: https://git.openjdk.org/jdk19u/pull/60 From clanger at openjdk.org Thu Nov 3 15:02:45 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Nov 2022 15:02:45 GMT Subject: [jdk19u] Integrated: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 14:49:43 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8294840](https://bugs.openjdk.org/browse/JDK-8294840), commit [f531dae4](https://github.com/openjdk/jdk/commit/f531dae4a0ffd2a5663cf4a4bde581d68fc728d5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 5 Oct 2022 and was reviewed by Alan Bateman. > > Thanks! This pull request has now been integrated. Changeset: 3bb0bc9a Author: Christoph Langer URL: https://git.openjdk.org/jdk19u/commit/3bb0bc9a84605eee56d26ba1407a1f97e65cb3c2 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8294840: langtools OptionalDependencyTest.java use File.pathSeparator Backport-of: f531dae4a0ffd2a5663cf4a4bde581d68fc728d5 ------------- PR: https://git.openjdk.org/jdk19u/pull/60 From goetz at openjdk.org Thu Nov 3 15:05:11 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 15:05:11 GMT Subject: [jdk11u-dev] Integrated: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix In-Reply-To: <15bRYfiOIuqxgcqDcfM239WtwkaSZc0FXaClOL-Ps2A=.0f5b5ff7-a48d-4229-9407-2ea0831ac877@github.com> References: <15bRYfiOIuqxgcqDcfM239WtwkaSZc0FXaClOL-Ps2A=.0f5b5ff7-a48d-4229-9407-2ea0831ac877@github.com> Message-ID: On Mon, 31 Oct 2022 17:25:48 GMT, Goetz Lindenmaier wrote: > I had to do similar resolves as in the underlying change JDK-8280550. > > In the test, I had to remove RandomGenerator which is not in 11. > The same pattern can not be implemented with SplittableRandom as it is final. > Thus, the test is no more deterministic. It depends on whether the > rounding error actually occurs. This pull request has now been integrated. Changeset: 182173af Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/182173afe38b3aaf74887c14a4611a502772aa97 Stats: 32 lines in 4 files changed: 28 ins; 0 del; 4 mod 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix Reviewed-by: phh Backport-of: 0e70d4504c267174738485c7da82a2ac0ef09770 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1487 From goetz at openjdk.org Thu Nov 3 15:14:49 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 15:14:49 GMT Subject: [jdk11u-dev] RFR: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950 [v2] In-Reply-To: References: Message-ID: <51pzjW-cJheAgBPVY0FK1nCD76Ib2zVZb_d4Eil5_W0=.ac12afbc-d321-495d-ac2b-6cfdd054a093@github.com> > I had to do similar resolves as in the two underlying changes. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1488/files - new: https://git.openjdk.org/jdk11u-dev/pull/1488/files/8b95f223..8b95f223 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1488&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1488&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1488.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1488/head:pull/1488 PR: https://git.openjdk.org/jdk11u-dev/pull/1488 From goetz at openjdk.org Thu Nov 3 15:22:27 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 15:22:27 GMT Subject: [jdk11u-dev] RFR: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950 [v3] In-Reply-To: References: Message-ID: > I had to do similar resolves as in the two underlying changes. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge branch 'master' into goetz_backport_8281183 - Backport 77b0240d44fd356711d75bc241e198f6f89ada8f - Make test compile with 11 - Backport 0e70d4504c267174738485c7da82a2ac0ef09770 - Remove stray comments - Add Test forgotten in orig commit. - Backport 0c42e43f77b91a50fedc3fddb74e17f910d8df2a ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1488/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1488&range=02 Stats: 8 lines in 3 files changed: 3 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1488.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1488/head:pull/1488 PR: https://git.openjdk.org/jdk11u-dev/pull/1488 From goetz at openjdk.org Thu Nov 3 15:29:12 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 15:29:12 GMT Subject: [jdk11u-dev] Integrated: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950 In-Reply-To: References: Message-ID: On Mon, 31 Oct 2022 18:08:46 GMT, Goetz Lindenmaier wrote: > I had to do similar resolves as in the two underlying changes. This pull request has now been integrated. Changeset: 3b40d213 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/3b40d21343bc0812d10e80a5bd2a375f9720d395 Stats: 8 lines in 3 files changed: 3 ins; 0 del; 5 mod 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950 Reviewed-by: phh Backport-of: 77b0240d44fd356711d75bc241e198f6f89ada8f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1488 From goetz at openjdk.org Thu Nov 3 16:12:08 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 16:12:08 GMT Subject: [jdk11u-dev] Integrated: 8295429: Update harfbuzz md file In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 13:29:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. > > Backport from 17 because that is clean. This pull request has now been integrated. Changeset: 7c5f9c68 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/7c5f9c6831e356fc10aac948a6abbc5cb07b56e0 Stats: 16 lines in 1 file changed: 8 ins; 0 del; 8 mod 8295429: Update harfbuzz md file Backport-of: cb9289ed7589e2cfbe8ac21ab6f3039ee09216ea ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1493 From goetz at openjdk.org Thu Nov 3 17:42:21 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 17:42:21 GMT Subject: [jdk11u-dev] RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints Message-ID: I backport this for parity with 11.0.18-oracle from 17. I had to resolve src/java.base/share/classes/sun/security/tools/keytool/Main.java due to various smaller differences. E.g., withWeak() has a PublicKey as argument in 11, which is a Key in 17. Copyright: src/java.base/share/classes/sun/security/tools/keytool/Resources.java To make it compile I had to add import for KnownOIDs and replace usage of finalChain by the available chain. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1495 Commit messages: - Make it compile - Resolved chunks - Backport c9c8564d7c094c4dad595c8908f2b37a00130fb6 Changes: https://git.openjdk.org/jdk11u-dev/pull/1497/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1497&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273236 Stats: 373 lines in 2 files changed: 318 ins; 0 del; 55 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1497.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1497/head:pull/1497 PR: https://git.openjdk.org/jdk11u-dev/pull/1497 From egahlin at openjdk.org Thu Nov 3 18:10:51 2022 From: egahlin at openjdk.org (Erik Gahlin) Date: Thu, 3 Nov 2022 18:10:51 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 12:10:00 GMT, Matthias Baesken wrote: > Having a couple of additional interesting (and not too complex !) events in the latest LTS is not a bad thing but this is my personal impression. On the other hand I do not care that much, if it is rejected than probably all additional events would be rejected because the others I looked at that were interesting were more complex. I think the bar should be high and there should be a good reason, for example to support new hardware or OS versions. Improve security. Things that are essential to be able to use the existing JDK release. I don't see this JFR event fall into that category. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From clanger at openjdk.org Thu Nov 3 19:14:03 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Nov 2022 19:14:03 GMT Subject: [jdk19u] RFR: 8288132: Update test artifacts in QuoVadis CA interop tests Message-ID: <3Gnlb3K6le95QASuyVhzaWK8aXFLb6HUhlxNx10BfNk=.fd915522-a31a-4889-9e51-2c3a03a2c11b@github.com> Hi all, This pull request contains a backport of https://bugs.openjdk.org/browse/JDK-8288132, commit [3ee1e605](https://github.com/openjdk/jdk/commit/3ee1e60595171be0dd8bda47d96e0a1268cdc461) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Rajan Halade on 10 Jun 2022 and was reviewed by Sean Mullan. Thanks! ------------- Commit messages: - Backport 3ee1e60595171be0dd8bda47d96e0a1268cdc461 Changes: https://git.openjdk.org/jdk19u/pull/61/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=61&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288132 Stats: 191 lines in 1 file changed: 21 ins; 0 del; 170 mod Patch: https://git.openjdk.org/jdk19u/pull/61.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/61/head:pull/61 PR: https://git.openjdk.org/jdk19u/pull/61 From clanger at openjdk.org Thu Nov 3 19:27:56 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Nov 2022 19:27:56 GMT Subject: [jdk17u-dev] RFR: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch" Message-ID: Backport of JDK-8277970. I had to trivially resolve because JDK-8282723 is not in 17u. ------------- Commit messages: - Backport d1252653b07ee3d0347b39b96f734e45772b5b36 Changes: https://git.openjdk.org/jdk17u-dev/pull/855/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=855&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8277970 Stats: 9 lines in 3 files changed: 6 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/855.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/855/head:pull/855 PR: https://git.openjdk.org/jdk17u-dev/pull/855 From clanger at openjdk.org Thu Nov 3 19:29:14 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Nov 2022 19:29:14 GMT Subject: [jdk17u-dev] RFR: 8288132: Update test artifacts in QuoVadis CA interop tests Message-ID: Hi all, This pull request contains a backport of [JDK-8288132](https://bugs.openjdk.org/browse/JDK-8288132), commit [3ee1e605](https://github.com/openjdk/jdk/commit/3ee1e60595171be0dd8bda47d96e0a1268cdc461) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Rajan Halade on 10 Jun 2022 and was reviewed by Sean Mullan. Thanks! ------------- Commit messages: - Backport 3ee1e60595171be0dd8bda47d96e0a1268cdc461 Changes: https://git.openjdk.org/jdk17u-dev/pull/856/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=856&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288132 Stats: 191 lines in 1 file changed: 21 ins; 0 del; 170 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/856.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/856/head:pull/856 PR: https://git.openjdk.org/jdk17u-dev/pull/856 From goetz at openjdk.org Thu Nov 3 19:40:04 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 3 Nov 2022 19:40:04 GMT Subject: [jdk17u-dev] RFR: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false Message-ID: <5sYqB3x6BweTr_4ZjNr8P_AX772Sl4hSprDPtivxfRg=.bc280e60-ef43-4c6f-947b-4e60fe6cefeb@github.com> I backport this for parity with 17.0.6-oracle. ------------- Commit messages: - Backport 5e1e449c116d44fb77a21ce4cd5187cfc55263f2 Changes: https://git.openjdk.org/jdk17u-dev/pull/857/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=857&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290920 Stats: 25 lines in 1 file changed: 13 ins; 11 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/857.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/857/head:pull/857 PR: https://git.openjdk.org/jdk17u-dev/pull/857 From clanger at openjdk.org Thu Nov 3 20:04:41 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Nov 2022 20:04:41 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 18:06:53 GMT, Erik Gahlin wrote: > > Having a couple of additional interesting (and not too complex !) events in the latest LTS is not a bad thing but this is my personal impression. On the other hand I do not care that much, if it is rejected than probably all additional events would be rejected because the others I looked at that were interesting were more complex. > > I think the bar should be high and there should be a good reason, for example to support new hardware or OS versions. Improve security. Things that are essential to be able to use the existing JDK release. I don't see this JFR event fall into that category. I know there have been discussions about backporting JFR events earlier on and I think none have ever happened. But I think we should constantly reconsider our decisions. Regarding JFR event backports, we have been very conservative overall and I think that is not bad. We need to be careful regarding stability and not to break things. Also, major feature improvements need to come with newer JDK releases. However, we still need and want to support our customers that are running on LTS releases of the OpenJDK. And that's what additional/improved JFR events will help to achieve. So, while we should err on the path of caution as to not break anything, I think we should not reject JFR enhancements per se. At least that's my current thinking... ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From clanger at openjdk.org Thu Nov 3 20:14:23 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Nov 2022 20:14:23 GMT Subject: [jdk11u-dev] RFR: 8288132: Update test artifacts in QuoVadis CA interop tests Message-ID: Hi all, This pull request contains a backport of [JDK-8288132](https://bugs.openjdk.org/browse/JDK-8288132), commit [3ee1e605](https://github.com/openjdk/jdk/commit/3ee1e60595171be0dd8bda47d96e0a1268cdc461) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Rajan Halade on 10 Jun 2022 and was reviewed by Sean Mullan. Thanks! ------------- Commit messages: - Backport 3ee1e60595171be0dd8bda47d96e0a1268cdc461 Changes: https://git.openjdk.org/jdk11u-dev/pull/1498/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1498&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288132 Stats: 191 lines in 1 file changed: 21 ins; 0 del; 170 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1498.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1498/head:pull/1498 PR: https://git.openjdk.org/jdk11u-dev/pull/1498 From clanger at openjdk.org Thu Nov 3 20:25:31 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Nov 2022 20:25:31 GMT Subject: [jdk11u-dev] RFR: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch" Message-ID: <8-hLl70Ka2fJ5PbPMPN-QJlbQCuPAF9GDDbTdniBE30=.0a962862-af45-483d-b74f-966b031850a9@github.com> Backport of JDK-8277970. I had to trivially resolve because JDK-8282723 is not in 11u. Let's see whether the bots will flag it as clean... ------------- Commit messages: - Backport d1252653b07ee3d0347b39b96f734e45772b5b36 Changes: https://git.openjdk.org/jdk11u-dev/pull/1499/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1499&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8277970 Stats: 9 lines in 3 files changed: 6 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1499.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1499/head:pull/1499 PR: https://git.openjdk.org/jdk11u-dev/pull/1499 From stuefe at openjdk.org Fri Nov 4 07:37:52 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 4 Nov 2022 07:37:52 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 18:06:53 GMT, Erik Gahlin wrote: >> Having a couple of additional interesting (and not too complex !) events in the latest LTS is not a bad thing but this is my personal impression. On the other hand I do not care that much, if it is rejected than probably all additional events would be rejected because the others I looked at that were interesting were more complex. >> Our users will avoid non-LTS releases because of the effort and investment costs , so this means Sept 2023 + probably ~ one more year of testing etc. , until they can consume other interesting JFR events that came in after 17 , quite a long time I think. > >> Having a couple of additional interesting (and not too complex !) events in the latest LTS is not a bad thing but this is my personal impression. On the other hand I do not care that much, if it is rejected than probably all additional events would be rejected because the others I looked at that were interesting were more complex. > > I think the bar should be high and there should be a good reason, for example to support new hardware or OS versions. Improve security. Things that are essential to be able to use the existing JDK release. I don't see this JFR event fall into that category. @egahlin do you have any concrete concerns regarding the safety or risk of this patch? Or would it make the produced JFR output incompatible with JMC or other readers in any way? If it is just a general concern about downporting practices, I vote for downporting it. As maintainers we have a high interest in keeping 17u stable, but we also need to have tools to analyze problems in the field. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From goetz at openjdk.org Fri Nov 4 07:55:30 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 07:55:30 GMT Subject: [jdk11u-dev] RFR: 8257722: Improve "keytool -printcert -jarfile" output In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 08:39:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. > > src/java.base/share/classes/sun/security/tools/keytool/Main.java > had to be resolved: > In 11, x.getSubjectDN() is printed to 'out'. In the original > change and in 17, x.getSubjectX500Principal() is printed in this > place. > This is because "8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects" is not in 11. > > I also had to resolve > src/java.base/share/classes/sun/security/tools/keytool/Resources.java > due to context. Thanks for the review! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1495 From mbaesken at openjdk.org Fri Nov 4 07:55:38 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 4 Nov 2022 07:55:38 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 20:00:45 GMT, Christoph Langer wrote: > I know there have been discussions about backporting JFR events earlier on and I think none have ever happened. We had a few backports to 11 ([8003209](https://bugs.openjdk.org/browse/JDK-8003209) even backported to 8) in the past https://bugs.openjdk.org/browse/JDK-8213617 (11.0.4) https://bugs.openjdk.org/browse/JDK-8223438 (11.0.6) https://bugs.openjdk.org/browse/JDK-8003209 (11.0.1) The last one looks like a rather complex event, as far as I can see ... Two of my examples added events, one just a field to an existing event. Not aware of any tools crashing/stopped working because of those additions (but to be fair, I do not monitor all tools that deal with JFR events). See also https://github.com/openjdk/jdk11u-dev/commits/master/src/hotspot/share/jfr/metadata/metadata.xml to get more info about the topic. Maybe regarding this event, as a compromise we could wait until jdk20 is released (includes JDK-8289524) and then some time; and then do the backport. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From goetz at openjdk.org Fri Nov 4 07:57:14 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 07:57:14 GMT Subject: [jdk11u-dev] Integrated: 8257722: Improve "keytool -printcert -jarfile" output In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 08:39:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. > > src/java.base/share/classes/sun/security/tools/keytool/Main.java > had to be resolved: > In 11, x.getSubjectDN() is printed to 'out'. In the original > change and in 17, x.getSubjectX500Principal() is printed in this > place. > This is because "8241003: Deprecate "denigrated" java.security.cert APIs that represent DNs as Principal or String objects" is not in 11. > > I also had to resolve > src/java.base/share/classes/sun/security/tools/keytool/Resources.java > due to context. This pull request has now been integrated. Changeset: 13c07e62 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/13c07e6218cf28ff94421b3df02a2a4ce5db031f Stats: 253 lines in 4 files changed: 166 ins; 84 del; 3 mod 8257722: Improve "keytool -printcert -jarfile" output Reviewed-by: phh Backport-of: de93b1d0e83a9428dae4a9609996fe7b7e9b4932 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1495 From goetz at openjdk.org Fri Nov 4 07:58:43 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 07:58:43 GMT Subject: [jdk11u-dev] Integrated: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown" In-Reply-To: <1CTgd1OcUcrhhcbirFzyYCcLBGnbrjBZWpzZyH4CN-s=.3b50a255-5f89-4cc1-882d-2d00c676d713@github.com> References: <1CTgd1OcUcrhhcbirFzyYCcLBGnbrjBZWpzZyH4CN-s=.3b50a255-5f89-4cc1-882d-2d00c676d713@github.com> Message-ID: <2JUVCzwMhdFZ7d9eIBt8bkaYPRyNpoiuu8bcfm262mg=.8181973e-e721-450f-8d40-cd2da1d9b0b5@github.com> On Mon, 31 Oct 2022 18:45:17 GMT, Goetz Lindenmaier wrote: > This is a special backport. > Time ago, I backported "8278794: Infinite loop in DeflaterOutputStream.finish() " > > There, i forgot to include CloseInflaterDeflaterTest.java. > I only realized this because I could not backport this fix now. > > So here I include the test and the fix. > Both in themselves apply clean. This pull request has now been integrated. Changeset: d403e0d0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/d403e0d02ba75be5af2dfdf4b8442bcfe870ec95 Stats: 209 lines in 1 file changed: 209 ins; 0 del; 0 mod 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown" Reviewed-by: mbaesken Backport-of: 7891085a877b8a5715d095e0c0dbaaf5bc8f16bb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1489 From goetz at openjdk.org Fri Nov 4 07:59:39 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 07:59:39 GMT Subject: [jdk11u-dev] Integrated: 8282730: LdapLoginModule throw NPE from logout method after login failure In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 12:32:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. > > I had to resolve 6 Copyrights. Will mark as clean. > > Copyrights in these files: > src/java.base/share/classes/javax/security/auth/login/LoginContext.java > src/java.management/share/classes/com/sun/jmx/remote/security/FileLoginModule.java > src/jdk.security.auth/share/classes/com/sun/security/auth/module/JndiLoginModule.java > src/jdk.security.auth/share/classes/com/sun/security/auth/module/LdapLoginModule.java > src/jdk.security.auth/share/classes/com/sun/security/auth/module/NTLoginModule.java > src/jdk.security.auth/share/classes/com/sun/security/auth/module/UnixLoginModule.java This pull request has now been integrated. Changeset: 6b2e6aef Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/6b2e6aef6f5689dad3996dea9a2a5e453db8e534 Stats: 223 lines in 11 files changed: 151 ins; 2 del; 70 mod 8282730: LdapLoginModule throw NPE from logout method after login failure Backport-of: 554f44ecb1134acff3eaf02e2e1c0e01158ab7e5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1491 From goetz at openjdk.org Fri Nov 4 08:02:52 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 08:02:52 GMT Subject: [jdk11u-dev] RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.18-oracle from 17. > > I had to resolve src/java.base/share/classes/sun/security/tools/keytool/Main.java > due to various smaller differences. E.g., withWeak() has a > PublicKey as argument in 11, which is a Key in 17. > > Copyright: src/java.base/share/classes/sun/security/tools/keytool/Resources.java > > To make it compile I had to add import for KnownOIDs and > replace usage of finalChain by the available chain. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1497/files - new: https://git.openjdk.org/jdk11u-dev/pull/1497/files/1ef94465..1ef94465 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1497&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1497&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1497.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1497/head:pull/1497 PR: https://git.openjdk.org/jdk11u-dev/pull/1497 From goetz at openjdk.org Fri Nov 4 08:05:47 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 08:05:47 GMT Subject: [jdk11u-dev] RFR: 8292682: Code change of JDK-8282730 not updated to reflect CSR update [v2] In-Reply-To: <5_ZPCFtoI-AeJMQW8okarbAFMoMvUJ-Jg9Zmp3W3DhQ=.937688bd-39fb-48c5-85de-65aa3ee6056a@github.com> References: <5_ZPCFtoI-AeJMQW8okarbAFMoMvUJ-Jg9Zmp3W3DhQ=.937688bd-39fb-48c5-85de-65aa3ee6056a@github.com> Message-ID: > I backport this for parity with 11.0.18-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1492/files - new: https://git.openjdk.org/jdk11u-dev/pull/1492/files/1d9d9f74..1d9d9f74 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1492&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1492&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1492.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1492/head:pull/1492 PR: https://git.openjdk.org/jdk11u-dev/pull/1492 From goetz at openjdk.org Fri Nov 4 08:14:37 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 08:14:37 GMT Subject: [jdk11u-dev] RFR: 8292682: Code change of JDK-8282730 not updated to reflect CSR update [v3] In-Reply-To: <5_ZPCFtoI-AeJMQW8okarbAFMoMvUJ-Jg9Zmp3W3DhQ=.937688bd-39fb-48c5-85de-65aa3ee6056a@github.com> References: <5_ZPCFtoI-AeJMQW8okarbAFMoMvUJ-Jg9Zmp3W3DhQ=.937688bd-39fb-48c5-85de-65aa3ee6056a@github.com> Message-ID: > I backport this for parity with 11.0.18-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8292682 - Backport 74d3330e106f2f920bf264356e4f25f8f6c11580 - Backport 554f44ecb1134acff3eaf02e2e1c0e01158ab7e5 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1492/files - new: https://git.openjdk.org/jdk11u-dev/pull/1492/files/1d9d9f74..486aa344 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1492&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1492&range=01-02 Stats: 608 lines in 11 files changed: 499 ins; 84 del; 25 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1492.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1492/head:pull/1492 PR: https://git.openjdk.org/jdk11u-dev/pull/1492 From goetz at openjdk.org Fri Nov 4 08:21:50 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 08:21:50 GMT Subject: [jdk11u-dev] Integrated: 8292682: Code change of JDK-8282730 not updated to reflect CSR update In-Reply-To: <5_ZPCFtoI-AeJMQW8okarbAFMoMvUJ-Jg9Zmp3W3DhQ=.937688bd-39fb-48c5-85de-65aa3ee6056a@github.com> References: <5_ZPCFtoI-AeJMQW8okarbAFMoMvUJ-Jg9Zmp3W3DhQ=.937688bd-39fb-48c5-85de-65aa3ee6056a@github.com> Message-ID: On Wed, 2 Nov 2022 12:58:53 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. This pull request has now been integrated. Changeset: f24340a8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/f24340a8e0a8e175991f43adf8a8c1bf19421d4b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8292682: Code change of JDK-8282730 not updated to reflect CSR update Backport-of: 74d3330e106f2f920bf264356e4f25f8f6c11580 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1492 From serb at openjdk.org Fri Nov 4 08:24:53 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 4 Nov 2022 08:24:53 GMT Subject: [jdk15u-dev] Integrated: 8295554: Move the "sizecalc.h" to the correct location In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 16:56:30 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [6673cd85](https://github.com/openjdk/jdk/commit/6673cd857722d117b108590ba7f7c02f8622fc3b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: 3b29dc10 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk15u-dev/commit/3b29dc10d0f814a69255d80edf16c32cf7f9a7a4 Stats: 7 lines in 3 files changed: 3 ins; 3 del; 1 mod 8295554: Move the "sizecalc.h" to the correct location Backport-of: 6673cd857722d117b108590ba7f7c02f8622fc3b ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/295 From serb at openjdk.org Fri Nov 4 08:25:27 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 4 Nov 2022 08:25:27 GMT Subject: [jdk13u-dev] Integrated: 8295554: Move the "sizecalc.h" to the correct location In-Reply-To: References: Message-ID: On Wed, 26 Oct 2022 01:21:53 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [6673cd85](https://github.com/openjdk/jdk/commit/6673cd857722d117b108590ba7f7c02f8622fc3b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: cb7db1ff Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk13u-dev/commit/cb7db1fffe5b6baac21d790612ad5e13b291861c Stats: 7 lines in 3 files changed: 3 ins; 3 del; 1 mod 8295554: Move the "sizecalc.h" to the correct location Backport-of: 6673cd857722d117b108590ba7f7c02f8622fc3b ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/421 From serb at openjdk.org Fri Nov 4 08:25:47 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 4 Nov 2022 08:25:47 GMT Subject: [jdk11u-dev] Integrated: 8295554: Move the "sizecalc.h" to the correct location In-Reply-To: References: Message-ID: On Wed, 26 Oct 2022 01:25:51 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [6673cd85](https://github.com/openjdk/jdk/commit/6673cd857722d117b108590ba7f7c02f8622fc3b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: 188ab591 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/188ab5910fb51af83ad64b3fea3205522f110aac Stats: 7 lines in 3 files changed: 3 ins; 3 del; 1 mod 8295554: Move the "sizecalc.h" to the correct location Backport-of: 6673cd857722d117b108590ba7f7c02f8622fc3b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1476 From serb at openjdk.org Fri Nov 4 08:26:01 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 4 Nov 2022 08:26:01 GMT Subject: [jdk17u-dev] Integrated: 8295554: Move the "sizecalc.h" to the correct location In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 16:52:11 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [6673cd85](https://github.com/openjdk/jdk/commit/6673cd857722d117b108590ba7f7c02f8622fc3b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: d38a3432 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/d38a3432c2a5267b1f8315b325a7cd9c24b4da16 Stats: 7 lines in 3 files changed: 3 ins; 3 del; 1 mod 8295554: Move the "sizecalc.h" to the correct location Backport-of: 6673cd857722d117b108590ba7f7c02f8622fc3b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/839 From goetz at openjdk.org Fri Nov 4 09:31:46 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 09:31:46 GMT Subject: [jdk11u-dev] RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.18-oracle from 17. > > I had to resolve src/java.base/share/classes/sun/security/tools/keytool/Main.java > due to various smaller differences. E.g., withWeak() has a > PublicKey as argument in 11, which is a Key in 17. > > Copyright: src/java.base/share/classes/sun/security/tools/keytool/Resources.java > > To make it compile I had to add import for KnownOIDs and > replace usage of finalChain by the available chain. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'master' into goetz_backport_8273236 - Make it compile - Resolved chunks - Backport c9c8564d7c094c4dad595c8908f2b37a00130fb6 - Backport de93b1d0e83a9428dae4a9609996fe7b7e9b4932 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1497/files - new: https://git.openjdk.org/jdk11u-dev/pull/1497/files/1ef94465..8bdb886d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1497&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1497&range=01-02 Stats: 585 lines in 21 files changed: 487 ins; 5 del; 93 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1497.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1497/head:pull/1497 PR: https://git.openjdk.org/jdk11u-dev/pull/1497 From goetz at openjdk.org Fri Nov 4 09:39:00 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 09:39:00 GMT Subject: [jdk11u-dev] RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints [v4] In-Reply-To: References: Message-ID: <7d5KpFJ-S7nhR_THAELPkFoGm_IYAfN6JlUzdrvAs8E=.971af8db-ff22-48c9-8c65-421e3b8164e0@github.com> > I backport this for parity with 11.0.18-oracle from 17. > > I had to resolve src/java.base/share/classes/sun/security/tools/keytool/Main.java > due to various smaller differences. E.g., withWeak() has a > PublicKey as argument in 11, which is a Key in 17. > > Copyright: src/java.base/share/classes/sun/security/tools/keytool/Resources.java > > To make it compile I had to add import for KnownOIDs and > replace usage of finalChain by the available chain. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add test ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1497/files - new: https://git.openjdk.org/jdk11u-dev/pull/1497/files/8bdb886d..b3d5d65b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1497&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1497&range=02-03 Stats: 60 lines in 1 file changed: 60 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1497.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1497/head:pull/1497 PR: https://git.openjdk.org/jdk11u-dev/pull/1497 From goetz at openjdk.org Fri Nov 4 11:13:24 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 11:13:24 GMT Subject: [jdk11u-dev] RFR: 8293826: Closed test fails after JDK-8276108 on aarch64 Message-ID: I backport this for parity with 11.0.18-oracle. A quite special backport as the original issue is not public. ------------- Commit messages: - Backport 62eb5ae268c23c3b2496a0f7f9c3b7001f75b362 Changes: https://git.openjdk.org/jdk11u-dev/pull/1500/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1500&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293826 Stats: 20 lines in 1 file changed: 0 ins; 17 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1500.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1500/head:pull/1500 PR: https://git.openjdk.org/jdk11u-dev/pull/1500 From mbaesken at openjdk.org Fri Nov 4 11:28:37 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 4 Nov 2022 11:28:37 GMT Subject: [jdk11u-dev] RFR: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints [v4] In-Reply-To: <7d5KpFJ-S7nhR_THAELPkFoGm_IYAfN6JlUzdrvAs8E=.971af8db-ff22-48c9-8c65-421e3b8164e0@github.com> References: <7d5KpFJ-S7nhR_THAELPkFoGm_IYAfN6JlUzdrvAs8E=.971af8db-ff22-48c9-8c65-421e3b8164e0@github.com> Message-ID: On Fri, 4 Nov 2022 09:39:00 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.18-oracle from 17. >> >> I had to resolve src/java.base/share/classes/sun/security/tools/keytool/Main.java >> due to various smaller differences. E.g., withWeak() has a >> PublicKey as argument in 11, which is a Key in 17. >> >> Copyright: src/java.base/share/classes/sun/security/tools/keytool/Resources.java >> >> To make it compile I had to add import for KnownOIDs and >> replace usage of finalChain by the available chain. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Add test LGTM, thanks for backporting ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1497 From egahlin at openjdk.org Fri Nov 4 11:49:18 2022 From: egahlin at openjdk.org (Erik Gahlin) Date: Fri, 4 Nov 2022 11:49:18 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 18:06:53 GMT, Erik Gahlin wrote: >> Having a couple of additional interesting (and not too complex !) events in the latest LTS is not a bad thing but this is my personal impression. On the other hand I do not care that much, if it is rejected than probably all additional events would be rejected because the others I looked at that were interesting were more complex. >> Our users will avoid non-LTS releases because of the effort and investment costs , so this means Sept 2023 + probably ~ one more year of testing etc. , until they can consume other interesting JFR events that came in after 17 , quite a long time I think. > >> Having a couple of additional interesting (and not too complex !) events in the latest LTS is not a bad thing but this is my personal impression. On the other hand I do not care that much, if it is rejected than probably all additional events would be rejected because the others I looked at that were interesting were more complex. > > I think the bar should be high and there should be a good reason, for example to support new hardware or OS versions. Improve security. Things that are essential to be able to use the existing JDK release. I don't see this JFR event fall into that category. > @egahlin do you have any concrete concerns regarding the safety or risk of this patch? Or would it make the produced JFR output incompatible with JMC or other readers in any way? > I don't know the impact on JMC or other tools consuming JFR data. To know, one would need to try them out, but any modification of the event metadata, or what is enabled in the default configuration, risks being a problem. When backporting events several releases back, it also becomes confusing for JFR API users since the event will be missing in releases between. In this case, JDK 18 and JDK 19. > If it is just a general concern about downporting practices, I vote for downporting it. As maintainers we have a high interest in keeping 17u stable, but we also need to have tools to analyze problems in the field. I like to know what problem this event solves? If there have been say 3-5 JVM bugs where this event would have resolved them significant faster, I think an argument can be made (and explained to a customer why it was added in a security update). It contributes to stability (faster fixes). On the other hand, adding events to get features 10 months faster into a LTS release doesn't sound like the right reason to me. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From aph at openjdk.org Fri Nov 4 12:09:33 2022 From: aph at openjdk.org (Andrew Haley) Date: Fri, 4 Nov 2022 12:09:33 GMT Subject: [jdk11u-dev] RFR: Backport JDK-8278417 In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 11:06:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. > > A quite special backport as the original issue is not public. Marked as reviewed by aph (Reviewer). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1500 From goetz at openjdk.org Fri Nov 4 12:36:09 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 12:36:09 GMT Subject: [jdk11u-dev] RFR: 8293826: Closed test fails after JDK-8276108 on aarch64 In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 11:06:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. > > A quite special backport as the original issue is not public. Fiddling with JBS and GitHub to convince the bots to accept this ... ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1500 From serb at openjdk.org Fri Nov 4 12:38:39 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 4 Nov 2022 12:38:39 GMT Subject: [jdk19u] Integrated: 8295554: Move the "sizecalc.h" to the correct location In-Reply-To: <41Cu1ZCdAYTIyU8e6yTCa5NcU-etJTzQjPERy6jPFHg=.497185ab-9634-403f-b73e-2c4edd6ab166@github.com> References: <41Cu1ZCdAYTIyU8e6yTCa5NcU-etJTzQjPERy6jPFHg=.497185ab-9634-403f-b73e-2c4edd6ab166@github.com> Message-ID: On Tue, 25 Oct 2022 16:46:59 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [6673cd85](https://github.com/openjdk/jdk/commit/6673cd857722d117b108590ba7f7c02f8622fc3b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: 491bdeeb Author: Sergey Bylokhov Committer: Alexey Ivanov URL: https://git.openjdk.org/jdk19u/commit/491bdeeb1a89bef7de7d6ec4a89e2c1c35c9b328 Stats: 7 lines in 3 files changed: 3 ins; 3 del; 1 mod 8295554: Move the "sizecalc.h" to the correct location Backport-of: 6673cd857722d117b108590ba7f7c02f8622fc3b ------------- PR: https://git.openjdk.org/jdk19u/pull/57 From goetz at openjdk.org Fri Nov 4 13:28:38 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 13:28:38 GMT Subject: [jdk11u-dev] RFR: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound [v3] In-Reply-To: References: Message-ID: On Mon, 31 Oct 2022 17:26:47 GMT, Goetz Lindenmaier wrote: >> The original fix patches jdk/internal/util/random/RandomSupport.java. >> This class is not in 11. >> >> The Random code was completely reworked by >> "8248862: Implement Enhanced Pseudo-Random Number Generators" >> In the old 11 code there are several methods 'nextDouble' or >> 'internalNextDouble' all using the same pattern. They were >> replaced by the implementation in the new class >> RandomSupport in 17. >> >> I adapted the following methods: >> in java/util/Random.java: >> final double internalNextDouble(double origin, double bound) >> >> in java/util/SplittableRandom.java >> final double internalNextDouble(double origin, double bound) >> public double nextDouble(double bound) >> >> in java/util/concurrent/ThreadLocalRandom.java >> final double internalNextDouble(double origin, double bound) >> public double nextDouble(double bound) >> >> I think this are all affected methods, but please double-check. >> >> The change requires follow-up 8280950 which needs to be >> adapted to touch the three internalNextDouble() >> methods. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove stray comments I opened JDK-8296402 for the pattern in Curve.java. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1478 From sgehwolf at openjdk.org Fri Nov 4 13:51:44 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 4 Nov 2022 13:51:44 GMT Subject: [jdk11u-dev] RFR: 8293826: Closed test fails after JDK-8276108 on aarch64 In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 12:33:12 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.18-oracle. >> >> A quite special backport as the original issue is not public. > > Fiddling with JBS and GitHub to convince the bots to accept this ... @GoeLin Maybe change the `/summary` before you integrate? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1500 From goetz at openjdk.org Fri Nov 4 13:55:32 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 13:55:32 GMT Subject: [jdk11u-dev] RFR: 8293826: Closed test fails after JDK-8276108 on aarch64 In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 11:06:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. > > A quite special backport as the original issue is not public. Hi, as Martin did with the 17 backport, I changed the "original" JBS issue to be a Bug. Now it's green :) I will change that back again after pushing. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1500 From goetz at openjdk.org Fri Nov 4 13:59:14 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 4 Nov 2022 13:59:14 GMT Subject: [jdk11u-dev] RFR: 8293826: Closed test fails after JDK-8276108 on aarch64 In-Reply-To: References: Message-ID: <-_s_vEefxlsXMFaebS3_hniscolSEumGp_5h7_qvDcQ=.e8effef4-631e-4ed7-ae09-d5204020d291@github.com> On Fri, 4 Nov 2022 11:06:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. > > A quite special backport as the original issue is not public. Pre-submit failure: Couldn't download packages: libsemanage1 libsepol1 Unrelated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1500 From mdoerr at openjdk.org Fri Nov 4 16:40:34 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 4 Nov 2022 16:40:34 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: <_V2OuM0MATCNzD0XqzU8RW8ER8i9bAalmqtvtPWWU3A=.54a65f5e-6a75-44b5-8f07-c51e29414836@github.com> On Wed, 2 Nov 2022 09:13:56 GMT, Matthias Baesken wrote: > backport of 8289524 The `EventJitRestart` is the counterpart of the `EventCodeCacheFull`. Those who want to see the latter will probably also want to see the first one. Otherwise, you can't see when the problem is solved (performance issue or other issues related to full code cache). It may be needed to understand other events. It is legitimate to omit non-LTS releases, but not so nice. JDK 18 is out of support. I think a JFR user should try it and comment about the usefulness. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From serb at openjdk.org Fri Nov 4 17:50:44 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 4 Nov 2022 17:50:44 GMT Subject: [jdk19u] RFR: 8295554: Move the "sizecalc.h" to the correct location In-Reply-To: References: <41Cu1ZCdAYTIyU8e6yTCa5NcU-etJTzQjPERy6jPFHg=.497185ab-9634-403f-b73e-2c4edd6ab166@github.com> Message-ID: On Wed, 2 Nov 2022 18:41:05 GMT, Alexey Ivanov wrote: >> Hi all, >> This pull request contains a backport of commit [6673cd85](https://github.com/openjdk/jdk/commit/6673cd857722d117b108590ba7f7c02f8622fc3b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov. >> Thanks! > > The bug has now `jdk19u-fix-yes` which it means it can be integrated to 19u. @aivanov-jdk thank you for the help! ------------- PR: https://git.openjdk.org/jdk19u/pull/57 From aivanov at openjdk.org Fri Nov 4 18:03:48 2022 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 4 Nov 2022 18:03:48 GMT Subject: [jdk19u] RFR: 8295554: Move the "sizecalc.h" to the correct location In-Reply-To: References: <41Cu1ZCdAYTIyU8e6yTCa5NcU-etJTzQjPERy6jPFHg=.497185ab-9634-403f-b73e-2c4edd6ab166@github.com> Message-ID: On Wed, 2 Nov 2022 18:41:05 GMT, Alexey Ivanov wrote: >> Hi all, >> This pull request contains a backport of commit [6673cd85](https://github.com/openjdk/jdk/commit/6673cd857722d117b108590ba7f7c02f8622fc3b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov. >> Thanks! > > The bug has now `jdk19u-fix-yes` which it means it can be integrated to 19u. > @aivanov-jdk thank you for the help! You're very welcome, @mrserb! ------------- PR: https://git.openjdk.org/jdk19u/pull/57 From xliu at openjdk.org Fri Nov 4 18:08:10 2022 From: xliu at openjdk.org (Xin Liu) Date: Fri, 4 Nov 2022 18:08:10 GMT Subject: [jdk11u-dev] RFR: 8270947: AArch64: C1: use zero_words to initialize all objects Message-ID: We would like to backport [JDK-8270947](https://bugs.openjdk.org/browse/JDK-8270947) to jdk11u. It's not only less code to maintain, but also better generated code. C1 can leverage DC ZVA in large allocations on aarch64. The secondary consideration is that openjdk11u aligns with oraclejdk11u. This isn't a clean backport. Small cosmetic changes are made in `MacroAssembler::zero_words(Register ptr, Register cnt)` chunk. There are also 2 trailing bugfixes. We will post them together. ------------- Commit messages: - Backport 6c68ce2d396c6fe02201daf2bdb8c164de807cc1 Changes: https://git.openjdk.org/jdk11u-dev/pull/1502/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1502&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8270947 Stats: 28949 lines in 8 files changed: 28783 ins; 117 del; 49 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1502.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1502/head:pull/1502 PR: https://git.openjdk.org/jdk11u-dev/pull/1502 From xliu at openjdk.org Fri Nov 4 18:28:28 2022 From: xliu at openjdk.org (Xin Liu) Date: Fri, 4 Nov 2022 18:28:28 GMT Subject: [jdk11u-dev] RFR: 8272094: compiler/codecache/TestStressCodeBuffers.java crashes with "failed to allocate space for trampoline" Message-ID: This is a stacked PR(2/3) of https://github.com/openjdk/jdk11u-dev/pull/1502. This patch is one of the trailing bugfix of JDK-8270947. It's not a clean patch. I just substitute 'nullptr' with NULL because jdk11u is using gnu++11 to compile HotSpot. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1502 Commit messages: - Backport 0948c097a855dcc9a8a437b4618d7c1922722eab Changes: https://git.openjdk.org/jdk11u-dev/pull/1503/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1503&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272094 Stats: 12 lines in 3 files changed: 7 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1503.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1503/head:pull/1503 PR: https://git.openjdk.org/jdk11u-dev/pull/1503 From xliu at openjdk.org Fri Nov 4 18:38:32 2022 From: xliu at openjdk.org (Xin Liu) Date: Fri, 4 Nov 2022 18:38:32 GMT Subject: [jdk11u-dev] RFR: 8272791: java -XX:BlockZeroingLowLimit=1 crashes after 8270947 Message-ID: <_AiT1jP7_vjAp-szD4MRq1TkOwnHnVKkgGQy-fQNOog=.a9fb0b04-5b32-4dde-91df-93fae8cd5014@github.com> This is a stacked PR(3/3) of https://github.com/openjdk/jdk11u-dev/pull/1502. This patch is one of the trailing bugfix of JDK-8270947. We can apply to jdk11u cleanly. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1503 Commit messages: - Backport e17118aa8afb14dfca049f19fd98a1483b2b5c1b Changes: https://git.openjdk.org/jdk11u-dev/pull/1504/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1504&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272791 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1504.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1504/head:pull/1504 PR: https://git.openjdk.org/jdk11u-dev/pull/1504 From duke at openjdk.org Sat Nov 5 08:28:45 2022 From: duke at openjdk.org (duke) Date: Sat, 5 Nov 2022 08:28:45 GMT Subject: [jdk11u-dev] Withdrawn: 8293202: Document how to edit doc/testing, doc/building In-Reply-To: References: Message-ID: On Fri, 2 Sep 2022 13:25:42 GMT, Ludvig Janiuk wrote: > Hi all, > > This pull request contains a backport of commit [7c2f2994](https://github.com/openjdk/jdk/commit/7c2f2994da1577152870eaf2ea71dfba470c29ef) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ludvig Janiuk on 1 Sep 2022 and was reviewed by Erik Joelsson. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1353 From duke at openjdk.org Sat Nov 5 08:38:39 2022 From: duke at openjdk.org (duke) Date: Sat, 5 Nov 2022 08:38:39 GMT Subject: [jdk18u] Withdrawn: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled In-Reply-To: <9asiWdvOqxpobN4kGz1WLhSA4UVs0qytlUZji-ZLgMY=.7298da47-f9e7-4cf5-91e0-36bab6a2018a@github.com> References: <9asiWdvOqxpobN4kGz1WLhSA4UVs0qytlUZji-ZLgMY=.7298da47-f9e7-4cf5-91e0-36bab6a2018a@github.com> Message-ID: On Wed, 22 Jun 2022 04:14:55 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [50d47de8](https://github.com/openjdk/jdk/commit/50d47de8358e2f22bf3a4a165d660c25ef6eacbc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Jaikiran Pai on 12 May 2022 and was reviewed by Magnus Ihse Bursie and Lance Andersen. > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk18u/pull/175 From phh at openjdk.org Sun Nov 6 22:17:23 2022 From: phh at openjdk.org (Paul Hohensee) Date: Sun, 6 Nov 2022 22:17:23 GMT Subject: [jdk11u-dev] RFR: 8272791: java -XX:BlockZeroingLowLimit=1 crashes after 8270947 In-Reply-To: <_AiT1jP7_vjAp-szD4MRq1TkOwnHnVKkgGQy-fQNOog=.a9fb0b04-5b32-4dde-91df-93fae8cd5014@github.com> References: <_AiT1jP7_vjAp-szD4MRq1TkOwnHnVKkgGQy-fQNOog=.a9fb0b04-5b32-4dde-91df-93fae8cd5014@github.com> Message-ID: On Fri, 4 Nov 2022 18:31:41 GMT, Xin Liu wrote: > This is a stacked PR(3/3) of https://github.com/openjdk/jdk11u-dev/pull/1502. > > This patch is one of the trailing bugfix of JDK-8270947. We can apply to jdk11u cleanly. If the backport is clean, please tag and comment on the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1504 From goetz at openjdk.org Mon Nov 7 08:16:38 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Nov 2022 08:16:38 GMT Subject: [jdk11u-dev] RFR: 8270947: AArch64: C1: use zero_words to initialize all objects In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 17:59:57 GMT, Xin Liu wrote: > We would like to backport [JDK-8270947](https://bugs.openjdk.org/browse/JDK-8270947) to jdk11u. It's not only less code to maintain, but also better generated code. C1 can leverage DC ZVA in large allocations on aarch64. The secondary consideration is that openjdk11u aligns with oraclejdk11u. > > This isn't a clean backport. Small cosmetic changes are made in `MacroAssembler::zero_words(Register ptr, Register cnt)` chunk. > > There are also 2 trailing bugfixes. We will post them together as stacked PRs Hi I think this has four follow ups: What about 8280234 and 8271956? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1502 From goetz at openjdk.org Mon Nov 7 08:37:35 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Nov 2022 08:37:35 GMT Subject: [jdk11u-dev] Withdrawn: 8258894: C2: Forbid GCM to move stores into loops In-Reply-To: <1mu8oweLGuPHCQY5NHdomlzJ-e1e2pKX2I_f1jrS5aU=.4fc24b55-8271-434d-b110-fcf1ec2a132a@github.com> References: <1mu8oweLGuPHCQY5NHdomlzJ-e1e2pKX2I_f1jrS5aU=.4fc24b55-8271-434d-b110-fcf1ec2a132a@github.com> Message-ID: On Fri, 7 Oct 2022 19:53:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. > > Two copyrights had to be resolved. > > I had to resolve two hunks in generateOptoStub.cpp. Simple. > There is #ifdef SPARC code that is left out by the > change. > I edited it canonically (quite obvious), but did not test it. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1401 From mbaesken at openjdk.org Mon Nov 7 08:44:04 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 7 Nov 2022 08:44:04 GMT Subject: [jdk11u-dev] RFR: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures Message-ID: 11u-dev backport of 8292866 ------------- Commit messages: - Backport 699c42962eeaa6aa950ad86c2dd1f77316a1da3e Changes: https://git.openjdk.org/jdk11u-dev/pull/1501/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1501&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292866 Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1501.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1501/head:pull/1501 PR: https://git.openjdk.org/jdk11u-dev/pull/1501 From goetz at openjdk.org Mon Nov 7 09:39:02 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Nov 2022 09:39:02 GMT Subject: [jdk17u-dev] RFR: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 2a2e9190d4e866ac1b712feb0e4bb61d08e112c7 Changes: https://git.openjdk.org/jdk17u-dev/pull/858/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=858&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273685 Stats: 88 lines in 1 file changed: 64 ins; 2 del; 22 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/858.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/858/head:pull/858 PR: https://git.openjdk.org/jdk17u-dev/pull/858 From sadayapalam at openjdk.org Mon Nov 7 09:56:26 2022 From: sadayapalam at openjdk.org (Srikanth Adayapalam) Date: Mon, 7 Nov 2022 09:56:26 GMT Subject: [jdk19u] RFR: 8296021: TYPE_USE annotations on generic type arguments of record components discarded Message-ID: Backport-of: 4d9a1cd26fa0cda902aafcccd6e02bd7bc60bbb3 ------------- Commit messages: - 8296021: TYPE_USE annotations on generic type arguments of record components discarded Changes: https://git.openjdk.org/jdk19u/pull/62/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=62&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296021 Stats: 72 lines in 3 files changed: 69 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk19u/pull/62.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/62/head:pull/62 PR: https://git.openjdk.org/jdk19u/pull/62 From goetz at openjdk.org Mon Nov 7 10:14:21 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Nov 2022 10:14:21 GMT Subject: [jdk17u-dev] RFR: 8286172: Create an automated test for JDK-4516019 Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport e72742eeb5f265e854d098a560cb41c83e93f905 Changes: https://git.openjdk.org/jdk17u-dev/pull/859/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=859&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286172 Stats: 121 lines in 1 file changed: 121 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/859.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/859/head:pull/859 PR: https://git.openjdk.org/jdk17u-dev/pull/859 From goetz at openjdk.org Mon Nov 7 11:30:27 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Nov 2022 11:30:27 GMT Subject: [jdk11u-dev] RFR: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction Message-ID: I backport this for parity with 11.0.19-oracle. ------------- Commit messages: - Backport 2a2e9190d4e866ac1b712feb0e4bb61d08e112c7 Changes: https://git.openjdk.org/jdk11u-dev/pull/1506/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1506&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273685 Stats: 88 lines in 1 file changed: 64 ins; 2 del; 22 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1506.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1506/head:pull/1506 PR: https://git.openjdk.org/jdk11u-dev/pull/1506 From goetz at openjdk.org Mon Nov 7 12:39:46 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Nov 2022 12:39:46 GMT Subject: [jdk17u-dev] Integrated: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false In-Reply-To: <5sYqB3x6BweTr_4ZjNr8P_AX772Sl4hSprDPtivxfRg=.bc280e60-ef43-4c6f-947b-4e60fe6cefeb@github.com> References: <5sYqB3x6BweTr_4ZjNr8P_AX772Sl4hSprDPtivxfRg=.bc280e60-ef43-4c6f-947b-4e60fe6cefeb@github.com> Message-ID: On Thu, 3 Nov 2022 19:31:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.6-oracle. This pull request has now been integrated. Changeset: 21c52e3d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/21c52e3d0b5171beb0d5f0cb86660116565c8348 Stats: 25 lines in 1 file changed: 13 ins; 11 del; 1 mod 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false Backport-of: 5e1e449c116d44fb77a21ce4cd5187cfc55263f2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/857 From goetz at openjdk.org Mon Nov 7 12:41:17 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Nov 2022 12:41:17 GMT Subject: [jdk11u-dev] Integrated: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 17:34:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle from 17. > > I had to resolve src/java.base/share/classes/sun/security/tools/keytool/Main.java > due to various smaller differences. E.g., withWeak() has a > PublicKey as argument in 11, which is a Key in 17. > > Copyright: src/java.base/share/classes/sun/security/tools/keytool/Resources.java > > To make it compile I had to add import for KnownOIDs and > replace usage of finalChain by the available chain. This pull request has now been integrated. Changeset: ca988a65 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ca988a65c6231fd3fc8a418d7e9dce914a55feee Stats: 433 lines in 3 files changed: 378 ins; 0 del; 55 mod 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints Reviewed-by: mbaesken Backport-of: c9c8564d7c094c4dad595c8908f2b37a00130fb6 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1497 From goetz at openjdk.org Mon Nov 7 12:42:36 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Nov 2022 12:42:36 GMT Subject: [jdk11u-dev] Integrated: 8293826: Closed test fails after JDK-8276108 on aarch64 In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 11:06:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. > > A quite special backport as the original issue is not public. This pull request has now been integrated. Changeset: 3e3f6655 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/3e3f66552d4098c9530dd15ce87ecb52d9b0cdeb Stats: 20 lines in 1 file changed: 0 ins; 17 del; 3 mod 8293826: Closed test fails after JDK-8276108 on aarch64 11u backport of JDK-8278417 Reviewed-by: aph Backport-of: 62eb5ae268c23c3b2496a0f7f9c3b7001f75b362 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1500 From vromero at openjdk.org Mon Nov 7 13:55:37 2022 From: vromero at openjdk.org (Vicente Romero) Date: Mon, 7 Nov 2022 13:55:37 GMT Subject: [jdk19u] RFR: 8296021: TYPE_USE annotations on generic type arguments of record components discarded In-Reply-To: References: Message-ID: <3hHIFhVUCKi0lTgBnIe8Kab2aHMrg0wza1gFxeJ-MVo=.4b9ba295-8164-441b-8fdd-e10a314d60da@github.com> On Mon, 7 Nov 2022 09:48:55 GMT, Srikanth Adayapalam wrote: > Backport-of: 4d9a1cd26fa0cda902aafcccd6e02bd7bc60bbb3 looks good ------------- Marked as reviewed by vromero (Reviewer). PR: https://git.openjdk.org/jdk19u/pull/62 From clanger at openjdk.org Mon Nov 7 14:03:54 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 7 Nov 2022 14:03:54 GMT Subject: [jdk17u-dev] Integrated: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch" In-Reply-To: References: Message-ID: <5SOcudF78hXr9i1ytPSN3kEWTYMQX-G5V4TBwFH3ius=.08a80051-2172-4c92-9930-fa3542b471f0@github.com> On Thu, 3 Nov 2022 19:21:06 GMT, Christoph Langer wrote: > Backport of JDK-8277970. > I had to trivially resolve because JDK-8282723 is not in 17u. However, the bots flag it as clean. ? This pull request has now been integrated. Changeset: 18c4c253 Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/18c4c253b388f5c031bd8a74a3283cf6e80fb841 Stats: 9 lines in 3 files changed: 6 ins; 1 del; 2 mod 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch" Backport-of: d1252653b07ee3d0347b39b96f734e45772b5b36 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/855 From clanger at openjdk.org Mon Nov 7 14:05:26 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 7 Nov 2022 14:05:26 GMT Subject: [jdk11u-dev] Integrated: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch" In-Reply-To: <8-hLl70Ka2fJ5PbPMPN-QJlbQCuPAF9GDDbTdniBE30=.0a962862-af45-483d-b74f-966b031850a9@github.com> References: <8-hLl70Ka2fJ5PbPMPN-QJlbQCuPAF9GDDbTdniBE30=.0a962862-af45-483d-b74f-966b031850a9@github.com> Message-ID: On Thu, 3 Nov 2022 20:17:35 GMT, Christoph Langer wrote: > Backport of JDK-8277970. > I had to trivially resolve because JDK-8282723 is not in 11u. Let's see whether the bots will flag it as clean... This pull request has now been integrated. Changeset: f07e6918 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/f07e69187b79863b78d5e985be84f15f4ecc462b Stats: 9 lines in 3 files changed: 6 ins; 1 del; 2 mod 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch" Backport-of: d1252653b07ee3d0347b39b96f734e45772b5b36 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1499 From clanger at openjdk.org Mon Nov 7 14:06:34 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 7 Nov 2022 14:06:34 GMT Subject: [jdk11u-dev] Integrated: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode In-Reply-To: <-cpyZdFR5QaUcTDQvH5YMaNRNNejAhl7cxX7gMIsszw=.4f21daf4-797a-45ae-a787-e45979fe84ad@github.com> References: <-cpyZdFR5QaUcTDQvH5YMaNRNNejAhl7cxX7gMIsszw=.4f21daf4-797a-45ae-a787-e45979fe84ad@github.com> Message-ID: On Thu, 3 Nov 2022 13:07:43 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8277881](https://bugs.openjdk.java.net/browse/JDK-8277881), commit [9d99a377](https://github.com/openjdk/jdk/commit/9d99a377bfb6ffa890db049aee575e97914fc2a1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Daniel Jelinski on 24 Dec 2021 and was reviewed by Anthony Scarpino. > > Thanks! This pull request has now been integrated. Changeset: 8f5ae914 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/8f5ae914eb71d229f16e65a3a32acfde6da25c65 Stats: 15 lines in 3 files changed: 4 ins; 1 del; 10 mod 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode Backport-of: 9d99a377bfb6ffa890db049aee575e97914fc2a1 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1496 From sadayapalam at openjdk.org Mon Nov 7 15:02:02 2022 From: sadayapalam at openjdk.org (Srikanth Adayapalam) Date: Mon, 7 Nov 2022 15:02:02 GMT Subject: [jdk19u] Integrated: 8292159: TYPE_USE annotations on generic type arguments of record components discarded In-Reply-To: References: Message-ID: On Mon, 7 Nov 2022 09:48:55 GMT, Srikanth Adayapalam wrote: > Backport-of: 4d9a1cd26fa0cda902aafcccd6e02bd7bc60bbb3 This pull request has now been integrated. Changeset: c6e18499 Author: Srikanth Adayapalam URL: https://git.openjdk.org/jdk19u/commit/c6e184999c2c8b7965f87001178613320bdce70a Stats: 72 lines in 3 files changed: 69 ins; 0 del; 3 mod 8292159: TYPE_USE annotations on generic type arguments of record components discarded Reviewed-by: vromero Backport-of: 4d9a1cd26fa0cda902aafcccd6e02bd7bc60bbb3 ------------- PR: https://git.openjdk.org/jdk19u/pull/62 From phh at openjdk.org Mon Nov 7 15:48:55 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 7 Nov 2022 15:48:55 GMT Subject: [jdk11u-dev] RFR: 8270947: AArch64: C1: use zero_words to initialize all objects In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 17:59:57 GMT, Xin Liu wrote: > We would like to backport [JDK-8270947](https://bugs.openjdk.org/browse/JDK-8270947) to jdk11u. It's not only less code to maintain, but also better generated code. C1 can leverage DC ZVA in large allocations on aarch64. The secondary consideration is that openjdk11u aligns with oraclejdk11u. > > This isn't a clean backport. Small cosmetic changes are made in `MacroAssembler::zero_words(Register ptr, Register cnt)` chunk. > > There are also 2 trailing bugfixes. We will post them together as stacked PRs Passed tier1. Lgtm. Pre-submit failure looks to be an infrastructure issue. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1502 From vrudomet at openjdk.org Mon Nov 7 18:51:57 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Mon, 7 Nov 2022 18:51:57 GMT Subject: [jdk11u-dev] Integrated: 8261445: Use memory_order_relaxed for os::random(). In-Reply-To: References: Message-ID: On Wed, 26 Oct 2022 19:28:42 GMT, Victor Rudometov wrote: > Backport https://bugs.openjdk.org/browse/JDK-8261445 Use memory_order_relaxed for os::random() for jdk11u > > Backport not clean, however the change is trivial. > Tested in linux x64/aarch64: tier1, tier2, jck's passed. This pull request has now been integrated. Changeset: df9c46ae Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/df9c46aef41996195cc3caa12b0a41171d533e4e Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8261445: Use memory_order_relaxed for os::random(). Reviewed-by: phh Backport-of: a25bae823979fc96d01a2e349506ed3b1ea39762 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1480 From duke at openjdk.org Mon Nov 7 19:21:49 2022 From: duke at openjdk.org (Scott Gibbons) Date: Mon, 7 Nov 2022 19:21:49 GMT Subject: [jdk17u-dev] RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v3] In-Reply-To: <2OAEPLwykVb_jnoj5P_pJTa6BNebcMb8KHLZi_cWThM=.a166cc77-9d71-4db1-acd9-1823c6abe1b6@github.com> References: <2OAEPLwykVb_jnoj5P_pJTa6BNebcMb8KHLZi_cWThM=.a166cc77-9d71-4db1-acd9-1823c6abe1b6@github.com> Message-ID: <2GQEi3uK-fHudz4Astq0LW5iYxRiDzBQc9x6ZbQ_FWw=.8554b344-8b6a-4277-b0f3-7c05c9bbe9bb@github.com> On Mon, 31 Oct 2022 20:26:26 GMT, Scott Gibbons wrote: >> This is a backport of JDK-8268276: Base64 Decoding optimization for x86 using AVX-512. >> >> We have had numerous customer requests for this functionality to be backported due to the ~19x performance improvement. >> >> Original patch does not apply cleanly to 17u, because of a bug that was identified in the original commit, but not fixed until the later Base64 Encode acceleration enhancement was complete. The fix is on line 6039 of src/hotspot/cpu/x86/stubGenerator_x86_64.cpp and has been included in this PR. All four "translatedX" registers needed to be checked for illegal characters in the input stream. >> >> Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. >> >> Testing: x86_64 build, affected tests, tier1, tier2 >> >> Thanks, >> --Scott > > Scott Gibbons has updated the pull request incrementally with two additional commits since the last revision: > > - Merge branch 'Decode-backport' of https://github.com/asgibbons/jdk17u-dev into Decode-backport > - Hand-merging bugfix 9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e Trying to do dependent PRs instead of piecemealing. Let me know if I'm doing something wrong. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/840 From duke at openjdk.org Mon Nov 7 19:21:49 2022 From: duke at openjdk.org (Scott Gibbons) Date: Mon, 7 Nov 2022 19:21:49 GMT Subject: [jdk17u-dev] Withdrawn: 8268276: Base64 Decoding optimization for x86 using AVX-512 In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 22:24:51 GMT, Scott Gibbons wrote: > This is a backport of JDK-8268276: Base64 Decoding optimization for x86 using AVX-512. > > We have had numerous customer requests for this functionality to be backported due to the ~19x performance improvement. > > Original patch does not apply cleanly to 17u, because of a bug that was identified in the original commit, but not fixed until the later Base64 Encode acceleration enhancement was complete. The fix is on line 6039 of src/hotspot/cpu/x86/stubGenerator_x86_64.cpp and has been included in this PR. All four "translatedX" registers needed to be checked for illegal characters in the input stream. > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1, tier2 > > Thanks, > --Scott This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/840 From xliu at openjdk.org Mon Nov 7 20:44:38 2022 From: xliu at openjdk.org (Xin Liu) Date: Mon, 7 Nov 2022 20:44:38 GMT Subject: [jdk11u-dev] RFR: 8270947: AArch64: C1: use zero_words to initialize all objects In-Reply-To: References: Message-ID: On Mon, 7 Nov 2022 08:12:39 GMT, Goetz Lindenmaier wrote: > Hi I think this has four follow ups: What about 8280234 and 8271956? Hi, thank you for the reminder. I didn't notice them at the beginning. Those two fixed compilation issues for other variants. 1. [8271956](https://bugs.openjdk.org/browse/JDK-8271956) is for variant client. 2. [8280234](https://bugs.openjdk.org/browse/JDK-8280234) is for variant core. For item-1, I can reproduce it in jdk11u. The backport is trivial. I will append it to the Stack PRs. for item-2, I can't reproduce it! it's because current jdk11u can't build variant 'core'. Here is the error message. === Output from failing command(s) repeated here === ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1502 From xliu at openjdk.org Mon Nov 7 20:56:32 2022 From: xliu at openjdk.org (Xin Liu) Date: Mon, 7 Nov 2022 20:56:32 GMT Subject: [jdk11u-dev] RFR: 8271956: AArch64: C1 build failed after JDK-8270947 Message-ID: 8271956: AArch64: C1 build failed after JDK-8270947 ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1504 Commit messages: - Backport b84a9c7b377282bd9b3d9ac78707f0c12f8dc53d Changes: https://git.openjdk.org/jdk11u-dev/pull/1507/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1507&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8271956 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1507.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1507/head:pull/1507 PR: https://git.openjdk.org/jdk11u-dev/pull/1507 From xliu at openjdk.org Mon Nov 7 23:05:35 2022 From: xliu at openjdk.org (Xin Liu) Date: Mon, 7 Nov 2022 23:05:35 GMT Subject: [jdk11u-dev] RFR: 8270947: AArch64: C1: use zero_words to initialize all objects In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 17:59:57 GMT, Xin Liu wrote: > We would like to backport [JDK-8270947](https://bugs.openjdk.org/browse/JDK-8270947) to jdk11u. It's not only less code to maintain, but also better generated code. C1 can leverage DC ZVA in large allocations on aarch64. The secondary consideration is that openjdk11u aligns with oraclejdk11u. > > This isn't a clean backport. Small cosmetic changes are made in `MacroAssembler::zero_words(Register ptr, Register cnt)` chunk. > > There are also 2 trailing bugfixes. We will post them together as stacked PRs I filed an issue about the build failure of variant=core. https://bugs.openjdk.org/browse/JDK-8296502 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1502 From phh at openjdk.org Mon Nov 7 23:14:29 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 7 Nov 2022 23:14:29 GMT Subject: [jdk11u-dev] RFR: 8272094: compiler/codecache/TestStressCodeBuffers.java crashes with "failed to allocate space for trampoline" In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 18:20:18 GMT, Xin Liu wrote: > This is a stacked PR(2/3) of https://github.com/openjdk/jdk11u-dev/pull/1502. > > This patch is one of the trailing bugfix of JDK-8270947. It's not a clean patch. I just substitute 'nullptr' with NULL because jdk11u is using gnu++11 to compile HotSpot. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1503 From phh at openjdk.org Mon Nov 7 23:18:34 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 7 Nov 2022 23:18:34 GMT Subject: [jdk11u-dev] RFR: 8272791: java -XX:BlockZeroingLowLimit=1 crashes after 8270947 In-Reply-To: <_AiT1jP7_vjAp-szD4MRq1TkOwnHnVKkgGQy-fQNOog=.a9fb0b04-5b32-4dde-91df-93fae8cd5014@github.com> References: <_AiT1jP7_vjAp-szD4MRq1TkOwnHnVKkgGQy-fQNOog=.a9fb0b04-5b32-4dde-91df-93fae8cd5014@github.com> Message-ID: On Fri, 4 Nov 2022 18:31:41 GMT, Xin Liu wrote: > This is a stacked PR(3/3) of https://github.com/openjdk/jdk11u-dev/pull/1502. > > This patch is one of the trailing bugfix of JDK-8270947. We can apply to jdk11u cleanly. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1504 From phh at openjdk.org Mon Nov 7 23:31:30 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 7 Nov 2022 23:31:30 GMT Subject: [jdk11u-dev] RFR: 8270947: AArch64: C1: use zero_words to initialize all objects In-Reply-To: References: Message-ID: <2r81GiVNq8fZUKZ2dyXrM7H5-GO7eezeJTybLrZB75U=.bb73e190-d2c2-45d9-9a1e-78382c453fe0@github.com> On Fri, 4 Nov 2022 17:59:57 GMT, Xin Liu wrote: > We would like to backport [JDK-8270947](https://bugs.openjdk.org/browse/JDK-8270947) to jdk11u. It's not only less code to maintain, but also better generated code. C1 can leverage DC ZVA in large allocations on aarch64. The secondary consideration is that openjdk11u aligns with oraclejdk11u. > > This isn't a clean backport. Small cosmetic changes are made in `MacroAssembler::zero_words(Register ptr, Register cnt)` chunk. > > There are also 2 trailing bugfixes. We will post them together as stacked PRs There may be an existing JBS issue patch that fixes the problem. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1502 From duke at openjdk.org Tue Nov 8 01:25:46 2022 From: duke at openjdk.org (Scott Gibbons) Date: Tue, 8 Nov 2022 01:25:46 GMT Subject: [jdk17u-dev] RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 Message-ID: <0y7sAHmlGQjKuPhNiZQE-e7ZYBo9NV5sU-ZJ93owKY4=.90744926-3cc4-41e6-9d3c-0436a2e1027b@github.com> This is a backport of JDK-8268276: Base64 Decoding optimization for x86 using AVX-512. Backport is clean. We have had numerous customer requests for this functionality to be backported due to the ~19x performance improvement. There will be two additional PRs for which this is a dependency. I will add the PR numbers when available. Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. Testing: x86_64 build, affected tests, tier1 Thanks, --Scott ------------- Commit messages: - Backport c37988d0793b24d98d285530dfda69999a227937 Changes: https://git.openjdk.org/jdk17u-dev/pull/860/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=860&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8268276 Stats: 753 lines in 12 files changed: 735 ins; 4 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/860.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/860/head:pull/860 PR: https://git.openjdk.org/jdk17u-dev/pull/860 From duke at openjdk.org Tue Nov 8 02:02:28 2022 From: duke at openjdk.org (Scott Gibbons) Date: Tue, 8 Nov 2022 02:02:28 GMT Subject: [jdk17u-dev] RFR: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 Message-ID: This is a backport of JDK-8269404: Base64 Encoding optimization enhancements for x86 using AVX-512. Backport is clean. We have had numerous customer requests for this functionality to be backported due to the performance improvement. There will be one additional PR for which this is a dependency. This dependency is dependent on PR #860. Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. Testing: x86_64 build, affected tests, tier1 Thanks, --Scott ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/860 Commit messages: - Backport 9cac94d581f240c10fe8fff2f803109a1ae30637 Changes: https://git.openjdk.org/jdk17u-dev/pull/861/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=861&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8269404 Stats: 710 lines in 5 files changed: 349 ins; 235 del; 126 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/861.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/861/head:pull/861 PR: https://git.openjdk.org/jdk17u-dev/pull/861 From duke at openjdk.org Tue Nov 8 02:54:44 2022 From: duke at openjdk.org (Scott Gibbons) Date: Tue, 8 Nov 2022 02:54:44 GMT Subject: [jdk17u-dev] RFR: 8273459: Update code segment alignment to 64 bytes Message-ID: <7MimxIbRHGnEwnGXTtJzk9XZ05vN_XZuT28XGzJZhr0=.c79a9799-6df6-469d-aee9-ba438198f14b@github.com> One of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. The next one will be for align32(), then followed by the buffer overrun bugfix required for Base64 decoding to work properly. Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. Testing: x86_64 build, affected tests, tier1 Thanks, --Scott ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/861 Commit messages: - Backport 53b25bce878bc291f3a217da7c26fd3097f18cfd Changes: https://git.openjdk.org/jdk17u-dev/pull/862/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=862&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273459 Stats: 27 lines in 4 files changed: 10 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/862.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/862/head:pull/862 PR: https://git.openjdk.org/jdk17u-dev/pull/862 From duke at openjdk.org Tue Nov 8 03:27:41 2022 From: duke at openjdk.org (Scott Gibbons) Date: Tue, 8 Nov 2022 03:27:41 GMT Subject: [jdk17u-dev] RFR: 8274527: Minimal VM build fails after JDK-8273459 Message-ID: Second of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. The next one will be for the buffer overrun bugfix required for Base64 decoding to work properly. Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. Testing: x86_64 build, affected tests, tier1 Thanks, --Scott ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/862 Commit messages: - Backport cdd8743b217f9d6a2f814fe27ebfc544e343055e Changes: https://git.openjdk.org/jdk17u-dev/pull/863/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=863&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274527 Stats: 22 lines in 4 files changed: 5 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/863.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/863/head:pull/863 PR: https://git.openjdk.org/jdk17u-dev/pull/863 From duke at openjdk.org Tue Nov 8 03:43:40 2022 From: duke at openjdk.org (Scott Gibbons) Date: Tue, 8 Nov 2022 03:43:40 GMT Subject: [jdk17u-dev] RFR: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276 Message-ID: Last of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. Testing: x86_64 build, affected tests, tier1 Thanks, --Scott ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/863 Commit messages: - Backport 9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e Changes: https://git.openjdk.org/jdk17u-dev/pull/864/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=864&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273108 Stats: 12 lines in 2 files changed: 7 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/864.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/864/head:pull/864 PR: https://git.openjdk.org/jdk17u-dev/pull/864 From yan at openjdk.org Tue Nov 8 08:12:20 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 8 Nov 2022 08:12:20 GMT Subject: [jdk13u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f Message-ID: This is a regular backport of TZ 2022f. Basically clean backport with a necessary change of src/java.base/share/data/tzdata to make/data/tzdata. All relevant tests do pass. ------------- Commit messages: - Backport 9d3b4ef2ad658afb5379796b7224458c12c81f5d Changes: https://git.openjdk.org/jdk13u-dev/pull/427/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=427&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296108 Stats: 1362 lines in 25 files changed: 560 ins; 705 del; 97 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/427.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/427/head:pull/427 PR: https://git.openjdk.org/jdk13u-dev/pull/427 From yan at openjdk.org Tue Nov 8 08:55:21 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 8 Nov 2022 08:55:21 GMT Subject: [jdk15u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f Message-ID: This is a regular backport of TZ 2022f. Basically clean backport with a necessary change of src/java.base/share/data/tzdata to make/data/tzdata. All relevant tests do pass. ------------- Commit messages: - Backport 9d3b4ef2ad658afb5379796b7224458c12c81f5d Changes: https://git.openjdk.org/jdk15u-dev/pull/301/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=301&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296108 Stats: 1362 lines in 25 files changed: 560 ins; 705 del; 97 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/301.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/301/head:pull/301 PR: https://git.openjdk.org/jdk15u-dev/pull/301 From bae at openjdk.org Tue Nov 8 09:36:36 2022 From: bae at openjdk.org (Andrew Brygin) Date: Tue, 8 Nov 2022 09:36:36 GMT Subject: [jdk15u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 08:46:45 GMT, Yuri Nesterenko wrote: > This is a regular backport of TZ 2022f. Basically clean backport with a necessary change of src/java.base/share/data/tzdata to make/data/tzdata. All relevant tests do pass. Marked as reviewed by bae (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/301 From bae at openjdk.org Tue Nov 8 09:38:32 2022 From: bae at openjdk.org (Andrew Brygin) Date: Tue, 8 Nov 2022 09:38:32 GMT Subject: [jdk13u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 08:05:05 GMT, Yuri Nesterenko wrote: > This is a regular backport of TZ 2022f. Basically clean backport with a necessary change of src/java.base/share/data/tzdata to make/data/tzdata. All relevant tests do pass. Marked as reviewed by bae (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/427 From yan at openjdk.org Tue Nov 8 09:46:32 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 8 Nov 2022 09:46:32 GMT Subject: [jdk13u-dev] Integrated: 8296108: (tz) Update Timezone Data to 2022f In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 08:05:05 GMT, Yuri Nesterenko wrote: > This is a regular backport of TZ 2022f. Basically clean backport with a necessary change of src/java.base/share/data/tzdata to make/data/tzdata. All relevant tests do pass. This pull request has now been integrated. Changeset: 46c908b7 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/46c908b7f2d9778f4793fbf9c2261a6d41122743 Stats: 1362 lines in 25 files changed: 560 ins; 705 del; 97 mod 8296108: (tz) Update Timezone Data to 2022f Reviewed-by: bae Backport-of: 9d3b4ef2ad658afb5379796b7224458c12c81f5d ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/427 From yan at openjdk.org Tue Nov 8 09:47:36 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 8 Nov 2022 09:47:36 GMT Subject: [jdk15u-dev] Integrated: 8296108: (tz) Update Timezone Data to 2022f In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 08:46:45 GMT, Yuri Nesterenko wrote: > This is a regular backport of TZ 2022f. Basically clean backport with a necessary change of src/java.base/share/data/tzdata to make/data/tzdata. All relevant tests do pass. This pull request has now been integrated. Changeset: 7379b6b2 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/7379b6b205528464ec79459ddc6fb5f6cab556df Stats: 1362 lines in 25 files changed: 560 ins; 705 del; 97 mod 8296108: (tz) Update Timezone Data to 2022f Reviewed-by: bae Backport-of: 9d3b4ef2ad658afb5379796b7224458c12c81f5d ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/301 From shade at openjdk.org Tue Nov 8 09:48:51 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 09:48:51 GMT Subject: [jdk19u] RFR: 8295469: S390X: Optimized builds are broken In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 17:09:14 GMT, Aleksey Shipilev wrote: > Fixes S390X optimized builds. > > Additional testing: > - [x] Linux S390X {fastdebug, release, slowdebug, optimized} builds Got the push approval. ------------- PR: https://git.openjdk.org/jdk19u/pull/58 From shade at openjdk.org Tue Nov 8 09:50:01 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 09:50:01 GMT Subject: [jdk19u] RFR: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 16:29:34 GMT, Aleksey Shipilev wrote: > Clean backport to fix the test on newer Debian/Ubuntu machines. The test is executed in tier2, and currently fails. > > Additional testing: > - [x] Linux x86_64 fastdebug: affected test now passes Got the push approval. ------------- PR: https://git.openjdk.org/jdk19u/pull/56 From shade at openjdk.org Tue Nov 8 09:50:39 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 09:50:39 GMT Subject: [jdk17u-dev] RFR: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag In-Reply-To: References: Message-ID: On Wed, 26 Oct 2022 11:34:38 GMT, Aleksey Shipilev wrote: > Clean backport to fix the minor performance bug. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/843 From shade at openjdk.org Tue Nov 8 09:51:52 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 09:51:52 GMT Subject: [jdk19u] Integrated: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 16:29:34 GMT, Aleksey Shipilev wrote: > Clean backport to fix the test on newer Debian/Ubuntu machines. The test is executed in tier2, and currently fails. > > Additional testing: > - [x] Linux x86_64 fastdebug: affected test now passes This pull request has now been integrated. Changeset: 9badfe4b Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk19u/commit/9badfe4b16c23ab05627dbb61deed493cab4f7ff Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails Backport-of: cddd6def9f796a25137e0059e82053142747c001 ------------- PR: https://git.openjdk.org/jdk19u/pull/56 From shade at openjdk.org Tue Nov 8 09:52:28 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 09:52:28 GMT Subject: [jdk19u] Integrated: 8295469: S390X: Optimized builds are broken In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 17:09:14 GMT, Aleksey Shipilev wrote: > Fixes S390X optimized builds. > > Additional testing: > - [x] Linux S390X {fastdebug, release, slowdebug, optimized} builds This pull request has now been integrated. Changeset: 0f76adec Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk19u/commit/0f76adecfbbb78a3462586496b8cfebd102b724a Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8295469: S390X: Optimized builds are broken Backport-of: 7b2e83b3955c034208325ea5477afd3c5e1da41a ------------- PR: https://git.openjdk.org/jdk19u/pull/58 From shade at openjdk.org Tue Nov 8 09:52:32 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 09:52:32 GMT Subject: [jdk17u-dev] Integrated: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag In-Reply-To: References: Message-ID: <8yvMRdqjbEnHLtA904cHbO7VDCZpfT6XSaHKWvaSKs4=.e7e75a07-aa6d-487e-bca4-b78d1a4add58@github.com> On Wed, 26 Oct 2022 11:34:38 GMT, Aleksey Shipilev wrote: > Clean backport to fix the minor performance bug. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` This pull request has now been integrated. Changeset: a61b74e2 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/a61b74e2adf9aa05747a4b71669e3542a1e98e4b Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag Backport-of: 08f0be8388914901ac40525ed995136ce020f432 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/843 From shade at openjdk.org Tue Nov 8 09:54:37 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 09:54:37 GMT Subject: [jdk17u-dev] RFR: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 16:12:30 GMT, Aleksey Shipilev wrote: > Clean backport to fix the test on newer Debian/Ubuntu machines. The test is executed in `tier2`, and currently fails. > > Additional testing: > - [x] Linux x86_64 fastdebug: affected test now passes Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/838 From shade at openjdk.org Tue Nov 8 09:54:37 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 09:54:37 GMT Subject: [jdk17u-dev] Integrated: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 16:12:30 GMT, Aleksey Shipilev wrote: > Clean backport to fix the test on newer Debian/Ubuntu machines. The test is executed in `tier2`, and currently fails. > > Additional testing: > - [x] Linux x86_64 fastdebug: affected test now passes This pull request has now been integrated. Changeset: a00bd138 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/a00bd13884800a2ee45071d1776af94339d86be8 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails Backport-of: cddd6def9f796a25137e0059e82053142747c001 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/838 From shade at openjdk.org Tue Nov 8 09:56:43 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 09:56:43 GMT Subject: [jdk17u-dev] RFR: 8281744: x86: Use short jumps in TIG::set_vtos_entry_points In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 16:05:50 GMT, Aleksey Shipilev wrote: > Clean (and arguably safe) backport to improve cold/interpreter performance. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` > - [x] Linux x86_64 fastdebug `tier2` Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/836 From shade at openjdk.org Tue Nov 8 10:00:19 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 10:00:19 GMT Subject: [jdk17u-dev] Integrated: 8281744: x86: Use short jumps in TIG::set_vtos_entry_points In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 16:05:50 GMT, Aleksey Shipilev wrote: > Clean (and arguably safe) backport to improve cold/interpreter performance. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` > - [x] Linux x86_64 fastdebug `tier2` This pull request has now been integrated. Changeset: 3a5bcf04 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/3a5bcf0407ba891c9497afb6f1d8f807a794204d Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod 8281744: x86: Use short jumps in TIG::set_vtos_entry_points Backport-of: 18704653dcc76b6360b746a6a9c20d614633da0e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/836 From shade at openjdk.org Tue Nov 8 10:01:35 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 10:01:35 GMT Subject: [jdk11u-dev] RFR: 8283199: Linux os::cpu_microcode_revision() stalls cold startup In-Reply-To: References: Message-ID: On Mon, 24 Oct 2022 09:32:39 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the startup time regression. > > The backport is not clean, because [JDK-8238161](https://bugs.openjdk.org/browse/JDK-8238161) is not present in JDK 11, and thus we have `fopen` instead of `os::fopen` in these hunks. I changed the code back to `fopen` to be consistent with the rest of JDK 11. > > Verified the startup time improves, using the scripts from the issue. > > > # Before > real 0m0.081s > real 0m0.081s > real 0m0.081s > > # After > real 0m0.062s > real 0m0.062s > real 0m0.062s > > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` Any takers? :) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1471 From shade at openjdk.org Tue Nov 8 10:01:38 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 10:01:38 GMT Subject: [jdk17u-dev] RFR: 8283199: Linux os::cpu_microcode_revision() stalls cold startup In-Reply-To: References: Message-ID: On Mon, 24 Oct 2022 09:23:07 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the startup time regression. > > The backport is not clean, because [JDK-8238161](https://bugs.openjdk.org/browse/JDK-8238161) is not present in JDK 17, and thus we have `fopen` instead of `os::fopen` in these hunks. I changed the code back to `fopen` to be consistent with the rest of JDK 17. > > Verified the startup time improves, using the scripts from the issue. > > > # Before > real 0m0.042s > real 0m0.043s > real 0m0.043s > > # After > real 0m0.025s > real 0m0.024s > real 0m0.024s > > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` Any takers? :) ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/820 From stuefe at openjdk.org Tue Nov 8 10:45:24 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 8 Nov 2022 10:45:24 GMT Subject: [jdk17u-dev] RFR: 8283199: Linux os::cpu_microcode_revision() stalls cold startup In-Reply-To: References: Message-ID: On Mon, 24 Oct 2022 09:23:07 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the startup time regression. > > The backport is not clean, because [JDK-8238161](https://bugs.openjdk.org/browse/JDK-8238161) is not present in JDK 17, and thus we have `fopen` instead of `os::fopen` in these hunks. I changed the code back to `fopen` to be consistent with the rest of JDK 17. > > Verified the startup time improves, using the scripts from the issue. > > > # Before > real 0m0.042s > real 0m0.043s > real 0m0.043s > > # After > real 0m0.025s > real 0m0.024s > real 0m0.024s > > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` All good. ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/820 From shade at openjdk.org Tue Nov 8 11:18:32 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 11:18:32 GMT Subject: [jdk17u-dev] RFR: 8283199: Linux os::cpu_microcode_revision() stalls cold startup In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 10:41:52 GMT, Thomas Stuefe wrote: > All good. Thanks! I marked the issue for approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/820 From goetz at openjdk.org Tue Nov 8 13:08:34 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Nov 2022 13:08:34 GMT Subject: [jdk11u-dev] RFR: 8277497: Last column cell in the JTable row is read as empty cell In-Reply-To: References: Message-ID: On Tue, 1 Nov 2022 16:46:32 GMT, William Kemper wrote: > Hi all, > > This pull request contains a backport of commit [70bad89b](https://github.com/openjdk/jdk/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Artem Semenov on 6 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal. This backport brings parity with oracle 11. > > Thanks! Removing the tag for now. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1490 From shade at openjdk.org Tue Nov 8 13:10:27 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 13:10:27 GMT Subject: [jdk17u-dev] RFR: 8283199: Linux os::cpu_microcode_revision() stalls cold startup In-Reply-To: References: Message-ID: On Mon, 24 Oct 2022 09:23:07 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the startup time regression. > > The backport is not clean, because [JDK-8238161](https://bugs.openjdk.org/browse/JDK-8238161) is not present in JDK 17, and thus we have `fopen` instead of `os::fopen` in these hunks. I changed the code back to `fopen` to be consistent with the rest of JDK 17. > > Verified the startup time improves, using the scripts from the issue. > > > # Before > real 0m0.042s > real 0m0.043s > real 0m0.043s > > # After > real 0m0.025s > real 0m0.024s > real 0m0.024s > > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/820 From goetz at openjdk.org Tue Nov 8 13:11:19 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Nov 2022 13:11:19 GMT Subject: [jdk11u-dev] RFR: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 15:06:53 GMT, Matthias Baesken wrote: > 11u-dev backport of 8292866 Omitted Copyright, which is already updated. LGTM Hi, you should have the issue reviewed before labeling it. (This one would have qualified for a /clean command after motivating it. ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1501 From shade at openjdk.org Tue Nov 8 13:12:02 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 8 Nov 2022 13:12:02 GMT Subject: [jdk17u-dev] Integrated: 8283199: Linux os::cpu_microcode_revision() stalls cold startup In-Reply-To: References: Message-ID: <77BJmLqmq6HIrSuMF_0vpne2OV0Cvo5XGTrERkh4g2I=.3319be6d-bb74-4e7c-bfd8-d3a0ff597329@github.com> On Mon, 24 Oct 2022 09:23:07 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the startup time regression. > > The backport is not clean, because [JDK-8238161](https://bugs.openjdk.org/browse/JDK-8238161) is not present in JDK 17, and thus we have `fopen` instead of `os::fopen` in these hunks. I changed the code back to `fopen` to be consistent with the rest of JDK 17. > > Verified the startup time improves, using the scripts from the issue. > > > # Before > real 0m0.042s > real 0m0.043s > real 0m0.043s > > # After > real 0m0.025s > real 0m0.024s > real 0m0.024s > > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` This pull request has now been integrated. Changeset: 6196d93e Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/6196d93e54f387b675eedf787b4b266d961cc6a3 Stats: 19 lines in 1 file changed: 16 ins; 0 del; 3 mod 8283199: Linux os::cpu_microcode_revision() stalls cold startup Reviewed-by: stuefe Backport-of: 1443f6b9191c127abdae38cadb1a44af3c652f1d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/820 From goetz at openjdk.org Tue Nov 8 13:15:35 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Nov 2022 13:15:35 GMT Subject: [jdk11u-dev] Integrated: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction In-Reply-To: References: Message-ID: On Mon, 7 Nov 2022 11:22:52 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. This pull request has now been integrated. Changeset: 03e12472 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/03e1247274fcce8f4f3f06d56e0fe44597691227 Stats: 88 lines in 1 file changed: 64 ins; 2 del; 22 mod 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction Backport-of: 2a2e9190d4e866ac1b712feb0e4bb61d08e112c7 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1506 From goetz at openjdk.org Tue Nov 8 13:15:40 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Nov 2022 13:15:40 GMT Subject: [jdk17u-dev] Integrated: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction In-Reply-To: References: Message-ID: On Mon, 7 Nov 2022 09:30:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: c29dc160 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c29dc160f7f8bc70e361cdc84bd069c869af3e15 Stats: 88 lines in 1 file changed: 64 ins; 2 del; 22 mod 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction Backport-of: 2a2e9190d4e866ac1b712feb0e4bb61d08e112c7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/858 From mbaesken at openjdk.org Tue Nov 8 13:16:51 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 8 Nov 2022 13:16:51 GMT Subject: [jdk11u-dev] RFR: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 15:06:53 GMT, Matthias Baesken wrote: > 11u-dev backport of 8292866 Thanks for the review ! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1501 From mbaesken at openjdk.org Tue Nov 8 13:18:27 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 8 Nov 2022 13:18:27 GMT Subject: [jdk11u-dev] Integrated: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 15:06:53 GMT, Matthias Baesken wrote: > 11u-dev backport of 8292866 This pull request has now been integrated. Changeset: c09c4337 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/c09c43375fbaf40605380d3e3654b3742dcc0e30 Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures Reviewed-by: goetz Backport-of: 699c42962eeaa6aa950ad86c2dd1f77316a1da3e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1501 From goetz at openjdk.org Tue Nov 8 13:21:36 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Nov 2022 13:21:36 GMT Subject: [jdk17u-dev] Integrated: 8286172: Create an automated test for JDK-4516019 In-Reply-To: References: Message-ID: <8GghA7-X8wK1nk_zNQhw_u-cMn6zYydZnO4KZar6jqs=.a456dcea-7fa9-400d-956d-61f3670bbb81@github.com> On Mon, 7 Nov 2022 10:05:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: 7723bb34 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7723bb34e31ff94d4a398df0445ed45c19caf4b3 Stats: 121 lines in 1 file changed: 121 ins; 0 del; 0 mod 8286172: Create an automated test for JDK-4516019 Backport-of: e72742eeb5f265e854d098a560cb41c83e93f905 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/859 From goetz at openjdk.org Tue Nov 8 13:31:34 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 8 Nov 2022 13:31:34 GMT Subject: [jdk17u-dev] RFR: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 In-Reply-To: References: Message-ID: <_6jSTRI4zChC_Pzvw-jCBbgLxVL4CryUQ0wR2vAm7Sw=.aa5cc542-22c7-40ac-8770-c23a41b01059@github.com> On Tue, 8 Nov 2022 01:56:55 GMT, Scott Gibbons wrote: > This is a backport of JDK-8269404: Base64 Encoding optimization enhancements for x86 using AVX-512. Backport is clean. > > We have had numerous customer requests for this functionality to be backported due to the performance improvement. > > There will be three additional PRs for which this is a dependency. This PR is dependent on PR #860. > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott What is wrong with the pre-submit tests? In addition, I will run the five changes through our testing. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/861 From duke at openjdk.org Tue Nov 8 13:49:26 2022 From: duke at openjdk.org (zzambers) Date: Tue, 8 Nov 2022 13:49:26 GMT Subject: [jdk11u-dev] RFR: 8295714: GHA ::set-output is deprecated and will be removed Message-ID: This backport fixes warnings generated in GHA summary page by use of deprecated set-output command. According to warning messages command will be removed soon: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/` All tests passed (no warnings). ------------- Commit messages: - Avoid use of deprecated ::set-output in GHA Changes: https://git.openjdk.org/jdk11u-dev/pull/1494/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1494&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295714 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1494.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1494/head:pull/1494 PR: https://git.openjdk.org/jdk11u-dev/pull/1494 From duke at openjdk.org Tue Nov 8 16:04:58 2022 From: duke at openjdk.org (Jan Kratochvil) Date: Tue, 8 Nov 2022 16:04:58 GMT Subject: [jdk11u-dev] RFR: 8268361: Fix the infinite loop in next_line Message-ID: There was a backport of the JDK-18 fix to JDK-13, JDK-15 and JDK-17. **Issues** [JDK-8268361](https://bugs.openjdk.org/browse/JDK-8268361): Fix the infinite loop in next_line I am not yet an Author - I do not have JBS account. I have run the testsuite on linux64 and there is no change of the results. There is no new testcase for this fix and I did not do any extra testing of the fix. ------------- Commit messages: - 8268361: Fix the infinite loop in next_line Changes: https://git.openjdk.org/jdk11u-dev/pull/1508/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1508&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8268361 Stats: 15 lines in 1 file changed: 11 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1508.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1508/head:pull/1508 PR: https://git.openjdk.org/jdk11u-dev/pull/1508 From andrew at openjdk.org Tue Nov 8 16:56:38 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 8 Nov 2022 16:56:38 GMT Subject: [jdk17u-dev] RFR: 8293834: Update CLDR data following tzdata 2022c update In-Reply-To: References: Message-ID: On Wed, 28 Sep 2022 15:49:43 GMT, Andrew John Hughes wrote: > Moving this here from https://github.com/openjdk/jdk17u/pull/355 as I guess this missed review before freeze. Do we need more people actively monitoring 17u during the rampdown period? > > This patch updates the CLDR data following the tzdata bump in JDK-8292579. > > This will be handled in trunk by a larger update to CLDRv42. > > It differs from the 19u version in that we also bring in a change from the CLDR v41 update (JDK-8265315) to use "Kyiv" rather than "Kiev" as the zone description. This change is already in 19u. > > The test fails with 17.0.4 (using system tzdata 2022c) as follows: > > ~~~ > $ grep 'AssertionError' test.1663972846/jdk/JTwork/sun/util/resources/cldr/TimeZoneNamesTest.jtr > java.lang.AssertionError: expected [Eastern European Standard Time] but found [Kyiv Standard Time] > java.lang.AssertionError: expected [heure normale d\u2019Europe de l\u2019Est] but found [Kyiv (heure standard)] > java.lang.AssertionError: expected [Osteurop\u00e4ische Normalzeit] but found [Kyiv Normalzeit] > ~~~ > > and passes with the patched build. Ping? > Lgtm. Thanks Paul. Flagged for approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/752 From duke at openjdk.org Tue Nov 8 17:20:35 2022 From: duke at openjdk.org (Scott Gibbons) Date: Tue, 8 Nov 2022 17:20:35 GMT Subject: [jdk17u-dev] RFR: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 01:56:55 GMT, Scott Gibbons wrote: > This is a backport of JDK-8269404: Base64 Encoding optimization enhancements for x86 using AVX-512. Backport is clean. > > We have had numerous customer requests for this functionality to be backported due to the performance improvement. > > There will be three additional PRs for which this is a dependency. This PR is dependent on PR #860. > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott Thanks, Goetz. The failure is in TestStringDeduplicationTools and is caused by improper 64-byte alignment of data structures. This bug was found and fixed with the subsequent PR (#862). The bug will show up sporadically and depends on the stub code generation process. Please let me know how I should handle this. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/861 From duke at openjdk.org Tue Nov 8 17:31:38 2022 From: duke at openjdk.org (Jan Kratochvil) Date: Tue, 8 Nov 2022 17:31:38 GMT Subject: [jdk11u-dev] RFR: 8268361: Fix the infinite loop in next_line [v2] In-Reply-To: References: Message-ID: > There was a backport of the JDK-18 fix to JDK-13, JDK-15 and JDK-17. > > **Issues** > > - [JDK-8268361](https://bugs.openjdk.org/browse/JDK-8268361): Fix the infinite loop in next_line > > I am not yet an Author - I do not have JBS account. > > I have run the testsuite on linux64 and there is no change of the results. There is no new testcase for this fix and I did not do any extra testing of the fix. Jan Kratochvil has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8268361: Fix the infinite loop in next_line Backport-of: 72672277e4dddf8e72f1c705cd5f57de40745635 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1508/files - new: https://git.openjdk.org/jdk11u-dev/pull/1508/files/9ca71d41..11f4f6b0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1508&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1508&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1508.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1508/head:pull/1508 PR: https://git.openjdk.org/jdk11u-dev/pull/1508 From xliu at openjdk.org Tue Nov 8 17:53:27 2022 From: xliu at openjdk.org (Xin Liu) Date: Tue, 8 Nov 2022 17:53:27 GMT Subject: [jdk11u-dev] RFR: 8270947: AArch64: C1: use zero_words to initialize all objects In-Reply-To: <2r81GiVNq8fZUKZ2dyXrM7H5-GO7eezeJTybLrZB75U=.bb73e190-d2c2-45d9-9a1e-78382c453fe0@github.com> References: <2r81GiVNq8fZUKZ2dyXrM7H5-GO7eezeJTybLrZB75U=.bb73e190-d2c2-45d9-9a1e-78382c453fe0@github.com> Message-ID: On Mon, 7 Nov 2022 23:29:14 GMT, Paul Hohensee wrote: > There may be an existing JBS issue patch that fixes the problem. Yes, I think JDK-8235673 can fix this build issue, but it isn't trivial. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1502 From phh at openjdk.org Tue Nov 8 17:58:34 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 8 Nov 2022 17:58:34 GMT Subject: [jdk11u-dev] RFR: 8270947: AArch64: C1: use zero_words to initialize all objects In-Reply-To: References: Message-ID: <1GqBbw1z7Z4B-ayRJ6ejDLO1SG7AgONQuS7cjar7M2g=.5eebc9c6-4441-4226-9756-a5360d8e09be@github.com> On Fri, 4 Nov 2022 17:59:57 GMT, Xin Liu wrote: > We would like to backport [JDK-8270947](https://bugs.openjdk.org/browse/JDK-8270947) to jdk11u. It's not only less code to maintain, but also better generated code. C1 can leverage DC ZVA in large allocations on aarch64. The secondary consideration is that openjdk11u aligns with oraclejdk11u. > > This isn't a clean backport. Small cosmetic changes are made in `MacroAssembler::zero_words(Register ptr, Register cnt)` chunk. > > There are also 2 trailing bugfixes. We will post them together as stacked PRs I took a look at JDK-8235673 and agree. Better to do the minimum fix you propose in JDK-8296502. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1502 From vrudomet at openjdk.org Tue Nov 8 23:51:17 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 8 Nov 2022 23:51:17 GMT Subject: [jdk19u] RFR: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException Message-ID: Backport for [JDK-8296485](https://bugs.openjdk.org/browse/JDK-8296485) BuildEEBasicConstraints.java test fails with SunCertPathBuilderException Clean backport, test fix, low risk. Test fails before the fix passes after the fix. ------------- Commit messages: - Backport 520db1eeb18797c782ddfad90467e19bbdd424ac Changes: https://git.openjdk.org/jdk19u/pull/63/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=63&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296485 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/63.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/63/head:pull/63 PR: https://git.openjdk.org/jdk19u/pull/63 From vrudomet at openjdk.org Tue Nov 8 23:51:59 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 8 Nov 2022 23:51:59 GMT Subject: [jdk17u-dev] RFR: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException Message-ID: Backport for [JDK-8296485](https://bugs.openjdk.org/browse/JDK-8296485) BuildEEBasicConstraints.java test fails with SunCertPathBuilderException Clean backport, test fix, low risk. Test fails before the fix passes after the fix. ------------- Commit messages: - Backport 520db1eeb18797c782ddfad90467e19bbdd424ac Changes: https://git.openjdk.org/jdk17u-dev/pull/865/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=865&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296485 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/865.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/865/head:pull/865 PR: https://git.openjdk.org/jdk17u-dev/pull/865 From vrudomet at openjdk.org Tue Nov 8 23:53:05 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 8 Nov 2022 23:53:05 GMT Subject: [jdk11u-dev] RFR: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException Message-ID: Backport for [JDK-8296485](https://bugs.openjdk.org/browse/JDK-8296485) BuildEEBasicConstraints.java test fails with SunCertPathBuilderException Clean backport, test fix, low risk. Test fails before the fix passes after the fix. ------------- Commit messages: - Backport 520db1eeb18797c782ddfad90467e19bbdd424ac Changes: https://git.openjdk.org/jdk11u-dev/pull/1509/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1509&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296485 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1509.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1509/head:pull/1509 PR: https://git.openjdk.org/jdk11u-dev/pull/1509 From ysatowse at openjdk.org Wed Nov 9 01:29:47 2022 From: ysatowse at openjdk.org (Yoshiki Sato) Date: Wed, 9 Nov 2022 01:29:47 GMT Subject: [jdk19u] RFR: 8296108: (tz) Update Timezone Data to 2022f Message-ID: <5we2loijGNyMgxmAg95K49y2YGsdpZLIBXpG1HghdH8=.71629758-5f90-4625-9025-2b4233ea65eb@github.com> Please review this MR. The MR is a clean backprot of [JDK-8296108](https://bugs.openjdk.org/browse/JDK-8296108): (tz) Update Timezone Data to 2022f. ------------- Commit messages: - Backport 9d3b4ef2ad658afb5379796b7224458c12c81f5d Changes: https://git.openjdk.org/jdk19u/pull/64/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=64&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296108 Stats: 1362 lines in 25 files changed: 560 ins; 705 del; 97 mod Patch: https://git.openjdk.org/jdk19u/pull/64.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/64/head:pull/64 PR: https://git.openjdk.org/jdk19u/pull/64 From naoto at openjdk.org Wed Nov 9 02:59:42 2022 From: naoto at openjdk.org (Naoto Sato) Date: Wed, 9 Nov 2022 02:59:42 GMT Subject: [jdk19u] RFR: 8296108: (tz) Update Timezone Data to 2022f In-Reply-To: <5we2loijGNyMgxmAg95K49y2YGsdpZLIBXpG1HghdH8=.71629758-5f90-4625-9025-2b4233ea65eb@github.com> References: <5we2loijGNyMgxmAg95K49y2YGsdpZLIBXpG1HghdH8=.71629758-5f90-4625-9025-2b4233ea65eb@github.com> Message-ID: <0gL_lyl-bP6iCnxG6Po-WlfuwCNxkzej2gC5GBJ0eAo=.90313ffd-1874-4af2-b0df-3d9b7dff9d26@github.com> On Wed, 9 Nov 2022 01:22:23 GMT, Yoshiki Sato wrote: > Please review this MR. The MR is a clean backprot of [JDK-8296108](https://bugs.openjdk.org/browse/JDK-8296108): (tz) Update Timezone Data to 2022f. Marked as reviewed by naoto (Reviewer). ------------- PR: https://git.openjdk.org/jdk19u/pull/64 From duke at openjdk.org Wed Nov 9 08:37:43 2022 From: duke at openjdk.org (Jan Kratochvil) Date: Wed, 9 Nov 2022 08:37:43 GMT Subject: [jdk11u-dev] Integrated: 8268361: Fix the infinite loop in next_line In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 15:56:14 GMT, Jan Kratochvil wrote: > There was a backport of the JDK-18 fix to JDK-13, JDK-15 and JDK-17. > > **Issues** > > - [JDK-8268361](https://bugs.openjdk.org/browse/JDK-8268361): Fix the infinite loop in next_line > > I am not yet an Author - I do not have JBS account. > > I have run the testsuite on linux64 and there is no change of the results. There is no new testcase for this fix and I did not do any extra testing of the fix. This pull request has now been integrated. Changeset: 6664437b Author: Jan Kratochvil Committer: Yuri Nesterenko URL: https://git.openjdk.org/jdk11u-dev/commit/6664437b465b06735a04d26f7df9c7dc60bd2a1d Stats: 15 lines in 1 file changed: 11 ins; 0 del; 4 mod 8268361: Fix the infinite loop in next_line Backport-of: 72672277e4dddf8e72f1c705cd5f57de40745635 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1508 From duke at openjdk.org Wed Nov 9 10:23:20 2022 From: duke at openjdk.org (George Adams) Date: Wed, 9 Nov 2022 10:23:20 GMT Subject: [jdk11u-dev] RFR: 8296652: Restore windows aarch64 fixpath patch that was removed in 8239708 Message-ID: When https://bugs.openjdk.org/browse/JDK-8239708 was backported to 11u, the Windows aarch64 specific fixpath patch added in https://github.com/openjdk/jdk11u/commit/7bdb8ac7f9f9a83779427da7a6d7f5e9ae548db7#diff-cbf3a26a7e5854d626b3c7e11c8bcb3c287ed95113360aaf220108bfa018e066was missed out. This will need restoring ------------- Commit messages: - 8296652: Restore windows aarch64 fixpath patch that was removed in 8239708 Changes: https://git.openjdk.org/jdk11u-dev/pull/1510/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1510&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296652 Stats: 49 lines in 1 file changed: 31 ins; 18 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1510.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1510/head:pull/1510 PR: https://git.openjdk.org/jdk11u-dev/pull/1510 From duke at openjdk.org Wed Nov 9 10:31:31 2022 From: duke at openjdk.org (George Adams) Date: Wed, 9 Nov 2022 10:31:31 GMT Subject: [jdk11u-dev] RFR: 8296652: Restore windows aarch64 fixpath patch that was removed in 8239708 [v2] In-Reply-To: References: Message-ID: <-o53BJwPa1id814_2R9D7B_l6TSECLIzH5AkeYYA3hY=.35de927a-90f7-4188-90bd-710011455060@github.com> > When https://bugs.openjdk.org/browse/JDK-8239708 was backported to 11u, the Windows aarch64 specific fixpath patch added in https://github.com/openjdk/jdk11u/commit/7bdb8ac7f9f9a83779427da7a6d7f5e9ae548db7#diff-cbf3a26a7e5854d626b3c7e11c8bcb3c287ed95113360aaf220108bfa018e066was missed out. This will need restoring George Adams has updated the pull request incrementally with one additional commit since the last revision: Update basic_windows.m4 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1510/files - new: https://git.openjdk.org/jdk11u-dev/pull/1510/files/6bd46645..9c3036e6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1510&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1510&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1510.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1510/head:pull/1510 PR: https://git.openjdk.org/jdk11u-dev/pull/1510 From duke at openjdk.org Wed Nov 9 10:41:40 2022 From: duke at openjdk.org (George Adams) Date: Wed, 9 Nov 2022 10:41:40 GMT Subject: [jdk11u-dev] RFR: 8296652: Restore windows aarch64 fixpath patch that was removed in 8239708 [v3] In-Reply-To: References: Message-ID: > When https://bugs.openjdk.org/browse/JDK-8239708 was backported to 11u, the Windows aarch64 specific fixpath patch added in https://github.com/openjdk/jdk11u/commit/7bdb8ac7f9f9a83779427da7a6d7f5e9ae548db7#diff-cbf3a26a7e5854d626b3c7e11c8bcb3c287ed95113360aaf220108bfa018e066was missed out. This will need restoring George Adams has updated the pull request incrementally with two additional commits since the last revision: - Update basic_windows.m4 - Update basic_windows.m4 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1510/files - new: https://git.openjdk.org/jdk11u-dev/pull/1510/files/9c3036e6..292448fb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1510&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1510&range=01-02 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1510.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1510/head:pull/1510 PR: https://git.openjdk.org/jdk11u-dev/pull/1510 From duke at openjdk.org Wed Nov 9 11:24:45 2022 From: duke at openjdk.org (George Adams) Date: Wed, 9 Nov 2022 11:24:45 GMT Subject: [jdk11u-dev] RFR: 8296652: Restore windows aarch64 fixpath patch that was removed in 8239708 [v4] In-Reply-To: References: Message-ID: > When https://bugs.openjdk.org/browse/JDK-8239708 was backported to 11u, the Windows aarch64 specific fixpath patch added in https://github.com/openjdk/jdk11u/commit/7bdb8ac7f9f9a83779427da7a6d7f5e9ae548db7#diff-cbf3a26a7e5854d626b3c7e11c8bcb3c287ed95113360aaf220108bfa018e066was missed out. This will need restoring George Adams has updated the pull request incrementally with one additional commit since the last revision: Update basic_windows.m4 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1510/files - new: https://git.openjdk.org/jdk11u-dev/pull/1510/files/292448fb..b488e7d6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1510&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1510&range=02-03 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1510.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1510/head:pull/1510 PR: https://git.openjdk.org/jdk11u-dev/pull/1510 From clanger at openjdk.org Wed Nov 9 13:14:40 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 9 Nov 2022 13:14:40 GMT Subject: [jdk17u-dev] Integrated: 8288132: Update test artifacts in QuoVadis CA interop tests In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 19:22:30 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8288132](https://bugs.openjdk.org/browse/JDK-8288132), commit [3ee1e605](https://github.com/openjdk/jdk/commit/3ee1e60595171be0dd8bda47d96e0a1268cdc461) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Rajan Halade on 10 Jun 2022 and was reviewed by Sean Mullan. > > Thanks! This pull request has now been integrated. Changeset: 703a82a3 Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/703a82a34381c04792ad5f5c6c677827c787fc1b Stats: 191 lines in 1 file changed: 21 ins; 0 del; 170 mod 8288132: Update test artifacts in QuoVadis CA interop tests Backport-of: 3ee1e60595171be0dd8bda47d96e0a1268cdc461 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/856 From clanger at openjdk.org Wed Nov 9 13:16:08 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 9 Nov 2022 13:16:08 GMT Subject: [jdk19u] Integrated: 8288132: Update test artifacts in QuoVadis CA interop tests In-Reply-To: <3Gnlb3K6le95QASuyVhzaWK8aXFLb6HUhlxNx10BfNk=.fd915522-a31a-4889-9e51-2c3a03a2c11b@github.com> References: <3Gnlb3K6le95QASuyVhzaWK8aXFLb6HUhlxNx10BfNk=.fd915522-a31a-4889-9e51-2c3a03a2c11b@github.com> Message-ID: On Thu, 3 Nov 2022 19:06:28 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of https://bugs.openjdk.org/browse/JDK-8288132, commit [3ee1e605](https://github.com/openjdk/jdk/commit/3ee1e60595171be0dd8bda47d96e0a1268cdc461) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Rajan Halade on 10 Jun 2022 and was reviewed by Sean Mullan. > > Thanks! This pull request has now been integrated. Changeset: b90a7bc7 Author: Christoph Langer URL: https://git.openjdk.org/jdk19u/commit/b90a7bc7c6558a0858c9661a6ec16955faa08940 Stats: 191 lines in 1 file changed: 21 ins; 0 del; 170 mod 8288132: Update test artifacts in QuoVadis CA interop tests Backport-of: 3ee1e60595171be0dd8bda47d96e0a1268cdc461 ------------- PR: https://git.openjdk.org/jdk19u/pull/61 From clanger at openjdk.org Wed Nov 9 13:16:38 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 9 Nov 2022 13:16:38 GMT Subject: [jdk11u-dev] Integrated: 8288132: Update test artifacts in QuoVadis CA interop tests In-Reply-To: References: Message-ID: On Thu, 3 Nov 2022 20:06:48 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8288132](https://bugs.openjdk.org/browse/JDK-8288132), commit [3ee1e605](https://github.com/openjdk/jdk/commit/3ee1e60595171be0dd8bda47d96e0a1268cdc461) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Rajan Halade on 10 Jun 2022 and was reviewed by Sean Mullan. > > Thanks! This pull request has now been integrated. Changeset: dde20e47 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/dde20e471dd77528baa922dde484e9ea92c005aa Stats: 191 lines in 1 file changed: 21 ins; 0 del; 170 mod 8288132: Update test artifacts in QuoVadis CA interop tests Backport-of: 3ee1e60595171be0dd8bda47d96e0a1268cdc461 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1498 From vrudomet at openjdk.org Wed Nov 9 17:40:50 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Wed, 9 Nov 2022 17:40:50 GMT Subject: [jdk19u] RFR: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException In-Reply-To: References: Message-ID: <8plV5RoA-C0kQedv-ow2xcgGBSZAs7ym-VfO09wdHPc=.30b563c8-780b-432f-9616-6ceb66f851a1@github.com> On Tue, 8 Nov 2022 23:43:42 GMT, Victor Rudometov wrote: > Backport for [JDK-8296485](https://bugs.openjdk.org/browse/JDK-8296485) BuildEEBasicConstraints.java test fails with SunCertPathBuilderException > > Clean backport, test fix, low risk. > Test fails before the fix passes after the fix. macos-x64/test failed on step Get The BootJDK Prepare all required actions Getting action download info Error: Internal Server Error occurred while resolving "actions/cache at v3" Will try to restart ------------- PR: https://git.openjdk.org/jdk19u/pull/63 From vrudomet at openjdk.org Wed Nov 9 17:44:14 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Wed, 9 Nov 2022 17:44:14 GMT Subject: [jdk11u-dev] Integrated: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException In-Reply-To: References: Message-ID: <5cILxlMIqjXjpHfQtievv1c1Wb2ORQZ8_ZZR9qbT8h0=.b3e8985f-ea3e-4d83-a94c-004b5ea6e7fd@github.com> On Tue, 8 Nov 2022 23:43:40 GMT, Victor Rudometov wrote: > Backport for [JDK-8296485](https://bugs.openjdk.org/browse/JDK-8296485) BuildEEBasicConstraints.java test fails with SunCertPathBuilderException > > Clean backport, test fix, low risk. > Test fails before the fix passes after the fix. This pull request has now been integrated. Changeset: ca885ee2 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/ca885ee2a73b677646ac79f19e3fd72c632e39fd Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException Backport-of: 520db1eeb18797c782ddfad90467e19bbdd424ac ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1509 From vrudomet at openjdk.org Wed Nov 9 17:44:49 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Wed, 9 Nov 2022 17:44:49 GMT Subject: [jdk17u-dev] Integrated: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 23:43:37 GMT, Victor Rudometov wrote: > Backport for [JDK-8296485](https://bugs.openjdk.org/browse/JDK-8296485) BuildEEBasicConstraints.java test fails with SunCertPathBuilderException > > Clean backport, test fix, low risk. > Test fails before the fix passes after the fix. This pull request has now been integrated. Changeset: 7d183e0c Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/7d183e0c84c5a1a14917fa92764acafd47905cc0 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException Backport-of: 520db1eeb18797c782ddfad90467e19bbdd424ac ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/865 From vrudomet at openjdk.org Wed Nov 9 18:08:08 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Wed, 9 Nov 2022 18:08:08 GMT Subject: [jdk19u] Integrated: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 23:43:42 GMT, Victor Rudometov wrote: > Backport for [JDK-8296485](https://bugs.openjdk.org/browse/JDK-8296485) BuildEEBasicConstraints.java test fails with SunCertPathBuilderException > > Clean backport, test fix, low risk. > Test fails before the fix passes after the fix. This pull request has now been integrated. Changeset: 2e830ac0 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk19u/commit/2e830ac00dd04b7ea641b020016b3118aa99724d Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException Backport-of: 520db1eeb18797c782ddfad90467e19bbdd424ac ------------- PR: https://git.openjdk.org/jdk19u/pull/63 From goetz at openjdk.org Wed Nov 9 18:53:16 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Nov 2022 18:53:16 GMT Subject: [jdk17u-dev] RFR: 8255439: System Tray icons get corrupted when Windows scaling changes Message-ID: I backport this for parity with 17.0.5-oracle. ------------- Commit messages: - Backport 8323787c07ced4fa8ce852995df4c0e2de4d7ccc Changes: https://git.openjdk.org/jdk17u-dev/pull/866/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=866&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8255439 Stats: 166 lines in 3 files changed: 164 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/866.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/866/head:pull/866 PR: https://git.openjdk.org/jdk17u-dev/pull/866 From duke at openjdk.org Wed Nov 9 19:53:02 2022 From: duke at openjdk.org (zzambers) Date: Wed, 9 Nov 2022 19:53:02 GMT Subject: [jdk17u-dev] Integrated: 8295714: GHA ::set-output is deprecated and will be removed In-Reply-To: References: Message-ID: On Tue, 1 Nov 2022 22:43:37 GMT, zzambers wrote: > This backport fixes warnings generated in GHA summary page by use of deprecated `set-output` command. According to warning messages command will be removed soon: > > The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/` > > Clean backport, all tests passed (no warnings). This pull request has now been integrated. Changeset: 3df72a35 Author: Magnus Ihse Bursie Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/3df72a359e402b929b210f88ed85a86f9f10231f Stats: 28 lines in 11 files changed: 1 ins; 0 del; 27 mod 8295714: GHA ::set-output is deprecated and will be removed Backport-of: b35922be6de7b848a2982d6a278dbd205fc39e6a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/852 From phh at openjdk.org Wed Nov 9 19:55:38 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 9 Nov 2022 19:55:38 GMT Subject: [jdk11u-dev] RFR: 8295714: GHA ::set-output is deprecated and will be removed In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 15:42:00 GMT, zzambers wrote: > This backport fixes warnings generated in GHA summary page by use of deprecated set-output command. According to warning messages command will be removed soon: > > The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/` > > All tests passed (no warnings). Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1494 From duke at openjdk.org Wed Nov 9 20:01:36 2022 From: duke at openjdk.org (zzambers) Date: Wed, 9 Nov 2022 20:01:36 GMT Subject: [jdk11u-dev] RFR: 8295714: GHA ::set-output is deprecated and will be removed In-Reply-To: References: Message-ID: On Wed, 9 Nov 2022 19:53:26 GMT, Paul Hohensee wrote: >> This backport fixes warnings generated in GHA summary page by use of deprecated set-output command. According to warning messages command will be removed soon: >> >> The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/` >> >> All tests passed (no warnings). > > Lgtm. @phohensee Thanks ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1494 From duke at openjdk.org Wed Nov 9 21:35:45 2022 From: duke at openjdk.org (Scott Gibbons) Date: Wed, 9 Nov 2022 21:35:45 GMT Subject: [jdk17u-dev] Integrated: 8268276: Base64 Decoding optimization for x86 using AVX-512 In-Reply-To: <0y7sAHmlGQjKuPhNiZQE-e7ZYBo9NV5sU-ZJ93owKY4=.90744926-3cc4-41e6-9d3c-0436a2e1027b@github.com> References: <0y7sAHmlGQjKuPhNiZQE-e7ZYBo9NV5sU-ZJ93owKY4=.90744926-3cc4-41e6-9d3c-0436a2e1027b@github.com> Message-ID: On Tue, 8 Nov 2022 01:18:18 GMT, Scott Gibbons wrote: > This is a backport of JDK-8268276: Base64 Decoding optimization for x86 using AVX-512. Backport is clean. > > We have had numerous customer requests for this functionality to be backported due to the ~19x performance improvement. > > There will be four additional PRs for which this is a dependency: #861 #862 #863 #864 > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott This pull request has now been integrated. Changeset: 07050b00 Author: Scott Gibbons Committer: Derek White URL: https://git.openjdk.org/jdk17u-dev/commit/07050b000ce20350c55505fbc5595c0b6c3052b5 Stats: 753 lines in 12 files changed: 735 ins; 4 del; 14 mod 8268276: Base64 Decoding optimization for x86 using AVX-512 Co-authored-by: Derek White Co-authored-by: Sandhya Viswanathan Backport-of: c37988d0793b24d98d285530dfda69999a227937 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/860 From duke at openjdk.org Wed Nov 9 21:39:52 2022 From: duke at openjdk.org (Scott Gibbons) Date: Wed, 9 Nov 2022 21:39:52 GMT Subject: [jdk17u-dev] RFR: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 [v2] In-Reply-To: References: Message-ID: > This is a backport of JDK-8269404: Base64 Encoding optimization enhancements for x86 using AVX-512. Backport is clean. > > We have had numerous customer requests for this functionality to be backported due to the performance improvement. > > There will be three additional PRs for which this is a dependency. This PR is dependent on PR #860. > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott Scott Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/861/files - new: https://git.openjdk.org/jdk17u-dev/pull/861/files/e8ff3f11..e8ff3f11 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=861&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=861&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/861.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/861/head:pull/861 PR: https://git.openjdk.org/jdk17u-dev/pull/861 From duke at openjdk.org Wed Nov 9 23:51:33 2022 From: duke at openjdk.org (Scott Gibbons) Date: Wed, 9 Nov 2022 23:51:33 GMT Subject: [jdk17u-dev] RFR: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 [v3] In-Reply-To: References: Message-ID: <3N-sDTttc6BQIsvWAX_SSMkxiW-90Aa3uj9OreC2uUU=.d9b763c2-7500-430e-9489-85892c7cdf23@github.com> > This is a backport of JDK-8269404: Base64 Encoding optimization enhancements for x86 using AVX-512. Backport is clean. > > We have had numerous customer requests for this functionality to be backported due to the performance improvement. > > There will be three additional PRs for which this is a dependency. This PR is dependent on PR #860. > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott Scott Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into Encode-backport - Backport 9cac94d581f240c10fe8fff2f803109a1ae30637 - Backport c37988d0793b24d98d285530dfda69999a227937 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/861/files - new: https://git.openjdk.org/jdk17u-dev/pull/861/files/e8ff3f11..e661488a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=861&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=861&range=01-02 Stats: 1119 lines in 20 files changed: 887 ins; 2 del; 230 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/861.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/861/head:pull/861 PR: https://git.openjdk.org/jdk17u-dev/pull/861 From duke at openjdk.org Thu Nov 10 00:03:46 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 00:03:46 GMT Subject: [jdk17u-dev] RFR: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 In-Reply-To: <_6jSTRI4zChC_Pzvw-jCBbgLxVL4CryUQ0wR2vAm7Sw=.aa5cc542-22c7-40ac-8770-c23a41b01059@github.com> References: <_6jSTRI4zChC_Pzvw-jCBbgLxVL4CryUQ0wR2vAm7Sw=.aa5cc542-22c7-40ac-8770-c23a41b01059@github.com> Message-ID: On Tue, 8 Nov 2022 13:29:20 GMT, Goetz Lindenmaier wrote: >> This is a backport of JDK-8269404: Base64 Encoding optimization enhancements for x86 using AVX-512. Backport is clean. >> >> We have had numerous customer requests for this functionality to be backported due to the performance improvement. >> >> There will be three additional PRs for which this is a dependency. This PR is dependent on PR #860. >> >> Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. >> >> Testing: x86_64 build, affected tests, tier1 >> >> Thanks, >> --Scott > > What is wrong with the pre-submit tests? > In addition, I will run the five changes through our testing. @GoeLin This seems not to be the way in which I would see dependent PRs handled. It appears that the bot added the dependent PRs commit to this commit, which should not happen. If the previous commit was merged into master, and this commit was retargeted to master, the previous PR should not be re-applied. It is already in master and should not appear here. I may not fully understand the dependent PR process, so clarification would be appreciated. I'm referencing an email from Erik Helin and Robin ?? entitled "New Skara feature: dependent pull requests" dated Mar 23, 2021. As can be seen from this PR's history, the patch was clean before the previous PR was integrated. Then once the previous was integrated, this PR shows conflicts. I did this manually (checkout openjdk/jdk17u-dev:master, then backported the patch) which worked as advertised. Please help. Thanks. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/861 From sviswanathan at openjdk.org Thu Nov 10 01:27:23 2022 From: sviswanathan at openjdk.org (Sandhya Viswanathan) Date: Thu, 10 Nov 2022 01:27:23 GMT Subject: [jdk17u-dev] RFR: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 Message-ID: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 ------------- Commit messages: - Backport 9cac94d581f240c10fe8fff2f803109a1ae30637 Changes: https://git.openjdk.org/jdk17u-dev/pull/867/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=867&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8269404 Stats: 710 lines in 5 files changed: 349 ins; 235 del; 126 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/867.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/867/head:pull/867 PR: https://git.openjdk.org/jdk17u-dev/pull/867 From duke at openjdk.org Thu Nov 10 01:27:23 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 01:27:23 GMT Subject: [jdk17u-dev] RFR: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 In-Reply-To: References: Message-ID: On Thu, 10 Nov 2022 01:14:06 GMT, Sandhya Viswanathan wrote: > 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 Created a clean PR due to issues with #861 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/867 From duke at openjdk.org Thu Nov 10 01:36:19 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 01:36:19 GMT Subject: [jdk17u-dev] RFR: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 [v3] In-Reply-To: <3N-sDTttc6BQIsvWAX_SSMkxiW-90Aa3uj9OreC2uUU=.d9b763c2-7500-430e-9489-85892c7cdf23@github.com> References: <3N-sDTttc6BQIsvWAX_SSMkxiW-90Aa3uj9OreC2uUU=.d9b763c2-7500-430e-9489-85892c7cdf23@github.com> Message-ID: On Wed, 9 Nov 2022 23:51:33 GMT, Scott Gibbons wrote: >> This is a backport of JDK-8269404: Base64 Encoding optimization enhancements for x86 using AVX-512. Backport is clean. >> >> We have had numerous customer requests for this functionality to be backported due to the performance improvement. >> >> There will be three additional PRs for which this is a dependency. This PR is dependent on PR #860. >> >> Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. >> >> Testing: x86_64 build, affected tests, tier1 >> >> Thanks, >> --Scott > > Scott Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into Encode-backport > - Backport 9cac94d581f240c10fe8fff2f803109a1ae30637 > - Backport c37988d0793b24d98d285530dfda69999a227937 Created a clean PR #867 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/861 From sviswanathan at openjdk.org Thu Nov 10 01:36:23 2022 From: sviswanathan at openjdk.org (Sandhya Viswanathan) Date: Thu, 10 Nov 2022 01:36:23 GMT Subject: [jdk17u-dev] Integrated: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 In-Reply-To: References: Message-ID: On Thu, 10 Nov 2022 01:14:06 GMT, Sandhya Viswanathan wrote: > 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 This pull request has now been integrated. Changeset: 7884eabf Author: Sandhya Viswanathan Committer: Derek White URL: https://git.openjdk.org/jdk17u-dev/commit/7884eabfc9ae2829248a24d8370961a74b564c39 Stats: 710 lines in 5 files changed: 349 ins; 235 del; 126 mod 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 Backport-of: 9cac94d581f240c10fe8fff2f803109a1ae30637 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/867 From duke at openjdk.org Thu Nov 10 01:36:37 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 01:36:37 GMT Subject: [jdk17u-dev] RFR: 8273459: Update code segment alignment to 64 bytes In-Reply-To: <7MimxIbRHGnEwnGXTtJzk9XZ05vN_XZuT28XGzJZhr0=.c79a9799-6df6-469d-aee9-ba438198f14b@github.com> References: <7MimxIbRHGnEwnGXTtJzk9XZ05vN_XZuT28XGzJZhr0=.c79a9799-6df6-469d-aee9-ba438198f14b@github.com> Message-ID: On Tue, 8 Nov 2022 02:45:33 GMT, Scott Gibbons wrote: > One of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. The next one will be for align32(), then followed by the buffer overrun bugfix required for Base64 decoding to work properly. > > Depends on PR #860 and #861 . > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott Created a clean PR #868 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/862 From sviswanathan at openjdk.org Thu Nov 10 01:44:07 2022 From: sviswanathan at openjdk.org (Sandhya Viswanathan) Date: Thu, 10 Nov 2022 01:44:07 GMT Subject: [jdk17u-dev] RFR: 8273459: Update code segment alignment to 64 bytes Message-ID: <-1ZOvoTPWvfKBk0K4T-qQHodLyKguMFk1aGBg7GDfmM=.ac862170-6ea3-44e0-975a-864e44e91252@github.com> 8273459: Update code segment alignment to 64 bytes ------------- Commit messages: - Backport 53b25bce878bc291f3a217da7c26fd3097f18cfd Changes: https://git.openjdk.org/jdk17u-dev/pull/868/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=868&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273459 Stats: 27 lines in 4 files changed: 10 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/868.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/868/head:pull/868 PR: https://git.openjdk.org/jdk17u-dev/pull/868 From duke at openjdk.org Thu Nov 10 01:44:08 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 01:44:08 GMT Subject: [jdk17u-dev] RFR: 8273459: Update code segment alignment to 64 bytes In-Reply-To: <-1ZOvoTPWvfKBk0K4T-qQHodLyKguMFk1aGBg7GDfmM=.ac862170-6ea3-44e0-975a-864e44e91252@github.com> References: <-1ZOvoTPWvfKBk0K4T-qQHodLyKguMFk1aGBg7GDfmM=.ac862170-6ea3-44e0-975a-864e44e91252@github.com> Message-ID: On Thu, 10 Nov 2022 01:33:57 GMT, Sandhya Viswanathan wrote: > 8273459: Update code segment alignment to 64 bytes Clean PR for #862 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/868 From sviswanathan at openjdk.org Thu Nov 10 01:45:47 2022 From: sviswanathan at openjdk.org (Sandhya Viswanathan) Date: Thu, 10 Nov 2022 01:45:47 GMT Subject: [jdk17u-dev] Integrated: 8273459: Update code segment alignment to 64 bytes In-Reply-To: <-1ZOvoTPWvfKBk0K4T-qQHodLyKguMFk1aGBg7GDfmM=.ac862170-6ea3-44e0-975a-864e44e91252@github.com> References: <-1ZOvoTPWvfKBk0K4T-qQHodLyKguMFk1aGBg7GDfmM=.ac862170-6ea3-44e0-975a-864e44e91252@github.com> Message-ID: On Thu, 10 Nov 2022 01:33:57 GMT, Sandhya Viswanathan wrote: > 8273459: Update code segment alignment to 64 bytes This pull request has now been integrated. Changeset: ccbf2a9b Author: Sandhya Viswanathan Committer: Derek White URL: https://git.openjdk.org/jdk17u-dev/commit/ccbf2a9bb330e92e8d6e072f00ce55e3ec768d53 Stats: 27 lines in 4 files changed: 10 ins; 0 del; 17 mod 8273459: Update code segment alignment to 64 bytes Backport-of: 53b25bce878bc291f3a217da7c26fd3097f18cfd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/868 From duke at openjdk.org Thu Nov 10 01:51:54 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 01:51:54 GMT Subject: [jdk17u-dev] RFR: 8274527: Minimal VM build fails after JDK-8273459 In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 02:58:15 GMT, Scott Gibbons wrote: > Second of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. The next one will be for the buffer overrun bugfix required for Base64 decoding to work properly. > > Depends on PR 860, 861, and 862. > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott Opened a clean PR #869 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/863 From sviswanathan at openjdk.org Thu Nov 10 01:56:09 2022 From: sviswanathan at openjdk.org (Sandhya Viswanathan) Date: Thu, 10 Nov 2022 01:56:09 GMT Subject: [jdk17u-dev] RFR: 8274527: Minimal VM build fails after JDK-8273459 Message-ID: 8274527: Minimal VM build fails after JDK-8273459 ------------- Commit messages: - Backport a8edd1b360d4e5f35aff371a91fda42eeb00d395 Changes: https://git.openjdk.org/jdk17u-dev/pull/869/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=869&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274527 Stats: 22 lines in 4 files changed: 5 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/869.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/869/head:pull/869 PR: https://git.openjdk.org/jdk17u-dev/pull/869 From duke at openjdk.org Thu Nov 10 01:56:09 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 01:56:09 GMT Subject: [jdk17u-dev] RFR: 8274527: Minimal VM build fails after JDK-8273459 In-Reply-To: References: Message-ID: On Thu, 10 Nov 2022 01:47:43 GMT, Sandhya Viswanathan wrote: > 8274527: Minimal VM build fails after JDK-8273459 Clean PR for PR #863 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/869 From sviswanathan at openjdk.org Thu Nov 10 01:57:49 2022 From: sviswanathan at openjdk.org (Sandhya Viswanathan) Date: Thu, 10 Nov 2022 01:57:49 GMT Subject: [jdk17u-dev] Integrated: 8274527: Minimal VM build fails after JDK-8273459 In-Reply-To: References: Message-ID: On Thu, 10 Nov 2022 01:47:43 GMT, Sandhya Viswanathan wrote: > 8274527: Minimal VM build fails after JDK-8273459 This pull request has now been integrated. Changeset: 193ccc4e Author: Sandhya Viswanathan Committer: Derek White URL: https://git.openjdk.org/jdk17u-dev/commit/193ccc4e0ea5fe9bb8942d66e1a1469b159249de Stats: 22 lines in 4 files changed: 5 ins; 0 del; 17 mod 8274527: Minimal VM build fails after JDK-8273459 Backport-of: a8edd1b360d4e5f35aff371a91fda42eeb00d395 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/869 From duke at openjdk.org Thu Nov 10 02:07:36 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 02:07:36 GMT Subject: [jdk17u-dev] RFR: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276 In-Reply-To: References: Message-ID: <1vYeX5LNON5BEepKnvpUjyZU5n1KH8MYncQfFomg5Xc=.931428a3-0158-4bc9-9955-0c4ab6aa1186@github.com> On Tue, 8 Nov 2022 03:35:43 GMT, Scott Gibbons wrote: > Last of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. > > Depends on PR #860, #861, #862, and #863 . > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott Created a clean PR #870 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/864 From duke at openjdk.org Thu Nov 10 02:12:04 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 02:12:04 GMT Subject: [jdk17u-dev] RFR: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276 Message-ID: Clean PR for #864 ------------- Commit messages: - Backport 9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e Changes: https://git.openjdk.org/jdk17u-dev/pull/870/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=870&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273108 Stats: 12 lines in 2 files changed: 7 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/870.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/870/head:pull/870 PR: https://git.openjdk.org/jdk17u-dev/pull/870 From duke at openjdk.org Thu Nov 10 02:13:52 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 02:13:52 GMT Subject: [jdk17u-dev] RFR: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 [v3] In-Reply-To: <3N-sDTttc6BQIsvWAX_SSMkxiW-90Aa3uj9OreC2uUU=.d9b763c2-7500-430e-9489-85892c7cdf23@github.com> References: <3N-sDTttc6BQIsvWAX_SSMkxiW-90Aa3uj9OreC2uUU=.d9b763c2-7500-430e-9489-85892c7cdf23@github.com> Message-ID: On Wed, 9 Nov 2022 23:51:33 GMT, Scott Gibbons wrote: >> This is a backport of JDK-8269404: Base64 Encoding optimization enhancements for x86 using AVX-512. Backport is clean. >> >> We have had numerous customer requests for this functionality to be backported due to the performance improvement. >> >> There will be three additional PRs for which this is a dependency. This PR is dependent on PR #860. >> >> Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. >> >> Testing: x86_64 build, affected tests, tier1 >> >> Thanks, >> --Scott > > Scott Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into Encode-backport > - Backport 9cac94d581f240c10fe8fff2f803109a1ae30637 > - Backport c37988d0793b24d98d285530dfda69999a227937 Closing this because of dependent PR issues. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/861 From duke at openjdk.org Thu Nov 10 02:13:52 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 02:13:52 GMT Subject: [jdk17u-dev] Withdrawn: 8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 01:56:55 GMT, Scott Gibbons wrote: > This is a backport of JDK-8269404: Base64 Encoding optimization enhancements for x86 using AVX-512. Backport is clean. > > We have had numerous customer requests for this functionality to be backported due to the performance improvement. > > There will be three additional PRs for which this is a dependency. This PR is dependent on PR #860. > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/861 From duke at openjdk.org Thu Nov 10 02:14:50 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 02:14:50 GMT Subject: [jdk17u-dev] RFR: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276 In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 03:35:43 GMT, Scott Gibbons wrote: > Last of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. > > Depends on PR #860, #861, #862, and #863 . > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott Closing this because of dependent PR issues. See #861 for details. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/864 From duke at openjdk.org Thu Nov 10 02:14:50 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 02:14:50 GMT Subject: [jdk17u-dev] Withdrawn: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276 In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 03:35:43 GMT, Scott Gibbons wrote: > Last of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. > > Depends on PR #860, #861, #862, and #863 . > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/864 From duke at openjdk.org Thu Nov 10 02:14:53 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 02:14:53 GMT Subject: [jdk17u-dev] RFR: 8274527: Minimal VM build fails after JDK-8273459 In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 02:58:15 GMT, Scott Gibbons wrote: > Second of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. The next one will be for the buffer overrun bugfix required for Base64 decoding to work properly. > > Depends on PR 860, 861, and 862. > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott Closing this because of dependent PR issues. See #861 for details. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/863 From duke at openjdk.org Thu Nov 10 02:14:53 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 02:14:53 GMT Subject: [jdk17u-dev] Withdrawn: 8274527: Minimal VM build fails after JDK-8273459 In-Reply-To: References: Message-ID: <64k96bYhMmLYmH7D5eGWhcA3mPXVuT0hw5Z0DRINAYo=.9c82bc71-2311-4dd9-b9bb-f33c09e1d768@github.com> On Tue, 8 Nov 2022 02:58:15 GMT, Scott Gibbons wrote: > Second of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. The next one will be for the buffer overrun bugfix required for Base64 decoding to work properly. > > Depends on PR 860, 861, and 862. > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/863 From duke at openjdk.org Thu Nov 10 02:15:52 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 02:15:52 GMT Subject: [jdk17u-dev] RFR: 8273459: Update code segment alignment to 64 bytes In-Reply-To: <7MimxIbRHGnEwnGXTtJzk9XZ05vN_XZuT28XGzJZhr0=.c79a9799-6df6-469d-aee9-ba438198f14b@github.com> References: <7MimxIbRHGnEwnGXTtJzk9XZ05vN_XZuT28XGzJZhr0=.c79a9799-6df6-469d-aee9-ba438198f14b@github.com> Message-ID: On Tue, 8 Nov 2022 02:45:33 GMT, Scott Gibbons wrote: > One of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. The next one will be for align32(), then followed by the buffer overrun bugfix required for Base64 decoding to work properly. > > Depends on PR #860 and #861 . > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott Closing this because of dependent PR issues. See #861 for details. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/862 From duke at openjdk.org Thu Nov 10 02:15:52 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 02:15:52 GMT Subject: [jdk17u-dev] Withdrawn: 8273459: Update code segment alignment to 64 bytes In-Reply-To: <7MimxIbRHGnEwnGXTtJzk9XZ05vN_XZuT28XGzJZhr0=.c79a9799-6df6-469d-aee9-ba438198f14b@github.com> References: <7MimxIbRHGnEwnGXTtJzk9XZ05vN_XZuT28XGzJZhr0=.c79a9799-6df6-469d-aee9-ba438198f14b@github.com> Message-ID: <1n_aMk9VIIufazA1ljt8yKiCkIzai8NdXomGbmL6EXs=.f8b52bf1-d761-4e53-b0e4-eacaeccd7708@github.com> On Tue, 8 Nov 2022 02:45:33 GMT, Scott Gibbons wrote: > One of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. The next one will be for align32(), then followed by the buffer overrun bugfix required for Base64 decoding to work properly. > > Depends on PR #860 and #861 . > > Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported. > > Testing: x86_64 build, affected tests, tier1 > > Thanks, > --Scott This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/862 From duke at openjdk.org Thu Nov 10 02:15:53 2022 From: duke at openjdk.org (Scott Gibbons) Date: Thu, 10 Nov 2022 02:15:53 GMT Subject: [jdk17u-dev] Integrated: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276 In-Reply-To: References: Message-ID: <3PWXkULeHlJJiAAbDkZUoSnxKgLs771OQm9C-X6C4Ho=.7d1de60d-8ca9-4b08-884b-d5f2d431db4a@github.com> On Thu, 10 Nov 2022 02:03:18 GMT, Scott Gibbons wrote: > Clean PR for #864 This pull request has now been integrated. Changeset: b7a0a0ab Author: Scott Gibbons Committer: Derek White URL: https://git.openjdk.org/jdk17u-dev/commit/b7a0a0abde2c923e8dc275065b45d8cad93afcbb Stats: 12 lines in 2 files changed: 7 ins; 0 del; 5 mod 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276 8272809: JFR thread sampler SI_KERNEL SEGV in metaspace::VirtualSpaceList::contains Backport-of: 9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/870 From duke at openjdk.org Thu Nov 10 09:00:18 2022 From: duke at openjdk.org (Johannes Bechberger) Date: Thu, 10 Nov 2022 09:00:18 GMT Subject: [jdk11u-dev] Integrated: 8282306: os::is_first_C_frame(frame*) crashes on invalid link access In-Reply-To: References: Message-ID: <3tfU2mlIAoCy-OT0oLKMAnP3rZ8-wOelIfoCvguaz20=.b3504071-68c7-4732-b336-108b9d413bbf@github.com> On Tue, 27 Sep 2022 12:39:27 GMT, Johannes Bechberger wrote: > Hardening os::is_first_C_frame(frame*) against accesses on invalid links. > > Applies relatively clean (only a comment changed which hindered it from applying directly). > > Tested via nightly SAP builds and on my own linux machine. This pull request has now been integrated. Changeset: 7c664bcd Author: Johannes Bechberger Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/7c664bcd82cf2a13c9fdcd803345c6095e4d3873 Stats: 79 lines in 11 files changed: 60 ins; 13 del; 6 mod 8282306: os::is_first_C_frame(frame*) crashes on invalid link access Reviewed-by: mdoerr Backport-of: 999da9bfc5be703141cdc07af455b4b6b2cc1aae ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1373 From goetz at openjdk.org Thu Nov 10 12:01:52 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Nov 2022 12:01:52 GMT Subject: [jdk17u-dev] RFR: 8255439: System Tray icons get corrupted when Windows scaling changes In-Reply-To: References: Message-ID: <-po3bxP6RzFDxMcxgLl3-dCnKV7fpnRiUzzHpRwvreI=.50c53a48-b5bb-4a94-bd9d-e5138276247a@github.com> On Wed, 9 Nov 2022 18:24:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. Pre-submit failure: unrealted. TestStringDeduplicationAgeThreshold.java#id1 known to be failing. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/866 From goetz at openjdk.org Thu Nov 10 12:11:15 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Nov 2022 12:11:15 GMT Subject: [jdk11u-dev] RFR: 8255439: System Tray icons get corrupted when Windows scaling changes Message-ID: <_zpFb3Sa8zd7PlQNlIfGmELP9fdwsMXrnAd23HUqAKc=.da58f74b-bc1c-47da-a331-f671fcf74c0f@github.com> I backport this for parity with 11.0.17-oracle. ------------- Commit messages: - Backport 8323787c07ced4fa8ce852995df4c0e2de4d7ccc Changes: https://git.openjdk.org/jdk11u-dev/pull/1511/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1511&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8255439 Stats: 166 lines in 3 files changed: 164 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1511.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1511/head:pull/1511 PR: https://git.openjdk.org/jdk11u-dev/pull/1511 From goetz at openjdk.org Thu Nov 10 13:33:01 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Nov 2022 13:33:01 GMT Subject: [jdk17u-dev] RFR: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java Message-ID: <5pQvDZHBa_OzhfrMcRg-o97PuphzekKXxQ6Yu20fGz0=.0bc15949-3028-4314-9c6f-175cd12e9197@github.com> I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport d57fb6f684eac5a7e68842dcf3284309e3867521 Changes: https://git.openjdk.org/jdk17u-dev/pull/872/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=872&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274456 Stats: 181 lines in 1 file changed: 44 ins; 90 del; 47 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/872.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/872/head:pull/872 PR: https://git.openjdk.org/jdk17u-dev/pull/872 From goetz at openjdk.org Thu Nov 10 13:37:44 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Nov 2022 13:37:44 GMT Subject: [jdk17u-dev] RFR: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport 296f8537f71b84f194cf2718ac9b85ba6843cfa3 Changes: https://git.openjdk.org/jdk17u-dev/pull/873/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=873&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274029 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/873.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/873/head:pull/873 PR: https://git.openjdk.org/jdk17u-dev/pull/873 From goetz at openjdk.org Thu Nov 10 13:47:22 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Nov 2022 13:47:22 GMT Subject: [jdk17u-dev] RFR: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails Message-ID: <5OLUsRVMPt86LM9xJS4jIFK2HMeowP8jjimzpSew22E=.8c77411c-2939-40d1-b47f-443124446e55@github.com> I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport f399ae558eabdce8960d339ef0758c023aeb89cc Changes: https://git.openjdk.org/jdk17u-dev/pull/874/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=874&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8202836 Stats: 115 lines in 1 file changed: 93 ins; 5 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/874.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/874/head:pull/874 PR: https://git.openjdk.org/jdk17u-dev/pull/874 From goetz at openjdk.org Thu Nov 10 13:56:55 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Nov 2022 13:56:55 GMT Subject: [jdk17u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f Message-ID: I backport this for parity with 17.0.7-oracle. Backporting from 15 as this should be clean. ------------- Commit messages: - Backport 7379b6b205528464ec79459ddc6fb5f6cab556df Changes: https://git.openjdk.org/jdk17u-dev/pull/875/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=875&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296108 Stats: 1362 lines in 25 files changed: 560 ins; 705 del; 97 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/875.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/875/head:pull/875 PR: https://git.openjdk.org/jdk17u-dev/pull/875 From goetz at openjdk.org Thu Nov 10 14:04:54 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Nov 2022 14:04:54 GMT Subject: [jdk17u-dev] RFR: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Message-ID: I backport this for parity with 17.0.7-oracle. ------------- Commit messages: - Backport b6ea69c06aca7f013e26596cebd039960c5b4d34 Changes: https://git.openjdk.org/jdk17u-dev/pull/876/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=876&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296480 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/876.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/876/head:pull/876 PR: https://git.openjdk.org/jdk17u-dev/pull/876 From goetz at openjdk.org Thu Nov 10 14:13:02 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Nov 2022 14:13:02 GMT Subject: [jdk11u-dev] RFR: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Message-ID: I backport this for parity with 11.0.19-oracle. ------------- Commit messages: - Backport b6ea69c06aca7f013e26596cebd039960c5b4d34 Changes: https://git.openjdk.org/jdk11u-dev/pull/1512/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1512&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296480 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1512.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1512/head:pull/1512 PR: https://git.openjdk.org/jdk11u-dev/pull/1512 From goetz at openjdk.org Thu Nov 10 14:13:18 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 10 Nov 2022 14:13:18 GMT Subject: [jdk17u-dev] RFR: 8286872: Refactor add/modify notification icon (TrayIcon) Message-ID: I backport this for parity with 17.0.6-oracle. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/866 Commit messages: - Backport 9f562ef7546c80e6ddce7b932f3f5ca17c741d21 Changes: https://git.openjdk.org/jdk17u-dev/pull/871/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=871&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286872 Stats: 26 lines in 2 files changed: 14 ins; 5 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/871.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/871/head:pull/871 PR: https://git.openjdk.org/jdk17u-dev/pull/871 From mdoerr at openjdk.org Thu Nov 10 14:34:49 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 10 Nov 2022 14:34:49 GMT Subject: [jdk17u-dev] RFR: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor Message-ID: <4L2OwTMp7co2wDVMEDb4cc4w_OP6JXggiDVgpb6_x9k=.e7954c04-104b-4248-bf51-d0b54df22a12@github.com> Clean backport of [JDK-8295872](https://bugs.openjdk.org/browse/JDK-8295872). Doesn't apply automatically, because the files were renamed. ------------- Commit messages: - Backport 59a13b1856cb1cf86385874b1152531016d41c22 Changes: https://git.openjdk.org/jdk17u-dev/pull/877/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=877&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295872 Stats: 18 lines in 2 files changed: 10 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/877.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/877/head:pull/877 PR: https://git.openjdk.org/jdk17u-dev/pull/877 From rkennke at openjdk.org Thu Nov 10 15:38:39 2022 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 10 Nov 2022 15:38:39 GMT Subject: [jdk11u-dev] RFR: 8277497: Last column cell in the JTable row is read as empty cell In-Reply-To: References: Message-ID: On Tue, 1 Nov 2022 16:46:32 GMT, William Kemper wrote: > Hi all, > > This pull request contains a backport of commit [70bad89b](https://github.com/openjdk/jdk/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Artem Semenov on 6 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal. This backport brings parity with oracle 11. > > Thanks! I tested the change on MacOS following the instructions in the original bug report, and I can confirm that the table cell that has been read falsely as 'null' is now correctly being read as 'image'. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1490 From dchuyko at openjdk.org Thu Nov 10 15:45:58 2022 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 10 Nov 2022 15:45:58 GMT Subject: [jdk17u-dev] RFR: 8284578: Relax InterpreterCodelet stub alignment [v5] In-Reply-To: <-S-PuYwXrek_TJNEUgFE7-5zClVhBKFK9CKEvX59iYY=.49d64463-b100-4589-a0f3-c0b57bc6935f@github.com> References: <-S-PuYwXrek_TJNEUgFE7-5zClVhBKFK9CKEvX59iYY=.49d64463-b100-4589-a0f3-c0b57bc6935f@github.com> Message-ID: > This change improves density of interpreter codelets. I have no intent to backport JDK-8281467 [1] (Allow larger OptoLoopAlignment and CodeEntryAlignment), entire JDK-8283298 [2] (productize CodeCacheSegmentSize) and its related change in stubRoutines.cpp JDK-8282355 [3]. > > However I suppose that Modification of MethodHandles::generate_adapters() from JDK-8283298 which makes blob size more accurate is related to this fix, so I included it here. JDK-8283298 modifications of TemplateInterpreter::initialize_stub() are overwritten by the changes from the original JDK-8284578 patch. > > So this patch consists of > - Original JDK-8284578 altered to be applicable without JDK-8283298 and JDK-8264207 [4] (can be backported afterwards). > - MethodHandles::generate_adapters() and copyrights from JDK-8283298. > > Testing: tier1, tier2 on x86 and aarch64 (release) > > [0] https://bugs.openjdk.org/browse/JDK-8284578 > [1] https://bugs.openjdk.org/browse/JDK-8281467 > [2] https://bugs.openjdk.org/browse/JDK-8283298 > [3] https://bugs.openjdk.org/browse/JDK-8282355 > [4] https://bugs.openjdk.org/browse/JDK-8264207 Dmitry Chuyko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8284578 - Merge branch 'openjdk:master' into JDK-8284578 - Backport 2241a057050ed521cfbfbe8a758353e621dee15f ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/753/files - new: https://git.openjdk.org/jdk17u-dev/pull/753/files/1a5f0047..04b6b21a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=753&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=753&range=03-04 Stats: 3083 lines in 91 files changed: 2052 ins; 353 del; 678 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/753.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/753/head:pull/753 PR: https://git.openjdk.org/jdk17u-dev/pull/753 From dchuyko at openjdk.org Thu Nov 10 15:48:43 2022 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 10 Nov 2022 15:48:43 GMT Subject: [jdk17u-dev] RFR: 8072070: Improve interpreter stack banging [v2] In-Reply-To: References: Message-ID: > Original patch applies almost cleanly. The only difference is in os.cpp where `thread->as_Java_thread()` is used instead of `JavaThread::cast(thread)` because https://bugs.openjdk.org/browse/JDK-8268368 (Adopt cast notation for JavaThread conversions) is not in 17u. > > Testing: jtreg tier1, tier2 on x86 and aarch64. Dmitry Chuyko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8072070 - Backport 3a13425bc9088cbb6d95e1a46248d7eba27fb1a6 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/848/files - new: https://git.openjdk.org/jdk17u-dev/pull/848/files/332622ca..bb5a70dd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=848&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=848&range=00-01 Stats: 3084 lines in 92 files changed: 2052 ins; 353 del; 679 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/848.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/848/head:pull/848 PR: https://git.openjdk.org/jdk17u-dev/pull/848 From dchuyko at openjdk.org Thu Nov 10 15:50:09 2022 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 10 Nov 2022 15:50:09 GMT Subject: [jdk17u-dev] RFR: 8265263: AArch64: Combine vneg with right shift count [v4] In-Reply-To: References: Message-ID: > This is a performance improvement for AArch64. There are several differences from the original change. > > https://bugs.openjdk.org/browse/JDK-8267356 (Vector API SVE codegen support) is not in 17u, so `UseSVE == 0` parts in predicates are missing/excluded. > > https://bugs.openjdk.org/browse/JDK-8288445 (C2 compilation fails) is a subsequent bugfix already backported in 17u, so some `immI` arguments in rules became `immI_positive`. > > https://bugs.openjdk.org/browse/JDK-8277239 (SIGSEGV in vrshift_reg_maskedNode::emit) is also related to Vector API and is not in 17u, so `!n->as_ShiftV()->is_var_shift()` is replaced by `VectorNode::is_vshift_cnt(n->in(2))`. This substitution may raise doubts. > > Testing: jtreg test/hotspot/jtreg/compiler, tier1, tier2 on aarch64. > > Performance improvements in the added benchmark VectorShiftRight on Graviton 2 for default size=1024 correspond to the original review: > > > rShiftByte 16% > rShiftInt 27% > rShiftLong 16% > rShiftShort 20% > urShiftByte 0% > urShiftChar 20% > urShiftInt 27% > urShiftLong 16% Dmitry Chuyko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8265263 - Fixed m4 mismatch - No SVE checks in vsrcnt8B, vsrcnt16B - Backport 49245131e98c1c72c447536e5527acecb3311add ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/811/files - new: https://git.openjdk.org/jdk17u-dev/pull/811/files/0a9c5957..4d87503c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=811&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=811&range=02-03 Stats: 3542 lines in 121 files changed: 2455 ins; 363 del; 724 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/811.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/811/head:pull/811 PR: https://git.openjdk.org/jdk17u-dev/pull/811 From dchuyko at openjdk.org Thu Nov 10 18:28:21 2022 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 10 Nov 2022 18:28:21 GMT Subject: [jdk17u-dev] RFR: 8284533: Improve InterpreterCodelet data footprint Message-ID: <9eekhJLssjjtrBGPDVsAoqXOL0OxqD1Ts54XqJjW5Bk=.f5994415-c820-4bdf-a75b-3e04de3d34e4@github.com> Original patch does not apply because of different NOT_PRODUCT fields of InterpreterCodelet. Repeated exactly the meaningful part: moving 3 fields in a new order after the NOT_PRODUCT part. Comments and white space 'after' are just like in the original diff. Testing: tier1, tier2 on aarch64. ------------- Commit messages: - Backport 61698bd137fc8ffad6a63b57b73df699712527b9 Changes: https://git.openjdk.org/jdk17u-dev/pull/878/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=878&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284533 Stats: 6 lines in 1 file changed: 3 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/878.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/878/head:pull/878 PR: https://git.openjdk.org/jdk17u-dev/pull/878 From yan at openjdk.org Fri Nov 11 07:07:23 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 11 Nov 2022 07:07:23 GMT Subject: [jdk13u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update Message-ID: <7-csMf0G3H9Bv5FcK-lPvEUQfOYuOGNYE-b-v1B2hGU=.d16846dd-2d5e-4f69-a4a0-22668eda0ddd@github.com> this is a regular update I need to backport. Everything is clean and tests pass but src/java.base/share/data/currency/ is make/data/currency/ in older releases. ------------- Commit messages: - Backport 3b1bc21727636cb50cd04d958031832f48fe17e3 Changes: https://git.openjdk.org/jdk13u-dev/pull/428/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=428&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294307 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/428.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/428/head:pull/428 PR: https://git.openjdk.org/jdk13u-dev/pull/428 From yan at openjdk.org Fri Nov 11 07:11:36 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 11 Nov 2022 07:11:36 GMT Subject: [jdk15u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update Message-ID: this is a regular update I need to backport. Everything is clean and tests pass but src/java.base/share/data/currency/ is make/data/currency/ in older releases. ------------- Commit messages: - Backport 3b1bc21727636cb50cd04d958031832f48fe17e3 Changes: https://git.openjdk.org/jdk15u-dev/pull/302/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=302&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294307 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/302.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/302/head:pull/302 PR: https://git.openjdk.org/jdk15u-dev/pull/302 From dcherepanov at openjdk.org Fri Nov 11 07:43:52 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 11 Nov 2022 07:43:52 GMT Subject: [jdk13u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update In-Reply-To: <7-csMf0G3H9Bv5FcK-lPvEUQfOYuOGNYE-b-v1B2hGU=.d16846dd-2d5e-4f69-a4a0-22668eda0ddd@github.com> References: <7-csMf0G3H9Bv5FcK-lPvEUQfOYuOGNYE-b-v1B2hGU=.d16846dd-2d5e-4f69-a4a0-22668eda0ddd@github.com> Message-ID: On Fri, 11 Nov 2022 06:59:52 GMT, Yuri Nesterenko wrote: > this is a regular update I need to backport. Everything is clean and tests pass but src/java.base/share/data/currency/ is make/data/currency/ in older releases. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/428 From dcherepanov at openjdk.org Fri Nov 11 07:44:48 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 11 Nov 2022 07:44:48 GMT Subject: [jdk15u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 07:05:51 GMT, Yuri Nesterenko wrote: > this is a regular update I need to backport. Everything is clean and tests pass but src/java.base/share/data/currency/ is make/data/currency/ in older releases. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/302 From bae at openjdk.org Fri Nov 11 07:48:16 2022 From: bae at openjdk.org (Andrew Brygin) Date: Fri, 11 Nov 2022 07:48:16 GMT Subject: [jdk15u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 07:05:51 GMT, Yuri Nesterenko wrote: > this is a regular update I need to backport. Everything is clean and tests pass but src/java.base/share/data/currency/ is make/data/currency/ in older releases. Marked as reviewed by bae (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/302 From bae at openjdk.org Fri Nov 11 07:49:42 2022 From: bae at openjdk.org (Andrew Brygin) Date: Fri, 11 Nov 2022 07:49:42 GMT Subject: [jdk13u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update In-Reply-To: <7-csMf0G3H9Bv5FcK-lPvEUQfOYuOGNYE-b-v1B2hGU=.d16846dd-2d5e-4f69-a4a0-22668eda0ddd@github.com> References: <7-csMf0G3H9Bv5FcK-lPvEUQfOYuOGNYE-b-v1B2hGU=.d16846dd-2d5e-4f69-a4a0-22668eda0ddd@github.com> Message-ID: <8kjGaevixe54UgP2lIEsbnhVB3uxmyJ6P4PWafhAGKU=.da413977-f59b-427a-883e-2937f70fa964@github.com> On Fri, 11 Nov 2022 06:59:52 GMT, Yuri Nesterenko wrote: > this is a regular update I need to backport. Everything is clean and tests pass but src/java.base/share/data/currency/ is make/data/currency/ in older releases. Marked as reviewed by bae (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/428 From goetz at openjdk.org Fri Nov 11 07:49:59 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 07:49:59 GMT Subject: [jdk11u-dev] RFR: 8277497: Last column cell in the JTable row is read as empty cell In-Reply-To: References: Message-ID: On Tue, 1 Nov 2022 16:46:32 GMT, William Kemper wrote: > Hi all, > > This pull request contains a backport of commit [70bad89b](https://github.com/openjdk/jdk/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Artem Semenov on 6 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal. This backport brings parity with oracle 11. > > Thanks! Thanks! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1490 From wkemper at openjdk.org Fri Nov 11 07:52:02 2022 From: wkemper at openjdk.org (William Kemper) Date: Fri, 11 Nov 2022 07:52:02 GMT Subject: [jdk11u-dev] Integrated: 8277497: Last column cell in the JTable row is read as empty cell In-Reply-To: References: Message-ID: On Tue, 1 Nov 2022 16:46:32 GMT, William Kemper wrote: > Hi all, > > This pull request contains a backport of commit [70bad89b](https://github.com/openjdk/jdk/commit/70bad89b012eb200ca1e76f384a6e5fb307cf26d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Artem Semenov on 6 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal. This backport brings parity with oracle 11. > > Thanks! This pull request has now been integrated. Changeset: 03fa4712 Author: William Kemper Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/03fa47127f299bfb07fa27c0b1850215397c0041 Stats: 22 lines in 1 file changed: 22 ins; 0 del; 0 mod 8277497: Last column cell in the JTable row is read as empty cell Backport-of: 70bad89b012eb200ca1e76f384a6e5fb307cf26d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1490 From yan at openjdk.org Fri Nov 11 08:01:10 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 11 Nov 2022 08:01:10 GMT Subject: [jdk13u-dev] Integrated: 8294307: ISO 4217 Amendment 173 Update In-Reply-To: <7-csMf0G3H9Bv5FcK-lPvEUQfOYuOGNYE-b-v1B2hGU=.d16846dd-2d5e-4f69-a4a0-22668eda0ddd@github.com> References: <7-csMf0G3H9Bv5FcK-lPvEUQfOYuOGNYE-b-v1B2hGU=.d16846dd-2d5e-4f69-a4a0-22668eda0ddd@github.com> Message-ID: On Fri, 11 Nov 2022 06:59:52 GMT, Yuri Nesterenko wrote: > this is a regular update I need to backport. Everything is clean and tests pass but src/java.base/share/data/currency/ is make/data/currency/ in older releases. This pull request has now been integrated. Changeset: 3d1d693e Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/3d1d693e46745badf810bb53a6ce7ded337f0f23 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8294307: ISO 4217 Amendment 173 Update Reviewed-by: dcherepanov, bae Backport-of: 3b1bc21727636cb50cd04d958031832f48fe17e3 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/428 From goetz at openjdk.org Fri Nov 11 08:34:02 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 08:34:02 GMT Subject: [jdk17u-dev] RFR: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java In-Reply-To: References: Message-ID: On Thu, 10 Nov 2022 13:28:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. Pre-submit failure: TestStringDeduplicationAgeThreshold.java#id1, known to be failing. Unrelated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/873 From yan at openjdk.org Fri Nov 11 09:08:40 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 11 Nov 2022 09:08:40 GMT Subject: [jdk15u-dev] Integrated: 8294307: ISO 4217 Amendment 173 Update In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 07:05:51 GMT, Yuri Nesterenko wrote: > this is a regular update I need to backport. Everything is clean and tests pass but src/java.base/share/data/currency/ is make/data/currency/ in older releases. This pull request has now been integrated. Changeset: 4b60ed4d Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/4b60ed4d08d6e4cfb26bde2533b6f06b8bf3fa25 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8294307: ISO 4217 Amendment 173 Update Reviewed-by: dcherepanov, bae Backport-of: 3b1bc21727636cb50cd04d958031832f48fe17e3 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/302 From goetz at openjdk.org Fri Nov 11 09:31:40 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 09:31:40 GMT Subject: [jdk17u-dev] Integrated: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java In-Reply-To: <5pQvDZHBa_OzhfrMcRg-o97PuphzekKXxQ6Yu20fGz0=.0bc15949-3028-4314-9c6f-175cd12e9197@github.com> References: <5pQvDZHBa_OzhfrMcRg-o97PuphzekKXxQ6Yu20fGz0=.0bc15949-3028-4314-9c6f-175cd12e9197@github.com> Message-ID: On Thu, 10 Nov 2022 13:24:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: 574d72fe Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/574d72fee5b5bb8fe980d4dbf51445711dcacea2 Stats: 181 lines in 1 file changed: 44 ins; 90 del; 47 mod 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java Backport-of: d57fb6f684eac5a7e68842dcf3284309e3867521 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/872 From goetz at openjdk.org Fri Nov 11 09:42:10 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 09:42:10 GMT Subject: [jdk17u-dev] Integrated: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java In-Reply-To: References: Message-ID: On Thu, 10 Nov 2022 13:28:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: 386f7146 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/386f7146ff6159c3364f526b17cefa65b3908bb5 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java Backport-of: 296f8537f71b84f194cf2718ac9b85ba6843cfa3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/873 From goetz at openjdk.org Fri Nov 11 09:42:51 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 09:42:51 GMT Subject: [jdk17u-dev] Integrated: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails In-Reply-To: <5OLUsRVMPt86LM9xJS4jIFK2HMeowP8jjimzpSew22E=.8c77411c-2939-40d1-b47f-443124446e55@github.com> References: <5OLUsRVMPt86LM9xJS4jIFK2HMeowP8jjimzpSew22E=.8c77411c-2939-40d1-b47f-443124446e55@github.com> Message-ID: On Thu, 10 Nov 2022 13:38:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: 3d18b231 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/3d18b231323ce4dce3af89956bc9d71e967a74c4 Stats: 115 lines in 1 file changed: 93 ins; 5 del; 17 mod 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails Backport-of: f399ae558eabdce8960d339ef0758c023aeb89cc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/874 From yan at openjdk.org Fri Nov 11 09:44:39 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 11 Nov 2022 09:44:39 GMT Subject: [jdk13u-dev] RFR: 8296239: ISO 4217 Amendment 174 Update Message-ID: backporting to keep data up-to-date. Again, src/java.base/share/data is make/data in older releases. Otherwise, it is aalmost clean backport with a difference in bugfix list in a test in 13u. The relevant tests run fine. ------------- Commit messages: - Backport fd837649811c866c144c9133d211fb5ad8f994a7 Changes: https://git.openjdk.org/jdk13u-dev/pull/429/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=429&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296239 Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/429.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/429/head:pull/429 PR: https://git.openjdk.org/jdk13u-dev/pull/429 From yan at openjdk.org Fri Nov 11 09:45:08 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 11 Nov 2022 09:45:08 GMT Subject: [jdk15u-dev] RFR: 8296239: ISO 4217 Amendment 174 Update Message-ID: backporting to keep data up-to-date. Again, src/java.base/share/data is make/data in older releases. Otherwise, it is a clean backport. The relevant tests run fine. ------------- Commit messages: - Backport fd837649811c866c144c9133d211fb5ad8f994a7 Changes: https://git.openjdk.org/jdk15u-dev/pull/303/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=303&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296239 Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/303.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/303/head:pull/303 PR: https://git.openjdk.org/jdk15u-dev/pull/303 From goetz at openjdk.org Fri Nov 11 09:45:52 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 09:45:52 GMT Subject: [jdk17u-dev] Integrated: 8255439: System Tray icons get corrupted when Windows scaling changes In-Reply-To: References: Message-ID: On Wed, 9 Nov 2022 18:24:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.5-oracle. This pull request has now been integrated. Changeset: cd4cc5d6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/cd4cc5d69e3243d9474bb766054aaf9b84a0148c Stats: 166 lines in 3 files changed: 164 ins; 0 del; 2 mod 8255439: System Tray icons get corrupted when Windows scaling changes Backport-of: 8323787c07ced4fa8ce852995df4c0e2de4d7ccc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/866 From goetz at openjdk.org Fri Nov 11 09:51:10 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 09:51:10 GMT Subject: [jdk17u-dev] RFR: 8286872: Refactor add/modify notification icon (TrayIcon) [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.6-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/871/files - new: https://git.openjdk.org/jdk17u-dev/pull/871/files/425cb676..425cb676 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=871&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=871&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/871.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/871/head:pull/871 PR: https://git.openjdk.org/jdk17u-dev/pull/871 From dcherepanov at openjdk.org Fri Nov 11 09:55:39 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 11 Nov 2022 09:55:39 GMT Subject: [jdk13u-dev] RFR: 8296239: ISO 4217 Amendment 174 Update In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 09:37:19 GMT, Yuri Nesterenko wrote: > backporting to keep data up-to-date. Again, src/java.base/share/data is make/data in older releases. > Otherwise, it is aalmost clean backport with a difference in bugfix list in a test in 13u. The relevant tests run fine. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/429 From dcherepanov at openjdk.org Fri Nov 11 09:57:38 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Fri, 11 Nov 2022 09:57:38 GMT Subject: [jdk15u-dev] RFR: 8296239: ISO 4217 Amendment 174 Update In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 09:37:50 GMT, Yuri Nesterenko wrote: > backporting to keep data up-to-date. Again, src/java.base/share/data is make/data in older releases. > Otherwise, it is a clean backport. The relevant tests run fine. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/303 From yan at openjdk.org Fri Nov 11 10:04:34 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 11 Nov 2022 10:04:34 GMT Subject: [jdk13u-dev] Integrated: 8296239: ISO 4217 Amendment 174 Update In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 09:37:19 GMT, Yuri Nesterenko wrote: > backporting to keep data up-to-date. Again, src/java.base/share/data is make/data in older releases. > Otherwise, it is aalmost clean backport with a difference in bugfix list in a test in 13u. The relevant tests run fine. This pull request has now been integrated. Changeset: d6b30727 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/d6b307277f8777fc95f3a6ddee3a0d466bc4781b Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod 8296239: ISO 4217 Amendment 174 Update Reviewed-by: dcherepanov Backport-of: fd837649811c866c144c9133d211fb5ad8f994a7 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/429 From goetz at openjdk.org Fri Nov 11 10:04:57 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 10:04:57 GMT Subject: [jdk17u-dev] RFR: 8286872: Refactor add/modify notification icon (TrayIcon) [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.6-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8286872 - Backport 9f562ef7546c80e6ddce7b932f3f5ca17c741d21 - Backport 8323787c07ced4fa8ce852995df4c0e2de4d7ccc ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/871/files - new: https://git.openjdk.org/jdk17u-dev/pull/871/files/425cb676..e827aebd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=871&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=871&range=01-02 Stats: 1702 lines in 31 files changed: 1133 ins; 223 del; 346 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/871.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/871/head:pull/871 PR: https://git.openjdk.org/jdk17u-dev/pull/871 From yan at openjdk.org Fri Nov 11 10:06:51 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 11 Nov 2022 10:06:51 GMT Subject: [jdk15u-dev] Integrated: 8296239: ISO 4217 Amendment 174 Update In-Reply-To: References: Message-ID: <577uf0iqy4dLcKVJEujp7qZKrUZxmgPGvOH2TfyprkI=.39d89fd8-061a-48b4-a6f5-01cc95422250@github.com> On Fri, 11 Nov 2022 09:37:50 GMT, Yuri Nesterenko wrote: > backporting to keep data up-to-date. Again, src/java.base/share/data is make/data in older releases. > Otherwise, it is a clean backport. The relevant tests run fine. This pull request has now been integrated. Changeset: 28bd3a82 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/28bd3a823ee8d3d1531c8f13e8e5829e8ff655bc Stats: 8 lines in 3 files changed: 0 ins; 0 del; 8 mod 8296239: ISO 4217 Amendment 174 Update Reviewed-by: dcherepanov Backport-of: fd837649811c866c144c9133d211fb5ad8f994a7 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/303 From goetz at openjdk.org Fri Nov 11 10:07:14 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 10:07:14 GMT Subject: [jdk11u-dev] Integrated: 8255439: System Tray icons get corrupted when Windows scaling changes In-Reply-To: <_zpFb3Sa8zd7PlQNlIfGmELP9fdwsMXrnAd23HUqAKc=.da58f74b-bc1c-47da-a331-f671fcf74c0f@github.com> References: <_zpFb3Sa8zd7PlQNlIfGmELP9fdwsMXrnAd23HUqAKc=.da58f74b-bc1c-47da-a331-f671fcf74c0f@github.com> Message-ID: On Thu, 10 Nov 2022 12:02:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.17-oracle. This pull request has now been integrated. Changeset: 338f9af9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/338f9af9aaf5e37670bb9a4a0802619b1601215f Stats: 166 lines in 3 files changed: 164 ins; 0 del; 2 mod 8255439: System Tray icons get corrupted when Windows scaling changes Backport-of: 8323787c07ced4fa8ce852995df4c0e2de4d7ccc ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1511 From goetz at openjdk.org Fri Nov 11 10:19:02 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 10:19:02 GMT Subject: [jdk17u-dev] Integrated: 8286872: Refactor add/modify notification icon (TrayIcon) In-Reply-To: References: Message-ID: On Thu, 10 Nov 2022 11:10:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.6-oracle. This pull request has now been integrated. Changeset: f29ade7e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f29ade7e4a25a9fe92ba4fa3328a2e71d8a6cc4c Stats: 26 lines in 2 files changed: 14 ins; 5 del; 7 mod 8286872: Refactor add/modify notification icon (TrayIcon) Backport-of: 9f562ef7546c80e6ddce7b932f3f5ca17c741d21 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/871 From goetz at openjdk.org Fri Nov 11 10:22:47 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 10:22:47 GMT Subject: [jdk17u-dev] Integrated: 8296108: (tz) Update Timezone Data to 2022f In-Reply-To: References: Message-ID: On Thu, 10 Nov 2022 13:47:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. > > Backporting from 15 as this should be clean. This pull request has now been integrated. Changeset: b5710c4b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/b5710c4b14b72c164aad4196c8ebe1a05ffccc94 Stats: 1362 lines in 25 files changed: 560 ins; 705 del; 97 mod 8296108: (tz) Update Timezone Data to 2022f Backport-of: 7379b6b205528464ec79459ddc6fb5f6cab556df ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/875 From goetz at openjdk.org Fri Nov 11 10:26:40 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 10:26:40 GMT Subject: [jdk17u-dev] Integrated: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing In-Reply-To: References: Message-ID: On Thu, 10 Nov 2022 13:56:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.7-oracle. This pull request has now been integrated. Changeset: 7d17479d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7d17479dc354d84198f505fc815391a6285af6b3 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Backport-of: b6ea69c06aca7f013e26596cebd039960c5b4d34 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/876 From goetz at openjdk.org Fri Nov 11 10:27:47 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 10:27:47 GMT Subject: [jdk11u-dev] Integrated: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing In-Reply-To: References: Message-ID: On Thu, 10 Nov 2022 14:04:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. This pull request has now been integrated. Changeset: 3b7f045c Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/3b7f045cd49ae727a7ce65c12fc180ddac09dbf7 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Backport-of: b6ea69c06aca7f013e26596cebd039960c5b4d34 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1512 From goetz at openjdk.org Fri Nov 11 10:28:35 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 10:28:35 GMT Subject: [jdk11u-dev] RFR: 8286872: Refactor add/modify notification icon (TrayIcon) Message-ID: I backport this for parity with 11.0.18-oracle. ------------- Commit messages: - Backport 9f562ef7546c80e6ddce7b932f3f5ca17c741d21 Changes: https://git.openjdk.org/jdk11u-dev/pull/1513/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1513&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286872 Stats: 26 lines in 2 files changed: 14 ins; 5 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1513.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1513/head:pull/1513 PR: https://git.openjdk.org/jdk11u-dev/pull/1513 From mdoerr at openjdk.org Fri Nov 11 12:19:11 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 11 Nov 2022 12:19:11 GMT Subject: [jdk17u-dev] RFR: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment In-Reply-To: References: Message-ID: On Fri, 23 Sep 2022 13:34:35 GMT, Johannes Bechberger wrote: > Fixes the minor possibility of ASGCT acquiring a lock. > > Tested using my jdk profiling tester. LGTM. src/hotspot/share/prims/forte.cpp line 532: > 530: > 531: if (trace->env_id == NULL || raw_thread == NULL || !raw_thread->is_Java_thread() || > 532: (thread = ((JavaThread*)raw_thread))->is_exiting()) { One minor diff: indentation ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/725 From goetz at openjdk.org Fri Nov 11 12:56:13 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 12:56:13 GMT Subject: [jdk17u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update Message-ID: A needed update. ------------- Commit messages: - Backport 4b60ed4d08d6e4cfb26bde2533b6f06b8bf3fa25 Changes: https://git.openjdk.org/jdk17u-dev/pull/879/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=879&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294307 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/879.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/879/head:pull/879 PR: https://git.openjdk.org/jdk17u-dev/pull/879 From goetz at openjdk.org Fri Nov 11 13:03:29 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 13:03:29 GMT Subject: [jdk11u-dev] RFR: 8294307: ISO 4217 Amendment 173 Update Message-ID: I backport this for parity with 13, 15, 17 and 19u. ------------- Commit messages: - Backport 4b60ed4d08d6e4cfb26bde2533b6f06b8bf3fa25 Changes: https://git.openjdk.org/jdk11u-dev/pull/1514/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1514&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294307 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1514.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1514/head:pull/1514 PR: https://git.openjdk.org/jdk11u-dev/pull/1514 From goetz at openjdk.org Fri Nov 11 13:17:19 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 13:17:19 GMT Subject: [jdk11u-dev] RFR: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java Message-ID: <-CU1dERIgNdtzMhqyTLboc0mVitv1WXvKhci-_b0aTc=.9115d8c0-de6f-4492-8979-644207641d38@github.com> I backport this for parity with 11.0.19-oracle. ------------- Commit messages: - Backport d57fb6f684eac5a7e68842dcf3284309e3867521 Changes: https://git.openjdk.org/jdk11u-dev/pull/1515/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1515&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274456 Stats: 181 lines in 1 file changed: 44 ins; 90 del; 47 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1515.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1515/head:pull/1515 PR: https://git.openjdk.org/jdk11u-dev/pull/1515 From goetz at openjdk.org Fri Nov 11 13:24:46 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 13:24:46 GMT Subject: [jdk11u-dev] RFR: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java Message-ID: I backport this for parity with 11.0.19-oracle. ------------- Commit messages: - Backport 296f8537f71b84f194cf2718ac9b85ba6843cfa3 Changes: https://git.openjdk.org/jdk11u-dev/pull/1517/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1517&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274029 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1517.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1517/head:pull/1517 PR: https://git.openjdk.org/jdk11u-dev/pull/1517 From goetz at openjdk.org Fri Nov 11 13:35:17 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 13:35:17 GMT Subject: [jdk11u-dev] RFR: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails Message-ID: I backport this for parity with 11.0.19-oracle. I had to replace a """ """ quoted string with java 11 syntax. This is only a change to a test, and the edit is most trivial, therefore I'll mark this as clean. ------------- Commit messages: - Backport f399ae558eabdce8960d339ef0758c023aeb89cc Changes: https://git.openjdk.org/jdk11u-dev/pull/1516/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1516&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8202836 Stats: 114 lines in 1 file changed: 92 ins; 5 del; 17 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1516.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1516/head:pull/1516 PR: https://git.openjdk.org/jdk11u-dev/pull/1516 From goetz at openjdk.org Fri Nov 11 13:57:49 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 11 Nov 2022 13:57:49 GMT Subject: [jdk11u-dev] RFR: 8296108: (tz) Update Timezone Data to 2022f Message-ID: I backport this for parity with 11.0.19-oracle. ------------- Commit messages: - Backport 46c908b7f2d9778f4793fbf9c2261a6d41122743 Changes: https://git.openjdk.org/jdk11u-dev/pull/1518/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1518&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296108 Stats: 1362 lines in 25 files changed: 560 ins; 705 del; 97 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1518.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1518/head:pull/1518 PR: https://git.openjdk.org/jdk11u-dev/pull/1518 From mdoerr at openjdk.org Fri Nov 11 14:54:57 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 11 Nov 2022 14:54:57 GMT Subject: [jdk17u-dev] Integrated: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor In-Reply-To: <4L2OwTMp7co2wDVMEDb4cc4w_OP6JXggiDVgpb6_x9k=.e7954c04-104b-4248-bf51-d0b54df22a12@github.com> References: <4L2OwTMp7co2wDVMEDb4cc4w_OP6JXggiDVgpb6_x9k=.e7954c04-104b-4248-bf51-d0b54df22a12@github.com> Message-ID: On Thu, 10 Nov 2022 14:28:40 GMT, Martin Doerr wrote: > Clean backport of [JDK-8295872](https://bugs.openjdk.org/browse/JDK-8295872). Doesn't apply automatically, because the files were renamed. This pull request has now been integrated. Changeset: 3486bb2f Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/3486bb2f8f89c6266e67b6efbc68dac14b2e6e74 Stats: 18 lines in 2 files changed: 10 ins; 0 del; 8 mod 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor Backport-of: 59a13b1856cb1cf86385874b1152531016d41c22 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/877 From mdoerr at openjdk.org Fri Nov 11 15:21:17 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 11 Nov 2022 15:21:17 GMT Subject: [jdk11u-dev] RFR: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor Message-ID: Backport of JDK-[8295872](https://github.com/openjdk/jdk17u-dev/commit/3486bb2f8f89c6266e67b6efbc68dac14b2e6e74). `nullptr` needs to get replaced by `NULL` because 11 uses an older C++ standard. ------------- Commit messages: - Backport 3486bb2f8f89c6266e67b6efbc68dac14b2e6e74 Changes: https://git.openjdk.org/jdk11u-dev/pull/1519/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1519&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295872 Stats: 18 lines in 2 files changed: 10 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1519.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1519/head:pull/1519 PR: https://git.openjdk.org/jdk11u-dev/pull/1519 From phh at openjdk.org Fri Nov 11 15:39:17 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 11 Nov 2022 15:39:17 GMT Subject: [jdk11u-dev] RFR: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 15:13:31 GMT, Martin Doerr wrote: > Backport of JDK-[8295872](https://github.com/openjdk/jdk17u-dev/commit/3486bb2f8f89c6266e67b6efbc68dac14b2e6e74). `nullptr` needs to get replaced by `NULL` because 11 uses an older C++ standard. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1519 From mdoerr at openjdk.org Fri Nov 11 15:39:18 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 11 Nov 2022 15:39:18 GMT Subject: [jdk11u-dev] RFR: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 15:13:31 GMT, Martin Doerr wrote: > Backport of JDK-[8295872](https://github.com/openjdk/jdk17u-dev/commit/3486bb2f8f89c6266e67b6efbc68dac14b2e6e74). `nullptr` needs to get replaced by `NULL` because 11 uses an older C++ standard. Thanks for the prompt review! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1519 From phh at openjdk.org Fri Nov 11 21:09:37 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 11 Nov 2022 21:09:37 GMT Subject: [jdk17u-dev] RFR: 8284533: Improve InterpreterCodelet data footprint In-Reply-To: <9eekhJLssjjtrBGPDVsAoqXOL0OxqD1Ts54XqJjW5Bk=.f5994415-c820-4bdf-a75b-3e04de3d34e4@github.com> References: <9eekhJLssjjtrBGPDVsAoqXOL0OxqD1Ts54XqJjW5Bk=.f5994415-c820-4bdf-a75b-3e04de3d34e4@github.com> Message-ID: On Thu, 10 Nov 2022 18:21:32 GMT, Dmitry Chuyko wrote: > Original patch does not apply because of different NOT_PRODUCT fields of InterpreterCodelet. Repeated exactly the meaningful part: moving 3 fields in a new order after the NOT_PRODUCT part. Comments and white space 'after' are just like in the original diff. > > Testing: tier1, tier2 on aarch64. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/878 From clanger at openjdk.org Fri Nov 11 23:33:47 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 11 Nov 2022 23:33:47 GMT Subject: [jdk19u] RFR: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect Message-ID: Hi all, This pull request contains a backport of [JDK-8296733](https://bugs.openjdk.org/browse/JDK-8296733), commit [ced88a2f](https://github.com/openjdk/jdk/commit/ced88a2fd9a35e0e027661ef1f3c5ea3a5fff9e0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Erik Gahlin on 11 Nov 2022 and was reviewed by Christoph Langer and Markus Gr?nlund. Thanks! ------------- Commit messages: - Backport ced88a2fd9a35e0e027661ef1f3c5ea3a5fff9e0 Changes: https://git.openjdk.org/jdk19u/pull/65/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=65&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296733 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/65.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/65/head:pull/65 PR: https://git.openjdk.org/jdk19u/pull/65 From ysatowse at openjdk.org Mon Nov 14 01:33:15 2022 From: ysatowse at openjdk.org (Yoshiki Sato) Date: Mon, 14 Nov 2022 01:33:15 GMT Subject: [jdk19u] RFR: 8296715: CLDR v42 update for tzdata 2022f Message-ID: Please review this MR. Different from the original fix, unicode version is not updated in ldmlSupplemental.dtd. ------------- Commit messages: - 8296715: CLDR v42 update for tzdata 2022f Changes: https://git.openjdk.org/jdk19u/pull/66/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=66&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296715 Stats: 15 lines in 5 files changed: 6 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk19u/pull/66.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/66/head:pull/66 PR: https://git.openjdk.org/jdk19u/pull/66 From mdoerr at openjdk.org Mon Nov 14 07:57:46 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 14 Nov 2022 07:57:46 GMT Subject: [jdk11u-dev] Integrated: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 15:13:31 GMT, Martin Doerr wrote: > Backport of JDK-[8295872](https://github.com/openjdk/jdk17u-dev/commit/3486bb2f8f89c6266e67b6efbc68dac14b2e6e74). `nullptr` needs to get replaced by `NULL` because 11 uses an older C++ standard. This pull request has now been integrated. Changeset: d2af6538 Author: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/d2af6538c026958408124830b7f65df200772e53 Stats: 18 lines in 2 files changed: 10 ins; 0 del; 8 mod 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor Reviewed-by: phh Backport-of: 3486bb2f8f89c6266e67b6efbc68dac14b2e6e74 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1519 From duke at openjdk.org Mon Nov 14 08:27:07 2022 From: duke at openjdk.org (Johannes Bechberger) Date: Mon, 14 Nov 2022 08:27:07 GMT Subject: [jdk17u-dev] RFR: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment In-Reply-To: References: Message-ID: <9ufRi52zw_zung-6UsnPsc5Lbp-n8yEs2QtW2h1HYRI=.ebad9007-0df6-4677-b455-4e312626cf9f@github.com> On Fri, 11 Nov 2022 12:15:57 GMT, Martin Doerr wrote: >> Fixes the minor possibility of ASGCT acquiring a lock. >> >> Tested using my jdk profiling tester. > > src/hotspot/share/prims/forte.cpp line 532: > >> 530: >> 531: if (trace->env_id == NULL || raw_thread == NULL || !raw_thread->is_Java_thread() || >> 532: (thread = ((JavaThread*)raw_thread))->is_exiting()) { > > One minor diff: indentation What is the problem with this indentation? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/725 From goetz at openjdk.org Mon Nov 14 08:35:34 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 14 Nov 2022 08:35:34 GMT Subject: [jdk17u-dev] RFR: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment In-Reply-To: <9ufRi52zw_zung-6UsnPsc5Lbp-n8yEs2QtW2h1HYRI=.ebad9007-0df6-4677-b455-4e312626cf9f@github.com> References: <9ufRi52zw_zung-6UsnPsc5Lbp-n8yEs2QtW2h1HYRI=.ebad9007-0df6-4677-b455-4e312626cf9f@github.com> Message-ID: <_wo2LwvvAintoWlL1rzw3_XtpM9PymGNNAW6tzIAKFw=.bfd24e74-390c-4008-b36f-2805dbf2ab57@github.com> On Mon, 14 Nov 2022 08:22:55 GMT, Johannes Bechberger wrote: >> src/hotspot/share/prims/forte.cpp line 532: >> >>> 530: >>> 531: if (trace->env_id == NULL || raw_thread == NULL || !raw_thread->is_Java_thread() || >>> 532: (thread = ((JavaThread*)raw_thread))->is_exiting()) { >> >> One minor diff: indentation > > What is the problem with this indentation? The original change indents line 532 by four, the backport only by three. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/725 From duke at openjdk.org Mon Nov 14 08:38:52 2022 From: duke at openjdk.org (Johannes Bechberger) Date: Mon, 14 Nov 2022 08:38:52 GMT Subject: [jdk17u-dev] RFR: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment In-Reply-To: <_wo2LwvvAintoWlL1rzw3_XtpM9PymGNNAW6tzIAKFw=.bfd24e74-390c-4008-b36f-2805dbf2ab57@github.com> References: <9ufRi52zw_zung-6UsnPsc5Lbp-n8yEs2QtW2h1HYRI=.ebad9007-0df6-4677-b455-4e312626cf9f@github.com> <_wo2LwvvAintoWlL1rzw3_XtpM9PymGNNAW6tzIAKFw=.bfd24e74-390c-4008-b36f-2805dbf2ab57@github.com> Message-ID: On Mon, 14 Nov 2022 08:33:13 GMT, Goetz Lindenmaier wrote: >> What is the problem with this indentation? > > The original change indents line 532 by four, the backport only by three. Thanks, I'll change it accordingly. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/725 From duke at openjdk.org Mon Nov 14 08:42:15 2022 From: duke at openjdk.org (Johannes Bechberger) Date: Mon, 14 Nov 2022 08:42:15 GMT Subject: [jdk17u-dev] RFR: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment [v2] In-Reply-To: References: Message-ID: > Fixes the minor possibility of ASGCT acquiring a lock. > > Tested using my jdk profiling tester. Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Update forte.cpp ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/725/files - new: https://git.openjdk.org/jdk17u-dev/pull/725/files/ebe5bc25..c38fe1e8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=725&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=725&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/725.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/725/head:pull/725 PR: https://git.openjdk.org/jdk17u-dev/pull/725 From aivanov at openjdk.org Mon Nov 14 13:10:21 2022 From: aivanov at openjdk.org (Alexey Ivanov) Date: Mon, 14 Nov 2022 13:10:21 GMT Subject: [jdk19u] RFR: 8296496: Overzealous check in sizecalc.h prevents large memory allocation Message-ID: <2vmf8VngGW0ZmmwOPmzsahbd0lIiF-hLyZcLLilf0tw=.41371fd3-251e-4260-a3eb-1b6cd685e556@github.com> Hi all, This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. Thanks! ------------- Commit messages: - Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 Changes: https://git.openjdk.org/jdk19u/pull/67/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=67&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296496 Stats: 11 lines in 1 file changed: 0 ins; 4 del; 7 mod Patch: https://git.openjdk.org/jdk19u/pull/67.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/67/head:pull/67 PR: https://git.openjdk.org/jdk19u/pull/67 From rmarchenko at openjdk.org Mon Nov 14 13:22:28 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Mon, 14 Nov 2022 13:22:28 GMT Subject: [jdk17u-dev] RFR: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled Message-ID: <0PmYoCgrEl0vbv2BWPXnougU0xsFnuiXG_SQxqsm7vY=.a034d40a-ce9f-4be9-80a3-abe9bd8116a2@github.com> Backport JDK-8065422 Clean backport, GHA passed. Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backpoted as dependant PRs. ------------- Commit messages: - Backport a95ee5ada230a0177517efd3a417f319066169dd Changes: https://git.openjdk.org/jdk17u-dev/pull/880/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=880&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8065422 Stats: 616 lines in 4 files changed: 613 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/880.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/880/head:pull/880 PR: https://git.openjdk.org/jdk17u-dev/pull/880 From duke at openjdk.org Mon Nov 14 13:50:57 2022 From: duke at openjdk.org (Johannes Bechberger) Date: Mon, 14 Nov 2022 13:50:57 GMT Subject: [jdk17u-dev] Integrated: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment In-Reply-To: References: Message-ID: On Fri, 23 Sep 2022 13:34:35 GMT, Johannes Bechberger wrote: > Fixes the minor possibility of ASGCT acquiring a lock. > > Tested using my jdk profiling tester. This pull request has now been integrated. Changeset: 175bd059 Author: Johannes Bechberger Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/175bd059595fd96d8cc7af416a9b95e77aa599c8 Stats: 9 lines in 1 file changed: 4 ins; 1 del; 4 mod 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment Reviewed-by: mdoerr Backport-of: d4474b5816c2ec8daaf1c905b77d8ba4e23c9439 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/725 From duke at openjdk.org Mon Nov 14 14:24:42 2022 From: duke at openjdk.org (zzambers) Date: Mon, 14 Nov 2022 14:24:42 GMT Subject: [jdk11u-dev] Integrated: 8295714: GHA ::set-output is deprecated and will be removed In-Reply-To: References: Message-ID: On Wed, 2 Nov 2022 15:42:00 GMT, zzambers wrote: > This backport fixes warnings generated in GHA summary page by use of deprecated set-output command. According to warning messages command will be removed soon: > > The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/` > > All tests passed (no warnings). This pull request has now been integrated. Changeset: 5d28a71c Author: Zdenek Zambersky Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/5d28a71c1f1b734a4d8f05363aa61c2b5b6df687 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod 8295714: GHA ::set-output is deprecated and will be removed Reviewed-by: phh Backport-of: b35922be6de7b848a2982d6a278dbd205fc39e6a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1494 From rmarchenko at openjdk.org Mon Nov 14 15:09:49 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Mon, 14 Nov 2022 15:09:49 GMT Subject: [jdk17u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired Message-ID: Backport JDK-8282398 Clean backport. Please note that new test added by the change may fail because there are additional changes in the dependant PR: - Prev PR #880 ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/880 Commit messages: - Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e Changes: https://git.openjdk.org/jdk17u-dev/pull/881/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=881&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282398 Stats: 202 lines in 2 files changed: 30 ins; 2 del; 170 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/881.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/881/head:pull/881 PR: https://git.openjdk.org/jdk17u-dev/pull/881 From rmarchenko at openjdk.org Mon Nov 14 15:43:25 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Mon, 14 Nov 2022 15:43:25 GMT Subject: [jdk17u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template Message-ID: Backport JDK-8282511 to 17u Clean backport. There are previous PRs this PR depend on: - #880 - #881 ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/881 Commit messages: - Backport 268fa693188b685de6289927ee5a1e99473a50f6 Changes: https://git.openjdk.org/jdk17u-dev/pull/882/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=882&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282511 Stats: 218 lines in 2 files changed: 37 ins; 2 del; 179 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/882.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/882/head:pull/882 PR: https://git.openjdk.org/jdk17u-dev/pull/882 From roland at openjdk.org Mon Nov 14 17:03:32 2022 From: roland at openjdk.org (Roland Westrelin) Date: Mon, 14 Nov 2022 17:03:32 GMT Subject: [jdk11u-dev] RFR: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces Message-ID: This is a clean backport. Was fixed in jdk 20 and backported to 17u. Low risk and reported by users on 17. ------------- Commit messages: - Backport 5977ce5adf85c2fb9b1dd62ed250f6d4f05a613c Changes: https://git.openjdk.org/jdk11u-dev/pull/1520/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1520&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288302 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1520.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1520/head:pull/1520 PR: https://git.openjdk.org/jdk11u-dev/pull/1520 From tsteele at openjdk.org Mon Nov 14 22:30:30 2022 From: tsteele at openjdk.org (Tyler Steele) Date: Mon, 14 Nov 2022 22:30:30 GMT Subject: [jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML Message-ID: Backporting this change to jdk11. I noticed this was also requested by @jocwurs as I was working on it. Functionally this is a clean backport. But, there are some differences that will trip up the bots. - Copyright years are sometimes newer in the current jdk11u. I kept the newer year. - I merged two lists of bug ids into one--keeping all bug-ids. - Git seems to treat `test/.../OutputPropertiesTest.java` as a new file in these changes, but not in the old ones. This wasn't a conflict, but it shows up differently for me on GitHub when I compare it to the changes in the original commit. Testing: OutputPropertiesTest passes. I'll wait for a review before requesting this in JBS. ------------- Commit messages: - 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML Changes: https://git.openjdk.org/jdk11u-dev/pull/1521/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1521&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8223291 Stats: 166 lines in 8 files changed: 138 ins; 7 del; 21 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1521.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1521/head:pull/1521 PR: https://git.openjdk.org/jdk11u-dev/pull/1521 From naoto at openjdk.org Tue Nov 15 00:00:28 2022 From: naoto at openjdk.org (Naoto Sato) Date: Tue, 15 Nov 2022 00:00:28 GMT Subject: [jdk19u] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Mon, 14 Nov 2022 01:25:21 GMT, Yoshiki Sato wrote: > Please review this MR. Different from the original fix, unicode version is not updated in ldmlSupplemental.dtd. Marked as reviewed by naoto (Reviewer). ------------- PR: https://git.openjdk.org/jdk19u/pull/66 From ysatowse at openjdk.org Tue Nov 15 00:54:25 2022 From: ysatowse at openjdk.org (Yoshiki Sato) Date: Tue, 15 Nov 2022 00:54:25 GMT Subject: [jdk19u] Integrated: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Mon, 14 Nov 2022 01:25:21 GMT, Yoshiki Sato wrote: > Please review this MR. Different from the original fix, unicode version is not updated in ldmlSupplemental.dtd. This pull request has now been integrated. Changeset: 55dd9022 Author: Yoshiki Sato Committer: Naoto Sato URL: https://git.openjdk.org/jdk19u/commit/55dd90222e2cef11ebca39a2998d8f799aadbb9a Stats: 15 lines in 5 files changed: 6 ins; 6 del; 3 mod 8296715: CLDR v42 update for tzdata 2022f Reviewed-by: naoto ------------- PR: https://git.openjdk.org/jdk19u/pull/66 From ysatowse at openjdk.org Tue Nov 15 06:54:18 2022 From: ysatowse at openjdk.org (Yoshiki Sato) Date: Tue, 15 Nov 2022 06:54:18 GMT Subject: [jdk19u] Integrated: 8296108: (tz) Update Timezone Data to 2022f In-Reply-To: <5we2loijGNyMgxmAg95K49y2YGsdpZLIBXpG1HghdH8=.71629758-5f90-4625-9025-2b4233ea65eb@github.com> References: <5we2loijGNyMgxmAg95K49y2YGsdpZLIBXpG1HghdH8=.71629758-5f90-4625-9025-2b4233ea65eb@github.com> Message-ID: On Wed, 9 Nov 2022 01:22:23 GMT, Yoshiki Sato wrote: > Please review this MR. The MR is a clean backprot of [JDK-8296108](https://bugs.openjdk.org/browse/JDK-8296108): (tz) Update Timezone Data to 2022f. This pull request has now been integrated. Changeset: 045c1f64 Author: Yoshiki Sato Committer: Sean Coffey URL: https://git.openjdk.org/jdk19u/commit/045c1f64897dbd8c12795ba84396ef12598f70a0 Stats: 1362 lines in 25 files changed: 560 ins; 705 del; 97 mod 8296108: (tz) Update Timezone Data to 2022f Reviewed-by: naoto Backport-of: 9d3b4ef2ad658afb5379796b7224458c12c81f5d ------------- PR: https://git.openjdk.org/jdk19u/pull/64 From goetz at openjdk.org Tue Nov 15 08:55:17 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 15 Nov 2022 08:55:17 GMT Subject: [jdk17u-dev] Integrated: 8294307: ISO 4217 Amendment 173 Update In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 12:47:21 GMT, Goetz Lindenmaier wrote: > A needed update. This pull request has now been integrated. Changeset: cfedd3f1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/cfedd3f165fb72a019cdc9d1cc3a1806a279e0a7 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8294307: ISO 4217 Amendment 173 Update Backport-of: 4b60ed4d08d6e4cfb26bde2533b6f06b8bf3fa25 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/879 From goetz at openjdk.org Tue Nov 15 09:01:36 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 15 Nov 2022 09:01:36 GMT Subject: [jdk11u-dev] Integrated: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java In-Reply-To: <-CU1dERIgNdtzMhqyTLboc0mVitv1WXvKhci-_b0aTc=.9115d8c0-de6f-4492-8979-644207641d38@github.com> References: <-CU1dERIgNdtzMhqyTLboc0mVitv1WXvKhci-_b0aTc=.9115d8c0-de6f-4492-8979-644207641d38@github.com> Message-ID: On Fri, 11 Nov 2022 13:09:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. This pull request has now been integrated. Changeset: 7e0603f2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/7e0603f2a87873acff0084942e2b01f418f61c90 Stats: 181 lines in 1 file changed: 44 ins; 90 del; 47 mod 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java Backport-of: d57fb6f684eac5a7e68842dcf3284309e3867521 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1515 From goetz at openjdk.org Tue Nov 15 10:22:31 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 15 Nov 2022 10:22:31 GMT Subject: [jdk11u-dev] Integrated: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 13:16:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. This pull request has now been integrated. Changeset: 8a40a9cf Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/8a40a9cf54d0c92453bb9476c1e63a2df89f3823 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java Backport-of: 296f8537f71b84f194cf2718ac9b85ba6843cfa3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1517 From yan at openjdk.org Tue Nov 15 11:53:48 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 15 Nov 2022 11:53:48 GMT Subject: [jdk13u-dev] RFR: 8297027: Fix broken aarch64 build of 13u/15u after bad backport of 8293044 Message-ID: Change argument of is_patching_needed() to thread, in this release. ------------- Commit messages: - Broken build on aarch64 Changes: https://git.openjdk.org/jdk13u-dev/pull/430/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=430&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297027 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/430.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/430/head:pull/430 PR: https://git.openjdk.org/jdk13u-dev/pull/430 From bae at openjdk.org Tue Nov 15 12:33:14 2022 From: bae at openjdk.org (Andrew Brygin) Date: Tue, 15 Nov 2022 12:33:14 GMT Subject: [jdk13u-dev] RFR: 8297027: Fix broken aarch64 build of 13u/15u after bad backport of 8293044 In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 11:47:22 GMT, Yuri Nesterenko wrote: > Change argument of is_patching_needed() to thread, in this release. Marked as reviewed by bae (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/430 From yan at openjdk.org Tue Nov 15 12:55:05 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 15 Nov 2022 12:55:05 GMT Subject: [jdk13u-dev] Integrated: 8297027: Fix broken aarch64 build of 13u/15u after bad backport of 8293044 In-Reply-To: References: Message-ID: <2GhOMx_srT7iaWjFjjIbtwpF1LdpFhAr1aq8OPTUb-0=.ed6f8300-32bb-4617-9035-e234f5c16fc4@github.com> On Tue, 15 Nov 2022 11:47:22 GMT, Yuri Nesterenko wrote: > Change argument of is_patching_needed() to thread, in this release. This pull request has now been integrated. Changeset: aa9053f3 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/aa9053f330b480b50d53eca1f059d5cf072e5cc3 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8297027: Fix broken aarch64 build of 13u/15u after bad backport of 8293044 Reviewed-by: bae ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/430 From yan at openjdk.org Tue Nov 15 12:59:24 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 15 Nov 2022 12:59:24 GMT Subject: [jdk15u-dev] RFR: 8297027: Fix broken aarch64 build of 13u/15u after bad backport of 8293044 Message-ID: Change argument of is_patching_needed() to thread, in this release, and remove some stray garbage left from a conflict resolution. ------------- Commit messages: - Broken build on aarch64 Changes: https://git.openjdk.org/jdk15u-dev/pull/304/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=304&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297027 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/304.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/304/head:pull/304 PR: https://git.openjdk.org/jdk15u-dev/pull/304 From goetz at openjdk.org Tue Nov 15 13:02:00 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 15 Nov 2022 13:02:00 GMT Subject: [jdk11u-dev] Integrated: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 13:16:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. > > I had to replace a """ """ quoted string with java 11 syntax. > > This is only a change to a test, and the edit is most trivial, therefore I'll mark this as clean. This pull request has now been integrated. Changeset: f2f7be92 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/f2f7be92a0368ebdf43eff60d9f6d22a244c20aa Stats: 114 lines in 1 file changed: 92 ins; 5 del; 17 mod 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails Backport-of: f399ae558eabdce8960d339ef0758c023aeb89cc ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1516 From bae at openjdk.org Tue Nov 15 13:02:56 2022 From: bae at openjdk.org (Andrew Brygin) Date: Tue, 15 Nov 2022 13:02:56 GMT Subject: [jdk15u-dev] RFR: 8297027: Fix broken aarch64 build of 13u/15u after bad backport of 8293044 In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 11:53:51 GMT, Yuri Nesterenko wrote: > Change argument of is_patching_needed() to thread, in this release, and remove some stray garbage left from a conflict resolution. Marked as reviewed by bae (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/304 From yan at openjdk.org Tue Nov 15 13:09:47 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 15 Nov 2022 13:09:47 GMT Subject: [jdk15u-dev] Integrated: 8297027: Fix broken aarch64 build of 13u/15u after bad backport of 8293044 In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 11:53:51 GMT, Yuri Nesterenko wrote: > Change argument of is_patching_needed() to thread, in this release, and remove some stray garbage left from a conflict resolution. This pull request has now been integrated. Changeset: a38104e1 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/a38104e176c2c5eca13db0f549e9201dd02a7bbc Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod 8297027: Fix broken aarch64 build of 13u/15u after bad backport of 8293044 Reviewed-by: bae ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/304 From yan at openjdk.org Tue Nov 15 13:38:44 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 15 Nov 2022 13:38:44 GMT Subject: [jdk13u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f Message-ID: need to backport this change following tz2022f. As in 15u, we omit ldmlSupplemental.dtd change of version and adapt the list of bugs in LocaleDataTest.java For 13u, we also remove es_MX.xml change: it already has restored in this fix format 'count' attribute but the number of patterns is different as it is in a newer (for 13) CLDR. ------------- Commit messages: - Backport 54c986e7d5d0b48a22b4da81c13153ce431c9f2f Changes: https://git.openjdk.org/jdk13u-dev/pull/431/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=431&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296715 Stats: 12 lines in 4 files changed: 6 ins; 3 del; 3 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/431.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/431/head:pull/431 PR: https://git.openjdk.org/jdk13u-dev/pull/431 From yan at openjdk.org Tue Nov 15 13:39:42 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 15 Nov 2022 13:39:42 GMT Subject: [jdk15u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f Message-ID: need to backport this change following tz2022f. For 15u, we omit ldmlSupplemental.dtd change of version and adapt the list of bugs in LocaleDataTest.java ------------- Commit messages: - Backport 54c986e7d5d0b48a22b4da81c13153ce431c9f2f Changes: https://git.openjdk.org/jdk15u-dev/pull/305/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=305&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296715 Stats: 15 lines in 5 files changed: 6 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/305.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/305/head:pull/305 PR: https://git.openjdk.org/jdk15u-dev/pull/305 From goetz at openjdk.org Tue Nov 15 15:18:08 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 15 Nov 2022 15:18:08 GMT Subject: [jdk11u-dev] Integrated: 8286872: Refactor add/modify notification icon (TrayIcon) In-Reply-To: References: Message-ID: <8UNdl5VuseFAHjVHF-Dhi0sZXrKE7uHagzRMyUqNBNU=.c59ffd4f-d5c5-4a73-b317-6b1de0565993@github.com> On Fri, 11 Nov 2022 10:21:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. This pull request has now been integrated. Changeset: 954a6e48 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/954a6e4834054e6ef15a6b3f001f451a90e14dcb Stats: 26 lines in 2 files changed: 14 ins; 5 del; 7 mod 8286872: Refactor add/modify notification icon (TrayIcon) Backport-of: 9f562ef7546c80e6ddce7b932f3f5ca17c741d21 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1513 From goetz at openjdk.org Tue Nov 15 15:19:15 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 15 Nov 2022 15:19:15 GMT Subject: [jdk17u-dev] Integrated: 8029633: Raw inner class constructor ref should not perform diamond inference In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 14:33:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.6-oracle. This pull request has now been integrated. Changeset: 8ce7bb4e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/8ce7bb4ed8903384a85b348cfbe5a89b961ba53b Stats: 32 lines in 3 files changed: 31 ins; 0 del; 1 mod 8029633: Raw inner class constructor ref should not perform diamond inference Backport-of: 6707bfbc153de193b891c1ad3d4d8d0a6ee62307 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/835 From goetz at openjdk.org Tue Nov 15 15:23:47 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 15 Nov 2022 15:23:47 GMT Subject: [jdk11u-dev] Integrated: 8296108: (tz) Update Timezone Data to 2022f In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 13:47:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.19-oracle. This pull request has now been integrated. Changeset: b7b00f7f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/b7b00f7fb4e6509becdfdb28eb1a336a7b07b315 Stats: 1362 lines in 25 files changed: 560 ins; 705 del; 97 mod 8296108: (tz) Update Timezone Data to 2022f Backport-of: 46c908b7f2d9778f4793fbf9c2261a6d41122743 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1518 From mbaesken at openjdk.org Tue Nov 15 15:35:16 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 15 Nov 2022 15:35:16 GMT Subject: [jdk11u-dev] RFR: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class Message-ID: backport of 8264666 ------------- Commit messages: - Backport 3ef9ce6c02784abe3b3b55e4d490554436bf5991 Changes: https://git.openjdk.org/jdk11u-dev/pull/1522/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1522&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8264666 Stats: 195 lines in 2 files changed: 169 ins; 15 del; 11 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1522.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1522/head:pull/1522 PR: https://git.openjdk.org/jdk11u-dev/pull/1522 From goetz at openjdk.org Tue Nov 15 15:20:58 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 15 Nov 2022 15:20:58 GMT Subject: [jdk11u-dev] Integrated: 8294307: ISO 4217 Amendment 173 Update In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 12:56:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 13, 15, 17 and 19u. This pull request has now been integrated. Changeset: e3eccbcb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/e3eccbcbc2e27921c058d43b81fb113d10be2dab Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8294307: ISO 4217 Amendment 173 Update Backport-of: 4b60ed4d08d6e4cfb26bde2533b6f06b8bf3fa25 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1514 From phh at openjdk.org Tue Nov 15 15:59:12 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 15 Nov 2022 15:59:12 GMT Subject: [jdk11u-dev] RFR: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 15:27:33 GMT, Matthias Baesken wrote: > backport of 8264666 Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1522 From shade at openjdk.org Tue Nov 15 16:17:16 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Nov 2022 16:17:16 GMT Subject: [jdk11u-dev] RFR: 8283199: Linux os::cpu_microcode_revision() stalls cold startup In-Reply-To: References: Message-ID: On Tue, 8 Nov 2022 09:57:41 GMT, Aleksey Shipilev wrote: > Any takers? :) Friendly reminder :) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1471 From mbaesken at openjdk.org Tue Nov 15 16:15:17 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 15 Nov 2022 16:15:17 GMT Subject: [jdk11u-dev] RFR: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 15:27:33 GMT, Matthias Baesken wrote: > backport of 8264666 Hi Paul, thanks for the review. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1522 From xliu at openjdk.org Tue Nov 15 17:24:18 2022 From: xliu at openjdk.org (Xin Liu) Date: Tue, 15 Nov 2022 17:24:18 GMT Subject: [jdk11u-dev] Withdrawn: 8272791: java -XX:BlockZeroingLowLimit=1 crashes after 8270947 In-Reply-To: <_AiT1jP7_vjAp-szD4MRq1TkOwnHnVKkgGQy-fQNOog=.a9fb0b04-5b32-4dde-91df-93fae8cd5014@github.com> References: <_AiT1jP7_vjAp-szD4MRq1TkOwnHnVKkgGQy-fQNOog=.a9fb0b04-5b32-4dde-91df-93fae8cd5014@github.com> Message-ID: On Fri, 4 Nov 2022 18:31:41 GMT, Xin Liu wrote: > This is a stacked PR(3/3) of https://github.com/openjdk/jdk11u-dev/pull/1502. > > This patch is one of the trailing bugfix of JDK-8270947. We can apply to jdk11u cleanly. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1504 From xliu at openjdk.org Tue Nov 15 17:25:08 2022 From: xliu at openjdk.org (Xin Liu) Date: Tue, 15 Nov 2022 17:25:08 GMT Subject: [jdk11u-dev] Withdrawn: 8270947: AArch64: C1: use zero_words to initialize all objects In-Reply-To: References: Message-ID: On Fri, 4 Nov 2022 17:59:57 GMT, Xin Liu wrote: > We would like to backport [JDK-8270947](https://bugs.openjdk.org/browse/JDK-8270947) to jdk11u. It's not only less code to maintain, but also better generated code. C1 can leverage DC ZVA in large allocations on aarch64. The secondary consideration is that openjdk11u aligns with oraclejdk11u. > > This isn't a clean backport. Small cosmetic changes are made in `MacroAssembler::zero_words(Register ptr, Register cnt)` chunk. > > There are also 3 trailing bugfixes. We will post them together as stacked PRs This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1502 From xliu at openjdk.org Tue Nov 15 17:25:15 2022 From: xliu at openjdk.org (Xin Liu) Date: Tue, 15 Nov 2022 17:25:15 GMT Subject: [jdk11u-dev] Withdrawn: 8271956: AArch64: C1 build failed after JDK-8270947 In-Reply-To: References: Message-ID: <4AIsMLzcPql_0X87G9Y0GX4lyhBHMw99bGb476oHVaE=.97cb5ef7-a99c-46c9-8c00-1245a240816b@github.com> On Mon, 7 Nov 2022 20:49:21 GMT, Xin Liu wrote: > This is a stacked PR(4/4) of https://github.com/openjdk/jdk11u-dev/pull/1502. > > This patch is one of the trailing bugfix of JDK-8270947. We can apply to jdk11u cleanly. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > > ### Integration blocker >  ?? Dependency #1504 must be integrated first > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.org/jdk11u-dev pull/1507/head:pull/1507` \ > `$ git checkout pull/1507` > > Update a local copy of the PR: \ > `$ git checkout pull/1507` \ > `$ git pull https://git.openjdk.org/jdk11u-dev pull/1507/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 1507` > > View PR using the GUI difftool: \ > `$ git pr show -t 1507` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.org/jdk11u-dev/pull/1507.diff > >
This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1507 From stuefe at openjdk.org Tue Nov 15 18:16:46 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 15 Nov 2022 18:16:46 GMT Subject: [jdk11u-dev] RFR: 8283199: Linux os::cpu_microcode_revision() stalls cold startup In-Reply-To: References: Message-ID: On Mon, 24 Oct 2022 09:32:39 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the startup time regression. > > The backport is not clean, because [JDK-8238161](https://bugs.openjdk.org/browse/JDK-8238161) is not present in JDK 11, and thus we have `fopen` instead of `os::fopen` in these hunks. I changed the code back to `fopen` to be consistent with the rest of JDK 11. > > Verified the startup time improves, using the scripts from the issue. > > > # Before > real 0m0.081s > real 0m0.081s > real 0m0.081s > > # After > real 0m0.062s > real 0m0.062s > real 0m0.062s > > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` Good. ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1471 From shade at openjdk.org Tue Nov 15 18:16:47 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Nov 2022 18:16:47 GMT Subject: [jdk11u-dev] RFR: 8283199: Linux os::cpu_microcode_revision() stalls cold startup In-Reply-To: References: Message-ID: <4eA4KpO2a0Nx_PC67-YsPpt1qqxI6rkuQMvQlFT4nBY=.e49fa219-a352-4683-9c0e-6809a54a5232@github.com> On Mon, 24 Oct 2022 09:32:39 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the startup time regression. > > The backport is not clean, because [JDK-8238161](https://bugs.openjdk.org/browse/JDK-8238161) is not present in JDK 11, and thus we have `fopen` instead of `os::fopen` in these hunks. I changed the code back to `fopen` to be consistent with the rest of JDK 11. > > Verified the startup time improves, using the scripts from the issue. > > > # Before > real 0m0.081s > real 0m0.081s > real 0m0.081s > > # After > real 0m0.062s > real 0m0.062s > real 0m0.062s > > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` Thank you, marked for approval. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1471 From shade at openjdk.org Tue Nov 15 19:27:41 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Nov 2022 19:27:41 GMT Subject: [jdk17u-dev] RFR: 8280391: NMT: Correct NMT tag on CollectedHeap Message-ID: Clean backport to improve NMT reporting. Additional testing: - [x] Linux x86_64 fastdebug `tier1` -- some unrelated failures ------------- Commit messages: - Backport 44db4794d29c6e0755a6dc0ea1346f48f918155b Changes: https://git.openjdk.org/jdk17u-dev/pull/883/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=883&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280391 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/883.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/883/head:pull/883 PR: https://git.openjdk.org/jdk17u-dev/pull/883 From clanger at openjdk.org Tue Nov 15 22:23:07 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 15 Nov 2022 22:23:07 GMT Subject: [jdk11u-dev] RFR: 8296652: Restore windows aarch64 fixpath patch that was removed in 8239708 [v4] In-Reply-To: References: Message-ID: On Wed, 9 Nov 2022 11:24:45 GMT, George Adams wrote: >> When https://bugs.openjdk.org/browse/JDK-8239708 was backported to 11u, the Windows aarch64 specific fixpath patch added in https://github.com/openjdk/jdk11u/commit/7bdb8ac7f9f9a83779427da7a6d7f5e9ae548db7#diff-cbf3a26a7e5854d626b3c7e11c8bcb3c287ed95113360aaf220108bfa018e066was missed out. This will need restoring > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > Update basic_windows.m4 This looks good. Thanks for restoring. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1510 From duke at openjdk.org Tue Nov 15 23:19:30 2022 From: duke at openjdk.org (Autumn) Date: Tue, 15 Nov 2022 23:19:30 GMT Subject: [jdk11u-dev] RFR: 8256109: Create implementation for NSAccessibilityButton protocol Message-ID: Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). ------------- Commit messages: - 8256109: Create implementation for NSAccessibilityButton protocol Changes: https://git.openjdk.org/jdk11u-dev/pull/1505/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1505&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256109 Stats: 252 lines in 5 files changed: 238 ins; 3 del; 11 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1505.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1505/head:pull/1505 PR: https://git.openjdk.org/jdk11u-dev/pull/1505 From phh at openjdk.org Tue Nov 15 23:19:31 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 15 Nov 2022 23:19:31 GMT Subject: [jdk11u-dev] RFR: 8256109: Create implementation for NSAccessibilityButton protocol In-Reply-To: References: Message-ID: On Sat, 5 Nov 2022 01:49:39 GMT, Autumn wrote: > Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). I can confirm that Autumn is an Amazon employee and therefore covered under the OCA. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1505 From manc at openjdk.org Wed Nov 16 01:34:20 2022 From: manc at openjdk.org (Man Cao) Date: Wed, 16 Nov 2022 01:34:20 GMT Subject: [jdk19u] RFR: 8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols Message-ID: Backport of https://bugs.openjdk.org/browse/JDK-8296970. ------------- Commit messages: - Backport f662a060463c2982da40307a53d59e514390f60c Changes: https://git.openjdk.org/jdk19u/pull/68/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=68&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296970 Stats: 4 lines in 2 files changed: 0 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk19u/pull/68.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/68/head:pull/68 PR: https://git.openjdk.org/jdk19u/pull/68 From dcherepanov at openjdk.org Wed Nov 16 07:57:14 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Wed, 16 Nov 2022 07:57:14 GMT Subject: [jdk15u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 13:33:28 GMT, Yuri Nesterenko wrote: > need to backport this change following tz2022f. > For 15u, we omit ldmlSupplemental.dtd change of version and adapt the list of bugs in LocaleDataTest.java Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/305 From dcherepanov at openjdk.org Wed Nov 16 07:58:19 2022 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Wed, 16 Nov 2022 07:58:19 GMT Subject: [jdk13u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 13:33:13 GMT, Yuri Nesterenko wrote: > need to backport this change following tz2022f. > As in 15u, we omit ldmlSupplemental.dtd change of version and adapt the list of bugs in LocaleDataTest.java > For 13u, we also remove es_MX.xml change: it already has restored in this fix format 'count' attribute but the number of patterns is different as it is in a newer (for 13) CLDR. Marked as reviewed by dcherepanov (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/431 From bae at openjdk.org Wed Nov 16 08:58:11 2022 From: bae at openjdk.org (Andrew Brygin) Date: Wed, 16 Nov 2022 08:58:11 GMT Subject: [jdk15u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 13:33:28 GMT, Yuri Nesterenko wrote: > need to backport this change following tz2022f. > For 15u, we omit ldmlSupplemental.dtd change of version and adapt the list of bugs in LocaleDataTest.java Marked as reviewed by bae (Reviewer). ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/305 From bae at openjdk.org Wed Nov 16 09:08:07 2022 From: bae at openjdk.org (Andrew Brygin) Date: Wed, 16 Nov 2022 09:08:07 GMT Subject: [jdk13u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 13:33:13 GMT, Yuri Nesterenko wrote: > need to backport this change following tz2022f. > As in 15u, we omit ldmlSupplemental.dtd change of version and adapt the list of bugs in LocaleDataTest.java > For 13u, we also remove es_MX.xml change: it already has restored in this fix format 'count' attribute but the number of patterns is different as it is in a newer (for 13) CLDR. Marked as reviewed by bae (Reviewer). ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/431 From yan at openjdk.org Wed Nov 16 09:19:23 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 16 Nov 2022 09:19:23 GMT Subject: [jdk15u-dev] Integrated: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 13:33:28 GMT, Yuri Nesterenko wrote: > need to backport this change following tz2022f. > For 15u, we omit ldmlSupplemental.dtd change of version and adapt the list of bugs in LocaleDataTest.java This pull request has now been integrated. Changeset: 42e0659c Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/42e0659cda75b3cc7687037bf4ceae2f4491418c Stats: 15 lines in 5 files changed: 6 ins; 6 del; 3 mod 8296715: CLDR v42 update for tzdata 2022f Reviewed-by: dcherepanov, bae Backport-of: 54c986e7d5d0b48a22b4da81c13153ce431c9f2f ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/305 From yan at openjdk.org Wed Nov 16 09:20:47 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 16 Nov 2022 09:20:47 GMT Subject: [jdk13u-dev] Integrated: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 13:33:13 GMT, Yuri Nesterenko wrote: > need to backport this change following tz2022f. > As in 15u, we omit ldmlSupplemental.dtd change of version and adapt the list of bugs in LocaleDataTest.java > For 13u, we also remove es_MX.xml change: it already has restored in this fix format 'count' attribute but the number of patterns is different as it is in a newer (for 13) CLDR. This pull request has now been integrated. Changeset: b8e815b6 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/b8e815b6fe0f4818628d8df05f398e92355e35fb Stats: 12 lines in 4 files changed: 6 ins; 3 del; 3 mod 8296715: CLDR v42 update for tzdata 2022f Reviewed-by: dcherepanov, bae Backport-of: 54c986e7d5d0b48a22b4da81c13153ce431c9f2f ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/431 From shade at openjdk.org Wed Nov 16 10:32:58 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Nov 2022 10:32:58 GMT Subject: [jdk17u-dev] RFR: 8273880: Zero: Print warnings when unsupported intrinsics are enabled Message-ID: <_4OatOZ_VLQp69CLxAdsO5n9WJPYHYcaTXLhsVQ-Ku4=.ebb43cd1-819b-45eb-95a4-d3be1be45549@github.com> Clean backport to improve Zero UX. Additional testing: - [x] Zero reproducer from the issue - [x] Linux x86_64 zero fastdebug build - [x] Linux AArch64 zero fastdebug build ------------- Commit messages: - Backport 54b456764bedb53adb7ae3c25f64d44dd8322ada Changes: https://git.openjdk.org/jdk17u-dev/pull/884/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=884&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273880 Stats: 65 lines in 1 file changed: 65 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/884.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/884/head:pull/884 PR: https://git.openjdk.org/jdk17u-dev/pull/884 From shade at openjdk.org Wed Nov 16 11:37:13 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Nov 2022 11:37:13 GMT Subject: [jdk17u-dev] RFR: 8274903: Zero: Support AsyncGetCallTrace Message-ID: Clean backport to improve Zero maintenance. Additional testing: - [x] Linux x86_64 Zero, eyeballing JMH `-prof async` results - [ ] Linux x86_64 Zero fastdebug `make bootcycle-images` ------------- Commit messages: - Backport 92aa75b72185c681757e6520d6fdc1ae4161d0c5 Changes: https://git.openjdk.org/jdk17u-dev/pull/885/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=885&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274903 Stats: 149 lines in 4 files changed: 131 ins; 6 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/885.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/885/head:pull/885 PR: https://git.openjdk.org/jdk17u-dev/pull/885 From roland at openjdk.org Wed Nov 16 12:33:13 2022 From: roland at openjdk.org (Roland Westrelin) Date: Wed, 16 Nov 2022 12:33:13 GMT Subject: [jdk11u-dev] Integrated: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces In-Reply-To: References: Message-ID: On Mon, 14 Nov 2022 16:56:35 GMT, Roland Westrelin wrote: > This is a clean backport. Was fixed in jdk 20 and backported to 17u. Low risk and reported by users on 17. This pull request has now been integrated. Changeset: 1549bb1e Author: Roland Westrelin URL: https://git.openjdk.org/jdk11u-dev/commit/1549bb1ecfe68d4e0f7b30aa055994e8ee728bca Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces Backport-of: 5977ce5adf85c2fb9b1dd62ed250f6d4f05a613c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1520 From mbaesken at openjdk.org Wed Nov 16 12:52:22 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 16 Nov 2022 12:52:22 GMT Subject: [jdk11u-dev] Integrated: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 15:27:33 GMT, Matthias Baesken wrote: > backport of 8264666 This pull request has now been integrated. Changeset: 55354dde Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/55354dde4807e4f45f87633e58455207b19c006f Stats: 195 lines in 2 files changed: 169 ins; 15 del; 11 mod 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class Reviewed-by: phh Backport-of: 3ef9ce6c02784abe3b3b55e4d490554436bf5991 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1522 From goetz at openjdk.org Wed Nov 16 13:09:19 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 16 Nov 2022 13:09:19 GMT Subject: [jdk17u-dev] RFR: 8293834: Update CLDR data following tzdata 2022c update In-Reply-To: References: Message-ID: <4fiI7Amz2jfx0Jjxw0Qp-UAl9Fq_DKXBT7jRdEhFjfM=.69cafa04-28be-46a2-a305-adf3ae69684a@github.com> On Tue, 8 Nov 2022 16:54:12 GMT, Andrew John Hughes wrote: >> Moving this here from https://github.com/openjdk/jdk17u/pull/355 as I guess this missed review before freeze. Do we need more people actively monitoring 17u during the rampdown period? >> >> This patch updates the CLDR data following the tzdata bump in JDK-8292579. >> >> This will be handled in trunk by a larger update to CLDRv42. >> >> It differs from the 19u version in that we also bring in a change from the CLDR v41 update (JDK-8265315) to use "Kyiv" rather than "Kiev" as the zone description. This change is already in 19u. >> >> The test fails with 17.0.4 (using system tzdata 2022c) as follows: >> >> ~~~ >> $ grep 'AssertionError' test.1663972846/jdk/JTwork/sun/util/resources/cldr/TimeZoneNamesTest.jtr >> java.lang.AssertionError: expected [Eastern European Standard Time] but found [Kyiv Standard Time] >> java.lang.AssertionError: expected [heure normale d\u2019Europe de l\u2019Est] but found [Kyiv (heure standard)] >> java.lang.AssertionError: expected [Osteurop\u00e4ische Normalzeit] but found [Kyiv Normalzeit] >> ~~~ >> >> and passes with the patched build. > > Ping? > >> Lgtm. > > Thanks Paul. Flagged for approval. Hi @gnu-andrew, this is ready to be pushed, isn't it? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/752 From mbaesken at openjdk.org Wed Nov 16 13:40:18 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 16 Nov 2022 13:40:18 GMT Subject: [jdk17u-dev] RFR: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: <7n-D5fSHkFswi-C-gA2TTwu6wbdsPwOpvw8odb1cqYc=.786e09d0-f65c-467d-8c65-04f8b1266837@github.com> On Wed, 2 Nov 2022 09:13:56 GMT, Matthias Baesken wrote: > backport of 8289524 it is labeled clean so I got the info from Goetz Lindenmaier that it can be integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From goetz at openjdk.org Wed Nov 16 13:42:53 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 16 Nov 2022 13:42:53 GMT Subject: [jdk11u-dev] RFR: 8029633: Raw inner class constructor ref should not perform diamond inference Message-ID: I backport this for parity with 11.0.18-oracle. ------------- Commit messages: - Backport 6707bfbc153de193b891c1ad3d4d8d0a6ee62307 Changes: https://git.openjdk.org/jdk11u-dev/pull/1523/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1523&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8029633 Stats: 32 lines in 3 files changed: 31 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1523.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1523/head:pull/1523 PR: https://git.openjdk.org/jdk11u-dev/pull/1523 From mbaesken at openjdk.org Wed Nov 16 13:43:45 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 16 Nov 2022 13:43:45 GMT Subject: [jdk17u-dev] Integrated: 8289524: Add JFR JIT restart event In-Reply-To: References: Message-ID: <5vUAGolGpLpuMyMaX4MlEPwl6x-LDPjrK8cjjEVvyHY=.9f9b2c67-e883-4134-a4c8-485c54e8c106@github.com> On Wed, 2 Nov 2022 09:13:56 GMT, Matthias Baesken wrote: > backport of 8289524 This pull request has now been integrated. Changeset: 10b7a6d4 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/10b7a6d4fe79e05db1ee3f11eb5ebc01cfc0166d Stats: 134 lines in 8 files changed: 129 ins; 5 del; 0 mod 8289524: Add JFR JIT restart event Backport-of: dfbc6919e1e233b42aede97f1323ce5529fab7cf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/853 From mbaesken at openjdk.org Wed Nov 16 13:59:26 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 16 Nov 2022 13:59:26 GMT Subject: [jdk17u-dev] RFR: 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false" Message-ID: 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false" ------------- Commit messages: - Backport 5d1ad3968416f2d1740453825445a0deb295f5de Changes: https://git.openjdk.org/jdk17u-dev/pull/886/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=886&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290839 Stats: 23 lines in 1 file changed: 18 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/886.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/886/head:pull/886 PR: https://git.openjdk.org/jdk17u-dev/pull/886 From mbaesken at openjdk.org Wed Nov 16 15:50:30 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 16 Nov 2022 15:50:30 GMT Subject: [jdk17u-dev] RFR: 8295419: JFR: Change name of jdk.JitRestart Message-ID: Another cpp file had to be modified in jdk17u-dev compared to jdk/jdk. ------------- Commit messages: - Backport ecfb6bce5a9878d7bedce47da60f96fa9146acf7 Changes: https://git.openjdk.org/jdk17u-dev/pull/888/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=888&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295419 Stats: 7 lines in 6 files changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/888.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/888/head:pull/888 PR: https://git.openjdk.org/jdk17u-dev/pull/888 From phh at openjdk.org Wed Nov 16 16:04:58 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 16 Nov 2022 16:04:58 GMT Subject: [jdk11u-dev] RFR: 8256109: Create implementation for NSAccessibilityButton protocol In-Reply-To: References: Message-ID: On Sat, 5 Nov 2022 01:49:39 GMT, Autumn wrote: > Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). The backport looks fine, but how did you test it? Also, do you intend to backport the whole sequence from JDK-8152350? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1505 From lucy at openjdk.org Wed Nov 16 16:16:10 2022 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 16 Nov 2022 16:16:10 GMT Subject: [jdk17u-dev] RFR: 8295419: JFR: Change name of jdk.JitRestart In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 15:42:17 GMT, Matthias Baesken wrote: > Another cpp file had to be modified in jdk17u-dev compared to jdk/jdk. Changes look good to me. ------------- Marked as reviewed by lucy (Committer). PR: https://git.openjdk.org/jdk17u-dev/pull/888 From phh at openjdk.org Wed Nov 16 16:23:08 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 16 Nov 2022 16:23:08 GMT Subject: [jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML In-Reply-To: References: Message-ID: On Mon, 14 Nov 2022 22:21:13 GMT, Tyler Steele wrote: > Backporting this change to jdk11. I noticed this was also requested by @jocwurs as I was working on it. > > Functionally this is a clean backport. But, there are some differences that will trip up the bots. > - Copyright years are sometimes newer in the current jdk11u. I kept the newer year. > - I merged two lists of bug ids into one--keeping all bug-ids. > - Git seems to treat `test/.../OutputPropertiesTest.java` as a new file in these changes, but not in the old ones. This wasn't a conflict, but it shows up differently for me on GitHub when I compare it to the changes in the original commit. > > Testing: OutputPropertiesTest passes. > > I'll wait for a review before requesting this in JBS. As indicated by the its @bug comment, OutputProperties.java is a file brought in by JDK-8219705, which hasn't been backported. Please backport JDK-8219705 first, revise this PR and make it dependent on that backport. There are likely also predecessor(s) for JDK-8219705, based on the LastModified update in OutputPropertiesFactory.java: Feb 2019 is updated to Mar 2019, while the 11u version has Oct 2017. ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1521 From mdoerr at openjdk.org Wed Nov 16 16:29:06 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 16 Nov 2022 16:29:06 GMT Subject: [jdk17u-dev] RFR: 8295419: JFR: Change name of jdk.JitRestart In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 15:42:17 GMT, Matthias Baesken wrote: > Another cpp file had to be modified in jdk17u-dev compared to jdk/jdk. Marked as reviewed by mdoerr (Reviewer). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/888 From duke at openjdk.org Wed Nov 16 16:31:07 2022 From: duke at openjdk.org (Autumn) Date: Wed, 16 Nov 2022 16:31:07 GMT Subject: [jdk11u-dev] RFR: 8256109: Create implementation for NSAccessibilityButton protocol In-Reply-To: References: Message-ID: On Sat, 5 Nov 2022 01:49:39 GMT, Autumn wrote: > Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). I tested it buy building a button and testing to make sure the accessibility voice features still work with my changes. I do intend to do them all. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1505 From phh at openjdk.org Wed Nov 16 16:39:15 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 16 Nov 2022 16:39:15 GMT Subject: [jdk11u-dev] RFR: 8256109: Create implementation for NSAccessibilityButton protocol In-Reply-To: References: Message-ID: <9wUqqf_Ychl5GRGbYiY3EAPpFy7IpVDnVbHgpYZ9NnU=.31db291a-a722-4627-9bab-bd701657e43b@github.com> On Sat, 5 Nov 2022 01:49:39 GMT, Autumn wrote: > Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). Thank you and lgtm. I recommend you do the backports in chronological order of commit dates. There's a conflict in this PR where the original commit includes the removal of the CommonComponentAccessibility declaration in JavaComponentAccessibility.m that isn't needed in this PR, because I suspect it wasn't backported first. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1505 From phh at openjdk.org Wed Nov 16 16:46:07 2022 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 16 Nov 2022 16:46:07 GMT Subject: [jdk11u-dev] RFR: 8256109: Create implementation for NSAccessibilityButton protocol In-Reply-To: References: Message-ID: On Sat, 5 Nov 2022 01:49:39 GMT, Autumn wrote: > Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). Tagged the JBS issue. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1505 From aivanov at openjdk.org Wed Nov 16 17:30:44 2022 From: aivanov at openjdk.org (Alexey Ivanov) Date: Wed, 16 Nov 2022 17:30:44 GMT Subject: [jdk19u] Integrated: 8296496: Overzealous check in sizecalc.h prevents large memory allocation In-Reply-To: <2vmf8VngGW0ZmmwOPmzsahbd0lIiF-hLyZcLLilf0tw=.41371fd3-251e-4260-a3eb-1b6cd685e556@github.com> References: <2vmf8VngGW0ZmmwOPmzsahbd0lIiF-hLyZcLLilf0tw=.41371fd3-251e-4260-a3eb-1b6cd685e556@github.com> Message-ID: On Mon, 14 Nov 2022 13:02:59 GMT, Alexey Ivanov wrote: > Hi all, > > This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. > > Thanks! This pull request has now been integrated. Changeset: 647450e7 Author: Alexey Ivanov URL: https://git.openjdk.org/jdk19u/commit/647450e75db972a9e049fdbdc553ed1a51dcd56a Stats: 11 lines in 1 file changed: 0 ins; 4 del; 7 mod 8296496: Overzealous check in sizecalc.h prevents large memory allocation Backport-of: 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 ------------- PR: https://git.openjdk.org/jdk19u/pull/67 From duke at openjdk.org Wed Nov 16 18:08:18 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 16 Nov 2022 18:08:18 GMT Subject: [jdk11u-dev] RFR: 8256109: Create implementation for NSAccessibilityButton protocol In-Reply-To: References: Message-ID: On Sat, 5 Nov 2022 01:49:39 GMT, Autumn Capasso wrote: > Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). > fixed I added my full name. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1505 From shade at openjdk.org Wed Nov 16 18:13:56 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Nov 2022 18:13:56 GMT Subject: [jdk17u-dev] RFR: 8280784: VM_Cleanup unnecessarily processes all thread oops Message-ID: Clean backport of performance enhancement for GCs that do concurrent thread roots (in JDK 17u those are Shenandoah and Z). On my machine, with Shenandoah running 20K threads, the safepoint cleanup time for "Cleanup" VM ops dropped from 2ms to nearly zero. A possible follow-up would be [JDK-8280817](https://bugs.openjdk.org/browse/JDK-8280817), which would extend this to other "empty" ops. Additional testing: - [x] Ad-hoc benchmarks - [x] Linux x86_64 fastdebug `tier1`, `tier2` - [x] Linux x86_64 fastdebug `tier1`, `tier2` with `-XX:+DeoptimizeALot` - [ ] Linux x86_64 fastdebug `tier1`, `tier2` with `-XX:+UseShenandoahGC` ------------- Commit messages: - Backport 8a3cca09ba427282f2712bec7298b85bbacf076b Changes: https://git.openjdk.org/jdk17u-dev/pull/889/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=889&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280784 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/889.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/889/head:pull/889 PR: https://git.openjdk.org/jdk17u-dev/pull/889 From tsteele at openjdk.org Wed Nov 16 21:40:20 2022 From: tsteele at openjdk.org (Tyler Steele) Date: Wed, 16 Nov 2022 21:40:20 GMT Subject: [jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML In-Reply-To: References: Message-ID: <7xCj0105BUaeg8E4whDtNXfm_m1qxh49zrSvB6vsVeI=.275d25a0-8cdc-43d7-934a-897db63e8c7a@github.com> On Mon, 14 Nov 2022 22:21:13 GMT, Tyler Steele wrote: > Backporting this change to jdk11. I noticed this was also requested by @jocwurs as I was working on it. > > Functionally this is a clean backport. But, there are some differences that will trip up the bots. > - Copyright years are sometimes newer in the current jdk11u. I kept the newer year. > - I merged two lists of bug ids into one--keeping all bug-ids. > - Git seems to treat `test/.../OutputPropertiesTest.java` as a new file in these changes, but not in the old ones. This wasn't a conflict, but it shows up differently for me on GitHub when I compare it to the changes in the original commit. > > Testing: OutputPropertiesTest passes. > > I'll wait for a review before requesting this in JBS. Good catch phohensee! Thanks for your comment. I will backport 8219705 and look for other possible dependencies before proceeding with this one. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1521 From mbaesken at openjdk.org Thu Nov 17 08:55:42 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 17 Nov 2022 08:55:42 GMT Subject: [jdk17u-dev] Integrated: 8295419: JFR: Change name of jdk.JitRestart In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 15:42:17 GMT, Matthias Baesken wrote: > Another cpp file had to be modified in jdk17u-dev compared to jdk/jdk. This pull request has now been integrated. Changeset: d4d4dbcd Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/d4d4dbcd36bd2d8bd480f85edf11e1990149ceab Stats: 7 lines in 6 files changed: 0 ins; 0 del; 7 mod 8295419: JFR: Change name of jdk.JitRestart Reviewed-by: lucy, mdoerr Backport-of: ecfb6bce5a9878d7bedce47da60f96fa9146acf7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/888 From shade at openjdk.org Thu Nov 17 11:23:08 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 17 Nov 2022 11:23:08 GMT Subject: [jdk17u-dev] RFR: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out Message-ID: Clean backport to improve test times. Test before: real 3m19.266s user 6m21.286s sys 0m10.274s Test after: real 0m49.397s user 1m44.700s sys 0m10.463s Testing: - [x] Affected test with Linux x86_64 fastdebug ------------- Commit messages: - Backport ff0cb98965a0b6be2f6c399e4645630c10b3466e Changes: https://git.openjdk.org/jdk17u-dev/pull/890/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=890&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279536 Stats: 18 lines in 1 file changed: 9 ins; 4 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/890.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/890/head:pull/890 PR: https://git.openjdk.org/jdk17u-dev/pull/890 From shade at openjdk.org Thu Nov 17 12:18:06 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 17 Nov 2022 12:18:06 GMT Subject: [jdk17u-dev] RFR: 8231490: Ugly racy writes to ZipUtils.defaultBuf Message-ID: Clean backport to fix a minor data race. Additional testing: - [x] Linux x86_64 fastdebug, `java/nio/zipfs`, `java/util/zip`, `java/util/jar` ------------- Commit messages: - Backport 905e3e88137d46f90de7034e9fc324e97af873a6 Changes: https://git.openjdk.org/jdk17u-dev/pull/891/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=891&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8231490 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/891.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/891/head:pull/891 PR: https://git.openjdk.org/jdk17u-dev/pull/891 From shade at openjdk.org Thu Nov 17 12:42:55 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 17 Nov 2022 12:42:55 GMT Subject: [jdk17u-dev] RFR: 8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size Message-ID: <9SOm5tviy2qbXZLxJkv2URtP9GSoSPUo0_jgL8QXaaU=.eea14eeb-0677-4d32-b06f-3ee6b91c6151@github.com> Clean backport to improve test reliability. Additional testing - [x] Linux x86_64 fastdebug, `gc/epsilon` ------------- Commit messages: - Backport 37ff7f3b66eaa74d62d6a93f2f34ec744db21834 Changes: https://git.openjdk.org/jdk17u-dev/pull/892/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=892&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8277866 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/892.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/892/head:pull/892 PR: https://git.openjdk.org/jdk17u-dev/pull/892 From sgehwolf at openjdk.org Thu Nov 17 14:13:24 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 17 Nov 2022 14:13:24 GMT Subject: [jdk11u-dev] RFR: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present Message-ID: Clean backport. Testing on cg 1 and cg 2 passes for me. ------------- Commit messages: - 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present Changes: https://git.openjdk.org/jdk11u-dev/pull/1525/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1525&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293472 Stats: 162 lines in 6 files changed: 108 ins; 27 del; 27 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1525.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1525/head:pull/1525 PR: https://git.openjdk.org/jdk11u-dev/pull/1525 From sgehwolf at openjdk.org Thu Nov 17 14:27:51 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 17 Nov 2022 14:27:51 GMT Subject: [jdk11u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts Message-ID: Clean backport. Passes tests on cg v1 and cg v2. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1525 Commit messages: - 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts Changes: https://git.openjdk.org/jdk11u-dev/pull/1526/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1526&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293540 Stats: 181 lines in 6 files changed: 143 ins; 23 del; 15 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1526.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1526/head:pull/1526 PR: https://git.openjdk.org/jdk11u-dev/pull/1526 From sgehwolf at openjdk.org Thu Nov 17 14:40:38 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 17 Nov 2022 14:40:38 GMT Subject: [jdk11u-dev] RFR: 8294740: Add cgroups keyword to TestDockerBasic.java Message-ID: Clean backport. Test only follow-up fix of #1526. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1526 Commit messages: - 8294740: Add cgroups keyword to TestDockerBasic.java Changes: https://git.openjdk.org/jdk11u-dev/pull/1527/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1527&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294740 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1527.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1527/head:pull/1527 PR: https://git.openjdk.org/jdk11u-dev/pull/1527 From shade at openjdk.org Thu Nov 17 14:52:48 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 17 Nov 2022 14:52:48 GMT Subject: [jdk17u-dev] RFR: 8278826: Print error if Shenandoah flags are empty (instead of crashing) Message-ID: Clean backport to fixes Shenandoah UX problem. Additional testing: - [x] Linux x86_64 fastdebug `hotspot_gc_shenandoah` - [x] Ad-hoc CLI tests ------------- Commit messages: - Backport 247ea71d24a251d29d9a5179e5b773df850e7261 Changes: https://git.openjdk.org/jdk17u-dev/pull/893/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=893&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278826 Stats: 50 lines in 4 files changed: 19 ins; 21 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/893.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/893/head:pull/893 PR: https://git.openjdk.org/jdk17u-dev/pull/893 From shade at openjdk.org Thu Nov 17 15:50:11 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 17 Nov 2022 15:50:11 GMT Subject: [jdk17u-dev] RFR: 8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier() Message-ID: Clean backport, provides the grounds for more clean backports. Additional testing: - [x] Linux x86_64 fastdebug, `hotspot_gc_shenandoah` ------------- Commit messages: - Backport 011958d30b275f0f6a2de097938ceeb34beb314d Changes: https://git.openjdk.org/jdk17u-dev/pull/894/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=894&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290374 Stats: 7 lines in 1 file changed: 0 ins; 5 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/894.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/894/head:pull/894 PR: https://git.openjdk.org/jdk17u-dev/pull/894 From dchuyko at openjdk.org Thu Nov 17 16:11:13 2022 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 17 Nov 2022 16:11:13 GMT Subject: [jdk17u-dev] Integrated: 8284533: Improve InterpreterCodelet data footprint In-Reply-To: <9eekhJLssjjtrBGPDVsAoqXOL0OxqD1Ts54XqJjW5Bk=.f5994415-c820-4bdf-a75b-3e04de3d34e4@github.com> References: <9eekhJLssjjtrBGPDVsAoqXOL0OxqD1Ts54XqJjW5Bk=.f5994415-c820-4bdf-a75b-3e04de3d34e4@github.com> Message-ID: On Thu, 10 Nov 2022 18:21:32 GMT, Dmitry Chuyko wrote: > Original patch does not apply because of different NOT_PRODUCT fields of InterpreterCodelet. Repeated exactly the meaningful part: moving 3 fields in a new order after the NOT_PRODUCT part. Comments and white space 'after' are just like in the original diff. > > Testing: tier1, tier2 on aarch64. This pull request has now been integrated. Changeset: 32aec436 Author: Dmitry Chuyko Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/32aec436de9b5953bb130d66188a8925244b2261 Stats: 6 lines in 1 file changed: 3 ins; 3 del; 0 mod 8284533: Improve InterpreterCodelet data footprint Reviewed-by: phh Backport-of: 61698bd137fc8ffad6a63b57b73df699712527b9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/878 From dchuyko at openjdk.org Thu Nov 17 16:29:04 2022 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Thu, 17 Nov 2022 16:29:04 GMT Subject: [jdk17u-dev] RFR: 8265263: AArch64: Combine vneg with right shift count [v5] In-Reply-To: References: Message-ID: > This is a performance improvement for AArch64. There are several differences from the original change. > > https://bugs.openjdk.org/browse/JDK-8267356 (Vector API SVE codegen support) is not in 17u, so `UseSVE == 0` parts in predicates are missing/excluded. > > https://bugs.openjdk.org/browse/JDK-8288445 (C2 compilation fails) is a subsequent bugfix already backported in 17u, so some `immI` arguments in rules became `immI_positive`. > > https://bugs.openjdk.org/browse/JDK-8277239 (SIGSEGV in vrshift_reg_maskedNode::emit) is also related to Vector API and is not in 17u, so `!n->as_ShiftV()->is_var_shift()` is replaced by `VectorNode::is_vshift_cnt(n->in(2))`. This substitution may raise doubts. > > Testing: jtreg test/hotspot/jtreg/compiler, tier1, tier2 on aarch64. > > Performance improvements in the added benchmark VectorShiftRight on Graviton 2 for default size=1024 correspond to the original review: > > > rShiftByte 16% > rShiftInt 27% > rShiftLong 16% > rShiftShort 20% > urShiftByte 0% > urShiftChar 20% > urShiftInt 27% > urShiftLong 16% Dmitry Chuyko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8265263 - Merge branch 'openjdk:master' into JDK-8265263 - Fixed m4 mismatch - No SVE checks in vsrcnt8B, vsrcnt16B - Backport 49245131e98c1c72c447536e5527acecb3311add ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/811/files - new: https://git.openjdk.org/jdk17u-dev/pull/811/files/4d87503c..2d11e1a5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=811&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=811&range=03-04 Stats: 2056 lines in 49 files changed: 1054 ins; 811 del; 191 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/811.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/811/head:pull/811 PR: https://git.openjdk.org/jdk17u-dev/pull/811 From duke at openjdk.org Thu Nov 17 17:48:37 2022 From: duke at openjdk.org (Nibedita Jena) Date: Thu, 17 Nov 2022 17:48:37 GMT Subject: [jdk19u] RFR: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Message-ID: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing ------------- Commit messages: - Backport b6ea69c06aca7f013e26596cebd039960c5b4d34 Changes: https://git.openjdk.org/jdk19u/pull/69/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=69&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296480 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/69.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/69/head:pull/69 PR: https://git.openjdk.org/jdk19u/pull/69 From goetz at openjdk.org Thu Nov 17 19:30:24 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 17 Nov 2022 19:30:24 GMT Subject: [jdk11u-dev] RFR: 8256109: Create implementation for NSAccessibilityButton protocol In-Reply-To: References: Message-ID: On Sat, 5 Nov 2022 01:49:39 GMT, Autumn Capasso wrote: > Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). Hi, I appreciate a lot that you are addressing this. As Paul said, it makes sense to work them in the order they were pushed originally to avoid unnecessary conflicts. There are also quite a lot of related follow up fixes and test fixes. This filter https://bugs.openjdk.org/issues/?filter=43450 gives you a list of the changes brought to 11.0.17-oracle and 11.0.18-oracle which are not yet in open jdk11u. If you work this list bottom up, you get the order they were pushed to 11-oracle. This is a good starting point, the one I would use. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1505 From andrew at openjdk.org Thu Nov 17 19:33:31 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Nov 2022 19:33:31 GMT Subject: [jdk17u-dev] RFR: 8293834: Update CLDR data following tzdata 2022c update In-Reply-To: References: Message-ID: On Wed, 28 Sep 2022 15:49:43 GMT, Andrew John Hughes wrote: > Moving this here from https://github.com/openjdk/jdk17u/pull/355 as I guess this missed review before freeze. Do we need more people actively monitoring 17u during the rampdown period? > > This patch updates the CLDR data following the tzdata bump in JDK-8292579. > > This will be handled in trunk by a larger update to CLDRv42. > > It differs from the 19u version in that we also bring in a change from the CLDR v41 update (JDK-8265315) to use "Kyiv" rather than "Kiev" as the zone description. This change is already in 19u. > > The test fails with 17.0.4 (using system tzdata 2022c) as follows: > > ~~~ > $ grep 'AssertionError' test.1663972846/jdk/JTwork/sun/util/resources/cldr/TimeZoneNamesTest.jtr > java.lang.AssertionError: expected [Eastern European Standard Time] but found [Kyiv Standard Time] > java.lang.AssertionError: expected [heure normale d\u2019Europe de l\u2019Est] but found [Kyiv (heure standard)] > java.lang.AssertionError: expected [Osteurop\u00e4ische Normalzeit] but found [Kyiv Normalzeit] > ~~~ > > and passes with the patched build. Now I see `jdk17u-fix-yes`, yes :) ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/752 From andrew at openjdk.org Thu Nov 17 19:37:32 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Nov 2022 19:37:32 GMT Subject: [jdk17u-dev] Integrated: 8293834: Update CLDR data following tzdata 2022c update In-Reply-To: References: Message-ID: On Wed, 28 Sep 2022 15:49:43 GMT, Andrew John Hughes wrote: > Moving this here from https://github.com/openjdk/jdk17u/pull/355 as I guess this missed review before freeze. Do we need more people actively monitoring 17u during the rampdown period? > > This patch updates the CLDR data following the tzdata bump in JDK-8292579. > > This will be handled in trunk by a larger update to CLDRv42. > > It differs from the 19u version in that we also bring in a change from the CLDR v41 update (JDK-8265315) to use "Kyiv" rather than "Kiev" as the zone description. This change is already in 19u. > > The test fails with 17.0.4 (using system tzdata 2022c) as follows: > > ~~~ > $ grep 'AssertionError' test.1663972846/jdk/JTwork/sun/util/resources/cldr/TimeZoneNamesTest.jtr > java.lang.AssertionError: expected [Eastern European Standard Time] but found [Kyiv Standard Time] > java.lang.AssertionError: expected [heure normale d\u2019Europe de l\u2019Est] but found [Kyiv (heure standard)] > java.lang.AssertionError: expected [Osteurop\u00e4ische Normalzeit] but found [Kyiv Normalzeit] > ~~~ > > and passes with the patched build. This pull request has now been integrated. Changeset: 52103da0 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk17u-dev/commit/52103da08c931f1a4599fa191d8f1cc6ca74d9bd Stats: 20 lines in 2 files changed: 18 ins; 0 del; 2 mod 8293834: Update CLDR data following tzdata 2022c update Reviewed-by: phh Backport-of: e10231248fc100f9dfa08468ac897f60b843857f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/752 From duke at openjdk.org Thu Nov 17 19:47:35 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 17 Nov 2022 19:47:35 GMT Subject: [jdk11u-dev] RFR: 8256109: Create implementation for NSAccessibilityButton protocol In-Reply-To: References: Message-ID: <1nfdzDtvsOBo4JKruq2wEVneIuZzQ9tIqnhYfibD-2I=.ff27483c-d47a-4c73-b63b-9f34e1823a72@github.com> On Sat, 5 Nov 2022 01:49:39 GMT, Autumn Capasso wrote: > Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). Thank you so much I will follow that advice. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1505 From duke at openjdk.org Thu Nov 17 20:15:43 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 17 Nov 2022 20:15:43 GMT Subject: [jdk11u-dev] Integrated: 8256109: Create implementation for NSAccessibilityButton protocol In-Reply-To: References: Message-ID: On Sat, 5 Nov 2022 01:49:39 GMT, Autumn Capasso wrote: > Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). This pull request has now been integrated. Changeset: 50437846 Author: Autumn Capasso Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/50437846bec39b40c4c279eec395b7fe6d30d136 Stats: 252 lines in 5 files changed: 238 ins; 3 del; 11 mod 8256109: Create implementation for NSAccessibilityButton protocol Reviewed-by: phh Backport-of: ae9187d757b6ed585d85c6e66105ca20bebe7bc7 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1505 From duke at openjdk.org Thu Nov 17 20:21:40 2022 From: duke at openjdk.org (Autumn Capasso) Date: Thu, 17 Nov 2022 20:21:40 GMT Subject: [jdk11u-dev] RFR: 8256109: Create implementation for NSAccessibilityButton protocol In-Reply-To: References: Message-ID: On Sat, 5 Nov 2022 01:49:39 GMT, Autumn Capasso wrote: > Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). @GoeLin Hi, The link you provided is marked as private so cannot accesses the list. Could you provide a list that is accessible so I can start on those backports. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1505 From clanger at openjdk.org Thu Nov 17 22:14:44 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 17 Nov 2022 22:14:44 GMT Subject: [jdk11u-dev] RFR: 8296652: Restore windows aarch64 fixpath patch that was removed in 8239708 [v4] In-Reply-To: References: Message-ID: On Wed, 9 Nov 2022 11:24:45 GMT, George Adams wrote: >> When https://bugs.openjdk.org/browse/JDK-8239708 was backported to 11u, the Windows aarch64 specific fixpath patch added in https://github.com/openjdk/jdk11u/commit/7bdb8ac7f9f9a83779427da7a6d7f5e9ae548db7#diff-cbf3a26a7e5854d626b3c7e11c8bcb3c287ed95113360aaf220108bfa018e066was missed out. This will need restoring > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > Update basic_windows.m4 @erikj79, any idea why @gdams is not recognized as committer here? As per the census he should be. Anyway... ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1510 From duke at openjdk.org Thu Nov 17 22:16:34 2022 From: duke at openjdk.org (George Adams) Date: Thu, 17 Nov 2022 22:16:34 GMT Subject: [jdk11u-dev] Integrated: 8296652: Restore windows aarch64 fixpath patch that was removed in 8239708 In-Reply-To: References: Message-ID: On Wed, 9 Nov 2022 10:17:53 GMT, George Adams wrote: > When https://bugs.openjdk.org/browse/JDK-8239708 was backported to 11u, the Windows aarch64 specific fixpath patch added in https://github.com/openjdk/jdk11u/commit/7bdb8ac7f9f9a83779427da7a6d7f5e9ae548db7#diff-cbf3a26a7e5854d626b3c7e11c8bcb3c287ed95113360aaf220108bfa018e066was missed out. This will need restoring This pull request has now been integrated. Changeset: 1f173716 Author: George Adams Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/1f173716812a570fe6b6eaf685ec90f66a840792 Stats: 54 lines in 1 file changed: 36 ins; 18 del; 0 mod 8296652: Restore windows aarch64 fixpath patch that was removed in 8239708 Reviewed-by: clanger ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1510 From clanger at openjdk.org Thu Nov 17 22:18:06 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 17 Nov 2022 22:18:06 GMT Subject: [jdk19u] Integrated: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect In-Reply-To: References: Message-ID: On Fri, 11 Nov 2022 23:25:00 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8296733](https://bugs.openjdk.org/browse/JDK-8296733), commit [ced88a2f](https://github.com/openjdk/jdk/commit/ced88a2fd9a35e0e027661ef1f3c5ea3a5fff9e0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Erik Gahlin on 11 Nov 2022 and was reviewed by Christoph Langer and Markus Gr?nlund. > > Thanks! This pull request has now been integrated. Changeset: 55a239c7 Author: Christoph Langer URL: https://git.openjdk.org/jdk19u/commit/55a239c7a61e1692eb7a49cd4430d945a4623606 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect Backport-of: ced88a2fd9a35e0e027661ef1f3c5ea3a5fff9e0 ------------- PR: https://git.openjdk.org/jdk19u/pull/65 From clanger at openjdk.org Thu Nov 17 22:43:40 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 17 Nov 2022 22:43:40 GMT Subject: [jdk17u-dev] RFR: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect Message-ID: Hi all, This pull request contains a backport of commit ced88a2f from the openjdk/jdk repository. The commit being backported was authored by Erik Gahlin on 11 Nov 2022 and was reviewed by Christoph Langer and Markus Gr?nlund. Thanks! ------------- Commit messages: - Backport ced88a2fd9a35e0e027661ef1f3c5ea3a5fff9e0 Changes: https://git.openjdk.org/jdk17u-dev/pull/895/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=895&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296733 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/895.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/895/head:pull/895 PR: https://git.openjdk.org/jdk17u-dev/pull/895 From xlinzheng at openjdk.org Fri Nov 18 04:22:36 2022 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Fri, 18 Nov 2022 04:22:36 GMT Subject: [jdk19u] RFR: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic Message-ID: <03UdGwZhCke-pBE5x8_KIfFJFx6AWsaW6zBj4rKGiKs=.c150df14-bab1-4c58-8904-461d5653d400@github.com> Clean backport from 20 for RISC-V backend: https://github.com/openjdk/jdk/commit/1fdbb1ba337b07dbcfb3c28c4fdeba74fee113dc Tier1~2 testing passed, including the added jtreg test in this PR. ------------- Commit messages: - 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic Changes: https://git.openjdk.org/jdk19u/pull/70/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=70&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295926 Stats: 100 lines in 2 files changed: 95 ins; 4 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/70.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/70/head:pull/70 PR: https://git.openjdk.org/jdk19u/pull/70 From xlinzheng at openjdk.org Fri Nov 18 04:36:03 2022 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Fri, 18 Nov 2022 04:36:03 GMT Subject: [jdk19u] RFR: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null Message-ID: A backport from 20 for RISC-V backend: https://github.com/openjdk/jdk/commit/93fed9b251c21f20b68ddc4e179d6595275dbcd2 Only affects RISC-V backend, so impact is low. The `access_store_at`'s signature changed so when cherry-picked from JDK20 I met one minor conflict (Not sure if it would be considered clean then). Tier1~2 testing passed. ------------- Commit messages: - 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null Changes: https://git.openjdk.org/jdk19u/pull/71/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=71&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296448 Stats: 52 lines in 8 files changed: 7 ins; 6 del; 39 mod Patch: https://git.openjdk.org/jdk19u/pull/71.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/71/head:pull/71 PR: https://git.openjdk.org/jdk19u/pull/71 From xlinzheng at openjdk.org Fri Nov 18 04:36:03 2022 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Fri, 18 Nov 2022 04:36:03 GMT Subject: [jdk19u] RFR: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 04:29:32 GMT, Xiaolin Zheng wrote: > A backport from 20 for RISC-V backend: https://github.com/openjdk/jdk/commit/93fed9b251c21f20b68ddc4e179d6595275dbcd2 > > Only affects RISC-V backend, so impact is low. > > The `access_store_at`'s signature changed so when cherry-picked from JDK20 I met one minor conflict (Not sure if it would be considered clean then). > > Tier1~2 testing passed. Oh, clean. Very Advanced. ------------- PR: https://git.openjdk.org/jdk19u/pull/71 From duke at openjdk.org Fri Nov 18 04:52:26 2022 From: duke at openjdk.org (Nibedita Jena) Date: Fri, 18 Nov 2022 04:52:26 GMT Subject: [jdk19u] RFR: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing In-Reply-To: References: Message-ID: <8qx6t-Pa4orwoeVv8kQF315tsOGJle35esWmaqxamnk=.964f6308-0a53-4342-8c25-507ec312c6cc@github.com> On Wed, 16 Nov 2022 14:53:06 GMT, Nibedita Jena wrote: > 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing https://mach5.us.oracle.com/mdash/jobs/jnibedit-jdk19u-cpu-20221116-1017-38572195/results?search=*java%2Fsecurity%2Fcert%2Fpkix%2FpolicyChanges%2FTestPolicy.java* ------------- PR: https://git.openjdk.org/jdk19u/pull/69 From vrudomet at openjdk.org Fri Nov 18 06:38:53 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 06:38:53 GMT Subject: [jdk19u] RFR: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Message-ID: [JDK-8286624](https://bugs.openjdk.org/browse/JDK-8286624) Regression Test CoordinateTruncationBug.java fails on OL8.3 (cherry picked from commit c71d87e54ca0c0173583bed978e06c7faa0fa283) Clean backport. New test, low risk. Test pass on manual run (mac, linux, x64 aarch64) using make run-test TEST="test/jdk/sun/java2d/SunGraphics2D/CoordinateTruncationBug.java" ------------- Commit messages: - 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Changes: https://git.openjdk.org/jdk19u/pull/72/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=72&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286624 Stats: 271 lines in 1 file changed: 271 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/72.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/72/head:pull/72 PR: https://git.openjdk.org/jdk19u/pull/72 From vrudomet at openjdk.org Fri Nov 18 06:39:36 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 06:39:36 GMT Subject: [jdk11u-dev] RFR: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Message-ID: [JDK-8286624](https://bugs.openjdk.org/browse/JDK-8286624) Regression Test CoordinateTruncationBug.java fails on OL8.3 (cherry picked from commit c71d87e54ca0c0173583bed978e06c7faa0fa283) Clean backport. New test, low risk. Test pass on manual run (mac, linux, x64 aarch64) using make run-test TEST="test/jdk/sun/java2d/SunGraphics2D/CoordinateTruncationBug.java" ------------- Commit messages: - 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Changes: https://git.openjdk.org/jdk11u-dev/pull/1528/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1528&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286624 Stats: 271 lines in 1 file changed: 271 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1528.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1528/head:pull/1528 PR: https://git.openjdk.org/jdk11u-dev/pull/1528 From vrudomet at openjdk.org Fri Nov 18 06:40:11 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 06:40:11 GMT Subject: [jdk17u-dev] RFR: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Message-ID: [JDK-8286624](https://bugs.openjdk.org/browse/JDK-8286624) Regression Test CoordinateTruncationBug.java fails on OL8.3 (cherry picked from commit c71d87e54ca0c0173583bed978e06c7faa0fa283) Clean backport. New test, low risk. Test pass on manual run (mac, linux, x64 aarch64) using make run-test TEST="test/jdk/sun/java2d/SunGraphics2D/CoordinateTruncationBug.java" ------------- Commit messages: - 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Changes: https://git.openjdk.org/jdk17u-dev/pull/896/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=896&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286624 Stats: 271 lines in 1 file changed: 271 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/896.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/896/head:pull/896 PR: https://git.openjdk.org/jdk17u-dev/pull/896 From vrudomet at openjdk.org Fri Nov 18 06:43:48 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 06:43:48 GMT Subject: [jdk17u-dev] RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM Message-ID: [JDK-8296083](https://bugs.openjdk.org/browse/JDK-8296083) javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM Clean backport. Test update, low risk. Test passed during manual run (run in a 50 loop). ------------- Commit messages: - Backport dd9aa7272d04b49dd5cbf3ff9f9091c7d63d68ae Changes: https://git.openjdk.org/jdk17u-dev/pull/897/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=897&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296083 Stats: 25 lines in 1 file changed: 21 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/897.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/897/head:pull/897 PR: https://git.openjdk.org/jdk17u-dev/pull/897 From vrudomet at openjdk.org Fri Nov 18 06:47:50 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 06:47:50 GMT Subject: [jdk19u] RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM Message-ID: [JDK-8296083](https://bugs.openjdk.org/browse/JDK-8296083) javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM Clean test backport, had to merge ProblemList.txt (test is missing in ProblemList.txt). Test update test, low risk. Test passed during manual run (run in a 50 loop). ------------- Commit messages: - Backport dd9aa7272d04b49dd5cbf3ff9f9091c7d63d68ae Changes: https://git.openjdk.org/jdk19u/pull/73/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=73&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296083 Stats: 25 lines in 1 file changed: 21 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk19u/pull/73.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/73/head:pull/73 PR: https://git.openjdk.org/jdk19u/pull/73 From vrudomet at openjdk.org Fri Nov 18 06:57:07 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 06:57:07 GMT Subject: [jdk11u-dev] RFR: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Message-ID: Backport for [JDK-8022403](https://bugs.openjdk.org/browse/JDK-8022403) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Cherry-picked from https://github.com/openjdk/jdk/commit/65f7de252366e30ba18a22c107fc301c0fdc9378 Clean test backport, had to merge ProblemList.txt. Test update, low risk. Test passed during manual run using cmd: make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java ------------- Commit messages: - Backport 65f7de252366e30ba18a22c107fc301c0fdc9378 Changes: https://git.openjdk.org/jdk11u-dev/pull/1529/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1529&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8022403 Stats: 160 lines in 2 files changed: 49 ins; 34 del; 77 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1529.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1529/head:pull/1529 PR: https://git.openjdk.org/jdk11u-dev/pull/1529 From vrudomet at openjdk.org Fri Nov 18 06:58:43 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 06:58:43 GMT Subject: [jdk17u-dev] RFR: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Message-ID: Backport for [JDK-8022403](https://bugs.openjdk.org/browse/JDK-8022403) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Cherry-picked from https://github.com/openjdk/jdk/commit/65f7de252366e30ba18a22c107fc301c0fdc9378 Clean test backport, had to merge ProblemList.txt. Test update, low risk. Test passed during manual run using cmd: make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java ------------- Commit messages: - Backport 65f7de252366e30ba18a22c107fc301c0fdc9378 Changes: https://git.openjdk.org/jdk17u-dev/pull/898/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=898&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8022403 Stats: 159 lines in 2 files changed: 49 ins; 34 del; 76 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/898.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/898/head:pull/898 PR: https://git.openjdk.org/jdk17u-dev/pull/898 From vrudomet at openjdk.org Fri Nov 18 07:00:07 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 07:00:07 GMT Subject: [jdk11u-dev] RFR: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails [v2] In-Reply-To: References: Message-ID: > Backport for [JDK-8022403](https://bugs.openjdk.org/browse/JDK-8022403) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails > > Cherry-picked from https://github.com/openjdk/jdk/commit/65f7de252366e30ba18a22c107fc301c0fdc9378 > > Clean test backport, had to merge ProblemList.txt. > Test update, low risk. > Test passed during manual run using cmd: > make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Victor Rudometov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 65f7de252366e30ba18a22c107fc301c0fdc9378 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1529/files - new: https://git.openjdk.org/jdk11u-dev/pull/1529/files/46f3e8d6..57925c63 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1529&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1529&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1529.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1529/head:pull/1529 PR: https://git.openjdk.org/jdk11u-dev/pull/1529 From mbaesken at openjdk.org Fri Nov 18 08:37:18 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 18 Nov 2022 08:37:18 GMT Subject: [jdk17u-dev] RFR: 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false" Message-ID: backport of 8290839 ------------- Commit messages: - Merge after rename JITRestart came in - Backport 5d1ad3968416f2d1740453825445a0deb295f5de Changes: https://git.openjdk.org/jdk17u-dev/pull/899/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=899&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290839 Stats: 23 lines in 1 file changed: 18 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/899.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/899/head:pull/899 PR: https://git.openjdk.org/jdk17u-dev/pull/899 From goetz at openjdk.org Fri Nov 18 09:14:27 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 18 Nov 2022 09:14:27 GMT Subject: [jdk17u-dev] RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 06:37:00 GMT, Victor Rudometov wrote: > Backport for [JDK-8296083](https://bugs.openjdk.org/browse/JDK-8296083) javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM > > Original commit https://github.com/openjdk/jdk/commit/dd9aa7272d04b49dd5cbf3ff9f9091c7d63d68ae > > Clean backport. > Test update, low risk. > Test passed during manual run (run in a 50 loop). LGTM You may mark changes that only needed a resolve in the ProblemList as /clean. ------------- Marked as reviewed by goetz (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/897 From goetz at openjdk.org Fri Nov 18 09:25:07 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 18 Nov 2022 09:25:07 GMT Subject: [jdk11u-dev] Integrated: 8029633: Raw inner class constructor ref should not perform diamond inference In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 13:31:58 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.18-oracle. This pull request has now been integrated. Changeset: 4ee685a9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/4ee685a92afdd80b2cdf8ae710d41733f5c330f4 Stats: 32 lines in 3 files changed: 31 ins; 0 del; 1 mod 8029633: Raw inner class constructor ref should not perform diamond inference Backport-of: 6707bfbc153de193b891c1ad3d4d8d0a6ee62307 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1523 From coffeys at openjdk.org Fri Nov 18 09:53:19 2022 From: coffeys at openjdk.org (Sean Coffey) Date: Fri, 18 Nov 2022 09:53:19 GMT Subject: [jdk19u] RFR: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 14:53:06 GMT, Nibedita Jena wrote: > 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing LGTM ------------- Marked as reviewed by coffeys (Reviewer). PR: https://git.openjdk.org/jdk19u/pull/69 From duke at openjdk.org Fri Nov 18 10:01:30 2022 From: duke at openjdk.org (Nibedita Jena) Date: Fri, 18 Nov 2022 10:01:30 GMT Subject: [jdk19u] Integrated: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing In-Reply-To: References: Message-ID: <8dJgiHSiAwdKVIoM0JvpImmnPG3kU19Pud2LEtzvN5M=.79e13c5d-f460-4a18-8e76-8a7a54ccdd1d@github.com> On Wed, 16 Nov 2022 14:53:06 GMT, Nibedita Jena wrote: > 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing This pull request has now been integrated. Changeset: e8fd24dd Author: nibjen Committer: Sean Coffey URL: https://git.openjdk.org/jdk19u/commit/e8fd24dd6360e19efca4ec012c1f59fc6fddc324 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Reviewed-by: coffeys Backport-of: b6ea69c06aca7f013e26596cebd039960c5b4d34 ------------- PR: https://git.openjdk.org/jdk19u/pull/69 From duke at openjdk.org Fri Nov 18 10:02:12 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 10:02:12 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v10] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - add toolchain changes - additional improvements - additional fixes - fixes - Backport d29c78da19ba78214efe9e7856cde30fdd9ba8ab ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1278/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=09 Stats: 4128 lines in 43 files changed: 1914 ins; 1876 del; 338 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From duke at openjdk.org Fri Nov 18 10:08:55 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 10:08:55 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v11] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: add toolchain changes ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/2c4fdab7..f4ba8764 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=10 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=09-10 Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From mbaesken at openjdk.org Fri Nov 18 10:14:59 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 18 Nov 2022 10:14:59 GMT Subject: [jdk17u-dev] Integrated: 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false" In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 08:25:32 GMT, Matthias Baesken wrote: > backport of 8290839 This pull request has now been integrated. Changeset: 1c13d7ef Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/1c13d7ef8548d896a8b65dbf258c778b96cbea21 Stats: 23 lines in 1 file changed: 18 ins; 0 del; 5 mod 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false" Backport-of: 5d1ad3968416f2d1740453825445a0deb295f5de ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/899 From sgehwolf at openjdk.org Fri Nov 18 10:58:31 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 18 Nov 2022 10:58:31 GMT Subject: [jdk11u-dev] Integrated: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 14:02:06 GMT, Severin Gehwolf wrote: > Clean backport. Testing on cg 1 and cg 2 passes for me. This pull request has now been integrated. Changeset: 7706fa81 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/7706fa81f5771446999d454d89b37dcafcefb9d4 Stats: 162 lines in 6 files changed: 108 ins; 27 del; 27 mod 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present Backport-of: 8f3bbe950fb5a3d9f6cae122209df01df0f342f0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1525 From sgehwolf at openjdk.org Fri Nov 18 11:06:16 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 18 Nov 2022 11:06:16 GMT Subject: [jdk11u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v2] In-Reply-To: References: Message-ID: > Clean backport. Passes tests on cg v1 and cg v2. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1526/files - new: https://git.openjdk.org/jdk11u-dev/pull/1526/files/ced2960a..ced2960a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1526&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1526&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1526.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1526/head:pull/1526 PR: https://git.openjdk.org/jdk11u-dev/pull/1526 From duke at openjdk.org Fri Nov 18 11:12:45 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 11:12:45 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v12] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has updated the pull request incrementally with one additional commit since the last revision: fix pathlist ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/f4ba8764..6810d0f5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=11 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=10-11 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From sgehwolf at openjdk.org Fri Nov 18 11:13:52 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 18 Nov 2022 11:13:52 GMT Subject: [jdk11u-dev] RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v3] In-Reply-To: References: Message-ID: > Clean backport. Passes tests on cg v1 and cg v2. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts Backport-of: 6d83482a6b5f1898514fd450d8143dbfef57e362 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1526/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1526&range=02 Stats: 181 lines in 6 files changed: 143 ins; 23 del; 15 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1526.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1526/head:pull/1526 PR: https://git.openjdk.org/jdk11u-dev/pull/1526 From sgehwolf at openjdk.org Fri Nov 18 11:19:57 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 18 Nov 2022 11:19:57 GMT Subject: [jdk11u-dev] RFR: 8294740: Add cgroups keyword to TestDockerBasic.java [v2] In-Reply-To: References: Message-ID: > Clean backport. Test only follow-up fix of #1526. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1527/files - new: https://git.openjdk.org/jdk11u-dev/pull/1527/files/22ee6541..22ee6541 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1527&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1527&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1527.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1527/head:pull/1527 PR: https://git.openjdk.org/jdk11u-dev/pull/1527 From duke at openjdk.org Fri Nov 18 12:03:02 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 12:03:02 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v13] In-Reply-To: References: Message-ID: <2Nni4zQMT3-apWXgRZlZHaGsT6WEiuF3cfGWlMus8yM=.4f27e315-a7a3-4b31-ac44-981cf8695dfe@github.com> > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has updated the pull request incrementally with one additional commit since the last revision: fix VSVARSFILES ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/6810d0f5..9478fe9a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=12 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=11-12 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From duke at openjdk.org Fri Nov 18 12:59:53 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 12:59:53 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v14] In-Reply-To: References: Message-ID: <4uctuJQ5pS7slp9oDGp3kJX751fBcpn5GprJMoo_kWQ=.b9b0ed6c-ab26-4297-8948-89b2fb8e7ba0@github.com> > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains three new commits since the last revision: - try this - Backport 764111ff831096729eb1bcc69a54d92fde67b044 - Backport d29c78da19ba78214efe9e7856cde30fdd9ba8ab ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/9478fe9a..779144fe Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=13 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=12-13 Stats: 8 lines in 2 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From duke at openjdk.org Fri Nov 18 13:09:00 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 13:09:00 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v15] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains two commits: - Backport 764111ff831096729eb1bcc69a54d92fde67b044 - Backport d29c78da19ba78214efe9e7856cde30fdd9ba8ab ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/779144fe..d09b1181 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=14 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=13-14 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From sgehwolf at openjdk.org Fri Nov 18 13:10:44 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 18 Nov 2022 13:10:44 GMT Subject: [jdk11u-dev] Integrated: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 14:19:13 GMT, Severin Gehwolf wrote: > Clean backport. Passes tests on cg v1 and cg v2. This pull request has now been integrated. Changeset: 9eac68b4 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/9eac68b4cc71c45d3508b95d8c0f5bb0a428b119 Stats: 181 lines in 6 files changed: 143 ins; 23 del; 15 mod 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts Backport-of: 6d83482a6b5f1898514fd450d8143dbfef57e362 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1526 From duke at openjdk.org Fri Nov 18 13:15:52 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 13:15:52 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v16] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has updated the pull request incrementally with one additional commit since the last revision: win fixpath for makefile ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/d09b1181..ad765190 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=15 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=14-15 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From mbaesken at openjdk.org Fri Nov 18 13:32:09 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 18 Nov 2022 13:32:09 GMT Subject: [jdk17u-dev] RFR: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests Message-ID: <-xmYMDEGeHpfc4NzaO3LqMD500G0s_M7dhGZMmzkmX8=.fa9415bc-2e4e-405f-9d91-fc9f2702bf7f@github.com> 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests ------------- Commit messages: - Backport d5d34241e21305379f1858556f225e7645cd294e Changes: https://git.openjdk.org/jdk17u-dev/pull/900/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=900&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295405 Stats: 24 lines in 7 files changed: 8 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/900.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/900/head:pull/900 PR: https://git.openjdk.org/jdk17u-dev/pull/900 From duke at openjdk.org Fri Nov 18 13:34:51 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 13:34:51 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v17] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: win fixpath for makefile ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/ad765190..48aed8d9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=16 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=15-16 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From sgehwolf at openjdk.org Fri Nov 18 13:36:39 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 18 Nov 2022 13:36:39 GMT Subject: [jdk11u-dev] RFR: 8294740: Add cgroups keyword to TestDockerBasic.java [v3] In-Reply-To: References: Message-ID: > Clean backport. Test only follow-up fix of #1526. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8294740: Add cgroups keyword to TestDockerBasic.java Backport-of: ae79af2ad67b51a7608f4c9060421dd175cabf3f ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1527/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1527&range=02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1527.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1527/head:pull/1527 PR: https://git.openjdk.org/jdk11u-dev/pull/1527 From duke at openjdk.org Fri Nov 18 13:37:50 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 13:37:50 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v18] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: win fixpath for makefile ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/48aed8d9..17ab7ab2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=17 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=16-17 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From sgehwolf at openjdk.org Fri Nov 18 13:47:01 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 18 Nov 2022 13:47:01 GMT Subject: [jdk11u-dev] Integrated: 8294740: Add cgroups keyword to TestDockerBasic.java In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 14:33:34 GMT, Severin Gehwolf wrote: > Clean backport. Test only follow-up fix of #1526. This pull request has now been integrated. Changeset: 7e6c47dd Author: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/7e6c47dd9ba12f2cc9cd3e0c0ae3ca6ab6856e03 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8294740: Add cgroups keyword to TestDockerBasic.java Backport-of: ae79af2ad67b51a7608f4c9060421dd175cabf3f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1527 From duke at openjdk.org Fri Nov 18 15:46:56 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 15:46:56 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v19] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: win fixpath for makefile ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/17ab7ab2..45ae79c0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=18 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=17-18 Stats: 5 lines in 2 files changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From duke at openjdk.org Fri Nov 18 15:55:55 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 15:55:55 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v20] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: win fixpath for makefile ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/45ae79c0..be69bd4f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=19 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=18-19 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From duke at openjdk.org Fri Nov 18 15:58:56 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 15:58:56 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v21] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: win fixpath for makefile ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/be69bd4f..ba8fa0fd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=20 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=19-20 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From duke at openjdk.org Fri Nov 18 16:05:24 2022 From: duke at openjdk.org (George Adams) Date: Fri, 18 Nov 2022 16:05:24 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v22] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: win fixpath for makefile ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/ba8fa0fd..5dcdbec4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=21 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=20-21 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From vrudomet at openjdk.org Fri Nov 18 17:45:35 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 17:45:35 GMT Subject: [jdk17u-dev] RFR: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 06:51:10 GMT, Victor Rudometov wrote: > Backport for [JDK-8022403](https://bugs.openjdk.org/browse/JDK-8022403) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails > > Cherry-picked from https://github.com/openjdk/jdk/commit/65f7de252366e30ba18a22c107fc301c0fdc9378 > > Clean test backport, had to merge ProblemList.txt. > Test update, low risk. > Test passed during manual run using cmd: > make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Linux x86 failure in jtreg:test/hotspot/jtreg:tier1_gc, the test/hotspot/jtreg/gc/stringdedup/TestStringDeduplicationTools.java in particular is not related to the test update in this pr ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/898 From vrudomet at openjdk.org Fri Nov 18 18:51:49 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 18:51:49 GMT Subject: [jdk17u-dev] RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 06:37:00 GMT, Victor Rudometov wrote: > Backport for [JDK-8296083](https://bugs.openjdk.org/browse/JDK-8296083) javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM > > Original commit https://github.com/openjdk/jdk/commit/dd9aa7272d04b49dd5cbf3ff9f9091c7d63d68ae > > Clean backport. > Test update, low risk. > Test passed during manual run (run in a 50 loop). Thank you. Unfortunately I do not have enough privileges to use /clean, I've tried it some time ago on a different backport. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/897 From vrudomet at openjdk.org Fri Nov 18 19:29:15 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 19:29:15 GMT Subject: [jdk17u-dev] Integrated: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 06:37:00 GMT, Victor Rudometov wrote: > Backport for [JDK-8296083](https://bugs.openjdk.org/browse/JDK-8296083) javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM > > Original commit https://github.com/openjdk/jdk/commit/dd9aa7272d04b49dd5cbf3ff9f9091c7d63d68ae > > Clean backport. > Test update, low risk. > Test passed during manual run (run in a 50 loop). This pull request has now been integrated. Changeset: 728dc4de Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/728dc4de173f2bb1e06b3b3574cb430621e2969b Stats: 25 lines in 1 file changed: 21 ins; 1 del; 3 mod 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM Reviewed-by: goetz Backport-of: dd9aa7272d04b49dd5cbf3ff9f9091c7d63d68ae ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/897 From vrudomet at openjdk.org Fri Nov 18 20:17:12 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 20:17:12 GMT Subject: [jdk19u] Integrated: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 06:37:08 GMT, Victor Rudometov wrote: > [JDK-8296083](https://bugs.openjdk.org/browse/JDK-8296083) javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM > > Clean test backport, had to merge ProblemList.txt (test is missing in ProblemList.txt). > Test update test, low risk. > Test passed during manual run (run in a 50 loop). This pull request has now been integrated. Changeset: c68057c7 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk19u/commit/c68057c7437d054b0930312b0c35cde4daa8abb6 Stats: 25 lines in 1 file changed: 21 ins; 1 del; 3 mod 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM Backport-of: dd9aa7272d04b49dd5cbf3ff9f9091c7d63d68ae ------------- PR: https://git.openjdk.org/jdk19u/pull/73 From phh at openjdk.org Fri Nov 18 20:44:02 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 18 Nov 2022 20:44:02 GMT Subject: [jdk17u-dev] RFR: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 22:36:22 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of commit ced88a2f from the openjdk/jdk repository. > > The commit being backported was authored by Erik Gahlin on 11 Nov 2022 and was reviewed by Christoph Langer and Markus Gr?nlund. > > Thanks! Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/895 From vrudomet at openjdk.org Fri Nov 18 20:44:41 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Fri, 18 Nov 2022 20:44:41 GMT Subject: [jdk19u] Integrated: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 06:31:06 GMT, Victor Rudometov wrote: > Backport for [JDK-8286624](https://bugs.openjdk.org/browse/JDK-8286624) Regression Test CoordinateTruncationBug.java fails on OL8.3 > > (cherry picked from commit c71d87e54ca0c0173583bed978e06c7faa0fa283) > > Clean backport. New test, low risk. > Test pass on manual run (mac, linux, x64 aarch64) using > make run-test TEST="test/jdk/sun/java2d/SunGraphics2D/CoordinateTruncationBug.java" This pull request has now been integrated. Changeset: ba534d3b Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk19u/commit/ba534d3be49d7cc2b62763ced10b9aea42d0549c Stats: 271 lines in 1 file changed: 271 ins; 0 del; 0 mod 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Backport-of: c71d87e54ca0c0173583bed978e06c7faa0fa283 ------------- PR: https://git.openjdk.org/jdk19u/pull/72 From phh at openjdk.org Fri Nov 18 20:54:35 2022 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 18 Nov 2022 20:54:35 GMT Subject: [jdk19u] RFR: 8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols In-Reply-To: References: Message-ID: <7-ylKGRnqJuz3sO4f660gAvYqJFwHxGEhShv5BBEQk0=.6507c70e-76f4-4049-ba87-e5a6ab07b449@github.com> On Wed, 16 Nov 2022 01:26:59 GMT, Man Cao wrote: > Backport of https://bugs.openjdk.org/browse/JDK-8296970. caoman, pls add /integrate and I'll sponsor. ------------- PR: https://git.openjdk.org/jdk19u/pull/68 From tsteele at openjdk.org Fri Nov 18 22:49:31 2022 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 18 Nov 2022 22:49:31 GMT Subject: [jdk11u-dev] RFR: 8187697: Cleanup: irrelevant code in OutputPropertiesFactory Message-ID: This is part of an effort to backport the following 3 commits. In order to resolve the issue presented by 3. This PR modifies OutputPropertiesFactory--adding changes which are then modifies by 2. 1. https://github.com/openjdk/jdk/commit/08a370a8a56b129c9b1a812648261fe3ae8d7ea5 2. https://github.com/openjdk/jdk/commit/b238aef18d56ad87ab954e3ceac797c234b3f3bf 3. https://github.com/openjdk/jdk/commit/5c12a30062a3c661f4a862eeb66b6ca18875bab4 ------------- Commit messages: - Backport 08a370a8a56b129c9b1a812648261fe3ae8d7ea5 Changes: https://git.openjdk.org/jdk11u-dev/pull/1530/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1530&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8187697 Stats: 596 lines in 5 files changed: 100 ins; 432 del; 64 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1530.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1530/head:pull/1530 PR: https://git.openjdk.org/jdk11u-dev/pull/1530 From manc at openjdk.org Fri Nov 18 22:59:51 2022 From: manc at openjdk.org (Man Cao) Date: Fri, 18 Nov 2022 22:59:51 GMT Subject: [jdk19u] Integrated: 8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols In-Reply-To: References: Message-ID: <_N1thgmDPTQHMG-VF9UTg5AZJmh4Zzln-IY6t7fQR7E=.ea5d5044-e491-4c33-8ca9-acdc018b0242@github.com> On Wed, 16 Nov 2022 01:26:59 GMT, Man Cao wrote: > Backport of https://bugs.openjdk.org/browse/JDK-8296970. This pull request has now been integrated. Changeset: d3d72499 Author: Man Cao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk19u/commit/d3d724991ce0bc46201f562910530a18f58e766b Stats: 4 lines in 2 files changed: 0 ins; 2 del; 2 mod 8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols Backport-of: f662a060463c2982da40307a53d59e514390f60c ------------- PR: https://git.openjdk.org/jdk19u/pull/68 From tsteele at openjdk.org Fri Nov 18 23:14:16 2022 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 18 Nov 2022 23:14:16 GMT Subject: [jdk11u-dev] RFR: 8219705: Wrong media-type for a given serialization method Message-ID: See comments in https://github.com/openjdk/jdk11u-dev/pull/1530 ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1530 Commit messages: - 8219705: Wrong media-type for a given serialization method Changes: https://git.openjdk.org/jdk11u-dev/pull/1531/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1531&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8219705 Stats: 75 lines in 2 files changed: 73 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1531.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1531/head:pull/1531 PR: https://git.openjdk.org/jdk11u-dev/pull/1531 From tsteele at openjdk.org Fri Nov 18 23:30:46 2022 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 18 Nov 2022 23:30:46 GMT Subject: [jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML [v2] In-Reply-To: References: Message-ID: > Backporting this change to jdk11. I noticed this was also requested by @jocwurs as I was working on it. > > Functionally this is a clean backport. But, there are some differences that will trip up the bots. > - Copyright years are sometimes newer in the current jdk11u. I kept the newer year. > - I merged two lists of bug ids into one--keeping all bug-ids. > - Git seems to treat `test/.../OutputPropertiesTest.java` as a new file in these changes, but not in the old ones. This wasn't a conflict, but it shows up differently for me on GitHub when I compare it to the changes in the original commit. > > Testing: OutputPropertiesTest passes. > > I'll wait for a review before requesting this in JBS. Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML Reviewed-by: dfuchs, lancea - 8219705: Wrong media-type for a given serialization method Reviewed-by: lancea - Backport 08a370a8a56b129c9b1a812648261fe3ae8d7ea5 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1521/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1521&range=01 Stats: 763 lines in 13 files changed: 238 ins; 439 del; 86 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1521.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1521/head:pull/1521 PR: https://git.openjdk.org/jdk11u-dev/pull/1521 From tsteele at openjdk.org Fri Nov 18 23:37:30 2022 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 18 Nov 2022 23:37:30 GMT Subject: [jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML [v3] In-Reply-To: References: Message-ID: > Backporting this change to jdk11. I noticed this was also requested by @jocwurs as I was working on it. > > Functionally this is a clean backport. But, there are some differences that will trip up the bots. > - Copyright years are sometimes newer in the current jdk11u. I kept the newer year. > - I merged two lists of bug ids into one--keeping all bug-ids. > - Git seems to treat `test/.../OutputPropertiesTest.java` as a new file in these changes, but not in the old ones. This wasn't a conflict, but it shows up differently for me on GitHub when I compare it to the changes in the original commit. > > Testing: OutputPropertiesTest passes. > > I'll wait for a review before requesting this in JBS. Tyler Steele has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: - 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML Reviewed-by: dfuchs, lancea - 8219705: Wrong media-type for a given serialization method Reviewed-by: lancea ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1521/files - new: https://git.openjdk.org/jdk11u-dev/pull/1521/files/13c10ee2..07a98a26 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1521&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1521&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1521.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1521/head:pull/1521 PR: https://git.openjdk.org/jdk11u-dev/pull/1521 From tsteele at openjdk.org Fri Nov 18 23:44:01 2022 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 18 Nov 2022 23:44:01 GMT Subject: [jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML [v4] In-Reply-To: References: Message-ID: > Backporting this change to jdk11. I noticed this was also requested by @jocwurs as I was working on it. > > Functionally this is a clean backport. But, there are some differences that will trip up the bots. > - Copyright years are sometimes newer in the current jdk11u. I kept the newer year. > - I merged two lists of bug ids into one--keeping all bug-ids. > - Git seems to treat `test/.../OutputPropertiesTest.java` as a new file in these changes, but not in the old ones. This wasn't a conflict, but it shows up differently for me on GitHub when I compare it to the changes in the original commit. > > Testing: OutputPropertiesTest passes. > > I'll wait for a review before requesting this in JBS. Tyler Steele has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML Reviewed-by: dfuchs, lancea ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1521/files - new: https://git.openjdk.org/jdk11u-dev/pull/1521/files/07a98a26..a5bcb19e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1521&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1521&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1521.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1521/head:pull/1521 PR: https://git.openjdk.org/jdk11u-dev/pull/1521 From tsteele at openjdk.org Fri Nov 18 23:45:56 2022 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 18 Nov 2022 23:45:56 GMT Subject: [jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML [v4] In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 16:20:40 GMT, Paul Hohensee wrote: >> Tyler Steele has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML >> >> Reviewed-by: dfuchs, lancea > > As indicated by the its @bug comment, OutputProperties.java is a file brought in by JDK-8219705, which hasn't been backported. Please backport JDK-8219705 first, revise this PR and make it dependent on that backport. There are likely also predecessor(s) for JDK-8219705, based on the LastModified update in OutputPropertiesFactory.java: Feb 2019 is updated to Mar 2019, while the 11u version has Oct 2017. @phohensee Closing in favour of https://github.com/openjdk/jdk11u-dev/pull/1532 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1521 From tsteele at openjdk.org Fri Nov 18 23:45:58 2022 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 18 Nov 2022 23:45:58 GMT Subject: [jdk11u-dev] Withdrawn: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML In-Reply-To: References: Message-ID: On Mon, 14 Nov 2022 22:21:13 GMT, Tyler Steele wrote: > Backporting this change to jdk11. I noticed this was also requested by @jocwurs as I was working on it. > > Functionally this is a clean backport. But, there are some differences that will trip up the bots. > - Copyright years are sometimes newer in the current jdk11u. I kept the newer year. > - I merged two lists of bug ids into one--keeping all bug-ids. > - Git seems to treat `test/.../OutputPropertiesTest.java` as a new file in these changes, but not in the old ones. This wasn't a conflict, but it shows up differently for me on GitHub when I compare it to the changes in the original commit. > > Testing: OutputPropertiesTest passes. > > I'll wait for a review before requesting this in JBS. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1521 From tsteele at openjdk.org Fri Nov 18 23:48:53 2022 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 18 Nov 2022 23:48:53 GMT Subject: [jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML Message-ID: See comments in https://github.com/openjdk/jdk11u-dev/pull/1530. This backport requires a review. It is not marked clean because it does not change the `@LastModified` dates in several places. In all cases, these dates were newer in the current version of jdk11u-dev. In a similar vein, this change adds to a newer list of bug ids in one place. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1531 Commit messages: - 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML Changes: https://git.openjdk.org/jdk11u-dev/pull/1532/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1532&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8223291 Stats: 94 lines in 8 files changed: 65 ins; 7 del; 22 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1532.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1532/head:pull/1532 PR: https://git.openjdk.org/jdk11u-dev/pull/1532 From vrudomet at openjdk.org Sat Nov 19 05:10:19 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Sat, 19 Nov 2022 05:10:19 GMT Subject: [jdk11u-dev] RFR: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" Message-ID: <_yT0lORIn90apNJVyWfrxi76AL19lg1SRp3fj1XUrzo=.3512099a-6461-431d-bffe-8e9e24ff7745@github.com> Backport for [JDK-8285604](https://bugs.openjdk.org/browse/JDK-8285604) closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" https://github.com/openjdk/jdk/commit/c56c69ed3e09df1b56e340498dc28ba50815d15e Clean backport. New test, low risk. Test passed with command: make run-test TEST="test/jdk/sun/java2d/GdiRendering/ClipShapeRendering.java" ------------- Commit messages: - 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" Changes: https://git.openjdk.org/jdk11u-dev/pull/1533/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1533&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285604 Stats: 518 lines in 1 file changed: 518 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1533.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1533/head:pull/1533 PR: https://git.openjdk.org/jdk11u-dev/pull/1533 From vrudomet at openjdk.org Sat Nov 19 05:11:17 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Sat, 19 Nov 2022 05:11:17 GMT Subject: [jdk19u] RFR: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" Message-ID: Backport for [JDK-8285604](https://bugs.openjdk.org/browse/JDK-8285604) closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" https://github.com/openjdk/jdk/commit/c56c69ed3e09df1b56e340498dc28ba50815d15e Clean backport. New test, low risk. Test passed with command: make run-test TEST="test/jdk/sun/java2d/GdiRendering/ClipShapeRendering.java" ------------- Commit messages: - 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" Changes: https://git.openjdk.org/jdk19u/pull/74/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=74&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285604 Stats: 518 lines in 1 file changed: 518 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/74.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/74/head:pull/74 PR: https://git.openjdk.org/jdk19u/pull/74 From vrudomet at openjdk.org Sat Nov 19 05:11:32 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Sat, 19 Nov 2022 05:11:32 GMT Subject: [jdk17u-dev] RFR: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" Message-ID: <80HdQp5WiE0Gj0nusqvbb2ZMuNcnd6Hr-qTneC3vd9g=.388fc2c1-904f-4c13-ba6f-5d66dd17dd2c@github.com> Backport for [JDK-8285604](https://bugs.openjdk.org/browse/JDK-8285604) closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" https://github.com/openjdk/jdk/commit/c56c69ed3e09df1b56e340498dc28ba50815d15e Clean backport. New test, low risk. Test passed with command: make run-test TEST="test/jdk/sun/java2d/GdiRendering/ClipShapeRendering.java" ------------- Commit messages: - 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" Changes: https://git.openjdk.org/jdk17u-dev/pull/901/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=901&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285604 Stats: 518 lines in 1 file changed: 518 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/901.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/901/head:pull/901 PR: https://git.openjdk.org/jdk17u-dev/pull/901 From vrudomet at openjdk.org Sat Nov 19 07:05:57 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Sat, 19 Nov 2022 07:05:57 GMT Subject: [jdk11u-dev] RFR: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout Message-ID: Backport for [JDK-8178698](https://bugs.openjdk.org/browse/JDK-8178698) javax/sound/midi/Sequencer/MetaCallback.java failed with timeout https://github.com/openjdk/jdk/commit/43ce047f9f417a1d8afa83a3d2c2429a478975db Clean backport Test update, low risk. Test passes on mac & linux using make run-test TEST="test/jdk/javax/sound/midi/Sequencer/MetaCallback.java" ------------- Commit messages: - Backport 43ce047f9f417a1d8afa83a3d2c2429a478975db Changes: https://git.openjdk.org/jdk11u-dev/pull/1534/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1534&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8178698 Stats: 29 lines in 2 files changed: 22 ins; 1 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1534.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1534/head:pull/1534 PR: https://git.openjdk.org/jdk11u-dev/pull/1534 From vrudomet at openjdk.org Sat Nov 19 07:07:18 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Sat, 19 Nov 2022 07:07:18 GMT Subject: [jdk17u-dev] RFR: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout Message-ID: Backport for [JDK-8178698](https://bugs.openjdk.org/browse/JDK-8178698) javax/sound/midi/Sequencer/MetaCallback.java failed with timeout https://github.com/openjdk/jdk/commit/43ce047f9f417a1d8afa83a3d2c2429a478975db Clean backport Test update, low risk. Test passes on mac & linux using make run-test TEST="test/jdk/javax/sound/midi/Sequencer/MetaCallback.java" ------------- Commit messages: - 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout Changes: https://git.openjdk.org/jdk17u-dev/pull/902/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=902&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8178698 Stats: 28 lines in 2 files changed: 22 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/902.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/902/head:pull/902 PR: https://git.openjdk.org/jdk17u-dev/pull/902 From vrudomet at openjdk.org Sat Nov 19 07:07:22 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Sat, 19 Nov 2022 07:07:22 GMT Subject: [jdk19u] RFR: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout Message-ID: <52mKtSvTrIHzlftJhy67EcvH0Y5Allkq6HUEzvPCIgs=.f186e4ee-801e-4360-b1a7-db5ef54f0c7e@github.com> Backport for [JDK-8178698](https://bugs.openjdk.org/browse/JDK-8178698) javax/sound/midi/Sequencer/MetaCallback.java failed with timeout https://github.com/openjdk/jdk/commit/43ce047f9f417a1d8afa83a3d2c2429a478975db Clean backport Test update, low risk. Test passes on mac & linux using make run-test TEST="test/jdk/javax/sound/midi/Sequencer/MetaCallback.java" ------------- Commit messages: - 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout Changes: https://git.openjdk.org/jdk19u/pull/75/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=75&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8178698 Stats: 28 lines in 2 files changed: 22 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk19u/pull/75.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/75/head:pull/75 PR: https://git.openjdk.org/jdk19u/pull/75 From vrudomet at openjdk.org Sat Nov 19 07:15:23 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Sat, 19 Nov 2022 07:15:23 GMT Subject: [jdk11u-dev] RFR: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout [v2] In-Reply-To: References: Message-ID: <_wIHrYhjpqiZ_FtqtGVMW0PBT0vPOpU-iRtlaGnJCAA=.1f599392-64b9-47b6-b663-e95ff5d318c4@github.com> > Backport for [JDK-8178698](https://bugs.openjdk.org/browse/JDK-8178698) javax/sound/midi/Sequencer/MetaCallback.java failed with timeout https://github.com/openjdk/jdk/commit/43ce047f9f417a1d8afa83a3d2c2429a478975db > > Clean backport for test, had to merge ProblemList.txt > Test update, low risk. > Test passes on mac & linux using make run-test TEST="test/jdk/javax/sound/midi/Sequencer/MetaCallback.java" Victor Rudometov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 43ce047f9f417a1d8afa83a3d2c2429a478975db ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1534/files - new: https://git.openjdk.org/jdk11u-dev/pull/1534/files/6b9c24f4..8f90cf66 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1534&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1534&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1534.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1534/head:pull/1534 PR: https://git.openjdk.org/jdk11u-dev/pull/1534 From vrudomet at openjdk.org Sat Nov 19 07:30:03 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Sat, 19 Nov 2022 07:30:03 GMT Subject: [jdk11u-dev] RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent Message-ID: Backport for [JDK-8296632](https://bugs.openjdk.org/browse/JDK-8296632) Write a test to verify the content change of TextArea sends TextEvent https://git.openjdk.org/jdk/commit/59a308b9d0546471566b11f62ef9bdc169ca0b95 Clean Backport. New test, low risk. Test passes during manual run: make run-test TEST="test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java" ------------- Commit messages: - 8296632: Write a test to verify the content change of TextArea sends TextEvent Changes: https://git.openjdk.org/jdk11u-dev/pull/1535/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1535&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296632 Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1535.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1535/head:pull/1535 PR: https://git.openjdk.org/jdk11u-dev/pull/1535 From vrudomet at openjdk.org Sat Nov 19 07:31:57 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Sat, 19 Nov 2022 07:31:57 GMT Subject: [jdk19u] RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent Message-ID: Backport for [JDK-8296632](https://bugs.openjdk.org/browse/JDK-8296632) Write a test to verify the content change of TextArea sends TextEvent https://git.openjdk.org/jdk/commit/59a308b9d0546471566b11f62ef9bdc169ca0b95 Clean Backport. New test, low risk. Test passes during manual run: make run-test TEST="test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java" ------------- Commit messages: - 8296632: Write a test to verify the content change of TextArea sends TextEvent Changes: https://git.openjdk.org/jdk19u/pull/76/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=76&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296632 Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/76.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/76/head:pull/76 PR: https://git.openjdk.org/jdk19u/pull/76 From vrudomet at openjdk.org Sat Nov 19 07:32:45 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Sat, 19 Nov 2022 07:32:45 GMT Subject: [jdk17u-dev] RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent Message-ID: Backport for [JDK-8296632](https://bugs.openjdk.org/browse/JDK-8296632) Write a test to verify the content change of TextArea sends TextEvent https://git.openjdk.org/jdk/commit/59a308b9d0546471566b11f62ef9bdc169ca0b95 Clean Backport. New test, low risk. Test passes during manual run: make run-test TEST="test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java" ------------- Commit messages: - 8296632: Write a test to verify the content change of TextArea sends TextEvent Changes: https://git.openjdk.org/jdk17u-dev/pull/903/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=903&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296632 Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/903.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/903/head:pull/903 PR: https://git.openjdk.org/jdk17u-dev/pull/903 From goetz at openjdk.org Sun Nov 20 20:19:20 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 20 Nov 2022 20:19:20 GMT Subject: [jdk11u-dev] RFR: 8297257: Bump update version for OpenJDK: jdk-11.0.19 Message-ID: The necessary version bump. To be pushed after tag jdk-11.0.19+0. ------------- Commit messages: - 8297257: Bump update version for OpenJDK: jdk-11.0.19 Changes: https://git.openjdk.org/jdk11u-dev/pull/1536/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1536&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297257 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1536.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1536/head:pull/1536 PR: https://git.openjdk.org/jdk11u-dev/pull/1536 From goetz at openjdk.org Sun Nov 20 20:23:19 2022 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 20 Nov 2022 20:23:19 GMT Subject: [jdk17u-dev] RFR: 8297259: Bump update version for OpenJDK: jdk-17.0.7 Message-ID: The necessary version bump. To be pushed after tag jdk-17.0.7+0. ------------- Commit messages: - 8297259: Bump update version for OpenJDK: jdk-17.0.7 Changes: https://git.openjdk.org/jdk17u-dev/pull/904/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=904&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297259 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/904.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/904/head:pull/904 PR: https://git.openjdk.org/jdk17u-dev/pull/904 From shade at openjdk.org Mon Nov 21 07:49:38 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:49:38 GMT Subject: [jdk17u-dev] RFR: 8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier() In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 15:41:16 GMT, Aleksey Shipilev wrote: > Clean backport, provides the grounds for more clean backports. > > Additional testing: > - [x] Linux x86_64 fastdebug, `hotspot_gc_shenandoah` Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/894 From shade at openjdk.org Mon Nov 21 07:50:34 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:50:34 GMT Subject: [jdk17u-dev] RFR: 8278826: Print error if Shenandoah flags are empty (instead of crashing) In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 14:45:23 GMT, Aleksey Shipilev wrote: > Clean backport to fixes Shenandoah UX problem. > > Additional testing: > - [x] Linux x86_64 fastdebug `hotspot_gc_shenandoah` > - [x] Ad-hoc CLI tests Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/893 From shade at openjdk.org Mon Nov 21 07:50:50 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:50:50 GMT Subject: [jdk17u-dev] RFR: 8280391: NMT: Correct NMT tag on CollectedHeap In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 19:18:38 GMT, Aleksey Shipilev wrote: > Clean backport to improve NMT reporting. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` -- some unrelated failures Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/883 From shade at openjdk.org Mon Nov 21 07:51:05 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:51:05 GMT Subject: [jdk17u-dev] Integrated: 8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier() In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 15:41:16 GMT, Aleksey Shipilev wrote: > Clean backport, provides the grounds for more clean backports. > > Additional testing: > - [x] Linux x86_64 fastdebug, `hotspot_gc_shenandoah` This pull request has now been integrated. Changeset: 7a111ea1 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/7a111ea14a8b3b3b8276a424897eb31f59be5ea2 Stats: 7 lines in 1 file changed: 0 ins; 5 del; 2 mod 8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier() Backport-of: 011958d30b275f0f6a2de097938ceeb34beb314d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/894 From shade at openjdk.org Mon Nov 21 07:52:50 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:52:50 GMT Subject: [jdk17u-dev] RFR: 8273880: Zero: Print warnings when unsupported intrinsics are enabled In-Reply-To: <_4OatOZ_VLQp69CLxAdsO5n9WJPYHYcaTXLhsVQ-Ku4=.ebb43cd1-819b-45eb-95a4-d3be1be45549@github.com> References: <_4OatOZ_VLQp69CLxAdsO5n9WJPYHYcaTXLhsVQ-Ku4=.ebb43cd1-819b-45eb-95a4-d3be1be45549@github.com> Message-ID: On Wed, 16 Nov 2022 10:08:47 GMT, Aleksey Shipilev wrote: > Clean backport to improve Zero UX. > > Additional testing: > - [x] Zero reproducer from the issue > - [x] Linux x86_64 zero fastdebug build > - [x] Linux AArch64 zero fastdebug build Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/884 From shade at openjdk.org Mon Nov 21 07:53:00 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:53:00 GMT Subject: [jdk17u-dev] RFR: 8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size In-Reply-To: <9SOm5tviy2qbXZLxJkv2URtP9GSoSPUo0_jgL8QXaaU=.eea14eeb-0677-4d32-b06f-3ee6b91c6151@github.com> References: <9SOm5tviy2qbXZLxJkv2URtP9GSoSPUo0_jgL8QXaaU=.eea14eeb-0677-4d32-b06f-3ee6b91c6151@github.com> Message-ID: On Thu, 17 Nov 2022 12:33:26 GMT, Aleksey Shipilev wrote: > Clean backport to improve test reliability. > > Additional testing > - [x] Linux x86_64 fastdebug, `gc/epsilon` Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/892 From shade at openjdk.org Mon Nov 21 07:53:01 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:53:01 GMT Subject: [jdk17u-dev] Integrated: 8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size In-Reply-To: <9SOm5tviy2qbXZLxJkv2URtP9GSoSPUo0_jgL8QXaaU=.eea14eeb-0677-4d32-b06f-3ee6b91c6151@github.com> References: <9SOm5tviy2qbXZLxJkv2URtP9GSoSPUo0_jgL8QXaaU=.eea14eeb-0677-4d32-b06f-3ee6b91c6151@github.com> Message-ID: On Thu, 17 Nov 2022 12:33:26 GMT, Aleksey Shipilev wrote: > Clean backport to improve test reliability. > > Additional testing > - [x] Linux x86_64 fastdebug, `gc/epsilon` This pull request has now been integrated. Changeset: 112ea1d7 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/112ea1d7be2a4e649337b6be4e9b3bbebdda76fd Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size Backport-of: 37ff7f3b66eaa74d62d6a93f2f34ec744db21834 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/892 From shade at openjdk.org Mon Nov 21 07:54:07 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:54:07 GMT Subject: [jdk17u-dev] RFR: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 11:15:15 GMT, Aleksey Shipilev wrote: > Clean backport to improve test times. > > Test before: > > > real 3m19.266s > user 6m21.286s > sys 0m10.274s > > > Test after: > > > real 0m49.397s > user 1m44.700s > sys 0m10.463s > > > Testing: > - [x] Affected test with Linux x86_64 fastdebug Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/890 From shade at openjdk.org Mon Nov 21 07:54:28 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:54:28 GMT Subject: [jdk17u-dev] Integrated: 8280391: NMT: Correct NMT tag on CollectedHeap In-Reply-To: References: Message-ID: On Tue, 15 Nov 2022 19:18:38 GMT, Aleksey Shipilev wrote: > Clean backport to improve NMT reporting. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` -- some unrelated failures This pull request has now been integrated. Changeset: a1679751 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/a1679751d04768bda53734908b65070c93b92c4e Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8280391: NMT: Correct NMT tag on CollectedHeap Backport-of: 44db4794d29c6e0755a6dc0ea1346f48f918155b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/883 From shade at openjdk.org Mon Nov 21 07:55:19 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:55:19 GMT Subject: [jdk17u-dev] Integrated: 8278826: Print error if Shenandoah flags are empty (instead of crashing) In-Reply-To: References: Message-ID: <1CMBgjgNJ_Tr6VBQX33yO9KOu2qw1PUJyV2-q8Kbyg4=.5024ec6f-871d-462d-b2d1-71fd5f54e6c7@github.com> On Thu, 17 Nov 2022 14:45:23 GMT, Aleksey Shipilev wrote: > Clean backport to fixes Shenandoah UX problem. > > Additional testing: > - [x] Linux x86_64 fastdebug `hotspot_gc_shenandoah` > - [x] Ad-hoc CLI tests This pull request has now been integrated. Changeset: 3f799528 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/3f799528d8424dfa7bd0db7947d5a3275a8f7aa8 Stats: 50 lines in 4 files changed: 19 ins; 21 del; 10 mod 8278826: Print error if Shenandoah flags are empty (instead of crashing) Backport-of: 247ea71d24a251d29d9a5179e5b773df850e7261 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/893 From shade at openjdk.org Mon Nov 21 07:56:06 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:56:06 GMT Subject: [jdk17u-dev] Integrated: 8273880: Zero: Print warnings when unsupported intrinsics are enabled In-Reply-To: <_4OatOZ_VLQp69CLxAdsO5n9WJPYHYcaTXLhsVQ-Ku4=.ebb43cd1-819b-45eb-95a4-d3be1be45549@github.com> References: <_4OatOZ_VLQp69CLxAdsO5n9WJPYHYcaTXLhsVQ-Ku4=.ebb43cd1-819b-45eb-95a4-d3be1be45549@github.com> Message-ID: On Wed, 16 Nov 2022 10:08:47 GMT, Aleksey Shipilev wrote: > Clean backport to improve Zero UX. > > Additional testing: > - [x] Zero reproducer from the issue > - [x] Linux x86_64 zero fastdebug build > - [x] Linux AArch64 zero fastdebug build This pull request has now been integrated. Changeset: 8f4a3a5f Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/8f4a3a5fca2311f6fab18e28a857ea3ac34b2fa6 Stats: 65 lines in 1 file changed: 65 ins; 0 del; 0 mod 8273880: Zero: Print warnings when unsupported intrinsics are enabled Backport-of: 54b456764bedb53adb7ae3c25f64d44dd8322ada ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/884 From shade at openjdk.org Mon Nov 21 07:57:06 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 07:57:06 GMT Subject: [jdk17u-dev] Integrated: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out In-Reply-To: References: Message-ID: <4mQoscZCJechFm1Lr0vIszVDc-rFs_FTDlgdz2HTvnc=.19582acb-60bd-4b64-8f2a-2c60e4c469ee@github.com> On Thu, 17 Nov 2022 11:15:15 GMT, Aleksey Shipilev wrote: > Clean backport to improve test times. > > Test before: > > > real 3m19.266s > user 6m21.286s > sys 0m10.274s > > > Test after: > > > real 0m49.397s > user 1m44.700s > sys 0m10.463s > > > Testing: > - [x] Affected test with Linux x86_64 fastdebug This pull request has now been integrated. Changeset: 023f651d Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/023f651d77f5194bea82ea22ed16865e39a71c0b Stats: 18 lines in 1 file changed: 9 ins; 4 del; 5 mod 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out Backport-of: ff0cb98965a0b6be2f6c399e4645630c10b3466e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/890 From shade at openjdk.org Mon Nov 21 08:14:15 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 08:14:15 GMT Subject: [jdk17u-dev] RFR: 8297259: Bump update version for OpenJDK: jdk-17.0.7 In-Reply-To: References: Message-ID: On Sun, 20 Nov 2022 20:17:35 GMT, Goetz Lindenmaier wrote: > The necessary version bump. To be pushed after tag jdk-17.0.7+0. Marked as reviewed by shade (Reviewer). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/904 From vrudomet at openjdk.org Mon Nov 21 08:18:53 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Mon, 21 Nov 2022 08:18:53 GMT Subject: [jdk17u-dev] Integrated: 8296632: Write a test to verify the content change of TextArea sends TextEvent In-Reply-To: References: Message-ID: <1T5TNxRH5cYGOHC-bQmuvYXTN95bv3TI9ZUJAOp0BMY=.820d86c4-81fd-46e1-aec3-1c71f4762fe5@github.com> On Sat, 19 Nov 2022 07:23:43 GMT, Victor Rudometov wrote: > Backport for [JDK-8296632](https://bugs.openjdk.org/browse/JDK-8296632) Write a test to verify the content change of TextArea sends TextEvent https://git.openjdk.org/jdk/commit/59a308b9d0546471566b11f62ef9bdc169ca0b95 > > Clean Backport. > New test, low risk. > Test passes during manual run: make run-test TEST="test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java" This pull request has now been integrated. Changeset: 94b9081b Author: Victor Rudometov Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/94b9081b033fd6a471be5515d72fc6d40b77dc54 Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod 8296632: Write a test to verify the content change of TextArea sends TextEvent Backport-of: 59a308b9d0546471566b11f62ef9bdc169ca0b95 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/903 From shade at openjdk.org Mon Nov 21 08:19:31 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 08:19:31 GMT Subject: [jdk17u-dev] RFR: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 06:51:10 GMT, Victor Rudometov wrote: > Backport for [JDK-8022403](https://bugs.openjdk.org/browse/JDK-8022403) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails > > Cherry-picked from https://github.com/openjdk/jdk/commit/65f7de252366e30ba18a22c107fc301c0fdc9378 > > Clean test backport, had to merge ProblemList.txt. > Test update, low risk. > Test passed during manual run using cmd: > make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java There are related open testbugs for this test, for example https://bugs.openjdk.org/browse/JDK-8297153 -- how does this affect 17u test stability? Should we wait for this test to be stabilized? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/898 From vrudomet at openjdk.org Mon Nov 21 08:19:33 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Mon, 21 Nov 2022 08:19:33 GMT Subject: [jdk17u-dev] Integrated: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout In-Reply-To: References: Message-ID: On Sat, 19 Nov 2022 06:59:15 GMT, Victor Rudometov wrote: > Backport for [JDK-8178698](https://bugs.openjdk.org/browse/JDK-8178698) javax/sound/midi/Sequencer/MetaCallback.java failed with timeout https://github.com/openjdk/jdk/commit/43ce047f9f417a1d8afa83a3d2c2429a478975db > > Clean backport > Test update, low risk. > Test passes on mac & linux using make run-test TEST="test/jdk/javax/sound/midi/Sequencer/MetaCallback.java" This pull request has now been integrated. Changeset: d0ad8713 Author: Victor Rudometov Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/d0ad871362e185b73f2c00651797832d293f5a05 Stats: 28 lines in 2 files changed: 22 ins; 1 del; 5 mod 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout Backport-of: 43ce047f9f417a1d8afa83a3d2c2429a478975db ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/902 From vrudomet at openjdk.org Mon Nov 21 08:20:12 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Mon, 21 Nov 2022 08:20:12 GMT Subject: [jdk17u-dev] Integrated: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" In-Reply-To: <80HdQp5WiE0Gj0nusqvbb2ZMuNcnd6Hr-qTneC3vd9g=.388fc2c1-904f-4c13-ba6f-5d66dd17dd2c@github.com> References: <80HdQp5WiE0Gj0nusqvbb2ZMuNcnd6Hr-qTneC3vd9g=.388fc2c1-904f-4c13-ba6f-5d66dd17dd2c@github.com> Message-ID: On Sat, 19 Nov 2022 05:04:05 GMT, Victor Rudometov wrote: > Backport for [JDK-8285604](https://bugs.openjdk.org/browse/JDK-8285604) closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" https://github.com/openjdk/jdk/commit/c56c69ed3e09df1b56e340498dc28ba50815d15e > > Clean backport. > New test, low risk. > Test passed with command: make run-test TEST="test/jdk/sun/java2d/GdiRendering/ClipShapeRendering.java" This pull request has now been integrated. Changeset: 1bbe4c29 Author: Victor Rudometov Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/1bbe4c2984df4ec3c454ff94e9affbb4bac2268b Stats: 518 lines in 1 file changed: 518 ins; 0 del; 0 mod 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" Backport-of: c56c69ed3e09df1b56e340498dc28ba50815d15e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/901 From vrudomet at openjdk.org Mon Nov 21 08:21:07 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Mon, 21 Nov 2022 08:21:07 GMT Subject: [jdk17u-dev] Integrated: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 In-Reply-To: References: Message-ID: <_W-pNjZgdh0xPn5qxxc3RYLH-RNPIqbksGuiUFP-Vwo=.9aa57620-9c31-45b9-923f-b470d34a2de6@github.com> On Fri, 18 Nov 2022 06:31:04 GMT, Victor Rudometov wrote: > Backport for [JDK-8286624](https://bugs.openjdk.org/browse/JDK-8286624) Regression Test CoordinateTruncationBug.java fails on OL8.3 > > (cherry picked from commit c71d87e54ca0c0173583bed978e06c7faa0fa283) > > Clean backport. New test, low risk. > Test pass on manual run (mac, linux, x64 aarch64) using > make run-test TEST="test/jdk/sun/java2d/SunGraphics2D/CoordinateTruncationBug.java" This pull request has now been integrated. Changeset: 5c802851 Author: Victor Rudometov Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/5c802851d4c8c36bb5551d8896a0a45b9cb83582 Stats: 271 lines in 1 file changed: 271 ins; 0 del; 0 mod 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Backport-of: c71d87e54ca0c0173583bed978e06c7faa0fa283 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/896 From shade at openjdk.org Mon Nov 21 08:45:22 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 08:45:22 GMT Subject: [jdk11u-dev] RFR: 8283199: Linux os::cpu_microcode_revision() stalls cold startup In-Reply-To: References: Message-ID: On Mon, 24 Oct 2022 09:32:39 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the startup time regression. > > The backport is not clean, because [JDK-8238161](https://bugs.openjdk.org/browse/JDK-8238161) is not present in JDK 11, and thus we have `fopen` instead of `os::fopen` in these hunks. I changed the code back to `fopen` to be consistent with the rest of JDK 11. > > Verified the startup time improves, using the scripts from the issue. > > > # Before > real 0m0.081s > real 0m0.081s > real 0m0.081s > > # After > real 0m0.062s > real 0m0.062s > real 0m0.062s > > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` Got the push approval. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1471 From shade at openjdk.org Mon Nov 21 08:47:19 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 08:47:19 GMT Subject: [jdk11u-dev] Integrated: 8283199: Linux os::cpu_microcode_revision() stalls cold startup In-Reply-To: References: Message-ID: <7ajA-gnNeeS1sHnERDEDjJGau9fGcAshQTLLVDMVPB4=.f1cea157-989d-49d9-8334-83f130bc9d41@github.com> On Mon, 24 Oct 2022 09:32:39 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the startup time regression. > > The backport is not clean, because [JDK-8238161](https://bugs.openjdk.org/browse/JDK-8238161) is not present in JDK 11, and thus we have `fopen` instead of `os::fopen` in these hunks. I changed the code back to `fopen` to be consistent with the rest of JDK 11. > > Verified the startup time improves, using the scripts from the issue. > > > # Before > real 0m0.081s > real 0m0.081s > real 0m0.081s > > # After > real 0m0.062s > real 0m0.062s > real 0m0.062s > > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` This pull request has now been integrated. Changeset: 5d9c09b8 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/5d9c09b8f10da495989918cb64ea4f92f520ccb5 Stats: 19 lines in 1 file changed: 16 ins; 0 del; 3 mod 8283199: Linux os::cpu_microcode_revision() stalls cold startup Reviewed-by: stuefe Backport-of: 1443f6b9191c127abdae38cadb1a44af3c652f1d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1471 From shade at openjdk.org Mon Nov 21 09:57:25 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 09:57:25 GMT Subject: [jdk17u-dev] RFR: 8269821: Remove is-queue-active check in inner loop of write_ref_array_pre_work Message-ID: <1cQ1Yc_NFDqnGl69lEPvAHePsK-XVVmcMves-8zcSv0=.25162874-26ec-470e-b1a7-01adf6632abf@github.com> Clean backport to improve G1 performance and provide grounds for next backports. Additional testing: - [x] Linux x86_64 fastdebug `tier1` - [ ] Linux x86_64 fastdebug `tier2` ------------- Commit messages: - Backport 675a9520b21e7adfded8a4bb8b1a06c1dcc6ccfb Changes: https://git.openjdk.org/jdk17u-dev/pull/905/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=905&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8269821 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/905.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/905/head:pull/905 PR: https://git.openjdk.org/jdk17u-dev/pull/905 From duke at openjdk.org Mon Nov 21 10:48:57 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 10:48:57 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v23] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has updated the pull request incrementally with one additional commit since the last revision: fixup ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/5dcdbec4..f4debfff Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=22 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=21-22 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From shade at openjdk.org Mon Nov 21 10:49:23 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 10:49:23 GMT Subject: [jdk17u-dev] RFR: 8283566: G1: Improve G1BarrierSet::enqueue performance Message-ID: Clean (after #905) backport to improve G1 performance. Additional testing: - [x] Linux x86_64 fastdebug `tier1` - [x] Linux x86_64 fastdebug `tier2` ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/905 Commit messages: - Backport 6ebf845ff7d758c99367488818427fcb7a5dbda9 Changes: https://git.openjdk.org/jdk17u-dev/pull/906/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=906&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283566 Stats: 46 lines in 4 files changed: 26 ins; 10 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/906.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/906/head:pull/906 PR: https://git.openjdk.org/jdk17u-dev/pull/906 From shade at openjdk.org Mon Nov 21 10:59:21 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 10:59:21 GMT Subject: [jdk17u-dev] RFR: 8266519: Cleanup resolve() leftovers from BarrierSet et al Message-ID: Clean backport to simplify GC interface for better maintainability. Additional testing: - [ ] Linux x86_64 fastdebug `tier1` ------------- Commit messages: - Backport 7eccbd4fde58ea36d6a21a2c4ffa3bc5d0b38c10 Changes: https://git.openjdk.org/jdk17u-dev/pull/907/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=907&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8266519 Stats: 41 lines in 4 files changed: 0 ins; 40 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/907.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/907/head:pull/907 PR: https://git.openjdk.org/jdk17u-dev/pull/907 From vkempik at openjdk.org Mon Nov 21 11:25:54 2022 From: vkempik at openjdk.org (Vladimir Kempik) Date: Mon, 21 Nov 2022 11:25:54 GMT Subject: [jdk19u] RFR: 8296602: RISC-V: improve performance of copy_memory stub Message-ID: Clean backport to jdk19u test results to follow ------------- Commit messages: - Backport bd57e2138fc980822a149af905e572ab71ccbf11 Changes: https://git.openjdk.org/jdk19u/pull/77/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=77&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296602 Stats: 70 lines in 1 file changed: 41 ins; 1 del; 28 mod Patch: https://git.openjdk.org/jdk19u/pull/77.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/77/head:pull/77 PR: https://git.openjdk.org/jdk19u/pull/77 From duke at openjdk.org Mon Nov 21 11:36:00 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 11:36:00 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v24] In-Reply-To: References: Message-ID: <4FXDCj0SgSl0ir-W8IH_ZG-whwh6-tvcefuBTLw35Ho=.dcb7abfa-7654-4235-8fdb-a1d5f36ebadb@github.com> > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has updated the pull request incrementally with one additional commit since the last revision: final attempt ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/f4debfff..853b1417 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=23 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=22-23 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From duke at openjdk.org Mon Nov 21 11:44:16 2022 From: duke at openjdk.org (Johannes Bechberger) Date: Mon, 21 Nov 2022 11:44:16 GMT Subject: [jdk11u-dev] RFR: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path Message-ID: Removes an unnecessary register push which currently makes stack walking impossible for async-profiler. ------------- Commit messages: - 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path Changes: https://git.openjdk.org/jdk11u-dev/pull/1524/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1524&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287425 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1524.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1524/head:pull/1524 PR: https://git.openjdk.org/jdk11u-dev/pull/1524 From phh at openjdk.org Mon Nov 21 11:44:16 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 21 Nov 2022 11:44:16 GMT Subject: [jdk11u-dev] RFR: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 16:50:10 GMT, Johannes Bechberger wrote: > Removes an unnecessary register push which currently makes stack walking impossible for async-profiler. This is a clean backport from 17u, so lgtm on the actual patch, other than the jcheck failure (you're got extra whitespace somewhere). But, as the bot says, a description is needed, and also a test report. The 17u backport passed tier1 and tier2 on x86 and aarch64. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1524 From duke at openjdk.org Mon Nov 21 11:44:17 2022 From: duke at openjdk.org (Johannes Bechberger) Date: Mon, 21 Nov 2022 11:44:17 GMT Subject: [jdk11u-dev] RFR: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 16:50:10 GMT, Johannes Bechberger wrote: > Removes an unnecessary register push which currently makes stack walking impossible for async-profiler. Thanks. I'll do it tomorrow. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1524 From duke at openjdk.org Mon Nov 21 12:24:13 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 12:24:13 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v25] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: final attempt ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/853b1417..4bbca99e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=24 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=23-24 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From duke at openjdk.org Mon Nov 21 12:25:28 2022 From: duke at openjdk.org (Johannes Bechberger) Date: Mon, 21 Nov 2022 12:25:28 GMT Subject: [jdk11u-dev] RFR: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment Message-ID: <1ymoeGd5tGOgeP6Kzock4IjWMjkkaHtbAfHMfzfwfb4=.accde646-043b-49af-8b3b-5cdc9556244f@github.com> Backports a fix to ensure that ASGCT does not obtain the mentioned lock. Tested with my profiling tester. ------------- Commit messages: - 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment Changes: https://git.openjdk.org/jdk11u-dev/pull/1537/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1537&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285794 Stats: 9 lines in 1 file changed: 4 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1537.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1537/head:pull/1537 PR: https://git.openjdk.org/jdk11u-dev/pull/1537 From rob.mckenna at oracle.com Mon Nov 21 12:29:12 2022 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Mon, 21 Nov 2022 12:29:12 +0000 Subject: [19u Communication] 19.0.2 will be closed for fixes on the 28th of November Message-ID: Hi folks, If you have fixes that you need to get into 19u please do so by the 28th of November. Thanks, -Rob From duke at openjdk.org Mon Nov 21 12:48:08 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 12:48:08 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v26] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: win fixpath for makefile ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/4bbca99e..87c7ed36 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=25 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=24-25 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From shade at openjdk.org Mon Nov 21 12:50:37 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 12:50:37 GMT Subject: [jdk17u-dev] RFR: 8280016: gc/g1/TestShrinkAuxiliaryData30 test fails on large machines Message-ID: Clean backport to improve testing. Additional testing: - [x] Affected test passes ------------- Commit messages: - Backport 590eb86033d5445018cd0e961e8721a20de4bb0c Changes: https://git.openjdk.org/jdk17u-dev/pull/908/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=908&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280016 Stats: 92 lines in 2 files changed: 46 ins; 46 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/908.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/908/head:pull/908 PR: https://git.openjdk.org/jdk17u-dev/pull/908 From xlinzheng at openjdk.org Mon Nov 21 12:51:55 2022 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Mon, 21 Nov 2022 12:51:55 GMT Subject: [jdk19u] Integrated: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic In-Reply-To: <03UdGwZhCke-pBE5x8_KIfFJFx6AWsaW6zBj4rKGiKs=.c150df14-bab1-4c58-8904-461d5653d400@github.com> References: <03UdGwZhCke-pBE5x8_KIfFJFx6AWsaW6zBj4rKGiKs=.c150df14-bab1-4c58-8904-461d5653d400@github.com> Message-ID: On Fri, 18 Nov 2022 04:14:37 GMT, Xiaolin Zheng wrote: > Clean backport from 20 for RISC-V backend: https://github.com/openjdk/jdk/commit/1fdbb1ba337b07dbcfb3c28c4fdeba74fee113dc > > Tier1~2 testing passed, including the added jtreg test in this PR. This pull request has now been integrated. Changeset: 3d88cc99 Author: Xiaolin Zheng Committer: Fei Yang URL: https://git.openjdk.org/jdk19u/commit/3d88cc990118fbc36a12b257de1a480d06089464 Stats: 100 lines in 2 files changed: 95 ins; 4 del; 1 mod 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic Backport-of: 1fdbb1ba337b07dbcfb3c28c4fdeba74fee113dc ------------- PR: https://git.openjdk.org/jdk19u/pull/70 From xlinzheng at openjdk.org Mon Nov 21 13:04:54 2022 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Mon, 21 Nov 2022 13:04:54 GMT Subject: [jdk19u] Integrated: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 04:29:32 GMT, Xiaolin Zheng wrote: > A backport from 20 for RISC-V backend: https://github.com/openjdk/jdk/commit/93fed9b251c21f20b68ddc4e179d6595275dbcd2 > > Only affects RISC-V backend, so impact is low. > > The `access_store_at`'s signature changed so when cherry-picked from JDK20 I met one minor conflict (Not sure if it would be considered clean then). > > Tier1~2 testing passed, and also passed the reproducible renaissance movie-lens test with CDS archive. This pull request has now been integrated. Changeset: 069569f9 Author: Xiaolin Zheng Committer: Fei Yang URL: https://git.openjdk.org/jdk19u/commit/069569f9e2c731e6ca3568ff767830ebbf88caab Stats: 52 lines in 8 files changed: 7 ins; 6 del; 39 mod 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null Backport-of: 93fed9b251c21f20b68ddc4e179d6595275dbcd2 ------------- PR: https://git.openjdk.org/jdk19u/pull/71 From duke at openjdk.org Mon Nov 21 13:15:15 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 13:15:15 GMT Subject: [jdk11u-dev] RFR: 8268860: Windows-Aarch64 build is failing in GitHub actions Message-ID: Applies cleanly except for the change added in https://github.com/openjdk/jdk11u-dev/commit/5d28a71c1f1b734a4d8f05363aa61c2b5b6df687 ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1278 Commit messages: - Backport acc3d995355b646c581623b0df5facbcdbfa4721 Changes: https://git.openjdk.org/jdk11u-dev/pull/1538/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1538&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8268860 Stats: 94 lines in 1 file changed: 92 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1538.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1538/head:pull/1538 PR: https://git.openjdk.org/jdk11u-dev/pull/1538 From duke at openjdk.org Mon Nov 21 13:18:11 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 13:18:11 GMT Subject: [jdk11u-dev] RFR: 8268860: Windows-Aarch64 build is failing in GitHub actions [v2] In-Reply-To: References: Message-ID: > Applies cleanly except for the change added in https://github.com/openjdk/jdk11u-dev/commit/5d28a71c1f1b734a4d8f05363aa61c2b5b6df687 George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport acc3d995355b646c581623b0df5facbcdbfa4721 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1538/files - new: https://git.openjdk.org/jdk11u-dev/pull/1538/files/c8e77b6b..7e2f04d0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1538&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1538&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1538.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1538/head:pull/1538 PR: https://git.openjdk.org/jdk11u-dev/pull/1538 From duke at openjdk.org Mon Nov 21 13:28:22 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 13:28:22 GMT Subject: [jdk11u-dev] RFR: 8287724: Fix various issues with msys2 Message-ID: This is the final piece of the puzzle in order to backport the GitHub actions refactor ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1278 Commit messages: - Backport 2e21c87fac8d60c3c7ed7b2d0afae9abfc110359 Changes: https://git.openjdk.org/jdk11u-dev/pull/1539/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1539&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287724 Stats: 38 lines in 3 files changed: 23 ins; 7 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1539.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1539/head:pull/1539 PR: https://git.openjdk.org/jdk11u-dev/pull/1539 From adinn at openjdk.org Mon Nov 21 13:41:45 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Mon, 21 Nov 2022 13:41:45 GMT Subject: [jdk11u-dev] RFR: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 21:19:21 GMT, Johannes Bechberger wrote: >> Removes an unnecessary register push which currently makes stack walking impossible for async-profiler. > > Thanks. I'll do it tomorrow. @parttimenerd This is now just waiting on a maintainer to ack the fix request. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1524 From duke at openjdk.org Mon Nov 21 13:50:23 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 13:50:23 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v26] In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 12:48:08 GMT, George Adams wrote: >> The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. >> >> This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. >> >> @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. > > George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > win fixpath for makefile Triggering a set of builds on the Adoptium CI: - [jdk11u-windows-x64-temurin #154](https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-windows-x64-temurin/154/) - [jdk11u-mac-aarch64-temurin #113](https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-mac-aarch64-temurin/113/) - [jdk11u-linux-aarch64-temurin #150](https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-aarch64-temurin/150/) - [jdk11u-linux-s390x-temurin #136](https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-s390x-temurin/136/) - [jdk11u-linux-arm-temurin #140](https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-arm-temurin/140/) - [jdk11u-linux-ppc64le-temurin #138](https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-ppc64le-temurin/138/) - [jdk11u-aix-ppc64-temurin #155](https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-aix-ppc64-temurin/155/) - [jdk11u-windows-x86-32-temurin #148](https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-windows-x86-32-temurin/148/) - [jdk11u-mac-x64-temurin #149](https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-mac-x64-temurin/149/) - [jdk11u-linux-x64-temurin #170](https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-x64-temurin/170/) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From shade at openjdk.org Mon Nov 21 14:11:26 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 14:11:26 GMT Subject: [jdk17u-dev] RFR: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long Message-ID: Clean backport to make ARM32 safer. Additional testing: - [x] Linux ARM32 cross-builds - [ ] Linux ARM32 `make bootcycle-images` ------------- Commit messages: - Backport 718eff2bb6e938440df9f7b982ef6d2f4060a759 Changes: https://git.openjdk.org/jdk17u-dev/pull/909/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=909&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273380 Stats: 20 lines in 1 file changed: 8 ins; 8 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/909.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/909/head:pull/909 PR: https://git.openjdk.org/jdk17u-dev/pull/909 From shade at openjdk.org Mon Nov 21 15:02:44 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 15:02:44 GMT Subject: [jdk17u-dev] RFR: 8278146: G1: Rework VM_G1Concurrent VMOp to clearly identify it as pause Message-ID: Clean backport to improve detailed VM diagnostics. @tschatzl, are you good with this in 17u? Additional testing: - [x] Linux x86_64 fastdebug `tier1` ------------- Commit messages: - Backport 3a1fca3adf3111a966cb62d926b95acc89b7fe97 Changes: https://git.openjdk.org/jdk17u-dev/pull/910/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=910&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278146 Stats: 67 lines in 4 files changed: 29 ins; 24 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/910.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/910/head:pull/910 PR: https://git.openjdk.org/jdk17u-dev/pull/910 From duke at openjdk.org Mon Nov 21 15:03:43 2022 From: duke at openjdk.org (duke) Date: Mon, 21 Nov 2022 15:03:43 GMT Subject: [jdk17u-dev] Withdrawn: 8274639: Provide a way to disable warnings for cross-modular links In-Reply-To: References: Message-ID: <9gIiRCJQ7vfsBpj0eJemgGbTJWwX8Bfcwk6EMvLRCOY=.6fe75f1a-945c-4d75-97b9-df4b55e880a2@github.com> On Fri, 23 Sep 2022 07:05:31 GMT, Alexey Pavlyutkin wrote: > Hi! Here is backport of [JDK-8274639](https://bugs.openjdk.org/browse/JDK-8274639). The patch adds the ability to disable Link Modularity Mismatch warnings and so projects using cross-modular links can be compiled with -Werror flag. > > Original patch applied cleanly. > > Verification (amd64/20.04LTS): test/langtools/jdk/javadoc/doclet/testLinkOption/TestLinkOptionWithModule.java > Regression (amd64/20.04LTS): test/langtools/jdk/javadoc This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/723 From mbaesken at openjdk.org Mon Nov 21 15:24:11 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 21 Nov 2022 15:24:11 GMT Subject: [jdk17u-dev] RFR: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds Message-ID: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds ------------- Commit messages: - Backport bcc6b12b711a9c5007d963123fb38a7e72aaf8e5 Changes: https://git.openjdk.org/jdk17u-dev/pull/911/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=911&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296945 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/911.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/911/head:pull/911 PR: https://git.openjdk.org/jdk17u-dev/pull/911 From shade at openjdk.org Mon Nov 21 15:36:50 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 15:36:50 GMT Subject: [jdk17u-dev] RFR: 8283999: Update JMH devkit to 1.35 Message-ID: Clean backport to improve testing. Additional testing: - [x] JMH devkit creation still works ------------- Commit messages: - Backport a3223cb6839dbed2476c928572d89dad84dc4636 Changes: https://git.openjdk.org/jdk17u-dev/pull/912/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=912&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283999 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/912.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/912/head:pull/912 PR: https://git.openjdk.org/jdk17u-dev/pull/912 From phh at openjdk.org Mon Nov 21 16:01:23 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 21 Nov 2022 16:01:23 GMT Subject: [jdk11u-dev] RFR: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 16:50:10 GMT, Johannes Bechberger wrote: > Removes an unnecessary register push which currently makes stack walking impossible for async-profiler. Lgtm ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1524 From adinn at openjdk.org Mon Nov 21 16:09:23 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Mon, 21 Nov 2022 16:09:23 GMT Subject: [jdk11u-dev] RFR: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 21:19:21 GMT, Johannes Bechberger wrote: >> Removes an unnecessary register push which currently makes stack walking impossible for async-profiler. > > Thanks. I'll do it tomorrow. @parttimenerd this has not yet had the fix request acked on the JIRA which is needed before anyone is supposed to sponsor it. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1524 From duke at openjdk.org Mon Nov 21 16:09:24 2022 From: duke at openjdk.org (Johannes Bechberger) Date: Mon, 21 Nov 2022 16:09:24 GMT Subject: [jdk11u-dev] RFR: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 16:50:10 GMT, Johannes Bechberger wrote: > Removes an unnecessary register push which currently makes stack walking impossible for async-profiler. Oh, thanks for mentioning that, I forgot that my fix request was pending. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1524 From adinn at openjdk.org Mon Nov 21 16:09:24 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Mon, 21 Nov 2022 16:09:24 GMT Subject: [jdk11u-dev] RFR: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path In-Reply-To: References: Message-ID: <0xabWFcEmLXdJZEIlK86xFGxP9BDPmq8-7rJa5bEvkE=.6c1828fb-52d5-41b7-93d7-171ec4819821@github.com> On Wed, 16 Nov 2022 16:50:10 GMT, Johannes Bechberger wrote: > Removes an unnecessary register push which currently makes stack walking impossible for async-profiler. @GoeLin would you be able to ack the fix request for jdk11u? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1524 From duke at openjdk.org Mon Nov 21 16:18:15 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 16:18:15 GMT Subject: [jdk11u-dev] RFR: 8268860: Windows-Aarch64 build is failing in GitHub actions [v3] In-Reply-To: References: Message-ID: > Applies cleanly except for the change added in https://github.com/openjdk/jdk11u-dev/commit/5d28a71c1f1b734a4d8f05363aa61c2b5b6df687 George Adams has updated the pull request incrementally with one additional commit since the last revision: bump actions versions ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1538/files - new: https://git.openjdk.org/jdk11u-dev/pull/1538/files/7e2f04d0..786b54ca Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1538&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1538&range=01-02 Stats: 19 lines in 1 file changed: 13 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1538.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1538/head:pull/1538 PR: https://git.openjdk.org/jdk11u-dev/pull/1538 From shade at openjdk.org Mon Nov 21 16:26:36 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Nov 2022 16:26:36 GMT Subject: [jdk17u-dev] RFR: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah Message-ID: Clean backport to stabilize the tests and hopefully resolve some GHA 17u intermittent failures. I was not able to reproduce the failures locally, so I am backporting this blindly. Additional testing: - [x] Linux x86_64 fastdebug, `gc/stringdedup` (20 repetitions) ------------- Commit messages: - Backport f9b2507f3e86bcb91e8ccfd0a84f31712fd535c2 Changes: https://git.openjdk.org/jdk17u-dev/pull/913/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=913&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8271834 Stats: 49 lines in 1 file changed: 43 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/913.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/913/head:pull/913 PR: https://git.openjdk.org/jdk17u-dev/pull/913 From phh at openjdk.org Mon Nov 21 21:41:30 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 21 Nov 2022 21:41:30 GMT Subject: [jdk11u-dev] RFR: 8219705: Wrong media-type for a given serialization method In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 22:55:06 GMT, Tyler Steele wrote: > See comments in https://github.com/openjdk/jdk11u-dev/pull/1530 > > This backport requires a review. It is not marked clean because it does not make the change to jaxp/TEST.ROOT from the original commit. I kept the version bumped by https://github.com/openjdk/jdk11u-dev/commit/00d94836393b0fc0e7136aef379af0726778e0f0. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1531 From tsteele at openjdk.org Mon Nov 21 22:07:34 2022 From: tsteele at openjdk.org (Tyler Steele) Date: Mon, 21 Nov 2022 22:07:34 GMT Subject: [jdk11u-dev] RFR: 8219705: Wrong media-type for a given serialization method In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 22:55:06 GMT, Tyler Steele wrote: > See comments in https://github.com/openjdk/jdk11u-dev/pull/1530 > > This backport requires a review. It is not marked clean because it does not make the change to jaxp/TEST.ROOT from the original commit. I kept the version bumped by https://github.com/openjdk/jdk11u-dev/commit/00d94836393b0fc0e7136aef379af0726778e0f0. Thanks for the review. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1531 From vrudomet at openjdk.org Mon Nov 21 22:25:42 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Mon, 21 Nov 2022 22:25:42 GMT Subject: [jdk19u] Integrated: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout In-Reply-To: <52mKtSvTrIHzlftJhy67EcvH0Y5Allkq6HUEzvPCIgs=.f186e4ee-801e-4360-b1a7-db5ef54f0c7e@github.com> References: <52mKtSvTrIHzlftJhy67EcvH0Y5Allkq6HUEzvPCIgs=.f186e4ee-801e-4360-b1a7-db5ef54f0c7e@github.com> Message-ID: On Sat, 19 Nov 2022 06:59:12 GMT, Victor Rudometov wrote: > Backport for [JDK-8178698](https://bugs.openjdk.org/browse/JDK-8178698) javax/sound/midi/Sequencer/MetaCallback.java failed with timeout https://github.com/openjdk/jdk/commit/43ce047f9f417a1d8afa83a3d2c2429a478975db > > Clean backport > Test update, low risk. > Test passes on mac & linux using make run-test TEST="test/jdk/javax/sound/midi/Sequencer/MetaCallback.java" This pull request has now been integrated. Changeset: 2e6729e0 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk19u/commit/2e6729e094e7a4f0c535e01f84391215bff390ec Stats: 28 lines in 2 files changed: 22 ins; 1 del; 5 mod 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout Backport-of: 43ce047f9f417a1d8afa83a3d2c2429a478975db ------------- PR: https://git.openjdk.org/jdk19u/pull/75 From phh at openjdk.org Mon Nov 21 22:33:34 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 21 Nov 2022 22:33:34 GMT Subject: [jdk11u-dev] RFR: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout [v2] In-Reply-To: <_wIHrYhjpqiZ_FtqtGVMW0PBT0vPOpU-iRtlaGnJCAA=.1f599392-64b9-47b6-b663-e95ff5d318c4@github.com> References: <_wIHrYhjpqiZ_FtqtGVMW0PBT0vPOpU-iRtlaGnJCAA=.1f599392-64b9-47b6-b663-e95ff5d318c4@github.com> Message-ID: On Sat, 19 Nov 2022 07:15:23 GMT, Victor Rudometov wrote: >> Backport for [JDK-8178698](https://bugs.openjdk.org/browse/JDK-8178698) javax/sound/midi/Sequencer/MetaCallback.java failed with timeout https://github.com/openjdk/jdk/commit/43ce047f9f417a1d8afa83a3d2c2429a478975db >> >> Clean backport for test, had to merge ProblemList.txt >> Test update, low risk. >> Test passes on mac & linux using make run-test TEST="test/jdk/javax/sound/midi/Sequencer/MetaCallback.java" > > Victor Rudometov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 43ce047f9f417a1d8afa83a3d2c2429a478975db Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1534 From vrudomet at openjdk.org Mon Nov 21 22:39:22 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Mon, 21 Nov 2022 22:39:22 GMT Subject: [jdk19u] Integrated: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" In-Reply-To: References: Message-ID: On Sat, 19 Nov 2022 05:04:08 GMT, Victor Rudometov wrote: > Backport for [JDK-8285604](https://bugs.openjdk.org/browse/JDK-8285604) closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" https://github.com/openjdk/jdk/commit/c56c69ed3e09df1b56e340498dc28ba50815d15e > > Clean backport. > New test, low risk. > Test passed with command: make run-test TEST="test/jdk/sun/java2d/GdiRendering/ClipShapeRendering.java" This pull request has now been integrated. Changeset: bbc70dae Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk19u/commit/bbc70daeda31ed471faeda5c40dec638db4a55a0 Stats: 518 lines in 1 file changed: 518 ins; 0 del; 0 mod 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" Backport-of: c56c69ed3e09df1b56e340498dc28ba50815d15e ------------- PR: https://git.openjdk.org/jdk19u/pull/74 From vrudomet at openjdk.org Mon Nov 21 22:47:49 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Mon, 21 Nov 2022 22:47:49 GMT Subject: [jdk11u-dev] Integrated: 8296632: Write a test to verify the content change of TextArea sends TextEvent In-Reply-To: References: Message-ID: On Sat, 19 Nov 2022 07:23:45 GMT, Victor Rudometov wrote: > Backport for [JDK-8296632](https://bugs.openjdk.org/browse/JDK-8296632) Write a test to verify the content change of TextArea sends TextEvent https://git.openjdk.org/jdk/commit/59a308b9d0546471566b11f62ef9bdc169ca0b95 > > Clean Backport. > New test, low risk. > Test passes during manual run: make run-test TEST="test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java" This pull request has now been integrated. Changeset: 14592778 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/14592778b19af792f7394be381c3e23bf216372d Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod 8296632: Write a test to verify the content change of TextArea sends TextEvent Backport-of: 59a308b9d0546471566b11f62ef9bdc169ca0b95 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1535 From vrudomet at openjdk.org Mon Nov 21 22:47:55 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Mon, 21 Nov 2022 22:47:55 GMT Subject: [jdk19u] Integrated: 8296632: Write a test to verify the content change of TextArea sends TextEvent In-Reply-To: References: Message-ID: On Sat, 19 Nov 2022 07:23:41 GMT, Victor Rudometov wrote: > Backport for [JDK-8296632](https://bugs.openjdk.org/browse/JDK-8296632) Write a test to verify the content change of TextArea sends TextEvent https://git.openjdk.org/jdk/commit/59a308b9d0546471566b11f62ef9bdc169ca0b95 > > Clean Backport. > New test, low risk. > Test passes during manual run: make run-test TEST="test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java" This pull request has now been integrated. Changeset: 8a105ca4 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk19u/commit/8a105ca49ffb23f0a2755b0714e780b6aac74dc4 Stats: 141 lines in 1 file changed: 141 ins; 0 del; 0 mod 8296632: Write a test to verify the content change of TextArea sends TextEvent Backport-of: 59a308b9d0546471566b11f62ef9bdc169ca0b95 ------------- PR: https://git.openjdk.org/jdk19u/pull/76 From vrudomet at openjdk.org Mon Nov 21 23:02:58 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Mon, 21 Nov 2022 23:02:58 GMT Subject: [jdk11u-dev] Integrated: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 06:31:08 GMT, Victor Rudometov wrote: > Backport for [JDK-8286624](https://bugs.openjdk.org/browse/JDK-8286624) Regression Test CoordinateTruncationBug.java fails on OL8.3 > > (cherry picked from commit c71d87e54ca0c0173583bed978e06c7faa0fa283) > > Clean backport. New test, low risk. > Test pass on manual run (mac, linux, x64 aarch64) using > make run-test TEST="test/jdk/sun/java2d/SunGraphics2D/CoordinateTruncationBug.java" This pull request has now been integrated. Changeset: 7964440d Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/7964440dd3274b84713c0debe1846092bb6d6d68 Stats: 271 lines in 1 file changed: 271 ins; 0 del; 0 mod 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Backport-of: c71d87e54ca0c0173583bed978e06c7faa0fa283 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1528 From duke at openjdk.org Mon Nov 21 23:06:33 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 23:06:33 GMT Subject: [jdk11u-dev] RFR: 8287895: Some langtools tests fail on msys2 Message-ID: applies cleanly (except for copyright header) - [JDK-8287895](https://bugs.openjdk.org/browse/JDK-8287895): Some langtools tests fail on msys2 ------------- Commit messages: - Backport f7791ad0ea984d49ff26e6f30233d8dcee4305b8 Changes: https://git.openjdk.org/jdk11u-dev/pull/1540/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1540&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287895 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1540.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1540/head:pull/1540 PR: https://git.openjdk.org/jdk11u-dev/pull/1540 From duke at openjdk.org Mon Nov 21 23:09:47 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 23:09:47 GMT Subject: [jdk11u-dev] RFR: 8287896: PropertiesTest.sh fail on msys2 Message-ID: <74J9JHdb7iWHL7vhVBD2zu_BPnPKxwBc_4BsV7LZ0WI=.0bb989b0-e9e8-4d89-bc5c-6ff86ca666e8@github.com> Applies cleanly (except for copyright header) backport of [JDK-8287896](https://bugs.openjdk.org/browse/JDK-8287896): PropertiesTest.sh fail on msys2 ------------- Commit messages: - Backport f1dd559e20342b892d0c1ed0314e5bba451bc5d3 Changes: https://git.openjdk.org/jdk11u-dev/pull/1541/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1541&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287896 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1541.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1541/head:pull/1541 PR: https://git.openjdk.org/jdk11u-dev/pull/1541 From duke at openjdk.org Mon Nov 21 23:14:28 2022 From: duke at openjdk.org (George Adams) Date: Mon, 21 Nov 2022 23:14:28 GMT Subject: [jdk11u-dev] RFR: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows Message-ID: This pull request contains a backport of [JDK-8287902](https://bugs.openjdk.org/browse/JDK-8287902), commit [975316e3](https://github.com/openjdk/jdk/commit/975316e3e5f1208e4e15eadc2493d25c15554647) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Magnus Ihse Bursie on 10 Jun 2022 and was reviewed by Naoto Sato. It fixes an issue that shows up in the new style GHA workflow. ------------- Commit messages: - Backport 975316e3e5f1208e4e15eadc2493d25c15554647 Changes: https://git.openjdk.org/jdk11u-dev/pull/1542/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1542&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287902 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1542.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1542/head:pull/1542 PR: https://git.openjdk.org/jdk11u-dev/pull/1542 From vrudomet at openjdk.org Tue Nov 22 00:27:38 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 22 Nov 2022 00:27:38 GMT Subject: [jdk17u-dev] RFR: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 06:51:10 GMT, Victor Rudometov wrote: > Backport for [JDK-8022403](https://bugs.openjdk.org/browse/JDK-8022403) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails > > Cherry-picked from https://github.com/openjdk/jdk/commit/65f7de252366e30ba18a22c107fc301c0fdc9378 > > Clean test backport, had to merge ProblemList.txt. > Test update, low risk. > Test passed during manual run using cmd: > make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Good point, totally agree to wait for this test to stabilize. Thank you. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/898 From vrudomet at openjdk.org Tue Nov 22 00:32:20 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 22 Nov 2022 00:32:20 GMT Subject: [jdk11u-dev] RFR: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails [v2] In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 07:00:07 GMT, Victor Rudometov wrote: >> Backport for [JDK-8022403](https://bugs.openjdk.org/browse/JDK-8022403) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails >> >> Cherry-picked from https://github.com/openjdk/jdk/commit/65f7de252366e30ba18a22c107fc301c0fdc9378 >> >> Clean test backport, had to merge ProblemList.txt. >> Test update, low risk. >> Test passed during manual run using cmd: >> make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java > > Victor Rudometov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 65f7de252366e30ba18a22c107fc301c0fdc9378 Will wait a bit for this test to stabilize before integrating. There is at least one more fix for this test in [JDK-8297153](https://bugs.openjdk.org/browse/JDK-8297153) (https://github.com/openjdk/jdk/commit/3c0949824e06f2b3d44f1bde9d2292a7627b0197) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1529 From btaylor at openjdk.org Tue Nov 22 01:11:48 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 22 Nov 2022 01:11:48 GMT Subject: [jdk17u-dev] RFR: 8273497: building.md should link to both md and html Message-ID: <13auB9odGxwMFMIzyFeOen89MJ3ta0KPQQtrzMdStMM=.cd2aaf93-44bb-4125-8fe3-8900f920f848@github.com> Documentation-only fix. This patch and [JDK-8285093](https://bugs.openjdk.org/browse/JDK-8285093) are needed to make [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) clean. ------------- Commit messages: - Backport 5bfd043e16fa79a101a1bee38c59d42d4cd69a48 Changes: https://git.openjdk.org/jdk17u-dev/pull/914/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=914&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273497 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/914.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/914/head:pull/914 PR: https://git.openjdk.org/jdk17u-dev/pull/914 From btaylor at openjdk.org Tue Nov 22 01:21:59 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 22 Nov 2022 01:21:59 GMT Subject: [jdk17u-dev] RFR: 8285093: Introduce UTIL_ARG_WITH Message-ID: Backporting to make [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) clean. This change is independent of #914 but both are required for [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/914 Commit messages: - Backport 94afb366b2ec76669e1aac38dbadc223ccafda3d Changes: https://git.openjdk.org/jdk17u-dev/pull/915/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=915&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285093 Stats: 381 lines in 2 files changed: 349 ins; 5 del; 27 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/915.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/915/head:pull/915 PR: https://git.openjdk.org/jdk17u-dev/pull/915 From btaylor at openjdk.org Tue Nov 22 01:35:17 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 22 Nov 2022 01:35:17 GMT Subject: [jdk17u-dev] RFR: 8285093: Introduce UTIL_ARG_WITH [v2] In-Reply-To: References: Message-ID: > Backporting to make [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) clean. > > This change is independent of #914 but both are required for [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). Ben Taylor has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: - Backport 94afb366b2ec76669e1aac38dbadc223ccafda3d - Backport 5bfd043e16fa79a101a1bee38c59d42d4cd69a48 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/915/files - new: https://git.openjdk.org/jdk17u-dev/pull/915/files/cfd8f19e..cf9bd011 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=915&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=915&range=00-01 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/915.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/915/head:pull/915 PR: https://git.openjdk.org/jdk17u-dev/pull/915 From btaylor at openjdk.org Tue Nov 22 01:47:37 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 22 Nov 2022 01:47:37 GMT Subject: [jdk17u-dev] RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries Message-ID: Backporting for parity with Oracle JDK 17. Patch is clean after [JDK-8273497](https://bugs.openjdk.org/browse/JDK-8273497) (#914) and [JDK-8285093](https://bugs.openjdk.org/browse/JDK-8285093) (#915). ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/915 Commit messages: - Backport f42caefe2e7658bfb5ab8ef938b134bdb6746ff1 Changes: https://git.openjdk.org/jdk17u-dev/pull/916/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=916&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293550 Stats: 212 lines in 10 files changed: 158 ins; 47 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/916.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/916/head:pull/916 PR: https://git.openjdk.org/jdk17u-dev/pull/916 From xlinzheng at openjdk.org Tue Nov 22 05:05:58 2022 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Tue, 22 Nov 2022 05:05:58 GMT Subject: [jdk19u] RFR: 8295414: [Aarch64] C2: assert(false) failed: bad AD file Message-ID: <9mnzo0rPmRAykKcXldtPZbJv5XKF7brBLuE4HXWQgUU=.93267bc0-4cf1-4225-945b-babfe719102e@github.com> This is a fix for a fast debug build assertion failure, and the impact is small. Clean backport from 20. Testing hotspot tier1~tier4. ------------- Commit messages: - 8295414: [Aarch64] C2: assert(false) failed: bad AD file Changes: https://git.openjdk.org/jdk19u/pull/78/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=78&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295414 Stats: 7 lines in 2 files changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/78.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/78/head:pull/78 PR: https://git.openjdk.org/jdk19u/pull/78 From xlinzheng at openjdk.org Tue Nov 22 05:07:35 2022 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Tue, 22 Nov 2022 05:07:35 GMT Subject: [jdk19u] RFR: 8296771: RISC-V: C2: assert(false) failed: bad AD file Message-ID: This is a fix for a fast debug build assertion failure, and the impact is small. Clean backport from 20. Testing currently. ------------- Commit messages: - 8296771: RISC-V: C2: assert(false) failed: bad AD file Changes: https://git.openjdk.org/jdk19u/pull/79/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=79&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296771 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/79.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/79/head:pull/79 PR: https://git.openjdk.org/jdk19u/pull/79 From shade at openjdk.org Tue Nov 22 10:01:39 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:01:39 GMT Subject: [jdk17u-dev] RFR: 8283999: Update JMH devkit to 1.35 In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 15:28:50 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. > > Additional testing: > - [x] JMH devkit creation still works Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/912 From shade at openjdk.org Tue Nov 22 10:02:49 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:02:49 GMT Subject: [jdk17u-dev] RFR: 8266519: Cleanup resolve() leftovers from BarrierSet et al In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 10:51:06 GMT, Aleksey Shipilev wrote: > Clean backport to simplify GC interface for better maintainability. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` > - [x] Linux x86_64 fastdebug `tier2` Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/907 From shade at openjdk.org Tue Nov 22 10:04:15 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:04:15 GMT Subject: [jdk17u-dev] RFR: 8280016: gc/g1/TestShrinkAuxiliaryData30 test fails on large machines In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 12:39:00 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. > > Additional testing: > - [x] Affected test passes Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/908 From shade at openjdk.org Tue Nov 22 10:04:30 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:04:30 GMT Subject: [jdk17u-dev] RFR: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 16:15:17 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the tests and hopefully resolve some GHA 17u intermittent failures. I was not able to reproduce the failures locally, so I am backporting this blindly. > > Additional testing: > - [x] Linux x86_64 fastdebug, `gc/stringdedup` (100 repetitions) Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/913 From shade at openjdk.org Tue Nov 22 10:05:46 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:05:46 GMT Subject: [jdk17u-dev] Integrated: 8283999: Update JMH devkit to 1.35 In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 15:28:50 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. > > Additional testing: > - [x] JMH devkit creation still works This pull request has now been integrated. Changeset: 51253206 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/512532067efd1c96d5d0eea3d38503482e9a99ce Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8283999: Update JMH devkit to 1.35 Backport-of: a3223cb6839dbed2476c928572d89dad84dc4636 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/912 From shade at openjdk.org Tue Nov 22 10:05:56 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:05:56 GMT Subject: [jdk17u-dev] Integrated: 8266519: Cleanup resolve() leftovers from BarrierSet et al In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 10:51:06 GMT, Aleksey Shipilev wrote: > Clean backport to simplify GC interface for better maintainability. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` > - [x] Linux x86_64 fastdebug `tier2` This pull request has now been integrated. Changeset: 24ac3473 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/24ac347348fe07c542bedbe52bc3dc934422a651 Stats: 41 lines in 4 files changed: 0 ins; 40 del; 1 mod 8266519: Cleanup resolve() leftovers from BarrierSet et al Backport-of: 7eccbd4fde58ea36d6a21a2c4ffa3bc5d0b38c10 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/907 From shade at openjdk.org Tue Nov 22 10:08:04 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:08:04 GMT Subject: [jdk17u-dev] Integrated: 8280016: gc/g1/TestShrinkAuxiliaryData30 test fails on large machines In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 12:39:00 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. > > Additional testing: > - [x] Affected test passes This pull request has now been integrated. Changeset: 14eb228c Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/14eb228cc596b946e5786e06d7a6b33063d6e8aa Stats: 92 lines in 2 files changed: 46 ins; 46 del; 0 mod 8280016: gc/g1/TestShrinkAuxiliaryData30 test fails on large machines Backport-of: 590eb86033d5445018cd0e961e8721a20de4bb0c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/908 From shade at openjdk.org Tue Nov 22 10:08:14 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:08:14 GMT Subject: [jdk17u-dev] Integrated: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 16:15:17 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the tests and hopefully resolve some GHA 17u intermittent failures. I was not able to reproduce the failures locally, so I am backporting this blindly. > > Additional testing: > - [x] Linux x86_64 fastdebug, `gc/stringdedup` (100 repetitions) This pull request has now been integrated. Changeset: c260e8a9 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/c260e8a9320b4e61bccf97f5f04db031e927bd2c Stats: 49 lines in 1 file changed: 43 ins; 2 del; 4 mod 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah Backport-of: f9b2507f3e86bcb91e8ccfd0a84f31712fd535c2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/913 From shade at openjdk.org Tue Nov 22 10:11:38 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:11:38 GMT Subject: [jdk17u-dev] RFR: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long In-Reply-To: References: Message-ID: <0fyveQba_qwhzCAi_yQFk9-LnBnh9YYJtixPhXgRrQw=.8dee366d-e63d-4528-bde2-c99c7cfa3ccb@github.com> On Mon, 21 Nov 2022 14:02:51 GMT, Aleksey Shipilev wrote: > Clean backport to make ARM32 safer. > > Additional testing: > - [x] Linux ARM32 cross-builds > - [x] Linux ARM32 `make bootcycle-images` Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/909 From shade at openjdk.org Tue Nov 22 10:15:04 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:15:04 GMT Subject: [jdk17u-dev] Integrated: 8273380: ARM32: Default to {ldrexd, strexd} in StubRoutines::atomic_{load|store}_long In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 14:02:51 GMT, Aleksey Shipilev wrote: > Clean backport to make ARM32 safer. > > Additional testing: > - [x] Linux ARM32 cross-builds > - [x] Linux ARM32 `make bootcycle-images` This pull request has now been integrated. Changeset: 174c147a Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/174c147ae18c8adc1803bbd0d81e2acc219e8bef Stats: 20 lines in 1 file changed: 8 ins; 8 del; 4 mod 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long Backport-of: 718eff2bb6e938440df9f7b982ef6d2f4060a759 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/909 From shade at openjdk.org Tue Nov 22 10:19:50 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:19:50 GMT Subject: [jdk17u-dev] RFR: 8274903: Zero: Support AsyncGetCallTrace In-Reply-To: References: Message-ID: <4SdUE6AAn1hjMmg7S54T79i1Vq59rie6xfiXLvQR0h0=.697805b1-d7fc-4fc9-8054-b3c828b1f7ac@github.com> On Wed, 16 Nov 2022 11:28:23 GMT, Aleksey Shipilev wrote: > Clean backport to improve Zero maintenance. > > Additional testing: > - [x] Linux x86_64 Zero, eyeballing JMH `-prof async` results > - [x] Linux x86_64 Zero fastdebug `make bootcycle-images` Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/885 From shade at openjdk.org Tue Nov 22 10:19:50 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Nov 2022 10:19:50 GMT Subject: [jdk17u-dev] Integrated: 8274903: Zero: Support AsyncGetCallTrace In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 11:28:23 GMT, Aleksey Shipilev wrote: > Clean backport to improve Zero maintenance. > > Additional testing: > - [x] Linux x86_64 Zero, eyeballing JMH `-prof async` results > - [x] Linux x86_64 Zero fastdebug `make bootcycle-images` This pull request has now been integrated. Changeset: 842edfe1 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/842edfe146b4806ce3d65e76135b52c50e54a0c0 Stats: 149 lines in 4 files changed: 131 ins; 6 del; 12 mod 8274903: Zero: Support AsyncGetCallTrace Backport-of: 92aa75b72185c681757e6520d6fdc1ae4161d0c5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/885 From clanger at openjdk.org Tue Nov 22 10:29:31 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 22 Nov 2022 10:29:31 GMT Subject: [jdk11u-dev] RFR: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 16:50:10 GMT, Johannes Bechberger wrote: > Removes an unnecessary register push which currently makes stack walking impossible for async-profiler. Approved. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1524 From duke at openjdk.org Tue Nov 22 10:33:37 2022 From: duke at openjdk.org (Johannes Bechberger) Date: Tue, 22 Nov 2022 10:33:37 GMT Subject: [jdk11u-dev] Integrated: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path In-Reply-To: References: Message-ID: On Wed, 16 Nov 2022 16:50:10 GMT, Johannes Bechberger wrote: > Removes an unnecessary register push which currently makes stack walking impossible for async-profiler. This pull request has now been integrated. Changeset: 7340e1bd Author: Johannes Bechberger Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/7340e1bdc05cefeec959a9db372ef6f093e15cc9 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path Reviewed-by: phh Backport-of: b5a646ee6cfd432cef6b7e69a177959227a38ace ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1524 From clanger at openjdk.org Tue Nov 22 10:35:28 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 22 Nov 2022 10:35:28 GMT Subject: [jdk11u-dev] RFR: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 23:05:35 GMT, George Adams wrote: > This pull request contains a backport of [JDK-8287902](https://bugs.openjdk.org/browse/JDK-8287902), commit [975316e3](https://github.com/openjdk/jdk/commit/975316e3e5f1208e4e15eadc2493d25c15554647) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Magnus Ihse Bursie on 10 Jun 2022 and was reviewed by Naoto Sato. > > It fixes an issue that shows up in the new style GHA workflow. @gdams Weird that you still need a sponsor. Maybe the Skara bots are checking the JDK repository for committer status (which would be wrong...) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1542 From duke at openjdk.org Tue Nov 22 10:37:25 2022 From: duke at openjdk.org (George Adams) Date: Tue, 22 Nov 2022 10:37:25 GMT Subject: [jdk11u-dev] Integrated: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows In-Reply-To: References: Message-ID: <1K5Bmts13VgtrrVe0c8CajdIfRxK801VIlqmWqwt-M0=.8a916bd1-f23f-43e9-a4da-07b44ad63ee9@github.com> On Mon, 21 Nov 2022 23:05:35 GMT, George Adams wrote: > This pull request contains a backport of [JDK-8287902](https://bugs.openjdk.org/browse/JDK-8287902), commit [975316e3](https://github.com/openjdk/jdk/commit/975316e3e5f1208e4e15eadc2493d25c15554647) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Magnus Ihse Bursie on 10 Jun 2022 and was reviewed by Naoto Sato. > > It fixes an issue that shows up in the new style GHA workflow. This pull request has now been integrated. Changeset: f27d48ec Author: George Adams Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/f27d48ec6ec40b296e3ad809f06eb2fd1c761ea5 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows Backport-of: 975316e3e5f1208e4e15eadc2493d25c15554647 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1542 From clanger at openjdk.org Tue Nov 22 11:12:49 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 22 Nov 2022 11:12:49 GMT Subject: [jdk19u] RFR: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds Message-ID: Hi all, This pull request contains a backport of [JDK-8296945](https://bugs.openjdk.org/browse/JDK-8296945), commit [bcc6b12b](https://github.com/openjdk/jdk/commit/bcc6b12b711a9c5007d963123fb38a7e72aaf8e5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Matthias Baesken on 21 Nov 2022 and was reviewed by Mandy Chung and Tobias Hartmann. Thanks! ------------- Commit messages: - Backport bcc6b12b711a9c5007d963123fb38a7e72aaf8e5 Changes: https://git.openjdk.org/jdk19u/pull/80/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=80&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296945 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk19u/pull/80.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/80/head:pull/80 PR: https://git.openjdk.org/jdk19u/pull/80 From gdams at openjdk.org Tue Nov 22 12:16:11 2022 From: gdams at openjdk.org (George Adams) Date: Tue, 22 Nov 2022 12:16:11 GMT Subject: [jdk11u-dev] Integrated: 8287895: Some langtools tests fail on msys2 In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 22:57:28 GMT, George Adams wrote: > applies cleanly (except for copyright header) - [JDK-8287895](https://bugs.openjdk.org/browse/JDK-8287895): Some langtools tests fail on msys2 This pull request has now been integrated. Changeset: 3bdd3706 Author: George Adams URL: https://git.openjdk.org/jdk11u-dev/commit/3bdd37064e111d322b856e8afb2d25a97f812970 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8287895: Some langtools tests fail on msys2 Backport-of: f7791ad0ea984d49ff26e6f30233d8dcee4305b8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1540 From gdams at openjdk.org Tue Nov 22 12:17:42 2022 From: gdams at openjdk.org (George Adams) Date: Tue, 22 Nov 2022 12:17:42 GMT Subject: [jdk11u-dev] Integrated: 8287896: PropertiesTest.sh fail on msys2 In-Reply-To: <74J9JHdb7iWHL7vhVBD2zu_BPnPKxwBc_4BsV7LZ0WI=.0bb989b0-e9e8-4d89-bc5c-6ff86ca666e8@github.com> References: <74J9JHdb7iWHL7vhVBD2zu_BPnPKxwBc_4BsV7LZ0WI=.0bb989b0-e9e8-4d89-bc5c-6ff86ca666e8@github.com> Message-ID: <4pPDFYUnzbeqZ1Qsz6SJo9LNSCpjv3LDz1OQ4FE8LPQ=.da76992b-3504-4478-92f5-8bfba41dc34a@github.com> On Mon, 21 Nov 2022 23:00:34 GMT, George Adams wrote: > Applies cleanly (except for copyright header) backport of [JDK-8287896](https://bugs.openjdk.org/browse/JDK-8287896): PropertiesTest.sh fail on msys2 This pull request has now been integrated. Changeset: 18055b84 Author: George Adams URL: https://git.openjdk.org/jdk11u-dev/commit/18055b84a4e6d7e9136fd7b02ba68579c4812880 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8287896: PropertiesTest.sh fail on msys2 Backport-of: f1dd559e20342b892d0c1ed0314e5bba451bc5d3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1541 From gdams at openjdk.org Tue Nov 22 15:23:33 2022 From: gdams at openjdk.org (George Adams) Date: Tue, 22 Nov 2022 15:23:33 GMT Subject: [jdk11u-dev] RFR: 8259485: Document need for short paths when building on Windows Message-ID: Backports a simple docs change ------------- Commit messages: - Backport 2243a1703b81aba2da0a943fc486e34f635f662c Changes: https://git.openjdk.org/jdk11u-dev/pull/1543/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1543&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8259485 Stats: 15 lines in 2 files changed: 15 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1543.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1543/head:pull/1543 PR: https://git.openjdk.org/jdk11u-dev/pull/1543 From thartmann at openjdk.org Tue Nov 22 16:00:36 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 22 Nov 2022 16:00:36 GMT Subject: [jdk19u] RFR: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite() Message-ID: <7bqjWz-93PIcBfl-jL4jHjq8I0sbwEefjEpxfljApwg=.366ae82d-2122-4091-9004-cc23b897dd3f@github.com> Backport of [JDK-8294538](https://bugs.openjdk.java.net/browse/JDK-8294538). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite() Changes: https://git.openjdk.org/jdk19u/pull/81/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=81&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294538 Stats: 22 lines in 3 files changed: 9 ins; 12 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/81.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/81/head:pull/81 PR: https://git.openjdk.org/jdk19u/pull/81 From thartmann at openjdk.org Tue Nov 22 16:02:37 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 22 Nov 2022 16:02:37 GMT Subject: [jdk19u] RFR: 8295414: [Aarch64] C2: assert(false) failed: bad AD file In-Reply-To: <9mnzo0rPmRAykKcXldtPZbJv5XKF7brBLuE4HXWQgUU=.93267bc0-4cf1-4225-945b-babfe719102e@github.com> References: <9mnzo0rPmRAykKcXldtPZbJv5XKF7brBLuE4HXWQgUU=.93267bc0-4cf1-4225-945b-babfe719102e@github.com> Message-ID: <1SFgZxBNEmlyWDq7UGWR0yS2MBtauYVo4O-Yu_oFKsY=.3037797a-1edb-4ff4-829a-4bb3a7dc5fe1@github.com> On Tue, 22 Nov 2022 04:57:44 GMT, Xiaolin Zheng wrote: > This is a fix for a fast debug build assertion failure, and the impact is small. > Clean backport from 20. > > Testing hotspot tier1~tier4. Looks good. ------------- Marked as reviewed by thartmann (Reviewer). PR: https://git.openjdk.org/jdk19u/pull/78 From thartmann at openjdk.org Tue Nov 22 16:06:15 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 22 Nov 2022 16:06:15 GMT Subject: [jdk19u] RFR: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work Message-ID: Backport of [JDK-8285835](https://bugs.openjdk.java.net/browse/JDK-8285835). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work Changes: https://git.openjdk.org/jdk19u/pull/82/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=82&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285835 Stats: 145 lines in 3 files changed: 135 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk19u/pull/82.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/82/head:pull/82 PR: https://git.openjdk.org/jdk19u/pull/82 From thartmann at openjdk.org Tue Nov 22 16:10:41 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 22 Nov 2022 16:10:41 GMT Subject: [jdk19u] RFR: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes" Message-ID: Backport of [JDK-8290964](https://bugs.openjdk.java.net/browse/JDK-8290964). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes" Changes: https://git.openjdk.org/jdk19u/pull/84/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=84&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290964 Stats: 21 lines in 3 files changed: 0 ins; 21 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/84.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/84/head:pull/84 PR: https://git.openjdk.org/jdk19u/pull/84 From thartmann at openjdk.org Tue Nov 22 16:14:23 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 22 Nov 2022 16:14:23 GMT Subject: [jdk19u] RFR: 8292780: misc tests failed "assert(false) failed: graph should be schedulable" Message-ID: Backport of [JDK-8292780](https://bugs.openjdk.java.net/browse/JDK-8292780). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8292780: misc tests failed "assert(false) failed: graph should be schedulable" Changes: https://git.openjdk.org/jdk19u/pull/85/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=85&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292780 Stats: 52 lines in 2 files changed: 51 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/85.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/85/head:pull/85 PR: https://git.openjdk.org/jdk19u/pull/85 From thartmann at openjdk.org Tue Nov 22 16:15:37 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 22 Nov 2022 16:15:37 GMT Subject: [jdk19u] RFR: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop Message-ID: Backport of [JDK-8293996](https://bugs.openjdk.java.net/browse/JDK-8293996). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop Changes: https://git.openjdk.org/jdk19u/pull/86/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=86&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293996 Stats: 65 lines in 2 files changed: 38 ins; 17 del; 10 mod Patch: https://git.openjdk.org/jdk19u/pull/86.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/86/head:pull/86 PR: https://git.openjdk.org/jdk19u/pull/86 From thartmann at openjdk.org Tue Nov 22 16:20:07 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 22 Nov 2022 16:20:07 GMT Subject: [jdk19u] RFR: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency Message-ID: <3g_pbLEnC6LLnVnGhqI02pQI7qXWlLj21MCvrp8JVPA=.0bda7107-f428-4536-b3fa-87daae210215@github.com> Backport of [JDK-8287217](https://bugs.openjdk.java.net/browse/JDK-8287217). Patch did not apply cleanly due to differences in surrounding code in `PhaseCCP::analyze`. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency Changes: https://git.openjdk.org/jdk19u/pull/87/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=87&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287217 Stats: 102 lines in 5 files changed: 81 ins; 2 del; 19 mod Patch: https://git.openjdk.org/jdk19u/pull/87.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/87/head:pull/87 PR: https://git.openjdk.org/jdk19u/pull/87 From vrudomet at openjdk.org Tue Nov 22 17:15:37 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 22 Nov 2022 17:15:37 GMT Subject: [jdk11u-dev] Integrated: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout In-Reply-To: References: Message-ID: On Sat, 19 Nov 2022 06:59:17 GMT, Victor Rudometov wrote: > Backport for [JDK-8178698](https://bugs.openjdk.org/browse/JDK-8178698) javax/sound/midi/Sequencer/MetaCallback.java failed with timeout https://github.com/openjdk/jdk/commit/43ce047f9f417a1d8afa83a3d2c2429a478975db > > Clean backport for test, had to merge ProblemList.txt > Test update, low risk. > Test passes on mac & linux using make run-test TEST="test/jdk/javax/sound/midi/Sequencer/MetaCallback.java" This pull request has now been integrated. Changeset: 57111978 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/57111978d2b7d6b44f1b170ee17c20f66a6df7db Stats: 28 lines in 2 files changed: 22 ins; 1 del; 5 mod 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout Reviewed-by: phh Backport-of: 43ce047f9f417a1d8afa83a3d2c2429a478975db ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1534 From vrudomet at openjdk.org Tue Nov 22 17:18:45 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 22 Nov 2022 17:18:45 GMT Subject: [jdk11u-dev] Integrated: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" In-Reply-To: <_yT0lORIn90apNJVyWfrxi76AL19lg1SRp3fj1XUrzo=.3512099a-6461-431d-bffe-8e9e24ff7745@github.com> References: <_yT0lORIn90apNJVyWfrxi76AL19lg1SRp3fj1XUrzo=.3512099a-6461-431d-bffe-8e9e24ff7745@github.com> Message-ID: On Sat, 19 Nov 2022 05:03:46 GMT, Victor Rudometov wrote: > Backport for [JDK-8285604](https://bugs.openjdk.org/browse/JDK-8285604) closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" https://github.com/openjdk/jdk/commit/c56c69ed3e09df1b56e340498dc28ba50815d15e > > Clean backport. > New test, low risk. > Test passed with command: make run-test TEST="test/jdk/sun/java2d/GdiRendering/ClipShapeRendering.java" This pull request has now been integrated. Changeset: 597a8009 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/597a8009dec1d94be10129b50b882f04e086811e Stats: 518 lines in 1 file changed: 518 ins; 0 del; 0 mod 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)" Backport-of: c56c69ed3e09df1b56e340498dc28ba50815d15e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1533 From eosterlund at openjdk.org Tue Nov 22 17:19:49 2022 From: eosterlund at openjdk.org (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Tue, 22 Nov 2022 17:19:49 GMT Subject: [jdk19u] RFR: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite() In-Reply-To: <7bqjWz-93PIcBfl-jL4jHjq8I0sbwEefjEpxfljApwg=.366ae82d-2122-4091-9004-cc23b897dd3f@github.com> References: <7bqjWz-93PIcBfl-jL4jHjq8I0sbwEefjEpxfljApwg=.366ae82d-2122-4091-9004-cc23b897dd3f@github.com> Message-ID: On Tue, 22 Nov 2022 15:51:17 GMT, Tobias Hartmann wrote: > Backport of [JDK-8294538](https://bugs.openjdk.java.net/browse/JDK-8294538). Applies cleanly. Approval is pending. > > Thanks, > Tobias Looks good. ------------- Marked as reviewed by eosterlund (Committer). PR: https://git.openjdk.org/jdk19u/pull/81 From jbhateja at openjdk.org Tue Nov 22 17:48:54 2022 From: jbhateja at openjdk.org (Jatin Bhateja) Date: Tue, 22 Nov 2022 17:48:54 GMT Subject: [jdk17u-dev] RFR: 8297441: Optimize Vector.rearrange over byte vectors for AVX512BW targets. Message-ID: Backport of [JDK-8290322](https://bugs.openjdk.org/browse/JDK-8290322), due to multiple dependencies backport was not clean. Patch enables wide vector byte level permutation for AVX512BW targets and benefits multiple generations of Intel's Xeon servers (SKX, CLX, CPX) prior to Ice lake which provides a direct HW instruction (VPERMB). JIT instruction sequence emitted in this case is specific to Vector.rearrange API, hence the scope of the patch is limited to VectorAPIs which is an incubating module currently. Vector API jtreg test suite contains multiple tests cases for ByteVector.SPECIES_512 to extensively tests the patch. Original patch review was done with [PR 9498](https://github.com/openjdk/jdk/pull/9498) ------------- Commit messages: - 8297441: Optimize Vector.rearrange over byte vectors for AVX512BW targets. Changes: https://git.openjdk.org/jdk17u-dev/pull/917/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=917&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297441 Stats: 193 lines in 6 files changed: 188 ins; 4 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/917.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/917/head:pull/917 PR: https://git.openjdk.org/jdk17u-dev/pull/917 From thartmann at openjdk.org Tue Nov 22 18:22:38 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 22 Nov 2022 18:22:38 GMT Subject: [jdk19u] RFR: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite() In-Reply-To: <7bqjWz-93PIcBfl-jL4jHjq8I0sbwEefjEpxfljApwg=.366ae82d-2122-4091-9004-cc23b897dd3f@github.com> References: <7bqjWz-93PIcBfl-jL4jHjq8I0sbwEefjEpxfljApwg=.366ae82d-2122-4091-9004-cc23b897dd3f@github.com> Message-ID: <8A2QbEq3I26Zh_8v_lN8z9TzRd_KS8dP4bs_QdQfHc8=.43949ddd-2be1-42a9-b08f-77b61258417c@github.com> On Tue, 22 Nov 2022 15:51:17 GMT, Tobias Hartmann wrote: > Backport of [JDK-8294538](https://bugs.openjdk.java.net/browse/JDK-8294538). Applies cleanly. Approval is pending. > > Thanks, > Tobias Thanks for the review, Erik! ------------- PR: https://git.openjdk.org/jdk19u/pull/81 From cushon at openjdk.org Tue Nov 22 19:15:31 2022 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Tue, 22 Nov 2022 19:15:31 GMT Subject: [jdk11u-dev] RFR: 8222091: Javadoc does not handle package annotations correctly on package-info.java In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 17:06:11 GMT, Liam Miller-Cushon wrote: > This is a backport of [JDK-8222091: Javadoc does not handle package annotations correctly on package-info.java](https://bugs.openjdk.java.net/browse/JDK-8222091) > > This fixes a regression in 11.0.17 caused by the backport of [JDK-8193462](https://bugs.openjdk.org/browse/JDK-8193462), see [JDK-8295850](https://bugs.openjdk.org/browse/JDK-8295850) > > Original patch applied cleanly, the test was updated due to some changes in test infrastructrure: > > > diff --git a/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java b/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java > index cd9697eede..9f04777f81 100644 > --- a/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java > +++ b/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java > @@ -25,14 +25,12 @@ > * @test > * @bug 8222091 > * @summary Javadoc does not handle package annotations correctly on package-info.java > - * @library ../../lib/ > + * @library ../lib/ > * @modules jdk.javadoc/jdk.javadoc.internal.tool > - * @build javadoc.tester.* > + * @build JavadocTester > * @run main TestPackageAnnotation > */ > > -import javadoc.tester.JavadocTester; > - > public class TestPackageAnnotation extends JavadocTester { > > public static void main(String... args) throws Exception { > > > Tested: tier1 langtools tests passed Any takers? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1475 From vrudomet at openjdk.org Tue Nov 22 20:10:32 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 22 Nov 2022 20:10:32 GMT Subject: [jdk19u] RFR: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Message-ID: Backport for [JDK-8022403](https://bugs.openjdk.org/browse/JDK-8022403) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Cherry-picked from https://github.com/openjdk/jdk/commit/65f7de252366e30ba18a22c107fc301c0fdc9378 Clean test backport. Test update, low risk. Test passed during manual run on mac and linux using cmd: make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java There's a followup fix for this test, that will be also backported. ------------- Commit messages: - 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Changes: https://git.openjdk.org/jdk19u/pull/89/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=89&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8022403 Stats: 159 lines in 2 files changed: 49 ins; 34 del; 76 mod Patch: https://git.openjdk.org/jdk19u/pull/89.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/89/head:pull/89 PR: https://git.openjdk.org/jdk19u/pull/89 From vrudomet at openjdk.org Tue Nov 22 20:33:37 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 22 Nov 2022 20:33:37 GMT Subject: [jdk17u-dev] Integrated: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 06:51:10 GMT, Victor Rudometov wrote: > Backport for [JDK-8022403](https://bugs.openjdk.org/browse/JDK-8022403) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails > > Cherry-picked from https://github.com/openjdk/jdk/commit/65f7de252366e30ba18a22c107fc301c0fdc9378 > > Clean test backport, had to merge ProblemList.txt. > Test update, low risk. > Test passed during manual run using cmd: > make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java This pull request has now been integrated. Changeset: 4a9774af Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/4a9774afd9c2fb64e7cf9515473a516051e64206 Stats: 159 lines in 2 files changed: 49 ins; 34 del; 76 mod 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Backport-of: 65f7de252366e30ba18a22c107fc301c0fdc9378 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/898 From vrudomet at openjdk.org Tue Nov 22 20:34:12 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 22 Nov 2022 20:34:12 GMT Subject: [jdk11u-dev] Integrated: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 06:50:29 GMT, Victor Rudometov wrote: > Backport for [JDK-8022403](https://bugs.openjdk.org/browse/JDK-8022403) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails > > Cherry-picked from https://github.com/openjdk/jdk/commit/65f7de252366e30ba18a22c107fc301c0fdc9378 > > Clean test backport, had to merge ProblemList.txt. > Test update, low risk. > Test passed during manual run using cmd: > make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java This pull request has now been integrated. Changeset: c488e046 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/c488e046f38ea33aeaf1880470116a0c2238ed4b Stats: 159 lines in 2 files changed: 49 ins; 34 del; 76 mod 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Backport-of: 65f7de252366e30ba18a22c107fc301c0fdc9378 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1529 From btaylor at openjdk.org Tue Nov 22 20:39:46 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 22 Nov 2022 20:39:46 GMT Subject: [jdk17u-dev] RFR: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response Message-ID: Backporting to 17 for improved performance. Backport is clean. ------------- Commit messages: - Backport 392ac7055d4697c56fa85ac5572f5bc4dc431f1d Changes: https://git.openjdk.org/jdk17u-dev/pull/918/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=918&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297211 Stats: 25 lines in 2 files changed: 9 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/918.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/918/head:pull/918 PR: https://git.openjdk.org/jdk17u-dev/pull/918 From duke at openjdk.org Tue Nov 22 20:43:27 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 22 Nov 2022 20:43:27 GMT Subject: [jdk11u-dev] RFR: JDK-8261352- Create implementation for component peer for all the components who should be ignored in a11y interactions Message-ID: [JDK-8261352](https://bugs.openjdk.org/browse/JDK-8261352) Mostly clean, 3/28 backports for accessibility. ------------- Commit messages: - JDK-8261352 create implementation for component peer for all the components who should be ignored in a11y interactions - 8256110: Create implementation for NSAccessibilityStepper protocol Changes: https://git.openjdk.org/jdk11u-dev/pull/1545/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1545&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261352 Stats: 580 lines in 9 files changed: 526 ins; 51 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1545.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1545/head:pull/1545 PR: https://git.openjdk.org/jdk11u-dev/pull/1545 From vrudomet at openjdk.org Tue Nov 22 20:49:30 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 22 Nov 2022 20:49:30 GMT Subject: [jdk19u] RFR: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Message-ID: Backport for [JDK-8297153](https://bugs.openjdk.org/browse/JDK-8297153) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again [JDK-8297241](https://bugs.openjdk.org/browse/JDK-8297241) Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Original commit: https://github.com/openjdk/jdk/commit/3c0949824e06f2b3d44f1bde9d2292a7627b0197 Clean backport. Fixing unstable test. Checked on mac and linux by running: make run-test TEST="test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java" This PR depends on https://github.com/openjdk/jdk19u/pull/89 ------------- Depends on: https://git.openjdk.org/jdk19u/pull/89 Commit messages: - 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Changes: https://git.openjdk.org/jdk19u/pull/90/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=90&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297241 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/90.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/90/head:pull/90 PR: https://git.openjdk.org/jdk19u/pull/90 From vrudomet at openjdk.org Tue Nov 22 21:38:19 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 22 Nov 2022 21:38:19 GMT Subject: [jdk17u-dev] RFR: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Message-ID: Backport for [JDK-8297153](https://bugs.openjdk.org/browse/JDK-8297153) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again [JDK-8297241](https://bugs.openjdk.org/browse/JDK-8297241) Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Original commit: https://github.com/openjdk/jdk/commit/3c0949824e06f2b3d44f1bde9d2292a7627b0197 Clean backport. Fixing unstable test. Checked on mac and linux by running: make run-test TEST="test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java" ------------- Commit messages: - 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Changes: https://git.openjdk.org/jdk17u-dev/pull/919/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=919&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297241 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/919.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/919/head:pull/919 PR: https://git.openjdk.org/jdk17u-dev/pull/919 From vrudomet at openjdk.org Tue Nov 22 21:39:16 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 22 Nov 2022 21:39:16 GMT Subject: [jdk11u-dev] RFR: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Message-ID: <6Y8_G48kLjyzptI6G72y-V24iJnWka7fTdEgt9oHOjU=.b08c3125-abbb-47bd-893a-9e5a7f7a6e9f@github.com> Backport for [JDK-8297153](https://bugs.openjdk.org/browse/JDK-8297153) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again [JDK-8297241](https://bugs.openjdk.org/browse/JDK-8297241) Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Original commit: https://github.com/openjdk/jdk/commit/3c0949824e06f2b3d44f1bde9d2292a7627b0197 Clean backport. Fixing unstable test. Checked on mac and linux by running: make run-test TEST="test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java" ------------- Commit messages: - 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Changes: https://git.openjdk.org/jdk11u-dev/pull/1546/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1546&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297241 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1546.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1546/head:pull/1546 PR: https://git.openjdk.org/jdk11u-dev/pull/1546 From serb at openjdk.org Tue Nov 22 21:58:20 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 22 Nov 2022 21:58:20 GMT Subject: [jdk19u] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Message-ID: Hi all, This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. Thanks! ------------- Commit messages: - Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8 Changes: https://git.openjdk.org/jdk19u/pull/88/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=88&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296957 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/88.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/88/head:pull/88 PR: https://git.openjdk.org/jdk19u/pull/88 From duke at openjdk.org Tue Nov 22 22:11:21 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 22 Nov 2022 22:11:21 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol Message-ID: Backport-of: a54adefb246d945fee88e19ca38b601ffc628305 for [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8259779) Mostly clean backport. 2/28 of the series of backports. ------------- Commit messages: - 8256110: Create implementation for NSAccessibilityStepper protocol Changes: https://git.openjdk.org/jdk11u-dev/pull/1544/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1544&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256110 Stats: 404 lines in 6 files changed: 387 ins; 15 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1544.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1544/head:pull/1544 PR: https://git.openjdk.org/jdk11u-dev/pull/1544 From duke at openjdk.org Wed Nov 23 00:05:19 2022 From: duke at openjdk.org (zzambers) Date: Wed, 23 Nov 2022 00:05:19 GMT Subject: [jdk11u-dev] RFR: 8295952: Problemlist existing compiler/rtm tests also on x86 Message-ID: Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected. ------------- Commit messages: - Backport 3f2f128af6ec2f9097af7758bfd41aeaa4354d40 Changes: https://git.openjdk.org/jdk11u-dev/pull/1547/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1547&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295952 Stats: 11 lines in 1 file changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1547.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1547/head:pull/1547 PR: https://git.openjdk.org/jdk11u-dev/pull/1547 From duke at openjdk.org Wed Nov 23 00:06:45 2022 From: duke at openjdk.org (zzambers) Date: Wed, 23 Nov 2022 00:06:45 GMT Subject: [jdk17u-dev] RFR: 8295952: Problemlist existing compiler/rtm tests also on x86 Message-ID: Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected. ------------- Commit messages: - Backport 3f2f128af6ec2f9097af7758bfd41aeaa4354d40 Changes: https://git.openjdk.org/jdk17u-dev/pull/920/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=920&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295952 Stats: 11 lines in 1 file changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/920.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/920/head:pull/920 PR: https://git.openjdk.org/jdk17u-dev/pull/920 From duke at openjdk.org Wed Nov 23 00:43:29 2022 From: duke at openjdk.org (zzambers) Date: Wed, 23 Nov 2022 00:43:29 GMT Subject: [jdk11u-dev] RFR: 8295952: Problemlist existing compiler/rtm tests also on x86 In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 23:58:43 GMT, zzambers wrote: > Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected. Test failure on MacOS seems to be caused by very slow test machine. (Tests took much longer than on other platforms, 1 test timeouted.) ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1547 From duke at openjdk.org Wed Nov 23 00:47:20 2022 From: duke at openjdk.org (zzambers) Date: Wed, 23 Nov 2022 00:47:20 GMT Subject: [jdk17u-dev] RFR: 8295952: Problemlist existing compiler/rtm tests also on x86 In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 23:57:12 GMT, zzambers wrote: > Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected. One build failure caused by failed checksum on asmtools sources (?) does not seem to have any relation to this change. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/920 From duke at openjdk.org Wed Nov 23 00:50:33 2022 From: duke at openjdk.org (Bo Zhang) Date: Wed, 23 Nov 2022 00:50:33 GMT Subject: [jdk11u] RFR: 8292434: javadoc generation fails if javadoc contains @see with generics Message-ID: This is a backport of JDK-8177280. ------------- Commit messages: - 8292434: javadoc generation fails if javadoc contains @see with generics Changes: https://git.openjdk.org/jdk11u/pull/61/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=61&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292434 Stats: 525 lines in 15 files changed: 329 ins; 131 del; 65 mod Patch: https://git.openjdk.org/jdk11u/pull/61.diff Fetch: git fetch https://git.openjdk.org/jdk11u pull/61/head:pull/61 PR: https://git.openjdk.org/jdk11u/pull/61 From andrew at openjdk.org Wed Nov 23 00:53:31 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 23 Nov 2022 00:53:31 GMT Subject: [jdk17u-dev] RFR: 8289301: P11Cipher should not throw out of bounds exception during padding In-Reply-To: References: Message-ID: On Wed, 21 Sep 2022 11:07:26 GMT, zzambers wrote: > Backport fixing possible out of bounds exception during padding in P11Cipher. > > Applied cleanly. Passed jdk_security tests. It looks like this one has been missed because `jdk17-fix-request` was added rather than `jdk17u-fix-request`. I've fixed this now and approved. Feel free to integrate. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/706 From duke at openjdk.org Wed Nov 23 00:53:43 2022 From: duke at openjdk.org (Bo Zhang) Date: Wed, 23 Nov 2022 00:53:43 GMT Subject: [jdk11u] RFR: 8292434: javadoc generation fails if javadoc contains @see with generics [v2] In-Reply-To: References: Message-ID: > This is a backport of JDK-8177280. Bo Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8292434: javadoc generation fails if javadoc contains @see with generics This is a backport of JDK-8177280. ------------- Changes: - all: https://git.openjdk.org/jdk11u/pull/61/files - new: https://git.openjdk.org/jdk11u/pull/61/files/ac43e851..e8c19330 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u&pr=61&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u&pr=61&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u/pull/61.diff Fetch: git fetch https://git.openjdk.org/jdk11u pull/61/head:pull/61 PR: https://git.openjdk.org/jdk11u/pull/61 From duke at openjdk.org Wed Nov 23 00:59:33 2022 From: duke at openjdk.org (zzambers) Date: Wed, 23 Nov 2022 00:59:33 GMT Subject: [jdk17u-dev] RFR: 8289301: P11Cipher should not throw out of bounds exception during padding In-Reply-To: References: Message-ID: <38sk8D514Caf_mntoG4DF3pKRp-sHHLRfwgy9_9DUbw=.5258f204-fa6f-4b81-8f65-f6d2eff4ca65@github.com> On Wed, 23 Nov 2022 00:49:40 GMT, Andrew John Hughes wrote: >> Backport fixing possible out of bounds exception during padding in P11Cipher. >> >> Applied cleanly. Passed jdk_security tests. > > It looks like this one has been missed because `jdk17-fix-request` was added rather than `jdk17u-fix-request`. I've fixed this now and approved. Feel free to integrate. @gnu-andrew Thanks I have now noticed, I have made same mistake here: https://bugs.openjdk.org/browse/JDK-8293815 (I have fixed it, thanks for pointing that out) ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/706 From duke at openjdk.org Wed Nov 23 01:28:29 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 23 Nov 2022 01:28:29 GMT Subject: [jdk11u-dev] RFR: JDK-8261351 Create implementation for NSAccessibilityRadioButton protocol Message-ID: [JDK-8261351 ](https://bugs.openjdk.org/browse/JDK-8261351) Mostly clean backport. 4/28 of the series of backports. ------------- Commit messages: - 8261351: Create implementation for NSAccessibilityRadioButton protocol - JDK-8261352 create implementation for component peer for all the components who should be ignored in a11y interactions - 8256110: Create implementation for NSAccessibilityStepper protocol Changes: https://git.openjdk.org/jdk11u-dev/pull/1548/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1548&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261351 Stats: 654 lines in 11 files changed: 599 ins; 51 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1548.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1548/head:pull/1548 PR: https://git.openjdk.org/jdk11u-dev/pull/1548 From kvn at openjdk.org Wed Nov 23 01:31:32 2022 From: kvn at openjdk.org (Vladimir Kozlov) Date: Wed, 23 Nov 2022 01:31:32 GMT Subject: [jdk19u] RFR: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency In-Reply-To: <3g_pbLEnC6LLnVnGhqI02pQI7qXWlLj21MCvrp8JVPA=.0bda7107-f428-4536-b3fa-87daae210215@github.com> References: <3g_pbLEnC6LLnVnGhqI02pQI7qXWlLj21MCvrp8JVPA=.0bda7107-f428-4536-b3fa-87daae210215@github.com> Message-ID: On Tue, 22 Nov 2022 16:11:57 GMT, Tobias Hartmann wrote: > Backport of [JDK-8287217](https://bugs.openjdk.java.net/browse/JDK-8287217). Patch did not apply cleanly due to differences in surrounding code in `PhaseCCP::analyze`. Approval is pending. > > Thanks, > Tobias Backport looks good. ------------- Marked as reviewed by kvn (Reviewer). PR: https://git.openjdk.org/jdk19u/pull/87 From duke at openjdk.org Wed Nov 23 02:23:28 2022 From: duke at openjdk.org (zzambers) Date: Wed, 23 Nov 2022 02:23:28 GMT Subject: [jdk17u-dev] Integrated: 8289301: P11Cipher should not throw out of bounds exception during padding In-Reply-To: References: Message-ID: On Wed, 21 Sep 2022 11:07:26 GMT, zzambers wrote: > Backport fixing possible out of bounds exception during padding in P11Cipher. > > Applied cleanly. Passed jdk_security tests. This pull request has now been integrated. Changeset: 2f7e673f Author: Zdenek Zambersky Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk17u-dev/commit/2f7e673f521a707d7be7b83efe73df2010d36206 Stats: 124 lines in 2 files changed: 117 ins; 0 del; 7 mod 8289301: P11Cipher should not throw out of bounds exception during padding Backport-of: 3e60e828148a0490a4422d0724d15f3eccec17f0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/706 From andrew at openjdk.org Wed Nov 23 02:23:40 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 23 Nov 2022 02:23:40 GMT Subject: [jdk17u-dev] RFR: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation In-Reply-To: References: Message-ID: On Wed, 21 Sep 2022 11:16:19 GMT, zzambers wrote: > Backport of fix for P11PSSSignature not to print debug message during normal operation. > > Applies cleanly. Passed jdk_security tests. Approved this one too. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/708 From xlinzheng at openjdk.org Wed Nov 23 02:47:33 2022 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Wed, 23 Nov 2022 02:47:33 GMT Subject: [jdk19u] RFR: 8295414: [Aarch64] C2: assert(false) failed: bad AD file In-Reply-To: <9mnzo0rPmRAykKcXldtPZbJv5XKF7brBLuE4HXWQgUU=.93267bc0-4cf1-4225-945b-babfe719102e@github.com> References: <9mnzo0rPmRAykKcXldtPZbJv5XKF7brBLuE4HXWQgUU=.93267bc0-4cf1-4225-945b-babfe719102e@github.com> Message-ID: On Tue, 22 Nov 2022 04:57:44 GMT, Xiaolin Zheng wrote: > This is a fix for a fast debug build assertion failure, and the impact is small. > Clean backport from 20. > > Testing hotspot tier1~tier4. Thank you, Tobias! (I saw another backport there which was closed :-) ) Hotspot tier1 and tier2 look okay and I received approval to push. ------------- PR: https://git.openjdk.org/jdk19u/pull/78 From lzhai at openjdk.org Wed Nov 23 02:48:18 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Wed, 23 Nov 2022 02:48:18 GMT Subject: [jdk17u-dev] RFR: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx Message-ID: <1PFq85qhwv6Hxk8fp5xneUYtGPIQbWoN7cXaz15mog0=.2354dc3e-a155-4a1b-8072-66f8b07c3fa1@github.com> Hi, I request the backport for jdk17u-dev. The patch applies clean. This backport is only a test change and fixes the test failure. Thanks, Leslie Zhai ------------- Commit messages: - Backport dfb9c0663370fc8335caf06ca6f0cb4dac95ce2d Changes: https://git.openjdk.org/jdk17u-dev/pull/921/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=921&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293535 Stats: 9 lines in 1 file changed: 4 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/921.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/921/head:pull/921 PR: https://git.openjdk.org/jdk17u-dev/pull/921 From xlinzheng at openjdk.org Wed Nov 23 02:52:49 2022 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Wed, 23 Nov 2022 02:52:49 GMT Subject: [jdk19u] RFR: 8296771: RISC-V: C2: assert(false) failed: bad AD file In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 04:58:38 GMT, Xiaolin Zheng wrote: > This is a fix for a fast debug build assertion failure, and the impact is small. > Clean backport from 20. > > Testing currently. Hotspot tier1 including the failed test in `TestSubTypeCheckMacroTrichotomy.java` from #78 passed. Received push approval. ------------- PR: https://git.openjdk.org/jdk19u/pull/79 From lzhai at openjdk.org Wed Nov 23 02:54:07 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Wed, 23 Nov 2022 02:54:07 GMT Subject: [jdk17u-dev] RFR: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx [v2] In-Reply-To: <1PFq85qhwv6Hxk8fp5xneUYtGPIQbWoN7cXaz15mog0=.2354dc3e-a155-4a1b-8072-66f8b07c3fa1@github.com> References: <1PFq85qhwv6Hxk8fp5xneUYtGPIQbWoN7cXaz15mog0=.2354dc3e-a155-4a1b-8072-66f8b07c3fa1@github.com> Message-ID: <0MzNPwpCR8Y2vi23WEaQ-z9ErW0UBTH2PL_Cqn7RdZQ=.03e3fcfc-fd28-4ab9-b891-f3193fb9d5ad@github.com> > Hi, > > I request the backport for jdk17u-dev. The patch applies clean. This backport is only a test change and fixes the test failure. > > Thanks, > Leslie Zhai Leslie Zhai has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/921/files - new: https://git.openjdk.org/jdk17u-dev/pull/921/files/5e6ff7e8..4a9774af Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=921&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=921&range=00-01 Stats: 9 lines in 1 file changed: 1 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/921.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/921/head:pull/921 PR: https://git.openjdk.org/jdk17u-dev/pull/921 From lzhai at openjdk.org Wed Nov 23 02:54:08 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Wed, 23 Nov 2022 02:54:08 GMT Subject: [jdk17u-dev] Withdrawn: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx In-Reply-To: <1PFq85qhwv6Hxk8fp5xneUYtGPIQbWoN7cXaz15mog0=.2354dc3e-a155-4a1b-8072-66f8b07c3fa1@github.com> References: <1PFq85qhwv6Hxk8fp5xneUYtGPIQbWoN7cXaz15mog0=.2354dc3e-a155-4a1b-8072-66f8b07c3fa1@github.com> Message-ID: On Wed, 23 Nov 2022 02:42:14 GMT, Leslie Zhai wrote: > Hi, > > I request the backport for jdk17u-dev. The patch applies clean. This backport is only a test change and fixes the test failure. > > Thanks, > Leslie Zhai This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/921 From lzhai at openjdk.org Wed Nov 23 02:59:51 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Wed, 23 Nov 2022 02:59:51 GMT Subject: [jdk17u-dev] RFR: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx Message-ID: <_le7M-l9Gx61vz8OWeqQQaewtX7fKwHTA9eatOobrE4=.d19d636f-db64-405c-8f34-b6f5fce4eeb7@github.com> Hi, I request the backport for jdk17u-dev. The patch applies clean. This backport is only a test change, no risk and fixes the test failure. Thanks, Leslie Zhai ------------- Commit messages: - Backport dfb9c0663370fc8335caf06ca6f0cb4dac95ce2d Changes: https://git.openjdk.org/jdk17u-dev/pull/922/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=922&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293535 Stats: 9 lines in 1 file changed: 4 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/922.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/922/head:pull/922 PR: https://git.openjdk.org/jdk17u-dev/pull/922 From xlinzheng at openjdk.org Wed Nov 23 03:02:31 2022 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Wed, 23 Nov 2022 03:02:31 GMT Subject: [jdk19u] Integrated: 8295414: [Aarch64] C2: assert(false) failed: bad AD file In-Reply-To: <9mnzo0rPmRAykKcXldtPZbJv5XKF7brBLuE4HXWQgUU=.93267bc0-4cf1-4225-945b-babfe719102e@github.com> References: <9mnzo0rPmRAykKcXldtPZbJv5XKF7brBLuE4HXWQgUU=.93267bc0-4cf1-4225-945b-babfe719102e@github.com> Message-ID: On Tue, 22 Nov 2022 04:57:44 GMT, Xiaolin Zheng wrote: > This is a fix for a fast debug build assertion failure, and the impact is small. > Clean backport from 20. > > Testing hotspot tier1~tier4. This pull request has now been integrated. Changeset: 2adc3e14 Author: Xiaolin Zheng Committer: Fei Yang URL: https://git.openjdk.org/jdk19u/commit/2adc3e14aac446a3fb9b79dc0d3c240d39827d0e Stats: 7 lines in 2 files changed: 6 ins; 0 del; 1 mod 8295414: [Aarch64] C2: assert(false) failed: bad AD file Reviewed-by: thartmann Backport-of: d3eba859f9c87465a8f1c0dfd6dd5aef368d5853 ------------- PR: https://git.openjdk.org/jdk19u/pull/78 From xlinzheng at openjdk.org Wed Nov 23 03:03:43 2022 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Wed, 23 Nov 2022 03:03:43 GMT Subject: [jdk19u] Integrated: 8296771: RISC-V: C2: assert(false) failed: bad AD file In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 04:58:38 GMT, Xiaolin Zheng wrote: > This is a fix for a fast debug build assertion failure, and the impact is small. > Clean backport from 20. > > Testing currently. This pull request has now been integrated. Changeset: c8082a3b Author: Xiaolin Zheng Committer: Fei Yang URL: https://git.openjdk.org/jdk19u/commit/c8082a3b64d294a0a9b4ae8299e79c51eda051e7 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8296771: RISC-V: C2: assert(false) failed: bad AD file Backport-of: 7244eac9dfe4e7e9c3eea613149f0fb1390f00aa ------------- PR: https://git.openjdk.org/jdk19u/pull/79 From thartmann at openjdk.org Wed Nov 23 06:07:23 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 23 Nov 2022 06:07:23 GMT Subject: [jdk19u] RFR: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency In-Reply-To: <3g_pbLEnC6LLnVnGhqI02pQI7qXWlLj21MCvrp8JVPA=.0bda7107-f428-4536-b3fa-87daae210215@github.com> References: <3g_pbLEnC6LLnVnGhqI02pQI7qXWlLj21MCvrp8JVPA=.0bda7107-f428-4536-b3fa-87daae210215@github.com> Message-ID: On Tue, 22 Nov 2022 16:11:57 GMT, Tobias Hartmann wrote: > Backport of [JDK-8287217](https://bugs.openjdk.java.net/browse/JDK-8287217). Patch did not apply cleanly due to differences in surrounding code in `PhaseCCP::analyze`. Approval is pending. > > Thanks, > Tobias Thanks, Vladimir! ------------- PR: https://git.openjdk.org/jdk19u/pull/87 From mbaesken at openjdk.org Wed Nov 23 08:33:58 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 23 Nov 2022 08:33:58 GMT Subject: [jdk17u-dev] Integrated: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 15:14:18 GMT, Matthias Baesken wrote: > 8296945: PublicMethodsTest is slow due to dependency verification with debug builds This pull request has now been integrated. Changeset: 4f5326c5 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/4f5326c5e33ca303388e5d4f4cdda0d3abf46174 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8296945: PublicMethodsTest is slow due to dependency verification with debug builds Backport-of: bcc6b12b711a9c5007d963123fb38a7e72aaf8e5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/911 From mbaesken at openjdk.org Wed Nov 23 08:34:01 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 23 Nov 2022 08:34:01 GMT Subject: [jdk17u-dev] RFR: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used Message-ID: <0L6H7y6ACShDKr5pENRo9wZ0OYwl5agyVjTR1T-Y10w=.e61783bb-0050-479c-b7dd-b40c14b307c9@github.com> 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used ------------- Commit messages: - Backport 88957a7ce8932b95e3a18e6a7d1ceb3b7f60c781 Changes: https://git.openjdk.org/jdk17u-dev/pull/923/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=923&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297147 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/923.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/923/head:pull/923 PR: https://git.openjdk.org/jdk17u-dev/pull/923 From shade at openjdk.org Wed Nov 23 10:49:50 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Nov 2022 10:49:50 GMT Subject: [jdk17u-dev] RFR: 8008243: Zero: Implement fast bytecodes Message-ID: Clean backport to improve Zero performance. The rationale for backport is the same as for mainline. Given that Zero is used to implement the JVM on emerging platforms that are still rather slow themselves, it makes sense to make Zero quantifiably faster. Even 10% improvement means more than 2 hours a day worth of CPU time. This backport requires a follow-up to fix some platforms: [8277485](https://bugs.openjdk.org/browse/JDK-8277485): Zero: Fix _fast_{i,f}access_0 bytecodes handling We still have `RewriteBytecodes` to get the original behavior if more bugs appear. Additional testing: - [x] Linux x86_64 Zero `make bootcycle-images` ------------- Commit messages: - Backport e4362007da8e40c076493364df91cf85960a03e7 Changes: https://git.openjdk.org/jdk17u-dev/pull/924/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=924&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8008243 Stats: 600 lines in 4 files changed: 525 ins; 56 del; 19 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/924.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/924/head:pull/924 PR: https://git.openjdk.org/jdk17u-dev/pull/924 From shade at openjdk.org Wed Nov 23 11:45:58 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Nov 2022 11:45:58 GMT Subject: [jdk17u-dev] RFR: 8277485: Zero: Fix _fast_{i,f}access_0 bytecodes handling Message-ID: <7IzSIe5NkF0BH2PnDFyU-q8u3jRKHCqyc0YLc-8Urgg=.407b0539-0044-4332-a7dd-ab283f28ec6d@github.com> Clean follow up for JDK-8008243. Additional testing: - [x] Linux x86_64 Zero fastdebug `make bootcycle-images` - [ ] Linux x86_32 Zero fastdebug `make bootcycle-images` ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/924 Commit messages: - Backport 0a9e76c4f9d966015c19e87e3eb59ceb7489459f Changes: https://git.openjdk.org/jdk17u-dev/pull/925/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=925&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8277485 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/925.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/925/head:pull/925 PR: https://git.openjdk.org/jdk17u-dev/pull/925 From shade at openjdk.org Wed Nov 23 11:49:26 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Nov 2022 11:49:26 GMT Subject: [jdk17u-dev] RFR: 8270155: ARM32: Improve register dump in hs_err Message-ID: Clean backport to improve ARM32 error handling. Additional testing: - [x] Linux ARM32 fastdebug `make bootcycle-images` - [x] Ad-hoc Linux ARM32 fastdebug crashes, eyeballing hs-errs ------------- Commit messages: - Backport 589a1d53df0f53c064fda8a2ac491e0a536ea487 Changes: https://git.openjdk.org/jdk17u-dev/pull/926/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=926&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8270155 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/926.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/926/head:pull/926 PR: https://git.openjdk.org/jdk17u-dev/pull/926 From shade at openjdk.org Wed Nov 23 11:55:45 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Nov 2022 11:55:45 GMT Subject: [jdk17u-dev] RFR: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter Message-ID: Clean backport to improve ARM32 reliability. Additional testing: - [ ] Linux ARM32 fastdebug `make bootcycle-images` ------------- Commit messages: - Backport a066c7bed0f9aa45fb9384f75ae84943548cd859 Changes: https://git.openjdk.org/jdk17u-dev/pull/927/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=927&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8270086 Stats: 16 lines in 1 file changed: 5 ins; 4 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/927.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/927/head:pull/927 PR: https://git.openjdk.org/jdk17u-dev/pull/927 From shade at openjdk.org Wed Nov 23 12:26:56 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Nov 2022 12:26:56 GMT Subject: [jdk17u-dev] RFR: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 11:47:28 GMT, Aleksey Shipilev wrote: > Clean backport to improve ARM32 reliability. > > Additional testing: > - [x] Linux ARM32 fastdebug `make bootcycle-images` @mychris, you might want to take a look or even test this for 17u? Thanks. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/927 From kcr at openjdk.org Wed Nov 23 12:36:24 2022 From: kcr at openjdk.org (Kevin Rushforth) Date: Wed, 23 Nov 2022 12:36:24 GMT Subject: [jdk17u-dev] RFR: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx In-Reply-To: <_le7M-l9Gx61vz8OWeqQQaewtX7fKwHTA9eatOobrE4=.d19d636f-db64-405c-8f34-b6f5fce4eeb7@github.com> References: <_le7M-l9Gx61vz8OWeqQQaewtX7fKwHTA9eatOobrE4=.d19d636f-db64-405c-8f34-b6f5fce4eeb7@github.com> Message-ID: On Wed, 23 Nov 2022 02:52:00 GMT, Leslie Zhai wrote: > Hi, > > I request the backport for jdk17u-dev. The patch applies clean. This backport is only a test change, no risk and fixes the test failure. > > Thanks, > Leslie Zhai Since this is a backport, you can (and should) use a "Backport-style" PR by changing the title of this PR to `Backport ` using the 40 char hash of the original commit in the jdk mainline repo. See [BackportPullRequests](https://wiki.openjdk.org/display/SKARA/Backports#Backports-BackportPullRequests) in the Wiki. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/922 From duke at openjdk.org Wed Nov 23 13:10:22 2022 From: duke at openjdk.org (zzambers) Date: Wed, 23 Nov 2022 13:10:22 GMT Subject: [jdk11u-dev] RFR: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails Message-ID: Clean backport. With plan to further backporting to JDK 8. ------------- Commit messages: - Backport 038f58d4f0782f885547d2b052a47fdf2229cfe3 Changes: https://git.openjdk.org/jdk11u-dev/pull/1549/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1549&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8226236 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1549.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1549/head:pull/1549 PR: https://git.openjdk.org/jdk11u-dev/pull/1549 From thartmann at openjdk.org Wed Nov 23 14:08:53 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 23 Nov 2022 14:08:53 GMT Subject: [jdk19u] Integrated: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 16:06:43 GMT, Tobias Hartmann wrote: > Backport of [JDK-8293996](https://bugs.openjdk.java.net/browse/JDK-8293996). Applies cleanly. Approval is pending. > > Thanks, > Tobias This pull request has now been integrated. Changeset: 62db7bb5 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk19u/commit/62db7bb5b7bb454da5c700493463d123c8ae06d8 Stats: 65 lines in 2 files changed: 38 ins; 17 del; 10 mod 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop Backport-of: dd51f7e0b75d3a16403608d89cd206ac0bedf882 ------------- PR: https://git.openjdk.org/jdk19u/pull/86 From thartmann at openjdk.org Wed Nov 23 14:12:24 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 23 Nov 2022 14:12:24 GMT Subject: [jdk19u] Integrated: 8292780: misc tests failed "assert(false) failed: graph should be schedulable" In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 16:05:02 GMT, Tobias Hartmann wrote: > Backport of [JDK-8292780](https://bugs.openjdk.java.net/browse/JDK-8292780). Applies cleanly. Approval is pending. > > Thanks, > Tobias This pull request has now been integrated. Changeset: 71b38e22 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk19u/commit/71b38e2247592e48c48d7c0813b86d9a5f27ec53 Stats: 52 lines in 2 files changed: 51 ins; 0 del; 1 mod 8292780: misc tests failed "assert(false) failed: graph should be schedulable" Backport-of: 16047e8308a845436f7003e09e604a88bb370632 ------------- PR: https://git.openjdk.org/jdk19u/pull/85 From thartmann at openjdk.org Wed Nov 23 14:12:42 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 23 Nov 2022 14:12:42 GMT Subject: [jdk19u] Integrated: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency In-Reply-To: <3g_pbLEnC6LLnVnGhqI02pQI7qXWlLj21MCvrp8JVPA=.0bda7107-f428-4536-b3fa-87daae210215@github.com> References: <3g_pbLEnC6LLnVnGhqI02pQI7qXWlLj21MCvrp8JVPA=.0bda7107-f428-4536-b3fa-87daae210215@github.com> Message-ID: <0s48JTUdgEoqaQxB7s9evVyKNtWekObDkhCEgf5eN2Y=.b6ae4b3d-ea42-4c0c-bbdf-911fbb5f17ac@github.com> On Tue, 22 Nov 2022 16:11:57 GMT, Tobias Hartmann wrote: > Backport of [JDK-8287217](https://bugs.openjdk.java.net/browse/JDK-8287217). Patch did not apply cleanly due to differences in surrounding code in `PhaseCCP::analyze`. Approval is pending. > > Thanks, > Tobias This pull request has now been integrated. Changeset: 4708c7b0 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk19u/commit/4708c7b0e43ba24882fc82534e9ad2ada288ce5e Stats: 102 lines in 5 files changed: 81 ins; 2 del; 19 mod 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency Reviewed-by: kvn Backport-of: 379f3094db0b8afe90ed6b7a341164222744085f ------------- PR: https://git.openjdk.org/jdk19u/pull/87 From thartmann at openjdk.org Wed Nov 23 14:13:57 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 23 Nov 2022 14:13:57 GMT Subject: [jdk19u] Integrated: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 15:57:49 GMT, Tobias Hartmann wrote: > Backport of [JDK-8285835](https://bugs.openjdk.java.net/browse/JDK-8285835). Applies cleanly. Approval is pending. > > Thanks, > Tobias This pull request has now been integrated. Changeset: 3f3bbdfa Author: Tobias Hartmann URL: https://git.openjdk.org/jdk19u/commit/3f3bbdfa2661931a5d1a99c00d0f95720309ee8f Stats: 145 lines in 3 files changed: 135 ins; 0 del; 10 mod 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work Backport-of: 8aa1526b443025b8606a3668262f46a9cb6ea6f6 ------------- PR: https://git.openjdk.org/jdk19u/pull/82 From thartmann at openjdk.org Wed Nov 23 14:16:12 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 23 Nov 2022 14:16:12 GMT Subject: [jdk19u] Integrated: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes" In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 16:02:35 GMT, Tobias Hartmann wrote: > Backport of [JDK-8290964](https://bugs.openjdk.java.net/browse/JDK-8290964). Applies cleanly. Approval is pending. > > Thanks, > Tobias This pull request has now been integrated. Changeset: 6c7378a3 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk19u/commit/6c7378a33ffbdec65bde165947c9f6acfa004e29 Stats: 21 lines in 3 files changed: 0 ins; 21 del; 0 mod 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes" Backport-of: 4bdd1c914859e221c64208d47ef309d463609953 ------------- PR: https://git.openjdk.org/jdk19u/pull/84 From thartmann at openjdk.org Wed Nov 23 14:17:10 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 23 Nov 2022 14:17:10 GMT Subject: [jdk19u] Integrated: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite() In-Reply-To: <7bqjWz-93PIcBfl-jL4jHjq8I0sbwEefjEpxfljApwg=.366ae82d-2122-4091-9004-cc23b897dd3f@github.com> References: <7bqjWz-93PIcBfl-jL4jHjq8I0sbwEefjEpxfljApwg=.366ae82d-2122-4091-9004-cc23b897dd3f@github.com> Message-ID: On Tue, 22 Nov 2022 15:51:17 GMT, Tobias Hartmann wrote: > Backport of [JDK-8294538](https://bugs.openjdk.java.net/browse/JDK-8294538). Applies cleanly. Approval is pending. > > Thanks, > Tobias This pull request has now been integrated. Changeset: d1268e96 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk19u/commit/d1268e9642b42fdcfe5555217965c21e28c03569 Stats: 22 lines in 3 files changed: 9 ins; 12 del; 1 mod 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite() Reviewed-by: eosterlund Backport-of: b5efa2afe268e3171f54d8488ef69bf67059bd7f ------------- PR: https://git.openjdk.org/jdk19u/pull/81 From duke at openjdk.org Wed Nov 23 14:23:38 2022 From: duke at openjdk.org (zzambers) Date: Wed, 23 Nov 2022 14:23:38 GMT Subject: [jdk17u-dev] RFR: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation In-Reply-To: References: Message-ID: <7Zib13MW_HhT8eubwiRo0mAyElOLxV5qcwIbBEtOYvc=.13bea628-61d6-4c59-b46a-5f8c3bf7ce95@github.com> On Wed, 23 Nov 2022 02:20:58 GMT, Andrew John Hughes wrote: >> Backport of fix for P11PSSSignature not to print debug message during normal operation. >> >> Applies cleanly. Passed jdk_security tests. > > Approved this one too. @gnu-andrew Thanks ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/708 From rmarchenko at openjdk.org Wed Nov 23 15:14:38 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 23 Nov 2022 15:14:38 GMT Subject: [jdk17u-dev] Integrated: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled In-Reply-To: <0PmYoCgrEl0vbv2BWPXnougU0xsFnuiXG_SQxqsm7vY=.a034d40a-ce9f-4be9-80a3-abe9bd8116a2@github.com> References: <0PmYoCgrEl0vbv2BWPXnougU0xsFnuiXG_SQxqsm7vY=.a034d40a-ce9f-4be9-80a3-abe9bd8116a2@github.com> Message-ID: On Mon, 14 Nov 2022 13:16:17 GMT, Roman Marchenko wrote: > Backport JDK-8065422 to 17u > > Clean backport, GHA passed. > > Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backported as dependant PRs: > > - #881 > - #882 This pull request has now been integrated. Changeset: a596d642 Author: Roman Marchenko Committer: Yuri Nesterenko URL: https://git.openjdk.org/jdk17u-dev/commit/a596d64207577fae924b2dfe68c2bfef1d4d9490 Stats: 616 lines in 4 files changed: 613 ins; 0 del; 3 mod 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled Backport-of: a95ee5ada230a0177517efd3a417f319066169dd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/880 From rmarchenko at openjdk.org Wed Nov 23 15:19:57 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 23 Nov 2022 15:19:57 GMT Subject: [jdk17u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired [v2] In-Reply-To: References: Message-ID: <5UOBA9B-yXzJUYkjN-FN6wZN-vN4uJ5ZxAhh3Ge7egw=.9dad4d90-2feb-475f-b872-2f3552a91c3b@github.com> > Backport JDK-8282398 to 17u > > Clean backport. > The test changed only. > > Please note that new test added by the change may fail because there are additional changes in the dependant PR: > > - Prev PR #880 > - Next PR #881 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/881/files - new: https://git.openjdk.org/jdk17u-dev/pull/881/files/7356821e..7356821e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=881&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=881&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/881.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/881/head:pull/881 PR: https://git.openjdk.org/jdk17u-dev/pull/881 From vrudomet at openjdk.org Wed Nov 23 18:14:21 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Wed, 23 Nov 2022 18:14:21 GMT Subject: [jdk19u] Integrated: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails In-Reply-To: References: Message-ID: <1JbnGU-NAyqsWIXG70QmXkvlKPnxOuh4xEsbYQM5YO8=.7d7eabfb-0fb3-41b9-9713-7280d7887b62@github.com> On Tue, 22 Nov 2022 20:01:18 GMT, Victor Rudometov wrote: > Backport for [JDK-8022403](https://bugs.openjdk.org/browse/JDK-8022403) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails > > Cherry-picked from https://github.com/openjdk/jdk/commit/65f7de252366e30ba18a22c107fc301c0fdc9378 > > Clean test backport. > Test update, low risk. > Test passed during manual run on mac and linux using cmd: > make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java > There's a followup fix for this test, that will be also backported. This pull request has now been integrated. Changeset: 793c16ce Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk19u/commit/793c16cebb8676f11f73d2610979f7505a4e6af5 Stats: 159 lines in 2 files changed: 49 ins; 34 del; 76 mod 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Backport-of: 65f7de252366e30ba18a22c107fc301c0fdc9378 ------------- PR: https://git.openjdk.org/jdk19u/pull/89 From vrudomet at openjdk.org Wed Nov 23 18:19:55 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Wed, 23 Nov 2022 18:19:55 GMT Subject: [jdk19u] RFR: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java [v2] In-Reply-To: References: Message-ID: > Backport for > [JDK-8297153](https://bugs.openjdk.org/browse/JDK-8297153) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again > [JDK-8297241](https://bugs.openjdk.org/browse/JDK-8297241) Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java > > Original commit: https://github.com/openjdk/jdk/commit/3c0949824e06f2b3d44f1bde9d2292a7627b0197 > > Clean backport. > Fixing unstable test. > Checked on mac and linux by running: > make run-test TEST="test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java" > > This PR depends on https://github.com/openjdk/jdk19u/pull/89 Victor Rudometov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk19u/pull/90/files - new: https://git.openjdk.org/jdk19u/pull/90/files/bda93fff..bda93fff Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk19u&pr=90&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk19u&pr=90&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/90.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/90/head:pull/90 PR: https://git.openjdk.org/jdk19u/pull/90 From vrudomet at openjdk.org Wed Nov 23 18:26:22 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Wed, 23 Nov 2022 18:26:22 GMT Subject: [jdk19u] RFR: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java [v3] In-Reply-To: References: Message-ID: > Backport for > [JDK-8297153](https://bugs.openjdk.org/browse/JDK-8297153) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again > [JDK-8297241](https://bugs.openjdk.org/browse/JDK-8297241) Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java > > Original commit: https://github.com/openjdk/jdk/commit/3c0949824e06f2b3d44f1bde9d2292a7627b0197 > > Clean backport. > Fixing unstable test. > Checked on mac and linux by running: > make run-test TEST="test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java" > > This PR depends on https://github.com/openjdk/jdk19u/pull/89 Victor Rudometov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into 8297153 - 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java 8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again Reviewed-by: serb (cherry picked from commit 3c0949824e06f2b3d44f1bde9d2292a7627b0197) - 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails Reviewed-by: prr, psadhukhan (cherry picked from commit 65f7de252366e30ba18a22c107fc301c0fdc9378) ------------- Changes: - all: https://git.openjdk.org/jdk19u/pull/90/files - new: https://git.openjdk.org/jdk19u/pull/90/files/bda93fff..13a60a5b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk19u&pr=90&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk19u&pr=90&range=01-02 Stats: 415 lines in 21 files changed: 321 ins; 52 del; 42 mod Patch: https://git.openjdk.org/jdk19u/pull/90.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/90/head:pull/90 PR: https://git.openjdk.org/jdk19u/pull/90 From vrudomet at openjdk.org Wed Nov 23 18:39:50 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Wed, 23 Nov 2022 18:39:50 GMT Subject: [jdk19u] RFR: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java [v4] In-Reply-To: References: Message-ID: > Backport for > [JDK-8297153](https://bugs.openjdk.org/browse/JDK-8297153) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again > [JDK-8297241](https://bugs.openjdk.org/browse/JDK-8297241) Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java > > Original commit: https://github.com/openjdk/jdk/commit/3c0949824e06f2b3d44f1bde9d2292a7627b0197 > > Clean backport. > Fixing unstable test. > Checked on mac and linux by running: > make run-test TEST="test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java" > > This PR depends on https://github.com/openjdk/jdk19u/pull/89 Victor Rudometov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java 8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again Reviewed-by: serb (cherry picked from commit 3c0949824e06f2b3d44f1bde9d2292a7627b0197) ------------- Changes: - all: https://git.openjdk.org/jdk19u/pull/90/files - new: https://git.openjdk.org/jdk19u/pull/90/files/13a60a5b..79ab864f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk19u&pr=90&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk19u&pr=90&range=02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/90.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/90/head:pull/90 PR: https://git.openjdk.org/jdk19u/pull/90 From luhenry at openjdk.org Wed Nov 23 20:57:36 2022 From: luhenry at openjdk.org (Ludovic Henry) Date: Wed, 23 Nov 2022 20:57:36 GMT Subject: [jdk19u] RFR: 8295264: Fix PaX check on RISC-V Message-ID: On Linux RISC-V, PROT_WRITE doesn't imply PROT_READ [1] The fix is to pass PROT_READ|PROT_WRITE. That matches all other calls to mmap in hotspot. [1] https://lkml.org/lkml/2022/9/8/1066 ------------- Commit messages: - Backport 4434cbb719db37880b48474ba342f300ed4828a8 Changes: https://git.openjdk.org/jdk19u/pull/91/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=91&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295264 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk19u/pull/91.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/91/head:pull/91 PR: https://git.openjdk.org/jdk19u/pull/91 From luhenry at openjdk.org Wed Nov 23 20:57:36 2022 From: luhenry at openjdk.org (Ludovic Henry) Date: Wed, 23 Nov 2022 20:57:36 GMT Subject: [jdk19u] RFR: 8295264: Fix PaX check on RISC-V In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 20:49:58 GMT, Ludovic Henry wrote: > On Linux RISC-V, PROT_WRITE doesn't imply PROT_READ [1] > > The fix is to pass PROT_READ|PROT_WRITE. That matches all other calls to mmap in hotspot. > > [1] https://lkml.org/lkml/2022/9/8/1066 The patch applies cleanly and was created by the openjdk bot from https://github.com/openjdk/jdk/pull/10690#issuecomment-1325635565 ------------- PR: https://git.openjdk.org/jdk19u/pull/91 From vkempik at openjdk.org Wed Nov 23 21:46:06 2022 From: vkempik at openjdk.org (Vladimir Kempik) Date: Wed, 23 Nov 2022 21:46:06 GMT Subject: [jdk19u] RFR: 8295264: Fix PaX check on RISC-V In-Reply-To: References: Message-ID: <3z7oPIT5XE4wjRWdCRVy1i37mdafIqNAbT-oFFICias=.c02773de-af52-4fe6-a9a6-86fb6b58f4c8@github.com> On Wed, 23 Nov 2022 20:49:58 GMT, Ludovic Henry wrote: > On Linux RISC-V, PROT_WRITE doesn't imply PROT_READ [1] > > The fix is to pass PROT_READ|PROT_WRITE. That matches all other calls to mmap in hotspot. > > [1] https://lkml.org/lkml/2022/9/8/1066 Small context code difference made skara think it's not clean. Lets try to make it into 19u until 28 Nov. ------------- Marked as reviewed by vkempik (Reviewer). PR: https://git.openjdk.org/jdk19u/pull/91 From rmarchenko at openjdk.org Wed Nov 23 21:48:07 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 23 Nov 2022 21:48:07 GMT Subject: [jdk17u-dev] RFR: 8282398: EndingDotHostname.java test fails because SSL cert expired [v3] In-Reply-To: References: Message-ID: <_TsskvVY7LCrMM7ADi8ULqhD3Y-NxcEd1uolqlJBqE4=.2f2af732-7bd3-4a3d-9140-ebcc324349af@github.com> > Backport JDK-8282398 to 17u > > Clean backport. > The test changed only. > > Please note that new test added by the change may fail because there are additional changes in the dependant PR: > > - Prev PR #880 > - Next PR #881 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/881/files - new: https://git.openjdk.org/jdk17u-dev/pull/881/files/7356821e..8be8b8fc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=881&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=881&range=01-02 Stats: 1986 lines in 48 files changed: 1663 ins; 177 del; 146 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/881.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/881/head:pull/881 PR: https://git.openjdk.org/jdk17u-dev/pull/881 From rmarchenko at openjdk.org Wed Nov 23 21:50:27 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 23 Nov 2022 21:50:27 GMT Subject: [jdk17u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2] In-Reply-To: References: Message-ID: > Backport JDK-8282511 to 17u > Clean backport. > The test changed only. > > There are previous PRs this PR depends on: > > - #880 > - #881 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/882/files - new: https://git.openjdk.org/jdk17u-dev/pull/882/files/da505a2d..da505a2d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=882&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=882&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/882.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/882/head:pull/882 PR: https://git.openjdk.org/jdk17u-dev/pull/882 From luhenry at openjdk.org Wed Nov 23 23:29:35 2022 From: luhenry at openjdk.org (Ludovic Henry) Date: Wed, 23 Nov 2022 23:29:35 GMT Subject: [jdk19u] RFR: 8295264: Fix PaX check on RISC-V In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 20:49:58 GMT, Ludovic Henry wrote: > On Linux RISC-V, PROT_WRITE doesn't imply PROT_READ [1] > > The fix is to pass PROT_READ|PROT_WRITE. That matches all other calls to mmap in hotspot. > > [1] https://lkml.org/lkml/2022/9/8/1066 IIUC I should wait on the label `jdk19-fix-yes` on https://bugs.openjdk.org/browse/JDK-8295264 before integrating, correct? ------------- PR: https://git.openjdk.org/jdk19u/pull/91 From lzhai at openjdk.org Thu Nov 24 00:52:01 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Thu, 24 Nov 2022 00:52:01 GMT Subject: [jdk17u-dev] RFR: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx In-Reply-To: References: <_le7M-l9Gx61vz8OWeqQQaewtX7fKwHTA9eatOobrE4=.d19d636f-db64-405c-8f34-b6f5fce4eeb7@github.com> Message-ID: <_BQuLfRor1e3eINJL0wGMuTX746FEcjcj0V5Q_G2Qdg=.f92f7f49-b45c-454a-8f6c-cda187d23534@github.com> On Wed, 23 Nov 2022 12:32:22 GMT, Kevin Rushforth wrote: >> Hi, >> >> I request the backport for jdk17u-dev. The patch applies clean. This backport is only a test change, no risk and fixes the test failure. >> >> Thanks, >> Leslie Zhai > > Since this is a backport, you can (and should) use a "Backport-style" PR by changing the title of this PR to `Backport ` using the 40 char hash of the original commit in the jdk mainline repo. See [BackportPullRequests](https://wiki.openjdk.org/display/SKARA/Backports#Backports-BackportPullRequests) in the Wiki. Hi @kevinrushforth > changing the title of this PR to Backport using the 40 char hash of the original commit in the jdk mainline repo. Thanks for your hint! Leslie Zhai ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/922 From serb at openjdk.org Thu Nov 24 02:12:36 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 24 Nov 2022 02:12:36 GMT Subject: [jdk19u] Integrated: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 18:23:50 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! This pull request has now been integrated. Changeset: 6615c054 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk19u/commit/6615c05467e99168f4ce02b6eeb7325ab98f5602 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Backport-of: fb6c992f325981c42c7f75109a6c9db7ca8715d8 ------------- PR: https://git.openjdk.org/jdk19u/pull/88 From serb at openjdk.org Thu Nov 24 04:21:22 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 24 Nov 2022 04:21:22 GMT Subject: [jdk17u-dev] RFR: 8296496: Overzealous check in sizecalc.h prevents large memory allocation Message-ID: Hi all, This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. Thanks! ------------- Commit messages: - Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 Changes: https://git.openjdk.org/jdk17u-dev/pull/928/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=928&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296496 Stats: 11 lines in 1 file changed: 0 ins; 4 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/928.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/928/head:pull/928 PR: https://git.openjdk.org/jdk17u-dev/pull/928 From rmarchenko at openjdk.org Thu Nov 24 06:32:06 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 24 Nov 2022 06:32:06 GMT Subject: [jdk17u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v3] In-Reply-To: References: Message-ID: > Backport JDK-8282511 to 17u > Clean backport. > The test changed only. > > There are previous PRs this PR depends on: > > - #880 > - #881 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 268fa693188b685de6289927ee5a1e99473a50f6 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/882/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=882&range=02 Stats: 218 lines in 2 files changed: 37 ins; 2 del; 179 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/882.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/882/head:pull/882 PR: https://git.openjdk.org/jdk17u-dev/pull/882 From rmarchenko at openjdk.org Thu Nov 24 06:36:55 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 24 Nov 2022 06:36:55 GMT Subject: [jdk17u-dev] Integrated: 8282398: EndingDotHostname.java test fails because SSL cert expired In-Reply-To: References: Message-ID: On Mon, 14 Nov 2022 15:00:18 GMT, Roman Marchenko wrote: > Backport JDK-8282398 to 17u > > Clean backport. > The test changed only. > > Please note that new test added by the change may fail because there are additional changes in the dependant PR: > > - Prev PR #880 > - Next PR #882 This pull request has now been integrated. Changeset: c0867256 Author: Roman Marchenko Committer: Yuri Nesterenko URL: https://git.openjdk.org/jdk17u-dev/commit/c086725698c238e487dee458a64e80493eb197df Stats: 202 lines in 2 files changed: 30 ins; 2 del; 170 mod 8282398: EndingDotHostname.java test fails because SSL cert expired Backport-of: afd4bcbc1d1b2a8a1c29005878c8e06c662a1f6e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/881 From rmarchenko at openjdk.org Thu Nov 24 06:46:06 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 24 Nov 2022 06:46:06 GMT Subject: [jdk17u-dev] RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v4] In-Reply-To: References: Message-ID: > Backport JDK-8282511 to 17u > Clean backport. > The test changed only. > > There are previous PRs this PR depends on: > > - #880 > - #881 Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport 268fa693188b685de6289927ee5a1e99473a50f6 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/882/files - new: https://git.openjdk.org/jdk17u-dev/pull/882/files/89aa14b9..790c6464 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=882&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=882&range=02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/882.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/882/head:pull/882 PR: https://git.openjdk.org/jdk17u-dev/pull/882 From vkempik at openjdk.org Thu Nov 24 06:49:30 2022 From: vkempik at openjdk.org (Vladimir Kempik) Date: Thu, 24 Nov 2022 06:49:30 GMT Subject: [jdk19u] RFR: 8295264: Fix PaX check on RISC-V In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 20:49:58 GMT, Ludovic Henry wrote: > On Linux RISC-V, PROT_WRITE doesn't imply PROT_READ [1] > > The fix is to pass PROT_READ|PROT_WRITE. That matches all other calls to mmap in hotspot. > > [1] https://lkml.org/lkml/2022/9/8/1066 Yes ------------- PR: https://git.openjdk.org/jdk19u/pull/91 From clanger at openjdk.org Thu Nov 24 07:54:59 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 24 Nov 2022 07:54:59 GMT Subject: [jdk19u] RFR: 8296904: Improve handling of macos xcode toolchain Message-ID: The diff to the make file and building.md applied cleanly. I had to regenerate building.html due to the different version of pandoc used. ------------- Commit messages: - Backport 470f3424fcce0e41b75cccdd5e3a56771cd07ff5 Changes: https://git.openjdk.org/jdk19u/pull/92/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=92&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296904 Stats: 73 lines in 3 files changed: 29 ins; 4 del; 40 mod Patch: https://git.openjdk.org/jdk19u/pull/92.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/92/head:pull/92 PR: https://git.openjdk.org/jdk19u/pull/92 From mbaesken at openjdk.org Thu Nov 24 08:02:32 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 24 Nov 2022 08:02:32 GMT Subject: [jdk19u] RFR: 8296904: Improve handling of macos xcode toolchain In-Reply-To: References: Message-ID: <8MyVYmwKtD4sfegkRuFUHeLY-0T9p5ZJEdYfepjPwQc=.e92ccda2-8a49-4e1b-a641-0be5ae89a9be@github.com> On Thu, 24 Nov 2022 07:47:43 GMT, Christoph Langer wrote: > The diff to the make file and building.md applied cleanly. > I had to regenerate building.html due to the different version of pandoc used. LGTM ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.org/jdk19u/pull/92 From serb at openjdk.org Thu Nov 24 09:50:06 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 24 Nov 2022 09:50:06 GMT Subject: [jdk15u-dev] RFR: 8296496: Overzealous check in sizecalc.h prevents large memory allocation Message-ID: Hi all, This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. Thanks! ------------- Commit messages: - Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 Changes: https://git.openjdk.org/jdk15u-dev/pull/306/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=306&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296496 Stats: 11 lines in 1 file changed: 0 ins; 4 del; 7 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/306.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/306/head:pull/306 PR: https://git.openjdk.org/jdk15u-dev/pull/306 From cgo at openjdk.org Thu Nov 24 10:17:40 2022 From: cgo at openjdk.org (Christoph =?UTF-8?B?R8O2dHRzY2hrZXM=?=) Date: Thu, 24 Nov 2022 10:17:40 GMT Subject: [jdk17u-dev] RFR: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 11:47:28 GMT, Aleksey Shipilev wrote: > Clean backport to improve ARM32 reliability. > > Additional testing: > - [x] Linux ARM32 fastdebug `make bootcycle-images` Hey Aleksey, thanks for the backport. Code looks good. I haven't worked on ARMv5 for a long time, so I have to reactivate my setup and see if I can run some tests. Will report back as soon as I have some results. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/927 From rmarchenko at openjdk.org Thu Nov 24 10:20:36 2022 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 24 Nov 2022 10:20:36 GMT Subject: [jdk17u-dev] Integrated: 8282511: Use fixed certificate validation date in SSLExampleCert template In-Reply-To: References: Message-ID: On Mon, 14 Nov 2022 15:33:26 GMT, Roman Marchenko wrote: > Backport JDK-8282511 to 17u > Clean backport. > The test changed only. > > There are previous PRs this PR depends on: > > - #880 > - #881 This pull request has now been integrated. Changeset: 4f5d8470 Author: Roman Marchenko Committer: Yuri Nesterenko URL: https://git.openjdk.org/jdk17u-dev/commit/4f5d8470e29d8b7e5ec6d0f01c45a6559b5aec7e Stats: 218 lines in 2 files changed: 37 ins; 2 del; 179 mod 8282511: Use fixed certificate validation date in SSLExampleCert template Backport-of: 268fa693188b685de6289927ee5a1e99473a50f6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/882 From clanger at openjdk.org Thu Nov 24 11:04:36 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 24 Nov 2022 11:04:36 GMT Subject: [jdk19u] Integrated: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 11:05:43 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8296945](https://bugs.openjdk.org/browse/JDK-8296945), commit [bcc6b12b](https://github.com/openjdk/jdk/commit/bcc6b12b711a9c5007d963123fb38a7e72aaf8e5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 21 Nov 2022 and was reviewed by Mandy Chung and Tobias Hartmann. > > Thanks! This pull request has now been integrated. Changeset: a3707580 Author: Christoph Langer URL: https://git.openjdk.org/jdk19u/commit/a3707580ab9695bde625e07e8cfe6e6645edb417 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8296945: PublicMethodsTest is slow due to dependency verification with debug builds Backport-of: bcc6b12b711a9c5007d963123fb38a7e72aaf8e5 ------------- PR: https://git.openjdk.org/jdk19u/pull/80 From vrudomet at openjdk.org Thu Nov 24 12:27:50 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Thu, 24 Nov 2022 12:27:50 GMT Subject: [jdk19u] Integrated: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 20:41:05 GMT, Victor Rudometov wrote: > Backport for > [JDK-8297153](https://bugs.openjdk.org/browse/JDK-8297153) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again > [JDK-8297241](https://bugs.openjdk.org/browse/JDK-8297241) Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java > > Original commit: https://github.com/openjdk/jdk/commit/3c0949824e06f2b3d44f1bde9d2292a7627b0197 > > Clean backport. > Fixing unstable test. > Checked on mac and linux by running: > make run-test TEST="test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java" > > This PR depends on https://github.com/openjdk/jdk19u/pull/89 This pull request has now been integrated. Changeset: 677a7c44 Author: Victor Rudometov Committer: Christoph Langer URL: https://git.openjdk.org/jdk19u/commit/677a7c445d4124e5bee61f62aebc7e6f2354b7d6 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java 8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again Backport-of: 3c0949824e06f2b3d44f1bde9d2292a7627b0197 ------------- PR: https://git.openjdk.org/jdk19u/pull/90 From shade at openjdk.org Thu Nov 24 12:40:42 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Nov 2022 12:40:42 GMT Subject: [jdk17u-dev] RFR: 8270155: ARM32: Improve register dump in hs_err In-Reply-To: References: Message-ID: <0l_JpZoKZRHpcB58Fyj--9ZHjTSX2mConJaI3C-FU-w=.f4aed387-051b-4ebf-9918-8e13eeaf2d32@github.com> On Wed, 23 Nov 2022 11:41:47 GMT, Aleksey Shipilev wrote: > Clean backport to improve ARM32 error handling. > > Additional testing: > - [x] Linux ARM32 fastdebug `make bootcycle-images` > - [x] Ad-hoc Linux ARM32 fastdebug crashes, eyeballing hs-errs Got the push approval. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/926 From duke at openjdk.org Thu Nov 24 12:42:43 2022 From: duke at openjdk.org (zzambers) Date: Thu, 24 Nov 2022 12:42:43 GMT Subject: [jdk17u-dev] Integrated: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation In-Reply-To: References: Message-ID: On Wed, 21 Sep 2022 11:16:19 GMT, zzambers wrote: > Backport of fix for P11PSSSignature not to print debug message during normal operation. > > Applies cleanly. Passed jdk_security tests. This pull request has now been integrated. Changeset: 17438250 Author: Zdenek Zambersky Committer: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/17438250773d086b5db0480152942799e7accf60 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation Backport-of: 2057070eb069ccee20760e47bd5e09590850d2ce ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/708 From shade at openjdk.org Thu Nov 24 12:43:41 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Nov 2022 12:43:41 GMT Subject: [jdk17u-dev] Integrated: 8270155: ARM32: Improve register dump in hs_err In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 11:41:47 GMT, Aleksey Shipilev wrote: > Clean backport to improve ARM32 error handling. > > Additional testing: > - [x] Linux ARM32 fastdebug `make bootcycle-images` > - [x] Ad-hoc Linux ARM32 fastdebug crashes, eyeballing hs-errs This pull request has now been integrated. Changeset: 615bf959 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/615bf959ff08c1efa42ab64bdc751be9d6ccdd92 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8270155: ARM32: Improve register dump in hs_err Backport-of: 589a1d53df0f53c064fda8a2ac491e0a536ea487 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/926 From duke at openjdk.org Thu Nov 24 13:10:36 2022 From: duke at openjdk.org (zzambers) Date: Thu, 24 Nov 2022 13:10:36 GMT Subject: [jdk17u-dev] RFR: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation In-Reply-To: References: Message-ID: <8tkiWMMhc2OYC87xfkS7sqCPe0Er_oW9lv0zFp_rbHQ=.ff21ee3e-f2c3-43c2-a484-4f6b0a8d8164@github.com> On Wed, 21 Sep 2022 11:16:19 GMT, zzambers wrote: > Backport of fix for P11PSSSignature not to print debug message during normal operation. > > Applies cleanly. Passed jdk_security tests. @RealCLanger Thanks ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/708 From sgehwolf at openjdk.org Thu Nov 24 14:30:36 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 24 Nov 2022 14:30:36 GMT Subject: [jdk17u-dev] RFR: 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField Message-ID: Clean backport which is needed for JDK 17-based future GraalVM builds. Testing: jvmci tests (passed). ------------- Commit messages: - 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField Changes: https://git.openjdk.org/jdk17u-dev/pull/929/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=929&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296961 Stats: 37 lines in 2 files changed: 34 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/929.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/929/head:pull/929 PR: https://git.openjdk.org/jdk17u-dev/pull/929 From sgehwolf at openjdk.org Thu Nov 24 14:34:35 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 24 Nov 2022 14:34:35 GMT Subject: [jdk17u-dev] RFR: 8296960: [JVMCI] list HotSpotConstantPool.loadReferencedType to ConstantPool Message-ID: Clean backport which is needed for JDK 17-based future GraalVM builds. Testing: jvmci tests (passed) ------------- Commit messages: - 8296960: [JVMCI] list HotSpotConstantPool.loadReferencedType to ConstantPool Changes: https://git.openjdk.org/jdk17u-dev/pull/930/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=930&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296960 Stats: 19 lines in 2 files changed: 19 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/930.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/930/head:pull/930 PR: https://git.openjdk.org/jdk17u-dev/pull/930 From clanger at openjdk.org Thu Nov 24 15:01:20 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 24 Nov 2022 15:01:20 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v26] In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 12:48:08 GMT, George Adams wrote: >> The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. >> >> This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. >> >> @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. > > George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > win fixpath for makefile I went over this PR now. It's rather huge and causes some headache - but on the other hand it modernizes the windows build environment and helps to significantly improve Github Actions testing. So I think we should go for it. Testing in SAP's environment showed no issues or regressions. One last question I have: The original change removes make/autoconf/util_windows.m4. Any reason why this is missed out here? ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From clanger at openjdk.org Thu Nov 24 15:12:32 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 24 Nov 2022 15:12:32 GMT Subject: [jdk11u-dev] RFR: 8268860: Windows-Aarch64 build is failing in GitHub actions [v3] In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 16:18:15 GMT, George Adams wrote: >> Applies cleanly except for the change added in https://github.com/openjdk/jdk11u-dev/commit/5d28a71c1f1b734a4d8f05363aa61c2b5b6df687 > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > bump actions versions Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1538 From clanger at openjdk.org Thu Nov 24 15:15:28 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 24 Nov 2022 15:15:28 GMT Subject: [jdk11u-dev] RFR: 8287724: Fix various issues with msys2 In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 13:21:30 GMT, George Adams wrote: > This is the final piece of the puzzle in order to backport the GitHub actions refactor Looks like clean, except for copyright... ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1539 From gdams at openjdk.org Thu Nov 24 15:28:26 2022 From: gdams at openjdk.org (George Adams) Date: Thu, 24 Nov 2022 15:28:26 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v27] In-Reply-To: References: Message-ID: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. George Adams has updated the pull request incrementally with one additional commit since the last revision: remove make/autoconf/util_windows.m4 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1278/files - new: https://git.openjdk.org/jdk11u-dev/pull/1278/files/87c7ed36..ec5c2cd7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=26 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1278&range=25-26 Stats: 308 lines in 1 file changed: 0 ins; 308 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1278.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1278/head:pull/1278 PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From gdams at openjdk.org Thu Nov 24 15:28:27 2022 From: gdams at openjdk.org (George Adams) Date: Thu, 24 Nov 2022 15:28:27 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v26] In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 14:57:19 GMT, Christoph Langer wrote: > One last question I have: The original change removes make/autoconf/util_windows.m4. Any reason why this is missed out here? Good spot, removed it now ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From clanger at openjdk.org Thu Nov 24 16:10:28 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 24 Nov 2022 16:10:28 GMT Subject: [jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v27] In-Reply-To: References: Message-ID: <4wSleMzdsN0GfCfmyiaDNziaw_WojjVQbU6The5Bq-s=.3c8aa60d-a3fb-421d-8743-a709705c7eb7@github.com> On Thu, 24 Nov 2022 15:28:26 GMT, George Adams wrote: >> The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. >> >> This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. >> >> @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > remove make/autoconf/util_windows.m4 Looks good to me now. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From clanger at openjdk.org Thu Nov 24 16:15:19 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 24 Nov 2022 16:15:19 GMT Subject: [jdk19u] RFR: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used Message-ID: Hi all, This pull request contains a backport of [JDK-8297147](https://bugs.openjdk.org/browse/JDK-8297147), commit [88957a7c](https://github.com/openjdk/jdk/commit/88957a7ce8932b95e3a18e6a7d1ceb3b7f60c781) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Matthias Baesken on 22 Nov 2022 and was reviewed by Thomas Stuefe and Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport 88957a7ce8932b95e3a18e6a7d1ceb3b7f60c781 Changes: https://git.openjdk.org/jdk19u/pull/93/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=93&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297147 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/93.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/93/head:pull/93 PR: https://git.openjdk.org/jdk19u/pull/93 From clanger at openjdk.org Thu Nov 24 16:47:07 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 24 Nov 2022 16:47:07 GMT Subject: [jdk17u-dev] Integrated: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect In-Reply-To: References: Message-ID: On Thu, 17 Nov 2022 22:36:22 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of commit ced88a2f from the openjdk/jdk repository. > > The commit being backported was authored by Erik Gahlin on 11 Nov 2022 and was reviewed by Christoph Langer and Markus Gr?nlund. > > Thanks! This pull request has now been integrated. Changeset: 10e16274 Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/10e16274c4d63964dfb38671628c3bafa423c877 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect Reviewed-by: phh Backport-of: ced88a2fd9a35e0e027661ef1f3c5ea3a5fff9e0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/895 From jbhateja at openjdk.org Thu Nov 24 16:49:52 2022 From: jbhateja at openjdk.org (Jatin Bhateja) Date: Thu, 24 Nov 2022 16:49:52 GMT Subject: [jdk17u-dev] RFR: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets. [v2] In-Reply-To: References: Message-ID: > Clean backport of [JDK-8290322](https://bugs.openjdk.org/browse/JDK-8290322), due to merge conflicts original patch could not be applied directly by bot. > > Patch enables wide vector byte level permutation for AVX512BW targets and benefits multiple generations of Intel's Xeon servers (SKX, CLX, CPX) prior to Ice lake which provides a direct HW instruction (VPERMB). JIT instruction sequence emitted in this case is specific to Vector.rearrange API, hence the scope of the patch is limited to VectorAPIs which is an incubating module currently. > > Vector API jtreg test suite contains multiple tests cases for ByteVector.SPECIES_512 to extensively tests the patch. > > Original patch review was done with [PR 9498](https://github.com/openjdk/jdk/pull/9498) Jatin Bhateja has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 38a81913d33c856d64b7c26f934026815a482e43 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/917/files - new: https://git.openjdk.org/jdk17u-dev/pull/917/files/1cd4752e..697699eb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=917&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=917&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/917.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/917/head:pull/917 PR: https://git.openjdk.org/jdk17u-dev/pull/917 From vrudomet at openjdk.org Thu Nov 24 17:40:27 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Thu, 24 Nov 2022 17:40:27 GMT Subject: [jdk11u-dev] Integrated: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java In-Reply-To: <6Y8_G48kLjyzptI6G72y-V24iJnWka7fTdEgt9oHOjU=.b08c3125-abbb-47bd-893a-9e5a7f7a6e9f@github.com> References: <6Y8_G48kLjyzptI6G72y-V24iJnWka7fTdEgt9oHOjU=.b08c3125-abbb-47bd-893a-9e5a7f7a6e9f@github.com> Message-ID: <9lylnKvlE7jvpEccfF9ibQfqC7FRhG5iGWhjYrocBqY=.1bb54d3d-cdbf-46ad-8483-64d79b802459@github.com> On Tue, 22 Nov 2022 21:31:56 GMT, Victor Rudometov wrote: > Backport for > [JDK-8297153](https://bugs.openjdk.org/browse/JDK-8297153) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again > [JDK-8297241](https://bugs.openjdk.org/browse/JDK-8297241) Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java > > Original commit: https://github.com/openjdk/jdk/commit/3c0949824e06f2b3d44f1bde9d2292a7627b0197 > > Clean backport. > Fixing unstable test. > Checked on mac and linux by running: > make run-test TEST="test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java" This pull request has now been integrated. Changeset: 382ac6b9 Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/382ac6b955057071006d06234339c521a7b826d1 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java 8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again Backport-of: 3c0949824e06f2b3d44f1bde9d2292a7627b0197 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1546 From vrudomet at openjdk.org Thu Nov 24 17:40:49 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Thu, 24 Nov 2022 17:40:49 GMT Subject: [jdk17u-dev] Integrated: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 21:31:59 GMT, Victor Rudometov wrote: > Backport for > [JDK-8297153](https://bugs.openjdk.org/browse/JDK-8297153) sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again > [JDK-8297241](https://bugs.openjdk.org/browse/JDK-8297241) Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java > > Original commit: https://github.com/openjdk/jdk/commit/3c0949824e06f2b3d44f1bde9d2292a7627b0197 > > Clean backport. > Fixing unstable test. > Checked on mac and linux by running: > make run-test TEST="test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java" This pull request has now been integrated. Changeset: 22df666f Author: Victor Rudometov Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/22df666f116f04e3c3bf6d0a17e845eed5a2c254 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java 8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again Backport-of: 3c0949824e06f2b3d44f1bde9d2292a7627b0197 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/919 From vkempik at openjdk.org Thu Nov 24 17:53:35 2022 From: vkempik at openjdk.org (Vladimir Kempik) Date: Thu, 24 Nov 2022 17:53:35 GMT Subject: [jdk19u] Integrated: 8296602: RISC-V: improve performance of copy_memory stub In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 11:17:11 GMT, Vladimir Kempik wrote: > Clean backport to jdk19u > test results to follow This pull request has now been integrated. Changeset: 7e340b3c Author: Vladimir Kempik URL: https://git.openjdk.org/jdk19u/commit/7e340b3c79639dfe5ba10e0f17625d1f02a80027 Stats: 70 lines in 1 file changed: 41 ins; 1 del; 28 mod 8296602: RISC-V: improve performance of copy_memory stub Backport-of: bd57e2138fc980822a149af905e572ab71ccbf11 ------------- PR: https://git.openjdk.org/jdk19u/pull/77 From luhenry at openjdk.org Thu Nov 24 18:05:09 2022 From: luhenry at openjdk.org (Ludovic Henry) Date: Thu, 24 Nov 2022 18:05:09 GMT Subject: [jdk19u] RFR: 8295264: Fix PaX check on RISC-V In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 06:45:50 GMT, Vladimir Kempik wrote: >> On Linux RISC-V, PROT_WRITE doesn't imply PROT_READ [1] >> >> The fix is to pass PROT_READ|PROT_WRITE. That matches all other calls to mmap in hotspot. >> >> [1] https://lkml.org/lkml/2022/9/8/1066 > > Yes @VladimirKempik I would need your sponsor to merge this PR. ------------- PR: https://git.openjdk.org/jdk19u/pull/91 From luhenry at openjdk.org Thu Nov 24 18:29:29 2022 From: luhenry at openjdk.org (Ludovic Henry) Date: Thu, 24 Nov 2022 18:29:29 GMT Subject: [jdk19u] Integrated: 8295264: Fix PaX check on RISC-V In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 20:49:58 GMT, Ludovic Henry wrote: > On Linux RISC-V, PROT_WRITE doesn't imply PROT_READ [1] > > The fix is to pass PROT_READ|PROT_WRITE. That matches all other calls to mmap in hotspot. > > [1] https://lkml.org/lkml/2022/9/8/1066 This pull request has now been integrated. Changeset: 4b6571b4 Author: Ludovic Henry Committer: Vladimir Kempik URL: https://git.openjdk.org/jdk19u/commit/4b6571b4e471d414b4b45d122800135ae5f705bc Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8295264: Fix PaX check on RISC-V Reviewed-by: vkempik ------------- PR: https://git.openjdk.org/jdk19u/pull/91 From phh at openjdk.org Thu Nov 24 18:35:34 2022 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 24 Nov 2022 18:35:34 GMT Subject: [jdk17u-dev] RFR: 8285093: Introduce UTIL_ARG_WITH [v2] In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 01:35:17 GMT, Ben Taylor wrote: >> Backporting to make [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) clean. >> >> This change is independent of #914 but both are required for [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). > > Ben Taylor has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: > > - Backport 94afb366b2ec76669e1aac38dbadc223ccafda3d > - Backport 5bfd043e16fa79a101a1bee38c59d42d4cd69a48 This appears to be built on top of https://github.com/openjdk/jdk17u-dev/pull/914/files. Please rebase against 914, see https://blog.logrocket.com/using-stacked-pull-requests-in-github/. ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/915 From serb at openjdk.org Fri Nov 25 04:41:57 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 25 Nov 2022 04:41:57 GMT Subject: [jdk13u-dev] RFR: 8296496: Overzealous check in sizecalc.h prevents large memory allocation Message-ID: Hi all, This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. Thanks! ------------- Commit messages: - Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 Changes: https://git.openjdk.org/jdk13u-dev/pull/432/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=432&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296496 Stats: 11 lines in 1 file changed: 0 ins; 4 del; 7 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/432.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/432/head:pull/432 PR: https://git.openjdk.org/jdk13u-dev/pull/432 From fjiang at openjdk.org Fri Nov 25 06:19:50 2022 From: fjiang at openjdk.org (Feilong Jiang) Date: Fri, 25 Nov 2022 06:19:50 GMT Subject: [jdk19u] RFR: 8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V Message-ID: Please review this backport to jdk19u. Backport of [JDK-8297476](https://bugs.openjdk.org/browse/JDK-8297476). Applies cleanly. Approval is pending. ------------- Commit messages: - Backport 5e196b4b8e623107424e2fb54672790fd925fe73 Changes: https://git.openjdk.org/jdk19u/pull/94/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=94&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297476 Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/94.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/94/head:pull/94 PR: https://git.openjdk.org/jdk19u/pull/94 From clanger at openjdk.org Fri Nov 25 06:43:56 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 25 Nov 2022 06:43:56 GMT Subject: [jdk17u-dev] RFR: 8296904: Improve handling of macos xcode toolchain Message-ID: I had to adapt the configure changes for the new option to the level of code in jdk17u. Furthermore, I regenerated docs/building.html which brings it in sync with building.md and removes a change that should not have been made when backporting [JDK-8280863](https://bugs.openjdk.org/browse/JDK-8280863). ------------- Commit messages: - Backport 470f3424fcce0e41b75cccdd5e3a56771cd07ff5 Changes: https://git.openjdk.org/jdk17u-dev/pull/931/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=931&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296904 Stats: 58 lines in 3 files changed: 16 ins; 0 del; 42 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/931.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/931/head:pull/931 PR: https://git.openjdk.org/jdk17u-dev/pull/931 From clanger at openjdk.org Fri Nov 25 06:57:59 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 25 Nov 2022 06:57:59 GMT Subject: [jdk19u] Integrated: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 16:07:57 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8297147](https://bugs.openjdk.org/browse/JDK-8297147), commit [88957a7c](https://github.com/openjdk/jdk/commit/88957a7ce8932b95e3a18e6a7d1ceb3b7f60c781) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 22 Nov 2022 and was reviewed by Thomas Stuefe and Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: ddc190ed Author: Christoph Langer URL: https://git.openjdk.org/jdk19u/commit/ddc190ed910f3f47f4b720b9823ec47e176a6e41 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used Backport-of: 88957a7ce8932b95e3a18e6a7d1ceb3b7f60c781 ------------- PR: https://git.openjdk.org/jdk19u/pull/93 From lzhai at openjdk.org Fri Nov 25 08:19:31 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Fri, 25 Nov 2022 08:19:31 GMT Subject: [jdk18u] RFR: 8275731: CDS archived enums objects are recreated at runtime Message-ID: Hi, Commit https://github.com/openjdk/jdk/commit/d983d108c565654e717e2811d88aa94d982da2f5 fix [JDK-8297543](https://bugs.openjdk.org/browse/JDK-8297543): runtime/cds/appcds/cacheObject/ArchivedModuleCompareTest.java fail with jfx git checkout https://github.com/openjdk/jdk/commit/c7cd1487fe00172be59e7571991f960c59b8c0eb reproduced the issue for jdk, then rebase to https://github.com/openjdk/jdk/commit/d983d108c565654e717e2811d88aa94d982da2f5 testcase Passed. I am backporting the patchest for jdk18u at first, and testing jtreg tier1~3 now. Thanks, Leslie Zhai --------- ### Progress - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer)) - [x] Change must not contain extraneous whitespace - [x] Commit message must refer to an issue ### Error  ?? The pull request body must not be empty. ### Reviewing
Using git Checkout this PR locally: \ `$ git fetch https://git.openjdk.org/jdk18u pull/179/head:pull/179` \ `$ git checkout pull/179` Update a local copy of the PR: \ `$ git checkout pull/179` \ `$ git pull https://git.openjdk.org/jdk18u pull/179/head`
Using Skara CLI tools Checkout this PR locally: \ `$ git pr checkout 179` View PR using the GUI difftool: \ `$ git pr show -t 179`
Using diff file Download this PR as a diff file: \ https://git.openjdk.org/jdk18u/pull/179.diff
------------- Commit messages: - Backport d983d108c565654e717e2811d88aa94d982da2f5 Changes: https://git.openjdk.org/jdk18u/pull/179/files Webrev: https://webrevs.openjdk.org/?repo=jdk18u&pr=179&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275731 Stats: 859 lines in 16 files changed: 807 ins; 4 del; 48 mod Patch: https://git.openjdk.org/jdk18u/pull/179.diff Fetch: git fetch https://git.openjdk.org/jdk18u pull/179/head:pull/179 PR: https://git.openjdk.org/jdk18u/pull/179 From serb at openjdk.org Fri Nov 25 08:22:56 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 25 Nov 2022 08:22:56 GMT Subject: [jdk11u-dev] RFR: 8296496: Overzealous check in sizecalc.h prevents large memory allocation Message-ID: Hi all, This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. Thanks! ------------- Commit messages: - Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 Changes: https://git.openjdk.org/jdk11u-dev/pull/1551/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1551&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296496 Stats: 11 lines in 1 file changed: 0 ins; 4 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1551.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1551/head:pull/1551 PR: https://git.openjdk.org/jdk11u-dev/pull/1551 From serb at openjdk.org Fri Nov 25 08:22:56 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 25 Nov 2022 08:22:56 GMT Subject: [jdk11u-dev] RFR: 8296496: Overzealous check in sizecalc.h prevents large memory allocation In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 02:33:50 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. > Thanks! The tier1 test failure is unrelated to this change, see https://bugs.openjdk.org/browse/JDK-8272195 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1551 From mbaesken at openjdk.org Fri Nov 25 08:35:53 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 25 Nov 2022 08:35:53 GMT Subject: [jdk17u-dev] Integrated: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used In-Reply-To: <0L6H7y6ACShDKr5pENRo9wZ0OYwl5agyVjTR1T-Y10w=.e61783bb-0050-479c-b7dd-b40c14b307c9@github.com> References: <0L6H7y6ACShDKr5pENRo9wZ0OYwl5agyVjTR1T-Y10w=.e61783bb-0050-479c-b7dd-b40c14b307c9@github.com> Message-ID: On Wed, 23 Nov 2022 08:24:27 GMT, Matthias Baesken wrote: > 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used This pull request has now been integrated. Changeset: 4c87089a Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/4c87089a231abb77d72c53690a504f232bade6c2 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used Backport-of: 88957a7ce8932b95e3a18e6a7d1ceb3b7f60c781 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/923 From gdams at openjdk.org Fri Nov 25 08:50:52 2022 From: gdams at openjdk.org (George Adams) Date: Fri, 25 Nov 2022 08:50:52 GMT Subject: [jdk11u-dev] Integrated: 8257679: Improved unix compatibility layer in Windows build (winenv) In-Reply-To: References: Message-ID: On Thu, 28 Jul 2022 13:54:05 GMT, George Adams wrote: > The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten. > > This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds. > > @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged. This pull request has now been integrated. Changeset: 40f4fc2d Author: George Adams URL: https://git.openjdk.org/jdk11u-dev/commit/40f4fc2da8532252a1660c7f082eb19046f4bc70 Stats: 4460 lines in 45 files changed: 1932 ins; 2187 del; 341 mod 8257679: Improved unix compatibility layer in Windows build (winenv) 8260272: bash configure --prefix does not work after JDK-8257679 Reviewed-by: clanger Backport-of: d29c78da19ba78214efe9e7856cde30fdd9ba8ab ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1278 From gdams at openjdk.org Fri Nov 25 08:52:21 2022 From: gdams at openjdk.org (George Adams) Date: Fri, 25 Nov 2022 08:52:21 GMT Subject: [jdk11u-dev] Integrated: 8259485: Document need for short paths when building on Windows In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 15:15:21 GMT, George Adams wrote: > Backports a simple docs change This pull request has now been integrated. Changeset: 7f440c28 Author: George Adams URL: https://git.openjdk.org/jdk11u-dev/commit/7f440c2849a3ca08723cc37a312bea37a9ec48ae Stats: 15 lines in 2 files changed: 15 ins; 0 del; 0 mod 8259485: Document need for short paths when building on Windows Backport-of: 2243a1703b81aba2da0a943fc486e34f635f662c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1543 From gdams at openjdk.org Fri Nov 25 10:37:49 2022 From: gdams at openjdk.org (George Adams) Date: Fri, 25 Nov 2022 10:37:49 GMT Subject: [jdk11u-dev] RFR: 8287724: Fix various issues with msys2 [v2] In-Reply-To: References: Message-ID: <-aSe3UvI6f1jkz9J1HMPRDC0DvBFQc1223KcXrTOrkE=.b278b9ed-2669-41c3-a91e-34ffe41f5f26@github.com> > This is the final piece of the puzzle in order to backport the GitHub actions refactor George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - merge master - Backport 2e21c87fac8d60c3c7ed7b2d0afae9abfc110359 - win fixpath for makefile - Backport 764111ff831096729eb1bcc69a54d92fde67b044 - Backport d29c78da19ba78214efe9e7856cde30fdd9ba8ab ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1539/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1539&range=01 Stats: 38 lines in 3 files changed: 23 ins; 7 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1539.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1539/head:pull/1539 PR: https://git.openjdk.org/jdk11u-dev/pull/1539 From gdams at openjdk.org Fri Nov 25 10:37:55 2022 From: gdams at openjdk.org (George Adams) Date: Fri, 25 Nov 2022 10:37:55 GMT Subject: [jdk11u-dev] RFR: 8268860: Windows-Aarch64 build is failing in GitHub actions [v4] In-Reply-To: References: Message-ID: > Applies cleanly except for the change added in https://github.com/openjdk/jdk11u-dev/commit/5d28a71c1f1b734a4d8f05363aa61c2b5b6df687 George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge remote-tracking branch 'upstream/master' into win_aarch64 - bump actions versions - Backport acc3d995355b646c581623b0df5facbcdbfa4721 - win fixpath for makefile - Backport 764111ff831096729eb1bcc69a54d92fde67b044 - Backport d29c78da19ba78214efe9e7856cde30fdd9ba8ab ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1538/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1538&range=03 Stats: 104 lines in 1 file changed: 103 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1538.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1538/head:pull/1538 PR: https://git.openjdk.org/jdk11u-dev/pull/1538 From cgo at openjdk.org Fri Nov 25 10:38:36 2022 From: cgo at openjdk.org (Christoph =?UTF-8?B?R8O2dHRzY2hrZXM=?=) Date: Fri, 25 Nov 2022 10:38:36 GMT Subject: [jdk17u-dev] RFR: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 11:47:28 GMT, Aleksey Shipilev wrote: > Clean backport to improve ARM32 reliability. > > Additional testing: > - [x] Linux ARM32 fastdebug `make bootcycle-images` Problem is fixed by the backport. I ran some of the tier1 tests and all looks good. I can't run the whole suite right now, would take way too long. ? from my side. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/927 From shade at openjdk.org Fri Nov 25 10:38:36 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Nov 2022 10:38:36 GMT Subject: [jdk17u-dev] RFR: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter In-Reply-To: References: Message-ID: <2M-QwP6uZTGgxHAuMByuZjZRtzH_v6bcBBgi4me3iYs=.7b3a42f6-48e7-4bd4-b197-98eef39c5232@github.com> On Wed, 23 Nov 2022 11:47:28 GMT, Aleksey Shipilev wrote: > Clean backport to improve ARM32 reliability. > > Additional testing: > - [x] Linux ARM32 fastdebug `make bootcycle-images` Excellent, thanks for testing. We got push approval too, so I am integrating. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/927 From clanger at openjdk.org Fri Nov 25 10:42:06 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 25 Nov 2022 10:42:06 GMT Subject: [jdk18u] RFR: 8275731: CDS archived enums objects are recreated at runtime In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 07:54:22 GMT, Leslie Zhai wrote: > Hi, > > Commit https://github.com/openjdk/jdk/commit/d983d108c565654e717e2811d88aa94d982da2f5 fix [JDK-8297543](https://bugs.openjdk.org/browse/JDK-8297543): runtime/cds/appcds/cacheObject/ArchivedModuleCompareTest.java fail with jfx > > git checkout https://github.com/openjdk/jdk/commit/c7cd1487fe00172be59e7571991f960c59b8c0eb reproduced the issue for jdk, then rebase to https://github.com/openjdk/jdk/commit/d983d108c565654e717e2811d88aa94d982da2f5 testcase Passed. > > I am backporting the patchest for jdk18u at first, and testing jtreg tier1~3 now. > > Thanks, > Leslie Zhai > > --------- > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.org/jdk18u pull/179/head:pull/179` \ > `$ git checkout pull/179` > > Update a local copy of the PR: \ > `$ git checkout pull/179` \ > `$ git pull https://git.openjdk.org/jdk18u pull/179/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 179` > > View PR using the GUI difftool: \ > `$ git pr show -t 179` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.org/jdk18u/pull/179.diff > >
@xiangzhai, you can close this PR. jdk18u is not maintained any more. If required, you could backport this to OpenJDK 17 updates via the jdk17u-dev repository. ------------- PR: https://git.openjdk.org/jdk18u/pull/179 From lzhai at openjdk.org Fri Nov 25 10:42:06 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Fri, 25 Nov 2022 10:42:06 GMT Subject: [jdk18u] RFR: 8275731: CDS archived enums objects are recreated at runtime In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 09:35:50 GMT, Christoph Langer wrote: >> Hi, >> >> Commit https://github.com/openjdk/jdk/commit/d983d108c565654e717e2811d88aa94d982da2f5 fix [JDK-8297543](https://bugs.openjdk.org/browse/JDK-8297543): runtime/cds/appcds/cacheObject/ArchivedModuleCompareTest.java fail with jfx >> >> git checkout https://github.com/openjdk/jdk/commit/c7cd1487fe00172be59e7571991f960c59b8c0eb reproduced the issue for jdk, then rebase to https://github.com/openjdk/jdk/commit/d983d108c565654e717e2811d88aa94d982da2f5 testcase Passed. >> >> I am backporting the patchest for jdk18u at first, and testing jtreg tier1~3 now. >> >> Thanks, >> Leslie Zhai >> >> --------- >> ### Progress >> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an issue >> >> >> >> ### Reviewing >>
Using git >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.org/jdk18u pull/179/head:pull/179` \ >> `$ git checkout pull/179` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/179` \ >> `$ git pull https://git.openjdk.org/jdk18u pull/179/head` >> >>
>>
Using Skara CLI tools >> >> Checkout this PR locally: \ >> `$ git pr checkout 179` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 179` >> >>
>>
Using diff file >> >> Download this PR as a diff file: \ >> https://git.openjdk.org/jdk18u/pull/179.diff >> >>
> > @xiangzhai, you can close this PR. jdk18u is not maintained any more. If required, you could backport this to OpenJDK 17 updates via the jdk17u-dev repository. Hi @RealCLanger Thanks for your remind! Leslie Zhai ------------- PR: https://git.openjdk.org/jdk18u/pull/179 From lzhai at openjdk.org Fri Nov 25 10:42:06 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Fri, 25 Nov 2022 10:42:06 GMT Subject: [jdk18u] Withdrawn: 8275731: CDS archived enums objects are recreated at runtime In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 07:54:22 GMT, Leslie Zhai wrote: > Hi, > > Commit https://github.com/openjdk/jdk/commit/d983d108c565654e717e2811d88aa94d982da2f5 fix [JDK-8297543](https://bugs.openjdk.org/browse/JDK-8297543): runtime/cds/appcds/cacheObject/ArchivedModuleCompareTest.java fail with jfx > > git checkout https://github.com/openjdk/jdk/commit/c7cd1487fe00172be59e7571991f960c59b8c0eb reproduced the issue for jdk, then rebase to https://github.com/openjdk/jdk/commit/d983d108c565654e717e2811d88aa94d982da2f5 testcase Passed. > > I am backporting the patchest for jdk18u at first, and testing jtreg tier1~3 now. > > Thanks, > Leslie Zhai > > --------- > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > > > > ### Reviewing >
Using git > > Checkout this PR locally: \ > `$ git fetch https://git.openjdk.org/jdk18u pull/179/head:pull/179` \ > `$ git checkout pull/179` > > Update a local copy of the PR: \ > `$ git checkout pull/179` \ > `$ git pull https://git.openjdk.org/jdk18u pull/179/head` > >
>
Using Skara CLI tools > > Checkout this PR locally: \ > `$ git pr checkout 179` > > View PR using the GUI difftool: \ > `$ git pr show -t 179` > >
>
Using diff file > > Download this PR as a diff file: \ > https://git.openjdk.org/jdk18u/pull/179.diff > >
This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk18u/pull/179 From shade at openjdk.org Fri Nov 25 11:08:02 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Nov 2022 11:08:02 GMT Subject: [jdk17u-dev] Integrated: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 11:47:28 GMT, Aleksey Shipilev wrote: > Clean backport to improve ARM32 reliability. > > Additional testing: > - [x] Linux ARM32 fastdebug `make bootcycle-images` This pull request has now been integrated. Changeset: 8ed9f83e Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/8ed9f83e8261cae7494405d2150bba26d4b9591d Stats: 16 lines in 1 file changed: 5 ins; 4 del; 7 mod 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter Backport-of: a066c7bed0f9aa45fb9384f75ae84943548cd859 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/927 From sgehwolf at openjdk.org Fri Nov 25 11:08:14 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 11:08:14 GMT Subject: [jdk17u-dev] Integrated: 8296960: [JVMCI] list HotSpotConstantPool.loadReferencedType to ConstantPool In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 14:27:04 GMT, Severin Gehwolf wrote: > Clean backport which is needed for JDK 17-based future GraalVM builds. > > Testing: jvmci tests (passed) This pull request has now been integrated. Changeset: aec08843 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/aec08843209fee4a43be4b6b5cbe1135534e598a Stats: 19 lines in 2 files changed: 19 ins; 0 del; 0 mod 8296960: [JVMCI] list HotSpotConstantPool.loadReferencedType to ConstantPool Backport-of: b3ef337566c2cf78de1f636e039c799a1bfcb17e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/930 From sgehwolf at openjdk.org Fri Nov 25 11:08:25 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 11:08:25 GMT Subject: [jdk17u-dev] Integrated: 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 14:22:35 GMT, Severin Gehwolf wrote: > Clean backport which is needed for JDK 17-based future GraalVM builds. > > Testing: jvmci tests (passed). This pull request has now been integrated. Changeset: 20f22188 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/20f22188e28918ee51db7c62e74acb4316672d5a Stats: 37 lines in 2 files changed: 34 ins; 0 del; 3 mod 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField Backport-of: 5db1b58c867608573a9e7cc57ca2ba22c9dd80d4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/929 From yan at openjdk.org Fri Nov 25 11:08:50 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 25 Nov 2022 11:08:50 GMT Subject: [jdk13u-dev] RFR: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Message-ID: Clean backport of the fix to a test failing because of just expired certificates. ------------- Commit messages: - Backport b6ea69c06aca7f013e26596cebd039960c5b4d34 Changes: https://git.openjdk.org/jdk13u-dev/pull/433/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=433&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296480 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/433.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/433/head:pull/433 PR: https://git.openjdk.org/jdk13u-dev/pull/433 From clanger at openjdk.org Fri Nov 25 11:08:55 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 25 Nov 2022 11:08:55 GMT Subject: [jdk11u-dev] RFR: 8222091: Javadoc does not handle package annotations correctly on package-info.java In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 17:06:11 GMT, Liam Miller-Cushon wrote: > This is a backport of [JDK-8222091: Javadoc does not handle package annotations correctly on package-info.java](https://bugs.openjdk.java.net/browse/JDK-8222091) > > This fixes a regression in 11.0.17 caused by the backport of [JDK-8193462](https://bugs.openjdk.org/browse/JDK-8193462), see [JDK-8295850](https://bugs.openjdk.org/browse/JDK-8295850) > > Original patch applied cleanly, the test was updated due to some changes in test infrastructrure: > > > diff --git a/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java b/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java > index cd9697eede..9f04777f81 100644 > --- a/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java > +++ b/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java > @@ -25,14 +25,12 @@ > * @test > * @bug 8222091 > * @summary Javadoc does not handle package annotations correctly on package-info.java > - * @library ../../lib/ > + * @library ../lib/ > * @modules jdk.javadoc/jdk.javadoc.internal.tool > - * @build javadoc.tester.* > + * @build JavadocTester > * @run main TestPackageAnnotation > */ > > -import javadoc.tester.JavadocTester; > - > public class TestPackageAnnotation extends JavadocTester { > > public static void main(String... args) throws Exception { > > > Tested: tier1 langtools tests passed LGTM. Thanks for fixing the regression. I'll additionally run it through SAP's nightlies. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1475 From yan at openjdk.org Fri Nov 25 11:08:57 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 25 Nov 2022 11:08:57 GMT Subject: [jdk15u-dev] RFR: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Message-ID: Clean backport of the fix to a test failing because of just expired certificates. ------------- Commit messages: - Backport b6ea69c06aca7f013e26596cebd039960c5b4d34 Changes: https://git.openjdk.org/jdk15u-dev/pull/307/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=307&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296480 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/307.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/307/head:pull/307 PR: https://git.openjdk.org/jdk15u-dev/pull/307 From mbaesken at openjdk.org Fri Nov 25 11:21:29 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 25 Nov 2022 11:21:29 GMT Subject: [jdk17u-dev] RFR: 8296904: Improve handling of macos xcode toolchain In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 06:28:49 GMT, Christoph Langer wrote: > I had to adapt the configure changes for the new option to the level of code in jdk17u. > > Furthermore, I regenerated docs/building.html which brings it in sync with building.md and removes a change that should not have been made when backporting [JDK-8280863](https://bugs.openjdk.org/browse/JDK-8280863). We always check TOOLCHAIN_PATH in basic.m4 UTIL_LOOKUP_PROGS(XCODEBUILD, xcodebuild, $TOOLCHAIN_PATH) Shouldn't we do it similar to jdk/jdk ? There we check in case of DEVKIT_ROOT set, DEKIT_TOOLCHAIN_PATH. In case of TOOLCHAIN_PATH set we check TOOLCHAIN_PATH. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/931 From duke at openjdk.org Fri Nov 25 11:29:28 2022 From: duke at openjdk.org (zzambers) Date: Fri, 25 Nov 2022 11:29:28 GMT Subject: [jdk17u-dev] Integrated: 8295952: Problemlist existing compiler/rtm tests also on x86 In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 23:57:12 GMT, zzambers wrote: > Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected. This pull request has now been integrated. Changeset: 22ad4098 Author: Zdenek Zambersky Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/22ad4098aa67eef9214b71e9de668f3db2e144a0 Stats: 11 lines in 1 file changed: 0 ins; 0 del; 11 mod 8295952: Problemlist existing compiler/rtm tests also on x86 Backport-of: 3f2f128af6ec2f9097af7758bfd41aeaa4354d40 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/920 From mbaesken at openjdk.org Fri Nov 25 11:32:28 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 25 Nov 2022 11:32:28 GMT Subject: [jdk17u-dev] Integrated: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests In-Reply-To: <-xmYMDEGeHpfc4NzaO3LqMD500G0s_M7dhGZMmzkmX8=.fa9415bc-2e4e-405f-9d91-fc9f2702bf7f@github.com> References: <-xmYMDEGeHpfc4NzaO3LqMD500G0s_M7dhGZMmzkmX8=.fa9415bc-2e4e-405f-9d91-fc9f2702bf7f@github.com> Message-ID: <5GrMdY9SVYo06dLM7ssvGNe4v4fnfv-2Gc48RbVHMeE=.2f6d7c5f-b98e-4df5-bad9-0735153230a3@github.com> On Fri, 18 Nov 2022 13:23:30 GMT, Matthias Baesken wrote: > 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests This pull request has now been integrated. Changeset: 44c8733b Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/44c8733bf6bb178fc1c05f3b649b01f9bbbebf3b Stats: 24 lines in 7 files changed: 8 ins; 0 del; 16 mod 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests Backport-of: d5d34241e21305379f1858556f225e7645cd294e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/900 From gdams at openjdk.org Fri Nov 25 11:33:14 2022 From: gdams at openjdk.org (George Adams) Date: Fri, 25 Nov 2022 11:33:14 GMT Subject: [jdk11u-dev] RFR: 8280863: Update build README to reflect that MSYS2 is supported Message-ID: <6OpiVqxxY5n5adaQdYzRfBSpkq79devpMvcrxqN5qpU=.28e1a462-6795-45a7-98bb-86e5ed1db8cc@github.com> The only diffs are the supported VS versions and the fact that for JDK11u we state that versions older than VS 2017 are likely to be unsupported at some point. ------------- Commit messages: - Backport 204e67a7adedc5ff8ed6dbe1da7aa1397c9beb38 Changes: https://git.openjdk.org/jdk11u-dev/pull/1552/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1552&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280863 Stats: 6 lines in 2 files changed: 0 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1552.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1552/head:pull/1552 PR: https://git.openjdk.org/jdk11u-dev/pull/1552 From clanger at openjdk.org Fri Nov 25 11:33:15 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 25 Nov 2022 11:33:15 GMT Subject: [jdk11u-dev] RFR: 8280863: Update build README to reflect that MSYS2 is supported In-Reply-To: <6OpiVqxxY5n5adaQdYzRfBSpkq79devpMvcrxqN5qpU=.28e1a462-6795-45a7-98bb-86e5ed1db8cc@github.com> References: <6OpiVqxxY5n5adaQdYzRfBSpkq79devpMvcrxqN5qpU=.28e1a462-6795-45a7-98bb-86e5ed1db8cc@github.com> Message-ID: On Fri, 25 Nov 2022 09:16:38 GMT, George Adams wrote: > The only diffs are the supported VS versions and the fact that for JDK11u we state that versions older than VS 2017 are likely to be unsupported at some point. Changes requested by clanger (Reviewer). doc/building.html line 363: > 361: CC: Sun C++ 5.13 SunOS_i386 151846-10 2015/10/30 > 362:

Microsoft Visual Studio

> 363:

The minimum accepted version of Visual Studio is 2010. Older versions will not be accepted by configure. The maximum accepted version of Visual Studio is 2019. Versions older than 2017 are unlikely to continue working for long.

Please remove this hunk. This should not be affected by the change to building.md which is the master document. I will try to regenerate building.html for 11u and possibly rectify diffs in another PR. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1552 From sgehwolf at openjdk.org Fri Nov 25 11:33:31 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 11:33:31 GMT Subject: [jdk17u-dev] RFR: 8296958: [JVMCI] add API for retrieving ConstantValue attributes Message-ID: Backport not clean due to JDK-8289094 not present in 17u which isn't needed. Adapted patch to the older API instead. Omitted hunk in `vmStructs_jvmci.cpp` as that pertains to the virtual threads, not available in 17. This backport is needed in order to be able to build future GraalVM based on JDK 17. Testing: jvmci tests (including changed `TestResolvedJavaField` test), passes. ------------- Commit messages: - 8296958: [JVMCI] add API for retrieving ConstantValue attributes Changes: https://git.openjdk.org/jdk17u-dev/pull/932/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=932&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296958 Stats: 199 lines in 8 files changed: 193 ins; 5 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/932.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/932/head:pull/932 PR: https://git.openjdk.org/jdk17u-dev/pull/932 From yan at openjdk.org Fri Nov 25 11:33:46 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 25 Nov 2022 11:33:46 GMT Subject: [jdk13u-dev] Integrated: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 09:22:22 GMT, Yuri Nesterenko wrote: > Clean backport of the fix to a test failing because of just expired certificates. This pull request has now been integrated. Changeset: c8fb914c Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk13u-dev/commit/c8fb914c6f4fae4b98c7800786ecf88f12f8ac59 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Backport-of: b6ea69c06aca7f013e26596cebd039960c5b4d34 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/433 From yan at openjdk.org Fri Nov 25 11:35:51 2022 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 25 Nov 2022 11:35:51 GMT Subject: [jdk15u-dev] Integrated: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 09:04:57 GMT, Yuri Nesterenko wrote: > Clean backport of the fix to a test failing because of just expired certificates. This pull request has now been integrated. Changeset: 130d34de Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk15u-dev/commit/130d34de847f1c49f128356fd64f3d179df9e1a5 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Backport-of: b6ea69c06aca7f013e26596cebd039960c5b4d34 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/307 From sgehwolf at openjdk.org Fri Nov 25 11:35:59 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 11:35:59 GMT Subject: [jdk17u-dev] RFR: 8296956: [JVMCI] HotSpotResolvedJavaFieldImpl.getIndex returns wrong value Message-ID: Clean backport. Fix applicable to 17u too. JVMCI only change. Testing: jvmci tests (including new test). Passed. ------------- Commit messages: - 8296956: [JVMCI] HotSpotResolvedJavaFieldImpl.getIndex returns wrong value Changes: https://git.openjdk.org/jdk17u-dev/pull/933/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=933&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296956 Stats: 180 lines in 7 files changed: 137 ins; 5 del; 38 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/933.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/933/head:pull/933 PR: https://git.openjdk.org/jdk17u-dev/pull/933 From mbaesken at openjdk.org Fri Nov 25 11:38:05 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 25 Nov 2022 11:38:05 GMT Subject: [jdk11u-dev] RFR: 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free Message-ID: 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free ------------- Commit messages: - Backport 996c0e9317ae9ff0b4ad88d4d050caf2ecf64811 Changes: https://git.openjdk.org/jdk11u-dev/pull/1553/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1553&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292778 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1553.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1553/head:pull/1553 PR: https://git.openjdk.org/jdk11u-dev/pull/1553 From duke at openjdk.org Fri Nov 25 11:39:07 2022 From: duke at openjdk.org (zzambers) Date: Fri, 25 Nov 2022 11:39:07 GMT Subject: [jdk11u-dev] Integrated: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 13:03:15 GMT, zzambers wrote: > Clean backport. With plan to further backporting to JDK 8 where `gc/metaspace/TestCapacityUntilGCWrapAround.java` > also fails on 32-bit windows. > > Testing: > Passes GHA. Ran hotspot/tier1 on win32 build, with and without backport, it fixed that failure, all tests passed with this change (compare [1] [2]). > > [1] https://github.com/zzambers/jdk-tester/actions/runs/3537285215/jobs/5937115368 > [2] https://github.com/zzambers/jdk-tester/actions/runs/3537288999/jobs/5937124628 This pull request has now been integrated. Changeset: 99b722d7 Author: Zdenek Zambersky Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/99b722d79703fb6f2652f0c9243e5a48a8d73680 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails Backport-of: 038f58d4f0782f885547d2b052a47fdf2229cfe3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1549 From clanger at openjdk.org Fri Nov 25 11:40:03 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 25 Nov 2022 11:40:03 GMT Subject: [jdk17u-dev] RFR: 8296904: Improve handling of macos xcode toolchain In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 11:19:04 GMT, Matthias Baesken wrote: > We always check TOOLCHAIN_PATH in basic.m4 UTIL_LOOKUP_PROGS(XCODEBUILD, xcodebuild, $TOOLCHAIN_PATH) Shouldn't we do it similar to jdk/jdk ? There we check in case of DEVKIT_ROOT set, DEKIT_TOOLCHAIN_PATH. In case of TOOLCHAIN_PATH set we check TOOLCHAIN_PATH. Hm, maybe yes. But in that case we should have a look at backporting [JDK-8287254](https://bugs.openjdk.org/browse/JDK-8287254) entirely. For the current level of jdk17u, I would think this fits. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/931 From clanger at openjdk.org Fri Nov 25 11:41:32 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 25 Nov 2022 11:41:32 GMT Subject: [jdk17u-dev] RFR: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx In-Reply-To: <_BQuLfRor1e3eINJL0wGMuTX746FEcjcj0V5Q_G2Qdg=.f92f7f49-b45c-454a-8f6c-cda187d23534@github.com> References: <_le7M-l9Gx61vz8OWeqQQaewtX7fKwHTA9eatOobrE4=.d19d636f-db64-405c-8f34-b6f5fce4eeb7@github.com> <_BQuLfRor1e3eINJL0wGMuTX746FEcjcj0V5Q_G2Qdg=.f92f7f49-b45c-454a-8f6c-cda187d23534@github.com> Message-ID: On Thu, 24 Nov 2022 00:48:50 GMT, Leslie Zhai wrote: >> Since this is a backport, you can (and should) use a "Backport-style" PR by changing the title of this PR to `Backport ` using the 40 char hash of the original commit in the jdk mainline repo. See [BackportPullRequests](https://wiki.openjdk.org/display/SKARA/Backports#Backports-BackportPullRequests) in the Wiki. > > Hi @kevinrushforth > >> changing the title of this PR to Backport using the 40 char hash of the original commit in the jdk mainline repo. > > Thanks for your hint! > > Leslie Zhai @xiangzhai, could you please enable Github Actions on your repository and trigger a GHA run? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/922 From gdams at openjdk.org Fri Nov 25 11:43:49 2022 From: gdams at openjdk.org (George Adams) Date: Fri, 25 Nov 2022 11:43:49 GMT Subject: [jdk11u-dev] Integrated: 8287724: Fix various issues with msys2 In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 13:21:30 GMT, George Adams wrote: > This is the final piece of the puzzle in order to backport the GitHub actions refactor This pull request has now been integrated. Changeset: af27be33 Author: George Adams URL: https://git.openjdk.org/jdk11u-dev/commit/af27be332fe616f075fbcbf993789386658b7084 Stats: 38 lines in 3 files changed: 23 ins; 7 del; 8 mod 8287724: Fix various issues with msys2 Reviewed-by: clanger Backport-of: 2e21c87fac8d60c3c7ed7b2d0afae9abfc110359 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1539 From mbaesken at openjdk.org Fri Nov 25 11:44:12 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 25 Nov 2022 11:44:12 GMT Subject: [jdk17u-dev] RFR: 8296904: Improve handling of macos xcode toolchain In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 06:28:49 GMT, Christoph Langer wrote: > I had to adapt the configure changes for the new option to the level of code in jdk17u. > > Furthermore, I regenerated docs/building.html which brings it in sync with building.md and removes a change that should not have been made when backporting [JDK-8280863](https://bugs.openjdk.org/browse/JDK-8280863). Marked as reviewed by mbaesken (Reviewer). Okay thanks for the explanation. Backporting [JDK-8287254](https://bugs.openjdk.org/browse/JDK-8287254) is a bit too much for now (maybe later?). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/931 From gdams at openjdk.org Fri Nov 25 11:45:59 2022 From: gdams at openjdk.org (George Adams) Date: Fri, 25 Nov 2022 11:45:59 GMT Subject: [jdk11u-dev] Integrated: 8268860: Windows-Aarch64 build is failing in GitHub actions In-Reply-To: References: Message-ID: On Mon, 21 Nov 2022 13:08:08 GMT, George Adams wrote: > Applies cleanly except for the change added in https://github.com/openjdk/jdk11u-dev/commit/5d28a71c1f1b734a4d8f05363aa61c2b5b6df687 This pull request has now been integrated. Changeset: bc704dae Author: George Adams URL: https://git.openjdk.org/jdk11u-dev/commit/bc704daea58dfe4c133ae67a739808557d0278d2 Stats: 104 lines in 1 file changed: 103 ins; 0 del; 1 mod 8268860: Windows-Aarch64 build is failing in GitHub actions Reviewed-by: clanger Backport-of: acc3d995355b646c581623b0df5facbcdbfa4721 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1538 From gdams at openjdk.org Fri Nov 25 12:17:42 2022 From: gdams at openjdk.org (George Adams) Date: Fri, 25 Nov 2022 12:17:42 GMT Subject: [jdk11u-dev] RFR: 8280863: Update build README to reflect that MSYS2 is supported [v2] In-Reply-To: <6OpiVqxxY5n5adaQdYzRfBSpkq79devpMvcrxqN5qpU=.28e1a462-6795-45a7-98bb-86e5ed1db8cc@github.com> References: <6OpiVqxxY5n5adaQdYzRfBSpkq79devpMvcrxqN5qpU=.28e1a462-6795-45a7-98bb-86e5ed1db8cc@github.com> Message-ID: > The only diffs are the supported VS versions and the fact that for JDK11u we state that versions older than VS 2017 are likely to be unsupported at some point. George Adams has updated the pull request incrementally with one additional commit since the last revision: revert ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1552/files - new: https://git.openjdk.org/jdk11u-dev/pull/1552/files/ee9e6d25..21f97ea3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1552&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1552&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1552.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1552/head:pull/1552 PR: https://git.openjdk.org/jdk11u-dev/pull/1552 From clanger at openjdk.org Fri Nov 25 12:17:43 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 25 Nov 2022 12:17:43 GMT Subject: [jdk11u-dev] RFR: 8280863: Update build README to reflect that MSYS2 is supported [v2] In-Reply-To: References: <6OpiVqxxY5n5adaQdYzRfBSpkq79devpMvcrxqN5qpU=.28e1a462-6795-45a7-98bb-86e5ed1db8cc@github.com> Message-ID: On Fri, 25 Nov 2022 12:12:28 GMT, George Adams wrote: >> The only diffs are the supported VS versions and the fact that for JDK11u we state that versions older than VS 2017 are likely to be unsupported at some point. > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > revert Looks good now. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1552 From gdams at openjdk.org Fri Nov 25 12:19:09 2022 From: gdams at openjdk.org (George Adams) Date: Fri, 25 Nov 2022 12:19:09 GMT Subject: [jdk11u-dev] RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests Message-ID: The final piece of the puzzle here, backports the GitHub actions rewrite. Also backported JDK-8288499 as it is required for this to be complete. Clean other than the fact that JDK-8295714 was applied before so had to be rewritten and macOS-10.15 is now deprecated so had to switch to 11 (which had happened already in the old workflow layout. ------------- Commit messages: - macOS bump to 11 - Backport 3df72a359e402b929b210f88ed85a86f9f10231f - Backport bebb61224b163a70d79392e41ede4e61dbb04288 - Backport 881ff368ceaff83ae78b1a17896c1ee45524bc84 Changes: https://git.openjdk.org/jdk11u-dev/pull/1554/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1554&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287906 Stats: 3993 lines in 20 files changed: 1912 ins; 2081 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1554.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1554/head:pull/1554 PR: https://git.openjdk.org/jdk11u-dev/pull/1554 From gdams at openjdk.org Fri Nov 25 12:23:45 2022 From: gdams at openjdk.org (George Adams) Date: Fri, 25 Nov 2022 12:23:45 GMT Subject: [jdk11u-dev] RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v2] In-Reply-To: References: Message-ID: > The final piece of the puzzle here, backports the GitHub actions rewrite. Also backported JDK-8288499 as it is required for this to be complete. > > Clean other than the fact that JDK-8295714 was applied before so had to be rewritten and macOS-10.15 is now deprecated so had to switch to 11 (which had happened already in the old workflow layout. George Adams has updated the pull request incrementally with one additional commit since the last revision: remove GTEST code blocks ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1554/files - new: https://git.openjdk.org/jdk11u-dev/pull/1554/files/47b56d44..f224c9db Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1554&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1554&range=00-01 Stats: 69 lines in 4 files changed: 0 ins; 69 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1554.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1554/head:pull/1554 PR: https://git.openjdk.org/jdk11u-dev/pull/1554 From sgehwolf at openjdk.org Fri Nov 25 12:48:21 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 12:48:21 GMT Subject: [jdk17u-dev] RFR: 8296958: [JVMCI] add API for retrieving ConstantValue attributes In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 10:23:45 GMT, Severin Gehwolf wrote: > Backport not clean due to JDK-8289094 not present in 17u which isn't needed. > Adapted patch to the older API instead. Omitted hunk in `vmStructs_jvmci.cpp` > as that pertains to the virtual threads, not available in 17. > > This backport is needed in order to be able to build future GraalVM based on JDK 17. > > Testing: jvmci tests (including changed `TestResolvedJavaField` test), passes. @adinn Can you please help review this patch? Thanks! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/932 From adinn at openjdk.org Fri Nov 25 14:42:16 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Fri, 25 Nov 2022 14:42:16 GMT Subject: [jdk17u-dev] RFR: 8296958: [JVMCI] add API for retrieving ConstantValue attributes In-Reply-To: References: Message-ID: <5w3TRs0lpQbEGlet4uRpvuef1uHabeHfptQq24bf268=.9ad1450a-15c3-4250-bd8e-7cee23a4b086@github.com> On Fri, 25 Nov 2022 10:23:45 GMT, Severin Gehwolf wrote: > Backport not clean due to JDK-8289094 not present in 17u which isn't needed. > Adapted patch to the older API instead. Omitted hunk in `vmStructs_jvmci.cpp` > as that pertains to the virtual threads, not available in 17. > > This backport is needed in order to be able to build future GraalVM based on JDK 17. > > Testing: jvmci tests (including changed `TestResolvedJavaField` test), passes. Backport looks good. ------------- Marked as reviewed by adinn (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/932 From adinn at openjdk.org Fri Nov 25 14:42:30 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Fri, 25 Nov 2022 14:42:30 GMT Subject: [jdk17u-dev] RFR: 8296956: [JVMCI] HotSpotResolvedJavaFieldImpl.getIndex returns wrong value In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 10:50:02 GMT, Severin Gehwolf wrote: > Clean backport. Fix applicable to 17u too. JVMCI only change. > > Testing: jvmci tests (including new test). Passed. Looks just as good as the patch to 17u-dev :-) ------------- Marked as reviewed by adinn (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/933 From sgehwolf at openjdk.org Fri Nov 25 14:51:22 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 14:51:22 GMT Subject: [jdk17u-dev] RFR: 8296958: [JVMCI] add API for retrieving ConstantValue attributes In-Reply-To: <5w3TRs0lpQbEGlet4uRpvuef1uHabeHfptQq24bf268=.9ad1450a-15c3-4250-bd8e-7cee23a4b086@github.com> References: <5w3TRs0lpQbEGlet4uRpvuef1uHabeHfptQq24bf268=.9ad1450a-15c3-4250-bd8e-7cee23a4b086@github.com> Message-ID: On Fri, 25 Nov 2022 14:38:36 GMT, Andrew Dinn wrote: > Backport looks good. Thanks for the review! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/932 From sgehwolf at openjdk.org Fri Nov 25 14:52:30 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 14:52:30 GMT Subject: [jdk17u-dev] RFR: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod Message-ID: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> Not clean. Copyright in `HotSpotResolvedJavaMethodImpl.java`. `getCodeSizeTest` in `TestResolvedJavaMethod.java` fixed up manually, as well as omitted `equalsTest` changes as that test is not in 17u (because both, JDK-8289687 and JDK-8289094 are not in 17u). HotSpotResolvedJavaFieldTest.java will need a follow-up, JDK-8297590, in order to fix the test and let it run. I'll get that backported to 17u once it's in JDK tip. This pr depends on #933 as that PR changes the signature of the `createField` static method in `HotSpotResolvedObjectTypeImpl` (which the test fix of JDK-8297590 corrects). Testing: jvmci tests (with backport of JDK-8297590 applied). Existing and newly included tests pass. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/933 Commit messages: - 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod Changes: https://git.openjdk.org/jdk17u-dev/pull/934/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=934&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296967 Stats: 309 lines in 8 files changed: 231 ins; 38 del; 40 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/934.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/934/head:pull/934 PR: https://git.openjdk.org/jdk17u-dev/pull/934 From sgehwolf at openjdk.org Fri Nov 25 14:59:35 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 14:59:35 GMT Subject: [jdk17u-dev] RFR: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod In-Reply-To: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> References: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> Message-ID: On Fri, 25 Nov 2022 14:46:01 GMT, Severin Gehwolf wrote: > Not clean. Copyright in `HotSpotResolvedJavaMethodImpl.java`. `getCodeSizeTest` in > `TestResolvedJavaMethod.java` fixed up manually, as well as omitted `equalsTest` changes > as that test is not in 17u (because both, JDK-8289687 and JDK-8289094 are not in 17u). > > HotSpotResolvedJavaFieldTest.java will need a follow-up, JDK-8297590, in order to fix the test > and let it run. I'll get that backported to 17u once it's in JDK tip. > > This pr depends on #933 as that PR changes the signature of the `createField` static method in > `HotSpotResolvedObjectTypeImpl` (which the test fix of JDK-8297590 corrects). > > Testing: jvmci tests (with backport of JDK-8297590 applied). Existing and newly included tests pass. @adinn Could you help with a review of this patch too, please? Thank you! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/934 From adinn at openjdk.org Fri Nov 25 15:20:15 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Fri, 25 Nov 2022 15:20:15 GMT Subject: [jdk17u-dev] RFR: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod In-Reply-To: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> References: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> Message-ID: On Fri, 25 Nov 2022 14:46:01 GMT, Severin Gehwolf wrote: > Not clean. Copyright in `HotSpotResolvedJavaMethodImpl.java`. `getCodeSizeTest` in > `TestResolvedJavaMethod.java` fixed up manually, as well as omitted `equalsTest` changes > as that test is not in 17u (because both, JDK-8289687 and JDK-8289094 are not in 17u). > > HotSpotResolvedJavaFieldTest.java will need a follow-up, JDK-8297590, in order to fix the test > and let it run. I'll get that backported to 17u once it's in JDK tip. > > This pr depends on #933 as that PR changes the signature of the `createField` static method in > `HotSpotResolvedObjectTypeImpl` (which the test fix of JDK-8297590 corrects). > > Testing: jvmci tests (with backport of JDK-8297590 applied). Existing and newly included tests pass. This also looks good. I agree that dropping equalsTest is correct for this backport. However, if at some point we decide we need to backport JDK-8296967 we will have to try to remember also to reinsert equalsTest. ------------- Marked as reviewed by adinn (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/934 From sgehwolf at openjdk.org Fri Nov 25 15:36:31 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 15:36:31 GMT Subject: [jdk17u-dev] RFR: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod In-Reply-To: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> References: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> Message-ID: On Fri, 25 Nov 2022 14:46:01 GMT, Severin Gehwolf wrote: > Not clean. Copyright in `HotSpotResolvedJavaMethodImpl.java`. `getCodeSizeTest` in > `TestResolvedJavaMethod.java` fixed up manually, as well as omitted `equalsTest` changes > as that test is not in 17u (because both, JDK-8289687 and JDK-8289094 are not in 17u). > > HotSpotResolvedJavaFieldTest.java will need a follow-up, JDK-8297590, in order to fix the test > and let it run. I'll get that backported to 17u once it's in JDK tip. > > This pr depends on #933 as that PR changes the signature of the `createField` static method in > `HotSpotResolvedObjectTypeImpl` (which the test fix of JDK-8297590 corrects). > > Testing: jvmci tests (with backport of JDK-8297590 applied). Existing and newly included tests pass. Thanks for the review! ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/934 From duke at openjdk.org Fri Nov 25 16:06:11 2022 From: duke at openjdk.org (zzambers) Date: Fri, 25 Nov 2022 16:06:11 GMT Subject: [jdk11u-dev] Integrated: 8295952: Problemlist existing compiler/rtm tests also on x86 In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 23:58:43 GMT, zzambers wrote: > Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected. This pull request has now been integrated. Changeset: 178b4002 Author: Zdenek Zambersky Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/178b400267b39ecf105ef2386d843db32ffdf2db Stats: 11 lines in 1 file changed: 0 ins; 0 del; 11 mod 8295952: Problemlist existing compiler/rtm tests also on x86 Backport-of: 3f2f128af6ec2f9097af7758bfd41aeaa4354d40 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1547 From sgehwolf at openjdk.org Fri Nov 25 16:27:53 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 16:27:53 GMT Subject: [jdk17u-dev] Integrated: 8296956: [JVMCI] HotSpotResolvedJavaFieldImpl.getIndex returns wrong value In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 10:50:02 GMT, Severin Gehwolf wrote: > Clean backport. Fix applicable to 17u too. JVMCI only change. > > Testing: jvmci tests (including new test). Passed. This pull request has now been integrated. Changeset: 94859b91 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/94859b91041ab79d2d0610c52a403f1a4a016b4e Stats: 180 lines in 7 files changed: 137 ins; 5 del; 38 mod 8296956: [JVMCI] HotSpotResolvedJavaFieldImpl.getIndex returns wrong value Reviewed-by: adinn Backport-of: 95c390ec75eec31cdf613c8bb236e43aa65a1bb5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/933 From sgehwolf at openjdk.org Fri Nov 25 16:30:30 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 16:30:30 GMT Subject: [jdk17u-dev] Integrated: 8296958: [JVMCI] add API for retrieving ConstantValue attributes In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 10:23:45 GMT, Severin Gehwolf wrote: > Backport not clean due to JDK-8289094 not present in 17u which isn't needed. > Adapted patch to the older API instead. Omitted hunk in `vmStructs_jvmci.cpp` > as that pertains to the virtual threads, not available in 17. > > This backport is needed in order to be able to build future GraalVM based on JDK 17. > > Testing: jvmci tests (including changed `TestResolvedJavaField` test), passes. This pull request has now been integrated. Changeset: b4a4f6ad Author: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/b4a4f6ad5531e01ac59b3e860e72475ba7b4acf0 Stats: 199 lines in 8 files changed: 193 ins; 5 del; 1 mod 8296958: [JVMCI] add API for retrieving ConstantValue attributes Reviewed-by: adinn Backport-of: 4ce4f384d720ab66ffde898c48d95a58039b0080 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/932 From sgehwolf at openjdk.org Fri Nov 25 16:34:45 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 16:34:45 GMT Subject: [jdk17u-dev] RFR: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod [v2] In-Reply-To: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> References: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> Message-ID: > Not clean. Copyright in `HotSpotResolvedJavaMethodImpl.java`. `getCodeSizeTest` in > `TestResolvedJavaMethod.java` fixed up manually, as well as omitted `equalsTest` changes > as that test is not in 17u (because both, JDK-8289687 and JDK-8289094 are not in 17u). > > HotSpotResolvedJavaFieldTest.java will need a follow-up, JDK-8297590, in order to fix the test > and let it run. I'll get that backported to 17u once it's in JDK tip. > > This pr depends on #933 as that PR changes the signature of the `createField` static method in > `HotSpotResolvedObjectTypeImpl` (which the test fix of JDK-8297590 corrects). > > Testing: jvmci tests (with backport of JDK-8297590 applied). Existing and newly included tests pass. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/934/files - new: https://git.openjdk.org/jdk17u-dev/pull/934/files/271e5457..271e5457 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=934&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=934&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/934.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/934/head:pull/934 PR: https://git.openjdk.org/jdk17u-dev/pull/934 From sgehwolf at openjdk.org Fri Nov 25 16:39:20 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 16:39:20 GMT Subject: [jdk17u-dev] RFR: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod [v3] In-Reply-To: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> References: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> Message-ID: > Not clean. Copyright in `HotSpotResolvedJavaMethodImpl.java`. `getCodeSizeTest` in > `TestResolvedJavaMethod.java` fixed up manually, as well as omitted `equalsTest` changes > as that test is not in 17u (because both, JDK-8289687 and JDK-8289094 are not in 17u). > > HotSpotResolvedJavaFieldTest.java will need a follow-up, JDK-8297590, in order to fix the test > and let it run. I'll get that backported to 17u once it's in JDK tip. > > This pr depends on #933 as that PR changes the signature of the `createField` static method in > `HotSpotResolvedObjectTypeImpl` (which the test fix of JDK-8297590 corrects). > > Testing: jvmci tests (with backport of JDK-8297590 applied). Existing and newly included tests pass. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod Not clean. Copyright in HotSpotResolvedJavaMethodImpl.java. getCodeSizeTest in TestResolvedJavaMethod.java as well as omitted equalsTest changes as that test is not in 17u (JDK-8289687 not in 17u as JDK-8289094 is not in 17u). HotSpotResolvedJavaFieldTest.java will need a follow-up: JDK-8297590 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/934/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=934&range=02 Stats: 309 lines in 8 files changed: 231 ins; 38 del; 40 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/934.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/934/head:pull/934 PR: https://git.openjdk.org/jdk17u-dev/pull/934 From duke at openjdk.org Fri Nov 25 16:44:18 2022 From: duke at openjdk.org (zzambers) Date: Fri, 25 Nov 2022 16:44:18 GMT Subject: [jdk11u-dev] RFR: 8295952: Problemlist existing compiler/rtm tests also on x86 In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 23:58:43 GMT, zzambers wrote: > Problemlist should be extended so that existing compiler/rtm entries include x86 (32-bit) intel builds as well, as these are also affected. @RealCLanger thanks ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1547 From aph at openjdk.org Fri Nov 25 17:10:46 2022 From: aph at openjdk.org (Andrew Haley) Date: Fri, 25 Nov 2022 17:10:46 GMT Subject: [jdk17u-dev] RFR: 8297656: AArch64: Enable AES/GCM Intrinsics Message-ID: <0gnkZkHlqtgtTXmHq9ZP9HvpRvuGtqt6Q5miqNo--10=.411dca64-c74e-4106-8ee2-a1354c866fab@github.com> These have been in maimline for more than a year. Time to enable them. ------------- Commit messages: - 8297656: AArch64: Enable AES/GCM Intrinsics Changes: https://git.openjdk.org/jdk17u-dev/pull/935/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=935&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297656 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/935.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/935/head:pull/935 PR: https://git.openjdk.org/jdk17u-dev/pull/935 From sgehwolf at openjdk.org Fri Nov 25 17:31:03 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 17:31:03 GMT Subject: [jdk17u-dev] Integrated: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod In-Reply-To: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> References: <4huXw8KIwGAP3FThSdeguAw2G93_30c6ZZlKU6rbxBs=.7908faf4-e21c-4cd5-a838-b02beb48bb98@github.com> Message-ID: On Fri, 25 Nov 2022 14:46:01 GMT, Severin Gehwolf wrote: > Not clean. Copyright in `HotSpotResolvedJavaMethodImpl.java`. `getCodeSizeTest` in > `TestResolvedJavaMethod.java` fixed up manually, as well as omitted `equalsTest` changes > as that test is not in 17u (because both, JDK-8289687 and JDK-8289094 are not in 17u). > > HotSpotResolvedJavaFieldTest.java will need a follow-up, JDK-8297590, in order to fix the test > and let it run. I'll get that backported to 17u once it's in JDK tip. > > This pr depends on #933 as that PR changes the signature of the `createField` static method in > `HotSpotResolvedObjectTypeImpl` (which the test fix of JDK-8297590 corrects). > > Testing: jvmci tests (with backport of JDK-8297590 applied). Existing and newly included tests pass. This pull request has now been integrated. Changeset: b464cc2d Author: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/b464cc2d92a5db7c4dfbab4ac1e6d52908b29028 Stats: 309 lines in 8 files changed: 231 ins; 38 del; 40 mod 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod Reviewed-by: adinn Backport-of: 37848a9ca2ab3021e7b3b2e112bab4631fbe1d99 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/934 From sgehwolf at openjdk.org Fri Nov 25 17:31:12 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 17:31:12 GMT Subject: [jdk11u-dev] RFR: 8297257: Bump update version for OpenJDK: jdk-11.0.19 In-Reply-To: References: Message-ID: On Sun, 20 Nov 2022 20:11:44 GMT, Goetz Lindenmaier wrote: > The necessary version bump. To be pushed after tag jdk-11.0.19+0. Marked as reviewed by sgehwolf (Reviewer). ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1536 From aph at openjdk.org Fri Nov 25 17:54:01 2022 From: aph at openjdk.org (Andrew Haley) Date: Fri, 25 Nov 2022 17:54:01 GMT Subject: [jdk11u-dev] RFR: 8297656: AArch64: Enable AES/GCM Intrinsics Message-ID: <0IQkbwRsfchhuggkEkvMIFIPf5HkAcEZYKbX0v6S2as=.c47922df-f953-4cbb-9986-7bc55c3e06f0@github.com> These have been in mainline for more than a year. Time to enable them. ------------- Commit messages: - 8297656: AArch64: Enable AES/GCM Intrinsics Changes: https://git.openjdk.org/jdk11u-dev/pull/1555/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1555&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297656 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1555.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1555/head:pull/1555 PR: https://git.openjdk.org/jdk11u-dev/pull/1555 From sgehwolf at openjdk.org Fri Nov 25 17:55:22 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 25 Nov 2022 17:55:22 GMT Subject: [jdk17u-dev] RFR: 8297590: [TESTBUG] HotSpotResolvedJavaFieldTest does not run Message-ID: Clean backport. Test fix so that it actually runs a recently added test when running jvmci tests. ------------- Commit messages: - 8297590: [TESTBUG] HotSpotResolvedJavaFieldTest does not run Changes: https://git.openjdk.org/jdk17u-dev/pull/936/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=936&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297590 Stats: 10 lines in 1 file changed: 8 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/936.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/936/head:pull/936 PR: https://git.openjdk.org/jdk17u-dev/pull/936 From gdams at openjdk.org Fri Nov 25 18:43:49 2022 From: gdams at openjdk.org (George Adams) Date: Fri, 25 Nov 2022 18:43:49 GMT Subject: [jdk11u-dev] Integrated: 8280863: Update build README to reflect that MSYS2 is supported In-Reply-To: <6OpiVqxxY5n5adaQdYzRfBSpkq79devpMvcrxqN5qpU=.28e1a462-6795-45a7-98bb-86e5ed1db8cc@github.com> References: <6OpiVqxxY5n5adaQdYzRfBSpkq79devpMvcrxqN5qpU=.28e1a462-6795-45a7-98bb-86e5ed1db8cc@github.com> Message-ID: On Fri, 25 Nov 2022 09:16:38 GMT, George Adams wrote: > The only diffs are the supported VS versions and the fact that for JDK11u we state that versions older than VS 2017 are likely to be unsupported at some point. This pull request has now been integrated. Changeset: b5555c19 Author: George Adams URL: https://git.openjdk.org/jdk11u-dev/commit/b5555c191537c27e6b7dcf7ac15c4dfe2967688e Stats: 5 lines in 2 files changed: 0 ins; 1 del; 4 mod 8280863: Update build README to reflect that MSYS2 is supported Reviewed-by: clanger Backport-of: 204e67a7adedc5ff8ed6dbe1da7aa1397c9beb38 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1552 From fjiang at openjdk.org Sat Nov 26 03:04:27 2022 From: fjiang at openjdk.org (Feilong Jiang) Date: Sat, 26 Nov 2022 03:04:27 GMT Subject: [jdk19u] RFR: 8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 06:12:37 GMT, Feilong Jiang wrote: > Please review this backport to jdk19u. > Backport of [JDK-8297476](https://bugs.openjdk.org/browse/JDK-8297476). Applies cleanly. Approval is pending. Got fix-request-yes, integrate then. ------------- PR: https://git.openjdk.org/jdk19u/pull/94 From fjiang at openjdk.org Sat Nov 26 08:10:07 2022 From: fjiang at openjdk.org (Feilong Jiang) Date: Sat, 26 Nov 2022 08:10:07 GMT Subject: [jdk19u] Integrated: 8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 06:12:37 GMT, Feilong Jiang wrote: > Please review this backport to jdk19u. > Backport of [JDK-8297476](https://bugs.openjdk.org/browse/JDK-8297476). Applies cleanly. Approval is pending. This pull request has now been integrated. Changeset: 94de334f Author: Feilong Jiang Committer: Vladimir Kempik URL: https://git.openjdk.org/jdk19u/commit/94de334f8ce3bf2ab55ccddde0983eee69288102 Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod 8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V Backport-of: 5e196b4b8e623107424e2fb54672790fd925fe73 ------------- PR: https://git.openjdk.org/jdk19u/pull/94 From adinn at openjdk.org Sat Nov 26 11:52:00 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Sat, 26 Nov 2022 11:52:00 GMT Subject: [jdk17u-dev] RFR: 8297656: AArch64: Enable AES/GCM Intrinsics In-Reply-To: <0gnkZkHlqtgtTXmHq9ZP9HvpRvuGtqt6Q5miqNo--10=.411dca64-c74e-4106-8ee2-a1354c866fab@github.com> References: <0gnkZkHlqtgtTXmHq9ZP9HvpRvuGtqt6Q5miqNo--10=.411dca64-c74e-4106-8ee2-a1354c866fab@github.com> Message-ID: On Fri, 25 Nov 2022 17:04:42 GMT, Andrew Haley wrote: > These have been in mainline for more than a year. Time to enable them. Reviewed ------------- Marked as reviewed by adinn (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/935 From adinn at openjdk.org Sat Nov 26 11:53:24 2022 From: adinn at openjdk.org (Andrew Dinn) Date: Sat, 26 Nov 2022 11:53:24 GMT Subject: [jdk11u-dev] RFR: 8297656: AArch64: Enable AES/GCM Intrinsics In-Reply-To: <0IQkbwRsfchhuggkEkvMIFIPf5HkAcEZYKbX0v6S2as=.c47922df-f953-4cbb-9986-7bc55c3e06f0@github.com> References: <0IQkbwRsfchhuggkEkvMIFIPf5HkAcEZYKbX0v6S2as=.c47922df-f953-4cbb-9986-7bc55c3e06f0@github.com> Message-ID: On Fri, 25 Nov 2022 17:49:03 GMT, Andrew Haley wrote: > These have been in mainline for more than a year. Time to enable them. Reviewed ------------- Marked as reviewed by adinn (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1555 From fjiang at openjdk.org Sat Nov 26 14:22:27 2022 From: fjiang at openjdk.org (Feilong Jiang) Date: Sat, 26 Nov 2022 14:22:27 GMT Subject: [jdk19u] RFR: 8290164: compiler/runtime/TestConstantsInError.java fails on riscv Message-ID: Please review this backport to jdk19u. Backport of [JDK-8290164](https://bugs.openjdk.org/browse/JDK-8290164). Applies cleanly. Approval is pending. ------------- Commit messages: - Backport 3471ac9a907780d894d05bd58cf883c4c8d8838d Changes: https://git.openjdk.org/jdk19u/pull/95/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=95&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290164 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk19u/pull/95.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/95/head:pull/95 PR: https://git.openjdk.org/jdk19u/pull/95 From chegar at openjdk.org Sun Nov 27 09:17:17 2022 From: chegar at openjdk.org (Chris Hegarty) Date: Sun, 27 Nov 2022 09:17:17 GMT Subject: [jdk19u] RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread Message-ID: Hi all, This pull request contains a backport of commit [50f9043c](https://github.com/openjdk/jdk/commit/50f9043c6965360c426b187e47c49c42481a2549) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Ryan Ernst on 26 Nov 2022 and was reviewed by Chris Hegarty and Alan Bateman. Thanks! ------------- Commit messages: - Backport 50f9043c6965360c426b187e47c49c42481a2549 Changes: https://git.openjdk.org/jdk19u/pull/96/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=96&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297451 Stats: 36 lines in 2 files changed: 29 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk19u/pull/96.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/96/head:pull/96 PR: https://git.openjdk.org/jdk19u/pull/96 From lzhai at openjdk.org Mon Nov 28 00:31:32 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Mon, 28 Nov 2022 00:31:32 GMT Subject: [jdk17u-dev] RFR: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx In-Reply-To: References: <_le7M-l9Gx61vz8OWeqQQaewtX7fKwHTA9eatOobrE4=.d19d636f-db64-405c-8f34-b6f5fce4eeb7@github.com> <_BQuLfRor1e3eINJL0wGMuTX746FEcjcj0V5Q_G2Qdg=.f92f7f49-b45c-454a-8f6c-cda187d23534@github.com> Message-ID: On Fri, 25 Nov 2022 11:39:02 GMT, Christoph Langer wrote: >> Hi @kevinrushforth >> >>> changing the title of this PR to Backport using the 40 char hash of the original commit in the jdk mainline repo. >> >> Thanks for your hint! >> >> Leslie Zhai > > @xiangzhai, could you please enable Github Actions on your repository and trigger a GHA run? Hi @RealCLanger Sorry for late response! [Triggered](https://github.com/xiangzhai/jdk17u-dev/actions/runs/3560666191). Thanks, Leslie Zhai ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/922 From dholmes at openjdk.org Mon Nov 28 06:23:52 2022 From: dholmes at openjdk.org (David Holmes) Date: Mon, 28 Nov 2022 06:23:52 GMT Subject: [jdk19u] RFR: 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads Message-ID: Backport of https://github.com/openjdk/jdk/commit/7b3984cb5a08edb99a233c28331c00b25457d664 It didn't apply cleanly because of the code being factored out of `thread.cpp` into `javaThread.cpp` in JDK 20. Thanks. ------------- Commit messages: - Backport 7b3984cb5a08edb99a233c28331c00b25457d664 Changes: https://git.openjdk.org/jdk19u/pull/97/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=97&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296463 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/97.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/97/head:pull/97 PR: https://git.openjdk.org/jdk19u/pull/97 From thartmann at openjdk.org Mon Nov 28 06:27:33 2022 From: thartmann at openjdk.org (Tobias Hartmann) Date: Mon, 28 Nov 2022 06:27:33 GMT Subject: [jdk19u] RFR: 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads In-Reply-To: References: Message-ID: On Mon, 28 Nov 2022 06:16:21 GMT, David Holmes wrote: > Backport of https://github.com/openjdk/jdk/commit/7b3984cb5a08edb99a233c28331c00b25457d664 > > It didn't apply cleanly because of the code being factored out of `thread.cpp` into `javaThread.cpp` in JDK 20. > > Thanks. Looks good. ------------- Marked as reviewed by thartmann (Reviewer). PR: https://git.openjdk.org/jdk19u/pull/97 From dholmes at openjdk.org Mon Nov 28 06:33:25 2022 From: dholmes at openjdk.org (David Holmes) Date: Mon, 28 Nov 2022 06:33:25 GMT Subject: [jdk19u] RFR: 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads In-Reply-To: References: Message-ID: On Mon, 28 Nov 2022 06:25:15 GMT, Tobias Hartmann wrote: >> Backport of https://github.com/openjdk/jdk/commit/7b3984cb5a08edb99a233c28331c00b25457d664 >> >> It didn't apply cleanly because of the code being factored out of `thread.cpp` into `javaThread.cpp` in JDK 20. >> >> Thanks. > > Looks good. Thanks @TobiHartmann ! ------------- PR: https://git.openjdk.org/jdk19u/pull/97 From dholmes at openjdk.org Mon Nov 28 07:25:08 2022 From: dholmes at openjdk.org (David Holmes) Date: Mon, 28 Nov 2022 07:25:08 GMT Subject: [jdk19u] Integrated: 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads In-Reply-To: References: Message-ID: On Mon, 28 Nov 2022 06:16:21 GMT, David Holmes wrote: > Backport of https://github.com/openjdk/jdk/commit/7b3984cb5a08edb99a233c28331c00b25457d664 > > It didn't apply cleanly because of the code being factored out of `thread.cpp` into `javaThread.cpp` in JDK 20. > > Thanks. This pull request has now been integrated. Changeset: 0959a653 Author: David Holmes URL: https://git.openjdk.org/jdk19u/commit/0959a6538ae7707ae47b134dadea007c60221854 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads Reviewed-by: thartmann Backport-of: 7b3984cb5a08edb99a233c28331c00b25457d664 ------------- PR: https://git.openjdk.org/jdk19u/pull/97 From gdams at openjdk.org Mon Nov 28 09:40:02 2022 From: gdams at openjdk.org (George Adams) Date: Mon, 28 Nov 2022 09:40:02 GMT Subject: [jdk11u-dev] RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v3] In-Reply-To: References: Message-ID: > The final piece of the puzzle here, backports the GitHub actions rewrite. Also backported JDK-8288499 as it is required for this to be complete. > > Clean other than the fact that JDK-8295714 was applied before so had to be rewritten and macOS-10.15 is now deprecated so had to switch to 11 (which had happened already in the old workflow layout. George Adams has updated the pull request incrementally with one additional commit since the last revision: fixup build/test failures ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1554/files - new: https://git.openjdk.org/jdk11u-dev/pull/1554/files/f224c9db..201d839f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1554&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1554&range=01-02 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1554.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1554/head:pull/1554 PR: https://git.openjdk.org/jdk11u-dev/pull/1554 From lzhai at openjdk.org Mon Nov 28 10:40:12 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Mon, 28 Nov 2022 10:40:12 GMT Subject: [jdk17u-dev] Integrated: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx In-Reply-To: <_le7M-l9Gx61vz8OWeqQQaewtX7fKwHTA9eatOobrE4=.d19d636f-db64-405c-8f34-b6f5fce4eeb7@github.com> References: <_le7M-l9Gx61vz8OWeqQQaewtX7fKwHTA9eatOobrE4=.d19d636f-db64-405c-8f34-b6f5fce4eeb7@github.com> Message-ID: On Wed, 23 Nov 2022 02:52:00 GMT, Leslie Zhai wrote: > Hi, > > I request the backport for jdk17u-dev. The patch applies clean. This backport is only a test change, no risk and fixes the test failure. > > Thanks, > Leslie Zhai This pull request has now been integrated. Changeset: ae1b055c Author: Leslie Zhai Committer: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/ae1b055c31e11dd1383967990c6c8068f8e9e2ea Stats: 9 lines in 1 file changed: 4 ins; 1 del; 4 mod 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx Backport-of: dfb9c0663370fc8335caf06ca6f0cb4dac95ce2d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/922 From serb at openjdk.org Mon Nov 28 11:03:07 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 28 Nov 2022 11:03:07 GMT Subject: [jdk11u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Message-ID: Hi all, This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. Thanks! ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1551 Commit messages: - Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8 Changes: https://git.openjdk.org/jdk11u-dev/pull/1556/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1556&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296957 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1556.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1556/head:pull/1556 PR: https://git.openjdk.org/jdk11u-dev/pull/1556 From serb at openjdk.org Mon Nov 28 11:04:28 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 28 Nov 2022 11:04:28 GMT Subject: [jdk13u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Message-ID: Hi all, This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. Thanks! ------------- Depends on: https://git.openjdk.org/jdk13u-dev/pull/432 Commit messages: - Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8 Changes: https://git.openjdk.org/jdk13u-dev/pull/434/files Webrev: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=434&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296957 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/434.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/434/head:pull/434 PR: https://git.openjdk.org/jdk13u-dev/pull/434 From serb at openjdk.org Mon Nov 28 11:05:52 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 28 Nov 2022 11:05:52 GMT Subject: [jdk17u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Message-ID: Hi all, This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. Thanks! ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/928 Commit messages: - Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8 Changes: https://git.openjdk.org/jdk17u-dev/pull/937/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=937&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296957 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/937.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/937/head:pull/937 PR: https://git.openjdk.org/jdk17u-dev/pull/937 From serb at openjdk.org Mon Nov 28 11:06:28 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 28 Nov 2022 11:06:28 GMT Subject: [jdk15u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 Message-ID: Hi all, This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. Thanks! ------------- Depends on: https://git.openjdk.org/jdk15u-dev/pull/306 Commit messages: - Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8 Changes: https://git.openjdk.org/jdk15u-dev/pull/308/files Webrev: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=308&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296957 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/308.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/308/head:pull/308 PR: https://git.openjdk.org/jdk15u-dev/pull/308 From shade at openjdk.org Mon Nov 28 12:33:11 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 28 Nov 2022 12:33:11 GMT Subject: [jdk17u-dev] RFR: 8297309: Memory leak in ShenandoahFullGC Message-ID: Clean backport to fix a trivial memory leak in Shenandoah. Additional testing: - [x] Linux x86_64 fastdebug, `hotspot_gc_shenandoah` ------------- Commit messages: - Backport b80f5af6981440aec14f4dedbc5ee46364d0254c Changes: https://git.openjdk.org/jdk17u-dev/pull/938/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=938&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297309 Stats: 5 lines in 2 files changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/938.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/938/head:pull/938 PR: https://git.openjdk.org/jdk17u-dev/pull/938 From sgehwolf at openjdk.org Mon Nov 28 12:57:54 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 28 Nov 2022 12:57:54 GMT Subject: [jdk17u-dev] Integrated: 8297590: [TESTBUG] HotSpotResolvedJavaFieldTest does not run In-Reply-To: References: Message-ID: On Fri, 25 Nov 2022 17:47:58 GMT, Severin Gehwolf wrote: > Clean backport. Test fix so that it actually runs a recently added test when running jvmci tests. This pull request has now been integrated. Changeset: 9336fb2f Author: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/9336fb2f73fb4365258b7921314b7ae5a47c0733 Stats: 10 lines in 1 file changed: 8 ins; 0 del; 2 mod 8297590: [TESTBUG] HotSpotResolvedJavaFieldTest does not run Backport-of: 08e6a820bcb70e74a0faa28198493292e2993901 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/936 From chegar at openjdk.org Mon Nov 28 13:05:37 2022 From: chegar at openjdk.org (Chris Hegarty) Date: Mon, 28 Nov 2022 13:05:37 GMT Subject: [jdk19u] RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread In-Reply-To: References: Message-ID: On Sun, 27 Nov 2022 09:09:19 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit [50f9043c](https://github.com/openjdk/jdk/commit/50f9043c6965360c426b187e47c49c42481a2549) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ryan Ernst on 26 Nov 2022 and was reviewed by Chris Hegarty and Alan Bateman. > > Thanks! Fix request approved - integrating ------------- PR: https://git.openjdk.org/jdk19u/pull/96 From chegar at openjdk.org Mon Nov 28 13:05:39 2022 From: chegar at openjdk.org (Chris Hegarty) Date: Mon, 28 Nov 2022 13:05:39 GMT Subject: [jdk19u] Integrated: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread In-Reply-To: References: Message-ID: <0hyF4IAEKG6AzQD5qfbf3cXa7Qu52o2HNOeWfnJgu_o=.8a6c23da-ce0b-4185-af00-dfb7e53f0987@github.com> On Sun, 27 Nov 2022 09:09:19 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit [50f9043c](https://github.com/openjdk/jdk/commit/50f9043c6965360c426b187e47c49c42481a2549) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ryan Ernst on 26 Nov 2022 and was reviewed by Chris Hegarty and Alan Bateman. > > Thanks! This pull request has now been integrated. Changeset: 998a6f51 Author: Chris Hegarty URL: https://git.openjdk.org/jdk19u/commit/998a6f51c27586857d5dac5c2a14e5498b663146 Stats: 36 lines in 2 files changed: 29 ins; 0 del; 7 mod 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread Backport-of: 50f9043c6965360c426b187e47c49c42481a2549 ------------- PR: https://git.openjdk.org/jdk19u/pull/96 From fjiang at openjdk.org Mon Nov 28 13:12:29 2022 From: fjiang at openjdk.org (Feilong Jiang) Date: Mon, 28 Nov 2022 13:12:29 GMT Subject: [jdk19u] RFR: 8290164: compiler/runtime/TestConstantsInError.java fails on riscv In-Reply-To: References: Message-ID: On Sat, 26 Nov 2022 14:14:28 GMT, Feilong Jiang wrote: > Please review this backport to jdk19u. Backport of [JDK-8290164](https://bugs.openjdk.org/browse/JDK-8290164). > Applies cleanly. Approval is pending. > > Testing: > > - compiler/runtime/TestConstantsInError.java passed Got fix-request-yes, then ------------- PR: https://git.openjdk.org/jdk19u/pull/95 From shade at openjdk.org Mon Nov 28 13:14:28 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 28 Nov 2022 13:14:28 GMT Subject: [jdk19u] RFR: 8297309: Memory leak in ShenandoahFullGC Message-ID: <8miV1uts--PxRqFggEZLcqRweWlvCvx3Irq5h3tu-Vo=.56639706-8510-40fa-97c2-d942a051ed37@github.com> Clean backport to fix a trivial memory leak in Shenandoah. Additional testing: - [x] Linux x86_64 fastdebug, hotspot_gc_shenandoah ------------- Commit messages: - Backport b80f5af6981440aec14f4dedbc5ee46364d0254c Changes: https://git.openjdk.org/jdk19u/pull/98/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=98&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297309 Stats: 5 lines in 2 files changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/98.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/98/head:pull/98 PR: https://git.openjdk.org/jdk19u/pull/98 From fjiang at openjdk.org Mon Nov 28 13:18:05 2022 From: fjiang at openjdk.org (Feilong Jiang) Date: Mon, 28 Nov 2022 13:18:05 GMT Subject: [jdk19u] Integrated: 8290164: compiler/runtime/TestConstantsInError.java fails on riscv In-Reply-To: References: Message-ID: On Sat, 26 Nov 2022 14:14:28 GMT, Feilong Jiang wrote: > Please review this backport to jdk19u. Backport of [JDK-8290164](https://bugs.openjdk.org/browse/JDK-8290164). > Applies cleanly. Approval is pending. > > Testing: > > - compiler/runtime/TestConstantsInError.java passed This pull request has now been integrated. Changeset: 7a3b69a9 Author: Feilong Jiang Committer: Fei Yang URL: https://git.openjdk.org/jdk19u/commit/7a3b69a93a27968dc983053c3dc31ff005e9d71d Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8290164: compiler/runtime/TestConstantsInError.java fails on riscv Backport-of: 3471ac9a907780d894d05bd58cf883c4c8d8838d ------------- PR: https://git.openjdk.org/jdk19u/pull/95 From duke at openjdk.org Mon Nov 28 17:51:39 2022 From: duke at openjdk.org (Autumn Capasso) Date: Mon, 28 Nov 2022 17:51:39 GMT Subject: [jdk11u-dev] RFR: 8261350: Create implementation for NSAccessibilityCheckBox protocol peer Message-ID: [JDK-8261350](https://bugs.openjdk.org/browse/JDK-8261350) Mostly clean each backport seems to just be cleaning up the java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m file so it aligns properly. ------------- Commit messages: - 8261350: Create implementation for NSAccessibilityCheckBox protocol peer - 8261351: Create implementation for NSAccessibilityRadioButton protocol - JDK-8261352 create implementation for component peer for all the components who should be ignored in a11y interactions - 8256110: Create implementation for NSAccessibilityStepper protocol Changes: https://git.openjdk.org/jdk11u-dev/pull/1550/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1550&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261350 Stats: 726 lines in 13 files changed: 672 ins; 51 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1550.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1550/head:pull/1550 PR: https://git.openjdk.org/jdk11u-dev/pull/1550 From clanger at openjdk.org Mon Nov 28 17:51:40 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 28 Nov 2022 17:51:40 GMT Subject: [jdk11u-dev] RFR: 8261350: Create implementation for NSAccessibilityCheckBox protocol peer In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 23:36:32 GMT, Autumn Capasso wrote: > [JDK-8261350](https://bugs.openjdk.org/browse/JDK-8261350) Mostly clean each backport seems to just be cleaning up the java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m file so it aligns properly. I think you need to remove the word "of" in the PR title to make the bots correctly recognize the backport. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1550 From duke at openjdk.org Mon Nov 28 17:51:41 2022 From: duke at openjdk.org (Autumn Capasso) Date: Mon, 28 Nov 2022 17:51:41 GMT Subject: [jdk11u-dev] RFR: 8261350: Create implementation for NSAccessibilityCheckBox protocol peer In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 15:15:00 GMT, Christoph Langer wrote: > I think you need to remove the word "of" in the PR title to make the bots correctly recognize the backport. Thank you! ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1550 From btaylor at openjdk.org Mon Nov 28 18:05:28 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 28 Nov 2022 18:05:28 GMT Subject: [jdk17u-dev] RFR: 8285093: Introduce UTIL_ARG_WITH [v3] In-Reply-To: References: Message-ID: > Backporting to make [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) clean. > > This change is independent of #914 but both are required for [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport 94afb366b2ec76669e1aac38dbadc223ccafda3d ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/915/files - new: https://git.openjdk.org/jdk17u-dev/pull/915/files/cf9bd011..b98a4e91 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=915&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=915&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/915.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/915/head:pull/915 PR: https://git.openjdk.org/jdk17u-dev/pull/915 From btaylor at openjdk.org Mon Nov 28 18:10:57 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 28 Nov 2022 18:10:57 GMT Subject: [jdk17u-dev] RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v2] In-Reply-To: References: Message-ID: > Backporting for parity with Oracle JDK 17. Patch is clean after [JDK-8273497](https://bugs.openjdk.org/browse/JDK-8273497) (#914) and [JDK-8285093](https://bugs.openjdk.org/browse/JDK-8285093) (#915). Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/916/files - new: https://git.openjdk.org/jdk17u-dev/pull/916/files/1a816a5d..1a816a5d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=916&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=916&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/916.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/916/head:pull/916 PR: https://git.openjdk.org/jdk17u-dev/pull/916 From phh at openjdk.org Mon Nov 28 22:43:46 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 28 Nov 2022 22:43:46 GMT Subject: [jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML In-Reply-To: References: Message-ID: On Fri, 18 Nov 2022 23:40:29 GMT, Tyler Steele wrote: > See comments in https://github.com/openjdk/jdk11u-dev/pull/1530. > > This backport requires a review. It is not marked clean because it does not change the `@LastModified` dates in several places. In all cases, these dates were newer in the current version of jdk11u-dev. In a similar vein, this change adds to a newer list of bug ids in one place. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1532 From phh at openjdk.org Mon Nov 28 22:47:31 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 28 Nov 2022 22:47:31 GMT Subject: [jdk11u-dev] RFR: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment In-Reply-To: <1ymoeGd5tGOgeP6Kzock4IjWMjkkaHtbAfHMfzfwfb4=.accde646-043b-49af-8b3b-5cdc9556244f@github.com> References: <1ymoeGd5tGOgeP6Kzock4IjWMjkkaHtbAfHMfzfwfb4=.accde646-043b-49af-8b3b-5cdc9556244f@github.com> Message-ID: On Mon, 21 Nov 2022 12:12:35 GMT, Johannes Bechberger wrote: > Backports a fix to ensure that ASGCT does not obtain the mentioned lock. Tested with my profiling tester. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk11u-dev/pull/1537 From phh at openjdk.org Mon Nov 28 22:52:25 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 28 Nov 2022 22:52:25 GMT Subject: [jdk17u-dev] RFR: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets. [v2] In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 16:49:52 GMT, Jatin Bhateja wrote: >> Clean backport of [JDK-8290322](https://bugs.openjdk.org/browse/JDK-8290322), due to merge conflicts original patch could not be applied directly by bot. >> >> Patch enables wide vector byte level permutation for AVX512BW targets and benefits multiple generations of Intel's Xeon servers (SKX, CLX, CPX) prior to Ice lake which provides a direct HW instruction (VPERMB). JIT instruction sequence emitted in this case is specific to Vector.rearrange API, hence the scope of the patch is limited to VectorAPIs which is an incubating module currently. >> >> Vector API jtreg test suite contains multiple tests cases for ByteVector.SPECIES_512 to extensively tests the patch. >> >> Original patch review was done with [PR 9498](https://github.com/openjdk/jdk/pull/9498) > > Jatin Bhateja has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 38a81913d33c856d64b7c26f934026815a482e43 Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/917 From phh at openjdk.org Mon Nov 28 23:29:57 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 28 Nov 2022 23:29:57 GMT Subject: [jdk11u] RFR: 8292434: javadoc generation fails if javadoc contains @see with generics [v2] In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 00:53:43 GMT, Bo Zhang wrote: >> This is a backport of JDK-8177280. > > Bo Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8292434: javadoc generation fails if javadoc contains @see with generics > > This is a backport of JDK-8177280. This is a backport of [JDK-8177280](https://bugs.openjdk.org/browse/JDK-8177280) and thus doesn't require that you file a separate JBS issue: that will be done by the hg-updater bot when the backport is pushed. Please close [JDK-8292434](https://bugs.openjdk.org/browse/JDK-8292434) and change this PR title to "Backport b43f356288315eb56b848e57c0dcfc9c31a640cc", which should cause the github openjdk bot to recognize the PR as a backport. "b43f356288315eb56b848e57c0dcfc9c31a640cc" is the original commit-id from the https://github.com/openjdk/jdk repo. I just noticed that this PR was filed against the jdk11u repo rather than the jdk11u-dev repo. You'll have to close this one and open one against the jdk11u-dev repo. In DocTrees.java, the later copyright date should be 2020, not 2022. @since on getType() should be 15, not 11. In Checker.java, no copyright date update is needed. In JavacTrees.java, the later copyright date should be 2020, not 2022. The new line 733 should not replace the old line 708. In HtmlDocletWriter.java, no copyright date update is needed. In LinkFactoryImpl.java, no copyright date update is needed. In LinkInfoImpl.java, the declaration/definition and use of ALL_CLASSES_FRAME hasn't been removed. In CommentHelper.java, there's modified code that isn't modified in the original commit, which implies there's a predecessor backport to be done before this one. Look at the git log for this file to see what that might be. For more information on how to do backports, see 8u wiki: https://wiki.openjdk.org/display/jdk8u/Main 11u and later wiki: https://wiki.openjdk.org/display/JDKUpdates/JDK11u 11u wiki: https://wiki.openjdk.org/display/JDKUpdates/JDK11u Skara (CLI tools): https://wiki.openjdk.org/display/SKARA Backports: https://wiki.openjdk.org/display/SKARA/Backports ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.org/jdk11u/pull/61 From phh at openjdk.org Mon Nov 28 23:44:35 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 28 Nov 2022 23:44:35 GMT Subject: [jdk11u-dev] RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v3] In-Reply-To: References: Message-ID: <5HBc7hXLTw-SlVxWJjsebXu2yq6oM4RGmLbYzJZwTk8=.dab66397-a951-45e0-b283-51873743b40c@github.com> On Mon, 28 Nov 2022 09:40:02 GMT, George Adams wrote: >> The final piece of the puzzle here, backports the GitHub actions rewrite. Also backported JDK-8288499 as it is required for this to be complete. >> >> Clean other than the fact that JDK-8295714 was applied before so had to be rewritten and macOS-10.15 is now deprecated so had to switch to 11 (which had happened already in the old workflow layout. > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > fixup build/test failures The backport of [JDK-8288499](https://bugs.openjdk.org/browse/JDK-8288499), though trivial, should be done separately. You can make that backport dependent on this one, see https://blog.logrocket.com/using-stacked-pull-requests-in-github/ ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1554 From phh at openjdk.org Mon Nov 28 23:48:00 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 28 Nov 2022 23:48:00 GMT Subject: [jdk17u-dev] RFR: 8285093: Introduce UTIL_ARG_WITH [v3] In-Reply-To: References: Message-ID: On Mon, 28 Nov 2022 18:05:28 GMT, Ben Taylor wrote: >> Backporting to make [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) clean. >> >> This change is independent of #914 but both are required for [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). > > Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 94afb366b2ec76669e1aac38dbadc223ccafda3d Looks good now, but please enable pre-submit testing on your repo, see https://wiki.openjdk.org/display/SKARA/Testing. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/915 From phh at openjdk.org Mon Nov 28 23:50:25 2022 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 28 Nov 2022 23:50:25 GMT Subject: [jdk17u-dev] RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v2] In-Reply-To: References: Message-ID: On Mon, 28 Nov 2022 18:10:57 GMT, Ben Taylor wrote: >> Backporting for parity with Oracle JDK 17. Patch is clean after [JDK-8273497](https://bugs.openjdk.org/browse/JDK-8273497) (#914) and [JDK-8285093](https://bugs.openjdk.org/browse/JDK-8285093) (#915). > > Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Please enable pre-submit testing on your repo, see https://wiki.openjdk.org/display/SKARA/Testing. Please enable pre-submit testing on your repo, see https://wiki.openjdk.org/display/SKARA/Testing. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/916 From sviswanathan at openjdk.org Tue Nov 29 00:06:32 2022 From: sviswanathan at openjdk.org (Sandhya Viswanathan) Date: Tue, 29 Nov 2022 00:06:32 GMT Subject: [jdk17u-dev] RFR: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets. [v2] In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 16:49:52 GMT, Jatin Bhateja wrote: >> Clean backport of [JDK-8290322](https://bugs.openjdk.org/browse/JDK-8290322), due to merge conflicts original patch could not be applied directly by bot. >> >> Patch enables wide vector byte level permutation for AVX512BW targets and benefits multiple generations of Intel's Xeon servers (SKX, CLX, CPX) prior to Ice lake which provides a direct HW instruction (VPERMB). JIT instruction sequence emitted in this case is specific to Vector.rearrange API, hence the scope of the patch is limited to VectorAPIs which is an incubating module currently. >> >> Vector API jtreg test suite contains multiple tests cases for ByteVector.SPECIES_512 to extensively tests the patch. >> >> Original patch review was done with [PR 9498](https://github.com/openjdk/jdk/pull/9498) > > Jatin Bhateja has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 38a81913d33c856d64b7c26f934026815a482e43 src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 3874: > 3872: void C2_MacroAssembler::rearrange_bytes(XMMRegister dst, XMMRegister shuffle, XMMRegister src, XMMRegister xtmp1, > 3873: XMMRegister xtmp2, XMMRegister xtmp3, Register rtmp, KRegister ktmp, > 3874: int vlen_enc) { This is the last method in the file in the original commit (https://github.com/openjdk/jdk/commit/38a81913d33c856d64b7c26f934026815a482e43) as well as jdk mainline tip. src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp line 278: > 276: > 277: void rearrange_bytes(XMMRegister dst, XMMRegister shuffle, XMMRegister src, XMMRegister xtmp1, > 278: XMMRegister xtmp2, XMMRegister xtmp3, Register rtmp, KRegister ktmp, int vlen_enc); There is a blank line between rerrange_bytes and endif in the original commit as well as jdk mainline tip. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/917 From duke at openjdk.org Tue Nov 29 01:02:30 2022 From: duke at openjdk.org (Autumn Capasso) Date: Tue, 29 Nov 2022 01:02:30 GMT Subject: [jdk11u-dev] RFR: 8256126: Create implementation for NSAccessibilityImage protocol peer Message-ID: Clean backport of [JDK-8256126](https://bugs.openjdk.org/browse/JDK-8256126) outside of having to modify the a few lines in one file which has had to be modified for each. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). 5/28 of the series of backports. ------------- Commit messages: - 8256126: Create implementation for NSAccessibilityImage protocol peer - 8261350: Create implementation for NSAccessibilityCheckBox protocol peer - 8261351: Create implementation for NSAccessibilityRadioButton protocol - JDK-8261352 create implementation for component peer for all the components who should be ignored in a11y interactions - 8256110: Create implementation for NSAccessibilityStepper protocol Changes: https://git.openjdk.org/jdk11u-dev/pull/1557/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1557&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256126 Stats: 798 lines in 15 files changed: 744 ins; 51 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1557.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1557/head:pull/1557 PR: https://git.openjdk.org/jdk11u-dev/pull/1557 From lzhai at openjdk.org Tue Nov 29 02:04:36 2022 From: lzhai at openjdk.org (Leslie Zhai) Date: Tue, 29 Nov 2022 02:04:36 GMT Subject: [jdk17u-dev] RFR: 8267189: Remove duplicated unregistered classes from dynamic archive Message-ID: Hi, Commit d983d108c565654e717e2811d88aa94d982da2f5 fix JDK-8297543: runtime/cds/appcds/cacheObject/ArchivedModuleCompareTest.java fail with jfx And dependencies: => JDK-8267189: Remove duplicated unregistered classes from dynamic archive * JDK-8268821: Split systemDictionaryShared.cpp * JDK-8269004: Implement ResizableResourceHashtable * JDK-8270061: Change parameter order of ResourceHashtable * JDK-8270803: Reduce CDS API verbosity * JDK-8270489: Support archived heap objects in EpsilonGC * JDK-8275731: CDS archived enums objects are recreated at runtime The patch applies clean except manually edit the source file: * src/hotspot/share/classfile/systemDictionaryShared.hpp Made `static void SystemDictionaryShared::remove_dumptime_info(InstanceKlass*)` public within this context. Tested jtreg tier1~3, no regression. Thanks, Leslie Zhai ------------- Commit messages: - Backport bb24fa652aa1edc8ece8713f559be2fe3437d666 Changes: https://git.openjdk.org/jdk17u-dev/pull/939/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=939&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8267189 Stats: 318 lines in 8 files changed: 299 ins; 2 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/939.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/939/head:pull/939 PR: https://git.openjdk.org/jdk17u-dev/pull/939 From vrudomet at openjdk.org Tue Nov 29 04:13:17 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 29 Nov 2022 04:13:17 GMT Subject: [jdk19u] RFR: 8295447: NullPointerException with invalid pattern matching construct in constructor call Message-ID: <9QqRxO_seqjYOYvVOxh73UMxxy6hIPGLASSf2bn878g=.b1bf214a-cfc7-4d74-9acb-db5c2fe7b784@github.com> Backport for [JDK-8295447](https://bugs.openjdk.org/browse/JDK-8295447) NullPointerException with invalid pattern matching construct in constructor call https://git.openjdk.org/jdk/commit/6c05771b9be3dd5cbcdb40d2e53cc53959926cdd Clean backport JTreg tier1, tier2, jck runtime and jck compiler passed. Test T8295447.java passes during run. ------------- Commit messages: - 8295447: NullPointerException with invalid pattern matching construct in constructor call Changes: https://git.openjdk.org/jdk19u/pull/99/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=99&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295447 Stats: 57 lines in 3 files changed: 56 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk19u/pull/99.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/99/head:pull/99 PR: https://git.openjdk.org/jdk19u/pull/99 From vrudomet at openjdk.org Tue Nov 29 08:25:23 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 29 Nov 2022 08:25:23 GMT Subject: [jdk17u-dev] RFR: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation Message-ID: Backport for [JDK-8297530](https://bugs.openjdk.org/browse/JDK-8297530) java.lang.IllegalArgumentException: Negative length on strings concatenation Clean backport, minor change Tier1, Tier2, JCK Compiler, JCK Runtime passed New test during run. ------------- Commit messages: - 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation Changes: https://git.openjdk.org/jdk17u-dev/pull/940/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=940&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297530 Stats: 141 lines in 2 files changed: 139 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/940.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/940/head:pull/940 PR: https://git.openjdk.org/jdk17u-dev/pull/940 From vrudomet at openjdk.org Tue Nov 29 08:30:21 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Tue, 29 Nov 2022 08:30:21 GMT Subject: [jdk19u] RFR: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation Message-ID: Backport for [JDK-8297530](https://bugs.openjdk.org/browse/JDK-8297530) java.lang.IllegalArgumentException: Negative length on strings concatenation Clean backport, minor change Tier1, Tier2, JCK Compiler, JCK Runtime passed New test passed during run. ------------- Commit messages: - 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation Changes: https://git.openjdk.org/jdk19u/pull/100/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=100&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297530 Stats: 141 lines in 2 files changed: 139 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk19u/pull/100.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/100/head:pull/100 PR: https://git.openjdk.org/jdk19u/pull/100 From jbhateja at openjdk.org Tue Nov 29 16:32:50 2022 From: jbhateja at openjdk.org (Jatin Bhateja) Date: Tue, 29 Nov 2022 16:32:50 GMT Subject: [jdk17u-dev] RFR: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets. [v3] In-Reply-To: References: Message-ID: > Clean backport of [JDK-8290322](https://bugs.openjdk.org/browse/JDK-8290322), due to merge conflicts original patch could not be applied directly by bot. > > Patch enables wide vector byte level permutation for AVX512BW targets and benefits multiple generations of Intel's Xeon servers (SKX, CLX, CPX) prior to Ice lake which provides a direct HW instruction (VPERMB). JIT instruction sequence emitted in this case is specific to Vector.rearrange API, hence the scope of the patch is limited to VectorAPIs which is an incubating module currently. > > Vector API jtreg test suite contains multiple tests cases for ByteVector.SPECIES_512 to extensively tests the patch. > > Original patch review was done with [PR 9498](https://github.com/openjdk/jdk/pull/9498) Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision: Backport 38a81913d33c856d64b7c26f934026815a482e43 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/917/files - new: https://git.openjdk.org/jdk17u-dev/pull/917/files/697699eb..ac9e9db9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=917&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=917&range=01-02 Stats: 93 lines in 2 files changed: 47 ins; 46 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/917.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/917/head:pull/917 PR: https://git.openjdk.org/jdk17u-dev/pull/917 From shade at openjdk.org Tue Nov 29 16:36:01 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 29 Nov 2022 16:36:01 GMT Subject: [jdk19u] RFR: 8297309: Memory leak in ShenandoahFullGC In-Reply-To: <8miV1uts--PxRqFggEZLcqRweWlvCvx3Irq5h3tu-Vo=.56639706-8510-40fa-97c2-d942a051ed37@github.com> References: <8miV1uts--PxRqFggEZLcqRweWlvCvx3Irq5h3tu-Vo=.56639706-8510-40fa-97c2-d942a051ed37@github.com> Message-ID: On Mon, 28 Nov 2022 13:05:42 GMT, Aleksey Shipilev wrote: > Clean backport to fix a trivial memory leak in Shenandoah. > > Additional testing: > - [x] Linux x86_64 fastdebug, hotspot_gc_shenandoah Got the push approval. ------------- PR: https://git.openjdk.org/jdk19u/pull/98 From jbhateja at openjdk.org Tue Nov 29 16:38:37 2022 From: jbhateja at openjdk.org (Jatin Bhateja) Date: Tue, 29 Nov 2022 16:38:37 GMT Subject: [jdk17u-dev] RFR: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets. [v2] In-Reply-To: References: Message-ID: On Mon, 28 Nov 2022 23:55:52 GMT, Sandhya Viswanathan wrote: >> Jatin Bhateja has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> Backport 38a81913d33c856d64b7c26f934026815a482e43 > > src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 3874: > >> 3872: void C2_MacroAssembler::rearrange_bytes(XMMRegister dst, XMMRegister shuffle, XMMRegister src, XMMRegister xtmp1, >> 3873: XMMRegister xtmp2, XMMRegister xtmp3, Register rtmp, KRegister ktmp, >> 3874: int vlen_enc) { > > This is the last method in the file in the original commit (https://github.com/openjdk/jdk/commit/38a81913d33c856d64b7c26f934026815a482e43) as well as jdk mainline tip. Fixed both styling comment. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/917 From shade at openjdk.org Tue Nov 29 16:39:00 2022 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 29 Nov 2022 16:39:00 GMT Subject: [jdk19u] Integrated: 8297309: Memory leak in ShenandoahFullGC In-Reply-To: <8miV1uts--PxRqFggEZLcqRweWlvCvx3Irq5h3tu-Vo=.56639706-8510-40fa-97c2-d942a051ed37@github.com> References: <8miV1uts--PxRqFggEZLcqRweWlvCvx3Irq5h3tu-Vo=.56639706-8510-40fa-97c2-d942a051ed37@github.com> Message-ID: On Mon, 28 Nov 2022 13:05:42 GMT, Aleksey Shipilev wrote: > Clean backport to fix a trivial memory leak in Shenandoah. > > Additional testing: > - [x] Linux x86_64 fastdebug, hotspot_gc_shenandoah This pull request has now been integrated. Changeset: d153a8c0 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk19u/commit/d153a8c0ca397f576199daf8fb61dbde1d91ecf3 Stats: 5 lines in 2 files changed: 5 ins; 0 del; 0 mod 8297309: Memory leak in ShenandoahFullGC Backport-of: b80f5af6981440aec14f4dedbc5ee46364d0254c ------------- PR: https://git.openjdk.org/jdk19u/pull/98 From sviswanathan at openjdk.org Tue Nov 29 17:00:10 2022 From: sviswanathan at openjdk.org (Sandhya Viswanathan) Date: Tue, 29 Nov 2022 17:00:10 GMT Subject: [jdk17u-dev] RFR: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets. [v3] In-Reply-To: References: Message-ID: <4tXhyLDpMajFwkEvbjPV3qpYObnGIjr83Lsvv_kxr0Y=.6ed5cad1-fba2-45f8-b5d0-885caa5bfffb@github.com> On Tue, 29 Nov 2022 16:32:50 GMT, Jatin Bhateja wrote: >> Clean backport of [JDK-8290322](https://bugs.openjdk.org/browse/JDK-8290322), due to merge conflicts original patch could not be applied directly by bot. >> >> Patch enables wide vector byte level permutation for AVX512BW targets and benefits multiple generations of Intel's Xeon servers (SKX, CLX, CPX) prior to Ice lake which provides a direct HW instruction (VPERMB). JIT instruction sequence emitted in this case is specific to Vector.rearrange API, hence the scope of the patch is limited to VectorAPIs which is an incubating module currently. >> >> Vector API jtreg test suite contains multiple tests cases for ByteVector.SPECIES_512 to extensively tests the patch. >> >> Original patch review was done with [PR 9498](https://github.com/openjdk/jdk/pull/9498) > > Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision: > > Backport 38a81913d33c856d64b7c26f934026815a482e43 Marked as reviewed by sviswanathan (no project role). ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/917 From phh at openjdk.org Tue Nov 29 18:07:27 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 29 Nov 2022 18:07:27 GMT Subject: [jdk17u-dev] RFR: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets. [v3] In-Reply-To: References: Message-ID: On Tue, 29 Nov 2022 16:32:50 GMT, Jatin Bhateja wrote: >> Clean backport of [JDK-8290322](https://bugs.openjdk.org/browse/JDK-8290322), due to merge conflicts original patch could not be applied directly by bot. >> >> Patch enables wide vector byte level permutation for AVX512BW targets and benefits multiple generations of Intel's Xeon servers (SKX, CLX, CPX) prior to Ice lake which provides a direct HW instruction (VPERMB). JIT instruction sequence emitted in this case is specific to Vector.rearrange API, hence the scope of the patch is limited to VectorAPIs which is an incubating module currently. >> >> Vector API jtreg test suite contains multiple tests cases for ByteVector.SPECIES_512 to extensively tests the patch. >> >> Original patch review was done with [PR 9498](https://github.com/openjdk/jdk/pull/9498) > > Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision: > > Backport 38a81913d33c856d64b7c26f934026815a482e43 Thank you, Sandhya. Waiting for maintainer approval. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/917 From btaylor at openjdk.org Tue Nov 29 18:51:46 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 29 Nov 2022 18:51:46 GMT Subject: [jdk17u-dev] Integrated: 8273497: building.md should link to both md and html In-Reply-To: <13auB9odGxwMFMIzyFeOen89MJ3ta0KPQQtrzMdStMM=.cd2aaf93-44bb-4125-8fe3-8900f920f848@github.com> References: <13auB9odGxwMFMIzyFeOen89MJ3ta0KPQQtrzMdStMM=.cd2aaf93-44bb-4125-8fe3-8900f920f848@github.com> Message-ID: On Tue, 22 Nov 2022 01:04:17 GMT, Ben Taylor wrote: > Documentation-only fix. > This patch and [JDK-8285093](https://bugs.openjdk.org/browse/JDK-8285093) are needed to make [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) clean. This pull request has now been integrated. Changeset: a10bb08a Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/a10bb08a4c187c6c0b21cafb25877895d885427e Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod 8273497: building.md should link to both md and html Backport-of: 5bfd043e16fa79a101a1bee38c59d42d4cd69a48 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/914 From btaylor at openjdk.org Tue Nov 29 19:18:17 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 29 Nov 2022 19:18:17 GMT Subject: [jdk17u-dev] RFR: 8285093: Introduce UTIL_ARG_WITH [v4] In-Reply-To: References: Message-ID: > Backporting to make [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) clean. > > This change is independent of #914 but both are required for [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' of https://git.openjdk.org/jdk17u-dev into 8285093 - Backport 94afb366b2ec76669e1aac38dbadc223ccafda3d - Backport 5bfd043e16fa79a101a1bee38c59d42d4cd69a48 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/915/files - new: https://git.openjdk.org/jdk17u-dev/pull/915/files/b98a4e91..99225eca Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=915&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=915&range=02-03 Stats: 2142 lines in 55 files changed: 1716 ins; 190 del; 236 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/915.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/915/head:pull/915 PR: https://git.openjdk.org/jdk17u-dev/pull/915 From phh at openjdk.org Tue Nov 29 23:10:43 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 29 Nov 2022 23:10:43 GMT Subject: [jdk11u-dev] RFR: 8256126: Create implementation for NSAccessibilityImage protocol peer In-Reply-To: References: Message-ID: On Tue, 29 Nov 2022 00:52:52 GMT, Autumn Capasso wrote: > Clean backport of [JDK-8256126](https://bugs.openjdk.org/browse/JDK-8256126) outside of having to modify the a few lines in one file which has had to be modified for each. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). 5/28 of the series of backports. The original commit changed only 3 files, while this PR changes 15. There's a prior dependency that must be backported first. Also, you can use dependent PRs as described at https://blog.logrocket.com/using-stacked-pull-requests-in-github/ to stage dependent backports. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1557 From phh at openjdk.org Tue Nov 29 23:15:29 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 29 Nov 2022 23:15:29 GMT Subject: [jdk11u-dev] RFR: 8256110: Create implementation for NSAccessibilityStepper protocol In-Reply-To: References: Message-ID: <8WhMO3y7xJ2jb4WwkA-RudRBbqnGa48swxIQyb_4A04=.4a65ebda-d5a2-424c-a0b6-b432597b456d@github.com> On Tue, 22 Nov 2022 20:31:58 GMT, Autumn Capasso wrote: > Backport-of: a54adefb246d945fee88e19ca38b601ffc628305 for [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8259779) Mostly clean backport. 2/28 of the series of backports. In Common ComponentAccessibility.m, is there a prior commit that added lines 52-53? If so, that prior commit should be backported first. Similarly, CoordinateTruncationBug.java doesn't exist in the original commit, so must have been added earlier. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1544 From phh at openjdk.org Tue Nov 29 23:22:16 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 29 Nov 2022 23:22:16 GMT Subject: [jdk11u-dev] RFR: 8261351: Create implementation for NSAccessibilityRadioButton protocol In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 01:22:15 GMT, Autumn Capasso wrote: > [JDK-8261351 ](https://bugs.openjdk.org/browse/JDK-8261351) Mostly clean backport. 4/28 of the series of backports. The original commit affected only 3 files, while this PR affects 12. There must be a prior commit to backport first. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1548 From phh at openjdk.org Tue Nov 29 23:23:29 2022 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 29 Nov 2022 23:23:29 GMT Subject: [jdk11u-dev] RFR: 8261350: Create implementation for NSAccessibilityCheckBox protocol peer In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 23:36:32 GMT, Autumn Capasso wrote: > [JDK-8261350](https://bugs.openjdk.org/browse/JDK-8261350) Mostly clean each backport seems to just be cleaning up the java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m file so it aligns properly. The original commit affected only 5 files, while this PR affects 12. There must be a prior commit to backport first. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1550 From vrudomet at openjdk.org Wed Nov 30 03:43:20 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Wed, 30 Nov 2022 03:43:20 GMT Subject: [jdk17u-dev] RFR: 8297481: Create a regression test for JDK-4424517 Message-ID: Backport for [JDK-8297481](https://bugs.openjdk.org/browse/JDK-8297481) Create a regression test for JDK-4424517 https://github.com/openjdk/jdk/commit/e2d71c0a0d654841e3e591beeaa04b44c6e6b37f Clean backport New test, low risk. Test passes during manual run, checked on macos and linux ------------- Commit messages: - 8297481: Create a regression test for JDK-4424517 Changes: https://git.openjdk.org/jdk17u-dev/pull/941/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=941&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297481 Stats: 212 lines in 1 file changed: 212 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/941.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/941/head:pull/941 PR: https://git.openjdk.org/jdk17u-dev/pull/941 From vrudomet at openjdk.org Wed Nov 30 03:43:36 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Wed, 30 Nov 2022 03:43:36 GMT Subject: [jdk11u-dev] RFR: 8297481: Create a regression test for JDK-4424517 Message-ID: Backport for [JDK-8297481](https://bugs.openjdk.org/browse/JDK-8297481) Create a regression test for JDK-4424517 https://github.com/openjdk/jdk/commit/e2d71c0a0d654841e3e591beeaa04b44c6e6b37f Clean backport New test, low risk. Test passes during manual run, checked on macos and linux ------------- Commit messages: - 8297481: Create a regression test for JDK-4424517 Changes: https://git.openjdk.org/jdk11u-dev/pull/1559/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1559&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297481 Stats: 212 lines in 1 file changed: 212 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1559.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1559/head:pull/1559 PR: https://git.openjdk.org/jdk11u-dev/pull/1559 From vrudomet at openjdk.org Wed Nov 30 03:43:49 2022 From: vrudomet at openjdk.org (Victor Rudometov) Date: Wed, 30 Nov 2022 03:43:49 GMT Subject: [jdk19u] RFR: 8297481: Create a regression test for JDK-4424517 Message-ID: Backport for [JDK-8297481](https://bugs.openjdk.org/browse/JDK-8297481) Create a regression test for JDK-4424517 https://github.com/openjdk/jdk/commit/e2d71c0a0d654841e3e591beeaa04b44c6e6b37f Clean backport New test, low risk. Test passes during manual run, checked on macos and linux ------------- Commit messages: - 8297481: Create a regression test for JDK-4424517 Changes: https://git.openjdk.org/jdk19u/pull/101/files Webrev: https://webrevs.openjdk.org/?repo=jdk19u&pr=101&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297481 Stats: 212 lines in 1 file changed: 212 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk19u/pull/101.diff Fetch: git fetch https://git.openjdk.org/jdk19u pull/101/head:pull/101 PR: https://git.openjdk.org/jdk19u/pull/101 From mbaesken at openjdk.org Wed Nov 30 09:03:56 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 30 Nov 2022 09:03:56 GMT Subject: [jdk17u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f Message-ID: backport of 8296715; avoid [make/data/cldr/common/dtd/ldmlSupplemental.dtd](https://github.com/openjdk/jdk/commit/54c986e7d5d0b48a22b4da81c13153ce431c9f2f#diff-0854244a893369539d4984ea67bc7e8788659b4f059c6e5f61a8cdf7f23c80c2) changes like it has been done in the 19u and 15u backports; test files need manual adjustment because of changes in the stride ------------- Commit messages: - Backport 55dd90222e2cef11ebca39a2998d8f799aadbb9a Changes: https://git.openjdk.org/jdk17u-dev/pull/942/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=942&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296715 Stats: 15 lines in 5 files changed: 6 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/942.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/942/head:pull/942 PR: https://git.openjdk.org/jdk17u-dev/pull/942 From goetz.lindenmaier at sap.com Wed Nov 30 09:18:48 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 30 Nov 2022 09:18:48 +0000 Subject: [11u reminder]: jdk 11.0.18 rampdown starts Tuesday, December 6th, 18:00 CET. Message-ID: Hi, I would like to remind everybody who is working on jdk 11 updates that rampdown of 11.0.18 starts next Tuesday, December 6th, at 18:00 CET. At that point in time the last merge from jdk11u-dev to jdk11u will take place. Please push all changes you want to get to 11.0.18 before that date. After that, changes for 11.0.18 must be requested with jdk11u-critical-request tags, and they need to be pushed directly to jdk11u. Best regards, Goetz See also https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u -------------- next part -------------- An HTML attachment was scrubbed... URL: From goetz.lindenmaier at sap.com Wed Nov 30 09:21:18 2022 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 30 Nov 2022 09:21:18 +0000 Subject: 17u reminder]: jdk 17.0.6 rampdown starts Tuesday, December 6th, 18:00 CET. Message-ID: Hi, I would like to remind everybody who is working on jdk 17 updates that rampdown of 17.0.6 starts next Tuesday, December 6th, at 18:00 CET. At that point in time the last merge from jdk17u-dev to jdk17u will take place. Please push all changes you want to get to 17.0.6 before that date. After that, changes for 17.0.6 must be requested with jdk17u-critical-request tags, and they need to be pushed directly to jdk17u. Best regards, Goetz See also https://wiki.openjdk.java.net/display/JDKUpdates/JDK17u -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Wed Nov 30 09:59:36 2022 From: duke at openjdk.org (Michal Karm Babacek) Date: Wed, 30 Nov 2022 09:59:36 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters Message-ID: Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. The test passes with the patch, fails without it. $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" ... ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java 1 1 0 0 ============================== TEST SUCCESS Stopping sjavac server Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. ## Unpatched Temurin-11.0.17+8 ? $ java WebSocketTest Http Request http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz WebSocket Request ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz ## Patched jdk11u ? $ java WebSocketTest Http Request http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz WebSocket Request ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz The patched version correctly leaves the latter part of the query param encoded. ------------- Commit messages: - Backports JDK-8245245: WebSocket can lose the URL encoding Changes: https://git.openjdk.org/jdk11u-dev/pull/1558/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1558&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8245245 Stats: 215 lines in 2 files changed: 207 ins; 6 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1558.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1558/head:pull/1558 PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From sgehwolf at openjdk.org Wed Nov 30 09:59:36 2022 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 30 Nov 2022 09:59:36 GMT Subject: [jdk11u-dev] RFR: 8245245: WebSocket can lose the URL encoding of URI query parameters In-Reply-To: References: Message-ID: <_SL3YG1-aIOzdZhfYxVUW8ZrJ6eUWThIv0mDJRd4Y-0=.d82c5722-318d-42c5-bb07-99a35bad5e07@github.com> On Wed, 30 Nov 2022 01:52:47 GMT, Michal Karm Babacek wrote: > Proposes to backport [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245). > > The backport is clean as far as the actual `OpeningHandshake.java` goes. The test needed a little tweak so as to compile with `SimpleSSLContext` and also to handle the fact that the erroneous response does not bring a response body. > > The test passes with the patch, fails without it. > > > $ make clean run-test TEST="jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/net/httpclient/websocket/HandshakeUrlEncodingTest.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Stopping sjavac server > Finished building targets 'clean run-test' in configuration 'linux-x86_64-normal-server-release' > > In addition to that, I compiled and executed the original `WebSocketTest.java` reproducer found on [JDK-8245245](https://bugs.openjdk.org/browse/JDK-8245245) JIRA. > > > ## Unpatched Temurin-11.0.17+8 ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc+def/ghi=xyz > > > ## Patched jdk11u ? > > $ java WebSocketTest > Http Request > http://localhost:8000/?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > WebSocket Request > ws://localhost:8000/?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > Server RequestURI: /?&raw=abc+def/ghi=xyz&encoded=abc%2Bdef%2Fghi%3Dxyz > > The patched version correctly leaves the latter part of the query param encoded. @Karm Please change the PR title to `Backport c07ce7eec71aefbd3cb624e03ca53f5148d01f19` so that the bots recognize this as a backport. Please be sure to run `:jdk_net` test group before/after as well. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1558 From clanger at openjdk.org Wed Nov 30 10:05:51 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 30 Nov 2022 10:05:51 GMT Subject: [jdk17u-dev] RFR: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 20:31:49 GMT, Ben Taylor wrote: > Backporting to 17 for improved performance. > Backport is clean. @benty-amzn, could you please enable GHA testing? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/918 From mdoerr at openjdk.org Wed Nov 30 10:39:35 2022 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 30 Nov 2022 10:39:35 GMT Subject: [jdk17u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 08:55:12 GMT, Matthias Baesken wrote: > backport of 8296715; > avoid [make/data/cldr/common/dtd/ldmlSupplemental.dtd](https://github.com/openjdk/jdk/commit/54c986e7d5d0b48a22b4da81c13153ce431c9f2f#diff-0854244a893369539d4984ea67bc7e8788659b4f059c6e5f61a8cdf7f23c80c2) > changes like it has been done in the 19u and 15u backports; test files need manual adjustment because of changes in the stride LGTM. Thanks for backporting! ------------- Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.org/jdk17u-dev/pull/942 From andrew at openjdk.org Wed Nov 30 15:57:33 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 30 Nov 2022 15:57:33 GMT Subject: [jdk17u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 08:55:12 GMT, Matthias Baesken wrote: > backport of 8296715; > avoid [make/data/cldr/common/dtd/ldmlSupplemental.dtd](https://github.com/openjdk/jdk/commit/54c986e7d5d0b48a22b4da81c13153ce431c9f2f#diff-0854244a893369539d4984ea67bc7e8788659b4f059c6e5f61a8cdf7f23c80c2) > changes like it has been done in the 19u and 15u backports; test files need manual adjustment because of changes in the stride The change looks good to me, but I think this should be a critical request for openjdk/jdk17u instead, so it makes 17.0.6 which has 2022f (17u went into rampdown yesterday: https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-November/019048.html). Note that Oracle have included this in their 17.0.6. Do you plan to handle 11u as well? ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/942 From mbaesken at openjdk.org Wed Nov 30 16:08:56 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 30 Nov 2022 16:08:56 GMT Subject: [jdk17u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 15:53:19 GMT, Andrew John Hughes wrote: > Do you plan to handle 11u as well? I am preparing an 11u-dev PR as well. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/942 From mbaesken at openjdk.org Wed Nov 30 16:12:25 2022 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 30 Nov 2022 16:12:25 GMT Subject: [jdk11u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f Message-ID: <7xpluEX58LMtG1Y-qHoO1R3tyyauqg8Zd_1HnmZiafo=.5d7efebf-6dd8-4035-a56f-c2a61e8dd1cf@github.com> Backport of 8296715; es_419.xml has different path, otherwise close to 13u backport ------------- Commit messages: - Backport b8e815b6fe0f4818628d8df05f398e92355e35fb Changes: https://git.openjdk.org/jdk11u-dev/pull/1560/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1560&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296715 Stats: 14 lines in 4 files changed: 6 ins; 3 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1560.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1560/head:pull/1560 PR: https://git.openjdk.org/jdk11u-dev/pull/1560 From andrew at openjdk.org Wed Nov 30 16:15:59 2022 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 30 Nov 2022 16:15:59 GMT Subject: [jdk17u-dev] RFR: 8296715: CLDR v42 update for tzdata 2022f In-Reply-To: References: Message-ID: On Wed, 30 Nov 2022 16:06:30 GMT, Matthias Baesken wrote: > > Do you plan to handle 11u as well? > > I am preparing an 11u-dev PR as well. Great. Same thing, please aim for 11u so we can get this in with the tzdata 2022f change. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/942 From duke at openjdk.org Wed Nov 30 17:16:39 2022 From: duke at openjdk.org (Johannes Bechberger) Date: Wed, 30 Nov 2022 17:16:39 GMT Subject: [jdk11u-dev] Integrated: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment In-Reply-To: <1ymoeGd5tGOgeP6Kzock4IjWMjkkaHtbAfHMfzfwfb4=.accde646-043b-49af-8b3b-5cdc9556244f@github.com> References: <1ymoeGd5tGOgeP6Kzock4IjWMjkkaHtbAfHMfzfwfb4=.accde646-043b-49af-8b3b-5cdc9556244f@github.com> Message-ID: On Mon, 21 Nov 2022 12:12:35 GMT, Johannes Bechberger wrote: > Backports a fix to ensure that ASGCT does not obtain the mentioned lock. Tested with my profiling tester. This pull request has now been integrated. Changeset: 13bcc231 Author: Johannes Bechberger Committer: Jaroslav Bachorik URL: https://git.openjdk.org/jdk11u-dev/commit/13bcc231c5a505e92cb9eb523d991f7e719e1ac9 Stats: 9 lines in 1 file changed: 4 ins; 1 del; 4 mod 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1537 From btaylor at openjdk.org Wed Nov 30 19:08:52 2022 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 30 Nov 2022 19:08:52 GMT Subject: [jdk17u-dev] Integrated: 8285093: Introduce UTIL_ARG_WITH In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 01:15:00 GMT, Ben Taylor wrote: > Backporting to make [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) clean. > > This change is independent of #914 but both are required for [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550). This pull request has now been integrated. Changeset: 5b77b574 Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/5b77b574685ee043dfce2b5b17cb0f166b339485 Stats: 381 lines in 2 files changed: 349 ins; 5 del; 27 mod 8285093: Introduce UTIL_ARG_WITH Backport-of: 94afb366b2ec76669e1aac38dbadc223ccafda3d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/915 From duke at openjdk.org Wed Nov 30 21:09:36 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 30 Nov 2022 21:09:36 GMT Subject: [jdk11u-dev] Withdrawn: 8261351: Create implementation for NSAccessibilityRadioButton protocol In-Reply-To: References: Message-ID: <_BYblNaDTrDvlm30YoahizX9kHvjKYXu-dexeUY3TUY=.97205ebb-a710-428f-accd-96c8fc389e9d@github.com> On Wed, 23 Nov 2022 01:22:15 GMT, Autumn Capasso wrote: > [JDK-8261351 ](https://bugs.openjdk.org/browse/JDK-8261351) Mostly clean backport. 4/28 of the series of backports. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1548 From duke at openjdk.org Wed Nov 30 21:09:38 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 30 Nov 2022 21:09:38 GMT Subject: [jdk11u-dev] Withdrawn: 8256110: Create implementation for NSAccessibilityStepper protocol In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 20:31:58 GMT, Autumn Capasso wrote: > Backport-of: a54adefb246d945fee88e19ca38b601ffc628305 for [JDK-8256110](https://bugs.openjdk.org/browse/JDK-8259779) Mostly clean backport. 2/28 of the series of backports. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1544 From duke at openjdk.org Wed Nov 30 21:09:49 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 30 Nov 2022 21:09:49 GMT Subject: [jdk11u-dev] Withdrawn: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions In-Reply-To: References: Message-ID: On Tue, 22 Nov 2022 20:35:50 GMT, Autumn Capasso wrote: > [JDK-8261352](https://bugs.openjdk.org/browse/JDK-8261352) Mostly clean, 3/28 backports for accessibility. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1545 From duke at openjdk.org Wed Nov 30 21:09:55 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 30 Nov 2022 21:09:55 GMT Subject: [jdk11u-dev] Withdrawn: 8261350: Create implementation for NSAccessibilityCheckBox protocol peer In-Reply-To: References: Message-ID: On Wed, 23 Nov 2022 23:36:32 GMT, Autumn Capasso wrote: > [JDK-8261350](https://bugs.openjdk.org/browse/JDK-8261350) Mostly clean each backport seems to just be cleaning up the java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m file so it aligns properly. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1550 From duke at openjdk.org Wed Nov 30 21:10:17 2022 From: duke at openjdk.org (Autumn Capasso) Date: Wed, 30 Nov 2022 21:10:17 GMT Subject: [jdk11u-dev] Withdrawn: 8256126: Create implementation for NSAccessibilityImage protocol peer In-Reply-To: References: Message-ID: On Tue, 29 Nov 2022 00:52:52 GMT, Autumn Capasso wrote: > Clean backport of [JDK-8256126](https://bugs.openjdk.org/browse/JDK-8256126) outside of having to modify the a few lines in one file which has had to be modified for each. This is part of broader group of changes as part of [JDK-8152350](https://bugs.openjdk.org/browse/JDK-8152350). 5/28 of the series of backports. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1557 From clanger at openjdk.org Wed Nov 30 22:03:29 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 30 Nov 2022 22:03:29 GMT Subject: [jdk19u] Integrated: 8296904: Improve handling of macos xcode toolchain In-Reply-To: References: Message-ID: <4SqV9LOrZOTKL6A6b9QFA3lh03o_kuTI7EatOcNOXRo=.07f65e27-4063-4d6e-9890-bbb7f1191a68@github.com> On Thu, 24 Nov 2022 07:47:43 GMT, Christoph Langer wrote: > The diff to the make file and building.md applied cleanly. > I had to regenerate building.html due to the different version of pandoc used. This pull request has now been integrated. Changeset: 7275da49 Author: Christoph Langer URL: https://git.openjdk.org/jdk19u/commit/7275da49c0e9728b1b22c21c85ce8e98438e9adc Stats: 73 lines in 3 files changed: 29 ins; 4 del; 40 mod 8296904: Improve handling of macos xcode toolchain Reviewed-by: mbaesken Backport-of: 470f3424fcce0e41b75cccdd5e3a56771cd07ff5 ------------- PR: https://git.openjdk.org/jdk19u/pull/92 From cushon at openjdk.org Wed Nov 30 22:07:12 2022 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Wed, 30 Nov 2022 22:07:12 GMT Subject: [jdk11u-dev] Integrated: 8222091: Javadoc does not handle package annotations correctly on package-info.java In-Reply-To: References: Message-ID: On Tue, 25 Oct 2022 17:06:11 GMT, Liam Miller-Cushon wrote: > This is a backport of [JDK-8222091: Javadoc does not handle package annotations correctly on package-info.java](https://bugs.openjdk.java.net/browse/JDK-8222091) > > This fixes a regression in 11.0.17 caused by the backport of [JDK-8193462](https://bugs.openjdk.org/browse/JDK-8193462), see [JDK-8295850](https://bugs.openjdk.org/browse/JDK-8295850) > > Original patch applied cleanly, the test was updated due to some changes in test infrastructrure: > > > diff --git a/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java b/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java > index cd9697eede..9f04777f81 100644 > --- a/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java > +++ b/test/langtools/jdk/javadoc/doclet/testPackageAnnotation/TestPackageAnnotation.java > @@ -25,14 +25,12 @@ > * @test > * @bug 8222091 > * @summary Javadoc does not handle package annotations correctly on package-info.java > - * @library ../../lib/ > + * @library ../lib/ > * @modules jdk.javadoc/jdk.javadoc.internal.tool > - * @build javadoc.tester.* > + * @build JavadocTester > * @run main TestPackageAnnotation > */ > > -import javadoc.tester.JavadocTester; > - > public class TestPackageAnnotation extends JavadocTester { > > public static void main(String... args) throws Exception { > > > Tested: tier1 langtools tests passed This pull request has now been integrated. Changeset: 09d50d9d Author: Liam Miller-Cushon Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/09d50d9d929214f5bafb39dc8de9c1ad32bad650 Stats: 244 lines in 9 files changed: 238 ins; 0 del; 6 mod 8222091: Javadoc does not handle package annotations correctly on package-info.java Reviewed-by: clanger Backport-of: 4d08dd703e4d742635c3dbc8acc4b07b3a298657 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1475 From serb at openjdk.org Wed Nov 30 23:02:24 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Nov 2022 23:02:24 GMT Subject: [jdk17u-dev] Integrated: 8296496: Overzealous check in sizecalc.h prevents large memory allocation In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 02:16:18 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. > Thanks! This pull request has now been integrated. Changeset: d9821584 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/d98215846e9bc5280f9009d434d45f065020eec9 Stats: 11 lines in 1 file changed: 0 ins; 4 del; 7 mod 8296496: Overzealous check in sizecalc.h prevents large memory allocation Backport-of: 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/928 From serb at openjdk.org Wed Nov 30 23:05:14 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Nov 2022 23:05:14 GMT Subject: [jdk15u-dev] Integrated: 8296496: Overzealous check in sizecalc.h prevents large memory allocation In-Reply-To: References: Message-ID: On Thu, 24 Nov 2022 02:19:30 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. > Thanks! This pull request has now been integrated. Changeset: ea36dfe8 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk15u-dev/commit/ea36dfe89d492b54f4754a2f8b95e48c41e57d51 Stats: 11 lines in 1 file changed: 0 ins; 4 del; 7 mod 8296496: Overzealous check in sizecalc.h prevents large memory allocation Backport-of: 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 ------------- PR: https://git.openjdk.org/jdk15u-dev/pull/306 From serb at openjdk.org Wed Nov 30 23:05:47 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Nov 2022 23:05:47 GMT Subject: [jdk13u-dev] Integrated: 8296496: Overzealous check in sizecalc.h prevents large memory allocation In-Reply-To: References: Message-ID: <1JA6Z5lO_tdG-YlDjxAdw7na55gBTwT8avMHZzExofc=.beea829e-0450-4a40-b1fa-29ab407514d1@github.com> On Thu, 24 Nov 2022 02:29:08 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. > Thanks! This pull request has now been integrated. Changeset: 5b062418 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk13u-dev/commit/5b0624187d2e55fd91dd31b20b7cb28398385700 Stats: 11 lines in 1 file changed: 0 ins; 4 del; 7 mod 8296496: Overzealous check in sizecalc.h prevents large memory allocation Backport-of: 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 ------------- PR: https://git.openjdk.org/jdk13u-dev/pull/432 From serb at openjdk.org Wed Nov 30 23:06:50 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Nov 2022 23:06:50 GMT Subject: [jdk15u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 [v2] In-Reply-To: References: Message-ID: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk15u-dev/pull/308/files - new: https://git.openjdk.org/jdk15u-dev/pull/308/files/44aff790..44aff790 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=308&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=308&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/308.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/308/head:pull/308 PR: https://git.openjdk.org/jdk15u-dev/pull/308 From serb at openjdk.org Wed Nov 30 23:07:13 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Nov 2022 23:07:13 GMT Subject: [jdk17u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 [v2] In-Reply-To: References: Message-ID: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/937/files - new: https://git.openjdk.org/jdk17u-dev/pull/937/files/c4f50645..c4f50645 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=937&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=937&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/937.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/937/head:pull/937 PR: https://git.openjdk.org/jdk17u-dev/pull/937 From serb at openjdk.org Wed Nov 30 23:12:32 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Nov 2022 23:12:32 GMT Subject: [jdk11u-dev] Integrated: 8296496: Overzealous check in sizecalc.h prevents large memory allocation In-Reply-To: References: Message-ID: <6U8wmf7Liaw5ib214TorOv2iXuPnY1xX48IoCQKY7Rc=.f3e7438d-99dc-4e41-b249-5c89a310f0fc@github.com> On Thu, 24 Nov 2022 02:33:50 GMT, Sergey Bylokhov wrote: > Hi all, > This pull request contains a backport of commit [84e12244](https://github.com/openjdk/jdk/commit/84e12244a4ff82b3307a5ffe6fbe9dded7b08d86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev. > Thanks! This pull request has now been integrated. Changeset: f643709b Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/f643709b3992fd76dbff7b73e9a2c482c3aaa372 Stats: 11 lines in 1 file changed: 0 ins; 4 del; 7 mod 8296496: Overzealous check in sizecalc.h prevents large memory allocation Backport-of: 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1551 From serb at openjdk.org Wed Nov 30 23:13:56 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Nov 2022 23:13:56 GMT Subject: [jdk13u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 [v2] In-Reply-To: References: Message-ID: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk13u-dev/pull/434/files - new: https://git.openjdk.org/jdk13u-dev/pull/434/files/45b062ca..45b062ca Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=434&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk13u-dev&pr=434&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk13u-dev/pull/434.diff Fetch: git fetch https://git.openjdk.org/jdk13u-dev pull/434/head:pull/434 PR: https://git.openjdk.org/jdk13u-dev/pull/434 From serb at openjdk.org Wed Nov 30 23:18:50 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Nov 2022 23:18:50 GMT Subject: [jdk11u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 [v2] In-Reply-To: References: Message-ID: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1556/files - new: https://git.openjdk.org/jdk11u-dev/pull/1556/files/9e336822..9e336822 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1556&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1556&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1556.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1556/head:pull/1556 PR: https://git.openjdk.org/jdk11u-dev/pull/1556 From serb at openjdk.org Wed Nov 30 23:32:59 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Nov 2022 23:32:59 GMT Subject: [jdk17u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 [v3] In-Reply-To: References: Message-ID: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into mrserb-backport-fb6c992f - Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8 - Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/937/files - new: https://git.openjdk.org/jdk17u-dev/pull/937/files/c4f50645..c07447ba Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=937&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=937&range=01-02 Stats: 1453 lines in 40 files changed: 1062 ins; 63 del; 328 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/937.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/937/head:pull/937 PR: https://git.openjdk.org/jdk17u-dev/pull/937 From serb at openjdk.org Wed Nov 30 23:36:27 2022 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Nov 2022 23:36:27 GMT Subject: [jdk15u-dev] RFR: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2 [v3] In-Reply-To: References: Message-ID: > Hi all, > This pull request contains a backport of commit [fb6c992f](https://github.com/openjdk/jdk/commit/fb6c992f325981c42c7f75109a6c9db7ca8715d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > The commit being backported was authored by Sergey Bylokhov on 22 Nov 2022 and was reviewed by Alexey Ivanov. > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into mrserb-backport-fb6c992f - Backport fb6c992f325981c42c7f75109a6c9db7ca8715d8 - Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 ------------- Changes: - all: https://git.openjdk.org/jdk15u-dev/pull/308/files - new: https://git.openjdk.org/jdk15u-dev/pull/308/files/44aff790..b0d76c7c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=308&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk15u-dev&pr=308&range=01-02 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk15u-dev/pull/308.diff Fetch: git fetch https://git.openjdk.org/jdk15u-dev pull/308/head:pull/308 PR: https://git.openjdk.org/jdk15u-dev/pull/308