[jdk17u-dev] RFR: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library [v2]

Martin Doerr mdoerr at openjdk.org
Tue Nov 1 11:27:11 UTC 2022


On Sun, 30 Oct 2022 10:02:44 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Resolved signals_posix.cpp because test for do_check is not in 17.
>> That was added by  8283337: Posix signal handler modification warning triggering incorrectly
>> I add 8283337 to this backport as it is subsumed by 8292695.
>> 
>> Resolved os.cpp due to context.
>> Context was changed by "8269466: Factor out the common code for initializing and starting internal VM JavaThreads"
>
> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add TestBreakSignalThreadDump I forgot in the original commit

Looks basically good. Only one comment change is missing.

src/hotspot/os/posix/signals_posix.cpp line 1242:

> 1240: #endif
> 1241: 
> 1242:   // Save handler setup for later checking

JDK-8283337 changed this comment to: // Save handler setup for possible later checking

-------------

PR: https://git.openjdk.org/jdk17u-dev/pull/834


More information about the jdk-updates-dev mailing list