[jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML
Paul Hohensee
phh at openjdk.org
Wed Nov 16 16:23:08 UTC 2022
On Mon, 14 Nov 2022 22:21:13 GMT, Tyler Steele <tsteele at openjdk.org> wrote:
> Backporting this change to jdk11. I noticed this was also requested by @jocwurs as I was working on it.
>
> Functionally this is a clean backport. But, there are some differences that will trip up the bots.
> - Copyright years are sometimes newer in the current jdk11u. I kept the newer year.
> - I merged two lists of bug ids into one--keeping all bug-ids.
> - Git seems to treat `test/.../OutputPropertiesTest.java` as a new file in these changes, but not in the old ones. This wasn't a conflict, but it shows up differently for me on GitHub when I compare it to the changes in the original commit.
>
> Testing: OutputPropertiesTest passes.
>
> I'll wait for a review before requesting this in JBS.
As indicated by the its @bug comment, OutputProperties.java is a file brought in by JDK-8219705, which hasn't been backported. Please backport JDK-8219705 first, revise this PR and make it dependent on that backport. There are likely also predecessor(s) for JDK-8219705, based on the LastModified update in OutputPropertiesFactory.java: Feb 2019 is updated to Mar 2019, while the 11u version has Oct 2017.
-------------
Changes requested by phh (Reviewer).
PR: https://git.openjdk.org/jdk11u-dev/pull/1521
More information about the jdk-updates-dev
mailing list