[jdk11u-dev] RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v26]

Christoph Langer clanger at openjdk.org
Thu Nov 24 15:01:20 UTC 2022


On Mon, 21 Nov 2022 12:48:08 GMT, George Adams <gdams at openjdk.org> wrote:

>> The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach. There are also several Solaris specific edge cases that needed to be rewritten.
>> 
>> This PR will finally allow me to backport [8287724: Fix various issues with msys2](https://github.com/openjdk/jdk17u-dev/commit/2e21c87fac8d60c3c7ed7b2d0afae9abfc110359) cleanly which should be the final piece in the puzzle to enabling MSYS2 builds.
>> 
>> @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged.
>
> George Adams has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   win fixpath for makefile

I went over this PR now. It's rather huge and causes some headache - but on the other hand it modernizes the windows build environment and helps to significantly improve Github Actions testing. So I think we should go for it.

Testing in SAP's environment showed no issues or regressions.

One last question I have: The original change removes make/autoconf/util_windows.m4. Any reason why this is missed out here?

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1278


More information about the jdk-updates-dev mailing list