[jdk17u-dev] RFR: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod

[Andrew Dinn]

On Fri, 25 Nov 2022 14:46:01 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Not clean. Copyright in `HotSpotResolvedJavaMethodImpl.java`. `getCodeSizeTest` in
> `TestResolvedJavaMethod.java` fixed up manually, as well as omitted `equalsTest` changes
> as that test is not in 17u (because both, JDK-8289687 and JDK-8289094 are not in 17u).
> 
> HotSpotResolvedJavaFieldTest.java will need a follow-up, JDK-8297590, in order to fix the test
> and let it run. I'll get that backported to 17u once it's in JDK tip.
> 
> This pr depends on #933 as that PR changes the signature of the `createField` static method in
> `HotSpotResolvedObjectTypeImpl` (which the test fix of JDK-8297590 corrects).
> 
> Testing: jvmci tests (with backport of JDK-8297590 applied). Existing and newly included tests pass.

This also looks good.

I agree that dropping equalsTest is correct for this backport. However, if at some point we decide we need to backport JDK-8296967 we will have to try to remember also to reinsert equalsTest.

-------------

Marked as reviewed by adinn (Reviewer).

PR: https://git.openjdk.org/jdk17u-dev/pull/934