[jdk17u-dev] RFR: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod [v3]
Severin Gehwolf
sgehwolf at openjdk.org
Fri Nov 25 16:39:20 UTC 2022
> Not clean. Copyright in `HotSpotResolvedJavaMethodImpl.java`. `getCodeSizeTest` in
> `TestResolvedJavaMethod.java` fixed up manually, as well as omitted `equalsTest` changes
> as that test is not in 17u (because both, JDK-8289687 and JDK-8289094 are not in 17u).
>
> HotSpotResolvedJavaFieldTest.java will need a follow-up, JDK-8297590, in order to fix the test
> and let it run. I'll get that backported to 17u once it's in JDK tip.
>
> This pr depends on #933 as that PR changes the signature of the `createField` static method in
> `HotSpotResolvedObjectTypeImpl` (which the test fix of JDK-8297590 corrects).
>
> Testing: jvmci tests (with backport of JDK-8297590 applied). Existing and newly included tests pass.
Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod
Not clean. Copyright in HotSpotResolvedJavaMethodImpl.java.
getCodeSizeTest in TestResolvedJavaMethod.java as well as omitted
equalsTest changes as that test is not in 17u (JDK-8289687 not in 17u
as JDK-8289094 is not in 17u).
HotSpotResolvedJavaFieldTest.java will need a follow-up: JDK-8297590
-------------
Changes: https://git.openjdk.org/jdk17u-dev/pull/934/files
Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=934&range=02
Stats: 309 lines in 8 files changed: 231 ins; 38 del; 40 mod
Patch: https://git.openjdk.org/jdk17u-dev/pull/934.diff
Fetch: git fetch https://git.openjdk.org/jdk17u-dev pull/934/head:pull/934
PR: https://git.openjdk.org/jdk17u-dev/pull/934
More information about the jdk-updates-dev
mailing list