[jdk11u-dev] RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368 [v2]

Matthias Baesken mbaesken at openjdk.org
Tue Oct 11 14:44:41 UTC 2022


On Tue, 11 Oct 2022 14:35:58 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with 11.0.18-oracle.
>> 
>> 
>> I had to resolve closeInbound() in SSLEngineImpl.java because 
>> "8221882: Use fiber-friendly java.util.concurrent.locks in JSSE" 
>> is not in 11.
>
> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add try ... finally.

Why not move up the try a bit  (for easier backporting from jdk in future), please compare
https://github.com/openjdk/jdk17u-dev/blob/master/src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java#L778
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java#L778

(otherwise okay)

-------------

Marked as reviewed by mbaesken (Reviewer).

PR: https://git.openjdk.org/jdk11u-dev/pull/1422


More information about the jdk-updates-dev mailing list