[jdk11u-dev] RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368 [v2]

[Martin Balao]

On Tue, 11 Oct 2022 14:35:58 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with 11.0.18-oracle.
>> 
>> 
>> I had to resolve closeInbound() in SSLEngineImpl.java because 
>> "8221882: Use fiber-friendly java.util.concurrent.locks in JSSE" 
>> is not in 11.
>
> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add try ... finally.

Thanks @GoeLin for proposing this backport. Looks good to me.

I think that calling `conContext.closeInbound` as part of the finally block is right. I also prefer that refactorings related to fibers are done separately -if it's ever decided to backport them, which I doubt.

One very minor detail (optional): there is an extra space in "throw  new SSLException". The only reason I might fix this is to grep text easier. I'd also indent the line below 8 spaces.

-------------

Marked as reviewed by mbalao (Reviewer).

PR: https://git.openjdk.org/jdk11u-dev/pull/1422