[jdk17u-dev] RFR: 8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes

[Rui Li]

On Fri, 21 Oct 2022 03:04:55 GMT, Rui Li <duke at openjdk.org> wrote:

>> @GoeLin I'm backporting https://bugs.openjdk.org/browse/JDK-8267189 to 17 and found this comment. Having trouble understanding it. Is it still safe / recommended to backport JDK-8267189 with this unclean 8274753 backport? Thanks.
>
> Attempted backport https://bugs.openjdk.org/browse/JDK-8267189, but the build failed due to these methods. I guess it won't be a clean backport. 
> 
> 
> Not very familiar with the code, would you be able to give suggestion on where I should update? With JDK-8267189, can we remove `SystemDictionaryShared::remove_dumptime_info(ik);`?
> 
> 
> === Output from failing command(s) repeated here ===
> * For target hotspot_variant-server_libjvm_objs_classLoaderData.o:
> src/hotspot/share/classfile/classLoaderData.cpp: In member function 'void ClassLoaderData::free_deallocate_list_C_heap_structures()':
> src/hotspot/share/classfile/classLoaderData.cpp:892:56: error: 'static void SystemDictionaryShared::remove_dumptime_info(InstanceKlass*)' is private within this context
>          SystemDictionaryShared::remove_dumptime_info(ik);
>                                                         ^
> In file included from src/hotspot/share/classfile/classLoaderData.cpp:58:0:
> src/hotspot/share/classfile/systemDictionaryShared.hpp:234:15: note: declared private here
>    static void remove_dumptime_info(InstanceKlass* k) NOT_CDS_RETURN;
>                ^~~~~~~~~~~~~~~~~~~~
> At global scope:
> cc1plus: error: unrecognized command line option '-Wno-cast-function-type' [-Werror]
> cc1plus: all warnings being treated as errors
> 
> * All command lines available in /workplace/ruiamzn/github/jdk17u-dev/build/linux-x86_64-server-release/make-support/failure-logs.
> === End of repeated output ===

Looked through the code, [JDK-8267189](https://bugs.openjdk.org/browse/JDK-8267189) introduces `handle_class_unloading`.

It seems undoing this change `necessary changes for jdk17` as part of backporting `JDK-8267189` makes sense (?). Tested locally with simply `make images`, can build.

-------------

PR: https://git.openjdk.org/jdk17u-dev/pull/118