[jdk17u-dev] RFR: 8287011: Improve container information

Lutz Schmidt lucy at openjdk.org
Thu Oct 27 13:40:44 UTC 2022


On Wed, 26 Oct 2022 12:45:16 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> backport of 8287011

Changes look good to me. The change 1024 -> K could be made in a separate change. 
Please note that I'm NOT an updates Reviewer.

src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp line 188:

> 186: char* CgroupV2Subsystem::mem_swp_current_val() {
> 187:   GET_CONTAINER_INFO_CPTR(cptr, _unified, "/memory.swap.current",
> 188:                          "Swap currently used is: %s", "%s", mem_swp_current_str, 1024);

Would love to see 'K' instead of 1024. 'K' is declared in share/utilities/globalDefinitions.hpp
This is just one of multiple occurrences. I do not mark all of them.

-------------

Marked as reviewed by lucy (Committer).

PR: https://git.openjdk.org/jdk17u-dev/pull/844


More information about the jdk-updates-dev mailing list