[jdk11u-dev] RFR: 8239708: Split basics.m4 into basic.m4 and util.m4 [v6]

Thu Sep 1 11:02:11 UTC 2022

On Thu, 1 Sep 2022 08:53:43 GMT, George Adams <duke at openjdk.org> wrote:

>> The main conflict is the lack of the WSL backport ([8215445: Enable building for Windows in WSL](https://github.com/openjdk/jdk/commit/46eb26b692ac7f9431d5b479028ec87e56707557)) Something which doesn't apply particularly cleanly and isn't required to achieve the MSYS2 backport that I'm trying to reach.
>> 
>> This backport will also considerably help many build/toolchain backports going forwards as this one nearly always trips me up when I backport patches.
>> 
>> This backport will allow me to more easily backport [8257679: Improved unix compatibility layer in Windows build (winenv)](https://github.com/openjdk/jdk/commit/d29c78da).
>> 
>> @RealCLanger / @GoeLin I suggest that this is run through the full SAP nightlies before this is merged.
>
> George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - changes from review
>  - Backport 63f939636a5fe9871f5f9057c93ed5b1a9924265

Looks good now. I'll run it another night through our testing. We've had it in for the last few weeks and didn't see problems, though.

-------------

Marked as reviewed by clanger (Reviewer).

PR: https://git.openjdk.org/jdk11u-dev/pull/1277