[jdk11u-dev] RFR: 8210962: Deprecate jdk-variant
Aleksey Shipilev
shade at openjdk.org
Thu Sep 22 10:39:21 UTC 2022
On Thu, 22 Sep 2022 10:00:42 GMT, Christoph Langer <clanger at openjdk.org> wrote:
> Backports [JDK-8210962](https://bugs.openjdk.org/browse/JDK-8210962) completely as parts of it have already been introduced via the backport of [JDK-8239708](https://bugs.openjdk.org/browse/JDK-8239708) with this [commit](https://github.com/openjdk/jdk11u-dev/commit/75b3e45fe9d16a8e29f4fd51f93e01acc9436562#diff-9cc5f1086e5a06c7e88857b7d319eb938a76d4fb28905cb3dda3bb7493e809a7).
>
> An alternative, if we refrain from backporting this change would be to also back out the change in basic.m4.
>
> The backport isn't clean because the change to basics.m4/basic.m4 is already present.
At this point I am thinking that reverting this little piece might be cleaner than trying to backport the rest of it. My rationale would be making 11u downstream builders' lives easier a bit. But this is something for 11u maintainers to decide.
make/autoconf/jdk-options.m4 line 36:
> 34: AC_DEFUN_ONCE([JDKOPT_SETUP_JDK_VARIANT],
> 35: [
> 36: # Deprecated in JDK 12
This comment is now misleading.
-------------
PR: https://git.openjdk.org/jdk11u-dev/pull/1368
More information about the jdk-updates-dev
mailing list