[jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5]

[Kimura Yukihiro]

On Wed, 29 Mar 2023 06:42:36 GMT, Kimura Yukihiro <duke at openjdk.org> wrote:

>> I would like to backport
>> JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence.
>> The original patch does not apply cleanly to 11u. 
>> Because the original patch has switch expressions which can not be used in 11u,
>> and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. 
>> There is no risk, because the logic around the changes is the same as jdk17. 
>> I confirmed the following test and all langtool tests.
>> test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java
>> 
>> Could anyone review the fix please?
>
> Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert backport e9f3e325c274f19b0f6eceea2367708e3be689e

Hello Christoph,

Thank you for your comment.
The problem was reproduced in my environment.
I'm investigating it, and below is the fix.

-                Path javaHome = Path.of(System.getProperty("java.home"));
+                Path javaHome = FileSystems.getDefault().getPath(System.getProperty("java.home"));

-                    legalNoticesDir = Path.of(legalNotices);
+                    legalNoticesDir = FileSystems.getDefault().getPath(legalNotices);

Can I reopen the pullrequest, or should I issue a new pullrequest?

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-1495311482