[jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections

[Andrew Haley]

On Fri, 7 Apr 2023 13:00:28 GMT, Henry <duke at openjdk.org> wrote:

> 8299602: blocked threads with KeepAliveCache.
> 
> I followed the steps that helped me carry out this pull-request.
> 
> REF/: https://mail.openjdk.org/pipermail/jdk-updates-dev/2023-February/020439.html
> 
> Thanks to @GoeLin and @jerboaa

I just looked at https://github.com/openjdk/jdk/pull/10401/files , and I see that it does not change white space in otherwise unchanged files. Please remove all white space-only changes from this patch. It'll make this patch easier to review.

src/java.base/share/classes/sun/net/www/http/KeepAliveCache.java line 55:

> 53: public class KeepAliveCache
> 54:         extends HashMap<KeepAliveKey, ClientVector>
> 55:         implements Runnable {

Suggestion:

    extends HashMap<KeepAliveKey, ClientVector>
    implements Runnable {

src/java.base/share/classes/sun/net/www/http/KeepAliveCache.java line 75:

> 73:     static int getUserKeepAliveSeconds(String type) {
> 74:         int v = AccessController.doPrivileged(
> 75:                 new GetIntegerAction(keepAliveProp + type, -1)).intValue();

Suggestion:

            new GetIntegerAction(keepAliveProp + type, -1)).intValue();


Are these whitespace changes all part of the commit you're backporting?

src/java.base/share/classes/sun/net/www/http/KeepAliveCache.java line 100:

> 98:             result = AccessController.doPrivileged(
> 99:                     new GetIntegerAction("http.maxConnections", MAX_CONNECTIONS))
> 100:                     .intValue();

Suggestion:

                new GetIntegerAction("http.maxConnections", MAX_CONNECTIONS))
                .intValue();

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1825#issuecomment-1500917440
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1825#discussion_r1161125009
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1825#discussion_r1161124910
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1825#discussion_r1161125065