[jdk17u-dev] RFR: JDK-8306768: CodeCache Analytics reports wrong threshold

[Paul Hohensee]

On Tue, 25 Apr 2023 09:06:28 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

> Jcmd CodeCache_Analytics uses own implementation of threshold calculation, allowing an error to creep in, making report invalid. The suggestion is to use the existing method for free ratio calculation. After the fix, the reported values become sane.
> 
> 
> java -XX:InitialCodeCacheSize=1G -XX:ReservedCodeCacheSize=1G ...
> 
> cmd jdk.compiler/com.sun.tools.javac.launcher.Main  Compiler.CodeHeap_Analytics | grep -A 2 "Threshold for method to be considered 'cold'"
> 
> Threshold for method to be considered 'cold':    -2037.960
> min. hotness =   1016
> avg. hotness =   2048
> --
> Threshold for method to be considered 'cold':    -2037.960
> min. hotness =   1016
> avg. hotness =   2048
> --
> Threshold for method to be considered 'cold':    -2037.960
> No hotness data available

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1295#pullrequestreview-1399826254