[jdk17u-dev] RFR: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument [v2]

[Martin Doerr]

On Wed, 26 Apr 2023 12:01:00 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with 17.0.8-oracle.
>> 
>> Does not apply because
>> "8275201: C2: hide klass() accessor from TypeOopPtr and typeKlassPtr subclasses" is not in 17.
>> 
>> The problem fixed by this change is that isa_aryptr() can return NULL.
>> I checked all occurances of this call. Many of them are checked for NULL which 
>> was missing in head before this fix. For inline_string_copy() the check was missing
>> in 17.
>> For many of the other checks, the result is assigned to a variable and then checked, 
>> but then isa_aryptr() is called again. I changed the code to use the checked variable.
>> I hope this makes clear that the check may not be removed :)
>
> Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport 45e4e00981ef8b4bf143afce0889698319273c1d

LGTM. `isa_aryptr()` is used quite often! I hope that it won't break again in the future.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1297#pullrequestreview-1402329948