From mbaesken at openjdk.org Tue Aug 1 07:12:57 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 1 Aug 2023 07:12:57 GMT Subject: [jdk21u] Integrated: 8311921: Inform about MaxExpectedDataSegmentSize in case of pthread_create failures on AIX In-Reply-To: References: Message-ID: On Fri, 28 Jul 2023 11:48:12 GMT, Matthias Baesken wrote: > 8311921: Inform about MaxExpectedDataSegmentSize in case of pthread_create failures on AIX This pull request has now been integrated. Changeset: f020851d Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u/commit/f020851dd8d94c1c91e607b03864fd6518287227 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8311921: Inform about MaxExpectedDataSegmentSize in case of pthread_create failures on AIX Backport-of: aa7367f1ecc5da15591963e56e1435aa7b830f79 ------------- PR: https://git.openjdk.org/jdk21u/pull/23 From mbaesken at openjdk.org Tue Aug 1 07:14:55 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 1 Aug 2023 07:14:55 GMT Subject: [jdk21u] Integrated: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails In-Reply-To: References: Message-ID: <8Pe2YYveLv7FlNrWvdjkURxAXx5A5B3u6od5SQnULtg=.3031a2c4-e106-4304-8f96-1b3d16076f88@github.com> On Mon, 31 Jul 2023 10:29:28 GMT, Matthias Baesken wrote: > 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails This pull request has now been integrated. Changeset: 22e162d6 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u/commit/22e162d62ed0b9b41aa3fbcc47db2994226b4fd9 Stats: 491 lines in 1 file changed: 142 ins; 30 del; 319 mod 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails Backport-of: 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3 ------------- PR: https://git.openjdk.org/jdk21u/pull/27 From thierry.aime at dgfip.finances.gouv.fr Tue Aug 1 07:15:17 2023 From: thierry.aime at dgfip.finances.gouv.fr (thierry.aime at dgfip.finances.gouv.fr) Date: Tue, 1 Aug 2023 09:15:17 +0200 (CEST) Subject: Auto: jdk-updates-dev Digest, Vol 70, Issue 1 Message-ID: <20230801071517.3A17214005411@mespgsa035.dgfip.finances.gouv.fr> Je suis absent du 17 juillet 2023 au 04 ao?t 2023 inclus. En cas d'urgence, contactez Laurent Continsouzas From mbaesken at openjdk.org Tue Aug 1 07:15:49 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 1 Aug 2023 07:15:49 GMT Subject: [jdk21u] Integrated: 8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose In-Reply-To: References: Message-ID: On Wed, 26 Jul 2023 11:43:59 GMT, Matthias Baesken wrote: > 8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose This pull request has now been integrated. Changeset: e9e15202 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u/commit/e9e15202b69f4f38357328676c3ec6b62c1ef404 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose Backport-of: 9eed049098b1ad98f6c061b88f21ca0e7ae3483f ------------- PR: https://git.openjdk.org/jdk21u/pull/15 From mbaesken at openjdk.org Tue Aug 1 07:32:51 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 1 Aug 2023 07:32:51 GMT Subject: [jdk21u] Integrated: 8312395: Improve assertions in growableArray In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 08:06:59 GMT, Matthias Baesken wrote: > 8312395: Improve assertions in growableArray This pull request has now been integrated. Changeset: d65f1c8b Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u/commit/d65f1c8bcb158fbaeb4d99a596b5370ebc9da50e Stats: 12 lines in 1 file changed: 0 ins; 0 del; 12 mod 8312395: Improve assertions in growableArray Backport-of: b772e67e2929afd9f9d6a4b08713e41f891667c0 ------------- PR: https://git.openjdk.org/jdk21u/pull/25 From andrewlu at openjdk.org Tue Aug 1 08:11:01 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 1 Aug 2023 08:11:01 GMT Subject: [jdk11u-dev] Integrated: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests In-Reply-To: <5VovRCf-D-rP7BbJAttcsbC2stG2qo62mXzYjAcKnQk=.b9150708-c12c-4e0d-a936-d7548c0b3d5a@github.com> References: <5VovRCf-D-rP7BbJAttcsbC2stG2qo62mXzYjAcKnQk=.b9150708-c12c-4e0d-a936-d7548c0b3d5a@github.com> Message-ID: <7xq0AxkIecQlNAbYRskujYNhkTkSd1fQVbDDPkiHlQA=.7554f2fc-7c30-41d7-9aac-93f7e1eb1e64@github.com> On Thu, 27 Jul 2023 06:58:23 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. > test/jdk/sun/net/www/protocol/https/ChunkedOutputStream.java > 'InetAddress loopback = InetAddress.getLoopbackAddress();' is added because it's miss. > test/jdk/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java > Resolved due to context. Copyright > test/jdk/sun/net/www/protocol/https/HttpsURLConnection/TunnelProxy.java > Resolved due to context. Copyright This pull request has now been integrated. Changeset: 894613f8 Author: Andrew Lu Committer: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/894613f86f60bcacf7bd5366ebf88d0f24710730 Stats: 1696 lines in 7 files changed: 126 ins; 1469 del; 101 mod 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests Reviewed-by: phh Backport-of: 7621fa37efb2739b953da1cda87dca4762b5bd0c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2059 From andrewlu at openjdk.org Tue Aug 1 08:13:06 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 1 Aug 2023 08:13:06 GMT Subject: [jdk11u-dev] Integrated: 8307128: Open source some drag and drop tests 4 In-Reply-To: References: Message-ID: <2cJPI-I1mnAsBiUjQK6akKuiP9S0HTYNqyoV5qio60E=.57f7019e-9aca-4600-a21d-60694dbf9af2@github.com> On Thu, 27 Jul 2023 08:26:30 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. > test/jdk/java/awt/dnd/MouseExitGestureTriggerTest.java > add backport for [JDK-8307799](https://bugs.openjdk.org/browse/JDK-8307799), Without this fix test will fail. > other backport clean. This pull request has now been integrated. Changeset: 7cf5b10c Author: Andrew Lu Committer: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/7cf5b10c217eeb6340f9421e3c6db28b953a1a79 Stats: 1680 lines in 5 files changed: 1680 ins; 0 del; 0 mod 8307128: Open source some drag and drop tests 4 8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg `@requires` clause Reviewed-by: phh Backport-of: 98294242a94c611e2a713c2d520e59dd873ae4a0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2060 From clanger at openjdk.org Tue Aug 1 08:22:58 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 1 Aug 2023 08:22:58 GMT Subject: [jdk17u-dev] RFR: 8283710: JVMTI: Use BitSet for object marking [v2] In-Reply-To: References: Message-ID: On Thu, 20 Jul 2023 15:46:06 GMT, Roman Kennke wrote: >> This is a backport of [JDK-8283710](https://bugs.openjdk.org/browse/JDK-8283710) to 17u. >> >> There have been contextual differences around the declaration of _bitset and corresponding contextual differences in the constructor: the field _dead_objects did not exist in jdk19, but does exist in jdk17u. There also have been differences in the large block that has been removed (the whole of ObjectMarker and related code). Other than that, the backport has been clean and straightforward. >> >> Testing: >> - [x] tier1 >> - [x] tier2 >> - [x] serviceability/jvmti >> - [x] serviceability/jdwp >> - [x] vmTestbase/nsk/jvmti >> - [x] vmTestbase/msk/jdwp > > Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: > > Fix copyright and include guards in jfrbitset.hpp I will run this through our nigthlies to verify... ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1602#issuecomment-1659810214 From mbaesken at openjdk.org Tue Aug 1 08:24:54 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 1 Aug 2023 08:24:54 GMT Subject: [jdk21u] RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v3] In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 12:47:07 GMT, Christoph Langer wrote: >> Hi all, >> >> This pull request contains a backport of [JDK-8308609](https://bugs.openjdk.org/browse/JDK-8308609), commit [44a8aa06](https://github.com/openjdk/jdk/commit/44a8aa0691f046d720a789a89c9039a010658f0c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Andrew Haley on 16 Jun 2023 and was reviewed by Alan Bateman. >> >> Thanks! > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > JDK-8310586 - add back exclusion Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u/pull/22#pullrequestreview-1556425289 From clanger at openjdk.org Tue Aug 1 08:30:48 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 1 Aug 2023 08:30:48 GMT Subject: [jdk17u-dev] RFR: 8309746: Reconfigure check should include make/conf/version-numbers.conf In-Reply-To: References: Message-ID: On Wed, 26 Jul 2023 11:53:38 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve build system support. > > The uncleanliness comes from the copyright dates conflict. > > Additional testing: > - [x] Checking that reconfigure message triggers after touching `make/conf/version-numbers.conf` If it's only about copyright years, you can mark it as clean. Not sure if I'm allowed to do it but I try: ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1626#issuecomment-1659820870 From mbaesken at openjdk.org Tue Aug 1 08:30:47 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 1 Aug 2023 08:30:47 GMT Subject: [jdk17u-dev] RFR: 8309746: Reconfigure check should include make/conf/version-numbers.conf In-Reply-To: References: Message-ID: On Wed, 26 Jul 2023 11:53:38 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve build system support. > > The uncleanliness comes from the copyright dates conflict. > > Additional testing: > - [x] Checking that reconfigure message triggers after touching `make/conf/version-numbers.conf` Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1626#pullrequestreview-1556435238 From aleonard at openjdk.org Tue Aug 1 08:32:05 2023 From: aleonard at openjdk.org (Andrew Leonard) Date: Tue, 1 Aug 2023 08:32:05 GMT Subject: [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image In-Reply-To: References: Message-ID: On Fri, 28 Jul 2023 15:56:24 GMT, Andrew Leonard wrote: > Backport 8273092: Sort classlist in JDK image > to jdk17u so that classlist order is deterministic for reproducible builds. > > The original needed modifying, because jdk17u does not dump ":id" Klass id, it just dumps the class/lambda name. Hi @iklam , would you be able to review this backport of your original classlist sorting please? thanks ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1632#issuecomment-1659825574 From clanger at openjdk.org Tue Aug 1 08:48:55 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 1 Aug 2023 08:48:55 GMT Subject: [jdk11u-dev] RFR: 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList In-Reply-To: <9_EImB9z4JU3XECid1SVg9Mxmz2sOQgf5ODwl-RK8o8=.861a21a6-1334-406c-b5b1-5af7180a7412@github.com> References: <9_EImB9z4JU3XECid1SVg9Mxmz2sOQgf5ODwl-RK8o8=.861a21a6-1334-406c-b5b1-5af7180a7412@github.com> Message-ID: On Tue, 18 Jul 2023 12:23:42 GMT, sendaoYan wrote: > 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList > > Reviewed-by: Yi Yang @sendaoYan you should not integrate before obtaining JBS approval. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2049#issuecomment-1659854368 From robm at openjdk.org Tue Aug 1 11:00:52 2023 From: robm at openjdk.org (Rob McKenna) Date: Tue, 1 Aug 2023 11:00:52 GMT Subject: [jdk21u] RFR: Merge jdk21:master Message-ID: Merge jdk21 ------------- Commit messages: - Merge - 8313316: Disable runtime/ErrorHandling/MachCodeFramesInErrorFile.java on ppc64le - 8300937: Update nroff pages in JDK 21 before RC - 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86 - 8313241: Temporarily disable "malformed control flow" assert to reduce noise - 8313250: Exclude java/foreign/TestByteBuffer.java on AIX - 8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086 - 8313208: ProblemList java/util/concurrent/tck/JSR166TestCase.java on select platforms - 8313193: ProblemList java/util/concurrent/SynchronousQueue/Fairness.java on X64 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk21u/pull/30/files Stats: 176 lines in 33 files changed: 45 ins; 62 del; 69 mod Patch: https://git.openjdk.org/jdk21u/pull/30.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/30/head:pull/30 PR: https://git.openjdk.org/jdk21u/pull/30 From robm at openjdk.org Tue Aug 1 11:13:03 2023 From: robm at openjdk.org (Rob McKenna) Date: Tue, 1 Aug 2023 11:13:03 GMT Subject: [jdk21u] Integrated: Merge jdk21:master In-Reply-To: References: Message-ID: <29-1SC0UCuErqZPXkpONjyIWJGd9tiYR9yPZM0Wo_fE=.c3ed2d01-9c2a-4e07-bc0c-e74d7751653c@github.com> On Tue, 1 Aug 2023 10:56:10 GMT, Rob McKenna wrote: > Merge jdk21 This pull request has now been integrated. Changeset: 5c6cd061 Author: Rob McKenna URL: https://git.openjdk.org/jdk21u/commit/5c6cd061779f42a2872a2568fb1b2af08f550e79 Stats: 176 lines in 33 files changed: 45 ins; 62 del; 69 mod Merge ------------- PR: https://git.openjdk.org/jdk21u/pull/30 From robm at openjdk.org Tue Aug 1 11:13:02 2023 From: robm at openjdk.org (Rob McKenna) Date: Tue, 1 Aug 2023 11:13:02 GMT Subject: [jdk21u] RFR: Merge jdk21:master [v2] In-Reply-To: References: Message-ID: > Merge jdk21 Rob McKenna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision: - Merge - 8312395: Improve assertions in growableArray Backport-of: b772e67e2929afd9f9d6a4b08713e41f891667c0 - 8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose Backport-of: 9eed049098b1ad98f6c061b88f21ca0e7ae3483f - 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails Backport-of: 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3 - 8311921: Inform about MaxExpectedDataSegmentSize in case of pthread_create failures on AIX Backport-of: aa7367f1ecc5da15591963e56e1435aa7b830f79 - 8311917: MAP_FAILED definition seems to be obsolete in src/java.desktop/unix/native/common/awt/fontpath.c Backport-of: a38a421f62efbcc0fc9c6a08738b5f0ab38a4594 - 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074 Backport-of: a9d21c61fb12a11e18c6bb8aa903e5a8e42473f1 - 8309746: Reconfigure check should include make/conf/version-numbers.conf Backport-of: 955fc2fabafc4c4d79d137bf86194228d5cf8ad8 - 8311026: Some G1 specific tests do not set -XX:+UseG1GC Backport-of: a7d168b522bb05345a40ae1fb18942ba663d3182 - 8311285: report some fontconfig related environment variables in hs_err file Backport-of: 0ef03f122866f010ebf50683097e9b92e41cdaad - ... and 10 more: https://git.openjdk.org/jdk21u/compare/7666b90f...d8a552cd ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/30/files - new: https://git.openjdk.org/jdk21u/pull/30/files/d8a552cd..d8a552cd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=30&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=30&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/30.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/30/head:pull/30 PR: https://git.openjdk.org/jdk21u/pull/30 From alanb at openjdk.org Tue Aug 1 11:23:47 2023 From: alanb at openjdk.org (Alan Bateman) Date: Tue, 1 Aug 2023 11:23:47 GMT Subject: [jdk21u] RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v3] In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 14:11:25 GMT, Christoph Langer wrote: > Yes, it's on my list. However, I didn't want to squeeze it in here. I'm currently running tests for this PR. Okay, I'm mostly wondering about the change to ProblemList-Virtual.txt to exclude it only on linux-x64, it should be all platforms. There is work required to improve the robustness that will surface when this test is run with JTREG_TEST_THREAD_FACTORY=Virtual, it's not specific to linux-x64. I suspect Dan excluded only on that platform because it was only initially seen on that platform. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/22#issuecomment-1660114394 From shade at openjdk.org Tue Aug 1 12:47:58 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 1 Aug 2023 12:47:58 GMT Subject: [jdk17u-dev] RFR: 8309746: Reconfigure check should include make/conf/version-numbers.conf In-Reply-To: References: Message-ID: On Wed, 26 Jul 2023 11:53:38 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve build system support. > > The uncleanliness comes from the copyright dates conflict. > > Additional testing: > - [x] Checking that reconfigure message triggers after touching `make/conf/version-numbers.conf` Reviews are here, push approval is here. Testing is clean. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1626#issuecomment-1660239093 From shade at openjdk.org Tue Aug 1 12:47:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 1 Aug 2023 12:47:59 GMT Subject: [jdk17u-dev] Integrated: 8309746: Reconfigure check should include make/conf/version-numbers.conf In-Reply-To: References: Message-ID: On Wed, 26 Jul 2023 11:53:38 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve build system support. > > The uncleanliness comes from the copyright dates conflict. > > Additional testing: > - [x] Checking that reconfigure message triggers after touching `make/conf/version-numbers.conf` This pull request has now been integrated. Changeset: d44c4461 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/d44c4461d2006c75d9ae9a734c92a0924099440e Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod 8309746: Reconfigure check should include make/conf/version-numbers.conf Reviewed-by: mbaesken Backport-of: 955fc2fabafc4c4d79d137bf86194228d5cf8ad8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1626 From dhanalla at openjdk.org Tue Aug 1 14:43:48 2023 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Tue, 1 Aug 2023 14:43:48 GMT Subject: [jdk11u-dev] Integrated: 8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance In-Reply-To: References: Message-ID: On Thu, 13 Jul 2023 17:38:23 GMT, Dhamoder Nalla wrote: > Backport of https://github.com/openjdk/jdk/pull/13430 > > Issue: > [JDK-8305763](https://bugs.openjdk.org/browse/JDK-8305763): Parsing a URI with an underscore goes through a silent exception, negatively impacting performance This pull request has now been integrated. Changeset: adc74777 Author: Dhamoder Nalla Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/adc74777b3790486adc2cd03fd0a154095e95cf4 Stats: 29 lines in 1 file changed: 20 ins; 0 del; 9 mod 8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance Backport-of: 749d4801937ac145f945765f0ba0980bbccf384f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2041 From tsteele at openjdk.org Tue Aug 1 15:23:52 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Tue, 1 Aug 2023 15:23:52 GMT Subject: [jdk17u-dev] RFR: 8307603: [AIX] Broken build after JDK-8307301 In-Reply-To: References: Message-ID: On Tue, 25 Jul 2023 17:18:00 GMT, Tyler Steele wrote: > Fixes this build error--associated with Harfbuzz--in jdk17. T1 Testing looks good. JBS approval received. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1624#issuecomment-1660546027 From tsteele at openjdk.org Tue Aug 1 15:24:46 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Tue, 1 Aug 2023 15:24:46 GMT Subject: [jdk11u-dev] RFR: 8307603: [AIX] Broken build after JDK-8307301 In-Reply-To: References: Message-ID: On Wed, 26 Jul 2023 20:41:58 GMT, Tyler Steele wrote: > Fixes this build error--associated with Harfbuzz--in jdk11. Approval received. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2058#issuecomment-1660547609 From clanger at openjdk.org Tue Aug 1 15:41:58 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 1 Aug 2023 15:41:58 GMT Subject: [jdk21u] RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v4] In-Reply-To: References: Message-ID: <5UR0goGdm6tOsiqpjgd68qoqG4-J4J-afahh_gCrB3o=.e4e0de7d-f3f9-4c08-91b1-174b52af36f9@github.com> > Hi all, > > This pull request contains a backport of [JDK-8308609](https://bugs.openjdk.org/browse/JDK-8308609), commit [44a8aa06](https://github.com/openjdk/jdk/commit/44a8aa0691f046d720a789a89c9039a010658f0c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew Haley on 16 Jun 2023 and was reviewed by Alan Bateman. > > Thanks! Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into RealCLanger-backport-44a8aa06 - JDK-8310586 - add back exclusion - Remove test exclusion from test/jdk/ProblemList-Xcomp.txt - Backport 44a8aa0691f046d720a789a89c9039a010658f0c ------------- Changes: https://git.openjdk.org/jdk21u/pull/22/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=22&range=03 Stats: 112 lines in 8 files changed: 42 ins; 29 del; 41 mod Patch: https://git.openjdk.org/jdk21u/pull/22.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/22/head:pull/22 PR: https://git.openjdk.org/jdk21u/pull/22 From duke at openjdk.org Tue Aug 1 16:26:55 2023 From: duke at openjdk.org (sendaoYan) Date: Tue, 1 Aug 2023 16:26:55 GMT Subject: [jdk11u-dev] Integrated: 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList In-Reply-To: <9_EImB9z4JU3XECid1SVg9Mxmz2sOQgf5ODwl-RK8o8=.861a21a6-1334-406c-b5b1-5af7180a7412@github.com> References: <9_EImB9z4JU3XECid1SVg9Mxmz2sOQgf5ODwl-RK8o8=.861a21a6-1334-406c-b5b1-5af7180a7412@github.com> Message-ID: On Tue, 18 Jul 2023 12:23:42 GMT, sendaoYan wrote: > 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList > > Reviewed-by: Yi Yang This pull request has now been integrated. Changeset: 440eea17 Author: sendaoYan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/440eea17477562822b5c615a860e6a30e96f8c25 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList Reviewed-by: serb Backport-of: 1e0184d142deb18e719fc28814a293b44bab6c63 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2049 From tsteele at openjdk.org Tue Aug 1 17:10:07 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Tue, 1 Aug 2023 17:10:07 GMT Subject: [jdk17u-dev] Integrated: 8307603: [AIX] Broken build after JDK-8307301 In-Reply-To: References: Message-ID: <8H90hkV9bwucppztk6n6SZcXlmoS8HpGA2zGh_SlLQE=.3279a93a-6daa-45cd-9caf-929d5a6fa531@github.com> On Tue, 25 Jul 2023 17:18:00 GMT, Tyler Steele wrote: > Fixes this build error--associated with Harfbuzz--in jdk17. T1 Testing looks good. This pull request has now been integrated. Changeset: b4c8cc8d Author: Tyler Steele Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/b4c8cc8d16a6926825e35c47ae19216b8fea3b37 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8307603: [AIX] Broken build after JDK-8307301 Backport-of: bb3e44d8b604b4e3facc4f49f625cc0b7ff2abd7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1624 From tsteele at openjdk.org Tue Aug 1 17:10:04 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Tue, 1 Aug 2023 17:10:04 GMT Subject: [jdk11u-dev] Integrated: 8307603: [AIX] Broken build after JDK-8307301 In-Reply-To: References: Message-ID: On Wed, 26 Jul 2023 20:41:58 GMT, Tyler Steele wrote: > Fixes this build error--associated with Harfbuzz--in jdk11. This pull request has now been integrated. Changeset: 0416d4cc Author: Tyler Steele Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/0416d4cc8add706cd70bba5128d460f63c333bff Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8307603: [AIX] Broken build after JDK-8307301 Reviewed-by: stuefe Backport-of: bb3e44d8b604b4e3facc4f49f625cc0b7ff2abd7 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2058 From shade at openjdk.org Tue Aug 1 18:18:54 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 1 Aug 2023 18:18:54 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter In-Reply-To: References: Message-ID: On Fri, 28 Jul 2023 08:18:46 GMT, Xin Liu wrote: > This patch is *NOT* a clean backport. The logic part is exactly the same, but I have to adjust code in the following parts: > 1. change from KVHashtable to ResourceHashtable because we want to use resourceArea instead of C_HEAP. > 2. we added lambda-API iterator() to ResourceHashtable. Instead of backporting all patches from TIP, we just reuse the original iterator(). > > > template > void iterate(Function function) const { // lambda enabled API > > > Testing: > jdk-test1 tests including gtest. > Manually check there's no malloc/free in runtime. Before I review the change, should https://bugs.openjdk.org/browse/JDK-8294075 be backported as well? Is JDK-8294075 caused by this change? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#issuecomment-1660849206 From shade at openjdk.org Tue Aug 1 19:39:56 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 1 Aug 2023 19:39:56 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter In-Reply-To: References: Message-ID: On Fri, 28 Jul 2023 08:18:46 GMT, Xin Liu wrote: > This patch is *NOT* a clean backport. The logic part is exactly the same, but I have to adjust code in the following parts: > 1. change from KVHashtable to ResourceHashtable because we want to use resourceArea instead of C_HEAP. > 2. we added lambda-API iterator() to ResourceHashtable. Instead of backporting all patches from TIP, we just reuse the original iterator(). > > > template > void iterate(Function function) const { // lambda enabled API > > > Testing: > jdk-test1 tests including gtest. > Manually check there's no malloc/free in runtime. Looked through the code, I have comments. src/hotspot/share/logging/logAsyncWriter.hpp line 63: > 61: using AsyncLogMap = ResourceHashtable, > 62: primitive_equals, 17, > 63: ResourceObj::C_HEAP, mtLogging>; These arguments should be on the new lines each, I think? This would match the upstream code better. src/hotspot/share/utilities/resourceHash.hpp line 187: > 185: template > 186: void iterate(ITER* iter) const { > 187: auto function = [&] (K& k, V& v) { Can we avoid doing this by making a named `struct` implementing `do_entry` for every use? I realize that would deviate the _uses_ from the upstream, but we would not be changing the shared code, which would be safer for generic code that does not use any of async logging *and* uses older toolchains. This hunk effectively backports https://bugs.openjdk.org/browse/JDK-8276789, which seems to imply the need to check this works well with different toolchains. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1630#pullrequestreview-1557685667 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#discussion_r1281063416 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#discussion_r1281066509 From xliu at openjdk.org Tue Aug 1 20:05:52 2023 From: xliu at openjdk.org (Xin Liu) Date: Tue, 1 Aug 2023 20:05:52 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter In-Reply-To: References: Message-ID: On Tue, 1 Aug 2023 18:15:49 GMT, Aleksey Shipilev wrote: > Before I review the change, should https://bugs.openjdk.org/browse/JDK-8294075 be backported as well? Is JDK-8294075 caused by this change? we found that it doesn't work. we still have intermittent failure. https://bugs.openjdk.org/browse/JDK-8309067 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#issuecomment-1660999611 From xliu at openjdk.org Tue Aug 1 20:11:56 2023 From: xliu at openjdk.org (Xin Liu) Date: Tue, 1 Aug 2023 20:11:56 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter In-Reply-To: References: Message-ID: On Tue, 1 Aug 2023 19:33:39 GMT, Aleksey Shipilev wrote: >> This patch is *NOT* a clean backport. The logic part is exactly the same, but I have to adjust code in the following parts: >> 1. change from KVHashtable to ResourceHashtable because we want to use resourceArea instead of C_HEAP. >> 2. we added lambda-API iterator() to ResourceHashtable. Instead of backporting all patches from TIP, we just reuse the original iterator(). >> >> >> template >> void iterate(Function function) const { // lambda enabled API >> >> >> Testing: >> jdk-test1 tests including gtest. >> Manually check there's no malloc/free in runtime. > > src/hotspot/share/utilities/resourceHash.hpp line 187: > >> 185: template >> 186: void iterate(ITER* iter) const { >> 187: auto function = [&] (K& k, V& v) { > > Can we avoid doing this by making a named `struct` implementing `do_entry` for every use? I realize that would deviate the _uses_ from the upstream, but we would not be changing the shared code, which would be safer for generic code that does not use any of async logging *and* uses older toolchains. > > This hunk effectively backports https://bugs.openjdk.org/browse/JDK-8276789, which seems to imply the need to check this works well with different toolchains. yes, I can rewrite lambdas using old-style functor. to backport [JDK-8276789](https://bugs.openjdk.org/browse/JDK-8276789), we also need to backport bucket_at(), table()/table_size() beforehand. I take your advice. my approach skips more verification and it's not good. I will use functor. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#discussion_r1281104422 From szaldana at openjdk.org Tue Aug 1 20:47:15 2023 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 1 Aug 2023 20:47:15 GMT Subject: [jdk17u-dev] RFR: 8300259: Add test coverage for processing of pending block files in signed JARs Message-ID: Hi all, This pull request contains a backport of commit [c129ce46](https://github.com/openjdk/jdk/commit/c129ce4660e6c9b5365c8bf89fb916e2a7c28e98) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Eirik Bjorsnos on 6 Feb 2023 and was reviewed by Weijun Wang. Thanks! ------------- Commit messages: - Backport c129ce4660e6c9b5365c8bf89fb916e2a7c28e98 Changes: https://git.openjdk.org/jdk17u-dev/pull/1634/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1634&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300259 Stats: 173 lines in 1 file changed: 173 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1634.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1634/head:pull/1634 PR: https://git.openjdk.org/jdk17u-dev/pull/1634 From gcao at openjdk.org Wed Aug 2 01:58:02 2023 From: gcao at openjdk.org (Gui Cao) Date: Wed, 2 Aug 2023 01:58:02 GMT Subject: [jdk17u-dev] RFR: 8311923: TestIRMatching.java fails on RISC-V [v4] In-Reply-To: <_1ztpBH-PnuvR07PO9Sh0NiR1h0N78PGeHXilnFguGk=.4c2c2ba9-28ef-4f44-917c-5d4992e66727@github.com> References: <_1ztpBH-PnuvR07PO9Sh0NiR1h0N78PGeHXilnFguGk=.4c2c2ba9-28ef-4f44-917c-5d4992e66727@github.com> Message-ID: On Wed, 26 Jul 2023 15:53:01 GMT, Paul Hohensee wrote: >> Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into backport-JDK-8311923 >> - Merge remote-tracking branch 'upstream/master' into backport-JDK-8311923 >> - Merge branch 'master' into backport-JDK-8311923 >> - 8311923: TestIRMatching.java fails on RISC-V > > Marked as reviewed by phh (Reviewer). @phohensee @RealFYang Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1611#issuecomment-1661368706 From gcao at openjdk.org Wed Aug 2 02:01:57 2023 From: gcao at openjdk.org (Gui Cao) Date: Wed, 2 Aug 2023 02:01:57 GMT Subject: [jdk17u-dev] Integrated: 8311923: TestIRMatching.java fails on RISC-V In-Reply-To: References: Message-ID: On Fri, 21 Jul 2023 07:26:55 GMT, Gui Cao wrote: > Hi, I would like to backport this to jdk17u-dev to make TestIRMatching.java test work on Linux RISC-V platform. > The backport is not clean because jdk17u-dev has no [JDK-8280378](https://bugs.openjdk.org/browse/JDK-8280378) `test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java` passed with fastdebug build using unmatched board. This pull request has now been integrated. Changeset: c486b9be Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk17u-dev/commit/c486b9be7400f5ce55ca6db8f8beaca247951a77 Stats: 11 lines in 2 files changed: 0 ins; 0 del; 11 mod 8311923: TestIRMatching.java fails on RISC-V Reviewed-by: phh, fyang Backport-of: e7adbdb1f1506b82392907f7e4a5c8882d3198eb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1611 From andrewlu at openjdk.org Wed Aug 2 05:37:17 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 2 Aug 2023 05:37:17 GMT Subject: [jdk11u-dev] RFR: 8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport b54c4a33c69e16adf5b85b80b8deb4ded2ed074d Changes: https://git.openjdk.org/jdk11u-dev/pull/2063/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2063&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299713 Stats: 64 lines in 1 file changed: 40 ins; 5 del; 19 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2063.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2063/head:pull/2063 PR: https://git.openjdk.org/jdk11u-dev/pull/2063 From thartmann at openjdk.org Wed Aug 2 06:42:22 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 2 Aug 2023 06:42:22 GMT Subject: [jdk21u] RFR: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere [v2] In-Reply-To: <7R3SYKAtEFwyCui24T3qSStQ4-oju7P6QkFVk7IO1oM=.610c212c-2589-45ba-8a08-249080439d89@github.com> References: <7R3SYKAtEFwyCui24T3qSStQ4-oju7P6QkFVk7IO1oM=.610c212c-2589-45ba-8a08-249080439d89@github.com> Message-ID: > Parsing of `-XX:CompileOnly=` hits a `ShouldNotReachHere` for `,` and ` ` arguments. The fix is to remove the assumption that `className` can only be null for `method_sep` because the parsing loop also exits on `,` and ` `: > > https://github.com/openjdk/jdk21u/blob/384a8b85a7266b920242ea73baf578577ca588ec/src/hotspot/share/compiler/compilerOracle.cpp#L1032-L1037 > > Instead, a missing class name is handled as "Any" class match in all the cases. > > I'm fixing this in JDK 21u because the issue was fixed in in JDK 22 as a side effect of [JDK-8027711](https://bugs.openjdk.org/browse/JDK-8027711). The VM now prints an error: > > > CompileOnly: An error occurred during parsing > Line: ',' > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > Thanks, > Tobias Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision: Change NULL to nullptr ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/19/files - new: https://git.openjdk.org/jdk21u/pull/19/files/51e2ed8e..0bfc5ce1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=19&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=19&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/19.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/19/head:pull/19 PR: https://git.openjdk.org/jdk21u/pull/19 From tholenstein at openjdk.org Wed Aug 2 06:42:24 2023 From: tholenstein at openjdk.org (Tobias Holenstein) Date: Wed, 2 Aug 2023 06:42:24 GMT Subject: [jdk21u] RFR: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere [v2] In-Reply-To: References: <7R3SYKAtEFwyCui24T3qSStQ4-oju7P6QkFVk7IO1oM=.610c212c-2589-45ba-8a08-249080439d89@github.com> Message-ID: On Wed, 2 Aug 2023 06:37:04 GMT, Tobias Hartmann wrote: >> Parsing of `-XX:CompileOnly=` hits a `ShouldNotReachHere` for `,` and ` ` arguments. The fix is to remove the assumption that `className` can only be null for `method_sep` because the parsing loop also exits on `,` and ` `: >> >> https://github.com/openjdk/jdk21u/blob/384a8b85a7266b920242ea73baf578577ca588ec/src/hotspot/share/compiler/compilerOracle.cpp#L1032-L1037 >> >> Instead, a missing class name is handled as "Any" class match in all the cases. >> >> I'm fixing this in JDK 21u because the issue was fixed in in JDK 22 as a side effect of [JDK-8027711](https://bugs.openjdk.org/browse/JDK-8027711). The VM now prints an error: >> >> >> CompileOnly: An error occurred during parsing >> Line: ',' >> Error: Could not create the Java Virtual Machine. >> Error: A fatal exception has occurred. Program will exit. >> >> >> Thanks, >> Tobias > > Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision: > > Change NULL to nullptr Looks good to me Marked as reviewed by tholenstein (no project role). src/hotspot/share/compiler/compilerOracle.cpp line 1053: > 1051: } > 1052: > 1053: if (className == NULL || className[0] == '\0') { Suggestion: if (className == nullptr || className[0] == '\0') { ------------- PR Review: https://git.openjdk.org/jdk21u/pull/19#pullrequestreview-1558292398 PR Review: https://git.openjdk.org/jdk21u/pull/19#pullrequestreview-1558296098 PR Review Comment: https://git.openjdk.org/jdk21u/pull/19#discussion_r1281454065 From thartmann at openjdk.org Wed Aug 2 06:42:25 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 2 Aug 2023 06:42:25 GMT Subject: [jdk21u] RFR: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere In-Reply-To: <7R3SYKAtEFwyCui24T3qSStQ4-oju7P6QkFVk7IO1oM=.610c212c-2589-45ba-8a08-249080439d89@github.com> References: <7R3SYKAtEFwyCui24T3qSStQ4-oju7P6QkFVk7IO1oM=.610c212c-2589-45ba-8a08-249080439d89@github.com> Message-ID: On Thu, 27 Jul 2023 12:01:05 GMT, Tobias Hartmann wrote: > Parsing of `-XX:CompileOnly=` hits a `ShouldNotReachHere` for `,` and ` ` arguments. The fix is to remove the assumption that `className` can only be null for `method_sep` because the parsing loop also exits on `,` and ` `: > > https://github.com/openjdk/jdk21u/blob/384a8b85a7266b920242ea73baf578577ca588ec/src/hotspot/share/compiler/compilerOracle.cpp#L1032-L1037 > > Instead, a missing class name is handled as "Any" class match in all the cases. > > I'm fixing this in JDK 21u because the issue was fixed in in JDK 22 as a side effect of [JDK-8027711](https://bugs.openjdk.org/browse/JDK-8027711). The VM now prints an error: > > > CompileOnly: An error occurred during parsing > Line: ',' > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > Thanks, > Tobias Thanks for the review, Toby. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/19#issuecomment-1661581099 From tholenstein at openjdk.org Wed Aug 2 06:42:27 2023 From: tholenstein at openjdk.org (Tobias Holenstein) Date: Wed, 2 Aug 2023 06:42:27 GMT Subject: [jdk21u] RFR: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere [v2] In-Reply-To: References: <7R3SYKAtEFwyCui24T3qSStQ4-oju7P6QkFVk7IO1oM=.610c212c-2589-45ba-8a08-249080439d89@github.com> Message-ID: On Wed, 2 Aug 2023 06:30:44 GMT, Tobias Holenstein wrote: >> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision: >> >> Change NULL to nullptr > > src/hotspot/share/compiler/compilerOracle.cpp line 1053: > >> 1051: } >> 1052: >> 1053: if (className == NULL || className[0] == '\0') { > > Suggestion: > > if (className == nullptr || className[0] == '\0') { I think it should be `nullptr` ------------- PR Review Comment: https://git.openjdk.org/jdk21u/pull/19#discussion_r1281454912 From thartmann at openjdk.org Wed Aug 2 06:42:28 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 2 Aug 2023 06:42:28 GMT Subject: [jdk21u] RFR: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere [v2] In-Reply-To: References: <7R3SYKAtEFwyCui24T3qSStQ4-oju7P6QkFVk7IO1oM=.610c212c-2589-45ba-8a08-249080439d89@github.com> Message-ID: On Wed, 2 Aug 2023 06:31:50 GMT, Tobias Holenstein wrote: >> src/hotspot/share/compiler/compilerOracle.cpp line 1053: >> >>> 1051: } >>> 1052: >>> 1053: if (className == NULL || className[0] == '\0') { >> >> Suggestion: >> >> if (className == nullptr || className[0] == '\0') { > > I think it should be `nullptr` Good catch! Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk21u/pull/19#discussion_r1281456027 From thartmann at openjdk.org Wed Aug 2 06:42:30 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 2 Aug 2023 06:42:30 GMT Subject: [jdk21u] Integrated: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere In-Reply-To: <7R3SYKAtEFwyCui24T3qSStQ4-oju7P6QkFVk7IO1oM=.610c212c-2589-45ba-8a08-249080439d89@github.com> References: <7R3SYKAtEFwyCui24T3qSStQ4-oju7P6QkFVk7IO1oM=.610c212c-2589-45ba-8a08-249080439d89@github.com> Message-ID: <2GTcE8D-RBlgQfQkLrdliD_XjSbdxDSuRJSTE18O260=.64de352d-562e-4261-ab3f-e4d92c54d8cb@github.com> On Thu, 27 Jul 2023 12:01:05 GMT, Tobias Hartmann wrote: > Parsing of `-XX:CompileOnly=` hits a `ShouldNotReachHere` for `,` and ` ` arguments. The fix is to remove the assumption that `className` can only be null for `method_sep` because the parsing loop also exits on `,` and ` `: > > https://github.com/openjdk/jdk21u/blob/384a8b85a7266b920242ea73baf578577ca588ec/src/hotspot/share/compiler/compilerOracle.cpp#L1032-L1037 > > Instead, a missing class name is handled as "Any" class match in all the cases. > > I'm fixing this in JDK 21u because the issue was fixed in in JDK 22 as a side effect of [JDK-8027711](https://bugs.openjdk.org/browse/JDK-8027711). The VM now prints an error: > > > CompileOnly: An error occurred during parsing > Line: ',' > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > Thanks, > Tobias This pull request has now been integrated. Changeset: 6f76b65a Author: Tobias Hartmann URL: https://git.openjdk.org/jdk21u/commit/6f76b65ace50b2361221dddab120e91b057497c1 Stats: 67 lines in 2 files changed: 52 ins; 11 del; 4 mod 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere Reviewed-by: kvn, tholenstein ------------- PR: https://git.openjdk.org/jdk21u/pull/19 From myano at openjdk.org Wed Aug 2 07:23:48 2023 From: myano at openjdk.org (Masanori Yano) Date: Wed, 2 Aug 2023 07:23:48 GMT Subject: [jdk11u-dev] RFR: 8213536: Update ProblemList for Linux In-Reply-To: References: Message-ID: <--DKVbPCsSaj8nQTBIjXL2HYGVRop7iBcP5aUUgS0gM=.2dfe5388-89e5-466c-8b6f-a15bdb1bbcb8@github.com> On Thu, 29 Jun 2023 10:03:08 GMT, Masanori Yano wrote: > I would like to backport JDK-8213536. However, since some backports were done without modifying the ProblemList, they cannot be backported to clean. > > The following tests were backported without exclusions, so ProblemList should not be backported. > > * java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java > https://bugs.openjdk.org/browse/JDK-8144030 > https://github.com/openjdk/jdk11u-dev/pull/1688 > > * java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java > https://bugs.openjdk.org/browse/JDK-8030121 > https://github.com/openjdk/jdk11u-dev/pull/1455 > > * javax/swing/border/TestTitledBorderLeak.java > https://bugs.openjdk.org/browse/JDK-8213531 > https://github.com/openjdk/jdk11u-dev/pull/1817 > > * javax/swing/JTree/8003400/Test8003400.java > https://bugs.openjdk.org/browse/JDK-8197560 > https://github.com/openjdk/jdk11u-dev/pull/374 > > * javax/swing/JPopupMenu/6583251/bug6583251.java > https://bugs.openjdk.org/browse/JDK-8217377 > https://github.com/openjdk/jdk11u-dev/pull/378 > > The following tests only exclude linux because macos exclusion has not yet been backported. > > * javax/swing/GraphicsConfigNotifier/StalePreferredSize.java > https://bugs.openjdk.org/browse/JDK-8213138 > https://github.com/openjdk/jdk/commit/2215c4c893e00321a96de56b322ec682173bfee9 > > The new exclusions are tests of fixes that are still excluded in the mainline repository or are not backported, as shown below. > > * java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java > https://bugs.openjdk.org/browse/JDK-8193543 > https://github.com/openjdk/jdk/pull/8346 > > * javax/swing/text/DefaultCaret/HidingSelection/MultiSelectionTest.java > https://bugs.openjdk.org/browse/JDK-8299077 > https://github.com/openjdk/jdk20/pull/68 No one has replied to this PR for a month. Can someone review it? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2003#issuecomment-1661645328 From thierry.aime at dgfip.finances.gouv.fr Wed Aug 2 07:24:20 2023 From: thierry.aime at dgfip.finances.gouv.fr (thierry.aime at dgfip.finances.gouv.fr) Date: Wed, 2 Aug 2023 09:24:20 +0200 (CEST) Subject: Auto: jdk-updates-dev Digest, Vol 70, Issue 10 Message-ID: <20230802072420.9EAB114005038@mespgsa035.dgfip.finances.gouv.fr> Je suis absent du 17 juillet 2023 au 04 ao?t 2023 inclus. En cas d'urgence, contactez Laurent Continsouzas From shade at openjdk.org Wed Aug 2 08:22:10 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 2 Aug 2023 08:22:10 GMT Subject: [jdk21u] Integrated: 8307766: Linux: Provide the option to override the timer slack In-Reply-To: <4fc1yBVa6Nzqw2aQYzbokidS-HutpK0qpP22kZPgc0I=.53e53efa-a2b7-4793-9c6f-e65493052b9a@github.com> References: <4fc1yBVa6Nzqw2aQYzbokidS-HutpK0qpP22kZPgc0I=.53e53efa-a2b7-4793-9c6f-e65493052b9a@github.com> Message-ID: On Fri, 28 Jul 2023 08:04:56 GMT, Aleksey Shipilev wrote: > Clean backport of experimental feature for in-field use. > > Additional testing: > - [x] Linux x86_64 fastdebug, new test > - [x] Linux x86_64 fastdebug, `tier1` > - [x] Linux x86_64 fastdebug, `tier2` > - [x] Linux x86_64 fastdebug, `tier3` This pull request has now been integrated. Changeset: 53aceba7 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/53aceba71e19bc2a702d96aa54c3fd0f56e94abf Stats: 176 lines in 3 files changed: 175 ins; 0 del; 1 mod 8307766: Linux: Provide the option to override the timer slack Reviewed-by: stuefe Backport-of: 7173c3009e0999f13eaa4bee5eedee7326f9d124 ------------- PR: https://git.openjdk.org/jdk21u/pull/21 From shade at openjdk.org Wed Aug 2 08:22:09 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 2 Aug 2023 08:22:09 GMT Subject: [jdk21u] RFR: 8307766: Linux: Provide the option to override the timer slack In-Reply-To: <4fc1yBVa6Nzqw2aQYzbokidS-HutpK0qpP22kZPgc0I=.53e53efa-a2b7-4793-9c6f-e65493052b9a@github.com> References: <4fc1yBVa6Nzqw2aQYzbokidS-HutpK0qpP22kZPgc0I=.53e53efa-a2b7-4793-9c6f-e65493052b9a@github.com> Message-ID: On Fri, 28 Jul 2023 08:04:56 GMT, Aleksey Shipilev wrote: > Clean backport of experimental feature for in-field use. > > Additional testing: > - [x] Linux x86_64 fastdebug, new test > - [x] Linux x86_64 fastdebug, `tier1` > - [x] Linux x86_64 fastdebug, `tier2` > - [x] Linux x86_64 fastdebug, `tier3` Testing is clean (the remaining GHA failure is unrelated). Reviews are good. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/21#issuecomment-1661727676 From shade at openjdk.org Wed Aug 2 08:24:02 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 2 Aug 2023 08:24:02 GMT Subject: [jdk17u-dev] RFR: 8307766: Linux: Provide the option to override the timer slack In-Reply-To: <1KxfN_e0NDqlG8m8wE_mweKtUsnK1XILddDEDLaFz-E=.43c3d1c8-f367-4154-82c7-fce926143c13@github.com> References: <1KxfN_e0NDqlG8m8wE_mweKtUsnK1XILddDEDLaFz-E=.43c3d1c8-f367-4154-82c7-fce926143c13@github.com> Message-ID: <2eomOyCbuRq5puyEa4FCXWmFEXzyIpgyGXqdX_vWYaQ=.553f79db-ef8a-4831-b257-a3a34e678f0a@github.com> On Fri, 28 Jul 2023 08:29:25 GMT, Aleksey Shipilev wrote: > Clean backport of experimental feature for in-field use. > > Additional testing: > - [x] Linux AArch64 fastdebug, new test > - [x] Linux AArch64 fastdebug, `tier1` > - [x] Linux AArch64 fastdebug, `tier2` > - [x] Linux AArch64 fastdebug, `tier3` Testing is clean (the remaining GHA failure is unrelated). Reviews are not needed. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1631#issuecomment-1661728811 From shade at openjdk.org Wed Aug 2 08:24:03 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 2 Aug 2023 08:24:03 GMT Subject: [jdk17u-dev] Integrated: 8307766: Linux: Provide the option to override the timer slack In-Reply-To: <1KxfN_e0NDqlG8m8wE_mweKtUsnK1XILddDEDLaFz-E=.43c3d1c8-f367-4154-82c7-fce926143c13@github.com> References: <1KxfN_e0NDqlG8m8wE_mweKtUsnK1XILddDEDLaFz-E=.43c3d1c8-f367-4154-82c7-fce926143c13@github.com> Message-ID: On Fri, 28 Jul 2023 08:29:25 GMT, Aleksey Shipilev wrote: > Clean backport of experimental feature for in-field use. > > Additional testing: > - [x] Linux AArch64 fastdebug, new test > - [x] Linux AArch64 fastdebug, `tier1` > - [x] Linux AArch64 fastdebug, `tier2` > - [x] Linux AArch64 fastdebug, `tier3` This pull request has now been integrated. Changeset: 735e1da1 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/735e1da18e33d1ecd1de12ac754f949595c85fe0 Stats: 176 lines in 3 files changed: 175 ins; 0 del; 1 mod 8307766: Linux: Provide the option to override the timer slack Backport-of: 7173c3009e0999f13eaa4bee5eedee7326f9d124 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1631 From shade at openjdk.org Wed Aug 2 08:29:14 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 2 Aug 2023 08:29:14 GMT Subject: [jdk21u] RFR: 8312591: GCC 6 build failure after JDK-8280982 Message-ID: Clean backport to upgrade older toolchains. Risk is low, adds a few warning exclusions. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 9454b2bbe130fdbe86485b928b80d19156c709ee Changes: https://git.openjdk.org/jdk21u/pull/32/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=32&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312591 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/32.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/32/head:pull/32 PR: https://git.openjdk.org/jdk21u/pull/32 From shade at openjdk.org Wed Aug 2 08:43:11 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 2 Aug 2023 08:43:11 GMT Subject: [jdk21u] RFR: 8313428: GHA: Bump GCC versions for July 2023 updates Message-ID: Clean backport to unbreak GHA. Additional testing: - [ ] GHA ------------- Commit messages: - Backport ec2f38fd389dc51dc4d8925e037a8bf2e64a3722 Changes: https://git.openjdk.org/jdk21u/pull/33/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=33&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313428 Stats: 9 lines in 1 file changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk21u/pull/33.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/33/head:pull/33 PR: https://git.openjdk.org/jdk21u/pull/33 From szaldana at openjdk.org Wed Aug 2 11:03:51 2023 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 2 Aug 2023 11:03:51 GMT Subject: [jdk17u-dev] Integrated: 8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java In-Reply-To: References: Message-ID: On Wed, 26 Jul 2023 20:01:45 GMT, Sonia Zaldana Calles wrote: > 8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java This pull request has now been integrated. Changeset: 482f2241 Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/482f2241da4d5d60c74e493c77fe7d9d11b1e753 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java Backport-of: 2d13fb21af783ebbe3dd5c2632aea11347317026 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1628 From vladimir.kempik at gmail.com Wed Aug 2 11:20:17 2023 From: vladimir.kempik at gmail.com (Vladimir Kempik) Date: Wed, 2 Aug 2023 14:20:17 +0300 Subject: regarding backporting 8305056 to 17u Message-ID: Hello maintainers of openjdk 17 udpates I would like to know your opinion on backporting https://bugs.openjdk.org/browse/JDK-8305056 to 17u-dev before I start backport process it?s important for risc-v to prevent misaligned load/stores when generating/patching executable code it opcodes aren?t naturally aligned. Sadly this backport isn?t risc-v only, but I can try to use ifdefs to protect other ports. Regards, Vladimir -------------- next part -------------- An HTML attachment was scrubbed... URL: From mbaesken at openjdk.org Wed Aug 2 11:56:23 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 2 Aug 2023 11:56:23 GMT Subject: [jdk21u] RFR: 8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX Message-ID: <1id0a0LM5XcLI1MbfQKBD2DrE4iA0iHCt9VGMYswI2Q=.94953bc6-2b57-4067-92e1-b045af89485b@github.com> 8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX ------------- Commit messages: - Backport 0328886450a4978f1edbe06a59d2ab8f733d19a9 Changes: https://git.openjdk.org/jdk21u/pull/34/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=34&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311955 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/34.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/34/head:pull/34 PR: https://git.openjdk.org/jdk21u/pull/34 From christoph.langer at sap.com Wed Aug 2 12:31:59 2023 From: christoph.langer at sap.com (Langer, Christoph) Date: Wed, 2 Aug 2023 12:31:59 +0000 Subject: regarding backporting 8305056 to 17u In-Reply-To: References: Message-ID: Hi Vladimir, I think you should try the backport, regardless of it being in non risc-v only code. Cheers Christoph From: jdk-updates-dev On Behalf Of Vladimir Kempik Sent: Mittwoch, 2. August 2023 13:20 To: jdk-updates-dev Subject: regarding backporting 8305056 to 17u Hello maintainers of openjdk 17 udpates I would like to know your opinion on backporting https://bugs.openjdk.org/browse/JDK-8305056 to 17u-dev before I start backport process it?s important for risc-v to prevent misaligned load/stores when generating/patching executable code it opcodes aren?t naturally aligned. Sadly this backport isn?t risc-v only, but I can try to use ifdefs to protect other ports. Regards, Vladimir -------------- next part -------------- An HTML attachment was scrubbed... URL: From eastig at amazon.co.uk Wed Aug 2 12:41:34 2023 From: eastig at amazon.co.uk (Astigeevich, Evgeny) Date: Wed, 2 Aug 2023 12:41:34 +0000 Subject: regarding backporting 8305056 to 17u Message-ID: <2E78C693-B663-41B2-8E02-CF566BC7FFE7@amazon.co.uk> Looked into the PR and found: https://github.com/openjdk/jdk/pull/13227#issuecomment-1519963429 The patch relies on inlining of ?memcpy? by compilers which might be a concern. From: jdk-updates-dev on behalf of "Langer, Christoph" Date: Wednesday, 2 August 2023 at 13:33 To: Vladimir Kempik , jdk-updates-dev Subject: RE: regarding backporting 8305056 to 17u Hi Vladimir, I think you should try the backport, regardless of it being in non risc-v only code. Cheers Christoph From: jdk-updates-dev On Behalf Of Vladimir Kempik Sent: Mittwoch, 2. August 2023 13:20 To: jdk-updates-dev Subject: regarding backporting 8305056 to 17u Hello maintainers of openjdk 17 udpates I would like to know your opinion on backporting https://bugs.openjdk.org/browse/JDK-8305056 to 17u-dev before I start backport process it?s important for risc-v to prevent misaligned load/stores when generating/patching executable code it opcodes aren?t naturally aligned. Sadly this backport isn?t risc-v only, but I can try to use ifdefs to protect other ports. Regards, Vladimir Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom. -------------- next part -------------- An HTML attachment was scrubbed... URL: From alanb at openjdk.org Wed Aug 2 13:36:55 2023 From: alanb at openjdk.org (Alan Bateman) Date: Wed, 2 Aug 2023 13:36:55 GMT Subject: [jdk21u] RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v4] In-Reply-To: <5UR0goGdm6tOsiqpjgd68qoqG4-J4J-afahh_gCrB3o=.e4e0de7d-f3f9-4c08-91b1-174b52af36f9@github.com> References: <5UR0goGdm6tOsiqpjgd68qoqG4-J4J-afahh_gCrB3o=.e4e0de7d-f3f9-4c08-91b1-174b52af36f9@github.com> Message-ID: On Tue, 1 Aug 2023 15:41:58 GMT, Christoph Langer wrote: >> Hi all, >> >> This pull request contains a backport of [JDK-8308609](https://bugs.openjdk.org/browse/JDK-8308609), commit [44a8aa06](https://github.com/openjdk/jdk/commit/44a8aa0691f046d720a789a89c9039a010658f0c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Andrew Haley on 16 Jun 2023 and was reviewed by Alan Bateman. >> >> Thanks! > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into RealCLanger-backport-44a8aa06 > - JDK-8310586 - add back exclusion > - Remove test exclusion from test/jdk/ProblemList-Xcomp.txt > - Backport 44a8aa0691f046d720a789a89c9039a010658f0c The backport of JDK-8308609 looks fine. JDK-8310586 excluded in ProblemList-Virtual.txt for linux-x64 only, it should be generic-all. ------------- Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk21u/pull/22#pullrequestreview-1559026710 From iklam at openjdk.org Wed Aug 2 21:49:58 2023 From: iklam at openjdk.org (Ioi Lam) Date: Wed, 2 Aug 2023 21:49:58 GMT Subject: [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image In-Reply-To: References: Message-ID: On Tue, 1 Aug 2023 08:29:28 GMT, Andrew Leonard wrote: > Hi @iklam , would you be able to review this backport of your original classlist sorting please? thanks Hmm, I am not sure why this backport is necessary. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1632#issuecomment-1663013330 From duke at openjdk.org Wed Aug 2 23:58:40 2023 From: duke at openjdk.org (ktakakuri) Date: Wed, 2 Aug 2023 23:58:40 GMT Subject: [jdk11u-dev] RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken [v2] In-Reply-To: References: Message-ID: > I would like to backport > 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. > There are minor differences regarding DocRoot, but otherwise this is a clean backport. ktakakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into 8248001 - Backport bb95dda0ac5032e4df582f2903dcbbbbaef9e8c4 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2002/files - new: https://git.openjdk.org/jdk11u-dev/pull/2002/files/a6008b0d..1831e33d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2002&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2002&range=00-01 Stats: 13387 lines in 294 files changed: 9982 ins; 2376 del; 1029 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2002.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2002/head:pull/2002 PR: https://git.openjdk.org/jdk11u-dev/pull/2002 From duke at openjdk.org Thu Aug 3 06:16:34 2023 From: duke at openjdk.org (ktakakuri) Date: Thu, 3 Aug 2023 06:16:34 GMT Subject: [jdk11u-dev] RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken [v2] In-Reply-To: References: Message-ID: <-cWeAqDyhvW1mGQ4RtFDz2MNepTlJH1LC0ZKpCM7a_8=.2f1282eb-5f4a-4ff5-89db-b7c98aac6b1a@github.com> On Wed, 2 Aug 2023 23:58:40 GMT, ktakakuri wrote: >> I would like to backport >> 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. >> There are minor differences regarding DocRoot, but otherwise this is a clean backport. > > ktakakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into 8248001 > - Backport bb95dda0ac5032e4df582f2903dcbbbbaef9e8c4 linux-cross-compile failed. E: Version '10.3.0-1ubuntu1~20.04cross1' for 'gcc-10-s390x-linux-gnu' was not found E: Version '10.3.0-1ubuntu1~20.04cross1' for 'g++-10-s390x-linux-gnu' was not found But all other tests passed. Is it OK? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2002#issuecomment-1663348460 From jlahoda at openjdk.org Thu Aug 3 06:40:58 2023 From: jlahoda at openjdk.org (Jan Lahoda) Date: Thu, 3 Aug 2023 06:40:58 GMT Subject: [jdk21u] RFR: 8312619: Strange error message when switching over long Message-ID: Hi all, This pull request contains a backport of commit [cc2a75e1](https://github.com/openjdk/jdk/commit/cc2a75e11c4b5728c547aa764067427fdea8c941) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jan Lahoda on 26 Jul 2023 and was reviewed by Vicente Romero. Thanks! ------------- Commit messages: - Backport cc2a75e11c4b5728c547aa764067427fdea8c941 Changes: https://git.openjdk.org/jdk21u/pull/35/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=35&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312619 Stats: 50 lines in 4 files changed: 43 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/35/head:pull/35 PR: https://git.openjdk.org/jdk21u/pull/35 From clanger at openjdk.org Thu Aug 3 06:54:38 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Aug 2023 06:54:38 GMT Subject: [jdk21u] RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v3] In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 14:11:25 GMT, Christoph Langer wrote: > JDK-8311926 Yes, this change is done in the follow-up [JDK-8311926](https://bugs.openjdk.org/browse/JDK-8311926). We'll also need [JDK-8310211](https://bugs.openjdk.org/browse/JDK-8310211). ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/22#issuecomment-1663391005 From clanger at openjdk.org Thu Aug 3 07:05:17 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 3 Aug 2023 07:05:17 GMT Subject: [jdk21u] RFR: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing Message-ID: Hi all, This pull request contains a backport of [JDK-8310211](https://bugs.openjdk.org/browse/JDK-8310211), commit [16134f44](https://github.com/openjdk/jdk/commit/16134f44221e46f71d91fdba08e30705b0e1f92f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Daniel D. Daugherty on 16 Jun 2023 and was reviewed by Mikael Vidstedt. It is needed as followup to #22 to fix the failing test. Thanks! ------------- Commit messages: - Backport 16134f44221e46f71d91fdba08e30705b0e1f92f Changes: https://git.openjdk.org/jdk21u/pull/36/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=36&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310211 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/36.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/36/head:pull/36 PR: https://git.openjdk.org/jdk21u/pull/36 From serb at openjdk.org Thu Aug 3 07:06:01 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 3 Aug 2023 07:06:01 GMT Subject: [jdk17u-dev] RFR: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0 Message-ID: Hi all, This pull request contains a backport of commit [8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 2 Aug 2023 and was reviewed by Aleksey Shipilev and Phil Race. Thanks! ------------- Commit messages: - Backport 8248e351d0bed263fb68d8468004a4286e6391af Changes: https://git.openjdk.org/jdk17u-dev/pull/1635/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1635&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313576 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1635.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1635/head:pull/1635 PR: https://git.openjdk.org/jdk17u-dev/pull/1635 From serb at openjdk.org Thu Aug 3 07:06:01 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 3 Aug 2023 07:06:01 GMT Subject: [jdk17u-dev] RFR: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0 In-Reply-To: References: Message-ID: On Thu, 3 Aug 2023 05:12:27 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 2 Aug 2023 and was reviewed by Aleksey Shipilev and Phil Race. > > Thanks! Tested with "--with-freetype=bundled", "--with-freetype=system" and w/o option. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1635#issuecomment-1663318835 From aleonard at openjdk.org Thu Aug 3 07:53:43 2023 From: aleonard at openjdk.org (Andrew Leonard) Date: Thu, 3 Aug 2023 07:53:43 GMT Subject: [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image In-Reply-To: References: Message-ID: On Wed, 2 Aug 2023 21:47:24 GMT, Ioi Lam wrote: > > Hi @iklam , would you be able to review this backport of your original classlist sorting please? thanks > > Hmm, I am not sure why this backport is necessary. @iklam The classlist file ordering is seemingly random, and thus 2 builds of the same code produces classlist files that differ. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1632#issuecomment-1663464667 From shade at openjdk.org Thu Aug 3 09:39:54 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 3 Aug 2023 09:39:54 GMT Subject: [jdk21u] RFR: 8313402: C1: Incorrect LoadIndexed value numbering Message-ID: Clean backport to fix the important C1 bug. Additional testing: - [x] New regression test fails without the patch, passes with it - [ ] Linux AArch64 `fastdebug` `tier1 tier2 tier3` ------------- Commit messages: - Backport 46fbedb2be98a9b8aba042fa9f90c3b25c312cd6 Changes: https://git.openjdk.org/jdk21u/pull/37/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=37&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313402 Stats: 59 lines in 2 files changed: 58 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/37.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/37/head:pull/37 PR: https://git.openjdk.org/jdk21u/pull/37 From jlahoda at openjdk.org Thu Aug 3 10:01:55 2023 From: jlahoda at openjdk.org (Jan Lahoda) Date: Thu, 3 Aug 2023 10:01:55 GMT Subject: [jdk21u] RFR: 8312984: javac may crash on a record pattern with too few components Message-ID: Hi all, This pull request contains a backport of commit [c3860917](https://github.com/openjdk/jdk/commit/c3860917346fb53ed3d23f11d112b58b8cd8448a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jan Lahoda on 3 Aug 2023 and was reviewed by Vicente Romero. Thanks! ------------- Commit messages: - Backport c3860917346fb53ed3d23f11d112b58b8cd8448a Changes: https://git.openjdk.org/jdk21u/pull/38/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=38&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312984 Stats: 19 lines in 4 files changed: 14 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u/pull/38.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/38/head:pull/38 PR: https://git.openjdk.org/jdk21u/pull/38 From thierry.aime at dgfip.finances.gouv.fr Thu Aug 3 10:02:17 2023 From: thierry.aime at dgfip.finances.gouv.fr (thierry.aime at dgfip.finances.gouv.fr) Date: Thu, 3 Aug 2023 12:02:17 +0200 (CEST) Subject: Auto: jdk-updates-dev Digest, Vol 70, Issue 16 Message-ID: <20230803100217.2054E14005019@mespgsa035.dgfip.finances.gouv.fr> Je suis absent du 17 juillet 2023 au 04 ao?t 2023 inclus. En cas d'urgence, contactez Laurent Continsouzas From mbaesken at openjdk.org Thu Aug 3 11:22:40 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 3 Aug 2023 11:22:40 GMT Subject: [jdk21u] RFR: 8312574: jdk/jdk/jfr/jvm/TestChunkIntegrity.java fails with timeout In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 15:26:08 GMT, Matthias Baesken wrote: > 8312574: jdk/jdk/jfr/jvm/TestChunkIntegrity.java fails with timeout directly ported to jdk21, so jdk21u is not needed any more. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/29#issuecomment-1663803392 From mbaesken at openjdk.org Thu Aug 3 11:22:41 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 3 Aug 2023 11:22:41 GMT Subject: [jdk21u] Withdrawn: 8312574: jdk/jdk/jfr/jvm/TestChunkIntegrity.java fails with timeout In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 15:26:08 GMT, Matthias Baesken wrote: > 8312574: jdk/jdk/jfr/jvm/TestChunkIntegrity.java fails with timeout This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u/pull/29 From shade at openjdk.org Thu Aug 3 11:29:11 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 3 Aug 2023 11:29:11 GMT Subject: [jdk17u-dev] RFR: 8313402: C1: Incorrect LoadIndexed value numbering Message-ID: Clean backport to fix the important C1 bug. Additional testing: - [x] New regression test fails without the patch, passes with it, when JDK-8313676 is applied - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` ------------- Commit messages: - Backport 46fbedb2be98a9b8aba042fa9f90c3b25c312cd6 Changes: https://git.openjdk.org/jdk17u-dev/pull/1636/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1636&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313402 Stats: 59 lines in 2 files changed: 58 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1636.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1636/head:pull/1636 PR: https://git.openjdk.org/jdk17u-dev/pull/1636 From phh at openjdk.org Thu Aug 3 14:10:53 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 3 Aug 2023 14:10:53 GMT Subject: [jdk11u-dev] RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken [v2] In-Reply-To: References: Message-ID: On Wed, 2 Aug 2023 23:58:40 GMT, ktakakuri wrote: >> I would like to backport >> 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. >> There are minor differences regarding DocRoot, but otherwise this is a clean backport. > > ktakakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into 8248001 > - Backport bb95dda0ac5032e4df582f2903dcbbbbaef9e8c4 It's ok, looks like a GHA infra failure. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2002#issuecomment-1664051936 From vkempik at openjdk.org Thu Aug 3 15:28:32 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Thu, 3 Aug 2023 15:28:32 GMT Subject: [jdk21u] Integrated: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic In-Reply-To: <2XPKtFOj0IdpDlc6XzXttoHMRrp3EW2S84n4MCUI08s=.f4334492-e7fe-4db1-bac2-5bb455f0c5fb@github.com> References: <2XPKtFOj0IdpDlc6XzXttoHMRrp3EW2S84n4MCUI08s=.f4334492-e7fe-4db1-bac2-5bb455f0c5fb@github.com> Message-ID: On Mon, 31 Jul 2023 10:35:43 GMT, Vladimir Kempik wrote: > Hi all, > > This pull request contains a clean backport of commit [d6245b68](https://github.com/openjdk/jdk/commit/d6245b6832ccd1da04616e8ba4b90321b2551971) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Vladimir Kempik on 28 Jul 2023 and was reviewed by Fei Yang. > > Thanks! This pull request has now been integrated. Changeset: 89875df8 Author: Vladimir Kempik URL: https://git.openjdk.org/jdk21u/commit/89875df8346cc063e68d70d3bce08d88d306ddd8 Stats: 145 lines in 4 files changed: 25 ins; 44 del; 76 mod 8310268: RISC-V: misaligned memory access in String.Compare intrinsic Backport-of: d6245b6832ccd1da04616e8ba4b90321b2551971 ------------- PR: https://git.openjdk.org/jdk21u/pull/28 From shade at openjdk.org Thu Aug 3 15:36:41 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 3 Aug 2023 15:36:41 GMT Subject: [jdk21u] RFR: 8312591: GCC 6 build failure after JDK-8280982 In-Reply-To: References: Message-ID: <1QeFvipc-pijvkDiogeuX5MwnT3ugyAAm7j-9rk0_fg=.abb5a884-5ac5-4b32-9992-e5197cceb7ed@github.com> On Wed, 2 Aug 2023 08:22:52 GMT, Aleksey Shipilev wrote: > Clean backport to upgrade older toolchains. > Risk is low, adds a few warning exclusions. > > Additional testing: > - [x] GHA GHA is not clean due to unrelated infra reasons. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/32#issuecomment-1664204790 From shade at openjdk.org Thu Aug 3 15:36:42 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 3 Aug 2023 15:36:42 GMT Subject: [jdk21u] Integrated: 8312591: GCC 6 build failure after JDK-8280982 In-Reply-To: References: Message-ID: On Wed, 2 Aug 2023 08:22:52 GMT, Aleksey Shipilev wrote: > Clean backport to upgrade older toolchains. > Risk is low, adds a few warning exclusions. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 230df992 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/230df9923e32e822daa05ae32ce93cece43b28df Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8312591: GCC 6 build failure after JDK-8280982 Backport-of: 9454b2bbe130fdbe86485b928b80d19156c709ee ------------- PR: https://git.openjdk.org/jdk21u/pull/32 From shade at openjdk.org Thu Aug 3 15:38:34 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 3 Aug 2023 15:38:34 GMT Subject: [jdk21u] RFR: 8313428: GHA: Bump GCC versions for July 2023 updates In-Reply-To: References: Message-ID: <9g7hT2tlADTTRYP2wMudO91fROFKlIj0jCME9mYwbcs=.cef51aea-7e8c-4881-b0bf-5c5152714d3c@github.com> On Wed, 2 Aug 2023 08:35:59 GMT, Aleksey Shipilev wrote: > Clean backport to unbreak GHA. > > Additional testing: > - [x] GHA RISC-V GHA builds fail due to infrastructure problem. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/33#issuecomment-1664205645 From shade at openjdk.org Thu Aug 3 15:38:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 3 Aug 2023 15:38:35 GMT Subject: [jdk21u] Integrated: 8313428: GHA: Bump GCC versions for July 2023 updates In-Reply-To: References: Message-ID: On Wed, 2 Aug 2023 08:35:59 GMT, Aleksey Shipilev wrote: > Clean backport to unbreak GHA. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 40092ed2 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/40092ed235cc8adfad5a981aae316c5a3d889b16 Stats: 9 lines in 1 file changed: 0 ins; 0 del; 9 mod 8313428: GHA: Bump GCC versions for July 2023 updates Backport-of: ec2f38fd389dc51dc4d8925e037a8bf2e64a3722 ------------- PR: https://git.openjdk.org/jdk21u/pull/33 From mbaesken at openjdk.org Thu Aug 3 15:40:38 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 3 Aug 2023 15:40:38 GMT Subject: [jdk21u] Integrated: 8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX In-Reply-To: <1id0a0LM5XcLI1MbfQKBD2DrE4iA0iHCt9VGMYswI2Q=.94953bc6-2b57-4067-92e1-b045af89485b@github.com> References: <1id0a0LM5XcLI1MbfQKBD2DrE4iA0iHCt9VGMYswI2Q=.94953bc6-2b57-4067-92e1-b045af89485b@github.com> Message-ID: On Wed, 2 Aug 2023 11:47:33 GMT, Matthias Baesken wrote: > 8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX This pull request has now been integrated. Changeset: 0346a346 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u/commit/0346a3469bb377d953e45653098d65a2fe1700d7 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX Backport-of: 0328886450a4978f1edbe06a59d2ab8f733d19a9 ------------- PR: https://git.openjdk.org/jdk21u/pull/34 From iklam at openjdk.org Thu Aug 3 15:50:43 2023 From: iklam at openjdk.org (Ioi Lam) Date: Thu, 3 Aug 2023 15:50:43 GMT Subject: [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image In-Reply-To: References: Message-ID: On Wed, 2 Aug 2023 21:47:24 GMT, Ioi Lam wrote: >> Hi @iklam , would you be able to review this backport of your original classlist sorting please? thanks > >> Hi @iklam , would you be able to review this backport of your original classlist sorting please? thanks > > Hmm, I am not sure why this backport is necessary. > > > Hi @iklam , would you be able to review this backport of your original classlist sorting please? thanks > > > > > > Hmm, I am not sure why this backport is necessary. > > @iklam The classlist file ordering is seemingly random, and thus 2 builds of the same code produces classlist files that differ. Is the goal for reproducible builds? Backporting this change alone isn't enough. The following are needed: https://bugs.openjdk.org/issues/?jql=labels%20%3D%20reproducible-build%20AND%20labels%20%3D%20cds%20ORDER%20BY%20fixVersion%20ASC However, the CDS code has changed significantly since JDK 17, so backporting will be very difficult. Please follow https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix and have a discussion on the [jdk-updates-dev mailing list](https://mail.openjdk.org/mailman/listinfo/jdk-updates-dev) before proceeding. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1632#issuecomment-1664227750 From serb at openjdk.org Thu Aug 3 17:11:51 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 3 Aug 2023 17:11:51 GMT Subject: [jdk21u] RFR: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0 Message-ID: <2PccSIRNyHlYyWiNkjP43u2rAeX-tt4bOLdesVk6JOo=.b92606ff-8823-46a2-8b72-428267b2e201@github.com> Hi all, This pull request contains a backport of commit [8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 2 Aug 2023 and was reviewed by Aleksey Shipilev and Phil Race. Thanks! ------------- Commit messages: - Backport 8248e351d0bed263fb68d8468004a4286e6391af Changes: https://git.openjdk.org/jdk21u/pull/39/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=39&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313576 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/39.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/39/head:pull/39 PR: https://git.openjdk.org/jdk21u/pull/39 From duke at openjdk.org Thu Aug 3 20:07:50 2023 From: duke at openjdk.org (duke) Date: Thu, 3 Aug 2023 20:07:50 GMT Subject: [jdk11u-dev] Withdrawn: 8264305: Create implementation for native accessibility peer for Statusbar java role In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 05:00:44 GMT, Autumn Nash wrote: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1809 From vkempik at openjdk.org Thu Aug 3 20:29:03 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Thu, 3 Aug 2023 20:29:03 GMT Subject: [jdk17u-dev] RFR: 8305056: Avoid unaligned access in emit_intX methods if it's unsupported Message-ID: Please review this backport to jdk17u-dev, it doesn't apply clean due to different codestyle of emit_int32 in jdk17u-dev (linebreaks) this is important for risc-v port as there support for misaligned memory access is implementation specific option. This commit changes logic from "always misaligned stores on all architectures" to "compiler (gcc/clang) knows better for every architecture" ------------- Commit messages: - 8305056: Avoid unaligned access in emit_intX methods if it's unsupported Changes: https://git.openjdk.org/jdk17u-dev/pull/1638/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1638&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305056 Stats: 15 lines in 1 file changed: 8 ins; 1 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1638.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1638/head:pull/1638 PR: https://git.openjdk.org/jdk17u-dev/pull/1638 From duke at openjdk.org Fri Aug 4 03:08:04 2023 From: duke at openjdk.org (Long Yang) Date: Fri, 4 Aug 2023 03:08:04 GMT Subject: [jdk17u-dev] RFR: 8312065: Socket.connect does not timeout as expected when profiling Message-ID: <6qwO59yJ9ooIzdb0HGXTFes3fODq5BiWQXVy7G0T6OY=.960cca89-4600-4507-ac99-ac040e6c1adc@github.com> Hi all, This pull request contains a fix for [JDK-8312065](https://bugs.openjdk.org/browse/JDK-8312065). The old SocketImpl is still present in JDK 17, can be enabled with -Djdk.net.usePlainSocketImpl. I have verified that this problem exists on Linux and macOS, and I feel that it also exists on AIX, so I repaired these 3 platforms. Windows implementations are different, so don't have this problem. I added a platform dependent test. The test needs to get the OS thread ID of the Java thread. It seems that there is no good Java API to get it directly. The minimum requirement of Linux [/proc/thread-self](https://man7.org/linux/man-pages/man5/proc.5.html#:~:text=/proc/thread%2Dself%20(since%20Linux%203.17)) is Linux 3.17. The JFR event records the OS thread ID, although this method is cumbersome, it is reliable. The test also needs to use the kill command to send a signal to the thread. macOS's kill seems to only support process, and I don't have an AIX environment, so this test only supports Linux. Thanks! ------------- Commit messages: - 8312065: Socket.connect does not timeout as expected when profiling Changes: https://git.openjdk.org/jdk17u-dev/pull/1639/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1639&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312065 Stats: 282 lines in 4 files changed: 279 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1639.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1639/head:pull/1639 PR: https://git.openjdk.org/jdk17u-dev/pull/1639 From duke at openjdk.org Fri Aug 4 05:27:53 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Fri, 4 Aug 2023 05:27:53 GMT Subject: [jdk11u-dev] RFR: 8302161: Upgrade jQuery UI to version 1.13.2 Message-ID: I want to backport JDK-8302161 for jdk11u. This is clean backport. Also, this backport contains JDK-8293180. All jdk/javadoc tests are passed. ------------- Commit messages: - Backport 404d5bddb9177c3bda03db81e14209e372a00027 Changes: https://git.openjdk.org/jdk11u-dev/pull/2064/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2064&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302161 Stats: 15 lines in 5 files changed: 0 ins; 0 del; 15 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2064.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2064/head:pull/2064 PR: https://git.openjdk.org/jdk11u-dev/pull/2064 From andrewlu at openjdk.org Fri Aug 4 08:24:43 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 4 Aug 2023 08:24:43 GMT Subject: [jdk11u-dev] RFR: 8307133: Open source some JTable jtreg tests Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport 5ca0b08a7505d5c210d906e76c2a4cfc3eed64aa Changes: https://git.openjdk.org/jdk11u-dev/pull/2065/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2065&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307133 Stats: 486 lines in 9 files changed: 486 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2065.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2065/head:pull/2065 PR: https://git.openjdk.org/jdk11u-dev/pull/2065 From aleonard at openjdk.org Fri Aug 4 09:32:47 2023 From: aleonard at openjdk.org (Andrew Leonard) Date: Fri, 4 Aug 2023 09:32:47 GMT Subject: [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image In-Reply-To: References: Message-ID: On Thu, 3 Aug 2023 15:48:00 GMT, Ioi Lam wrote: > > > > Hi @iklam , would you be able to review this backport of your original classlist sorting please? thanks > > > > > > > > > Hmm, I am not sure why this backport is necessary. > > > > > > @iklam The classlist file ordering is seemingly random, and thus 2 builds of the same code produces classlist files that differ. > > Is the goal for reproducible builds? Backporting this change alone isn't enough. The following are needed: > > https://bugs.openjdk.org/issues/?jql=labels%20%3D%20reproducible-build%20AND%20labels%20%3D%20cds%20ORDER%20BY%20fixVersion%20ASC > > However, the CDS code has changed significantly since JDK 17, so backporting will be very difficult. > > Please follow https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix and have a discussion on the [jdk-updates-dev mailing list](https://mail.openjdk.org/mailman/listinfo/jdk-updates-dev) before proceeding. Thanks @iklam will do ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1632#issuecomment-1665313867 From anleonar at redhat.com Fri Aug 4 09:39:17 2023 From: anleonar at redhat.com (Andrew Leonard) Date: Fri, 4 Aug 2023 10:39:17 +0100 Subject: [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image : regarding CDS archives Message-ID: Hi, I am currently backporting the fix to sort the classlist file, for a deterministic output: https://github.com/openjdk/jdk17u-dev/pull/1632 and as Ioi Lam pointed out CDS archives in jdk17u are non-deterministic without various jdk-21+ fixes ( https://bugs.openjdk.org/browse/JDK-8245335?jql=labels%20%3D%20reproducible-build%20AND%20labels%20%3D%20cds%20ORDER%20BY%20fixVersion%20ASC), which are unlikely to be backported as jdk17u CDS is quite different to 21+ now. However, it would still be useful to at least have the classlist deterministic, to achieve a JDK tarball that is reproducible bar the CDS archives. There is an argument that CDS archives could be produced at a different point in time from the build tarball, for example maybe via the installer at user install time. Thoughts please? on whether it is useful to merge this classlist sorting, regardless of the CDS archive issue? Thanks Andrew -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrewlu at openjdk.org Fri Aug 4 09:45:43 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 4 Aug 2023 09:45:43 GMT Subject: [jdk11u-dev] Integrated: 8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor In-Reply-To: References: Message-ID: On Wed, 2 Aug 2023 05:29:25 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. This pull request has now been integrated. Changeset: 2c547273 Author: Andrew Lu Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/2c547273fe43208d504720ace23499578b41c03e Stats: 64 lines in 1 file changed: 40 ins; 5 del; 19 mod 8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor Backport-of: b54c4a33c69e16adf5b85b80b8deb4ded2ed074d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2063 From thartmann at openjdk.org Fri Aug 4 09:54:38 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Fri, 4 Aug 2023 09:54:38 GMT Subject: [jdk21u] RFR: 8313402: C1: Incorrect LoadIndexed value numbering In-Reply-To: References: Message-ID: On Thu, 3 Aug 2023 09:32:59 GMT, Aleksey Shipilev wrote: > Clean backport to fix the important C1 bug. > > Additional testing: > - [x] New regression test fails without the patch, passes with it > - [ ] Linux AArch64 `fastdebug` `tier1 tier2 tier3` Looks good. ------------- Marked as reviewed by thartmann (Reviewer). PR Review: https://git.openjdk.org/jdk21u/pull/37#pullrequestreview-1562553486 From clanger at openjdk.org Fri Aug 4 10:00:42 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 4 Aug 2023 10:00:42 GMT Subject: [jdk21u] RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v4] In-Reply-To: <5UR0goGdm6tOsiqpjgd68qoqG4-J4J-afahh_gCrB3o=.e4e0de7d-f3f9-4c08-91b1-174b52af36f9@github.com> References: <5UR0goGdm6tOsiqpjgd68qoqG4-J4J-afahh_gCrB3o=.e4e0de7d-f3f9-4c08-91b1-174b52af36f9@github.com> Message-ID: On Tue, 1 Aug 2023 15:41:58 GMT, Christoph Langer wrote: >> Hi all, >> >> This pull request contains a backport of [JDK-8308609](https://bugs.openjdk.org/browse/JDK-8308609), commit [44a8aa06](https://github.com/openjdk/jdk/commit/44a8aa0691f046d720a789a89c9039a010658f0c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Andrew Haley on 16 Jun 2023 and was reviewed by Alan Bateman. >> >> Thanks! > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into RealCLanger-backport-44a8aa06 > - JDK-8310586 - add back exclusion > - Remove test exclusion from test/jdk/ProblemList-Xcomp.txt > - Backport 44a8aa0691f046d720a789a89c9039a010658f0c GHA failures will be fixed with #36 which I'll integrate as well. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/22#issuecomment-1665347996 From clanger at openjdk.org Fri Aug 4 10:00:44 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 4 Aug 2023 10:00:44 GMT Subject: [jdk21u] Integrated: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" In-Reply-To: References: Message-ID: <9UvX5Rulvtg0ZMP5ye494M-LKudcshsDepf2JTlWCAg=.ea9343e7-ce79-4db3-8387-7af505bc3ee8@github.com> On Fri, 28 Jul 2023 11:32:32 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8308609](https://bugs.openjdk.org/browse/JDK-8308609), commit [44a8aa06](https://github.com/openjdk/jdk/commit/44a8aa0691f046d720a789a89c9039a010658f0c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew Haley on 16 Jun 2023 and was reviewed by Alan Bateman. > > Thanks! This pull request has now been integrated. Changeset: b0da6c16 Author: Christoph Langer URL: https://git.openjdk.org/jdk21u/commit/b0da6c16bb94ed25094cd7f5079e0a3e1b4f4013 Stats: 112 lines in 8 files changed: 42 ins; 29 del; 41 mod 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all Reviewed-by: mbaesken, alanb Backport-of: 44a8aa0691f046d720a789a89c9039a010658f0c ------------- PR: https://git.openjdk.org/jdk21u/pull/22 From clanger at openjdk.org Fri Aug 4 10:01:41 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 4 Aug 2023 10:01:41 GMT Subject: [jdk21u] RFR: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing In-Reply-To: References: Message-ID: <35diONZUSkUpuodwNW3uHlDmIViV2sckMOd5Qex885M=.3b0098f3-c35e-4171-a542-0fd1fbea840f@github.com> On Thu, 3 Aug 2023 06:58:31 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8310211](https://bugs.openjdk.org/browse/JDK-8310211), commit [16134f44](https://github.com/openjdk/jdk/commit/16134f44221e46f71d91fdba08e30705b0e1f92f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Daniel D. Daugherty on 16 Jun 2023 and was reviewed by Mikael Vidstedt. > > It is needed as followup to #22 to fix the failing test. > > Thanks! GHA failures will be fixed by integrating #22 at the same time. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/36#issuecomment-1665349198 From clanger at openjdk.org Fri Aug 4 10:01:42 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 4 Aug 2023 10:01:42 GMT Subject: [jdk21u] Integrated: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing In-Reply-To: References: Message-ID: On Thu, 3 Aug 2023 06:58:31 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8310211](https://bugs.openjdk.org/browse/JDK-8310211), commit [16134f44](https://github.com/openjdk/jdk/commit/16134f44221e46f71d91fdba08e30705b0e1f92f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Daniel D. Daugherty on 16 Jun 2023 and was reviewed by Mikael Vidstedt. > > It is needed as followup to #22 to fix the failing test. > > Thanks! This pull request has now been integrated. Changeset: 90249f0a Author: Christoph Langer URL: https://git.openjdk.org/jdk21u/commit/90249f0add935bcfae5cc0fe648cce60d29c36ad Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing Backport-of: 16134f44221e46f71d91fdba08e30705b0e1f92f ------------- PR: https://git.openjdk.org/jdk21u/pull/36 From thartmann at openjdk.org Fri Aug 4 10:12:56 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Fri, 4 Aug 2023 10:12:56 GMT Subject: [jdk21u] RFR: 8312909: C1 should not inline through interface calls with non-subtype receiver Message-ID: Backport of [JDK-8312909](https://bugs.openjdk.java.net/browse/JDK-8312909). Applies cleanly. Thanks, Tobias ------------- Commit messages: - 8312909: C1 should not inline through interface calls with non-subtype receiver Changes: https://git.openjdk.org/jdk21u/pull/40/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=40&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312909 Stats: 109 lines in 3 files changed: 105 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u/pull/40.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/40/head:pull/40 PR: https://git.openjdk.org/jdk21u/pull/40 From thartmann at openjdk.org Fri Aug 4 10:25:46 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Fri, 4 Aug 2023 10:25:46 GMT Subject: [jdk21u] RFR: 8304954: SegmentedCodeCache fails when using large pages Message-ID: Backport of [JDK-8304954](https://bugs.openjdk.java.net/browse/JDK-8304954). Applies cleanly. Thanks, Tobias ------------- Commit messages: - 8304954: SegmentedCodeCache fails when using large pages Changes: https://git.openjdk.org/jdk21u/pull/41/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=41&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304954 Stats: 115 lines in 3 files changed: 109 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk21u/pull/41.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/41/head:pull/41 PR: https://git.openjdk.org/jdk21u/pull/41 From clanger at openjdk.org Fri Aug 4 10:39:49 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 4 Aug 2023 10:39:49 GMT Subject: [jdk21u] RFR: 8311926: java/lang/ScopedValue/StressStackOverflow.java takes 9mins in tier1 Message-ID: <8d0lFUuijhrX4OwK9faRs7-iz2LJyUCn73grtqMXmVc=.4395c28f-30a1-4811-ae35-149a5cba6eeb@github.com> Hi all, This pull request contains a backport of [JDK-8311926](https://bugs.openjdk.org/browse/JDK-8311926), commit [7304316a](https://github.com/openjdk/jdk/commit/7304316a8c55a4c0f2a96d1b99ba9e97e49ed7f4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alan Bateman on 12 Jul 2023 and was reviewed by Jaikiran Pai. Thanks! ------------- Commit messages: - Backport 7304316a8c55a4c0f2a96d1b99ba9e97e49ed7f4 Changes: https://git.openjdk.org/jdk21u/pull/42/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=42&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311926 Stats: 20 lines in 2 files changed: 14 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk21u/pull/42.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/42/head:pull/42 PR: https://git.openjdk.org/jdk21u/pull/42 From shade at openjdk.org Fri Aug 4 11:30:46 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 4 Aug 2023 11:30:46 GMT Subject: [jdk21u] RFR: 8313707: GHA: Bootstrap sysroots with --variant=minbase Message-ID: Clean backport to improve and fix GHA. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 29f1d8ef50e3b4b235177fd9642a1fcf26fe3bab Changes: https://git.openjdk.org/jdk21u/pull/43/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=43&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313707 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/43.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/43/head:pull/43 PR: https://git.openjdk.org/jdk21u/pull/43 From thierry.aime at dgfip.finances.gouv.fr Fri Aug 4 11:31:07 2023 From: thierry.aime at dgfip.finances.gouv.fr (thierry.aime at dgfip.finances.gouv.fr) Date: Fri, 4 Aug 2023 13:31:07 +0200 (CEST) Subject: Auto: jdk-updates-dev Digest, Vol 70, Issue 23 Message-ID: <20230804113107.3BCDD14007C08@mespgsa035.dgfip.finances.gouv.fr> Je suis absent du 17 juillet 2023 au 04 ao?t 2023 inclus. En cas d'urgence, contactez Laurent Continsouzas From stuefe at openjdk.org Fri Aug 4 18:34:11 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 4 Aug 2023 18:34:11 GMT Subject: [jdk11u-dev] RFR: 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace Message-ID: We see this exact problem at customers, and the fix is trivial and no-risk, so lets get this fixed. Unclean backport. Differences: - `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/FileMapInfo.java` had been rewritten for `8263002: Remove CDS MiscCode region` but it does not affect the effectiveness of this patch. - `test/hotspot/jtreg/ProblemList.txt`: the original patch re-includes the formerly excluded test `serviceability/sa/ClhsdbScanOops.java` for macos. That exclusion did not exist in 11, so I left the hunk out. Tests: I manually tested `serviceability/sa/ClhsdbScanOops.java` on Linux x64, seems fine. ------------- Commit messages: - Backport 7f634155b5c4b9f07ab73ceb4c6042ac10dad65e Changes: https://git.openjdk.org/jdk11u-dev/pull/2066/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2066&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8243210 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2066.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2066/head:pull/2066 PR: https://git.openjdk.org/jdk11u-dev/pull/2066 From xliu at openjdk.org Fri Aug 4 19:07:54 2023 From: xliu at openjdk.org (Xin Liu) Date: Fri, 4 Aug 2023 19:07:54 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter In-Reply-To: References: Message-ID: On Tue, 1 Aug 2023 19:30:35 GMT, Aleksey Shipilev wrote: >> This patch is *NOT* a clean backport. The logic part is exactly the same, but I have to adjust code in the following parts: >> 1. change from KVHashtable to ResourceHashtable because we want to use resourceArea instead of C_HEAP. >> 2. we added lambda-API iterator() to ResourceHashtable. Instead of backporting all patches from TIP, we just reuse the original iterator(). >> >> >> template >> void iterate(Function function) const { // lambda enabled API >> >> >> Testing: >> jdk-test1 tests including gtest. >> Manually check there's no malloc/free in runtime. > > src/hotspot/share/logging/logAsyncWriter.hpp line 63: > >> 61: using AsyncLogMap = ResourceHashtable, >> 62: primitive_equals, 17, >> 63: ResourceObj::C_HEAP, mtLogging>; > > These arguments should be on the new lines each, I think? This would match the upstream code better. hi, @shipilev Do we have linter rules for this? ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#discussion_r1284752224 From xliu at openjdk.org Fri Aug 4 19:13:35 2023 From: xliu at openjdk.org (Xin Liu) Date: Fri, 4 Aug 2023 19:13:35 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 19:04:22 GMT, Xin Liu wrote: >> src/hotspot/share/logging/logAsyncWriter.hpp line 63: >> >>> 61: using AsyncLogMap = ResourceHashtable, >>> 62: primitive_equals, 17, >>> 63: ResourceObj::C_HEAP, mtLogging>; >> >> These arguments should be on the new lines each, I think? This would match the upstream code better. > > hi, @shipilev > Do we have linter rules for this? even in tip of jdk, I still can find code like this: https://github.com/openjdk/jdk/blob/master/src/hotspot/share/classfile/classLoaderStats.hpp#L114 ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#discussion_r1284758431 From xliu at openjdk.org Fri Aug 4 19:40:10 2023 From: xliu at openjdk.org (Xin Liu) Date: Fri, 4 Aug 2023 19:40:10 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v2] In-Reply-To: References: Message-ID: > This patch is *NOT* a clean backport. The logic part is exactly the same, but I have to adjust code in the following parts: > 1. change from KVHashtable to ResourceHashtable because we want to use resourceArea instead of C_HEAP. > 2. we added lambda-API iterator() to ResourceHashtable. Instead of backporting all patches from TIP, we just reuse the original iterator(). > > > template > void iterate(Function function) const { // lambda enabled API > > > Testing: > jdk-test1 tests including gtest. > Manually check there's no malloc/free in runtime. Xin Liu has updated the pull request incrementally with one additional commit since the last revision: Revert resourceHash.hpp and use functor instead of C++ lambda. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1630/files - new: https://git.openjdk.org/jdk17u-dev/pull/1630/files/4511c52f..a0bf39dd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1630&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1630&range=00-01 Stats: 80 lines in 3 files changed: 44 ins; 26 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1630.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1630/head:pull/1630 PR: https://git.openjdk.org/jdk17u-dev/pull/1630 From clanger at openjdk.org Fri Aug 4 21:06:33 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 4 Aug 2023 21:06:33 GMT Subject: [jdk11u-dev] RFR: 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace In-Reply-To: References: Message-ID: <9yHnxJYIU0QkS8P3VqOFi1G4P1DU9zxZDVxsBS5CdTI=.bbb636f2-846b-48c4-896f-84f70eb2d963@github.com> On Fri, 4 Aug 2023 15:09:49 GMT, Thomas Stuefe wrote: > We see this exact problem at customers, and the fix is trivial and no-risk, so lets get this fixed. > > Unclean backport. > > Differences: > > - `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/FileMapInfo.java` had been rewritten for `8263002: Remove CDS MiscCode region` but it does not affect the effectiveness of this patch. > > - `test/hotspot/jtreg/ProblemList.txt`: the original patch re-includes the formerly excluded test `serviceability/sa/ClhsdbScanOops.java` for macos. That exclusion did not exist in 11, so I left the hunk out. > > Tests: > > I manually tested `serviceability/sa/ClhsdbScanOops.java` on Linux x64, seems fine. Looks good. ------------- Marked as reviewed by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2066#pullrequestreview-1563562871 From jiangli at openjdk.org Fri Aug 4 22:41:03 2023 From: jiangli at openjdk.org (Jiangli Zhou) Date: Fri, 4 Aug 2023 22:41:03 GMT Subject: [jdk21u] RFR: 8312401: SymbolTable::do_add_if_needed hangs when called in InstanceKlass::add_initialization_error path with requesting length exceeds max_symbol_length Message-ID: <2eiw0nbld1V-XLRYduQ2iQnAyr78TwK5Xs3tQ4-ELwk=.305606bf-8e13-4ff8-b0d3-8fb9cbe8776c@github.com> This is a backport of JDK-8312401, https://git.openjdk.org/jdk/commit/36f3bae556783e7a9ab27b2a2f8dbb0d38be3583. The backport request has been approved by https://bugs.openjdk.org/browse/JDK-8312401?focusedCommentId=14601744&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14601744. Thanks ------------- Commit messages: - Backport 36f3bae556783e7a9ab27b2a2f8dbb0d38be3583 Changes: https://git.openjdk.org/jdk21u/pull/44/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=44&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312401 Stats: 56 lines in 3 files changed: 54 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/44.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/44/head:pull/44 PR: https://git.openjdk.org/jdk21u/pull/44 From clanger at openjdk.org Fri Aug 4 22:49:48 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 4 Aug 2023 22:49:48 GMT Subject: [jdk11u-dev] RFR: 8313803: [11u] Exclude jdk/jfr/event/sampling/TestStackFrameLineNumbers.java Message-ID: The test jdk/jfr/event/sampling/TestStackFrameLineNumbers.java is shaky, ever since it was brought to 11u with 11.0.12. Unless this can be improved we should exclude it to avoid noise in the CI. ------------- Commit messages: - JDK-8313803 Changes: https://git.openjdk.org/jdk11u-dev/pull/2067/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2067&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313803 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2067.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2067/head:pull/2067 PR: https://git.openjdk.org/jdk11u-dev/pull/2067 From clanger at openjdk.org Fri Aug 4 22:52:02 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 4 Aug 2023 22:52:02 GMT Subject: [jdk11u-dev] RFR: 8181383: com/sun/jdi/OptionTest.java fails intermittently with bind failed: Address already in use Message-ID: Hi all, This pull request contains a backport of JDK-8181383, commit [f16ddb2c](https://github.com/openjdk/jdk17u-dev/commit/f16ddb2c3d0edb60ce0521fc0e3920f831dbb3bf) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. The commit being backported was authored by Alex Menkov on 26 Feb 2019 and was reviewed by Serguei Spitsyn and Chris Plummer. We see this error occasionally in our CI, so this backport will help to reduce noise. Thanks! ------------- Commit messages: - Backport f16ddb2c3d0edb60ce0521fc0e3920f831dbb3bf Changes: https://git.openjdk.org/jdk11u-dev/pull/2068/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2068&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8181383 Stats: 42 lines in 2 files changed: 14 ins; 17 del; 11 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2068.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2068/head:pull/2068 PR: https://git.openjdk.org/jdk11u-dev/pull/2068 From jiangli at openjdk.org Sat Aug 5 03:14:40 2023 From: jiangli at openjdk.org (Jiangli Zhou) Date: Sat, 5 Aug 2023 03:14:40 GMT Subject: [jdk21u] Integrated: 8312401: SymbolTable::do_add_if_needed hangs when called in InstanceKlass::add_initialization_error path with requesting length exceeds max_symbol_length In-Reply-To: <2eiw0nbld1V-XLRYduQ2iQnAyr78TwK5Xs3tQ4-ELwk=.305606bf-8e13-4ff8-b0d3-8fb9cbe8776c@github.com> References: <2eiw0nbld1V-XLRYduQ2iQnAyr78TwK5Xs3tQ4-ELwk=.305606bf-8e13-4ff8-b0d3-8fb9cbe8776c@github.com> Message-ID: On Fri, 4 Aug 2023 22:33:59 GMT, Jiangli Zhou wrote: > This is a backport of JDK-8312401, https://git.openjdk.org/jdk/commit/36f3bae556783e7a9ab27b2a2f8dbb0d38be3583. The backport request has been approved by https://bugs.openjdk.org/browse/JDK-8312401?focusedCommentId=14601744&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14601744. > > Thanks This pull request has now been integrated. Changeset: 6dc4a075 Author: Jiangli Zhou URL: https://git.openjdk.org/jdk21u/commit/6dc4a075562c6e79a97f2039fcd818d5002c2088 Stats: 56 lines in 3 files changed: 54 ins; 1 del; 1 mod 8312401: SymbolTable::do_add_if_needed hangs when called in InstanceKlass::add_initialization_error path with requesting length exceeds max_symbol_length Backport-of: 36f3bae556783e7a9ab27b2a2f8dbb0d38be3583 ------------- PR: https://git.openjdk.org/jdk21u/pull/44 From stuefe at openjdk.org Sat Aug 5 06:20:42 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sat, 5 Aug 2023 06:20:42 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v2] In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 19:40:10 GMT, Xin Liu wrote: >> This patch is *NOT* a clean backport. The logic part is exactly the same, but I have to adjust code in the following parts: >> 1. change from KVHashtable to ResourceHashtable because we want to use resourceArea instead of C_HEAP. >> 2. rewrite lambda expression using Functor. >> >> Testing: >> jdk-test1 tests including gtest. >> Manually check there's no malloc/free in runtime. > > Xin Liu has updated the pull request incrementally with one additional commit since the last revision: > > Revert resourceHash.hpp and use functor instead of C++ lambda. Is it necessary to downport this patch? On its own, it does not sound that important, especially if we downport the glibc autotrimmer. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#issuecomment-1666408147 From stuefe at openjdk.org Sat Aug 5 10:54:41 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sat, 5 Aug 2023 10:54:41 GMT Subject: [jdk11u-dev] RFR: 8313803: [11u] Exclude jdk/jfr/event/sampling/TestStackFrameLineNumbers.java In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 22:44:11 GMT, Christoph Langer wrote: > The test jdk/jfr/event/sampling/TestStackFrameLineNumbers.java is shaky, ever since it was brought to 11u with 11.0.12. Unless this can be improved we should exclude it to avoid noise in the CI. Okay. But that this bug has not been looked at for two years is not great. Could your resident profiling specialist not look into this? @parttimenerd? ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2067#pullrequestreview-1563856175 From thomas.stuefe at gmail.com Sat Aug 5 14:23:52 2023 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Sat, 5 Aug 2023 16:23:52 +0200 Subject: Fwd: jdk-11.0.20+8 :: MacOS :: compilation errors :: libharfbuzz In-Reply-To: References: Message-ID: Forwarded to updates-dev. Goetz, have you seen something like this? ---------- Forwarded message --------- From: Dmitri Volotsajev Date: Tue, Aug 1, 2023 at 5:57?PM Subject: jdk-11.0.20+8 :: MacOS :: compilation errors :: libharfbuzz To: build-dev at openjdk.org Hi, Maybe someone from this list can help me. I have errors during build of jdk-11.0.20+8. Same Mac that I used to build other JDK11 versions. Latest successful build: jdk-11.0.19+7 *Build log attached.* About build setup: Mac10.13 build system type - x86_64-apple-darwin17.7.0 JAVA_HOME = '/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/' (same errors reproduced on 11.0.2) Boot JDK version... java version "10.0.2" 2018-07-17 Java(TM) SE Runtime Environment 18.3 (build 10.0.2+13) Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.2+13, mixed mode) SDKPATH = '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk' (same errors reproduced on 10.14 and 10.15) Xcode major version: 10 Using clang C compiler version 10.0.0 [Apple LLVM version 10.0.0 (clang-1000.11.45.5) Target: x86_64-apple-darwin17.7.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin] Using clang C++ compiler version 10.0.0 [Apple LLVM version 10.0.0 (clang-1000.11.45.5) Target: x86_64-apple-darwin17.7.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin] JFX Downloaded https://github.com/openjdk/jfx.git (11+26) compiled with JAVA_HOME (version 11)on same Mac configuration example *17:31:01* + bash configure --with-jvm-variants=server '--with-macosx-codesign-identity=Developer ID Application: X' --with-debug-level=release --with-native-debug-symbols=none --enable-dtrace=auto --enable-ccache --with-macosx-codesign=hardened --disable-warnings-as-errors --with-import-modules=/Users/admin/Downloads/openjfx/jfx/build/modular-sdk --without-version-pre --with-version-build=8 --with-vendor-version-string=X --with-vendor-url=X --with-vendor-name=X --with-vendor-bug-url=X --with-vendor-vm-bug-url=X --with-freetype=bundled Thank you, *Dmitri Volotsajev | DevOps engineer, OpenLogic * Perforce Software P: +372*53832344* Visit us on: LinkedIn | Twitter | Facebook | YouTube This e-mail may contain information that is privileged or confidential. If you are not the intended recipient, please delete the e-mail and any attachments and notify us immediately. -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- 17:58:34 Creating support/modules_libs/jdk.security.auth/libjaas.dylib from 1 file(s) 17:58:35 Updating images/sec-bin.zip 17:59:56 In file included from ./src/java.desktop/share/native/libharfbuzz/hb-subset.cc:27: 17:59:56 In file included from ./src/java.desktop/share/native/libharfbuzz/OT/Color/COLR/../../../hb.hh:514: 17:59:56 ./src/java.desktop/share/native/libharfbuzz/hb-iter.hh:372:23: error: no matching function for call to object of type 'const struct (anonymous struct at ./src/java.desktop/share/native/libharfbuzz/hb-algs.hh:412:1)' 17:59:56 decltype (hb_get (hb_declval (Proj), *hb_declval (Iter)))> 17:59:56 ^~~~~~ 17:59:56 ./src/java.desktop/share/native/libharfbuzz/hb-map.hh:356:5: note: in instantiation of template class 'hb_map_iter_t, unsigned int, true>::item_t>, bool (hb_hashmap_t, unsigned int, true>::item_t::*)() const, const (anonymous struct at ./src/java.desktop/share/native/libharfbuzz/hb-algs.hh:200:1) &, nullptr>, const char *, hb_function_sortedness_t::NOT_SORTED, nullptr>' requested here 17:59:56 + keys_ref () 17:59:56 ^ 17:59:56 ./src/java.desktop/share/native/libharfbuzz/hb-ot-post-table-v2subset.hh:81:44: note: in instantiation of template class 'hb_hashmap_t, unsigned int, true>' requested here 17:59:56 hb_hashmap_t glyph_name_to_new_index; 17:59:56 ^ 17:59:56 ./src/java.desktop/share/native/libharfbuzz/hb-algs.hh:438:3: note: candidate template ignored: substitution failure [with Proj = const char *, Val = hb_hashmap_t, unsigned int, true>::item_t &]: no matching member function for call to 'impl' 17:59:56 operator () (Proj&& f, Val &&v) const HB_AUTO_RETURN 17:59:56 ^ 17:59:56 In file included from ./src/java.desktop/share/native/libharfbuzz/hb-subset.cc:27: 17:59:56 In file included from ./src/java.desktop/share/native/libharfbuzz/OT/Color/COLR/../../../hb.hh:514: 17:59:56 ./src/java.desktop/share/native/libharfbuzz/hb-iter.hh:376:21: error: no matching function for call to object of type 'const struct (anonymous struct at ./src/java.desktop/share/native/libharfbuzz/hb-algs.hh:412:1)' 17:59:56 typedef decltype (hb_get (hb_declval (Proj), *hb_declval (Iter))) __item_t__; 17:59:56 ^~~~~~ 17:59:56 ./src/java.desktop/share/native/libharfbuzz/hb-algs.hh:438:3: note: candidate template ignored: substitution failure [with Proj = const char *, Val = hb_hashmap_t, unsigned int, true>::item_t &]: no matching member function for call to 'impl' 17:59:56 operator () (Proj&& f, Val &&v) const HB_AUTO_RETURN 17:59:56 ^ 17:59:56 In file included from ./src/java.desktop/share/native/libharfbuzz/hb-subset.cc:28: 17:59:56 In file included from ./src/java.desktop/share/native/libharfbuzz/OT/Color/sbix/../../../hb-open-type.hh:37: 17:59:56 In file included from ./src/java.desktop/share/native/libharfbuzz/hb-subset.hh:36: 17:59:56 In file included from ./src/java.desktop/share/native/libharfbuzz/hb-serialize.hh:36: 17:59:56 ./src/java.desktop/share/native/libharfbuzz/hb-map.hh:356:5: error: invalid argument type 'decltype((+ this->iter_items() | hb_map(& item_t::key)))' (aka 'hb_map_iter_t, unsigned int, true>::item_t>, bool (hb_hashmap_t, unsigned int, true>::item_t::*)() const, const (anonymous struct at ./src/java.desktop/share/native/libharfbuzz/hb-algs.hh:200:1) &, nullptr>, const char *, (hb_function_sortedness_t)0>') to unary expression 17:59:56 + keys_ref () 17:59:56 ^ ~~~~~~~~~~~ 17:59:56 ./src/java.desktop/share/native/libharfbuzz/hb-meta.hh:76:41: note: expanded from macro 'HB_AUTO_RETURN' 17:59:56 #define HB_AUTO_RETURN(E) -> decltype ((E)) { return (E); } 17:59:56 ^ 17:59:56 ./src/java.desktop/share/native/libharfbuzz/hb-ot-post-table-v2subset.hh:81:44: note: in instantiation of template class 'hb_hashmap_t, unsigned int, true>' requested here 17:59:56 hb_hashmap_t glyph_name_to_new_index; 17:59:56 ^ 17:59:56 3 errors generated. 17:59:56 make[3]: *** [/Users/admin/Downloads/jdk11u/build/macosx-x86_64-normal-server-release/support/native/java.desktop/libfontmanager/hb-subset.o] Error 1 17:59:56 make[3]: *** Waiting for unfinished jobs.... 18:00:09 make[2]: *** [java.desktop-libs] Error 2 18:00:09 18:00:09 ERROR: Build failed for target 'images' in configuration 'macosx-x86_64-normal-server-release' (exit code 2) 18:00:09 18:00:09 === Output from failing command(s) repeated here === 18:00:09 * For target support_native_java.desktop_libfontmanager_hb-subset.o: 18:00:09 In file included from ./src/java.desktop/share/native/libharfbuzz/hb-subset.cc:27: 18:00:09 In file included from ./src/java.desktop/share/native/libharfbuzz/OT/Color/COLR/../../../hb.hh:514: 18:00:09 ./src/java.desktop/share/native/libharfbuzz/hb-iter.hh:372:23: error: no matching function for call to object of type 'const struct (anonymous struct at ./src/java.desktop/share/native/libharfbuzz/hb-algs.hh:412:1)' 18:00:09 decltype (hb_get (hb_declval (Proj), *hb_declval (Iter)))> 18:00:09 ^~~~~~ 18:00:09 ./src/java.desktop/share/native/libharfbuzz/hb-map.hh:356:5: note: in instantiation of template class 'hb_map_iter_t, unsigned int, true>::item_t>, bool (hb_hashmap_t, unsigned int, true>::item_t::*)() const, const (anonymous struct at ./src/java.desktop/share/native/libharfbuzz/hb-algs.hh:200:1) &, nullptr>, const char *, hb_function_sortedness_t::NOT_SORTED, nullptr>' requested here 18:00:09 + keys_ref () 18:00:09 ^ 18:00:09 ./src/java.desktop/share/native/libharfbuzz/hb-ot-post-table-v2subset.hh:81:44: note: in instantiation of template class 'hb_hashmap_t, unsigned int, true>' requested here 18:00:09 hb_hashmap_t glyph_name_to_new_index; 18:00:09 ^ 18:00:09 ./src/java.desktop/share/native/libharfbuzz/hb-algs.hh:438:3: note: candidate template ignored: substitution failure [with Proj = const char *, Val = hb_hashmap_t, unsigned int, true>::item_t &]: no matching member function for call to 'impl' 18:00:09 operator () (Proj&& f, Val &&v) const HB_AUTO_RETURN 18:00:09 ^ 18:00:09 In file included from ./src/java.desktop/share/native/libharfbuzz/hb-subset.cc:27: 18:00:09 ... (rest of output omitted) 18:00:09 18:00:09 * All command lines available in /Users/admin/Downloads/jdk11u/build/macosx-x86_64-normal-server-release/make-support/failure-logs. 18:00:09 === End of repeated output === 18:00:09 18:00:09 No indication of failed target found. 18:00:09 Hint: Try searching the build log for '] Error'. 18:00:09 Hint: See doc/building.html#troubleshooting for assistance. 18:00:09 18:00:09 make[1]: *** [main] Error 2 18:00:09 make: *** [images] Error 2 From clanger at openjdk.org Sun Aug 6 11:52:39 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 6 Aug 2023 11:52:39 GMT Subject: [jdk11u-dev] RFR: 8313803: [11u] Exclude jdk/jfr/event/sampling/TestStackFrameLineNumbers.java In-Reply-To: References: Message-ID: <5UpPyWhdBRQI8io2lsSyUCs-wgdnsRCS9d3kWDKwLm8=.c3c11e1a-7e31-4683-bd78-ce3e7af3273a@github.com> On Fri, 4 Aug 2023 22:44:11 GMT, Christoph Langer wrote: > The test jdk/jfr/event/sampling/TestStackFrameLineNumbers.java is shaky, ever since it was brought to 11u with 11.0.12. Unless this can be improved we should exclude it to avoid noise in the CI. Thanks for the review. > But that this bug has not been looked at for two years is not great. Could your resident profiling specialist not look into this? @parttimenerd? Good suggestion. I assigned him the Bug ? @jbachorik, maybe you might have a look as well (together with @parttimenerd)? ? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2067#issuecomment-1666830804 From christoph.langer at sap.com Sun Aug 6 11:55:05 2023 From: christoph.langer at sap.com (Langer, Christoph) Date: Sun, 6 Aug 2023 11:55:05 +0000 Subject: jdk-11.0.20+8 :: MacOS :: compilation errors :: libharfbuzz In-Reply-To: References: Message-ID: Hi, looks like an Xcode 10 is used. We?re building with Xcode 13. Maybe recent harfbuzz upgrades have broken compatibility with this old Xcode compiler. I?m not sure whether this could/should be fixed. Maybe updating the compiler is the better solution? Best regards Christoph From: jdk-updates-dev On Behalf Of Thomas St?fe Sent: Samstag, 5. August 2023 16:24 To: jdk-updates-dev at openjdk.org; Lindenmaier, Goetz Subject: Fwd: jdk-11.0.20+8 :: MacOS :: compilation errors :: libharfbuzz Forwarded to updates-dev. Goetz, have you seen something like this? ---------- Forwarded message --------- From: Dmitri Volotsajev > Date: Tue, Aug 1, 2023 at 5:57?PM Subject: jdk-11.0.20+8 :: MacOS :: compilation errors :: libharfbuzz To: build-dev at openjdk.org > Hi, Maybe someone from this list can help me. I have errors during build of jdk-11.0.20+8. Same Mac that I used to build other JDK11 versions. Latest successful build: jdk-11.0.19+7 Build log attached. About build setup: Mac10.13 build system type - x86_64-apple-darwin17.7.0 JAVA_HOME = '/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home/' (same errors reproduced on 11.0.2) Boot JDK version... java version "10.0.2" 2018-07-17 Java(TM) SE Runtime Environment 18.3 (build 10.0.2+13) Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.2+13, mixed mode) SDKPATH = '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk' (same errors reproduced on 10.14 and 10.15) Xcode major version: 10 Using clang C compiler version 10.0.0 [Apple LLVM version 10.0.0 (clang-1000.11.45.5) Target: x86_64-apple-darwin17.7.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin] Using clang C++ compiler version 10.0.0 [Apple LLVM version 10.0.0 (clang-1000.11.45.5) Target: x86_64-apple-darwin17.7.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin] JFX Downloaded https://github.com/openjdk/jfx.git (11+26) compiled with JAVA_HOME (version 11)on same Mac configuration example 17:31:01 + bash configure --with-jvm-variants=server '--with-macosx-codesign-identity=Developer ID Application: X' --with-debug-level=release --with-native-debug-symbols=none --enable-dtrace=auto --enable-ccache --with-macosx-codesign=hardened --disable-warnings-as-errors --with-import-modules=/Users/admin/Downloads/openjfx/jfx/build/modular-sdk --without-version-pre --with-version-build=8 --with-vendor-version-string=X --with-vendor-url=X --with-vendor-name=X --with-vendor-bug-url=X --with-vendor-vm-bug-url=X --with-freetype=bundled Thank you, Dmitri Volotsajev | DevOps engineer, OpenLogic Perforce Software P: +37253832344 Visit us on: LinkedIn | Twitter | Facebook | YouTube This e-mail may contain information that is privileged or confidential. If you are not the intended recipient, please delete the e-mail and any attachments and notify us immediately. -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Mon Aug 7 00:54:47 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Mon, 7 Aug 2023 00:54:47 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Message-ID: I would like to fix this issue because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. Testing: all serviceability area tests jdk_svc, and a specific test to verify the fix. Could anyone review the fix please? Thanks, Kimura Yukihiro ------------- Commit messages: - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Changes: https://git.openjdk.org/jdk17u-dev/pull/1641/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1641&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313815 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1641.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1641/head:pull/1641 PR: https://git.openjdk.org/jdk17u-dev/pull/1641 From xliu at openjdk.org Mon Aug 7 05:41:34 2023 From: xliu at openjdk.org (Xin Liu) Date: Mon, 7 Aug 2023 05:41:34 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v2] In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 19:40:10 GMT, Xin Liu wrote: >> This patch is *NOT* a clean backport. The logic part is exactly the same, but I have to adjust code in the following parts: >> 1. change from KVHashtable to ResourceHashtable because we want to use resourceArea instead of C_HEAP. >> 2. rewrite lambda expression using Functor. >> >> Testing: >> jdk-test1 tests including gtest. >> Manually check there's no malloc/free in runtime. > > Xin Liu has updated the pull request incrementally with one additional commit since the last revision: > > Revert resourceHash.hpp and use functor instead of C++ lambda. Hi, Thomas, Thanks you for the comments. I was told that it is better reducing memory footprint of UL in jdk17u, a LTS Java. May I learn more about glibc autotrim? Is it a glibc feature or a new feature of hotspot? I found [JDK-8268893](https://bugs.openjdk.org/browse/JDK-8268893) on JBS. It itself is a very useful feature! It is not an automatic trimmer, is it? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#issuecomment-1667216510 From jlahoda at openjdk.org Mon Aug 7 07:13:37 2023 From: jlahoda at openjdk.org (Jan Lahoda) Date: Mon, 7 Aug 2023 07:13:37 GMT Subject: [jdk21u] Integrated: 8312984: javac may crash on a record pattern with too few components In-Reply-To: References: Message-ID: On Thu, 3 Aug 2023 09:55:25 GMT, Jan Lahoda wrote: > Hi all, > > This pull request contains a backport of commit [c3860917](https://github.com/openjdk/jdk/commit/c3860917346fb53ed3d23f11d112b58b8cd8448a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jan Lahoda on 3 Aug 2023 and was reviewed by Vicente Romero. > > Thanks! This pull request has now been integrated. Changeset: 8ebd234c Author: Jan Lahoda URL: https://git.openjdk.org/jdk21u/commit/8ebd234cbfb3fd35ee40391fbe0dee318fb8c405 Stats: 19 lines in 4 files changed: 14 ins; 0 del; 5 mod 8312984: javac may crash on a record pattern with too few components Backport-of: c3860917346fb53ed3d23f11d112b58b8cd8448a ------------- PR: https://git.openjdk.org/jdk21u/pull/38 From shade at openjdk.org Mon Aug 7 07:19:57 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 7 Aug 2023 07:19:57 GMT Subject: [jdk17u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 Message-ID: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> This is a series of commits that bring 17u GHA close to mainline. The root change is Ubuntu 22.04 bump, but that one could not be tested alone, because GHA would be broken due to missing compilers, dependencies, etc. Therefore, I opted to do a bulk PR that contains a series of inter-dependent changes. This PR should bring 17u GHA to the good state, atomically. The included changes are in separate commits, if you want to review them separately. But it would be easier to see the changes against JDK 22 GHA. There are differences against JDK 22 GHA, but those look minor, not breaking/fixing current GHA, and we can backport separately once we get JDK 17u GHA in shape. Additional testing: - [x] GHA - [x] Eyeballing the difference between patched JDK 17u and JDK 22 GHA: [jdk17-jdk22-gha-diff.txt](https://github.com/openjdk/jdk17u-dev/files/12261456/jdk17-jdk22-gha-diff.txt) ------------- Commit messages: - Unclean backport JDK-8313707: GHA: Bootstrap sysroots with --variant=minbase - Unclean backport: JDK-8313428: GHA: Bump GCC versions for July 2023 updates - Unclean backport JDK-8295213: Run GHA manually with user-specified make and configure arguments - Clean backport JDK-8293361: GHA: dump config.log in case of configure failure - Unclean backport: JDK-8293107: GHA: Bump to Ubuntu 22.04 - Unclean backport JDK-8293098: GHA: Harmonize GCC version handling for host and cross builds Changes: https://git.openjdk.org/jdk17u-dev/pull/1640/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1640&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293107 Stats: 116 lines in 5 files changed: 87 ins; 3 del; 26 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1640.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1640/head:pull/1640 PR: https://git.openjdk.org/jdk17u-dev/pull/1640 From shade at openjdk.org Mon Aug 7 07:19:57 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 7 Aug 2023 07:19:57 GMT Subject: [jdk17u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> References: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> Message-ID: On Fri, 4 Aug 2023 14:04:14 GMT, Aleksey Shipilev wrote: > This is a series of commits that bring 17u GHA close to mainline. The root change is Ubuntu 22.04 bump, but that one could not be tested alone, because GHA would be broken due to missing compilers, dependencies, etc. Therefore, I opted to do a bulk PR that contains a series of inter-dependent changes. This PR should bring 17u GHA to the good state, atomically. > > The included changes are in separate commits, if you want to review them separately. But it would be easier to see the changes against JDK 22 GHA. There are differences against JDK 22 GHA, but those look minor, not breaking/fixing current GHA, and we can backport separately once we get JDK 17u GHA in shape. > > Additional testing: > - [x] GHA > - [x] Eyeballing the difference between patched JDK 17u and JDK 22 GHA: [jdk17-jdk22-gha-diff.txt](https://github.com/openjdk/jdk17u-dev/files/12261456/jdk17-jdk22-gha-diff.txt) @RealCLanger, @TheRealMDoerr -- this approach makes sense to you? If so, I'll mark this PR ready for review. It would add the PR links to all affected issues, which I don't want to do unless we are going forward with this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1640#issuecomment-1665677055 From clanger at openjdk.org Mon Aug 7 07:19:57 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 7 Aug 2023 07:19:57 GMT Subject: [jdk17u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: References: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> Message-ID: On Fri, 4 Aug 2023 14:13:05 GMT, Aleksey Shipilev wrote: > @RealCLanger, @TheRealMDoerr -- this approach makes sense to you? If so, I'll mark this PR ready for review. It would add the PR links to all affected issues, which I don't want to do unless we are going forward with this PR. Yep, that makes sense. Thanks for the work, happy to review it. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1640#issuecomment-1666069315 From clanger at openjdk.org Mon Aug 7 08:19:56 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 7 Aug 2023 08:19:56 GMT Subject: [jdk11u-dev] RFR: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4 Message-ID: Hi all, This pull request contains a backport of [JDK-8269091](https://bugs.openjdk.org/browse/JDK-8269091), commit [b6a5d208](https://github.com/openjdk/jdk17u-dev/commit/b6a5d2082832c9d70051df8d4a5190f6a6faec58) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. The commit being backported was authored by Matthias Baesken on 13 Jun 2023 and had no reviewers. Thanks! ------------- Commit messages: - Backport b6a5d2082832c9d70051df8d4a5190f6a6faec58 Changes: https://git.openjdk.org/jdk11u-dev/pull/2069/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2069&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8269091 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2069.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2069/head:pull/2069 PR: https://git.openjdk.org/jdk11u-dev/pull/2069 From jlahoda at openjdk.org Mon Aug 7 08:20:43 2023 From: jlahoda at openjdk.org (Jan Lahoda) Date: Mon, 7 Aug 2023 08:20:43 GMT Subject: [jdk21u] Integrated: 8312619: Strange error message when switching over long In-Reply-To: References: Message-ID: On Thu, 3 Aug 2023 06:33:30 GMT, Jan Lahoda wrote: > Hi all, > > This pull request contains a backport of commit [cc2a75e1](https://github.com/openjdk/jdk/commit/cc2a75e11c4b5728c547aa764067427fdea8c941) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jan Lahoda on 26 Jul 2023 and was reviewed by Vicente Romero. > > Thanks! This pull request has now been integrated. Changeset: f65c4503 Author: Jan Lahoda URL: https://git.openjdk.org/jdk21u/commit/f65c4503a89940fbbff87ae5889e2165ed1c9509 Stats: 50 lines in 4 files changed: 43 ins; 0 del; 7 mod 8312619: Strange error message when switching over long Backport-of: cc2a75e11c4b5728c547aa764067427fdea8c941 ------------- PR: https://git.openjdk.org/jdk21u/pull/35 From stuefe at openjdk.org Mon Aug 7 09:23:35 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 7 Aug 2023 09:23:35 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v2] In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 19:40:10 GMT, Xin Liu wrote: >> This patch is *NOT* a clean backport. The logic part is exactly the same, but I have to adjust code in the following parts: >> 1. change from KVHashtable to ResourceHashtable because we want to use resourceArea instead of C_HEAP. >> 2. rewrite lambda expression using Functor. >> >> Testing: >> jdk-test1 tests including gtest. >> Manually check there's no malloc/free in runtime. > > Xin Liu has updated the pull request incrementally with one additional commit since the last revision: > > Revert resourceHash.hpp and use functor instead of C++ lambda. Hi Xin :) > Hi, Thomas, > > Thanks you for the comments. I was told that it is better reducing memory footprint of UL in jdk17u, a LTS Java. Interesting, I'm curious about the effectiveness of your patch. Do you see good results? I would have thought that a lot of these interleaving memory requests are just taken from and handed back into fastbins or tcache, and therefore don't make the arena grow. Also, the glibc attempts to reclaim memory automatically are quite limited (see PR description https://github.com/openjdk/jdk/pull/14781#issue-1790932923) > May I learn more about glibc autotrim? Is it a glibc feature or a new feature of hotspot? > > I found [JDK-8268893](https://bugs.openjdk.org/browse/JDK-8268893) on JBS. It itself is a very useful feature! It is not an automatic trimmer, is it? Its https://bugs.openjdk.org/browse/JDK-8293114. You have to manually enable it, it is still marked as experimental. Also not in 17 yet, but Aleksey is preparing things to get it down quickly once it has baked in head a bit. Essentially, what the trimmer does is run periodically a malloc_trim() operation. malloc_trim() will reclaim memory that has been free'd and that is in page granularity (so, it will also reclaim memory in the middle of an arena). Cheers, Thomas ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#issuecomment-1667504164 From shade at openjdk.org Mon Aug 7 09:51:33 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 7 Aug 2023 09:51:33 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v2] In-Reply-To: References: Message-ID: On Sat, 5 Aug 2023 06:17:33 GMT, Thomas Stuefe wrote: > Is it necessary to downport this patch? On its own, it does not sound that important, especially if we downport the glibc autotrimmer. I think that autotrimmer is a mitigation strategy for oversubscription, rather than a fix. it also does not resolve fragmentation issues, if there are surviving mallocs between temporarly async logging mallocs. In other words, it is more compelling to avoid the issue instead of relying on auto-trimmer. We use a lot of `-Xlog:async` in production, and this would give us additional safety against memory leaks at least with glibc. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#issuecomment-1667545916 From stuefe at openjdk.org Mon Aug 7 11:38:43 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 7 Aug 2023 11:38:43 GMT Subject: [jdk11u-dev] RFR: 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 15:09:49 GMT, Thomas Stuefe wrote: > We see this exact problem at customers, and the fix is trivial and no-risk, so lets get this fixed. > > Unclean backport. > > Differences: > > - `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/FileMapInfo.java` had been rewritten for `8263002: Remove CDS MiscCode region` but it does not affect the effectiveness of this patch. > > - `test/hotspot/jtreg/ProblemList.txt`: the original patch re-includes the formerly excluded test `serviceability/sa/ClhsdbScanOops.java` for macos. That exclusion did not exist in 11, so I left the hunk out. > > Tests: > > I manually tested `serviceability/sa/ClhsdbScanOops.java` on Linux x64, seems fine. GHAs broken for crossbuild platforms; I tested the patch locally with arm32. Due to the really simple nature of the patch I think the broken GHAs are not relevant. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2066#issuecomment-1667692681 From clanger at openjdk.org Mon Aug 7 12:04:57 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 7 Aug 2023 12:04:57 GMT Subject: [jdk11u-dev] RFR: 8313878: Exclude compiler/rtm/locking/TestRTMSpinLoopCount.java on linux ppc64le Message-ID: The test compiler/rtm/locking/TestRTMSpinLoopCount.java fails very often in JDK11 on linux ppc64le and should be excluded to reduce noise in the CI infrastructure. ------------- Commit messages: - JDK-8313878 Changes: https://git.openjdk.org/jdk11u-dev/pull/2070/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2070&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313878 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2070.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2070/head:pull/2070 PR: https://git.openjdk.org/jdk11u-dev/pull/2070 From sgehwolf at redhat.com Mon Aug 7 13:38:40 2023 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Mon, 07 Aug 2023 15:38:40 +0200 Subject: CFV: New JDK Updates Committer: Victor Rudometov In-Reply-To: <30b5012f-fab0-53d8-2f1f-d32630cf5d6e@amazon.de> References: <30b5012f-fab0-53d8-2f1f-d32630cf5d6e@amazon.de> Message-ID: Vote: yes On Mon, 2023-07-24 at 16:20 +0200, Aleksey Shipilev wrote: > I hereby nominate Victor Rudometov (vrudomet) [1] to JDK Updates Committer. From sgehwolf at redhat.com Mon Aug 7 13:59:00 2023 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Mon, 07 Aug 2023 15:59:00 +0200 Subject: [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image : regarding CDS archives In-Reply-To: References: Message-ID: <64680ca459b370d2ede753f9736eefa93139f8b6.camel@redhat.com> On Fri, 2023-08-04 at 10:39 +0100, Andrew Leonard wrote: > Hi, > I am currently backporting the fix to sort the classlist file, for a > deterministic output: https://github.com/openjdk/jdk17u-dev/pull/1632 > and as Ioi Lam pointed out CDS archives in jdk17u are non- > deterministic without various jdk-21+ fixes > (https://bugs.openjdk.org/browse/JDK-8245335?jql=labels%20%3D%20repro > ducible- > build%20AND%20labels%20%3D%20cds%20ORDER%20BY%20fixVersion%20ASC), > which are unlikely to be backported as jdk17u CDS is quite different > to 21+ now. > > However, it would still be useful to at least have the classlist > deterministic, to achieve a JDK tarball that is reproducible bar the > CDS archives. Looking at the patch, the classlist file being deterministic seems fine as a stand-alone JDK 17 backport. > There is an argument that CDS archives could be produced at a > different point in time from the build tarball, for example maybe via > the installer at user install time. That's not a good idea as dynamic CDS dumps (-XX:ArchiveClassesAtExit) depend on the JDK's base CDS archive to be the same as the one at dump time. > Thoughts please? on whether it is useful to merge this classlist > sorting, regardless of the CDS archive issue? Since the classlist file is only used by CDS the patch making classlist deterministic is only part of the full CDS-being-deterministic story. As said above, JDK-8273092 seems low risk enough to be suitable stand- alone for JDK 17u. Thanks, Severin From goetz.lindenmaier at sap.com Mon Aug 7 14:07:02 2023 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Mon, 7 Aug 2023 14:07:02 +0000 Subject: [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image : regarding CDS archives In-Reply-To: References: Message-ID: Hi, I agree to what Severin says, this one seems acceptable. But I think the list mentioned by Ioi is definitely not a candidate for 17. Best regards, Goetz From: jdk-updates-dev On Behalf Of Andrew Leonard Sent: Freitag, 4. August 2023 11:39 To: jdk-updates-dev at openjdk.org Subject: [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image : regarding CDS archives Hi, I am currently backporting the fix to sort the classlist file, for a deterministic output: https://github.com/openjdk/jdk17u-dev/pull/1632 and as Ioi Lam pointed out CDS archives in jdk17u are non-deterministic without various jdk-21+ fixes (https://bugs.openjdk.org/browse/JDK-8245335?jql=labels%20%3D%20reproducible-build%20AND%20labels%20%3D%20cds%20ORDER%20BY%20fixVersion%20ASC), which are unlikely to be backported as jdk17u CDS is quite different to 21+ now. However, it would still be useful to at least have the classlist deterministic, to achieve a JDK tarball that is reproducible bar the CDS archives. There is an argument that CDS archives could be produced at a different point in time from the build tarball, for example maybe via the installer at user install time. Thoughts please? on whether it is useful to merge this classlist sorting, regardless of the CDS archive issue? Thanks Andrew -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Mon Aug 7 14:07:51 2023 From: duke at openjdk.org (ktakakuri) Date: Mon, 7 Aug 2023 14:07:51 GMT Subject: [jdk11u-dev] Integrated: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken In-Reply-To: References: Message-ID: On Thu, 29 Jun 2023 05:49:56 GMT, ktakakuri wrote: > I would like to backport > 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. > There are minor differences regarding DocRoot, but otherwise this is a clean backport. This pull request has now been integrated. Changeset: f5f17ec7 Author: ktakakuri <83941312+ktakakuri at users.noreply.github.com> Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/f5f17ec7c363d398256114e57ac59d64520cc38d Stats: 79 lines in 3 files changed: 76 ins; 0 del; 3 mod 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken Reviewed-by: phh Backport-of: bb95dda0ac5032e4df582f2903dcbbbbaef9e8c4 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2002 From clanger at openjdk.org Mon Aug 7 14:18:46 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 7 Aug 2023 14:18:46 GMT Subject: [jdk17u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> References: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> Message-ID: <2q3xqukUvcmKU8Stp1q6SpTSN0kIylp7v8US_mRPduA=.75cbf7af-9ba9-463c-93b5-e4b2c7821e34@github.com> On Fri, 4 Aug 2023 14:04:14 GMT, Aleksey Shipilev wrote: > This is a series of commits that bring 17u GHA close to mainline. The root change is Ubuntu 22.04 bump, but that one could not be tested alone, because GHA would be broken due to missing compilers, dependencies, etc. Therefore, I opted to do a bulk PR that contains a series of inter-dependent changes. This PR should bring 17u GHA to the good state, atomically. > > The included changes are in separate commits, if you want to review them separately. But it would be easier to see the changes against JDK 22 GHA. There are differences against JDK 22 GHA, but those look minor, not breaking/fixing current GHA, and we can backport separately once we get JDK 17u GHA in shape. > > Additional testing: > - [x] GHA > - [x] Eyeballing the difference between patched JDK 17u and JDK 22 GHA: [jdk17-jdk22-gha-diff.txt](https://github.com/openjdk/jdk17u-dev/files/12261456/jdk17-jdk22-gha-diff.txt) Looks good to me. Thanks for bringing GHA in 17u up to date. ------------- Marked as reviewed by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1640#pullrequestreview-1565432985 From shade at openjdk.org Mon Aug 7 14:30:46 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 7 Aug 2023 14:30:46 GMT Subject: [jdk17u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> References: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> Message-ID: On Fri, 4 Aug 2023 14:04:14 GMT, Aleksey Shipilev wrote: > This is a series of commits that bring 17u GHA close to mainline. The root change is Ubuntu 22.04 bump, but that one could not be tested alone, because GHA would be broken due to missing compilers, dependencies, etc. Therefore, I opted to do a bulk PR that contains a series of inter-dependent changes. This PR should bring 17u GHA to the good state, atomically. > > The included changes are in separate commits, if you want to review them separately. But it would be easier to see the changes against JDK 22 GHA. There are differences against JDK 22 GHA, but those look minor, not breaking/fixing current GHA, and we can backport separately once we get JDK 17u GHA in shape. > > Additional testing: > - [x] GHA > - [x] Eyeballing the difference between patched JDK 17u and JDK 22 GHA: [jdk17-jdk22-gha-diff.txt](https://github.com/openjdk/jdk17u-dev/files/12261456/jdk17-jdk22-gha-diff.txt) Thanks! I added 17u fix requests on all issues. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1640#issuecomment-1667966596 From anleonar at redhat.com Mon Aug 7 14:49:07 2023 From: anleonar at redhat.com (Andrew Leonard) Date: Mon, 7 Aug 2023 15:49:07 +0100 Subject: [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image : regarding CDS archives In-Reply-To: References: Message-ID: Thank you Severin, Goetz, Yes agree. The intention is to at least make jdk17u tar ball reproducible with the exception of the CDS itself, which will remain for the stated reasons. Could I request your review of the PR please? https://github.com/openjdk/jdk17u-dev/pull/1632 Many thanks Andrew On Mon, Aug 7, 2023 at 3:07?PM Lindenmaier, Goetz wrote: > Hi, > > > > I agree to what Severin says, this one seems acceptable. > > > > But I think the list mentioned by Ioi is definitely not a candidate for 17. > > > > Best regards, > > Goetz > > > > *From:* jdk-updates-dev *On Behalf Of *Andrew > Leonard > *Sent:* Freitag, 4. August 2023 11:39 > *To:* jdk-updates-dev at openjdk.org > *Subject:* [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image : > regarding CDS archives > > > > Hi, > > I am currently backporting the fix to sort the classlist file, for a > deterministic output: https://github.com/openjdk/jdk17u-dev/pull/1632 > > and as Ioi Lam pointed out CDS archives in jdk17u are non-deterministic > without various jdk-21+ fixes ( > https://bugs.openjdk.org/browse/JDK-8245335?jql=labels%20%3D%20reproducible-build%20AND%20labels%20%3D%20cds%20ORDER%20BY%20fixVersion%20ASC), > which are unlikely to be backported as jdk17u CDS is quite different to 21+ > now. > > > > However, it would still be useful to at least have the classlist > deterministic, to achieve a JDK tarball that is reproducible bar the CDS > archives. There is an argument that CDS archives could be produced at a > different point in time from the build tarball, for example maybe via the > installer at user install time. > > > > Thoughts please? on whether it is useful to merge this classlist sorting, > regardless of the CDS archive issue? > > > > Thanks > > Andrew > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From goetz at openjdk.org Mon Aug 7 14:50:41 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 7 Aug 2023 14:50:41 GMT Subject: [jdk17u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> References: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> Message-ID: On Fri, 4 Aug 2023 14:04:14 GMT, Aleksey Shipilev wrote: > This is a series of commits that bring 17u GHA close to mainline. The root change is Ubuntu 22.04 bump, but that one could not be tested alone, because GHA would be broken due to missing compilers, dependencies, etc. Therefore, I opted to do a bulk PR that contains a series of inter-dependent changes. This PR should bring 17u GHA to the good state, atomically. > > The included changes are in separate commits, if you want to review them separately. But it would be easier to see the changes against JDK 22 GHA. There are differences against JDK 22 GHA, but those look minor, not breaking/fixing current GHA, and we can backport separately once we get JDK 17u GHA in shape. > > Additional testing: > - [x] GHA > - [x] Eyeballing the difference between patched JDK 17u and JDK 22 GHA: [jdk17-jdk22-gha-diff.txt](https://github.com/openjdk/jdk17u-dev/files/12261456/jdk17-jdk22-gha-diff.txt) Please see my comment in [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1640#issuecomment-1668010220 From mdoerr at openjdk.org Mon Aug 7 15:20:39 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 7 Aug 2023 15:20:39 GMT Subject: [jdk11u-dev] RFR: 8313878: Exclude compiler/rtm/locking/TestRTMSpinLoopCount.java on linux ppc64le In-Reply-To: References: Message-ID: On Mon, 7 Aug 2023 11:58:33 GMT, Christoph Langer wrote: > The test compiler/rtm/locking/TestRTMSpinLoopCount.java fails very often in JDK11 on linux ppc64le and should be excluded to reduce noise in the CI infrastructure. The test is shaky on all platforms. Why not exclude it for generic-all? If you only want to address linux ppc64le, ok. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2070#pullrequestreview-1565595106 From clanger at openjdk.org Mon Aug 7 16:03:44 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 7 Aug 2023 16:03:44 GMT Subject: [jdk11u-dev] RFR: 8313878: Exclude compiler/rtm/locking/TestRTMSpinLoopCount.java on linux ppc64le In-Reply-To: References: Message-ID: <7AGGUw-0kF_Xod11iHrqQo5bBDuBVYXSGw5_vcLtoxE=.5e28afdc-a7cd-4570-a050-63e6736b932a@github.com> On Mon, 7 Aug 2023 15:17:33 GMT, Martin Doerr wrote: > The test is shaky on all platforms. Why not exclude it for generic-all? If you only want to address linux ppc64le, ok. Well, generic-x64 is de-facto all and that's already excluded. I could also use generic-ppc64le. However, I guess there is only linux-ppc64le, so also no difference. ? But anyway, thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2070#issuecomment-1668147192 From clanger at openjdk.org Mon Aug 7 16:35:38 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 7 Aug 2023 16:35:38 GMT Subject: [jdk17u-dev] RFR: 8302182: Update Public Suffix List to 88467c9 Message-ID: <9Tnu2BOT-kgojQKexSyM7ur3RbYjY-uP4L_qeyX5PcY=.1e55aa1d-95a3-43ab-b6b9-82d32e4cf8c8@github.com> Hi all, This pull request contains a backport of [JDK-8302182](https://bugs.openjdk.org/browse/JDK-8302182), commit [01b85129](https://github.com/openjdk/jdk/commit/01b85129116dd2cc762e518ac631305bd8511764) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Weijun Wang on 26 Apr 2023 and was reviewed by Sean Mullan. It contains an update of the public suffix list which should be brought to update releases to keep them up to date as well. Thanks! ------------- Commit messages: - Backport 01b85129116dd2cc762e518ac631305bd8511764 Changes: https://git.openjdk.org/jdk17u-dev/pull/1642/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1642&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302182 Stats: 1479 lines in 5 files changed: 647 ins; 697 del; 135 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1642.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1642/head:pull/1642 PR: https://git.openjdk.org/jdk17u-dev/pull/1642 From stuefe at openjdk.org Mon Aug 7 18:16:55 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 7 Aug 2023 18:16:55 GMT Subject: [jdk11u-dev] RFR: 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 15:09:49 GMT, Thomas Stuefe wrote: > We see this exact problem at customers, and the fix is trivial and no-risk, so lets get this fixed. > > Unclean backport. > > Differences: > > - `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/FileMapInfo.java` had been rewritten for `8263002: Remove CDS MiscCode region` but it does not affect the effectiveness of this patch. > > - `test/hotspot/jtreg/ProblemList.txt`: the original patch re-includes the formerly excluded test `serviceability/sa/ClhsdbScanOops.java` for macos. That exclusion did not exist in 11, so I left the hunk out. > > Tests: > > I manually tested `serviceability/sa/ClhsdbScanOops.java` on Linux x64, seems fine. Got approval + reviews. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2066#issuecomment-1668364733 From stuefe at openjdk.org Mon Aug 7 18:16:55 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 7 Aug 2023 18:16:55 GMT Subject: [jdk11u-dev] Integrated: 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 15:09:49 GMT, Thomas Stuefe wrote: > We see this exact problem at customers, and the fix is trivial and no-risk, so lets get this fixed. > > Unclean backport. > > Differences: > > - `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/FileMapInfo.java` had been rewritten for `8263002: Remove CDS MiscCode region` but it does not affect the effectiveness of this patch. > > - `test/hotspot/jtreg/ProblemList.txt`: the original patch re-includes the formerly excluded test `serviceability/sa/ClhsdbScanOops.java` for macos. That exclusion did not exist in 11, so I left the hunk out. > > Tests: > > I manually tested `serviceability/sa/ClhsdbScanOops.java` on Linux x64, seems fine. This pull request has now been integrated. Changeset: 9d15f3e6 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk11u-dev/commit/9d15f3e6537bf7a5ba081b2a6b7339a601ab7ba5 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace Reviewed-by: clanger Backport-of: 7f634155b5c4b9f07ab73ceb4c6042ac10dad65e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2066 From clanger at openjdk.org Mon Aug 7 20:16:44 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 7 Aug 2023 20:16:44 GMT Subject: [jdk17u-dev] RFR: 8302182: Update Public Suffix List to 88467c9 In-Reply-To: <9Tnu2BOT-kgojQKexSyM7ur3RbYjY-uP4L_qeyX5PcY=.1e55aa1d-95a3-43ab-b6b9-82d32e4cf8c8@github.com> References: <9Tnu2BOT-kgojQKexSyM7ur3RbYjY-uP4L_qeyX5PcY=.1e55aa1d-95a3-43ab-b6b9-82d32e4cf8c8@github.com> Message-ID: On Mon, 7 Aug 2023 16:29:17 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8302182](https://bugs.openjdk.org/browse/JDK-8302182), commit [01b85129](https://github.com/openjdk/jdk/commit/01b85129116dd2cc762e518ac631305bd8511764) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Weijun Wang on 26 Apr 2023 and was reviewed by Sean Mullan. > > It contains an update of the public suffix list which should be brought to update releases to keep them up to date as well. > > Thanks! Not sure why this doesn't get marked as clean. I made no changes, it's a plain bots cherry-pick. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1642#issuecomment-1668510036 From mdoerr at openjdk.org Mon Aug 7 20:17:43 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 7 Aug 2023 20:17:43 GMT Subject: [jdk17u-dev] RFR: 8195589: T6587786.java failed after JDK-8189997 Message-ID: Backport of [JDK-8195589](https://bugs.openjdk.java.net/browse/JDK-8195589). ------------- Commit messages: - Backport 21b62fef335aa981a239415532fa8b804fb5676d Changes: https://git.openjdk.org/jdk17u-dev/pull/1643/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1643&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8195589 Stats: 11 lines in 2 files changed: 3 ins; 1 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1643.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1643/head:pull/1643 PR: https://git.openjdk.org/jdk17u-dev/pull/1643 From mdoerr at openjdk.org Mon Aug 7 20:24:47 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 7 Aug 2023 20:24:47 GMT Subject: [jdk17u-dev] RFR: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest Message-ID: Backport of [JDK-8267860](https://bugs.openjdk.org/browse/JDK-8267860). ------------- Commit messages: - Backport 2adef6a1f84d478bb38b179795f08ffa43680e36 Changes: https://git.openjdk.org/jdk17u-dev/pull/1644/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1644&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8267860 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1644.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1644/head:pull/1644 PR: https://git.openjdk.org/jdk17u-dev/pull/1644 From serb at openjdk.org Tue Aug 8 01:41:08 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 8 Aug 2023 01:41:08 GMT Subject: [jdk17u-dev] RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs Message-ID: Hi all, This pull request contains a backport of commit [d4a795d7](https://github.com/openjdk/jdk/commit/d4a795d75aef8d787934f5c05e146c61138a408a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Peter Levart on 4 Aug 2022 and was reviewed by Roman Kennke and Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport d4a795d75aef8d787934f5c05e146c61138a408a Changes: https://git.openjdk.org/jdk17u-dev/pull/1645/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1645&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283276 Stats: 96 lines in 1 file changed: 69 ins; 11 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1645.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1645/head:pull/1645 PR: https://git.openjdk.org/jdk17u-dev/pull/1645 From robm at openjdk.org Tue Aug 8 10:56:46 2023 From: robm at openjdk.org (Rob McKenna) Date: Tue, 8 Aug 2023 10:56:46 GMT Subject: [jdk21u] Integrated: Merge jdk21:master Message-ID: Merge jdk21:master ------------- Commit messages: - Merge - 8312619: Strange error message when switching over long - 8312984: javac may crash on a record pattern with too few components - 8312401: SymbolTable::do_add_if_needed hangs when called in InstanceKlass::add_initialization_error path with requesting length exceeds max_symbol_length - 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing - 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" - 8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX - 8313428: GHA: Bump GCC versions for July 2023 updates - 8312591: GCC 6 build failure after JDK-8280982 - 8310268: RISC-V: misaligned memory access in String.Compare intrinsic - ... and 22 more: https://git.openjdk.org/jdk21u/compare/bfe037a4...6a43ef5f The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk21u/pull/45/files Stats: 966 lines in 55 files changed: 653 ins; 113 del; 200 mod Patch: https://git.openjdk.org/jdk21u/pull/45.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/45/head:pull/45 PR: https://git.openjdk.org/jdk21u/pull/45 From robm at openjdk.org Tue Aug 8 10:56:47 2023 From: robm at openjdk.org (Rob McKenna) Date: Tue, 8 Aug 2023 10:56:47 GMT Subject: [jdk21u] Integrated: Merge jdk21:master In-Reply-To: References: Message-ID: <_PRpaeOfAzc3yFHc_QzgjB1BSZbNPSEqt3Ty6X-BQlI=.6d56f0a5-f236-4c2f-a3a6-1fa9915ed9a5@github.com> On Tue, 8 Aug 2023 10:49:09 GMT, Rob McKenna wrote: > Merge jdk21:master This pull request has now been integrated. Changeset: aafd687c Author: Rob McKenna URL: https://git.openjdk.org/jdk21u/commit/aafd687cb5958bb68ff29d11fd0c475551939429 Stats: 562 lines in 64 files changed: 225 ins; 84 del; 253 mod Merge ------------- PR: https://git.openjdk.org/jdk21u/pull/45 From clanger at openjdk.org Tue Aug 8 12:06:40 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 8 Aug 2023 12:06:40 GMT Subject: [jdk21u] RFR: 8311926: java/lang/ScopedValue/StressStackOverflow.java takes 9mins in tier1 In-Reply-To: <8d0lFUuijhrX4OwK9faRs7-iz2LJyUCn73grtqMXmVc=.4395c28f-30a1-4811-ae35-149a5cba6eeb@github.com> References: <8d0lFUuijhrX4OwK9faRs7-iz2LJyUCn73grtqMXmVc=.4395c28f-30a1-4811-ae35-149a5cba6eeb@github.com> Message-ID: On Fri, 4 Aug 2023 10:33:31 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8311926](https://bugs.openjdk.org/browse/JDK-8311926), commit [7304316a](https://github.com/openjdk/jdk/commit/7304316a8c55a4c0f2a96d1b99ba9e97e49ed7f4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alan Bateman on 12 Jul 2023 and was reviewed by Jaikiran Pai. > > Thanks! Errors in cross compile GHA step are unrelated. Got push approval. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/42#issuecomment-1669482500 From clanger at openjdk.org Tue Aug 8 12:06:40 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 8 Aug 2023 12:06:40 GMT Subject: [jdk21u] Integrated: 8311926: java/lang/ScopedValue/StressStackOverflow.java takes 9mins in tier1 In-Reply-To: <8d0lFUuijhrX4OwK9faRs7-iz2LJyUCn73grtqMXmVc=.4395c28f-30a1-4811-ae35-149a5cba6eeb@github.com> References: <8d0lFUuijhrX4OwK9faRs7-iz2LJyUCn73grtqMXmVc=.4395c28f-30a1-4811-ae35-149a5cba6eeb@github.com> Message-ID: On Fri, 4 Aug 2023 10:33:31 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8311926](https://bugs.openjdk.org/browse/JDK-8311926), commit [7304316a](https://github.com/openjdk/jdk/commit/7304316a8c55a4c0f2a96d1b99ba9e97e49ed7f4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alan Bateman on 12 Jul 2023 and was reviewed by Jaikiran Pai. > > Thanks! This pull request has now been integrated. Changeset: a21ad550 Author: Christoph Langer URL: https://git.openjdk.org/jdk21u/commit/a21ad5503a799b350d712f97f27bc78ed21ee039 Stats: 20 lines in 2 files changed: 14 ins; 1 del; 5 mod 8311926: java/lang/ScopedValue/StressStackOverflow.java takes 9mins in tier1 Backport-of: 7304316a8c55a4c0f2a96d1b99ba9e97e49ed7f4 ------------- PR: https://git.openjdk.org/jdk21u/pull/42 From clanger at openjdk.org Tue Aug 8 12:07:03 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 8 Aug 2023 12:07:03 GMT Subject: [jdk11u-dev] RFR: 8313878: Exclude two compiler/rtm/locking tests on ppc64le [v2] In-Reply-To: References: Message-ID: > The test compiler/rtm/locking/TestRTMSpinLoopCount.java fails very often in JDK11 on linux ppc64le and should be excluded to reduce noise in the CI infrastructure. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Also exclude TestRTMAbortThreshold and follow Martin's suggestion to exclude for generic-ppc64le - Merge remote-tracking branch 'upstream/master' into JDK-8313878 - JDK-8313878 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2070/files - new: https://git.openjdk.org/jdk11u-dev/pull/2070/files/73a0616c..5d499d38 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2070&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2070&range=00-01 Stats: 84 lines in 5 files changed: 79 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2070.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2070/head:pull/2070 PR: https://git.openjdk.org/jdk11u-dev/pull/2070 From clanger at openjdk.org Tue Aug 8 12:07:03 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 8 Aug 2023 12:07:03 GMT Subject: [jdk11u-dev] RFR: 8313878: Exclude two compiler/rtm/locking tests on ppc64le [v2] In-Reply-To: <7AGGUw-0kF_Xod11iHrqQo5bBDuBVYXSGw5_vcLtoxE=.5e28afdc-a7cd-4570-a050-63e6736b932a@github.com> References: <7AGGUw-0kF_Xod11iHrqQo5bBDuBVYXSGw5_vcLtoxE=.5e28afdc-a7cd-4570-a050-63e6736b932a@github.com> Message-ID: On Mon, 7 Aug 2023 16:00:20 GMT, Christoph Langer wrote: > The test is shaky on all platforms. Why not exclude it for generic-all? If you only want to address linux ppc64le, ok. Hey @TheRealMDoerr, I excluded TestRTMAbortThreshold as well since it's shaky, too. And I changed the exclusion platform to generic-ppc64le. I don't want to use generic-all since there might be platforms where the test still runs and also there is another bug that the already existing exclusions for that test refer to. Please check & approve the PR again. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2070#issuecomment-1669477641 From mdoerr at openjdk.org Tue Aug 8 12:07:04 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 8 Aug 2023 12:07:04 GMT Subject: [jdk11u-dev] RFR: 8313878: Exclude two compiler/rtm/locking tests on ppc64le In-Reply-To: References: Message-ID: On Mon, 7 Aug 2023 11:58:33 GMT, Christoph Langer wrote: > The test compiler/rtm/locking/TestRTMSpinLoopCount.java fails very often in JDK11 on linux ppc64le and should be excluded to reduce noise in the CI infrastructure. You only left AIX enabled ;-) RTM is only implemented on x86 and PPC64. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2070#issuecomment-1669479460 From clanger at openjdk.org Tue Aug 8 12:08:52 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 8 Aug 2023 12:08:52 GMT Subject: [jdk11u-dev] RFR: 8181383: com/sun/jdi/OptionTest.java fails intermittently with bind failed: Address already in use In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 22:45:41 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of JDK-8181383, commit [f16ddb2c](https://github.com/openjdk/jdk17u-dev/commit/f16ddb2c3d0edb60ce0521fc0e3920f831dbb3bf) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Alex Menkov on 26 Feb 2019 and was reviewed by Serguei Spitsyn and Chris Plummer. > > We see this error occasionally in our CI, so this backport will help to reduce noise. > > Thanks! GHA errors unrelated, got push approval. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2068#issuecomment-1669484300 From clanger at openjdk.org Tue Aug 8 12:08:53 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 8 Aug 2023 12:08:53 GMT Subject: [jdk11u-dev] Integrated: 8181383: com/sun/jdi/OptionTest.java fails intermittently with bind failed: Address already in use In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 22:45:41 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of JDK-8181383, commit [f16ddb2c](https://github.com/openjdk/jdk17u-dev/commit/f16ddb2c3d0edb60ce0521fc0e3920f831dbb3bf) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Alex Menkov on 26 Feb 2019 and was reviewed by Serguei Spitsyn and Chris Plummer. > > We see this error occasionally in our CI, so this backport will help to reduce noise. > > Thanks! This pull request has now been integrated. Changeset: daeb3620 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/daeb36203d49e1c6ff9ab11b8323d48f0438ea8a Stats: 42 lines in 2 files changed: 14 ins; 17 del; 11 mod 8181383: com/sun/jdi/OptionTest.java fails intermittently with bind failed: Address already in use Backport-of: f16ddb2c3d0edb60ce0521fc0e3920f831dbb3bf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2068 From clanger at openjdk.org Tue Aug 8 12:10:38 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 8 Aug 2023 12:10:38 GMT Subject: [jdk11u-dev] Integrated: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4 In-Reply-To: References: Message-ID: On Mon, 7 Aug 2023 08:13:58 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8269091](https://bugs.openjdk.org/browse/JDK-8269091), commit [b6a5d208](https://github.com/openjdk/jdk17u-dev/commit/b6a5d2082832c9d70051df8d4a5190f6a6faec58) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Matthias Baesken on 13 Jun 2023 and had no reviewers. > > Thanks! This pull request has now been integrated. Changeset: 06772f1d Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/06772f1d0c2fd778454d6f1dde45e208da0d2010 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4 Backport-of: b6a5d2082832c9d70051df8d4a5190f6a6faec58 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2069 From clanger at openjdk.org Tue Aug 8 12:11:37 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 8 Aug 2023 12:11:37 GMT Subject: [jdk11u-dev] Integrated: 8313803: [11u] Exclude jdk/jfr/event/sampling/TestStackFrameLineNumbers.java In-Reply-To: References: Message-ID: <_gAKMA3v8ZxBVzcyed6qHWQsgjGhMlw6qpYTBMxtr-Q=.1b0aaebf-95cb-4a25-9f30-e0ffb0d020b6@github.com> On Fri, 4 Aug 2023 22:44:11 GMT, Christoph Langer wrote: > The test jdk/jfr/event/sampling/TestStackFrameLineNumbers.java is shaky, ever since it was brought to 11u with 11.0.12. Unless this can be improved we should exclude it to avoid noise in the CI. This pull request has now been integrated. Changeset: d24c7dff Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/d24c7dff21a2adfc4c3275362040d40f3aa0fc8a Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8313803: [11u] Exclude jdk/jfr/event/sampling/TestStackFrameLineNumbers.java Reviewed-by: stuefe ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2067 From mdoerr at openjdk.org Tue Aug 8 12:23:03 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 8 Aug 2023 12:23:03 GMT Subject: [jdk17u-dev] RFR: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment Message-ID: Backport of [JDK-8289797](https://bugs.openjdk.org/browse/JDK-8289797). ------------- Commit messages: - Backport a11477ce259d6d2a053117a2300ebb171145cfde Changes: https://git.openjdk.org/jdk17u-dev/pull/1646/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1646&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289797 Stats: 51 lines in 1 file changed: 26 ins; 3 del; 22 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1646.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1646/head:pull/1646 PR: https://git.openjdk.org/jdk17u-dev/pull/1646 From mdoerr at openjdk.org Tue Aug 8 12:25:43 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 8 Aug 2023 12:25:43 GMT Subject: [jdk11u-dev] RFR: 8313878: Exclude two compiler/rtm/locking tests on ppc64le [v2] In-Reply-To: References: Message-ID: <5_8m0o7YF9NugWIeqNCCeGA_SHtH6jX9dWS931ACwrE=.d9d7af86-c963-47b1-97b4-34d5b23cbabb@github.com> On Tue, 8 Aug 2023 12:07:03 GMT, Christoph Langer wrote: >> The test compiler/rtm/locking/TestRTMSpinLoopCount.java fails very often in JDK11 on linux ppc64le and should be excluded to reduce noise in the CI infrastructure. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Also exclude TestRTMAbortThreshold and follow Martin's suggestion to exclude for generic-ppc64le > - Merge remote-tracking branch 'upstream/master' into JDK-8313878 > - JDK-8313878 Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2070#pullrequestreview-1567172978 From mdoerr at openjdk.org Tue Aug 8 12:25:59 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 8 Aug 2023 12:25:59 GMT Subject: [jdk17u-dev] RFR: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports Message-ID: Backport of [JDK-6381945](https://bugs.openjdk.org/browse/JDK-6381945). ------------- Commit messages: - Backport f79b3d42f07b703f0e3b9fc67c92dee260b0e602 Changes: https://git.openjdk.org/jdk17u-dev/pull/1647/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1647&range=00 Issue: https://bugs.openjdk.org/browse/JDK-6381945 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1647.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1647/head:pull/1647 PR: https://git.openjdk.org/jdk17u-dev/pull/1647 From mdoerr at openjdk.org Tue Aug 8 12:35:58 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 8 Aug 2023 12:35:58 GMT Subject: [jdk17u-dev] RFR: 8301167: Update VerifySignedJar to actually exercise and test verification Message-ID: Backport of [JDK-8301167](https://bugs.openjdk.org/browse/JDK-8301167). Clean, but deleted jar file differs. ------------- Commit messages: - Backport 05ea083b0563ddacf3e38dc329ba00dc4bac9b29 Changes: https://git.openjdk.org/jdk17u-dev/pull/1648/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1648&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301167 Stats: 110 lines in 2 files changed: 84 ins; 12 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1648.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1648/head:pull/1648 PR: https://git.openjdk.org/jdk17u-dev/pull/1648 From mdoerr at openjdk.org Tue Aug 8 12:47:48 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 8 Aug 2023 12:47:48 GMT Subject: [jdk17u-dev] RFR: 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext Message-ID: Backport of [JDK-8255548](https://bugs.openjdk.org/browse/JDK-8255548). ------------- Commit messages: - Backport 76cda9f44a80b1979e6e1b7a21431ef631f80782 Changes: https://git.openjdk.org/jdk17u-dev/pull/1649/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1649&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8255548 Stats: 46 lines in 1 file changed: 45 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1649.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1649/head:pull/1649 PR: https://git.openjdk.org/jdk17u-dev/pull/1649 From mdoerr at openjdk.org Tue Aug 8 12:51:51 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 8 Aug 2023 12:51:51 GMT Subject: [jdk17u-dev] RFR: 8307079: Update test java/awt/Choice/DragOffNoSelect.java Message-ID: Backport of [JDK-8307079](https://bugs.openjdk.org/browse/JDK-8307079). Tested manually on Mac M1. ------------- Commit messages: - Backport 89711f376751d4cfa05758705867afedfafeb602 Changes: https://git.openjdk.org/jdk17u-dev/pull/1650/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1650&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307079 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1650.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1650/head:pull/1650 PR: https://git.openjdk.org/jdk17u-dev/pull/1650 From mdoerr at openjdk.org Tue Aug 8 12:53:53 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 8 Aug 2023 12:53:53 GMT Subject: [jdk17u-dev] RFR: 8309095: Remove UTF-8 character from TaskbarPositionTest.java Message-ID: Backport of [JDK-8309095](https://bugs.openjdk.org/browse/JDK-8309095). ------------- Commit messages: - Backport 07f2070411b3bff5608166ceae0e0bdbf155e7c2 Changes: https://git.openjdk.org/jdk17u-dev/pull/1651/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1651&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309095 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1651.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1651/head:pull/1651 PR: https://git.openjdk.org/jdk17u-dev/pull/1651 From thartmann at openjdk.org Tue Aug 8 14:24:47 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 8 Aug 2023 14:24:47 GMT Subject: [jdk21u] Integrated: 8304954: SegmentedCodeCache fails when using large pages In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 10:18:48 GMT, Tobias Hartmann wrote: > Backport of [JDK-8304954](https://bugs.openjdk.java.net/browse/JDK-8304954). Applies cleanly. > > Thanks, > Tobias This pull request has now been integrated. Changeset: 515387d7 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk21u/commit/515387d71fe391e4f777f1bda4143df9db0c5d5d Stats: 115 lines in 3 files changed: 109 ins; 1 del; 5 mod 8304954: SegmentedCodeCache fails when using large pages Backport-of: cad6114e1c69bfebe5f7892c3e105b4c70d04398 ------------- PR: https://git.openjdk.org/jdk21u/pull/41 From thartmann at openjdk.org Tue Aug 8 14:24:47 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Tue, 8 Aug 2023 14:24:47 GMT Subject: [jdk21u] Integrated: 8312909: C1 should not inline through interface calls with non-subtype receiver In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 10:06:10 GMT, Tobias Hartmann wrote: > Backport of [JDK-8312909](https://bugs.openjdk.java.net/browse/JDK-8312909). Applies cleanly. > > Thanks, > Tobias This pull request has now been integrated. Changeset: 7350b3f5 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk21u/commit/7350b3f5c37aee603773d3d7451f65a18da57ff0 Stats: 109 lines in 3 files changed: 105 ins; 0 del; 4 mod 8312909: C1 should not inline through interface calls with non-subtype receiver Backport-of: ab1c212ac1097ae6e1122ef1aba47ca51eca11f2 ------------- PR: https://git.openjdk.org/jdk21u/pull/40 From aph at openjdk.org Tue Aug 8 17:36:41 2023 From: aph at openjdk.org (Andrew Haley) Date: Tue, 8 Aug 2023 17:36:41 GMT Subject: [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image In-Reply-To: References: Message-ID: On Fri, 28 Jul 2023 15:56:24 GMT, Andrew Leonard wrote: > Backport 8273092: Sort classlist in JDK image > to jdk17u so that classlist order is deterministic for reproducible builds. > > The original needed modifying, because jdk17u does not dump ":id" Klass id, it just dumps the class/lambda name. Marked as reviewed by aph (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1632#pullrequestreview-1567819120 From serb at openjdk.org Tue Aug 8 17:44:41 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 8 Aug 2023 17:44:41 GMT Subject: [jdk21u] Integrated: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0 In-Reply-To: <2PccSIRNyHlYyWiNkjP43u2rAeX-tt4bOLdesVk6JOo=.b92606ff-8823-46a2-8b72-428267b2e201@github.com> References: <2PccSIRNyHlYyWiNkjP43u2rAeX-tt4bOLdesVk6JOo=.b92606ff-8823-46a2-8b72-428267b2e201@github.com> Message-ID: <0k9CLvjHMG_20bkzm_Hg6eJx2M0_-SFiOyHlpE8f_CI=.8eb112ac-1257-4387-afcc-24cdbe9b8de8@github.com> On Thu, 3 Aug 2023 16:22:13 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 2 Aug 2023 and was reviewed by Aleksey Shipilev and Phil Race. > > Thanks! This pull request has now been integrated. Changeset: 51d128da Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u/commit/51d128dafd6e51eb591dd9dbc4517b4e527b65b6 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0 Backport-of: 8248e351d0bed263fb68d8468004a4286e6391af ------------- PR: https://git.openjdk.org/jdk21u/pull/39 From serb at openjdk.org Tue Aug 8 17:44:47 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 8 Aug 2023 17:44:47 GMT Subject: [jdk17u-dev] Integrated: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0 In-Reply-To: References: Message-ID: On Thu, 3 Aug 2023 05:12:27 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 2 Aug 2023 and was reviewed by Aleksey Shipilev and Phil Race. > > Thanks! This pull request has now been integrated. Changeset: a5cdc22d Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/a5cdc22db03ac72d6a1aad50fef0cf4f47c72408 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0 Backport-of: 8248e351d0bed263fb68d8468004a4286e6391af ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1635 From cjplummer at openjdk.org Tue Aug 8 19:25:43 2023 From: cjplummer at openjdk.org (Chris Plummer) Date: Tue, 8 Aug 2023 19:25:43 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows In-Reply-To: References: Message-ID: On Mon, 7 Aug 2023 00:48:11 GMT, Kimura Yukihiro wrote: > I would like to fix this issue > because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. > Testing: > all serviceability area tests jdk_svc, and a specific test to verify the fix. > > Could anyone review the fix please? > > Thanks, > Kimura Yukihiro We have the following in agent.properties: agent.err.invalid.state = Invalid agent state: {0} and it is used by: public static final String INVALID_STATE = "agent.err.invalid.state"; throw new RuntimeException(getText(INVALID_STATE, "Agent already started")); Shouldn't "Agent already started" also be text that we should localize in the properties files? If we did, I think this issue would go away. Since the above is the only reference to INVALID_STATE, we could just instead have: agent.err.invalid.state = Invalid agent state: Agent already started ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1670166936 From rreddy at openjdk.org Wed Aug 9 02:39:44 2023 From: rreddy at openjdk.org (Ravi Reddy) Date: Wed, 9 Aug 2023 02:39:44 GMT Subject: [jdk21u] RFR: 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors Message-ID: The test used a too-small heap for generic testing, and coupled with looking at freeMemory() it led to a less-than-ideal determinism of execution of the test. It is a clean backport of https://github.com/openjdk/jdk/commit/8c9d091f19760deece8daf3e57add85482b9f2a7 . ------------- Commit messages: - 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors Changes: https://git.openjdk.org/jdk21u/pull/46/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=46&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308047 Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/46.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/46/head:pull/46 PR: https://git.openjdk.org/jdk21u/pull/46 From abhiscxk at openjdk.org Wed Aug 9 06:07:45 2023 From: abhiscxk at openjdk.org (Abhishek Kumar) Date: Wed, 9 Aug 2023 06:07:45 GMT Subject: [jdk21u] RFR: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem Message-ID: This is backport of https://bugs.openjdk.org/browse/JDK-8311160 to jdk21u. VoiceOver doesn't announce anything for JRadioButtonMenuItem and JCheckBoxMenuItem when navigated with down arrow key. JRadioButtonMenuItem and JCheckBoxMenuItem are having an accessible role of RadioButton and CheckBox respectively and it is required to notify native side whenever they are selected. Added the required fix and tested with SwingSet2 application. CI testing is also fine. Fix can be tested with SwingSet2 application and test instructions are mentioned in [JDK-8311160](https://bugs.openjdk.org/browse/JDK-8311160) description. ------------- Commit messages: - Backport c1f4595e64b0ea0439c6e7f61a6a92b56b526d97 Changes: https://git.openjdk.org/jdk21u/pull/48/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=48&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311160 Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/48.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/48/head:pull/48 PR: https://git.openjdk.org/jdk21u/pull/48 From abhiscxk at openjdk.org Wed Aug 9 06:14:35 2023 From: abhiscxk at openjdk.org (Abhishek Kumar) Date: Wed, 9 Aug 2023 06:14:35 GMT Subject: [jdk21u] RFR: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 06:01:49 GMT, Abhishek Kumar wrote: > This is backport of https://bugs.openjdk.org/browse/JDK-8311160 to jdk21u. > > VoiceOver doesn't announce anything for JRadioButtonMenuItem and JCheckBoxMenuItem when navigated with down arrow key. JRadioButtonMenuItem and JCheckBoxMenuItem are having an accessible role of RadioButton and CheckBox respectively and it is required to notify native side whenever they are selected. > > Added the required fix and tested with SwingSet2 application. CI testing is also fine. > > Fix can be tested with SwingSet2 application and test instructions are mentioned in [JDK-8311160](https://bugs.openjdk.org/browse/JDK-8311160) description. @azuev-java and @savoptik Please review. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/48#issuecomment-1670731539 From duke at openjdk.org Wed Aug 9 07:28:33 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Wed, 9 Aug 2023 07:28:33 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v2] In-Reply-To: References: Message-ID: > I would like to fix this issue > because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. > Testing: > all serviceability area tests jdk_svc, and a specific test to verify the fix. > > Could anyone review the fix please? > > Thanks, > Kimura Yukihiro Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge master - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1641/files - new: https://git.openjdk.org/jdk17u-dev/pull/1641/files/4a249da2..0e2813dc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1641&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1641&range=00-01 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1641.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1641/head:pull/1641 PR: https://git.openjdk.org/jdk17u-dev/pull/1641 From andrewlu at openjdk.org Wed Aug 9 08:03:30 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 9 Aug 2023 08:03:30 GMT Subject: [jdk11u-dev] RFR: 8306954: Open source five Focus related tests Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport 6d6d00b69cea47ccbe05a844db0fb6c384045caa Changes: https://git.openjdk.org/jdk11u-dev/pull/2071/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2071&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306954 Stats: 962 lines in 5 files changed: 962 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2071.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2071/head:pull/2071 PR: https://git.openjdk.org/jdk11u-dev/pull/2071 From andrewlu at openjdk.org Wed Aug 9 08:17:03 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 9 Aug 2023 08:17:03 GMT Subject: [jdk11u-dev] RFR: 8306955: Open source several JComboBox jtreg tests Message-ID: <1iEji4b_hiBxvtTRUQMyWJgS62-BCBhVpXvKudjK4VE=.730e35c7-2a67-4e5b-84b2-42874a0bcaa1@github.com> I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport 1f689241cfcb4083cba283a2010b532948865283 Changes: https://git.openjdk.org/jdk11u-dev/pull/2072/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2072&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306955 Stats: 392 lines in 5 files changed: 392 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2072.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2072/head:pull/2072 PR: https://git.openjdk.org/jdk11u-dev/pull/2072 From shade at openjdk.org Wed Aug 9 08:36:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 9 Aug 2023 08:36:59 GMT Subject: [jdk21u] RFR: 8313402: C1: Incorrect LoadIndexed value numbering In-Reply-To: References: Message-ID: On Thu, 3 Aug 2023 09:32:59 GMT, Aleksey Shipilev wrote: > Clean backport to fix the important C1 bug. > > Additional testing: > - [x] New regression test fails without the patch, passes with it > - [x] Linux AArch64 `fastdebug` `tier1 tier2 tier3` Reviews are here, testing is clean, GHA failures are infra issues. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/37#issuecomment-1670885029 From shade at openjdk.org Wed Aug 9 08:36:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 9 Aug 2023 08:36:59 GMT Subject: [jdk21u] RFR: 8313707: GHA: Bootstrap sysroots with --variant=minbase In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 11:25:23 GMT, Aleksey Shipilev wrote: > Clean backport to improve and fix GHA. > > Additional testing: > - [x] GHA GHAs are clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/43#issuecomment-1670883324 From shade at openjdk.org Wed Aug 9 08:37:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 9 Aug 2023 08:37:28 GMT Subject: [jdk21u] Integrated: 8313707: GHA: Bootstrap sysroots with --variant=minbase In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 11:25:23 GMT, Aleksey Shipilev wrote: > Clean backport to improve and fix GHA. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 134e2702 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/134e2702e61e2da9027fe29a011bd5be25644b8f Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8313707: GHA: Bootstrap sysroots with --variant=minbase Backport-of: 29f1d8ef50e3b4b235177fd9642a1fcf26fe3bab ------------- PR: https://git.openjdk.org/jdk21u/pull/43 From shade at openjdk.org Wed Aug 9 08:37:29 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 9 Aug 2023 08:37:29 GMT Subject: [jdk21u] Integrated: 8313402: C1: Incorrect LoadIndexed value numbering In-Reply-To: References: Message-ID: On Thu, 3 Aug 2023 09:32:59 GMT, Aleksey Shipilev wrote: > Clean backport to fix the important C1 bug. > > Additional testing: > - [x] New regression test fails without the patch, passes with it > - [x] Linux AArch64 `fastdebug` `tier1 tier2 tier3` This pull request has now been integrated. Changeset: fd7a104b Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/fd7a104bebeca01ea2f6c3f2f22cf44f8963a1a0 Stats: 59 lines in 2 files changed: 58 ins; 0 del; 1 mod 8313402: C1: Incorrect LoadIndexed value numbering Reviewed-by: thartmann Backport-of: 46fbedb2be98a9b8aba042fa9f90c3b25c312cd6 ------------- PR: https://git.openjdk.org/jdk21u/pull/37 From duke at openjdk.org Wed Aug 9 09:09:58 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Wed, 9 Aug 2023 09:09:58 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v2] In-Reply-To: References: Message-ID: <8INq0E3nflJJK15gmijmEKIcfSuNE4koMJOZvPNvZqw=.40a47e14-4662-4217-812a-3fa92469b7f3@github.com> On Wed, 9 Aug 2023 07:28:33 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Hello Chris, Thank you for your review. I'll consider it. Thanks, Kimura Yukihiro ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1670932454 From asemenov at openjdk.org Wed Aug 9 09:21:30 2023 From: asemenov at openjdk.org (Artem Semenov) Date: Wed, 9 Aug 2023 09:21:30 GMT Subject: [jdk21u] RFR: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 06:01:49 GMT, Abhishek Kumar wrote: > This is backport of https://bugs.openjdk.org/browse/JDK-8311160 to jdk21u. > > VoiceOver doesn't announce anything for JRadioButtonMenuItem and JCheckBoxMenuItem when navigated with down arrow key. JRadioButtonMenuItem and JCheckBoxMenuItem are having an accessible role of RadioButton and CheckBox respectively and it is required to notify native side whenever they are selected. > > Added the required fix and tested with SwingSet2 application. CI testing is also fine. > > Fix can be tested with SwingSet2 application and test instructions are mentioned in [JDK-8311160](https://bugs.openjdk.org/browse/JDK-8311160) description. LGTM ------------- Marked as reviewed by asemenov (Committer). PR Review: https://git.openjdk.org/jdk21u/pull/48#pullrequestreview-1569102711 From shade at openjdk.org Wed Aug 9 09:26:29 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 9 Aug 2023 09:26:29 GMT Subject: [jdk21u] RFR: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly Message-ID: Clean backport to improve the test. Additional testing: - [x] macosx-aarch64-server-fastdebug, the affected test is still sensitive to original fix ------------- Commit messages: - Backport 4b192a8dc37297f0746c0c68322e0168d9f47771 Changes: https://git.openjdk.org/jdk21u/pull/49/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=49&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313676 Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/49.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/49/head:pull/49 PR: https://git.openjdk.org/jdk21u/pull/49 From goetz at openjdk.org Wed Aug 9 11:17:58 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 9 Aug 2023 11:17:58 GMT Subject: [jdk17u-dev] RFR: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports In-Reply-To: References: Message-ID: <6BnxzNIAHK5eaWbYbSKkpldeZx3qaf2ijq72byHNiio=.1597ee60-6f24-40da-aaff-f346074bee03@github.com> On Tue, 8 Aug 2023 12:19:33 GMT, Martin Doerr wrote: > Backport of [JDK-6381945](https://bugs.openjdk.org/browse/JDK-6381945). Why are the pre submit tests failling? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1647#issuecomment-1671123665 From shade at openjdk.org Wed Aug 9 11:20:30 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 9 Aug 2023 11:20:30 GMT Subject: [jdk21u] RFR: 8313248: C2: setScopedValueCache intrinsic exposes nullptr pre-values to store barriers Message-ID: <1Q1tMtiYSKuCLoB30YDglG9B12XG-i9X6Xi2dbDiNaU=.9a595455-1b47-4e9e-9daa-7c3966cc27fd@github.com> Clean backport to fix Loom bug reproducing at least with Shenandoah, but also maybe with G1. Additional testing: - [x] macos-aarch64-server-fastdebug, original reproducer fails without the patch, passes with it ------------- Commit messages: - Backport e8a37b90db8dca4dc3653970b2d66d2faf8ef452 Changes: https://git.openjdk.org/jdk21u/pull/50/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=50&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313248 Stats: 22 lines in 2 files changed: 10 ins; 8 del; 4 mod Patch: https://git.openjdk.org/jdk21u/pull/50.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/50/head:pull/50 PR: https://git.openjdk.org/jdk21u/pull/50 From shade at openjdk.org Wed Aug 9 11:25:58 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 9 Aug 2023 11:25:58 GMT Subject: [jdk21u] RFR: 8293114: JVM should trim the native heap [v2] In-Reply-To: <5fBNmS5U8R6UvZwIzlHEtDaWQqC6u7tjNe-x-bElhV0=.4520f49d-7f42-4490-98dd-3ed4c3fa35c7@github.com> References: <5fBNmS5U8R6UvZwIzlHEtDaWQqC6u7tjNe-x-bElhV0=.4520f49d-7f42-4490-98dd-3ed4c3fa35c7@github.com> Message-ID: > Clean backport to get the important feature to LTS users. > > Additional testing: > - [x] Linux AArch64 fastdebug trimming tests > - [x] Linux AArch64 fastdebug `tier1` > - [x] Linux AArch64 fastdebug `tier2` > - [x] Linux AArch64 fastdebug `tier3` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8293114-trim-native-heap - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/13/files - new: https://git.openjdk.org/jdk21u/pull/13/files/5300bdaf..c26a154a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=13&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=13&range=00-01 Stats: 46817 lines in 329 files changed: 4409 ins; 40908 del; 1500 mod Patch: https://git.openjdk.org/jdk21u/pull/13.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/13/head:pull/13 PR: https://git.openjdk.org/jdk21u/pull/13 From mdoerr at openjdk.org Wed Aug 9 13:37:29 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 9 Aug 2023 13:37:29 GMT Subject: [jdk17u-dev] RFR: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports In-Reply-To: References: Message-ID: On Tue, 8 Aug 2023 12:19:33 GMT, Martin Doerr wrote: > Backport of [JDK-6381945](https://bugs.openjdk.org/browse/JDK-6381945). "E: Version '10.3.0-1ubuntu1~20.04' for 'gcc-10' was not found". Unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1647#issuecomment-1671315751 From mdoerr at openjdk.org Wed Aug 9 13:37:30 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 9 Aug 2023 13:37:30 GMT Subject: [jdk17u-dev] Integrated: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest In-Reply-To: References: Message-ID: On Mon, 7 Aug 2023 20:18:17 GMT, Martin Doerr wrote: > Backport of [JDK-8267860](https://bugs.openjdk.org/browse/JDK-8267860). This pull request has now been integrated. Changeset: 4786a004 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/4786a004e7d1c9136f4ccaba6dc985a28934eb41 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest Backport-of: 2adef6a1f84d478bb38b179795f08ffa43680e36 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1644 From mdoerr at openjdk.org Wed Aug 9 13:37:30 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 9 Aug 2023 13:37:30 GMT Subject: [jdk17u-dev] Integrated: 8195589: T6587786.java failed after JDK-8189997 In-Reply-To: References: Message-ID: On Mon, 7 Aug 2023 20:10:23 GMT, Martin Doerr wrote: > Backport of [JDK-8195589](https://bugs.openjdk.java.net/browse/JDK-8195589). This pull request has now been integrated. Changeset: 2f5a9527 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/2f5a9527fee0f380b515d41200dbf6db421183a5 Stats: 11 lines in 2 files changed: 3 ins; 1 del; 7 mod 8195589: T6587786.java failed after JDK-8189997 Backport-of: 21b62fef335aa981a239415532fa8b804fb5676d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1643 From mdoerr at openjdk.org Wed Aug 9 13:37:30 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 9 Aug 2023 13:37:30 GMT Subject: [jdk17u-dev] Integrated: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment In-Reply-To: References: Message-ID: On Tue, 8 Aug 2023 12:16:12 GMT, Martin Doerr wrote: > Backport of [JDK-8289797](https://bugs.openjdk.org/browse/JDK-8289797). This pull request has now been integrated. Changeset: 6349de60 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/6349de605cc5da32a6bf094243ba9e9f7a07a7b0 Stats: 51 lines in 1 file changed: 26 ins; 3 del; 22 mod 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment Backport-of: a11477ce259d6d2a053117a2300ebb171145cfde ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1646 From mdoerr at openjdk.org Wed Aug 9 13:37:31 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 9 Aug 2023 13:37:31 GMT Subject: [jdk17u-dev] Integrated: 8309095: Remove UTF-8 character from TaskbarPositionTest.java In-Reply-To: References: Message-ID: <9tlvhsEel8MsdyeD-K_PPTiV41yY3X4Be667dhsjpuQ=.9ca4f281-9031-4b79-973e-52454db8e0d6@github.com> On Tue, 8 Aug 2023 12:46:34 GMT, Martin Doerr wrote: > Backport of [JDK-8309095](https://bugs.openjdk.org/browse/JDK-8309095). This pull request has now been integrated. Changeset: 9c8731bd Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/9c8731bddeff5c134d81c1d3f9c0f3dea43dde5f Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8309095: Remove UTF-8 character from TaskbarPositionTest.java Backport-of: 07f2070411b3bff5608166ceae0e0bdbf155e7c2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1651 From clanger at openjdk.org Wed Aug 9 14:52:58 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 9 Aug 2023 14:52:58 GMT Subject: [jdk17u-dev] Integrated: 8302182: Update Public Suffix List to 88467c9 In-Reply-To: <9Tnu2BOT-kgojQKexSyM7ur3RbYjY-uP4L_qeyX5PcY=.1e55aa1d-95a3-43ab-b6b9-82d32e4cf8c8@github.com> References: <9Tnu2BOT-kgojQKexSyM7ur3RbYjY-uP4L_qeyX5PcY=.1e55aa1d-95a3-43ab-b6b9-82d32e4cf8c8@github.com> Message-ID: On Mon, 7 Aug 2023 16:29:17 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8302182](https://bugs.openjdk.org/browse/JDK-8302182), commit [01b85129](https://github.com/openjdk/jdk/commit/01b85129116dd2cc762e518ac631305bd8511764) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Weijun Wang on 26 Apr 2023 and was reviewed by Sean Mullan. > > It contains an update of the public suffix list which should be brought to update releases to keep them up to date as well. > > Thanks! This pull request has now been integrated. Changeset: ec2abc2d Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/ec2abc2d82bf737258ae8ee0bba8ba6a15e1dabb Stats: 1479 lines in 5 files changed: 647 ins; 697 del; 135 mod 8302182: Update Public Suffix List to 88467c9 Backport-of: 01b85129116dd2cc762e518ac631305bd8511764 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1642 From clanger at openjdk.org Wed Aug 9 14:54:00 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 9 Aug 2023 14:54:00 GMT Subject: [jdk11u-dev] Integrated: 8313878: Exclude two compiler/rtm/locking tests on ppc64le In-Reply-To: References: Message-ID: <_Nwt4iepY18SDOtHBY_H8Fw4W4NLAum7D81Heznp4gA=.21b33907-1be8-4633-9572-2d69175296d8@github.com> On Mon, 7 Aug 2023 11:58:33 GMT, Christoph Langer wrote: > The test compiler/rtm/locking/TestRTMSpinLoopCount.java fails very often in JDK11 on linux ppc64le and should be excluded to reduce noise in the CI infrastructure. This pull request has now been integrated. Changeset: 6faea22b Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/6faea22b528a459294d2c2ae425275dfba824396 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8313878: Exclude two compiler/rtm/locking tests on ppc64le Reviewed-by: mdoerr ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2070 From mdoerr at openjdk.org Wed Aug 9 14:54:36 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 9 Aug 2023 14:54:36 GMT Subject: [jdk17u-dev] RFR: 8308090: Add container tests for on-the-fly resource quota updates Message-ID: Backport of [JDK-8308090](https://bugs.openjdk.org/browse/JDK-8308090). ------------- Commit messages: - Backport dc8bc6c98ca1f9b441cf71c641675fe29dda9162 Changes: https://git.openjdk.org/jdk17u-dev/pull/1652/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1652&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308090 Stats: 434 lines in 5 files changed: 431 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1652.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1652/head:pull/1652 PR: https://git.openjdk.org/jdk17u-dev/pull/1652 From mdoerr at openjdk.org Wed Aug 9 15:41:34 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 9 Aug 2023 15:41:34 GMT Subject: [jdk17u-dev] RFR: 8156889: ListKeychainStore.sh fails in some virtualized environments Message-ID: Backport of [JDK-8156889](https://bugs.openjdk.org/browse/JDK-8156889). ------------- Commit messages: - Backport 82c8b28f4005c3c335d4fd60c2e3b55adfd200c6 Changes: https://git.openjdk.org/jdk17u-dev/pull/1653/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1653&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8156889 Stats: 449 lines in 4 files changed: 202 ins; 247 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1653.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1653/head:pull/1653 PR: https://git.openjdk.org/jdk17u-dev/pull/1653 From mdoerr at openjdk.org Wed Aug 9 15:55:58 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 9 Aug 2023 15:55:58 GMT Subject: [jdk17u-dev] RFR: 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt Message-ID: Backport of [JDK-8310551](https://bugs.openjdk.org/browse/JDK-8310551). ------------- Commit messages: - Backport c84866ac0dcda487fe2abc2a8841f237df0a395b Changes: https://git.openjdk.org/jdk17u-dev/pull/1654/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1654&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310551 Stats: 8 lines in 2 files changed: 1 ins; 1 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1654.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1654/head:pull/1654 PR: https://git.openjdk.org/jdk17u-dev/pull/1654 From shade at openjdk.org Wed Aug 9 16:09:58 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 9 Aug 2023 16:09:58 GMT Subject: [jdk21u] RFR: 8293114: JVM should trim the native heap [v2] In-Reply-To: References: <5fBNmS5U8R6UvZwIzlHEtDaWQqC6u7tjNe-x-bElhV0=.4520f49d-7f42-4490-98dd-3ed4c3fa35c7@github.com> Message-ID: On Mon, 31 Jul 2023 16:47:28 GMT, Thomas Stuefe wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge branch 'master' into JDK-8293114-trim-native-heap >> - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 > > Good + Thanks! > > Same as for 17, I would let it steam a bit in 22, if for no other reason than to see if other intermittent issues come up. I think we are ready for 21u, @tstuefe? ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/13#issuecomment-1671674454 From stuefe at openjdk.org Wed Aug 9 16:37:29 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 9 Aug 2023 16:37:29 GMT Subject: [jdk21u] RFR: 8293114: JVM should trim the native heap [v2] In-Reply-To: References: <5fBNmS5U8R6UvZwIzlHEtDaWQqC6u7tjNe-x-bElhV0=.4520f49d-7f42-4490-98dd-3ed4c3fa35c7@github.com> Message-ID: On Wed, 9 Aug 2023 11:25:58 GMT, Aleksey Shipilev wrote: >> Clean backport to get the important feature to LTS users. >> >> Additional testing: >> - [x] Linux AArch64 fastdebug trimming tests >> - [x] Linux AArch64 fastdebug `tier1` >> - [x] Linux AArch64 fastdebug `tier2` >> - [x] Linux AArch64 fastdebug `tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8293114-trim-native-heap > - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 I think so too. No new issues have crept up. Thanks for doing this! ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/13#issuecomment-1671733238 From shade at openjdk.org Wed Aug 9 16:44:01 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 9 Aug 2023 16:44:01 GMT Subject: [jdk21u] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction [v2] In-Reply-To: <9sKqCy5LS17_Kn92yLb2o2WgBrGOCHnWxd9qnuXtVm0=.62e537f8-de85-43f0-a92b-ec0a69ede1ad@github.com> References: <9sKqCy5LS17_Kn92yLb2o2WgBrGOCHnWxd9qnuXtVm0=.62e537f8-de85-43f0-a92b-ec0a69ede1ad@github.com> Message-ID: > Semi-clean follow-up backport to relax the test. > > There are no `ProblemList` additions in 21u, so this changeset does not have the relevant hunk. > > Additional testing: > - [x] Linux x86_64 fastdebug, affected test Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport ad34be1f329edc8e7155983835cc70d733c014b8 ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/26/files - new: https://git.openjdk.org/jdk21u/pull/26/files/9009d8e6..c5794abb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=26&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=26&range=00-01 Stats: 46817 lines in 329 files changed: 4409 ins; 40908 del; 1500 mod Patch: https://git.openjdk.org/jdk21u/pull/26.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/26/head:pull/26 PR: https://git.openjdk.org/jdk21u/pull/26 From shade at openjdk.org Wed Aug 9 16:44:58 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 9 Aug 2023 16:44:58 GMT Subject: [jdk21u] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction In-Reply-To: <9sKqCy5LS17_Kn92yLb2o2WgBrGOCHnWxd9qnuXtVm0=.62e537f8-de85-43f0-a92b-ec0a69ede1ad@github.com> References: <9sKqCy5LS17_Kn92yLb2o2WgBrGOCHnWxd9qnuXtVm0=.62e537f8-de85-43f0-a92b-ec0a69ede1ad@github.com> Message-ID: On Mon, 31 Jul 2023 09:21:27 GMT, Aleksey Shipilev wrote: > Semi-clean follow-up backport to relax the test. > > There are no `ProblemList` additions in 21u, so this changeset does not have the relevant hunk. > > Additional testing: > - [x] Linux x86_64 fastdebug, affected test @tstuefe, please ack this? ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/26#issuecomment-1671738037 From serb at openjdk.org Wed Aug 9 16:56:58 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 9 Aug 2023 16:56:58 GMT Subject: [jdk17u-dev] Integrated: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs In-Reply-To: References: Message-ID: On Tue, 8 Aug 2023 00:27:51 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [d4a795d7](https://github.com/openjdk/jdk/commit/d4a795d75aef8d787934f5c05e146c61138a408a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Peter Levart on 4 Aug 2022 and was reviewed by Roman Kennke and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: fe3920e6 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/fe3920e63bdeb81947091c1fa5fc66b785f98a7f Stats: 96 lines in 1 file changed: 69 ins; 11 del; 16 mod 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs Backport-of: d4a795d75aef8d787934f5c05e146c61138a408a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1645 From stuefe at openjdk.org Wed Aug 9 17:09:29 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 9 Aug 2023 17:09:29 GMT Subject: [jdk21u] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction [v2] In-Reply-To: References: <9sKqCy5LS17_Kn92yLb2o2WgBrGOCHnWxd9qnuXtVm0=.62e537f8-de85-43f0-a92b-ec0a69ede1ad@github.com> Message-ID: On Wed, 9 Aug 2023 16:44:01 GMT, Aleksey Shipilev wrote: >> Semi-clean follow-up backport to relax the test. >> >> There are no `ProblemList` additions in 21u, so this changeset does not have the relevant hunk. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug, affected test > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport ad34be1f329edc8e7155983835cc70d733c014b8 Good! ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk21u/pull/26#pullrequestreview-1570140763 From cjplummer at openjdk.org Wed Aug 9 17:10:58 2023 From: cjplummer at openjdk.org (Chris Plummer) Date: Wed, 9 Aug 2023 17:10:58 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v2] In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 07:28:33 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows If you are going to go with the localization of "Agent already started" approach, it should probably be done in 22 and then backported. If you want to just go with your current fix, that's ok to. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1671818503 From duke at openjdk.org Wed Aug 9 18:41:29 2023 From: duke at openjdk.org (duke) Date: Wed, 9 Aug 2023 18:41:29 GMT Subject: [jdk11u-dev] Withdrawn: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 08:09:57 GMT, Frederic Thevenet wrote: > Hi, > > This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > Original patch does not apply cleanly to 11u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. > > GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. > > Thanks. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1942 From fthevenet at openjdk.org Wed Aug 9 18:49:28 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Wed, 9 Aug 2023 18:49:28 GMT Subject: [jdk11u-dev] RFR: 8309959: JFR: Display N/A for missing data amount [v2] In-Reply-To: <6foGCFra_mjZVlPkaJxYpYDMbXIm1LjKYXaRVnoOqGI=.99ce53cf-9c34-49b0-b2d8-0752dc717476@github.com> References: <6foGCFra_mjZVlPkaJxYpYDMbXIm1LjKYXaRVnoOqGI=.99ce53cf-9c34-49b0-b2d8-0752dc717476@github.com> Message-ID: > This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount. > > It is a follow up to the backport of [JDK-8309550](https://github.com/openjdk/jdk17u-dev/pull/1438): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported. > > A run of the Jdk_jfr test suite via GHA will be available here: https://github.com/fthevenet/jdk11u-dev/actions/runs/5324629652 > > Thanks Frederic Thevenet has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1969/files - new: https://git.openjdk.org/jdk11u-dev/pull/1969/files/b25d2d5f..b25d2d5f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1969&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1969&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1969.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1969/head:pull/1969 PR: https://git.openjdk.org/jdk11u-dev/pull/1969 From xliu at openjdk.org Wed Aug 9 19:10:28 2023 From: xliu at openjdk.org (Xin Liu) Date: Wed, 9 Aug 2023 19:10:28 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v2] In-Reply-To: References: Message-ID: On Mon, 7 Aug 2023 09:20:49 GMT, Thomas Stuefe wrote: >> Xin Liu has updated the pull request incrementally with one additional commit since the last revision: >> >> Revert resourceHash.hpp and use functor instead of C++ lambda. > > Hi Xin :) > >> Hi, Thomas, >> >> Thanks you for the comments. I was told that it is better reducing memory footprint of UL in jdk17u, a LTS Java. > > Interesting, I'm curious about the effectiveness of your patch. Do you see good results? I would have thought that a lot of these interleaving memory requests are just taken from and handed back into fastbins or tcache, and therefore don't make the arena grow. Also, the glibc attempts to reclaim memory automatically are quite limited (see PR description https://github.com/openjdk/jdk/pull/14781#issue-1790932923) > >> May I learn more about glibc autotrim? Is it a glibc feature or a new feature of hotspot? >> >> I found [JDK-8268893](https://bugs.openjdk.org/browse/JDK-8268893) on JBS. It itself is a very useful feature! It is not an automatic trimmer, is it? > > Its https://bugs.openjdk.org/browse/JDK-8293114. You have to manually enable it, it is still marked as experimental. Also not in 17 yet, but Aleksey is preparing things to get it down quickly once it has baked in head a bit. > > Essentially, what the trimmer does is run periodically a malloc_trim() operation. malloc_trim() will reclaim memory that has been free'd and that is in page granularity (so, it will also reclaim memory in the middle of an arena). > > Cheers, Thomas hi, @tstuefe, I think we need both of them. This patch refrains from using any malloc/free in the first place. It also helps avoid the fragmentation issue. Autotrimmer is a general solution for glibc overprovision. Should we still consider to include this patch in jdk17u? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#issuecomment-1671961761 From clanger at openjdk.org Wed Aug 9 22:07:32 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 9 Aug 2023 22:07:32 GMT Subject: [jdk11u-dev] RFR: 8302182: Update Public Suffix List to 88467c9 Message-ID: Hi all, This pull request contains a backport of [JDK-8302182](https://bugs.openjdk.org/browse/JDK-8302182), commit [ec2abc2d](https://github.com/openjdk/jdk17u-dev/commit/ec2abc2d82bf737258ae8ee0bba8ba6a15e1dabb) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. The commit being backported was authored by Christoph Langer on 9 Aug 2023 and had no reviewers. Thanks! ------------- Commit messages: - Backport ec2abc2d82bf737258ae8ee0bba8ba6a15e1dabb Changes: https://git.openjdk.org/jdk11u-dev/pull/2073/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2073&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302182 Stats: 1479 lines in 5 files changed: 647 ins; 697 del; 135 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2073.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2073/head:pull/2073 PR: https://git.openjdk.org/jdk11u-dev/pull/2073 From duke at openjdk.org Thu Aug 10 03:00:29 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Thu, 10 Aug 2023 03:00:29 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v2] In-Reply-To: References: Message-ID: <3PeiZOnfXtcmuFkVHxzdoPeuLoJXk4dL7ZY-hSQwJzk=.ec94504d-eae5-4cd9-ba99-4799dbd515fa@github.com> On Wed, 9 Aug 2023 07:28:33 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Hello Chris, Thank you for your comments. I think your suggestion is to set a localized exception message or the English message to the RuntimeException. I'm sorry if I misunderstood. I prefer to modify jcmd (HotSpotVirtualMachine.java) for two reasons. First, ManagementAgent.start can specify jmxremote.host, so the encoding may be different from the host running jcmd. Second, I think setting a localized message to a RuntimeException is not desirable. It would be nice to change the message to English on the localized environment, but from JDK18, the localized message is output correctly. I believe it's not necessary to fix JDK22 as this issue doesn't occur owing to JEP 400. Thanks, Kimura Yukihiro ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1672468638 From stuefe at openjdk.org Thu Aug 10 05:09:29 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 10 Aug 2023 05:09:29 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v2] In-Reply-To: References: Message-ID: On Mon, 7 Aug 2023 09:20:49 GMT, Thomas Stuefe wrote: >> Xin Liu has updated the pull request incrementally with one additional commit since the last revision: >> >> Revert resourceHash.hpp and use functor instead of C++ lambda. > > Hi Xin :) > >> Hi, Thomas, >> >> Thanks you for the comments. I was told that it is better reducing memory footprint of UL in jdk17u, a LTS Java. > > Interesting, I'm curious about the effectiveness of your patch. Do you see good results? I would have thought that a lot of these interleaving memory requests are just taken from and handed back into fastbins or tcache, and therefore don't make the arena grow. Also, the glibc attempts to reclaim memory automatically are quite limited (see PR description https://github.com/openjdk/jdk/pull/14781#issue-1790932923) > >> May I learn more about glibc autotrim? Is it a glibc feature or a new feature of hotspot? >> >> I found [JDK-8268893](https://bugs.openjdk.org/browse/JDK-8268893) on JBS. It itself is a very useful feature! It is not an automatic trimmer, is it? > > Its https://bugs.openjdk.org/browse/JDK-8293114. You have to manually enable it, it is still marked as experimental. Also not in 17 yet, but Aleksey is preparing things to get it down quickly once it has baked in head a bit. > > Essentially, what the trimmer does is run periodically a malloc_trim() operation. malloc_trim() will reclaim memory that has been free'd and that is in page granularity (so, it will also reclaim memory in the middle of an arena). > > Cheers, Thomas > hi, @tstuefe, > > I think we need both of them. This patch refrains from using any malloc/free in the first place. It also helps avoid the fragmentation issue. Autotrimmer is a general solution for glibc overprovision. > > Should we still consider to include this patch in jdk17u? I don't want to block this patch, so sure. I just would have liked to know what the strategy brings in terms of RSS. Plain curiousity. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#issuecomment-1672555490 From mdoerr at openjdk.org Thu Aug 10 08:52:00 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 10 Aug 2023 08:52:00 GMT Subject: [jdk17u-dev] Integrated: 8307079: Update test java/awt/Choice/DragOffNoSelect.java In-Reply-To: References: Message-ID: <9qEWnv7z2l7ATCRlZh4ucQozDCh3AVs7k-YOIzYbQX8=.9c3f7e38-80a4-4bd5-bab8-5dd5a18c0984@github.com> On Tue, 8 Aug 2023 12:44:03 GMT, Martin Doerr wrote: > Backport of [JDK-8307079](https://bugs.openjdk.org/browse/JDK-8307079). Tested manually on Mac M1. This pull request has now been integrated. Changeset: 3d868105 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/3d868105588d379585b9172fc7a613f1cb51315b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8307079: Update test java/awt/Choice/DragOffNoSelect.java Backport-of: 89711f376751d4cfa05758705867afedfafeb602 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1650 From mdoerr at openjdk.org Thu Aug 10 08:52:02 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 10 Aug 2023 08:52:02 GMT Subject: [jdk17u-dev] Integrated: 8301167: Update VerifySignedJar to actually exercise and test verification In-Reply-To: References: Message-ID: On Tue, 8 Aug 2023 12:29:20 GMT, Martin Doerr wrote: > Backport of [JDK-8301167](https://bugs.openjdk.org/browse/JDK-8301167). This pull request has now been integrated. Changeset: 8aad6965 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/8aad696538397934198671faa0fffce1684ed1b0 Stats: 110 lines in 2 files changed: 84 ins; 12 del; 14 mod 8301167: Update VerifySignedJar to actually exercise and test verification Backport-of: 05ea083b0563ddacf3e38dc329ba00dc4bac9b29 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1648 From mdoerr at openjdk.org Thu Aug 10 08:52:03 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 10 Aug 2023 08:52:03 GMT Subject: [jdk17u-dev] Integrated: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports In-Reply-To: References: Message-ID: On Tue, 8 Aug 2023 12:19:33 GMT, Martin Doerr wrote: > Backport of [JDK-6381945](https://bugs.openjdk.org/browse/JDK-6381945). This pull request has now been integrated. Changeset: 242513fb Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/242513fbcd10e1fb9f09fe6a2dae5f15253de45c Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports Backport-of: f79b3d42f07b703f0e3b9fc67c92dee260b0e602 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1647 From mdoerr at openjdk.org Thu Aug 10 08:52:04 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 10 Aug 2023 08:52:04 GMT Subject: [jdk17u-dev] Integrated: 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext In-Reply-To: References: Message-ID: On Tue, 8 Aug 2023 12:41:59 GMT, Martin Doerr wrote: > Backport of [JDK-8255548](https://bugs.openjdk.org/browse/JDK-8255548). This pull request has now been integrated. Changeset: fe9b7c69 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/fe9b7c69714b86c2784273f0d53b21d167400392 Stats: 46 lines in 1 file changed: 45 ins; 0 del; 1 mod 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext Backport-of: 76cda9f44a80b1979e6e1b7a21431ef631f80782 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1649 From duke at openjdk.org Thu Aug 10 09:13:30 2023 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 10 Aug 2023 09:13:30 GMT Subject: [jdk11u-dev] RFR: 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java Message-ID: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> I`d like to fix the bug reported in JDK-8314086. `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. This is causing compilation failure in ChildAlwaysOnTopTest.java. After fixing this typo, the test successfully passed. ------------- Commit messages: - 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java Changes: https://git.openjdk.org/jdk11u-dev/pull/2074/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2074&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314086 Stats: 1 line in 2 files changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2074.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2074/head:pull/2074 PR: https://git.openjdk.org/jdk11u-dev/pull/2074 From anleonar at redhat.com Thu Aug 10 09:56:16 2023 From: anleonar at redhat.com (Andrew Leonard) Date: Thu, 10 Aug 2023 10:56:16 +0100 Subject: Request for Sponsor: 8273092: Sort classlist in JDK image Message-ID: 8273092: Sort classlist in JDK image https://github.com/openjdk/jdk17u-dev/pull/1632#issuecomment-1672894478 is ready for integration, please can I request a Sponsor to merge this? Many thanks Andrew -------------- next part -------------- An HTML attachment was scrubbed... URL: From anleonar at redhat.com Thu Aug 10 10:15:37 2023 From: anleonar at redhat.com (Andrew Leonard) Date: Thu, 10 Aug 2023 11:15:37 +0100 Subject: Request for Sponsor: 8273092: Sort classlist in JDK image Message-ID: Thank you Thomas -------------- next part -------------- An HTML attachment was scrubbed... URL: From aleonard at openjdk.org Thu Aug 10 10:24:59 2023 From: aleonard at openjdk.org (Andrew Leonard) Date: Thu, 10 Aug 2023 10:24:59 GMT Subject: [jdk17u-dev] Integrated: 8273092: Sort classlist in JDK image In-Reply-To: References: Message-ID: <80SeHYwX1J8Ezq99INNFL9DQ4J412I-c-HYGnjRiOsw=.5a3a8a4d-5f71-426b-8e57-f050c152be55@github.com> On Fri, 28 Jul 2023 15:56:24 GMT, Andrew Leonard wrote: > Backport 8273092: Sort classlist in JDK image > to jdk17u so that classlist order is deterministic for reproducible builds. > > The original needed modifying, because jdk17u does not dump ":id" Klass id, it just dumps the class/lambda name. This pull request has now been integrated. Changeset: 762c351b Author: Andrew Leonard Committer: Thomas Stuefe URL: https://git.openjdk.org/jdk17u-dev/commit/762c351b6620ae1675276dd8b0fa2689c2e678ef Stats: 86 lines in 3 files changed: 82 ins; 0 del; 4 mod 8273092: Sort classlist in JDK image Reviewed-by: aph Backport-of: 1996f649a3a30b7ac4b547a762417f807f5fa414 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1632 From duke at openjdk.org Thu Aug 10 10:35:28 2023 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 10 Aug 2023 10:35:28 GMT Subject: [jdk11u-dev] RFR: 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v2] In-Reply-To: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: > I`d like to fix the bug reported in JDK-8314086. > `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. > This is causing compilation failure in ChildAlwaysOnTopTest.java. > After fixing this typo, the test successfully passed. Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2074/files - new: https://git.openjdk.org/jdk11u-dev/pull/2074/files/341bb139..4d7fa891 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2074&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2074&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2074.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2074/head:pull/2074 PR: https://git.openjdk.org/jdk11u-dev/pull/2074 From mdoerr at openjdk.org Thu Aug 10 10:56:01 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 10 Aug 2023 10:56:01 GMT Subject: [jdk17u-dev] RFR: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee Message-ID: Backport of [JDK-8308232](https://bugs.openjdk.org/browse/JDK-8308232). Recognized as clean (context differs because Loom is not it 17u). nsk/jdb tests have passed. ------------- Commit messages: - Backport c6f20db945c6217aea84cebd6c97dbf8b93c48a4 Changes: https://git.openjdk.org/jdk17u-dev/pull/1655/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1655&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308232 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1655.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1655/head:pull/1655 PR: https://git.openjdk.org/jdk17u-dev/pull/1655 From shade at openjdk.org Thu Aug 10 11:39:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 11:39:28 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v2] In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 19:40:10 GMT, Xin Liu wrote: >> This patch is *NOT* a clean backport. The logic part is exactly the same, but I have to adjust code in the following parts: >> 1. change from KVHashtable to ResourceHashtable because we want to use resourceArea instead of C_HEAP. >> 2. rewrite lambda expression using Functor. >> >> Testing: >> jdk-test1 tests including gtest. >> Manually check there's no malloc/free in runtime. > > Xin Liu has updated the pull request incrementally with one additional commit since the last revision: > > Revert resourceHash.hpp and use functor instead of C++ lambda. OK, this looks good, but I think we should fix/backport these two before backporting this one to 17u: https://bugs.openjdk.org/browse/JDK-8297302 (fixed, should be backported) https://bugs.openjdk.org/browse/JDK-8309067 (not fixed, should be dealt with first) src/hotspot/share/logging/logAsyncWriter.cpp line 77: > 75: if (!_buffer->push_back(output, decorations, msg)) { > 76: bool p_created; > 77: uint32_t* counter = _stats.put_if_absent(output, 0, &p_created); Just checking: the rewrite `add_if_absent` -> `put_if_absent` is needed, because the underlying type changed, right? ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1630#pullrequestreview-1571651821 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#discussion_r1289970916 From rreddy at openjdk.org Thu Aug 10 12:06:29 2023 From: rreddy at openjdk.org (Ravi Reddy) Date: Thu, 10 Aug 2023 12:06:29 GMT Subject: [jdk21u] Integrated: 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 02:32:56 GMT, Ravi Reddy wrote: > The test used a too-small heap for generic testing, and coupled with looking at freeMemory() it led to a less-than-ideal determinism of execution of the test. > It is a clean backport of https://github.com/openjdk/jdk/commit/8c9d091f19760deece8daf3e57add85482b9f2a7 . This pull request has now been integrated. Changeset: 588036aa Author: Ravi Reddy Committer: Rob McKenna URL: https://git.openjdk.org/jdk21u/commit/588036aa26c289dd756805aa92b22032c64cf765 Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors Backport-of: 8c9d091f19760deece8daf3e57add85482b9f2a7 ------------- PR: https://git.openjdk.org/jdk21u/pull/46 From shade at openjdk.org Thu Aug 10 12:06:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 12:06:28 GMT Subject: [jdk21u] RFR: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 08:59:55 GMT, Aleksey Shipilev wrote: > Clean backport to improve the test. > > Additional testing: > - [x] macosx-aarch64-server-fastdebug, the affected test is still sensitive to original fix Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/49#issuecomment-1673065675 From shade at openjdk.org Thu Aug 10 12:07:58 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 12:07:58 GMT Subject: [jdk21u] RFR: 8293114: JVM should trim the native heap [v2] In-Reply-To: References: <5fBNmS5U8R6UvZwIzlHEtDaWQqC6u7tjNe-x-bElhV0=.4520f49d-7f42-4490-98dd-3ed4c3fa35c7@github.com> Message-ID: On Wed, 9 Aug 2023 11:25:58 GMT, Aleksey Shipilev wrote: >> Clean backport to get the important feature to LTS users. >> >> Additional testing: >> - [x] Linux AArch64 fastdebug trimming tests >> - [x] Linux AArch64 fastdebug `tier1` >> - [x] Linux AArch64 fastdebug `tier2` >> - [x] Linux AArch64 fastdebug `tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8293114-trim-native-heap > - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 Tests are clean. Review is done. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/13#issuecomment-1673079019 From shade at openjdk.org Thu Aug 10 12:07:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 12:07:28 GMT Subject: [jdk21u] Integrated: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 08:59:55 GMT, Aleksey Shipilev wrote: > Clean backport to improve the test. > > Additional testing: > - [x] macosx-aarch64-server-fastdebug, the affected test is still sensitive to original fix This pull request has now been integrated. Changeset: fd1f47c6 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/fd1f47c64a64cb2ddf290a74b7ff08ded8b43b36 Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly Backport-of: 4b192a8dc37297f0746c0c68322e0168d9f47771 ------------- PR: https://git.openjdk.org/jdk21u/pull/49 From shade at openjdk.org Thu Aug 10 12:21:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 12:21:59 GMT Subject: [jdk21u] RFR: 8313248: C2: setScopedValueCache intrinsic exposes nullptr pre-values to store barriers In-Reply-To: <1Q1tMtiYSKuCLoB30YDglG9B12XG-i9X6Xi2dbDiNaU=.9a595455-1b47-4e9e-9daa-7c3966cc27fd@github.com> References: <1Q1tMtiYSKuCLoB30YDglG9B12XG-i9X6Xi2dbDiNaU=.9a595455-1b47-4e9e-9daa-7c3966cc27fd@github.com> Message-ID: On Wed, 9 Aug 2023 10:51:18 GMT, Aleksey Shipilev wrote: > Clean backport to fix Loom bug reproducing at least with Shenandoah, but also maybe with G1. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, original reproducer fails without the patch, passes with it Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/50#issuecomment-1673089281 From shade at openjdk.org Thu Aug 10 12:22:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 12:22:59 GMT Subject: [jdk21u] Integrated: 8293114: JVM should trim the native heap In-Reply-To: <5fBNmS5U8R6UvZwIzlHEtDaWQqC6u7tjNe-x-bElhV0=.4520f49d-7f42-4490-98dd-3ed4c3fa35c7@github.com> References: <5fBNmS5U8R6UvZwIzlHEtDaWQqC6u7tjNe-x-bElhV0=.4520f49d-7f42-4490-98dd-3ed4c3fa35c7@github.com> Message-ID: On Fri, 21 Jul 2023 16:15:18 GMT, Aleksey Shipilev wrote: > Clean backport to get the important feature to LTS users. > > Additional testing: > - [x] Linux AArch64 fastdebug trimming tests > - [x] Linux AArch64 fastdebug `tier1` > - [x] Linux AArch64 fastdebug `tier2` > - [x] Linux AArch64 fastdebug `tier3` This pull request has now been integrated. Changeset: a094e937 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/a094e937bfabeeacc0218220fca301e3501f67d9 Stats: 843 lines in 20 files changed: 835 ins; 0 del; 8 mod 8293114: JVM should trim the native heap Reviewed-by: stuefe Backport-of: 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 ------------- PR: https://git.openjdk.org/jdk21u/pull/13 From shade at openjdk.org Thu Aug 10 12:22:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 12:22:28 GMT Subject: [jdk21u] Integrated: 8313248: C2: setScopedValueCache intrinsic exposes nullptr pre-values to store barriers In-Reply-To: <1Q1tMtiYSKuCLoB30YDglG9B12XG-i9X6Xi2dbDiNaU=.9a595455-1b47-4e9e-9daa-7c3966cc27fd@github.com> References: <1Q1tMtiYSKuCLoB30YDglG9B12XG-i9X6Xi2dbDiNaU=.9a595455-1b47-4e9e-9daa-7c3966cc27fd@github.com> Message-ID: On Wed, 9 Aug 2023 10:51:18 GMT, Aleksey Shipilev wrote: > Clean backport to fix Loom bug reproducing at least with Shenandoah, but also maybe with G1. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, original reproducer fails without the patch, passes with it This pull request has now been integrated. Changeset: f67c2418 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/f67c241842097f54e1b798ceb6fbbe219530e940 Stats: 22 lines in 2 files changed: 10 ins; 8 del; 4 mod 8313248: C2: setScopedValueCache intrinsic exposes nullptr pre-values to store barriers Backport-of: e8a37b90db8dca4dc3653970b2d66d2faf8ef452 ------------- PR: https://git.openjdk.org/jdk21u/pull/50 From shade at openjdk.org Thu Aug 10 12:25:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 12:25:59 GMT Subject: [jdk21u] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction [v3] In-Reply-To: <9sKqCy5LS17_Kn92yLb2o2WgBrGOCHnWxd9qnuXtVm0=.62e537f8-de85-43f0-a92b-ec0a69ede1ad@github.com> References: <9sKqCy5LS17_Kn92yLb2o2WgBrGOCHnWxd9qnuXtVm0=.62e537f8-de85-43f0-a92b-ec0a69ede1ad@github.com> Message-ID: > Semi-clean follow-up backport to relax the test. > > There are no `ProblemList` additions in 21u, so this changeset does not have the relevant hunk. > > Additional testing: > - [x] Linux x86_64 fastdebug, affected test Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport ad34be1f329edc8e7155983835cc70d733c014b8 ------------- Changes: https://git.openjdk.org/jdk21u/pull/26/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=26&range=02 Stats: 43 lines in 2 files changed: 33 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk21u/pull/26.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/26/head:pull/26 PR: https://git.openjdk.org/jdk21u/pull/26 From shade at openjdk.org Thu Aug 10 12:26:32 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 12:26:32 GMT Subject: [jdk21u] Integrated: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction In-Reply-To: <9sKqCy5LS17_Kn92yLb2o2WgBrGOCHnWxd9qnuXtVm0=.62e537f8-de85-43f0-a92b-ec0a69ede1ad@github.com> References: <9sKqCy5LS17_Kn92yLb2o2WgBrGOCHnWxd9qnuXtVm0=.62e537f8-de85-43f0-a92b-ec0a69ede1ad@github.com> Message-ID: On Mon, 31 Jul 2023 09:21:27 GMT, Aleksey Shipilev wrote: > Semi-clean follow-up backport to relax the test. > > There are no `ProblemList` additions in 21u, so this changeset does not have the relevant hunk. > > Additional testing: > - [x] Linux x86_64 fastdebug, affected test This pull request has now been integrated. Changeset: fc624dfa Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/fc624dfa2a20e9b87143b33150ec3c67b4d55589 Stats: 43 lines in 2 files changed: 33 ins; 0 del; 10 mod 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction Reviewed-by: stuefe Backport-of: ad34be1f329edc8e7155983835cc70d733c014b8 ------------- PR: https://git.openjdk.org/jdk21u/pull/26 From shade at openjdk.org Thu Aug 10 12:26:30 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 12:26:30 GMT Subject: [jdk21u] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction [v2] In-Reply-To: References: <9sKqCy5LS17_Kn92yLb2o2WgBrGOCHnWxd9qnuXtVm0=.62e537f8-de85-43f0-a92b-ec0a69ede1ad@github.com> Message-ID: On Wed, 9 Aug 2023 16:44:01 GMT, Aleksey Shipilev wrote: >> Semi-clean follow-up backport to relax the test. >> >> There are no `ProblemList` additions in 21u, so this changeset does not have the relevant hunk. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug, affected test > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. Push approval is here. Reviews are here. GHA should continue to pass after rebase. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/26#issuecomment-1673087292 From shade at openjdk.org Thu Aug 10 14:40:33 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 14:40:33 GMT Subject: [jdk17u-dev] RFR: 8297350: Update JMH devkit to 1.36 Message-ID: Clean backport to bump to intermediate JMH version. There is a mainline PR pending to bring 1.37 in, it would be backported later. ------------- Commit messages: - Backport f26bd4e0e8b68de297a9ff93526cd7fac8668320 Changes: https://git.openjdk.org/jdk17u-dev/pull/1656/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1656&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297350 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1656.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1656/head:pull/1656 PR: https://git.openjdk.org/jdk17u-dev/pull/1656 From shade at openjdk.org Thu Aug 10 14:55:05 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 14:55:05 GMT Subject: [jdk21u] RFR: 8313307: java/util/Formatter/Padding.java fails on some Locales Message-ID: <9dG0t39XCw-tiLcoUynYFu4me237J-HU1Jevzaw8mHc=.81055dd5-21de-43c1-99ed-48931df1ee18@github.com> Clean backport to fix the test. Additional testing: - [x] Affected test fails without the fix, passes with it ------------- Commit messages: - Backport 408987e1ca9a42db8019b1bd7e52f85607975dde Changes: https://git.openjdk.org/jdk21u/pull/51/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=51&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313307 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/51.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/51/head:pull/51 PR: https://git.openjdk.org/jdk21u/pull/51 From shade at openjdk.org Thu Aug 10 16:24:58 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 10 Aug 2023 16:24:58 GMT Subject: [jdk21u] RFR: 8312127: FileDescriptor.sync should temporarily increase parallelism Message-ID: Clean backport to avoid the temporary loss of platform thread when virtual thread does `fsync`. In https://github.com/openjdk/jdk/pull/15231, I tested that the overhead of doing this for platform threads is very small compared to the cost of the `fsync` itself. ------------- Commit messages: - Backport fbe51e388d8a7475f162f10aa788a6d37ec4c6d8 Changes: https://git.openjdk.org/jdk21u/pull/52/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=52&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312127 Stats: 17 lines in 3 files changed: 11 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u/pull/52.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/52/head:pull/52 PR: https://git.openjdk.org/jdk21u/pull/52 From xliu at openjdk.org Thu Aug 10 17:54:28 2023 From: xliu at openjdk.org (Xin Liu) Date: Thu, 10 Aug 2023 17:54:28 GMT Subject: [jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v2] In-Reply-To: References: Message-ID: On Thu, 10 Aug 2023 11:23:01 GMT, Aleksey Shipilev wrote: > https://bugs.openjdk.org/browse/JDK-8309067 (not fixed, should be dealt with first) okay. I will work on [JDK-8309067](https://bugs.openjdk.org/browse/JDK-8309067) > src/hotspot/share/logging/logAsyncWriter.cpp line 77: > >> 75: if (!_buffer->push_back(output, decorations, msg)) { >> 76: bool p_created; >> 77: uint32_t* counter = _stats.put_if_absent(output, 0, &p_created); > > Just checking: the rewrite `add_if_absent` -> `put_if_absent` is needed, because the underlying type changed, right? Correct. I change from hashtable.hpp to resourceHash.hpp because the later supports arena allocator. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#issuecomment-1673639791 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#discussion_r1290468080 From phh at openjdk.org Thu Aug 10 17:54:58 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 10 Aug 2023 17:54:58 GMT Subject: [jdk11u-dev] RFR: 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v2] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Thu, 10 Aug 2023 10:35:28 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > Update full name Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2074#pullrequestreview-1572417078 From rmarchenko at openjdk.org Thu Aug 10 18:40:58 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 10 Aug 2023 18:40:58 GMT Subject: [jdk17u-dev] Integrated: 8289646: configure script failed on WSL In-Reply-To: <5QHslcx7U9Hks7DQeOJ_bLUZ2Jy9wnAjxokHKGjXFN8=.e17ebb55-37f4-48ec-8198-43e30f1d1e8a@github.com> References: <5QHslcx7U9Hks7DQeOJ_bLUZ2Jy9wnAjxokHKGjXFN8=.e17ebb55-37f4-48ec-8198-43e30f1d1e8a@github.com> Message-ID: On Fri, 9 Jun 2023 09:25:11 GMT, Roman Marchenko wrote: > Clean backport, no tier1 regressions. This pull request has now been integrated. Changeset: 38204b09 Author: Roman Marchenko Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/38204b0925a36dbcf6060796f15d17764b8383ed Stats: 8 lines in 1 file changed: 2 ins; 3 del; 3 mod 8289646: configure script failed on WSL Backport-of: 3f1174aa4709aabcfde8b40deec88b8ed466cc06 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1418 From phh at openjdk.org Thu Aug 10 23:20:59 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 10 Aug 2023 23:20:59 GMT Subject: [jdk11u-dev] RFR: 8305733: Pattern.CASE_INSENSITIVE does not take effect in jdk11 [v8] In-Reply-To: References: Message-ID: <0R5DcImSYhHnnQvB559EeXMGzT2gLpG-SAUYbO80jV8=.9a3e35fa-7814-415a-a5da-845c5c1516b2@github.com> On Mon, 31 Jul 2023 02:16:13 GMT, Korov wrote: >> fix [JDK-8305733](https://bugs.openjdk.org/browse/JDK-8305733) > > Korov has updated the pull request incrementally with one additional commit since the last revision: > > Update RegExTest.java Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2062#pullrequestreview-1572837247 From phh at openjdk.org Thu Aug 10 23:33:28 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 10 Aug 2023 23:33:28 GMT Subject: [jdk17u-dev] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 09:30:40 GMT, Aleksey Shipilev wrote: > Semi-clean follow-up backport to relax the test. > > There are no ProblemList additions in 17u, so this changeset does not have the relevant hunk. > > Additional testing: > - [x] Linux x86_64 fastdebug, affected test Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1633#pullrequestreview-1572845837 From dzhang at openjdk.org Fri Aug 11 02:36:29 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Fri, 11 Aug 2023 02:36:29 GMT Subject: [jdk17u-dev] RFR: 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V [v2] In-Reply-To: References: Message-ID: > I would like to backport [JDK-8309254](https://bugs.openjdk.org/browse/JDK-8309254). > The backport is not clean because 17u has no [JDK-8302908](https://bugs.openjdk.org/browse/JDK-8302908), which use v0 as mask register. > The test `test/hotspot/jtreg/compiler/intrinsics/string/TestEncodeIntrinsics.java` passed and command log with "-XX:+PrintOptoAssembly" output is similar to the mainline: > > ... > 240 Encode ISO array R12, R11, R13 -> R10 # KILL R12, R11, R13, R28, V1-V3 > ... > 0118 Encode ASCII array R12, R11, R13 -> R10 # KILL R12, R11, R13, R25, V1-V3 > ... Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into backport-8309254 - 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1567/files - new: https://git.openjdk.org/jdk17u-dev/pull/1567/files/2afc6793..bd1c4506 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1567&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1567&range=00-01 Stats: 42964 lines in 918 files changed: 15974 ins; 14438 del; 12552 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1567.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1567/head:pull/1567 PR: https://git.openjdk.org/jdk17u-dev/pull/1567 From kevinw at openjdk.org Fri Aug 11 10:03:28 2023 From: kevinw at openjdk.org (Kevin Walls) Date: Fri, 11 Aug 2023 10:03:28 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v2] In-Reply-To: References: Message-ID: <44k27WcaoRfO2gYCi3tBmcFbS2lM3tme163aGUfw50M=.03188800-5f40-4b76-97de-b2b37b18ca5c@github.com> On Wed, 9 Aug 2023 07:28:33 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows OK, looks good to me. 8-) ------------- Marked as reviewed by kevinw (Committer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1641#pullrequestreview-1573342865 From shade at openjdk.org Fri Aug 11 10:33:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 11 Aug 2023 10:33:59 GMT Subject: [jdk21u] RFR: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased Message-ID: <0pc0MHBSETKeT0yaVL7Q_eW_CXgN4TNJz4_Ko5akoyE=.046a5fb6-2f22-438e-91ce-9bdaf52648db@github.com> Clean backport to stabilize the test. ------------- Commit messages: - Backport 117f42dbe9a78bcf43bdf3873d5d86a19a9092d3 Changes: https://git.openjdk.org/jdk21u/pull/53/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=53&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312625 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/53.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/53/head:pull/53 PR: https://git.openjdk.org/jdk21u/pull/53 From archana.nogriya at uk.ibm.com Fri Aug 11 10:58:39 2023 From: archana.nogriya at uk.ibm.com (Archana Nogriya) Date: Fri, 11 Aug 2023 10:58:39 +0000 Subject: Copyright Issue founds : JDK21 - GPLv2 is present but Classpath exception is missing In-Reply-To: References: Message-ID: Hi, Please are there any updates on handling this copyrights issue or if any issue has been created where I can see when I can expect the fix ? Much appreciated the help. Many Thanks & Regards Archana Nogriya Java Runtimes Project/Release Manager IBM Hursley IBM United Kingdom Ltd internet email: archana.nogriya at uk.ibm.com Working hrs (Mon-Fri)- 9am - 3pm From: Archana Nogriya Date: Friday, 28 July 2023 at 10:07 To: jdk-updates-dev at openjdk.java.net , jdk-dev at openjdk.java.net Cc: Tyler Steele , Kishor Patil , Paul Arockiam Subject: Copyright Issue founds : JDK21 - GPLv2 is present but Classpath exception is missing Hi, JDK21 has a copyright issue with following files, where GPLv2 is present but Classpath exception is missing, Please, if someone can help to fix these issues. src/java.base/share/classes/jdk/internal/classfile/components/ClassRemapper.java src/java.base/share/classes/jdk/internal/classfile/components/CodeLocalsShifter.java src/java.base/share/classes/jdk/internal/classfile/components/CodeRelabeler.java src/java.base/share/classes/jdk/internal/classfile/components/CodeStackTracker.java src/java.base/share/classes/jdk/internal/classfile/impl/ClassHierarchyImpl.java src/java.base/share/classes/jdk/internal/classfile/impl/ClassRemapperImpl.java src/java.base/share/classes/jdk/internal/classfile/impl/CodeLocalsShifterImpl.java src/java.base/share/classes/jdk/internal/classfile/impl/CodeRelabelerImpl.java src/java.base/share/classes/jdk/internal/classfile/impl/CodeStackTrackerImpl.java src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java src/java.base/share/classes/jdk/internal/classfile/impl/verifier/VerificationWrapper.java src/java.base/share/classes/jdk/internal/foreign/abi/riscv64/RISCV64Architecture.java src/java.base/share/classes/jdk/internal/foreign/abi/riscv64/linux/LinuxRISCV64CallArranger.java src/java.base/share/classes/jdk/internal/foreign/abi/riscv64/linux/LinuxRISCV64Linker.java src/java.base/share/classes/jdk/internal/foreign/abi/riscv64/linux/TypeClass.java src/java.base/share/classes/jdk/internal/util/Architecture.java src/java.base/share/classes/jdk/internal/util/OSVersion.java src/java.base/share/classes/jdk/internal/util/OperatingSystem.java src/java.base/share/classes/jdk/internal/util/PlatformProps.java Many Thanks & Regards Archana Nogriya Java Runtimes Project/Release Manager IBM Hursley IBM United Kingdom Ltd internet email: archana.nogriya at uk.ibm.com Working hrs (Mon-Fri)- 9am - 3pm Unless otherwise stated above: IBM United Kingdom Limited Registered in England and Wales with number 741598 Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From shade at openjdk.org Fri Aug 11 11:02:34 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 11 Aug 2023 11:02:34 GMT Subject: [jdk21u] RFR: 8308474: DSA does not reset SecureRandom when initSign is called again Message-ID: <2fjTw6kJLxyYq3jYIISzWvEqFC9WlPKXlHEpYEUxJ30=.45cbaa00-ae8f-419b-b068-6df46bcf1f5a@github.com> Clean backport to improve DSA security. Additional testing: - [x] New regression test fails without the patch, passes with it ------------- Commit messages: - Backport bed9161c815b5b4773f36eac7e8dadc1384c7fd1 Changes: https://git.openjdk.org/jdk21u/pull/54/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=54&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308474 Stats: 70 lines in 2 files changed: 69 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/54.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/54/head:pull/54 PR: https://git.openjdk.org/jdk21u/pull/54 From Alan.Bateman at oracle.com Fri Aug 11 12:29:29 2023 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 11 Aug 2023 05:29:29 -0700 Subject: Copyright Issue founds : JDK21 - GPLv2 is present but Classpath exception is missing In-Reply-To: References: Message-ID: <298bf769-4bcb-c3d2-b35d-c420ac48d861@oracle.com> On 11/08/2023 03:58, Archana Nogriya wrote: > > Hi, > > Please are there any updates on handling this copyrights issue or if > any issue has been created where I can see when I can expect the fix ? > > Much appreciated the help. > > It was addressed in the main line with JDK-8313312 [1] and JDK-8310643 [2]. -Alan [1] https://bugs.openjdk.org/browse/JDK-8313312 [2] https://bugs.openjdk.org/browse/JDK-8310643 -------------- next part -------------- An HTML attachment was scrubbed... URL: From alanb at openjdk.org Fri Aug 11 12:42:33 2023 From: alanb at openjdk.org (Alan Bateman) Date: Fri, 11 Aug 2023 12:42:33 GMT Subject: [jdk21u] RFR: 8312127: FileDescriptor.sync should temporarily increase parallelism In-Reply-To: References: Message-ID: On Thu, 10 Aug 2023 16:06:10 GMT, Aleksey Shipilev wrote: > Clean backport to avoid the temporary loss of platform thread when virtual thread does `fsync`. In https://github.com/openjdk/jdk/pull/15231, I tested that the overhead of doing this for platform threads is very small compared to the cost of the `fsync` itself. I also had this on my list for jdk21u, looks good. ------------- Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk21u/pull/52#pullrequestreview-1573573300 From shade at openjdk.org Fri Aug 11 14:15:30 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 11 Aug 2023 14:15:30 GMT Subject: [jdk21u] RFR: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers Message-ID: Clean backport to fix minor TLS 3.0 bug. Additional testing: - [x] macosx-aarch64-server-fastdebug, `jdk_security` passes ------------- Commit messages: - Backport db133dbc02a7f38104fdbca967c59f758c6f4336 Changes: https://git.openjdk.org/jdk21u/pull/55/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=55&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310106 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/55.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/55/head:pull/55 PR: https://git.openjdk.org/jdk21u/pull/55 From mbaesken at openjdk.org Fri Aug 11 15:30:04 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 11 Aug 2023 15:30:04 GMT Subject: [jdk21u] RFR: 8311511: Improve description of NativeLibrary JFR event Message-ID: <0_10xSyku9Q4xcOkBZ3SEbarnS464cPgbkBhTYqawC8=.9cfb5dd7-b8d2-4ead-be80-6b15878b82d9@github.com> 8311511: Improve description of NativeLibrary JFR event ------------- Commit messages: - Backport 848abd2831ab38d99b6b76b55cbe8d84c28be330 Changes: https://git.openjdk.org/jdk21u/pull/56/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=56&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311511 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/56.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/56/head:pull/56 PR: https://git.openjdk.org/jdk21u/pull/56 From stuefe at openjdk.org Fri Aug 11 15:56:29 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 11 Aug 2023 15:56:29 GMT Subject: [jdk21u] RFR: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased In-Reply-To: <0pc0MHBSETKeT0yaVL7Q_eW_CXgN4TNJz4_Ko5akoyE=.046a5fb6-2f22-438e-91ce-9bdaf52648db@github.com> References: <0pc0MHBSETKeT0yaVL7Q_eW_CXgN4TNJz4_Ko5akoyE=.046a5fb6-2f22-438e-91ce-9bdaf52648db@github.com> Message-ID: <3J7QBytq39jt56Bx0ePD5I4aCeIySLy3u27gf4RQJp8=.198feaf6-78c3-4ffd-8b0a-c92609441106@github.com> On Fri, 11 Aug 2023 10:05:21 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the test. +1 ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk21u/pull/53#pullrequestreview-1573952880 From mdoerr at openjdk.org Fri Aug 11 21:36:28 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 11 Aug 2023 21:36:28 GMT Subject: [jdk17u-dev] Integrated: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee In-Reply-To: References: Message-ID: On Thu, 10 Aug 2023 10:29:33 GMT, Martin Doerr wrote: > Backport of [JDK-8308232](https://bugs.openjdk.org/browse/JDK-8308232). Recognized as clean (context differs because Loom is not it 17u). nsk/jdb tests have passed. This pull request has now been integrated. Changeset: 8683db88 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/8683db8853d083618e4538a3ef478e7bc3848681 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee Backport-of: c6f20db945c6217aea84cebd6c97dbf8b93c48a4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1655 From mdoerr at openjdk.org Fri Aug 11 21:35:29 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 11 Aug 2023 21:35:29 GMT Subject: [jdk17u-dev] Integrated: 8308090: Add container tests for on-the-fly resource quota updates In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 14:37:43 GMT, Martin Doerr wrote: > Backport of [JDK-8308090](https://bugs.openjdk.org/browse/JDK-8308090). This pull request has now been integrated. Changeset: 6ab5177b Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/6ab5177b81f86172a8a5f820f6ef63b6f1a9b175 Stats: 434 lines in 5 files changed: 431 ins; 2 del; 1 mod 8308090: Add container tests for on-the-fly resource quota updates Backport-of: dc8bc6c98ca1f9b441cf71c641675fe29dda9162 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1652 From mdoerr at openjdk.org Fri Aug 11 21:37:58 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 11 Aug 2023 21:37:58 GMT Subject: [jdk17u-dev] Integrated: 8156889: ListKeychainStore.sh fails in some virtualized environments In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 15:25:08 GMT, Martin Doerr wrote: > Backport of [JDK-8156889](https://bugs.openjdk.org/browse/JDK-8156889). This pull request has now been integrated. Changeset: 10942c1f Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/10942c1f2fab05f4d85a884faedfac5b95d2a7e5 Stats: 449 lines in 4 files changed: 202 ins; 247 del; 0 mod 8156889: ListKeychainStore.sh fails in some virtualized environments Backport-of: 82c8b28f4005c3c335d4fd60c2e3b55adfd200c6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1653 From mdoerr at openjdk.org Fri Aug 11 21:53:02 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 11 Aug 2023 21:53:02 GMT Subject: [jdk17u-dev] Integrated: 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt In-Reply-To: References: Message-ID: <-OSI0Mm_N0tLmOEOjZuJn8-2-FDRiF4nu3maE4UZnuw=.08f53b59-6e9f-4ed4-bb32-d8ee1ab7901a@github.com> On Wed, 9 Aug 2023 15:40:26 GMT, Martin Doerr wrote: > Backport of [JDK-8310551](https://bugs.openjdk.org/browse/JDK-8310551). Applies cleanly except removal from ProblemList. (Not problem listed in 17u). Test has passed. This pull request has now been integrated. Changeset: d7b3306b Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/d7b3306bce0d9d5f85472763e1ce9e1b7a8f8953 Stats: 8 lines in 2 files changed: 1 ins; 1 del; 6 mod 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt Backport-of: c84866ac0dcda487fe2abc2a8841f237df0a395b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1654 From duke at openjdk.org Sat Aug 12 14:08:32 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Sat, 12 Aug 2023 14:08:32 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v3] In-Reply-To: References: Message-ID: > I would like to fix this issue > because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. > Testing: > all serviceability area tests jdk_svc, and a specific test to verify the fix. > > Could anyone review the fix please? > > Thanks, > Kimura Yukihiro Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge master - Merge master - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1641/files - new: https://git.openjdk.org/jdk17u-dev/pull/1641/files/0e2813dc..5a5c43ca Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1641&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1641&range=01-02 Stats: 2788 lines in 32 files changed: 1596 ins; 978 del; 214 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1641.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1641/head:pull/1641 PR: https://git.openjdk.org/jdk17u-dev/pull/1641 From mdoerr at openjdk.org Sat Aug 12 20:38:29 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Sat, 12 Aug 2023 20:38:29 GMT Subject: [jdk17u-dev] RFR: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails Message-ID: Backport of [JDK-8309088](https://bugs.openjdk.org/browse/JDK-8309088). ------------- Commit messages: - Backport 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3 Changes: https://git.openjdk.org/jdk17u-dev/pull/1657/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1657&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309088 Stats: 491 lines in 1 file changed: 142 ins; 30 del; 319 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1657.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1657/head:pull/1657 PR: https://git.openjdk.org/jdk17u-dev/pull/1657 From mbaesken at openjdk.org Mon Aug 14 07:28:58 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 14 Aug 2023 07:28:58 GMT Subject: [jdk11u-dev] RFR: 8239333: Mark test AmazonCA.java with intermittent key Message-ID: 8239333: Mark test AmazonCA.java with intermittent key ------------- Commit messages: - Backport 7f3bbc3f2075dd04ab0f54d282b8d9d02c472785 Changes: https://git.openjdk.org/jdk11u-dev/pull/2075/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2075&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8239333 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2075.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2075/head:pull/2075 PR: https://git.openjdk.org/jdk11u-dev/pull/2075 From andrewlu at openjdk.org Mon Aug 14 08:12:04 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 14 Aug 2023 08:12:04 GMT Subject: [jdk11u-dev] RFR: 8306133: Open source few AWT Drag & Drop related tests Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport ec5c7926f3cea68bf0d0ceb460a8383f5e4ea278 Changes: https://git.openjdk.org/jdk11u-dev/pull/2076/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2076&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306133 Stats: 1062 lines in 5 files changed: 1062 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2076.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2076/head:pull/2076 PR: https://git.openjdk.org/jdk11u-dev/pull/2076 From shade at openjdk.org Mon Aug 14 08:24:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 08:24:28 GMT Subject: [jdk17u-dev] Integrated: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> References: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> Message-ID: On Fri, 4 Aug 2023 14:04:14 GMT, Aleksey Shipilev wrote: > This is a series of commits that bring 17u GHA close to mainline. The root change is Ubuntu 22.04 bump, but that one could not be tested alone, because GHA would be broken due to missing compilers, dependencies, etc. Therefore, I opted to do a bulk PR that contains a series of inter-dependent changes. This PR should bring 17u GHA to the good state, atomically. > > The included changes are in separate commits, if you want to review them separately. But it would be easier to see the changes against JDK 22 GHA. There are differences against JDK 22 GHA, but those look minor, not breaking/fixing current GHA, and we can backport separately once we get JDK 17u GHA in shape. > > Additional testing: > - [x] GHA > - [x] Eyeballing the difference between patched JDK 17u and JDK 22 GHA: [jdk17-jdk22-gha-diff.txt](https://github.com/openjdk/jdk17u-dev/files/12261456/jdk17-jdk22-gha-diff.txt) This pull request has now been integrated. Changeset: 260f2876 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/260f28761a87553fd634615df5ba3db5b76ae692 Stats: 116 lines in 5 files changed: 87 ins; 3 del; 26 mod 8293107: GHA: Bump to Ubuntu 22.04 8293098: GHA: Harmonize GCC version handling for host and cross builds 8293361: GHA: dump config.log in case of configure failure 8295213: Run GHA manually with user-specified make and configure arguments 8313428: GHA: Bump GCC versions for July 2023 updates 8313707: GHA: Bootstrap sysroots with --variant=minbase Reviewed-by: clanger Backport-of: d7536588b38e368eaa6395bcbcc6724a39303fc5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1640 From shade at openjdk.org Mon Aug 14 08:23:29 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 08:23:29 GMT Subject: [jdk17u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> References: <7SH__2_nQuxK0iUezTsUsABcPDun6Mf4XN7R3D7CG2Y=.aea1cbf0-5e63-4ef3-93ff-e1094691d1fb@github.com> Message-ID: On Fri, 4 Aug 2023 14:04:14 GMT, Aleksey Shipilev wrote: > This is a series of commits that bring 17u GHA close to mainline. The root change is Ubuntu 22.04 bump, but that one could not be tested alone, because GHA would be broken due to missing compilers, dependencies, etc. Therefore, I opted to do a bulk PR that contains a series of inter-dependent changes. This PR should bring 17u GHA to the good state, atomically. > > The included changes are in separate commits, if you want to review them separately. But it would be easier to see the changes against JDK 22 GHA. There are differences against JDK 22 GHA, but those look minor, not breaking/fixing current GHA, and we can backport separately once we get JDK 17u GHA in shape. > > Additional testing: > - [x] GHA > - [x] Eyeballing the difference between patched JDK 17u and JDK 22 GHA: [jdk17-jdk22-gha-diff.txt](https://github.com/openjdk/jdk17u-dev/files/12261456/jdk17-jdk22-gha-diff.txt) The discussion seem to be resolved. The recent GHA run is clean. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1640#issuecomment-1676879798 From shade at openjdk.org Mon Aug 14 08:40:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 08:40:28 GMT Subject: [jdk17u-dev] RFR: 8297350: Update JMH devkit to 1.36 In-Reply-To: References: Message-ID: On Thu, 10 Aug 2023 14:17:59 GMT, Aleksey Shipilev wrote: > Clean backport to bump to intermediate JMH version. There is a mainline PR pending to bring 1.37 in, it would be backported later. Push approval is here. GHA fails, but this change does not touch the product code. Therefore, I am integrating. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1656#issuecomment-1676890784 From shade at openjdk.org Mon Aug 14 08:40:29 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 08:40:29 GMT Subject: [jdk17u-dev] Integrated: 8297350: Update JMH devkit to 1.36 In-Reply-To: References: Message-ID: On Thu, 10 Aug 2023 14:17:59 GMT, Aleksey Shipilev wrote: > Clean backport to bump to intermediate JMH version. There is a mainline PR pending to bring 1.37 in, it would be backported later. This pull request has now been integrated. Changeset: 6e6bddff Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/6e6bddffe84e962e532d9a79639082615ccc318e Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8297350: Update JMH devkit to 1.36 Backport-of: f26bd4e0e8b68de297a9ff93526cd7fac8668320 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1656 From shade at openjdk.org Mon Aug 14 08:41:30 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 08:41:30 GMT Subject: [jdk17u-dev] RFR: 8313402: C1: Incorrect LoadIndexed value numbering [v2] In-Reply-To: References: Message-ID: > Clean backport to fix the important C1 bug. > > Additional testing: > - [x] New regression test fails without the patch, passes with it, when JDK-8313676 is applied > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 46fbedb2be98a9b8aba042fa9f90c3b25c312cd6 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/1636/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1636&range=01 Stats: 59 lines in 2 files changed: 58 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1636.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1636/head:pull/1636 PR: https://git.openjdk.org/jdk17u-dev/pull/1636 From shade at openjdk.org Mon Aug 14 08:41:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 08:41:59 GMT Subject: [jdk17u-dev] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction [v2] In-Reply-To: References: Message-ID: > Semi-clean follow-up backport to relax the test. > > There are no ProblemList additions in 17u, so this changeset does not have the relevant hunk. > > Additional testing: > - [x] Linux x86_64 fastdebug, affected test Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport ad34be1f329edc8e7155983835cc70d733c014b8 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/1633/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1633&range=01 Stats: 43 lines in 2 files changed: 33 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1633.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1633/head:pull/1633 PR: https://git.openjdk.org/jdk17u-dev/pull/1633 From shade at openjdk.org Mon Aug 14 08:50:30 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 08:50:30 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v4] In-Reply-To: References: Message-ID: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> > Unclean backport to get useful experimental feature to LTS users. > > In addition to usual contextual differences, there is a number of differences against upstream version: > - `synchronizer.cpp` hunks are different, since we do not have [JDK-8256302](https://github.com/openjdk/jdk/commit/6402004852ccc993bb6e879c49fb71e2afdcdfbe) in JDK 17 > - `NativeHeapTrimmer_lock` changed from `Mutex::safepoint` to `Mutex::leaf`, since [JDK-8273915](https://github.com/openjdk/jdk/commit/111d5e1a9324cb5e8d98627f6329d17fcbc9c13d) renamed it after JDK 17 > - `NativeHeapTrimmer_lock` should also allow VMThread block and never require safepoint checks; this was simplified by [JDK-8274004](https://bugs.openjdk.org/browse/JDK-8274004) later > - `vmError.cpp` code was rewritten in JDK 17 style > - gtest uses `EXPECT_NOT_NULL`, only brought by [JDK-8295865](https://github.com/openjdk/jdk/commit/657a0b2f1564e1754dbd64b776c53a52c480c901#diff-35b3b4703decd15bfd2fc614d431e909727a6cf4d399cf05c7a12466e61ab8a0R58-R59) -- I rewrote them to EXPECT_NE/EQ. > > Additional testing: > - [x] Linux x86_64 fastdebug, trim tests > - [x] Linux x86_64 fastdebug, `tier1` > - [x] Linux x86_64 fastdebug, `tier2` > - [x] Linux x86_64 fastdebug, `tier3` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into JDK-8293114-trim-native - More adjustments - Adjustments - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1616/files - new: https://git.openjdk.org/jdk17u-dev/pull/1616/files/05262205..e5e158a2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1616&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1616&range=02-03 Stats: 3822 lines in 64 files changed: 2518 ins; 990 del; 314 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1616.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1616/head:pull/1616 PR: https://git.openjdk.org/jdk17u-dev/pull/1616 From shade at openjdk.org Mon Aug 14 08:57:08 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 08:57:08 GMT Subject: [jdk17u-dev] RFR: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one Message-ID: Clean backport to improve GHA reliability. Additional testing: - [ ] GHA ------------- Commit messages: - Backport c5f462e83b85ec53ec395622063a5b131aaf0827 Changes: https://git.openjdk.org/jdk17u-dev/pull/1660/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1660&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294956 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1660.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1660/head:pull/1660 PR: https://git.openjdk.org/jdk17u-dev/pull/1660 From shade at openjdk.org Mon Aug 14 08:59:58 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 08:59:58 GMT Subject: [jdk17u-dev] RFR: 8304353: Add lib-test tier1 testing in GHA Message-ID: Clean backport to improve GHA coverage. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 57276101df79f07b14b914b36b1155cedec3eb3d Changes: https://git.openjdk.org/jdk17u-dev/pull/1658/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1658&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304353 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1658.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1658/head:pull/1658 PR: https://git.openjdk.org/jdk17u-dev/pull/1658 From shade at openjdk.org Mon Aug 14 09:01:29 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 09:01:29 GMT Subject: [jdk17u-dev] RFR: 8299330: Minor improvements in MSYS2 Workflow handling Message-ID: Clean backport to improve GHA reliability. Additional testing: - [ ] GHA ------------- Commit messages: - Backport cf00d09c8c37ee301e1c6657df45777647a834e9 Changes: https://git.openjdk.org/jdk17u-dev/pull/1659/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1659&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299330 Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1659.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1659/head:pull/1659 PR: https://git.openjdk.org/jdk17u-dev/pull/1659 From shade at openjdk.org Mon Aug 14 09:16:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 09:16:28 GMT Subject: [jdk17u-dev] RFR: 8294941: GHA: Cut down cross-compilation sysroots Message-ID: Clean backport to improve GHA footprint overheads. Additional testing: - [ ] GHA ------------- Commit messages: - Backport a1747ef81a10e84177f474565193204ceaa0ede8 Changes: https://git.openjdk.org/jdk17u-dev/pull/1661/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1661&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294941 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1661.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1661/head:pull/1661 PR: https://git.openjdk.org/jdk17u-dev/pull/1661 From shade at openjdk.org Mon Aug 14 09:56:30 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 09:56:30 GMT Subject: [jdk17u-dev] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction [v2] In-Reply-To: References: Message-ID: <7YY9BB4mqtM8Opipc-AYnnakfzFDvh-K2n1QC6e_R6s=.8a1d2dec-d0b7-4964-804f-c300bd515651@github.com> On Mon, 14 Aug 2023 08:41:59 GMT, Aleksey Shipilev wrote: >> Semi-clean follow-up backport to relax the test. >> >> There are no ProblemList additions in 17u, so this changeset does not have the relevant hunk. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug, affected test > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport ad34be1f329edc8e7155983835cc70d733c014b8 Botched this PR. Reopening... Reopened as #1662. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1633#issuecomment-1676999299 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1633#issuecomment-1677000867 From shade at openjdk.org Mon Aug 14 09:56:32 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 09:56:32 GMT Subject: [jdk17u-dev] Withdrawn: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 09:30:40 GMT, Aleksey Shipilev wrote: > Semi-clean follow-up backport to relax the test. > > There are no ProblemList additions in 17u, so this changeset does not have the relevant hunk. > > Additional testing: > - [x] Linux x86_64 fastdebug, affected test This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1633 From shade at openjdk.org Mon Aug 14 09:56:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 09:56:59 GMT Subject: [jdk17u-dev] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction Message-ID: Semi-clean follow-up backport to relax the test. There are no ProblemList additions in 17u, so this changeset does not have the relevant hunk. Additional testing: - [x] Linux x86_64 fastdebug, affected test ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/1616 Commit messages: - Backport ad34be1f329edc8e7155983835cc70d733c014b8 Changes: https://git.openjdk.org/jdk17u-dev/pull/1662/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1662&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312525 Stats: 43 lines in 2 files changed: 33 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1662.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1662/head:pull/1662 PR: https://git.openjdk.org/jdk17u-dev/pull/1662 From mdoerr at openjdk.org Mon Aug 14 10:24:28 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 14 Aug 2023 10:24:28 GMT Subject: [jdk17u-dev] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 09:33:58 GMT, Aleksey Shipilev wrote: > Semi-clean follow-up backport to relax the test. > > There are no ProblemList additions in 17u, so this changeset does not have the relevant hunk. > > Additional testing: > - [x] Linux x86_64 fastdebug, affected test Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1662#pullrequestreview-1576547147 From shade at openjdk.org Mon Aug 14 10:25:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 10:25:59 GMT Subject: [jdk21u] RFR: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level Message-ID: Clean backport to fix TCP_QUICKACK bug. Additional testing: - [ ] Linux AArch64 fastdebug, `jdk_net` - [ ] Linux AArch64 fastdebug, `tier1 tier2 tier3` ------------- Commit messages: - Backport 56a73a6f0f3d38379cecea1de5eacb751febca95 Changes: https://git.openjdk.org/jdk21u/pull/57/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=57&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309591 Stats: 7 lines in 2 files changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u/pull/57.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/57/head:pull/57 PR: https://git.openjdk.org/jdk21u/pull/57 From shade at openjdk.org Mon Aug 14 10:41:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 10:41:59 GMT Subject: [jdk21u] RFR: 8314118: Update JMH devkit to 1.37 Message-ID: Clean backport to improve performance testing. ------------- Commit messages: - Backport 06aa3c5628e749188238dda3d41c776a5a2f7c81 Changes: https://git.openjdk.org/jdk21u/pull/58/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=58&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314118 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/58.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/58/head:pull/58 PR: https://git.openjdk.org/jdk21u/pull/58 From mbaesken at openjdk.org Mon Aug 14 10:56:29 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 14 Aug 2023 10:56:29 GMT Subject: [jdk21u] RFR: 8313251: Add NativeLibraryLoad event Message-ID: 8313251: Add NativeLibraryLoad event ------------- Commit messages: - Backport 5d232959c2d98b632a5c48c89f369f7e80c8b68f Changes: https://git.openjdk.org/jdk21u/pull/59/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=59&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313251 Stats: 218 lines in 9 files changed: 216 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/59.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/59/head:pull/59 PR: https://git.openjdk.org/jdk21u/pull/59 From shade at openjdk.org Mon Aug 14 11:11:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 11:11:28 GMT Subject: [jdk17u-dev] RFR: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level Message-ID: Unclean backport to fix TCP_QUICKACK bug. The backport is unclean, because AIX hunks could not be applied. The implementation of extended socket options on AIX went into JDK 21 with [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089). Additional testing: - [ ] Linux AArch64 fastdebug, `jdk_net` - [ ] Linux AArch64 fastdebug, `tier1 tier2 tier3` ------------- Commit messages: - Backport 56a73a6f0f3d38379cecea1de5eacb751febca95 Changes: https://git.openjdk.org/jdk17u-dev/pull/1664/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1664&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309591 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1664.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1664/head:pull/1664 PR: https://git.openjdk.org/jdk17u-dev/pull/1664 From shade at openjdk.org Mon Aug 14 11:11:32 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 11:11:32 GMT Subject: [jdk17u-dev] RFR: 8294149: JMH 1.34 and later requires jopt-simple 5.0.4 Message-ID: <-WnOoJp-G-0mP3lZFf3I3yRAxYBLs0W2z8FYQccuXZA=.310a45af-17b1-408e-99cf-19de1e2d2aa0@github.com> A series of clean backports to unbreak JMH. The clean resolution of conflicts in `jib-profiles.js` prompts clean backports of two pre-requisites: JDK-8277427 and JDK-8280032. (Nothing in OpenJDK uses those, but it is trivial to pick those up for extra cleanliness). ------------- Commit messages: - Backport 2283c3244f4fe475593d8a53613b5a3228bec356 - Backport 9e536b64705f841b224d0e64cad0f1609ebf5bca - Backport b1a1bf4e305d6675f8f751aa8fef7013d99466f1 Changes: https://git.openjdk.org/jdk17u-dev/pull/1663/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1663&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294149 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1663.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1663/head:pull/1663 PR: https://git.openjdk.org/jdk17u-dev/pull/1663 From shipilev at amazon.de Mon Aug 14 11:39:27 2023 From: shipilev at amazon.de (Aleksey Shipilev) Date: Mon, 14 Aug 2023 13:39:27 +0200 Subject: Result: New JDK Updates Committer: Victor Rudometov Message-ID: <142de50f-41b4-41ac-bb1f-fc3ace61f66c@amazon.de> Voting [1] for Victor Rudometov (vrudomet [2]) is now closed. Yes: 6 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus [3], this is sufficient to approve the nomination. [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2023-July/024058.html [2] https://openjdk.org/census#vrudomet [3] https://openjdk.java.net/bylaws#three-vote-consensus -- Thanks, -Aleksey Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From shipilev at amazon.de Mon Aug 14 11:43:14 2023 From: shipilev at amazon.de (Aleksey Shipilev) Date: Mon, 14 Aug 2023 13:43:14 +0200 Subject: Result: New JDK Updates Reviewer: Fei Yang Message-ID: Voting [1] for Fei Yang (fyang)[2] is now closed. Yes: 11 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus [3], this is sufficient to approve the nomination. [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2023-July/023701.html [2] https://openjdk.org/census#fyang [3] https://openjdk.java.net/bylaws#three-vote-consensus -- Thanks, -Aleksey Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From shade at openjdk.org Mon Aug 14 11:57:02 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 11:57:02 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v4] In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 16:45:39 GMT, Thomas Stuefe wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: >> >> - Merge branch 'master' into JDK-8293114-trim-native >> - More adjustments >> - Adjustments >> - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 > > Good! Thanks for doing this, and sorry for the delay, I'm swamped. > > I would wait a bit though, and let the patch cook upstream, before pushing. It will obviously also need https://bugs.openjdk.org/browse/JDK-8312525. I think we are ready for 17u integration. Do you agree, @tstuefe? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1677172608 From mbaesken at openjdk.org Mon Aug 14 13:26:32 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 14 Aug 2023 13:26:32 GMT Subject: [jdk11u-dev] RFR: 8239333: Mark test AmazonCA.java with intermittent key In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 07:12:11 GMT, Matthias Baesken wrote: > 8239333: Mark test AmazonCA.java with intermittent key GHA tests have various unrelated toolchain issues, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2075#issuecomment-1677274873 From mbaesken at openjdk.org Mon Aug 14 13:26:34 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 14 Aug 2023 13:26:34 GMT Subject: [jdk11u-dev] Integrated: 8239333: Mark test AmazonCA.java with intermittent key In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 07:12:11 GMT, Matthias Baesken wrote: > 8239333: Mark test AmazonCA.java with intermittent key This pull request has now been integrated. Changeset: 00f39319 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/00f3931961fcdfd6adf7ec62d7ccc656e3e777cc Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8239333: Mark test AmazonCA.java with intermittent key Backport-of: 7f3bbc3f2075dd04ab0f54d282b8d9d02c472785 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2075 From mbaesken at openjdk.org Mon Aug 14 13:28:00 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 14 Aug 2023 13:28:00 GMT Subject: [jdk11u-dev] Integrated: 8238157: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java test failures because of revocation date Message-ID: <39gsgw0Tgkfp9GPh39gyohnWv4Phj6Lj1vaxJEdl4go=.49367e74-32ba-42e5-ab21-6d9eeb2955ee@github.com> 8238157: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java test failures because of revocation date ------------- Commit messages: - Backport 0df797de94ddcc2062067b0562afb89a936868f9 Changes: https://git.openjdk.org/jdk11u-dev/pull/2077/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2077&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8238157 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2077.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2077/head:pull/2077 PR: https://git.openjdk.org/jdk11u-dev/pull/2077 From mbaesken at openjdk.org Mon Aug 14 13:28:01 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 14 Aug 2023 13:28:01 GMT Subject: [jdk11u-dev] Integrated: 8238157: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java test failures because of revocation date In-Reply-To: <39gsgw0Tgkfp9GPh39gyohnWv4Phj6Lj1vaxJEdl4go=.49367e74-32ba-42e5-ab21-6d9eeb2955ee@github.com> References: <39gsgw0Tgkfp9GPh39gyohnWv4Phj6Lj1vaxJEdl4go=.49367e74-32ba-42e5-ab21-6d9eeb2955ee@github.com> Message-ID: On Mon, 14 Aug 2023 13:09:34 GMT, Matthias Baesken wrote: > 8238157: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java test failures because of revocation date This pull request has now been integrated. Changeset: 2411c887 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/2411c887b352c2441ae6ed9bae7daf7efefe49e0 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod 8238157: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java test failures because of revocation date Backport-of: 0df797de94ddcc2062067b0562afb89a936868f9 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2077 From mbaesken at openjdk.org Mon Aug 14 13:43:01 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 14 Aug 2023 13:43:01 GMT Subject: [jdk11u-dev] RFR: 8271838: AmazonCA.java interop test fails Message-ID: 8271838: AmazonCA.java interop test fails ------------- Commit messages: - Backport 512db0ff31a0a1a2bd8805964ba3d06e2cbfb9e9 Changes: https://git.openjdk.org/jdk11u-dev/pull/2078/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2078&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8271838 Stats: 245 lines in 1 file changed: 0 ins; 51 del; 194 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2078.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2078/head:pull/2078 PR: https://git.openjdk.org/jdk11u-dev/pull/2078 From mdoerr at openjdk.org Mon Aug 14 14:27:28 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 14 Aug 2023 14:27:28 GMT Subject: [jdk17u-dev] Integrated: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails In-Reply-To: References: Message-ID: On Sat, 12 Aug 2023 20:13:19 GMT, Martin Doerr wrote: > Backport of [JDK-8309088](https://bugs.openjdk.org/browse/JDK-8309088). This pull request has now been integrated. Changeset: ca0f1486 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/ca0f148681114b64ba0b40ea77b89a5e9bc68657 Stats: 491 lines in 1 file changed: 142 ins; 30 del; 319 mod 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails Backport-of: 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1657 From rkennke at openjdk.org Mon Aug 14 15:54:28 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Mon, 14 Aug 2023 15:54:28 GMT Subject: [jdk17u-dev] Withdrawn: 8283710: JVMTI: Use BitSet for object marking In-Reply-To: References: Message-ID: On Wed, 19 Jul 2023 13:48:07 GMT, Roman Kennke wrote: > This is a backport of [JDK-8283710](https://bugs.openjdk.org/browse/JDK-8283710) to 17u. > > There have been contextual differences around the declaration of _bitset and corresponding contextual differences in the constructor: the field _dead_objects did not exist in jdk19, but does exist in jdk17u. There also have been differences in the large block that has been removed (the whole of ObjectMarker and related code). Other than that, the backport has been clean and straightforward. > > Testing: > - [x] tier1 > - [x] tier2 > - [x] serviceability/jvmti > - [x] serviceability/jdwp > - [x] vmTestbase/nsk/jvmti > - [x] vmTestbase/msk/jdwp This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1602 From shade at openjdk.org Mon Aug 14 16:10:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 14 Aug 2023 16:10:28 GMT Subject: [jdk17u-dev] RFR: 8294149: JMH 1.34 and later requires jopt-simple 5.0.4 In-Reply-To: <-WnOoJp-G-0mP3lZFf3I3yRAxYBLs0W2z8FYQccuXZA=.310a45af-17b1-408e-99cf-19de1e2d2aa0@github.com> References: <-WnOoJp-G-0mP3lZFf3I3yRAxYBLs0W2z8FYQccuXZA=.310a45af-17b1-408e-99cf-19de1e2d2aa0@github.com> Message-ID: On Mon, 14 Aug 2023 10:41:18 GMT, Aleksey Shipilev wrote: > A series of clean backports to unbreak JMH. The clean resolution of conflicts in `jib-profiles.js` prompts clean backports of two pre-requisites: JDK-8277427 and JDK-8280032. (Nothing in OpenJDK uses those, but it is trivial to pick those up for extra cleanliness). @RealCLanger, @phohensee want to take a look here? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1663#issuecomment-1677608493 From kizune at openjdk.org Mon Aug 14 18:21:01 2023 From: kizune at openjdk.org (Alexander Zuev) Date: Mon, 14 Aug 2023 18:21:01 GMT Subject: [jdk21u] RFR: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 06:01:49 GMT, Abhishek Kumar wrote: > This is backport of https://bugs.openjdk.org/browse/JDK-8311160 to jdk21u. > > VoiceOver doesn't announce anything for JRadioButtonMenuItem and JCheckBoxMenuItem when navigated with down arrow key. JRadioButtonMenuItem and JCheckBoxMenuItem are having an accessible role of RadioButton and CheckBox respectively and it is required to notify native side whenever they are selected. > > Added the required fix and tested with SwingSet2 application. CI testing is also fine. > > Fix can be tested with SwingSet2 application and test instructions are mentioned in [JDK-8311160](https://bugs.openjdk.org/browse/JDK-8311160) description. Marked as reviewed by kizune (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u/pull/48#pullrequestreview-1577390755 From phh at openjdk.org Mon Aug 14 21:11:19 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 14 Aug 2023 21:11:19 GMT Subject: [jdk11u-dev] RFR: 8306133: Open source few AWT Drag & Drop related tests In-Reply-To: References: Message-ID: <5NACreWRLfa-Zxc1Qz0qBRz1Ye1PgcJyJIGkX1mRkwA=.42ae0980-181f-4a3c-88e8-653140036ffc@github.com> On Mon, 14 Aug 2023 07:53:29 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. Relative to the 17u backport, NotReallySerializableTest.java is missing "@key headfull". Otherwise good. ------------- Changes requested by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2076#pullrequestreview-1577655127 From valeriep at openjdk.org Tue Aug 15 00:19:13 2023 From: valeriep at openjdk.org (Valerie Peng) Date: Tue, 15 Aug 2023 00:19:13 GMT Subject: [jdk21u] RFR: 8308474: DSA does not reset SecureRandom when initSign is called again In-Reply-To: <2fjTw6kJLxyYq3jYIISzWvEqFC9WlPKXlHEpYEUxJ30=.45cbaa00-ae8f-419b-b068-6df46bcf1f5a@github.com> References: <2fjTw6kJLxyYq3jYIISzWvEqFC9WlPKXlHEpYEUxJ30=.45cbaa00-ae8f-419b-b068-6df46bcf1f5a@github.com> Message-ID: On Fri, 11 Aug 2023 10:36:08 GMT, Aleksey Shipilev wrote: > Clean backport to improve DSA security. > > Additional testing: > - [x] New regression test fails without the patch, passes with it Looks good. Thanks~ ------------- Marked as reviewed by valeriep (Reviewer). PR Review: https://git.openjdk.org/jdk21u/pull/54#pullrequestreview-1577821706 From duke at openjdk.org Tue Aug 15 00:20:19 2023 From: duke at openjdk.org (duke) Date: Tue, 15 Aug 2023 00:20:19 GMT Subject: [jdk17u-dev] Withdrawn: 8277216: Examine InstanceKlass::_misc_flags for concurrency issues In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 09:45:53 GMT, Aleksey Shipilev wrote: > Clean backport to improve JVM reliability. > > Additional testing: > - [x] Inspecting affected code paths > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1469 From stuefe at openjdk.org Tue Aug 15 05:52:18 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 15 Aug 2023 05:52:18 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v4] In-Reply-To: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> References: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> Message-ID: On Mon, 14 Aug 2023 08:50:30 GMT, Aleksey Shipilev wrote: >> Unclean backport to get useful experimental feature to LTS users. >> >> In addition to usual contextual differences, there is a number of differences against upstream version: >> - `synchronizer.cpp` hunks are different, since we do not have [JDK-8256302](https://github.com/openjdk/jdk/commit/6402004852ccc993bb6e879c49fb71e2afdcdfbe) in JDK 17 >> - `NativeHeapTrimmer_lock` changed from `Mutex::safepoint` to `Mutex::leaf`, since [JDK-8273915](https://github.com/openjdk/jdk/commit/111d5e1a9324cb5e8d98627f6329d17fcbc9c13d) renamed it after JDK 17 >> - `NativeHeapTrimmer_lock` should also allow VMThread block and never require safepoint checks; this was simplified by [JDK-8274004](https://bugs.openjdk.org/browse/JDK-8274004) later >> - `vmError.cpp` code was rewritten in JDK 17 style >> - gtest uses `EXPECT_NOT_NULL`, only brought by [JDK-8295865](https://github.com/openjdk/jdk/commit/657a0b2f1564e1754dbd64b776c53a52c480c901#diff-35b3b4703decd15bfd2fc614d431e909727a6cf4d399cf05c7a12466e61ab8a0R58-R59) -- I rewrote them to EXPECT_NE/EQ. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug, trim tests >> - [x] Linux x86_64 fastdebug, `tier1` >> - [x] Linux x86_64 fastdebug, `tier2` >> - [x] Linux x86_64 fastdebug, `tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into JDK-8293114-trim-native > - More adjustments > - Adjustments > - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 Hold up , I'll ask my SAP collegues first to put this through their backport CI. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1678455694 From shade at openjdk.org Tue Aug 15 07:00:14 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:00:14 GMT Subject: [jdk21u] RFR: 8312127: FileDescriptor.sync should temporarily increase parallelism In-Reply-To: References: Message-ID: On Thu, 10 Aug 2023 16:06:10 GMT, Aleksey Shipilev wrote: > Clean backport to avoid the temporary loss of platform thread when virtual thread does `fsync`. In https://github.com/openjdk/jdk/pull/15231, I tested that the overhead of doing this for platform threads is very small compared to the cost of the `fsync` itself. Reviews are here. Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/52#issuecomment-1678503327 From shade at openjdk.org Tue Aug 15 07:01:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:01:13 GMT Subject: [jdk21u] RFR: 8308474: DSA does not reset SecureRandom when initSign is called again In-Reply-To: <2fjTw6kJLxyYq3jYIISzWvEqFC9WlPKXlHEpYEUxJ30=.45cbaa00-ae8f-419b-b068-6df46bcf1f5a@github.com> References: <2fjTw6kJLxyYq3jYIISzWvEqFC9WlPKXlHEpYEUxJ30=.45cbaa00-ae8f-419b-b068-6df46bcf1f5a@github.com> Message-ID: On Fri, 11 Aug 2023 10:36:08 GMT, Aleksey Shipilev wrote: > Clean backport to improve DSA security. > > Additional testing: > - [x] New regression test fails without the patch, passes with it Thanks! Review is here. Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/54#issuecomment-1678502349 From shade at openjdk.org Tue Aug 15 07:01:19 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:01:19 GMT Subject: [jdk21u] RFR: 8313307: java/util/Formatter/Padding.java fails on some Locales In-Reply-To: <9dG0t39XCw-tiLcoUynYFu4me237J-HU1Jevzaw8mHc=.81055dd5-21de-43c1-99ed-48931df1ee18@github.com> References: <9dG0t39XCw-tiLcoUynYFu4me237J-HU1Jevzaw8mHc=.81055dd5-21de-43c1-99ed-48931df1ee18@github.com> Message-ID: On Thu, 10 Aug 2023 14:26:28 GMT, Aleksey Shipilev wrote: > Clean backport to fix the test. > > Additional testing: > - [x] Affected test fails without the fix, passes with it Push approval is here. Testing is clean. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/51#issuecomment-1678502824 From shade at openjdk.org Tue Aug 15 07:01:16 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:01:16 GMT Subject: [jdk21u] Integrated: 8308474: DSA does not reset SecureRandom when initSign is called again In-Reply-To: <2fjTw6kJLxyYq3jYIISzWvEqFC9WlPKXlHEpYEUxJ30=.45cbaa00-ae8f-419b-b068-6df46bcf1f5a@github.com> References: <2fjTw6kJLxyYq3jYIISzWvEqFC9WlPKXlHEpYEUxJ30=.45cbaa00-ae8f-419b-b068-6df46bcf1f5a@github.com> Message-ID: On Fri, 11 Aug 2023 10:36:08 GMT, Aleksey Shipilev wrote: > Clean backport to improve DSA security. > > Additional testing: > - [x] New regression test fails without the patch, passes with it This pull request has now been integrated. Changeset: bdf9f4b6 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/bdf9f4b6cc1ccd4ba6865435a5e9f6713f647881 Stats: 70 lines in 2 files changed: 69 ins; 0 del; 1 mod 8308474: DSA does not reset SecureRandom when initSign is called again Reviewed-by: valeriep Backport-of: bed9161c815b5b4773f36eac7e8dadc1384c7fd1 ------------- PR: https://git.openjdk.org/jdk21u/pull/54 From shade at openjdk.org Tue Aug 15 07:01:19 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:01:19 GMT Subject: [jdk21u] Integrated: 8313307: java/util/Formatter/Padding.java fails on some Locales In-Reply-To: <9dG0t39XCw-tiLcoUynYFu4me237J-HU1Jevzaw8mHc=.81055dd5-21de-43c1-99ed-48931df1ee18@github.com> References: <9dG0t39XCw-tiLcoUynYFu4me237J-HU1Jevzaw8mHc=.81055dd5-21de-43c1-99ed-48931df1ee18@github.com> Message-ID: On Thu, 10 Aug 2023 14:26:28 GMT, Aleksey Shipilev wrote: > Clean backport to fix the test. > > Additional testing: > - [x] Affected test fails without the fix, passes with it This pull request has now been integrated. Changeset: bd634d2e Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/bd634d2ec77f0208a2db54bc00567777ee7c8661 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8313307: java/util/Formatter/Padding.java fails on some Locales Backport-of: 408987e1ca9a42db8019b1bd7e52f85607975dde ------------- PR: https://git.openjdk.org/jdk21u/pull/51 From shade at openjdk.org Tue Aug 15 07:02:14 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:02:14 GMT Subject: [jdk21u] Integrated: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased In-Reply-To: <0pc0MHBSETKeT0yaVL7Q_eW_CXgN4TNJz4_Ko5akoyE=.046a5fb6-2f22-438e-91ce-9bdaf52648db@github.com> References: <0pc0MHBSETKeT0yaVL7Q_eW_CXgN4TNJz4_Ko5akoyE=.046a5fb6-2f22-438e-91ce-9bdaf52648db@github.com> Message-ID: On Fri, 11 Aug 2023 10:05:21 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the test. This pull request has now been integrated. Changeset: b06ee413 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/b06ee413fb246d7fed9bd2c6d562ce401a055f14 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased Reviewed-by: stuefe Backport-of: 117f42dbe9a78bcf43bdf3873d5d86a19a9092d3 ------------- PR: https://git.openjdk.org/jdk21u/pull/53 From shade at openjdk.org Tue Aug 15 07:02:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:02:13 GMT Subject: [jdk21u] RFR: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased In-Reply-To: <0pc0MHBSETKeT0yaVL7Q_eW_CXgN4TNJz4_Ko5akoyE=.046a5fb6-2f22-438e-91ce-9bdaf52648db@github.com> References: <0pc0MHBSETKeT0yaVL7Q_eW_CXgN4TNJz4_Ko5akoyE=.046a5fb6-2f22-438e-91ce-9bdaf52648db@github.com> Message-ID: <-qsjLhuBavDVYK1T-idP6tAIFCYt-UbQcldv0jTV9ZE=.97673125-4d58-48fb-b7e9-0228807ca7a1@github.com> On Fri, 11 Aug 2023 10:05:21 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the test. Reviews are here. Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/53#issuecomment-1678504096 From shade at openjdk.org Tue Aug 15 07:03:18 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:03:18 GMT Subject: [jdk21u] Integrated: 8312127: FileDescriptor.sync should temporarily increase parallelism In-Reply-To: References: Message-ID: On Thu, 10 Aug 2023 16:06:10 GMT, Aleksey Shipilev wrote: > Clean backport to avoid the temporary loss of platform thread when virtual thread does `fsync`. In https://github.com/openjdk/jdk/pull/15231, I tested that the overhead of doing this for platform threads is very small compared to the cost of the `fsync` itself. This pull request has now been integrated. Changeset: 8912d3e5 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/8912d3e5893a517a4f428e83b1fb2d96be572791 Stats: 17 lines in 3 files changed: 11 ins; 0 del; 6 mod 8312127: FileDescriptor.sync should temporarily increase parallelism Reviewed-by: alanb Backport-of: fbe51e388d8a7475f162f10aa788a6d37ec4c6d8 ------------- PR: https://git.openjdk.org/jdk21u/pull/52 From duke at openjdk.org Tue Aug 15 07:05:08 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Tue, 15 Aug 2023 07:05:08 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v4] In-Reply-To: References: Message-ID: > I would like to fix this issue > because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. > Testing: > all serviceability area tests jdk_svc, and a specific test to verify the fix. > > Could anyone review the fix please? > > Thanks, > Kimura Yukihiro Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into 8313815 - Merge master - Merge master - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1641/files - new: https://git.openjdk.org/jdk17u-dev/pull/1641/files/5a5c43ca..3bd7e1a7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1641&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1641&range=02-03 Stats: 608 lines in 7 files changed: 229 ins; 33 del; 346 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1641.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1641/head:pull/1641 PR: https://git.openjdk.org/jdk17u-dev/pull/1641 From shade at openjdk.org Tue Aug 15 07:06:15 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:06:15 GMT Subject: [jdk21u] RFR: 8314118: Update JMH devkit to 1.37 In-Reply-To: References: Message-ID: <3TC35jpgMis49Z2mYNTupPViADZGS8iO5CbNhYnHPgw=.5fb93504-de0e-4608-904c-45fee63e6ea3@github.com> On Mon, 14 Aug 2023 10:10:55 GMT, Aleksey Shipilev wrote: > Clean backport to improve performance testing. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/58#issuecomment-1678505767 From shade at openjdk.org Tue Aug 15 07:06:15 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:06:15 GMT Subject: [jdk21u] Integrated: 8314118: Update JMH devkit to 1.37 In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 10:10:55 GMT, Aleksey Shipilev wrote: > Clean backport to improve performance testing. This pull request has now been integrated. Changeset: 56e6e454 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/56e6e4544cc1a1ea5e3974e2ffc3b7231e5d5652 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8314118: Update JMH devkit to 1.37 Backport-of: 06aa3c5628e749188238dda3d41c776a5a2f7c81 ------------- PR: https://git.openjdk.org/jdk21u/pull/58 From shade at openjdk.org Tue Aug 15 07:09:15 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:09:15 GMT Subject: [jdk21u] RFR: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers In-Reply-To: References: Message-ID: On Fri, 11 Aug 2023 13:49:44 GMT, Aleksey Shipilev wrote: > Clean backport to fix minor TLS 3.0 bug. > > Additional testing: > - [x] macosx-aarch64-server-fastdebug, `jdk_security` passes Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/55#issuecomment-1678508979 From shade at openjdk.org Tue Aug 15 07:09:16 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 07:09:16 GMT Subject: [jdk21u] Integrated: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers In-Reply-To: References: Message-ID: On Fri, 11 Aug 2023 13:49:44 GMT, Aleksey Shipilev wrote: > Clean backport to fix minor TLS 3.0 bug. > > Additional testing: > - [x] macosx-aarch64-server-fastdebug, `jdk_security` passes This pull request has now been integrated. Changeset: afd6c7a0 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/afd6c7a0bcd8946dcc2a956a8130a443272c2023 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers Backport-of: db133dbc02a7f38104fdbca967c59f758c6f4336 ------------- PR: https://git.openjdk.org/jdk21u/pull/55 From mbaesken at openjdk.org Tue Aug 15 07:13:09 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 15 Aug 2023 07:13:09 GMT Subject: [jdk21u] Integrated: 8311511: Improve description of NativeLibrary JFR event In-Reply-To: <0_10xSyku9Q4xcOkBZ3SEbarnS464cPgbkBhTYqawC8=.9cfb5dd7-b8d2-4ead-be80-6b15878b82d9@github.com> References: <0_10xSyku9Q4xcOkBZ3SEbarnS464cPgbkBhTYqawC8=.9cfb5dd7-b8d2-4ead-be80-6b15878b82d9@github.com> Message-ID: On Fri, 11 Aug 2023 14:59:44 GMT, Matthias Baesken wrote: > 8311511: Improve description of NativeLibrary JFR event This pull request has now been integrated. Changeset: 956d563e Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u/commit/956d563e3cb3868c3471a1e6f9758a75743c7963 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8311511: Improve description of NativeLibrary JFR event Backport-of: 848abd2831ab38d99b6b76b55cbe8d84c28be330 ------------- PR: https://git.openjdk.org/jdk21u/pull/56 From stuefe at openjdk.org Tue Aug 15 09:28:51 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 15 Aug 2023 09:28:51 GMT Subject: [jdk21u] RFR: 8310233: Fix THP detection on Linux Message-ID: Hi all, This patch is one in a small line of preparatory patches that aim, ultimately, to fix https://bugs.openjdk.org/browse/JDK-8312182 ("THPs cause huge RSS due to thread start timing issue"). This pull request contains a backport of commit [37ca9024](https://github.com/openjdk/jdk/commit/37ca9024ef59d99cae0bd7e25b2e6d3c1e085f97) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Thomas Stuefe on 17 Jul 2023 and was reviewed by Johan Sj?len and David Holmes. Thanks! ------------- Commit messages: - Backport 37ca9024ef59d99cae0bd7e25b2e6d3c1e085f97 Changes: https://git.openjdk.org/jdk21u/pull/60/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=60&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310233 Stats: 815 lines in 7 files changed: 684 ins; 99 del; 32 mod Patch: https://git.openjdk.org/jdk21u/pull/60.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/60/head:pull/60 PR: https://git.openjdk.org/jdk21u/pull/60 From shade at openjdk.org Tue Aug 15 09:36:48 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 09:36:48 GMT Subject: [jdk17u-dev] RFR: 8280705: Parallel: Full gc mark stack draining should prefer to make work available to other threads [v3] In-Reply-To: References: Message-ID: <90O1Q5M9iOYOAhuGnASsn83i9IikMZi69M763L_u04w=.1e7cb634-0717-4698-a48f-5e5f44a8bf49@github.com> > Clean backport to match what G1 is also doing. The change was in mainline for more than a year without related issues. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` with `-XX:+UseParallelGC` > - [x] Linux x86_64 fastdebug `tier2` with `-XX:+UseParallelGC` > - [x] Linux x86_64 fastdebug `tier3` with `-XX:+UseParallelGC` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into JDK-8280705-parallel-fullgc-work - Merge branch 'master' into JDK-8280705-parallel-fullgc-work - Merge branch 'master' into JDK-8280705-parallel-fullgc-work - Backport bdda43e066b8da0ebf9a8ef2f843eabb230f0800 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1521/files - new: https://git.openjdk.org/jdk17u-dev/pull/1521/files/e941b400..8ff5270e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1521&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1521&range=01-02 Stats: 43631 lines in 910 files changed: 16515 ins; 14581 del; 12535 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1521.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1521/head:pull/1521 PR: https://git.openjdk.org/jdk17u-dev/pull/1521 From andrewlu at openjdk.org Tue Aug 15 11:51:34 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 15 Aug 2023 11:51:34 GMT Subject: [jdk11u-dev] Integrated: 8306954: Open source five Focus related tests In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 07:33:57 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. This pull request has now been integrated. Changeset: 026e3282 Author: Andrew Lu Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/026e328252b77da57af852dc978a9b259ee4bece Stats: 962 lines in 5 files changed: 962 ins; 0 del; 0 mod 8306954: Open source five Focus related tests Backport-of: 6d6d00b69cea47ccbe05a844db0fb6c384045caa ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2071 From andrewlu at openjdk.org Tue Aug 15 11:51:37 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 15 Aug 2023 11:51:37 GMT Subject: [jdk11u-dev] Integrated: 8307133: Open source some JTable jtreg tests In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 08:15:32 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. This pull request has now been integrated. Changeset: ba86e9db Author: Andrew Lu Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/ba86e9dbad7fb38151f36f4ed108c6724ca9051f Stats: 486 lines in 9 files changed: 486 ins; 0 del; 0 mod 8307133: Open source some JTable jtreg tests Backport-of: 5ca0b08a7505d5c210d906e76c2a4cfc3eed64aa ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2065 From andrewlu at openjdk.org Tue Aug 15 11:52:23 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 15 Aug 2023 11:52:23 GMT Subject: [jdk11u-dev] Integrated: 8306955: Open source several JComboBox jtreg tests In-Reply-To: <1iEji4b_hiBxvtTRUQMyWJgS62-BCBhVpXvKudjK4VE=.730e35c7-2a67-4e5b-84b2-42874a0bcaa1@github.com> References: <1iEji4b_hiBxvtTRUQMyWJgS62-BCBhVpXvKudjK4VE=.730e35c7-2a67-4e5b-84b2-42874a0bcaa1@github.com> Message-ID: On Wed, 9 Aug 2023 07:56:48 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. This pull request has now been integrated. Changeset: 9eadce36 Author: Andrew Lu Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/9eadce369ea69e9d15f66f4f16b1bddbedd0040f Stats: 392 lines in 5 files changed: 392 ins; 0 del; 0 mod 8306955: Open source several JComboBox jtreg tests Backport-of: 1f689241cfcb4083cba283a2010b532948865283 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2072 From shade at openjdk.org Tue Aug 15 15:16:22 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 15:16:22 GMT Subject: [jdk17u-dev] RFR: 8280705: Parallel: Full gc mark stack draining should prefer to make work available to other threads [v3] In-Reply-To: <90O1Q5M9iOYOAhuGnASsn83i9IikMZi69M763L_u04w=.1e7cb634-0717-4698-a48f-5e5f44a8bf49@github.com> References: <90O1Q5M9iOYOAhuGnASsn83i9IikMZi69M763L_u04w=.1e7cb634-0717-4698-a48f-5e5f44a8bf49@github.com> Message-ID: On Tue, 15 Aug 2023 09:36:48 GMT, Aleksey Shipilev wrote: >> Clean backport to match what G1 is also doing. The change was in mainline for more than a year without related issues. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug `tier1` with `-XX:+UseParallelGC` >> - [x] Linux x86_64 fastdebug `tier2` with `-XX:+UseParallelGC` >> - [x] Linux x86_64 fastdebug `tier3` with `-XX:+UseParallelGC` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into JDK-8280705-parallel-fullgc-work > - Merge branch 'master' into JDK-8280705-parallel-fullgc-work > - Merge branch 'master' into JDK-8280705-parallel-fullgc-work > - Backport bdda43e066b8da0ebf9a8ef2f843eabb230f0800 Hm, this actually regresses Parallel Full GC performance on some workloads. For example, `dotty`: % java -XX:+UseParallelGC -Xmx1g -Xms1g -Xlog:gc -jar ../renaissance-mit-0.14.2.jar dotty 2>&1 | grep "Pause Full" # Baseline ... [62.287s][info][gc] GC(76) Pause Full (System.gc()) 22M->22M(981M) 64.464ms [63.693s][info][gc] GC(78) Pause Full (System.gc()) 22M->22M(981M) 62.254ms [65.091s][info][gc] GC(80) Pause Full (System.gc()) 22M->22M(981M) 61.213ms [66.492s][info][gc] GC(82) Pause Full (System.gc()) 22M->22M(981M) 62.152ms [67.893s][info][gc] GC(84) Pause Full (System.gc()) 22M->22M(981M) 61.495ms [69.292s][info][gc] GC(86) Pause Full (System.gc()) 22M->22M(981M) 62.536ms [70.680s][info][gc] GC(88) Pause Full (System.gc()) 22M->22M(981M) 62.616ms [72.078s][info][gc] GC(90) Pause Full (System.gc()) 22M->22M(981M) 62.685ms [73.471s][info][gc] GC(92) Pause Full (System.gc()) 22M->22M(981M) 60.560ms # 17u with this patch [63.834s][info][gc] GC(78) Pause Full (System.gc()) 22M->22M(981M) 66.412ms [65.235s][info][gc] GC(80) Pause Full (System.gc()) 22M->22M(981M) 70.616ms [66.638s][info][gc] GC(82) Pause Full (System.gc()) 22M->22M(981M) 66.929ms [68.043s][info][gc] GC(84) Pause Full (System.gc()) 22M->22M(981M) 66.627ms [69.451s][info][gc] GC(86) Pause Full (System.gc()) 22M->22M(981M) 67.261ms [70.858s][info][gc] GC(88) Pause Full (System.gc()) 22M->22M(981M) 71.890ms [72.259s][info][gc] GC(90) Pause Full (System.gc()) 22M->22M(981M) 67.020ms [73.656s][info][gc] GC(92) Pause Full (System.gc()) 22M->22M(981M) 67.471ms [75.059s][info][gc] GC(94) Pause Full (System.gc()) 22M->22M(981M) 68.016ms ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1521#issuecomment-1679106712 From shade at openjdk.org Tue Aug 15 17:16:19 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 15 Aug 2023 17:16:19 GMT Subject: [jdk17u-dev] RFR: 8280705: Parallel: Full gc mark stack draining should prefer to make work available to other threads [v3] In-Reply-To: <90O1Q5M9iOYOAhuGnASsn83i9IikMZi69M763L_u04w=.1e7cb634-0717-4698-a48f-5e5f44a8bf49@github.com> References: <90O1Q5M9iOYOAhuGnASsn83i9IikMZi69M763L_u04w=.1e7cb634-0717-4698-a48f-5e5f44a8bf49@github.com> Message-ID: On Tue, 15 Aug 2023 09:36:48 GMT, Aleksey Shipilev wrote: >> Clean backport to match what G1 is also doing. The change was in mainline for more than a year without related issues. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug `tier1` with `-XX:+UseParallelGC` >> - [x] Linux x86_64 fastdebug `tier2` with `-XX:+UseParallelGC` >> - [x] Linux x86_64 fastdebug `tier3` with `-XX:+UseParallelGC` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into JDK-8280705-parallel-fullgc-work > - Merge branch 'master' into JDK-8280705-parallel-fullgc-work > - Merge branch 'master' into JDK-8280705-parallel-fullgc-work > - Backport bdda43e066b8da0ebf9a8ef2f843eabb230f0800 Same with `naive-bayes`: $ build/linux-x86_64-server-release/images/jdk/bin/java -XX:+UseParallelGC -Xmx4g -Xms4g -XX:+AlwaysPreTouch -Xlog:gc -jar ../renaissance-mit-0.14.2.jar naive-bayes 2>&1 | grep "Pause Full" # Before [24.500s][info][gc] GC(340) Pause Full (System.gc()) 1373M->1367M(4089M) 90.501ms [25.173s][info][gc] GC(353) Pause Full (System.gc()) 1373M->1367M(4090M) 92.504ms [25.844s][info][gc] GC(366) Pause Full (System.gc()) 1373M->1367M(4089M) 93.355ms [26.518s][info][gc] GC(379) Pause Full (System.gc()) 1373M->1367M(4090M) 91.851ms [27.215s][info][gc] GC(392) Pause Full (System.gc()) 1373M->1367M(4090M) 91.128ms [27.900s][info][gc] GC(405) Pause Full (System.gc()) 1373M->1367M(4090M) 90.536ms [28.570s][info][gc] GC(418) Pause Full (System.gc()) 1373M->1367M(4090M) 92.705ms [29.247s][info][gc] GC(431) Pause Full (System.gc()) 1373M->1367M(4090M) 91.838ms [29.926s][info][gc] GC(444) Pause Full (System.gc()) 1373M->1367M(4090M) 92.964ms [30.599s][info][gc] GC(457) Pause Full (System.gc()) 1373M->1367M(4089M) 91.042ms # After [24.654s][info][gc] GC(338) Pause Full (System.gc()) 1373M->1367M(4090M) 105.490ms [25.349s][info][gc] GC(351) Pause Full (System.gc()) 1373M->1367M(4090M) 106.263ms [26.046s][info][gc] GC(364) Pause Full (System.gc()) 1373M->1367M(4090M) 106.324ms [26.748s][info][gc] GC(377) Pause Full (System.gc()) 1373M->1367M(4090M) 106.146ms [27.448s][info][gc] GC(390) Pause Full (System.gc()) 1373M->1367M(4090M) 108.895ms [28.143s][info][gc] GC(403) Pause Full (System.gc()) 1373M->1367M(4090M) 107.850ms [28.861s][info][gc] GC(416) Pause Full (System.gc()) 1373M->1367M(4090M) 106.542ms [29.550s][info][gc] GC(429) Pause Full (System.gc()) 1373M->1367M(4090M) 109.635ms [30.233s][info][gc] GC(442) Pause Full (System.gc()) 1373M->1367M(4090M) 107.652ms [30.922s][info][gc] GC(455) Pause Full (System.gc()) 1374M->1367M(4090M) 108.397ms ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1521#issuecomment-1679313219 From mdoerr at openjdk.org Tue Aug 15 19:30:23 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 15 Aug 2023 19:30:23 GMT Subject: [jdk11u-dev] RFR: 8305733: Pattern.CASE_INSENSITIVE does not take effect in jdk11 [v8] In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 02:16:13 GMT, Korov wrote: >> fix [JDK-8305733](https://bugs.openjdk.org/browse/JDK-8305733) > > Korov has updated the pull request incrementally with one additional commit since the last revision: > > Update RegExTest.java This repository requires approval before integration. See https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix step 6. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2062#issuecomment-1679479975 From btaylor at openjdk.org Tue Aug 15 21:57:37 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 15 Aug 2023 21:57:37 GMT Subject: [jdk17u-dev] RFR: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Message-ID: <4TvXNgthFyHG2Wt9xecwHFlCFlFFAxzCataV3Oz16os=.f9cfea17-b5a4-4836-96a0-195ceadb0221@github.com> Backort [8313796](https://bugs.openjdk.org/browse/JDK-8313796) to resolve a hotspot crash. Backport is clean and passes jtreg tier 1-4 tests. ------------- Commit messages: - Backport 0e2c72d7a5206b7173af5bf69e21d21ea276bd94 Changes: https://git.openjdk.org/jdk17u-dev/pull/1665/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1665&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313796 Stats: 16 lines in 7 files changed: 11 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1665.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1665/head:pull/1665 PR: https://git.openjdk.org/jdk17u-dev/pull/1665 From btaylor at openjdk.org Tue Aug 15 21:57:44 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 15 Aug 2023 21:57:44 GMT Subject: [jdk11u-dev] RFR: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Message-ID: Backport [8313796](https://bugs.openjdk.org/browse/JDK-8313796) to resolve a hotspot crash. Passes jtreg tier 1-4 tests. This change required the following modifications: - Remove riscv code, as the riscv port is not present in jdk 11 - Replace `nullptr` with `NULL` to accommodate older C++ standards/compilers ------------- Commit messages: - 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Changes: https://git.openjdk.org/jdk11u-dev/pull/2079/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2079&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313796 Stats: 15 lines in 6 files changed: 11 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2079.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2079/head:pull/2079 PR: https://git.openjdk.org/jdk11u-dev/pull/2079 From phh at openjdk.org Tue Aug 15 23:34:14 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 15 Aug 2023 23:34:14 GMT Subject: [jdk11u-dev] RFR: 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v2] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Thu, 10 Aug 2023 10:35:28 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > Update full name Tagged the JBS issue. GHA failures look like infrastructure issues. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2074#issuecomment-1679758450 From phh at openjdk.org Tue Aug 15 23:52:17 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 15 Aug 2023 23:52:17 GMT Subject: [jdk11u-dev] RFR: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer In-Reply-To: References: Message-ID: On Tue, 15 Aug 2023 21:49:14 GMT, Ben Taylor wrote: > Backport [8313796](https://bugs.openjdk.org/browse/JDK-8313796) to resolve a hotspot crash. Passes jtreg tier 1-4 tests. > > This change required the following modifications: > - Remove riscv code, as the riscv port is not present in jdk 11 > - Replace `nullptr` with `NULL` to accommodate older C++ standards/compilers Lgtm. Please configure pre-submit testing on your repo and run it. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2079#pullrequestreview-1579610464 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2079#issuecomment-1679770488 From andrewlu at openjdk.org Wed Aug 16 02:20:24 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 16 Aug 2023 02:20:24 GMT Subject: [jdk11u-dev] RFR: 8306133: Open source few AWT Drag & Drop related tests In-Reply-To: <5NACreWRLfa-Zxc1Qz0qBRz1Ye1PgcJyJIGkX1mRkwA=.42ae0980-181f-4a3c-88e8-653140036ffc@github.com> References: <5NACreWRLfa-Zxc1Qz0qBRz1Ye1PgcJyJIGkX1mRkwA=.42ae0980-181f-4a3c-88e8-653140036ffc@github.com> Message-ID: On Mon, 14 Aug 2023 21:08:57 GMT, Paul Hohensee wrote: > Relative to the 17u backport, NotReallySerializableTest.java is missing "@key headfull". Otherwise good. hi, NotReallySerializableTest.java has "@key headfull" backport from JDK-8307135 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2076#issuecomment-1679866372 From phh at openjdk.org Wed Aug 16 05:47:22 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 16 Aug 2023 05:47:22 GMT Subject: [jdk11u-dev] RFR: 8306133: Open source few AWT Drag & Drop related tests In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 07:53:29 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. :) ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2076#pullrequestreview-1579839341 From abhiscxk at openjdk.org Wed Aug 16 06:22:16 2023 From: abhiscxk at openjdk.org (Abhishek Kumar) Date: Wed, 16 Aug 2023 06:22:16 GMT Subject: [jdk21u] Integrated: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 06:01:49 GMT, Abhishek Kumar wrote: > This is backport of https://bugs.openjdk.org/browse/JDK-8311160 to jdk21u. > > VoiceOver doesn't announce anything for JRadioButtonMenuItem and JCheckBoxMenuItem when navigated with down arrow key. JRadioButtonMenuItem and JCheckBoxMenuItem are having an accessible role of RadioButton and CheckBox respectively and it is required to notify native side whenever they are selected. > > Added the required fix and tested with SwingSet2 application. CI testing is also fine. > > Fix can be tested with SwingSet2 application and test instructions are mentioned in [JDK-8311160](https://bugs.openjdk.org/browse/JDK-8311160) description. This pull request has now been integrated. Changeset: f7626de5 Author: Abhishek Kumar Committer: Jayathirth D V URL: https://git.openjdk.org/jdk21u/commit/f7626de5d198a83263b5ccc00575974deed023c1 Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem Reviewed-by: asemenov, kizune Backport-of: c1f4595e64b0ea0439c6e7f61a6a92b56b526d97 ------------- PR: https://git.openjdk.org/jdk21u/pull/48 From duke at openjdk.org Wed Aug 16 06:31:20 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Wed, 16 Aug 2023 06:31:20 GMT Subject: [jdk11u-dev] RFR: 8302161: Upgrade jQuery UI to version 1.13.2 In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 05:21:05 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8302161 for jdk11u. > This is clean backport. > Also, this backport contains JDK-8293180. > > All jdk/javadoc tests are passed. Would someone review this fix? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2064#issuecomment-1680035380 From andrewlu at openjdk.org Wed Aug 16 07:03:27 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 16 Aug 2023 07:03:27 GMT Subject: [jdk11u-dev] RFR: 8307080: Open source some more JComboBox jtreg tests Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport b8de39431dca90e63552968829a349a9b63e68ca Changes: https://git.openjdk.org/jdk11u-dev/pull/2080/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2080&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307080 Stats: 425 lines in 5 files changed: 425 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2080.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2080/head:pull/2080 PR: https://git.openjdk.org/jdk11u-dev/pull/2080 From shade at openjdk.org Wed Aug 16 07:19:26 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 07:19:26 GMT Subject: [jdk17u-dev] RFR: 8294149: JMH 1.34 and later requires jopt-simple 5.0.4 In-Reply-To: <-WnOoJp-G-0mP3lZFf3I3yRAxYBLs0W2z8FYQccuXZA=.310a45af-17b1-408e-99cf-19de1e2d2aa0@github.com> References: <-WnOoJp-G-0mP3lZFf3I3yRAxYBLs0W2z8FYQccuXZA=.310a45af-17b1-408e-99cf-19de1e2d2aa0@github.com> Message-ID: On Mon, 14 Aug 2023 10:41:18 GMT, Aleksey Shipilev wrote: > A series of clean backports to unbreak JMH. The clean resolution of conflicts in `jib-profiles.js` prompts clean backports of two pre-requisites: JDK-8277427 and JDK-8280032. (Nothing in OpenJDK uses those, but it is trivial to pick those up for extra cleanliness). Actually, I might just declare these clean, since I made no actual changes. The PR is not marked clean because it is a stack of backports. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1663#issuecomment-1680088203 From duke at openjdk.org Wed Aug 16 07:20:21 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Wed, 16 Aug 2023 07:20:21 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v4] In-Reply-To: References: Message-ID: On Tue, 15 Aug 2023 07:05:08 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into 8313815 > - Merge master > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Hello Chris, Thank you for your review. I would like to go with the current fix, as I replied to your comment. I received a comment from you that this fix is OK, but please let me know if you have any concerns. It would be great if you could approve it. It is my understanding that a pull request must be approved by at least two reviewer in order to be accepted. Thanks, Kimura Yukihiro ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1680089176 From shade at openjdk.org Wed Aug 16 08:18:26 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 08:18:26 GMT Subject: [jdk17u-dev] RFR: 8294149: JMH 1.34 and later requires jopt-simple 5.0.4 In-Reply-To: <-WnOoJp-G-0mP3lZFf3I3yRAxYBLs0W2z8FYQccuXZA=.310a45af-17b1-408e-99cf-19de1e2d2aa0@github.com> References: <-WnOoJp-G-0mP3lZFf3I3yRAxYBLs0W2z8FYQccuXZA=.310a45af-17b1-408e-99cf-19de1e2d2aa0@github.com> Message-ID: On Mon, 14 Aug 2023 10:41:18 GMT, Aleksey Shipilev wrote: > A series of clean backports to unbreak JMH. The clean resolution of conflicts in `jib-profiles.js` prompts clean backports of two pre-requisites: JDK-8277427 and JDK-8280032. (Nothing in OpenJDK uses those, but it is trivial to pick those up for extra cleanliness). Push approval for all three is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1663#issuecomment-1680165488 From shade at openjdk.org Wed Aug 16 08:19:38 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 08:19:38 GMT Subject: [jdk17u-dev] RFR: 8304353: Add lib-test tier1 testing in GHA In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 08:33:52 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA coverage. > > Additional testing: > - [x] GHA Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1658#issuecomment-1680164355 From shade at openjdk.org Wed Aug 16 08:19:39 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 08:19:39 GMT Subject: [jdk17u-dev] Integrated: 8304353: Add lib-test tier1 testing in GHA In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 08:33:52 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA coverage. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 6985739a Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/6985739a238db664050815f4de1fc56c803f5594 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod 8304353: Add lib-test tier1 testing in GHA Backport-of: 57276101df79f07b14b914b36b1155cedec3eb3d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1658 From goetz at openjdk.org Wed Aug 16 08:19:37 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 16 Aug 2023 08:19:37 GMT Subject: [jdk11u-dev] RFR: 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v2] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Thu, 10 Aug 2023 10:35:28 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > Update full name Hi, you are adding a new file jdk.zip. I think this is not a good idea. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2074#issuecomment-1680166325 From shade at openjdk.org Wed Aug 16 08:21:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 08:21:35 GMT Subject: [jdk17u-dev] Integrated: 8294149: JMH 1.34 and later requires jopt-simple 5.0.4 In-Reply-To: <-WnOoJp-G-0mP3lZFf3I3yRAxYBLs0W2z8FYQccuXZA=.310a45af-17b1-408e-99cf-19de1e2d2aa0@github.com> References: <-WnOoJp-G-0mP3lZFf3I3yRAxYBLs0W2z8FYQccuXZA=.310a45af-17b1-408e-99cf-19de1e2d2aa0@github.com> Message-ID: On Mon, 14 Aug 2023 10:41:18 GMT, Aleksey Shipilev wrote: > A series of clean backports to unbreak JMH. The clean resolution of conflicts in `jib-profiles.js` prompts clean backports of two pre-requisites: JDK-8277427 and JDK-8280032. (Nothing in OpenJDK uses those, but it is trivial to pick those up for extra cleanliness). This pull request has now been integrated. Changeset: 75779ec2 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/75779ec29462f62e0f282258dde9ff35d475c396 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8294149: JMH 1.34 and later requires jopt-simple 5.0.4 8277427: Update jib-profiles.js to use JMH 1.33 devkit 8280032: Update jib-profiles.js to use JMH 1.34 devkit Backport-of: 2283c3244f4fe475593d8a53613b5a3228bec356 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1663 From shade at openjdk.org Wed Aug 16 08:34:23 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 08:34:23 GMT Subject: [jdk17u-dev] RFR: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 08:39:55 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA reliability. > > Additional testing: > - [x] GHA (sysroots are re-created successfully) Push approval is here. Testing is clean. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1660#issuecomment-1680187539 From shade at openjdk.org Wed Aug 16 08:36:21 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 08:36:21 GMT Subject: [jdk17u-dev] RFR: 8299330: Minor improvements in MSYS2 Workflow handling In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 08:37:38 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA reliability. > > Additional testing: > - [x] GHA (Windows build/test is fine) Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1659#issuecomment-1680186996 From shade at openjdk.org Wed Aug 16 08:36:22 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 08:36:22 GMT Subject: [jdk17u-dev] Integrated: 8299330: Minor improvements in MSYS2 Workflow handling In-Reply-To: References: Message-ID: <6cYHTk6p7rKQRxPktJkGAcABgyxqoK9Aqd7IsZ00910=.dda5aff7-578e-4d4f-89cb-68a3ce9e9931@github.com> On Mon, 14 Aug 2023 08:37:38 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA reliability. > > Additional testing: > - [x] GHA (Windows build/test is fine) This pull request has now been integrated. Changeset: 197d2dab Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/197d2dabd00efc97c471c54582c6325c722d7930 Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod 8299330: Minor improvements in MSYS2 Workflow handling Backport-of: cf00d09c8c37ee301e1c6657df45777647a834e9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1659 From shade at openjdk.org Wed Aug 16 08:37:14 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 08:37:14 GMT Subject: [jdk17u-dev] Integrated: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 08:39:55 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA reliability. > > Additional testing: > - [x] GHA (sysroots are re-created successfully) This pull request has now been integrated. Changeset: b9a72316 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/b9a72316112952e47b05a2a2310c82c7f54eebcf Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8294956: GHA: qemu-debootstrap is deprecated, use the regular one Backport-of: c5f462e83b85ec53ec395622063a5b131aaf0827 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1660 From shade at openjdk.org Wed Aug 16 08:42:22 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 08:42:22 GMT Subject: [jdk17u-dev] RFR: 8294941: GHA: Cut down cross-compilation sysroots In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 08:41:50 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA footprint overheads. > > Additional testing: > - [x] GHA (no failures during sysroot re-creation) Push approval is here. Testing is clean. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1661#issuecomment-1680196272 From shade at openjdk.org Wed Aug 16 08:42:22 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 08:42:22 GMT Subject: [jdk17u-dev] Integrated: 8294941: GHA: Cut down cross-compilation sysroots In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 08:41:50 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA footprint overheads. > > Additional testing: > - [x] GHA (no failures during sysroot re-creation) This pull request has now been integrated. Changeset: ba380adc Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/ba380adc85a52b278439051c57e0162bf604d13a Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8294941: GHA: Cut down cross-compilation sysroots Backport-of: a1747ef81a10e84177f474565193204ceaa0ede8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1661 From shade at openjdk.org Wed Aug 16 08:51:43 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 08:51:43 GMT Subject: [jdk17u-dev] RFR: 8314118: Update JMH devkit to 1.37 Message-ID: Clean backport to improve performance testing. ------------- Commit messages: - Backport 06aa3c5628e749188238dda3d41c776a5a2f7c81 Changes: https://git.openjdk.org/jdk17u-dev/pull/1666/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1666&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314118 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1666.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1666/head:pull/1666 PR: https://git.openjdk.org/jdk17u-dev/pull/1666 From mbaesken at openjdk.org Wed Aug 16 09:00:22 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 16 Aug 2023 09:00:22 GMT Subject: [jdk11u-dev] Integrated: 8271838: AmazonCA.java interop test fails In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 13:15:58 GMT, Matthias Baesken wrote: > 8271838: AmazonCA.java interop test fails This pull request has now been integrated. Changeset: e9ac2bc8 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/e9ac2bc80c5c0af78fcae6d46cb8df19b577bb28 Stats: 245 lines in 1 file changed: 0 ins; 51 del; 194 mod 8271838: AmazonCA.java interop test fails Backport-of: 512db0ff31a0a1a2bd8805964ba3d06e2cbfb9e9 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2078 From andrewlu at openjdk.org Wed Aug 16 09:22:25 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 16 Aug 2023 09:22:25 GMT Subject: [jdk11u-dev] Integrated: 8306133: Open source few AWT Drag & Drop related tests In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 07:53:29 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. This pull request has now been integrated. Changeset: de644926 Author: Andrew Lu Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/de644926827900ba77120fafebb6c6a2d6130360 Stats: 1062 lines in 5 files changed: 1062 ins; 0 del; 0 mod 8306133: Open source few AWT Drag & Drop related tests 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed Reviewed-by: phh Backport-of: ec5c7926f3cea68bf0d0ceb460a8383f5e4ea278 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2076 From mbaesken at openjdk.org Wed Aug 16 09:25:51 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 16 Aug 2023 09:25:51 GMT Subject: [jdk11u-dev] RFR: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails Message-ID: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails ------------- Commit messages: - Backport 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3 Changes: https://git.openjdk.org/jdk11u-dev/pull/2081/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2081&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309088 Stats: 491 lines in 1 file changed: 142 ins; 30 del; 319 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2081.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2081/head:pull/2081 PR: https://git.openjdk.org/jdk11u-dev/pull/2081 From lucy at openjdk.org Wed Aug 16 09:46:53 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 16 Aug 2023 09:46:53 GMT Subject: [jdk11u-dev] RFR: 8301269: Update Commons BCEL to Version 6.7.0 Message-ID: Fix request [11u] One of the required updates of external libs. I based the bckport to 11u on Goetz's backport to 17u, Low risk. Except for two copyright format issues (missing comma), I had to resolve just this one file: src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/Utility.java This file had undergone major restructuring. In the end, the resolve process resulted in a simple copy from 17 to 11. SAP nightly testing successful. No findings attributable to this backport. Reviews pending. ------------- Commit messages: - Backport 6a44120a16d0f06b4ed9f0ebf6b0919da7070287 Changes: https://git.openjdk.org/jdk11u-dev/pull/2082/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2082&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301269 Stats: 30508 lines in 334 files changed: 9314 ins; 10825 del; 10369 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2082.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2082/head:pull/2082 PR: https://git.openjdk.org/jdk11u-dev/pull/2082 From mdoerr at openjdk.org Wed Aug 16 10:12:21 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 16 Aug 2023 10:12:21 GMT Subject: [jdk11u-dev] RFR: 8301269: Update Commons BCEL to Version 6.7.0 In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 09:28:44 GMT, Lutz Schmidt wrote: > Fix request [11u] > > One of the required updates of external libs. > > I based the bckport to 11u on Goetz's backport to 17u, Low risk. > Except for two copyright format issues (missing comma), I had to resolve just this one file: src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/Utility.java > This file had undergone major restructuring. In the end, the resolve process resulted in a simple copy from 17 to 11. > > SAP nightly testing successful. No findings attributable to this backport. > Reviews pending. Ok, the diffs are because https://github.com/openjdk/jdk17u-dev/commit/d799563ac06d66acea6dbd9cb1fe78b253e8a0e7 was not backported before this one. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2082#pullrequestreview-1580258867 From lucy at openjdk.org Wed Aug 16 10:39:11 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 16 Aug 2023 10:39:11 GMT Subject: [jdk11u-dev] RFR: 8301269: Update Commons BCEL to Version 6.7.0 In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 10:09:48 GMT, Martin Doerr wrote: >> Fix request [11u] >> >> One of the required updates of external libs. >> >> I based the bckport to 11u on Goetz's backport to 17u, Low risk. >> Except for two copyright format issues (missing comma), I had to resolve just this one file: src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/Utility.java >> This file had undergone major restructuring. In the end, the resolve process resulted in a simple copy from 17 to 11. >> >> SAP nightly testing successful. No findings attributable to this backport. >> Reviews pending. > > Ok, the diffs exist because https://github.com/openjdk/jdk17u-dev/commit/d799563ac06d66acea6dbd9cb1fe78b253e8a0e7 was not backported before this one. ([JDK-8256919](https://bugs.openjdk.org/browse/JDK-8256919) is actually also fixed with this PR.) LGTM. Thank you for the review, @TheRealMDoerr I'll go ahead and request integrate authorization. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2082#issuecomment-1680364094 From shade at openjdk.org Wed Aug 16 10:41:18 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 10:41:18 GMT Subject: [jdk17u-dev] RFR: 8313402: C1: Incorrect LoadIndexed value numbering [v2] In-Reply-To: References: Message-ID: <6jcfTZ1LuPpC8z4rogMfJzxYGsk-6hwN9oPQrxxhg78=.d1df5fd4-53ae-4eb4-9e97-8ecfe1565eab@github.com> On Mon, 14 Aug 2023 08:41:30 GMT, Aleksey Shipilev wrote: >> Clean backport to fix the important C1 bug. >> >> Additional testing: >> - [x] New regression test fails without the patch, passes with it, when JDK-8313676 is applied >> - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 46fbedb2be98a9b8aba042fa9f90c3b25c312cd6 Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1636#issuecomment-1680364620 From shade at openjdk.org Wed Aug 16 10:41:21 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 10:41:21 GMT Subject: [jdk17u-dev] Integrated: 8313402: C1: Incorrect LoadIndexed value numbering In-Reply-To: References: Message-ID: On Thu, 3 Aug 2023 11:21:29 GMT, Aleksey Shipilev wrote: > Clean backport to fix the important C1 bug. > > Additional testing: > - [x] New regression test fails without the patch, passes with it, when JDK-8313676 is applied > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` This pull request has now been integrated. Changeset: 528e3b89 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/528e3b89263b7c99bfb72dc1c13e888714ea378b Stats: 59 lines in 2 files changed: 58 ins; 0 del; 1 mod 8313402: C1: Incorrect LoadIndexed value numbering Backport-of: 46fbedb2be98a9b8aba042fa9f90c3b25c312cd6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1636 From shade at openjdk.org Wed Aug 16 10:42:10 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 10:42:10 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v4] In-Reply-To: References: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> Message-ID: On Tue, 15 Aug 2023 05:49:13 GMT, Thomas Stuefe wrote: > Hold up , I'll ask my SAP collegues first to put this through their backport CI. I see `jdk17u-fix-yes` from Goetz set today. Have you heard about testing results? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1680368113 From lucy at openjdk.org Wed Aug 16 10:43:21 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 16 Aug 2023 10:43:21 GMT Subject: [jdk11u-dev] RFR: 8301269: Update Commons BCEL to Version 6.7.0 In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 09:28:44 GMT, Lutz Schmidt wrote: > Fix request [11u] > > One of the required updates of external libs. > > I based the bckport to 11u on Goetz's backport to 17u, Low risk. > Except for two copyright format issues (missing comma), I had to resolve just this one file: src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/Utility.java > This file had undergone major restructuring. In the end, the resolve process resulted in a simple copy from 17 to 11. > > SAP nightly testing successful. No findings attributable to this backport. > Review received. Failing pre-submit tests point to an infrastructure issue. Not related to this PR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2082#issuecomment-1680369211 From shade at openjdk.org Wed Aug 16 11:09:36 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 11:09:36 GMT Subject: [jdk21u] RFR: 8314262: GHA: Cut down cross-compilation sysroots deeper Message-ID: <2USI8EcZ7ARKog6arY4so-L9Q3KWRZAUS7ism2mYz2A=.0c4be611-8850-4e1e-8237-b5f013932cf7@github.com> Clean backport to improve GHA overheads. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 38687f1a3eb7d1c2e8aa43b85509ab7999fe0e40 Changes: https://git.openjdk.org/jdk21u/pull/61/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=61&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314262 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/61.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/61/head:pull/61 PR: https://git.openjdk.org/jdk21u/pull/61 From stuefe at openjdk.org Wed Aug 16 11:14:13 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 16 Aug 2023 11:14:13 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v4] In-Reply-To: References: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> Message-ID: <-B_WLoijXyJMOAbeoUh428qgR0tMiRR9eSPCxnS4IAg=.4918249d-982f-4ea7-afcd-de15214c205f@github.com> On Wed, 16 Aug 2023 10:39:30 GMT, Aleksey Shipilev wrote: > > Hold up , I'll ask my SAP collegues first to put this through their backport CI. > > I see `jdk17u-fix-yes` from Goetz set today. Have you heard about testing results? Martin reported some errors. I suspect he sees the known ones that had been fixed with 8312525, but I need to confirm. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1680409241 From shade at openjdk.org Wed Aug 16 11:18:18 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 11:18:18 GMT Subject: [jdk17u-dev] RFR: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly Message-ID: Clean backport to make the test sensitive to original regression. Additional testing: - [x] macos-aarch64-server-fastdebug; test passes out of box; starts to fail when JDK-8313402 is reverted (sensitivity check) ------------- Commit messages: - Backport 4b192a8dc37297f0746c0c68322e0168d9f47771 Changes: https://git.openjdk.org/jdk17u-dev/pull/1667/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1667&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313676 Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1667.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1667/head:pull/1667 PR: https://git.openjdk.org/jdk17u-dev/pull/1667 From shade at openjdk.org Wed Aug 16 11:26:39 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 11:26:39 GMT Subject: [jdk17u-dev] RFR: 8314262: GHA: Cut down cross-compilation sysroots deeper Message-ID: <1MCSCQaHdNGBg2fEdq57iaRARE7_HXgu8ms3fQOjBB0=.d36eadca-113f-4a17-a46c-fd362152ed8a@github.com> Clean backport to improve GHA overheads. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 38687f1a3eb7d1c2e8aa43b85509ab7999fe0e40 Changes: https://git.openjdk.org/jdk17u-dev/pull/1668/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1668&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314262 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1668.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1668/head:pull/1668 PR: https://git.openjdk.org/jdk17u-dev/pull/1668 From mbaesken at openjdk.org Wed Aug 16 11:34:14 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 16 Aug 2023 11:34:14 GMT Subject: [jdk11u-dev] RFR: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails In-Reply-To: References: Message-ID: <9ECgasKrQPg5gP9pbvXQ-Dt9HoIw0-sgBOexJkFb34E=.4f515657-2848-4d0a-b13a-399b0fca17d7@github.com> On Wed, 16 Aug 2023 09:13:15 GMT, Matthias Baesken wrote: > 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails The GHA failures seem to be infrastructure issues. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2081#issuecomment-1680431101 From mbaesken at openjdk.org Wed Aug 16 11:34:15 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 16 Aug 2023 11:34:15 GMT Subject: [jdk11u-dev] Integrated: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails In-Reply-To: References: Message-ID: <5jydmgCSFEtINpkhsYCcYRU3ymS0LJaYUxL7vmILS2Y=.e15b04f2-78fa-4931-8add-e5e423d7165f@github.com> On Wed, 16 Aug 2023 09:13:15 GMT, Matthias Baesken wrote: > 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails This pull request has now been integrated. Changeset: 95a42a88 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/95a42a8831fd16cec653abeb58a08dc458a4a1ff Stats: 491 lines in 1 file changed: 142 ins; 30 del; 319 mod 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails Backport-of: 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2081 From stuefe at openjdk.org Wed Aug 16 12:39:22 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 16 Aug 2023 12:39:22 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v4] In-Reply-To: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> References: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> Message-ID: On Mon, 14 Aug 2023 08:50:30 GMT, Aleksey Shipilev wrote: >> Unclean backport to get useful experimental feature to LTS users. >> >> In addition to usual contextual differences, there is a number of differences against upstream version: >> - `synchronizer.cpp` hunks are different, since we do not have [JDK-8256302](https://github.com/openjdk/jdk/commit/6402004852ccc993bb6e879c49fb71e2afdcdfbe) in JDK 17 >> - `NativeHeapTrimmer_lock` changed from `Mutex::safepoint` to `Mutex::leaf`, since [JDK-8273915](https://github.com/openjdk/jdk/commit/111d5e1a9324cb5e8d98627f6329d17fcbc9c13d) renamed it after JDK 17 >> - `NativeHeapTrimmer_lock` should also allow VMThread block and never require safepoint checks; this was simplified by [JDK-8274004](https://bugs.openjdk.org/browse/JDK-8274004) later >> - `vmError.cpp` code was rewritten in JDK 17 style >> - gtest uses `EXPECT_NOT_NULL`, only brought by [JDK-8295865](https://github.com/openjdk/jdk/commit/657a0b2f1564e1754dbd64b776c53a52c480c901#diff-35b3b4703decd15bfd2fc614d431e909727a6cf4d399cf05c7a12466e61ab8a0R58-R59) -- I rewrote them to EXPECT_NE/EQ. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug, trim tests >> - [x] Linux x86_64 fastdebug, `tier1` >> - [x] Linux x86_64 fastdebug, `tier2` >> - [x] Linux x86_64 fastdebug, `tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into JDK-8293114-trim-native > - More adjustments > - Adjustments > - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 Okay, we see still problems in head at SAP. https://bugs.openjdk.org/browse/JDK-8314426. Lets wait with the downport till that one is fixed. Should be quick, hopefully. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1680524807 From mdoerr at openjdk.org Wed Aug 16 12:54:20 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 16 Aug 2023 12:54:20 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v4] In-Reply-To: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> References: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> Message-ID: <705_53TJgEJ6bP611_ONv-a7-dQoy2o4kl89LiWqiJ8=.5dda2860-cee0-4335-8f4d-1475c4ae06ad@github.com> On Mon, 14 Aug 2023 08:50:30 GMT, Aleksey Shipilev wrote: >> Unclean backport to get useful experimental feature to LTS users. >> >> In addition to usual contextual differences, there is a number of differences against upstream version: >> - `synchronizer.cpp` hunks are different, since we do not have [JDK-8256302](https://github.com/openjdk/jdk/commit/6402004852ccc993bb6e879c49fb71e2afdcdfbe) in JDK 17 >> - `NativeHeapTrimmer_lock` changed from `Mutex::safepoint` to `Mutex::leaf`, since [JDK-8273915](https://github.com/openjdk/jdk/commit/111d5e1a9324cb5e8d98627f6329d17fcbc9c13d) renamed it after JDK 17 >> - `NativeHeapTrimmer_lock` should also allow VMThread block and never require safepoint checks; this was simplified by [JDK-8274004](https://bugs.openjdk.org/browse/JDK-8274004) later >> - `vmError.cpp` code was rewritten in JDK 17 style >> - gtest uses `EXPECT_NOT_NULL`, only brought by [JDK-8295865](https://github.com/openjdk/jdk/commit/657a0b2f1564e1754dbd64b776c53a52c480c901#diff-35b3b4703decd15bfd2fc614d431e909727a6cf4d399cf05c7a12466e61ab8a0R58-R59) -- I rewrote them to EXPECT_NE/EQ. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug, trim tests >> - [x] Linux x86_64 fastdebug, `tier1` >> - [x] Linux x86_64 fastdebug, `tier2` >> - [x] Linux x86_64 fastdebug, `tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into JDK-8293114-trim-native > - More adjustments > - Adjustments > - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 The backport looks good, but the test has issues in head as well. Thanks, Thomas, for investigating! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1680547301 From shade at openjdk.org Wed Aug 16 12:58:12 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 12:58:12 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v4] In-Reply-To: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> References: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> Message-ID: On Mon, 14 Aug 2023 08:50:30 GMT, Aleksey Shipilev wrote: >> Unclean backport to get useful experimental feature to LTS users. >> >> In addition to usual contextual differences, there is a number of differences against upstream version: >> - `synchronizer.cpp` hunks are different, since we do not have [JDK-8256302](https://github.com/openjdk/jdk/commit/6402004852ccc993bb6e879c49fb71e2afdcdfbe) in JDK 17 >> - `NativeHeapTrimmer_lock` changed from `Mutex::safepoint` to `Mutex::leaf`, since [JDK-8273915](https://github.com/openjdk/jdk/commit/111d5e1a9324cb5e8d98627f6329d17fcbc9c13d) renamed it after JDK 17 >> - `NativeHeapTrimmer_lock` should also allow VMThread block and never require safepoint checks; this was simplified by [JDK-8274004](https://bugs.openjdk.org/browse/JDK-8274004) later >> - `vmError.cpp` code was rewritten in JDK 17 style >> - gtest uses `EXPECT_NOT_NULL`, only brought by [JDK-8295865](https://github.com/openjdk/jdk/commit/657a0b2f1564e1754dbd64b776c53a52c480c901#diff-35b3b4703decd15bfd2fc614d431e909727a6cf4d399cf05c7a12466e61ab8a0R58-R59) -- I rewrote them to EXPECT_NE/EQ. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug, trim tests >> - [x] Linux x86_64 fastdebug, `tier1` >> - [x] Linux x86_64 fastdebug, `tier2` >> - [x] Linux x86_64 fastdebug, `tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into JDK-8293114-trim-native > - More adjustments > - Adjustments > - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 No problem, we can wait for that test to be fixed, and the backport for it lined up for 17u-dev, before we proceed with this integration. Then we would not break anyone's CI, hopefully. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1680553795 From robm at openjdk.org Wed Aug 16 13:03:39 2023 From: robm at openjdk.org (Rob McKenna) Date: Wed, 16 Aug 2023 13:03:39 GMT Subject: [jdk21u] RFR: Merge jdk21:master Message-ID: merge jdk21 master to jdk21u ------------- Commit messages: - Merge - 8314062: ProblemList jdk/jfr/tool/TestView.java on macosx-x64 - 8311179: Generational ZGC: gc/z/TestSmallHeap.java failed with OutOfMemoryError - 8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16 - 8312814: Compiler crash when template processor type is a captured wildcard - 8313345: SuperWord fails due to CMove without matching Bool pack The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk21u&pr=62&range=00.0 - jdk21:master: https://webrevs.openjdk.org/?repo=jdk21u&pr=62&range=00.1 Changes: https://git.openjdk.org/jdk21u/pull/62/files Stats: 170 lines in 8 files changed: 165 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk21u/pull/62.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/62/head:pull/62 PR: https://git.openjdk.org/jdk21u/pull/62 From shade at openjdk.org Wed Aug 16 13:05:29 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 13:05:29 GMT Subject: [jdk21u] RFR: 8314020: Print instruction blocks in byte units Message-ID: Clean backport to improve post-mortem diagnostics. ------------- Commit messages: - Backport a602624ef46908456052146d50467c60efa636c3 Changes: https://git.openjdk.org/jdk21u/pull/63/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=63&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314020 Stats: 12 lines in 12 files changed: 0 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk21u/pull/63.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/63/head:pull/63 PR: https://git.openjdk.org/jdk21u/pull/63 From robm at openjdk.org Wed Aug 16 13:16:15 2023 From: robm at openjdk.org (Rob McKenna) Date: Wed, 16 Aug 2023 13:16:15 GMT Subject: [jdk21u] Integrated: Merge jdk21:master In-Reply-To: References: Message-ID: <7NiTXEF8l38KMthUkhPx2xK7paN6tyXC7t4wZAZ6-Tc=.4542c795-144e-4355-a31c-93d25b70184b@github.com> On Wed, 16 Aug 2023 12:56:09 GMT, Rob McKenna wrote: > merge jdk21 master to jdk21u This pull request has now been integrated. Changeset: 9c24db16 Author: Rob McKenna URL: https://git.openjdk.org/jdk21u/commit/9c24db165bb2019ddf220ae4fa06b272ab5c5db4 Stats: 170 lines in 8 files changed: 165 ins; 2 del; 3 mod Merge ------------- PR: https://git.openjdk.org/jdk21u/pull/62 From shade at openjdk.org Wed Aug 16 13:33:37 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 16 Aug 2023 13:33:37 GMT Subject: [jdk17u-dev] RFR: 8284273: Early crashes in os::print_context on AArch64 Message-ID: <6lUr3kX1tFsBaHBbSAh8peb9QYIxrkDZgqmYt5M2zrg=.918ed60f-6991-4256-a593-899c1dfa5b71@github.com> Clean backport to improve the resilience of crash reporting, and provide the grounds for other relevant backports in this area. Additional testing: - [x] macos AArch64 fastdebug, `runtime/ErrorHandling` - [ ] Linux AArch64 fastdebug, `tier1 tier2 tier3` ------------- Commit messages: - Backport 83cec4b6cc25b9b0db751bbe873444259cdcb21c Changes: https://git.openjdk.org/jdk17u-dev/pull/1669/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1669&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284273 Stats: 124 lines in 15 files changed: 95 ins; 11 del; 18 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1669.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1669/head:pull/1669 PR: https://git.openjdk.org/jdk17u-dev/pull/1669 From stuefe at openjdk.org Wed Aug 16 14:18:20 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 16 Aug 2023 14:18:20 GMT Subject: [jdk17u-dev] RFR: 8284273: Early crashes in os::print_context on AArch64 In-Reply-To: <6lUr3kX1tFsBaHBbSAh8peb9QYIxrkDZgqmYt5M2zrg=.918ed60f-6991-4256-a593-899c1dfa5b71@github.com> References: <6lUr3kX1tFsBaHBbSAh8peb9QYIxrkDZgqmYt5M2zrg=.918ed60f-6991-4256-a593-899c1dfa5b71@github.com> Message-ID: <7W7w0cl3LMNNsuqubJP1Yw0g7Ef6XdSOq2lRF_M0Kj0=.f1928745-b858-42ff-8403-efd19b5d027c@github.com> On Wed, 16 Aug 2023 13:26:39 GMT, Aleksey Shipilev wrote: > Clean backport to improve the resilience of crash reporting, and provide the grounds for other relevant backports in this area. > > Additional testing: > - [x] macos AArch64 fastdebug, `runtime/ErrorHandling` > - [ ] Linux AArch64 fastdebug, `tier1 tier2 tier3` +1 ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1669#pullrequestreview-1580738653 From duke at openjdk.org Wed Aug 16 14:44:36 2023 From: duke at openjdk.org (Weibing Xiao) Date: Wed, 16 Aug 2023 14:44:36 GMT Subject: [jdk21u] RFR: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors Message-ID: Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. ------------- Commit messages: - Backport e56d3bc2dab3d32453b6eda66e8434953c436084 Changes: https://git.openjdk.org/jdk21u/pull/64/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=64&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313657 Stats: 214 lines in 2 files changed: 205 ins; 2 del; 7 mod Patch: https://git.openjdk.org/jdk21u/pull/64.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/64/head:pull/64 PR: https://git.openjdk.org/jdk21u/pull/64 From duke at openjdk.org Wed Aug 16 15:31:13 2023 From: duke at openjdk.org (Weibing Xiao) Date: Wed, 16 Aug 2023 15:31:13 GMT Subject: [jdk21u] Integrated: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 14:37:46 GMT, Weibing Xiao wrote: > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. This pull request has now been integrated. Changeset: d37d019b Author: Weibing Xiao Committer: Rob McKenna URL: https://git.openjdk.org/jdk21u/commit/d37d019be233ee642d5855d171a881c630c41556 Stats: 214 lines in 2 files changed: 205 ins; 2 del; 7 mod 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors Backport-of: e56d3bc2dab3d32453b6eda66e8434953c436084 ------------- PR: https://git.openjdk.org/jdk21u/pull/64 From stuefe at openjdk.org Wed Aug 16 16:15:18 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 16 Aug 2023 16:15:18 GMT Subject: [jdk17u-dev] RFR: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer In-Reply-To: <4TvXNgthFyHG2Wt9xecwHFlCFlFFAxzCataV3Oz16os=.f9cfea17-b5a4-4836-96a0-195ceadb0221@github.com> References: <4TvXNgthFyHG2Wt9xecwHFlCFlFFAxzCataV3Oz16os=.f9cfea17-b5a4-4836-96a0-195ceadb0221@github.com> Message-ID: <-xpssbL1Hv-3iobbn9hPtxEW2hWa7LQXBUHUG53p9XM=.714e7034-1e70-4259-b45d-2e30db6b0c94@github.com> On Tue, 15 Aug 2023 21:49:16 GMT, Ben Taylor wrote: > Backort [8313796](https://bugs.openjdk.org/browse/JDK-8313796) to resolve a hotspot crash. Backport is clean and passes jtreg tier 1-4 tests. Looks good. ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1665#pullrequestreview-1580983323 From btaylor at openjdk.org Wed Aug 16 16:49:24 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 16 Aug 2023 16:49:24 GMT Subject: [jdk11u-dev] RFR: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer [v2] In-Reply-To: References: Message-ID: <3yiyQjVtrGr_uDBHgLbvw0TtfwW22XKjx6dQuPcR4VY=.0bb622f4-8953-4008-b88c-179e526430b8@github.com> > Backport [8313796](https://bugs.openjdk.org/browse/JDK-8313796) to resolve a hotspot crash. Passes jtreg tier 1-4 tests. > > This change required the following modifications: > - Remove riscv code, as the riscv port is not present in jdk 11 > - Replace `nullptr` with `NULL` to accommodate older C++ standards/compilers Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Reviewed-by: coleenp, aph, stuefe ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2079/files - new: https://git.openjdk.org/jdk11u-dev/pull/2079/files/98163382..ae012a4e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2079&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2079&range=00-01 Stats: 1569 lines in 6 files changed: 1169 ins; 46 del; 354 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2079.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2079/head:pull/2079 PR: https://git.openjdk.org/jdk11u-dev/pull/2079 From cjplummer at openjdk.org Wed Aug 16 17:06:21 2023 From: cjplummer at openjdk.org (Chris Plummer) Date: Wed, 16 Aug 2023 17:06:21 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v4] In-Reply-To: References: Message-ID: <-VikbXADivSviDj1i0JJzHUb2OUySIHiaCfFfOBzl3w=.c87a4004-850d-47c8-ba45-78d07b227c50@github.com> On Tue, 15 Aug 2023 07:05:08 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into 8313815 > - Merge master > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Marked as reviewed by cjplummer (Committer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1641#pullrequestreview-1581071802 From btaylor at openjdk.org Wed Aug 16 18:19:22 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 16 Aug 2023 18:19:22 GMT Subject: [jdk17u-dev] Integrated: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer In-Reply-To: <4TvXNgthFyHG2Wt9xecwHFlCFlFFAxzCataV3Oz16os=.f9cfea17-b5a4-4836-96a0-195ceadb0221@github.com> References: <4TvXNgthFyHG2Wt9xecwHFlCFlFFAxzCataV3Oz16os=.f9cfea17-b5a4-4836-96a0-195ceadb0221@github.com> Message-ID: On Tue, 15 Aug 2023 21:49:16 GMT, Ben Taylor wrote: > Backort [8313796](https://bugs.openjdk.org/browse/JDK-8313796) to resolve a hotspot crash. Backport is clean and passes jtreg tier 1-4 tests. This pull request has now been integrated. Changeset: 4084a818 Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/4084a8181337999b87cf89950f2401b1b78204dc Stats: 16 lines in 7 files changed: 11 ins; 0 del; 5 mod 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Reviewed-by: stuefe Backport-of: 0e2c72d7a5206b7173af5bf69e21d21ea276bd94 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1665 From mchung at openjdk.org Wed Aug 16 18:26:47 2023 From: mchung at openjdk.org (Mandy Chung) Date: Wed, 16 Aug 2023 18:26:47 GMT Subject: [jdk21u] RFR: 8240567: MethodTooLargeException thrown while creating a jlink image Message-ID: Manually resolved the merge conflict due to JDK-8310848 which is not in jdk21u. Trivial 1-line change: diff --git a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java index 1ec5f750f4c..563371b05a1 100644 --- a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java +++ b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java @@ -685,7 +685,7 @@ public final class SystemModulesPlugin extends AbstractPlugin { if (moduleInfos.size() <= moduleDescriptorsPerMethod) { clb.withMethodBody( "moduleDescriptors", - MTD_ModuleDescriptorArray, + MethodTypeDesc.of(CD_MODULE_DESCRIPTOR.arrayType()), ACC_PUBLIC, cob -> { cob.constantInstruction(moduleInfos.size()) ------------- Commit messages: - Backport ec7da91bd83803b7d91a4de3a01caf0ba256c037 Changes: https://git.openjdk.org/jdk21u/pull/65/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=65&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8240567 Stats: 288 lines in 3 files changed: 269 ins; 1 del; 18 mod Patch: https://git.openjdk.org/jdk21u/pull/65.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/65/head:pull/65 PR: https://git.openjdk.org/jdk21u/pull/65 From mchung at openjdk.org Wed Aug 16 18:33:41 2023 From: mchung at openjdk.org (Mandy Chung) Date: Wed, 16 Aug 2023 18:33:41 GMT Subject: [jdk21u] RFR: 8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder Message-ID: Hi all, This pull request contains a backport of commit [bc8e9f44](https://github.com/openjdk/jdk/commit/bc8e9f44a39ff59b59b2d1d5d546a148be75a2f2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Christoph Schwentker on 15 Aug 2023 and was reviewed by Mandy Chung. This is an additional test added for https://github.com/openjdk/jdk21u/pull/65. Thanks! ------------- Commit messages: - Backport bc8e9f44a39ff59b59b2d1d5d546a148be75a2f2 Changes: https://git.openjdk.org/jdk21u/pull/66/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=66&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311591 Stats: 357 lines in 9 files changed: 351 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk21u/pull/66.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/66/head:pull/66 PR: https://git.openjdk.org/jdk21u/pull/66 From btaylor at openjdk.org Wed Aug 16 19:17:21 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 16 Aug 2023 19:17:21 GMT Subject: [jdk11u-dev] RFR: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer [v2] In-Reply-To: <3yiyQjVtrGr_uDBHgLbvw0TtfwW22XKjx6dQuPcR4VY=.0bb622f4-8953-4008-b88c-179e526430b8@github.com> References: <3yiyQjVtrGr_uDBHgLbvw0TtfwW22XKjx6dQuPcR4VY=.0bb622f4-8953-4008-b88c-179e526430b8@github.com> Message-ID: On Wed, 16 Aug 2023 16:49:24 GMT, Ben Taylor wrote: >> Backport [8313796](https://bugs.openjdk.org/browse/JDK-8313796) to resolve a hotspot crash. Passes jtreg tier 1-4 tests. >> >> This change required the following modifications: >> - Remove riscv code, as the riscv port is not present in jdk 11 >> - Replace `nullptr` with `NULL` to accommodate older C++ standards/compilers > > Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer > > Reviewed-by: coleenp, aph, stuefe Linux failures look like an infra issue - e.g. [here](https://github.com/benty-amzn/jdk11u-dev/actions/runs/5881525324/job/15950185174#step:6:75). Other platforms are clean, and I've tested linux locally. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2079#issuecomment-1681144131 From phh at openjdk.org Wed Aug 16 20:53:52 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 16 Aug 2023 20:53:52 GMT Subject: [jdk21u] RFR: 8240567: MethodTooLargeException thrown while creating a jlink image In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 18:19:12 GMT, Mandy Chung wrote: > Manually resolved the merge conflict due to JDK-8310848 which is not in jdk21u. Trivial 1-line change: > > > diff --git a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > index 1ec5f750f4c..563371b05a1 100644 > --- a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > +++ b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > @@ -685,7 +685,7 @@ public final class SystemModulesPlugin extends AbstractPlugin { > if (moduleInfos.size() <= moduleDescriptorsPerMethod) { > clb.withMethodBody( > "moduleDescriptors", > - MTD_ModuleDescriptorArray, > + MethodTypeDesc.of(CD_MODULE_DESCRIPTOR.arrayType()), > ACC_PUBLIC, > cob -> { > cob.constantInstruction(moduleInfos.size()) Are the definitions of MTD_StringArray and MTD_SystemModules in SystemModulesPlugin.java needed? They're not in the original commit and aren't referenced by the patch. ------------- PR Review: https://git.openjdk.org/jdk21u/pull/65#pullrequestreview-1581391924 From bylokhov at amazon.com Wed Aug 16 21:15:58 2023 From: bylokhov at amazon.com (Sergey Bylokhov) Date: Wed, 16 Aug 2023 14:15:58 -0700 Subject: Respin of July CPU due to the JDK-8313765 Message-ID: <4741fe9e-2499-416b-b40e-eae4b771a57e@amazon.com> Hello, OpenJDK maintainers. I would like to gather you opinions about respins of JDK11, JDK17 and JDK20 due to the bug fixed by the JDK-8313765[1]. We consider that bug as a serious regression and would like to release a patch. But before doing that we would like to confirm will the OpenJDK plan to do a respin(and when) or not, and if yes then what version/build/update will be used. [1] JBS https://bugs.openjdk.org/browse/JDK-8313765 [2] PR https://github.com/openjdk/jdk/pull/15273 -- Best regards, Sergey. From mchung at openjdk.org Wed Aug 16 21:21:22 2023 From: mchung at openjdk.org (Mandy Chung) Date: Wed, 16 Aug 2023 21:21:22 GMT Subject: [jdk21u] RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v2] In-Reply-To: References: Message-ID: > Manually resolved the merge conflict due to JDK-8310848 which is not in jdk21u. Trivial 1-line change: > > > diff --git a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > index 1ec5f750f4c..563371b05a1 100644 > --- a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > +++ b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > @@ -685,7 +685,7 @@ public final class SystemModulesPlugin extends AbstractPlugin { > if (moduleInfos.size() <= moduleDescriptorsPerMethod) { > clb.withMethodBody( > "moduleDescriptors", > - MTD_ModuleDescriptorArray, > + MethodTypeDesc.of(CD_MODULE_DESCRIPTOR.arrayType()), > ACC_PUBLIC, > cob -> { > cob.constantInstruction(moduleInfos.size()) Mandy Chung has updated the pull request incrementally with one additional commit since the last revision: Remove unused imports. Review feedback ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/65/files - new: https://git.openjdk.org/jdk21u/pull/65/files/cf933f1d..cb527294 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=65&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=65&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/65.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/65/head:pull/65 PR: https://git.openjdk.org/jdk21u/pull/65 From mchung at openjdk.org Wed Aug 16 21:21:23 2023 From: mchung at openjdk.org (Mandy Chung) Date: Wed, 16 Aug 2023 21:21:23 GMT Subject: [jdk21u] RFR: 8240567: MethodTooLargeException thrown while creating a jlink image In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 18:19:12 GMT, Mandy Chung wrote: > Manually resolved the merge conflict due to JDK-8310848 which is not in jdk21u. Trivial 1-line change: > > > diff --git a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > index 1ec5f750f4c..563371b05a1 100644 > --- a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > +++ b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > @@ -685,7 +685,7 @@ public final class SystemModulesPlugin extends AbstractPlugin { > if (moduleInfos.size() <= moduleDescriptorsPerMethod) { > clb.withMethodBody( > "moduleDescriptors", > - MTD_ModuleDescriptorArray, > + MethodTypeDesc.of(CD_MODULE_DESCRIPTOR.arrayType()), > ACC_PUBLIC, > cob -> { > cob.constantInstruction(moduleInfos.size()) Thanks for catching this. It's improper merge. Now removed. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/65#issuecomment-1681282129 From phh at openjdk.org Wed Aug 16 22:01:30 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 16 Aug 2023 22:01:30 GMT Subject: [jdk17u-dev] RFR: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level In-Reply-To: References: Message-ID: <7ED6fDJVO3q_Wgl7ZqSudxe43OPNbZsjxhzwLIfasog=.2f45d0d0-3306-4b18-bb8a-ec9c07a7cd3c@github.com> On Mon, 14 Aug 2023 10:49:42 GMT, Aleksey Shipilev wrote: > Unclean backport to fix TCP_QUICKACK bug. > > The backport is unclean, because AIX hunks could not be applied. The implementation of extended socket options on AIX went into JDK 21 with [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089). > > Additional testing: > - [x] Linux AArch64 fastdebug, `jdk_net` > - [x] Linux AArch64 fastdebug, `tier1 tier2 tier3` Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1664#pullrequestreview-1581489938 From phh at openjdk.org Wed Aug 16 22:06:39 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 16 Aug 2023 22:06:39 GMT Subject: [jdk11u-dev] RFR: 8302161: Upgrade jQuery UI to version 1.13.2 In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 05:21:05 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8302161 for jdk11u. > This is clean backport. > Also, this backport contains JDK-8293180. > > All jdk/javadoc tests are passed. Backport from 17u appears clean. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2064#pullrequestreview-1581498050 From phh at openjdk.org Wed Aug 16 22:09:26 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 16 Aug 2023 22:09:26 GMT Subject: [jdk21u] RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v2] In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 21:21:22 GMT, Mandy Chung wrote: >> Manually resolved the merge conflict due to JDK-8310848 which is not in jdk21u. Trivial 1-line change: >> >> >> diff --git a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java >> index 1ec5f750f4c..563371b05a1 100644 >> --- a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java >> +++ b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java >> @@ -685,7 +685,7 @@ public final class SystemModulesPlugin extends AbstractPlugin { >> if (moduleInfos.size() <= moduleDescriptorsPerMethod) { >> clb.withMethodBody( >> "moduleDescriptors", >> - MTD_ModuleDescriptorArray, >> + MethodTypeDesc.of(CD_MODULE_DESCRIPTOR.arrayType()), >> ACC_PUBLIC, >> cob -> { >> cob.constantInstruction(moduleInfos.size()) > > Mandy Chung has updated the pull request incrementally with one additional commit since the last revision: > > Remove unused imports. Review feedback Thanks for fixing, looks good. Also, please enable pre-submit testing on your repo and run it. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk21u/pull/65#pullrequestreview-1581500367 PR Comment: https://git.openjdk.org/jdk21u/pull/65#issuecomment-1681330782 From mchung at openjdk.org Wed Aug 16 23:21:17 2023 From: mchung at openjdk.org (Mandy Chung) Date: Wed, 16 Aug 2023 23:21:17 GMT Subject: [jdk21u] RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v3] In-Reply-To: References: Message-ID: > Manually resolved the merge conflict due to JDK-8310848 which is not in jdk21u. Trivial 1-line change: > > > diff --git a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > index 1ec5f750f4c..563371b05a1 100644 > --- a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > +++ b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > @@ -685,7 +685,7 @@ public final class SystemModulesPlugin extends AbstractPlugin { > if (moduleInfos.size() <= moduleDescriptorsPerMethod) { > clb.withMethodBody( > "moduleDescriptors", > - MTD_ModuleDescriptorArray, > + MethodTypeDesc.of(CD_MODULE_DESCRIPTOR.arrayType()), > ACC_PUBLIC, > cob -> { > cob.constantInstruction(moduleInfos.size()) Mandy Chung has updated the pull request incrementally with one additional commit since the last revision: trigger pre-submit runs ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/65/files - new: https://git.openjdk.org/jdk21u/pull/65/files/cb527294..67101b29 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=65&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=65&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/65.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/65/head:pull/65 PR: https://git.openjdk.org/jdk21u/pull/65 From almatvee at openjdk.org Thu Aug 17 00:17:50 2023 From: almatvee at openjdk.org (Alexander Matveev) Date: Thu, 17 Aug 2023 00:17:50 GMT Subject: [jdk21u] RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing Message-ID: <4VNFyMbckiN8i1VPvey0rXvmy3IJV33RtSA-guGfAY4=.34adf858-2f30-4db9-a85d-23685b6eb8f9@github.com> Clean backport of JDK-8313904. ------------- Commit messages: - Backport ec0cc6300a02dd92b25d9072b8b3859dab583bbd Changes: https://git.openjdk.org/jdk21u/pull/67/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=67&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313904 Stats: 94 lines in 8 files changed: 58 ins; 0 del; 36 mod Patch: https://git.openjdk.org/jdk21u/pull/67.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/67/head:pull/67 PR: https://git.openjdk.org/jdk21u/pull/67 From btaylor at openjdk.org Thu Aug 17 02:24:12 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 02:24:12 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) Message-ID: Backport is not clean, required changes: - Some context lines - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 All tests in `test/jdk/java/util/zip` pass ------------- Commit messages: - 8313765: Invalid CEN header (invalid zip64 extra data field size) Changes: https://git.openjdk.org/jdk17u-dev/pull/1670/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1670&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313765 Stats: 995 lines in 4 files changed: 982 ins; 1 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1670.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1670/head:pull/1670 PR: https://git.openjdk.org/jdk17u-dev/pull/1670 From andrewlu at openjdk.org Thu Aug 17 02:24:49 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 17 Aug 2023 02:24:49 GMT Subject: [jdk11u-dev] RFR: 8307078: Opensource and clean up five more AWT Focus related tests Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport 6d6f726b74f7fcd3e7c37d50bd2476b3e921662b Changes: https://git.openjdk.org/jdk11u-dev/pull/2083/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2083&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307078 Stats: 965 lines in 5 files changed: 965 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2083.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2083/head:pull/2083 PR: https://git.openjdk.org/jdk11u-dev/pull/2083 From btaylor at openjdk.org Thu Aug 17 02:25:00 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 02:25:00 GMT Subject: [jdk20u] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) Message-ID: <8kUgRlkY6Y4-R7k7ZbCIYy0AU4vUw9NKuAHeKAWkpuk=.34fda669-edc2-408e-b9cb-a6578ad5073f@github.com> Backport is not clean, required changes: - Some context lines - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 All tests in `test/jdk/java/util/zip` pass ------------- Commit messages: - 8313765: Invalid CEN header (invalid zip64 extra data field size) Changes: https://git.openjdk.org/jdk20u/pull/87/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=87&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313765 Stats: 995 lines in 4 files changed: 982 ins; 1 del; 12 mod Patch: https://git.openjdk.org/jdk20u/pull/87.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/87/head:pull/87 PR: https://git.openjdk.org/jdk20u/pull/87 From btaylor at openjdk.org Thu Aug 17 02:25:00 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 02:25:00 GMT Subject: [jdk20u] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: <8kUgRlkY6Y4-R7k7ZbCIYy0AU4vUw9NKuAHeKAWkpuk=.34fda669-edc2-408e-b9cb-a6578ad5073f@github.com> References: <8kUgRlkY6Y4-R7k7ZbCIYy0AU4vUw9NKuAHeKAWkpuk=.34fda669-edc2-408e-b9cb-a6578ad5073f@github.com> Message-ID: On Thu, 17 Aug 2023 02:16:29 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass Failing linux GHA looks like infra issues - https://github.com/benty-amzn/jdk20u/actions/runs/5885853677/job/15962891969#step:7:179 ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/87#issuecomment-1681511858 From btaylor at openjdk.org Thu Aug 17 02:25:12 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 02:25:12 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) Message-ID: Backport is not clean, required changes: - Some context lines - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 All tests in `test/jdk/java/util/zip` pass ------------- Commit messages: - 8313765: Invalid CEN header (invalid zip64 extra data field size) Changes: https://git.openjdk.org/jdk11u-dev/pull/2084/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2084&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313765 Stats: 997 lines in 4 files changed: 983 ins; 1 del; 13 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2084.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2084/head:pull/2084 PR: https://git.openjdk.org/jdk11u-dev/pull/2084 From btaylor at openjdk.org Thu Aug 17 02:25:12 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 02:25:12 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:16:27 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 > > All tests in `test/jdk/java/util/zip` pass Failing linux GHA looks like infra issues - https://github.com/benty-amzn/jdk11u-dev/actions/runs/5885841578/job/15962854580#step:6:76 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1681512148 From btaylor at openjdk.org Thu Aug 17 03:00:36 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 03:00:36 GMT Subject: [jdk20u] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: <8kUgRlkY6Y4-R7k7ZbCIYy0AU4vUw9NKuAHeKAWkpuk=.34fda669-edc2-408e-b9cb-a6578ad5073f@github.com> References: <8kUgRlkY6Y4-R7k7ZbCIYy0AU4vUw9NKuAHeKAWkpuk=.34fda669-edc2-408e-b9cb-a6578ad5073f@github.com> Message-ID: On Thu, 17 Aug 2023 02:16:29 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass Windows failures also look like infra issues - https://github.com/benty-amzn/jdk20u/actions/runs/5885853677/job/15962892691#step:5:853 ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/87#issuecomment-1681535728 From volker.simonis at gmail.com Thu Aug 17 05:33:00 2023 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 16 Aug 2023 22:33:00 -0700 Subject: Downporting JDK-8313765 to jdk11u and jdk17u and respinning 11.0.20 and 17.0.8 Message-ID: Hi, We would like to downport JDK-8313765 [1] to jdk11u-dev and jdk17u-dev and propose to release new versions of 11.0.20 and 17.0.8. JDK-8313765 [1] is a fix for a regression in the processing of zip files containing extended ZIP64 entries that was introduced by JDK-8302483 in the July security update. This regression affects a significant number of our internal as well as external customers (you can find more details in the JBS issue [1] and the original PR [2]). We think that the blast radius of the regression justifies a re-spin of 11.0.20 and 17.0.8 and we are planning to do this for Amazon Corretto. We would however appreciate if we could agree on this downport among all maintainers and come up with a synchronized up-stream fix and versioning. We've published corresponding PRs for jdk11u-dev [3] and jdk17u-dev [4]. Best regards, Volker [1] https://bugs.openjdk.org/browse/JDK-8313765 [2] https://github.com/openjdk/jdk/pull/15273 [3] https://github.com/openjdk/jdk11u-dev/pull/2084 [4] https://github.com/openjdk/jdk17u-dev/pull/1670 -------------- next part -------------- An HTML attachment was scrubbed... URL: From tschatzl at openjdk.org Thu Aug 17 07:36:46 2023 From: tschatzl at openjdk.org (Thomas Schatzl) Date: Thu, 17 Aug 2023 07:36:46 GMT Subject: [jdk21u] RFR: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp Message-ID: Hi all, This pull request contains a backport of commit [19255084](https://github.com/openjdk/jdk/commit/1925508425cf1b2d46173754077a588290253430) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Thomas Schatzl on 16 Aug 2023 and was reviewed by Albert Mingkun Yang and Ivan Walulya. Thanks! ------------- Commit messages: - Backport 1925508425cf1b2d46173754077a588290253430 Changes: https://git.openjdk.org/jdk21u/pull/68/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=68&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314144 Stats: 3 lines in 2 files changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/68.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/68/head:pull/68 PR: https://git.openjdk.org/jdk21u/pull/68 From abimpoudis at openjdk.org Thu Aug 17 08:01:03 2023 From: abimpoudis at openjdk.org (Aggelos Biboudis) Date: Thu, 17 Aug 2023 08:01:03 GMT Subject: [jdk21u] RFR: 8314423: Multiple patterns without unnamed variables Message-ID: 8314423: Multiple patterns without unnamed variables ------------- Commit messages: - Backport 43311930107d1783b742adbe567e9bdbcb55775d Changes: https://git.openjdk.org/jdk21u/pull/69/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=69&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314423 Stats: 63 lines in 6 files changed: 63 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/69.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/69/head:pull/69 PR: https://git.openjdk.org/jdk21u/pull/69 From andrewlu at openjdk.org Thu Aug 17 08:58:30 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 17 Aug 2023 08:58:30 GMT Subject: [jdk11u-dev] RFR: 8306718: Optimize and opensource some old AWT tests Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport 9beae21864d18054ca3762ec989d51ff0660db84 Changes: https://git.openjdk.org/jdk11u-dev/pull/2085/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2085&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306718 Stats: 410 lines in 4 files changed: 410 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2085.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2085/head:pull/2085 PR: https://git.openjdk.org/jdk11u-dev/pull/2085 From sgehwolf at redhat.com Thu Aug 17 09:34:25 2023 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 17 Aug 2023 11:34:25 +0200 Subject: Downporting JDK-8313765 to jdk11u and jdk17u and respinning 11.0.20 and 17.0.8 In-Reply-To: References: Message-ID: Hi, On Wed, 2023-08-16 at 22:33 -0700, Volker Simonis wrote: > Hi, > > We would like to downport JDK-8313765 [1] to jdk11u-dev and jdk17u- > dev and propose to release new versions of 11.0.20 and 17.0.8.? > > JDK-8313765 [1] is a fix for a regression in the processing of zip > files containing extended ZIP64 entries that was introduced by JDK- > 8302483 in the July security update. That bug introduced the jdk.util.zip.disableZip64ExtraFieldValidation property so as to have a way to disable the new extra validation. That seems like a work-around to me. Is that not working? I'll also note that CVE-2023-22036 (8302483) has a score of 3.7 (low) if that is being turned off. > This regression affects a significant number of our internal as well > as external customers (you can find more details in the JBS issue [1] > and the original PR [2]). > > We think that the blast radius of the regression justifies a re-spin > of 11.0.20 and 17.0.8 and we are planning to do this for Amazon > Corretto. We would however appreciate if we could agree on this > downport among all maintainers and come up with a synchronized up- > stream fix and versioning. We've published corresponding PRs for > jdk11u-dev [3] and jdk17u-dev [4]. While I agree that it makes sense to fix this in the next JDK 17 (17.0.9) and 11 (11.0.21) releases, I'm not sure this warrants an upstream respin (provided the work-around does what it's supposed to). Thanks, Severin > > [1] https://bugs.openjdk.org/browse/JDK-8313765 > [2] https://github.com/openjdk/jdk/pull/15273 > [3] https://github.com/openjdk/jdk11u-dev/pull/2084 > [4] https://github.com/openjdk/jdk17u-dev/pull/1670 From rgiulietti at openjdk.org Thu Aug 17 13:16:59 2023 From: rgiulietti at openjdk.org (Raffaello Giulietti) Date: Thu, 17 Aug 2023 13:16:59 GMT Subject: [jdk21u] RFR: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match Message-ID: Hi all, This pull request contains a backport of commit 61c58fdd from the openjdk/jdk repository. The commit being backported was authored by Raffaello Giulietti on 4 Aug 2023 and was reviewed by Alan Bateman and Stuart Marks. Thanks! ------------- Commit messages: - Backport 61c58fdd00727da2841a052477e4f4ecfa7094d6 Changes: https://git.openjdk.org/jdk21u/pull/70/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=70&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312976 Stats: 88 lines in 2 files changed: 80 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk21u/pull/70.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/70/head:pull/70 PR: https://git.openjdk.org/jdk21u/pull/70 From rriggs at openjdk.org Thu Aug 17 13:35:33 2023 From: rriggs at openjdk.org (Roger Riggs) Date: Thu, 17 Aug 2023 13:35:33 GMT Subject: [jdk21u] RFR: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 13:09:33 GMT, Raffaello Giulietti wrote: > Hi all, > > This pull request contains a backport of commit 61c58fdd from the openjdk/jdk repository. > > The commit being backported was authored by Raffaello Giulietti on 4 Aug 2023 and was reviewed by Alan Bateman and Stuart Marks. > > Thanks! Marked as reviewed by rriggs (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u/pull/70#pullrequestreview-1582634554 From volker.simonis at gmail.com Thu Aug 17 13:56:15 2023 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 17 Aug 2023 06:56:15 -0700 Subject: Downporting JDK-8313765 to jdk11u and jdk17u and respinning 11.0.20 and 17.0.8 In-Reply-To: References: Message-ID: Hi Severin, As you correctly noted, the workaround will disable all ZIP64 field validation and expose customers to the known vulnerability. This is not acceptable for our customers and I don't think we should force customers into a position where they have to choose between security and functionality. Moreover we know from big customers who are holding back the whole security update untill this issue gets fixed because they cannot easily add the new property to all of their deployments and are afraid to break their services. I've privately talked to Christoph and Goetz (who are both on vacation) and they both support a synchronized up-stream respin. Andrew Haley also the indicated support last week when I talked to him at JVMLS (would be interested in getting his opinion here on this thread). The only tricky thing is the 11u and 17u repos already contain the changes for the October release. So after we got the approval and pushed the downports to 11u-dev and 17u-dev we have to cherry pick them and apply them in a new branch right on top of the 11.0.20/17.0.8 GA changes (and not the current HEAD of those repos). We'd also had to bump the version strings in those new branches. But this has all been done in the past already and I'm happy to do the work. I'd therefore kindly ask you to reconsider your opinion Severin and support a re-spin for the benefit of the OpenJDK community and customers. Thank you and best regards, Volker Severin Gehwolf schrieb am Do., 17. Aug. 2023, 02:34: > Hi, > > On Wed, 2023-08-16 at 22:33 -0700, Volker Simonis wrote: > > Hi, > > > > We would like to downport JDK-8313765 [1] to jdk11u-dev and jdk17u- > > dev and propose to release new versions of 11.0.20 and 17.0.8. > > > > JDK-8313765 [1] is a fix for a regression in the processing of zip > > files containing extended ZIP64 entries that was introduced by JDK- > > 8302483 in the July security update. > > That bug introduced the jdk.util.zip.disableZip64ExtraFieldValidation > property so as to have a way to disable the new extra validation. That > seems like a work-around to me. Is that not working? > > I'll also note that CVE-2023-22036 (8302483) has a score of 3.7 (low) > if that is being turned off. > > > This regression affects a significant number of our internal as well > > as external customers (you can find more details in the JBS issue [1] > > and the original PR [2]). > > > > We think that the blast radius of the regression justifies a re-spin > > of 11.0.20 and 17.0.8 and we are planning to do this for Amazon > > Corretto. We would however appreciate if we could agree on this > > downport among all maintainers and come up with a synchronized up- > > stream fix and versioning. We've published corresponding PRs for > > jdk11u-dev [3] and jdk17u-dev [4]. > > While I agree that it makes sense to fix this in the next JDK 17 > (17.0.9) and 11 (11.0.21) releases, I'm not sure this warrants an > upstream respin (provided the work-around does what it's supposed to). > > Thanks, > Severin > > > > > [1] https://bugs.openjdk.org/browse/JDK-8313765 > > [2] https://github.com/openjdk/jdk/pull/15273 > > [3] https://github.com/openjdk/jdk11u-dev/pull/2084 > > [4] https://github.com/openjdk/jdk17u-dev/pull/1670 > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From schernyshev at openjdk.org Thu Aug 17 14:11:04 2023 From: schernyshev at openjdk.org (Sergey Chernyshev) Date: Thu, 17 Aug 2023 14:11:04 GMT Subject: [jdk17u-dev] RFR: 8168469: Memory leak in JceSecurity Message-ID: The patch did not apply cleanly: updated the copyright header. All tests in javax/crypto, sun/security, com/sun/crypto pass. The new test fails before the fix and passes after the fix. ------------- Commit messages: - Backport a284920b3432b00496a2a32a284a91a9bd49fb06 Changes: https://git.openjdk.org/jdk17u-dev/pull/1671/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1671&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8168469 Stats: 111 lines in 2 files changed: 84 ins; 8 del; 19 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1671.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1671/head:pull/1671 PR: https://git.openjdk.org/jdk17u-dev/pull/1671 From asemenyuk at openjdk.org Thu Aug 17 15:13:35 2023 From: asemenyuk at openjdk.org (Alexey Semenyuk) Date: Thu, 17 Aug 2023 15:13:35 GMT Subject: [jdk21u] RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing In-Reply-To: <4VNFyMbckiN8i1VPvey0rXvmy3IJV33RtSA-guGfAY4=.34adf858-2f30-4db9-a85d-23685b6eb8f9@github.com> References: <4VNFyMbckiN8i1VPvey0rXvmy3IJV33RtSA-guGfAY4=.34adf858-2f30-4db9-a85d-23685b6eb8f9@github.com> Message-ID: <0TFbjbDMepjfJWr5fSi6DFOw9VbKx8Hw618aLfp6vTw=.9f16a7b3-34d0-4008-81c8-b42a12065a28@github.com> On Thu, 17 Aug 2023 00:10:11 GMT, Alexander Matveev wrote: > Clean backport of JDK-8313904. Marked as reviewed by asemenyuk (Author). ------------- PR Review: https://git.openjdk.org/jdk21u/pull/67#pullrequestreview-1582853831 From mchung at openjdk.org Thu Aug 17 16:14:33 2023 From: mchung at openjdk.org (Mandy Chung) Date: Thu, 17 Aug 2023 16:14:33 GMT Subject: [jdk21u] Integrated: 8240567: MethodTooLargeException thrown while creating a jlink image In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 18:19:12 GMT, Mandy Chung wrote: > Manually resolved the merge conflict due to JDK-8310848 which is not in jdk21u. Trivial 1-line change: > > > diff --git a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > index 1ec5f750f4c..563371b05a1 100644 > --- a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > +++ b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > @@ -685,7 +685,7 @@ public final class SystemModulesPlugin extends AbstractPlugin { > if (moduleInfos.size() <= moduleDescriptorsPerMethod) { > clb.withMethodBody( > "moduleDescriptors", > - MTD_ModuleDescriptorArray, > + MethodTypeDesc.of(CD_MODULE_DESCRIPTOR.arrayType()), > ACC_PUBLIC, > cob -> { > cob.constantInstruction(moduleInfos.size()) This pull request has now been integrated. Changeset: 1e81fa55 Author: Mandy Chung URL: https://git.openjdk.org/jdk21u/commit/1e81fa55d5f4b08f9354a3283f719140369289dc Stats: 286 lines in 3 files changed: 267 ins; 1 del; 18 mod 8240567: MethodTooLargeException thrown while creating a jlink image Reviewed-by: phh Backport-of: ec7da91bd83803b7d91a4de3a01caf0ba256c037 ------------- PR: https://git.openjdk.org/jdk21u/pull/65 From andrew at openjdk.org Thu Aug 17 17:06:49 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 17:06:49 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:21:13 GMT, Ben Taylor wrote: > Failing linux GHA looks like infra issues - https://github.com/benty-amzn/jdk11u-dev/actions/runs/5885841578/job/15962854580#step:6:76 Yes, this looks like a variant of the same problem I fixed for 8u in [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772), namely that the very specific version of gcc used is fragile and easily broken by Ubuntu updates. I'd suggest applying something similar to 11u. We do need this to run through GHA before being committed. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1682655169 From gnu.andrew at redhat.com Thu Aug 17 17:31:07 2023 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 17 Aug 2023 18:31:07 +0100 Subject: Downporting JDK-8313765 to jdk11u and jdk17u and respinning 11.0.20 and 17.0.8 In-Reply-To: References: Message-ID: On 22:33 Wed 16 Aug , Volker Simonis wrote: > Hi, > > We would like to downport JDK-8313765 [1] to jdk11u-dev and jdk17u-dev and > propose to release new versions of 11.0.20 and 17.0.8. > > JDK-8313765 [1] is a fix for a regression in the processing of zip files > containing extended ZIP64 entries that was introduced by JDK-8302483 in the > July security update. This regression affects a significant number of our > internal as well as external customers (you can find more details in the > JBS issue [1] and the original PR [2]). > > We think that the blast radius of the regression justifies a re-spin of > 11.0.20 and 17.0.8 and we are planning to do this for Amazon Corretto. We > would however appreciate if we could agree on this downport among all > maintainers and come up with a synchronized up-stream fix and versioning. > We've published corresponding PRs for jdk11u-dev [3] and jdk17u-dev [4]. > > Best regards, > Volker > > [1] https://bugs.openjdk.org/browse/JDK-8313765 > [2] https://github.com/openjdk/jdk/pull/15273 > [3] https://github.com/openjdk/jdk11u-dev/pull/2084 > [4] https://github.com/openjdk/jdk17u-dev/pull/1670 Yes, I've been tracking this since it was discussed in the vulnerability group. I agree it is preferable to have a fix rather than resorting to turning off a CVE fix. My main worry is not about backporting the fix, but in whether we can squeeze in a respin. I'm glad to see the proposed fix has finally been posted publicly, reviewed and integrated as of yesterday. It seems to have taken a long time to get to that stage from the original VG discussion. When we've done interim releases in the past, they have been within a few weeks of the original release. With this release, we are already at the point where we enter rampdown for the next release in < 2 weeks. I think we can still manage an interim release this time, but it needs to happen within the next week, before people start to focus on testing and adding security fixes to the October update. I'll go and review the 11u & 17u backports now. Note that there are currently GHA failures with both, one down to the GCC versioning we removed in 8u with https://bugs.openjdk.org/browse/JDK-8284772 Best regards, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Thu Aug 17 17:31:41 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 17:31:41 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:16:28 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass Failing test is `java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java` which is new to this test. It looks like missing functionality in JUnit: ~~~ /home/runner/work/jdk17u-dev/jdk17u-dev/test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java:24: error: package org.junit.jupiter.api does not exist import org.junit.jupiter.api.BeforeAll; ^ /home/runner/work/jdk17u-dev/jdk17u-dev/test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java:25: error: package org.junit.jupiter.api does not exist import org.junit.jupiter.api.Test; ^ /home/runner/work/jdk17u-dev/jdk17u-dev/test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java:26: error: package org.junit.jupiter.params does not exist import org.junit.jupiter.params.ParameterizedTest; ^ /home/runner/work/jdk17u-dev/jdk17u-dev/test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java:27: error: package org.junit.jupiter.params.provider does not exist import org.junit.jupiter.params.provider.MethodSource; ~~~ Have you managed to run this test against the backport? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#issuecomment-1682686085 From btaylor at openjdk.org Thu Aug 17 17:56:41 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 17:56:41 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:16:28 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass Checked out this branch locally on an amazon linux 2 x64 host: ==================================================== A new configuration has been successfully created in /home/benty/workspace/github/jdk17u-dev/build/linux-x86_64-server-release using configure arguments '--with-jtreg=/home/benty/jtreg/7.3.1/jtreg/'. Configuration summary: * Name: linux-x86_64-server-release * Debug level: release * HS debug level: product * JVM variants: server * JVM features: server: 'cds compiler1 compiler2 epsilongc g1gc jfr jni-check jvmci jvmti management nmt parallelgc serialgc services shenandoahgc vm-structs zgc' * OpenJDK target: OS: linux, CPU architecture: x86, address length: 64 * Version string: 17.0.9-internal+0-adhoc.benty.jdk17u-dev (17.0.9-internal) Tools summary: * Boot JDK: openjdk version "17.0.8" 2023-07-18 LTS OpenJDK Runtime Environment Corretto-17.0.8.7.1 (build 17.0.8+7-LTS) OpenJDK 64-Bit Server VM Corretto-17.0.8.7.1 (build 17.0.8+7-LTS, mixed mode, sharing) (at /usr/lib/jvm/java-17-amazon-corretto.x86_64) * Toolchain: gcc (GNU Compiler Collection) * C Compiler: Version 7.3.1 (at /usr/bin/gcc) * C++ Compiler: Version 7.3.1 (at /usr/bin/g++) Build performance summary: * Cores to use: 16 * Memory limit: 122745 MB `${HOME}/jtreg/7.3.1/jtreg/bin/jtreg -agentvm -a -ea -esa -conc:7 -ignore:quiet -J-Xmx1024m -v:summary,fail,error -timeoutFactor:8 -vmoption:-Xmx1024m -jdk:build/linux-x86_64-server-release/jdk -dir:. test/jdk/java/util/zip` produced Passed: java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java Test results: passed: 70 I can share the jtr if it would be helpful. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#issuecomment-1682720893 From andrew at openjdk.org Thu Aug 17 18:05:40 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 18:05:40 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:16:28 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass Backport otherwise looks good and changes to `CorruptedZipFiles.java` look appropriate. So pending issue is getting the new test to run. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1670#pullrequestreview-1583191164 From andrew at openjdk.org Thu Aug 17 18:08:40 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 18:08:40 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 17:53:23 GMT, Ben Taylor wrote: > Checked out this branch locally on an amazon linux 2 x64 host: > > ``` > ==================================================== > A new configuration has been successfully created in > /home/benty/workspace/github/jdk17u-dev/build/linux-x86_64-server-release > using configure arguments '--with-jtreg=/home/benty/jtreg/7.3.1/jtreg/'. > > Configuration summary: > * Name: linux-x86_64-server-release > * Debug level: release > * HS debug level: product > * JVM variants: server > * JVM features: server: 'cds compiler1 compiler2 epsilongc g1gc jfr jni-check jvmci jvmti management nmt parallelgc serialgc services shenandoahgc vm-structs zgc' > * OpenJDK target: OS: linux, CPU architecture: x86, address length: 64 > * Version string: 17.0.9-internal+0-adhoc.benty.jdk17u-dev (17.0.9-internal) > > Tools summary: > * Boot JDK: openjdk version "17.0.8" 2023-07-18 LTS OpenJDK Runtime Environment Corretto-17.0.8.7.1 (build 17.0.8+7-LTS) OpenJDK 64-Bit Server VM Corretto-17.0.8.7.1 (build 17.0.8+7-LTS, mixed mode, sharing) (at /usr/lib/jvm/java-17-amazon-corretto.x86_64) > * Toolchain: gcc (GNU Compiler Collection) > * C Compiler: Version 7.3.1 (at /usr/bin/gcc) > * C++ Compiler: Version 7.3.1 (at /usr/bin/g++) > > Build performance summary: > * Cores to use: 16 > * Memory limit: 122745 MB > ``` > > `${HOME}/jtreg/7.3.1/jtreg/bin/jtreg -agentvm -a -ea -esa -conc:7 -ignore:quiet -J-Xmx1024m -v:summary,fail,error -timeoutFactor:8 -vmoption:-Xmx1024m -jdk:build/linux-x86_64-server-release/jdk -dir:. test/jdk/java/util/zip` produced > > ``` > > Passed: java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java > > Test results: passed: 70 > ``` > > I can share the jtr if it would be helpful. Thanks, it would be. I think the issue may be the version of JTreg & junit used by GHA. I'll take a look at that now. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#issuecomment-1682736189 From volker.simonis at gmail.com Thu Aug 17 18:21:00 2023 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 17 Aug 2023 11:21:00 -0700 Subject: Downporting JDK-8313765 to jdk11u and jdk17u and respinning 11.0.20 and 17.0.8 In-Reply-To: References: Message-ID: On Thu, Aug 17, 2023 at 10:31?AM Andrew Hughes wrote: > > On 22:33 Wed 16 Aug , Volker Simonis wrote: > > Hi, > > > > We would like to downport JDK-8313765 [1] to jdk11u-dev and jdk17u-dev and > > propose to release new versions of 11.0.20 and 17.0.8. > > > > JDK-8313765 [1] is a fix for a regression in the processing of zip files > > containing extended ZIP64 entries that was introduced by JDK-8302483 in the > > July security update. This regression affects a significant number of our > > internal as well as external customers (you can find more details in the > > JBS issue [1] and the original PR [2]). > > > > We think that the blast radius of the regression justifies a re-spin of > > 11.0.20 and 17.0.8 and we are planning to do this for Amazon Corretto. We > > would however appreciate if we could agree on this downport among all > > maintainers and come up with a synchronized up-stream fix and versioning. > > We've published corresponding PRs for jdk11u-dev [3] and jdk17u-dev [4]. > > > > Best regards, > > Volker > > > > [1] https://bugs.openjdk.org/browse/JDK-8313765 > > [2] https://github.com/openjdk/jdk/pull/15273 > > [3] https://github.com/openjdk/jdk11u-dev/pull/2084 > > [4] https://github.com/openjdk/jdk17u-dev/pull/1670 > > Yes, I've been tracking this since it was discussed in the vulnerability > group. I agree it is preferable to have a fix rather than resorting to > turning off a CVE fix. > > My main worry is not about backporting the fix, but in whether we can > squeeze in a respin. I'm glad to see the proposed fix has finally been > posted publicly, reviewed and integrated as of yesterday. It seems > to have taken a long time to get to that stage from the original VG > discussion. > > When we've done interim releases in the past, they have been within a > few weeks of the original release. With this release, we are already > at the point where we enter rampdown for the next release in < 2 > weeks. > > I think we can still manage an interim release this time, but it > needs to happen within the next week, before people start to focus > on testing and adding security fixes to the October update. > Thanks Andrew, I agree. I think because the 11u and 17u repos already contain changes for the October release we will have to cherry pick the downports from 11u-dev and 17u-dev and apply them in a new branch right on top of the 11.0.20/17.0.8 GA changes (and not the current HEAD of 11u and 17u). We also have to bump the version strings in those new branches. But this has all been done in the past already (e.g. see https://github.com/openjdk/jdk11u/commits/jdk11.0.16.1) so shouldn't be a blocker. > I'll go and review the 11u & 17u backports now. Note that there > are currently GHA failures with both, one down to the GCC versioning > we removed in 8u with https://bugs.openjdk.org/browse/JDK-8284772 > Thanks! > Best regards, > -- > Andrew :) > Pronouns: he / him or they / them > Principal Free Java Software Engineer > OpenJDK Package Owner > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > Please contact via e-mail, not proprietary chat networks > Available on Libera Chat & OFTC IRC networks as gnu_andrew From btaylor at openjdk.org Thu Aug 17 18:24:39 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 18:24:39 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:16:28 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass #Test Results (version 2) #Thu Aug 17 17:49:05 UTC 2023 #-----testdescription----- $file=/local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java $root=/local/home/benty/workspace/github/jdk17u-dev/test/jdk keywords=bug8313765 junit run=USER_SPECIFIED junit ReadNonStandardExtraHeadersTest\n source=ReadNonStandardExtraHeadersTest.java title=Validate that a Zip File with an Extra Header with a data size of 0 can be read. #-----environment----- #-----testresult----- description=file:/local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java elapsed=2517 0:00:02.517 end=Thu Aug 17 17:49:05 UTC 2023 environment=regtest execStatus=Passed. Execution successful harnessLoaderMode=Classpath Loader harnessVariety=Full Bundle hostname= javatestOS=Linux 5.4.249-170.359.amzn2int.x86_64 (amd64) javatestVersion=6.0-ea+b24-2023-08-07-${BUILT_FROM_COMMIT} jtregVersion=jtreg 7.3 dev 0 script=com.sun.javatest.regtest.exec.RegressionScript sections=script_messages build compile junit start=Thu Aug 17 17:49:02 UTC 2023 test=java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java testJDK=/local/home/benty/workspace/github/jdk17u-dev/build/linux-x86_64-server-release/jdk testJDK_OS=[name:Linux,arch:amd64,version:5.4.249-170.359.amzn2int.x86_64,family:linux,simple_arch:x64,simple_version:5.4,processors:16,maxMemory:128708317184,maxSwap:0] testJDK_os.arch=amd64 testJDK_os.name=Linux testJDK_os.version=5.4.249-170.359.amzn2int.x86_64 totalTime=2530 user.name=benty work=/local/home/benty/workspace/github/jdk17u-dev/JTwork/java/util/zip/ZipFile #section:script_messages ----------messages:(4/308)---------- JDK under test: /local/home/benty/workspace/github/jdk17u-dev/build/linux-x86_64-server-release/jdk openjdk version "17.0.9-internal" 2023-10-17 OpenJDK Runtime Environment (build 17.0.9-internal+0-adhoc.benty.jdk17u-dev) OpenJDK 64-Bit Server VM (build 17.0.9-internal+0-adhoc.benty.jdk17u-dev, mixed mode) #section:build ----------messages:(7/252)---------- command: build ReadNonStandardExtraHeadersTest reason: Named class compiled on demand started: Thu Aug 17 17:49:02 UTC 2023 Test directory: compile: ReadNonStandardExtraHeadersTest finished: Thu Aug 17 17:49:04 UTC 2023 elapsed time (seconds): 1.106 result: Passed. Build successful #section:compile ----------messages:(7/314)---------- command: compile /local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java reason: .class file out of date or does not exist started: Thu Aug 17 17:49:02 UTC 2023 Mode: agentvm Agent id: 4 finished: Thu Aug 17 17:49:04 UTC 2023 elapsed time (seconds): 1.106 ----------configuration:(11/716)---------- Boot Layer (javac runtime environment) class path: /local/home/benty/jtreg/7.3.1/jtreg/lib/javatest.jar /local/home/benty/jtreg/7.3.1/jtreg/lib/jtreg.jar patch: java.base /local/home/benty/workspace/github/jdk17u-dev/JTwork/patches/java.base javac compilation environment source path: /local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile class path: /local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile /local/home/benty/workspace/github/jdk17u-dev/JTwork/classes/1/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.d /local/home/benty/jtreg/7.3.1/jtreg/lib/junit-platform-console-standalone-1.9.2.jar ----------rerun:(28/2484)*---------- cd /local/home/benty/workspace/github/jdk17u-dev/JTwork/scratch/6 && \\ HOME=/home/benty \\ LANG=en_US.UTF-8 \\ PATH=/bin:/usr/bin:/usr/sbin \\ XDG_RUNTIME_DIR=/run/user/4923612 \\ XDG_SESSION_ID=84863 \\ /local/home/benty/workspace/github/jdk17u-dev/build/linux-x86_64-server-release/jdk/bin/javac \\ -J-ea \\ -J-esa \\ -J-Xmx1024m \\ -J-Dtest.vm.opts='-ea -esa -Xmx1024m' \\ -J-Dtest.tool.vm.opts='-J-ea -J-esa -J-Xmx1024m' \\ -J-Dtest.compiler.opts= \\ -J-Dtest.java.opts= \\ -J-Dtest.jdk=/local/home/benty/workspace/github/jdk17u-dev/build/linux-x86_64-server-release/jdk \\ -J-Dcompile.jdk=/local/home/benty/workspace/github/jdk17u-dev/build/linux-x86_64-server-release/jdk \\ -J-Dtest.timeout.factor=8.0 \\ -J-Dtest.root=/local/home/benty/workspace/github/jdk17u-dev/test/jdk \\ -J-Dtest.name=java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java \\ -J-Dtest.file=/local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java \\ -J-Dtest.src=/local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile \\ -J-Dtest.src.path=/local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile \\ -J-Dtest.classes=/local/home/benty/workspace/github/jdk17u-dev/JTwork/classes/1/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.d \\ -J-Dtest.class.path=/local/home/benty/workspace/github/jdk17u-dev/JTwork/classes/1/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.d \\ -J-Dtest.class.path.prefix=/local/home/benty/workspace/github/jdk17u-dev/JTwork/classes/1/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.d:/local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile \\ -d /local/home/benty/workspace/github/jdk17u-dev/JTwork/classes/1/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.d \\ -sourcepath /local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile \\ -classpath /local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile:/local/home/benty/workspace/github/jdk17u-dev/JTwork/classes/1/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.d:/local/home/benty/jtreg/7.3.1/jtreg/lib/junit-platform-console-standalone-1.9.2.jar /local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java result: Passed. Compilation successful #section:junit ----------messages:(7/254)---------- command: junit ReadNonStandardExtraHeadersTest reason: User specified action: run junit ReadNonStandardExtraHeadersTest started: Thu Aug 17 17:49:04 UTC 2023 Mode: agentvm Agent id: 8 finished: Thu Aug 17 17:49:05 UTC 2023 elapsed time (seconds): 1.405 ----------configuration:(13/793)---------- Boot Layer class path: /local/home/benty/jtreg/7.3.1/jtreg/lib/javatest.jar /local/home/benty/jtreg/7.3.1/jtreg/lib/jtreg.jar /local/home/benty/jtreg/7.3.1/jtreg/lib/junit-platform-console-standalone-1.9.2.jar /local/home/benty/jtreg/7.3.1/jtreg/lib/testng-7.3.0.jar /local/home/benty/jtreg/7.3.1/jtreg/lib/guice-5.1.0.jar /local/home/benty/jtreg/7.3.1/jtreg/lib/jcommander-1.82.jar patch: java.base /local/home/benty/workspace/github/jdk17u-dev/JTwork/patches/java.base Test Layer class path: /local/home/benty/workspace/github/jdk17u-dev/JTwork/classes/1/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.d /local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile ----------rerun:(24/2296)*---------- cd /local/home/benty/workspace/github/jdk17u-dev/JTwork/scratch/6 && \\ HOME=/home/benty \\ LANG=en_US.UTF-8 \\ PATH=/bin:/usr/bin:/usr/sbin \\ XDG_RUNTIME_DIR=/run/user/4923612 \\ XDG_SESSION_ID=84863 \\ /local/home/benty/workspace/github/jdk17u-dev/build/linux-x86_64-server-release/jdk/bin/java \\ -Dtest.vm.opts='-ea -esa -Xmx1024m' \\ -Dtest.tool.vm.opts='-J-ea -J-esa -J-Xmx1024m' \\ -Dtest.compiler.opts= \\ -Dtest.java.opts= \\ -Dtest.jdk=/local/home/benty/workspace/github/jdk17u-dev/build/linux-x86_64-server-release/jdk \\ -Dcompile.jdk=/local/home/benty/workspace/github/jdk17u-dev/build/linux-x86_64-server-release/jdk \\ -Dtest.timeout.factor=8.0 \\ -Dtest.root=/local/home/benty/workspace/github/jdk17u-dev/test/jdk \\ -Dtest.name=java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java \\ -Dtest.file=/local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java \\ -Dtest.src=/local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile \\ -Dtest.src.path=/local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile \\ -Dtest.classes=/local/home/benty/workspace/github/jdk17u-dev/JTwork/classes/1/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.d \\ -Dtest.class.path=/local/home/benty/workspace/github/jdk17u-dev/JTwork/classes/1/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.d \\ -Dtest.class.path.prefix=/local/home/benty/workspace/github/jdk17u-dev/JTwork/classes/1/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.d:/local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile \\ -classpath /local/home/benty/workspace/github/jdk17u-dev/JTwork/classes/1/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.d:/local/home/benty/workspace/github/jdk17u-dev/test/jdk/java/util/zip/ZipFile:/local/home/benty/jtreg/7.3.1/jtreg/lib/junit-platform-console-standalone-1.9.2.jar:/local/home/benty/jtreg/7.3.1/jtreg/lib/javatest.jar:/local/home/benty/jtreg/7.3.1/jtreg/lib/jtreg.jar \\ com.sun.javatest.regtest.agent.JUnitRunner java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java ReadNonStandardExtraHeadersTest ----------System.err:(23/1722)---------- STARTED ReadNonStandardExtraHeadersTest::zipFilesToTest '[1] working-apk.zip' SUCCESSFUL ReadNonStandardExtraHeadersTest::zipFilesToTest '[1] working-apk.zip' STARTED ReadNonStandardExtraHeadersTest::zipFilesToTest '[2] valid-apache-compress.jar' SUCCESSFUL ReadNonStandardExtraHeadersTest::zipFilesToTest '[2] valid-apache-compress.jar' STARTED ReadNonStandardExtraHeadersTest::zipFilesToTest '[3] valid-ant-zip64-unicode-extrafields.jar' SUCCESSFUL ReadNonStandardExtraHeadersTest::zipFilesToTest '[3] valid-ant-zip64-unicode-extrafields.jar' STARTED ReadNonStandardExtraHeadersTest::zipFilesToTest '[4] valid-ant-zip64-unicode-extrafields.zip' SUCCESSFUL ReadNonStandardExtraHeadersTest::zipFilesToTest '[4] valid-ant-zip64-unicode-extrafields.zip' STARTED ReadNonStandardExtraHeadersTest::readZipFSTest '[1] working-apk.zip' SUCCESSFUL ReadNonStandardExtraHeadersTest::readZipFSTest '[1] working-apk.zip' STARTED ReadNonStandardExtraHeadersTest::readZipFSTest '[2] valid-apache-compress.jar' SUCCESSFUL ReadNonStandardExtraHeadersTest::readZipFSTest '[2] valid-apache-compress.jar' STARTED ReadNonStandardExtraHeadersTest::readZipFSTest '[3] valid-ant-zip64-unicode-extrafields.jar' SUCCESSFUL ReadNonStandardExtraHeadersTest::readZipFSTest '[3] valid-ant-zip64-unicode-extrafields.jar' STARTED ReadNonStandardExtraHeadersTest::readZipFSTest '[4] valid-ant-zip64-unicode-extrafields.zip' SUCCESSFUL ReadNonStandardExtraHeadersTest::readZipFSTest '[4] valid-ant-zip64-unicode-extrafields.zip' [ JUnit Containers: found 6, started 6, succeeded 6, failed 0, aborted 0, skipped 0] [ JUnit Tests: found 8, started 8, succeeded 8, failed 0, aborted 0, skipped 0] JavaTest Message: Test complete. ----------System.out:(8/804)---------- /local/home/benty/workspace/github/jdk17u-dev/JTwork/scratch/6/working-apk.zip opened /local/home/benty/workspace/github/jdk17u-dev/JTwork/scratch/6/valid-apache-compress.jar opened /local/home/benty/workspace/github/jdk17u-dev/JTwork/scratch/6/valid-ant-zip64-unicode-extrafields.jar opened /local/home/benty/workspace/github/jdk17u-dev/JTwork/scratch/6/valid-ant-zip64-unicode-extrafields.zip opened /local/home/benty/workspace/github/jdk17u-dev/JTwork/scratch/6/working-apk.zip opened /local/home/benty/workspace/github/jdk17u-dev/JTwork/scratch/6/valid-apache-compress.jar opened /local/home/benty/workspace/github/jdk17u-dev/JTwork/scratch/6/valid-ant-zip64-unicode-extrafields.jar opened /local/home/benty/workspace/github/jdk17u-dev/JTwork/scratch/6/valid-ant-zip64-unicode-extrafields.zip opened result: Passed. Execution successful test result: Passed. Execution successful ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#issuecomment-1682758471 From simonis at openjdk.org Thu Aug 17 18:48:41 2023 From: simonis at openjdk.org (Volker Simonis) Date: Thu, 17 Aug 2023 18:48:41 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 17:03:36 GMT, Andrew John Hughes wrote: > > Failing linux GHA looks like infra issues - https://github.com/benty-amzn/jdk11u-dev/actions/runs/5885841578/job/15962854580#step:6:76 > > Yes, this looks like a variant of the same problem I fixed for 8u in [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772), namely that the very specific version of gcc used is fragile and easily broken by Ubuntu updates. I'd suggest applying something similar to 11u. We do need this to run through GHA before being committed. @gnu-andrew are you working on fixing GHA for jdk11u and is there a JBS issue for it already or should we pick it up? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1682789269 From btaylor at openjdk.org Thu Aug 17 18:52:41 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 18:52:41 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:16:28 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass Discussed with @shipilev and @mrserb. The jtreg update is blocked on other issues in #1595 and #1572. We will investigate rewriting the test without the junit dependency for now, although ideally this test can be restored to the version in tip once the jtreg update is completed to prevent divergence in the future. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#issuecomment-1682790471 From andrew at openjdk.org Thu Aug 17 18:52:41 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 18:52:41 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:16:28 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass Thanks. Yeah, the problem here is the GHA is still using JTReg 6.1+3. The test passes for me locally too with 7+1 or 7+2, but fails as soon as I go back to 6.1+1. Rather than altering the test significantly for this backport, let's see if we can update the JTreg used by 17u by backporting [8289798](https://bugs.openjdk.org/browse/JDK-8289798). It looks like the dependent changes to tests were already backported by @GoeLin so this might not be too risky. Ah, I did wonder why the dependent fixes had been backported and not the update. I'll have a look at those PRs. It would be good to unblock this both for 11u & 17u. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#issuecomment-1682792739 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#issuecomment-1682794282 From rgiulietti at openjdk.org Thu Aug 17 19:14:38 2023 From: rgiulietti at openjdk.org (Raffaello Giulietti) Date: Thu, 17 Aug 2023 19:14:38 GMT Subject: [jdk21u] Integrated: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 13:09:33 GMT, Raffaello Giulietti wrote: > Hi all, > > This pull request contains a backport of commit 61c58fdd from the openjdk/jdk repository. > > The commit being backported was authored by Raffaello Giulietti on 4 Aug 2023 and was reviewed by Alan Bateman and Stuart Marks. > > Thanks! This pull request has now been integrated. Changeset: c3eda1c5 Author: Raffaello Giulietti Committer: Roger Riggs URL: https://git.openjdk.org/jdk21u/commit/c3eda1c52984dd1673e010ea77583b806f27fef0 Stats: 88 lines in 2 files changed: 80 ins; 0 del; 8 mod 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match Reviewed-by: rriggs Backport-of: 61c58fdd00727da2841a052477e4f4ecfa7094d6 ------------- PR: https://git.openjdk.org/jdk21u/pull/70 From btaylor at openjdk.org Thu Aug 17 19:24:08 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 19:24:08 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: Remove junit dependency in ReadNonStandardExtraHeadersTest.java to run with jtreg 6 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1670/files - new: https://git.openjdk.org/jdk17u-dev/pull/1670/files/0f84fe31..de8e62da Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1670&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1670&range=00-01 Stats: 25 lines in 1 file changed: 13 ins; 10 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1670.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1670/head:pull/1670 PR: https://git.openjdk.org/jdk17u-dev/pull/1670 From rriggs at openjdk.org Thu Aug 17 19:27:48 2023 From: rriggs at openjdk.org (Roger Riggs) Date: Thu, 17 Aug 2023 19:27:48 GMT Subject: [jdk21u] RFR: 8313312: Add missing classpath exception copyright header Message-ID: The same copyright updates are needed in jdk21u. ------------- Commit messages: - Backport 53ca75b18ea419d469758475fac8352bf915b484 Changes: https://git.openjdk.org/jdk21u/pull/71/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=71&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313312 Stats: 48 lines in 16 files changed: 32 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk21u/pull/71.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/71/head:pull/71 PR: https://git.openjdk.org/jdk21u/pull/71 From andrew at openjdk.org Thu Aug 17 19:30:40 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 19:30:40 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 18:45:33 GMT, Volker Simonis wrote: > > > Failing linux GHA looks like infra issues - https://github.com/benty-amzn/jdk11u-dev/actions/runs/5885841578/job/15962854580#step:6:76 > > > > > > Yes, this looks like a variant of the same problem I fixed for 8u in [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772), namely that the very specific version of gcc used is fragile and easily broken by Ubuntu updates. I'd suggest applying something similar to 11u. We do need this to run through GHA before being committed. > > @gnu-andrew are you working on fixing GHA for jdk11u and is there a JBS issue for it already or should we pick it up? I'm about to open a PR, which this one can then depend on and retest. It may be contentious though, as I intend to suggest dropping the minor version requirement altogether rather than continually bumping it every time Ubuntu update the gcc package. We did this in 8u some time ago and it's not been an issue since. Note that this PR will need the same changes we added to the 17u one, as 11u is also still on JTReg 6. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1682841808 From andrew at openjdk.org Thu Aug 17 19:47:07 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 19:47:07 GMT Subject: [jdk11u-dev] RFR: 8284772: 8u GHA: Use GCC Major Version Dependencies Only Message-ID: GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available. Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. ------------- Commit messages: - Backport 62defc3dfc4b9ba5adfe3189f34fe8b3f59b94a0 Changes: https://git.openjdk.org/jdk11u-dev/pull/2087/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2087&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284772 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2087.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2087/head:pull/2087 PR: https://git.openjdk.org/jdk11u-dev/pull/2087 From andrew at openjdk.org Thu Aug 17 19:47:40 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 19:47:40 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:16:27 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 > > All tests in `test/jdk/java/util/zip` pass https://github.com/openjdk/jdk11u-dev/pull/2087 This is already progressing further in GHA than the run here managed. If you make this dependent on that PR (change the target from openjdk:master to openjdk:pr/2087) it should be possible to re-run the tests ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1682866703 From serb at openjdk.org Thu Aug 17 20:02:31 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 17 Aug 2023 20:02:31 GMT Subject: [jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 19:39:59 GMT, Andrew John Hughes wrote: > GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available. > > Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. > > Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. Marked as reviewed by serb (Reviewer). maybe we can do the same for 17? ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2087#pullrequestreview-1583374166 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2087#issuecomment-1682894591 From btaylor at openjdk.org Thu Aug 17 20:10:41 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 20:10:41 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:16:27 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 > > All tests in `test/jdk/java/util/zip` pass Updated. Would you like me to also include the commit from [jdk17u-dev #1670](https://github.com/openjdk/jdk17u-dev/pull/1670) to allow running on jtreg6? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1682906110 From serb at openjdk.org Thu Aug 17 20:34:38 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 17 Aug 2023 20:34:38 GMT Subject: [jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: <6uJ0MG-5akagNaiUzOg77yNZRMCiLFjQaNnf2iTi5Ks=.c9372496-8fdc-45ed-b2e0-f5b701e09907@github.com> On Thu, 17 Aug 2023 19:39:59 GMT, Andrew John Hughes wrote: > GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available. > > Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. > > Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. [build-cross-compile.yml](https://github.com/openjdk/jdk11u-dev/blob/master/.github/workflows/build-cross-compile.yml#L38) should be updated as well? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2087#issuecomment-1682932820 From andrew at openjdk.org Thu Aug 17 21:19:40 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 21:19:40 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 20:07:27 GMT, Ben Taylor wrote: > Updated. Would you like me to also include the commit from [jdk17u-dev #1670](https://github.com/openjdk/jdk17u-dev/pull/1670) to allow running on jtreg6? Yes please. Looks like we're now seeing the same failure as we did in 17u. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1682992836 From andrew at openjdk.org Thu Aug 17 21:21:39 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 21:21:39 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 19:24:08 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Remove junit dependency in ReadNonStandardExtraHeadersTest.java to run with jtreg 6 Test looks like it's passing now so this is good to go. Glad removing the dep wasn't too complicated. If you add a `jdk17u-fix-request` label and appropriate request comment to the bug, I can approve for 17u. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1670#pullrequestreview-1583509421 From simonis at openjdk.org Thu Aug 17 21:32:33 2023 From: simonis at openjdk.org (Volker Simonis) Date: Thu, 17 Aug 2023 21:32:33 GMT Subject: [jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 19:39:59 GMT, Andrew John Hughes wrote: > GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available. > > Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. > > Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. Thanks for the quick fix. Looks good to me. ------------- Marked as reviewed by simonis (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2087#pullrequestreview-1583523839 From btaylor at openjdk.org Thu Aug 17 21:34:15 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 17 Aug 2023 21:34:15 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 > > All tests in `test/jdk/java/util/zip` pass Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: Remove junit dependency in ReadNonStandardExtraHeadersTest.java to run with jtreg 6 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2084/files - new: https://git.openjdk.org/jdk11u-dev/pull/2084/files/73d80cb2..b7ccbf17 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2084&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2084&range=00-01 Stats: 25 lines in 1 file changed: 13 ins; 10 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2084.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2084/head:pull/2084 PR: https://git.openjdk.org/jdk11u-dev/pull/2084 From tsteele at openjdk.org Thu Aug 17 21:36:38 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Thu, 17 Aug 2023 21:36:38 GMT Subject: [jdk11u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address In-Reply-To: References: Message-ID: On Fri, 9 Jun 2023 16:25:13 GMT, Tyler Steele wrote: > This PR backports the change reported in [JDK-8305906](https://bugs.openjdk.org/browse/JDK-8305906). Bump ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1941#issuecomment-1683009868 From tsteele at openjdk.org Thu Aug 17 21:39:37 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Thu, 17 Aug 2023 21:39:37 GMT Subject: [jdk17u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address In-Reply-To: References: Message-ID: On Fri, 9 Jun 2023 16:20:19 GMT, Tyler Steele wrote: > This PR backports the change reported in [JDK-8305906](https://bugs.openjdk.org/browse/JDK-8305906). Bump ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1419#issuecomment-1683012866 From serb at openjdk.org Thu Aug 17 21:40:37 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 17 Aug 2023 21:40:37 GMT Subject: [jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: <4js-1nJ4Mcp2VMLKM_4-wGz-xd9yhRmp_8fhpzj5VxQ=.22785e90-c596-4bb1-bbe9-21c04ac13662@github.com> On Thu, 17 Aug 2023 19:39:59 GMT, Andrew John Hughes wrote: > GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available. > > Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. > > Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. Yeah cross compilation should be updated. ------------- Changes requested by serb (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2087#pullrequestreview-1583532064 From bylokhov at amazon.com Thu Aug 17 21:50:51 2023 From: bylokhov at amazon.com (Sergey Bylokhov) Date: Thu, 17 Aug 2023 14:50:51 -0700 Subject: Downporting JDK-8313765 to jdk11u and jdk17u and respinning 11.0.20 and 17.0.8 In-Reply-To: References: Message-ID: <33fa9d7e-ce9e-4936-b250-cb1b254c282c@amazon.com> Nobody mention respin of JDK 20u: https://github.com/openjdk/jdk20u/pull/87 Does anybody plan to do it? On 8/17/23 10:31, Andrew Hughes wrote: > Yes, I've been tracking this since it was discussed in the vulnerability > group. I agree it is preferable to have a fix rather than resorting to > turning off a CVE fix. > > My main worry is not about backporting the fix, but in whether we can > squeeze in a respin. I'm glad to see the proposed fix has finally been > posted publicly, reviewed and integrated as of yesterday. It seems > to have taken a long time to get to that stage from the original VG > discussion. > > When we've done interim releases in the past, they have been within a > few weeks of the original release. With this release, we are already > at the point where we enter rampdown for the next release in < 2 > weeks. > > I think we can still manage an interim release this time, but it > needs to happen within the next week, before people start to focus > on testing and adding security fixes to the October update. > > I'll go and review the 11u & 17u backports now. Note that there > are currently GHA failures with both, one down to the GCC versioning > we removed in 8u with https://bugs.openjdk.org/browse/JDK-8284772 -- Best regards, Sergey. From serb at openjdk.org Thu Aug 17 22:20:40 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 17 Aug 2023 22:20:40 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 19:24:08 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Remove junit dependency in ReadNonStandardExtraHeadersTest.java to run with jtreg 6 test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java line 937: > 935: }); > 936: } > 937: } I think an upstream has the newline here. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#discussion_r1297802317 From serb at openjdk.org Thu Aug 17 22:23:37 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 17 Aug 2023 22:23:37 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: <42URDw0kqnUzQ3UlFj7dm1FStNu-J7sGylcEbrk0MzM=.f2fccf58-e442-40df-b5a2-4b96d005111d@github.com> On Thu, 17 Aug 2023 21:34:15 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Remove junit dependency in ReadNonStandardExtraHeadersTest.java to run with jtreg 6 test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java line 939: > 937: }); > 938: } > 939: } The new line? ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#discussion_r1297804195 From serb at openjdk.org Thu Aug 17 22:26:40 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 17 Aug 2023 22:26:40 GMT Subject: [jdk11u-dev] RFR: 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v2] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Thu, 10 Aug 2023 10:35:28 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > Update full name please confirm that this is a jdk11u-dev fix only caused by the typo in the backport and we do not need to patch any other versions like 17u-dev ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2074#issuecomment-1683054025 From andrew at openjdk.org Thu Aug 17 23:27:39 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 23:27:39 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 22:17:31 GMT, Sergey Bylokhov wrote: >> Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove junit dependency in ReadNonStandardExtraHeadersTest.java to run with jtreg 6 > > test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java line 937: > >> 935: }); >> 936: } >> 937: } > > I think an upstream has the newline here. I don't see one in https://github.com/openjdk/jdk/commit/13f6450e2e70df4df8bd882def837fbd5bef1524#diff-3f36cef3f473e3b83ba97e882fcc9bbb4b84a36bf56ad118e49584c12e2c3a17 either (and it's not showing up in a diff between the two) ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#discussion_r1297841926 From andrew at openjdk.org Thu Aug 17 23:29:33 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 17 Aug 2023 23:29:33 GMT Subject: [jdk20u] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: <8kUgRlkY6Y4-R7k7ZbCIYy0AU4vUw9NKuAHeKAWkpuk=.34fda669-edc2-408e-b9cb-a6578ad5073f@github.com> References: <8kUgRlkY6Y4-R7k7ZbCIYy0AU4vUw9NKuAHeKAWkpuk=.34fda669-edc2-408e-b9cb-a6578ad5073f@github.com> Message-ID: On Thu, 17 Aug 2023 02:16:29 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass I don't believe there will be any more JDK20 releases, so this probably needs to target openjdk/jdk21u. ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/87#issuecomment-1683107342 From duke at openjdk.org Thu Aug 17 23:45:44 2023 From: duke at openjdk.org (Dan Lutker) Date: Thu, 17 Aug 2023 23:45:44 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 Message-ID: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. bash ./configure --with-jtreg=jtreg-7.3+1 make images make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" ------------- Commit messages: - 8314552: Fix javadoc tests to work with jtreg 7 Changes: https://git.openjdk.org/jdk17u-dev/pull/1672/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1672&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314552 Stats: 18 lines in 6 files changed: 6 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1672.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1672/head:pull/1672 PR: https://git.openjdk.org/jdk17u-dev/pull/1672 From andrew at openjdk.org Fri Aug 18 00:19:57 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 00:19:57 GMT Subject: [jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2] In-Reply-To: References: Message-ID: > GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available. > > Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. > > Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: Fix specific version usage in cross compilation ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2087/files - new: https://git.openjdk.org/jdk11u-dev/pull/2087/files/5ab54a0f..f620328a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2087&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2087&range=00-01 Stats: 12 lines in 1 file changed: 0 ins; 8 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2087.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2087/head:pull/2087 PR: https://git.openjdk.org/jdk11u-dev/pull/2087 From andrew at openjdk.org Fri Aug 18 00:31:39 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 00:31:39 GMT Subject: [jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2] In-Reply-To: <4js-1nJ4Mcp2VMLKM_4-wGz-xd9yhRmp_8fhpzj5VxQ=.22785e90-c596-4bb1-bbe9-21c04ac13662@github.com> References: <4js-1nJ4Mcp2VMLKM_4-wGz-xd9yhRmp_8fhpzj5VxQ=.22785e90-c596-4bb1-bbe9-21c04ac13662@github.com> Message-ID: <3Grs5_GjTcdZbONtgOua6QPcnI9GuHrJBUF1c8NnhNA=.4d9f6e53-1366-4513-87b1-c3933add0525@github.com> On Thu, 17 Aug 2023 21:37:35 GMT, Sergey Bylokhov wrote: > Yeah cross compilation should be updated. Good catch. My `grep` didn't catch that as the version is set indirectly as a default value. For the current 11u version of `build-cross-compile.yml`, we just drop `apt-gcc-version` and `apt-gcc-cross-suffix` altogether as they only relate to the specific version e.g. we now ask for `gcc-10-s390x-linux-gnu` not `gcc-10-s390x-linux-gnu=10.3.0-1ubuntu1~20.04cross1` (https://packages.ubuntu.com/jammy/gcc-10-s390x-linux-gnu) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2087#issuecomment-1683151969 From andrew at openjdk.org Fri Aug 18 00:31:41 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 00:31:41 GMT Subject: [jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 19:58:43 GMT, Sergey Bylokhov wrote: > maybe we can do the same for 17? I'm happy to propose it if this goes through. It's not as critical as https://github.com/openjdk/jdk17u/commit/260f28761a87553fd634615df5ba3db5b76ae692 was already added there. The need for things like [JDK-8313428](https://bugs.openjdk.org/browse/JDK-8313428) included in that change is exactly why I think this is the better long-term option. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2087#issuecomment-1683152923 From serb at openjdk.org Fri Aug 18 01:00:42 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 18 Aug 2023 01:00:42 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 23:24:33 GMT, Andrew John Hughes wrote: >> test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java line 937: >> >>> 935: }); >>> 936: } >>> 937: } >> >> I think an upstream has the newline here. > > I don't see one in https://github.com/openjdk/jdk/commit/13f6450e2e70df4df8bd882def837fbd5bef1524#diff-3f36cef3f473e3b83ba97e882fcc9bbb4b84a36bf56ad118e49584c12e2c3a17 either (and it's not showing up in a diff between the two) 17: https://patch-diff.githubusercontent.com/raw/openjdk/jdk17u-dev/pull/1670.diff jdk: https://patch-diff.githubusercontent.com/raw/openjdk/jdk/pull/15273.diff in the 17 check the end of the file + } +} \ No newline at end of file ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#discussion_r1297883405 From serb at openjdk.org Fri Aug 18 01:02:31 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 18 Aug 2023 01:02:31 GMT Subject: [jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2] In-Reply-To: References: Message-ID: <0c_R7Qjd0fojR2gykKChChLVLZ7F9Y2f3cQkmQ_FtaE=.9bf9fac0-8c0c-43d2-919d-c6f84b535215@github.com> On Fri, 18 Aug 2023 00:19:57 GMT, Andrew John Hughes wrote: >> GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available. >> >> Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. >> >> Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. > > Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: > > Fix specific version usage in cross compilation Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2087#pullrequestreview-1583687069 From andrew at openjdk.org Fri Aug 18 02:00:33 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 02:00:33 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 In-Reply-To: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: <9rranwZ08Gb9yEX_J9CTECLD0eNvIkNA8bBk4PmgvMo=.17c89504-26f3-47f5-a85a-8d66c8f17fae@github.com> On Thu, 17 Aug 2023 23:39:45 GMT, Dan Lutker wrote: > Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. > > > bash ./configure --with-jtreg=jtreg-7.3+1 > make images > make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" > > > All tests pass. Can you make this target pr/1595 instead of master? Then we can see if it fixes the issue we're seeing on that PR. The tests work for me locally with JTReg 7 without this patch. We need to know if fixes things in GHA. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1672#issuecomment-1683221534 From andrew at openjdk.org Fri Aug 18 02:08:42 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 02:08:42 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 00:56:05 GMT, Sergey Bylokhov wrote: >> I don't see one in https://github.com/openjdk/jdk/commit/13f6450e2e70df4df8bd882def837fbd5bef1524#diff-3f36cef3f473e3b83ba97e882fcc9bbb4b84a36bf56ad118e49584c12e2c3a17 either (and it's not showing up in a diff between the two) > > 17: https://patch-diff.githubusercontent.com/raw/openjdk/jdk17u-dev/pull/1670.diff > jdk: https://patch-diff.githubusercontent.com/raw/openjdk/jdk/pull/15273.diff > > in the 17 check the end of the file > > + } > +} > \ No newline at end of file Ah I see it now. It was introduced by the second commit. The original version I have didn't have this issue. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#discussion_r1297910089 From andrew at openjdk.org Fri Aug 18 02:08:43 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 02:08:43 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 02:04:05 GMT, Andrew John Hughes wrote: >> 17: https://patch-diff.githubusercontent.com/raw/openjdk/jdk17u-dev/pull/1670.diff >> jdk: https://patch-diff.githubusercontent.com/raw/openjdk/jdk/pull/15273.diff >> >> in the 17 check the end of the file >> >> + } >> +} >> \ No newline at end of file > > Ah I see it now. It was introduced by the second commit. The original version I have didn't have this issue. ~~~ $ diff -u 8313765.17u{,-02} |tail ++ try { ++ test.zipFilesToTest(path); ++ test.readZipFSTest(path); ++ } catch (IOException e) { ++ throw new RuntimeException(e); ++ } ++ }); ++ } +} +\ No newline at end of file ~~~ ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#discussion_r1297910596 From andrew at openjdk.org Fri Aug 18 02:43:37 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 02:43:37 GMT Subject: [jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2] In-Reply-To: References: Message-ID: <4rXaBlntajQo1OBLkkY2LPeIhHZ-jmMU9-5tZFZj2jQ=.4b61d1bc-a8fc-4bff-9acb-8d2b44b5c008@github.com> On Fri, 18 Aug 2023 00:19:57 GMT, Andrew John Hughes wrote: >> GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available. >> >> Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. >> >> Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. > > Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: > > Fix specific version usage in cross compilation Thanks for the reviews. I've flagged the bug for 11u approval. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2087#issuecomment-1683255222 From fyang at openjdk.org Fri Aug 18 03:05:41 2023 From: fyang at openjdk.org (Fei Yang) Date: Fri, 18 Aug 2023 03:05:41 GMT Subject: [jdk17u-dev] RFR: 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V [v2] In-Reply-To: References: Message-ID: <1i9XCgTGbaOslTQ6NZLrITApyfADvl6a2H_zQALmrdo=.fed0a987-4846-4214-adea-63243349d840@github.com> On Fri, 11 Aug 2023 02:36:29 GMT, Dingli Zhang wrote: >> I would like to backport [JDK-8309254](https://bugs.openjdk.org/browse/JDK-8309254). >> The backport is not clean because 17u has no [JDK-8302908](https://bugs.openjdk.org/browse/JDK-8302908), which use v0 as mask register. >> The test `test/hotspot/jtreg/compiler/intrinsics/string/TestEncodeIntrinsics.java` passed and command log with "-XX:+PrintOptoAssembly" output is similar to the mainline: >> >> ... >> 240 Encode ISO array R12, R11, R13 -> R10 # KILL R12, R11, R13, R28, V1-V3 >> ... >> 0118 Encode ASCII array R12, R11, R13 -> R10 # KILL R12, R11, R13, R25, V1-V3 >> ... > > Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into backport-8309254 > - 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V Marked as reviewed by fyang (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1567#pullrequestreview-1583758621 From dzhang at openjdk.org Fri Aug 18 03:17:46 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Fri, 18 Aug 2023 03:17:46 GMT Subject: [jdk17u-dev] RFR: 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V [v3] In-Reply-To: References: Message-ID: > I would like to backport [JDK-8309254](https://bugs.openjdk.org/browse/JDK-8309254). > The backport is not clean because 17u has no [JDK-8302908](https://bugs.openjdk.org/browse/JDK-8302908), which use v0 as mask register. > The test `test/hotspot/jtreg/compiler/intrinsics/string/TestEncodeIntrinsics.java` passed and command log with "-XX:+PrintOptoAssembly" output is similar to the mainline: > > ... > 240 Encode ISO array R12, R11, R13 -> R10 # KILL R12, R11, R13, R28, V1-V3 > ... > 0118 Encode ASCII array R12, R11, R13 -> R10 # KILL R12, R11, R13, R25, V1-V3 > ... Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into backport-8309254 - Merge remote-tracking branch 'origin/master' into backport-8309254 - 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1567/files - new: https://git.openjdk.org/jdk17u-dev/pull/1567/files/bd1c4506..539e39fe Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1567&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1567&range=01-02 Stats: 1592 lines in 31 files changed: 944 ins; 283 del; 365 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1567.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1567/head:pull/1567 PR: https://git.openjdk.org/jdk17u-dev/pull/1567 From duke at openjdk.org Fri Aug 18 04:21:34 2023 From: duke at openjdk.org (Dan Lutker) Date: Fri, 18 Aug 2023 04:21:34 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v2] In-Reply-To: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: <0f-6nu4wItS4fp8nyGgOV32Z61zRoWVbxmX7Fx2n-1c=.08d93651-2d6b-479e-983f-2f080b78d5ae@github.com> > Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. > > > bash ./configure --with-jtreg=jtreg-7.3+1 > make images > make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" > > > All tests pass. Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: 8314552: Fix javadoc tests to work with jtreg 7 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1672/files - new: https://git.openjdk.org/jdk17u-dev/pull/1672/files/f11a581b..c81dda6e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1672&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1672&range=00-01 Stats: 40705 lines in 874 files changed: 13165 ins; 15178 del; 12362 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1672.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1672/head:pull/1672 PR: https://git.openjdk.org/jdk17u-dev/pull/1672 From duke at openjdk.org Fri Aug 18 04:23:31 2023 From: duke at openjdk.org (Dan Lutker) Date: Fri, 18 Aug 2023 04:23:31 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 In-Reply-To: <9rranwZ08Gb9yEX_J9CTECLD0eNvIkNA8bBk4PmgvMo=.17c89504-26f3-47f5-a85a-8d66c8f17fae@github.com> References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> <9rranwZ08Gb9yEX_J9CTECLD0eNvIkNA8bBk4PmgvMo=.17c89504-26f3-47f5-a85a-8d66c8f17fae@github.com> Message-ID: <2TmVxOldT8yrywvXLBVByVjQwbKPq2uwhmDQj65vqC8=.7175a8bf-eb39-41b5-8977-6f2079c27cf3@github.com> On Fri, 18 Aug 2023 01:57:19 GMT, Andrew John Hughes wrote: > Can you make this target pr/1595 instead of master? Then we can see if it fixes the issue we're seeing on that PR. > > The tests work for me locally with JTReg 7 without this patch. We need to know if fixes things in GHA. > > Thanks. And now we hit the GCC version issue.... Can you forward port https://github.com/openjdk/jdk11u-dev/pull/2087 and then we can target pr/1595 onto that and maybe all should work? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1672#issuecomment-1683332256 From andrewlu at openjdk.org Fri Aug 18 06:11:16 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 18 Aug 2023 06:11:16 GMT Subject: [jdk11u-dev] RFR: 8306575: Clean up and open source four Dialog related tests Message-ID: I backport this for parity with 11.0.21-oracle. test/jdk/java/awt/Dialog/DialogLocationTest.java "random.nextInt(insetX, width - 300)" is modified as random.nextInt(int origin, int bound) is not supported in jdk11. "System.out.println(message.formatted(newX, newY, eventLoc.x, eventLoc.y, eventLoc.x - newX, eventLoc.y - newY))" is also modified as String.formatted(Object... args) is not supported in jdk11. ------------- Commit messages: - Backport 8d696aea9e1cefca97a760c017a5fde545facaa9 Changes: https://git.openjdk.org/jdk11u-dev/pull/2088/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2088&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306575 Stats: 581 lines in 4 files changed: 581 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2088.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2088/head:pull/2088 PR: https://git.openjdk.org/jdk11u-dev/pull/2088 From btaylor at openjdk.org Fri Aug 18 06:23:18 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 18 Aug 2023 06:23:18 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3] In-Reply-To: References: Message-ID: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 > > All tests in `test/jdk/java/util/zip` pass Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2084/files - new: https://git.openjdk.org/jdk11u-dev/pull/2084/files/b7ccbf17..014dbf6a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2084&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2084&range=01-02 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2084.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2084/head:pull/2084 PR: https://git.openjdk.org/jdk11u-dev/pull/2084 From btaylor at openjdk.org Fri Aug 18 06:25:02 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 18 Aug 2023 06:25:02 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3] In-Reply-To: References: Message-ID: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1670/files - new: https://git.openjdk.org/jdk17u-dev/pull/1670/files/de8e62da..e2f9bde8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1670&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1670&range=01-02 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1670.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1670/head:pull/1670 PR: https://git.openjdk.org/jdk17u-dev/pull/1670 From goetz at openjdk.org Fri Aug 18 07:45:43 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 18 Aug 2023 07:45:43 GMT Subject: [jdk11u-dev] RFR: 8302161: Upgrade jQuery UI to version 1.13.2 In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 05:21:05 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8302161 for jdk11u. > This is clean backport. > Also, this backport contains JDK-8293180. > > All jdk/javadoc tests are passed. Hi [Nagata-Haruhito](https://github.com/Nagata-Haruhito) For next time: If you backport starting out with the change in 17 and using the hash of the push there in the commit message, such backports often are clean. This saves work for the reviewer and increases trust in the change. Best, Goetz. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2064#issuecomment-1683500646 From goetz at openjdk.org Fri Aug 18 07:50:33 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 18 Aug 2023 07:50:33 GMT Subject: [jdk11u-dev] RFR: 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v2] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Thu, 10 Aug 2023 10:35:28 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > Update full name Please remove file test/jdk.zip from the PR! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2074#issuecomment-1683508184 From goetz at openjdk.org Fri Aug 18 07:56:40 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 18 Aug 2023 07:56:40 GMT Subject: [jdk11u-dev] RFR: 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v2] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Thu, 10 Aug 2023 10:35:28 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > Update full name This was actually broken in 11u, cause is backport of JDK-8222323, JDK-8312462. Please add [11u] to the title of the PR as I did for the JBS bug. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2074#issuecomment-1683514121 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2074#issuecomment-1683514719 From lucy at openjdk.org Fri Aug 18 08:30:44 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 18 Aug 2023 08:30:44 GMT Subject: [jdk11u-dev] Integrated: 8301269: Update Commons BCEL to Version 6.7.0 In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 09:28:44 GMT, Lutz Schmidt wrote: > Fix request [11u] > > One of the required updates of external libs. > > I based the bckport to 11u on Goetz's backport to 17u, Low risk. > Except for two copyright format issues (missing comma), I had to resolve just this one file: src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/Utility.java > This file had undergone major restructuring. In the end, the resolve process resulted in a simple copy from 17 to 11. > > SAP nightly testing successful. No findings attributable to this backport. > Review received. This pull request has now been integrated. Changeset: cb392e6b Author: Lutz Schmidt URL: https://git.openjdk.org/jdk11u-dev/commit/cb392e6baccc23ab7a4ea176845b85b32e105b04 Stats: 30508 lines in 334 files changed: 9314 ins; 10825 del; 10369 mod 8301269: Update Commons BCEL to Version 6.7.0 Reviewed-by: mdoerr Backport-of: 6a44120a16d0f06b4ed9f0ebf6b0919da7070287 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2082 From duke at openjdk.org Fri Aug 18 08:35:38 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Fri, 18 Aug 2023 08:35:38 GMT Subject: [jdk11u-dev] RFR: 8302161: Upgrade jQuery UI to version 1.13.2 In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 05:21:05 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8302161 for jdk11u. > This is clean backport. > Also, this backport contains JDK-8293180. > > All jdk/javadoc tests are passed. Thanks for your advice. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2064#issuecomment-1683561271 From ayang at openjdk.org Fri Aug 18 11:47:37 2023 From: ayang at openjdk.org (Albert Mingkun Yang) Date: Fri, 18 Aug 2023 11:47:37 GMT Subject: [jdk21u] RFR: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp In-Reply-To: References: Message-ID: <6AH-4flPOH5C-I57pHWljilec5ul2bPBzRs2A6Va9fY=.04e0612d-d3cf-4483-977f-cf53b397b22a@github.com> On Thu, 17 Aug 2023 07:29:31 GMT, Thomas Schatzl wrote: > Hi all, > > This pull request contains a backport of commit [19255084](https://github.com/openjdk/jdk/commit/1925508425cf1b2d46173754077a588290253430) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Schatzl on 16 Aug 2023 and was reviewed by Albert Mingkun Yang and Ivan Walulya. > > Thanks! Marked as reviewed by ayang (no project role). ------------- PR Review: https://git.openjdk.org/jdk21u/pull/68#pullrequestreview-1584417051 From tschatzl at openjdk.org Fri Aug 18 11:47:38 2023 From: tschatzl at openjdk.org (Thomas Schatzl) Date: Fri, 18 Aug 2023 11:47:38 GMT Subject: [jdk21u] RFR: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp In-Reply-To: <6AH-4flPOH5C-I57pHWljilec5ul2bPBzRs2A6Va9fY=.04e0612d-d3cf-4483-977f-cf53b397b22a@github.com> References: <6AH-4flPOH5C-I57pHWljilec5ul2bPBzRs2A6Va9fY=.04e0612d-d3cf-4483-977f-cf53b397b22a@github.com> Message-ID: On Fri, 18 Aug 2023 11:43:09 GMT, Albert Mingkun Yang wrote: >> Hi all, >> >> This pull request contains a backport of commit [19255084](https://github.com/openjdk/jdk/commit/1925508425cf1b2d46173754077a588290253430) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Thomas Schatzl on 16 Aug 2023 and was reviewed by Albert Mingkun Yang and Ivan Walulya. >> >> Thanks! > > Marked as reviewed by ayang (no project role). Thanks @albertnetymk for your review ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/68#issuecomment-1683796819 From tschatzl at openjdk.org Fri Aug 18 11:47:39 2023 From: tschatzl at openjdk.org (Thomas Schatzl) Date: Fri, 18 Aug 2023 11:47:39 GMT Subject: [jdk21u] Integrated: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 07:29:31 GMT, Thomas Schatzl wrote: > Hi all, > > This pull request contains a backport of commit [19255084](https://github.com/openjdk/jdk/commit/1925508425cf1b2d46173754077a588290253430) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Schatzl on 16 Aug 2023 and was reviewed by Albert Mingkun Yang and Ivan Walulya. > > Thanks! This pull request has now been integrated. Changeset: be077e06 Author: Thomas Schatzl URL: https://git.openjdk.org/jdk21u/commit/be077e0667bfd046862aa7994a61fe36356c9afe Stats: 3 lines in 2 files changed: 2 ins; 0 del; 1 mod 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp Reviewed-by: ayang Backport-of: 1925508425cf1b2d46173754077a588290253430 ------------- PR: https://git.openjdk.org/jdk21u/pull/68 From serb at openjdk.org Fri Aug 18 15:57:33 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 18 Aug 2023 15:57:33 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3] In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 06:25:02 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1670#pullrequestreview-1584825351 From andrew at openjdk.org Fri Aug 18 16:20:38 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 16:20:38 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v2] In-Reply-To: <0f-6nu4wItS4fp8nyGgOV32Z61zRoWVbxmX7Fx2n-1c=.08d93651-2d6b-479e-983f-2f080b78d5ae@github.com> References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> <0f-6nu4wItS4fp8nyGgOV32Z61zRoWVbxmX7Fx2n-1c=.08d93651-2d6b-479e-983f-2f080b78d5ae@github.com> Message-ID: <-sUdcz3URWSi9v5s9bP4Gz4BOcPVPVSNhN-ogw2F4AQ=.1bc742d6-4269-418d-80ea-f736106d7f66@github.com> On Fri, 18 Aug 2023 04:21:34 GMT, Dan Lutker wrote: >> Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. >> >> >> bash ./configure --with-jtreg=jtreg-7.3+1 >> make images >> make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" >> >> >> All tests pass. > > Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8314552: Fix javadoc tests to work with jtreg 7 Done: https://github.com/openjdk/jdk17u-dev/pull/1673 Note that this would probably be resolved by merging with jdk17u-dev/master alone, as I did first (the versions were bumped after 1595 was made), but you may as well just make this dependent on 1673 now. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1672#issuecomment-1684143904 From andrew at openjdk.org Fri Aug 18 16:23:28 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 16:23:28 GMT Subject: [jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only Message-ID: GHA regularly breaks because we specify a very explicit GCC version, even down to the release versioning of the Ubuntu package. Rather than bumping this yet again like https://github.com/openjdk/jdk17u/commit/260f28761a87553fd634615df5ba3db5b76ae692, this PR suggests dropping the specific version as we did some time ago in 8u and I've also proposed to fix the same breakage in 11u (https://github.com/openjdk/jdk11u-dev/pull/2087). The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by recent GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. This is based on https://github.com/openjdk/jdk17u-dev/pull/1595 to allow https://github.com/openjdk/jdk17u-dev/pull/1672 to proceed. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/1595 Commit messages: - Backport 62defc3dfc4b9ba5adfe3189f34fe8b3f59b94a0 - Merge remote-tracking branch 'jdk17u-dev/master' into JDK-8284772 - 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer - 8313402: C1: Incorrect LoadIndexed value numbering - 8294941: GHA: Cut down cross-compilation sysroots - 8294956: GHA: qemu-debootstrap is deprecated, use the regular one - 8299330: Minor improvements in MSYS2 Workflow handling - 8294149: JMH 1.34 and later requires jopt-simple 5.0.4 - 8304353: Add lib-test tier1 testing in GHA - 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails - ... and 71 more: https://git.openjdk.org/jdk17u-dev/compare/7ad622dd...4e51a975 Changes: https://git.openjdk.org/jdk17u-dev/pull/1673/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1673&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284772 Stats: 41524 lines in 867 files changed: 14767 ins; 14022 del; 12735 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1673.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1673/head:pull/1673 PR: https://git.openjdk.org/jdk17u-dev/pull/1673 From btaylor at openjdk.org Fri Aug 18 16:25:37 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 18 Aug 2023 16:25:37 GMT Subject: [jdk17u-dev] Integrated: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:16:28 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass This pull request has now been integrated. Changeset: 41cadb7a Author: Ben Taylor Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk17u-dev/commit/41cadb7ab7bf1c77dc5222ab0f9a8e8dd17cfacf Stats: 999 lines in 4 files changed: 986 ins; 1 del; 12 mod 8313765: Invalid CEN header (invalid zip64 extra data field size) Reviewed-by: andrew, serb Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1670 From andrew at openjdk.org Fri Aug 18 16:30:45 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 16:30:45 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3] In-Reply-To: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> References: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> Message-ID: On Fri, 18 Aug 2023 06:23:18 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java Looks good to me. Nice that we can get rid of the need to wrap `GetBooleanAction` with `AccessController.doPrivileged` thanks to the switch to `GetPropertyAction` and `privilegedGetProperty`. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2084#pullrequestreview-1584872767 From andrew at openjdk.org Fri Aug 18 16:34:38 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 16:34:38 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3] In-Reply-To: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> References: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> Message-ID: On Fri, 18 Aug 2023 06:23:18 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java I imagine the GHA change will only be picked up when the fix goes into `jdk11u-dev/master` , unless the branch itself is actually rebased on top of pr/2084 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1684161008 From ogillespie at openjdk.org Fri Aug 18 16:38:00 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Fri, 18 Aug 2023 16:38:00 GMT Subject: [jdk17u-dev] RFR: 8313678: SymbolTable can leak Symbols during cleanup Message-ID: Backporting fix for symbol table leak from https://bugs.openjdk.org/browse/JDK-8313678. Not totally clean: * places where 17 uses NULL versus nullptr in tip, trivial fix * symbolTable uses `Symbol**` in 17 instead of `Symbol*`, also easy fix * dictionary.cpp is not a concurrent hash table in 17 (missing 8292680), so no need to modify it * finalizerService, g1CardSet, DynamicSharedSymbols test don't exist in 17 ------------- Commit messages: - Backport 4b2703ad39f8160264eb30c797824cc93a6b56e2 Changes: https://git.openjdk.org/jdk17u-dev/pull/1674/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1674&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313678 Stats: 66 lines in 7 files changed: 43 ins; 12 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1674.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1674/head:pull/1674 PR: https://git.openjdk.org/jdk17u-dev/pull/1674 From btaylor at openjdk.org Fri Aug 18 16:43:40 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 18 Aug 2023 16:43:40 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3] In-Reply-To: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> References: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> Message-ID: On Fri, 18 Aug 2023 06:23:18 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java Would you like me to do that? Not sure if that will complicate the merge ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1684170479 From simonis at openjdk.org Fri Aug 18 16:44:43 2023 From: simonis at openjdk.org (Volker Simonis) Date: Fri, 18 Aug 2023 16:44:43 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 18:49:32 GMT, Andrew John Hughes wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> >> All tests in `test/jdk/java/util/zip` pass > > Ah, I did wonder why the dependent fixes had been backported and not the update. I'll have a look at those PRs. It would be good to unblock this both for 11u & 17u. Thanks @gnu-andrew for pushing this. Should we create a JBS issue for bumping the version to jdk-17.0.8.1 and prepare a PR for or do you want to take care of it? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#issuecomment-1684171249 From simonis at openjdk.org Fri Aug 18 16:52:39 2023 From: simonis at openjdk.org (Volker Simonis) Date: Fri, 18 Aug 2023 16:52:39 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3] In-Reply-To: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> References: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> Message-ID: On Fri, 18 Aug 2023 06:23:18 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java Wouldn't it be enough to push https://github.com/openjdk/jdk11u-dev/pull/2087? This PR depends on #2087 so once that is pushed it should be easy to merge it into this PR. Or am I missing something? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1684180375 From duke at openjdk.org Fri Aug 18 17:05:00 2023 From: duke at openjdk.org (Dan Lutker) Date: Fri, 18 Aug 2023 17:05:00 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v3] In-Reply-To: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: > Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. > > > bash ./configure --with-jtreg=jtreg-7.3+1 > make images > make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" > > > All tests pass. Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8314552: Fix javadoc tests to work with jtreg 7 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/1672/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1672&range=02 Stats: 18 lines in 6 files changed: 6 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1672.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1672/head:pull/1672 PR: https://git.openjdk.org/jdk17u-dev/pull/1672 From duke at openjdk.org Fri Aug 18 17:05:00 2023 From: duke at openjdk.org (Dan Lutker) Date: Fri, 18 Aug 2023 17:05:00 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v2] In-Reply-To: <0f-6nu4wItS4fp8nyGgOV32Z61zRoWVbxmX7Fx2n-1c=.08d93651-2d6b-479e-983f-2f080b78d5ae@github.com> References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> <0f-6nu4wItS4fp8nyGgOV32Z61zRoWVbxmX7Fx2n-1c=.08d93651-2d6b-479e-983f-2f080b78d5ae@github.com> Message-ID: <8Y5h3TRuo2rKnKX4sTXJJBnzX_JwY_oBAN5mdmXKYiw=.a8aadc10-8f5f-4a1f-8b03-91def31c1460@github.com> On Fri, 18 Aug 2023 04:21:34 GMT, Dan Lutker wrote: >> Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. >> >> >> bash ./configure --with-jtreg=jtreg-7.3+1 >> make images >> make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" >> >> >> All tests pass. > > Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. Updated the target, let's see how this goes. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1672#issuecomment-1684192954 From phh at openjdk.org Fri Aug 18 17:29:39 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 18 Aug 2023 17:29:39 GMT Subject: [jdk17u-dev] RFR: 8313678: SymbolTable can leak Symbols during cleanup In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 16:31:51 GMT, Oli Gillespie wrote: > Backporting fix for symbol table leak from https://bugs.openjdk.org/browse/JDK-8313678. > > Not totally clean: > > * places where 17 uses NULL versus nullptr in tip, trivial fix > * symbolTable uses `Symbol**` in 17 instead of `Symbol*`, also easy fix > * dictionary.cpp is not a concurrent hash table in 17 (missing 8292680), so no need to modify it > * finalizerService, g1CardSet, DynamicSharedSymbols test don't exist in 17 Please file a 21u backport PR to go with this one. Have you done testing other than GHA? ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1674#pullrequestreview-1584948130 From andrew at openjdk.org Fri Aug 18 17:35:43 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 17:35:43 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3] In-Reply-To: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> References: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> Message-ID: On Fri, 18 Aug 2023 06:23:18 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java > Wouldn't it be enough to push #2087? This PR depends on #2087 so once that is pushed it should be easy to merge it into this PR. Or am I missing something? Yes, that's what I was thinking. I didn't realise @GoeLin was back and had approved it until just now. I've integrated it, so we should be able to just rebase this onto `jdk11u-dev/master`. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1684224637 From andrew at openjdk.org Fri Aug 18 17:35:45 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 17:35:45 GMT Subject: [jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2] In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 00:19:57 GMT, Andrew John Hughes wrote: >> GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available. >> >> Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. >> >> Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. > > Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: > > Fix specific version usage in cross compilation I see `jdk11u-fix-yes`. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2087#issuecomment-1684223799 From andrew at openjdk.org Fri Aug 18 17:35:46 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 17:35:46 GMT Subject: [jdk11u-dev] Integrated: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 19:39:59 GMT, Andrew John Hughes wrote: > GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available. > > Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. > > Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. This pull request has now been integrated. Changeset: ee128b2f Author: Andrew John Hughes URL: https://git.openjdk.org/jdk11u-dev/commit/ee128b2f6c24410ad04cf9bb662fc0423b919427 Stats: 17 lines in 2 files changed: 0 ins; 8 del; 9 mod 8284772: GHA: Use GCC Major Version Dependencies Only Reviewed-by: serb, simonis Backport-of: 62defc3dfc4b9ba5adfe3189f34fe8b3f59b94a0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2087 From gnu.andrew at redhat.com Fri Aug 18 17:40:57 2023 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Fri, 18 Aug 2023 18:40:57 +0100 Subject: Downporting JDK-8313765 to jdk11u and jdk17u and respinning 11.0.20 and 17.0.8 In-Reply-To: <33fa9d7e-ce9e-4936-b250-cb1b254c282c@amazon.com> References: <33fa9d7e-ce9e-4936-b250-cb1b254c282c@amazon.com> Message-ID: On 14:50 Thu 17 Aug , Sergey Bylokhov wrote: > Nobody mention respin of JDK 20u: > https://github.com/openjdk/jdk20u/pull/87 > Does anybody plan to do it? > > On 8/17/23 10:31, Andrew Hughes wrote: > > Yes, I've been tracking this since it was discussed in the vulnerability > > group. I agree it is preferable to have a fix rather than resorting to > > turning off a CVE fix. > > > > My main worry is not about backporting the fix, but in whether we can > > squeeze in a respin. I'm glad to see the proposed fix has finally been > > posted publicly, reviewed and integrated as of yesterday. It seems > > to have taken a long time to get to that stage from the original VG > > discussion. > > > > When we've done interim releases in the past, they have been within a > > few weeks of the original release. With this release, we are already > > at the point where we enter rampdown for the next release in < 2 > > weeks. > > > > I think we can still manage an interim release this time, but it > > needs to happen within the next week, before people start to focus > > on testing and adding security fixes to the October update. > > > > I'll go and review the 11u & 17u backports now. Note that there > > are currently GHA failures with both, one down to the GCC versioning > > we removed in 8u with https://bugs.openjdk.org/browse/JDK-8284772 > > -- > Best regards, Sergey. > We're not maintainers, Oracle are. I guess their efforts are now focused on 21. They are aware of this and have apparently added it to 17.0.10-oracle and 11.0.22-oracle already, and I see a request for 21 too [0] [0] https://bugs.openjdk.org/browse/JDK-8313765?focusedCommentId=14604862&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14604862 Best regards, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Fri Aug 18 17:52:44 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 18 Aug 2023 17:52:44 GMT Subject: [jdk17u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3] In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 06:25:02 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java I've just replied to @GoeLin's e-mail about this. I think it's probably easiest to let him handle the release side of this as I believe he has the direct push access necessary to create branches. We'll also need to request the new version from ops. That should happen on Monday. I think the best way to handle it is likely a 17.0.8.1 branch from openjdk/jdk17u and then merge that back into both openjdk/jdk17u/master and openjdk/jdk17u-dev/master. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#issuecomment-1684241937 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1670#issuecomment-1684242884 From serb at openjdk.org Fri Aug 18 17:53:37 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 18 Aug 2023 17:53:37 GMT Subject: [jdk20u] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: <8kUgRlkY6Y4-R7k7ZbCIYy0AU4vUw9NKuAHeKAWkpuk=.34fda669-edc2-408e-b9cb-a6578ad5073f@github.com> References: <8kUgRlkY6Y4-R7k7ZbCIYy0AU4vUw9NKuAHeKAWkpuk=.34fda669-edc2-408e-b9cb-a6578ad5073f@github.com> Message-ID: On Thu, 17 Aug 2023 02:16:29 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass But this is still the source code for jdk20u, and we can have a commits here even if the openjdk20u will not release the bundles, other vendors can do that. ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/87#issuecomment-1684242817 From rschmelter at openjdk.org Fri Aug 18 18:01:35 2023 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Fri, 18 Aug 2023 18:01:35 GMT Subject: [jdk17u-dev] Integrated: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64 In-Reply-To: References: Message-ID: On Tue, 18 Jul 2023 08:06:42 GMT, Ralf Schmelter wrote: > Hi all, > > This pull request contains a backport of commit [5551cb66](https://github.com/openjdk/jdk/commit/5551cb66ba58cadce7291a95c5af662ade2cb7b8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ralf Schmelter on 22 Nov 2022 and was reviewed by Matthias Baesken and Thomas Stuefe. > > It just fixes the metadata of an JFR event. > > Thanks! This pull request has now been integrated. Changeset: 4dca60e4 Author: Ralf Schmelter URL: https://git.openjdk.org/jdk17u-dev/commit/4dca60e43a002a5664a465e28049f0f34834cbf1 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64 Reviewed-by: mdoerr Backport-of: 5551cb66ba58cadce7291a95c5af662ade2cb7b8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1594 From btaylor at openjdk.org Fri Aug 18 18:13:58 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 18 Aug 2023 18:13:58 GMT Subject: [jdk21u] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) Message-ID: Backport is clean, all tests in test/jdk/java/util/zip pass. ------------- Commit messages: - Backport 13f6450e2e70df4df8bd882def837fbd5bef1524 Changes: https://git.openjdk.org/jdk21u/pull/72/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=72&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313765 Stats: 1004 lines in 4 files changed: 986 ins; 4 del; 14 mod Patch: https://git.openjdk.org/jdk21u/pull/72.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/72/head:pull/72 PR: https://git.openjdk.org/jdk21u/pull/72 From rschmelter at openjdk.org Fri Aug 18 18:21:06 2023 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Fri, 18 Aug 2023 18:21:06 GMT Subject: [jdk17u-dev] RFR: 8297142: jdk/jfr/event/runtime/TestShutdown.java fails on Linux ppc64le and Linux aarch64 Message-ID: <6GHqxBJ9AwDQgHHX_pRF15395BLIi05e1VMAfO6f0nk=.08e3a6fd-918c-4963-b211-6b279eef946c@github.com> This fixes a test which rarely fails on aarch64 and ppc64. ------------- Commit messages: - Backport bde0e35ded82ab5e95452dc8da36c63e084536a2 Changes: https://git.openjdk.org/jdk17u-dev/pull/1675/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1675&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297142 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1675.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1675/head:pull/1675 PR: https://git.openjdk.org/jdk17u-dev/pull/1675 From duke at openjdk.org Fri Aug 18 18:50:31 2023 From: duke at openjdk.org (duke) Date: Fri, 18 Aug 2023 18:50:31 GMT Subject: [jdk11u-dev] Withdrawn: 8310451: CMS MxBean reports zero memory usage In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 13:28:55 GMT, Zhengyu Gu wrote: > CMS GC notification sometimes reports zero memory usages, because background sweep GC overlaps regular GC, that results consecutive gc end calls. The first gc end call pushes correct GC stats info, then reset current GC stats info. When the second gc end call arrives, there is no data to report `(gc index == 0)`, but it pushes notification anyway. > > The patch avoids to push the second notification if there is no data available. > > Current jdk head has the same code, but none of other GCs returns `gc index == 0`, except CMS. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1986 From btaylor at openjdk.org Fri Aug 18 18:53:33 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 18 Aug 2023 18:53:33 GMT Subject: [jdk11u-dev] Integrated: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer In-Reply-To: References: Message-ID: On Tue, 15 Aug 2023 21:49:14 GMT, Ben Taylor wrote: > Backport [8313796](https://bugs.openjdk.org/browse/JDK-8313796) to resolve a hotspot crash. Passes jtreg tier 1-4 tests. > > This change required the following modifications: > - Remove riscv code, as the riscv port is not present in jdk 11 > - Replace `nullptr` with `NULL` to accommodate older C++ standards/compilers This pull request has now been integrated. Changeset: 3c9dc44b Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/3c9dc44bff76757a720ce8cb5321d274b23238be Stats: 15 lines in 6 files changed: 11 ins; 0 del; 4 mod 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Reviewed-by: phh Backport-of: 0e2c72d7a5206b7173af5bf69e21d21ea276bd94 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2079 From duke at openjdk.org Fri Aug 18 18:57:34 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Fri, 18 Aug 2023 18:57:34 GMT Subject: [jdk11u-dev] Integrated: 8302161: Upgrade jQuery UI to version 1.13.2 In-Reply-To: References: Message-ID: On Fri, 4 Aug 2023 05:21:05 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8302161 for jdk11u. > This is clean backport. > Also, this backport contains JDK-8293180. > > All jdk/javadoc tests are passed. This pull request has now been integrated. Changeset: a7dab960 Author: Nagata, Haruhito Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/a7dab960a4e3b9709f0668b7b06eb2513c3bef3a Stats: 15 lines in 5 files changed: 0 ins; 0 del; 15 mod 8302161: Upgrade jQuery UI to version 1.13.2 8293180: JQuery UI license file not updated Reviewed-by: phh Backport-of: 404d5bddb9177c3bda03db81e14209e372a00027 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2064 From phh at openjdk.org Fri Aug 18 19:04:39 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 18 Aug 2023 19:04:39 GMT Subject: [jdk11u-dev] RFR: 8305733: Pattern.CASE_INSENSITIVE does not take effect in jdk11 [v8] In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 02:16:13 GMT, Korov wrote: >> fix [JDK-8305733](https://bugs.openjdk.org/browse/JDK-8305733) > > Korov has updated the pull request incrementally with one additional commit since the last revision: > > Update RegExTest.java @Korov, what testing have you done, and what do you estimate the risk is? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2062#issuecomment-1684324006 From serb at openjdk.org Fri Aug 18 19:11:37 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 18 Aug 2023 19:11:37 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v3] In-Reply-To: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> References: <6ihxsQ0IiN9sn6be40-vY3pU7AmpA5oLuSLhqLnvkjc=.93d8bfe7-4199-47bc-9ac8-9cd394a2c381@github.com> Message-ID: On Fri, 18 Aug 2023 06:23:18 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request incrementally with one additional commit since the last revision: > > Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2084#pullrequestreview-1585085972 From btaylor at openjdk.org Fri Aug 18 19:34:17 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 18 Aug 2023 19:34:17 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v4] In-Reply-To: References: Message-ID: <_8DGMS3cCfAMC-Lb3TqtDOrSvglDBPunsmpZNz5v0kA=.f90ecbe8-0907-4261-863f-af75df591e37@github.com> > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 > > All tests in `test/jdk/java/util/zip` pass Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into 8313765 - Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java - Remove junit dependency in ReadNonStandardExtraHeadersTest.java to run with jtreg 6 - 8313765: Invalid CEN header (invalid zip64 extra data field size) Reviewed-by: simonis, alanb, coffeys ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2084/files - new: https://git.openjdk.org/jdk11u-dev/pull/2084/files/014dbf6a..dd7538f7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2084&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2084&range=02-03 Stats: 30555 lines in 347 files changed: 9325 ins; 10833 del; 10397 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2084.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2084/head:pull/2084 PR: https://git.openjdk.org/jdk11u-dev/pull/2084 From serb at openjdk.org Fri Aug 18 19:43:38 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 18 Aug 2023 19:43:38 GMT Subject: [jdk11u-dev] RFR: 8312972: Bump update version for OpenJDK: jdk-11.0.22 In-Reply-To: References: Message-ID: On Tue, 25 Jul 2023 15:05:43 GMT, Goetz Lindenmaier wrote: > The required version bump, to be pushed after tag 11.0.22+0. Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2056#pullrequestreview-1585124432 From apangin at openjdk.org Fri Aug 18 21:26:18 2023 From: apangin at openjdk.org (Andrei Pangin) Date: Fri, 18 Aug 2023 21:26:18 GMT Subject: [jdk11u-dev] RFR: 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly Message-ID: <_fb5LpoXaOQLGklnwPfOsrl1iwoCsKWZzRL8P8fBoLU=.c49d71bd-6267-447a-932d-2c5123894405@github.com> Please consider the proposed backport of the fix for JDK-8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly. Customers complain about unexpected `java.net.SocketTimeoutException` when profiling an application running on JDK 11.0.20. The original patch applies cleanly with a trivial adjustment in `make/common/TestFilesCompilation.gmk`, where `$$` has been replaced with `$`. ------------- Commit messages: - 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly Changes: https://git.openjdk.org/jdk11u-dev/pull/2089/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2089&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8237858 Stats: 486 lines in 8 files changed: 462 ins; 6 del; 18 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2089.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2089/head:pull/2089 PR: https://git.openjdk.org/jdk11u-dev/pull/2089 From stuefe at openjdk.org Sat Aug 19 06:40:28 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sat, 19 Aug 2023 06:40:28 GMT Subject: [jdk11u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue Message-ID: Unclean composite backport to fix JDK-8312182 - "THPs cause huge RSS due to thread start timing issue" (https://bugs.openjdk.org/browse/JDK-8312182) Problem: On a machine with transparent huge pages (THP) unconditionally enabled (/sys/kernel/mm/transparent_hugepage/enabled = "always"), the JVM may show a huge memory footprint (RSS) and degraded thread start performance. The following factors make the problem more severe and more likely: - thread stack size of 2M (on arm64 or x64) or larger - many threads, or high thread creation churn - a slow or overloaded machine (since part of the problem is timing-dependent) For a detailed discussion of the underlying problem, please see https://github.com/openjdk/jdk/pull/14919. ---------------- In jdk Head, the issue got fixed with a sequence of patches: - [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) "Make thread stacks not use huge pages" - [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) "THPs cause huge RSS due to thread start timing" However, JDK-8312182 itself needed one preparatory fix: - [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) "Fix THP detection on Linux" and then we had several corner-case test problems which are fixed with: - [JDK-8312394](https://bugs.openjdk.org/browse/JDK-8312394) "[linux] SIGSEGV if kernel was built without hugepage support" - [JDK-8312620](https://bugs.openjdk.org/browse/JDK-8312620) "WSL Linux build crashes after JDK-8310233" - [JDK-8314139](https://bugs.openjdk.org/browse/JDK-8314139) "TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores" and finally, we decided to rename the switch that allows to switch off the THP mitigation with a final patch: - [JDK-8312585](https://bugs.openjdk.org/browse/JDK-8312585) "Rename DisableTHPStackMitigation flag to THPStackMitigation" Instead of downporting these 7 patches verbatim, I prepared a composite patch containing only the necessary mitigation and mitigation tests. This patch does: - make sure that all thread stacks have at least one glibc guard page to prevent clustering of adjacent thread stacks into one VMA - change the default size of stacks to be not aligned to 2MB to prevent intra-stack THPs from forming The patch needs some infrastructure, but I downported only the necessary parts: the helper class "HugePages", which is used in head to scan the operating system for information about THP settings. I only included the parts to do with THPs and left the rest out. The patch also includes a regression test. --------------------- Testing: I manually tested the JVM on Linux x64 with THP=always: Without the patch (-Xmx1g -Xms1g -XX:+AlwaysPreTouch -Xss2m, 10000 threads started), I see slow thread startup and *11 GB - 14 GB* of RSS. The patched version comes up a lot faster and only shows *1.3* GB of RSS. GHAs: unfortunately broken due to infrastructure issues. ------------- Commit messages: - Backport 84b325b844c08809448a9c073a11443d9e3c3f8e Changes: https://git.openjdk.org/jdk11u-dev/pull/2086/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2086&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312182 Stats: 741 lines in 7 files changed: 737 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2086.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2086/head:pull/2086 PR: https://git.openjdk.org/jdk11u-dev/pull/2086 From dzhang at openjdk.org Sun Aug 20 05:19:29 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Sun, 20 Aug 2023 05:19:29 GMT Subject: [jdk17u-dev] RFR: 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V [v3] In-Reply-To: <1i9XCgTGbaOslTQ6NZLrITApyfADvl6a2H_zQALmrdo=.fed0a987-4846-4214-adea-63243349d840@github.com> References: <1i9XCgTGbaOslTQ6NZLrITApyfADvl6a2H_zQALmrdo=.fed0a987-4846-4214-adea-63243349d840@github.com> Message-ID: On Fri, 18 Aug 2023 03:02:57 GMT, Fei Yang wrote: >> Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into backport-8309254 >> - Merge remote-tracking branch 'origin/master' into backport-8309254 >> - 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V > > Marked as reviewed by fyang (Reviewer). @RealFYang Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1567#issuecomment-1685179303 From dzhang at openjdk.org Sun Aug 20 07:08:40 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Sun, 20 Aug 2023 07:08:40 GMT Subject: [jdk17u-dev] Integrated: 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V In-Reply-To: References: Message-ID: On Tue, 11 Jul 2023 09:06:38 GMT, Dingli Zhang wrote: > I would like to backport [JDK-8309254](https://bugs.openjdk.org/browse/JDK-8309254). > The backport is not clean because 17u has no [JDK-8302908](https://bugs.openjdk.org/browse/JDK-8302908), which use v0 as mask register. > The test `test/hotspot/jtreg/compiler/intrinsics/string/TestEncodeIntrinsics.java` passed and command log with "-XX:+PrintOptoAssembly" output is similar to the mainline: > > ... > 240 Encode ISO array R12, R11, R13 -> R10 # KILL R12, R11, R13, R28, V1-V3 > ... > 0118 Encode ASCII array R12, R11, R13 -> R10 # KILL R12, R11, R13, R25, V1-V3 > ... This pull request has now been integrated. Changeset: 0fa04fe5 Author: Dingli Zhang Committer: Fei Yang URL: https://git.openjdk.org/jdk17u-dev/commit/0fa04fe58414a278666669662845553c7bda4e1e Stats: 47 lines in 4 files changed: 30 ins; 0 del; 17 mod 8309254: Implement fast-path for ASCII-compatible CharsetEncoders on RISC-V Reviewed-by: fyang Backport-of: 61bb014a8692305c705a4cf0361e319275c35ca3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1567 From duke at openjdk.org Sun Aug 20 07:24:39 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Sun, 20 Aug 2023 07:24:39 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v4] In-Reply-To: References: Message-ID: <1jKRHWTn9df3PjPXFNScNBvccVYDFEg_EoVmZoD8KX8=.b55d1ee2-6567-4a59-a0ac-570635dc29e0@github.com> On Tue, 15 Aug 2023 07:05:08 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into 8313815 > - Merge master > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Hello everyone, Thank you for your help with this issue. I tested all serviceability area tests. And I tested a specific test to verify the fix, which I run the test on: English Windows Japanese Windows RHEL LANG/LC_ALL= RHEL LANG/LC_ALL=C RHEL LANG/LC_ALL=en_US.UTF-8 RHEL LNAG/LC_ALL=ja_JP.UTF-8 Is there anything left for me to do to get the fix integrated? I would like to fix this problem because it is very inconvenient for customers to not be able to read error messages in the Japanese Windows environment. Thanks, Kimura Yukihiro ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1685208815 From goetz at openjdk.org Sun Aug 20 08:19:36 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 20 Aug 2023 08:19:36 GMT Subject: [jdk17u-dev] RFR: 8168469: Memory leak in JceSecurity In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 14:03:59 GMT, Sergey Chernyshev wrote: > The patch did not apply cleanly: updated the copyright header. > > All tests in javax/crypto, sun/security, com/sun/crypto pass. The new test fails before the fix and passes after the fix. Please enable github actions for this repo. Please label again if the change is ready, i.e. tested and reviewed. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1671#issuecomment-1685221636 From goetz at openjdk.org Sun Aug 20 08:23:40 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 20 Aug 2023 08:23:40 GMT Subject: [jdk11u-dev] RFR: 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v2] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Thu, 10 Aug 2023 10:35:28 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > Update full name Please label again once you fixed above issues. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2074#issuecomment-1685222303 From duke at openjdk.org Mon Aug 21 03:16:12 2023 From: duke at openjdk.org (Taizo Kurashige) Date: Mon, 21 Aug 2023 03:16:12 GMT Subject: [jdk11u-dev] RFR: [11u] 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v3] In-Reply-To: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: > I`d like to fix the bug reported in JDK-8314086. > `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. > This is causing compilation failure in ChildAlwaysOnTopTest.java. > After fixing this typo, the test successfully passed. Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: Remove a useless file ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2074/files - new: https://git.openjdk.org/jdk11u-dev/pull/2074/files/4d7fa891..3af0081d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2074&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2074&range=01-02 Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2074.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2074/head:pull/2074 PR: https://git.openjdk.org/jdk11u-dev/pull/2074 From duke at openjdk.org Mon Aug 21 03:18:54 2023 From: duke at openjdk.org (Taizo Kurashige) Date: Mon, 21 Aug 2023 03:18:54 GMT Subject: [jdk11u-dev] RFR: [11u] 8314086: A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v4] In-Reply-To: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: > I`d like to fix the bug reported in JDK-8314086. > `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. > This is causing compilation failure in ChildAlwaysOnTopTest.java. > After fixing this typo, the test successfully passed. Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2074/files - new: https://git.openjdk.org/jdk11u-dev/pull/2074/files/3af0081d..fd5185b7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2074&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2074&range=02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2074.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2074/head:pull/2074 PR: https://git.openjdk.org/jdk11u-dev/pull/2074 From duke at openjdk.org Mon Aug 21 03:27:59 2023 From: duke at openjdk.org (Taizo Kurashige) Date: Mon, 21 Aug 2023 03:27:59 GMT Subject: [jdk11u-dev] RFR: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v4] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Mon, 21 Aug 2023 03:18:54 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > Update full name I'm sorry that I made some mistakes and that I took a long time to deal with them. I removed useless zip file and fixed PR title. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2074#issuecomment-1685567927 From duke at openjdk.org Mon Aug 21 03:27:59 2023 From: duke at openjdk.org (Taizo Kurashige) Date: Mon, 21 Aug 2023 03:27:59 GMT Subject: [jdk11u-dev] RFR: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v5] In-Reply-To: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: > I`d like to fix the bug reported in JDK-8314086. > `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. > This is causing compilation failure in ChildAlwaysOnTopTest.java. > After fixing this typo, the test successfully passed. Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2074/files - new: https://git.openjdk.org/jdk11u-dev/pull/2074/files/fd5185b7..cab11167 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2074&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2074&range=03-04 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2074.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2074/head:pull/2074 PR: https://git.openjdk.org/jdk11u-dev/pull/2074 From schernyshev at openjdk.org Mon Aug 21 08:16:43 2023 From: schernyshev at openjdk.org (Sergey Chernyshev) Date: Mon, 21 Aug 2023 08:16:43 GMT Subject: [jdk17u-dev] RFR: 8168469: Memory leak in JceSecurity In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 14:03:59 GMT, Sergey Chernyshev wrote: > The patch did not apply cleanly: updated the copyright header. > > All tests in javax/crypto, sun/security, com/sun/crypto pass. The new test fails before the fix and passes after the fix. Thank you Goetz, I enabled the github actions and reran the tests manually. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1671#issuecomment-1685863708 From ogillespie at openjdk.org Mon Aug 21 08:35:30 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Mon, 21 Aug 2023 08:35:30 GMT Subject: [jdk17u-dev] RFR: 8313678: SymbolTable can leak Symbols during cleanup In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 16:31:51 GMT, Oli Gillespie wrote: > Backporting fix for symbol table leak from https://bugs.openjdk.org/browse/JDK-8313678. > > Not totally clean: > > * places where 17 uses NULL versus nullptr in tip, trivial fix > * symbolTable uses `Symbol**` in 17 instead of `Symbol*`, also easy fix > * dictionary.cpp is not a concurrent hash table in 17 (missing 8292680), so no need to modify it > * finalizerService, g1CardSet, DynamicSharedSymbols test don't exist in 17 I tested that the new test fails without the patch, and passes with it. Nothing else. Here's the 21 backport https://github.com/openjdk/jdk21u/pull/73 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1674#issuecomment-1685891154 From ogillespie at openjdk.org Mon Aug 21 08:39:49 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Mon, 21 Aug 2023 08:39:49 GMT Subject: [jdk21u] RFR: 8313678: SymbolTable can leak Symbols during cleanup Message-ID: Clean backport for https://bugs.openjdk.org/browse/JDK-8313678. ------------- Commit messages: - Backport 4b2703ad39f8160264eb30c797824cc93a6b56e2 Changes: https://git.openjdk.org/jdk21u/pull/73/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=73&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313678 Stats: 82 lines in 11 files changed: 53 ins; 14 del; 15 mod Patch: https://git.openjdk.org/jdk21u/pull/73.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/73/head:pull/73 PR: https://git.openjdk.org/jdk21u/pull/73 From shade at openjdk.org Mon Aug 21 09:12:30 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:12:30 GMT Subject: [jdk17u-dev] RFR: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 11:11:15 GMT, Aleksey Shipilev wrote: > Clean backport to make the test sensitive to original regression. > > Additional testing: > - [x] macos-aarch64-server-fastdebug; test passes out of box; starts to fail when JDK-8313402 is reverted (sensitivity check) Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1667#issuecomment-1685946496 From shade at openjdk.org Mon Aug 21 09:12:44 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:12:44 GMT Subject: [jdk17u-dev] RFR: 8314118: Update JMH devkit to 1.37 In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 08:42:27 GMT, Aleksey Shipilev wrote: > Clean backport to improve performance testing. Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1666#issuecomment-1685945190 From shade at openjdk.org Mon Aug 21 09:12:44 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:12:44 GMT Subject: [jdk17u-dev] Integrated: 8314118: Update JMH devkit to 1.37 In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 08:42:27 GMT, Aleksey Shipilev wrote: > Clean backport to improve performance testing. This pull request has now been integrated. Changeset: 4087dbb6 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/4087dbb67803761c21b312e3f68f35c5b883b6cf Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8314118: Update JMH devkit to 1.37 Backport-of: 06aa3c5628e749188238dda3d41c776a5a2f7c81 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1666 From shade at openjdk.org Mon Aug 21 09:14:39 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:14:39 GMT Subject: [jdk17u-dev] RFR: 8314262: GHA: Cut down cross-compilation sysroots deeper In-Reply-To: <1MCSCQaHdNGBg2fEdq57iaRARE7_HXgu8ms3fQOjBB0=.d36eadca-113f-4a17-a46c-fd362152ed8a@github.com> References: <1MCSCQaHdNGBg2fEdq57iaRARE7_HXgu8ms3fQOjBB0=.d36eadca-113f-4a17-a46c-fd362152ed8a@github.com> Message-ID: On Wed, 16 Aug 2023 11:18:54 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA overheads. > > Additional testing: > - [x] GHA GHA testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1668#issuecomment-1685947938 From shade at openjdk.org Mon Aug 21 09:14:39 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:14:39 GMT Subject: [jdk17u-dev] Integrated: 8314262: GHA: Cut down cross-compilation sysroots deeper In-Reply-To: <1MCSCQaHdNGBg2fEdq57iaRARE7_HXgu8ms3fQOjBB0=.d36eadca-113f-4a17-a46c-fd362152ed8a@github.com> References: <1MCSCQaHdNGBg2fEdq57iaRARE7_HXgu8ms3fQOjBB0=.d36eadca-113f-4a17-a46c-fd362152ed8a@github.com> Message-ID: <3Qy4JmBWOLmAzfg8vYk0ZL1l1fsVriOwCJPJAMNbyVU=.319b96d9-aff4-42ca-bead-00c7f3e2914c@github.com> On Wed, 16 Aug 2023 11:18:54 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA overheads. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: a6bbaaeb Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/a6bbaaeb208af9010ba80776f9aeffb2e1bc5170 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8314262: GHA: Cut down cross-compilation sysroots deeper Backport-of: 38687f1a3eb7d1c2e8aa43b85509ab7999fe0e40 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1668 From shade at openjdk.org Mon Aug 21 09:15:44 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:15:44 GMT Subject: [jdk17u-dev] Integrated: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 11:11:15 GMT, Aleksey Shipilev wrote: > Clean backport to make the test sensitive to original regression. > > Additional testing: > - [x] macos-aarch64-server-fastdebug; test passes out of box; starts to fail when JDK-8313402 is reverted (sensitivity check) This pull request has now been integrated. Changeset: 4dac2bd3 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/4dac2bd3be6b59de02a40b2f623cdd1101d66000 Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly Backport-of: 4b192a8dc37297f0746c0c68322e0168d9f47771 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1667 From shade at openjdk.org Mon Aug 21 09:17:43 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:17:43 GMT Subject: [jdk17u-dev] RFR: 8284273: Early crashes in os::print_context on AArch64 In-Reply-To: <6lUr3kX1tFsBaHBbSAh8peb9QYIxrkDZgqmYt5M2zrg=.918ed60f-6991-4256-a593-899c1dfa5b71@github.com> References: <6lUr3kX1tFsBaHBbSAh8peb9QYIxrkDZgqmYt5M2zrg=.918ed60f-6991-4256-a593-899c1dfa5b71@github.com> Message-ID: On Wed, 16 Aug 2023 13:26:39 GMT, Aleksey Shipilev wrote: > Clean backport to improve the resilience of crash reporting, and provide the grounds for other relevant backports in this area. > > Additional testing: > - [x] macos AArch64 fastdebug, `runtime/ErrorHandling` > - [x] Linux AArch64 fastdebug, `tier1 tier2 tier3` Reviews are here. Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1669#issuecomment-1685950340 From shade at openjdk.org Mon Aug 21 09:17:43 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:17:43 GMT Subject: [jdk17u-dev] Integrated: 8284273: Early crashes in os::print_context on AArch64 In-Reply-To: <6lUr3kX1tFsBaHBbSAh8peb9QYIxrkDZgqmYt5M2zrg=.918ed60f-6991-4256-a593-899c1dfa5b71@github.com> References: <6lUr3kX1tFsBaHBbSAh8peb9QYIxrkDZgqmYt5M2zrg=.918ed60f-6991-4256-a593-899c1dfa5b71@github.com> Message-ID: On Wed, 16 Aug 2023 13:26:39 GMT, Aleksey Shipilev wrote: > Clean backport to improve the resilience of crash reporting, and provide the grounds for other relevant backports in this area. > > Additional testing: > - [x] macos AArch64 fastdebug, `runtime/ErrorHandling` > - [x] Linux AArch64 fastdebug, `tier1 tier2 tier3` This pull request has now been integrated. Changeset: d7259618 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/d72596187614331aa5b0b10ea3dde195aa088dbe Stats: 124 lines in 15 files changed: 95 ins; 11 del; 18 mod 8284273: Early crashes in os::print_context on AArch64 Reviewed-by: stuefe Backport-of: 83cec4b6cc25b9b0db751bbe873444259cdcb21c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1669 From shade at openjdk.org Mon Aug 21 09:19:32 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:19:32 GMT Subject: [jdk17u-dev] RFR: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 10:49:42 GMT, Aleksey Shipilev wrote: > Unclean backport to fix TCP_QUICKACK bug. > > The backport is unclean, because AIX hunks could not be applied. The implementation of extended socket options on AIX went into JDK 21 with [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089). > > Additional testing: > - [x] Linux AArch64 fastdebug, `jdk_net` > - [x] Linux AArch64 fastdebug, `tier1 tier2 tier3` Reviews are here. Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1664#issuecomment-1685953634 From shade at openjdk.org Mon Aug 21 09:19:34 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:19:34 GMT Subject: [jdk17u-dev] Integrated: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 10:49:42 GMT, Aleksey Shipilev wrote: > Unclean backport to fix TCP_QUICKACK bug. > > The backport is unclean, because AIX hunks could not be applied. The implementation of extended socket options on AIX went into JDK 21 with [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089). > > Additional testing: > - [x] Linux AArch64 fastdebug, `jdk_net` > - [x] Linux AArch64 fastdebug, `tier1 tier2 tier3` This pull request has now been integrated. Changeset: 78bbd57d Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/78bbd57d5bee4bd3eec670fab69a35588025d9a1 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level Reviewed-by: phh Backport-of: 56a73a6f0f3d38379cecea1de5eacb751febca95 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1664 From shade at openjdk.org Mon Aug 21 09:40:43 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:40:43 GMT Subject: [jdk21u] RFR: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails Message-ID: Clean backport to fix the test failure with Shenandoah. Additional testing: - [x] Test fails with Shenandoah without the fix, passes with it ------------- Commit messages: - Backport 812f475bc4ea84225e8bbb0b5a677eed0af864dd Changes: https://git.openjdk.org/jdk21u/pull/74/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=74&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314501 Stats: 7 lines in 2 files changed: 1 ins; 3 del; 3 mod Patch: https://git.openjdk.org/jdk21u/pull/74.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/74/head:pull/74 PR: https://git.openjdk.org/jdk21u/pull/74 From shade at openjdk.org Mon Aug 21 09:49:53 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:49:53 GMT Subject: [jdk17u-dev] RFR: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails Message-ID: Clean backport to fix the test failure with Shenandoah. Additional testing: - [x] Test fails with Shenandoah without the fix, passes with it ------------- Commit messages: - Backport 812f475bc4ea84225e8bbb0b5a677eed0af864dd Changes: https://git.openjdk.org/jdk17u-dev/pull/1676/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1676&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314501 Stats: 7 lines in 2 files changed: 1 ins; 3 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1676.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1676/head:pull/1676 PR: https://git.openjdk.org/jdk17u-dev/pull/1676 From shade at openjdk.org Mon Aug 21 09:57:55 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 09:57:55 GMT Subject: [jdk17u-dev] RFR: 8293851: hs_err should print more stack in hex dump Message-ID: Clean backport to improve post-mortem diagnostics, and provide cleaner ground for the subsequent backports in the same area. Addtional testing: - [x] Eye-balling the `hs_err` from artificial crash on MacOS AArch64 - [x] MacOS server aarch64 fastdebug, `runtime/ErrorHandling` ------------- Commit messages: - Backport cbd0688b321ff88a405be4f7929d6862e543ab50 Changes: https://git.openjdk.org/jdk17u-dev/pull/1677/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1677&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293851 Stats: 41 lines in 13 files changed: 7 ins; 12 del; 22 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1677.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1677/head:pull/1677 PR: https://git.openjdk.org/jdk17u-dev/pull/1677 From shade at openjdk.org Mon Aug 21 10:16:33 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 10:16:33 GMT Subject: [jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 16:16:29 GMT, Andrew John Hughes wrote: > GHA regularly breaks because we specify a very explicit GCC version, even down to the release versioning of the Ubuntu package. > > Rather than bumping this yet again like https://github.com/openjdk/jdk17u/commit/260f28761a87553fd634615df5ba3db5b76ae692, this PR suggests dropping the specific version as we did some time ago in 8u and I've also proposed to fix the same breakage in 11u (https://github.com/openjdk/jdk11u-dev/pull/2087). The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. > > Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by recent GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. > > This is based on https://github.com/openjdk/jdk17u-dev/pull/1595 to allow https://github.com/openjdk/jdk17u-dev/pull/1672 to proceed. Nope, not for 17u. While the actual removal of minor GCC version tracking might be okay, it is wrong to keep effectively _forward-porting_ the GHA change from 8u -> 11u -> 17u. You need to do this in mainline, argue the point on minor GCC version removals (in other words, the reversal of [JDK-8256393](https://bugs.openjdk.org/browse/JDK-8256393)), and then argue for backports. Otherwise, you will keep doing this for every subsequent XXu. ------------- Changes requested by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1673#pullrequestreview-1586671811 From fjiang at openjdk.org Mon Aug 21 10:49:41 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Mon, 21 Aug 2023 10:49:41 GMT Subject: [jdk21u] RFR: 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java Message-ID: This fixes the incorrect VMReg encoding in `RISCV64Frame.java` for risc-v. Patch applies clean. ------------- Commit messages: - Backport 5c9162288570a140138a0055cd9c4e88fe40e69d Changes: https://git.openjdk.org/jdk21u/pull/75/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=75&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314117 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/75.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/75/head:pull/75 PR: https://git.openjdk.org/jdk21u/pull/75 From kevinw at openjdk.org Mon Aug 21 10:51:30 2023 From: kevinw at openjdk.org (Kevin Walls) Date: Mon, 21 Aug 2023 10:51:30 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v4] In-Reply-To: References: Message-ID: On Tue, 15 Aug 2023 07:05:08 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into 8313815 > - Merge master > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Yes that sounds good. I think you can /integrate and we can /sponsor if that is needed. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1686094718 From fjiang at openjdk.org Mon Aug 21 10:57:58 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Mon, 21 Aug 2023 10:57:58 GMT Subject: [jdk17u-dev] RFR: 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java Message-ID: This fixes the incorrect VMReg encoding in RISCV64Frame.java for risc-v. Patch applies clean. ------------- Commit messages: - Backport 5c9162288570a140138a0055cd9c4e88fe40e69d Changes: https://git.openjdk.org/jdk17u-dev/pull/1678/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1678&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314117 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1678.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1678/head:pull/1678 PR: https://git.openjdk.org/jdk17u-dev/pull/1678 From shade at openjdk.org Mon Aug 21 11:14:44 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 11:14:44 GMT Subject: [jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2] In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 00:19:57 GMT, Andrew John Hughes wrote: >> GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available. >> >> Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. >> >> Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. > > Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: > > Fix specific version usage in cross compilation I don't think we should be doing these point fixes that diverge 11u GHA, and effectively do forward-ports from 8u. If we want to change how minor GCC versions are handled, we need to do this in mainline, and then back-port that change properly to 21u, 17u, 11u. 8u is harder, because GHA is way backwards here, missing major GHA rewrites. But for 11u we should just keep maintaining the parity with mainline. In other words, do 11u GHA updates like we did for 17u: https://github.com/openjdk/jdk11u-dev/pull/2090. That PR effectively reverts this one. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2087#issuecomment-1686129207 From duke at openjdk.org Mon Aug 21 11:46:46 2023 From: duke at openjdk.org (Nibedita Jena) Date: Mon, 21 Aug 2023 11:46:46 GMT Subject: [jdk21u] RFR: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar Message-ID: Clean backport of https://bugs.openjdk.org/browse/JDK-8312489 (e47a84f23dd2608c6f5748093eefe301fb5bf750) ------------- Commit messages: - Backport e47a84f23dd2608c6f5748093eefe301fb5bf750 Changes: https://git.openjdk.org/jdk21u/pull/76/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=76&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312489 Stats: 9 lines in 2 files changed: 2 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u/pull/76.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/76/head:pull/76 PR: https://git.openjdk.org/jdk21u/pull/76 From stuefe at openjdk.org Mon Aug 21 12:16:15 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 21 Aug 2023 12:16:15 GMT Subject: [jdk11u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue [v2] In-Reply-To: References: Message-ID: > Unclean composite backport to fix JDK-8312182 - "THPs cause huge RSS due to thread start timing issue" (https://bugs.openjdk.org/browse/JDK-8312182) > > Problem: > > On a machine with transparent huge pages (THP) unconditionally enabled (/sys/kernel/mm/transparent_hugepage/enabled = "always"), the JVM may show a huge memory footprint (RSS) and degraded thread start performance. > > The following factors make the problem more severe and more likely: > - thread stack size of 2M (on arm64 or x64) or larger > - many threads, or high thread creation churn > - a slow or overloaded machine (since part of the problem is timing-dependent) > > For a detailed discussion of the underlying problem, please see https://github.com/openjdk/jdk/pull/14919. > > ---------------- > > In jdk Head, the issue got fixed with a sequence of patches: > > - [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) "Make thread stacks not use huge pages" > - [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) "THPs cause huge RSS due to thread start timing" > > However, JDK-8312182 itself needed one preparatory fix: > - [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) "Fix THP detection on Linux" > > and then we had several corner-case test problems which are fixed with: > - [JDK-8312394](https://bugs.openjdk.org/browse/JDK-8312394) "[linux] SIGSEGV if kernel was built without hugepage support" > - [JDK-8312620](https://bugs.openjdk.org/browse/JDK-8312620) "WSL Linux build crashes after JDK-8310233" > - [JDK-8314139](https://bugs.openjdk.org/browse/JDK-8314139) "TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores" > > and finally, we decided to rename the switch that allows to switch off the THP mitigation with a final patch: > - [JDK-8312585](https://bugs.openjdk.org/browse/JDK-8312585) "Rename DisableTHPStackMitigation flag to THPStackMitigation" > > > > Instead of downporting these 7 patches verbatim, I prepared a composite patch containing only the necessary mitigation and mitigation tests. > > This patch does: > - make sure that all thread stacks have at least one glibc guard page to prevent clustering of adjacent thread stacks into one VMA > - change the default size of stacks to be not aligned to 2MB to prevent intra-stack THPs from forming > > The patch needs some infrastructure, but I downported only the necessary parts: the helper class "HugePages", which is used in head to scan the operating system for information about THP settings. I only included the parts to do... Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into tstuefe-backport-84b325b8 - Backport 84b325b844c08809448a9c073a11443d9e3c3f8e ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2086/files - new: https://git.openjdk.org/jdk11u-dev/pull/2086/files/c13269c1..3709c1e6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2086&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2086&range=00-01 Stats: 30555 lines in 347 files changed: 9325 ins; 10833 del; 10397 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2086.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2086/head:pull/2086 PR: https://git.openjdk.org/jdk11u-dev/pull/2086 From stuefe at openjdk.org Mon Aug 21 12:28:33 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 21 Aug 2023 12:28:33 GMT Subject: [jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: <8v4j2R_vOJBXWJCZtWEtI9rLtV1gIrJjNilO1DDRTW8=.a22ce71a-e927-43c8-aef4-4aaedcc44e33@github.com> On Fri, 18 Aug 2023 16:16:29 GMT, Andrew John Hughes wrote: > GHA regularly breaks because we specify a very explicit GCC version, even down to the release versioning of the Ubuntu package. > > Rather than bumping this yet again like https://github.com/openjdk/jdk17u/commit/260f28761a87553fd634615df5ba3db5b76ae692, this PR suggests dropping the specific version as we did some time ago in 8u and I've also proposed to fix the same breakage in 11u (https://github.com/openjdk/jdk11u-dev/pull/2087). The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. > > Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by recent GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. > > This is based on https://github.com/openjdk/jdk17u-dev/pull/1595 to allow https://github.com/openjdk/jdk17u-dev/pull/1672 to proceed. I'm very much in favor of dropping the GCC minor version dependency since it has been a huge pain. I don't care for patch direction, as long as we can convince mainline to do the same. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1673#issuecomment-1686232781 From alexsch at openjdk.org Mon Aug 21 12:38:58 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Mon, 21 Aug 2023 12:38:58 GMT Subject: [jdk11u-dev] RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute Message-ID: This is a clean backport of the fix `8311033: [macos] PrinterJob does not take into account Sides attribute`. The fix allows to print pages with `DUPLEX` and `TUMBLE` attributes on macOS. Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. ------------- Commit messages: - Backport a3d67231a71fbe37c509fcedd54c679b4644c0d9 Changes: https://git.openjdk.org/jdk11u-dev/pull/2091/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2091&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311033 Stats: 335 lines in 4 files changed: 335 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2091.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2091/head:pull/2091 PR: https://git.openjdk.org/jdk11u-dev/pull/2091 From duke at openjdk.org Mon Aug 21 12:52:32 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Mon, 21 Aug 2023 12:52:32 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v4] In-Reply-To: References: Message-ID: On Tue, 15 Aug 2023 07:05:08 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into 8313815 > - Merge master > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Thank you for your quick reply. Could you please sponsor the fix? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1686267395 From shade at openjdk.org Mon Aug 21 13:03:03 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 13:03:03 GMT Subject: [jdk11u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 Message-ID: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> This similar to the bulk GHA update we did here: https://github.com/shipilev/jdk17u-dev/commit/260f28761a87553fd634615df5ba3db5b76ae692 -- but now for 11u. Note this effectively reverts [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772). I strongly believe if we change minor GCC version handling, we should be doing it in mainline, and then pulling changes in as the proper backports, not forward ports from 8u -> 11u. There are other GHA improvements we would backport later. This one atomic PR brings in 11u GHA closer to mainline GHA state without breaking the builds. For reference, after this PR, the 11u-vs-mainline GHA diff would be this: [gha-11u-vs-mainline.patch](https://github.com/openjdk/jdk11u-dev/files/12395257/gha-11u-vs-mainline.patch) ------------- Commit messages: - Unclean backport: JDK-8313428: GHA: Bump GCC versions for July 2023 updates - Clean backport: JDK-8295885: GHA: Bump gcc versions - Unclean backport JDK-8295213: Run GHA manually with user-specified make and configure arguments - Clean backport: JDK-8293107: GHA: Bump to Ubuntu 22.04 - Clean backport JDK-8293361: GHA: dump config.log in case of configure failure - Clean backport: JDK-8293098: GHA: Harmonize GCC version handling for host and cross builds - Revert JDK-8284772: GHA: Use GCC Major Version Dependencies Only Changes: https://git.openjdk.org/jdk11u-dev/pull/2090/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2090&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293107 Stats: 121 lines in 5 files changed: 92 ins; 1 del; 28 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2090.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2090/head:pull/2090 PR: https://git.openjdk.org/jdk11u-dev/pull/2090 From stuefe at openjdk.org Mon Aug 21 13:03:03 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 21 Aug 2023 13:03:03 GMT Subject: [jdk11u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> References: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> Message-ID: On Mon, 21 Aug 2023 10:56:18 GMT, Aleksey Shipilev wrote: > This similar to the bulk GHA update we did here: https://github.com/shipilev/jdk17u-dev/commit/260f28761a87553fd634615df5ba3db5b76ae692 -- but now for 11u. > > Note this effectively reverts [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772). I strongly believe if we change minor GCC version handling, we should be doing it in mainline, and then pulling changes in as the proper backports, not forward ports from 8u -> 11u. > > There are other GHA improvements we would backport later. This one atomic PR brings in 11u GHA closer to mainline GHA state without breaking the builds. For reference, after this PR, the 11u-vs-mainline GHA diff would be this: [gha-11u-vs-mainline.patch](https://github.com/openjdk/jdk11u-dev/files/12395257/gha-11u-vs-mainline.patch) What is the reason for this PR, reducing maintenance by reducing delta to upstream? I would slightly prefer testing 11u on older systems with older glibcs (20.04 still rocks 2.31, which predates mallinfo2() for instance). ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2090#issuecomment-1686229221 From rob.mckenna at oracle.com Mon Aug 21 13:10:03 2023 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Mon, 21 Aug 2023 13:10:03 +0000 Subject: [21u Communication] 21.0.1 will be closed for fixes on the 4th of September Message-ID: eom! -Rob From andrew at openjdk.org Mon Aug 21 13:11:35 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 21 Aug 2023 13:11:35 GMT Subject: [jdk11u-dev] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v4] In-Reply-To: <_8DGMS3cCfAMC-Lb3TqtDOrSvglDBPunsmpZNz5v0kA=.f90ecbe8-0907-4261-863f-af75df591e37@github.com> References: <_8DGMS3cCfAMC-Lb3TqtDOrSvglDBPunsmpZNz5v0kA=.f90ecbe8-0907-4261-863f-af75df591e37@github.com> Message-ID: On Fri, 18 Aug 2023 19:34:17 GMT, Ben Taylor wrote: >> Backport is not clean, required changes: >> - Some context lines >> - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 >> - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 >> >> All tests in `test/jdk/java/util/zip` pass > > Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into 8313765 > - Restore newline at end of test/jdk/java/util/zip/ZipFile/ReadNonStandardExtraHeadersTest.java > - Remove junit dependency in ReadNonStandardExtraHeadersTest.java to run with jtreg 6 > - 8313765: Invalid CEN header (invalid zip64 extra data field size) > > Reviewed-by: simonis, alanb, coffeys The bug has `jdk11u-fix-yes` now, so if you integrate, one of us can sponsor and get this in. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2084#issuecomment-1686298923 From shade at openjdk.org Mon Aug 21 13:13:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 13:13:35 GMT Subject: [jdk11u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> References: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> Message-ID: On Mon, 21 Aug 2023 10:56:18 GMT, Aleksey Shipilev wrote: > This similar to the bulk GHA update we did here: https://github.com/shipilev/jdk17u-dev/commit/260f28761a87553fd634615df5ba3db5b76ae692 -- but now for 11u. > > Note this effectively reverts [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772). I strongly believe if we change minor GCC version handling, we should be doing it in mainline, and then pulling changes in as the proper backports, not forward ports from 8u -> 11u. > > There are other GHA improvements we would backport later. This one atomic PR brings in 11u GHA closer to mainline GHA state without breaking the builds. For reference, after this PR, the 11u-vs-mainline GHA diff would be this: [gha-11u-vs-mainline.patch](https://github.com/openjdk/jdk11u-dev/files/12395257/gha-11u-vs-mainline.patch) We had the [longer discussion about this already](https://bugs.openjdk.org/browse/JDK-8293107) in the RFE itself. > What is the reason for this PR, reducing maintenance by reducing delta to upstream? Yes. This is how you look at it: GHA is not under our control. When GHA infra changes, it changes globally for all JDK releases currently in testing. Therefore, the sane way to maintain GHA across JDK release repos is to keep it in sync as much as possible. That's what we did in 17u, and this is what we have to do in 11u, lest somebody is signing up to maintain the diverged 11u GHA going forward. > I would slightly prefer testing 11u on older systems with older glibcs (20.04 still rocks 2.31, which predates mallinfo2() for instance). We cannot do toolchain compatibility testing with GHA, because GHA infra is not under our control. If we keep old GHA code, the testing would first slow down, then it would start sporadically break on the way to EOL, and then it would completely break. Which also means we would be _forced to do this sync anyway_. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2090#issuecomment-1686300322 From tsteele at openjdk.org Mon Aug 21 13:46:47 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Mon, 21 Aug 2023 13:46:47 GMT Subject: [jdk21u] RFR: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) Message-ID: <2Ds_NQrSmvzAbscmX2K6GS068OOvpKNG0S-aJ2kNYKk=.41fabaeb-fc42-44f8-9585-910bca30f66b@github.com> Hi all, This pull request contains a backport of commit [fdac6a6a](https://github.com/openjdk/jdk/commit/fdac6a6ac871366614efe44aca58ab520766b5c8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. I am backporting this in order to backport [it's follow up](https://github.com/openjdk/jdk/commit/395fc78880a91eeb06a08c1abf6905d580a650c0) as well. The commit being backported was authored by Tyler Steele on 18 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe. Thanks! ------------- Commit messages: - Backport fdac6a6ac871366614efe44aca58ab520766b5c8 Changes: https://git.openjdk.org/jdk21u/pull/77/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=77&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312180 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/77.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/77/head:pull/77 PR: https://git.openjdk.org/jdk21u/pull/77 From apangin at openjdk.org Mon Aug 21 13:57:41 2023 From: apangin at openjdk.org (Andrei Pangin) Date: Mon, 21 Aug 2023 13:57:41 GMT Subject: [jdk17u-dev] RFR: 8312065: Socket.connect does not timeout when profiling In-Reply-To: <6qwO59yJ9ooIzdb0HGXTFes3fODq5BiWQXVy7G0T6OY=.960cca89-4600-4507-ac99-ac040e6c1adc@github.com> References: <6qwO59yJ9ooIzdb0HGXTFes3fODq5BiWQXVy7G0T6OY=.960cca89-4600-4507-ac99-ac040e6c1adc@github.com> Message-ID: On Fri, 4 Aug 2023 03:02:00 GMT, Long Yang wrote: > Hi all, > > This pull request contains a fix for [JDK-8312065](https://bugs.openjdk.org/browse/JDK-8312065). > > The old SocketImpl is still present in JDK 17, can be enabled with -Djdk.net.usePlainSocketImpl. > > I have verified that this problem exists on Linux and macOS, and I feel that it also exists on AIX, > so I repaired these 3 platforms. Windows implementations are different, so don't have this problem. > > All callers of NET_Poll() already check for EINTR, so the fix is to remove do-while loop in the implementation of NET_Poll(). > > Other methods, such as NET_Read, NET_NonBlockingRead, NET_Accept, NET_Connect, are not affected. > Because if Socket has timeout, it will call NET_Timeout first, and then call them. NET_Timeout has a correct timeout implementation and is not affected by profiling signals. > If the Socket does not have a timeout, and if the system call is interrupted by a signal, the [Linux Kernel will automatically retry](https://man7.org/linux/man-pages/man7/signal.7.html), and the application code will not be aware of it. > > I added a platform dependent test. > > The test needs to get the OS thread ID of the Java thread. It seems that there is no good Java API to get it directly. The minimum requirement of Linux [/proc/thread-self](https://man7.org/linux/man-pages/man5/proc.5.html#:~:text=/proc/thread%2Dself%20(since%20Linux%203.17)) is Linux 3.17. > The JFR event records the OS thread ID, although this method is cumbersome, it is reliable. > > The test also needs to use the kill command to send a signal to the thread. macOS's kill seems to only support process, and I don't have an AIX environment, so this test only supports Linux. > > Thanks! test/jdk/java/net/Socket/B8312065.java line 181: > 179: */ > 180: private static long getOSThreadId() throws IOException, ParseException { > 181: startJFR(); You may reuse `libNativeThread` for finding threadId and sending signals. This should make the test a lot simpler. See `SocketAcceptInterruptTest` and `SocketReadInterruptTest` for example. JFR is an optional feature, it is not available in Minimal VM. test/jdk/java/net/Socket/B8312065.java line 249: > 247: success = true; > 248: } > 249: } EOL is missing on the last line ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1639#discussion_r1300146121 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1639#discussion_r1300147412 From shade at openjdk.org Mon Aug 21 14:29:55 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 14:29:55 GMT Subject: [jdk21u] RFR: 8313701: GHA: RISC-V should use the official repository for bootstrap Message-ID: <43FjjUy5o5vyhHjg3tYbyAW_3NCVC4OJAioG6wfdTFU=.64005a19-a7e7-484c-a0c2-596010bb035d@github.com> Clean backport to improve GHA stability. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 538f9557b87f750264231f04bfbc91d15f8af8c0 Changes: https://git.openjdk.org/jdk21u/pull/78/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=78&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313701 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/78.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/78/head:pull/78 PR: https://git.openjdk.org/jdk21u/pull/78 From shade at openjdk.org Mon Aug 21 14:36:30 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 14:36:30 GMT Subject: [jdk17u-dev] RFR: 8313701: GHA: RISC-V should use the official repository for bootstrap Message-ID: Unclean backport to improve GHA stability. The conflict is due to RISC-V GHA changes of the slightly different form in 17u: does not have explicit `keyring` handling blocks. That block is going away with another clean up upstream, so I just resolved the conflict to only update the `debian-repository` itself. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 538f9557b87f750264231f04bfbc91d15f8af8c0 Changes: https://git.openjdk.org/jdk17u-dev/pull/1680/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1680&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313701 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1680.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1680/head:pull/1680 PR: https://git.openjdk.org/jdk17u-dev/pull/1680 From duke at openjdk.org Mon Aug 21 14:36:43 2023 From: duke at openjdk.org (Korov) Date: Mon, 21 Aug 2023 14:36:43 GMT Subject: [jdk11u-dev] RFR: 8305733: Pattern.CASE_INSENSITIVE does not take effect in jdk11 [v8] In-Reply-To: References: Message-ID: <1sUDqiq5xvGYKV4oSKrDYmgMFPhIP8Xoev4EHh9kZBk=.cda226c7-3867-47f2-a440-050ec193e568@github.com> On Fri, 18 Aug 2023 19:01:47 GMT, Paul Hohensee wrote: > @Korov, what testing have you done, and what do you estimate the risk is? Here we test whether the matching of Posix character, Unicode character, Unicode categories, aliases, properties, and java methods is correct under the condition of ignoring case. Currently considered no risk. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2062#issuecomment-1686451164 From shade at openjdk.org Mon Aug 21 14:40:45 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 14:40:45 GMT Subject: [jdk21u] RFR: 8314262: GHA: Cut down cross-compilation sysroots deeper In-Reply-To: <2USI8EcZ7ARKog6arY4so-L9Q3KWRZAUS7ism2mYz2A=.0c4be611-8850-4e1e-8237-b5f013932cf7@github.com> References: <2USI8EcZ7ARKog6arY4so-L9Q3KWRZAUS7ism2mYz2A=.0c4be611-8850-4e1e-8237-b5f013932cf7@github.com> Message-ID: On Wed, 16 Aug 2023 11:02:58 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA overheads. > > Additional testing: > - [x] GHA Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/61#issuecomment-1686454433 From shade at openjdk.org Mon Aug 21 14:40:45 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 14:40:45 GMT Subject: [jdk21u] Integrated: 8314262: GHA: Cut down cross-compilation sysroots deeper In-Reply-To: <2USI8EcZ7ARKog6arY4so-L9Q3KWRZAUS7ism2mYz2A=.0c4be611-8850-4e1e-8237-b5f013932cf7@github.com> References: <2USI8EcZ7ARKog6arY4so-L9Q3KWRZAUS7ism2mYz2A=.0c4be611-8850-4e1e-8237-b5f013932cf7@github.com> Message-ID: <6ZfgNZ639oTm1NjYiv5sfII66CpOfm9vPOO-vBFMnsA=.d42ae772-c76f-4b84-b7ff-7a8d0f25044f@github.com> On Wed, 16 Aug 2023 11:02:58 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA overheads. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 04adfb39 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/04adfb390c09d2348a874ee65c1d36ad7afb363c Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8314262: GHA: Cut down cross-compilation sysroots deeper Backport-of: 38687f1a3eb7d1c2e8aa43b85509ab7999fe0e40 ------------- PR: https://git.openjdk.org/jdk21u/pull/61 From shade at openjdk.org Mon Aug 21 15:09:04 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 15:09:04 GMT Subject: [jdk17u-dev] RFR: 8314658: [17u] GHA: Sync up debian-version for cross-builds Message-ID: [JDK-8283929](https://bugs.openjdk.org/browse/JDK-8283929) brought the change to cross-compilation configs that bootstrapped with "buster". This was a deviation from the original change, AFAICS because the runners were still on Ubuntu 20.04. After the upgrade to Ubuntu 22.04 runner with [JDK-8312511](https://bugs.openjdk.org/browse/JDK-8312511), it would make more sense to bootstrap with "bullseye", like current mainline that also runs with 22.04 does. This avoids accidental infra breakages that would be only detectable on 17u, not on mainline. Additional testing: - [ ] GHA ------------- Commit messages: - Fix Changes: https://git.openjdk.org/jdk17u-dev/pull/1681/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1681&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314658 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1681.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1681/head:pull/1681 PR: https://git.openjdk.org/jdk17u-dev/pull/1681 From shade at openjdk.org Mon Aug 21 15:46:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 15:46:35 GMT Subject: [jdk21u] RFR: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 10:02:54 GMT, Aleksey Shipilev wrote: > Clean backport to fix TCP_QUICKACK bug. > > Additional testing: > - [x] Linux AArch64 fastdebug, `jdk_net` > - [x] Linux AArch64 fastdebug, `tier1 tier2 tier3` Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/57#issuecomment-1686572533 From shade at openjdk.org Mon Aug 21 15:46:36 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 21 Aug 2023 15:46:36 GMT Subject: [jdk21u] Integrated: 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level In-Reply-To: References: Message-ID: On Mon, 14 Aug 2023 10:02:54 GMT, Aleksey Shipilev wrote: > Clean backport to fix TCP_QUICKACK bug. > > Additional testing: > - [x] Linux AArch64 fastdebug, `jdk_net` > - [x] Linux AArch64 fastdebug, `tier1 tier2 tier3` This pull request has now been integrated. Changeset: 32a1c790 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/32a1c7906637c2810d429cfb6a5850f0703f4fa1 Stats: 7 lines in 2 files changed: 0 ins; 0 del; 7 mod 8309591: Socket.setOption(TCP_QUICKACK) uses wrong level Backport-of: 56a73a6f0f3d38379cecea1de5eacb751febca95 ------------- PR: https://git.openjdk.org/jdk21u/pull/57 From stuefe at openjdk.org Mon Aug 21 16:06:34 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 21 Aug 2023 16:06:34 GMT Subject: [jdk11u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue [v2] In-Reply-To: References: Message-ID: <_gLs_CQMh3NVvRmqgyo20Myzm2UwGNHqj0FY1We5Sls=.9172a4ef-554a-4396-b4b6-1f264f9edbdb@github.com> On Mon, 21 Aug 2023 12:16:15 GMT, Thomas Stuefe wrote: >> Unclean composite backport to fix JDK-8312182 - "THPs cause huge RSS due to thread start timing issue" (https://bugs.openjdk.org/browse/JDK-8312182) >> >> Problem: >> >> On a machine with transparent huge pages (THP) unconditionally enabled (/sys/kernel/mm/transparent_hugepage/enabled = "always"), the JVM may show a huge memory footprint (RSS) and degraded thread start performance. >> >> The following factors make the problem more severe and more likely: >> - thread stack size of 2M (on arm64 or x64) or larger >> - many threads, or high thread creation churn >> - a slow or overloaded machine (since part of the problem is timing-dependent) >> >> For a detailed discussion of the underlying problem, please see https://github.com/openjdk/jdk/pull/14919. >> >> ---------------- >> >> In jdk Head, the issue got fixed with a sequence of patches: >> >> - [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) "Make thread stacks not use huge pages" >> - [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) "THPs cause huge RSS due to thread start timing" >> >> However, JDK-8312182 itself needed one preparatory fix: >> - [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) "Fix THP detection on Linux" >> >> and then we had several corner-case test problems which are fixed with: >> - [JDK-8312394](https://bugs.openjdk.org/browse/JDK-8312394) "[linux] SIGSEGV if kernel was built without hugepage support" >> - [JDK-8312620](https://bugs.openjdk.org/browse/JDK-8312620) "WSL Linux build crashes after JDK-8310233" >> - [JDK-8314139](https://bugs.openjdk.org/browse/JDK-8314139) "TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores" >> >> and finally, we decided to rename the switch that allows to switch off the THP mitigation with a final patch: >> - [JDK-8312585](https://bugs.openjdk.org/browse/JDK-8312585) "Rename DisableTHPStackMitigation flag to THPStackMitigation" >> >> >> >> Instead of downporting these 7 patches verbatim, I prepared a composite patch containing only the necessary mitigation and mitigation tests. >> >> This patch does: >> - make sure that all thread stacks have at least one glibc guard page to prevent clustering of adjacent thread stacks into one VMA >> - change the default size of stacks to be not aligned to 2MB to prevent intra-stack THPs from forming >> >> The patch needs some infrastructure, but I downported only the necessary parts: the helper class "HugePages", which is used in head to scan the oper... > > Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into tstuefe-backport-84b325b8 > - Backport 84b325b844c08809448a9c073a11443d9e3c3f8e All tests are green now. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2086#issuecomment-1686606567 From rriggs at openjdk.org Mon Aug 21 16:09:28 2023 From: rriggs at openjdk.org (Roger Riggs) Date: Mon, 21 Aug 2023 16:09:28 GMT Subject: [jdk21u] RFR: 8313312: Add missing classpath exception copyright header In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 19:21:55 GMT, Roger Riggs wrote: > The same copyright updates are needed in jdk21u. The backport for 20.0.1 ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/71#issuecomment-1686612601 From stuefe at openjdk.org Mon Aug 21 16:12:15 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 21 Aug 2023 16:12:15 GMT Subject: [jdk17u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue Message-ID: Unclean composite backport to jdk17u. Fixes JDK-8312182 - "THPs cause huge RSS due to thread start timing issue" (https://bugs.openjdk.org/browse/JDK-8312182) Problem: On a machine with transparent huge pages (THP) unconditionally enabled (/sys/kernel/mm/transparent_hugepage/enabled = "always"), the JVM may show a huge memory footprint (RSS) and degraded thread start performance. The following factors make the problem more severe and more likely: - thread stack size of 2M (on arm64 or x64) or larger - many threads, or high thread creation churn - a slow or overloaded machine (since part of the problem is timing-dependent) For a detailed discussion of the underlying problem, please see https://github.com/openjdk/jdk/pull/14919. ---------------- In jdk Head, the issue got fixed with a sequence of patches: - [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) "Make thread stacks not use huge pages" - [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) "THPs cause huge RSS due to thread start timing" However, JDK-8312182 itself needed one preparatory fix: - [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) "Fix THP detection on Linux" and then we had several corner-case test problems which are fixed with: - [JDK-8312394](https://bugs.openjdk.org/browse/JDK-8312394) "[linux] SIGSEGV if kernel was built without hugepage support" - [JDK-8312620](https://bugs.openjdk.org/browse/JDK-8312620) "WSL Linux build crashes after JDK-8310233" - [JDK-8314139](https://bugs.openjdk.org/browse/JDK-8314139) "TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores" and finally, we decided to rename the switch that allows to switch off the THP mitigation with a final patch: - [JDK-8312585](https://bugs.openjdk.org/browse/JDK-8312585) "Rename DisableTHPStackMitigation flag to THPStackMitigation" Instead of downporting these 7 patches verbatim, I prepared a composite patch containing only the necessary mitigation and mitigation tests. This is similar to the [jdk11u downport](https://github.com/openjdk/jdk11u-dev/pull/2086), but in jdk17u, [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) had been already backported. Therefore there are some minor differences. This patch does: - make sure that all thread stacks have at least one glibc guard page to prevent clustering of adjacent thread stacks into one VMA - change the default size of stacks to be not aligned to 2MB to prevent intra-stack THPs from forming The patch needs some infrastructure, but I downported only the necessary parts: the helper class "HugePages", which is used in head to scan the operating system for information about THP settings. I only included the parts to do with THPs and left the rest out. The patch also includes a regression test. ------ Testing: I manually tested the JVM on Linux x64 with THP=always: Without the patch (-Xmx1g -Xms1g -XX:+AlwaysPreTouch -Xss2m, 10000 threads started), I see slow thread startup and *11 GB - 14 GB* of RSS. The patched version comes up a lot faster and only shows *1.3* GB of RSS. ------------- Commit messages: - Backport 84b325b844c08809448a9c073a11443d9e3c3f8e Changes: https://git.openjdk.org/jdk17u-dev/pull/1679/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1679&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312182 Stats: 725 lines in 6 files changed: 717 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1679.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1679/head:pull/1679 PR: https://git.openjdk.org/jdk17u-dev/pull/1679 From btaylor at openjdk.org Mon Aug 21 16:25:48 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 21 Aug 2023 16:25:48 GMT Subject: [jdk11u-dev] Integrated: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:16:27 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > - Path in `ReadNonStandardExtraHeadersTest.java` had to be converted to URI, I believe because of FileSystems API changes in JDK13 > > All tests in `test/jdk/java/util/zip` pass This pull request has now been integrated. Changeset: 399633c2 Author: Ben Taylor Committer: Volker Simonis URL: https://git.openjdk.org/jdk11u-dev/commit/399633c223a5ee7de3355a12c5f616f30266a09d Stats: 1001 lines in 4 files changed: 987 ins; 1 del; 13 mod 8313765: Invalid CEN header (invalid zip64 extra data field size) Reviewed-by: andrew, serb Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2084 From phh at openjdk.org Mon Aug 21 16:27:43 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 21 Aug 2023 16:27:43 GMT Subject: [jdk17u-dev] RFR: 8313701: GHA: RISC-V should use the official repository for bootstrap In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 14:28:25 GMT, Aleksey Shipilev wrote: > Unclean backport to improve GHA stability. The conflict is due to RISC-V GHA changes of the slightly different form in 17u: does not have explicit `keyring` handling blocks. That block is going away with another clean up upstream, so I just resolved the conflict to only update the `debian-repository` itself. > > Additional testing: > - [ ] GHA Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1680#pullrequestreview-1587412444 From btaylor at openjdk.org Mon Aug 21 17:16:35 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 21 Aug 2023 17:16:35 GMT Subject: [jdk21u] Integrated: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: <_ff_iSGtQx60HvkB5eoIrbHMEJ56eDjXvJp4E_yUzH8=.a1aa2f40-9df2-4e41-a2b3-7baefbb4e3e7@github.com> On Fri, 18 Aug 2023 18:07:06 GMT, Ben Taylor wrote: > Backport is clean, all tests in test/jdk/java/util/zip pass. This pull request has now been integrated. Changeset: 9d1d5e78 Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u/commit/9d1d5e78c68ac1e437011169e136c92bb1a9a4ac Stats: 1004 lines in 4 files changed: 986 ins; 4 del; 14 mod 8313765: Invalid CEN header (invalid zip64 extra data field size) Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524 ------------- PR: https://git.openjdk.org/jdk21u/pull/72 From volker.simonis at gmail.com Mon Aug 21 17:57:35 2023 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 21 Aug 2023 10:57:35 -0700 Subject: Downporting JDK-8313765 to jdk11u and jdk17u and respinning 11.0.20 and 17.0.8 In-Reply-To: References: <33fa9d7e-ce9e-4936-b250-cb1b254c282c@amazon.com> Message-ID: I've just created "JDK-8314677: Bump update version for OpenJDK: jdk-17.0.8.1" [1] and set its "Fix version" to "17.0.8.1". Ben is preparing a PR for it. I'm not sure however, if he can create a PR which will be merged with 17.0.8-ga? Maybe only G?tzt can do that (or create a 17.0.8.1 branch in 17u)? [1] https://bugs.openjdk.org/browse/JDK-8314677 On Fri, Aug 18, 2023 at 10:41?AM Andrew Hughes wrote: > > On 14:50 Thu 17 Aug , Sergey Bylokhov wrote: > > Nobody mention respin of JDK 20u: > > https://github.com/openjdk/jdk20u/pull/87 > > Does anybody plan to do it? > > > > On 8/17/23 10:31, Andrew Hughes wrote: > > > Yes, I've been tracking this since it was discussed in the vulnerability > > > group. I agree it is preferable to have a fix rather than resorting to > > > turning off a CVE fix. > > > > > > My main worry is not about backporting the fix, but in whether we can > > > squeeze in a respin. I'm glad to see the proposed fix has finally been > > > posted publicly, reviewed and integrated as of yesterday. It seems > > > to have taken a long time to get to that stage from the original VG > > > discussion. > > > > > > When we've done interim releases in the past, they have been within a > > > few weeks of the original release. With this release, we are already > > > at the point where we enter rampdown for the next release in < 2 > > > weeks. > > > > > > I think we can still manage an interim release this time, but it > > > needs to happen within the next week, before people start to focus > > > on testing and adding security fixes to the October update. > > > > > > I'll go and review the 11u & 17u backports now. Note that there > > > are currently GHA failures with both, one down to the GCC versioning > > > we removed in 8u with https://bugs.openjdk.org/browse/JDK-8284772 > > > > -- > > Best regards, Sergey. > > > > We're not maintainers, Oracle are. I guess their efforts are now focused > on 21. They are aware of this and have apparently added it to 17.0.10-oracle > and 11.0.22-oracle already, and I see a request for 21 too [0] > > [0] https://bugs.openjdk.org/browse/JDK-8313765?focusedCommentId=14604862&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14604862 > > Best regards, > -- > Andrew :) > Pronouns: he / him or they / them > Principal Free Java Software Engineer > OpenJDK Package Owner > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > Please contact via e-mail, not proprietary chat networks > Available on Libera Chat & OFTC IRC networks as gnu_andrew From btaylor at openjdk.org Mon Aug 21 18:02:03 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 21 Aug 2023 18:02:03 GMT Subject: [jdk17u] RFR: 8314677: Bump update version for OpenJDK: jdk-17.0.8.1 Message-ID: Proposed branch for [JDK-8314677](https://bugs.openjdk.org/browse/JDK-8314677) Note that the merge preview on this branch will be incorrect as there is no upstream jdk17.0.8 branch, only a 17.0.8-ga tag. As such the PR is based on `master`. Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk17u/compare/jdk-17.0.8-ga...benty-amzn:jdk17u:jdk17.0.8.1?expand=1) See also previous discussion on #374 ------------- Commit messages: - 8313765: Invalid CEN header (invalid zip64 extra data field size) - 8314677: Bump update version for OpenJDK: jdk-17.0.8.1 Changes: https://git.openjdk.org/jdk17u/pull/375/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=375&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314677 Stats: 1002 lines in 6 files changed: 986 ins; 1 del; 15 mod Patch: https://git.openjdk.org/jdk17u/pull/375.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/375/head:pull/375 PR: https://git.openjdk.org/jdk17u/pull/375 From phh at openjdk.org Mon Aug 21 18:04:31 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 21 Aug 2023 18:04:31 GMT Subject: [jdk17u-dev] RFR: 8313678: SymbolTable can leak Symbols during cleanup In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 16:31:51 GMT, Oli Gillespie wrote: > Backporting fix for symbol table leak from https://bugs.openjdk.org/browse/JDK-8313678. > > Not totally clean: > > * places where 17 uses NULL versus nullptr in tip, trivial fix > * symbolTable uses `Symbol**` in 17 instead of `Symbol*`, also easy fix > * dictionary.cpp is not a concurrent hash table in 17 (missing 8292680), so no need to modify it > * finalizerService, g1CardSet, DynamicSharedSymbols test don't exist in 17 Marked as reviewed by phh (Reviewer). Looks good. Please tag the JBS issue. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1674#pullrequestreview-1587591414 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1674#issuecomment-1686787133 From bpb at openjdk.org Mon Aug 21 18:34:35 2023 From: bpb at openjdk.org (Brian Burkhalter) Date: Mon, 21 Aug 2023 18:34:35 GMT Subject: [jdk21u] RFR: 8313312: Add missing classpath exception copyright header In-Reply-To: References: Message-ID: <57suA9E3c1k0uTm2URAyeg38wWo5FRon04TtS6lm3xw=.37f718a4-0b01-4a5b-ab09-801055564346@github.com> On Thu, 17 Aug 2023 19:21:55 GMT, Roger Riggs wrote: > The same copyright updates are needed in jdk21u. Looks fine. ------------- Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk21u/pull/71#pullrequestreview-1587641346 From btaylor at openjdk.org Mon Aug 21 18:39:00 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 21 Aug 2023 18:39:00 GMT Subject: [jdk11u] RFR: 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 Message-ID: Proposed branch for [JDK-8314678](https://bugs.openjdk.org/browse/JDK-8314678) Note that the merge preview on this branch will be incorrect as there is no upstream jdk11.0.20 branch, only a 11.0.20-ga tag. As such the PR is based on `master`. Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk11u/compare/jdk-11.0.20-ga...benty-amzn:jdk11u:jdk11.0.20.1?expand=1) See also previous discussion on [jdk17u #374](https://github.com/openjdk/jdk17u/pull/374) and [jdk17u #375](https://github.com/openjdk/jdk17u/pull/375) ------------- Commit messages: - 8313765: Invalid CEN header (invalid zip64 extra data field size) - 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 Changes: https://git.openjdk.org/jdk11u/pull/76/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=76&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314678 Stats: 1004 lines in 6 files changed: 987 ins; 1 del; 16 mod Patch: https://git.openjdk.org/jdk11u/pull/76.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/76/head:pull/76 PR: https://git.openjdk.org/jdk11u/pull/76 From goetz.lindenmaier at sap.com Mon Aug 21 18:57:51 2023 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Mon, 21 Aug 2023 18:57:51 +0000 Subject: Downporting JDK-8313765 to jdk11u and jdk17u and respinning 11.0.20 and 17.0.8 In-Reply-To: References: <33fa9d7e-ce9e-4936-b250-cb1b254c282c@amazon.com> Message-ID: Hi, I just checked. I can not create the branch. The ops team at Oracle had asked me to check whether I can do it, but as it does not work they will create a branch. There is a convention not to use dashes, so the branches will be Named "jdk11.0.20.1" and "jdk17.0.8.1". Once they are there you can make PRs against these branches and push once reviewed etc. Best regards, Goetz. > -----Original Message----- > From: Volker Simonis > Sent: Montag, 21. August 2023 19:58 > To: Andrew Hughes > Cc: Sergey Bylokhov ; jdk-updates-dev dev at openjdk.java.net>; Langer, Christoph ; > Andrew Haley ; Severin Gehwolf ; > Lindenmaier, Goetz ; Taylor, Ben > > Subject: Re: Downporting JDK-8313765 to jdk11u and jdk17u and respinning > 11.0.20 and 17.0.8 > > I've just created "JDK-8314677: Bump update version for OpenJDK: > jdk-17.0.8.1" [1] and set its "Fix version" to "17.0.8.1". > Ben is preparing a PR for it. I'm not sure however, if he can create a > PR which will be merged with 17.0.8-ga? Maybe only G?tzt can do that > (or create a 17.0.8.1 branch in 17u)? > > [1] https://bugs.openjdk.org/browse/JDK-8314677 > > On Fri, Aug 18, 2023 at 10:41?AM Andrew Hughes > wrote: > > > > On 14:50 Thu 17 Aug , Sergey Bylokhov wrote: > > > Nobody mention respin of JDK 20u: > > > https://github.com/openjdk/jdk20u/pull/87 > > > Does anybody plan to do it? > > > > > > On 8/17/23 10:31, Andrew Hughes wrote: > > > > Yes, I've been tracking this since it was discussed in the vulnerability > > > > group. I agree it is preferable to have a fix rather than resorting to > > > > turning off a CVE fix. > > > > > > > > My main worry is not about backporting the fix, but in whether we can > > > > squeeze in a respin. I'm glad to see the proposed fix has finally been > > > > posted publicly, reviewed and integrated as of yesterday. It seems > > > > to have taken a long time to get to that stage from the original VG > > > > discussion. > > > > > > > > When we've done interim releases in the past, they have been within a > > > > few weeks of the original release. With this release, we are already > > > > at the point where we enter rampdown for the next release in < 2 > > > > weeks. > > > > > > > > I think we can still manage an interim release this time, but it > > > > needs to happen within the next week, before people start to focus > > > > on testing and adding security fixes to the October update. > > > > > > > > I'll go and review the 11u & 17u backports now. Note that there > > > > are currently GHA failures with both, one down to the GCC versioning > > > > we removed in 8u with https://bugs.openjdk.org/browse/JDK-8284772 > > > > > > -- > > > Best regards, Sergey. > > > > > > > We're not maintainers, Oracle are. I guess their efforts are now focused > > on 21. They are aware of this and have apparently added it to 17.0.10-oracle > > and 11.0.22-oracle already, and I see a request for 21 too [0] > > > > [0] https://bugs.openjdk.org/browse/JDK- > 8313765?focusedCommentId=14604862&page=com.atlassian.jira.plugin.syste > m.issuetabpanels:comment-tabpanel#comment-14604862 > > > > Best regards, > > -- > > Andrew :) > > Pronouns: he / him or they / them > > Principal Free Java Software Engineer > > OpenJDK Package Owner > > Red Hat, Inc. > (http://www.re/ > dhat.com%2F&data=05%7C01%7Cgoetz.lindenmaier%40sap.com%7Cea1605b > d5234423e4a7608dba2702388%7C42f7676cf455423c82f6dc2d99791af7%7C0 > %7C0%7C638282374731170501%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC > 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7 > C%7C%7C&sdata=uTOwVSxZZtb08DjX6lB6uUHOzUeHzRo145u3itNqCDc%3D&r > eserved=0) > > > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > > > Please contact via e-mail, not proprietary chat networks > > Available on Libera Chat & OFTC IRC networks as gnu_andrew From volker.simonis at gmail.com Mon Aug 21 19:06:41 2023 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 21 Aug 2023 12:06:41 -0700 Subject: Downporting JDK-8313765 to jdk11u and jdk17u and respinning 11.0.20 and 17.0.8 In-Reply-To: References: <33fa9d7e-ce9e-4936-b250-cb1b254c282c@amazon.com> Message-ID: Thanks a lot G?tz! On Mon, Aug 21, 2023 at 11:57?AM Lindenmaier, Goetz wrote: > > Hi, > > I just checked. > I can not create the branch. > > The ops team at Oracle had asked me to check whether I can do it, > but as it does not work they will create a branch. > > There is a convention not to use dashes, so the branches will be > Named "jdk11.0.20.1" and "jdk17.0.8.1". > > Once they are there you can make PRs against these branches > and push once reviewed etc. > > Best regards, > Goetz. > > > > -----Original Message----- > > From: Volker Simonis > > Sent: Montag, 21. August 2023 19:58 > > To: Andrew Hughes > > Cc: Sergey Bylokhov ; jdk-updates-dev > dev at openjdk.java.net>; Langer, Christoph ; > > Andrew Haley ; Severin Gehwolf ; > > Lindenmaier, Goetz ; Taylor, Ben > > > > Subject: Re: Downporting JDK-8313765 to jdk11u and jdk17u and respinning > > 11.0.20 and 17.0.8 > > > > I've just created "JDK-8314677: Bump update version for OpenJDK: > > jdk-17.0.8.1" [1] and set its "Fix version" to "17.0.8.1". > > Ben is preparing a PR for it. I'm not sure however, if he can create a > > PR which will be merged with 17.0.8-ga? Maybe only G?tzt can do that > > (or create a 17.0.8.1 branch in 17u)? > > > > [1] https://bugs.openjdk.org/browse/JDK-8314677 > > > > On Fri, Aug 18, 2023 at 10:41?AM Andrew Hughes > > wrote: > > > > > > On 14:50 Thu 17 Aug , Sergey Bylokhov wrote: > > > > Nobody mention respin of JDK 20u: > > > > https://github.com/openjdk/jdk20u/pull/87 > > > > Does anybody plan to do it? > > > > > > > > On 8/17/23 10:31, Andrew Hughes wrote: > > > > > Yes, I've been tracking this since it was discussed in the vulnerability > > > > > group. I agree it is preferable to have a fix rather than resorting to > > > > > turning off a CVE fix. > > > > > > > > > > My main worry is not about backporting the fix, but in whether we can > > > > > squeeze in a respin. I'm glad to see the proposed fix has finally been > > > > > posted publicly, reviewed and integrated as of yesterday. It seems > > > > > to have taken a long time to get to that stage from the original VG > > > > > discussion. > > > > > > > > > > When we've done interim releases in the past, they have been within a > > > > > few weeks of the original release. With this release, we are already > > > > > at the point where we enter rampdown for the next release in < 2 > > > > > weeks. > > > > > > > > > > I think we can still manage an interim release this time, but it > > > > > needs to happen within the next week, before people start to focus > > > > > on testing and adding security fixes to the October update. > > > > > > > > > > I'll go and review the 11u & 17u backports now. Note that there > > > > > are currently GHA failures with both, one down to the GCC versioning > > > > > we removed in 8u with https://bugs.openjdk.org/browse/JDK-8284772 > > > > > > > > -- > > > > Best regards, Sergey. > > > > > > > > > > We're not maintainers, Oracle are. I guess their efforts are now focused > > > on 21. They are aware of this and have apparently added it to 17.0.10-oracle > > > and 11.0.22-oracle already, and I see a request for 21 too [0] > > > > > > [0] https://bugs.openjdk.org/browse/JDK- > > 8313765?focusedCommentId=14604862&page=com.atlassian.jira.plugin.syste > > m.issuetabpanels:comment-tabpanel#comment-14604862 > > > > > > Best regards, > > > -- > > > Andrew :) > > > Pronouns: he / him or they / them > > > Principal Free Java Software Engineer > > > OpenJDK Package Owner > > > Red Hat, Inc. > > (http://www.re/ > > dhat.com%2F&data=05%7C01%7Cgoetz.lindenmaier%40sap.com%7Cea1605b > > d5234423e4a7608dba2702388%7C42f7676cf455423c82f6dc2d99791af7%7C0 > > %7C0%7C638282374731170501%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC > > 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7 > > C%7C%7C&sdata=uTOwVSxZZtb08DjX6lB6uUHOzUeHzRo145u3itNqCDc%3D&r > > eserved=0) > > > > > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > > > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > > > > > Please contact via e-mail, not proprietary chat networks > > > Available on Libera Chat & OFTC IRC networks as gnu_andrew From abimpoudis at openjdk.org Mon Aug 21 19:19:30 2023 From: abimpoudis at openjdk.org (Aggelos Biboudis) Date: Mon, 21 Aug 2023 19:19:30 GMT Subject: [jdk21u] Integrated: 8314423: Multiple patterns without unnamed variables In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 07:52:56 GMT, Aggelos Biboudis wrote: > 8314423: Multiple patterns without unnamed variables This pull request has now been integrated. Changeset: 8a092532 Author: Aggelos Biboudis Committer: Vicente Romero URL: https://git.openjdk.org/jdk21u/commit/8a0925322150610348d02d01fc17d112bf3a860a Stats: 63 lines in 6 files changed: 63 ins; 0 del; 0 mod 8314423: Multiple patterns without unnamed variables 8314216: Case enumConstant, pattern compilation fails Backport-of: 43311930107d1783b742adbe567e9bdbcb55775d ------------- PR: https://git.openjdk.org/jdk21u/pull/69 From goetz at openjdk.org Mon Aug 21 19:28:35 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 21 Aug 2023 19:28:35 GMT Subject: [jdk17u] RFR: 8314677: Bump update version for OpenJDK: jdk-17.0.8.1 In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 17:55:53 GMT, Ben Taylor wrote: > Proposed branch for [JDK-8314677](https://bugs.openjdk.org/browse/JDK-8314677) > > > Note that the merge preview on this branch will be incorrect as there is no upstream jdk17.0.8 branch, only a 17.0.8-ga tag. As such the PR is based on `master`. > Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk17u/compare/jdk-17.0.8-ga...benty-amzn:jdk17u:jdk17.0.8.1?expand=1) > > See also previous discussion on #374 Hi Ben, please be careful to push two seperate changes. This here already includes the fix. It should only include changes to the two files with the version. You can make a second PR on top of this one for the real fix. Just select branch pr/375 as base of the second PR. Probably you want to wait until the branches are created and you rebased this one on the branch. Also, I think it is better to use August 24th as date. No one will be able to deliver a JVM tomorrow. Best regards, Goetz. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/375#issuecomment-1686912351 From valeriep at openjdk.org Mon Aug 21 19:40:58 2023 From: valeriep at openjdk.org (Valerie Peng) Date: Mon, 21 Aug 2023 19:40:58 GMT Subject: [jdk21u] RFR: 8302017: Allocate BadPaddingException only if it will be thrown Message-ID: This PR contains a backport of commit c27c8778 from the openjdk/jdk repository. The commit being backported was authored by Valerie Peng on 27 Jul 2023 and was reviewed by Xue-Lei Andrew Fan. Thanks! Valerie ------------- Commit messages: - Backport c27c87786a612501e080222dd8647f94b3b261e6 Changes: https://git.openjdk.org/jdk21u/pull/79/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=79&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302017 Stats: 157 lines in 5 files changed: 91 ins; 27 del; 39 mod Patch: https://git.openjdk.org/jdk21u/pull/79.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/79/head:pull/79 PR: https://git.openjdk.org/jdk21u/pull/79 From phh at openjdk.org Mon Aug 21 19:44:40 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 21 Aug 2023 19:44:40 GMT Subject: [jdk17u-dev] RFR: 8314658: [17u] GHA: Sync up debian-version for cross-builds In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 15:02:46 GMT, Aleksey Shipilev wrote: > [JDK-8283929](https://bugs.openjdk.org/browse/JDK-8283929) brought the change to cross-compilation configs that bootstrapped with "buster". This was a deviation from the original change, AFAICS because the runners were still on Ubuntu 20.04. > > After the upgrade to Ubuntu 22.04 runner with [JDK-8312511](https://bugs.openjdk.org/browse/JDK-8312511), it would make more sense to bootstrap with "bullseye", like current mainline that also runs with 22.04 does. This avoids accidental infra breakages that would be only detectable on 17u, not on mainline. > > Additional testing: > - [ ] GHA Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1681#pullrequestreview-1587741423 From phh at openjdk.org Mon Aug 21 19:46:32 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 21 Aug 2023 19:46:32 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v3] In-Reply-To: References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: On Fri, 18 Aug 2023 17:05:00 GMT, Dan Lutker wrote: >> Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. >> >> >> bash ./configure --with-jtreg=jtreg-7.3+1 >> make images >> make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" >> >> >> All tests pass. > > Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > 8314552: Fix javadoc tests to work with jtreg 7 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1672#pullrequestreview-1587744726 From btaylor at openjdk.org Mon Aug 21 20:02:36 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 21 Aug 2023 20:02:36 GMT Subject: [jdk17u] RFR: 8314677: Bump update version for OpenJDK: jdk-17.0.8.1 [v2] In-Reply-To: References: Message-ID: > Proposed branch for [JDK-8314677](https://bugs.openjdk.org/browse/JDK-8314677) > > > Note that the merge preview on this branch will be incorrect as there is no upstream jdk17.0.8 branch, only a 17.0.8-ga tag. As such the PR is based on `master`. > Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk17u/compare/jdk-17.0.8-ga...benty-amzn:jdk17u:jdk17.0.8.1?expand=1) > > See also previous discussion on #374 Ben Taylor has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Update release date to 2023-08-24 ------------- Changes: - all: https://git.openjdk.org/jdk17u/pull/375/files - new: https://git.openjdk.org/jdk17u/pull/375/files/f44db0c3..7cc2ce0c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u&pr=375&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u&pr=375&range=00-01 Stats: 1000 lines in 5 files changed: 1 ins; 986 del; 13 mod Patch: https://git.openjdk.org/jdk17u/pull/375.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/375/head:pull/375 PR: https://git.openjdk.org/jdk17u/pull/375 From duke at openjdk.org Mon Aug 21 20:04:46 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Mon, 21 Aug 2023 20:04:46 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v4] In-Reply-To: References: Message-ID: On Tue, 15 Aug 2023 07:05:08 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into 8313815 > - Merge master > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows I'm very sorry, I typed integrate before being marked as ready for integration. The jdk17-fix-yes has not be set on JBS yet. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1686962118 From btaylor at openjdk.org Mon Aug 21 20:06:37 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 21 Aug 2023 20:06:37 GMT Subject: [jdk17u] RFR: 8314677: Bump update version for OpenJDK: jdk-17.0.8.1 In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 17:55:53 GMT, Ben Taylor wrote: > Proposed branch for [JDK-8314677](https://bugs.openjdk.org/browse/JDK-8314677) > > > Note that the merge preview on this branch will be incorrect as there is no upstream jdk17.0.8 branch, only a 17.0.8-ga tag. As such the PR is based on `master`. > Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk17u/compare/jdk-17.0.8-ga...benty-amzn:jdk17u:jdk17.0.8.1?expand=1) > > See also previous discussion on #374 I'm not sure if the jdk17u repo is set up to support dependent PRs - I don't see the expected pr/375 branch available as a base for the fix. I'll create the PR against 17.0.8.1 with this patch included, and wait for this PR to be integrated first. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/375#issuecomment-1686961698 From btaylor at openjdk.org Mon Aug 21 20:10:12 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 21 Aug 2023 20:10:12 GMT Subject: [jdk11u] RFR: 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 [v2] In-Reply-To: References: Message-ID: > Proposed branch for [JDK-8314678](https://bugs.openjdk.org/browse/JDK-8314678) > > > Note that the merge preview on this branch will be incorrect as there is no upstream jdk11.0.20 branch, only a 11.0.20-ga tag. As such the PR is based on `master`. > Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk11u/compare/jdk-11.0.20-ga...benty-amzn:jdk11u:jdk11.0.20.1?expand=1) > > See also previous discussion on [jdk17u #374](https://github.com/openjdk/jdk17u/pull/374) and [jdk17u #375](https://github.com/openjdk/jdk17u/pull/375) Ben Taylor has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 ------------- Changes: - all: https://git.openjdk.org/jdk11u/pull/76/files - new: https://git.openjdk.org/jdk11u/pull/76/files/f4a4f404..52892b3a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u&pr=76&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u&pr=76&range=00-01 Stats: 1002 lines in 5 files changed: 1 ins; 987 del; 14 mod Patch: https://git.openjdk.org/jdk11u/pull/76.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/76/head:pull/76 PR: https://git.openjdk.org/jdk11u/pull/76 From btaylor at openjdk.org Mon Aug 21 20:11:03 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 21 Aug 2023 20:11:03 GMT Subject: [jdk17u] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) Message-ID: Backport of 8313765: Invalid CEN header (invalid zip64 extra data field size), [jdk17u-dev #1670](https://github.com/openjdk/jdk17u-dev/pull/1670) for the 17.0.8.1 patch release. ------------- Commit messages: - 8313765: Invalid CEN header (invalid zip64 extra data field size) - 8314677: Bump update version for OpenJDK: jdk-17.0.8.1 Changes: https://git.openjdk.org/jdk17u/pull/376/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=376&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313765 Stats: 1002 lines in 6 files changed: 986 ins; 1 del; 15 mod Patch: https://git.openjdk.org/jdk17u/pull/376.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/376/head:pull/376 PR: https://git.openjdk.org/jdk17u/pull/376 From btaylor at openjdk.org Mon Aug 21 20:13:43 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 21 Aug 2023 20:13:43 GMT Subject: [jdk11u] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) Message-ID: Backport of 8313765: Invalid CEN header (invalid zip64 extra data field size), [jdk11u-dev #2084](https://github.com/openjdk/jdk11u-dev/pull/2084) for the 11.0.20.1 patch release. ------------- Commit messages: - 8313765: Invalid CEN header (invalid zip64 extra data field size) - 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 Changes: https://git.openjdk.org/jdk11u/pull/77/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=77&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313765 Stats: 1004 lines in 6 files changed: 987 ins; 1 del; 16 mod Patch: https://git.openjdk.org/jdk11u/pull/77.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/77/head:pull/77 PR: https://git.openjdk.org/jdk11u/pull/77 From phh at openjdk.org Mon Aug 21 20:52:33 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 21 Aug 2023 20:52:33 GMT Subject: [jdk11u] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 20:05:53 GMT, Ben Taylor wrote: > Backport of 8313765: Invalid CEN header (invalid zip64 extra data field size), [jdk11u-dev #2084](https://github.com/openjdk/jdk11u-dev/pull/2084) for the 11.0.20.1 patch release. Needs the title fixed to "Backport " so the bot will recognize it properly. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/77#issuecomment-1687025004 From almatvee at openjdk.org Mon Aug 21 21:02:37 2023 From: almatvee at openjdk.org (Alexander Matveev) Date: Mon, 21 Aug 2023 21:02:37 GMT Subject: [jdk21u] Integrated: 8313904: [macos] All signing tests which verifies unsigned app images are failing In-Reply-To: <4VNFyMbckiN8i1VPvey0rXvmy3IJV33RtSA-guGfAY4=.34adf858-2f30-4db9-a85d-23685b6eb8f9@github.com> References: <4VNFyMbckiN8i1VPvey0rXvmy3IJV33RtSA-guGfAY4=.34adf858-2f30-4db9-a85d-23685b6eb8f9@github.com> Message-ID: <1AEPv05v3wkJhLlchdznjxw1j8_LFO4p6RaJL8ayA6M=.b5f04a6c-6919-43bf-aa21-c03d1b6db6e4@github.com> On Thu, 17 Aug 2023 00:10:11 GMT, Alexander Matveev wrote: > Clean backport of JDK-8313904. This pull request has now been integrated. Changeset: 16fa0559 Author: Alexander Matveev Committer: Alexander Zuev URL: https://git.openjdk.org/jdk21u/commit/16fa05594cc2cbc4939266f9ecb8bbff05204978 Stats: 94 lines in 8 files changed: 58 ins; 0 del; 36 mod 8313904: [macos] All signing tests which verifies unsigned app images are failing Reviewed-by: asemenyuk Backport-of: ec0cc6300a02dd92b25d9072b8b3859dab583bbd ------------- PR: https://git.openjdk.org/jdk21u/pull/67 From simonis at openjdk.org Mon Aug 21 22:50:35 2023 From: simonis at openjdk.org (Volker Simonis) Date: Mon, 21 Aug 2023 22:50:35 GMT Subject: [jdk17u] RFR: 8314677: Bump update version for OpenJDK: jdk-17.0.8.1 [v2] In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 20:02:36 GMT, Ben Taylor wrote: >> Proposed branch for [JDK-8314677](https://bugs.openjdk.org/browse/JDK-8314677) >> >> >> Note that the merge preview on this branch will be incorrect as there is no upstream jdk17.0.8 branch, only a 17.0.8-ga tag. As such the PR is based on `master`. >> Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk17u/compare/jdk-17.0.8-ga...benty-amzn:jdk17u:jdk17.0.8.1?expand=1) >> >> See also previous discussion on #374 > > Ben Taylor has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Update release date to 2023-08-24 Looks good. ------------- Marked as reviewed by simonis (Reviewer). PR Review: https://git.openjdk.org/jdk17u/pull/375#pullrequestreview-1588020097 From simonis at openjdk.org Mon Aug 21 22:51:29 2023 From: simonis at openjdk.org (Volker Simonis) Date: Mon, 21 Aug 2023 22:51:29 GMT Subject: [jdk11u] RFR: 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 [v2] In-Reply-To: References: Message-ID: <0aR3Bx3W8QRVf0OnCk4iQBEMSMQqoNPfPVc1l8PLXjA=.9863b59e-2218-4e8d-ae5c-4b1b975b3399@github.com> On Mon, 21 Aug 2023 20:10:12 GMT, Ben Taylor wrote: >> Proposed branch for [JDK-8314678](https://bugs.openjdk.org/browse/JDK-8314678) >> >> >> Note that the merge preview on this branch will be incorrect as there is no upstream jdk11.0.20 branch, only a 11.0.20-ga tag. As such the PR is based on `master`. >> Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk11u/compare/jdk-11.0.20-ga...benty-amzn:jdk11u:jdk11.0.20.1?expand=1) >> >> See also previous discussion on [jdk17u #374](https://github.com/openjdk/jdk17u/pull/374) and [jdk17u #375](https://github.com/openjdk/jdk17u/pull/375) > > Ben Taylor has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 Looks good. ------------- Marked as reviewed by simonis (Reviewer). PR Review: https://git.openjdk.org/jdk11u/pull/76#pullrequestreview-1588021094 From valeriep at openjdk.org Tue Aug 22 00:20:39 2023 From: valeriep at openjdk.org (Valerie Peng) Date: Tue, 22 Aug 2023 00:20:39 GMT Subject: [jdk21u] Integrated: 8302017: Allocate BadPaddingException only if it will be thrown In-Reply-To: References: Message-ID: <91VqM_Mzbk_bjpFMhpVyPC-esP_lHEDpA_YxFRiFf2c=.20068bba-d60e-4bf8-8b78-4e4eea3e3c95@github.com> On Mon, 21 Aug 2023 19:33:46 GMT, Valerie Peng wrote: > This PR contains a backport of commit c27c8778 from the openjdk/jdk repository. > The commit being backported was authored by Valerie Peng on 27 Jul 2023 and was reviewed by Xue-Lei Andrew Fan. > > Thanks! > Valerie This pull request has now been integrated. Changeset: 334b9772 Author: Valerie Peng URL: https://git.openjdk.org/jdk21u/commit/334b977259930368160db705c1f2feda0b0e8707 Stats: 157 lines in 5 files changed: 91 ins; 27 del; 39 mod 8302017: Allocate BadPaddingException only if it will be thrown Backport-of: c27c87786a612501e080222dd8647f94b3b261e6 ------------- PR: https://git.openjdk.org/jdk21u/pull/79 From serb at openjdk.org Tue Aug 22 01:52:41 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 22 Aug 2023 01:52:41 GMT Subject: [jdk11u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> References: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> Message-ID: On Mon, 21 Aug 2023 10:56:18 GMT, Aleksey Shipilev wrote: > This similar to the bulk GHA update we did here: https://github.com/shipilev/jdk17u-dev/commit/260f28761a87553fd634615df5ba3db5b76ae692 -- but now for 11u. > > Note this effectively reverts [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772). I strongly believe if we change minor GCC version handling, we should be doing it in mainline, and then pulling changes in as the proper backports, not forward ports from 8u -> 11u. > > There are other GHA improvements we would backport later. This one atomic PR brings in 11u GHA closer to mainline GHA state without breaking the builds. For reference, after this PR, the 11u-vs-mainline GHA diff would be this: [gha-11u-vs-mainline.patch](https://github.com/openjdk/jdk11u-dev/files/12395257/gha-11u-vs-mainline.patch) Will this change causes the same breakages we had when the minor version of gcc was changed? I prefer to ignore that minor number in GA. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2090#issuecomment-1687292716 From fyang at openjdk.org Tue Aug 22 02:03:01 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 22 Aug 2023 02:03:01 GMT Subject: [jdk17u-dev] RFR: 8310873: Re-enable locked_create_entry symbol check in runtime/NMT/CheckForProperDetailStackTrace.java for RISC-V Message-ID: Clean backport to jdk17u. This re-enables the "locked_create_entry" symbol checking in the test for RISC-V. Testing: This test still passes on linux-riscv platform with this small change. ------------- Commit messages: - Backport 87e6fab2c498558d4593f6c0537c998a61779aaf Changes: https://git.openjdk.org/jdk17u-dev/pull/1684/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1684&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310873 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1684.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1684/head:pull/1684 PR: https://git.openjdk.org/jdk17u-dev/pull/1684 From andrew at openjdk.org Tue Aug 22 02:14:33 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 22 Aug 2023 02:14:33 GMT Subject: [jdk21u] RFR: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 11:40:22 GMT, Nibedita Jena wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8312489 (e47a84f23dd2608c6f5748093eefe301fb5bf750) This shouldn't be merged until https://bugs.openjdk.org/browse/JDK-8312489 has `jdk21u-fix-yes`. Also, please turn on actions on your fork so testing can be run. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/76#issuecomment-1687308791 From andrew at openjdk.org Tue Aug 22 02:24:41 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 22 Aug 2023 02:24:41 GMT Subject: [jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 10:13:51 GMT, Aleksey Shipilev wrote: > Nope, not for 17u. > > While the actual removal of minor GCC version tracking might be okay, it is wrong to keep effectively _forward-porting_ the GHA change from 8u -> 11u -> 17u. You need to do this in mainline, argue the point on minor GCC version removals (in other words, the reversal of [JDK-8256393](https://bugs.openjdk.org/browse/JDK-8256393)), and then argue for backports. Otherwise, you will keep doing this for every subsequent XXu. Yes, this was never intended to be merged in the current state anyway. It was provided so we could see if #1672 would actually fix the JTReg failures. My intention was to propose it to trunk as well in due course and I've now done that (https://github.com/openjdk/jdk/pull/15374). We can still use this PR for the subsequent 17u PR. I would very much like to see someone argue in favour of keeping this versioning. It seems to have been added with little review and has baffled me from the start. I was surprised to find it was still present over this last week. I had hoped someone else would have ditched it long ago. I tend to be focused mostly on 8u, where we dropped it from the start and haven't had any problems since. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1673#issuecomment-1687315077 From andrew at openjdk.org Tue Aug 22 02:24:42 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 22 Aug 2023 02:24:42 GMT Subject: [jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: <8v4j2R_vOJBXWJCZtWEtI9rLtV1gIrJjNilO1DDRTW8=.a22ce71a-e927-43c8-aef4-4aaedcc44e33@github.com> References: <8v4j2R_vOJBXWJCZtWEtI9rLtV1gIrJjNilO1DDRTW8=.a22ce71a-e927-43c8-aef4-4aaedcc44e33@github.com> Message-ID: On Mon, 21 Aug 2023 12:25:51 GMT, Thomas Stuefe wrote: > I'm very much in favor of dropping the GCC minor version dependency since it has been a huge pain. I don't care for patch direction, as long as we can convince mainline to do the same. Hopefully. Having had tests fail three times in the last week due to this (once in 11u, once in 17u and once in our own fork of 21u), I'm surprised people have stuck with it this long. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1673#issuecomment-1687315832 From fjiang at openjdk.org Tue Aug 22 02:45:27 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Tue, 22 Aug 2023 02:45:27 GMT Subject: [jdk21u] RFR: 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 10:42:29 GMT, Feilong Jiang wrote: > This fixes the incorrect VMReg encoding in `RISCV64Frame.java` for risc-v. Patch applies clean. Got `fix-request-yes` and GHA failure is not related to riscv port. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/75#issuecomment-1687330761 From fjiang at openjdk.org Tue Aug 22 02:49:38 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Tue, 22 Aug 2023 02:49:38 GMT Subject: [jdk21u] Integrated: 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 10:42:29 GMT, Feilong Jiang wrote: > This fixes the incorrect VMReg encoding in `RISCV64Frame.java` for risc-v. Patch applies clean. This pull request has now been integrated. Changeset: 8792922f Author: Feilong Jiang Committer: Fei Yang URL: https://git.openjdk.org/jdk21u/commit/8792922fc7b25ad6fad51eb1755276a9147f51a3 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java Backport-of: 5c9162288570a140138a0055cd9c4e88fe40e69d ------------- PR: https://git.openjdk.org/jdk21u/pull/75 From gcao at openjdk.org Tue Aug 22 03:15:53 2023 From: gcao at openjdk.org (Gui Cao) Date: Tue, 22 Aug 2023 03:15:53 GMT Subject: [jdk21u] RFR: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected Message-ID: Hi, I would like to backport this to jdk21u Make -XX:MaxVectorSize work correctly on Linux RISC-V platform. `test/hotspot/jtreg/compiler/loopopts/superword/TestUnorderedReduction.java` passed with fastdebug and use build using qemu. ------------- Commit messages: - Backport a66b5df14a163d2990e6dd746906942367e4fdb2 Changes: https://git.openjdk.org/jdk21u/pull/80/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=80&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314618 Stats: 4 lines in 2 files changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/80.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/80/head:pull/80 PR: https://git.openjdk.org/jdk21u/pull/80 From shade at openjdk.org Tue Aug 22 06:16:39 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Aug 2023 06:16:39 GMT Subject: [jdk11u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: References: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> Message-ID: On Tue, 22 Aug 2023 01:49:34 GMT, Sergey Bylokhov wrote: > Will this change causes the same breakages we had when the minor version of gcc was changed? I prefer to ignore that minor number in GA. In current form, yes, that's a risk that is shared with mainline, 21u, 17u, and until recently 11u GHAs. It would still be there until we backport the GHA change that drops the minor GCC version from all GHAs. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2090#issuecomment-1687512769 From shade at openjdk.org Tue Aug 22 07:49:08 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Aug 2023 07:49:08 GMT Subject: [jdk11u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 [v2] In-Reply-To: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> References: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> Message-ID: > This similar to the bulk GHA update we did here: https://github.com/shipilev/jdk17u-dev/commit/260f28761a87553fd634615df5ba3db5b76ae692 -- but now for 11u. > > Note this reverts and then reapplies [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772) to avoid backport conflicts. > > There are other GHA improvements we would backport later. This one atomic PR brings in 11u GHA closer to mainline GHA state without breaking the builds. For reference, after this PR, the 11u-vs-mainline GHA diff would be this: [gha-11u-vs-mainline.patch](https://github.com/openjdk/jdk11u-dev/files/12395257/gha-11u-vs-mainline.patch) Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Reapply JDK-8284772: GHA: Use GCC Major Version Dependencies Only ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2090/files - new: https://git.openjdk.org/jdk11u-dev/pull/2090/files/59335b55..934f48a5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2090&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2090&range=00-01 Stats: 22 lines in 3 files changed: 0 ins; 17 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2090.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2090/head:pull/2090 PR: https://git.openjdk.org/jdk11u-dev/pull/2090 From shade at openjdk.org Tue Aug 22 07:49:08 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Aug 2023 07:49:08 GMT Subject: [jdk11u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: References: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> Message-ID: On Tue, 22 Aug 2023 06:13:55 GMT, Aleksey Shipilev wrote: > > Will this change causes the same breakages we had when the minor version of gcc was changed? I prefer to ignore that minor number in GA. > > In current form, yes, that's a risk that is shared with mainline, 21u, 17u, and until recently 11u GHAs. It would still be there until we backport the GHA change that drops the minor GCC version from all GHAs. Actually, we should just reapply [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772) on top, so minor versions get eliminated again. I just approved [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772) for inclusion in mainline, which should eliminate the 11u vs mainline difference again. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2090#issuecomment-1687645747 From goetz at openjdk.org Tue Aug 22 07:53:45 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 22 Aug 2023 07:53:45 GMT Subject: [jdk17u] RFR: 8314677: Bump update version for OpenJDK: jdk-17.0.8.1 [v2] In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 20:02:36 GMT, Ben Taylor wrote: >> Proposed branch for [JDK-8314677](https://bugs.openjdk.org/browse/JDK-8314677) >> >> >> Note that the merge preview on this branch will be incorrect as there is no upstream jdk17.0.8 branch, only a 17.0.8-ga tag. As such the PR is based on `master`. >> Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk17u/compare/jdk-17.0.8-ga...benty-amzn:jdk17u:jdk17.0.8.1?expand=1) >> >> See also previous discussion on #374 > > Ben Taylor has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Update release date to 2023-08-24 LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk17u/pull/375#pullrequestreview-1588694300 From goetz at openjdk.org Tue Aug 22 07:59:35 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 22 Aug 2023 07:59:35 GMT Subject: [jdk11u] RFR: 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 [v2] In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 20:10:12 GMT, Ben Taylor wrote: >> Proposed branch for [JDK-8314678](https://bugs.openjdk.org/browse/JDK-8314678) >> >> >> Note that the merge preview on this branch will be incorrect as there is no upstream jdk11.0.20 branch, only a 11.0.20-ga tag. As such the PR is based on `master`. >> Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk11u/compare/jdk-11.0.20-ga...benty-amzn:jdk11u:jdk11.0.20.1?expand=1) >> >> See also previous discussion on [jdk17u #374](https://github.com/openjdk/jdk17u/pull/374) and [jdk17u #375](https://github.com/openjdk/jdk17u/pull/375) > > Ben Taylor has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk11u/pull/76#pullrequestreview-1588710325 From shade at openjdk.org Tue Aug 22 08:07:37 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Aug 2023 08:07:37 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v3] In-Reply-To: References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: On Fri, 18 Aug 2023 17:05:00 GMT, Dan Lutker wrote: >> Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. >> >> >> bash ./configure --with-jtreg=jtreg-7.3+1 >> make images >> make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" >> >> >> All tests pass. > > Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8314552: Fix javadoc tests to work with jtreg 7 This PR does not need to depend on [openjdk:pr/1673](https://github.com/openjdk/jdk17u-dev/tree/pr/1673). Current jdk17u-dev should compile fine, it is just your [personal fork](https://github.com/lutkerd/jdk17u-dev) is way too old: "This branch is [1 commit ahead](https://github.com/lutkerd/jdk17u-dev/compare/openjdk:jdk17u-dev:master...master), [1480 commits behind](https://github.com/lutkerd/jdk17u-dev/compare/master...openjdk:jdk17u-dev:master) openjdk:master." Please pull new jdk17u-dev to your personal fork, and then rebase for new master. This will let you integrate this PR without waiting unnecessarily for [openjdk:pr/1673](https://github.com/openjdk/jdk17u-dev/tree/pr/1673) to integrate. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1672#issuecomment-1687678182 From goetz at openjdk.org Tue Aug 22 08:15:39 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 22 Aug 2023 08:15:39 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v3] In-Reply-To: References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: On Fri, 18 Aug 2023 17:05:00 GMT, Dan Lutker wrote: >> Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. >> >> >> bash ./configure --with-jtreg=jtreg-7.3+1 >> make images >> make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" >> >> >> All tests pass. > > Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8314552: Fix javadoc tests to work with jtreg 7 Thanks for fixing this! You need to update the branch please so that it can be marked ready. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1672#issuecomment-1687693105 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1672#issuecomment-1687695283 From fjiang at openjdk.org Tue Aug 22 11:09:36 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Tue, 22 Aug 2023 11:09:36 GMT Subject: [jdk17u-dev] RFR: 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java In-Reply-To: References: Message-ID: <_VQNxVOIWkpw31iaf-kyk-Fvi_AnmU7pdjAiALyMV5s=.914e0310-4f2a-4eab-9983-6cb20279a485@github.com> On Mon, 21 Aug 2023 10:50:38 GMT, Feilong Jiang wrote: > This fixes the incorrect VMReg encoding in RISCV64Frame.java for risc-v. > Patch applies clean. Windows x64 GHA failure is JTRreg building issue, not related. Got `fix-request-yes`, going to integrate it then. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1678#issuecomment-1687975906 From fjiang at openjdk.org Tue Aug 22 12:40:42 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Tue, 22 Aug 2023 12:40:42 GMT Subject: [jdk17u-dev] Integrated: 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 10:50:38 GMT, Feilong Jiang wrote: > This fixes the incorrect VMReg encoding in RISCV64Frame.java for risc-v. > Patch applies clean. This pull request has now been integrated. Changeset: 74a12fc2 Author: Feilong Jiang Committer: Fei Yang URL: https://git.openjdk.org/jdk17u-dev/commit/74a12fc23e1c342c8f05e2c3dd2f7d60c63c95b1 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java Backport-of: 5c9162288570a140138a0055cd9c4e88fe40e69d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1678 From fyang at openjdk.org Tue Aug 22 12:42:33 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 22 Aug 2023 12:42:33 GMT Subject: [jdk17u-dev] RFR: 8310873: Re-enable locked_create_entry symbol check in runtime/NMT/CheckForProperDetailStackTrace.java for RISC-V In-Reply-To: References: Message-ID: <_VpD49Rb0hXxk8PxzCXQLE4CUvCOjDTuH7DgXDLUg70=.a6af83de-2d20-436d-9092-6eafabb91eb9@github.com> On Tue, 22 Aug 2023 01:56:01 GMT, Fei Yang wrote: > Clean backport to jdk17u. > This is a test-only change which re-enables the "locked_create_entry" symbol checking in the test for RISC-V. > Testing: This test still passes on linux-riscv platform with this small change. Push approval is here and GHA is clean. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1684#issuecomment-1688106748 From fyang at openjdk.org Tue Aug 22 12:42:34 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 22 Aug 2023 12:42:34 GMT Subject: [jdk17u-dev] Integrated: 8310873: Re-enable locked_create_entry symbol check in runtime/NMT/CheckForProperDetailStackTrace.java for RISC-V In-Reply-To: References: Message-ID: On Tue, 22 Aug 2023 01:56:01 GMT, Fei Yang wrote: > Clean backport to jdk17u. > This is a test-only change which re-enables the "locked_create_entry" symbol checking in the test for RISC-V. > Testing: This test still passes on linux-riscv platform with this small change. This pull request has now been integrated. Changeset: 994f16fe Author: Fei Yang URL: https://git.openjdk.org/jdk17u-dev/commit/994f16fe74f0050b7f474a86dd9088451bd554df Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8310873: Re-enable locked_create_entry symbol check in runtime/NMT/CheckForProperDetailStackTrace.java for RISC-V Backport-of: 87e6fab2c498558d4593f6c0537c998a61779aaf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1684 From robm at openjdk.org Tue Aug 22 12:48:04 2023 From: robm at openjdk.org (Rob McKenna) Date: Tue, 22 Aug 2023 12:48:04 GMT Subject: [jdk21u] Integrated: Merge jdk21:master Message-ID: merge jdk21 master to jdk21u ------------- Commit messages: - Merge - 8314062: ProblemList jdk/jfr/tool/TestView.java on macosx-x64 - 8311179: Generational ZGC: gc/z/TestSmallHeap.java failed with OutOfMemoryError - 8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16 - 8312814: Compiler crash when template processor type is a captured wildcard - 8313345: SuperWord fails due to CMove without matching Bool pack The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk21u&pr=81&range=00.0 - jdk21:master: https://webrevs.openjdk.org/?repo=jdk21u&pr=81&range=00.1 Changes: https://git.openjdk.org/jdk21u/pull/81/files Stats: 170 lines in 8 files changed: 165 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk21u/pull/81.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/81/head:pull/81 PR: https://git.openjdk.org/jdk21u/pull/81 From robm at openjdk.org Tue Aug 22 12:48:04 2023 From: robm at openjdk.org (Rob McKenna) Date: Tue, 22 Aug 2023 12:48:04 GMT Subject: [jdk21u] Integrated: Merge jdk21:master In-Reply-To: References: Message-ID: On Tue, 22 Aug 2023 12:38:17 GMT, Rob McKenna wrote: > merge jdk21 master to jdk21u This pull request has now been integrated. Changeset: e1ef69ab Author: Rob McKenna URL: https://git.openjdk.org/jdk21u/commit/e1ef69abbabe7a8977b70d6ae7bdc6532e72023b Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Merge ------------- PR: https://git.openjdk.org/jdk21u/pull/81 From alexsch at openjdk.org Tue Aug 22 13:36:47 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Tue, 22 Aug 2023 13:36:47 GMT Subject: [jdk11u-dev] Integrated: 8311033: [macos] PrinterJob does not take into account Sides attribute In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 12:28:45 GMT, Alexander Scherbatiy wrote: > This is a clean backport of the fix `8311033: [macos] PrinterJob does not take into account Sides attribute`. > > The fix allows to print pages with `DUPLEX` and `TUMBLE` attributes on macOS. > Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. This pull request has now been integrated. Changeset: d0f6931a Author: Alexander Scherbatiy URL: https://git.openjdk.org/jdk11u-dev/commit/d0f6931ab7f9e3ad30365abfa862958820035ee3 Stats: 335 lines in 4 files changed: 335 ins; 0 del; 0 mod 8311033: [macos] PrinterJob does not take into account Sides attribute Backport-of: a3d67231a71fbe37c509fcedd54c679b4644c0d9 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2091 From alexsch at openjdk.org Tue Aug 22 14:12:23 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Tue, 22 Aug 2023 14:12:23 GMT Subject: [jdk11u-dev] RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation Message-ID: This is a clean backport of the fix `8295737: macOS: Print content cut off when width > height with portrait orientation`. The fix allows to print a page which width is greater than height with portrait orientation on macOS. Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. ------------- Commit messages: - Backport d00a767047ec41e233e711dbc5fe7b8818e72f28 Changes: https://git.openjdk.org/jdk11u-dev/pull/2092/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2092&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295737 Stats: 433 lines in 2 files changed: 430 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2092.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2092/head:pull/2092 PR: https://git.openjdk.org/jdk11u-dev/pull/2092 From mbaesken at openjdk.org Tue Aug 22 14:42:17 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 22 Aug 2023 14:42:17 GMT Subject: [jdk17u-dev] RFR: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 Message-ID: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 ------------- Commit messages: - Backport d24b7b7026cf85f1aecf44f60819762872cfd5c1 Changes: https://git.openjdk.org/jdk17u-dev/pull/1685/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1685&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276651 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1685.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1685/head:pull/1685 PR: https://git.openjdk.org/jdk17u-dev/pull/1685 From btaylor at openjdk.org Tue Aug 22 15:27:18 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 22 Aug 2023 15:27:18 GMT Subject: [jdk11u] Integrated: 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 18:31:14 GMT, Ben Taylor wrote: > Proposed branch for [JDK-8314678](https://bugs.openjdk.org/browse/JDK-8314678) > > > Note that the merge preview on this branch will be incorrect as there is no upstream jdk11.0.20 branch, only a 11.0.20-ga tag. As such the PR is based on `master`. > Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk11u/compare/jdk-11.0.20-ga...benty-amzn:jdk11u:jdk11.0.20.1?expand=1) > > See also previous discussion on [jdk17u #374](https://github.com/openjdk/jdk17u/pull/374) and [jdk17u #375](https://github.com/openjdk/jdk17u/pull/375) This pull request has now been integrated. Changeset: 1b3c516e Author: Ben Taylor Committer: Volker Simonis URL: https://git.openjdk.org/jdk11u/commit/1b3c516eff4fcfb67cea4005be80d0812b2a74f0 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 Reviewed-by: simonis, goetz ------------- PR: https://git.openjdk.org/jdk11u/pull/76 From btaylor at openjdk.org Tue Aug 22 15:27:18 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 22 Aug 2023 15:27:18 GMT Subject: [jdk17u] Integrated: 8314677: Bump update version for OpenJDK: jdk-17.0.8.1 In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 17:55:53 GMT, Ben Taylor wrote: > Proposed branch for [JDK-8314677](https://bugs.openjdk.org/browse/JDK-8314677) > > > Note that the merge preview on this branch will be incorrect as there is no upstream jdk17.0.8 branch, only a 17.0.8-ga tag. As such the PR is based on `master`. > Changes against the GA tag can be viewed at [diff](https://github.com/openjdk/jdk17u/compare/jdk-17.0.8-ga...benty-amzn:jdk17u:jdk17.0.8.1?expand=1) > > See also previous discussion on #374 This pull request has now been integrated. Changeset: b31f232f Author: Ben Taylor Committer: Volker Simonis URL: https://git.openjdk.org/jdk17u/commit/b31f232f9acff5a08a18759e6ba408da64938b43 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8314677: Bump update version for OpenJDK: jdk-17.0.8.1 Reviewed-by: simonis, goetz ------------- PR: https://git.openjdk.org/jdk17u/pull/375 From btaylor at openjdk.org Tue Aug 22 15:27:26 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 22 Aug 2023 15:27:26 GMT Subject: [jdk17u] RFR: Backport 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: > Backport of 8313765: Invalid CEN header (invalid zip64 extra data field size), [jdk17u-dev #1670](https://github.com/openjdk/jdk17u-dev/pull/1670) for the 17.0.8.1 patch release. Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8313765: Invalid CEN header (invalid zip64 extra data field size) Reviewed-by: andrew, serb Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524 ------------- Changes: https://git.openjdk.org/jdk17u/pull/376/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=376&range=01 Stats: 999 lines in 4 files changed: 986 ins; 1 del; 12 mod Patch: https://git.openjdk.org/jdk17u/pull/376.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/376/head:pull/376 PR: https://git.openjdk.org/jdk17u/pull/376 From btaylor at openjdk.org Tue Aug 22 15:28:48 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 22 Aug 2023 15:28:48 GMT Subject: [jdk11u] RFR: Backport 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: > Backport of 8313765: Invalid CEN header (invalid zip64 extra data field size), [jdk11u-dev #2084](https://github.com/openjdk/jdk11u-dev/pull/2084) for the 11.0.20.1 patch release. Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8313765: Invalid CEN header (invalid zip64 extra data field size) Reviewed-by: andrew, serb Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524 ------------- Changes: https://git.openjdk.org/jdk11u/pull/77/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=77&range=01 Stats: 1001 lines in 4 files changed: 987 ins; 1 del; 13 mod Patch: https://git.openjdk.org/jdk11u/pull/77.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/77/head:pull/77 PR: https://git.openjdk.org/jdk11u/pull/77 From duke at openjdk.org Tue Aug 22 16:12:48 2023 From: duke at openjdk.org (Dan Lutker) Date: Tue, 22 Aug 2023 16:12:48 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v4] In-Reply-To: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: > Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. > > > bash ./configure --with-jtreg=jtreg-7.3+1 > make images > make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" > > > All tests pass. Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8314552: Fix javadoc tests to work with jtreg 7 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/1672/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1672&range=03 Stats: 18 lines in 6 files changed: 6 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1672.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1672/head:pull/1672 PR: https://git.openjdk.org/jdk17u-dev/pull/1672 From duke at openjdk.org Tue Aug 22 16:13:18 2023 From: duke at openjdk.org (Dan Lutker) Date: Tue, 22 Aug 2023 16:13:18 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v3] In-Reply-To: References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: On Fri, 18 Aug 2023 17:05:00 GMT, Dan Lutker wrote: >> Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. >> >> >> bash ./configure --with-jtreg=jtreg-7.3+1 >> make images >> make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" >> >> >> All tests pass. > > Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. Rebased and updated to target master so it can be merged on its own. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1672#issuecomment-1688468524 From simonis at openjdk.org Tue Aug 22 16:55:48 2023 From: simonis at openjdk.org (Volker Simonis) Date: Tue, 22 Aug 2023 16:55:48 GMT Subject: [jdk17u] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: On Tue, 22 Aug 2023 15:27:26 GMT, Ben Taylor wrote: >> Backport of 8313765: Invalid CEN header (invalid zip64 extra data field size), [jdk17u-dev #1670](https://github.com/openjdk/jdk17u-dev/pull/1670) for the 17.0.8.1 patch release. > > Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8313765: Invalid CEN header (invalid zip64 extra data field size) > > Reviewed-by: andrew, serb > Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524 Thanks for doing the downport! Looks good to me. ------------- Marked as reviewed by simonis (Reviewer). PR Review: https://git.openjdk.org/jdk17u/pull/376#pullrequestreview-1589903373 From simonis at openjdk.org Tue Aug 22 16:56:48 2023 From: simonis at openjdk.org (Volker Simonis) Date: Tue, 22 Aug 2023 16:56:48 GMT Subject: [jdk11u] RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v2] In-Reply-To: References: Message-ID: On Tue, 22 Aug 2023 15:28:48 GMT, Ben Taylor wrote: >> Backport of 8313765: Invalid CEN header (invalid zip64 extra data field size), [jdk11u-dev #2084](https://github.com/openjdk/jdk11u-dev/pull/2084) for the 11.0.20.1 patch release. > > Ben Taylor has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > 8313765: Invalid CEN header (invalid zip64 extra data field size) > > Reviewed-by: andrew, serb > Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524 Thanks for doing the downport! Looks good to me. ------------- Marked as reviewed by simonis (Reviewer). PR Review: https://git.openjdk.org/jdk11u/pull/77#pullrequestreview-1589900814 From phh at openjdk.org Tue Aug 22 16:57:47 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 22 Aug 2023 16:57:47 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v4] In-Reply-To: References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: On Tue, 22 Aug 2023 16:12:48 GMT, Dan Lutker wrote: >> Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. >> >> >> bash ./configure --with-jtreg=jtreg-7.3+1 >> make images >> make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" >> >> >> All tests pass. > > Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > 8314552: Fix javadoc tests to work with jtreg 7 Still good. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1672#pullrequestreview-1589901186 From tsteele at openjdk.org Tue Aug 22 16:59:21 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Tue, 22 Aug 2023 16:59:21 GMT Subject: [jdk21u] RFR: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) Message-ID: Hi all, This pull request contains a backport of commit [fdac6a6a](https://github.com/openjdk/jdk/commit/fdac6a6ac871366614efe44aca58ab520766b5c8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. It fixes TestByteBuffer.java, and depends on changes the backported by #77. The commit being backported was authored by Tyler Steele on 18 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe. Thanks! ------------- Commit messages: - Backport 395fc78880a91eeb06a08c1abf6905d580a650c0 Changes: https://git.openjdk.org/jdk21u/pull/82/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=82&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309475 Stats: 235 lines in 3 files changed: 210 ins; 25 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/82.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/82/head:pull/82 PR: https://git.openjdk.org/jdk21u/pull/82 From shade at openjdk.org Tue Aug 22 17:26:18 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 22 Aug 2023 17:26:18 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v4] In-Reply-To: References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: On Tue, 22 Aug 2023 16:12:48 GMT, Dan Lutker wrote: >> Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. >> >> >> bash ./configure --with-jtreg=jtreg-7.3+1 >> make images >> make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" >> >> >> All tests pass. > > Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8314552: Fix javadoc tests to work with jtreg 7 Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1672#pullrequestreview-1589947529 From dholmes at openjdk.org Wed Aug 23 01:46:17 2023 From: dholmes at openjdk.org (David Holmes) Date: Wed, 23 Aug 2023 01:46:17 GMT Subject: [jdk21u] RFR: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out Message-ID: Hi all, This pull request contains a backport of commit [f142470d](https://github.com/openjdk/jdk/commit/f142470deaebbf9cff7f6f28842972393506b7c4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by David Holmes on 14 Aug 2023 and was reviewed by Stefan Karlsson, Patricio Chilano Mateo, Daniel D. Daugherty and Robbin Ehn. Thanks! ------------- Commit messages: - Backport f142470deaebbf9cff7f6f28842972393506b7c4 Changes: https://git.openjdk.org/jdk21u/pull/83/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=83&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311981 Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/83.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/83/head:pull/83 PR: https://git.openjdk.org/jdk21u/pull/83 From goetz.lindenmaier at sap.com Wed Aug 23 06:02:22 2023 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 23 Aug 2023 06:02:22 +0000 Subject: [17u, 11u notice] Patch updates 17.0.8.1 and 11.0.20.1 have been pushed Message-ID: Hi, we tagged updates 17.0.8.1 and 11.0.20.1 to fix a regression in the July updates: JDK-8313765: Invalid CEN header (invalid zip64 extra data field size). [1] 17u: Tag jdk-17.0.8.1-ga in https://github.com/openjdk/jdk17u 11u: Tag jdk-11.0.20.1-ga in https://github.com/openjdk/jdk11u Best regards, Goetz [1] https://bugs.openjdk.org/browse/JDK-8313765 -------------- next part -------------- An HTML attachment was scrubbed... URL: From goetz.lindenmaier at sap.com Wed Aug 23 06:08:09 2023 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 23 Aug 2023 06:08:09 +0000 Subject: [17u reminder]: jdk 17.0.9 rampdown starts Tuesday, August 29, 18:00 CET. Message-ID: Hi I would like to remind everybody who is working on jdk 17 updates that rampdown of 17.0.9 starts next Tuesday, August 29, at 18:00 CET. At that point in time the last merge from jdk11u-dev to jdk17u will take place. Please push all changes you want to get to 17.0.9 before that date. After that, changes for 17.0.9 must be requested with jdk17u-critical-request tags, and they need to be pushed directly to jdk17u. Best regards, Goetz See also https://wiki.openjdk.java.net/display/JDKUpdates/JDK+17u -------------- next part -------------- An HTML attachment was scrubbed... URL: From goetz.lindenmaier at sap.com Wed Aug 23 06:08:28 2023 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 23 Aug 2023 06:08:28 +0000 Subject: [11u reminder]: jdk 11.0.21 rampdown starts Tuesday, August 29, 18:00 CET. Message-ID: Hi I would like to remind everybody who is working on jdk 11 updates that rampdown of 11.0.21 starts next Tuesday, August 29, at 18:00 CET. At that point in time the last merge from jdk11u-dev to jdk11u will take place. Please push all changes you want to get to 11.0.21 before that date. After that, changes for 11.0.21 must be requested with jdk11u-critical-request tags, and they need to be pushed directly to jdk11u. Best regards, Goetz See also https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u -------------- next part -------------- An HTML attachment was scrubbed... URL: From volker.simonis at gmail.com Wed Aug 23 07:09:30 2023 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 23 Aug 2023 09:09:30 +0200 Subject: [17u, 11u notice] Patch updates 17.0.8.1 and 11.0.20.1 have been pushed In-Reply-To: References: Message-ID: Thanks a lot G?tz! Lindenmaier, Goetz schrieb am Mi., 23. Aug. 2023, 08:02: > Hi, > > > > we tagged updates 17.0.8.1 and 11.0.20.1 to fix a regression in > > the July updates: > > JDK-8313765: Invalid CEN header (invalid zip64 extra data field size). [1] > > > > 17u: Tag jdk-17.0.8.1-ga in https://github.com/openjdk/jdk17u > > 11u: Tag jdk-11.0.20.1-ga in https://github.com/openjdk/jdk11u > > > > Best regards, > > Goetz > > > > [1] https://bugs.openjdk.org/browse/JDK-8313765 > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From gcao at openjdk.org Wed Aug 23 09:17:34 2023 From: gcao at openjdk.org (Gui Cao) Date: Wed, 23 Aug 2023 09:17:34 GMT Subject: [jdk21u] RFR: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected In-Reply-To: References: Message-ID: On Tue, 22 Aug 2023 03:08:46 GMT, Gui Cao wrote: > Hi, This issue also exists in the JDK21U, so i would like to backport this to jdk21u make -XX:MaxVectorSize work correctly on Linux RISC-V platform. > `test/hotspot/jtreg/compiler/loopopts/superword/TestUnorderedReduction.java` passed with fastdebug and use build using qemu. Got the push approval ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/80#issuecomment-1689328077 From gcao at openjdk.org Wed Aug 23 09:17:37 2023 From: gcao at openjdk.org (Gui Cao) Date: Wed, 23 Aug 2023 09:17:37 GMT Subject: [jdk21u] Integrated: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected In-Reply-To: References: Message-ID: On Tue, 22 Aug 2023 03:08:46 GMT, Gui Cao wrote: > Hi, This issue also exists in the JDK21U, so i would like to backport this to jdk21u make -XX:MaxVectorSize work correctly on Linux RISC-V platform. > `test/hotspot/jtreg/compiler/loopopts/superword/TestUnorderedReduction.java` passed with fastdebug and use build using qemu. This pull request has now been integrated. Changeset: 89aea0da Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk21u/commit/89aea0dace4afd2b1bbc5d636322969afcf0072c Stats: 4 lines in 2 files changed: 1 ins; 1 del; 2 mod 8314618: RISC-V: -XX:MaxVectorSize does not work as expected Backport-of: a66b5df14a163d2990e6dd746906942367e4fdb2 ------------- PR: https://git.openjdk.org/jdk21u/pull/80 From shade at openjdk.org Wed Aug 23 09:17:52 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:17:52 GMT Subject: [jdk21u] RFR: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError Message-ID: <60lChuN6oKVRLrm93XGjRGo5Ket6_OL2_kWNHsPnsHg=.75bab692-d5f5-4307-b186-39e31acc1a2a@github.com> Clean backport to stabilize test. Additional testing: - [x] Affected test passes with 100+ repetitions ------------- Commit messages: - Backport d1de3d082ef9b83aaa68664e653ab09feb8bad87 Changes: https://git.openjdk.org/jdk21u/pull/84/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=84&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313901 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/84.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/84/head:pull/84 PR: https://git.openjdk.org/jdk21u/pull/84 From shade at openjdk.org Wed Aug 23 09:17:40 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:17:40 GMT Subject: [jdk21u] RFR: 8313752: InstanceKlassFlags::print_on doesn't print the flag names Message-ID: Clean backport to fix JDK 21 regression in diagnostic printing. Additional testing: - [x] New test passes with the fix, fails without it ------------- Commit messages: - Backport 735b16a6969ba5998b4f809927e5ac42a7e72d2d Changes: https://git.openjdk.org/jdk21u/pull/87/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=87&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313752 Stats: 7 lines in 4 files changed: 3 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk21u/pull/87.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/87/head:pull/87 PR: https://git.openjdk.org/jdk21u/pull/87 From shade at openjdk.org Wed Aug 23 09:17:56 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:17:56 GMT Subject: [jdk21u] RFR: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev Message-ID: Clean backport to improve GHA stability. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 69d900d2ce97e5479020cff9a63c471d07e39989 Changes: https://git.openjdk.org/jdk21u/pull/85/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=85&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314730 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/85.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/85/head:pull/85 PR: https://git.openjdk.org/jdk21u/pull/85 From btaylor at openjdk.org Wed Aug 23 09:18:16 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 23 Aug 2023 09:18:16 GMT Subject: [jdk17u] Integrated: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 20:03:31 GMT, Ben Taylor wrote: > Backport of 8313765: Invalid CEN header (invalid zip64 extra data field size), [jdk17u-dev #1670](https://github.com/openjdk/jdk17u-dev/pull/1670) for the 17.0.8.1 patch release. This pull request has now been integrated. Changeset: 0f29caa3 Author: Ben Taylor Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u/commit/0f29caa372f605210b4569bf2be26a55946943b3 Stats: 999 lines in 4 files changed: 986 ins; 1 del; 12 mod 8313765: Invalid CEN header (invalid zip64 extra data field size) Reviewed-by: simonis Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524 ------------- PR: https://git.openjdk.org/jdk17u/pull/376 From shade at openjdk.org Wed Aug 23 09:18:44 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:18:44 GMT Subject: [jdk17u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 12:47:15 GMT, Thomas Stuefe wrote: > Unclean composite backport to jdk17u. Fixes JDK-8312182 - "THPs cause huge RSS due to thread start timing issue" (https://bugs.openjdk.org/browse/JDK-8312182) > > Problem: > > On a machine with transparent huge pages (THP) unconditionally enabled (/sys/kernel/mm/transparent_hugepage/enabled = "always"), the JVM may show a huge memory footprint (RSS) and degraded thread start performance. > > The following factors make the problem more severe and more likely: > - thread stack size of 2M (on arm64 or x64) or larger > - many threads, or high thread creation churn > - a slow or overloaded machine (since part of the problem is timing-dependent) > > For a detailed discussion of the underlying problem, please see https://github.com/openjdk/jdk/pull/14919. > > ---------------- > > In jdk Head, the issue got fixed with a sequence of patches: > > - [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) "Make thread stacks not use huge pages" > - [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) "THPs cause huge RSS due to thread start timing" > > However, JDK-8312182 itself needed one preparatory fix: > - [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) "Fix THP detection on Linux" > > and then we had several corner-case test problems which are fixed with: > - [JDK-8312394](https://bugs.openjdk.org/browse/JDK-8312394) "[linux] SIGSEGV if kernel was built without hugepage support" > - [JDK-8312620](https://bugs.openjdk.org/browse/JDK-8312620) "WSL Linux build crashes after JDK-8310233" > - [JDK-8314139](https://bugs.openjdk.org/browse/JDK-8314139) "TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores" > > and finally, we decided to rename the switch that allows to switch off the THP mitigation with a final patch: > - [JDK-8312585](https://bugs.openjdk.org/browse/JDK-8312585) "Rename DisableTHPStackMitigation flag to THPStackMitigation" > > > Instead of downporting these 7 patches verbatim, I prepared a composite patch containing only the necessary mitigation and mitigation tests. > > This is similar to the [jdk11u downport](https://github.com/openjdk/jdk11u-dev/pull/2086), but in jdk17u, [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) had been already backported. Therefore there are some minor differences. > > This patch does: > - make sure that all thread stacks have at least one glibc guard page to prevent clustering of adjacent thread stacks into one VMA > - change the default size of stacks to be not aligned to 2MB to prevent intra-stack... Process-wise and for historical record, if you do a composite patch out of several issues, you need at least mark those issues as fixed by this PR. Tell bot like this: `/issue add 8303215,8312182,...` ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1679#issuecomment-1689464699 From kevinw at openjdk.org Wed Aug 23 09:18:56 2023 From: kevinw at openjdk.org (Kevin Walls) Date: Wed, 23 Aug 2023 09:18:56 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v4] In-Reply-To: References: Message-ID: <2s1GSXw6D_3-APbVF4-8ZWWXsPao6BQ-4JlRxw1NDnA=.a9354f1a-39e9-4b0b-bef3-818eb0a6eae2@github.com> On Tue, 15 Aug 2023 07:05:08 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into 8313815 > - Merge master > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Yes of course. On the jbs entry, I think that should have been a jdk17u-fix-request label, so I updated it. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1689571130 From ogillespie at openjdk.org Wed Aug 23 09:18:52 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Wed, 23 Aug 2023 09:18:52 GMT Subject: [jdk17u-dev] RFR: 8313678: SymbolTable can leak Symbols during cleanup In-Reply-To: References: Message-ID: <8CAr33L3Md3d6jDKibfnbe4Vmbp31Xln_ZywNRnFUN0=.c600b4fc-be65-4868-a258-5fa430f86126@github.com> On Fri, 18 Aug 2023 16:31:51 GMT, Oli Gillespie wrote: > Backporting fix for symbol table leak from https://bugs.openjdk.org/browse/JDK-8313678. > > Not totally clean: > > * places where 17 uses NULL versus nullptr in tip, trivial fix > * symbolTable uses `Symbol**` in 17 instead of `Symbol*`, also easy fix > * dictionary.cpp is not a concurrent hash table in 17 (missing 8292680), so no need to modify it > * finalizerService, g1CardSet, DynamicSharedSymbols test don't exist in 17 Thanks. > Could you please check that the test addition is sensitive to this bug? I.e. locally revert every hunk except the test one, would the test fail then? Yes, confirmed. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1674#issuecomment-1689501622 From shade at openjdk.org Wed Aug 23 09:18:54 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:18:54 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v4] In-Reply-To: References: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> Message-ID: On Wed, 16 Aug 2023 12:36:01 GMT, Thomas Stuefe wrote: > Okay, we see still problems in head at SAP. https://bugs.openjdk.org/browse/JDK-8314426. Lets wait with the downport till that one is fixed. Should be quick, hopefully. OK, I lined up the backport to 17u-dev for that fix here: #1687. Assuming that passes GHA testing, are we good with integrating all three PRs in 17u-dev? I would like to reserve some time to deal with any other low-probability fallout before 17.0.9 stabilization form. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1689457291 From stuefe at openjdk.org Wed Aug 23 09:18:58 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 23 Aug 2023 09:18:58 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v4] In-Reply-To: References: <6tAZ1V__ijuXfn6EcRyF4Y3TUA4rIyf7vG6qcvrZ3p0=.97b5bc8f-e57f-43fa-bb7a-c9b9636ef784@github.com> Message-ID: <2tEEGHviPN4RbamgZFHjqUWlr49YDp98xOsiRzE5LqU=.ef17521e-1354-4a59-b249-cbb6b6f8bb10@github.com> On Wed, 23 Aug 2023 07:47:33 GMT, Aleksey Shipilev wrote: > > Okay, we see still problems in head at SAP. https://bugs.openjdk.org/browse/JDK-8314426. Lets wait with the downport till that one is fixed. Should be quick, hopefully. > > OK, I lined up the backport to 17u-dev for that fix here: #1687. Assuming that passes GHA testing, are we good with integrating all three PRs in 17u-dev? I would like to reserve some time to deal with any other low-probability fallout before 17.0.9 stabilization form. I'm fine with it, but note that I will be gone throughout September. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1689509037 From shade at openjdk.org Wed Aug 23 09:19:08 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:19:08 GMT Subject: [jdk17u-dev] RFR: 8293851: hs_err should print more stack in hex dump In-Reply-To: References: Message-ID: <_gEsR7zq0aCkeHIf5iVlCfVBBpjI2LB1593eHc28yaA=.11e9b37a-e9e2-496b-8bd9-b3a8f5cf7a89@github.com> On Mon, 21 Aug 2023 09:51:21 GMT, Aleksey Shipilev wrote: > Clean backport to improve post-mortem diagnostics, and provide cleaner ground for the subsequent backports in the same area. > > Addtional testing: > - [x] Eye-balling the `hs_err` from artificial crash on MacOS AArch64 > - [x] MacOS server aarch64 fastdebug, `runtime/ErrorHandling` Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1677#issuecomment-1689355429 From shade at openjdk.org Wed Aug 23 09:19:10 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:19:10 GMT Subject: [jdk17u-dev] RFR: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails In-Reply-To: References: Message-ID: <9XlSBheMfAbJPONp9jRCkO8k6Rfv9TQTqB4lnL8OftM=.37a80be4-6583-4c6e-8d07-9265b2b1f324@github.com> On Mon, 21 Aug 2023 09:42:07 GMT, Aleksey Shipilev wrote: > Clean backport to fix the test failure with Shenandoah. > > Additional testing: > - [x] Test fails with Shenandoah without the fix, passes with it Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1676#issuecomment-1689356094 From shade at openjdk.org Wed Aug 23 09:19:10 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:19:10 GMT Subject: [jdk17u-dev] Integrated: 8293851: hs_err should print more stack in hex dump In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 09:51:21 GMT, Aleksey Shipilev wrote: > Clean backport to improve post-mortem diagnostics, and provide cleaner ground for the subsequent backports in the same area. > > Addtional testing: > - [x] Eye-balling the `hs_err` from artificial crash on MacOS AArch64 > - [x] MacOS server aarch64 fastdebug, `runtime/ErrorHandling` This pull request has now been integrated. Changeset: d35a8963 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/d35a896350979d402af70c625a3b550178c10019 Stats: 41 lines in 13 files changed: 7 ins; 12 del; 22 mod 8293851: hs_err should print more stack in hex dump Backport-of: cbd0688b321ff88a405be4f7929d6862e543ab50 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1677 From shade at openjdk.org Wed Aug 23 09:19:12 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:19:12 GMT Subject: [jdk17u-dev] Integrated: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails In-Reply-To: References: Message-ID: <1eT7ngai3rr2ofT4wOVDQeLibct3Y8ybPJO4aCLybkw=.ad5684ba-e90e-42ea-9f0e-651d16419914@github.com> On Mon, 21 Aug 2023 09:42:07 GMT, Aleksey Shipilev wrote: > Clean backport to fix the test failure with Shenandoah. > > Additional testing: > - [x] Test fails with Shenandoah without the fix, passes with it This pull request has now been integrated. Changeset: 49ffbcf4 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/49ffbcf4bcfa74973b651980d97514ee942a82fe Stats: 7 lines in 2 files changed: 1 ins; 3 del; 3 mod 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails Backport-of: 812f475bc4ea84225e8bbb0b5a677eed0af864dd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1676 From shade at openjdk.org Wed Aug 23 09:19:16 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:19:16 GMT Subject: [jdk17u-dev] RFR: 8314658: [17u] GHA: Sync up debian-version for cross-builds In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 15:02:46 GMT, Aleksey Shipilev wrote: > [JDK-8283929](https://bugs.openjdk.org/browse/JDK-8283929) brought the change to cross-compilation configs that bootstrapped with "buster". This was a deviation from the original change, AFAICS because the runners were still on Ubuntu 20.04. > > After the upgrade to Ubuntu 22.04 runner with [JDK-8312511](https://bugs.openjdk.org/browse/JDK-8312511), it would make more sense to bootstrap with "bullseye", like current mainline that also runs with 22.04 does. This avoids accidental infra breakages that would be only detectable on 17u, not on mainline. > > Additional testing: > - [x] GHA Testing is clean. Review is here. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1681#issuecomment-1689353120 From shade at openjdk.org Wed Aug 23 09:19:20 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:19:20 GMT Subject: [jdk17u-dev] Integrated: 8314658: [17u] GHA: Sync up debian-version for cross-builds In-Reply-To: References: Message-ID: <0Xh_Zhekynfxs1xp5cvqRcV91Dvn-irwCqNNWa19e1w=.38d2c0c6-b51c-421f-a354-6f07ac431639@github.com> On Mon, 21 Aug 2023 15:02:46 GMT, Aleksey Shipilev wrote: > [JDK-8283929](https://bugs.openjdk.org/browse/JDK-8283929) brought the change to cross-compilation configs that bootstrapped with "buster". This was a deviation from the original change, AFAICS because the runners were still on Ubuntu 20.04. > > After the upgrade to Ubuntu 22.04 runner with [JDK-8312511](https://bugs.openjdk.org/browse/JDK-8312511), it would make more sense to bootstrap with "bullseye", like current mainline that also runs with 22.04 does. This avoids accidental infra breakages that would be only detectable on 17u, not on mainline. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 3f8e9953 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/3f8e9953f200985958a93d4bf30c2f213c02efce Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8314658: [17u] GHA: Sync up debian-version for cross-builds Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1681 From btaylor at openjdk.org Wed Aug 23 09:19:32 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 23 Aug 2023 09:19:32 GMT Subject: [jdk11u] Integrated: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 20:05:53 GMT, Ben Taylor wrote: > Backport of 8313765: Invalid CEN header (invalid zip64 extra data field size), [jdk11u-dev #2084](https://github.com/openjdk/jdk11u-dev/pull/2084) for the 11.0.20.1 patch release. This pull request has now been integrated. Changeset: fffaff3d Author: Ben Taylor Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u/commit/fffaff3d5e823187acbf7783339ee3df77580a00 Stats: 1001 lines in 4 files changed: 987 ins; 1 del; 13 mod 8313765: Invalid CEN header (invalid zip64 extra data field size) Reviewed-by: simonis Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524 ------------- PR: https://git.openjdk.org/jdk11u/pull/77 From shade at openjdk.org Wed Aug 23 09:18:47 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:18:47 GMT Subject: [jdk17u-dev] RFR: 8313678: SymbolTable can leak Symbols during cleanup In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 16:31:51 GMT, Oli Gillespie wrote: > Backporting fix for symbol table leak from https://bugs.openjdk.org/browse/JDK-8313678. > > Not totally clean: > > * places where 17 uses NULL versus nullptr in tip, trivial fix > * symbolTable uses `Symbol**` in 17 instead of `Symbol*`, also easy fix > * dictionary.cpp is not a concurrent hash table in 17 (missing 8292680), so no need to modify it > * finalizerService, g1CardSet, DynamicSharedSymbols test don't exist in 17 This looks fine. Could you please check that the test addition is sensitive to this bug? I.e. locally revert every hunk except the test one, would the test fail then? ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1674#pullrequestreview-1590943028 From shade at openjdk.org Wed Aug 23 09:18:15 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:18:15 GMT Subject: [jdk21u] RFR: 8314426: runtime/os/TestTrimNative.java is failing on slow machines Message-ID: Clean backport to stabilize the test. Additional testing: - [x] 100+ repetitions of affected test ------------- Commit messages: - Backport 20e94784c9f7c30e95550c72aedb5e986a153114 Changes: https://git.openjdk.org/jdk21u/pull/86/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=86&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314426 Stats: 6 lines in 1 file changed: 3 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/86.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/86/head:pull/86 PR: https://git.openjdk.org/jdk21u/pull/86 From shade at openjdk.org Wed Aug 23 09:20:03 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:20:03 GMT Subject: [jdk11u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 [v2] In-Reply-To: References: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> Message-ID: On Tue, 22 Aug 2023 07:49:08 GMT, Aleksey Shipilev wrote: >> This similar to the bulk GHA update we did here: https://github.com/shipilev/jdk17u-dev/commit/260f28761a87553fd634615df5ba3db5b76ae692 -- but now for 11u. >> >> Note this reverts and then reapplies [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772) to avoid backport conflicts. >> >> There are other GHA improvements we would backport later. This one atomic PR brings in 11u GHA closer to mainline GHA state without breaking the builds. For reference, after this PR, the 11u-vs-mainline GHA diff would be this: [gha-11u-vs-mainline.patch](https://github.com/openjdk/jdk11u-dev/files/12395257/gha-11u-vs-mainline.patch) > > Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: > > Reapply JDK-8284772: GHA: Use GCC Major Version Dependencies Only I think we should proceed with this. Can I have some formal reviews? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2090#issuecomment-1689374445 From shade at openjdk.org Wed Aug 23 09:20:04 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:20:04 GMT Subject: [jdk17u-dev] RFR: 8314020: Print instruction blocks in byte units Message-ID: Semi-clean backport to improve post-mortem diagnostics. Two conflicts: - In `os.hpp` we have a contextual differences due to Loom integration, applied the hunk by hand - In `os_linux_zero.cpp`, the contextual difference due to missing [JDK-8294211](https://bugs.openjdk.org/browse/JDK-8294211), which I do not want to backport yet; skipped the hunk Additional testing: - [x] Eyeballing the artificial crash ------------- Commit messages: - Backport a602624ef46908456052146d50467c60efa636c3 Changes: https://git.openjdk.org/jdk17u-dev/pull/1686/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1686&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314020 Stats: 11 lines in 11 files changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1686.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1686/head:pull/1686 PR: https://git.openjdk.org/jdk17u-dev/pull/1686 From shade at openjdk.org Wed Aug 23 09:20:27 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 23 Aug 2023 09:20:27 GMT Subject: [jdk17u-dev] RFR: 8314426: runtime/os/TestTrimNative.java is failing on slow machines Message-ID: Clean backport, further stabilization of the test. Additional testing: - [x] 100+ iterations of affected test on Linux x86_64 fastdebug ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/1662 Commit messages: - Backport 20e94784c9f7c30e95550c72aedb5e986a153114 Changes: https://git.openjdk.org/jdk17u-dev/pull/1687/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1687&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314426 Stats: 6 lines in 1 file changed: 3 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1687.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1687/head:pull/1687 PR: https://git.openjdk.org/jdk17u-dev/pull/1687 From duke at openjdk.org Wed Aug 23 09:21:23 2023 From: duke at openjdk.org (toshiogata) Date: Wed, 23 Aug 2023 09:21:23 GMT Subject: [jdk11u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags Message-ID: Hi all, This is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags JDK11 reproduces the reported bug, so this patch should be applied. There is a related Issue: JDK-8217850, and I submit the corresponding PR. The original patch is applied cleanly. Testing: all serviceability agent tests,?hotspot_all and the test which comes with this patch Thank you. ------------- Commit messages: - Backport d6a75a0f86d4c84132a3794c432b34068163fa60 Changes: https://git.openjdk.org/jdk11u-dev/pull/2093/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2093&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8217612 Stats: 122 lines in 3 files changed: 113 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2093.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2093/head:pull/2093 PR: https://git.openjdk.org/jdk11u-dev/pull/2093 From ogillespie at openjdk.org Wed Aug 23 10:17:25 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Wed, 23 Aug 2023 10:17:25 GMT Subject: [jdk21u] RFR: 8313874: JNI NewWeakGlobalRef throws exception for null arg Message-ID: Hi all, This pull request contains a clean backport of commit [028b3ae1](https://github.com/openjdk/jdk/commit/028b3ae1b162bd8f7c340bfa6e9487ca83697955) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Oli Gillespie on 10 Aug 2023 and was reviewed by David Holmes, Kim Barrett and Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport 028b3ae1b162bd8f7c340bfa6e9487ca83697955 Changes: https://git.openjdk.org/jdk21u/pull/88/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=88&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313874 Stats: 11 lines in 2 files changed: 10 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/88.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/88/head:pull/88 PR: https://git.openjdk.org/jdk21u/pull/88 From ogillespie at openjdk.org Wed Aug 23 10:24:45 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Wed, 23 Aug 2023 10:24:45 GMT Subject: [jdk17u-dev] RFR: 8313874: JNI NewWeakGlobalRef throws exception for null arg Message-ID: Nearly clean backport for https://bugs.openjdk.org/browse/JDK-8313874, the only difference is 17 using `NULL` compared to `nullptr` in tip required a manual (but trivial) merge. ------------- Commit messages: - Backport 028b3ae1b162bd8f7c340bfa6e9487ca83697955 Changes: https://git.openjdk.org/jdk17u-dev/pull/1688/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1688&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313874 Stats: 11 lines in 2 files changed: 10 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1688.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1688/head:pull/1688 PR: https://git.openjdk.org/jdk17u-dev/pull/1688 From lucy at openjdk.org Wed Aug 23 10:51:12 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 23 Aug 2023 10:51:12 GMT Subject: [jdk11u-dev] RFR: 8306881: Update FreeType to 2.13.0 Message-ID: Fix Request (11u): Should get backported for parity with 11.0.21-oracle. Applies cleanly. To prevent MacOS build failures (compiler warnings) with GHA, the workaround from jdk17u (https://git.openjdk.org/jdk17u-dev/pull/1504) was added as an additional commit. Tests (SAP-internal and GHA) pending. Review pending. ------------- Commit messages: - JDK-8306881 Fix make warning when old make toolchain is used - Backport 723582c524c62ee73f7984a53b046f8832b23a7f Changes: https://git.openjdk.org/jdk11u-dev/pull/2094/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2094&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306881 Stats: 3607 lines in 284 files changed: 1611 ins; 690 del; 1306 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2094.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2094/head:pull/2094 PR: https://git.openjdk.org/jdk11u-dev/pull/2094 From mdoerr at openjdk.org Wed Aug 23 10:56:34 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 23 Aug 2023 10:56:34 GMT Subject: [jdk11u-dev] RFR: 8306881: Update FreeType to 2.13.0 In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 10:44:31 GMT, Lutz Schmidt wrote: > Fix Request (11u): > Should get backported for parity with 11.0.21-oracle. Applies cleanly. > To prevent MacOS build failures (compiler warnings) with GHA, the workaround from jdk17u (https://git.openjdk.org/jdk17u-dev/pull/1504) was added as an additional commit. > > Tests (SAP-internal and GHA) pending. > Review pending. Thanks for backporting it together with my workaround for the build warning. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2094#pullrequestreview-1591318401 From mbaesken at openjdk.org Wed Aug 23 11:57:53 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 23 Aug 2023 11:57:53 GMT Subject: [jdk21u] RFR: 8314517: some tests fail in case ipv6 is disabled on the machine Message-ID: <00Odsd73GT1O4FJ-V8ucuPPNCvd6j3114aOT4YhtcRs=.38771097-edff-419a-8d84-12347d84603a@github.com> 8314517: some tests fail in case ipv6 is disabled on the machine ------------- Commit messages: - Backport 703817d21f6fd8b24cc670695625dfdb09d3592c Changes: https://git.openjdk.org/jdk21u/pull/89/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=89&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314517 Stats: 82 lines in 6 files changed: 34 ins; 1 del; 47 mod Patch: https://git.openjdk.org/jdk21u/pull/89.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/89/head:pull/89 PR: https://git.openjdk.org/jdk21u/pull/89 From aivanov at openjdk.org Wed Aug 23 12:03:06 2023 From: aivanov at openjdk.org (Alexey Ivanov) Date: Wed, 23 Aug 2023 12:03:06 GMT Subject: [jdk21u] RFR: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1) Message-ID: This pull request contains a backport of commit [62610203](https://github.com/openjdk/jdk/commit/62610203f18095cbd25b456f0622bad033a65a5d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. It is a fix to a regression. The patch applies cleanly. ------------- Commit messages: - Backport 62610203f18095cbd25b456f0622bad033a65a5d Changes: https://git.openjdk.org/jdk21u/pull/90/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=90&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312555 Stats: 224 lines in 2 files changed: 222 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/90.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/90/head:pull/90 PR: https://git.openjdk.org/jdk21u/pull/90 From mbaesken at openjdk.org Wed Aug 23 12:21:40 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 23 Aug 2023 12:21:40 GMT Subject: [jdk21u] RFR: 8313602: increase timeout for jdk/classfile/CorpusTest.java Message-ID: <0KTQ1V-rKCP8k4K-WnoTi3MoNok5Yw7wi_nRfoVOzxM=.fe6d4f42-e985-45e2-993c-8cb84d93ecc1@github.com> 8313602: increase timeout for jdk/classfile/CorpusTest.java ------------- Commit messages: - Backport bdac348c80d451cefbc73eb8313e8511dbb0de31 Changes: https://git.openjdk.org/jdk21u/pull/91/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=91&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313602 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/91.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/91/head:pull/91 PR: https://git.openjdk.org/jdk21u/pull/91 From thartmann at openjdk.org Wed Aug 23 13:06:51 2023 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 23 Aug 2023 13:06:51 GMT Subject: [jdk21u] RFR: 8313626: C2 crash due to unexpected exception control flow Message-ID: Backport of [JDK-8313626](https://bugs.openjdk.java.net/browse/JDK-8313626). Applies cleanly. Approval is pending. Thanks, Tobias ------------- Commit messages: - 8313626: C2 crash due to unexpected exception control flow Changes: https://git.openjdk.org/jdk21u/pull/92/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=92&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313626 Stats: 180 lines in 3 files changed: 180 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/92.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/92/head:pull/92 PR: https://git.openjdk.org/jdk21u/pull/92 From phh at openjdk.org Wed Aug 23 15:03:38 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 23 Aug 2023 15:03:38 GMT Subject: [jdk17u-dev] RFR: 8313874: JNI NewWeakGlobalRef throws exception for null arg In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 10:17:50 GMT, Oli Gillespie wrote: > Nearly clean backport for https://bugs.openjdk.org/browse/JDK-8313874, the only difference is 17 using `NULL` compared to `nullptr` in tip required a manual (but trivial) merge. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1688#pullrequestreview-1591817093 From andrew at openjdk.org Wed Aug 23 18:14:43 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 23 Aug 2023 18:14:43 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v4] In-Reply-To: References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: On Tue, 22 Aug 2023 16:12:48 GMT, Dan Lutker wrote: >> Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. >> >> >> bash ./configure --with-jtreg=jtreg-7.3+1 >> make images >> make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" >> >> >> All tests pass. > > Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > 8314552: Fix javadoc tests to work with jtreg 7 Changes look good and pass on both JTreg 6 & 7. Approved for 17u. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1672#pullrequestreview-1592152400 From andrew at openjdk.org Wed Aug 23 18:14:45 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 23 Aug 2023 18:14:45 GMT Subject: [jdk17u-dev] RFR: 8314552: Fix javadoc tests to work with jtreg 7 [v3] In-Reply-To: References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: On Tue, 22 Aug 2023 08:03:36 GMT, Aleksey Shipilev wrote: > This PR does not need to depend on [openjdk:pr/1673](https://github.com/openjdk/jdk17u-dev/tree/pr/1673). Current jdk17u-dev should compile fine, it is just your [personal fork](https://github.com/lutkerd/jdk17u-dev) is way too old: "This branch is [1 commit ahead](https://github.com/lutkerd/jdk17u-dev/compare/openjdk:jdk17u-dev:master...master), [1480 commits behind](https://github.com/lutkerd/jdk17u-dev/compare/master...openjdk:jdk17u-dev:master) openjdk:master." > > Please pull new jdk17u-dev to your personal fork, and then rebase for new master. This will let you integrate this PR without waiting unnecessarily for [openjdk:pr/1673](https://github.com/openjdk/jdk17u-dev/tree/pr/1673) to integrate. Yes, as I mentioned above. This was just a quick way to see if it would make the tests pass. There's actually no reason for this to even wait on the JTreg update as it's independent of that (and GHA show tests passing). ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1672#issuecomment-1690413624 From andrew at openjdk.org Wed Aug 23 18:25:12 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 23 Aug 2023 18:25:12 GMT Subject: [jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2] In-Reply-To: References: Message-ID: <19GqWms4PGLXC8VXXlV25KRyichxKWH7H54eEbhrxoU=.82060de1-0f1a-4031-9b75-910506ec3120@github.com> > GHA regularly breaks because we specify a very explicit GCC version, even down to the release versioning of the Ubuntu package. > > Rather than bumping this yet again like https://github.com/openjdk/jdk17u/commit/260f28761a87553fd634615df5ba3db5b76ae692, this PR suggests dropping the specific version as we did some time ago in 8u and I've also proposed to fix the same breakage in 11u (https://github.com/openjdk/jdk11u-dev/pull/2087). The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. > > Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by recent GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. > > ~~This is based on https://github.com/openjdk/jdk17u-dev/pull/1595 to allow https://github.com/openjdk/jdk17u-dev/pull/1672 to proceed.~~ This is now based on master and the change is in trunk. Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport 62defc3dfc4b9ba5adfe3189f34fe8b3f59b94a0 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1673/files - new: https://git.openjdk.org/jdk17u-dev/pull/1673/files/4e51a975..829cf722 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1673&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1673&range=00-01 Stats: 1251 lines in 42 files changed: 1122 ins; 23 del; 106 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1673.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1673/head:pull/1673 PR: https://git.openjdk.org/jdk17u-dev/pull/1673 From duke at openjdk.org Wed Aug 23 18:45:31 2023 From: duke at openjdk.org (Dan Lutker) Date: Wed, 23 Aug 2023 18:45:31 GMT Subject: [jdk17u-dev] Integrated: 8314552: Fix javadoc tests to work with jtreg 7 In-Reply-To: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> References: <2kzb5fN0vxaZXMl6Qy-UyCx4AZYBmHS7vY209BJrdhw=.21aa7d19-9fb4-4048-8a2a-2cf37277e686@github.com> Message-ID: On Thu, 17 Aug 2023 23:39:45 GMT, Dan Lutker wrote: > Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar. > > > bash ./configure --with-jtreg=jtreg-7.3+1 > make images > make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet" > > > All tests pass. This pull request has now been integrated. Changeset: e8304640 Author: Dan Lutker Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/e83046409d81d074cd68dc823e794a852ed93cee Stats: 18 lines in 6 files changed: 6 ins; 0 del; 12 mod 8314552: Fix javadoc tests to work with jtreg 7 Reviewed-by: phh, shade, andrew ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1672 From valeriep at openjdk.org Wed Aug 23 19:08:41 2023 From: valeriep at openjdk.org (Valerie Peng) Date: Wed, 23 Aug 2023 19:08:41 GMT Subject: [jdk21u] RFR: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154 Message-ID: Hi all, This pull request contains a backport of commit [ba6cdbe2](https://github.com/openjdk/jdk/commit/ba6cdbe2c2897a0fdc266119f0fe4545c3352b8e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Valerie Peng on 22 Aug 2023 and was reviewed by Matthias Baesken and Jamil Nimeh. Thanks! ------------- Commit messages: - Backport ba6cdbe2c2897a0fdc266119f0fe4545c3352b8e Changes: https://git.openjdk.org/jdk21u/pull/93/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=93&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309214 Stats: 53 lines in 2 files changed: 39 ins; 12 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/93.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/93/head:pull/93 PR: https://git.openjdk.org/jdk21u/pull/93 From btaylor at openjdk.org Wed Aug 23 19:35:53 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 23 Aug 2023 19:35:53 GMT Subject: [jdk21u] RFR: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Message-ID: Backport [JDK-8313796](https://bugs.openjdk.org/browse/JDK-8313796) to 21u to fix a sigsegv. Change is clean and passes tier1 tests. ------------- Commit messages: - Backport 0e2c72d7a5206b7173af5bf69e21d21ea276bd94 Changes: https://git.openjdk.org/jdk21u/pull/94/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=94&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313796 Stats: 16 lines in 7 files changed: 11 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u/pull/94.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/94/head:pull/94 PR: https://git.openjdk.org/jdk21u/pull/94 From btaylor at openjdk.org Wed Aug 23 19:48:31 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 23 Aug 2023 19:48:31 GMT Subject: [jdk20u] Withdrawn: 8313765: Invalid CEN header (invalid zip64 extra data field size) In-Reply-To: <8kUgRlkY6Y4-R7k7ZbCIYy0AU4vUw9NKuAHeKAWkpuk=.34fda669-edc2-408e-b9cb-a6578ad5073f@github.com> References: <8kUgRlkY6Y4-R7k7ZbCIYy0AU4vUw9NKuAHeKAWkpuk=.34fda669-edc2-408e-b9cb-a6578ad5073f@github.com> Message-ID: On Thu, 17 Aug 2023 02:16:29 GMT, Ben Taylor wrote: > Backport is not clean, required changes: > - Some context lines > - Changes to `CorruptedZipFiles.java` had to be altered because [8304014](https://bugs.openjdk.org/browse/JDK-8304014) has not been backported to jdk20 > > All tests in `test/jdk/java/util/zip` pass This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk20u/pull/87 From tsteele at openjdk.org Wed Aug 23 22:22:46 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Wed, 23 Aug 2023 22:22:46 GMT Subject: [jdk21u] RFR: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) In-Reply-To: <2Ds_NQrSmvzAbscmX2K6GS068OOvpKNG0S-aJ2kNYKk=.41fabaeb-fc42-44f8-9585-910bca30f66b@github.com> References: <2Ds_NQrSmvzAbscmX2K6GS068OOvpKNG0S-aJ2kNYKk=.41fabaeb-fc42-44f8-9585-910bca30f66b@github.com> Message-ID: On Mon, 21 Aug 2023 13:40:36 GMT, Tyler Steele wrote: > Hi all, > > This pull request contains a backport of commit [fdac6a6a](https://github.com/openjdk/jdk/commit/fdac6a6ac871366614efe44aca58ab520766b5c8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. I am backporting this in order to backport [it's follow up](https://github.com/openjdk/jdk/commit/395fc78880a91eeb06a08c1abf6905d580a650c0) as well. > > The commit being backported was authored by Tyler Steele on 18 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe. > > Thanks! Approval received! ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/77#issuecomment-1690719970 From dholmes at openjdk.org Wed Aug 23 22:23:38 2023 From: dholmes at openjdk.org (David Holmes) Date: Wed, 23 Aug 2023 22:23:38 GMT Subject: [jdk21u] RFR: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 01:22:16 GMT, David Holmes wrote: > Hi all, > > This pull request contains a backport of commit [f142470d](https://github.com/openjdk/jdk/commit/f142470deaebbf9cff7f6f28842972393506b7c4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by David Holmes on 14 Aug 2023 and was reviewed by Stefan Karlsson, Patricio Chilano Mateo, Daniel D. Daugherty and Robbin Ehn. > > Thanks! Backport has been approved. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/83#issuecomment-1690720052 From dholmes at openjdk.org Wed Aug 23 22:26:07 2023 From: dholmes at openjdk.org (David Holmes) Date: Wed, 23 Aug 2023 22:26:07 GMT Subject: [jdk21u] Integrated: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 01:22:16 GMT, David Holmes wrote: > Hi all, > > This pull request contains a backport of commit [f142470d](https://github.com/openjdk/jdk/commit/f142470deaebbf9cff7f6f28842972393506b7c4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by David Holmes on 14 Aug 2023 and was reviewed by Stefan Karlsson, Patricio Chilano Mateo, Daniel D. Daugherty and Robbin Ehn. > > Thanks! This pull request has now been integrated. Changeset: 3d38c53c Author: David Holmes URL: https://git.openjdk.org/jdk21u/commit/3d38c53c342896073cb7d40215120d0498c270ba Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out Backport-of: f142470deaebbf9cff7f6f28842972393506b7c4 ------------- PR: https://git.openjdk.org/jdk21u/pull/83 From almatvee at openjdk.org Wed Aug 23 23:38:45 2023 From: almatvee at openjdk.org (Alexander Matveev) Date: Wed, 23 Aug 2023 23:38:45 GMT Subject: [jdk21u] RFR: 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters Message-ID: <7Nr7pXGztksF4Uasl-5bV0cVBXCOe4Ge6M2EdLZdBIc=.2f26d704-64e0-4957-ae52-3fef11853831@github.com> Clean backport of JDK-8308042. ------------- Commit messages: - Backport 57a322da9bf6aac98e834516728fb6da1c18e7aa Changes: https://git.openjdk.org/jdk21u/pull/95/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=95&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308042 Stats: 444 lines in 11 files changed: 248 ins; 60 del; 136 mod Patch: https://git.openjdk.org/jdk21u/pull/95.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/95/head:pull/95 PR: https://git.openjdk.org/jdk21u/pull/95 From v-terrychow at microsoft.com Thu Aug 24 00:54:21 2023 From: v-terrychow at microsoft.com (Terry Chow (Simba Technologies Inc)) Date: Thu, 24 Aug 2023 00:54:21 +0000 Subject: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u Message-ID: Hi maintainers of OpenJDK updates, I'd like to backport JDK-8308593 (keepalive extended socket options for Windows) to 11u and 17u (maybe 8u later as well). And so, I just want to open discussion on this topic to hear your opinions before I start the backporting process. I did some initial investigation on the backport and I learned the following: Backporting to 11u requires three additional changes to be made on top of the backport in order for it to work. 1. Lib-jdk.net.gmk will need to be updated to support building extnet for Windows. 2. jdk.net.ExtendedSocketOption will need to add a case to support returning a Windows instance of PlatformSocketOptions. 3. The Windows PlainSocketImpl class needs to have the same code on lines 61 - 96 in the Unix PlainSocketImpl class. Backporting to 17u requires two additional changes (similar to 11u). 1. jdk.net/Lib.gmk will need to be updated to support building extnet for Windows. 2. jdk.net.ExtendedSocketOption will need to add a case to support returning a Windows instance of PlatformSocketOptions. Let me know if the additional changes are acceptable or if they're disruptive. Thanks, Terry -------------- next part -------------- An HTML attachment was scrubbed... URL: From stuefe at openjdk.org Thu Aug 24 05:50:37 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 24 Aug 2023 05:50:37 GMT Subject: [jdk21u] RFR: 8310233: Fix THP detection on Linux In-Reply-To: References: Message-ID: On Tue, 15 Aug 2023 09:22:23 GMT, Thomas Stuefe wrote: > Hi all, > > This patch is one in a small line of preparatory patches that aim, ultimately, to fix https://bugs.openjdk.org/browse/JDK-8312182 ("THPs cause huge RSS due to thread start timing issue"). > > This pull request contains a backport of commit [37ca9024](https://github.com/openjdk/jdk/commit/37ca9024ef59d99cae0bd7e25b2e6d3c1e085f97) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Stuefe on 17 Jul 2023 and was reviewed by Johan Sj?len and David Holmes. > > Thanks! got fix approval. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/60#issuecomment-1691040833 From stuefe at openjdk.org Thu Aug 24 05:50:39 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 24 Aug 2023 05:50:39 GMT Subject: [jdk21u] Integrated: 8310233: Fix THP detection on Linux In-Reply-To: References: Message-ID: On Tue, 15 Aug 2023 09:22:23 GMT, Thomas Stuefe wrote: > Hi all, > > This patch is one in a small line of preparatory patches that aim, ultimately, to fix https://bugs.openjdk.org/browse/JDK-8312182 ("THPs cause huge RSS due to thread start timing issue"). > > This pull request contains a backport of commit [37ca9024](https://github.com/openjdk/jdk/commit/37ca9024ef59d99cae0bd7e25b2e6d3c1e085f97) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Stuefe on 17 Jul 2023 and was reviewed by Johan Sj?len and David Holmes. > > Thanks! This pull request has now been integrated. Changeset: d6a4e469 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk21u/commit/d6a4e469e4b2bba2f699d36c7b04aa0381a72c42 Stats: 815 lines in 7 files changed: 684 ins; 99 del; 32 mod 8310233: Fix THP detection on Linux Backport-of: 37ca9024ef59d99cae0bd7e25b2e6d3c1e085f97 ------------- PR: https://git.openjdk.org/jdk21u/pull/60 From shade at openjdk.org Thu Aug 24 06:09:36 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 06:09:36 GMT Subject: [jdk21u] RFR: 8313752: InstanceKlassFlags::print_on doesn't print the flag names In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 07:59:37 GMT, Aleksey Shipilev wrote: > Clean backport to fix JDK 21 regression in diagnostic printing. > > Additional testing: > - [x] New test passes with the fix, fails without it Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/87#issuecomment-1691055964 From shade at openjdk.org Thu Aug 24 06:09:37 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 06:09:37 GMT Subject: [jdk21u] Integrated: 8313752: InstanceKlassFlags::print_on doesn't print the flag names In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 07:59:37 GMT, Aleksey Shipilev wrote: > Clean backport to fix JDK 21 regression in diagnostic printing. > > Additional testing: > - [x] New test passes with the fix, fails without it This pull request has now been integrated. Changeset: 1c3409b3 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/1c3409b3a5e36e614b271634c159d5d2c7420ac2 Stats: 7 lines in 4 files changed: 3 ins; 1 del; 3 mod 8313752: InstanceKlassFlags::print_on doesn't print the flag names Backport-of: 735b16a6969ba5998b4f809927e5ac42a7e72d2d ------------- PR: https://git.openjdk.org/jdk21u/pull/87 From shade at openjdk.org Thu Aug 24 06:10:33 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 06:10:33 GMT Subject: [jdk21u] RFR: 8314426: runtime/os/TestTrimNative.java is failing on slow machines In-Reply-To: References: Message-ID: <24HeIu7PMPj3X1Vm0Mkie_b1xxZL8kgo7AJ9-6mxWFY=.4ab63392-1294-4ddf-a0c1-329e636e41c5@github.com> On Wed, 23 Aug 2023 07:16:00 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the test. > > Additional testing: > - [x] 100+ repetitions of affected test Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/86#issuecomment-1691056094 From shade at openjdk.org Thu Aug 24 06:10:34 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 06:10:34 GMT Subject: [jdk21u] Integrated: 8314426: runtime/os/TestTrimNative.java is failing on slow machines In-Reply-To: References: Message-ID: <4XPRcwuWxTCDeNwKq5y9hBJDyjmWuBRzEMytnhyAS1g=.a8ed97ab-fadc-492b-b714-009729e8b19a@github.com> On Wed, 23 Aug 2023 07:16:00 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize the test. > > Additional testing: > - [x] 100+ repetitions of affected test This pull request has now been integrated. Changeset: f07aa564 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/f07aa56445d6ebc1013f5a2eff4343499ec4379d Stats: 6 lines in 1 file changed: 3 ins; 1 del; 2 mod 8314426: runtime/os/TestTrimNative.java is failing on slow machines Backport-of: 20e94784c9f7c30e95550c72aedb5e986a153114 ------------- PR: https://git.openjdk.org/jdk21u/pull/86 From shade at openjdk.org Thu Aug 24 06:11:29 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 06:11:29 GMT Subject: [jdk21u] RFR: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 09:30:48 GMT, Aleksey Shipilev wrote: > Clean backport to fix the test failure with Shenandoah. > > Additional testing: > - [x] Test fails with Shenandoah without the fix, passes with it Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/74#issuecomment-1691056686 From shade at openjdk.org Thu Aug 24 06:11:29 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 06:11:29 GMT Subject: [jdk21u] Integrated: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 09:30:48 GMT, Aleksey Shipilev wrote: > Clean backport to fix the test failure with Shenandoah. > > Additional testing: > - [x] Test fails with Shenandoah without the fix, passes with it This pull request has now been integrated. Changeset: c17b5d75 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/c17b5d7588cf186150822b72bb901927dca9a9f5 Stats: 7 lines in 2 files changed: 1 ins; 3 del; 3 mod 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails Backport-of: 812f475bc4ea84225e8bbb0b5a677eed0af864dd ------------- PR: https://git.openjdk.org/jdk21u/pull/74 From tsteele at openjdk.org Thu Aug 24 06:16:37 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Thu, 24 Aug 2023 06:16:37 GMT Subject: [jdk21u] Integrated: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) In-Reply-To: <2Ds_NQrSmvzAbscmX2K6GS068OOvpKNG0S-aJ2kNYKk=.41fabaeb-fc42-44f8-9585-910bca30f66b@github.com> References: <2Ds_NQrSmvzAbscmX2K6GS068OOvpKNG0S-aJ2kNYKk=.41fabaeb-fc42-44f8-9585-910bca30f66b@github.com> Message-ID: <7j_cg_SKLgGEqVndc6-Zbj5MM5K6rLwGi21Svx7ZEZ0=.68b6e05c-71a7-4844-a270-63f5bd3564a5@github.com> On Mon, 21 Aug 2023 13:40:36 GMT, Tyler Steele wrote: > Hi all, > > This pull request contains a backport of commit [fdac6a6a](https://github.com/openjdk/jdk/commit/fdac6a6ac871366614efe44aca58ab520766b5c8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. I am backporting this in order to backport [it's follow up](https://github.com/openjdk/jdk/commit/395fc78880a91eeb06a08c1abf6905d580a650c0) as well. > > The commit being backported was authored by Tyler Steele on 18 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe. > > Thanks! This pull request has now been integrated. Changeset: 82d7bc57 Author: Tyler Steele Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/82d7bc57b7a1d2fee01bec1bf2ab667c330ea634 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) Backport-of: fdac6a6ac871366614efe44aca58ab520766b5c8 ------------- PR: https://git.openjdk.org/jdk21u/pull/77 From shade at openjdk.org Thu Aug 24 06:21:23 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 06:21:23 GMT Subject: [jdk21u] RFR: 8313701: GHA: RISC-V should use the official repository for bootstrap [v2] In-Reply-To: <43FjjUy5o5vyhHjg3tYbyAW_3NCVC4OJAioG6wfdTFU=.64005a19-a7e7-484c-a0c2-596010bb035d@github.com> References: <43FjjUy5o5vyhHjg3tYbyAW_3NCVC4OJAioG6wfdTFU=.64005a19-a7e7-484c-a0c2-596010bb035d@github.com> Message-ID: > Clean backport to improve GHA stability. > > Additional testing: > - [ ] GHA Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8313701-gha-riscv-official - Backport 538f9557b87f750264231f04bfbc91d15f8af8c0 ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/78/files - new: https://git.openjdk.org/jdk21u/pull/78/files/c2579656..770ecad5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=78&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=78&range=00-01 Stats: 2181 lines in 45 files changed: 1901 ins; 136 del; 144 mod Patch: https://git.openjdk.org/jdk21u/pull/78.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/78/head:pull/78 PR: https://git.openjdk.org/jdk21u/pull/78 From shade at openjdk.org Thu Aug 24 06:26:47 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 06:26:47 GMT Subject: [jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2] In-Reply-To: <19GqWms4PGLXC8VXXlV25KRyichxKWH7H54eEbhrxoU=.82060de1-0f1a-4031-9b75-910506ec3120@github.com> References: <19GqWms4PGLXC8VXXlV25KRyichxKWH7H54eEbhrxoU=.82060de1-0f1a-4031-9b75-910506ec3120@github.com> Message-ID: On Wed, 23 Aug 2023 18:25:12 GMT, Andrew John Hughes wrote: >> GHA regularly breaks because we specify a very explicit GCC version, even down to the release versioning of the Ubuntu package. >> >> Rather than bumping this yet again like https://github.com/openjdk/jdk17u/commit/260f28761a87553fd634615df5ba3db5b76ae692, this PR suggests dropping the specific version as we did some time ago in 8u and I've also proposed to fix the same breakage in 11u (https://github.com/openjdk/jdk11u-dev/pull/2087). The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. >> >> Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by recent GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. >> >> ~~This is based on https://github.com/openjdk/jdk17u-dev/pull/1595 to allow https://github.com/openjdk/jdk17u-dev/pull/1672 to proceed.~~ This is now based on master and the change is in trunk. > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 62defc3dfc4b9ba5adfe3189f34fe8b3f59b94a0 Looks okay now. I guess we should be doing these in every maintained release at this point. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1673#pullrequestreview-1592857452 From duke at openjdk.org Thu Aug 24 06:29:14 2023 From: duke at openjdk.org (Long Yang) Date: Thu, 24 Aug 2023 06:29:14 GMT Subject: [jdk17u-dev] RFR: 8312065: Socket.connect does not timeout when profiling [v2] In-Reply-To: <6qwO59yJ9ooIzdb0HGXTFes3fODq5BiWQXVy7G0T6OY=.960cca89-4600-4507-ac99-ac040e6c1adc@github.com> References: <6qwO59yJ9ooIzdb0HGXTFes3fODq5BiWQXVy7G0T6OY=.960cca89-4600-4507-ac99-ac040e6c1adc@github.com> Message-ID: > Hi all, > > This pull request contains a fix for [JDK-8312065](https://bugs.openjdk.org/browse/JDK-8312065). > > The old SocketImpl is still present in JDK 17, can be enabled with -Djdk.net.usePlainSocketImpl. > > I have verified that this problem exists on Linux and macOS, and I feel that it also exists on AIX, > so I repaired these 3 platforms. Windows implementations are different, so don't have this problem. > > All callers of NET_Poll() already check for EINTR, so the fix is to remove do-while loop in the implementation of NET_Poll(). > > Other methods, such as NET_Read, NET_NonBlockingRead, NET_Accept, NET_Connect, are not affected. > Because if Socket has timeout, it will call NET_Timeout first, and then call them. NET_Timeout has a correct timeout implementation and is not affected by profiling signals. > If the Socket does not have a timeout, and if the system call is interrupted by a signal, the [Linux Kernel will automatically retry](https://man7.org/linux/man-pages/man7/signal.7.html), and the application code will not be aware of it. > > Thanks! Long Yang has updated the pull request incrementally with one additional commit since the last revision: use libNativeThread to get OS thread id and send signal ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1639/files - new: https://git.openjdk.org/jdk17u-dev/pull/1639/files/9d8c7982..5c6b859d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1639&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1639&range=00-01 Stats: 203 lines in 1 file changed: 10 ins; 177 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1639.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1639/head:pull/1639 PR: https://git.openjdk.org/jdk17u-dev/pull/1639 From duke at openjdk.org Thu Aug 24 06:29:32 2023 From: duke at openjdk.org (Long Yang) Date: Thu, 24 Aug 2023 06:29:32 GMT Subject: [jdk17u-dev] RFR: 8312065: Socket.connect does not timeout when profiling [v2] In-Reply-To: References: <6qwO59yJ9ooIzdb0HGXTFes3fODq5BiWQXVy7G0T6OY=.960cca89-4600-4507-ac99-ac040e6c1adc@github.com> Message-ID: On Mon, 21 Aug 2023 13:53:38 GMT, Andrei Pangin wrote: >> Long Yang has updated the pull request incrementally with one additional commit since the last revision: >> >> use libNativeThread to get OS thread id and send signal > > test/jdk/java/net/Socket/B8312065.java line 181: > >> 179: */ >> 180: private static long getOSThreadId() throws IOException, ParseException { >> 181: startJFR(); > > You may reuse `libNativeThread` for finding threadId and sending signals. This should make the test a lot simpler. > See `SocketAcceptInterruptTest` and `SocketReadInterruptTest` for example. > JFR is an optional feature, it is not available in Minimal VM. Thanks for your advice. I have updated the test code. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1639#discussion_r1303858199 From stuefe at openjdk.org Thu Aug 24 06:31:47 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 24 Aug 2023 06:31:47 GMT Subject: [jdk21u] RFR: 8312394: [linux] SIGSEGV if kernel was built without hugepage support Message-ID: <1L7f5KIKdWv442lo6u6bCb1OKyG6SVTd678tCXPDVhs=.74baba94-6fe8-4a2b-8e0c-b26cbed4e66b@github.com> Hi all, This patch is one in a small line of preparatory patches that aim, ultimately, to fix https://bugs.openjdk.org/browse/JDK-8312182 ("THPs cause huge RSS due to thread start timing issue"). This particular patch fixes an issue where the JVM would crash on startup when started on a linux box with a kernel that does not support hugepages (mostly affected by this are small SBCs) ------------- Commit messages: - Backport 94eb44b192ba421692549a178c386ea34164ea50 Changes: https://git.openjdk.org/jdk21u/pull/97/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=97&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312394 Stats: 22 lines in 1 file changed: 6 ins; 2 del; 14 mod Patch: https://git.openjdk.org/jdk21u/pull/97.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/97/head:pull/97 PR: https://git.openjdk.org/jdk21u/pull/97 From stuefe at openjdk.org Thu Aug 24 06:34:14 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 24 Aug 2023 06:34:14 GMT Subject: [jdk21u] RFR: 8303815: Improve Metaspace test speed Message-ID: Small improvement, low risk, that speeds up metaspace tests (jtreg and gtests). ------------- Commit messages: - Backport de0e46c2f6dfa817bfa745195573810d250640de Changes: https://git.openjdk.org/jdk21u/pull/98/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=98&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303815 Stats: 56 lines in 6 files changed: 34 ins; 5 del; 17 mod Patch: https://git.openjdk.org/jdk21u/pull/98.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/98/head:pull/98 PR: https://git.openjdk.org/jdk21u/pull/98 From shade at openjdk.org Thu Aug 24 07:19:43 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 07:19:43 GMT Subject: [jdk21u] RFR: 8313262: C2: Sinking node may cause required cast to be dropped Message-ID: <5J-am32LvigQiSpQYcW6rJ5xcue_Ot6iwZsvB1gcdCI=.02554307-cec8-487d-ab46-6d205247205a@github.com> Clean backport to fix recent JDK 21 backport regression. Additional testing: - [x] New test fails without the fix, passes with it - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` ------------- Commit messages: - Backport 1cee3b9fd9720e7938029a6992460b9053e65e57 Changes: https://git.openjdk.org/jdk21u/pull/99/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=99&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313262 Stats: 69 lines in 2 files changed: 68 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/99.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/99/head:pull/99 PR: https://git.openjdk.org/jdk21u/pull/99 From mbaesken at openjdk.org Thu Aug 24 07:33:38 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 24 Aug 2023 07:33:38 GMT Subject: [jdk21u] Integrated: 8313602: increase timeout for jdk/classfile/CorpusTest.java In-Reply-To: <0KTQ1V-rKCP8k4K-WnoTi3MoNok5Yw7wi_nRfoVOzxM=.fe6d4f42-e985-45e2-993c-8cb84d93ecc1@github.com> References: <0KTQ1V-rKCP8k4K-WnoTi3MoNok5Yw7wi_nRfoVOzxM=.fe6d4f42-e985-45e2-993c-8cb84d93ecc1@github.com> Message-ID: On Wed, 23 Aug 2023 12:12:59 GMT, Matthias Baesken wrote: > 8313602: increase timeout for jdk/classfile/CorpusTest.java This pull request has now been integrated. Changeset: 5ad0c0c3 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u/commit/5ad0c0c3f158ed620ad43faf4ea577d34f90ec8d Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8313602: increase timeout for jdk/classfile/CorpusTest.java Backport-of: bdac348c80d451cefbc73eb8313e8511dbb0de31 ------------- PR: https://git.openjdk.org/jdk21u/pull/91 From mbaesken at openjdk.org Thu Aug 24 07:44:28 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 24 Aug 2023 07:44:28 GMT Subject: [jdk21u] Integrated: 8314517: some tests fail in case ipv6 is disabled on the machine In-Reply-To: <00Odsd73GT1O4FJ-V8ucuPPNCvd6j3114aOT4YhtcRs=.38771097-edff-419a-8d84-12347d84603a@github.com> References: <00Odsd73GT1O4FJ-V8ucuPPNCvd6j3114aOT4YhtcRs=.38771097-edff-419a-8d84-12347d84603a@github.com> Message-ID: On Wed, 23 Aug 2023 11:50:50 GMT, Matthias Baesken wrote: > 8314517: some tests fail in case ipv6 is disabled on the machine This pull request has now been integrated. Changeset: 5c84a01a Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u/commit/5c84a01a45e9fbdb10f406c7b7bccb8b4b651ce3 Stats: 82 lines in 6 files changed: 34 ins; 1 del; 47 mod 8314517: some tests fail in case ipv6 is disabled on the machine Backport-of: 703817d21f6fd8b24cc670695625dfdb09d3592c ------------- PR: https://git.openjdk.org/jdk21u/pull/89 From sgehwolf at redhat.com Thu Aug 24 08:17:42 2023 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 24 Aug 2023 10:17:42 +0200 Subject: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u In-Reply-To: References: Message-ID: <26a6d12b49b4b19e24b9e8e75eb382376848df16.camel@redhat.com> Hi Terry, On Thu, 2023-08-24 at 00:54 +0000, Terry Chow (Simba Technologies Inc) wrote: > Hi maintainers of OpenJDK updates, > > I'd like to backport JDK-8308593?(keepalive extended socket options for Windows) to 11u and 17u (maybe 8u later as well). And so, I just want to open discussion on this topic to hear your opinions before I start the backporting process. I did some initial investigation on the backport and I learned the following: > > Backporting to 11u requires three additional changes to be made on top of the backport in order for it to work. > ???1. Lib-jdk.net.gmk will need to be updated to support building extnet for Windows. > ???2. jdk.net.ExtendedSocketOption will need to add a case to support returning a Windows instance of PlatformSocketOptions. > ???3. The Windows PlainSocketImpl class needs to have the same code on lines 61 - 96 in the Unix PlainSocketImpl class. > Backporting to 17u requires two additional changes (similar to 11u). > ???1. jdk.net/Lib.gmkwill need to be updated to support building extnet for Windows. > ???2. jdk.net.ExtendedSocketOption will need to add a case to support returning a Windows instance of PlatformSocketOptions. > Let me know if the additional changes are acceptable or if they're disruptive. As the change went into JDK 22, I'd first suggest to get this into JDK 21u which would bring this feature to LTS users. JDK 17u seems OK as a next step from a brief glance (once it's in 21u). Only then we should evaluate JDK 11u and older releases. Thanks, Severin From shade at openjdk.org Thu Aug 24 08:34:04 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 08:34:04 GMT Subject: [jdk17u-dev] RFR: 8313262: C2: Sinking node may cause required cast to be dropped Message-ID: Clean backport to fix recent JDK 17 backport regression. Additional testing: - [x] New test fails without the fix, passes with it - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` ------------- Commit messages: - Backport 1cee3b9fd9720e7938029a6992460b9053e65e57 Changes: https://git.openjdk.org/jdk17u-dev/pull/1690/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1690&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313262 Stats: 69 lines in 2 files changed: 68 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1690.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1690/head:pull/1690 PR: https://git.openjdk.org/jdk17u-dev/pull/1690 From duke at openjdk.org Thu Aug 24 09:30:03 2023 From: duke at openjdk.org (toshiogata) Date: Thu, 24 Aug 2023 09:30:03 GMT Subject: [jdk11u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 Message-ID: Hi all, This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 I worked for backporting JDK-8217612, and found that this related patch should be backported at the same time. The riginal patch is applied cleanly to JDK-8217612 applied code. Testing: all serviceability agent tests, hotspot_all that includes CompressedClassSpaceSizeInJmapHeap.java and the test which come with JDK-8217612. Thank you. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/2093 Commit messages: - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d Changes: https://git.openjdk.org/jdk11u-dev/pull/2096/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2096&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8217850 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2096.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2096/head:pull/2096 PR: https://git.openjdk.org/jdk11u-dev/pull/2096 From shade at openjdk.org Thu Aug 24 09:35:01 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 09:35:01 GMT Subject: [jdk17u-dev] RFR: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev Message-ID: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> Semi-clean backport to make RISC-V sysroot bootstrap more reliable. The conflict is in x86_32 line that contained additional packages for mainline GHA. Additional test: - [ ] GHA ------------- Commit messages: - Backport 69d900d2ce97e5479020cff9a63c471d07e39989 Changes: https://git.openjdk.org/jdk17u-dev/pull/1691/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1691&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314730 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1691.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1691/head:pull/1691 PR: https://git.openjdk.org/jdk17u-dev/pull/1691 From duke at openjdk.org Thu Aug 24 09:46:24 2023 From: duke at openjdk.org (toshiogata) Date: Thu, 24 Aug 2023 09:46:24 GMT Subject: [jdk11u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v2] In-Reply-To: References: Message-ID: > Hi all, > > This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 > > I worked for backporting JDK-8217612, and found that this related patch should be backported at the same time. > > The riginal patch is applied cleanly to JDK-8217612 applied code. > > Testing: all serviceability agent tests, hotspot_all that includes CompressedClassSpaceSizeInJmapHeap.java and the test which come with JDK-8217612. > > Thank you. toshiogata has updated the pull request incrementally with 28 additional commits since the last revision: - Merge branch 'master' into toshiogata-backport-8217850 - 8311033: [macos] PrinterJob does not take into account Sides attribute Backport-of: a3d67231a71fbe37c509fcedd54c679b4644c0d9 - 8313765: Invalid CEN header (invalid zip64 extra data field size) Reviewed-by: andrew, serb Backport-of: 13f6450e2e70df4df8bd882def837fbd5bef1524 - 8302161: Upgrade jQuery UI to version 1.13.2 8293180: JQuery UI license file not updated Reviewed-by: phh Backport-of: 404d5bddb9177c3bda03db81e14209e372a00027 - 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Reviewed-by: phh Backport-of: 0e2c72d7a5206b7173af5bf69e21d21ea276bd94 - 8284772: GHA: Use GCC Major Version Dependencies Only Reviewed-by: serb, simonis Backport-of: 62defc3dfc4b9ba5adfe3189f34fe8b3f59b94a0 - 8301269: Update Commons BCEL to Version 6.7.0 Reviewed-by: mdoerr Backport-of: 6a44120a16d0f06b4ed9f0ebf6b0919da7070287 - 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails Backport-of: 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3 - 8306133: Open source few AWT Drag & Drop related tests 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed Reviewed-by: phh Backport-of: ec5c7926f3cea68bf0d0ceb460a8383f5e4ea278 - 8271838: AmazonCA.java interop test fails Backport-of: 512db0ff31a0a1a2bd8805964ba3d06e2cbfb9e9 - ... and 18 more: https://git.openjdk.org/jdk11u-dev/compare/5b7382a2...dab74fb6 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2096/files - new: https://git.openjdk.org/jdk11u-dev/pull/2096/files/5b7382a2..dab74fb6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2096&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2096&range=00-01 Stats: 39036 lines in 406 files changed: 15735 ins; 12372 del; 10929 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2096.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2096/head:pull/2096 PR: https://git.openjdk.org/jdk11u-dev/pull/2096 From duke at openjdk.org Thu Aug 24 09:53:21 2023 From: duke at openjdk.org (toshiogata) Date: Thu, 24 Aug 2023 09:53:21 GMT Subject: [jdk11u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v2] In-Reply-To: References: Message-ID: > Hi all, > > This is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags > > JDK11 reproduces the reported bug, so this patch should be applied. > There is a related Issue: JDK-8217850, and I submit the corresponding PR. > > The original patch is applied cleanly. > > Testing: all serviceability agent tests,?hotspot_all and the test which comes with this patch > > Thank you. toshiogata has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into toshiogata-backport-8217612 - Backport d6a75a0f86d4c84132a3794c432b34068163fa60 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2093/files - new: https://git.openjdk.org/jdk11u-dev/pull/2093/files/82ea3c9c..b13c67d9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2093&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2093&range=00-01 Stats: 39036 lines in 406 files changed: 15735 ins; 12372 del; 10929 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2093.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2093/head:pull/2093 PR: https://git.openjdk.org/jdk11u-dev/pull/2093 From duke at openjdk.org Thu Aug 24 10:08:32 2023 From: duke at openjdk.org (toshiogata) Date: Thu, 24 Aug 2023 10:08:32 GMT Subject: [jdk11u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v3] In-Reply-To: References: Message-ID: > Hi all, > > This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 > > I worked for backporting JDK-8217612, and found that this related patch should be backported at the same time. > > The riginal patch is applied cleanly to JDK-8217612 applied code. > > Testing: all serviceability agent tests, hotspot_all that includes CompressedClassSpaceSizeInJmapHeap.java and the test which come with JDK-8217612. > > Thank you. toshiogata has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Revert "Merge branch 'master' into toshiogata-backport-8217850" This reverts commit dab74fb67badb3c65ba75df5ee3f410f12f2b9cd, reversing changes made to 5b7382a21f1cc7ff394a3579d665f0459a772a1f. - Merge branch 'master' into toshiogata-backport-8217850 - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d - Backport d6a75a0f86d4c84132a3794c432b34068163fa60 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2096/files - new: https://git.openjdk.org/jdk11u-dev/pull/2096/files/dab74fb6..f593091d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2096&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2096&range=01-02 Stats: 39407 lines in 406 files changed: 12756 ins; 16119 del; 10532 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2096.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2096/head:pull/2096 PR: https://git.openjdk.org/jdk11u-dev/pull/2096 From duke at openjdk.org Thu Aug 24 10:21:07 2023 From: duke at openjdk.org (toshiogata) Date: Thu, 24 Aug 2023 10:21:07 GMT Subject: [jdk11u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v4] In-Reply-To: References: Message-ID: > Hi all, > > This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 > > I worked for backporting JDK-8217612, and found that this related patch should be backported at the same time. > > The riginal patch is applied cleanly to JDK-8217612 applied code. > > Testing: all serviceability agent tests, hotspot_all that includes CompressedClassSpaceSizeInJmapHeap.java and the test which come with JDK-8217612. > > Thank you. toshiogata has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2096/files - new: https://git.openjdk.org/jdk11u-dev/pull/2096/files/f593091d..5b7382a2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2096&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2096&range=02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2096.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2096/head:pull/2096 PR: https://git.openjdk.org/jdk11u-dev/pull/2096 From duke at openjdk.org Thu Aug 24 10:26:16 2023 From: duke at openjdk.org (toshiogata) Date: Thu, 24 Aug 2023 10:26:16 GMT Subject: [jdk11u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v5] In-Reply-To: References: Message-ID: <26FtqbFaw_UM-whVaFRXhBnnrpgMbBilcUcQRlCGmqU=.19fa4f07-95f2-4f3d-9b5f-551918c88206@github.com> > Hi all, > > This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 > > I worked for backporting JDK-8217612, and found that this related patch should be backported at the same time. > > The riginal patch is applied cleanly to JDK-8217612 applied code. > > Testing: all serviceability agent tests, hotspot_all that includes CompressedClassSpaceSizeInJmapHeap.java and the test which come with JDK-8217612. > > Thank you. toshiogata has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'toshiogata-backport-8217612' into toshiogata-backport-8217850 - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2096/files - new: https://git.openjdk.org/jdk11u-dev/pull/2096/files/5b7382a2..0267bf96 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2096&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2096&range=03-04 Stats: 39036 lines in 406 files changed: 15735 ins; 12372 del; 10929 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2096.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2096/head:pull/2096 PR: https://git.openjdk.org/jdk11u-dev/pull/2096 From aivanov at openjdk.org Thu Aug 24 12:27:37 2023 From: aivanov at openjdk.org (Alexey Ivanov) Date: Thu, 24 Aug 2023 12:27:37 GMT Subject: [jdk21u] Integrated: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1) In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 11:55:59 GMT, Alexey Ivanov wrote: > This pull request contains a backport of commit [62610203](https://github.com/openjdk/jdk/commit/62610203f18095cbd25b456f0622bad033a65a5d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > It is a fix to a regression. > > The patch applies cleanly. This pull request has now been integrated. Changeset: 6588678b Author: Alexey Ivanov URL: https://git.openjdk.org/jdk21u/commit/6588678b8119088502121f3e7610f3d008cc703d Stats: 224 lines in 2 files changed: 222 ins; 0 del; 2 mod 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1) Ignore bitmaps embedded into fonts for non-uniform scales Backport-of: 62610203f18095cbd25b456f0622bad033a65a5d ------------- PR: https://git.openjdk.org/jdk21u/pull/90 From shade at openjdk.org Thu Aug 24 13:00:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 13:00:35 GMT Subject: [jdk21u] RFR: 8314020: Print instruction blocks in byte units In-Reply-To: References: Message-ID: <-Gro5YPTsSw6LlzU1C-R4GqY6MrRshvuXeKWixG2Kcg=.300aa73a-d0ac-4fb0-a6fb-60a53806ca79@github.com> On Wed, 16 Aug 2023 12:59:18 GMT, Aleksey Shipilev wrote: > Clean backport to improve post-mortem diagnostics. Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/63#issuecomment-1691626930 From shade at openjdk.org Thu Aug 24 13:02:29 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 13:02:29 GMT Subject: [jdk21u] RFR: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError In-Reply-To: <60lChuN6oKVRLrm93XGjRGo5Ket6_OL2_kWNHsPnsHg=.75bab692-d5f5-4307-b186-39e31acc1a2a@github.com> References: <60lChuN6oKVRLrm93XGjRGo5Ket6_OL2_kWNHsPnsHg=.75bab692-d5f5-4307-b186-39e31acc1a2a@github.com> Message-ID: On Wed, 23 Aug 2023 06:21:39 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize test. > > Additional testing: > - [x] Affected test passes with 100+ repetitions Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/84#issuecomment-1691626345 From shade at openjdk.org Thu Aug 24 13:02:34 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 13:02:34 GMT Subject: [jdk21u] RFR: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 06:43:24 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA stability. > > Additional testing: > - [x] GHA Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/85#issuecomment-1691625655 From shade at openjdk.org Thu Aug 24 13:02:30 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 13:02:30 GMT Subject: [jdk21u] Integrated: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError In-Reply-To: <60lChuN6oKVRLrm93XGjRGo5Ket6_OL2_kWNHsPnsHg=.75bab692-d5f5-4307-b186-39e31acc1a2a@github.com> References: <60lChuN6oKVRLrm93XGjRGo5Ket6_OL2_kWNHsPnsHg=.75bab692-d5f5-4307-b186-39e31acc1a2a@github.com> Message-ID: On Wed, 23 Aug 2023 06:21:39 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize test. > > Additional testing: > - [x] Affected test passes with 100+ repetitions This pull request has now been integrated. Changeset: f6bd1691 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/f6bd1691f474798b971d0469b0cc7f6ae242b4be Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError Backport-of: d1de3d082ef9b83aaa68664e653ab09feb8bad87 ------------- PR: https://git.openjdk.org/jdk21u/pull/84 From shade at openjdk.org Thu Aug 24 13:02:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 13:02:35 GMT Subject: [jdk21u] Integrated: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 06:43:24 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA stability. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 17a7fc31 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/17a7fc316df0df51b6cb58706f5e236c7b75a0df Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev Backport-of: 69d900d2ce97e5479020cff9a63c471d07e39989 ------------- PR: https://git.openjdk.org/jdk21u/pull/85 From shade at openjdk.org Thu Aug 24 13:03:38 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 13:03:38 GMT Subject: [jdk21u] Integrated: 8314020: Print instruction blocks in byte units In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 12:59:18 GMT, Aleksey Shipilev wrote: > Clean backport to improve post-mortem diagnostics. This pull request has now been integrated. Changeset: 7a2aa866 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/7a2aa866800296be1b35b4490d9a807fcfe45e91 Stats: 12 lines in 12 files changed: 0 ins; 0 del; 12 mod 8314020: Print instruction blocks in byte units Backport-of: a602624ef46908456052146d50467c60efa636c3 ------------- PR: https://git.openjdk.org/jdk21u/pull/63 From shade at openjdk.org Thu Aug 24 13:13:00 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 13:13:00 GMT Subject: [jdk21u] RFR: 8313262: C2: Sinking node may cause required cast to be dropped [v2] In-Reply-To: <5J-am32LvigQiSpQYcW6rJ5xcue_Ot6iwZsvB1gcdCI=.02554307-cec8-487d-ab46-6d205247205a@github.com> References: <5J-am32LvigQiSpQYcW6rJ5xcue_Ot6iwZsvB1gcdCI=.02554307-cec8-487d-ab46-6d205247205a@github.com> Message-ID: > Clean backport to fix recent JDK 21 backport regression. > > Additional testing: > - [x] New test fails without the fix, passes with it > - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8313262-c2-sinking-node-cast - Backport 1cee3b9fd9720e7938029a6992460b9053e65e57 ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/99/files - new: https://git.openjdk.org/jdk21u/pull/99/files/40877111..6f95682e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=99&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=99&range=00-01 Stats: 328 lines in 24 files changed: 260 ins; 1 del; 67 mod Patch: https://git.openjdk.org/jdk21u/pull/99.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/99/head:pull/99 PR: https://git.openjdk.org/jdk21u/pull/99 From stuefe at openjdk.org Thu Aug 24 13:20:35 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 24 Aug 2023 13:20:35 GMT Subject: [jdk11u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue [v2] In-Reply-To: References: Message-ID: <8SwjaUZd57avrnK8tCPMo6F22WLND8hJ4Jmv0muNEus=.c528d332-fc34-4405-b743-b32587bdef99@github.com> On Mon, 21 Aug 2023 12:16:15 GMT, Thomas Stuefe wrote: >> Unclean composite backport to fix JDK-8312182 - "THPs cause huge RSS due to thread start timing issue" (https://bugs.openjdk.org/browse/JDK-8312182) >> >> Problem: >> >> On a machine with transparent huge pages (THP) unconditionally enabled (/sys/kernel/mm/transparent_hugepage/enabled = "always"), the JVM may show a huge memory footprint (RSS) and degraded thread start performance. >> >> The following factors make the problem more severe and more likely: >> - thread stack size of 2M (on arm64 or x64) or larger >> - many threads, or high thread creation churn >> - a slow or overloaded machine (since part of the problem is timing-dependent) >> >> For a detailed discussion of the underlying problem, please see https://github.com/openjdk/jdk/pull/14919. >> >> ---------------- >> >> In jdk Head, the issue got fixed with a sequence of patches: >> >> - [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) "Make thread stacks not use huge pages" >> - [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) "THPs cause huge RSS due to thread start timing" >> >> However, JDK-8312182 itself needed one preparatory fix: >> - [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) "Fix THP detection on Linux" >> >> and then we had several corner-case test problems which are fixed with: >> - [JDK-8312394](https://bugs.openjdk.org/browse/JDK-8312394) "[linux] SIGSEGV if kernel was built without hugepage support" >> - [JDK-8312620](https://bugs.openjdk.org/browse/JDK-8312620) "WSL Linux build crashes after JDK-8310233" >> - [JDK-8314139](https://bugs.openjdk.org/browse/JDK-8314139) "TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores" >> >> and finally, we decided to rename the switch that allows to switch off the THP mitigation with a final patch: >> - [JDK-8312585](https://bugs.openjdk.org/browse/JDK-8312585) "Rename DisableTHPStackMitigation flag to THPStackMitigation" >> >> >> >> Instead of downporting these 7 patches verbatim, I prepared a composite patch containing only the necessary mitigation and mitigation tests. >> >> This patch does: >> - make sure that all thread stacks have at least one glibc guard page to prevent clustering of adjacent thread stacks into one VMA >> - change the default size of stacks to be not aligned to 2MB to prevent intra-stack THPs from forming >> >> The patch needs some infrastructure, but I downported only the necessary parts: the helper class "HugePages", which is used in head to scan the oper... > > Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into tstuefe-backport-84b325b8 > - Backport 84b325b844c08809448a9c073a11443d9e3c3f8e Friendly ping. It would be good to get this fixed in time for the next CPU. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2086#issuecomment-1691660053 From stuefe at openjdk.org Thu Aug 24 13:20:38 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 24 Aug 2023 13:20:38 GMT Subject: [jdk17u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 12:47:15 GMT, Thomas Stuefe wrote: > Unclean composite backport to jdk17u. Fixes JDK-8312182 - "THPs cause huge RSS due to thread start timing issue" (https://bugs.openjdk.org/browse/JDK-8312182) > > Problem: > > On a machine with transparent huge pages (THP) unconditionally enabled (/sys/kernel/mm/transparent_hugepage/enabled = "always"), the JVM may show a huge memory footprint (RSS) and degraded thread start performance. > > The following factors make the problem more severe and more likely: > - thread stack size of 2M (on arm64 or x64) or larger > - many threads, or high thread creation churn > - a slow or overloaded machine (since part of the problem is timing-dependent) > > For a detailed discussion of the underlying problem, please see https://github.com/openjdk/jdk/pull/14919. > > ---------------- > > In jdk Head, the issue got fixed with a sequence of patches: > > - [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) "Make thread stacks not use huge pages" > - [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) "THPs cause huge RSS due to thread start timing" > > However, JDK-8312182 itself needed one preparatory fix: > - [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) "Fix THP detection on Linux" > > and then we had several corner-case test problems which are fixed with: > - [JDK-8312394](https://bugs.openjdk.org/browse/JDK-8312394) "[linux] SIGSEGV if kernel was built without hugepage support" > - [JDK-8312620](https://bugs.openjdk.org/browse/JDK-8312620) "WSL Linux build crashes after JDK-8310233" > - [JDK-8314139](https://bugs.openjdk.org/browse/JDK-8314139) "TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores" > > and finally, we decided to rename the switch that allows to switch off the THP mitigation with a final patch: > - [JDK-8312585](https://bugs.openjdk.org/browse/JDK-8312585) "Rename DisableTHPStackMitigation flag to THPStackMitigation" > > > Instead of downporting these 7 patches verbatim, I prepared a composite patch containing only the necessary mitigation and mitigation tests. > > This is similar to the [jdk11u downport](https://github.com/openjdk/jdk11u-dev/pull/2086), but in jdk17u, [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) had been already backported. Therefore there are some minor differences. > > This patch does: > - make sure that all thread stacks have at least one glibc guard page to prevent clustering of adjacent thread stacks into one VMA > - change the default size of stacks to be not aligned to 2MB to prevent intra-stack... Friendly ping. It would be good to get this fixed in time for the next CPU. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1679#issuecomment-1691659782 From shade at openjdk.org Thu Aug 24 13:26:57 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 13:26:57 GMT Subject: [jdk21u] RFR: 8313701: GHA: RISC-V should use the official repository for bootstrap [v3] In-Reply-To: <43FjjUy5o5vyhHjg3tYbyAW_3NCVC4OJAioG6wfdTFU=.64005a19-a7e7-484c-a0c2-596010bb035d@github.com> References: <43FjjUy5o5vyhHjg3tYbyAW_3NCVC4OJAioG6wfdTFU=.64005a19-a7e7-484c-a0c2-596010bb035d@github.com> Message-ID: <7ykboBwcCs7ulf1lPSrBm1rdsoNg0Yx70jXSTPcjF9Q=.3ca37a99-c493-476a-8e78-101dee6a6698@github.com> > Clean backport to improve GHA stability. > > Additional testing: > - [ ] GHA Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8313701-gha-riscv-official - Merge branch 'master' into JDK-8313701-gha-riscv-official - Backport 538f9557b87f750264231f04bfbc91d15f8af8c0 ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/78/files - new: https://git.openjdk.org/jdk21u/pull/78/files/770ecad5..7b726918 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=78&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=78&range=01-02 Stats: 328 lines in 24 files changed: 260 ins; 1 del; 67 mod Patch: https://git.openjdk.org/jdk21u/pull/78.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/78/head:pull/78 PR: https://git.openjdk.org/jdk21u/pull/78 From stuefe at openjdk.org Thu Aug 24 13:27:42 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 24 Aug 2023 13:27:42 GMT Subject: [jdk17u-dev] RFR: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev In-Reply-To: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> References: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> Message-ID: On Thu, 24 Aug 2023 09:27:04 GMT, Aleksey Shipilev wrote: > Semi-clean backport to make RISC-V sysroot bootstrap more reliable. The conflict is in x86_32 line that contained additional packages for mainline GHA. > > Additional test: > - [x] GHA Looks good. ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1691#pullrequestreview-1593587639 From shade at openjdk.org Thu Aug 24 13:32:39 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 13:32:39 GMT Subject: [jdk17u-dev] RFR: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev In-Reply-To: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> References: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> Message-ID: On Thu, 24 Aug 2023 09:27:04 GMT, Aleksey Shipilev wrote: > Semi-clean backport to make RISC-V sysroot bootstrap more reliable. The conflict is in x86_32 line that contained additional packages for mainline GHA. > > Additional test: > - [x] GHA Yeah, so RISC-V sysroot still fails because we have not switched to official repo. This `libasound2:riscv64` failure is likely debian-ports slowly rotting even further. And we cannot switch cleanly with #1680, because official repo requires this `libfreetype6-dev` to be solved ?? . So I am inclined to integrate both to 17u and then hope we get a clean RISC-V run, and don't see further breakages. I am testing to see if https://github.com/openjdk/jdk21u/pull/78 would get a clean run with both patches in 21u. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1691#issuecomment-1691677654 From shade at openjdk.org Thu Aug 24 13:47:39 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 13:47:39 GMT Subject: [jdk17u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 13:18:01 GMT, Thomas Stuefe wrote: > Friendly ping. It would be good to get this fixed in time for the next CPU. I have concerns about this, for several reasons: 1. The fix has a considerable bugtail _in the product code_, which does not inspire confidence there would not be more soon; 2. The fix is enabled by default, which means any bugs in it would be exposed to users immediately; 3. The review is hard, because it cobbles 7 commits together, so it would take a while to disentangle if any mistakes crept in (note: the usual way to deal with this problem is to propose the PR with a commit per issue, so we can review individual commits); This also does not look like a recent regression, but rather a long-standing bug, right? So, is there a reason to rush it for 17.0.9 in October? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1679#issuecomment-1691709355 From shade at openjdk.org Thu Aug 24 14:31:55 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 14:31:55 GMT Subject: [jdk17u-dev] RFR: 8283724: Incorrect description for jtreg-failure-handler option Message-ID: Trivial clean backport to improve context for other backports in this area. ------------- Commit messages: - Backport 0901548833a0125f15fede64bc2e7dbe84fed42d Changes: https://git.openjdk.org/jdk17u-dev/pull/1692/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1692&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283724 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1692.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1692/head:pull/1692 PR: https://git.openjdk.org/jdk17u-dev/pull/1692 From zgu at openjdk.org Thu Aug 24 14:46:52 2023 From: zgu at openjdk.org (Zhengyu Gu) Date: Thu, 24 Aug 2023 14:46:52 GMT Subject: [jdk11u-dev] RFR: 8314950: CMS may miss NMT tag after mark stack expansion Message-ID: Please review this small fix that tags new mark stack after expansion. Thanks @MBaesken for reporting this bug. ------------- Commit messages: - 8314950: CMS may miss NMT tag after mark stack expansion Changes: https://git.openjdk.org/jdk11u-dev/pull/2097/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2097&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314950 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2097.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2097/head:pull/2097 PR: https://git.openjdk.org/jdk11u-dev/pull/2097 From tsteele at openjdk.org Thu Aug 24 15:03:56 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Thu, 24 Aug 2023 15:03:56 GMT Subject: [jdk21u] RFR: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [fdac6a6a](https://github.com/openjdk/jdk/commit/fdac6a6ac871366614efe44aca58ab520766b5c8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. It fixes TestByteBuffer.java, and depends on changes the backported by #77. > > The commit being backported was authored by Tyler Steele on 18 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe. > > Thanks! Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into backwaterred-backport-395fc788 - Backport 395fc78880a91eeb06a08c1abf6905d580a650c0 ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/82/files - new: https://git.openjdk.org/jdk21u/pull/82/files/1c027c6e..090829d3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=82&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=82&range=00-01 Stats: 1180 lines in 42 files changed: 962 ins; 106 del; 112 mod Patch: https://git.openjdk.org/jdk21u/pull/82.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/82/head:pull/82 PR: https://git.openjdk.org/jdk21u/pull/82 From shade at openjdk.org Thu Aug 24 15:09:38 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 15:09:38 GMT Subject: [jdk11u-dev] RFR: 8314950: CMS may miss NMT tag after mark stack expansion In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 14:41:42 GMT, Zhengyu Gu wrote: > Please review this small fix that tags new mark stack after expansion. > > Thanks @MBaesken for reporting this bug. Looks good. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2097#pullrequestreview-1593842415 From mbaesken at openjdk.org Thu Aug 24 15:26:36 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 24 Aug 2023 15:26:36 GMT Subject: [jdk11u-dev] RFR: 8314950: CMS may miss NMT tag after mark stack expansion In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 14:41:42 GMT, Zhengyu Gu wrote: > Please review this small fix that tags new mark stack after expansion. > > Thanks @MBaesken for reporting this bug. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2097#pullrequestreview-1593876104 From shade at openjdk.org Thu Aug 24 15:47:55 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 15:47:55 GMT Subject: [jdk17u-dev] Withdrawn: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev In-Reply-To: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> References: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> Message-ID: On Thu, 24 Aug 2023 09:27:04 GMT, Aleksey Shipilev wrote: > Semi-clean backport to make RISC-V sysroot bootstrap more reliable. The conflict is in x86_32 line that contained additional packages for mainline GHA. > > Additional test: > - [x] GHA This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1691 From zgu at openjdk.org Thu Aug 24 15:54:33 2023 From: zgu at openjdk.org (Zhengyu Gu) Date: Thu, 24 Aug 2023 15:54:33 GMT Subject: [jdk11u-dev] RFR: 8314950: CMS may miss NMT tag after mark stack expansion In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 15:07:15 GMT, Aleksey Shipilev wrote: >> Please review this small fix that tags new mark stack after expansion. >> >> Thanks @MBaesken for reporting this bug. > > Looks good. Thanks, @shipilev and @MBaesken ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2097#issuecomment-1691947345 From shade at openjdk.org Thu Aug 24 15:54:34 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 15:54:34 GMT Subject: [jdk11u-dev] RFR: 8314950: CMS may miss NMT tag after mark stack expansion In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 14:41:42 GMT, Zhengyu Gu wrote: > Please review this small fix that tags new mark stack after expansion. > > Thanks @MBaesken for reporting this bug. > /integrate Hold on now, you need to request `jdk11u-fix-request` for pushes to jdk11u-dev. Please do one retro-actively. If maintainers reject the backport, we would need to yank it. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2097#issuecomment-1691956784 From zgu at openjdk.org Thu Aug 24 15:54:35 2023 From: zgu at openjdk.org (Zhengyu Gu) Date: Thu, 24 Aug 2023 15:54:35 GMT Subject: [jdk11u-dev] Integrated: 8314950: CMS may miss NMT tag after mark stack expansion In-Reply-To: References: Message-ID: <7DihcK52gk17iDQpcFrgK84SQCC1PXjuCZCUcP9L-cM=.b49deb54-e2e4-4b3d-a3b5-5eb952383e98@github.com> On Thu, 24 Aug 2023 14:41:42 GMT, Zhengyu Gu wrote: > Please review this small fix that tags new mark stack after expansion. > > Thanks @MBaesken for reporting this bug. This pull request has now been integrated. Changeset: cde3cd2a Author: Zhengyu Gu URL: https://git.openjdk.org/jdk11u-dev/commit/cde3cd2a940a83ecf62ec800897420b16e3e1386 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8314950: CMS may miss NMT tag after mark stack expansion Reviewed-by: shade, mbaesken ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2097 From stuefe at openjdk.org Thu Aug 24 16:15:28 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 24 Aug 2023 16:15:28 GMT Subject: [jdk17u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 13:44:39 GMT, Aleksey Shipilev wrote: >> Friendly ping. It would be good to get this fixed in time for the next CPU. > >> Friendly ping. It would be good to get this fixed in time for the next CPU. > > I have concerns about this, for several reasons: > 1. The fix has a considerable bugtail _in the product code_, which does not inspire confidence there would not be more soon; > 2. The fix is enabled by default, which means any bugs in it would be exposed to users immediately; > 3. The review is hard, because it cobbles 7 commits together, so it would take a while to disentangle if any mistakes crept in (note: the usual way to deal with this problem is to propose the PR with a commit per issue, so we can review individual commits); > > This also does not look like a recent regression, but rather a long-standing bug, right? > So, is there a reason to rush it for 17.0.9 in October? @shipilev Thanks for looking at this. I debated with myself for a long time whether this was the right approach. I did not choose to build a composite patch out of laziness (if anything, downporting the issues separately and verbatim would have been much simpler, albeit slower). By providing a minimal (not cobbled together but carefully selected) patch I minimize the problem surface because I leave out code that have nothing to do with the goal of this patch: the static hugepage detection of [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) "Fix THP detection on Linux"). > * The fix has a considerable bugtail _in the product code_, which does not inspire confidence there will not be more soon; we have two trailing bugs in product code: a) [JDK-8312394](https://bugs.openjdk.org/browse/JDK-8312394) "[linux] SIGSEGV if kernel was built without hugepage support" b) [JDK-8312620](https://bugs.openjdk.org/browse/JDK-8312620) "WSL Linux build crashes after JDK-8310233" (a) JDK-8312394 is of no concern since it only affects code I explicitly left out from the patch (it does not affect THPs). It would be a concern were I to downport patches individually and verbatim. That leaves (b), which is a bug in a super obscure context (building on Windows with WSL that carries an arguably broken Linux kernel). One bug is not a very long tail. > > * The fix is enabled by default, which means any bugs in it would be exposed to users immediately; > I think this patch is just not that risky. > * The review is hard, because it cobbles 7 commits together, so it would take a while to disentangle if any mistakes crept in (note: the usual way to deal with this problem is to propose the PR with a commit per issue, so we can review individual commits); But that process would carry more risk since I would have to downport unnecessary parts and have time windows with unfixed bugs. This also shows a shortcoming of the review process. If I downport stuff verbatim, reviews are simple since they are mostly mechanical mental diffing; but that is not the most ideal patch, which would be one that is small and confined. > > This also does not look like a recent regression, but rather a long-standing bug, right? So, is there a reason to rush it for 17.0.9 in October? We have customers running with THP enabled always and unwilling or unable to change that; they would be happy about a fix. I'm fine with postponing this patch (not that I have any choice since I lack reviews and the window is almost closed). But the whole discussion leaves me dissatisfied with the practice of downporting whole patch trees to get a single issue fixed. We recently had similar discussions when downporting https://github.com/openjdk/jdk11u-dev/pull/2035 which ended up a far bigger change than necessary, carrying a lot of code for the sole purpose of keeping a low delta to upstream. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1679#issuecomment-1691994196 From shade at openjdk.org Thu Aug 24 16:32:34 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 16:32:34 GMT Subject: [jdk11u-dev] RFR: 8314950: CMS may miss NMT tag after mark stack expansion In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 15:47:20 GMT, Zhengyu Gu wrote: >> Looks good. > > Thanks, @shipilev and @MBaesken @zhengyu123 ^^^ ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2097#issuecomment-1692031420 From aturbanov at openjdk.org Thu Aug 24 17:03:44 2023 From: aturbanov at openjdk.org (Andrey Turbanov) Date: Thu, 24 Aug 2023 17:03:44 GMT Subject: [jdk17u-dev] Integrated: 8299827: Add resolved IP address in connection exception for sockets In-Reply-To: References: Message-ID: On Fri, 21 Jul 2023 11:37:36 GMT, Andrey Turbanov wrote: > 8299827: Add resolved IP address in connection exception for sockets This pull request has now been integrated. Changeset: 40add10f Author: Andrey Turbanov Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/40add10f8ba99ee3da50e07c30340a8e15a7b86c Stats: 18 lines in 2 files changed: 3 ins; 10 del; 5 mod 8299827: Add resolved IP address in connection exception for sockets Backport-of: 92d8326e4037605897d7c4eb4b3edb63a2fc11b0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1612 From andrewlu at openjdk.org Thu Aug 24 17:05:39 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 24 Aug 2023 17:05:39 GMT Subject: [jdk11u-dev] Integrated: 8306718: Optimize and opensource some old AWT tests In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 08:50:22 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. This pull request has now been integrated. Changeset: e65fbde3 Author: Andrew Lu Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/e65fbde33a273792b0132ffe5a209b56c2b134b1 Stats: 410 lines in 4 files changed: 410 ins; 0 del; 0 mod 8306718: Optimize and opensource some old AWT tests Backport-of: 9beae21864d18054ca3762ec989d51ff0660db84 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2085 From andrewlu at openjdk.org Thu Aug 24 17:05:52 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 24 Aug 2023 17:05:52 GMT Subject: [jdk11u-dev] Integrated: 8307078: Opensource and clean up five more AWT Focus related tests In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 02:15:53 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. This pull request has now been integrated. Changeset: 094cd261 Author: Andrew Lu Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/094cd261aef11446c9a50819bb29f37570467dd1 Stats: 965 lines in 5 files changed: 965 ins; 0 del; 0 mod 8307078: Opensource and clean up five more AWT Focus related tests Backport-of: 6d6f726b74f7fcd3e7c37d50bd2476b3e921662b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2083 From andrewlu at openjdk.org Thu Aug 24 17:07:02 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 24 Aug 2023 17:07:02 GMT Subject: [jdk11u-dev] Integrated: 8307080: Open source some more JComboBox jtreg tests In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 06:54:28 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.21-oracle. This pull request has now been integrated. Changeset: eeec20f4 Author: Andrew Lu Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/eeec20f4c861ccde56a54545245673bc572ccb89 Stats: 425 lines in 5 files changed: 425 ins; 0 del; 0 mod 8307080: Open source some more JComboBox jtreg tests Backport-of: b8de39431dca90e63552968829a349a9b63e68ca ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2080 From shade at openjdk.org Thu Aug 24 17:54:34 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 24 Aug 2023 17:54:34 GMT Subject: [jdk17u-dev] RFR: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev In-Reply-To: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> References: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> Message-ID: On Thu, 24 Aug 2023 09:27:04 GMT, Aleksey Shipilev wrote: > Semi-clean backport to make RISC-V sysroot bootstrap more reliable. The conflict is in x86_32 line that contained additional packages for mainline GHA. > > Additional test: > - [x] GHA Operator error: deleted branch by mistake. Should still work. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1691#issuecomment-1692163644 From rriggs at openjdk.org Thu Aug 24 18:08:36 2023 From: rriggs at openjdk.org (Roger Riggs) Date: Thu, 24 Aug 2023 18:08:36 GMT Subject: [jdk21u] Integrated: 8313312: Add missing classpath exception copyright header In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 19:21:55 GMT, Roger Riggs wrote: > The same copyright updates are needed in jdk21u. This pull request has now been integrated. Changeset: 4729fad0 Author: Roger Riggs URL: https://git.openjdk.org/jdk21u/commit/4729fad053b8bdbd821f70141d5c702e72ae6886 Stats: 48 lines in 16 files changed: 32 ins; 0 del; 16 mod 8313312: Add missing classpath exception copyright header Reviewed-by: bpb Backport-of: 53ca75b18ea419d469758475fac8352bf915b484 ------------- PR: https://git.openjdk.org/jdk21u/pull/71 From hchao at openjdk.org Thu Aug 24 18:19:27 2023 From: hchao at openjdk.org (Hai-May Chao) Date: Thu, 24 Aug 2023 18:19:27 GMT Subject: [jdk21u] RFR: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 11:40:22 GMT, Nibedita Jena wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8312489 (e47a84f23dd2608c6f5748093eefe301fb5bf750) Marked as reviewed by hchao (no project role). Change looks good. Thanks. ------------- PR Review: https://git.openjdk.org/jdk21u/pull/76#pullrequestreview-1594191833 PR Comment: https://git.openjdk.org/jdk21u/pull/76#issuecomment-1692194944 From serb at openjdk.org Thu Aug 24 18:20:39 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 24 Aug 2023 18:20:39 GMT Subject: [jdk17u-dev] RFR: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException Message-ID: Hi all, This pull request contains a backport of commit [87298d2a](https://github.com/openjdk/jdk/commit/87298d2ade41c689d3140981a123b0e9130fc651) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race. Thanks! ------------- Commit messages: - Backport 87298d2ade41c689d3140981a123b0e9130fc651 Changes: https://git.openjdk.org/jdk17u-dev/pull/1689/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1689&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312535 Stats: 66 lines in 3 files changed: 59 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1689.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1689/head:pull/1689 PR: https://git.openjdk.org/jdk17u-dev/pull/1689 From serb at openjdk.org Thu Aug 24 18:32:43 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 24 Aug 2023 18:32:43 GMT Subject: [jdk21u] RFR: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException Message-ID: Hi all, This pull request contains a backport of commit [87298d2a](https://github.com/openjdk/jdk/commit/87298d2ade41c689d3140981a123b0e9130fc651) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race. Thanks! ------------- Commit messages: - Backport 87298d2ade41c689d3140981a123b0e9130fc651 Changes: https://git.openjdk.org/jdk21u/pull/96/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=96&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312535 Stats: 66 lines in 3 files changed: 59 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u/pull/96.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/96/head:pull/96 PR: https://git.openjdk.org/jdk21u/pull/96 From serb at openjdk.org Thu Aug 24 18:35:59 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 24 Aug 2023 18:35:59 GMT Subject: [jdk11u-dev] RFR: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException Message-ID: Hi all, This pull request contains a backport of commit [87298d2a](https://github.com/openjdk/jdk/commit/87298d2ade41c689d3140981a123b0e9130fc651) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race. Thanks! ------------- Commit messages: - Backport 87298d2ade41c689d3140981a123b0e9130fc651 Changes: https://git.openjdk.org/jdk11u-dev/pull/2095/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2095&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312535 Stats: 66 lines in 3 files changed: 59 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2095.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2095/head:pull/2095 PR: https://git.openjdk.org/jdk11u-dev/pull/2095 From v-terrychow at microsoft.com Thu Aug 24 18:42:41 2023 From: v-terrychow at microsoft.com (Terry Chow (Simba Technologies Inc)) Date: Thu, 24 Aug 2023 18:42:41 +0000 Subject: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u In-Reply-To: <26a6d12b49b4b19e24b9e8e75eb382376848df16.camel@redhat.com> References: <26a6d12b49b4b19e24b9e8e75eb382376848df16.camel@redhat.com> Message-ID: Hi Severin, Thanks for the feedback. Just to confirm some details, is this the correct repo for backports into 21u? I was expecting a "jdk21u-dev" repo, similar to 17u and 11u. openjdk/jdk21u: https://openjdk.org/projects/jdk-updates (github.com) Also, can the guide below be applied to backporting into 21u, the process is the same as 17u and 11u? There aren't any specific details I need to be aware of to get a backport into 21u right? How to contribute or backport a fix - How to contribute or backport a fix - OpenJDK Wiki Thanks, Terry ________________________________ From: Severin Gehwolf Sent: August 24, 2023 1:17 AM To: Terry Chow (Simba Technologies Inc) ; jdk-updates-dev at openjdk.org Subject: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u [You don't often get email from sgehwolf at redhat.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hi Terry, On Thu, 2023-08-24 at 00:54 +0000, Terry Chow (Simba Technologies Inc) wrote: > Hi maintainers of OpenJDK updates, > > I'd like to backport JDK-8308593 (keepalive extended socket options for Windows) to 11u and 17u (maybe 8u later as well). And so, I just want to open discussion on this topic to hear your opinions before I start the backporting process. I did some initial investigation on the backport and I learned the following: > > Backporting to 11u requires three additional changes to be made on top of the backport in order for it to work. > 1. Lib-jdk.net.gmk will need to be updated to support building extnet for Windows. > 2. jdk.net.ExtendedSocketOption will need to add a case to support returning a Windows instance of PlatformSocketOptions. > 3. The Windows PlainSocketImpl class needs to have the same code on lines 61 - 96 in the Unix PlainSocketImpl class. > Backporting to 17u requires two additional changes (similar to 11u). > 1. jdk.net/Lib.gmkwill need to be updated to support building extnet for Windows. > 2. jdk.net.ExtendedSocketOption will need to add a case to support returning a Windows instance of PlatformSocketOptions. > Let me know if the additional changes are acceptable or if they're disruptive. As the change went into JDK 22, I'd first suggest to get this into JDK 21u which would bring this feature to LTS users. JDK 17u seems OK as a next step from a brief glance (once it's in 21u). Only then we should evaluate JDK 11u and older releases. Thanks, Severin -------------- next part -------------- An HTML attachment was scrubbed... URL: From valeriep at openjdk.org Thu Aug 24 19:31:20 2023 From: valeriep at openjdk.org (Valerie Peng) Date: Thu, 24 Aug 2023 19:31:20 GMT Subject: [jdk21u] Integrated: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154 In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 19:01:26 GMT, Valerie Peng wrote: > Hi all, > > This pull request contains a backport of commit [ba6cdbe2](https://github.com/openjdk/jdk/commit/ba6cdbe2c2897a0fdc266119f0fe4545c3352b8e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Valerie Peng on 22 Aug 2023 and was reviewed by Matthias Baesken and Jamil Nimeh. > > Thanks! This pull request has now been integrated. Changeset: c849fa5b Author: Valerie Peng URL: https://git.openjdk.org/jdk21u/commit/c849fa5b1fe52ff92588762fb739253d6f2044b6 Stats: 53 lines in 2 files changed: 39 ins; 12 del; 2 mod 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154 Backport-of: ba6cdbe2c2897a0fdc266119f0fe4545c3352b8e ------------- PR: https://git.openjdk.org/jdk21u/pull/93 From pchilanomate at openjdk.org Thu Aug 24 19:34:32 2023 From: pchilanomate at openjdk.org (Patricio Chilano Mateo) Date: Thu, 24 Aug 2023 19:34:32 GMT Subject: [jdk21u] RFR: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter Message-ID: This pull request contains a backport of commit [8e4240c3](https://github.com/openjdk/jdk/commit/8e4240c3167ff6c803f3391f70ef9cfa7f408085) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Patricio Chilano Mateo on 24 Aug 2023 and was reviewed by Ron Pressler and Andrew Haley. Thanks! ------------- Commit messages: - Backport 8e4240c3167ff6c803f3391f70ef9cfa7f408085 Changes: https://git.openjdk.org/jdk21u/pull/100/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=100&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314850 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/100.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/100/head:pull/100 PR: https://git.openjdk.org/jdk21u/pull/100 From stuefe at openjdk.org Fri Aug 25 05:44:25 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 25 Aug 2023 05:44:25 GMT Subject: [jdk17u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 12:47:15 GMT, Thomas Stuefe wrote: > Unclean composite backport to jdk17u. Fixes JDK-8312182 - "THPs cause huge RSS due to thread start timing issue" (https://bugs.openjdk.org/browse/JDK-8312182) > > Problem: > > On a machine with transparent huge pages (THP) unconditionally enabled (/sys/kernel/mm/transparent_hugepage/enabled = "always"), the JVM may show a huge memory footprint (RSS) and degraded thread start performance. > > The following factors make the problem more severe and more likely: > - thread stack size of 2M (on arm64 or x64) or larger > - many threads, or high thread creation churn > - a slow or overloaded machine (since part of the problem is timing-dependent) > > For a detailed discussion of the underlying problem, please see https://github.com/openjdk/jdk/pull/14919. > > ---------------- > > In jdk Head, the issue got fixed with a sequence of patches: > > - [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) "Make thread stacks not use huge pages" > - [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) "THPs cause huge RSS due to thread start timing" > > However, JDK-8312182 itself needed one preparatory fix: > - [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) "Fix THP detection on Linux" > > and then we had several corner-case test problems which are fixed with: > - [JDK-8312394](https://bugs.openjdk.org/browse/JDK-8312394) "[linux] SIGSEGV if kernel was built without hugepage support" > - [JDK-8312620](https://bugs.openjdk.org/browse/JDK-8312620) "WSL Linux build crashes after JDK-8310233" > - [JDK-8314139](https://bugs.openjdk.org/browse/JDK-8314139) "TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores" > > and finally, we decided to rename the switch that allows to switch off the THP mitigation with a final patch: > - [JDK-8312585](https://bugs.openjdk.org/browse/JDK-8312585) "Rename DisableTHPStackMitigation flag to THPStackMitigation" > > > Instead of downporting these 7 patches verbatim, I prepared a composite patch containing only the necessary mitigation and mitigation tests. > > This is similar to the [jdk11u downport](https://github.com/openjdk/jdk11u-dev/pull/2086), but in jdk17u, [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) had been already backported. Therefore there are some minor differences. > > This patch does: > - make sure that all thread stacks have at least one glibc guard page to prevent clustering of adjacent thread stacks into one VMA > - change the default size of stacks to be not aligned to 2MB to prevent intra-stack... okay, I'll withdraw. Let's do it piece by piece as usual. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1679#issuecomment-1692791488 From stuefe at openjdk.org Fri Aug 25 05:44:27 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 25 Aug 2023 05:44:27 GMT Subject: [jdk11u-dev] Withdrawn: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: On Thu, 17 Aug 2023 14:50:49 GMT, Thomas Stuefe wrote: > Unclean composite backport to fix JDK-8312182 - "THPs cause huge RSS due to thread start timing issue" (https://bugs.openjdk.org/browse/JDK-8312182) > > Problem: > > On a machine with transparent huge pages (THP) unconditionally enabled (/sys/kernel/mm/transparent_hugepage/enabled = "always"), the JVM may show a huge memory footprint (RSS) and degraded thread start performance. > > The following factors make the problem more severe and more likely: > - thread stack size of 2M (on arm64 or x64) or larger > - many threads, or high thread creation churn > - a slow or overloaded machine (since part of the problem is timing-dependent) > > For a detailed discussion of the underlying problem, please see https://github.com/openjdk/jdk/pull/14919. > > ---------------- > > In jdk Head, the issue got fixed with a sequence of patches: > > - [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) "Make thread stacks not use huge pages" > - [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) "THPs cause huge RSS due to thread start timing" > > However, JDK-8312182 itself needed one preparatory fix: > - [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) "Fix THP detection on Linux" > > and then we had several corner-case test problems which are fixed with: > - [JDK-8312394](https://bugs.openjdk.org/browse/JDK-8312394) "[linux] SIGSEGV if kernel was built without hugepage support" > - [JDK-8312620](https://bugs.openjdk.org/browse/JDK-8312620) "WSL Linux build crashes after JDK-8310233" > - [JDK-8314139](https://bugs.openjdk.org/browse/JDK-8314139) "TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores" > > and finally, we decided to rename the switch that allows to switch off the THP mitigation with a final patch: > - [JDK-8312585](https://bugs.openjdk.org/browse/JDK-8312585) "Rename DisableTHPStackMitigation flag to THPStackMitigation" > > > > Instead of downporting these 7 patches verbatim, I prepared a composite patch containing only the necessary mitigation and mitigation tests. > > This patch does: > - make sure that all thread stacks have at least one glibc guard page to prevent clustering of adjacent thread stacks into one VMA > - change the default size of stacks to be not aligned to 2MB to prevent intra-stack THPs from forming > > The patch needs some infrastructure, but I downported only the necessary parts: the helper class "HugePages", which is used in head to scan the operating system for information about THP settings. I only included the parts to do... This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2086 From stuefe at openjdk.org Fri Aug 25 05:44:27 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 25 Aug 2023 05:44:27 GMT Subject: [jdk17u-dev] Withdrawn: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 12:47:15 GMT, Thomas Stuefe wrote: > Unclean composite backport to jdk17u. Fixes JDK-8312182 - "THPs cause huge RSS due to thread start timing issue" (https://bugs.openjdk.org/browse/JDK-8312182) > > Problem: > > On a machine with transparent huge pages (THP) unconditionally enabled (/sys/kernel/mm/transparent_hugepage/enabled = "always"), the JVM may show a huge memory footprint (RSS) and degraded thread start performance. > > The following factors make the problem more severe and more likely: > - thread stack size of 2M (on arm64 or x64) or larger > - many threads, or high thread creation churn > - a slow or overloaded machine (since part of the problem is timing-dependent) > > For a detailed discussion of the underlying problem, please see https://github.com/openjdk/jdk/pull/14919. > > ---------------- > > In jdk Head, the issue got fixed with a sequence of patches: > > - [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) "Make thread stacks not use huge pages" > - [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) "THPs cause huge RSS due to thread start timing" > > However, JDK-8312182 itself needed one preparatory fix: > - [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) "Fix THP detection on Linux" > > and then we had several corner-case test problems which are fixed with: > - [JDK-8312394](https://bugs.openjdk.org/browse/JDK-8312394) "[linux] SIGSEGV if kernel was built without hugepage support" > - [JDK-8312620](https://bugs.openjdk.org/browse/JDK-8312620) "WSL Linux build crashes after JDK-8310233" > - [JDK-8314139](https://bugs.openjdk.org/browse/JDK-8314139) "TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores" > > and finally, we decided to rename the switch that allows to switch off the THP mitigation with a final patch: > - [JDK-8312585](https://bugs.openjdk.org/browse/JDK-8312585) "Rename DisableTHPStackMitigation flag to THPStackMitigation" > > > Instead of downporting these 7 patches verbatim, I prepared a composite patch containing only the necessary mitigation and mitigation tests. > > This is similar to the [jdk11u downport](https://github.com/openjdk/jdk11u-dev/pull/2086), but in jdk17u, [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215) had been already backported. Therefore there are some minor differences. > > This patch does: > - make sure that all thread stacks have at least one glibc guard page to prevent clustering of adjacent thread stacks into one VMA > - change the default size of stacks to be not aligned to 2MB to prevent intra-stack... This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1679 From shade at openjdk.org Fri Aug 25 06:25:27 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 06:25:27 GMT Subject: [jdk17u-dev] RFR: 8283724: Incorrect description for jtreg-failure-handler option In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 14:25:53 GMT, Aleksey Shipilev wrote: > Trivial clean backport to improve context for other backports in this area. Push approval granted. Testing is clean, apart from known RISC-V sysroot creation failure. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1692#issuecomment-1692829591 From shade at openjdk.org Fri Aug 25 06:25:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 06:25:28 GMT Subject: [jdk17u-dev] Integrated: 8283724: Incorrect description for jtreg-failure-handler option In-Reply-To: References: Message-ID: <8BWy7Ucdl27TniBhgCtMQ__dBAVdTWeA0YjWZ_jMkPs=.fd27c548-93d3-496b-9a6d-75254f9eb864@github.com> On Thu, 24 Aug 2023 14:25:53 GMT, Aleksey Shipilev wrote: > Trivial clean backport to improve context for other backports in this area. This pull request has now been integrated. Changeset: e070c315 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/e070c31515c4ca3348757ca56fa8adf57e8cf5a2 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8283724: Incorrect description for jtreg-failure-handler option Backport-of: 0901548833a0125f15fede64bc2e7dbe84fed42d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1692 From shade at openjdk.org Fri Aug 25 06:36:24 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 06:36:24 GMT Subject: [jdk17u-dev] RFR: 8313701: GHA: RISC-V should use the official repository for bootstrap In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 14:28:25 GMT, Aleksey Shipilev wrote: > Unclean backport to improve GHA stability. The conflict is due to RISC-V GHA changes of the slightly different form in 17u: does not have explicit `keyring` handling blocks. That block is going away with another clean up upstream, so I just resolved the conflict to only update the `debian-repository` itself. > > Additional testing: > - [x] GHA Push approval granted. RISC-V sysroot creation should be fixed after we integrate another PR, mentioned above. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1680#issuecomment-1692838939 From shade at openjdk.org Fri Aug 25 06:36:25 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 06:36:25 GMT Subject: [jdk17u-dev] Integrated: 8313701: GHA: RISC-V should use the official repository for bootstrap In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 14:28:25 GMT, Aleksey Shipilev wrote: > Unclean backport to improve GHA stability. The conflict is due to RISC-V GHA changes of the slightly different form in 17u: does not have explicit `keyring` handling blocks. That block is going away with another clean up upstream, so I just resolved the conflict to only update the `debian-repository` itself. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: e84d9ddf Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/e84d9ddf5ae065f87e1c2bb220deb0ffddc20221 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8313701: GHA: RISC-V should use the official repository for bootstrap Reviewed-by: phh Backport-of: 538f9557b87f750264231f04bfbc91d15f8af8c0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1680 From goetz at openjdk.org Fri Aug 25 06:39:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 25 Aug 2023 06:39:25 GMT Subject: [jdk11u-dev] RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation In-Reply-To: References: Message-ID: On Tue, 22 Aug 2023 13:53:20 GMT, Alexander Scherbatiy wrote: > This is a clean backport of the fix `8295737: macOS: Print content cut off when width > height with portrait orientation`. > > The fix allows to print a page which width is greater than height with portrait orientation on macOS. > Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. Please backport this to 17 first. Then label for 11 again. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2092#issuecomment-1692843325 From shade at openjdk.org Fri Aug 25 06:40:25 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 06:40:25 GMT Subject: [jdk17u-dev] RFR: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev In-Reply-To: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> References: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> Message-ID: On Thu, 24 Aug 2023 09:27:04 GMT, Aleksey Shipilev wrote: > Semi-clean backport to make RISC-V sysroot bootstrap more reliable. The conflict is in x86_32 line that contained additional packages for mainline GHA. > > Additional test: > - [x] GHA Push approval granted. RISC-V sysroot creation is supposed to finish well now. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1691#issuecomment-1692842060 From shade at openjdk.org Fri Aug 25 06:40:26 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 06:40:26 GMT Subject: [jdk17u-dev] Integrated: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev In-Reply-To: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> References: <4PEvaPkVmHiGthlMtlohSxKgvBiKhK3G3-f0FvzSUGI=.9e5fdff9-fa97-429a-9d3f-de0f188a8a3b@github.com> Message-ID: <7qKciw9zY96XjLPIeRWqUEq0WoOBO3tZ2a0RFOxjfEI=.17f0ecc3-f55a-4369-b871-26b28ae71c78@github.com> On Thu, 24 Aug 2023 09:27:04 GMT, Aleksey Shipilev wrote: > Semi-clean backport to make RISC-V sysroot bootstrap more reliable. The conflict is in x86_32 line that contained additional packages for mainline GHA. > > Additional test: > - [x] GHA This pull request has now been integrated. Changeset: d9985d03 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/d9985d033fcbec5afef20b3e7d8fdd97ad355123 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev Reviewed-by: stuefe Backport-of: 69d900d2ce97e5479020cff9a63c471d07e39989 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1691 From shade at openjdk.org Fri Aug 25 06:50:12 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 06:50:12 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v5] In-Reply-To: References: Message-ID: > Unclean backport to get useful experimental feature to LTS users. > > In addition to usual contextual differences, there is a number of differences against upstream version: > - `synchronizer.cpp` hunks are different, since we do not have [JDK-8256302](https://github.com/openjdk/jdk/commit/6402004852ccc993bb6e879c49fb71e2afdcdfbe) in JDK 17 > - `NativeHeapTrimmer_lock` changed from `Mutex::safepoint` to `Mutex::leaf`, since [JDK-8273915](https://github.com/openjdk/jdk/commit/111d5e1a9324cb5e8d98627f6329d17fcbc9c13d) renamed it after JDK 17 > - `NativeHeapTrimmer_lock` should also allow VMThread block and never require safepoint checks; this was simplified by [JDK-8274004](https://bugs.openjdk.org/browse/JDK-8274004) later > - `vmError.cpp` code was rewritten in JDK 17 style > - gtest uses `EXPECT_NOT_NULL`, only brought by [JDK-8295865](https://github.com/openjdk/jdk/commit/657a0b2f1564e1754dbd64b776c53a52c480c901#diff-35b3b4703decd15bfd2fc614d431e909727a6cf4d399cf05c7a12466e61ab8a0R58-R59) -- I rewrote them to EXPECT_NE/EQ. > > Additional testing: > - [x] Linux x86_64 fastdebug, trim tests > - [x] Linux x86_64 fastdebug, `tier1` > - [x] Linux x86_64 fastdebug, `tier2` > - [x] Linux x86_64 fastdebug, `tier3` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'master' into JDK-8293114-trim-native - Merge branch 'master' into JDK-8293114-trim-native - More adjustments - Adjustments - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1616/files - new: https://git.openjdk.org/jdk17u-dev/pull/1616/files/e5e158a2..611e8529 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1616&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1616&range=03-04 Stats: 1856 lines in 57 files changed: 1350 ins; 63 del; 443 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1616.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1616/head:pull/1616 PR: https://git.openjdk.org/jdk17u-dev/pull/1616 From shade at openjdk.org Fri Aug 25 06:50:49 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 06:50:49 GMT Subject: [jdk17u-dev] RFR: 8292717: Clean up checking of testing requirements in configure Message-ID: Prepares build system for cleaner googletest and jtreg dependency updates. After this, at least googletest update applies only with minor conflicts. I expect jtreg updates would be smoother too. I did this PR by reverting JDK-8292716 and JDK-8292763 fixes, applying this move cleanly, and then reapplying the first two cleanly. See commit history for individual commits. This makes sure we do not miss anything in backports. @GoeLin, you might want to take a look. Additional testing: - [ ] GHA ------------- Commit messages: - Clean backport: JDK-8292763: JDK-8292716 breaks configure without jtreg - Clean backport: JDK-8292716: Configure should check that jtreg is of the required version - Clean backport JDK-8292717: Clean up checking of testing requirements in configure - Revert "8292716: Configure should check that jtreg is of the required version" Changes: https://git.openjdk.org/jdk17u-dev/pull/1693/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1693&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292717 Stats: 348 lines in 4 files changed: 174 ins; 172 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1693.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1693/head:pull/1693 PR: https://git.openjdk.org/jdk17u-dev/pull/1693 From shade at openjdk.org Fri Aug 25 06:56:10 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 06:56:10 GMT Subject: [jdk17u-dev] RFR: 8313262: C2: Sinking node may cause required cast to be dropped [v2] In-Reply-To: References: Message-ID: > Clean backport to fix recent JDK 17 backport regression. > > Additional testing: > - [x] New test fails without the fix, passes with it > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8313262-c2-sinking-node - Backport 1cee3b9fd9720e7938029a6992460b9053e65e57 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1690/files - new: https://git.openjdk.org/jdk17u-dev/pull/1690/files/c94da7e7..2cb00f49 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1690&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1690&range=00-01 Stats: 22 lines in 5 files changed: 3 ins; 10 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1690.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1690/head:pull/1690 PR: https://git.openjdk.org/jdk17u-dev/pull/1690 From mbaesken at openjdk.org Fri Aug 25 07:00:17 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 25 Aug 2023 07:00:17 GMT Subject: [jdk17u-dev] Integrated: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 In-Reply-To: References: Message-ID: On Tue, 22 Aug 2023 14:21:40 GMT, Matthias Baesken wrote: > 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 This pull request has now been integrated. Changeset: 14215408 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/142154084d318e423e7476abd45ace19316e90fe Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 Backport-of: d24b7b7026cf85f1aecf44f60819762872cfd5c1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1685 From coffeys at openjdk.org Fri Aug 25 07:00:47 2023 From: coffeys at openjdk.org (Sean Coffey) Date: Fri, 25 Aug 2023 07:00:47 GMT Subject: [jdk21u] RFR: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers Message-ID: Reduce the excessive number of InvalidParameterSpecException objects created in TLS environments where non-JDK provider may be in use ------------- Commit messages: - Backport e554fdee254ce51d605fe127b73644620e87e23b Changes: https://git.openjdk.org/jdk21u/pull/101/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=101&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311592 Stats: 14 lines in 1 file changed: 5 ins; 3 del; 6 mod Patch: https://git.openjdk.org/jdk21u/pull/101.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/101/head:pull/101 PR: https://git.openjdk.org/jdk21u/pull/101 From shade at openjdk.org Fri Aug 25 07:03:16 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 07:03:16 GMT Subject: [jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: <8v4j2R_vOJBXWJCZtWEtI9rLtV1gIrJjNilO1DDRTW8=.a22ce71a-e927-43c8-aef4-4aaedcc44e33@github.com> Message-ID: On Tue, 22 Aug 2023 02:22:01 GMT, Andrew John Hughes wrote: >> I'm very much in favor of dropping the GCC minor version dependency since it has been a huge pain. I don't care for patch direction, as long as we can convince mainline to do the same. > >> I'm very much in favor of dropping the GCC minor version dependency since it has been a huge pain. I don't care for patch direction, as long as we can convince mainline to do the same. > > Hopefully. Having had tests fail three times in the last week due to this (once in 11u, once in 17u and once in our own fork of 21u), I'm surprised people have stuck with it this long. @gnu-andrew, you need `jdk17u-fix-request` on it now, I think. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1673#issuecomment-1692867771 From shade at openjdk.org Fri Aug 25 07:04:15 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 07:04:15 GMT Subject: [jdk17u-dev] RFR: 8272998: ImageIO.read() throws incorrect exception type In-Reply-To: References: Message-ID: <__bJOckqv1millTpMLDgBGmqSagM4CX9LoGfb_zy1So=.0c8e4f76-e8f0-4561-848d-7f45d6ef4f49@github.com> On Thu, 13 Jul 2023 23:32:49 GMT, Jenny Shivayogi wrote: > Backport for [JDK-8272998] > ImageIO.read() throws incorrect exception type > New tests all pass > tier1 tested with GHA > tier2 tested on linux @kspeeyu, you need to request the push approval for 17u-dev by setting `jdk17u-fix-request` label in the bug and providing the "Fix Request" comment. Please also rebase to current master to get the actual testing. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1582#issuecomment-1692869229 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1582#issuecomment-1692869510 From mbaesken at openjdk.org Fri Aug 25 07:08:42 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 25 Aug 2023 07:08:42 GMT Subject: [jdk11u-dev] RFR: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 Message-ID: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 ------------- Commit messages: - Backport d24b7b7026cf85f1aecf44f60819762872cfd5c1 Changes: https://git.openjdk.org/jdk11u-dev/pull/2098/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2098&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276651 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2098.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2098/head:pull/2098 PR: https://git.openjdk.org/jdk11u-dev/pull/2098 From shade at openjdk.org Fri Aug 25 07:30:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 07:30:13 GMT Subject: [jdk17u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 05:41:41 GMT, Thomas Stuefe wrote: > okay, I'll withdraw. Let's do it piece by piece as usual. Thanks! Yes, piece by piece would be the right approach here. I don't actually mind clustering several changes into one PR, as long as PR commits tell the story well: what was picked, in what order, and what changes were done along the way. I also don't mind bringing in safe-ish improvements to the common code if it resolves significant deviation from mainline. A palpable number of deviations we did over the years bit us in the back at unfortunate times... ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1679#issuecomment-1692898135 From stuefe at openjdk.org Fri Aug 25 09:38:22 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 25 Aug 2023 09:38:22 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v5] In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 06:50:12 GMT, Aleksey Shipilev wrote: >> Unclean backport to get useful experimental feature to LTS users. >> >> In addition to usual contextual differences, there is a number of differences against upstream version: >> - `synchronizer.cpp` hunks are different, since we do not have [JDK-8256302](https://github.com/openjdk/jdk/commit/6402004852ccc993bb6e879c49fb71e2afdcdfbe) in JDK 17 >> - `NativeHeapTrimmer_lock` changed from `Mutex::safepoint` to `Mutex::leaf`, since [JDK-8273915](https://github.com/openjdk/jdk/commit/111d5e1a9324cb5e8d98627f6329d17fcbc9c13d) renamed it after JDK 17 >> - `NativeHeapTrimmer_lock` should also allow VMThread block and never require safepoint checks; this was simplified by [JDK-8274004](https://bugs.openjdk.org/browse/JDK-8274004) later >> - `vmError.cpp` code was rewritten in JDK 17 style >> - gtest uses `EXPECT_NOT_NULL`, only brought by [JDK-8295865](https://github.com/openjdk/jdk/commit/657a0b2f1564e1754dbd64b776c53a52c480c901#diff-35b3b4703decd15bfd2fc614d431e909727a6cf4d399cf05c7a12466e61ab8a0R58-R59) -- I rewrote them to EXPECT_NE/EQ. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug, trim tests >> - [x] Linux x86_64 fastdebug, `tier1` >> - [x] Linux x86_64 fastdebug, `tier2` >> - [x] Linux x86_64 fastdebug, `tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into JDK-8293114-trim-native > - Merge branch 'master' into JDK-8293114-trim-native > - More adjustments > - Adjustments > - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 I see you have all follow-ups already neatly aligned; will you ship it today or so to still get into the rapidly closing window? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1693073871 From lucy at openjdk.org Fri Aug 25 10:11:29 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 25 Aug 2023 10:11:29 GMT Subject: [jdk11u-dev] Integrated: 8306881: Update FreeType to 2.13.0 In-Reply-To: References: Message-ID: <_4la-uitX5jKOSBS8Tzgfsp-caLOf01k-iGDhKXDtxE=.f43523b7-b6b7-49b0-9e18-bcca2413a3b5@github.com> On Wed, 23 Aug 2023 10:44:31 GMT, Lutz Schmidt wrote: > Fix Request (11u): > Should get backported for parity with 11.0.21-oracle. Applies cleanly. > To prevent MacOS build failures (compiler warnings) with GHA, the workaround from jdk17u (https://git.openjdk.org/jdk17u-dev/pull/1504) was added as an additional commit. > > Tests (SAP-internal and GHA) successful. > Review received. This pull request has now been integrated. Changeset: c844a55f Author: Lutz Schmidt URL: https://git.openjdk.org/jdk11u-dev/commit/c844a55f2f9b75c3edf2750f7a67a5edb6b635eb Stats: 3607 lines in 284 files changed: 1611 ins; 690 del; 1306 mod 8306881: Update FreeType to 2.13.0 Reviewed-by: mdoerr Backport-of: 723582c524c62ee73f7984a53b046f8832b23a7f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2094 From shade at openjdk.org Fri Aug 25 10:39:14 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 10:39:14 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v5] In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 09:35:54 GMT, Thomas Stuefe wrote: > I see you have all follow-ups already neatly aligned; will you ship it today or so to still get into the rapidly closing window? Yes, my plan is to integrate today. I was checking if GHAs are still good with this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1693153058 From stuefe at openjdk.org Fri Aug 25 11:03:19 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 25 Aug 2023 11:03:19 GMT Subject: [jdk17u-dev] RFR: 8314426: runtime/os/TestTrimNative.java is failing on slow machines In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 07:28:08 GMT, Aleksey Shipilev wrote: > Clean backport, further stabilization of the test. > > Additional testing: > - [x] 100+ iterations of affected test on Linux x86_64 fastdebug +1 ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1687#pullrequestreview-1595462155 From stuefe at openjdk.org Fri Aug 25 12:06:42 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 25 Aug 2023 12:06:42 GMT Subject: [jdk17u-dev] RFR: 8310233: Fix THP detection on Linux Message-ID: *Note: not for October CPU* Unclean backport. Needed as a prerequisite to fix [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182). No factual differences exist; merge failed due to surrounding hunks being different (NULL->nullptr). ------------- Commit messages: - Backport 37ca9024ef59d99cae0bd7e25b2e6d3c1e085f97 Changes: https://git.openjdk.org/jdk17u-dev/pull/1694/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1694&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310233 Stats: 815 lines in 7 files changed: 684 ins; 99 del; 32 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1694.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1694/head:pull/1694 PR: https://git.openjdk.org/jdk17u-dev/pull/1694 From stuefe at openjdk.org Fri Aug 25 12:53:53 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 25 Aug 2023 12:53:53 GMT Subject: [jdk21u] RFR: 8312620: WSL Linux build crashes after JDK-8310233 Message-ID: Clean backport, fixes a crash when building on windows with WSL. ------------- Commit messages: - Backport 25058cd23ac9c8993e7acfd82728ee4c623f0914 - Backport 94eb44b192ba421692549a178c386ea34164ea50 Changes: https://git.openjdk.org/jdk21u/pull/102/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=102&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312620 Stats: 40 lines in 3 files changed: 20 ins; 2 del; 18 mod Patch: https://git.openjdk.org/jdk21u/pull/102.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/102/head:pull/102 PR: https://git.openjdk.org/jdk21u/pull/102 From shade at openjdk.org Fri Aug 25 13:22:33 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 13:22:33 GMT Subject: [jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v5] In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 06:50:12 GMT, Aleksey Shipilev wrote: >> Unclean backport to get useful experimental feature to LTS users. >> >> In addition to usual contextual differences, there is a number of differences against upstream version: >> - `synchronizer.cpp` hunks are different, since we do not have [JDK-8256302](https://github.com/openjdk/jdk/commit/6402004852ccc993bb6e879c49fb71e2afdcdfbe) in JDK 17 >> - `NativeHeapTrimmer_lock` changed from `Mutex::safepoint` to `Mutex::leaf`, since [JDK-8273915](https://github.com/openjdk/jdk/commit/111d5e1a9324cb5e8d98627f6329d17fcbc9c13d) renamed it after JDK 17 >> - `NativeHeapTrimmer_lock` should also allow VMThread block and never require safepoint checks; this was simplified by [JDK-8274004](https://bugs.openjdk.org/browse/JDK-8274004) later >> - `vmError.cpp` code was rewritten in JDK 17 style >> - gtest uses `EXPECT_NOT_NULL`, only brought by [JDK-8295865](https://github.com/openjdk/jdk/commit/657a0b2f1564e1754dbd64b776c53a52c480c901#diff-35b3b4703decd15bfd2fc614d431e909727a6cf4d399cf05c7a12466e61ab8a0R58-R59) -- I rewrote them to EXPECT_NE/EQ. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug, trim tests >> - [x] Linux x86_64 fastdebug, `tier1` >> - [x] Linux x86_64 fastdebug, `tier2` >> - [x] Linux x86_64 fastdebug, `tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into JDK-8293114-trim-native > - Merge branch 'master' into JDK-8293114-trim-native > - More adjustments > - Adjustments > - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 Testing is clean. Review is here. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1616#issuecomment-1693351270 From shade at openjdk.org Fri Aug 25 13:22:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 13:22:35 GMT Subject: [jdk17u-dev] Integrated: 8293114: JVM should trim the native heap In-Reply-To: References: Message-ID: On Fri, 21 Jul 2023 17:55:38 GMT, Aleksey Shipilev wrote: > Unclean backport to get useful experimental feature to LTS users. > > In addition to usual contextual differences, there is a number of differences against upstream version: > - `synchronizer.cpp` hunks are different, since we do not have [JDK-8256302](https://github.com/openjdk/jdk/commit/6402004852ccc993bb6e879c49fb71e2afdcdfbe) in JDK 17 > - `NativeHeapTrimmer_lock` changed from `Mutex::safepoint` to `Mutex::leaf`, since [JDK-8273915](https://github.com/openjdk/jdk/commit/111d5e1a9324cb5e8d98627f6329d17fcbc9c13d) renamed it after JDK 17 > - `NativeHeapTrimmer_lock` should also allow VMThread block and never require safepoint checks; this was simplified by [JDK-8274004](https://bugs.openjdk.org/browse/JDK-8274004) later > - `vmError.cpp` code was rewritten in JDK 17 style > - gtest uses `EXPECT_NOT_NULL`, only brought by [JDK-8295865](https://github.com/openjdk/jdk/commit/657a0b2f1564e1754dbd64b776c53a52c480c901#diff-35b3b4703decd15bfd2fc614d431e909727a6cf4d399cf05c7a12466e61ab8a0R58-R59) -- I rewrote them to EXPECT_NE/EQ. > > Additional testing: > - [x] Linux x86_64 fastdebug, trim tests > - [x] Linux x86_64 fastdebug, `tier1` > - [x] Linux x86_64 fastdebug, `tier2` > - [x] Linux x86_64 fastdebug, `tier3` This pull request has now been integrated. Changeset: f667b356 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/f667b356714fc55cd9f9ae3488d42193984a0eda Stats: 847 lines in 20 files changed: 840 ins; 0 del; 7 mod 8293114: JVM should trim the native heap Reviewed-by: stuefe Backport-of: 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1616 From shade at openjdk.org Fri Aug 25 13:33:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 13:33:28 GMT Subject: [jdk17u-dev] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction [v2] In-Reply-To: References: Message-ID: > Semi-clean follow-up backport to relax the test. > > There are no ProblemList additions in 17u, so this changeset does not have the relevant hunk. > > Additional testing: > - [x] Linux x86_64 fastdebug, affected test Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport ad34be1f329edc8e7155983835cc70d733c014b8 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/1662/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1662&range=01 Stats: 43 lines in 2 files changed: 33 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1662.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1662/head:pull/1662 PR: https://git.openjdk.org/jdk17u-dev/pull/1662 From shade at openjdk.org Fri Aug 25 13:36:55 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 13:36:55 GMT Subject: [jdk17u-dev] RFR: 8314426: runtime/os/TestTrimNative.java is failing on slow machines [v2] In-Reply-To: References: Message-ID: > Clean backport, further stabilization of the test. > > Additional testing: > - [x] 100+ iterations of affected test on Linux x86_64 fastdebug Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Backport 20e94784c9f7c30e95550c72aedb5e986a153114 - Backport ad34be1f329edc8e7155983835cc70d733c014b8 - Merge branch 'master' into JDK-8293114-trim-native - More adjustments - Adjustments - Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1687/files - new: https://git.openjdk.org/jdk17u-dev/pull/1687/files/a623b67b..a623b67b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1687&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1687&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1687.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1687/head:pull/1687 PR: https://git.openjdk.org/jdk17u-dev/pull/1687 From shade at openjdk.org Fri Aug 25 14:34:18 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 14:34:18 GMT Subject: [jdk17u-dev] RFR: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction [v2] In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 13:33:28 GMT, Aleksey Shipilev wrote: >> Semi-clean follow-up backport to relax the test. >> >> There are no ProblemList additions in 17u, so this changeset does not have the relevant hunk. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug, affected test > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport ad34be1f329edc8e7155983835cc70d733c014b8 Testing was clean before rebase. Local testing passes. Review is here. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1662#issuecomment-1693455257 From shade at openjdk.org Fri Aug 25 14:34:20 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 14:34:20 GMT Subject: [jdk17u-dev] Integrated: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction In-Reply-To: References: Message-ID: <7fuQy2R5ImjmquW0YyhrafJKI6xVHh2ipzAJyObq_xk=.6bcc3c19-6660-40b5-8d89-33bc53ce7dd6@github.com> On Mon, 14 Aug 2023 09:33:58 GMT, Aleksey Shipilev wrote: > Semi-clean follow-up backport to relax the test. > > There are no ProblemList additions in 17u, so this changeset does not have the relevant hunk. > > Additional testing: > - [x] Linux x86_64 fastdebug, affected test This pull request has now been integrated. Changeset: 3c426c70 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/3c426c70edbfdfbce362740dca30005f8d781e53 Stats: 43 lines in 2 files changed: 33 ins; 0 del; 10 mod 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction Reviewed-by: mdoerr Backport-of: ad34be1f329edc8e7155983835cc70d733c014b8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1662 From shade at openjdk.org Fri Aug 25 14:40:37 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 14:40:37 GMT Subject: [jdk17u-dev] RFR: 8314426: runtime/os/TestTrimNative.java is failing on slow machines [v3] In-Reply-To: References: Message-ID: <_nTZmrvhirQDlpXsdvgtEMyFB-5Dh_h9VfDLuYBK84E=.9efdf61a-27aa-47c4-9bcc-3c97b9b10134@github.com> > Clean backport, further stabilization of the test. > > Additional testing: > - [x] 100+ iterations of affected test on Linux x86_64 fastdebug Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 20e94784c9f7c30e95550c72aedb5e986a153114 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/1687/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1687&range=02 Stats: 6 lines in 1 file changed: 3 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1687.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1687/head:pull/1687 PR: https://git.openjdk.org/jdk17u-dev/pull/1687 From alexsch at openjdk.org Fri Aug 25 15:16:55 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Fri, 25 Aug 2023 15:16:55 GMT Subject: [jdk17u-dev] RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation Message-ID: This is a clean backport of the fix `8295737: macOS: Print content cut off when width > height with portrait orientation.` The fix allows to print a page which width is greater than height with portrait orientation on macOS. Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. ------------- Commit messages: - Backport d00a767047ec41e233e711dbc5fe7b8818e72f28 Changes: https://git.openjdk.org/jdk17u-dev/pull/1700/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1700&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295737 Stats: 433 lines in 2 files changed: 430 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1700.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1700/head:pull/1700 PR: https://git.openjdk.org/jdk17u-dev/pull/1700 From shade at openjdk.org Fri Aug 25 15:33:16 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 15:33:16 GMT Subject: [jdk17u-dev] RFR: 8314426: runtime/os/TestTrimNative.java is failing on slow machines [v3] In-Reply-To: <_nTZmrvhirQDlpXsdvgtEMyFB-5Dh_h9VfDLuYBK84E=.9efdf61a-27aa-47c4-9bcc-3c97b9b10134@github.com> References: <_nTZmrvhirQDlpXsdvgtEMyFB-5Dh_h9VfDLuYBK84E=.9efdf61a-27aa-47c4-9bcc-3c97b9b10134@github.com> Message-ID: On Fri, 25 Aug 2023 14:40:37 GMT, Aleksey Shipilev wrote: >> Clean backport, further stabilization of the test. >> >> Additional testing: >> - [x] 100+ iterations of affected test on Linux x86_64 fastdebug > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 20e94784c9f7c30e95550c72aedb5e986a153114 Testing was clean before rebase. Local testing passes. Review is here. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1687#issuecomment-1693542911 From shade at openjdk.org Fri Aug 25 15:33:18 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 15:33:18 GMT Subject: [jdk17u-dev] Integrated: 8314426: runtime/os/TestTrimNative.java is failing on slow machines In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 07:28:08 GMT, Aleksey Shipilev wrote: > Clean backport, further stabilization of the test. > > Additional testing: > - [x] 100+ iterations of affected test on Linux x86_64 fastdebug This pull request has now been integrated. Changeset: fdc41302 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/fdc413029acf88e29015a9cb9b2d95dccfde0cfb Stats: 6 lines in 1 file changed: 3 ins; 1 del; 2 mod 8314426: runtime/os/TestTrimNative.java is failing on slow machines Reviewed-by: stuefe Backport-of: 20e94784c9f7c30e95550c72aedb5e986a153114 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1687 From duke at openjdk.org Fri Aug 25 16:03:16 2023 From: duke at openjdk.org (duke) Date: Fri, 25 Aug 2023 16:03:16 GMT Subject: [jdk17u-dev] Withdrawn: 8288139: JavaThread touches oop after GC barrier is detached In-Reply-To: References: Message-ID: <0pstrJLXP4rrbwKrc1tbya_-Wc3EOqJTRPFsLfIVQ-w=.0fc866fe-88a2-4994-aeeb-5ddae93ef789@github.com> On Thu, 29 Jun 2023 17:07:21 GMT, Aleksey Shipilev wrote: > Unclean backport to avoid a JVM crash. The source for uncleanliness is the absent `JavaThread::cast`, which I replaced back to `->as_Java_thread()`. > > Additional testing: > - [x] Linux AArch64 fastdebug tier1 (as part of whole batch of PRs) > - [x] Linux AArch64 fastdebug tier2 (as part of whole batch of PRs) > - [x] Linux AArch64 fastdebug tier3 (as part of whole batch of PRs) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1515 From duke at openjdk.org Fri Aug 25 16:05:15 2023 From: duke at openjdk.org (duke) Date: Fri, 25 Aug 2023 16:05:15 GMT Subject: [jdk17u-dev] Withdrawn: 8288497: add support for JavaThread::is_oop_safe() In-Reply-To: References: Message-ID: <4zxcYMQoloKrDJxnLJtQq7wrm8a6xlgXO0nTOMLV8_w=.6d0029be-6e7e-4990-ac94-afe75954f5a9@github.com> On Thu, 29 Jun 2023 16:59:01 GMT, Aleksey Shipilev wrote: > Clean backport on the way to fix [JDK-8288139](https://bugs.openjdk.org/browse/JDK-8288139). Requires follow-ups as dependent PRs. > > Additional testing: > - [x] Linux AArch64 fastdebug tier1 (as part of whole batch of PRs) > - [x] Linux AArch64 fastdebug tier2 (as part of whole batch of PRs) > - [x] Linux AArch64 fastdebug tier3 (as part of whole batch of PRs) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1514 From shade at openjdk.org Fri Aug 25 17:03:19 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 17:03:19 GMT Subject: [jdk21u] Integrated: 8313701: GHA: RISC-V should use the official repository for bootstrap In-Reply-To: <43FjjUy5o5vyhHjg3tYbyAW_3NCVC4OJAioG6wfdTFU=.64005a19-a7e7-484c-a0c2-596010bb035d@github.com> References: <43FjjUy5o5vyhHjg3tYbyAW_3NCVC4OJAioG6wfdTFU=.64005a19-a7e7-484c-a0c2-596010bb035d@github.com> Message-ID: On Mon, 21 Aug 2023 14:23:40 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA stability. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: a34b8444 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/a34b84442848a26115a8a2b90b07c2c6172cdfc4 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8313701: GHA: RISC-V should use the official repository for bootstrap Backport-of: 538f9557b87f750264231f04bfbc91d15f8af8c0 ------------- PR: https://git.openjdk.org/jdk21u/pull/78 From shade at openjdk.org Fri Aug 25 17:03:18 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 17:03:18 GMT Subject: [jdk21u] RFR: 8313701: GHA: RISC-V should use the official repository for bootstrap [v3] In-Reply-To: <7ykboBwcCs7ulf1lPSrBm1rdsoNg0Yx70jXSTPcjF9Q=.3ca37a99-c493-476a-8e78-101dee6a6698@github.com> References: <43FjjUy5o5vyhHjg3tYbyAW_3NCVC4OJAioG6wfdTFU=.64005a19-a7e7-484c-a0c2-596010bb035d@github.com> <7ykboBwcCs7ulf1lPSrBm1rdsoNg0Yx70jXSTPcjF9Q=.3ca37a99-c493-476a-8e78-101dee6a6698@github.com> Message-ID: On Thu, 24 Aug 2023 13:26:57 GMT, Aleksey Shipilev wrote: >> Clean backport to improve GHA stability. >> >> Additional testing: >> - [x] GHA > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into JDK-8313701-gha-riscv-official > - Merge branch 'master' into JDK-8313701-gha-riscv-official > - Backport 538f9557b87f750264231f04bfbc91d15f8af8c0 Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/78#issuecomment-1693671968 From shade at openjdk.org Fri Aug 25 17:50:43 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 25 Aug 2023 17:50:43 GMT Subject: [jdk21u] RFR: 8313262: C2: Sinking node may cause required cast to be dropped [v3] In-Reply-To: <5J-am32LvigQiSpQYcW6rJ5xcue_Ot6iwZsvB1gcdCI=.02554307-cec8-487d-ab46-6d205247205a@github.com> References: <5J-am32LvigQiSpQYcW6rJ5xcue_Ot6iwZsvB1gcdCI=.02554307-cec8-487d-ab46-6d205247205a@github.com> Message-ID: > Clean backport to fix recent JDK 21 backport regression. > > Additional testing: > - [x] New test fails without the fix, passes with it > - [x] Linux x86_64 AArch64 `tier1 tier2 tier3` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8313262-c2-sinking-node-cast - Merge branch 'master' into JDK-8313262-c2-sinking-node-cast - Backport 1cee3b9fd9720e7938029a6992460b9053e65e57 ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/99/files - new: https://git.openjdk.org/jdk21u/pull/99/files/6f95682e..8b42299c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=99&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=99&range=01-02 Stats: 103 lines in 19 files changed: 71 ins; 13 del; 19 mod Patch: https://git.openjdk.org/jdk21u/pull/99.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/99/head:pull/99 PR: https://git.openjdk.org/jdk21u/pull/99 From sjayagond at openjdk.org Fri Aug 25 17:52:29 2023 From: sjayagond at openjdk.org (Sidraya Jayagond) Date: Fri, 25 Aug 2023 17:52:29 GMT Subject: [jdk21u] RFR: 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. Message-ID: Hi all, This pull request contains a backport of commit [514816ed](https://github.com/openjdk/jdk/commit/514816ed7d7dea1fb13d32b80aef89774bee13d3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sidraya Jayagond on 4 Jul 2023 and was reviewed by Amit Kumar and Lutz Schmidt. Thanks! ------------- Commit messages: - Backport 514816ed7d7dea1fb13d32b80aef89774bee13d3 Changes: https://git.openjdk.org/jdk21u/pull/106/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=106&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309889 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/106.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/106/head:pull/106 PR: https://git.openjdk.org/jdk21u/pull/106 From coffeys at openjdk.org Fri Aug 25 18:25:11 2023 From: coffeys at openjdk.org (Sean Coffey) Date: Fri, 25 Aug 2023 18:25:11 GMT Subject: [jdk21u] Integrated: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 06:52:51 GMT, Sean Coffey wrote: > Reduce the excessive number of InvalidParameterSpecException objects created in TLS environments where non-JDK provider may be in use This pull request has now been integrated. Changeset: b96aa3c4 Author: Sean Coffey URL: https://git.openjdk.org/jdk21u/commit/b96aa3c42e46485c83a833e41f6cd39a9fc732c9 Stats: 14 lines in 1 file changed: 5 ins; 3 del; 6 mod 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers Backport-of: e554fdee254ce51d605fe127b73644620e87e23b ------------- PR: https://git.openjdk.org/jdk21u/pull/101 From rhalade at openjdk.org Fri Aug 25 18:26:33 2023 From: rhalade at openjdk.org (Rajan Halade) Date: Fri, 25 Aug 2023 18:26:33 GMT Subject: [jdk21u] RFR: 8314960: Add Certigna Root CA - 2 Message-ID: The clean backport to JDK 21u to add new root CA. ------------- Commit messages: - Backport e9ba8d5a0e74c7e61f963b9a295662899d0156dd Changes: https://git.openjdk.org/jdk21u/pull/107/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=107&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314960 Stats: 568 lines in 4 files changed: 338 ins; 227 del; 3 mod Patch: https://git.openjdk.org/jdk21u/pull/107.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/107/head:pull/107 PR: https://git.openjdk.org/jdk21u/pull/107 From duke at openjdk.org Fri Aug 25 18:49:30 2023 From: duke at openjdk.org (toshiogata) Date: Fri, 25 Aug 2023 18:49:30 GMT Subject: [jdk11u-dev] Integrated: 8217612: (CL)HSDB cannot show some JVM flags In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 07:56:09 GMT, toshiogata wrote: > Hi all, > > This is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags > > JDK11 reproduces the reported bug, so this patch should be applied. > There is a related Issue: JDK-8217850, and I submit the corresponding PR. > > The original patch is applied cleanly. > > Testing: all serviceability agent tests,?hotspot_all and the test which comes with this patch > > Thank you. This pull request has now been integrated. Changeset: 2b9f5629 Author: t.ogata Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/2b9f5629676d3a59b99a3e9187b83b4f11b3fabe Stats: 122 lines in 3 files changed: 113 ins; 0 del; 9 mod 8217612: (CL)HSDB cannot show some JVM flags Backport-of: d6a75a0f86d4c84132a3794c432b34068163fa60 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2093 From btaylor at openjdk.org Fri Aug 25 19:53:14 2023 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 25 Aug 2023 19:53:14 GMT Subject: [jdk21u] Integrated: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 19:27:53 GMT, Ben Taylor wrote: > Backport [JDK-8313796](https://bugs.openjdk.org/browse/JDK-8313796) to 21u to fix a sigsegv. Change is clean and passes tier1 tests. This pull request has now been integrated. Changeset: 46ce5553 Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u/commit/46ce5553e459cda7c2523b43bb13c14585548aa9 Stats: 16 lines in 7 files changed: 11 ins; 0 del; 5 mod 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Backport-of: 0e2c72d7a5206b7173af5bf69e21d21ea276bd94 ------------- PR: https://git.openjdk.org/jdk21u/pull/94 From pchilanomate at openjdk.org Fri Aug 25 19:54:11 2023 From: pchilanomate at openjdk.org (Patricio Chilano Mateo) Date: Fri, 25 Aug 2023 19:54:11 GMT Subject: [jdk21u] Integrated: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 19:24:51 GMT, Patricio Chilano Mateo wrote: > This pull request contains a backport of commit [8e4240c3](https://github.com/openjdk/jdk/commit/8e4240c3167ff6c803f3391f70ef9cfa7f408085) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Patricio Chilano Mateo on 24 Aug 2023 and was reviewed by Ron Pressler and Andrew Haley. > > Thanks! This pull request has now been integrated. Changeset: f5eef202 Author: Patricio Chilano Mateo Committer: Coleen Phillimore URL: https://git.openjdk.org/jdk21u/commit/f5eef2021abd688c0bc6208b17eff3266c757ca6 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter Backport-of: 8e4240c3167ff6c803f3391f70ef9cfa7f408085 ------------- PR: https://git.openjdk.org/jdk21u/pull/100 From phh at openjdk.org Fri Aug 25 19:56:22 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 25 Aug 2023 19:56:22 GMT Subject: [jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v4] In-Reply-To: References: Message-ID: On Tue, 15 Aug 2023 07:05:08 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. >> Testing: >> all serviceability area tests jdk_svc, and a specific test to verify the fix. >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into 8313815 > - Merge master > - Merge master > - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1641#pullrequestreview-1596415942 From rhalade at openjdk.org Fri Aug 25 20:10:13 2023 From: rhalade at openjdk.org (Rajan Halade) Date: Fri, 25 Aug 2023 20:10:13 GMT Subject: [jdk21u] Integrated: 8314960: Add Certigna Root CA - 2 In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 18:20:40 GMT, Rajan Halade wrote: > The clean backport to JDK 21u to add new root CA. This pull request has now been integrated. Changeset: 4909911f Author: Rajan Halade URL: https://git.openjdk.org/jdk21u/commit/4909911fdee38b251d746ef6b0041ec7c4271512 Stats: 568 lines in 4 files changed: 338 ins; 227 del; 3 mod 8314960: Add Certigna Root CA - 2 Backport-of: e9ba8d5a0e74c7e61f963b9a295662899d0156dd ------------- PR: https://git.openjdk.org/jdk21u/pull/107 From phh at openjdk.org Fri Aug 25 20:22:18 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 25 Aug 2023 20:22:18 GMT Subject: [jdk17u-dev] RFR: 8310233: Fix THP detection on Linux In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 10:55:00 GMT, Thomas Stuefe wrote: > *Note: not for October CPU* > > Unclean backport. Needed as a prerequisite to fix [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182). > > No factual differences exist; merge failed due to surrounding hunks being different (NULL->nullptr). Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1694#pullrequestreview-1596451985 From v-terrychow at microsoft.com Fri Aug 25 20:26:41 2023 From: v-terrychow at microsoft.com (Terry Chow (Simba Technologies Inc)) Date: Fri, 25 Aug 2023 20:26:41 +0000 Subject: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u In-Reply-To: References: <26a6d12b49b4b19e24b9e8e75eb382376848df16.camel@redhat.com> Message-ID: Hi Severin, I forgot to add this in my last reply. From my last email, if that is the correct 21u repo and if there aren't any other special details for backporting to 21u, could you or someone with JBS account help me add an initial "Fix request 21u" to JDK-8308593 to start the backport process for 21u? Thanks again, Terry ________________________________ From: Terry Chow (Simba Technologies Inc) Sent: August 24, 2023 11:42 AM To: Severin Gehwolf ; jdk-updates-dev at openjdk.org Subject: Re: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u Hi Severin, Thanks for the feedback. Just to confirm some details, is this the correct repo for backports into 21u? I was expecting a "jdk21u-dev" repo, similar to 17u and 11u. openjdk/jdk21u: https://openjdk.org/projects/jdk-updates (github.com) Also, can the guide below be applied to backporting into 21u, the process is the same as 17u and 11u? There aren't any specific details I need to be aware of to get a backport into 21u right? How to contribute or backport a fix - How to contribute or backport a fix - OpenJDK Wiki Thanks, Terry ________________________________ From: Severin Gehwolf Sent: August 24, 2023 1:17 AM To: Terry Chow (Simba Technologies Inc) ; jdk-updates-dev at openjdk.org Subject: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u [You don't often get email from sgehwolf at redhat.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hi Terry, On Thu, 2023-08-24 at 00:54 +0000, Terry Chow (Simba Technologies Inc) wrote: > Hi maintainers of OpenJDK updates, > > I'd like to backport JDK-8308593 (keepalive extended socket options for Windows) to 11u and 17u (maybe 8u later as well). And so, I just want to open discussion on this topic to hear your opinions before I start the backporting process. I did some initial investigation on the backport and I learned the following: > > Backporting to 11u requires three additional changes to be made on top of the backport in order for it to work. > 1. Lib-jdk.net.gmk will need to be updated to support building extnet for Windows. > 2. jdk.net.ExtendedSocketOption will need to add a case to support returning a Windows instance of PlatformSocketOptions. > 3. The Windows PlainSocketImpl class needs to have the same code on lines 61 - 96 in the Unix PlainSocketImpl class. > Backporting to 17u requires two additional changes (similar to 11u). > 1. jdk.net/Lib.gmkwill need to be updated to support building extnet for Windows. > 2. jdk.net.ExtendedSocketOption will need to add a case to support returning a Windows instance of PlatformSocketOptions. > Let me know if the additional changes are acceptable or if they're disruptive. As the change went into JDK 22, I'd first suggest to get this into JDK 21u which would bring this feature to LTS users. JDK 17u seems OK as a next step from a brief glance (once it's in 21u). Only then we should evaluate JDK 11u and older releases. Thanks, Severin -------------- next part -------------- An HTML attachment was scrubbed... URL: From phh at openjdk.org Fri Aug 25 20:35:19 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 25 Aug 2023 20:35:19 GMT Subject: [jdk17u-dev] RFR: 8314020: Print instruction blocks in byte units In-Reply-To: References: Message-ID: <628ig1AnQQAyKS-ipw8N5bCCwFPTjQ4OMShq1yH7XEM=.26f6f555-8e03-4783-b763-32c27e6d0c5e@github.com> On Wed, 23 Aug 2023 07:01:44 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve post-mortem diagnostics. > > Two conflicts: > - In `os.hpp` we have a contextual differences due to Loom integration, applied the hunk by hand > - In `os_linux_zero.cpp`, the contextual difference due to missing [JDK-8294211](https://bugs.openjdk.org/browse/JDK-8294211), which I do not want to backport yet; skipped the hunk > > Additional testing: > - [x] Eyeballing the artificial crash Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1686#pullrequestreview-1596466336 From phh at openjdk.org Fri Aug 25 20:42:22 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 25 Aug 2023 20:42:22 GMT Subject: [jdk11u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v5] In-Reply-To: <26FtqbFaw_UM-whVaFRXhBnnrpgMbBilcUcQRlCGmqU=.19fa4f07-95f2-4f3d-9b5f-551918c88206@github.com> References: <26FtqbFaw_UM-whVaFRXhBnnrpgMbBilcUcQRlCGmqU=.19fa4f07-95f2-4f3d-9b5f-551918c88206@github.com> Message-ID: On Thu, 24 Aug 2023 10:26:16 GMT, toshiogata wrote: >> Hi all, >> >> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 >> >> I worked for backporting JDK-8217612, and found that this related patch should be backported at the same time. >> >> The riginal patch is applied cleanly to JDK-8217612 applied code. >> >> Testing: all serviceability agent tests, hotspot_all that includes CompressedClassSpaceSizeInJmapHeap.java and the test which come with JDK-8217612. >> >> Thank you. > > toshiogata has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'toshiogata-backport-8217612' into toshiogata-backport-8217850 > - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d Please merge with upstream jdk11u-dev now that https://github.com/openjdk/jdk11u-dev/pull/2093 has been integrated. The result should be clean. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2096#issuecomment-1693903913 From fyang at openjdk.org Sat Aug 26 03:15:28 2023 From: fyang at openjdk.org (Fei Yang) Date: Sat, 26 Aug 2023 03:15:28 GMT Subject: [jdk11u-dev] RFR: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures Message-ID: Backport this test-only change in order to help "weak" and slow platforms to have stable results. Doing in advance of RISC-V port in https://github.com/openjdk/riscv-port-jdk11u where this helps to get stable test results. Original patch does not apply cleanly as the dependent bug https://bugs.openjdk.org/browse/JDK-8218471 was only partially backported. So there are some conflicts in file test/hotspot/jtreg/compiler/unsafe/X-UnsafeAccessTest.java.template and the auto-generated tests from this template file. Testing - [ ] GHA (updated tests are part of tier1) ------------- Commit messages: - Merge remote-tracking branch 'upstream/master' into backport-8292407 - JDK-8292407 Changes: https://git.openjdk.org/jdk11u-dev/pull/2099/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2099&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292407 Stats: 951 lines in 45 files changed: 800 ins; 0 del; 151 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2099.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2099/head:pull/2099 PR: https://git.openjdk.org/jdk11u-dev/pull/2099 From stuefe at openjdk.org Sat Aug 26 05:36:16 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sat, 26 Aug 2023 05:36:16 GMT Subject: [jdk21u] RFR: 8312394: [linux] SIGSEGV if kernel was built without hugepage support In-Reply-To: <1L7f5KIKdWv442lo6u6bCb1OKyG6SVTd678tCXPDVhs=.74baba94-6fe8-4a2b-8e0c-b26cbed4e66b@github.com> References: <1L7f5KIKdWv442lo6u6bCb1OKyG6SVTd678tCXPDVhs=.74baba94-6fe8-4a2b-8e0c-b26cbed4e66b@github.com> Message-ID: On Thu, 24 Aug 2023 06:24:57 GMT, Thomas Stuefe wrote: > Hi all, > > This patch is one in a small line of preparatory patches that aim, ultimately, to fix https://bugs.openjdk.org/browse/JDK-8312182 ("THPs cause huge RSS due to thread start timing issue"). > > This particular patch fixes an issue where the JVM would crash on startup when started on a linux box with a kernel that does not support hugepages (mostly affected by this are small SBCs) Tests clean, apart from riscv, which is an infrastructure issue. Got approval. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/97#issuecomment-1694174433 From stuefe at openjdk.org Sat Aug 26 05:36:16 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sat, 26 Aug 2023 05:36:16 GMT Subject: [jdk21u] Integrated: 8312394: [linux] SIGSEGV if kernel was built without hugepage support In-Reply-To: <1L7f5KIKdWv442lo6u6bCb1OKyG6SVTd678tCXPDVhs=.74baba94-6fe8-4a2b-8e0c-b26cbed4e66b@github.com> References: <1L7f5KIKdWv442lo6u6bCb1OKyG6SVTd678tCXPDVhs=.74baba94-6fe8-4a2b-8e0c-b26cbed4e66b@github.com> Message-ID: On Thu, 24 Aug 2023 06:24:57 GMT, Thomas Stuefe wrote: > Hi all, > > This patch is one in a small line of preparatory patches that aim, ultimately, to fix https://bugs.openjdk.org/browse/JDK-8312182 ("THPs cause huge RSS due to thread start timing issue"). > > This particular patch fixes an issue where the JVM would crash on startup when started on a linux box with a kernel that does not support hugepages (mostly affected by this are small SBCs) This pull request has now been integrated. Changeset: 3f889a8d Author: Thomas Stuefe URL: https://git.openjdk.org/jdk21u/commit/3f889a8d253e90f6a8bb24129e38fd721d5ae992 Stats: 22 lines in 1 file changed: 6 ins; 2 del; 14 mod 8312394: [linux] SIGSEGV if kernel was built without hugepage support Backport-of: 94eb44b192ba421692549a178c386ea34164ea50 ------------- PR: https://git.openjdk.org/jdk21u/pull/97 From stuefe at openjdk.org Sat Aug 26 05:48:33 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sat, 26 Aug 2023 05:48:33 GMT Subject: [jdk21u] RFR: 8312620: WSL Linux build crashes after JDK-8310233 [v2] In-Reply-To: References: Message-ID: > Clean backport, fixes a crash when building on windows with WSL. Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. ------------- Changes: https://git.openjdk.org/jdk21u/pull/102/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=102&range=01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/102.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/102/head:pull/102 PR: https://git.openjdk.org/jdk21u/pull/102 From stuefe at openjdk.org Sat Aug 26 05:48:33 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sat, 26 Aug 2023 05:48:33 GMT Subject: [jdk21u] Withdrawn: 8312620: WSL Linux build crashes after JDK-8310233 In-Reply-To: References: Message-ID: <7VykknBmwwPVEBjvZgNfXXurb-XFLXGLGmf9zLPV6FA=.14d0fb6c-eda5-46f2-b9e4-8943ecc8a8bd@github.com> On Fri, 25 Aug 2023 12:45:41 GMT, Thomas Stuefe wrote: > Clean backport, fixes a crash when building on windows with WSL. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u/pull/102 From stuefe at openjdk.org Sat Aug 26 06:08:32 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sat, 26 Aug 2023 06:08:32 GMT Subject: [jdk21u] RFR: 8312182: THPs cause huge RSS due to thread start timing issue Message-ID: Fixes a serious issue that may cause huge RSS bloat and thread startup performance degradation. Applies cleanly. ------------- Commit messages: - Merge branch 'openjdk:master' into tstuefe-backport-84b325b8 - Backport 84b325b844c08809448a9c073a11443d9e3c3f8e Changes: https://git.openjdk.org/jdk21u/pull/103/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=103&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312182 Stats: 301 lines in 3 files changed: 294 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u/pull/103.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/103/head:pull/103 PR: https://git.openjdk.org/jdk21u/pull/103 From stuefe at openjdk.org Sat Aug 26 12:36:45 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sat, 26 Aug 2023 12:36:45 GMT Subject: [jdk21u] RFR: 8312620: WSL Linux build crashes after JDK-8310233 Message-ID: Clean backport to fix a build error when building in WSL on Windows. ------------- Commit messages: - Backport 25058cd23ac9c8993e7acfd82728ee4c623f0914 Changes: https://git.openjdk.org/jdk21u/pull/108/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=108&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312620 Stats: 21 lines in 3 files changed: 14 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u/pull/108.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/108/head:pull/108 PR: https://git.openjdk.org/jdk21u/pull/108 From duke at openjdk.org Sat Aug 26 14:35:22 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Sat, 26 Aug 2023 14:35:22 GMT Subject: [jdk17u-dev] Integrated: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows In-Reply-To: References: Message-ID: <3j53Yisb1i6qp3xx29PXr0rn_wTuKbNptwbV7UJ-zYY=.f2b3b31a-caea-413c-bf80-c0c618d61101@github.com> On Mon, 7 Aug 2023 00:48:11 GMT, Kimura Yukihiro wrote: > I would like to fix this issue > because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened. > Testing: > all serviceability area tests jdk_svc, and a specific test to verify the fix. > > Could anyone review the fix please? > > Thanks, > Kimura Yukihiro This pull request has now been integrated. Changeset: 7286bb85 Author: Kimura Yukihiro Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/7286bb8518543501045de4cf970094ac9c1af4fa Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows Reviewed-by: kevinw, cjplummer, phh ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1641 From tsteele at openjdk.org Sun Aug 27 01:01:15 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Sun, 27 Aug 2023 01:01:15 GMT Subject: [jdk21u] RFR: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) [v2] In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 15:03:56 GMT, Tyler Steele wrote: >> Hi all, >> >> This pull request contains a backport of commit [fdac6a6a](https://github.com/openjdk/jdk/commit/fdac6a6ac871366614efe44aca58ab520766b5c8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. It fixes TestByteBuffer.java, and depends on changes the backported by #77. >> >> The commit being backported was authored by Tyler Steele on 18 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe. >> >> Thanks! > > Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into backwaterred-backport-395fc788 > - Backport 395fc78880a91eeb06a08c1abf6905d580a650c0 Approval granted. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/82#issuecomment-1694535340 From alexsch at openjdk.org Mon Aug 28 05:29:29 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Mon, 28 Aug 2023 05:29:29 GMT Subject: [jdk17u-dev] Integrated: 8295737: macOS: Print content cut off when width > height with portrait orientation In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 15:08:28 GMT, Alexander Scherbatiy wrote: > This is a clean backport of the fix `8295737: macOS: Print content cut off when width > height with portrait orientation.` > > The fix allows to print a page which width is greater than height with portrait orientation on macOS. > Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. This pull request has now been integrated. Changeset: 4c123ac3 Author: Alexander Scherbatiy URL: https://git.openjdk.org/jdk17u-dev/commit/4c123ac3146ccec1bb168751fc38d3fcdd973190 Stats: 433 lines in 2 files changed: 430 ins; 0 del; 3 mod 8295737: macOS: Print content cut off when width > height with portrait orientation Backport-of: d00a767047ec41e233e711dbc5fe7b8818e72f28 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1700 From alexsch at openjdk.org Mon Aug 28 05:33:28 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Mon, 28 Aug 2023 05:33:28 GMT Subject: [jdk11u-dev] RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation In-Reply-To: References: Message-ID: On Tue, 22 Aug 2023 13:53:20 GMT, Alexander Scherbatiy wrote: > This is a clean backport of the fix `8295737: macOS: Print content cut off when width > height with portrait orientation`. > > The fix allows to print a page which width is greater than height with portrait orientation on macOS. > Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. The fix has been backported to 17u: https://github.com/openjdk/jdk17u-dev/commit/4c123ac3146ccec1bb168751fc38d3fcdd973190 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2092#issuecomment-1695034030 From alexsch at openjdk.org Mon Aug 28 05:33:29 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Mon, 28 Aug 2023 05:33:29 GMT Subject: [jdk11u-dev] Integrated: 8295737: macOS: Print content cut off when width > height with portrait orientation In-Reply-To: References: Message-ID: On Tue, 22 Aug 2023 13:53:20 GMT, Alexander Scherbatiy wrote: > This is a clean backport of the fix `8295737: macOS: Print content cut off when width > height with portrait orientation`. > > The fix allows to print a page which width is greater than height with portrait orientation on macOS. > Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. This pull request has now been integrated. Changeset: 2bfbe31f Author: Alexander Scherbatiy URL: https://git.openjdk.org/jdk11u-dev/commit/2bfbe31fbc23eecade16306bbd1a1bd6953c5fb3 Stats: 433 lines in 2 files changed: 430 ins; 0 del; 3 mod 8295737: macOS: Print content cut off when width > height with portrait orientation Backport-of: d00a767047ec41e233e711dbc5fe7b8818e72f28 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2092 From alexsch at openjdk.org Mon Aug 28 05:50:42 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Mon, 28 Aug 2023 05:50:42 GMT Subject: [jdk17u-dev] RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute Message-ID: This is a clean backport of the fix `8311033: [macos] PrinterJob does not take into account Sides attribute`. The fix allows to print pages with DUPLEX and TUMBLE attributes on macOS. Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. ------------- Commit messages: - Backport a3d67231a71fbe37c509fcedd54c679b4644c0d9 Changes: https://git.openjdk.org/jdk17u-dev/pull/1701/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1701&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311033 Stats: 335 lines in 4 files changed: 335 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1701.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1701/head:pull/1701 PR: https://git.openjdk.org/jdk17u-dev/pull/1701 From sjayagond at openjdk.org Mon Aug 28 05:59:16 2023 From: sjayagond at openjdk.org (Sidraya Jayagond) Date: Mon, 28 Aug 2023 05:59:16 GMT Subject: [jdk21u] RFR: 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. In-Reply-To: References: Message-ID: <0QgK9K6XODZdX-iTsE_7HKfYZZA5cnGEBjQZEiaAsww=.ba34e0b5-a1ae-4333-a9bf-caf3373c6db5@github.com> On Fri, 25 Aug 2023 17:45:18 GMT, Sidraya Jayagond wrote: > Hi all, > > This pull request contains a backport of commit [514816ed](https://github.com/openjdk/jdk/commit/514816ed7d7dea1fb13d32b80aef89774bee13d3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sidraya Jayagond on 4 Jul 2023 and was reviewed by Amit Kumar and Lutz Schmidt. > > Thanks! since this is a trivial change, I Will integrate it directly integrate. Can somebody sponsor this PR? ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/106#issuecomment-1695057829 From duke at openjdk.org Mon Aug 28 06:16:51 2023 From: duke at openjdk.org (toshiogata) Date: Mon, 28 Aug 2023 06:16:51 GMT Subject: [jdk11u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v6] In-Reply-To: References: Message-ID: > Hi all, > > This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 > > I worked for backporting JDK-8217612, and found that this related patch should be backported at the same time. > > The riginal patch is applied cleanly to JDK-8217612 applied code. > > Testing: all serviceability agent tests, hotspot_all that includes CompressedClassSpaceSizeInJmapHeap.java and the test which come with JDK-8217612. > > Thank you. toshiogata has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'master' into toshiogata-backport-8217850 - Merge branch 'toshiogata-backport-8217612' into toshiogata-backport-8217850 - Merge branch 'master' into toshiogata-backport-8217612 - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d - Backport d6a75a0f86d4c84132a3794c432b34068163fa60 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2096/files - new: https://git.openjdk.org/jdk11u-dev/pull/2096/files/0267bf96..21275c46 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2096&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2096&range=04-05 Stats: 5410 lines in 299 files changed: 3414 ins; 690 del; 1306 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2096.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2096/head:pull/2096 PR: https://git.openjdk.org/jdk11u-dev/pull/2096 From duke at openjdk.org Mon Aug 28 08:27:26 2023 From: duke at openjdk.org (toshiogata) Date: Mon, 28 Aug 2023 08:27:26 GMT Subject: [jdk11u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v6] In-Reply-To: References: Message-ID: <8zYcDWHvw4_yvZqiFpXNLY1OUZ8K2RnCoZ7QPCY8U-k=.a45a007a-6a2d-4e13-bf52-9973eb79be63@github.com> On Mon, 28 Aug 2023 06:16:51 GMT, toshiogata wrote: >> Hi all, >> >> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 >> >> I worked for backporting JDK-8217612, and found that this related patch should be backported at the same time. >> >> The riginal patch is applied cleanly to JDK-8217612 applied code. >> >> Testing: all serviceability agent tests, hotspot_all that includes CompressedClassSpaceSizeInJmapHeap.java and the test which come with JDK-8217612. >> >> Thank you. > > toshiogata has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into toshiogata-backport-8217850 > - Merge branch 'toshiogata-backport-8217612' into toshiogata-backport-8217850 > - Merge branch 'master' into toshiogata-backport-8217612 > - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d > - Backport d6a75a0f86d4c84132a3794c432b34068163fa60 Thank you for your comment. Merged with upstream jdk11u-dev to verify that this is a clean backport. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2096#issuecomment-1695258407 From duke at openjdk.org Mon Aug 28 09:34:24 2023 From: duke at openjdk.org (toshiogata) Date: Mon, 28 Aug 2023 09:34:24 GMT Subject: [jdk11u-dev] Integrated: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 09:23:13 GMT, toshiogata wrote: > Hi all, > > This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 > > I worked for backporting JDK-8217612, and found that this related patch should be backported at the same time. > > The riginal patch is applied cleanly to JDK-8217612 applied code. > > Testing: all serviceability agent tests, hotspot_all that includes CompressedClassSpaceSizeInJmapHeap.java and the test which come with JDK-8217612. > > Thank you. This pull request has now been integrated. Changeset: 81806b78 Author: t.ogata Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/81806b786e0ec9c29d2e3d64ef099f710724fba1 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 Backport-of: 49c91b7f9522a991bcac789b9fcccfee8bf08b5d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2096 From mbaesken at openjdk.org Mon Aug 28 11:54:50 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 28 Aug 2023 11:54:50 GMT Subject: [jdk17u-dev] RFR: 8314517: some tests fail in case ipv6 is disabled on the machine Message-ID: Backport 8314517 ------------- Commit messages: - Backport 703817d21f6fd8b24cc670695625dfdb09d3592c Changes: https://git.openjdk.org/jdk17u-dev/pull/1702/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1702&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314517 Stats: 46 lines in 3 files changed: 20 ins; 1 del; 25 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1702.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1702/head:pull/1702 PR: https://git.openjdk.org/jdk17u-dev/pull/1702 From amitkumar at openjdk.org Mon Aug 28 11:56:15 2023 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 28 Aug 2023 11:56:15 GMT Subject: [jdk21u] RFR: 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 17:45:18 GMT, Sidraya Jayagond wrote: > Hi all, > > This pull request contains a backport of commit [514816ed](https://github.com/openjdk/jdk/commit/514816ed7d7dea1fb13d32b80aef89774bee13d3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sidraya Jayagond on 4 Jul 2023 and was reviewed by Amit Kumar and Lutz Schmidt. > > Thanks! I'll sponser this once we got approval. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/106#issuecomment-1695561622 From sjayagond at openjdk.org Mon Aug 28 12:11:48 2023 From: sjayagond at openjdk.org (Sidraya Jayagond) Date: Mon, 28 Aug 2023 12:11:48 GMT Subject: [jdk21u] RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) Message-ID: Hi all, This pull request contains a backport of commit [ec1f7a84](https://github.com/openjdk/jdk/commit/ec1f7a8480db025a6f405817a106af8e92b69c44) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sidraya on 21 Aug 2023 and was reviewed by Amit Kumar, Jorn Vernee and Martin Doerr. This PR apply clean on jdk21u, testes with release, fastdebug and slowdebug build. Thanks! ------------- Commit messages: - Backport ec1f7a8480db025a6f405817a106af8e92b69c44 Changes: https://git.openjdk.org/jdk21u/pull/110/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=110&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311630 Stats: 1523 lines in 19 files changed: 1469 ins; 4 del; 50 mod Patch: https://git.openjdk.org/jdk21u/pull/110.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/110/head:pull/110 PR: https://git.openjdk.org/jdk21u/pull/110 From mdoerr at openjdk.org Mon Aug 28 12:26:21 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 28 Aug 2023 12:26:21 GMT Subject: [jdk17u-dev] RFR: 8314517: some tests fail in case ipv6 is disabled on the machine In-Reply-To: References: Message-ID: On Mon, 28 Aug 2023 11:47:21 GMT, Matthias Baesken wrote: > Backport 8314517 Marked as reviewed by mdoerr (Reviewer). Ok. The other tests are not in 17. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1702#pullrequestreview-1598183685 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1702#issuecomment-1695602763 From andrew at openjdk.org Mon Aug 28 12:36:22 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 28 Aug 2023 12:36:22 GMT Subject: [jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2] In-Reply-To: References: <19GqWms4PGLXC8VXXlV25KRyichxKWH7H54eEbhrxoU=.82060de1-0f1a-4031-9b75-910506ec3120@github.com> Message-ID: On Thu, 24 Aug 2023 06:23:32 GMT, Aleksey Shipilev wrote: > Looks okay now. I guess we should be doing these in every maintained release at this point. Yes, I should open a PR for 21u. Added `jdk17u-fix-request` for this one now. Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1673#issuecomment-1695618531 From sgehwolf at redhat.com Mon Aug 28 12:50:35 2023 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Mon, 28 Aug 2023 14:50:35 +0200 Subject: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u In-Reply-To: References: <26a6d12b49b4b19e24b9e8e75eb382376848df16.camel@redhat.com> Message-ID: <3ee1b5a6bfa67f3638a24c6477527d12aec587a2.camel@redhat.com> Hi, On Fri, 2023-08-25 at 20:26 +0000, Terry Chow (Simba Technologies Inc) wrote: > Hi Severin, > > I forgot to add this in my last reply. From my last email, if that is > the correct 21u repo and if there aren't any other special details > for backporting to 21u, could you or someone with JBS account help me > add an initial "Fix request 21u" to JDK-8308593 to start the backport > process for 21u? If you tell us the "Fix Request" comment, then somebody (perhaps someone from Microsoft with access?) could transplant it to the master bug and request the 21u backport approval. Please be sure to mention testing you've done on various platforms and the risk this change involves if integrated as well as potential follow-up bug fixes that need to be backported as well. Thanks, Severin > Thanks again, > Terry > From: Terry Chow (Simba Technologies Inc) > Sent: August 24, 2023 11:42 AM > To: Severin Gehwolf ; > jdk-updates-dev at openjdk.org > Subject: Re: [EXTERNAL] Re: Backporting Keepalive Windows Extended > Socket Options (JDK-8308593) to 11u and 17u > ? > Hi Severin, > > Thanks for the feedback. Just to confirm some details, is this the > correct repo for backports into 21u? I was expecting a "jdk21u-dev" > repo, similar to 17u and 11u. > > openjdk/jdk21u: https://openjdk.org/projects/jdk-updates (github.com) > > Also, can the guide below be applied to backporting into 21u, the > process is the same as 17u and 11u? There aren't any specific details > I need to be aware of to get a backport into 21u right? > > How to contribute or backport a fix - How to contribute or backport a > fix - OpenJDK Wiki > > Thanks, > Terry > > From: Severin Gehwolf > Sent: August 24, 2023 1:17 AM > To: Terry Chow (Simba Technologies Inc) ; > jdk-updates-dev at openjdk.org > Subject: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket > Options (JDK-8308593) to 11u and 17u > ? > [You don't often get email from sgehwolf at redhat.com. Learn why this > is important athttps://aka.ms/LearnAboutSenderIdentification ] > > Hi Terry, > > On Thu, 2023-08-24 at 00:54 +0000, Terry Chow (Simba Technologies > Inc) wrote: > > Hi maintainers of OpenJDK updates, > > > > I'd like to backport JDK-8308593 (keepalive extended socket options > > for Windows) to 11u and 17u (maybe 8u later as well). And so, I > > just want to open discussion on this topic to hear your opinions > > before I start the backporting process. I did some initial > > investigation on the backport and I learned the following: > > > > Backporting to 11u requires three additional changes to be made on > > top of the backport in order for it to work. > > ??? 1. Lib-jdk.net.gmk will need to be updated to support building > > extnet for Windows. > > ??? 2. jdk.net.ExtendedSocketOption will need to add a case to > > support returning a Windows instance of PlatformSocketOptions. > > ??? 3. The Windows PlainSocketImpl class needs to have the same > > code on lines 61 - 96 in the Unix PlainSocketImpl class. > > Backporting to 17u requires two additional changes (similar to > > 11u). > > ??? 1. jdk.net/Lib.gmkwill need to be updated to support building > > extnet for Windows. > > ??? 2. jdk.net.ExtendedSocketOption will need to add a case to > > support returning a Windows instance of PlatformSocketOptions. > > Let me know if the additional changes are acceptable or if they're > > disruptive. > > As the change went into JDK 22, I'd first suggest to get this into > JDK > 21u which would bring this feature to LTS users. JDK 17u seems OK as > a > next step from a brief glance (once it's in 21u). Only then we should > evaluate JDK 11u and older releases. > > Thanks, > Severin > From andrew at openjdk.org Mon Aug 28 12:50:46 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 28 Aug 2023 12:50:46 GMT Subject: [jdk17u-dev] RFR: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar Message-ID: The security fix, JDK-8300596, introduced a maximum size for signature-related files in JAR files, via the `jdk.jar.maxSignatureFileSize` property. The default value of 8MB has since proven to be too low for some JARs in general use. This change doubles it to 16MB, while still being much lower than the previous `MAX_ARRAY_SIZE` value of `Integer.MAX_VALUE - 8` This pull request contains a clean backport of commit [e47a84f2](https://github.com/openjdk/jdk/commit/e47a84f23dd2608c6f5748093eefe301fb5bf750) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Hai-May Chao on 31 Jul 2023 and was reviewed by Sean Mullan and Matthias Baesken. ------------- Commit messages: - Backport e47a84f23dd2608c6f5748093eefe301fb5bf750 Changes: https://git.openjdk.org/jdk17u-dev/pull/1703/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1703&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312489 Stats: 9 lines in 2 files changed: 2 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1703.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1703/head:pull/1703 PR: https://git.openjdk.org/jdk17u-dev/pull/1703 From andrew at openjdk.org Mon Aug 28 13:03:29 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 28 Aug 2023 13:03:29 GMT Subject: [jdk21u] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only Message-ID: This keeps 21u in sync with 8u, 11u, 17u & trunk where the minor version check has either been removed or (in the case of 17u) proposed for removal. This pull request contains a clean backport of commit [7e843c22](https://github.com/openjdk/jdk/commit/7e843c22e718ad17e0ea7223f10a26fb62477157) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Andrew John Hughes on 23 Aug 2023 and was reviewed by Julian Waters, Aleksey Shipilev, Thomas Stuefe, Erik Joelsson and Sergey Bylokhov. ------------- Commit messages: - Backport 7e843c22e718ad17e0ea7223f10a26fb62477157 Changes: https://git.openjdk.org/jdk21u/pull/111/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=111&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284772 Stats: 23 lines in 3 files changed: 0 ins; 18 del; 5 mod Patch: https://git.openjdk.org/jdk21u/pull/111.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/111/head:pull/111 PR: https://git.openjdk.org/jdk21u/pull/111 From clanger at openjdk.org Mon Aug 28 13:13:27 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 28 Aug 2023 13:13:27 GMT Subject: [jdk11u-dev] Integrated: 8302182: Update Public Suffix List to 88467c9 In-Reply-To: References: Message-ID: On Wed, 9 Aug 2023 21:46:54 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8302182](https://bugs.openjdk.org/browse/JDK-8302182), commit [ec2abc2d](https://github.com/openjdk/jdk17u-dev/commit/ec2abc2d82bf737258ae8ee0bba8ba6a15e1dabb) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Christoph Langer on 9 Aug 2023 and had no reviewers. > > Thanks! This pull request has now been integrated. Changeset: e1b839e7 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/e1b839e7ee85e1d532da219bd84961b00c080411 Stats: 1479 lines in 5 files changed: 647 ins; 697 del; 135 mod 8302182: Update Public Suffix List to 88467c9 Backport-of: ec2abc2d82bf737258ae8ee0bba8ba6a15e1dabb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2073 From duke at openjdk.org Mon Aug 28 14:45:46 2023 From: duke at openjdk.org (Weibing Xiao) Date: Mon, 28 Aug 2023 14:45:46 GMT Subject: [jdk21u] RFR: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection Message-ID: The socket is not closed in Connection::createSocket when the handshake fails for LDAP connection. This is the backporting task for https://bugs.openjdk.org/browse/JDK-8314063 ------------- Commit messages: - Backport f2383b3cbd1096f0b38e89a3d876da2217511f11 Changes: https://git.openjdk.org/jdk21u/pull/112/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=112&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314063 Stats: 357 lines in 3 files changed: 290 ins; 42 del; 25 mod Patch: https://git.openjdk.org/jdk21u/pull/112.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/112/head:pull/112 PR: https://git.openjdk.org/jdk21u/pull/112 From clanger at openjdk.org Mon Aug 28 15:16:25 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 28 Aug 2023 15:16:25 GMT Subject: [jdk11u-dev] RFR: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v5] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Mon, 21 Aug 2023 03:27:59 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java I've approved the backport in the JBS issue. Please go ahead and integrate. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2074#issuecomment-1695877780 From alexsch at openjdk.org Mon Aug 28 15:16:27 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Mon, 28 Aug 2023 15:16:27 GMT Subject: [jdk17u-dev] Integrated: 8311033: [macos] PrinterJob does not take into account Sides attribute In-Reply-To: References: Message-ID: On Mon, 28 Aug 2023 05:43:22 GMT, Alexander Scherbatiy wrote: > This is a clean backport of the fix `8311033: [macos] PrinterJob does not take into account Sides attribute`. > > The fix allows to print pages with DUPLEX and TUMBLE attributes on macOS. > Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. This pull request has now been integrated. Changeset: 47ed2e5b Author: Alexander Scherbatiy URL: https://git.openjdk.org/jdk17u-dev/commit/47ed2e5b266b816b0566c537c51f7c502f6c293b Stats: 335 lines in 4 files changed: 335 ins; 0 del; 0 mod 8311033: [macos] PrinterJob does not take into account Sides attribute Backport-of: a3d67231a71fbe37c509fcedd54c679b4644c0d9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1701 From mbaesken at openjdk.org Mon Aug 28 15:21:38 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 28 Aug 2023 15:21:38 GMT Subject: [jdk21u] RFR: 8313691: use close after failing os::fdopen in vmError and ciEnv Message-ID: <1sHKo3vU5Eb2U-OfQm0l9703pT2GxsMgsTcDZrK6abE=.69b79a02-0be5-47f5-bf34-cc4c27cfca06@github.com> 8313691: use close after failing os::fdopen in vmError and ciEnv ------------- Commit messages: - Backport 96304f37f8344b0c0e271ff9cda84961519d5109 Changes: https://git.openjdk.org/jdk21u/pull/113/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=113&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313691 Stats: 3 lines in 2 files changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/113.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/113/head:pull/113 PR: https://git.openjdk.org/jdk21u/pull/113 From amitkumar at openjdk.org Mon Aug 28 15:26:09 2023 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 28 Aug 2023 15:26:09 GMT Subject: [jdk21u] RFR: 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 17:45:18 GMT, Sidraya Jayagond wrote: > Hi all, > > This pull request contains a backport of commit [514816ed](https://github.com/openjdk/jdk/commit/514816ed7d7dea1fb13d32b80aef89774bee13d3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sidraya Jayagond on 4 Jul 2023 and was reviewed by Amit Kumar and Lutz Schmidt. > > Thanks! Fix Approved !! ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/106#issuecomment-1695893346 From stuefe at openjdk.org Mon Aug 28 15:35:14 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 28 Aug 2023 15:35:14 GMT Subject: [jdk21u] RFR: 8303815: Improve Metaspace test speed In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 06:26:46 GMT, Thomas Stuefe wrote: > Small improvement, low risk, that speeds up metaspace tests (jtreg and gtests). Push approval there, tests clean apart from riscv infra issue. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/98#issuecomment-1695904556 From stuefe at openjdk.org Mon Aug 28 15:35:18 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 28 Aug 2023 15:35:18 GMT Subject: [jdk21u] RFR: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 12:48:36 GMT, Thomas Stuefe wrote: > Fixes a serious issue that may cause huge RSS bloat and thread startup performance degradation. Applies cleanly. Got push approval. Tests clean. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/103#issuecomment-1695906798 From stuefe at openjdk.org Mon Aug 28 15:35:15 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 28 Aug 2023 15:35:15 GMT Subject: [jdk21u] Integrated: 8303815: Improve Metaspace test speed In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 06:26:46 GMT, Thomas Stuefe wrote: > Small improvement, low risk, that speeds up metaspace tests (jtreg and gtests). This pull request has now been integrated. Changeset: 89234bc3 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk21u/commit/89234bc31da95bd2e499ca25a7639919948e3d10 Stats: 56 lines in 6 files changed: 34 ins; 5 del; 17 mod 8303815: Improve Metaspace test speed Backport-of: de0e46c2f6dfa817bfa745195573810d250640de ------------- PR: https://git.openjdk.org/jdk21u/pull/98 From phh at openjdk.org Mon Aug 28 15:37:26 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 28 Aug 2023 15:37:26 GMT Subject: [jdk11u-dev] RFR: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v5] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Mon, 21 Aug 2023 03:27:59 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2074#pullrequestreview-1598549551 From stuefe at openjdk.org Mon Aug 28 15:38:23 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 28 Aug 2023 15:38:23 GMT Subject: [jdk21u] Integrated: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 12:48:36 GMT, Thomas Stuefe wrote: > Fixes a serious issue that may cause huge RSS bloat and thread startup performance degradation. Applies cleanly. This pull request has now been integrated. Changeset: 4cca633e Author: Thomas Stuefe URL: https://git.openjdk.org/jdk21u/commit/4cca633e3761633d9779e42d22b80151fa7655e9 Stats: 301 lines in 3 files changed: 294 ins; 0 del; 7 mod 8312182: THPs cause huge RSS due to thread start timing issue 8310687: JDK-8303215 is incomplete Backport-of: 84b325b844c08809448a9c073a11443d9e3c3f8e ------------- PR: https://git.openjdk.org/jdk21u/pull/103 From stuefe at openjdk.org Mon Aug 28 15:45:24 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 28 Aug 2023 15:45:24 GMT Subject: [jdk21u] RFR: 8312620: WSL Linux build crashes after JDK-8310233 In-Reply-To: References: Message-ID: On Sat, 26 Aug 2023 06:00:52 GMT, Thomas Stuefe wrote: > Clean backport to fix a build error when building in WSL on Windows. Got push approval, tests are clean. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/108#issuecomment-1695918602 From stuefe at openjdk.org Mon Aug 28 15:45:25 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 28 Aug 2023 15:45:25 GMT Subject: [jdk21u] Integrated: 8312620: WSL Linux build crashes after JDK-8310233 In-Reply-To: References: Message-ID: <202c3uTbS0AOYc1auNB4bmpD1MpE99J2yAzTPPthksM=.997e7233-36bc-4e4e-8e55-bd5ffcebe9f2@github.com> On Sat, 26 Aug 2023 06:00:52 GMT, Thomas Stuefe wrote: > Clean backport to fix a build error when building in WSL on Windows. This pull request has now been integrated. Changeset: 34e9be51 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk21u/commit/34e9be5154c12c5938e517016c1dee164dfeeafe Stats: 21 lines in 3 files changed: 14 ins; 0 del; 7 mod 8312620: WSL Linux build crashes after JDK-8310233 Backport-of: 25058cd23ac9c8993e7acfd82728ee4c623f0914 ------------- PR: https://git.openjdk.org/jdk21u/pull/108 From duke at openjdk.org Mon Aug 28 16:03:16 2023 From: duke at openjdk.org (Weibing Xiao) Date: Mon, 28 Aug 2023 16:03:16 GMT Subject: [jdk21u] Integrated: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection In-Reply-To: References: Message-ID: On Mon, 28 Aug 2023 14:39:24 GMT, Weibing Xiao wrote: > The socket is not closed in Connection::createSocket when the handshake fails for LDAP connection. This is the backporting task for https://bugs.openjdk.org/browse/JDK-8314063 This pull request has now been integrated. Changeset: 1f5ba7a8 Author: Weibing Xiao Committer: Rob McKenna URL: https://git.openjdk.org/jdk21u/commit/1f5ba7a8d640d32a70aa722d46708f40517d08e8 Stats: 357 lines in 3 files changed: 290 ins; 42 del; 25 mod 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection Backport-of: f2383b3cbd1096f0b38e89a3d876da2217511f11 ------------- PR: https://git.openjdk.org/jdk21u/pull/112 From phh at openjdk.org Mon Aug 28 16:33:27 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 28 Aug 2023 16:33:27 GMT Subject: [jdk11u-dev] RFR: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v5] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Mon, 21 Aug 2023 03:27:59 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java GHA failures are unrelated infrastructure problems. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2074#issuecomment-1695994584 From cjplummer at openjdk.org Mon Aug 28 18:11:43 2023 From: cjplummer at openjdk.org (Chris Plummer) Date: Mon, 28 Aug 2023 18:11:43 GMT Subject: [jdk21u] RFR: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM Message-ID: Clean merge. Needed to address issue uncovered by [JDK-8294323](https://bugs.openjdk.org/browse/JDK-8294323) ------------- Commit messages: - Backport 38a9edfb7ee2d91ff52074137c5b69e27bcdbdc3 Changes: https://git.openjdk.org/jdk21u/pull/115/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=115&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314679 Stats: 95 lines in 3 files changed: 94 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/115.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/115/head:pull/115 PR: https://git.openjdk.org/jdk21u/pull/115 From simonis at openjdk.org Mon Aug 28 19:25:59 2023 From: simonis at openjdk.org (Volker Simonis) Date: Mon, 28 Aug 2023 19:25:59 GMT Subject: [jdk11u-dev] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() Message-ID: This issue was found by Yakov Shafranovich (yakovsh at amazon.com) who also provided the reproducer and proposed a fix. The native implementation of the `Pack200.Unpacker` class included in OpenJDK 8 and 11 has a native and heap memory leak that gets triggered when corrupted files are processed. If the native `NativeUnpack::start()` method throws an exception (because of a corrupted input file) its caller `NativeUnpack::run()` fails to call the native `NativeUnpack::finish()` method which is responsible for freeing the allocated native memory and releasing the created ?global JNI handles?. A Java application processing large number of malformed Pack200 files will eventually run either out of native memory or out of heap space and exit with an `OutOfMemoryError`. The problem can be demonstrated with the following short test program which will exit with an `OutOfMemoryError` quite quickly if run with `java -Xmx32m NativePack200POC`: import java.io.*; import java.util.jar.*; @SuppressWarnings("removal") public class NativePack200POC { public static void main(String[] args) { try { ByteArrayInputStream in = new ByteArrayInputStream("foobar".getBytes()); for(int i=0; i < 1_000_000; i++) { try { JarOutputStream out = new JarOutputStream(new ByteArrayOutputStream()); Pack200.Unpacker unpacker = Pack200.newUnpacker(); unpacker.unpack(in, out); } catch (IOException e) { } } } catch (OutOfMemoryError e) { System.out.println(e); throw e; } } } The problem can be worked around by disabling the native Pack200 implementation with `-Dcom.sun.java.util.jar.pack.disable.native=true` but the default setting is `-Dcom.sun.java.util.jar.pack.disable.native=false`. Notice that this bug can not be fixed in HEAD because the Pack200 functionality has been removed in JDK 14 (https://openjdk.org/jeps/367). I therefore propose to fix this in jdk11u-dev first and then downport the fix to jdk8u-dev as well. ? ------------- Commit messages: - 8315135: Memory leak in the native implementation of Pack200O.Unpacker.unpack() Changes: https://git.openjdk.org/jdk11u-dev/pull/2100/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2100&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315135 Stats: 61 lines in 3 files changed: 60 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2100.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2100/head:pull/2100 PR: https://git.openjdk.org/jdk11u-dev/pull/2100 From alexsch at openjdk.org Mon Aug 28 21:00:35 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Mon, 28 Aug 2023 21:00:35 GMT Subject: [jdk21u] RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute Message-ID: This is a clean backport of the fix `8311033: [macos] PrinterJob does not take into account Sides attribute`. The fix allows to print pages with DUPLEX and TUMBLE attributes on macOS. Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. ------------- Commit messages: - Backport a3d67231a71fbe37c509fcedd54c679b4644c0d9 Changes: https://git.openjdk.org/jdk21u/pull/116/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=116&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311033 Stats: 335 lines in 4 files changed: 335 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/116/head:pull/116 PR: https://git.openjdk.org/jdk21u/pull/116 From tsteele at openjdk.org Mon Aug 28 21:18:15 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Mon, 28 Aug 2023 21:18:15 GMT Subject: [jdk21u] Integrated: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) In-Reply-To: References: Message-ID: On Tue, 22 Aug 2023 16:36:59 GMT, Tyler Steele wrote: > Hi all, > > This pull request contains a backport of commit [fdac6a6a](https://github.com/openjdk/jdk/commit/fdac6a6ac871366614efe44aca58ab520766b5c8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. It fixes TestByteBuffer.java, and depends on changes the backported by #77. > > The commit being backported was authored by Tyler Steele on 18 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe. > > Thanks! This pull request has now been integrated. Changeset: 2408df23 Author: Tyler Steele Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u/commit/2408df237e7fc10f92711f741762422252d17e94 Stats: 235 lines in 3 files changed: 210 ins; 25 del; 0 mod 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) Backport-of: 395fc78880a91eeb06a08c1abf6905d580a650c0 ------------- PR: https://git.openjdk.org/jdk21u/pull/82 From mdoerr at openjdk.org Mon Aug 28 21:24:13 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 28 Aug 2023 21:24:13 GMT Subject: [jdk21u] RFR: 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. In-Reply-To: References: Message-ID: <5KI5HVkDUAJ0BENsdIDGMSQMTT_ZVyve-GUehVKVax0=.7ba07c7a-fefa-4834-9007-6f19cf0e40bb@github.com> On Fri, 25 Aug 2023 17:45:18 GMT, Sidraya Jayagond wrote: > Hi all, > > This pull request contains a backport of commit [514816ed](https://github.com/openjdk/jdk/commit/514816ed7d7dea1fb13d32b80aef89774bee13d3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sidraya Jayagond on 4 Jul 2023 and was reviewed by Amit Kumar and Lutz Schmidt. > > Thanks! I think only jdk-updates committers can sponsor it. I'll do it. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/106#issuecomment-1696427291 From sjayagond at openjdk.org Mon Aug 28 21:24:13 2023 From: sjayagond at openjdk.org (Sidraya Jayagond) Date: Mon, 28 Aug 2023 21:24:13 GMT Subject: [jdk21u] Integrated: 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 17:45:18 GMT, Sidraya Jayagond wrote: > Hi all, > > This pull request contains a backport of commit [514816ed](https://github.com/openjdk/jdk/commit/514816ed7d7dea1fb13d32b80aef89774bee13d3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sidraya Jayagond on 4 Jul 2023 and was reviewed by Amit Kumar and Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: 8bf3ba34 Author: Sidraya Jayagond Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u/commit/8bf3ba34b5770a373fdb967f8ad8230321471530 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. Backport-of: 514816ed7d7dea1fb13d32b80aef89774bee13d3 ------------- PR: https://git.openjdk.org/jdk21u/pull/106 From v-terrychow at microsoft.com Mon Aug 28 23:58:15 2023 From: v-terrychow at microsoft.com (Terry Chow (Simba Technologies Inc)) Date: Mon, 28 Aug 2023 23:58:15 +0000 Subject: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u In-Reply-To: <3ee1b5a6bfa67f3638a24c6477527d12aec587a2.camel@redhat.com> References: <26a6d12b49b4b19e24b9e8e75eb382376848df16.camel@redhat.com> <3ee1b5a6bfa67f3638a24c6477527d12aec587a2.camel@redhat.com> Message-ID: Hey Severin, My mistake for not including the fix request comment in the last email. Also, last week I tried reaching out to my Microsoft JDK contact for help with this, but it seems like they're away at the moment without a return date. Here's the "Fix request" comment, in case you or anyone else can help apply the request to ticket JDK-8308593: Fix Request 21u The reason for backporting the Windows keepalive extended socket options to 21u is to have keepalive parity with the other OS platforms. The risk is low as the backported code introduces a new code path that only takes effect when keepalive extended socket options are set on a Windows platform. It isn't expected to cause unintended effects or affect any current users as the keepalive options were never supported in the JDK for Windows before this patch. Tier 1 tests were ran and they're passing. I also manually tested and confirmed the patch to be working on Windows (specifically Windows 10 since that's the only Windows platform available to me at the moment). Test coverage is covered by existing tests from another backport from JDK-8194298. The backport cleanly applies to 21u without any conflicts. Thanks again Severin, Terry ________________________________ From: Severin Gehwolf Sent: August 28, 2023 5:50 AM To: Terry Chow (Simba Technologies Inc) ; jdk-updates-dev at openjdk.org Subject: Re: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u Hi, On Fri, 2023-08-25 at 20:26 +0000, Terry Chow (Simba Technologies Inc) wrote: > Hi Severin, > > I forgot to add this in my last reply. From my last email, if that is > the correct 21u repo and if there aren't any other special details > for backporting to 21u, could you or someone with JBS account help me > add an initial "Fix request 21u" to JDK-8308593 to start the backport > process for 21u? If you tell us the "Fix Request" comment, then somebody (perhaps someone from Microsoft with access?) could transplant it to the master bug and request the 21u backport approval. Please be sure to mention testing you've done on various platforms and the risk this change involves if integrated as well as potential follow-up bug fixes that need to be backported as well. Thanks, Severin > Thanks again, > Terry > From: Terry Chow (Simba Technologies Inc) > Sent: August 24, 2023 11:42 AM > To: Severin Gehwolf ; > jdk-updates-dev at openjdk.org > Subject: Re: [EXTERNAL] Re: Backporting Keepalive Windows Extended > Socket Options (JDK-8308593) to 11u and 17u > > Hi Severin, > > Thanks for the feedback. Just to confirm some details, is this the > correct repo for backports into 21u? I was expecting a "jdk21u-dev" > repo, similar to 17u and 11u. > > openjdk/jdk21u: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopenjdk.org%2Fprojects%2Fjdk-updates&data=05%7C01%7Cv-terrychow%40microsoft.com%7Ca355ccafb8574a17b61108dba7c561b6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638288238420042142%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MmdGW1%2Fnx%2F6Qmb06WZBInKfmwjr8%2BEWNPk6%2FNmk4FtU%3D&reserved=0 (github.com) > > Also, can the guide below be applied to backporting into 21u, the > process is the same as 17u and 11u? There aren't any specific details > I need to be aware of to get a backport into 21u right? > > How to contribute or backport a fix - How to contribute or backport a > fix - OpenJDK Wiki > > Thanks, > Terry > > From: Severin Gehwolf > Sent: August 24, 2023 1:17 AM > To: Terry Chow (Simba Technologies Inc) ; > jdk-updates-dev at openjdk.org > Subject: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket > Options (JDK-8308593) to 11u and 17u > > [You don't often get email from sgehwolf at redhat.com. Learn why this > is important athttps://aka.ms/LearnAboutSenderIdentification ] > > Hi Terry, > > On Thu, 2023-08-24 at 00:54 +0000, Terry Chow (Simba Technologies > Inc) wrote: > > Hi maintainers of OpenJDK updates, > > > > I'd like to backport JDK-8308593 (keepalive extended socket options > > for Windows) to 11u and 17u (maybe 8u later as well). And so, I > > just want to open discussion on this topic to hear your opinions > > before I start the backporting process. I did some initial > > investigation on the backport and I learned the following: > > > > Backporting to 11u requires three additional changes to be made on > > top of the backport in order for it to work. > > 1. Lib-jdk.net.gmk will need to be updated to support building > > extnet for Windows. > > 2. jdk.net.ExtendedSocketOption will need to add a case to > > support returning a Windows instance of PlatformSocketOptions. > > 3. The Windows PlainSocketImpl class needs to have the same > > code on lines 61 - 96 in the Unix PlainSocketImpl class. > > Backporting to 17u requires two additional changes (similar to > > 11u). > > 1. jdk.net/Lib.gmkwill need to be updated to support building > > extnet for Windows. > > 2. jdk.net.ExtendedSocketOption will need to add a case to > > support returning a Windows instance of PlatformSocketOptions. > > Let me know if the additional changes are acceptable or if they're > > disruptive. > > As the change went into JDK 22, I'd first suggest to get this into > JDK > 21u which would bring this feature to LTS users. JDK 17u seems OK as > a > next step from a brief glance (once it's in 21u). Only then we should > evaluate JDK 11u and older releases. > > Thanks, > Severin > -------------- next part -------------- An HTML attachment was scrubbed... URL: From serb at openjdk.org Tue Aug 29 02:29:50 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 29 Aug 2023 02:29:50 GMT Subject: [jdk17u-dev] RFR: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned Message-ID: Hi all, This pull request contains a backport of commit [68756782](https://github.com/openjdk/jdk/commit/687567822a5380fb7d8c5b54ae548b2a5c848187) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 30 Oct 2021 and was reviewed by Alexey Ivanov. Thanks! ------------- Commit messages: - Backport 687567822a5380fb7d8c5b54ae548b2a5c848187 Changes: https://git.openjdk.org/jdk17u-dev/pull/1625/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1625&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273831 Stats: 120 lines in 3 files changed: 104 ins; 3 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1625.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1625/head:pull/1625 PR: https://git.openjdk.org/jdk17u-dev/pull/1625 From andrew at openjdk.org Tue Aug 29 02:32:25 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 29 Aug 2023 02:32:25 GMT Subject: [jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2] In-Reply-To: <19GqWms4PGLXC8VXXlV25KRyichxKWH7H54eEbhrxoU=.82060de1-0f1a-4031-9b75-910506ec3120@github.com> References: <19GqWms4PGLXC8VXXlV25KRyichxKWH7H54eEbhrxoU=.82060de1-0f1a-4031-9b75-910506ec3120@github.com> Message-ID: On Wed, 23 Aug 2023 18:25:12 GMT, Andrew John Hughes wrote: >> GHA regularly breaks because we specify a very explicit GCC version, even down to the release versioning of the Ubuntu package. >> >> Rather than bumping this yet again like https://github.com/openjdk/jdk17u/commit/260f28761a87553fd634615df5ba3db5b76ae692, this PR suggests dropping the specific version as we did some time ago in 8u and I've also proposed to fix the same breakage in 11u (https://github.com/openjdk/jdk11u-dev/pull/2087). The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. >> >> Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by recent GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. >> >> ~~This is based on https://github.com/openjdk/jdk17u-dev/pull/1595 to allow https://github.com/openjdk/jdk17u-dev/pull/1672 to proceed.~~ This is now based on master and the change is in trunk. > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Backport 62defc3dfc4b9ba5adfe3189f34fe8b3f59b94a0 I see `jdk17u-fix-yes` ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1673#issuecomment-1696674733 From andrew at openjdk.org Tue Aug 29 02:32:25 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 29 Aug 2023 02:32:25 GMT Subject: [jdk17u-dev] Integrated: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 16:16:29 GMT, Andrew John Hughes wrote: > GHA regularly breaks because we specify a very explicit GCC version, even down to the release versioning of the Ubuntu package. > > Rather than bumping this yet again like https://github.com/openjdk/jdk17u/commit/260f28761a87553fd634615df5ba3db5b76ae692, this PR suggests dropping the specific version as we did some time ago in 8u and I've also proposed to fix the same breakage in 11u (https://github.com/openjdk/jdk11u-dev/pull/2087). The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone. > > Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by recent GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK. > > ~~This is based on https://github.com/openjdk/jdk17u-dev/pull/1595 to allow https://github.com/openjdk/jdk17u-dev/pull/1672 to proceed.~~ This is now based on master and the change is in trunk. This pull request has now been integrated. Changeset: 1d65a31d Author: Andrew John Hughes URL: https://git.openjdk.org/jdk17u-dev/commit/1d65a31dd43f69599d05c34ca19c49e0caba504a Stats: 22 lines in 3 files changed: 0 ins; 17 del; 5 mod 8284772: GHA: Use GCC Major Version Dependencies Only Reviewed-by: shade Backport-of: 62defc3dfc4b9ba5adfe3189f34fe8b3f59b94a0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1673 From andrew at openjdk.org Tue Aug 29 02:34:19 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 29 Aug 2023 02:34:19 GMT Subject: [jdk21u] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: On Mon, 28 Aug 2023 12:56:35 GMT, Andrew John Hughes wrote: > This keeps 21u in sync with 8u, 11u, 17u & trunk where the minor version check has either been removed or (in the case of 17u) proposed for removal. > > This pull request contains a clean backport of commit [7e843c22](https://github.com/openjdk/jdk/commit/7e843c22e718ad17e0ea7223f10a26fb62477157) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew John Hughes on 23 Aug 2023 and was reviewed by Julian Waters, Aleksey Shipilev, Thomas Stuefe, Erik Joelsson and Sergey Bylokhov. I see `jdk21u-fix-yes` ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/111#issuecomment-1696676050 From andrew at openjdk.org Tue Aug 29 02:34:20 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 29 Aug 2023 02:34:20 GMT Subject: [jdk21u] Integrated: 8284772: GHA: Use GCC Major Version Dependencies Only In-Reply-To: References: Message-ID: On Mon, 28 Aug 2023 12:56:35 GMT, Andrew John Hughes wrote: > This keeps 21u in sync with 8u, 11u, 17u & trunk where the minor version check has either been removed or (in the case of 17u) proposed for removal. > > This pull request contains a clean backport of commit [7e843c22](https://github.com/openjdk/jdk/commit/7e843c22e718ad17e0ea7223f10a26fb62477157) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew John Hughes on 23 Aug 2023 and was reviewed by Julian Waters, Aleksey Shipilev, Thomas Stuefe, Erik Joelsson and Sergey Bylokhov. This pull request has now been integrated. Changeset: 77b5fa2d Author: Andrew John Hughes URL: https://git.openjdk.org/jdk21u/commit/77b5fa2d9b8277b363b7fdfadfce84f70d6ee6a0 Stats: 23 lines in 3 files changed: 0 ins; 18 del; 5 mod 8284772: GHA: Use GCC Major Version Dependencies Only Backport-of: 7e843c22e718ad17e0ea7223f10a26fb62477157 ------------- PR: https://git.openjdk.org/jdk21u/pull/111 From aoqi at openjdk.org Tue Aug 29 04:58:34 2023 From: aoqi at openjdk.org (Ao Qi) Date: Tue, 29 Aug 2023 04:58:34 GMT Subject: [jdk21u] RFR: 8315020: The macro definition for LoongArch64 zero build is not accurate. Message-ID: Clean backport to fix the LoongArch64 zero build. This backport would be convenient for some OS distributions in the future, such as Debian. Additional testing: - [x] LoongArch Zero release and fastdebug build. ------------- Commit messages: - Backport 725ec0ce1b463b21cd4c5287cf4ccbee53ec7349 Changes: https://git.openjdk.org/jdk21u/pull/109/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=109&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315020 Stats: 8 lines in 2 files changed: 4 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/109.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/109/head:pull/109 PR: https://git.openjdk.org/jdk21u/pull/109 From clanger at openjdk.org Tue Aug 29 05:15:15 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 29 Aug 2023 05:15:15 GMT Subject: [jdk11u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 [v2] In-Reply-To: References: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> Message-ID: On Tue, 22 Aug 2023 07:49:08 GMT, Aleksey Shipilev wrote: >> This similar to the bulk GHA update we did here: https://github.com/shipilev/jdk17u-dev/commit/260f28761a87553fd634615df5ba3db5b76ae692 -- but now for 11u. >> >> Note this reverts and then reapplies [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772) to avoid backport conflicts. >> >> There are other GHA improvements we would backport later. This one atomic PR brings in 11u GHA closer to mainline GHA state without breaking the builds. For reference, after this PR, the 11u-vs-mainline GHA diff would be this: [gha-11u-vs-mainline.patch](https://github.com/openjdk/jdk11u-dev/files/12395257/gha-11u-vs-mainline.patch) > > Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: > > Reapply JDK-8284772: GHA: Use GCC Major Version Dependencies Only Looks good, thanks for the effort. Please add approval labels. ------------- Marked as reviewed by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2090#pullrequestreview-1599490096 From serb at openjdk.org Tue Aug 29 06:29:44 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 29 Aug 2023 06:29:44 GMT Subject: [jdk17u-dev] RFR: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [68756782](https://github.com/openjdk/jdk/commit/687567822a5380fb7d8c5b54ae548b2a5c848187) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 30 Oct 2021 and was reviewed by Alexey Ivanov. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into mrserb-backport-68756782 - Backport 687567822a5380fb7d8c5b54ae548b2a5c848187 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1625/files - new: https://git.openjdk.org/jdk17u-dev/pull/1625/files/0bd4c38c..ea6da0d0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1625&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1625&range=00-01 Stats: 7317 lines in 144 files changed: 5492 ins; 1054 del; 771 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1625.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1625/head:pull/1625 PR: https://git.openjdk.org/jdk17u-dev/pull/1625 From serb at openjdk.org Tue Aug 29 06:29:57 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 29 Aug 2023 06:29:57 GMT Subject: [jdk17u-dev] RFR: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException [v2] In-Reply-To: References: Message-ID: <0_hQsbIsBS017P0OMQYHSPnIh8j8voomW4uZvAMkiH0=.0b3b5361-76b5-4ca8-8317-c14a3cfed7de@github.com> > Hi all, > > This pull request contains a backport of commit [87298d2a](https://github.com/openjdk/jdk/commit/87298d2ade41c689d3140981a123b0e9130fc651) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into mrserb-backport-87298d2a - Backport 87298d2ade41c689d3140981a123b0e9130fc651 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1689/files - new: https://git.openjdk.org/jdk17u-dev/pull/1689/files/78a19c61..37e5e9db Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1689&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1689&range=00-01 Stats: 1698 lines in 34 files changed: 1644 ins; 28 del; 26 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1689.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1689/head:pull/1689 PR: https://git.openjdk.org/jdk17u-dev/pull/1689 From serb at openjdk.org Tue Aug 29 06:58:42 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 29 Aug 2023 06:58:42 GMT Subject: [jdk17u-dev] RFR: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free Message-ID: Hi all, This pull request contains a backport of commit [7c2c5858](https://github.com/openjdk/jdk/commit/7c2c58587d4eda5523331eae45e7d897252dc097) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 12 Dec 2021 and was reviewed by Prasanta Sadhukhan and Alexey Ivanov. Thanks! ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/1625 Commit messages: - Backport 7c2c58587d4eda5523331eae45e7d897252dc097 Changes: https://git.openjdk.org/jdk17u-dev/pull/1706/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1706&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276819 Stats: 9 lines in 1 file changed: 3 ins; 4 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1706.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1706/head:pull/1706 PR: https://git.openjdk.org/jdk17u-dev/pull/1706 From mbaesken at openjdk.org Tue Aug 29 07:25:25 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 29 Aug 2023 07:25:25 GMT Subject: [jdk11u-dev] Integrated: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 In-Reply-To: References: Message-ID: <1SLjgpGIaHThtW4ixf-fQoobZN8y1pqY_TrARIyZofg=.c1d18e17-e184-4315-9793-a2ad8ad3fa65@github.com> On Fri, 25 Aug 2023 07:02:31 GMT, Matthias Baesken wrote: > 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 This pull request has now been integrated. Changeset: 89a88f05 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/89a88f054503cc12052116bde61f01947c2a2d4f Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 Backport-of: d24b7b7026cf85f1aecf44f60819762872cfd5c1 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2098 From clanger at openjdk.org Tue Aug 29 07:26:22 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 29 Aug 2023 07:26:22 GMT Subject: [jdk17u-dev] RFR: 8292717: Clean up checking of testing requirements in configure In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 14:38:38 GMT, Aleksey Shipilev wrote: > Prepares build system for cleaner googletest and jtreg dependency updates. After this, at least googletest update applies only with minor conflicts. I expect jtreg updates would be smoother too. > > Current backport does not apply cleanly, because prior backports are in the way. So I did this PR by reverting JDK-8292716 and JDK-8292763 fixes, applying this move cleanly, and then reapplying the first two cleanly. Therefore both JDK-8292716 and JDK-8292763 still effectively remain in 17u-dev. See commit history for individual commits. This also makes sure we do not miss anything in backports. > > @GoeLin, you might want to take a look. > > Additional testing: > - [x] GHA LGTM ------------- Marked as reviewed by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1693#pullrequestreview-1599679783 From mbaesken at openjdk.org Tue Aug 29 07:34:15 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 29 Aug 2023 07:34:15 GMT Subject: [jdk17u-dev] RFR: 8314517: some tests fail in case ipv6 is disabled on the machine In-Reply-To: References: Message-ID: On Mon, 28 Aug 2023 11:47:21 GMT, Matthias Baesken wrote: > Backport 8314517 Hi Martin, thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1702#issuecomment-1696917626 From mbaesken at openjdk.org Tue Aug 29 07:34:16 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 29 Aug 2023 07:34:16 GMT Subject: [jdk17u-dev] Integrated: 8314517: some tests fail in case ipv6 is disabled on the machine In-Reply-To: References: Message-ID: On Mon, 28 Aug 2023 11:47:21 GMT, Matthias Baesken wrote: > Backport 8314517 This pull request has now been integrated. Changeset: d82de1c7 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/d82de1c7aba95f7922434d485a9cf4761b71574d Stats: 46 lines in 3 files changed: 20 ins; 1 del; 25 mod 8314517: some tests fail in case ipv6 is disabled on the machine Reviewed-by: mdoerr Backport-of: 703817d21f6fd8b24cc670695625dfdb09d3592c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1702 From stuefe at openjdk.org Tue Aug 29 07:39:20 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 29 Aug 2023 07:39:20 GMT Subject: [jdk21u] RFR: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores Message-ID: Clean backport to fix an test issue on many-core machines post JDK-8312182 ------------- Commit messages: - Merge branch 'openjdk:master' into tstuefe-backport-73325028 - Merge branch 'openjdk:master' into tstuefe-backport-73325028 - Backport 733250288325bc663afc0376342d4c5a7a471cbd Changes: https://git.openjdk.org/jdk21u/pull/114/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=114&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314139 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/114.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/114/head:pull/114 PR: https://git.openjdk.org/jdk21u/pull/114 From clanger at openjdk.org Tue Aug 29 07:39:24 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 29 Aug 2023 07:39:24 GMT Subject: [jdk11u-dev] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() In-Reply-To: References: Message-ID: On Mon, 28 Aug 2023 19:17:36 GMT, Volker Simonis wrote: > This issue was found by Yakov Shafranovich (yakovsh at amazon.com) who also provided the reproducer and proposed a fix. > > The native implementation of the `Pack200.Unpacker` class included in OpenJDK 8 and 11 has a native and heap memory leak that gets triggered when corrupted files are processed. If the native `NativeUnpack::start()` method throws an exception (because of a corrupted input file) its caller `NativeUnpack::run()` fails to call the native `NativeUnpack::finish()` method which is responsible for freeing the allocated native memory and releasing the created ?global JNI handles?. A Java application processing large number of malformed Pack200 files will eventually run either out of native memory or out of heap space and exit with an `OutOfMemoryError`. > > The problem can be demonstrated with the following short test program which will exit with an `OutOfMemoryError` quite quickly if run with `java -Xmx32m NativePack200POC`: > > > import java.io.*; > import java.util.jar.*; > > @SuppressWarnings("removal") > public class NativePack200POC { > public static void main(String[] args) { > try { > ByteArrayInputStream in = new ByteArrayInputStream("foobar".getBytes()); > for(int i=0; i < 1_000_000; i++) { > try { > JarOutputStream out = new JarOutputStream(new ByteArrayOutputStream()); > Pack200.Unpacker unpacker = Pack200.newUnpacker(); > unpacker.unpack(in, out); > } catch (IOException e) { > } > } > } catch (OutOfMemoryError e) { > System.out.println(e); > throw e; > } > } > } > > > The problem can be worked around by disabling the native Pack200 implementation with `-Dcom.sun.java.util.jar.pack.disable.native=true` but the default setting is `-Dcom.sun.java.util.jar.pack.disable.native=false`. > > Notice that this bug can not be fixed in HEAD because the Pack200 functionality has been removed in JDK 14 (https://openjdk.org/jeps/367). I therefore propose to fix this in jdk11u-dev first and then downport the fix to jdk8u-dev as well. > ? Looks good overall. The test doesn't use the formatting conventions of OpenJDK Java code, though. Indentation should be 4 spaces and also a space between `if` and the following `(` is missing. Please clean this up before integrating. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2100#pullrequestreview-1599712162 From clanger at openjdk.org Tue Aug 29 08:16:19 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 29 Aug 2023 08:16:19 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:jdk17.0.8.1 Message-ID: We should merge the jdk17.0.8.1 release into the tree of jdk17u/jdk17u-dev. ------------- Commit messages: - Merge 'jdk17.0.8.1' into jdk17u - 8313765: Invalid CEN header (invalid zip64 extra data field size) - 8314677: Bump update version for OpenJDK: jdk-17.0.8.1 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/1707/files Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1707.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1707/head:pull/1707 PR: https://git.openjdk.org/jdk17u-dev/pull/1707 From clanger at openjdk.org Tue Aug 29 08:29:27 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 29 Aug 2023 08:29:27 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:jdk11.0.20.1 Message-ID: We should merge the jdk11.0.20.1 release into the tree of jdk11u/jdk11u-dev. ------------- Commit messages: - Merge 'jdk11.0.20.1' into jdk11u-dev - 8313765: Invalid CEN header (invalid zip64 extra data field size) - 8314678: Bump update version for OpenJDK: jdk-11.0.20.1 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk11u-dev/pull/2101/files Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2101.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2101/head:pull/2101 PR: https://git.openjdk.org/jdk11u-dev/pull/2101 From andrewlu at openjdk.org Tue Aug 29 09:29:11 2023 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 29 Aug 2023 09:29:11 GMT Subject: [jdk11u-dev] RFR: 8289077: Add manual tests to open Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport 787e16bb444ee3b63803f5d1701d0f0a68b5d474 Changes: https://git.openjdk.org/jdk11u-dev/pull/2102/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2102&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289077 Stats: 945 lines in 7 files changed: 945 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2102.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2102/head:pull/2102 PR: https://git.openjdk.org/jdk11u-dev/pull/2102 From stuefe at openjdk.org Tue Aug 29 10:04:18 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 29 Aug 2023 10:04:18 GMT Subject: [jdk21u] RFR: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores In-Reply-To: References: Message-ID: <5cHAxviALHDIJRHy2KNJLiWkGFvl4UlTtuh1xpetiAE=.0de5be8b-543a-4013-b8f7-22a93cff53de@github.com> On Mon, 28 Aug 2023 15:53:19 GMT, Thomas Stuefe wrote: > Clean backport to fix an test issue on many-core machines post JDK-8312182 got fix approval, tests are green. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/114#issuecomment-1697136790 From stuefe at openjdk.org Tue Aug 29 10:07:17 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 29 Aug 2023 10:07:17 GMT Subject: [jdk21u] Integrated: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores In-Reply-To: References: Message-ID: <5jwAfSQRBScwi5wJWrgbGIfRYDjFTYQFK89XAi_o2AM=.ce92e4b6-90ca-4b79-9f4a-89275a141923@github.com> On Mon, 28 Aug 2023 15:53:19 GMT, Thomas Stuefe wrote: > Clean backport to fix an test issue on many-core machines post JDK-8312182 This pull request has now been integrated. Changeset: af9d11eb Author: Thomas Stuefe URL: https://git.openjdk.org/jdk21u/commit/af9d11eb223a1b8144fdd03c52611525e62c5da8 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores Backport-of: 733250288325bc663afc0376342d4c5a7a471cbd ------------- PR: https://git.openjdk.org/jdk21u/pull/114 From stuefe at openjdk.org Tue Aug 29 10:28:29 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 29 Aug 2023 10:28:29 GMT Subject: [jdk21u] RFR: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation Message-ID: Clean backport. 8312182 introduced a mitigation for THP-related RSS bloat; it came with a switch to switch it off. We then decided to rename the switch. Since the switch should be the same across all releases, this needs to be backported too. ------------- Commit messages: - Merge branch 'openjdk:master' into tstuefe-backport-226cdc69 - Backport 226cdc696d933fbc174d07b0d9817246dbc0e06c - Backport 733250288325bc663afc0376342d4c5a7a471cbd Changes: https://git.openjdk.org/jdk21u/pull/105/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=105&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312585 Stats: 12 lines in 3 files changed: 2 ins; 2 del; 8 mod Patch: https://git.openjdk.org/jdk21u/pull/105.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/105/head:pull/105 PR: https://git.openjdk.org/jdk21u/pull/105 From clanger at openjdk.org Tue Aug 29 11:49:18 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 29 Aug 2023 11:49:18 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:jdk17.0.8.1 In-Reply-To: References: Message-ID: On Tue, 29 Aug 2023 08:08:49 GMT, Christoph Langer wrote: > We should merge the jdk17.0.8.1 release into the tree of jdk17u/jdk17u-dev. This pull request has now been integrated. Changeset: 7ea65a0d Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/7ea65a0d14cbee391d6fad8791e40fa6297e7675 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1707 From clanger at openjdk.org Tue Aug 29 11:49:25 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 29 Aug 2023 11:49:25 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:jdk11.0.20.1 In-Reply-To: References: Message-ID: <_jJuD1Rl0pWGqDggmpuE1bYLQi6s63d86UX0E12S40w=.68c1541c-1995-4e62-9663-efcd6c5c4dda@github.com> On Tue, 29 Aug 2023 08:23:22 GMT, Christoph Langer wrote: > We should merge the jdk11.0.20.1 release into the tree of jdk11u/jdk11u-dev. This pull request has now been integrated. Changeset: 749ecd50 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/749ecd50633cf0286307880e9f58c4cee906a7f1 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2101 From alexsch at openjdk.org Tue Aug 29 11:53:19 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Tue, 29 Aug 2023 11:53:19 GMT Subject: [jdk21u] RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute In-Reply-To: References: Message-ID: On Mon, 28 Aug 2023 20:53:54 GMT, Alexander Scherbatiy wrote: > This is a clean backport of the fix `8311033: [macos] PrinterJob does not take into account Sides attribute`. > > The fix allows to print pages with DUPLEX and TUMBLE attributes on macOS. > Manual `test/jdk/java/awt/print` and `test/jdk/javax/print` tests were run to check printing on macOS with and without the fix. Pre-submit tests fail because for some reason `jt6.0-b24.zip` can't be downloaded: [build.sh][INFO] Downloading https://git.openjdk.java.net/jtharness/archive/jt6.0-b24.zip to /home/runner/work/jdk21u/jdk21u/jtreg/src/make/../build/deps/jtharness/src/../source.zip Error: sh][ERROR] wget exited with exit code 8 Error: Process completed with exit code 1. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/116#issuecomment-1697291414 From goetz at openjdk.org Tue Aug 29 12:39:22 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 29 Aug 2023 12:39:22 GMT Subject: [jdk17u-dev] RFR: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException [v2] In-Reply-To: <0_hQsbIsBS017P0OMQYHSPnIh8j8voomW4uZvAMkiH0=.0b3b5361-76b5-4ca8-8317-c14a3cfed7de@github.com> References: <0_hQsbIsBS017P0OMQYHSPnIh8j8voomW4uZvAMkiH0=.0b3b5361-76b5-4ca8-8317-c14a3cfed7de@github.com> Message-ID: On Tue, 29 Aug 2023 06:29:57 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [87298d2a](https://github.com/openjdk/jdk/commit/87298d2ade41c689d3140981a123b0e9130fc651) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race. >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into mrserb-backport-87298d2a > - Backport 87298d2ade41c689d3140981a123b0e9130fc651 Hi, what is wrong with the pre submit tests? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1689#issuecomment-1697361194 From duke at openjdk.org Tue Aug 29 13:26:16 2023 From: duke at openjdk.org (duke) Date: Tue, 29 Aug 2023 13:26:16 GMT Subject: [jdk11u-dev] Withdrawn: 8308286: Fix clang warnings in linux code In-Reply-To: References: Message-ID: On Fri, 30 Jun 2023 13:19:47 GMT, Artem Semenov wrote: > When using the clang compiler to build OpenJDk on Linux, we encounter various "warnings as errors". > They can be fixed with small changes. > > As in the original patch, I added instructions to the make to suppress the clang compiler warnings. > > @djelinski please review This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2016 From ogillespie at openjdk.org Tue Aug 29 13:55:21 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 29 Aug 2023 13:55:21 GMT Subject: [jdk21u] Integrated: 8313678: SymbolTable can leak Symbols during cleanup In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 08:32:32 GMT, Oli Gillespie wrote: > Clean backport for https://bugs.openjdk.org/browse/JDK-8313678. This pull request has now been integrated. Changeset: c1892758 Author: Oli Gillespie Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u/commit/c1892758cee86d69c2d708a116eb002abb0db1d0 Stats: 82 lines in 11 files changed: 53 ins; 14 del; 15 mod 8313678: SymbolTable can leak Symbols during cleanup Backport-of: 4b2703ad39f8160264eb30c797824cc93a6b56e2 ------------- PR: https://git.openjdk.org/jdk21u/pull/73 From ogillespie at openjdk.org Tue Aug 29 13:56:21 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 29 Aug 2023 13:56:21 GMT Subject: [jdk21u] Integrated: 8313874: JNI NewWeakGlobalRef throws exception for null arg In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 10:11:13 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a clean backport of commit [028b3ae1](https://github.com/openjdk/jdk/commit/028b3ae1b162bd8f7c340bfa6e9487ca83697955) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 10 Aug 2023 and was reviewed by David Holmes, Kim Barrett and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: 42aec914 Author: Oli Gillespie Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u/commit/42aec9148858b415f8a580e1750b7bcd90e58053 Stats: 11 lines in 2 files changed: 10 ins; 0 del; 1 mod 8313874: JNI NewWeakGlobalRef throws exception for null arg Backport-of: 028b3ae1b162bd8f7c340bfa6e9487ca83697955 ------------- PR: https://git.openjdk.org/jdk21u/pull/88 From simonis at openjdk.org Tue Aug 29 14:10:03 2023 From: simonis at openjdk.org (Volker Simonis) Date: Tue, 29 Aug 2023 14:10:03 GMT Subject: [jdk11u-dev] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() [v2] In-Reply-To: References: Message-ID: > This issue was found by Yakov Shafranovich (yakovsh at amazon.com) who also provided the reproducer and proposed a fix. > > The native implementation of the `Pack200.Unpacker` class included in OpenJDK 8 and 11 has a native and heap memory leak that gets triggered when corrupted files are processed. If the native `NativeUnpack::start()` method throws an exception (because of a corrupted input file) its caller `NativeUnpack::run()` fails to call the native `NativeUnpack::finish()` method which is responsible for freeing the allocated native memory and releasing the created ?global JNI handles?. A Java application processing large number of malformed Pack200 files will eventually run either out of native memory or out of heap space and exit with an `OutOfMemoryError`. > > The problem can be demonstrated with the following short test program which will exit with an `OutOfMemoryError` quite quickly if run with `java -Xmx32m NativePack200POC`: > > > import java.io.*; > import java.util.jar.*; > > @SuppressWarnings("removal") > public class NativePack200POC { > public static void main(String[] args) { > try { > ByteArrayInputStream in = new ByteArrayInputStream("foobar".getBytes()); > for(int i=0; i < 1_000_000; i++) { > try { > JarOutputStream out = new JarOutputStream(new ByteArrayOutputStream()); > Pack200.Unpacker unpacker = Pack200.newUnpacker(); > unpacker.unpack(in, out); > } catch (IOException e) { > } > } > } catch (OutOfMemoryError e) { > System.out.println(e); > throw e; > } > } > } > > > The problem can be worked around by disabling the native Pack200 implementation with `-Dcom.sun.java.util.jar.pack.disable.native=true` but the default setting is `-Dcom.sun.java.util.jar.pack.disable.native=false`. > > Notice that this bug can not be fixed in HEAD because the Pack200 functionality has been removed in JDK 14 (https://openjdk.org/jeps/367). I therefore propose to fix this in jdk11u-dev first and then downport the fix to jdk8u-dev as well. > ? Volker Simonis has updated the pull request incrementally with one additional commit since the last revision: Fixed indentation in test ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2100/files - new: https://git.openjdk.org/jdk11u-dev/pull/2100/files/52138846..d27b82ae Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2100&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2100&range=00-01 Stats: 21 lines in 1 file changed: 8 ins; 8 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2100.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2100/head:pull/2100 PR: https://git.openjdk.org/jdk11u-dev/pull/2100 From simonis at openjdk.org Tue Aug 29 14:10:05 2023 From: simonis at openjdk.org (Volker Simonis) Date: Tue, 29 Aug 2023 14:10:05 GMT Subject: [jdk11u-dev] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() [v2] In-Reply-To: References: Message-ID: On Tue, 29 Aug 2023 07:36:29 GMT, Christoph Langer wrote: > Looks good overall. > > The test doesn't use the formatting conventions of OpenJDK Java code, though. Indentation should be 4 spaces and also a space between `if` and the following `(` is missing. Please clean this up before integrating. Thanks for looking into this @RealCLanger. I've updated the indentation as requested. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2100#issuecomment-1697510786 From stuefe at openjdk.org Tue Aug 29 14:47:25 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 29 Aug 2023 14:47:25 GMT Subject: [jdk11u-dev] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() [v2] In-Reply-To: References: Message-ID: On Tue, 29 Aug 2023 14:10:03 GMT, Volker Simonis wrote: >> This issue was found by Yakov Shafranovich (yakovsh at amazon.com) who also provided the reproducer and proposed a fix. >> >> The native implementation of the `Pack200.Unpacker` class included in OpenJDK 8 and 11 has a native and heap memory leak that gets triggered when corrupted files are processed. If the native `NativeUnpack::start()` method throws an exception (because of a corrupted input file) its caller `NativeUnpack::run()` fails to call the native `NativeUnpack::finish()` method which is responsible for freeing the allocated native memory and releasing the created ?global JNI handles?. A Java application processing large number of malformed Pack200 files will eventually run either out of native memory or out of heap space and exit with an `OutOfMemoryError`. >> >> The problem can be demonstrated with the following short test program which will exit with an `OutOfMemoryError` quite quickly if run with `java -Xmx32m NativePack200POC`: >> >> >> import java.io.*; >> import java.util.jar.*; >> >> @SuppressWarnings("removal") >> public class NativePack200POC { >> public static void main(String[] args) { >> try { >> ByteArrayInputStream in = new ByteArrayInputStream("foobar".getBytes()); >> for(int i=0; i < 1_000_000; i++) { >> try { >> JarOutputStream out = new JarOutputStream(new ByteArrayOutputStream()); >> Pack200.Unpacker unpacker = Pack200.newUnpacker(); >> unpacker.unpack(in, out); >> } catch (IOException e) { >> } >> } >> } catch (OutOfMemoryError e) { >> System.out.println(e); >> throw e; >> } >> } >> } >> >> >> The problem can be worked around by disabling the native Pack200 implementation with `-Dcom.sun.java.util.jar.pack.disable.native=true` but the default setting is `-Dcom.sun.java.util.jar.pack.disable.native=false`. >> >> Notice that this bug can not be fixed in HEAD because the Pack200 functionality has been removed in JDK 14 (https://openjdk.org/jeps/367). I therefore propose to fix this in jdk11u-dev first and then downport the fix to jdk8u-dev as well. >> ? > > Volker Simonis has updated the pull request incrementally with one additional commit since the last revision: > > Fixed indentation in test src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java line 123: > 121: // Free up native memory and JNI handles to prevent leaks > 122: ((NativeUnpack) _nunp).finish(); > 123: } What happens if `NativeUnpack` already called `finish()`? In case an error happened in the window after it calling `finish()` and it returning? Would that be harmless? ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2100#discussion_r1308948577 From ogillespie at openjdk.org Tue Aug 29 15:13:18 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 29 Aug 2023 15:13:18 GMT Subject: [jdk17u-dev] Integrated: 8313874: JNI NewWeakGlobalRef throws exception for null arg In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 10:17:50 GMT, Oli Gillespie wrote: > Nearly clean backport for https://bugs.openjdk.org/browse/JDK-8313874, the only difference is 17 using `NULL` compared to `nullptr` in tip required a manual (but trivial) merge. This pull request has now been integrated. Changeset: c91fb3f7 Author: Oli Gillespie Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/c91fb3f7a51461e24fee53187543333b1455accb Stats: 11 lines in 2 files changed: 10 ins; 0 del; 1 mod 8313874: JNI NewWeakGlobalRef throws exception for null arg Reviewed-by: phh Backport-of: 028b3ae1b162bd8f7c340bfa6e9487ca83697955 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1688 From ogillespie at openjdk.org Tue Aug 29 15:14:20 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 29 Aug 2023 15:14:20 GMT Subject: [jdk17u-dev] Integrated: 8313678: SymbolTable can leak Symbols during cleanup In-Reply-To: References: Message-ID: On Fri, 18 Aug 2023 16:31:51 GMT, Oli Gillespie wrote: > Backporting fix for symbol table leak from https://bugs.openjdk.org/browse/JDK-8313678. > > Not totally clean: > > * places where 17 uses NULL versus nullptr in tip, trivial fix > * symbolTable uses `Symbol**` in 17 instead of `Symbol*`, also easy fix > * dictionary.cpp is not a concurrent hash table in 17 (missing 8292680), so no need to modify it > * finalizerService, g1CardSet, DynamicSharedSymbols test don't exist in 17 This pull request has now been integrated. Changeset: a75e5de8 Author: Oli Gillespie Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/a75e5de8ed4fe1f66e0c6dc714f54f2ef38c8c8d Stats: 66 lines in 7 files changed: 43 ins; 12 del; 11 mod 8313678: SymbolTable can leak Symbols during cleanup Reviewed-by: phh, shade Backport-of: 4b2703ad39f8160264eb30c797824cc93a6b56e2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1674 From serb at openjdk.org Tue Aug 29 16:20:41 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 29 Aug 2023 16:20:41 GMT Subject: [jdk17u-dev] RFR: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException [v3] In-Reply-To: References: Message-ID: <87XaDOKsVzSJKV2VQMcyRqnvFlpw3uNy9vzRuN1r_mo=.586a3ef5-c6e1-4eea-bde3-9fe6e98939a5@github.com> > Hi all, > > This pull request contains a backport of commit [87298d2a](https://github.com/openjdk/jdk/commit/87298d2ade41c689d3140981a123b0e9130fc651) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into mrserb-backport-87298d2a - Merge branch 'openjdk:master' into mrserb-backport-87298d2a - Backport 87298d2ade41c689d3140981a123b0e9130fc651 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1689/files - new: https://git.openjdk.org/jdk17u-dev/pull/1689/files/37e5e9db..fccd52c8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1689&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1689&range=01-02 Stats: 123 lines in 12 files changed: 73 ins; 13 del; 37 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1689.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1689/head:pull/1689 PR: https://git.openjdk.org/jdk17u-dev/pull/1689 From serb at openjdk.org Tue Aug 29 16:28:58 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 29 Aug 2023 16:28:58 GMT Subject: [jdk21u] RFR: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [87298d2a](https://github.com/openjdk/jdk/commit/87298d2ade41c689d3140981a123b0e9130fc651) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into mrserb-backport-87298d2a - Backport 87298d2ade41c689d3140981a123b0e9130fc651 ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/96/files - new: https://git.openjdk.org/jdk21u/pull/96/files/e6604c23..62e91859 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=96&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=96&range=00-01 Stats: 2954 lines in 99 files changed: 2291 ins; 452 del; 211 mod Patch: https://git.openjdk.org/jdk21u/pull/96.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/96/head:pull/96 PR: https://git.openjdk.org/jdk21u/pull/96 From phh at openjdk.org Tue Aug 29 17:14:24 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 29 Aug 2023 17:14:24 GMT Subject: [jdk11u-dev] RFR: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java [v5] In-Reply-To: References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Mon, 21 Aug 2023 03:27:59 GMT, Taizo Kurashige wrote: >> I`d like to fix the bug reported in JDK-8314086. >> `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. >> This is causing compilation failure in ChildAlwaysOnTopTest.java. >> After fixing this typo, the test successfully passed. > > Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: > > 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java Hi, Taizo. Please add a "/integrate" comment so I (or Christoph) can sponsor. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2074#issuecomment-1697838828 From duke at openjdk.org Tue Aug 29 17:15:22 2023 From: duke at openjdk.org (Terry Chow) Date: Tue, 29 Aug 2023 17:15:22 GMT Subject: [jdk21u] RFR: 8308593: Add KEEPALIVE Extended Socket Options Support for Windows Message-ID: This is a clean backport of [JDK-8308593](https://bugs.openjdk.org/browse/JDK-8308593), which provides support for the keepalive extended socket options on Windows. Tier 1 tests were ran and they're passing along with the existing keepalive tests. I also manually tested and confirmed the patch to be working on Windows (specifically Windows 10 since that's the only Windows platform available to me at the moment). ------------- Commit messages: - Backport f3ade388dac0b882e671462caa762138f44817fb Changes: https://git.openjdk.org/jdk21u/pull/117/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=117&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308593 Stats: 210 lines in 9 files changed: 169 ins; 0 del; 41 mod Patch: https://git.openjdk.org/jdk21u/pull/117.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/117/head:pull/117 PR: https://git.openjdk.org/jdk21u/pull/117 From simonis at openjdk.org Tue Aug 29 18:18:47 2023 From: simonis at openjdk.org (Volker Simonis) Date: Tue, 29 Aug 2023 18:18:47 GMT Subject: [jdk11u-dev] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() [v3] In-Reply-To: References: Message-ID: > This issue was found by Yakov Shafranovich (yakovsh at amazon.com) who also provided the reproducer and proposed a fix. > > The native implementation of the `Pack200.Unpacker` class included in OpenJDK 8 and 11 has a native and heap memory leak that gets triggered when corrupted files are processed. If the native `NativeUnpack::start()` method throws an exception (because of a corrupted input file) its caller `NativeUnpack::run()` fails to call the native `NativeUnpack::finish()` method which is responsible for freeing the allocated native memory and releasing the created ?global JNI handles?. A Java application processing large number of malformed Pack200 files will eventually run either out of native memory or out of heap space and exit with an `OutOfMemoryError`. > > The problem can be demonstrated with the following short test program which will exit with an `OutOfMemoryError` quite quickly if run with `java -Xmx32m NativePack200POC`: > > > import java.io.*; > import java.util.jar.*; > > @SuppressWarnings("removal") > public class NativePack200POC { > public static void main(String[] args) { > try { > ByteArrayInputStream in = new ByteArrayInputStream("foobar".getBytes()); > for(int i=0; i < 1_000_000; i++) { > try { > JarOutputStream out = new JarOutputStream(new ByteArrayOutputStream()); > Pack200.Unpacker unpacker = Pack200.newUnpacker(); > unpacker.unpack(in, out); > } catch (IOException e) { > } > } > } catch (OutOfMemoryError e) { > System.out.println(e); > throw e; > } > } > } > > > The problem can be worked around by disabling the native Pack200 implementation with `-Dcom.sun.java.util.jar.pack.disable.native=true` but the default setting is `-Dcom.sun.java.util.jar.pack.disable.native=false`. > > Notice that this bug can not be fixed in HEAD because the Pack200 functionality has been removed in JDK 14 (https://openjdk.org/jeps/367). I therefore propose to fix this in jdk11u-dev first and then downport the fix to jdk8u-dev as well. > ? Volker Simonis has updated the pull request incrementally with one additional commit since the last revision: Make sure we don't unnecessarily create and free the native unpacker if NativeUnpack::finish() is called more than once ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2100/files - new: https://git.openjdk.org/jdk11u-dev/pull/2100/files/d27b82ae..1cf8f356 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2100&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2100&range=01-02 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2100.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2100/head:pull/2100 PR: https://git.openjdk.org/jdk11u-dev/pull/2100 From simonis at openjdk.org Tue Aug 29 18:43:21 2023 From: simonis at openjdk.org (Volker Simonis) Date: Tue, 29 Aug 2023 18:43:21 GMT Subject: [jdk11u-dev] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() [v2] In-Reply-To: References: Message-ID: On Tue, 29 Aug 2023 14:44:24 GMT, Thomas Stuefe wrote: >> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision: >> >> Fixed indentation in test > > src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java line 123: > >> 121: // Free up native memory and JNI handles to prevent leaks >> 122: ((NativeUnpack) _nunp).finish(); >> 123: } > > What happens if `NativeUnpack` already called `finish()`? In case an error happened in the window after it calling `finish()` and it returning? Would that be harmless? The normal control flow if no error happens is that `NativeUnpack::run()` calls `NativeUnpack::finish()` before returning to its caller `UnpackerImpl::unpack()`. You are right that with these changes `NativeUnpack::finish()` will now be called two times in the case of successful unpacking. That's not a problem, because `NativeUnpack::finish()` is implemented as follows: JNIEXPORT jlong JNICALL Java_com_sun_java_util_jar_pack_NativeUnpack_finish(JNIEnv *env, jobject pObj) { unpacker* uPtr = get_unpacker(env, pObj, false); CHECK_EXCEPTION_RETURN_VALUE(uPtr, 0); size_t consumed = uPtr->input_consumed(); free_unpacker(env, pObj, uPtr); return consumed; } and `get_unpacker(env, pObj, false)` will always return a valid pointer to a `unpacker` object (or throw an exception). That's controlled by the third argument, which basically instructs `get_unpacker()` to create a new `unpacker` object if the current one is NULL. `free_unpacker(env, pObj, uPtr)` in a subsequent line will than release all the `unpacker`'s native memory and set the unpacker field (i.e. `NativeUnpack::unpackerPtr`) to NULL. So while calling `NativeUnpack::finish()` repeatedly is correct, it is unnecessarily expensive because we may create a new native `unpacker` object in `Java_com_sun_java_util_jar_pack_NativeUnpack_finish()` just to delete it right afterwards. I've therefore changed `Java_com_sun_java_util_jar_pack_NativeUnpack_finish()` as follows: JNIEXPORT jlong JNICALL Java_com_sun_java_util_jar_pack_NativeUnpack_finish(JNIEnv *env, jobject pObj) { // There's no need to create a new unpacker here if we don't already have one // just to immediatly free it afterwards. unpacker* uPtr = get_unpacker(env, pObj, /* noCreate= */ true); CHECK_EXCEPTION_RETURN_VALUE(uPtr, 0); size_t consumed = uPtr->input_consumed(); // free_unpacker() will set the unpacker field on 'pObj' to null free_unpacker(env, pObj, uPtr); return consumed; } Now, if we call `get_unpacker()` with the third argument set to `true`, `get_unpacker()` will not create a new `unpacker` object any more if the `NativeUnpack::unpackerPtr` is already NULL. The subsequent `CHECK_EXCEPTION_RETURN_VALUE` will check for a NULL return value and simple return from `Java_com_sun_java_util_jar_pack_NativeUnpack_finish()`. PS: the third, boolean argument `noCreate` of `get_unpacker()` is a default argument with the default value being `false`. All other call sites of `get_unpacker()` use this default, only the call from `Java_com_sun_java_util_jar_pack_NativeUnpack_finish()` explicitly adds the third argument as `false` which is already the default anyway. I strongly suspect that should have been `true` from the very beginning, because it makes no sense to create a new `unpacker` object just to delete it again a few lines later. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2100#discussion_r1309215728 From stuefe at openjdk.org Tue Aug 29 19:47:24 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 29 Aug 2023 19:47:24 GMT Subject: [jdk11u-dev] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() [v3] In-Reply-To: References: Message-ID: On Tue, 29 Aug 2023 18:18:47 GMT, Volker Simonis wrote: >> This issue was found by Yakov Shafranovich (yakovsh at amazon.com) who also provided the reproducer and proposed a fix. >> >> The native implementation of the `Pack200.Unpacker` class included in OpenJDK 8 and 11 has a native and heap memory leak that gets triggered when corrupted files are processed. If the native `NativeUnpack::start()` method throws an exception (because of a corrupted input file) its caller `NativeUnpack::run()` fails to call the native `NativeUnpack::finish()` method which is responsible for freeing the allocated native memory and releasing the created ?global JNI handles?. A Java application processing large number of malformed Pack200 files will eventually run either out of native memory or out of heap space and exit with an `OutOfMemoryError`. >> >> The problem can be demonstrated with the following short test program which will exit with an `OutOfMemoryError` quite quickly if run with `java -Xmx32m NativePack200POC`: >> >> >> import java.io.*; >> import java.util.jar.*; >> >> @SuppressWarnings("removal") >> public class NativePack200POC { >> public static void main(String[] args) { >> try { >> ByteArrayInputStream in = new ByteArrayInputStream("foobar".getBytes()); >> for(int i=0; i < 1_000_000; i++) { >> try { >> JarOutputStream out = new JarOutputStream(new ByteArrayOutputStream()); >> Pack200.Unpacker unpacker = Pack200.newUnpacker(); >> unpacker.unpack(in, out); >> } catch (IOException e) { >> } >> } >> } catch (OutOfMemoryError e) { >> System.out.println(e); >> throw e; >> } >> } >> } >> >> >> The problem can be worked around by disabling the native Pack200 implementation with `-Dcom.sun.java.util.jar.pack.disable.native=true` but the default setting is `-Dcom.sun.java.util.jar.pack.disable.native=false`. >> >> Notice that this bug can not be fixed in HEAD because the Pack200 functionality has been removed in JDK 14 (https://openjdk.org/jeps/367). I therefore propose to fix this in jdk11u-dev first and then downport the fix to jdk8u-dev as well. >> ? > > Volker Simonis has updated the pull request incrementally with one additional commit since the last revision: > > Make sure we don't unnecessarily create and free the native unpacker if NativeUnpack::finish() is called more than once Looks good, Volker. I agree, passing `false` as value to noCreate seems odd. But a default parameter as negation in itself is odd. ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2100#pullrequestreview-1601161520 From stuefe at openjdk.org Tue Aug 29 19:47:25 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 29 Aug 2023 19:47:25 GMT Subject: [jdk11u-dev] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() [v2] In-Reply-To: References: Message-ID: On Tue, 29 Aug 2023 18:40:23 GMT, Volker Simonis wrote: >> src/java.base/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java line 123: >> >>> 121: // Free up native memory and JNI handles to prevent leaks >>> 122: ((NativeUnpack) _nunp).finish(); >>> 123: } >> >> What happens if `NativeUnpack` already called `finish()`? In case an error happened in the window after it calling `finish()` and it returning? Would that be harmless? > > The normal control flow if no error happens is that `NativeUnpack::run()` calls `NativeUnpack::finish()` before returning to its caller `UnpackerImpl::unpack()`. You are right that with these changes `NativeUnpack::finish()` will now be called two times in the case of successful unpacking. That's not a problem, because `NativeUnpack::finish()` is implemented as follows: > > JNIEXPORT jlong JNICALL > Java_com_sun_java_util_jar_pack_NativeUnpack_finish(JNIEnv *env, jobject pObj) { > unpacker* uPtr = get_unpacker(env, pObj, false); > CHECK_EXCEPTION_RETURN_VALUE(uPtr, 0); > size_t consumed = uPtr->input_consumed(); > free_unpacker(env, pObj, uPtr); > return consumed; > } > > and `get_unpacker(env, pObj, false)` will always return a valid pointer to a `unpacker` object (or throw an exception). That's controlled by the third argument, which basically instructs `get_unpacker()` to create a new `unpacker` object if the current one is NULL. `free_unpacker(env, pObj, uPtr)` in a subsequent line will than release all the `unpacker`'s native memory and set the unpacker field (i.e. `NativeUnpack::unpackerPtr`) to NULL. > > So while calling `NativeUnpack::finish()` repeatedly is correct, it is unnecessarily expensive because we may create a new native `unpacker` object in `Java_com_sun_java_util_jar_pack_NativeUnpack_finish()` just to delete it right afterwards. I've therefore changed `Java_com_sun_java_util_jar_pack_NativeUnpack_finish()` as follows: > > JNIEXPORT jlong JNICALL > Java_com_sun_java_util_jar_pack_NativeUnpack_finish(JNIEnv *env, jobject pObj) { > // There's no need to create a new unpacker here if we don't already have one > // just to immediatly free it afterwards. > unpacker* uPtr = get_unpacker(env, pObj, /* noCreate= */ true); > CHECK_EXCEPTION_RETURN_VALUE(uPtr, 0); > size_t consumed = uPtr->input_consumed(); > // free_unpacker() will set the unpacker field on 'pObj' to null > free_unpacker(env, pObj, uPtr); > return consumed; > } > > Now, if we call `get_unpacker()` with the third argument set to `true`, `get_unpacker()` will not create a new `unpacker` object any more if the `NativeUnpack::unpackerPtr` is already NULL. The subsequent `CHECK_EXCEPTION_RETURN_VALUE` will check for a NULL return value and simple return from `Java_com_sun_java_util_jar_pack_NativeUnpack_finish()`. > > PS: the third, boolean argument `noCreate` of `get_unpacker()` is a default argument with the default value being `false`. All other call sites of `get_unpacker()` use this default, only the cal... Nice, thanks. I double-checked `CHECK_EXCEPTION_RETURN_VALUE` to make sure it really checks also for null and not only for `env->ExceptionOccurred`. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2100#discussion_r1309280278 From phh at openjdk.org Tue Aug 29 19:51:21 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 29 Aug 2023 19:51:21 GMT Subject: [jdk11u-dev] RFR: 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly In-Reply-To: <_fb5LpoXaOQLGklnwPfOsrl1iwoCsKWZzRL8P8fBoLU=.c49d71bd-6267-447a-932d-2c5123894405@github.com> References: <_fb5LpoXaOQLGklnwPfOsrl1iwoCsKWZzRL8P8fBoLU=.c49d71bd-6267-447a-932d-2c5123894405@github.com> Message-ID: <0-1H4aLIMCxI1lYyarPUxRkK7HHJAecO6ZoqsAwZ0MU=.27c768ca-770e-4fc6-80db-e2b8903bcb1b@github.com> On Fri, 18 Aug 2023 21:18:19 GMT, Andrei Pangin wrote: > Please consider the proposed backport of the fix for JDK-8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly. > > Customers complain about unexpected `java.net.SocketTimeoutException` when profiling an application running on JDK 11.0.20. > > The original patch applies cleanly with a trivial adjustment in `make/common/TestFilesCompilation.gmk`, where `$$` has been replaced with `$`. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2089#pullrequestreview-1601167918 From phh at openjdk.org Tue Aug 29 19:55:25 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 29 Aug 2023 19:55:25 GMT Subject: [jdk11u-dev] RFR: 8305733: Pattern.CASE_INSENSITIVE does not take effect in jdk11 [v8] In-Reply-To: <1sUDqiq5xvGYKV4oSKrDYmgMFPhIP8Xoev4EHh9kZBk=.cda226c7-3867-47f2-a440-050ec193e568@github.com> References: <1sUDqiq5xvGYKV4oSKrDYmgMFPhIP8Xoev4EHh9kZBk=.cda226c7-3867-47f2-a440-050ec193e568@github.com> Message-ID: On Mon, 21 Aug 2023 14:34:03 GMT, Korov wrote: >> @Korov, what testing have you done, and what do you estimate the risk is? > >> @Korov, what testing have you done, and what do you estimate the risk is? > > Here we test whether the matching of Posix character, Unicode character, Unicode categories, aliases, properties, and java methods is correct under the condition of ignoring case. > > Currently considered no risk. @Korov, please post a fix request comment for the JBS issue outlining risk and testing. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2062#issuecomment-1698041534 From serb at openjdk.org Tue Aug 29 22:55:19 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 29 Aug 2023 22:55:19 GMT Subject: [jdk17u-dev] RFR: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException [v2] In-Reply-To: References: <0_hQsbIsBS017P0OMQYHSPnIh8j8voomW4uZvAMkiH0=.0b3b5361-76b5-4ca8-8317-c14a3cfed7de@github.com> Message-ID: On Tue, 29 Aug 2023 12:36:16 GMT, Goetz Lindenmaier wrote: >what is wrong with the pre submit tests? That tasks failed to start due to timeout, seems too many tasks were submitted at that moment. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1689#issuecomment-1698246438 From shade at openjdk.org Wed Aug 30 05:48:21 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 05:48:21 GMT Subject: [jdk17u-dev] Integrated: 8314020: Print instruction blocks in byte units In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 07:01:44 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve post-mortem diagnostics. > > Two conflicts: > - In `os.hpp` we have a contextual differences due to Loom integration, applied the hunk by hand > - In `os_linux_zero.cpp`, the contextual difference due to missing [JDK-8294211](https://bugs.openjdk.org/browse/JDK-8294211), which I do not want to backport yet; skipped the hunk > > Additional testing: > - [x] Eyeballing the artificial crash This pull request has now been integrated. Changeset: f09ba799 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/f09ba7996581df64cc194b80a50f0da6b50c5636 Stats: 11 lines in 11 files changed: 0 ins; 0 del; 11 mod 8314020: Print instruction blocks in byte units Reviewed-by: phh Backport-of: a602624ef46908456052146d50467c60efa636c3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1686 From shade at openjdk.org Wed Aug 30 05:58:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 05:58:28 GMT Subject: [jdk17u-dev] Integrated: 8313262: C2: Sinking node may cause required cast to be dropped In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 08:25:40 GMT, Aleksey Shipilev wrote: > Clean backport to fix recent JDK 17 backport regression. > > Additional testing: > - [x] New test fails without the fix, passes with it > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` This pull request has now been integrated. Changeset: 25efeccb Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/25efeccb05bc747aafafb45b0b6910103a53b2b9 Stats: 69 lines in 2 files changed: 68 ins; 0 del; 1 mod 8313262: C2: Sinking node may cause required cast to be dropped Backport-of: 1cee3b9fd9720e7938029a6992460b9053e65e57 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1690 From shade at openjdk.org Wed Aug 30 05:59:11 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 05:59:11 GMT Subject: [jdk21u] RFR: 8313262: C2: Sinking node may cause required cast to be dropped [v3] In-Reply-To: References: <5J-am32LvigQiSpQYcW6rJ5xcue_Ot6iwZsvB1gcdCI=.02554307-cec8-487d-ab46-6d205247205a@github.com> Message-ID: On Fri, 25 Aug 2023 17:50:43 GMT, Aleksey Shipilev wrote: >> Clean backport to fix recent JDK 21 backport regression. >> >> Additional testing: >> - [x] New test fails without the fix, passes with it >> - [x] Linux x86_64 AArch64 `tier1 tier2 tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into JDK-8313262-c2-sinking-node-cast > - Merge branch 'master' into JDK-8313262-c2-sinking-node-cast > - Backport 1cee3b9fd9720e7938029a6992460b9053e65e57 Patch is clean. Testing is passing. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/99#issuecomment-1698535974 From shade at openjdk.org Wed Aug 30 05:59:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 05:59:13 GMT Subject: [jdk21u] Integrated: 8313262: C2: Sinking node may cause required cast to be dropped In-Reply-To: <5J-am32LvigQiSpQYcW6rJ5xcue_Ot6iwZsvB1gcdCI=.02554307-cec8-487d-ab46-6d205247205a@github.com> References: <5J-am32LvigQiSpQYcW6rJ5xcue_Ot6iwZsvB1gcdCI=.02554307-cec8-487d-ab46-6d205247205a@github.com> Message-ID: <43WJ93C1tkGhGBnbMTPO0a7ceXN_nEkbI63e9QJ2sPU=.d21e215b-4cf4-4227-96cf-9e2617223fac@github.com> On Thu, 24 Aug 2023 07:13:09 GMT, Aleksey Shipilev wrote: > Clean backport to fix recent JDK 21 backport regression. > > Additional testing: > - [x] New test fails without the fix, passes with it > - [x] Linux x86_64 AArch64 `tier1 tier2 tier3` This pull request has now been integrated. Changeset: 511224ac Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/511224ac142d54cda13571aa13956ccb80f90b67 Stats: 69 lines in 2 files changed: 68 ins; 0 del; 1 mod 8313262: C2: Sinking node may cause required cast to be dropped Backport-of: 1cee3b9fd9720e7938029a6992460b9053e65e57 ------------- PR: https://git.openjdk.org/jdk21u/pull/99 From shade at openjdk.org Wed Aug 30 05:58:26 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 05:58:26 GMT Subject: [jdk17u-dev] RFR: 8313262: C2: Sinking node may cause required cast to be dropped [v2] In-Reply-To: References: Message-ID: <3hhtey9cvJdOcYqpOOjrxEKLnRTSyBhMQQRxXG4kqKk=.fcbf2950-1b2a-4a9b-a892-63b5a4977700@github.com> On Fri, 25 Aug 2023 06:56:10 GMT, Aleksey Shipilev wrote: >> Clean backport to fix recent JDK 17 backport regression. >> >> Additional testing: >> - [x] New test fails without the fix, passes with it >> - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8313262-c2-sinking-node > - Backport 1cee3b9fd9720e7938029a6992460b9053e65e57 Patch is clean. Testing is passing. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1690#issuecomment-1698535741 From shade at openjdk.org Wed Aug 30 05:48:21 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 05:48:21 GMT Subject: [jdk17u-dev] RFR: 8314020: Print instruction blocks in byte units In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 07:01:44 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve post-mortem diagnostics. > > Two conflicts: > - In `os.hpp` we have a contextual differences due to Loom integration, applied the hunk by hand > - In `os_linux_zero.cpp`, the contextual difference due to missing [JDK-8294211](https://bugs.openjdk.org/browse/JDK-8294211), which I do not want to backport yet; skipped the hunk > > Additional testing: > - [x] Eyeballing the artificial crash Testing is clean. Review is here. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1686#issuecomment-1698528635 From goetz at openjdk.org Wed Aug 30 08:00:27 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 30 Aug 2023 08:00:27 GMT Subject: [jdk17u-dev] Integrated: 8312974: Bump update version for OpenJDK: jdk-17.0.10 In-Reply-To: References: Message-ID: <9CnEPkJkyQ1MGJrYsVt0jUlNXcflJE6XBxrkTq1ZD58=.652c9714-87f1-4e79-9569-bd6eebd502d9@github.com> On Tue, 25 Jul 2023 14:52:03 GMT, Goetz Lindenmaier wrote: > The usual updates. To be pushed after tag 17.0.10+0 This pull request has now been integrated. Changeset: a64639f4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/a64639f4f9462c97980ae9a1e315272c1470d4b8 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8312974: Bump update version for OpenJDK: jdk-17.0.10 Reviewed-by: shade ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1623 From duke at openjdk.org Wed Aug 30 08:00:32 2023 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 30 Aug 2023 08:00:32 GMT Subject: [jdk11u-dev] Integrated: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java In-Reply-To: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> References: <-4nzTLRmmHUp1ZMYjyOc-6O4d7oUswjKD90pCz2Hq_g=.89de53be-bfb1-44c5-914e-e144e62338fc@github.com> Message-ID: On Thu, 10 Aug 2023 08:49:01 GMT, Taizo Kurashige wrote: > I`d like to fix the bug reported in JDK-8314086. > `{` is missing in ChildAlwaysOnTopTest.java as suggested in the issue. > This is causing compilation failure in ChildAlwaysOnTopTest.java. > After fixing this typo, the test successfully passed. This pull request has now been integrated. Changeset: 39986e07 Author: Taizo Kurashige Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/39986e07ed1d3da86eeedad8feb5adddfb672c24 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2074 From goetz at openjdk.org Wed Aug 30 08:14:17 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 30 Aug 2023 08:14:17 GMT Subject: [jdk11u-dev] Integrated: 8312972: Bump update version for OpenJDK: jdk-11.0.22 In-Reply-To: References: Message-ID: On Tue, 25 Jul 2023 15:05:43 GMT, Goetz Lindenmaier wrote: > The required version bump, to be pushed after tag 11.0.22+0. This pull request has now been integrated. Changeset: c86ba43b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/c86ba43b8e880e0415f6732b19306568f3a10bdc Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8312972: Bump update version for OpenJDK: jdk-11.0.22 Reviewed-by: serb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2056 From shade at openjdk.org Wed Aug 30 08:16:17 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 08:16:17 GMT Subject: [jdk11u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 [v2] In-Reply-To: References: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> Message-ID: On Tue, 29 Aug 2023 05:12:01 GMT, Christoph Langer wrote: > Looks good, thanks for the effort. Please add approval labels. Thanks! I think I marked all mentioned issues now. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2090#issuecomment-1698702466 From shade at openjdk.org Wed Aug 30 08:36:55 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 08:36:55 GMT Subject: [jdk21u] RFR: 8314656: GHA: No need for Debian ports keyring installation after JDK-8313701 Message-ID: Clean backport to maintain clean undiverged GHA between releases. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 76b9011c9ecb8c0c713a58d034f281ba70d65d4e Changes: https://git.openjdk.org/jdk21u/pull/118/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=118&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314656 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/118.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/118/head:pull/118 PR: https://git.openjdk.org/jdk21u/pull/118 From shade at openjdk.org Wed Aug 30 08:49:31 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 08:49:31 GMT Subject: [jdk11u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04 [v2] In-Reply-To: References: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> Message-ID: On Tue, 22 Aug 2023 07:49:08 GMT, Aleksey Shipilev wrote: >> This similar to the bulk GHA update we did here: https://github.com/shipilev/jdk17u-dev/commit/260f28761a87553fd634615df5ba3db5b76ae692 -- but now for 11u. >> >> Note this reverts and then reapplies [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772) to avoid backport conflicts. >> >> There are other GHA improvements we would backport later. This one atomic PR brings in 11u GHA closer to mainline GHA state without breaking the builds. For reference, after this PR, the 11u-vs-mainline GHA diff would be this: [gha-11u-vs-mainline.patch](https://github.com/openjdk/jdk11u-dev/files/12395257/gha-11u-vs-mainline.patch) > > Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: > > Reapply JDK-8284772: GHA: Use GCC Major Version Dependencies Only Got the push approval for all issues now. Integrating to make GHA more reliable. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2090#issuecomment-1698750963 From shade at openjdk.org Wed Aug 30 08:49:32 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 08:49:32 GMT Subject: [jdk11u-dev] Integrated: 8293107: GHA: Bump to Ubuntu 22.04 In-Reply-To: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> References: <9Mn2EBXcEKuLQ9SX-nZ-LonG_cfUnNlwEbXSwFNm2aU=.95e410f0-28ec-4f0a-8b22-72ac2ecb142b@github.com> Message-ID: On Mon, 21 Aug 2023 10:56:18 GMT, Aleksey Shipilev wrote: > This similar to the bulk GHA update we did here: https://github.com/shipilev/jdk17u-dev/commit/260f28761a87553fd634615df5ba3db5b76ae692 -- but now for 11u. > > Note this reverts and then reapplies [JDK-8284772](https://bugs.openjdk.org/browse/JDK-8284772) to avoid backport conflicts. > > There are other GHA improvements we would backport later. This one atomic PR brings in 11u GHA closer to mainline GHA state without breaking the builds. For reference, after this PR, the 11u-vs-mainline GHA diff would be this: [gha-11u-vs-mainline.patch](https://github.com/openjdk/jdk11u-dev/files/12395257/gha-11u-vs-mainline.patch) This pull request has now been integrated. Changeset: b984b0a2 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/b984b0a2937ad612697586d4f90e18dbc22d2571 Stats: 101 lines in 5 files changed: 75 ins; 1 del; 25 mod 8293107: GHA: Bump to Ubuntu 22.04 8293098: GHA: Harmonize GCC version handling for host and cross builds 8293361: GHA: dump config.log in case of configure failure 8295213: Run GHA manually with user-specified make and configure arguments 8295885: GHA: Bump gcc versions 8313428: GHA: Bump GCC versions for July 2023 updates Reviewed-by: clanger Backport-of: d7536588b38e368eaa6395bcbcc6724a39303fc5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2090 From shade at openjdk.org Wed Aug 30 08:55:19 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 08:55:19 GMT Subject: [jdk17u-dev] RFR: 8292717: Clean up checking of testing requirements in configure In-Reply-To: References: Message-ID: <-MMtkEPh5480Tjo6Kgm00Ufedvdiihl91nbO-xY1YV8=.c59a7a58-3eab-44b9-851e-7936fa8c96d3@github.com> On Thu, 24 Aug 2023 14:38:38 GMT, Aleksey Shipilev wrote: > Prepares build system for cleaner googletest and jtreg dependency updates. After this, at least googletest update applies only with minor conflicts. I expect jtreg updates would be smoother too. > > Current backport does not apply cleanly, because prior backports are in the way. So I did this PR by reverting JDK-8292716 and JDK-8292763 fixes, applying this move cleanly, and then reapplying the first two cleanly. Therefore both JDK-8292716 and JDK-8292763 still effectively remain in 17u-dev. See commit history for individual commits. This also makes sure we do not miss anything in backports. > > @GoeLin, you might want to take a look. > > Additional testing: > - [x] GHA Review is here. Push approval is granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1693#issuecomment-1698757661 From shade at openjdk.org Wed Aug 30 08:55:20 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 08:55:20 GMT Subject: [jdk17u-dev] Integrated: 8292717: Clean up checking of testing requirements in configure In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 14:38:38 GMT, Aleksey Shipilev wrote: > Prepares build system for cleaner googletest and jtreg dependency updates. After this, at least googletest update applies only with minor conflicts. I expect jtreg updates would be smoother too. > > Current backport does not apply cleanly, because prior backports are in the way. So I did this PR by reverting JDK-8292716 and JDK-8292763 fixes, applying this move cleanly, and then reapplying the first two cleanly. Therefore both JDK-8292716 and JDK-8292763 still effectively remain in 17u-dev. See commit history for individual commits. This also makes sure we do not miss anything in backports. > > @GoeLin, you might want to take a look. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 0bc4e7ec Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/0bc4e7ec7c6b03000e8d0fb6238d9c6b68d85014 Stats: 348 lines in 4 files changed: 174 ins; 172 del; 2 mod 8292717: Clean up checking of testing requirements in configure Reviewed-by: clanger Backport-of: 16593cf51c3d994ba4a6d28ab97e519dfd53f37b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1693 From stuefe at openjdk.org Wed Aug 30 09:15:27 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 09:15:27 GMT Subject: [jdk17u-dev] RFR: 8310233: Fix THP detection on Linux In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 10:55:00 GMT, Thomas Stuefe wrote: > *Note: not for October CPU* > > Unclean backport. Needed as a prerequisite to fix [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182). > > No factual differences exist; merge failed due to surrounding hunks being different (NULL->nullptr). Got commit approval, tests are green. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1694#issuecomment-1698793936 From stuefe at openjdk.org Wed Aug 30 09:15:30 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 09:15:30 GMT Subject: [jdk17u-dev] Integrated: 8310233: Fix THP detection on Linux In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 10:55:00 GMT, Thomas Stuefe wrote: > *Note: not for October CPU* > > Unclean backport. Needed as a prerequisite to fix [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182). > > No factual differences exist; merge failed due to surrounding hunks being different (NULL->nullptr). This pull request has now been integrated. Changeset: 36817195 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk17u-dev/commit/36817195e41e2c216cf9ed7641a1081b9b49ac23 Stats: 815 lines in 7 files changed: 684 ins; 99 del; 32 mod 8310233: Fix THP detection on Linux Reviewed-by: phh Backport-of: 37ca9024ef59d99cae0bd7e25b2e6d3c1e085f97 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1694 From stuefe at openjdk.org Wed Aug 30 09:21:32 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 09:21:32 GMT Subject: [jdk17u-dev] RFR: 8312394: [linux] SIGSEGV if kernel was built without hugepage support Message-ID: Clean backport (based on https://github.com/openjdk/jdk17u-dev/pull/1694). Fixes a crash post-8310233 on obscure Linux kernels (compiled without huge page support, typically for SBCs). We saw it on arm32 on Raspian OS. ------------- Commit messages: - Backport 94eb44b192ba421692549a178c386ea34164ea50 Changes: https://git.openjdk.org/jdk17u-dev/pull/1695/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1695&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312394 Stats: 22 lines in 1 file changed: 6 ins; 2 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1695.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1695/head:pull/1695 PR: https://git.openjdk.org/jdk17u-dev/pull/1695 From stuefe at openjdk.org Wed Aug 30 09:26:32 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 09:26:32 GMT Subject: [jdk17u-dev] RFR: 8312620: WSL Linux build crashes after JDK-8310233 Message-ID: Clean backport (based on https://github.com/openjdk/jdk17u-dev/pull/1695), fixes an issue where the build on Windows WSL was failing post-8310233. ------------- Commit messages: - Backport 25058cd23ac9c8993e7acfd82728ee4c623f0914 - Backport 94eb44b192ba421692549a178c386ea34164ea50 Changes: https://git.openjdk.org/jdk17u-dev/pull/1696/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1696&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312620 Stats: 40 lines in 3 files changed: 20 ins; 2 del; 18 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1696.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1696/head:pull/1696 PR: https://git.openjdk.org/jdk17u-dev/pull/1696 From shade at openjdk.org Wed Aug 30 09:26:45 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 09:26:45 GMT Subject: [jdk17u-dev] RFR: 8295229: Try to verify gtest version Message-ID: Clean backport on the way to cleanly backport gtest updates. Additional testing: - [x] Configure works with gtest 1.8.1 locally - [ ] GHA (implicitly tests current gtest works) ------------- Commit messages: - Backport cd1357b0af0d4e3b459fcf88e67510502464bb90 Changes: https://git.openjdk.org/jdk17u-dev/pull/1708/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1708&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295229 Stats: 23 lines in 3 files changed: 22 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1708.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1708/head:pull/1708 PR: https://git.openjdk.org/jdk17u-dev/pull/1708 From stuefe at openjdk.org Wed Aug 30 09:38:47 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 09:38:47 GMT Subject: [jdk17u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue Message-ID: Clean backport. Fixes a serious issue that may cause huge RSS bloat and thread start performance degradation. ------------- Commit messages: - Backport 84b325b844c08809448a9c073a11443d9e3c3f8e Changes: https://git.openjdk.org/jdk17u-dev/pull/1697/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1697&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312182 Stats: 301 lines in 3 files changed: 294 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1697.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1697/head:pull/1697 PR: https://git.openjdk.org/jdk17u-dev/pull/1697 From clanger at openjdk.org Wed Aug 30 09:53:16 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 30 Aug 2023 09:53:16 GMT Subject: [jdk11u-dev] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() [v3] In-Reply-To: References: Message-ID: On Tue, 29 Aug 2023 18:18:47 GMT, Volker Simonis wrote: >> This issue was found by Yakov Shafranovich (yakovsh at amazon.com) who also provided the reproducer and proposed a fix. >> >> The native implementation of the `Pack200.Unpacker` class included in OpenJDK 8 and 11 has a native and heap memory leak that gets triggered when corrupted files are processed. If the native `NativeUnpack::start()` method throws an exception (because of a corrupted input file) its caller `NativeUnpack::run()` fails to call the native `NativeUnpack::finish()` method which is responsible for freeing the allocated native memory and releasing the created ?global JNI handles?. A Java application processing large number of malformed Pack200 files will eventually run either out of native memory or out of heap space and exit with an `OutOfMemoryError`. >> >> The problem can be demonstrated with the following short test program which will exit with an `OutOfMemoryError` quite quickly if run with `java -Xmx32m NativePack200POC`: >> >> >> import java.io.*; >> import java.util.jar.*; >> >> @SuppressWarnings("removal") >> public class NativePack200POC { >> public static void main(String[] args) { >> try { >> ByteArrayInputStream in = new ByteArrayInputStream("foobar".getBytes()); >> for(int i=0; i < 1_000_000; i++) { >> try { >> JarOutputStream out = new JarOutputStream(new ByteArrayOutputStream()); >> Pack200.Unpacker unpacker = Pack200.newUnpacker(); >> unpacker.unpack(in, out); >> } catch (IOException e) { >> } >> } >> } catch (OutOfMemoryError e) { >> System.out.println(e); >> throw e; >> } >> } >> } >> >> >> The problem can be worked around by disabling the native Pack200 implementation with `-Dcom.sun.java.util.jar.pack.disable.native=true` but the default setting is `-Dcom.sun.java.util.jar.pack.disable.native=false`. >> >> Notice that this bug can not be fixed in HEAD because the Pack200 functionality has been removed in JDK 14 (https://openjdk.org/jeps/367). I therefore propose to fix this in jdk11u-dev first and then downport the fix to jdk8u-dev as well. >> ? > > Volker Simonis has updated the pull request incrementally with one additional commit since the last revision: > > Make sure we don't unnecessarily create and free the native unpacker if NativeUnpack::finish() is called more than once Marked as reviewed by clanger (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2100#pullrequestreview-1602332394 From shade at openjdk.org Wed Aug 30 09:57:42 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 09:57:42 GMT Subject: [jdk11u-dev] RFR: 8299330: Minor improvements in MSYS2 Workflow handling Message-ID: <_gm9dIdBG2C_f0-kM3GzMYuB52cXQ31za8jy68dmIuE=.b9d1465e-9677-4c58-813c-bd69a33c9266@github.com> Clean backport to improve GHA reliability. Additional testing: - [ ] GHA ------------- Commit messages: - Backport cf00d09c8c37ee301e1c6657df45777647a834e9 Changes: https://git.openjdk.org/jdk11u-dev/pull/2103/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2103&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299330 Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2103.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2103/head:pull/2103 PR: https://git.openjdk.org/jdk11u-dev/pull/2103 From shade at openjdk.org Wed Aug 30 09:59:40 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 09:59:40 GMT Subject: [jdk11u-dev] RFR: 8304353: Add lib-test tier1 testing in GHA Message-ID: Clean backport to improve 11u GHA coverage. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 57276101df79f07b14b914b36b1155cedec3eb3d Changes: https://git.openjdk.org/jdk11u-dev/pull/2104/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2104&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304353 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2104.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2104/head:pull/2104 PR: https://git.openjdk.org/jdk11u-dev/pull/2104 From shade at openjdk.org Wed Aug 30 10:02:44 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 10:02:44 GMT Subject: [jdk11u-dev] RFR: 8294941: GHA: Cut down cross-compilation sysroots Message-ID: Clean backport to improve 11u GHA overheads. It would be followed by another backport that would cut stuff even deeper: [JDK-8314262](https://bugs.openjdk.org/browse/JDK-8314262). Additional testing: - [ ] GHA ------------- Commit messages: - Backport a1747ef81a10e84177f474565193204ceaa0ede8 Changes: https://git.openjdk.org/jdk11u-dev/pull/2105/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2105&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294941 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2105.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2105/head:pull/2105 PR: https://git.openjdk.org/jdk11u-dev/pull/2105 From shade at openjdk.org Wed Aug 30 10:04:40 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 10:04:40 GMT Subject: [jdk11u-dev] RFR: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one Message-ID: Clean backport to further improve 11u GHA reliability. Additional testing: - [ ] GHA ------------- Commit messages: - Backport c5f462e83b85ec53ec395622063a5b131aaf0827 Changes: https://git.openjdk.org/jdk11u-dev/pull/2106/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2106&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294956 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2106.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2106/head:pull/2106 PR: https://git.openjdk.org/jdk11u-dev/pull/2106 From shade at openjdk.org Wed Aug 30 11:26:48 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 11:26:48 GMT Subject: [jdk17u-dev] RFR: 8313626: C2 crash due to unexpected exception control flow Message-ID: Clean backport to fix C2 issue. Additional testing: - [x] New test fails without the patch, passes with it - [ ] Linux ??? `tier1 tier2 tier3` ------------- Commit messages: - Backport f8203cb272e6136b784e5c43a500f6a0bfb19c8b Changes: https://git.openjdk.org/jdk17u-dev/pull/1709/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1709&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313626 Stats: 180 lines in 3 files changed: 180 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1709.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1709/head:pull/1709 PR: https://git.openjdk.org/jdk17u-dev/pull/1709 From shade at openjdk.org Wed Aug 30 12:02:05 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 12:02:05 GMT Subject: [jdk11u-dev] RFR: 8313626: C2 crash due to unexpected exception control flow Message-ID: Clean backport to fix C2 failure. Additional testing: - [ ] New test fails without the patch, passes with it - [ ] Linux ??? tier1 tier2 tier3 ------------- Commit messages: - Backport f8203cb272e6136b784e5c43a500f6a0bfb19c8b Changes: https://git.openjdk.org/jdk11u-dev/pull/2107/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2107&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313626 Stats: 180 lines in 3 files changed: 180 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2107.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2107/head:pull/2107 PR: https://git.openjdk.org/jdk11u-dev/pull/2107 From stuefe at openjdk.org Wed Aug 30 12:46:55 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 12:46:55 GMT Subject: [jdk21u] RFR: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation [v2] In-Reply-To: References: Message-ID: <2KlS_B5HE-EYIFY8LBxWvUBvIVLNluDKlFKLIWOFqvA=.cd54d360-e155-424f-8b7e-eed4febaad8a@github.com> > Clean backport. 8312182 introduced a mitigation for THP-related RSS bloat; it came with a switch to switch it off. We then decided to rename the switch. Since the switch should be the same across all releases, this needs to be backported too. Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into tstuefe-backport-226cdc69 - Merge branch 'openjdk:master' into tstuefe-backport-226cdc69 - Backport 226cdc696d933fbc174d07b0d9817246dbc0e06c - Backport 733250288325bc663afc0376342d4c5a7a471cbd ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/105/files - new: https://git.openjdk.org/jdk21u/pull/105/files/9367cbbb..ff51a268 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=105&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=105&range=00-01 Stats: 162 lines in 15 files changed: 131 ins; 14 del; 17 mod Patch: https://git.openjdk.org/jdk21u/pull/105.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/105/head:pull/105 PR: https://git.openjdk.org/jdk21u/pull/105 From aoqi at openjdk.org Wed Aug 30 12:48:16 2023 From: aoqi at openjdk.org (Ao Qi) Date: Wed, 30 Aug 2023 12:48:16 GMT Subject: [jdk21u] RFR: 8315020: The macro definition for LoongArch64 zero build is not accurate. In-Reply-To: References: Message-ID: <37kWWNJrTICA8TSsiNDMJEziPvs4Cc80KFqlsv6LABM=.fa60d480-6789-4177-8cc3-e6a206a62eed@github.com> On Mon, 28 Aug 2023 11:51:47 GMT, Ao Qi wrote: > Clean backport to fix the LoongArch64 zero build. This backport would be convenient for some OS distributions in the future, such as Debian. > > Additional testing: > > - [x] LoongArch Zero release and fastdebug build. Got the `jdk21u-fix-yes`. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/109#issuecomment-1699102467 From stuefe at openjdk.org Wed Aug 30 12:53:11 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 12:53:11 GMT Subject: [jdk21u] RFR: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation [v3] In-Reply-To: References: Message-ID: <5ML7ZKzdxZiFWIQTObUY6t5uRumn9p88ozHJdaLyVoA=.3f5ea3c8-2cba-49e6-8658-e0370fb3dbc4@github.com> > Clean backport. 8312182 introduced a mitigation for THP-related RSS bloat; it came with a switch to switch it off. We then decided to rename the switch. Since the switch should be the same across all releases, this needs to be backported too. Thomas Stuefe has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 226cdc696d933fbc174d07b0d9817246dbc0e06c ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/105/files - new: https://git.openjdk.org/jdk21u/pull/105/files/ff51a268..7734fa8d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=105&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=105&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/105.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/105/head:pull/105 PR: https://git.openjdk.org/jdk21u/pull/105 From mbaesken at openjdk.org Wed Aug 30 12:53:20 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 30 Aug 2023 12:53:20 GMT Subject: [jdk21u] RFR: 8313691: use close after failing os::fdopen in vmError and ciEnv In-Reply-To: <1sHKo3vU5Eb2U-OfQm0l9703pT2GxsMgsTcDZrK6abE=.69b79a02-0be5-47f5-bf34-cc4c27cfca06@github.com> References: <1sHKo3vU5Eb2U-OfQm0l9703pT2GxsMgsTcDZrK6abE=.69b79a02-0be5-47f5-bf34-cc4c27cfca06@github.com> Message-ID: On Mon, 28 Aug 2023 15:15:23 GMT, Matthias Baesken wrote: > 8313691: use close after failing os::fdopen in vmError and ciEnv tons of strange download errors in GHA , most likely unrelated . ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/113#issuecomment-1699107083 From mbaesken at openjdk.org Wed Aug 30 12:53:20 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 30 Aug 2023 12:53:20 GMT Subject: [jdk21u] Integrated: 8313691: use close after failing os::fdopen in vmError and ciEnv In-Reply-To: <1sHKo3vU5Eb2U-OfQm0l9703pT2GxsMgsTcDZrK6abE=.69b79a02-0be5-47f5-bf34-cc4c27cfca06@github.com> References: <1sHKo3vU5Eb2U-OfQm0l9703pT2GxsMgsTcDZrK6abE=.69b79a02-0be5-47f5-bf34-cc4c27cfca06@github.com> Message-ID: On Mon, 28 Aug 2023 15:15:23 GMT, Matthias Baesken wrote: > 8313691: use close after failing os::fdopen in vmError and ciEnv This pull request has now been integrated. Changeset: 071ec8d0 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u/commit/071ec8d04b7359e0694fd028c7157def1caa4dcc Stats: 3 lines in 2 files changed: 3 ins; 0 del; 0 mod 8313691: use close after failing os::fdopen in vmError and ciEnv Backport-of: 96304f37f8344b0c0e271ff9cda84961519d5109 ------------- PR: https://git.openjdk.org/jdk21u/pull/113 From simonis at openjdk.org Wed Aug 30 15:20:30 2023 From: simonis at openjdk.org (Volker Simonis) Date: Wed, 30 Aug 2023 15:20:30 GMT Subject: [jdk11u-dev] Integrated: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() In-Reply-To: References: Message-ID: On Mon, 28 Aug 2023 19:17:36 GMT, Volker Simonis wrote: > This issue was found by Yakov Shafranovich (yakovsh at amazon.com) who also provided the reproducer and proposed a fix. > > The native implementation of the `Pack200.Unpacker` class included in OpenJDK 8 and 11 has a native and heap memory leak that gets triggered when corrupted files are processed. If the native `NativeUnpack::start()` method throws an exception (because of a corrupted input file) its caller `NativeUnpack::run()` fails to call the native `NativeUnpack::finish()` method which is responsible for freeing the allocated native memory and releasing the created ?global JNI handles?. A Java application processing large number of malformed Pack200 files will eventually run either out of native memory or out of heap space and exit with an `OutOfMemoryError`. > > The problem can be demonstrated with the following short test program which will exit with an `OutOfMemoryError` quite quickly if run with `java -Xmx32m NativePack200POC`: > > > import java.io.*; > import java.util.jar.*; > > @SuppressWarnings("removal") > public class NativePack200POC { > public static void main(String[] args) { > try { > ByteArrayInputStream in = new ByteArrayInputStream("foobar".getBytes()); > for(int i=0; i < 1_000_000; i++) { > try { > JarOutputStream out = new JarOutputStream(new ByteArrayOutputStream()); > Pack200.Unpacker unpacker = Pack200.newUnpacker(); > unpacker.unpack(in, out); > } catch (IOException e) { > } > } > } catch (OutOfMemoryError e) { > System.out.println(e); > throw e; > } > } > } > > > The problem can be worked around by disabling the native Pack200 implementation with `-Dcom.sun.java.util.jar.pack.disable.native=true` but the default setting is `-Dcom.sun.java.util.jar.pack.disable.native=false`. > > Notice that this bug can not be fixed in HEAD because the Pack200 functionality has been removed in JDK 14 (https://openjdk.org/jeps/367). I therefore propose to fix this in jdk11u-dev first and then downport the fix to jdk8u-dev as well. > ? This pull request has now been integrated. Changeset: b77c161e Author: Volker Simonis URL: https://git.openjdk.org/jdk11u-dev/commit/b77c161e7509aa3b09ebf3e6b2b1490c0667bbdc Stats: 65 lines in 4 files changed: 63 ins; 0 del; 2 mod 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() Co-authored-by: Yakov Shafranovich Reviewed-by: clanger, stuefe ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2100 From apangin at openjdk.org Wed Aug 30 15:24:28 2023 From: apangin at openjdk.org (Andrei Pangin) Date: Wed, 30 Aug 2023 15:24:28 GMT Subject: [jdk11u-dev] Integrated: 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly In-Reply-To: <_fb5LpoXaOQLGklnwPfOsrl1iwoCsKWZzRL8P8fBoLU=.c49d71bd-6267-447a-932d-2c5123894405@github.com> References: <_fb5LpoXaOQLGklnwPfOsrl1iwoCsKWZzRL8P8fBoLU=.c49d71bd-6267-447a-932d-2c5123894405@github.com> Message-ID: On Fri, 18 Aug 2023 21:18:19 GMT, Andrei Pangin wrote: > Please consider the proposed backport of the fix for JDK-8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly. > > Customers complain about unexpected `java.net.SocketTimeoutException` when profiling an application running on JDK 11.0.20. > > The original patch applies cleanly with a trivial adjustment in `make/common/TestFilesCompilation.gmk`, where `$$` has been replaced with `$`. This pull request has now been integrated. Changeset: d76e6ea2 Author: Andrei Pangin Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/d76e6ea25e7b77cd28584a1e804e702f77176e8e Stats: 486 lines in 8 files changed: 462 ins; 6 del; 18 mod 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly PlainSocketImpl.socketAccept() handles EINTR incorrectly Reviewed-by: phh Backport-of: 955aee3bfa8cad8b60fd38fb472b431075eea9d0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2089 From shade at openjdk.org Wed Aug 30 16:00:38 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 16:00:38 GMT Subject: [jdk17u-dev] RFR: 8295229: Try to verify gtest version In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 09:18:28 GMT, Aleksey Shipilev wrote: > Clean backport on the way to cleanly backport gtest updates. > > Additional testing: > - [x] Configure works with gtest 1.8.1 locally > - [x] GHA (implicitly tests current gtest works) Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1708#issuecomment-1699440217 From shade at openjdk.org Wed Aug 30 16:00:38 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 16:00:38 GMT Subject: [jdk17u-dev] Integrated: 8295229: Try to verify gtest version In-Reply-To: References: Message-ID: <6gzkE57AsFsTg6tNxjPGNHELuOOItahjGof1tHolaRw=.37cf752c-94c8-48fc-be70-f5cbf83a8168@github.com> On Wed, 30 Aug 2023 09:18:28 GMT, Aleksey Shipilev wrote: > Clean backport on the way to cleanly backport gtest updates. > > Additional testing: > - [x] Configure works with gtest 1.8.1 locally > - [x] GHA (implicitly tests current gtest works) This pull request has now been integrated. Changeset: 0d4fbb46 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/0d4fbb460d8ed6bb2695cbaad8a345dfe4d6b005 Stats: 23 lines in 3 files changed: 22 ins; 0 del; 1 mod 8295229: Try to verify gtest version Backport-of: cd1357b0af0d4e3b459fcf88e67510502464bb90 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1708 From simonis at openjdk.org Wed Aug 30 16:13:33 2023 From: simonis at openjdk.org (Volker Simonis) Date: Wed, 30 Aug 2023 16:13:33 GMT Subject: [jdk11u] RFR: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() Message-ID: Hi all, This pull request contains a backport of commit [b77c161e](https://github.com/openjdk/jdk11u-dev/commit/b77c161e7509aa3b09ebf3e6b2b1490c0667bbdc) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. The commit being backported was authored by Volker Simonis on 30 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe. Thanks! ------------- Commit messages: - Backport b77c161e7509aa3b09ebf3e6b2b1490c0667bbdc Changes: https://git.openjdk.org/jdk11u/pull/79/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=79&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315135 Stats: 65 lines in 4 files changed: 63 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u/pull/79.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/79/head:pull/79 PR: https://git.openjdk.org/jdk11u/pull/79 From duke at openjdk.org Wed Aug 30 17:35:15 2023 From: duke at openjdk.org (Nibedita Jena) Date: Wed, 30 Aug 2023 17:35:15 GMT Subject: [jdk21u] Integrated: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar In-Reply-To: References: Message-ID: On Mon, 21 Aug 2023 11:40:22 GMT, Nibedita Jena wrote: > Clean backport of https://bugs.openjdk.org/browse/JDK-8312489 (e47a84f23dd2608c6f5748093eefe301fb5bf750) This pull request has now been integrated. Changeset: c7cff818 Author: nibjen Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u/commit/c7cff818b5c70b8634d8e0a7123c279df08a6551 Stats: 9 lines in 2 files changed: 2 ins; 0 del; 7 mod 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar Reviewed-by: hchao Backport-of: e47a84f23dd2608c6f5748093eefe301fb5bf750 ------------- PR: https://git.openjdk.org/jdk21u/pull/76 From shade at openjdk.org Wed Aug 30 17:46:19 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 30 Aug 2023 17:46:19 GMT Subject: [jdk17u-dev] RFR: 8286430: make test TEST="gtest:" exits with error when it shouldn't Message-ID: Clean backport to unblock update to gtest 1.13. Additional testing: - [ ] Linux AArch64 `gtest:all` with gtest 1.8.1 (still works) - [x] Linux AArch64 `gtest:all` with gtest 1.13 (with another PR enabling it, now works) ------------- Commit messages: - Backport 63a1ec6e7c08fc21d5cded734637eeb80147079f Changes: https://git.openjdk.org/jdk17u-dev/pull/1711/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1711&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286430 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1711.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1711/head:pull/1711 PR: https://git.openjdk.org/jdk17u-dev/pull/1711 From stuefe at openjdk.org Wed Aug 30 17:58:36 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 17:58:36 GMT Subject: [jdk17u-dev] RFR: 8312394: [linux] SIGSEGV if kernel was built without hugepage support In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 11:41:17 GMT, Thomas Stuefe wrote: > Clean backport (based on https://github.com/openjdk/jdk17u-dev/pull/1694). Fixes a crash post-8310233 on obscure Linux kernels (compiled without huge page support, typically for SBCs). We saw it on arm32 on Raspian OS. Tests clean apart from an unrelated windows test error, push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1695#issuecomment-1699610843 From stuefe at openjdk.org Wed Aug 30 17:58:50 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 17:58:50 GMT Subject: [jdk21u] RFR: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation [v4] In-Reply-To: References: Message-ID: > Clean backport. 8312182 introduced a mitigation for THP-related RSS bloat; it came with a switch to switch it off. We then decided to rename the switch. Since the switch should be the same across all releases, this needs to be backported too. Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into tstuefe-backport-226cdc69 - Backport 226cdc696d933fbc174d07b0d9817246dbc0e06c ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/105/files - new: https://git.openjdk.org/jdk21u/pull/105/files/7734fa8d..8ed050e7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=105&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=105&range=02-03 Stats: 12 lines in 4 files changed: 5 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u/pull/105.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/105/head:pull/105 PR: https://git.openjdk.org/jdk21u/pull/105 From stuefe at openjdk.org Wed Aug 30 18:02:32 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 18:02:32 GMT Subject: [jdk17u-dev] Integrated: 8312394: [linux] SIGSEGV if kernel was built without hugepage support In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 11:41:17 GMT, Thomas Stuefe wrote: > Clean backport (based on https://github.com/openjdk/jdk17u-dev/pull/1694). Fixes a crash post-8310233 on obscure Linux kernels (compiled without huge page support, typically for SBCs). We saw it on arm32 on Raspian OS. This pull request has now been integrated. Changeset: fbe3773a Author: Thomas Stuefe URL: https://git.openjdk.org/jdk17u-dev/commit/fbe3773a3256e1c663ba84cd0f5b67d0dcfc23c2 Stats: 22 lines in 1 file changed: 6 ins; 2 del; 14 mod 8312394: [linux] SIGSEGV if kernel was built without hugepage support Backport-of: 94eb44b192ba421692549a178c386ea34164ea50 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1695 From stuefe at openjdk.org Wed Aug 30 18:03:38 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 18:03:38 GMT Subject: [jdk17u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: <7gtK7uqHwultsRdnI4fGtK6VRfmjhBicspjC1q-omZ4=.21e42dd5-adcb-4bce-90b3-eb0f6df1902c@github.com> On Fri, 25 Aug 2023 11:57:30 GMT, Thomas Stuefe wrote: > Clean backport. Fixes a serious issue that may cause huge RSS bloat and thread start performance degradation. Tests clean, push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1697#issuecomment-1699613115 From stuefe at openjdk.org Wed Aug 30 18:03:39 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 18:03:39 GMT Subject: [jdk17u-dev] Integrated: 8312182: THPs cause huge RSS due to thread start timing issue In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 11:57:30 GMT, Thomas Stuefe wrote: > Clean backport. Fixes a serious issue that may cause huge RSS bloat and thread start performance degradation. This pull request has now been integrated. Changeset: e6b87a71 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk17u-dev/commit/e6b87a7116dffd6f065589edd2821f182b265fa6 Stats: 301 lines in 3 files changed: 294 ins; 0 del; 7 mod 8312182: THPs cause huge RSS due to thread start timing issue 8310687: JDK-8303215 is incomplete Backport-of: 84b325b844c08809448a9c073a11443d9e3c3f8e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1697 From stuefe at openjdk.org Wed Aug 30 18:29:14 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 18:29:14 GMT Subject: [jdk17u-dev] RFR: 8312620: WSL Linux build crashes after JDK-8310233 [v2] In-Reply-To: References: Message-ID: > Clean backport (based on https://github.com/openjdk/jdk17u-dev/pull/1695), fixes an issue where the build on Windows WSL was failing post-8310233. Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 25058cd23ac9c8993e7acfd82728ee4c623f0914 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/1696/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1696&range=01 Stats: 21 lines in 3 files changed: 14 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1696.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1696/head:pull/1696 PR: https://git.openjdk.org/jdk17u-dev/pull/1696 From stuefe at openjdk.org Wed Aug 30 18:31:50 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 30 Aug 2023 18:31:50 GMT Subject: [jdk17u-dev] RFR: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores Message-ID: <2piQSJ32qyKRj6FFj3fybKx2w_kGAPzpwZ0k12T7jS8=.83529fd9-a9dc-403d-9dd6-3f923e09dffc@github.com> Clean backport to stabilize test after 8312182. ------------- Commit messages: - Backport 733250288325bc663afc0376342d4c5a7a471cbd Changes: https://git.openjdk.org/jdk17u-dev/pull/1698/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1698&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314139 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1698.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1698/head:pull/1698 PR: https://git.openjdk.org/jdk17u-dev/pull/1698 From cjplummer at openjdk.org Wed Aug 30 18:53:37 2023 From: cjplummer at openjdk.org (Chris Plummer) Date: Wed, 30 Aug 2023 18:53:37 GMT Subject: [jdk21u] Integrated: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM In-Reply-To: References: Message-ID: <4e17O8RtR1jDLxrGX9JeSj2HXlx2ziKCFuhqJ8Lupr8=.ff5ea291-a3a0-4c41-ac8a-978fa446e50d@github.com> On Mon, 28 Aug 2023 18:04:34 GMT, Chris Plummer wrote: > Clean merge. Needed to address issue uncovered by [JDK-8294323](https://bugs.openjdk.org/browse/JDK-8294323) This pull request has now been integrated. Changeset: bb1adb1d Author: Chris Plummer URL: https://git.openjdk.org/jdk21u/commit/bb1adb1d3d6d0dc8d95b65c7ce09aaa8ac34a342 Stats: 95 lines in 3 files changed: 94 ins; 0 del; 1 mod 8314679: SA fails to properly attach to JVM after having just detached from a different JVM Backport-of: 38a9edfb7ee2d91ff52074137c5b69e27bcdbdc3 ------------- PR: https://git.openjdk.org/jdk21u/pull/115 From serb at openjdk.org Wed Aug 30 19:24:07 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 30 Aug 2023 19:24:07 GMT Subject: [jdk11u-dev] RFR: 8294281: Allow warnings to be disabled on a per-file basis Message-ID: Hi all, This pull request contains a backport of commit [e45f3d51](https://github.com/openjdk/jdk/commit/e45f3d5176e4affaa08480b560ca983fdbcb2846) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Magnus Ihse Bursie on 23 Sep 2022 and was reviewed by Erik Joelsson. Thanks! ------------- Commit messages: - Backport e45f3d5176e4affaa08480b560ca983fdbcb2846 Changes: https://git.openjdk.org/jdk11u-dev/pull/2109/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2109&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294281 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2109.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2109/head:pull/2109 PR: https://git.openjdk.org/jdk11u-dev/pull/2109 From simonis at openjdk.org Wed Aug 30 19:30:39 2023 From: simonis at openjdk.org (Volker Simonis) Date: Wed, 30 Aug 2023 19:30:39 GMT Subject: [jdk11u] Integrated: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() In-Reply-To: References: Message-ID: <6SSfIKAGlCcbdymbG5ohlChfE2z9F4iezhYVTyi5ucQ=.00a8ab10-f903-4bc5-8a8d-2e5865180e0f@github.com> On Wed, 30 Aug 2023 16:04:59 GMT, Volker Simonis wrote: > Hi all, > > This pull request contains a backport of commit [b77c161e](https://github.com/openjdk/jdk11u-dev/commit/b77c161e7509aa3b09ebf3e6b2b1490c0667bbdc) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Volker Simonis on 30 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe. > > Thanks! This pull request has now been integrated. Changeset: 14fa970e Author: Volker Simonis URL: https://git.openjdk.org/jdk11u/commit/14fa970e610a2202c14ad0c999cf6c215bdc5e52 Stats: 65 lines in 4 files changed: 63 ins; 0 del; 2 mod 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack() Backport-of: b77c161e7509aa3b09ebf3e6b2b1490c0667bbdc ------------- PR: https://git.openjdk.org/jdk11u/pull/79 From phh at openjdk.org Wed Aug 30 21:14:17 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 30 Aug 2023 21:14:17 GMT Subject: [jdk11u-dev] RFR: 8305733: Pattern.CASE_INSENSITIVE does not take effect in jdk11 [v8] In-Reply-To: References: Message-ID: On Mon, 31 Jul 2023 02:16:13 GMT, Korov wrote: >> fix [JDK-8305733](https://bugs.openjdk.org/browse/JDK-8305733) > > Korov has updated the pull request incrementally with one additional commit since the last revision: > > Update RegExTest.java Tagged the JBS issue. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2062#issuecomment-1699845581 From almatvee at openjdk.org Wed Aug 30 21:30:10 2023 From: almatvee at openjdk.org (Alexander Matveev) Date: Wed, 30 Aug 2023 21:30:10 GMT Subject: [jdk21u] Integrated: 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters In-Reply-To: <7Nr7pXGztksF4Uasl-5bV0cVBXCOe4Ge6M2EdLZdBIc=.2f26d704-64e0-4957-ae52-3fef11853831@github.com> References: <7Nr7pXGztksF4Uasl-5bV0cVBXCOe4Ge6M2EdLZdBIc=.2f26d704-64e0-4957-ae52-3fef11853831@github.com> Message-ID: On Wed, 23 Aug 2023 23:31:48 GMT, Alexander Matveev wrote: > Clean backport of JDK-8308042. This pull request has now been integrated. Changeset: d55535d2 Author: Alexander Matveev Committer: Alexander Zuev URL: https://git.openjdk.org/jdk21u/commit/d55535d2e88b2eac19e77ab746da78a506952d73 Stats: 444 lines in 11 files changed: 248 ins; 60 del; 136 mod 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters Backport-of: 57a322da9bf6aac98e834516728fb6da1c18e7aa ------------- PR: https://git.openjdk.org/jdk21u/pull/95 From myano at openjdk.org Wed Aug 30 23:54:12 2023 From: myano at openjdk.org (Masanori Yano) Date: Wed, 30 Aug 2023 23:54:12 GMT Subject: [jdk11u-dev] RFR: 8213536: Update ProblemList for Linux In-Reply-To: References: Message-ID: On Thu, 29 Jun 2023 10:03:08 GMT, Masanori Yano wrote: > I would like to backport JDK-8213536. However, since some backports were done without modifying the ProblemList, they cannot be backported to clean. > > The following tests were backported without exclusions, so ProblemList should not be backported. > > * java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java > https://bugs.openjdk.org/browse/JDK-8144030 > https://github.com/openjdk/jdk11u-dev/pull/1688 > > * java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java > https://bugs.openjdk.org/browse/JDK-8030121 > https://github.com/openjdk/jdk11u-dev/pull/1455 > > * javax/swing/border/TestTitledBorderLeak.java > https://bugs.openjdk.org/browse/JDK-8213531 > https://github.com/openjdk/jdk11u-dev/pull/1817 > > * javax/swing/JTree/8003400/Test8003400.java > https://bugs.openjdk.org/browse/JDK-8197560 > https://github.com/openjdk/jdk11u-dev/pull/374 > > * javax/swing/JPopupMenu/6583251/bug6583251.java > https://bugs.openjdk.org/browse/JDK-8217377 > https://github.com/openjdk/jdk11u-dev/pull/378 > > The following tests only exclude linux because macos exclusion has not yet been backported. > > * javax/swing/GraphicsConfigNotifier/StalePreferredSize.java > https://bugs.openjdk.org/browse/JDK-8213138 > https://github.com/openjdk/jdk/commit/2215c4c893e00321a96de56b322ec682173bfee9 > > The new exclusions are tests of fixes that are still excluded in the mainline repository or are not backported, as shown below. > > * java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java > https://bugs.openjdk.org/browse/JDK-8193543 > https://github.com/openjdk/jdk/pull/8346 > > * javax/swing/text/DefaultCaret/HidingSelection/MultiSelectionTest.java > https://bugs.openjdk.org/browse/JDK-8299077 > https://github.com/openjdk/jdk20/pull/68 No one has reviewed this PR for two months. Is there any bad reason? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2003#issuecomment-1700004287 From serb at openjdk.org Thu Aug 31 04:06:13 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 31 Aug 2023 04:06:13 GMT Subject: [jdk21u] Integrated: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 04:45:57 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [87298d2a](https://github.com/openjdk/jdk/commit/87298d2ade41c689d3140981a123b0e9130fc651) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race. > > Thanks! This pull request has now been integrated. Changeset: 70c05d1b Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u/commit/70c05d1b071cf88b3087b3cea641c7d731d8e8d3 Stats: 66 lines in 3 files changed: 59 ins; 0 del; 7 mod 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException Backport-of: 87298d2ade41c689d3140981a123b0e9130fc651 ------------- PR: https://git.openjdk.org/jdk21u/pull/96 From serb at openjdk.org Thu Aug 31 04:19:17 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 31 Aug 2023 04:19:17 GMT Subject: [jdk17u-dev] Integrated: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 05:06:35 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [87298d2a](https://github.com/openjdk/jdk/commit/87298d2ade41c689d3140981a123b0e9130fc651) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race. > > Thanks! This pull request has now been integrated. Changeset: e0b39c75 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/e0b39c75416493c9a57b456e85a7f03bd9da7f9f Stats: 66 lines in 3 files changed: 59 ins; 0 del; 7 mod 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException Backport-of: 87298d2ade41c689d3140981a123b0e9130fc651 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1689 From serb at openjdk.org Thu Aug 31 04:25:22 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 31 Aug 2023 04:25:22 GMT Subject: [jdk11u-dev] Integrated: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException In-Reply-To: References: Message-ID: On Thu, 24 Aug 2023 05:10:05 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [87298d2a](https://github.com/openjdk/jdk/commit/87298d2ade41c689d3140981a123b0e9130fc651) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race. > > Thanks! This pull request has now been integrated. Changeset: 121c997e Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/121c997e02031a2ce208129feea143fac1e79c4c Stats: 66 lines in 3 files changed: 59 ins; 0 del; 7 mod 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException Backport-of: 87298d2ade41c689d3140981a123b0e9130fc651 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2095 From stuefe at openjdk.org Thu Aug 31 04:50:04 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 04:50:04 GMT Subject: [jdk17u-dev] RFR: 8312620: WSL Linux build crashes after JDK-8310233 [v2] In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 18:29:14 GMT, Thomas Stuefe wrote: >> Clean backport (based on https://github.com/openjdk/jdk17u-dev/pull/1695), fixes an issue where the build on Windows WSL was failing post-8310233. > > Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 25058cd23ac9c8993e7acfd82728ee4c623f0914 Tests clean, Approval given. integrate ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1696#issuecomment-1700361763 From stuefe at openjdk.org Thu Aug 31 04:57:19 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 04:57:19 GMT Subject: [jdk17u-dev] Integrated: 8312620: WSL Linux build crashes after JDK-8310233 In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 11:45:18 GMT, Thomas Stuefe wrote: > Clean backport (based on https://github.com/openjdk/jdk17u-dev/pull/1695), fixes an issue where the build on Windows WSL was failing post-8310233. This pull request has now been integrated. Changeset: 804ce093 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk17u-dev/commit/804ce093a4b7c31e7d14f7e396df46b65fb1a974 Stats: 21 lines in 3 files changed: 14 ins; 0 del; 7 mod 8312620: WSL Linux build crashes after JDK-8310233 Backport-of: 25058cd23ac9c8993e7acfd82728ee4c623f0914 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1696 From stuefe at openjdk.org Thu Aug 31 05:08:38 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 05:08:38 GMT Subject: [jdk17u-dev] RFR: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation Message-ID: Clean backport. 8312182 introduced a mitigation for THP-related RSS bloat; it came with a switch to switch it off. We then decided to rename the switch. Since the switch should be the same across all releases, this needs to be backported too. ------------- Commit messages: - Backport 226cdc696d933fbc174d07b0d9817246dbc0e06c Changes: https://git.openjdk.org/jdk17u-dev/pull/1699/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1699&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312585 Stats: 12 lines in 3 files changed: 2 ins; 2 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1699.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1699/head:pull/1699 PR: https://git.openjdk.org/jdk17u-dev/pull/1699 From stuefe at openjdk.org Thu Aug 31 05:48:15 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 05:48:15 GMT Subject: [jdk11u-dev] RFR: 8213536: Update ProblemList for Linux In-Reply-To: References: Message-ID: On Thu, 29 Jun 2023 10:03:08 GMT, Masanori Yano wrote: > I would like to backport JDK-8213536. However, since some backports were done without modifying the ProblemList, they cannot be backported to clean. > > The following tests were backported without exclusions, so ProblemList should not be backported. > > * java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java > https://bugs.openjdk.org/browse/JDK-8144030 > https://github.com/openjdk/jdk11u-dev/pull/1688 > > * java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java > https://bugs.openjdk.org/browse/JDK-8030121 > https://github.com/openjdk/jdk11u-dev/pull/1455 > > * javax/swing/border/TestTitledBorderLeak.java > https://bugs.openjdk.org/browse/JDK-8213531 > https://github.com/openjdk/jdk11u-dev/pull/1817 > > * javax/swing/JTree/8003400/Test8003400.java > https://bugs.openjdk.org/browse/JDK-8197560 > https://github.com/openjdk/jdk11u-dev/pull/374 > > * javax/swing/JPopupMenu/6583251/bug6583251.java > https://bugs.openjdk.org/browse/JDK-8217377 > https://github.com/openjdk/jdk11u-dev/pull/378 > > The following tests only exclude linux because macos exclusion has not yet been backported. > > * javax/swing/GraphicsConfigNotifier/StalePreferredSize.java > https://bugs.openjdk.org/browse/JDK-8213138 > https://github.com/openjdk/jdk/commit/2215c4c893e00321a96de56b322ec682173bfee9 > > The new exclusions are tests of fixes that are still excluded in the mainline repository or are not backported, as shown below. > > * java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java > https://bugs.openjdk.org/browse/JDK-8193543 > https://github.com/openjdk/jdk/pull/8346 > > * javax/swing/text/DefaultCaret/HidingSelection/MultiSelectionTest.java > https://bugs.openjdk.org/browse/JDK-8299077 > https://github.com/openjdk/jdk20/pull/68 Why do you want to backport this patch? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2003#issuecomment-1700402105 From myano at openjdk.org Thu Aug 31 06:38:04 2023 From: myano at openjdk.org (Masanori Yano) Date: Thu, 31 Aug 2023 06:38:04 GMT Subject: [jdk11u-dev] RFR: 8213536: Update ProblemList for Linux In-Reply-To: References: Message-ID: On Thu, 29 Jun 2023 10:03:08 GMT, Masanori Yano wrote: > I would like to backport JDK-8213536. However, since some backports were done without modifying the ProblemList, they cannot be backported to clean. > > The following tests were backported without exclusions, so ProblemList should not be backported. > > * java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java > https://bugs.openjdk.org/browse/JDK-8144030 > https://github.com/openjdk/jdk11u-dev/pull/1688 > > * java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java > https://bugs.openjdk.org/browse/JDK-8030121 > https://github.com/openjdk/jdk11u-dev/pull/1455 > > * javax/swing/border/TestTitledBorderLeak.java > https://bugs.openjdk.org/browse/JDK-8213531 > https://github.com/openjdk/jdk11u-dev/pull/1817 > > * javax/swing/JTree/8003400/Test8003400.java > https://bugs.openjdk.org/browse/JDK-8197560 > https://github.com/openjdk/jdk11u-dev/pull/374 > > * javax/swing/JPopupMenu/6583251/bug6583251.java > https://bugs.openjdk.org/browse/JDK-8217377 > https://github.com/openjdk/jdk11u-dev/pull/378 > > The following tests only exclude linux because macos exclusion has not yet been backported. > > * javax/swing/GraphicsConfigNotifier/StalePreferredSize.java > https://bugs.openjdk.org/browse/JDK-8213138 > https://github.com/openjdk/jdk/commit/2215c4c893e00321a96de56b322ec682173bfee9 > > The new exclusions are tests of fixes that are still excluded in the mainline repository or are not backported, as shown below. > > * java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java > https://bugs.openjdk.org/browse/JDK-8193543 > https://github.com/openjdk/jdk/pull/8346 > > * javax/swing/text/DefaultCaret/HidingSelection/MultiSelectionTest.java > https://bugs.openjdk.org/browse/JDK-8299077 > https://github.com/openjdk/jdk20/pull/68 The reason I want to backport this patch is because the JDK-8213531 backport pointed out that I did not backport the prerequisite patch. https://github.com/openjdk/jdk11u-dev/pull/1817 I would like to avoid that the ProblemList is not updated correctly by changing the backport order. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2003#issuecomment-1700446289 From stuefe at openjdk.org Thu Aug 31 07:57:16 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 07:57:16 GMT Subject: [jdk11u-dev] RFR: 8213536: Update ProblemList for Linux In-Reply-To: References: Message-ID: <1CRJAvh-MKqEhf89Rb0B7O73YS59adWs0cdYLt2OMec=.c19186e2-ebc8-4bc3-acbf-a5de996f69c3@github.com> On Thu, 29 Jun 2023 10:03:08 GMT, Masanori Yano wrote: > I would like to backport JDK-8213536. However, since some backports were done without modifying the ProblemList, they cannot be backported to clean. > > The following tests were backported without exclusions, so ProblemList should not be backported. > > * java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java > https://bugs.openjdk.org/browse/JDK-8144030 > https://github.com/openjdk/jdk11u-dev/pull/1688 > > * java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java > https://bugs.openjdk.org/browse/JDK-8030121 > https://github.com/openjdk/jdk11u-dev/pull/1455 > > * javax/swing/border/TestTitledBorderLeak.java > https://bugs.openjdk.org/browse/JDK-8213531 > https://github.com/openjdk/jdk11u-dev/pull/1817 > > * javax/swing/JTree/8003400/Test8003400.java > https://bugs.openjdk.org/browse/JDK-8197560 > https://github.com/openjdk/jdk11u-dev/pull/374 > > * javax/swing/JPopupMenu/6583251/bug6583251.java > https://bugs.openjdk.org/browse/JDK-8217377 > https://github.com/openjdk/jdk11u-dev/pull/378 > > The following tests only exclude linux because macos exclusion has not yet been backported. > > * javax/swing/GraphicsConfigNotifier/StalePreferredSize.java > https://bugs.openjdk.org/browse/JDK-8213138 > https://github.com/openjdk/jdk/commit/2215c4c893e00321a96de56b322ec682173bfee9 > > The new exclusions are tests of fixes that are still excluded in the mainline repository or are not backported, as shown below. > > * java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java > https://bugs.openjdk.org/browse/JDK-8193543 > https://github.com/openjdk/jdk/pull/8346 > > * javax/swing/text/DefaultCaret/HidingSelection/MultiSelectionTest.java > https://bugs.openjdk.org/browse/JDK-8299077 > https://github.com/openjdk/jdk20/pull/68 > The reason I want to backport this patch is because the JDK-8213531 backport pointed out that I did not backport the prerequisite patch. #1817 I would like to avoid that the ProblemList is not updated correctly by changing the backport order. Okay, I see. You want to backport it now proactively since the fact that test/jdk/javax/swing/border/TestTitledBorderLeak.java should not be problemlisted is fresh in your head. But it is difficult to understand why these changes to ProblemList should be backported at all. Difficult to verify the correctness since the original issue description does not contain any explanation whatsoever. Are these tests failing in 11u? If yes, do we have issues to track these failures? If not, why should we exclude them? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2003#issuecomment-1700542868 From shade at openjdk.org Thu Aug 31 08:02:09 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 08:02:09 GMT Subject: [jdk21u] RFR: 8314656: GHA: No need for Debian ports keyring installation after JDK-8313701 In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 08:29:35 GMT, Aleksey Shipilev wrote: > Clean backport to maintain clean undiverged GHA between releases. > > Additional testing: > - [x] GHA Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/118#issuecomment-1700550692 From shade at openjdk.org Thu Aug 31 08:05:10 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 08:05:10 GMT Subject: [jdk21u] Integrated: 8314656: GHA: No need for Debian ports keyring installation after JDK-8313701 In-Reply-To: References: Message-ID: <2s3K12UPZ3sWuTEAmjp1IL_K6ZpyVHqTC2F-hSz7XUQ=.da82b08c-15ce-4e34-83cf-68a01bf66b9a@github.com> On Wed, 30 Aug 2023 08:29:35 GMT, Aleksey Shipilev wrote: > Clean backport to maintain clean undiverged GHA between releases. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 5cd6929a Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u/commit/5cd6929a2c8c232a569a12869737a30aaed9b54a Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod 8314656: GHA: No need for Debian ports keyring installation after JDK-8313701 Backport-of: 76b9011c9ecb8c0c713a58d034f281ba70d65d4e ------------- PR: https://git.openjdk.org/jdk21u/pull/118 From clanger at openjdk.org Thu Aug 31 11:25:41 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 31 Aug 2023 11:25:41 GMT Subject: [jdk17u-dev] RFR: 8207166: jdk/jshell/JdiHangingLaunchExecutionControlTest.java - launch timeout Message-ID: <0Df8I6Rs4w8BpDWae2Zlykymt3kSelU2Zj7L_Y607uo=.ffcbe46f-f4e3-4c8a-9d56-98ca4bc2bc10@github.com> Hi all, This pull request contains a backport of [JDK-8207166](https://bugs.openjdk.org/browse/JDK-8207166), commit [02dce24b](https://github.com/openjdk/jdk/commit/02dce24b59ab53f00309a71ee94f45067c880b5c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Daniel D. Daugherty on 7 Sep 2022 and was reviewed by Vicente Romero. We see the timeout problem occasionally in our CI in 17 as well. Thanks! ------------- Commit messages: - Backport 02dce24b59ab53f00309a71ee94f45067c880b5c Changes: https://git.openjdk.org/jdk17u-dev/pull/1713/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1713&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8207166 Stats: 9 lines in 2 files changed: 3 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1713.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1713/head:pull/1713 PR: https://git.openjdk.org/jdk17u-dev/pull/1713 From stuefe at openjdk.org Thu Aug 31 11:53:15 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 11:53:15 GMT Subject: [jdk17u-dev] RFR: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation In-Reply-To: References: Message-ID: <5dlL45aLcbJCQoxOtduvbqaecmDMKPDtOlSzN0LDJnA=.331da4f0-0931-44cf-9f2e-8c1cca5fa3e4@github.com> On Fri, 25 Aug 2023 12:16:22 GMT, Thomas Stuefe wrote: > Clean backport. 8312182 introduced a mitigation for THP-related RSS bloat; it came with a switch to switch it off. We then decided to rename the switch. Since the switch should be the same across all releases, this needs to be backported too. Tests green, push approval given. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1699#issuecomment-1700889735 From stuefe at openjdk.org Thu Aug 31 11:53:16 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 11:53:16 GMT Subject: [jdk17u-dev] Integrated: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 12:16:22 GMT, Thomas Stuefe wrote: > Clean backport. 8312182 introduced a mitigation for THP-related RSS bloat; it came with a switch to switch it off. We then decided to rename the switch. Since the switch should be the same across all releases, this needs to be backported too. This pull request has now been integrated. Changeset: eb639a25 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk17u-dev/commit/eb639a25fd90428e45abad69e3ddb9220a37fc98 Stats: 12 lines in 3 files changed: 2 ins; 2 del; 8 mod 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation Backport-of: 226cdc696d933fbc174d07b0d9817246dbc0e06c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1699 From shade at openjdk.org Thu Aug 31 13:52:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 13:52:35 GMT Subject: [jdk17u-dev] RFR: 8314495: Update to use jtreg 7.3.1 In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 19:25:05 GMT, Aleksey Shipilev wrote: > Atomically brings jtreg 7.3.1 (current at mainline) to 17u. Depending on new jtreg allows to cleanly backport tests from mainline without rewriting them for older jtreg. > > Thankfully, @GoeLin backported all the actual test changes that are needed for this to work. > > The uncleanliness comes mostly from the gtest "version" variable conflicts. Otherwise the whole stack applies cleanly. > > Additional testing: > - [x] GHA > - [x] Linux AArch64 `tier1 tier2 tier3 tier4` I don't really see the point of adding all the relevant "jtreg update" issues to this PR, but I can if anyone has a strong opinion about it. @GoeLin, @RealCLanger? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1712#issuecomment-1701073423 From shade at openjdk.org Thu Aug 31 13:52:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 13:52:35 GMT Subject: [jdk17u-dev] RFR: 8314495: Update to use jtreg 7.3.1 Message-ID: Atomically brings jtreg 7.3.1 (current at mainline) to 17u. Depending on new jtreg allows to cleanly backport tests from mainline without rewriting them for older jtreg. Thankfully, @GoeLin backported all the actual test changes that are needed for this to work. The uncleanliness comes mostly from the gtest "version" variable conflicts. Otherwise the whole stack applies cleanly. Additional testing: - [x] GHA - [x] Linux AArch64 `tier1 tier2 tier3 tier4` ------------- Commit messages: - Unclean backport JDK-8314495: Update to use jtreg 7.3.1 - Unclean backport JDK-8313167: Update to use jtreg 7.3 - Unclean backport JDK-8304896: Update to use jtreg 7.2 - Clean backport JDK-8298178: Update to use jtreg 7.1.1 - Clean backport JDK-8296710: Update to use jtreg 7.1 - Unclean backport JDK-8289798: Update to use jtreg 7 - Unclean backport JDK-8275512: Upgrade required version of jtreg to 6.1 Changes: https://git.openjdk.org/jdk17u-dev/pull/1712/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1712&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314495 Stats: 11 lines in 8 files changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1712.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1712/head:pull/1712 PR: https://git.openjdk.org/jdk17u-dev/pull/1712 From shade at openjdk.org Thu Aug 31 14:06:14 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 14:06:14 GMT Subject: [jdk17u-dev] Integrated: 8286430: make test TEST="gtest:" exits with error when it shouldn't In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 17:39:06 GMT, Aleksey Shipilev wrote: > Clean backport to unblock update to gtest 1.13. > > Additional testing: > - [x] Linux AArch64 `gtest:all` with gtest 1.8.1 (still works) > - [x] Linux AArch64 `gtest:all` with gtest 1.13 (with another PR enabling it, now works) This pull request has now been integrated. Changeset: 7f3f76f7 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/7f3f76f772a8f63e93bb0297fe4a45b14b9c790b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8286430: make test TEST="gtest:" exits with error when it shouldn't Backport-of: 63a1ec6e7c08fc21d5cded734637eeb80147079f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1711 From shade at openjdk.org Thu Aug 31 14:06:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 14:06:13 GMT Subject: [jdk17u-dev] RFR: 8286430: make test TEST="gtest:" exits with error when it shouldn't In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 17:39:06 GMT, Aleksey Shipilev wrote: > Clean backport to unblock update to gtest 1.13. > > Additional testing: > - [x] Linux AArch64 `gtest:all` with gtest 1.8.1 (still works) > - [x] Linux AArch64 `gtest:all` with gtest 1.13 (with another PR enabling it, now works) Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1711#issuecomment-1701102372 From rmarchenko at openjdk.org Thu Aug 31 14:20:32 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 31 Aug 2023 14:20:32 GMT Subject: [jdk17u-dev] RFR: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info Message-ID: Clean backport. Tests in compiler/loopopts are passed. ------------- Commit messages: - Backport ed1ea5fe7c6fad03ca96e7dece2127eab21a608a Changes: https://git.openjdk.org/jdk17u-dev/pull/1714/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1714&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314024 Stats: 83 lines in 3 files changed: 83 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1714.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1714/head:pull/1714 PR: https://git.openjdk.org/jdk17u-dev/pull/1714 From shade at openjdk.org Thu Aug 31 14:43:06 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 14:43:06 GMT Subject: [jdk17u-dev] RFR: 8313626: C2 crash due to unexpected exception control flow In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 11:18:57 GMT, Aleksey Shipilev wrote: > Clean backport to fix C2 issue. > > Additional testing: > - [x] New test fails without the patch, passes with it > - [x] Linux AArch64 `tier1 tier2 tier3` Testing is clean. Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1709#issuecomment-1701181101 From shade at openjdk.org Thu Aug 31 14:46:07 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 14:46:07 GMT Subject: [jdk17u-dev] Integrated: 8313626: C2 crash due to unexpected exception control flow In-Reply-To: References: Message-ID: <8Oi3XKFb6vut-JgG4aXX5ynx1C8hQhUNARTKxN0aywE=.c7ab917e-a9e9-40b1-975e-7703f89df97b@github.com> On Wed, 30 Aug 2023 11:18:57 GMT, Aleksey Shipilev wrote: > Clean backport to fix C2 issue. > > Additional testing: > - [x] New test fails without the patch, passes with it > - [x] Linux AArch64 `tier1 tier2 tier3` This pull request has now been integrated. Changeset: 8d704294 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/8d704294d3d0d813a4665aae776c009e3ece8ae0 Stats: 180 lines in 3 files changed: 180 ins; 0 del; 0 mod 8313626: C2 crash due to unexpected exception control flow Backport-of: f8203cb272e6136b784e5c43a500f6a0bfb19c8b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1709 From stuefe at openjdk.org Thu Aug 31 15:02:44 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 15:02:44 GMT Subject: [jdk17u-dev] RFR: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores [v2] In-Reply-To: <2piQSJ32qyKRj6FFj3fybKx2w_kGAPzpwZ0k12T7jS8=.83529fd9-a9dc-403d-9dd6-3f923e09dffc@github.com> References: <2piQSJ32qyKRj6FFj3fybKx2w_kGAPzpwZ0k12T7jS8=.83529fd9-a9dc-403d-9dd6-3f923e09dffc@github.com> Message-ID: <7KUyiC4Wxmg77r6VnotRr76DbosgDBdu-cAUb7pLeag=.c6e21a6c-d761-458b-bd65-3cea772f6c3d@github.com> > Clean backport to stabilize test after 8312182. Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into tstuefe-backport-73325028 - Backport 733250288325bc663afc0376342d4c5a7a471cbd ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1698/files - new: https://git.openjdk.org/jdk17u-dev/pull/1698/files/cb3d4e33..e81dd5d7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1698&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1698&range=00-01 Stats: 280 lines in 13 files changed: 255 ins; 2 del; 23 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1698.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1698/head:pull/1698 PR: https://git.openjdk.org/jdk17u-dev/pull/1698 From stuefe at openjdk.org Thu Aug 31 15:02:39 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 15:02:39 GMT Subject: [jdk21u] RFR: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation [v5] In-Reply-To: References: Message-ID: > Clean backport. 8312182 introduced a mitigation for THP-related RSS bloat; it came with a switch to switch it off. We then decided to rename the switch. Since the switch should be the same across all releases, this needs to be backported too. Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into tstuefe-backport-226cdc69 - Merge branch 'openjdk:master' into tstuefe-backport-226cdc69 - Backport 226cdc696d933fbc174d07b0d9817246dbc0e06c ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/105/files - new: https://git.openjdk.org/jdk21u/pull/105/files/8ed050e7..f5cf1efd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=105&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=105&range=03-04 Stats: 608 lines in 18 files changed: 401 ins; 62 del; 145 mod Patch: https://git.openjdk.org/jdk21u/pull/105.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/105/head:pull/105 PR: https://git.openjdk.org/jdk21u/pull/105 From shade at openjdk.org Thu Aug 31 15:03:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 15:03:13 GMT Subject: [jdk11u-dev] RFR: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 09:57:32 GMT, Aleksey Shipilev wrote: > Clean backport to further improve 11u GHA reliability. > > Additional testing: > - [x] GHA GHA run is clean. Push approval is granted. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2106#issuecomment-1701215749 From shade at openjdk.org Thu Aug 31 15:04:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 15:04:13 GMT Subject: [jdk11u-dev] RFR: 8299330: Minor improvements in MSYS2 Workflow handling In-Reply-To: <_gm9dIdBG2C_f0-kM3GzMYuB52cXQ31za8jy68dmIuE=.b9d1465e-9677-4c58-813c-bd69a33c9266@github.com> References: <_gm9dIdBG2C_f0-kM3GzMYuB52cXQ31za8jy68dmIuE=.b9d1465e-9677-4c58-813c-bd69a33c9266@github.com> Message-ID: On Wed, 30 Aug 2023 09:49:22 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA reliability. > > Additional testing: > - [x] GHA GHA run is clean. Push approval is granted. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2103#issuecomment-1701216735 From shade at openjdk.org Thu Aug 31 15:06:20 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 15:06:20 GMT Subject: [jdk11u-dev] RFR: 8294941: GHA: Cut down cross-compilation sysroots In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 09:55:21 GMT, Aleksey Shipilev wrote: > Clean backport to improve 11u GHA overheads. It would be followed by another backport that would cut stuff even deeper: [JDK-8314262](https://bugs.openjdk.org/browse/JDK-8314262). > > Additional testing: > - [x] GHA GHA runs are clean. Push approval is granted. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2105#issuecomment-1701216141 From shade at openjdk.org Thu Aug 31 15:06:20 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 15:06:20 GMT Subject: [jdk11u-dev] Integrated: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 09:57:32 GMT, Aleksey Shipilev wrote: > Clean backport to further improve 11u GHA reliability. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 373be434 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/373be4349c03f841e62a76120aeafd9631b2e765 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8294956: GHA: qemu-debootstrap is deprecated, use the regular one Backport-of: c5f462e83b85ec53ec395622063a5b131aaf0827 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2106 From shade at openjdk.org Thu Aug 31 15:06:21 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 15:06:21 GMT Subject: [jdk11u-dev] Integrated: 8294941: GHA: Cut down cross-compilation sysroots In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 09:55:21 GMT, Aleksey Shipilev wrote: > Clean backport to improve 11u GHA overheads. It would be followed by another backport that would cut stuff even deeper: [JDK-8314262](https://bugs.openjdk.org/browse/JDK-8314262). > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: f5eb11f3 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/f5eb11f381d4812c489dc2b206e88b34201300f8 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8294941: GHA: Cut down cross-compilation sysroots Backport-of: a1747ef81a10e84177f474565193204ceaa0ede8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2105 From shade at openjdk.org Thu Aug 31 15:07:09 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 15:07:09 GMT Subject: [jdk11u-dev] Integrated: 8299330: Minor improvements in MSYS2 Workflow handling In-Reply-To: <_gm9dIdBG2C_f0-kM3GzMYuB52cXQ31za8jy68dmIuE=.b9d1465e-9677-4c58-813c-bd69a33c9266@github.com> References: <_gm9dIdBG2C_f0-kM3GzMYuB52cXQ31za8jy68dmIuE=.b9d1465e-9677-4c58-813c-bd69a33c9266@github.com> Message-ID: On Wed, 30 Aug 2023 09:49:22 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA reliability. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 4cd3ad9c Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/4cd3ad9c7177231bc4d981d28e155621e42f72ff Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod 8299330: Minor improvements in MSYS2 Workflow handling Backport-of: cf00d09c8c37ee301e1c6657df45777647a834e9 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2103 From stuefe at openjdk.org Thu Aug 31 15:08:16 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 15:08:16 GMT Subject: [jdk21u] RFR: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation [v5] In-Reply-To: References: Message-ID: On Thu, 31 Aug 2023 15:02:39 GMT, Thomas Stuefe wrote: >> Clean backport. 8312182 introduced a mitigation for THP-related RSS bloat; it came with a switch to switch it off. We then decided to rename the switch. Since the switch should be the same across all releases, this needs to be backported too. > > Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into tstuefe-backport-226cdc69 > - Merge branch 'openjdk:master' into tstuefe-backport-226cdc69 > - Backport 226cdc696d933fbc174d07b0d9817246dbc0e06c Got approval. Last tests before the merge had been green. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/105#issuecomment-1701224682 From stuefe at openjdk.org Thu Aug 31 15:08:23 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 15:08:23 GMT Subject: [jdk17u-dev] RFR: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores [v2] In-Reply-To: <7KUyiC4Wxmg77r6VnotRr76DbosgDBdu-cAUb7pLeag=.c6e21a6c-d761-458b-bd65-3cea772f6c3d@github.com> References: <2piQSJ32qyKRj6FFj3fybKx2w_kGAPzpwZ0k12T7jS8=.83529fd9-a9dc-403d-9dd6-3f923e09dffc@github.com> <7KUyiC4Wxmg77r6VnotRr76DbosgDBdu-cAUb7pLeag=.c6e21a6c-d761-458b-bd65-3cea772f6c3d@github.com> Message-ID: On Thu, 31 Aug 2023 15:02:44 GMT, Thomas Stuefe wrote: >> Clean backport to stabilize test after 8312182. > > Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into tstuefe-backport-73325028 > - Backport 733250288325bc663afc0376342d4c5a7a471cbd Got approval. Last tests had been successful. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1698#issuecomment-1701221151 From stuefe at openjdk.org Thu Aug 31 15:08:24 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 15:08:24 GMT Subject: [jdk17u-dev] Integrated: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores In-Reply-To: <2piQSJ32qyKRj6FFj3fybKx2w_kGAPzpwZ0k12T7jS8=.83529fd9-a9dc-403d-9dd6-3f923e09dffc@github.com> References: <2piQSJ32qyKRj6FFj3fybKx2w_kGAPzpwZ0k12T7jS8=.83529fd9-a9dc-403d-9dd6-3f923e09dffc@github.com> Message-ID: On Fri, 25 Aug 2023 12:09:44 GMT, Thomas Stuefe wrote: > Clean backport to stabilize test after 8312182. This pull request has now been integrated. Changeset: f85df30c Author: Thomas Stuefe URL: https://git.openjdk.org/jdk17u-dev/commit/f85df30c92401376b060d769a5fb08844bbac3d4 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores Backport-of: 733250288325bc663afc0376342d4c5a7a471cbd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1698 From stuefe at openjdk.org Thu Aug 31 15:08:17 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 31 Aug 2023 15:08:17 GMT Subject: [jdk21u] Integrated: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation In-Reply-To: References: Message-ID: On Fri, 25 Aug 2023 12:54:28 GMT, Thomas Stuefe wrote: > Clean backport. 8312182 introduced a mitigation for THP-related RSS bloat; it came with a switch to switch it off. We then decided to rename the switch. Since the switch should be the same across all releases, this needs to be backported too. This pull request has now been integrated. Changeset: 5589b9ec Author: Thomas Stuefe URL: https://git.openjdk.org/jdk21u/commit/5589b9ec51f0fbf8e3434828cbffd4488c6b9261 Stats: 12 lines in 3 files changed: 2 ins; 2 del; 8 mod 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation Backport-of: 226cdc696d933fbc174d07b0d9817246dbc0e06c ------------- PR: https://git.openjdk.org/jdk21u/pull/105 From shade at openjdk.org Thu Aug 31 15:15:37 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 15:15:37 GMT Subject: [jdk11u-dev] RFR: 8314262: GHA: Cut down cross-compilation sysroots deeper Message-ID: Clean backport to improve GHA infrastructure costs even further. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 38687f1a3eb7d1c2e8aa43b85509ab7999fe0e40 Changes: https://git.openjdk.org/jdk11u-dev/pull/2110/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2110&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314262 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2110.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2110/head:pull/2110 PR: https://git.openjdk.org/jdk11u-dev/pull/2110 From clanger at openjdk.org Thu Aug 31 15:24:17 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 31 Aug 2023 15:24:17 GMT Subject: [jdk11u-dev] RFR: 8305733: Pattern.CASE_INSENSITIVE does not take effect in jdk11 [v8] In-Reply-To: References: Message-ID: <75KTCtBNgk_yqHW5_M2DcVEIrh4RD7RwKwPztU7QmnE=.2cc877f7-968d-49ce-a7bc-cdc28693ded3@github.com> On Mon, 31 Jul 2023 02:16:13 GMT, Korov wrote: >> fix [JDK-8305733](https://bugs.openjdk.org/browse/JDK-8305733) > > Korov has updated the pull request incrementally with one additional commit since the last revision: > > Update RegExTest.java I don't get this. What is the difference of this change to a full backport of [JDK-8214245](https://bugs.openjdk.org/browse/JDK-8214245)? If there's no difference, this should be a backport of JDK-8214245. And then we'd also need to file a CSR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2062#issuecomment-1701251331 From serb at openjdk.org Thu Aug 31 16:35:14 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 31 Aug 2023 16:35:14 GMT Subject: [jdk11u-dev] Integrated: 8294281: Allow warnings to be disabled on a per-file basis In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 19:09:48 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [e45f3d51](https://github.com/openjdk/jdk/commit/e45f3d5176e4affaa08480b560ca983fdbcb2846) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Magnus Ihse Bursie on 23 Sep 2022 and was reviewed by Erik Joelsson. > > Thanks! This pull request has now been integrated. Changeset: caa05aca Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/caa05aca911798eb9a0e71f18bbb2e56cc2f0fd1 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod 8294281: Allow warnings to be disabled on a per-file basis Backport-of: e45f3d5176e4affaa08480b560ca983fdbcb2846 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2109 From serb at openjdk.org Thu Aug 31 17:02:27 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 31 Aug 2023 17:02:27 GMT Subject: [jdk11u-dev] RFR: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0 In-Reply-To: References: Message-ID: <6mm9TaoAepclU08ZPiuV0hZZjVy_RHjohgbgcdt6_Tk=.839c0b95-065e-4a08-a9a4-8458c311ec5c@github.com> On Wed, 30 Aug 2023 18:08:48 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 2 Aug 2023 and was reviewed by Aleksey Shipilev and Phil Race. > > Thanks! Tested with "--with-freetype=bundled", "--with-freetype=system" and w/o option. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2108#issuecomment-1699634110 From serb at openjdk.org Thu Aug 31 17:02:27 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 31 Aug 2023 17:02:27 GMT Subject: [jdk11u-dev] RFR: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0 Message-ID: Hi all, This pull request contains a backport of commit [8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 2 Aug 2023 and was reviewed by Aleksey Shipilev and Phil Race. Thanks! ------------- Commit messages: - Merge branch 'openjdk:master' into JDK-8313576 - Backport 8248e351d0bed263fb68d8468004a4286e6391af Changes: https://git.openjdk.org/jdk11u-dev/pull/2108/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2108&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313576 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2108.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2108/head:pull/2108 PR: https://git.openjdk.org/jdk11u-dev/pull/2108 From shade at openjdk.org Thu Aug 31 17:32:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 31 Aug 2023 17:32:35 GMT Subject: [jdk11u-dev] RFR: 8315480: [11u] Harmonize GHA cross-compilation block with mainline Message-ID: Parts of this block were rewritten with RISC-V GHA integration ([JDK-8283929](https://bugs.openjdk.org/browse/JDK-8283929)). Since we don't expect RISC-V to integrate any time soon, we could just roll in the rewrite without RISC-V parts to 11u, and this minimize the difference to mainline. This would allow other clean backports. Additional testing: - [ ] GHA (cross-compilation still works) ------------- Commit messages: - Fix Changes: https://git.openjdk.org/jdk11u-dev/pull/2111/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2111&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315480 Stats: 18 lines in 1 file changed: 12 ins; 4 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2111.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2111/head:pull/2111 PR: https://git.openjdk.org/jdk11u-dev/pull/2111 From mchung at openjdk.org Thu Aug 31 17:39:09 2023 From: mchung at openjdk.org (Mandy Chung) Date: Thu, 31 Aug 2023 17:39:09 GMT Subject: [jdk21u] RFR: 8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder In-Reply-To: References: Message-ID: On Wed, 16 Aug 2023 18:26:57 GMT, Mandy Chung wrote: > Hi all, > > This pull request contains a backport of commit [bc8e9f44](https://github.com/openjdk/jdk/commit/bc8e9f44a39ff59b59b2d1d5d546a148be75a2f2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christoph Schwentker on 15 Aug 2023 and was reviewed by Mandy Chung. > > This is an additional test added for https://github.com/openjdk/jdk21u/pull/65. > > Thanks! @phohensee you reviewed #65. This is a new test going with the fix. Do you mind reviewing this PR as well? ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/66#issuecomment-1701477710 From mdoerr at openjdk.org Thu Aug 31 17:46:11 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 31 Aug 2023 17:46:11 GMT Subject: [jdk17u-dev] RFR: 8314495: Update to use jtreg 7.3.1 In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 19:25:05 GMT, Aleksey Shipilev wrote: > Atomically brings jtreg 7.3.1 (current at mainline) to 17u. Depending on new jtreg allows to cleanly backport tests from mainline without rewriting them for older jtreg. > > Thankfully, @GoeLin backported all the actual test changes that are needed for this to work. > > The uncleanliness comes mostly from the gtest "version" variable conflicts. Otherwise the whole stack applies cleanly. > > Additional testing: > - [x] GHA > - [x] Linux AArch64 `tier1 tier2 tier3 tier4` This makes sense! ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1712#pullrequestreview-1605328676 From mdoerr at openjdk.org Thu Aug 31 19:06:42 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 31 Aug 2023 19:06:42 GMT Subject: [jdk17u-dev] RFR: 8314960: Add Certigna Root CA - 2 Message-ID: Backport of [JDK-8314960](https://bugs.openjdk.org/browse/JDK-8314960). Applies cleanly except: - I had to move the certificate due to [JDK-8257733](https://bugs.openjdk.java.net/browse/JDK-8257733). - Hunks in VerifyCACerts.java very easy to resolve. I had to compute and insert the new checksum. ------------- Commit messages: - Backport e9ba8d5a0e74c7e61f963b9a295662899d0156dd Changes: https://git.openjdk.org/jdk17u-dev/pull/1715/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1715&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314960 Stats: 568 lines in 4 files changed: 338 ins; 227 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1715.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1715/head:pull/1715 PR: https://git.openjdk.org/jdk17u-dev/pull/1715 From mdoerr at openjdk.org Thu Aug 31 19:22:23 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 31 Aug 2023 19:22:23 GMT Subject: [jdk21u] RFR: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge Message-ID: Clean backport of [JDK-8299658](https://bugs.openjdk.org/browse/JDK-8299658). ------------- Commit messages: - Backport cf2d33ca2ee08c61596ab10b7602500a6931fa31 Changes: https://git.openjdk.org/jdk21u/pull/119/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=119&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299658 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/119.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/119/head:pull/119 PR: https://git.openjdk.org/jdk21u/pull/119 From mdoerr at openjdk.org Thu Aug 31 19:28:27 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 31 Aug 2023 19:28:27 GMT Subject: [jdk17u-dev] RFR: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge Message-ID: <4XCKEz7_QemBE8pthEcBIEW6ZCtIG9-c11CEnUy43Bs=.784b48a0-6fc3-4385-89e4-413c52379daa@github.com> Clean backport of [JDK-8299658](https://bugs.openjdk.org/browse/JDK-8299658). ------------- Commit messages: - Backport cf2d33ca2ee08c61596ab10b7602500a6931fa31 Changes: https://git.openjdk.org/jdk17u-dev/pull/1716/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1716&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299658 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1716.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1716/head:pull/1716 PR: https://git.openjdk.org/jdk17u-dev/pull/1716 From mdoerr at openjdk.org Thu Aug 31 19:39:13 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 31 Aug 2023 19:39:13 GMT Subject: [jdk17u-dev] RFR: 8314960: Add Certigna Root CA - 2 In-Reply-To: References: Message-ID: On Thu, 31 Aug 2023 18:58:27 GMT, Martin Doerr wrote: > Backport of [JDK-8314960](https://bugs.openjdk.org/browse/JDK-8314960). > Applies cleanly except: > > - I had to move the certificate due to [JDK-8257733](https://bugs.openjdk.java.net/browse/JDK-8257733). > - Hunks in VerifyCACerts.java are easy to resolve. I had to compute and insert the new CHECKSUM. Too late. Please review https://github.com/openjdk/jdk17u/pull/377 instead. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1715#issuecomment-1701674812 From mdoerr at openjdk.org Thu Aug 31 19:43:33 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 31 Aug 2023 19:43:33 GMT Subject: [jdk17u] RFR: 8314960: Add Certigna Root CA - 2 Message-ID: Backport of [JDK-8314960](https://bugs.openjdk.org/browse/JDK-8314960). Applies cleanly except: - I had to move the certificate due to [JDK-8257733](https://bugs.openjdk.java.net/browse/JDK-8257733). - Hunks in VerifyCACerts.java are easy to resolve. I had to compute and insert the new CHECKSUM. ------------- Commit messages: - Backport e9ba8d5a0e74c7e61f963b9a295662899d0156dd Changes: https://git.openjdk.org/jdk17u/pull/377/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=377&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314960 Stats: 568 lines in 4 files changed: 338 ins; 227 del; 3 mod Patch: https://git.openjdk.org/jdk17u/pull/377.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/377/head:pull/377 PR: https://git.openjdk.org/jdk17u/pull/377 From clanger at openjdk.org Thu Aug 31 20:20:07 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 31 Aug 2023 20:20:07 GMT Subject: [jdk17u-dev] RFR: 8314495: Update to use jtreg 7.3.1 In-Reply-To: References: Message-ID: On Wed, 30 Aug 2023 19:25:05 GMT, Aleksey Shipilev wrote: > Atomically brings jtreg 7.3.1 (current at mainline) to 17u. Depending on new jtreg allows to cleanly backport tests from mainline without rewriting them for older jtreg. > > Thankfully, @GoeLin backported all the actual test changes that are needed for this to work. > > The uncleanliness comes mostly from the gtest "version" variable conflicts. Otherwise the whole stack applies cleanly. > > Additional testing: > - [x] GHA > - [x] Linux AArch64 `tier1 tier2 tier3 tier4` Marked as reviewed by clanger (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1712#pullrequestreview-1605643599 From clanger at openjdk.org Thu Aug 31 20:20:08 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 31 Aug 2023 20:20:08 GMT Subject: [jdk17u-dev] RFR: 8314495: Update to use jtreg 7.3.1 In-Reply-To: References: Message-ID: On Thu, 31 Aug 2023 13:47:49 GMT, Aleksey Shipilev wrote: > I don't really see the point of adding all the relevant "jtreg update" issues to this PR, but I can if anyone has a strong opinion about it. @GoeLin, @RealCLanger? No strong opinion, it's fine. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1712#issuecomment-1701722847