[jdk21u] RFR: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere [v2]

Tobias Hartmann thartmann at openjdk.org
Wed Aug 2 06:42:22 UTC 2023


> Parsing of `-XX:CompileOnly=` hits a `ShouldNotReachHere` for `,` and ` ` arguments. The fix is to remove the assumption that `className` can only be null for `method_sep` because the parsing loop also exits on `,` and ` `:
> 
> https://github.com/openjdk/jdk21u/blob/384a8b85a7266b920242ea73baf578577ca588ec/src/hotspot/share/compiler/compilerOracle.cpp#L1032-L1037
> 
> Instead, a missing class name is handled as "Any" class match in all the cases.
> 
> I'm fixing this in JDK 21u because the issue was fixed in in JDK 22 as a side effect of [JDK-8027711](https://bugs.openjdk.org/browse/JDK-8027711). The VM now prints an error:
> 
> 
> CompileOnly: An error occurred during parsing
> Line: ','
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> 
> 
> Thanks,
> Tobias

Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:

  Change NULL to nullptr

-------------

Changes:
  - all: https://git.openjdk.org/jdk21u/pull/19/files
  - new: https://git.openjdk.org/jdk21u/pull/19/files/51e2ed8e..0bfc5ce1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=19&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=19&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk21u/pull/19.diff
  Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/19/head:pull/19

PR: https://git.openjdk.org/jdk21u/pull/19


More information about the jdk-updates-dev mailing list