[jdk21u] RFR: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere [v2]

Tobias Holenstein tholenstein at openjdk.org
Wed Aug 2 06:42:27 UTC 2023


On Wed, 2 Aug 2023 06:30:44 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change NULL to nullptr
>
> src/hotspot/share/compiler/compilerOracle.cpp line 1053:
> 
>> 1051:     }
>> 1052: 
>> 1053:     if (className == NULL || className[0] == '\0') {
> 
> Suggestion:
> 
>     if (className == nullptr || className[0] == '\0') {

I think it should be `nullptr`

-------------

PR Review Comment: https://git.openjdk.org/jdk21u/pull/19#discussion_r1281454912


More information about the jdk-updates-dev mailing list