[jdk17u-dev] RFR: 8292989: Avoid dynamic memory in AsyncLogWriter

Xin Liu xliu at openjdk.org
Fri Aug 4 19:13:35 UTC 2023


On Fri, 4 Aug 2023 19:04:22 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> src/hotspot/share/logging/logAsyncWriter.hpp line 63:
>> 
>>> 61:   using AsyncLogMap = ResourceHashtable<LogFileStreamOutput*, uint32_t, primitive_hash<LogFileStreamOutput*>,
>>> 62:                                         primitive_equals<LogFileStreamOutput*>, 17,
>>> 63:                                         ResourceObj::C_HEAP, mtLogging>;
>> 
>> These arguments should be on the new lines each, I think? This would match the upstream code better.
>
> hi, @shipilev 
> Do we have linter rules for this?

even in tip of jdk, I still can find code like this: 
https://github.com/openjdk/jdk/blob/master/src/hotspot/share/classfile/classLoaderStats.hpp#L114

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1630#discussion_r1284758431


More information about the jdk-updates-dev mailing list