[jdk17u-dev] RFR: 8273092: Sort classlist in JDK image : regarding CDS archives

[Andrew Leonard]

Thank you Severin, Goetz,

Yes agree. The intention is to at least make jdk17u tar ball reproducible
with the exception of the CDS itself, which will remain for the stated
reasons.

Could I request your review of the PR please?
https://github.com/openjdk/jdk17u-dev/pull/1632

Many thanks
Andrew


On Mon, Aug 7, 2023 at 3:07 PM Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
wrote:

> Hi,
>
>
>
> I agree to what Severin says, this one seems acceptable.
>
>
>
> But I think the list mentioned by Ioi is definitely not a candidate for 17.
>
>
>
> Best regards,
>
>   Goetz
>
>
>
> *From:* jdk-updates-dev <jdk-updates-dev-retn at openjdk.org> *On Behalf Of *Andrew
> Leonard
> *Sent:* Freitag, 4. August 2023 11:39
> *To:* jdk-updates-dev at openjdk.org
> *Subject:* [jdk17u-dev] RFR: 8273092: Sort classlist in JDK image :
> regarding CDS archives
>
>
>
> Hi,
>
> I am currently backporting the fix to sort the classlist file, for a
> deterministic output: https://github.com/openjdk/jdk17u-dev/pull/1632
>
> and as Ioi Lam pointed out CDS archives in jdk17u are non-deterministic
> without various jdk-21+ fixes (
> https://bugs.openjdk.org/browse/JDK-8245335?jql=labels%20%3D%20reproducible-build%20AND%20labels%20%3D%20cds%20ORDER%20BY%20fixVersion%20ASC),
> which are unlikely to be backported as jdk17u CDS is quite different to 21+
> now.
>
>
>
> However, it would still be useful to at least have the classlist
> deterministic, to achieve a JDK tarball that is reproducible bar the CDS
> archives. There is an argument that CDS archives could be produced at a
> different point in time from the build tarball, for example maybe via the
> installer at user install time.
>
>
>
> Thoughts please? on whether it is useful to merge this classlist sorting,
> regardless of the CDS archive issue?
>
>
>
> Thanks
>
> Andrew
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20230807/e5ea8fa3/attachment-0001.htm>